[Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sun Jul 25 01:25:13 CEST 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122354|0                           |1
        is obsolete|                            |

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 123168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123168&action=edit
Bug 28565: Refactor tests

Tests were too complex with no gain. They even deleted the whole DB to
run (inside a transaction). I refactored to test the same thing, and
make it rely (mostly) on existing data.

_count behavior is tested implicitly by comparing with Koha::*->count.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/UsageStats.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests still pass
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list