[Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #50 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Kyle,

1) For the From address, please use the $library->inbound_email_address
routine:

+        my $email =
+             C4::Context->preference('ExpireReservesAutoFillEmail')
+          || $library->{branchemail}
+          || C4::Context->preference('KohaAdminEmailAddress');

It will take the Reply-To addresses into account and make the behaviour match
with other notices sent to the library.

2) Duplicated code

It looks like the code for sending the HOLD_CHANGED email is duplicated in sub
_koha_notify_reserve and _koha_notify_hold_changed multiple times?

(also reserve should always be hold)

3) Improve sample email

I believe the copynumber is not helpful, we should include the itemcallnumber
instead.

Please fix capitalization "Canceled Hold Available for Different Patron".

4) Pref descriptions

Please link ExpireReservesAutoFillEmail :)

Please adjust description for the change in 1).

"Send email notification of the new hold filled with a canceled item to"

Does canceled item work here? Maybe "hold filled with an expired hold item"
instead?

5) Sample notices missing

You've only added the new notice to nb-NO, but we need it in various other
files as well. See xt/sample_notices.t. It gives a bit confusing advice right
now as it thinks the notice has to be deleted, but it has to be added to
installer/data/mysql/en/mandatory/sample_notices.yml first and then the test
can be rerun.

-- 
You are receiving this mail because:
You are watching all bug changes.