[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

--- Comment #175 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Martin Renvoize from comment #169)
> RM comments addressed in followups.
> 
> I also took the opportunity to add the Koha::TrackedLink(s) classes and use
> those Koha::Object(s) based accessors to clarify some of the code found
> within move_to_biblio.  With this change, the odd call to update_all has
> been replaced with our Koha::Objects based automatic trigger handling update
> call (without passing no_triggers yet).  The other DBIC resultset acting
> call is against a single row so update is correct.. I believe.

To clarify, I was not asking to add new classes. I was wondering if the
inconsistency (update vs update_all) in those two calls was expected:

1257     my $hold_fill_target = $self->_result->hold_fill_target;
1258     if ($hold_fill_target) {
1259         $hold_fill_target->update({ biblionumber => $to_biblionumber });
1260     }


1260     my $linktrackers = $schema->resultset('Linktracker')->search({
itemnumber => $self->itemnumber });
1261     $linktrackers->update_all({ biblionumber => $to_biblionumber });

both are DBIx::Class::ResultSet

-- 
You are receiving this mail because:
You are watching all bug changes.