[Koha-bugs] [Bug 27944] Add new stages to the article request process

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

--- Comment #42 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Tomas asked me to look at the following QA errors:

Prototype mismatch: sub Koha::ArticleRequest::Status::Completed: none vs () at
/usr/share/perl/5.28/constant.pm line 171.                                      
Prototype mismatch: sub Koha::ArticleRequest::Status::Processing: none vs () at
/usr/share/perl/5.28/constant.pm line 171.                                      
Prototype mismatch: sub Koha::ArticleRequest::Status::Pending: none vs () at
/usr/share/perl/5.28/constant.pm line 171.                                      
Prototype mismatch: sub Koha::ArticleRequest::Status::Canceled: none vs () at
/usr/share/perl/5.28/constant.pm line 171. 

I'd say we can ignore them.

What's happening (from what I understand):
The module are reloaded when the git branch is checked out:

1. "use Koha::ArticleRequest::Status" is done on master
2. processing tests before patches
3. Checkout the branch with the patches
4. reload the modules
5. processing tests after patches

The error appears during 3.
https://gitlab.com/koha-community/qa-test-tools/-/blob/bca1e51151665ba4965b219a5f48cdac3affa6e5/koha-qa.pl#L102

            eval "require $module";
            $module->import;

Requested (and friends) went from sub to constant and so Perl is warning us.
Does that make sense?

(related with bug 17600 comment 109 and following)

-- 
You are receiving this mail because:
You are watching all bug changes.