[Koha-bugs] [Bug 17600] Standardize the EXPORT

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

--- Comment #119 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #114)
> (In reply to Katrin Fischer from comment #108)
> > Just wondering about the implications of this as I did some easy rebases
> > today. Should we ask for new use statements always having the methods used
> > added with qw? Should there be a coding guideline/QA test?
> 
> I've tried to explain in the commit message.
> Basically you need to
> 1. Use EXPORT_OK instead of EXPORT in modules
> 2. either
>   use Module qw( method_1 method_2 );
>   method_1();
>   
> or 
>   use Module;
>   Module::method_1();
> 

Probably you still need to differentiate between Koha modules and external CPAN
stuff?
The use Module statement does still try to import names. If you do 'use Module
()' with empty list, you do NOT import anymore. Actually, you only 'require'.

-- 
You are receiving this mail because:
You are watching all bug changes.