From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 03:23:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 01:23:19 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #26 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121521&action=edit Bug 27741: serials folder Bug 27631 corrected the

tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

are in the correct order and hierarchy Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 03:50:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 01:50:53 +0000 Subject: [Koha-bugs] [Bug 28420] Allow login via AzureAD OpenID-Connect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28420 --- Comment #13 from David Cook --- Thanks for posting this, Mark. I have a few comments at a glance. As a contributor, you don't make changes to updatedatabase.pl or $Koha::VERSION directly. The release manager takes care of those. You need to create your database update as per https://wiki.koha-community.org/wiki/Database_updates. I'll put in some comments against opac/svc/auth/azureadopenidconnect using Bugzilla's tools. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 03:58:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 01:58:02 +0000 Subject: [Koha-bugs] [Bug 28420] Allow login via AzureAD OpenID-Connect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28420 --- Comment #14 from David Cook --- Comment on attachment 121514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121514 AzureAD OAuth2 implementation based on the existing implementation for Google Review of attachment 121514: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=28420&attachment=121514) ----------------------------------------------------------------- Technically, a lot of this code should be put into a module rather than a script, but I know that you were basing your work on Nicholas's and his made it into Koha, so I don't think we can require you to put it into a module with unit tests. ::: opac/svc/auth/azureadopenidconnect @@ +48,5 @@ > + > +my $tenantID = C4::Context->preference('AzureADOAuth2TenantID'); > +my $authority= "https://login.microsoftonline.com/${tenantID}/v2.0"; > +my $discoveryDocURL = "${authority}/.well-known/openid-configuration"; > +warn $discoveryDocURL; This debugging code needs to be removed. @@ +253,5 @@ > + my $prompt = $query->param('reauthenticate') // q{}; > + if ( $authendpoint eq q{} ) { > + loginfailed( $query, 'Unable to discover authorisation endpoint.' ); > + } > + my $authorisationurl = This isn't a blocker, but I'd suggest using the URI Perl module for creating this URL. I find it a lot nicer to work with than trying to concatenate together a big URL string. https://metacpan.org/pod/URI -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 03:59:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 01:59:28 +0000 Subject: [Koha-bugs] [Bug 28420] Allow login via AzureAD OpenID-Connect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28420 --- Comment #15 from David Cook --- When you're ready for others to test your code, provide a test plan that they can use for testing it, and change the status to "Needs Signoff". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 04:05:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 02:05:39 +0000 Subject: [Koha-bugs] [Bug 28420] Allow login via AzureAD OpenID-Connect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28420 --- Comment #16 from David Cook --- Actually, after reviewing the code again, I'm not sure that this has to be Azure-specific. The only thing I notice at a glance that is Azure specific is the $tenantID and $authority variables. I'd like to see this made more generic, so that users can provide their own $discoveryDocURL via a system preference. With the system preference, you could provide a hint like "For AzureAD, use https://login.microsoftonline.com//v2.0/.well-known/openid-configuration". If you make this more generic, I'd be happy to test it against Keycloak. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 04:12:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 02:12:46 +0000 Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 --- Comment #43 from David Cook --- (In reply to Katrin Fischer from comment #42) > But... from our own experience: especially the self reg ones are quite > dangerous. If you put a 'wrong' patron category type into the pref, it will > delete a big chunk of your users without batting an eye (and they are > delete-deleted, not moved). I think the "Delete unverified self registrations older than DAYS" should be safe either way? But "Delete expired self registration accounts" does sound dangerous as you describe. Personally, I don't see the merit of having that in cleanup_database.pl at all. Even with a sysadmin adding that flag, you can't control the behaviour of library staff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 05:18:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 03:18:24 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #331 from David Cook --- Comment on attachment 120645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120645 Bug 15516: Allow to reserve first available item from a group of titles Review of attachment 120645: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15516&attachment=120645) ----------------------------------------------------------------- ::: reserve/hold-group.pl @@ +1,1 @@ > +#!/usr/bin/env perl This has the wrong shebang. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 06:45:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 04:45:24 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #42 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121522&action=edit Bug 27631: (follow-up) reports/guided_reports_start.tt Changed file to have one

tag showing that describes the page, rather than the

around the logo. The hierarchy of other heading tags may be wrong, but this wil be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to reports/guided_reports_start and check that it has an obvious and descriptive heading 4) Ensure that the heading is

Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 07:19:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 05:19:10 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #332 from David Cook --- I thought that I'd run the QA tools again, as I just noticed that there is a follow-up for the QA tools. My test plan: 0a. Apply the patch 0b. perl ./installer/data/mysql/updatedatabase.pl 0c. qa testing 8 commit(s) (applied to 949f0aa '68 Koha 21.05.00 is here!') Processing files before patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 331. |========================>| 27 / 27 (100.00%) Processing files after patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 331. |========================>| 27 / 27 (100.00%) OK C4/Reserves.pm OK Koha/Hold.pm OK Koha/HoldGroup.pm OK Koha/HoldGroups.pm OK Koha/Holds.pm FAIL Koha/Schema/Result/HoldGroup.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK Koha/Schema/Result/OldReserve.pm OK Koha/Schema/Result/Reserve.pm OK circ/view_holdsqueue.pl OK installer/data/mysql/kohastructure.sql OK koha-tmpl/intranet-tmpl/prog/en/includes/hold-group-modal.inc OK koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/reserve/hold-group.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt OK koha-tmpl/intranet-tmpl/prog/js/hold-group.js OK koha-tmpl/intranet-tmpl/prog/js/holds.js OK opac/opac-reserve.pl OK reserve/hold-group.pl OK reserve/placerequest.pl OK reserve/request.pl OK svc/holds OK t/db_dependent/Koha/Holds.t OK t/db_dependent/Reserves/HoldGroup.t Processing additional checks OK! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 07:22:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 05:22:43 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #333 from David Cook --- Created attachment 121523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121523&action=edit Bug 15516: Fix shebang in hold-group.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 07:47:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 05:47:46 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen at koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 07:53:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 05:53:41 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #334 from David Cook --- (In reply to Aleisha Amohia from comment #326) > Ah I remember now - yes, a hold group is supposed to be treated as one hold > because when one item from that group is confirmed to fill the hold, the > rest of the group is deleted. > > I'll fix this up. After reading through the code and further testing and thinking, I don't think that's feasible. It would require much more refactoring to achieve that, and I'm not sure that it's worth it. So I think if we pull out the count_grouped() code, then this could actually pass QA, so long as the intention is to create a group of holds, and that fulfilling one hold will clear the other holds. That works well. The counting of the hold group as 1 hold does not work at all though, so perhaps that concept should be abandoned (for now at least). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 07:57:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 05:57:14 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #335 from David Cook --- Test plan setup: 0a. Apply the patch 0b. perl ./installer/data/mysql/updatedatabase.pl 0c. perl misc/devel/update_dbix_class_files.pl --koha-conf /etc/koha/sites/kohadev/koha-conf.xml 0d. restart_all Test: Create a hold group from a group of items 1. Go to intranet search, display some results, click on the first 2 checkboxes and click on 'Place hold' button at the top of the results. (e.g. http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test) 2. Search for the "koha" patron (cardnumber 42) 3a. Check the 'Treat as hold group' checkbox 3b. Set pickup location for each item 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a hold group)' in Details column. 6. Click on the "hold group" link. A modal window should appear with the content of the hold group (a list of holds) Result: PASS Test: Hold groups count as 1 hold (maxreserves) 1. Change maxreserves to 2 2. Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&biblionumber=134 3. Note that it says "koha can only place a maximum of 2 total holds" 4. Change maxreserves to 50 Result: FAIL Test: Hold groups count as 1 hold ("Holds allowed (total)") 1. Go to http://localhost:8081/cgi-bin/koha/admin/smart-rules.pl 2. Change "Holds allowed (total)" to 2 3. Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&biblionumber=134 4. Note that it says "koha can only place a maximum of 2 total holds" 5. Change "Holds allowed (total)" to unlimited (by entering a blank value) Result: FAIL Test: Hold groups count as 1 hold ("Holds allowed (daily)") 1. Go to http://localhost:8081/cgi-bin/koha/admin/smart-rules.pl 2. Change "Holds allowed (daily)" to 2 3. Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&biblionumber=134 4. Note it says "No items are available to be placed on hold" and near the bottom of the screen each item says "Daily hold limit reached for patron" Result: FAIL Test: Hold groups count as 1 hold (Patron view) 1. Go to http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51 2. Note that 2 holds are listed, although each hold is listed as "part of a hold group" (and the links to that hold group are for the same hold group) Result: FAIL Test: Hold groups count as 1 hold (Circulation view) 1. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 2. Note that 2 holds are listed, although each hold is listed as "part of a hold group" (and the links to that hold group are for the same hold group) Result: FAIL Test: Hold groups count as 1 hold (OPAC home page view) 1. Go to http://localhost:8080/ 2. Note that the screen says "2 holds pending" Result: FAIL Test: Hold groups count as 1 hold (OPAC user page view) 1. Go to http://localhost:8080/cgi-bin/koha/opac-user.pl#opac-user-holds 2. Note that the screen says "2 holds" without any indication of them being part of the same hold group Result: FAIL Test: Hold groups count as 1 hold (OPAC place hold view) 1. Go to http://localhost:8080/cgi-bin/koha/opac-reserve.pl?biblionumber=134 2. Note that the screen says "There are no items that can be placed on hold" Result: FAIL Test: Hold groups are disbanded when 1 hold in the group is fulfilled 1. Check in an item of one of the reserved biblios and confirm the hold (e.g. Check in 39999000001310 ) 8. The hold status is changed to Waiting, and all other holds in the hold group are deleted. Result: PASS Note: The "hold group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 08:06:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 06:06:58 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #336 from David Cook --- Also, I notice that the text for the release notes say here that this is only for the staff interface, so the change for opac/opac-reserve.pl shouldn't be here at all. Since it's only for the staff interface, the concept of a hold group counting as 1 hold also doesn't make sense, since it would require complicated hold calculations that would vary depending on the interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 08:14:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 06:14:28 +0000 Subject: [Koha-bugs] [Bug 27300] Create a hold group for multiple items in one record in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27300 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from David Cook --- *** This bug has been marked as a duplicate of bug 15516 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 08:14:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 06:14:28 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #337 from David Cook --- *** Bug 27300 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 08:46:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 06:46:38 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 10:09:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 08:09:05 +0000 Subject: [Koha-bugs] [Bug 28493] New: Make koha-passwd display the username Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28493 Bug ID: 28493 Summary: Make koha-passwd display the username Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: mtj at kohaaloha.com The current output looks like this: sudo koha-passwd Password for : abc123 Press enter to clear the screen... But who remembers what the username looks like? It would be helpful to print this too, along with the password. (The format of the username is "koha_".) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 11:16:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 09:16:14 +0000 Subject: [Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 11:16:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 09:16:18 +0000 Subject: [Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115126|0 |1 is obsolete| | Attachment #115127|0 |1 is obsolete| | Attachment #115128|0 |1 is obsolete| | Attachment #115129|0 |1 is obsolete| | Attachment #115130|0 |1 is obsolete| | --- Comment #54 from Arthur Suzuki --- Created attachment 121524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121524&action=edit Bug 25408: Added unit tests for opacitemholds policy Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 11:16:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 09:16:34 +0000 Subject: [Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 --- Comment #55 from Arthur Suzuki --- Created attachment 121525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121525&action=edit Bug 25408: Add "opacitemholds" checks in CanBookBeReserved & CanItemBeReserved The rule "opacitemholds" seemed not to be controlled in some cases. This patch adds a control for this issuingrule in such a way it is checked across all interfaces (staff, opac, api) Added error message when trying to hold on the record and opacitemhold is set to "Force" to item-level hold To test: 0 - Apply patches 1 - Set rule to "Don't allow" item specific holds on opac 2 - Attempt to place hold on staff side 3 - Hold is still allowed 4 - Attempt to place hold from opac or api 5 - Hold is not allowed 6 - Change rule to 'force' 7 - Item-level hold can be placed in all interfaces 8 - Record-level hold cannot be placed in all interfaces Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 11:21:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 09:21:04 +0000 Subject: [Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 --- Comment #56 from Arthur Suzuki --- Hi Joubu, points 2 and 3 from last comment has been addressed. "Context" variable name is missused, I'm uploading a new version of the patch with use of C4::Context->interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 11:35:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 09:35:10 +0000 Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 --- Comment #44 from Katrin Fischer --- > But "Delete expired self registration accounts" does sound dangerous as you > describe. Personally, I don't see the merit of having that in > cleanup_database.pl at all. Even with a sysadmin adding that flag, you can't > control the behaviour of library staff. I think having all "delete" and clean-up things together is ok, especially when we move things into the GUI. But it requires good documentation for sure. We added a hint to the system preference, maybe we should add one to the script as well for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 11:58:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 09:58:50 +0000 Subject: [Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121524|0 |1 is obsolete| | Attachment #121525|0 |1 is obsolete| | --- Comment #57 from Arthur Suzuki --- Created attachment 121526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121526&action=edit Bug 25408: Add "opacitemholds" checks in CanBookBeReserved & CanItemBeReserved The rule "opacitemholds" seemed not to be controlled in some cases. This patch adds a control for this issuingrule in such a way it is checked across all interfaces (staff, opac, api) Added error message when trying to hold on the record and opacitemhold is set to "Force" to item-level hold To test: 0 - Apply patches 1 - Set rule to "Don't allow" item specific holds on opac 2 - Attempt to place hold on staff side 3 - Hold is still allowed 4 - Attempt to place hold from opac or api 5 - Hold is not allowed 6 - Change rule to 'force' 7 - Item-level hold can be placed in all interfaces 8 - Record-level hold cannot be placed in all interfaces Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 11:59:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 09:59:35 +0000 Subject: [Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121526|0 |1 is obsolete| | --- Comment #58 from Arthur Suzuki --- Created attachment 121527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121527&action=edit Bug 25408: Added unit tests for opacitemholds policy Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 11:59:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 09:59:56 +0000 Subject: [Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 --- Comment #59 from Arthur Suzuki --- Created attachment 121528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121528&action=edit Bug 25408: Add "opacitemholds" checks in CanBookBeReserved & CanItemBeReserved The rule "opacitemholds" seemed not to be controlled in some cases. This patch adds a control for this issuingrule in such a way it is checked across all interfaces (staff, opac, api) Added error message when trying to hold on the record and opacitemhold is set to "Force" to item-level hold To test: 0 - Apply patches 1 - Set rule to "Don't allow" item specific holds on opac 2 - Attempt to place hold on staff side 3 - Hold is still allowed 4 - Attempt to place hold from opac or api 5 - Hold is not allowed 6 - Change rule to 'force' 7 - Item-level hold can be placed in all interfaces 8 - Record-level hold cannot be placed in all interfaces Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 12:27:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 10:27:25 +0000 Subject: [Koha-bugs] [Bug 25900] QueryWeightFields creates unnecessary whitespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 12:27:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 10:27:29 +0000 Subject: [Koha-bugs] [Bug 25900] QueryWeightFields creates unnecessary whitespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114228|0 |1 is obsolete| | --- Comment #20 from Peter Vashchuk --- Created attachment 121529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121529&action=edit Bug 25900: trim spaces in search with Zebra and QueryWeightFields Search with Zebra and system preference QueryWeightFields on builds a query with surrounding double quotes : q=tree => q="tree". Therefore existing double quotes are replaced by a space : q="tree" => q=" tree ". Patch corrects by adding trim on operand after transforming quotes into spaces. Test plan : 1) Use Zebra searchengine and enable system preference QueryWeightFields 2) Go to advanced search 3) Search on two words from a title, surrounded by double quotes. Like "Order of the Phoenix" 4) Check you get same results with an without patch Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 13:19:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 11:19:43 +0000 Subject: [Koha-bugs] [Bug 28494] New: Can't enable plugins on a new instance of Koha Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28494 Bug ID: 28494 Summary: Can't enable plugins on a new instance of Koha Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: somesecretemail at mailinator.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The system preference UseKohaPlugins is lacking in version 20.05 and 20.11. Steps to reproduce: 1. Install a new instance of Koha version 20.11 2. Change 0 to 1 in your koha-conf.xml file to enable plugin functionality 3, Restart web server 4. Search for system preference UseKohaPlugins i administration module i Koha Result: "No system preferences matched your search for: UseKohaPlugins" Expected: system preferences UseKohaPlugins displayed. This has the unfortunate effect that you can't enable plugins on a new instance. (If you already have plugins enabled and upgraded to version 20.05, the plugin functionality continuous to be enabled) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 13:54:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 11:54:41 +0000 Subject: [Koha-bugs] [Bug 28494] Can't enable plugins on a new instance of Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28494 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Hi Stefan, this is not a bug, the prefernce has been removed. The koha-conf switch + permissions was deemed to be enough. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 13:55:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 11:55:21 +0000 Subject: [Koha-bugs] [Bug 28494] Can't enable plugins on a new instance of Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28494 --- Comment #2 from Katrin Fischer --- If you don't see the plugin options after changing koha-conf, try restarting Plack, Memcached, Apache etc. usually it's something like that :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 14:05:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 12:05:41 +0000 Subject: [Koha-bugs] [Bug 28494] Can't enable plugins on a new instance of Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28494 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #3 from Magnus Enger --- Looks like it is still in the 20.05 docs: https://koha-community.org/manual/20.05/en/html/systempreferences.html#usekohaplugins -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 14:08:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 12:08:57 +0000 Subject: [Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121528|0 |1 is obsolete| | --- Comment #60 from Arthur Suzuki --- Created attachment 121530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121530&action=edit Bug 25408: Add "opacitemholds" checks in CanBookBeReserved & CanItemBeReserved The rule "opacitemholds" seemed not to be controlled in some cases. This patch adds a control for this issuingrule in such a way it is checked across all interfaces (staff, opac, api) Added error message when trying to hold on the record and opacitemhold is set to "Force" to item-level hold To test: 0 - Apply patches 1 - Set rule to "Don't allow" item specific holds on opac 2 - Attempt to place hold on staff side 3 - Hold is still allowed 4 - Attempt to place hold from opac or api 5 - Hold is not allowed 6 - Change rule to 'force' 7 - Item-level hold can be placed in all interfaces 8 - Record-level hold cannot be placed in all interfaces Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 14:11:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 12:11:48 +0000 Subject: [Koha-bugs] [Bug 28494] Can't enable plugins on a new instance of Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28494 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20415 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415 [Bug 20415] Remove UseKohaPlugins system preference -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 14:11:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 12:11:48 +0000 Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28494 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28494 [Bug 28494] Can't enable plugins on a new instance of Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 14:12:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 12:12:38 +0000 Subject: [Koha-bugs] [Bug 28494] Can't enable plugins on a new instance of Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28494 --- Comment #4 from Katrin Fischer --- I found and linked the bug - it was removed in 20.05, possibly missed a manual update (provide a patch? :) ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 14:18:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 12:18:49 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120780|0 |1 is obsolete| | --- Comment #131 from Arthur Suzuki --- Created attachment 121531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121531&action=edit Bug 11999: Test improvements + check maxreserves improve t/db_dependent/Reserves.t to make tests pass on UNIMARC installation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 14:20:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 12:20:07 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #132 from Arthur Suzuki --- Hi David, I've not reproduced the issue with t/db_dependent/Holds.t number of tests in Reserves.t has been updated. Kr, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 14:22:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 12:22:46 +0000 Subject: [Koha-bugs] [Bug 28494] Can't enable plugins on a new instance of Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28494 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 15:19:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 13:19:21 +0000 Subject: [Koha-bugs] [Bug 21286] Advanced search for Corporate-name creates Zebra errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21286 --- Comment #7 from Nick Clemens --- (In reply to David Nind from comment #6) > I attempted to test this, but I couldn't recreate the error(steps 4-8) - I > could find the record with the corporate name in it (I added a unique name > not used anywhere else). > Try disabling the syspref 'QueryAutoTruncate' - that seems to be a key to triggering this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 15:57:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 13:57:05 +0000 Subject: [Koha-bugs] [Bug 28495] New: Add validation to branchcode upon library creation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Bug ID: 28495 Summary: Add validation to branchcode upon library creation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Since hyphens and trailing spaces can cause issues in the branchcode (see bug 28492), I propose we add a validation to the branchcode when a user creates a new library. I would limit it to letters and numbers only. Is there something else? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 15:57:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 13:57:52 +0000 Subject: [Koha-bugs] [Bug 28482] Floating point math prevents items from being returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28482 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 16:11:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 14:11:00 +0000 Subject: [Koha-bugs] [Bug 28448] Record with too many items is not shown in results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28448 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org --- Comment #8 from George Williams (NEKLS) --- My experience is that this happens when the Marc record exceeds 9999k in size. Our solution was to separate the record into multiple records and put all of the items from one year on one record, all of the items from the next year on the second record and so on . . . It wasn't a problem with Koha. The problem was that we were exceeding the maximum size of a Marc record. George -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 16:13:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 14:13:46 +0000 Subject: [Koha-bugs] [Bug 2486] Show user comments in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2486 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 16:14:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 14:14:33 +0000 Subject: [Koha-bugs] [Bug 28465] Don't allow staff user to change patron categories of other staff users and their own account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28465 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 16:25:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 14:25:30 +0000 Subject: [Koha-bugs] [Bug 28452] Add managing librarian to transaction page (boraccount.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28452 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 16:30:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 14:30:43 +0000 Subject: [Koha-bugs] [Bug 28496] New: Club holds form broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28496 Bug ID: 28496 Summary: Club holds form broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 28273 broke the form. To reproduce: 1. Have a club with some enrollments 2. Search for some biblio and try adding a club hold => FAIL: things are not ok with the dropdown. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 16:45:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 14:45:59 +0000 Subject: [Koha-bugs] [Bug 28497] New: Display city and zipcode as part of address on user search summary Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28497 Bug ID: 28497 Summary: Display city and zipcode as part of address on user search summary Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: david.roberts at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When you search for users and get a results list, the address field doesn't contain a city or zipcode, so it's not possible to tell where the user lives without opening the individual record. This is in /intranet-tmpl/prog/en/modules/members/tables/members_results.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 16:46:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 14:46:10 +0000 Subject: [Koha-bugs] [Bug 28497] Display city and zipcode as part of address on user search summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28497 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c |ity.org |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 16:47:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 14:47:19 +0000 Subject: [Koha-bugs] [Bug 28498] New: Add CLI counterpart for plugin actions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28498 Bug ID: 28498 Summary: Add CLI counterpart for plugin actions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org We need a CLI counterpart for plugin actions: - Install (from a URL, from a .kpz) - Upgrade (from a URL, from a .kpz) - Uninstall - Configure based on some file format -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 16:48:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 14:48:01 +0000 Subject: [Koha-bugs] [Bug 28498] Add CLI counterpart for plugin actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28498 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au, | |jonathan.druart+koha at gmail. | |com, | |katrin.fischer at bsz-bw.de, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 16:49:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 14:49:23 +0000 Subject: [Koha-bugs] [Bug 28499] New: Add support for no-UI / administrative plugins Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28499 Bug ID: 28499 Summary: Add support for no-UI / administrative plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It would be helpful for support to have the ability to add plugins that configure/affect the syste, but are not accessible by the users (cannot be removed, edited, etc) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 16:49:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 14:49:27 +0000 Subject: [Koha-bugs] [Bug 28499] Add support for no-UI / administrative plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28499 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au, | |jonathan.druart+koha at gmail. | |com, | |katrin.fischer at bsz-bw.de, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 16:50:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 14:50:57 +0000 Subject: [Koha-bugs] [Bug 24539] Build generic authentication module interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24539 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 16:59:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 14:59:23 +0000 Subject: [Koha-bugs] [Bug 2486] Show user comments in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2486 --- Comment #3 from Christopher Brannon --- Still valid. Would like to have an easier way to see comments in record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 17:10:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 15:10:43 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #338 from Christopher Brannon --- (In reply to David Cook from comment #334) > (In reply to Aleisha Amohia from comment #326) > > Ah I remember now - yes, a hold group is supposed to be treated as one hold > > because when one item from that group is confirmed to fill the hold, the > > rest of the group is deleted. > > > > I'll fix this up. > > After reading through the code and further testing and thinking, I don't > think that's feasible. It would require much more refactoring to achieve > that, and I'm not sure that it's worth it. > > So I think if we pull out the count_grouped() code, then this could actually > pass QA, so long as the intention is to create a group of holds, and that > fulfilling one hold will clear the other holds. That works well. > > The counting of the hold group as 1 hold does not work at all though, so > perhaps that concept should be abandoned (for now at least). I'm not sure if I am following correctly or not. Is the group hold going to count as one placed hold or count for every item in the group?? If it is going to show as multiple holds, then it becomes a problem for anyone that uses it. The group hold HAS to count as a single hold for this to be useful and not exploited by patrons. Without looking at the code, logically, it seems like if you have each group hold count as some kind of of proxy hold in the hold system, when Koha looks to see how many holds there are, it should also see how many group holds there are, and each group for that user should just reflect as one hold. I may be over simplifying this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 17:14:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 15:14:38 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #339 from Christopher Brannon --- (In reply to David Cook from comment #336) > Also, I notice that the text for the release notes say here that this is > only for the staff interface, so the change for opac/opac-reserve.pl > shouldn't be here at all. > > Since it's only for the staff interface, the concept of a hold group > counting as 1 hold also doesn't make sense, since it would require > complicated hold calculations that would vary depending on the interface. I don't know why this was limited to just the staff client. Maybe it is with the intent that someone will duplicate it for the OPAC? But if it is going to be just for staff, I think that it does only have the intended job from the original request. The original request was not for this to be a staff only function. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 17:27:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 15:27:59 +0000 Subject: [Koha-bugs] [Bug 26469] Register_id saves incorrect value in accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 17:47:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 15:47:23 +0000 Subject: [Koha-bugs] [Bug 28498] Add CLI counterpart for plugin actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28498 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 17:53:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 15:53:20 +0000 Subject: [Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #34 from Tomás Cohen Arazi --- I agree with Fridolin: we should think of adding API routes for this. There should be a privileged route, and an unprivileged route. You shouldn't worry about sessions and all. Just add the required permissions to interact with the routes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 17:55:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 15:55:08 +0000 Subject: [Koha-bugs] [Bug 28496] Club holds form broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28496 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |28273 Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 [Bug 28273] Multi-holds allow invalid pickup locations -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 17:55:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 15:55:08 +0000 Subject: [Koha-bugs] [Bug 28273] Multi-holds allow invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28496 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28496 [Bug 28496] Club holds form broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 18:04:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 16:04:48 +0000 Subject: [Koha-bugs] [Bug 21507] Decimal separators issues in patrons payments/fines, simplified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21507 --- Comment #11 from Victor Grousset/tuxayo --- > 2. Work backwards to find if we have decimal digits (i.e. 2 digits after either a comma or dot) > 3. If we find a decimal delimiter, drop the opposit delimiter from the string (i.e. if we find a dot then drop any comma's.. if we find a comma, drop any dots) This works thanks to relying on having two decimal digits right? No less, no more. Which is fine, it's already soooo hard as it is. This looks great, it seems to cover all of the cases and the logic is quite simple, amazing algorithm that your have found there!!!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 18:18:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 16:18:59 +0000 Subject: [Koha-bugs] [Bug 28496] Club holds form broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28496 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 121532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121532&action=edit Bug 28496: Club holds pickup locations don't come from the API This patch fixes a issue that is generated by the fact different inputs were reusing the same id. To test: 1. Have a club with some enrollments 2. Make sure you have your circ rules to allow any library be a pickup location. 3. Search for a biblio 4. Try placing a club hold => FAIL: The dropdown only has the (currently) logged in library. 5. Apply this patch 6. Repeat 3-4 => SUCCESS: The dropdown has all the options -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 18:22:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 16:22:13 +0000 Subject: [Koha-bugs] [Bug 28496] Club holds form broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28496 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 18:26:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 16:26:07 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 --- Comment #16 from Victor Grousset/tuxayo --- Does that still need need work about the 1st half of comment 5? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 19:25:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 17:25:23 +0000 Subject: [Koha-bugs] [Bug 28475] Searching all headings returns no results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 --- Comment #17 from Tomás Cohen Arazi --- (In reply to Fridolin Somers from comment #15) > Test plan has a mistake : > > 1. Open the authorities section in the OPAC > => It in is in staff interface Oops. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 19:36:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 17:36:26 +0000 Subject: [Koha-bugs] [Bug 28465] Don't allow staff user to change patron categories of other staff users and their own account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28465 --- Comment #2 from Christofer Zorn --- Thank you Katrin ... that looks great to me. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 19:42:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 17:42:08 +0000 Subject: [Koha-bugs] [Bug 28496] Club holds form broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28496 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 20:14:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 18:14:30 +0000 Subject: [Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #35 from Blou --- I'm sorry Tomas, this really muddied the picture for Ivan, and I can't help him as I've no idea how he should proceed. Do you mean his api/elasticsearch/elasticsearch.pl should be put under /v1/ and the routes added to swagger, etc... Any wiki to help him there? We had hope this would get into 21.05 initially, but right now it looks like Ivan will recode it for the foreseable future. Which won't happen, I'll give him one more go at it then drop it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 21:45:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 19:45:15 +0000 Subject: [Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 --- Comment #11 from Rudolf Byker --- Hi there. Who needs to sign off on this issue? Is there anything else I can do to help speed up the process? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 22:15:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 20:15:02 +0000 Subject: [Koha-bugs] [Bug 25029] AllowPatronToControlAutorenewal needs to have a disable setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 22:44:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 20:44:35 +0000 Subject: [Koha-bugs] [Bug 28500] New: Display before and after values when a biblio has been edited Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28500 Bug ID: 28500 Summary: Display before and after values when a biblio has been edited Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Trying to determine what information was changed in a biblio is rather difficult. While there is some functionality in the logs, not all staff have access to the logs, nor is the info easy to interpret. It would be really helpful to have another method of tracking changes to bib records, such as a simple BEFORE value: xxxx AFTER value: xxxxx that only records the changes made, which user made the change, and when. Ideally this would be viewable outside of logs, perhaps through reports, and kept for the entire time the biblio is in the catalog. This is very important for libraries that have multiple locations and multiple staff editing biblios - there is a need to see who made what changes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 22:55:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 20:55:01 +0000 Subject: [Koha-bugs] [Bug 28440] Inventory tool tries to put a time into DateLastSeen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28440 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |20.05 --- Comment #3 from Andrew Fuerste-Henry --- I've been able to recreate this behavior on 20.05, but only in the afternoon :) To recreate: - Set TimeFormat to 12 Hour - make sure cataloging log is on - wait until afternoon - have an item with barcode "TEST" and callnumber "9999" - in Inventory, upload a text file of just the barcode "TEST," limit inventory to callnumber range 9999-9999 - submit inventory, it tells you it set Date Last Seen to today for 1 item - go to item, confirm it shows a null Date Last Seen - look at the modification log, see Koha tried to put a date and time into Date Last Seen -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 23:16:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 21:16:37 +0000 Subject: [Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 --- Comment #12 from Katrin Fischer --- (In reply to Rudolf Byker from comment #11) > Hi there. Who needs to sign off on this issue? Is there anything else I can > do to help speed up the process? Hi Rudolf, at this stage, anyone can sign off - there is not much you can do, but maybe talk to people who might be interested in this patch got gain a sign off. Sometimes an email to the mailing list might help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 23:19:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 21:19:09 +0000 Subject: [Koha-bugs] [Bug 28500] Display before and after values when a biblio has been edited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28500 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14367 --- Comment #1 from Katrin Fischer --- Hi Donna, I think bug 14367 might be what you are looking for. If it does fit your idea, you could mark this one as a duplicate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 1 23:19:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 21:19:09 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28500 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 01:04:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 23:04:26 +0000 Subject: [Koha-bugs] [Bug 28316] Cannot search with square brackets [] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #11 from Victor Grousset/tuxayo --- With the patch of comment 8 and services restarted. Retried the case listed in the comment 8: > With QueryAutoTruncate = only if * is added: > The ideas behind the chess openings "fox quick"~5 tag:{alpha TO omega} => No results I still have no result with the patch from comment 8 I still have to quote it. > With QueryAutoTrunacte = automatically: > The ideas behind the chess openings "fox quick"~5 tag:{alpha TO omega} => Error: Unable to perform your search Still error With QueryAutoTruncate=both possible values For a search of the following and a record named the following: name:/joh?n(ath[oa]n)/ => no result With QueryAutoTruncate=only if * For a search of the following and a record named the following: count:[10 TO *] => no result With QueryAutoTruncate=auto For a search of the following and a record named the following: count:[10 TO *] => Error: Unable to perform your search With QueryAutoTruncate=only if * For a search of the following and a record named the following: age:(+>=10 +<20) => no result With QueryAutoTruncate=auto For a search of the following and a record named the following: age:(+>=10 +<20) => no result With QueryAutoTruncate=only if * For a search of the following and a record named the following: quick^2 fox => Error: Unable to perform your search With QueryAutoTruncate=only if * For a search of the following and a record named the following: The reserved characters are: + - = && || > < ! ( ) { } [ ] ^ " ~ * ? : \ / => Error: Unable to perform your search With QueryAutoTruncate=auto For a search of the following and a record named the following: The reserved characters are: + - = && || > < ! ( ) { } [ ] ^ " ~ * ? : \ / => Error: Unable to perform your search With QueryAutoTruncate=auto For a search of the following (no record) [chess TO *] => Error: Unable to perform your search With QueryAutoTruncate=only if * For a search of the following (no record) [chess TO *] => whole catalogue Maybe it's expected With QueryAutoTruncate=auto For a search of the following (no record) Nmap network scanning : <> >< => Error: Unable to perform your search Not sure what is expected in the above results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 01:28:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Jun 2021 23:28:24 +0000 Subject: [Koha-bugs] [Bug 28316] Cannot search with square brackets [] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #12 from Victor Grousset/tuxayo --- With QueryAutoTruncate=both possible values nmap onfocus=JaVaSCript:alert(9) autofocus => Error: Unable to perform your search With QueryAutoTruncate=both possible values nmap " onfocus=JaVaSCript:alert(10) autofocus => Error: Unable to perform your search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 04:28:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 02:28:14 +0000 Subject: [Koha-bugs] [Bug 28476] Update info in docs/teams.yaml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28476 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 04:28:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 02:28:18 +0000 Subject: [Koha-bugs] [Bug 28476] Update info in docs/teams.yaml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28476 --- Comment #4 from Mason James --- Created attachment 121533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121533&action=edit Bug 28476: Update info in docs/teams.yaml file (2) oops, correct info -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 04:29:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 02:29:02 +0000 Subject: [Koha-bugs] [Bug 28476] Update info in docs/teams.yaml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28476 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 04:29:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 02:29:16 +0000 Subject: [Koha-bugs] [Bug 28476] Update info in docs/teams.yaml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28476 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 04:29:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 02:29:30 +0000 Subject: [Koha-bugs] [Bug 28476] Update info in docs/teams.yaml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28476 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 04:40:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 02:40:30 +0000 Subject: [Koha-bugs] [Bug 28498] Add CLI counterpart for plugin actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28498 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25671 --- Comment #1 from David Cook --- +1000000 I opened Bug 25671 a while ago for this, but I ran out of time/energy for it, as we don't really use plugins much at this point. I'm happy for that bug report to be marked as a duplicate of this one, if Tomas is going to work on this. Really really looking forward to progress on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 04:40:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 02:40:30 +0000 Subject: [Koha-bugs] [Bug 25671] Install 1 Koha plugin for X Koha instances using the CLI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25671 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28498 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 04:41:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 02:41:33 +0000 Subject: [Koha-bugs] [Bug 28498] Add CLI counterpart for plugin actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28498 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 04:44:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 02:44:18 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #340 from David Cook --- (In reply to Christopher Brannon from comment #338) > Is the group hold going to count as one placed hold or count for every item in the group?? At the moment, each member of a group hold counts as its own hold. > If it is > going to show as multiple holds, then it becomes a problem for anyone that > uses it. The group hold HAS to count as a single hold for this to be useful > and not exploited by patrons. I'm not sure what you mean here by "exploited". To me, each member of a group hold counting as a hold is problematic only in terms of hold limits. If you had a limit of 10 holds, and they create 1 hold group with 10 members, then they've exhausted their limit, and that's not necessarily fair to patrons. > Without looking at the code, logically, it seems like if you have each group > hold count as some kind of of proxy hold in the hold system, when Koha looks > to see how many holds there are, it should also see how many group holds > there are, and each group for that user should just reflect as one hold. I > may be over simplifying this. I wouldn't say over simplifying heh. It's quite complex. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 04:46:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 02:46:14 +0000 Subject: [Koha-bugs] [Bug 25671] Install 1 Koha plugin for X Koha instances using the CLI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25671 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #10 from David Cook --- *** This bug has been marked as a duplicate of bug 28498 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 04:46:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 02:46:14 +0000 Subject: [Koha-bugs] [Bug 28498] Add CLI counterpart for plugin actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28498 --- Comment #2 from David Cook --- *** Bug 25671 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 04:46:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 02:46:47 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #341 from David Cook --- (In reply to Christopher Brannon from comment #339) > I don't know why this was limited to just the staff client. Maybe it is > with the intent that someone will duplicate it for the OPAC? But if it is > going to be just for staff, I think that it does only have the intended job > from the original request. The original request was not for this to be a > staff only function. Bug 17217 is for the OPAC side, but I think it's incomplete. There are libraries out in the world running a local version of this, but it's different to what's in Bugzilla. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 04:48:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 02:48:36 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #342 from Aleisha Amohia --- Thanks for discussing this everyone. If you just decide what the best behaviour should be and let me know when I need to implement I should be able to get to this later this week. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 04:50:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 02:50:15 +0000 Subject: [Koha-bugs] [Bug 25671] Install 1 Koha plugin for X Koha instances using the CLI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25671 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #11 from Tomás Cohen Arazi --- I didn't know or heard about this before. Will be looking at this code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 04:50:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 02:50:34 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org --- Comment #22 from David Cook --- (In reply to Joonas Kylmälä from comment #21) > David, any updates on this? :) Ooops. Missed the email notification. While I still have an interest in plugins, we just don't use them enough to justify me working on them during my job hours. And outside my job I have so few hours available and those I'm putting towards authentication/Mojolicious controller things. So I'll abdicate as assignee. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 04:52:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 02:52:02 +0000 Subject: [Koha-bugs] [Bug 28499] Add support for no-UI / administrative plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28499 --- Comment #1 from David Cook --- Oooh I like the sound of this. Ideally, I'd like to not allow libraries to install their own plugins (similar to Bug 25672), but I would like to be able to install plugins on their system from the CLI. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 04:53:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 02:53:57 +0000 Subject: [Koha-bugs] [Bug 28498] Add CLI counterpart for plugin actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28498 --- Comment #3 from David Cook --- Btw, it could be interesting after installing/upgrading a plugin to do a graceful restart on Starman using HUP as per https://metacpan.org/pod/Starman. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 04:54:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 02:54:24 +0000 Subject: [Koha-bugs] [Bug 28499] Add support for no-UI / administrative plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28499 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25672 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 04:54:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 02:54:24 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28499 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 04:55:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 02:55:14 +0000 Subject: [Koha-bugs] [Bug 28499] Add support for no-UI / administrative plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28499 --- Comment #2 from David Cook --- One question: Would the plugin itself denote itself as non-accessible to users, or would it be a flag used when installing via the CLI? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 04:57:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 02:57:18 +0000 Subject: [Koha-bugs] [Bug 25671] Install 1 Koha plugin for X Koha instances using the CLI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25671 --- Comment #12 from David Cook --- (In reply to Tomás Cohen Arazi from comment #11) > I didn't know or heard about this before. Will be looking at this code. <3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 05:00:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 03:00:51 +0000 Subject: [Koha-bugs] [Bug 28499] Add support for no-UI / administrative plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28499 --- Comment #3 from Tomás Cohen Arazi --- (In reply to David Cook from comment #2) > One question: > > Would the plugin itself denote itself as non-accessible to users, or would > it be a flag used when installing via the CLI? I think both use cases are valid and interesting. I was pointing more to the first one in an initial approach, as the second one has interesting edge cases, like users installing a new version, etc. What do you think it would be best? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 05:08:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 03:08:59 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #343 from David Cook --- (In reply to Aleisha Amohia from comment #342) > Thanks for discussing this everyone. If you just decide what the best > behaviour should be and let me know when I need to implement I should be > able to get to this later this week. I think that it would be good for them to be counted as 1 hold for the sake of hold limits. However, I think that's probably easier said than done. Based on my investigations for Bug 15516 and 15565, it seems like the master code for determining hold limits is a mess. One downside of hold groups counting as 1 hold for limits is that it might not be clear to users how many holds they can place as well, although maybe that should be a separate enhancement... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 05:21:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 03:21:20 +0000 Subject: [Koha-bugs] [Bug 28499] Add support for no-UI / administrative plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28499 --- Comment #4 from David Cook --- (In reply to Tomás Cohen Arazi from comment #3) > (In reply to David Cook from comment #2) > > One question: > > > > Would the plugin itself denote itself as non-accessible to users, or would > > it be a flag used when installing via the CLI? > > I think both use cases are valid and interesting. I was pointing more to the > first one in an initial approach, as the second one has interesting edge > cases, like users installing a new version, etc. > > What do you think it would be best? I think the first one is probably the most realistic. Like you say, the second one has too many edge cases I think. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 05:27:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 03:27:02 +0000 Subject: [Koha-bugs] [Bug 24539] Build generic authentication module interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24539 --- Comment #14 from David Cook --- I might have another poke at this tonight. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 05:28:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 03:28:26 +0000 Subject: [Koha-bugs] [Bug 28448] Record with too many items is not shown in results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28448 --- Comment #9 from David Cook --- (In reply to George Williams (NEKLS) from comment #8) > My experience is that this happens when the Marc record exceeds 9999k in > size. Our solution was to separate the record into multiple records and put > all of the items from one year on one record, all of the items from the next > year on the second record and so on . . . > > It wasn't a problem with Koha. The problem was that we were exceeding the > maximum size of a Marc record. > > George That's interesting. I thought that we'd overcome that limitation by switching to MARCXML with Zebra but perhaps we didn't... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 05:28:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 03:28:50 +0000 Subject: [Koha-bugs] [Bug 28448] Record with too many items is not shown in results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28448 --- Comment #10 from David Cook --- Bohdan: With your 20.11 installation, is it a new installation or an upgraded installation that you've had for a long time? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 05:36:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 03:36:49 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #27 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121534&action=edit Bug 27741: reports folder Bug 27631 corrected the

tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

are in the correct order and hierarchy Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 05:39:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 03:39:53 +0000 Subject: [Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #36 from David Cook --- (In reply to Tomás Cohen Arazi from comment #34) > I agree with Fridolin: we should think of adding API routes for this. There > should be a privileged route, and an unprivileged route. > You shouldn't worry about sessions and all. Just add the required > permissions to interact with the routes. Yeah, I don't get why session data is being used here. I don't even know if there needs to be 2 routes. Maybe just 1 public/unprivileged API route. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 05:40:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 03:40:39 +0000 Subject: [Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #37 from David Cook --- Also, it's not clear from the test plan what the user is expected to see/do in terms of the autocomplete... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 06:04:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 04:04:16 +0000 Subject: [Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740 Wally DesChamps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wdeschamps at prospertx.gov --- Comment #10 from Wally DesChamps --- This would be an invaluable enhancement. With all that goes on at our circ desk, and the steps involved in handling money, updating Koha, credit card terminal, etc.,e tc., etc., changing the item to Lost and Paid For is often missed and becomes an exercise in frustration to balance in the accounting reports, especially when one payment covers multiple items. Has there been any progress with this Bug? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 07:50:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 05:50:56 +0000 Subject: [Koha-bugs] [Bug 20662] The "most popular" function on the opac does not honour opac supression In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from David Cook --- *** This bug has been marked as a duplicate of bug 19704 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 07:50:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 05:50:56 +0000 Subject: [Koha-bugs] [Bug 19704] OPACs most popular feature includes titles hidden by OpacHiddenItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19704 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- *** Bug 20662 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 09:08:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 07:08:51 +0000 Subject: [Koha-bugs] [Bug 28448] Record with too many items is not shown in results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28448 --- Comment #11 from Bohdan --- This Koha is an upgraded one. I installed version 19.11. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 10:37:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 08:37:54 +0000 Subject: [Koha-bugs] [Bug 24539] Build generic authentication module interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24539 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121412|0 |1 is obsolete| | --- Comment #15 from David Cook --- Created attachment 121535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121535&action=edit Bug 24539: Add hooks to allow pluggable authentication modules This patch adds the ability to specify an authentication module to C4::Auth::checkauth(). That module then needs to implement at the very least a do_login() method and optionally do_logout() and get_data() methods if they're needed for that authentication style. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 10:40:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 08:40:23 +0000 Subject: [Koha-bugs] [Bug 24539] Build generic authentication module interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24539 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 10:46:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 08:46:41 +0000 Subject: [Koha-bugs] [Bug 24539] Build generic authentication module interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24539 --- Comment #16 from David Cook --- To test (using a test auth plugin): 1. Download and install Koha Plugin koha-plugin-test-auth 2. Upload plugin via http://localhost:8081/cgi-bin/koha/plugins/plugins-home.pl 3. Enable the plugin 4. Go to http://localhost:8081/cgi-bin/koha/admin/patron-attr-types.pl 5. Create a new patron attribute with the code "TestAuthT" (you should make the description "TestAuthMagicLogin" but it doesn't matter, and you should make it a Unique identifier, so that a token can only belong to one patron) 6. Go to http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=51&step=4 7. Add "1234" to TestAuthMagicLogin attribute 8. Log out of Koha 9. koha-plack --restart kohadev #This loads the plugin route 10. Go to http://localhost:8081/api/v1/contrib/testauth/authn?token=1234 11. Note that you've been logged in as the "koha" user 12. Check /var/log/koha/kohadev/plack-api-error.log, and note warnings like the following: [2021/06/02 08:43:47] [WARN] Koha::Plugin::Dcook::TestAuth::AuthN::Plugin do_login at /var/lib/koha/kohadev/plugins/Koha/Plugin/Dcook/TestAuth/AuthN/Plugin.pm line 17. [2021/06/02 08:43:47] [WARN] Koha::Plugin::Dcook::TestAuth::AuthN::Plugin get_data at /var/lib/koha/kohadev/plugins/Koha/Plugin/Dcook/TestAuth/AuthN/Plugin.pm line 60. [2021/06/02 08:43:47] [WARN] $VAR1 = { 'TestAuthKey' => 'TestAuthValue' }; 13. Log out of the staff interface 14. Note that you've been logged out 15. Check /var/log/koha/kohadev/plack-intranet-error.log, and note warnings like the following: [2021/06/02 08:44:44] [WARN] Koha::Plugin::Dcook::TestAuth::AuthN::Plugin do_logout at /var/lib/koha/kohadev/plugins/Koha/Plugin/Dcook/TestAuth/AuthN/Plugin.pm line 52. [2021/06/02 08:44:44] [WARN] $VAR1 = { 'TestAuthKey' => 'TestAuthValue' }; 16. Go to http://localhost:8080/api/v1/contrib/testauth/authn?token=1234 17. Note that you've been logged into the OPAC 18. Log out of the OPAC 19. Note the warnings in /var/log/koha/kohadev/plack-api-error.log and /var/log/koha/kohadev/plack-opac-error.log -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 10:53:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 08:53:53 +0000 Subject: [Koha-bugs] [Bug 24539] Build generic authentication module interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24539 --- Comment #17 from David Cook --- Created attachment 121536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121536&action=edit [DO NOT PUSH] koha-plugin-test-auth Koha Plugin for testing This is a Koha Plugin that I slapped together to prove that the generic authentication module interface works. Perhaps next week I can put together an OpenID Connect module. It might be tricky to do as a Koha Plugin, since checkauth() is based on CGI.pm and that doesn't play nicely with Mojolicious... although maybe $c will be in scope. That's for another night though... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 11:00:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 09:00:40 +0000 Subject: [Koha-bugs] [Bug 24539] Build generic authentication module interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24539 --- Comment #18 from David Cook --- (In reply to David Cook from comment #17) > Perhaps next week I can put together an OpenID Connect module. It might be > tricky to do as a Koha Plugin, since checkauth() is based on CGI.pm and that > doesn't play nicely with Mojolicious... although maybe $c will be in scope. Darn. I just did a little test, and $c is not in scope for do_login when called within checkauth() from a Mojolicious controller. I do have another idea which is so hacky. In the koha-plugin-test-auth, I redirect STDOUT and STDERR to /dev/null, but I could actually redirect STDOUT to a scalar variable, and then I could parse the output and translate it to Mojolicious... Rather than hacking apart Koha's existing functions, it might be a better idea to refactor checkauth() so that it's comprised of separate login and logout functions, which can be called in a more environmentally aware way. Anyway, definitely calling it a night... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 11:05:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 09:05:11 +0000 Subject: [Koha-bugs] [Bug 24539] Build generic authentication module interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24539 --- Comment #19 from David Cook --- (In reply to David Cook from comment #18) > (In reply to David Cook from comment #17) > > Perhaps next week I can put together an OpenID Connect module. It might be > > tricky to do as a Koha Plugin, since checkauth() is based on CGI.pm and that > > doesn't play nicely with Mojolicious... although maybe $c will be in scope. > > Darn. I just did a little test, and $c is not in scope for do_login when > called within checkauth() from a Mojolicious controller. > > I do have another idea which is so hacky. In the koha-plugin-test-auth, I > redirect STDOUT and STDERR to /dev/null, but I could actually redirect > STDOUT to a scalar variable, and then I could parse the output and translate > it to Mojolicious... > > Rather than hacking apart Koha's existing functions, it might be a better > idea to refactor checkauth() so that it's comprised of separate login and > logout functions, which can be called in a more environmentally aware way. > > Anyway, definitely calling it a night... Actually, the better way to do it would be to focus on the concept of authenticated sessions. You could have a Koha Plugin perform a login however it wants, and it just ends up with a session. It then redirects or whatever and sets the session cookie. Then it's all good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 11:09:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 09:09:46 +0000 Subject: [Koha-bugs] [Bug 24539] Build generic authentication module interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24539 --- Comment #20 from David Cook --- Note that this generic authentication module interface doesn't have to be done using Koha Plugins. We can provide these authentication modules in the Koha core codebase. Then we'd just need to write the controller code (in CGI style for the time being) that leverages the particular authentication module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 12:01:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 10:01:17 +0000 Subject: [Koha-bugs] [Bug 21383] Sorting on ILL request table is inaccurate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21383 Angela changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angela.oconnordesmond at staff | |.ittralee.ie --- Comment #2 from Angela --- Hi, Also interested in seeing this one resolved. Thanks, Angela -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 13:08:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 11:08:58 +0000 Subject: [Koha-bugs] [Bug 20344] Transferring an item while on hold results in a transfer where the destination is the same as the source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20344 --- Comment #7 from Victor Grousset/tuxayo --- > 4. First one should have been canceled > «Canceled, new transfer from A to A created» Notes, it's about the comment column. In current master, this message isn't there anymore. It was there at least until 17.11 (https://pro-demo1711-koha.test.biblibre.eu) > 6. These 2 things are the issue. > Because doing the same without a hold > - doesn't create a new transfer > - doesn't cancel the first one Without a hold. A new transfer is created and the old one is canceled. With a hold when doing "Ignore and return to transfers: " A new transfer is created and the old one is canceled. With a hold when doing "Waiting" A new transfer is created and the old one is canceled. An item hold doesn't change this. So, it happens regardless of the hold. 17.11: Without hold, just doing several transfers, none additional is created, the table is untouched (no timestamp change) So, is there something wrong? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 13:27:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 11:27:02 +0000 Subject: [Koha-bugs] [Bug 28501] New: Document how to use the search configuration page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28501 Bug ID: 28501 Summary: Document how to use the search configuration page Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Keywords: Manual Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org In the manual there is currently no information on how to use the search configuration page for Elasticsearch. I am especially thinking of: - How to add a field/subfield to an existing index - How to create a new index to use for search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 13:42:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 11:42:24 +0000 Subject: [Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740 --- Comment #11 from Katrin Fischer --- (In reply to Wally DesChamps from comment #10) > This would be an invaluable enhancement. With all that goes on at our circ > desk, and the steps involved in handling money, updating Koha, credit card > terminal, etc.,e tc., etc., changing the item to Lost and Paid For is often > missed and becomes an exercise in frustration to balance in the accounting > reports, especially when one payment covers multiple items. Has there been > any progress with this Bug? At the moment this bug has no Assignee (someone working on a patch) and has not been marked as "Sponsored". I can only assume that there is no ongoing work on this. As there seem a lot of people interested in it, maybe you could join forces to get this funded and developed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 14:45:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 12:45:15 +0000 Subject: [Koha-bugs] [Bug 28502] New: Changing patron category from child to adult doesn't delete non patron guarantor data. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28502 Bug ID: 28502 Summary: Changing patron category from child to adult doesn't delete non patron guarantor data. Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: didier.gautheron at biblibre.com Reporter: didier.gautheron at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com But guarantor name and relationship fields aren't displayed anymore and librarian can't delete them manually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 14:59:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 12:59:27 +0000 Subject: [Koha-bugs] [Bug 11083] Authority Search Result Display should be XSLT Driven In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083 --- Comment #2 from Julian Maurice --- Created attachment 121537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121537&action=edit Bug 11083: Add ability to generate authority summary using XSLT This patch only affects authority search results in the staff interface. It adds a new system preference AuthorityXSLTResultsDisplay. If set, each authority search result MARCXML will be transformed using the XSLT at the given filename or URL. The output will be displayed in place of the default summary. If errors occur, the XSLT is ignored and the default summary is displayed. The syspref value can contain {langcode} and {authtypecode} which will be replaced by the appropriate value (resp. current language and authority type code) Test plan: 1. Apply patch and run updatedatabase 2. Verify that authority search results are not affected yet. 3. Create an XSLT file (for instance in /home/koha/xslt/en/GEOGR_NAME.xsl) 4. Set AuthorityXSLTResultsDisplay syspref value to /home/koha/xslt/{langcode}/{authtypecode}.xsl 5. Do an authority search that returns GEOGR_NAME results. Verify that the summary matches what you expect from your XSLT 6. Do an authority search that returns authorities of other types. Verify that the default summary is displayed. Example of a minimal XSLT: authority-summary -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 14:59:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 12:59:38 +0000 Subject: [Koha-bugs] [Bug 11083] Authority Search Result Display should be XSLT Driven In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 14:59:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 12:59:47 +0000 Subject: [Koha-bugs] [Bug 11083] Authority Search Result Display should be XSLT Driven In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 15:22:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 13:22:54 +0000 Subject: [Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 --- Comment #21 from Thomas Dukleth --- Some important bug fixes and some improvements with support for excluding old archived content from simple search are included in this version of code and Koha Wiki files to test migrating the database and upgrading the wiki from the previous version is currently available at , https://test01.agogme.com/koha_migrate_mwiki_db_and_upgrade_test.tgz . More changes improving automation of the installation and validation are needed. Changes support a dynamic archive with mass tagging of outdated pages in the same wiki also holding current pages with a distinct search query page for accessing old content. Anyone interested in testing would need to separately obtain a full dump of the Koha Wiki to avoid publicly compromising Koha Wiki usernames and passwords which are not contained in the published archive. Similarly as I should have mentioned previously, the issue of resetting wgSecretKey in LocalSettings.php could be avoided by obtaining a copy of the Koha Wiki LocalSettings.php . >From the current changelog. In README.txt ------------- Specified required system packages somewhat more completely. Added RESTBase section. In apt configuration example files ---------------------------------- Added support for MediaWiki VisualEditor extension which relies upon the MediaWiki RESTBase API service which needs nodejs version 6+ and uses Apache Cassandra. nodejs 6+ needs the stretch-backports repository for Installation in Debian Stretch. No successful RESTBase configuration found for Apache and thus may require forthcoming NGINX configuration. In webserver configuration example files ---------------------------------- Added support for MediaWiki VisualEditor extension which relies upon the MediaWiki RESTBase API service which needs nodejs version 6+ and uses Apache Cassandra. nodejs 6+ needs the stretch-backports repository for Installation in Debian Stretch. No successful RESTBase configuration found for Apache and thus may require forthcoming NGINX configuration. In koha_migrate_mwiki_db_and_upgrade.pl --------------------------------------- Uncommented a few lines for apt update and downloading files which had been temporarily commented out for testing to avoid requesting network recources too frequently with a rapid testing cycle. Specified required system packages somewhat more completely. Fixed escaping characters for setting Debian version in special PHP apt repository. Added use of more variables to control file locations. Excluded Semantic MediaWiki tables from the database dump used in building the particular MySQL MediaWiki database for upgrading to the current MediaWiki version thus discarding populated data before upgrade to save unnecessary extra work. Semantic MediaWiki had never functioned properly in Postgres and failed command line tests. Attempting to properly preserve unused Semantic MediaWiki data would require additional work to first upgrade to MediaWiki 1.24 before upgrading to the current version with no actual benefit as we have not been using the broken extension in Postgres. In any case, the data is recreated with reinstallation of Semantic MediaWiki. Added support for MediaWiki VisualEditor extension which relies upon the MediaWiki RESTBase API service which needs nodejs version 6+ and uses Apache Cassandra. nodejs 6+ needs the stretch-backports repository for Installation in Debian Stretch. koha_mediawiki_pgsqltomysql.py ------------------------------ Fixed treatment of NULL values which had left some NULLs not converting properly and led to bad strftime conversion for columns with NULL values in database migration from Postgres to MySQL. koha_mwiki_instances_postinstall.sh ----------------------------------- Added installation of Semantic MediaWiki extension. Added specification of Vector skin default. Added MassEditRegex extension. Added installation of MessageBox templates and needed modules. SearchBox.mustache ----------------------------------- Added JavaScript to exclude Content_Old category from simple search box queries with Vector skin allowing archived content to be excluded from searches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 15:54:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 13:54:44 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #10 from Julian Maurice --- If I modify sessions.a_session from longtext to longblob I no longer have the bug. Can you test if it works for you too ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 15:58:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 13:58:07 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #96 from Arthur Suzuki --- Just had a quick check at this patch. Seems the controls on the overlapping reserves is done in the interface code (opac/place-reserve.pl and so on) and not in C4/Reserves. This is then not checked for ILS-DI and RestAPI. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 16:01:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 14:01:11 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 16:01:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 14:01:15 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #1 from Jonathan Druart --- Created attachment 121538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121538&action=edit Bug 28490: Remove "relationship" from the patron form This is managed by the "guarantor" section (table borrower_relationships in DB). It shouldn't be a separate section in the form. We removed the DB column on bug 28490. It caused an exception when the patron's data was stored. Patron modification failed! - No property relationship for Koha::Patron at /usr/share/koha/intranet/cgi-bin/members/memberentry.pl Test plan: Edit a patron with category "Child" and save -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 16:01:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 14:01:21 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 16:01:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 14:01:31 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 16:08:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 14:08:37 +0000 Subject: [Koha-bugs] [Bug 28158] Lost items not charging when marked lost from batch item modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28158 --- Comment #31 from Jonathan Druart --- (In reply to Fridolin Somers from comment #30) > Pushed to 20.11.x for 20.11.07 I wouldn't have backported this, it's a big change. Moreover Nick reported that it was working on 20.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 16:09:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 14:09:53 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 16:18:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 14:18:16 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #11 from Julian Maurice --- Created attachment 121539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121539&action=edit Bug 28489: Modify sessions.a_session from longtext to longblob This column contains serialized data, it should be a blob. And it fixes encoding issues. Test plan: 1. Apply patch and run updatedatabase 2. In $KOHA_CONF make sure that you have 0 3. Create 2 libraries: a. TESTÄ/Testä b. TEST✓/Test✓ 4. Go to the staff interface, change your library to Testä, then navigate to a few other pages, make sure there is no encoding problem with the library name in the top right corner 5. Do the same with Test✓ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 16:18:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 14:18:33 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 16:18:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 14:18:41 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 16:23:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 14:23:04 +0000 Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Henry Bolshaw changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh at parliament.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 16:33:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 14:33:42 +0000 Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 --- Comment #45 from Jonathan Druart --- (In reply to David Cook from comment #41) > (In reply to Jonathan Druart from comment #36) > > David, basically you are asking for another switch in koha-conf that would > > be off by default, that's it? > > I'm not sure what you mean by "asking for another switch in koha-conf". I don't want to add more confusion and I guess it wouldn't have answered the need anyway. I thought you were asking for more flexibility and so adding a new switch in koha-conf.xml to allow the syspref to have precedence over the script flag. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 16:34:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 14:34:45 +0000 Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #46 from Jonathan Druart --- I would like another QA stamp and clarification on what we need here. I won't have time to dedicate to this in the next couple of weeks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 16:49:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 14:49:47 +0000 Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 --- Comment #2 from Tomás Cohen Arazi --- I really like it. The code is really simple, and handling dateformat seems sleek as well. The only thing I could mention is the modal feels too big. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 16:50:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 14:50:10 +0000 Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 17:01:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 15:01:06 +0000 Subject: [Koha-bugs] [Bug 28467] Add wording to TrackLastPatronActivity description to tell users that it records SIP authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28467 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 17:01:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 15:01:10 +0000 Subject: [Koha-bugs] [Bug 28467] Add wording to TrackLastPatronActivity description to tell users that it records SIP authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28467 --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 121540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121540&action=edit Bug 28467: Update wording of TrackLastPatronActivity syspref To Test: 1 - look up TrackLastPatronActivity 2 - Read it, be dissatisfied with it 3 - apply patch, restart, reload page 4 - be happier with the new wording -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 17:02:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 15:02:37 +0000 Subject: [Koha-bugs] [Bug 28467] Add wording to TrackLastPatronActivity description to tell users that it records SIP authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28467 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |andrew at bywatersolutions.com |ity.org | --- Comment #3 from Andrew Fuerste-Henry --- I updated it to read "The first time each day that a patron either logs into the OPAC or connects to Koha via SIP, borrowers.last seen will update with the current date and time." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 17:04:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 15:04:48 +0000 Subject: [Koha-bugs] [Bug 28503] New: When ReservesControlBranch set to "patron's home library" and Hold policy set to "From home library" all holds are allowed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Bug ID: 28503 Summary: When ReservesControlBranch set to "patron's home library" and Hold policy set to "From home library" all holds are allowed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In C4::Reserves::CheckReserves we have: next if (($branchitemrule->{'holdallowed'} eq 'from_home_library') && ($branch ne $patron->branchcode)); Where $branch is the return of my $branch = GetReservesControlBranch( $item->unblessed, $patron->unblessed ); When ReservesControlBranch is set to "patron's home library" this boils down to: $patron->branchcode ne $patron->branchcode which will never be true In all other locations we ue ReservesControlBranch to fetch the rule, but always compare the item's homebranch to the patron's branchcode: 543 if ( $branchitemrule->{holdallowed} eq 'from_home_library' 544 && $borrower->{branchcode} ne $item->homebranch ) 545 { 546 return { status => 'cannotReserveFromOtherBranches' }; 547 } 1409 || $branchitemrule->{holdallowed} eq 'from_home_library' && $param->{patron}->branchcode ne $i->homebranch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 17:05:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 15:05:40 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 17:05:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 15:05:45 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121539|0 |1 is obsolete| | --- Comment #12 from Peter Vashchuk --- Created attachment 121541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121541&action=edit Bug 28489: Modify sessions.a_session from longtext to longblob This column contains serialized data, it should be a blob. And it fixes encoding issues. Test plan: 1. Apply patch and run updatedatabase 2. In $KOHA_CONF make sure that you have 0 3. Create 2 libraries: a. TESTÄ/Testä b. TEST✓/Test✓ 4. Go to the staff interface, change your library to Testä, then navigate to a few other pages, make sure there is no encoding problem with the library name in the top right corner 5. Do the same with Test✓ Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 17:25:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 15:25:56 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #13 from Andrew Nugged --- Yesterday I experimented with the same – I changed to "mediumblob" manually on my local test server to find a solution and it worked. What I can say that I found that Data::Dumper when converting Perl strings scalars acts "fuzzily" (better: weirdly), and if it meets real Unicode chars it stores them in the string in \xXX perl-form, so they stored in DB properly and restored properly, for example, I created branch "Čentervälly": it is stored in MySQL in a_session dumped in this way: 'branchname' => "\x{10c}enterv\x{e4}lly" so here it works and no error happens, but when it meets only single "ä" for example "Hämeenlinna" (and maybe few other characters like that which suspect can be represented in old ASCII latin-1 or how that fuzziness fuzzies :)...) chars, so it stores in such a way in MySQL longtext (broken): 'branchname' => 'H?meenlinna', because: see below hex dump of the blob, and when it saves to UTF-8-MySQL-field – it gets malformed, but yes, with blob it works: 'branchname' => 'Hämeenlinna', and when I looked inside blob in HEX, I see: 48 E4 6D 65 65 6E 6C 69 6E 6E 61 H‰meenlinna because it stores ä as E4 and it is then get returned "in the same way" into "ä" (seems). But oh that's silvertape everywhere :). This is just to say, that it weird but WORKS with blob, so – thanks Julian for the patch, and I say I support it, (yet I'd blame Data::Dumper "fuzziness" :) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 17:28:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 15:28:54 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch set to "patron's home library" and Hold policy set to "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 17:28:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 15:28:58 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch set to "patron's home library" and Hold policy set to "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 --- Comment #1 from Nick Clemens --- Created attachment 121542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121542&action=edit Bug 28503: Unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 17:29:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 15:29:01 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch set to "patron's home library" and Hold policy set to "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 --- Comment #2 from Nick Clemens --- Created attachment 121543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121543&action=edit Bug 28503: Compare item homebranch to patron branch when hold policy set to 'from_home_library' This fixes an issue in the way we calculate the check for hold policy 'from_home_library' Currently we change the comparison based on ReservesControlBranch, however, that should only control the rule we fetch, not how we compare When ReservesControlBranch is set to "patron's home library" we compare the patron's branch to the patron's branch, this is useless and means we pass the check for all branches all of the time We should instead compare the patron's branch to the item's branch, and only fetch the rule using ReservesControlBranch To test: 1 - Have a record with an item from library A and library B 2 - Set the 'Default checkout, hold and return policy'->Hold policy->From home library for all libraries and ensure you have no branch specific/itemtype specific rules set 3 - Attempt to place a hold on the record for a patron from library B 4 - Note that only the library B item is holdable - place a title level hold (do not choose an item) 5 - Check in the item from library A 6 - It fills the hold - This is incorrect - ignore the hold 7 - Apply patch 8 - Restart all the things 9 - Check in the item from library A 10 - No hold found 11 - Check in the item from library B 12 - Hold found, correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 17:29:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 15:29:51 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch set to "patron's home library" and Hold policy set to "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5800 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 17:29:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 15:29:51 +0000 Subject: [Koha-bugs] [Bug 5800] Hold Policy "home library only" incompatible with CircControl "patron home library" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5800 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28503 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 17:52:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 15:52:12 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch set to "patron's home library" and Hold policy set to "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 --- Comment #3 from Nick Clemens --- Created attachment 121544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121544&action=edit Bug 28503: Clarify what ReservesControlBranch controls -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 17:55:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 15:55:11 +0000 Subject: [Koha-bugs] [Bug 28504] New: Hold pickup library match (hold_fulfillment_policy) not enforced when filling holds if set to "patron's group" / 'patrongroup' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28504 Bug ID: 28504 Summary: Hold pickup library match (hold_fulfillment_policy) not enforced when filling holds if set to "patron's group" / 'patrongroup' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The case is simply not covered in the code In C4::Reserves::CheckReserves: 908 my $hold_fulfillment_policy = $branchitemrule->{hold_fulfillment_policy}; 909 next if ( ($hold_fulfillment_policy eq 'holdgroup') && (!$library->validate_hold_sibling({branchcode => $res->{branchcode}})) ); 910 next if ( ($hold_fulfillment_policy eq 'homebranch') && ($res->{branchcode} ne $item->$hold_fulfillment_policy) ); 911 next if ( ($hold_fulfillment_policy eq 'holdingbranch') && ($res->{branchcode} ne $item->$hold_fulfillment_policy) ); 912 next unless $item->can_be_transferred( { to => Koha::Libraries->find( $res->{branchcode} ) } ); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 18:00:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 16:00:23 +0000 Subject: [Koha-bugs] [Bug 28505] New: Hold fulfillment policy should not prevent selection of libraries when holds are being placed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28505 Bug ID: 28505 Summary: Hold fulfillment policy should not prevent selection of libraries when holds are being placed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In bug 15532 the idea of 'hold pickup library match' / hold_fulfillment_policy was that in system where items float or rotate a patron would be able to place a hold for delivery anywhere, but it would only fill when the item arrived at a branch that met the policy. Recent work on validating the pickup location when placing the hold seems to have broken the ability to place a hold for delivery that violates rules now, but may be valid in the future. When placing holds the pickup locations should not be limited by the hold fulfillment policy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 18:07:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 16:07:54 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #2 from Joonas Kylmälä --- Hmm, why was the column removed in bug 28490 if it is actually used as part of the non-patron guarantor infos? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 18:08:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 16:08:47 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #3 from Joonas Kylmälä --- I meant bug 26995 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 18:27:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 16:27:21 +0000 Subject: [Koha-bugs] [Bug 26561] Number on claims tab not showing when translated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26561 --- Comment #3 from Katrin Fischer --- Still broken in German in 20.11.06, trying some change in the po files in order to fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 18:31:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 16:31:14 +0000 Subject: [Koha-bugs] [Bug 26561] Number on claims tab not showing when translated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26561 --- Comment #4 from Katrin Fischer --- (In reply to Katrin Fischer from comment #3) > Still broken in German in 20.11.06, trying some change in the po files in > order to fix it. Tested the fix on 21.05 and looks ok there now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 18:35:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 16:35:27 +0000 Subject: [Koha-bugs] [Bug 27081] Notes missing from lost items report column configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27081 --- Comment #3 from Katrin Fischer --- This is ok in 21.05 as well, but in 20.11.06 the last entry in the pull down is 'not for loan', notes is missing there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 18:36:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 16:36:06 +0000 Subject: [Koha-bugs] [Bug 26939] Account payment_type in the cash register details page should use description instead of code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26939 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Account payment_type in the |Account payment_type in the |cash register details page |cash register details page |should use description |should use description |instead of code. |instead of code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 18:43:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 16:43:15 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 18:44:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 16:44:06 +0000 Subject: [Koha-bugs] [Bug 28500] Display before and after values when a biblio has been edited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28500 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Donna --- *** This bug has been marked as a duplicate of bug 14367 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 18:44:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 16:44:06 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 --- Comment #61 from Donna --- *** Bug 28500 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 19:02:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 17:02:54 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Summary|When ReservesControlBranch |When ReservesControlBranch |set to "patron's home |= "patron's home library" |library" and Hold policy |and Hold policy = "From |set to "From home library" |home library" all holds are |all holds are allowed |allowed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 19:05:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 17:05:08 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Joonas Kylmälä --- Bug 28490 should have not been merged, it removed actively used data that is only in borrowers.relationship, the non-patron guarantor info relationship. We need to revert it and make database update re-create the table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 19:17:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 17:17:37 +0000 Subject: [Koha-bugs] [Bug 28475] Searching all headings returns no results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 --- Comment #18 from Victor Grousset/tuxayo --- Ready to backport to the new oldoldstable (20.05.x). Applied locally until getting the push rights. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 19:31:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 17:31:12 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha at gmail. |joonas.kylmala at helsinki.fi |com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 19:47:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 17:47:29 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |katrin.fischer at bsz-bw.de, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 20:00:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 18:00:35 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 20:00:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 18:00:39 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121538|0 |1 is obsolete| | --- Comment #5 from Joonas Kylmälä --- Created attachment 121545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121545&action=edit Bug 28490: Revert "Bug 26995: Remove one remaining occurrence in moremember" This reverts commit c3b50e9e97e917090ce09283807168caaad3de4a. It was part of a patch set that removed actively used data and must be therefore reverted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 20:00:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 18:00:44 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #6 from Joonas Kylmälä --- Created attachment 121546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121546&action=edit Bug 28490: Revert "Bug 26995: Remove occurrences in sample_patrons.yml" This reverts commit 690b073478b04c7c801058b49f85275281c502d5. It was part of a patch set that removed actively used data and must be therefore reverted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 20:00:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 18:00:49 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #7 from Joonas Kylmälä --- Created attachment 121547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121547&action=edit Bug 28490: Revert "Bug 26995: Fix SQL syntax error on the about page" This reverts commit 1131bb687f14fef7b4cb5f3b194711e85f9227af. It was part of a patch set that removed actively used data and must be therefore reverted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 20:00:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 18:00:54 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #8 from Joonas Kylmälä --- Created attachment 121548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121548&action=edit Bug 28490: Revert "Bug 26995: Remove references to relationship column" This reverts commit 1cc8a77c287666ed878ea58f17216793f52ce224. It was part of a patch set that removed actively used data and must be therefore reverted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 20:00:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 18:00:58 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #9 from Joonas Kylmälä --- Created attachment 121549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121549&action=edit Bug 28490: Revert "Bug 26995: Drop column relationship from borrowers, deletedborrowers and borrower_modifications tables" This reverts commit ca0e7541ecdff13ada9ba8ffbd992c963959d30f. It was part of a patch set that removed actively used data and must be therefore reverted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 20:01:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 18:01:03 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #10 from Joonas Kylmälä --- Created attachment 121550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121550&action=edit Bug 28490: Comment out the relationship data removing DB update step These columns that were actively used to store non-patron guarantor relationship info were dropped incorrectly. In a later patch the relationship fields will be re-added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 20:01:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 18:01:07 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #11 from Joonas Kylmälä --- Created attachment 121551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121551&action=edit Bug 28490: Bring back accidentally deleted relationship columns These were in active use before and were accidentally deleted in Bug 26995. This restores those deleted relationship columns. To test: 1) verify the borrower_modifications, borrowers, deletedborrowers contain the column exactly like it was before after applying these patches by comparing to the old kohastructure.sql version -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 20:01:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 18:01:13 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #12 from Joonas Kylmälä --- Created attachment 121552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121552&action=edit [DO NOT PUSH] Bug 28490: Add DBIx schema changes for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 20:02:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 18:02:31 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #13 from Kyle M Hall --- (In reply to Joonas Kylmälä from comment #4) > Bug 28490 should have not been merged, it removed actively used data that is > only in borrowers.relationship, the non-patron guarantor info relationship. > We need to revert it and make database update re-create the table. I don't think that bug is really the culprit. This is actually a culmination of changes starting with the multiple guarantors development. The decision was made to leave the alternate contact as a 'non-koha patron' guarantor, but no provision was made to be able to apply a relationship to that field! I think the solution is not to revert bug 26995, but to develop an Alternate Contact relationship field ( e.g. 'altcontactrelationship' ) that uses the same set of relationship options available for patron-based guarantors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 20:04:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 18:04:48 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 20:10:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 18:10:52 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #14 from Joonas Kylmälä --- (In reply to Kyle M Hall from comment #13) > (In reply to Joonas Kylmälä from comment #4) > > Bug 28490 should have not been merged, it removed actively used data that is > > only in borrowers.relationship, the non-patron guarantor info relationship. > > We need to revert it and make database update re-create the table. > > I don't think that bug is really the culprit. This is actually a culmination > of changes starting with the multiple guarantors development. The decision > was made to leave the alternate contact as a 'non-koha patron' guarantor, > but no provision was made to be able to apply a relationship to that field! What decision? However regardless of any decision we absolutely cannot just remove completely a database column from koha which has been available in the GUI for many releases to fill in with data, there could be for sure people using that relationship column. Also what you say below about altcontactrelationships I think it is best we restore the columns with the same name "relationship" so that in case people have already upgraded to koha 21.05 and lost their data due to this error they are able to restore it from database dump easily after we fix this issue. Changing the column name now would make that process a lot more difficult. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 20:15:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 18:15:17 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #15 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #14) > (In reply to Kyle M Hall from comment #13) > > (In reply to Joonas Kylmälä from comment #4) > > > Bug 28490 should have not been merged, it removed actively used data that is > > > only in borrowers.relationship, the non-patron guarantor info relationship. > > > We need to revert it and make database update re-create the table. > > > > I don't think that bug is really the culprit. This is actually a culmination > > of changes starting with the multiple guarantors development. The decision > > was made to leave the alternate contact as a 'non-koha patron' guarantor, > > but no provision was made to be able to apply a relationship to that field! > > What decision? [...] ah, getting tired. I guess you meant the patches from 14570 where the new guarantor feature was introduced. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 21:01:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 19:01:44 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #25 from Victor Grousset/tuxayo --- error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 21:06:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 19:06:23 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #26 from Victor Grousset/tuxayo --- Test note: Here is how to generate barcodes by a plugin: > 952$p mapped to barcode.pl plugin in frameworks > C4::Context->preference("autoBarcode"); > set autobarcode and then clicking in the field fro new item should generate thanks kidclamp and cait :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 22:07:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 20:07:50 +0000 Subject: [Koha-bugs] [Bug 28452] Add managing librarian to transaction page (boraccount.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28452 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from George Williams (NEKLS) --- Tested on the ByWater sandboxes. Nice enhancement. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 22:14:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 20:14:15 +0000 Subject: [Koha-bugs] [Bug 28448] Record with too many items is not shown in results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28448 --- Comment #12 from George Williams (NEKLS) --- (In reply to David Cook from comment #9) > (In reply to George Williams (NEKLS) from comment #8) > > My experience is that this happens when the Marc record exceeds 9999k in > > size. Our solution was to separate the record into multiple records and put > > all of the items from one year on one record, all of the items from the next > > year on the second record and so on . . . > > > > It wasn't a problem with Koha. The problem was that we were exceeding the > > maximum size of a Marc record. > > > > George > > That's interesting. I thought that we'd overcome that limitation by > switching to MARCXML with Zebra but perhaps we didn't... It's possible that the 9999k limit has been fixed and I just never realized it because we trained everyone to limit the size of the records that might hit that limit. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 22:58:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 20:58:57 +0000 Subject: [Koha-bugs] [Bug 28496] Club holds form broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28496 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 22:59:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 20:59:05 +0000 Subject: [Koha-bugs] [Bug 28496] Club holds form broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28496 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121532|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 121553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121553&action=edit Bug 28496: Club holds pickup locations don't come from the API This patch fixes a issue that is generated by the fact different inputs were reusing the same id. To test: 1. Have a club with some enrollments 2. Make sure you have your circ rules to allow any library be a pickup location. 3. Search for a biblio 4. Try placing a club hold => FAIL: The dropdown only has the (currently) logged in library. 5. Apply this patch 6. Repeat 3-4 => SUCCESS: The dropdown has all the options Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 23:03:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 21:03:35 +0000 Subject: [Koha-bugs] [Bug 28496] Club holds form broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28496 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This fixes the libraries release notes| |shown in the 'Pickup at' | |dropdown list when placing | |a club hold so that it | |shows all libraries, | |instead of just the | |currently logged in | |library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 23:35:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 21:35:24 +0000 Subject: [Koha-bugs] [Bug 21286] Advanced search for Corporate-name creates Zebra errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21286 --- Comment #8 from David Nind --- > Try disabling the syspref 'QueryAutoTruncate' - that seems to be a key to > triggering this Thanks Nick! That worked, sign off on the way.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 23:36:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 21:36:16 +0000 Subject: [Koha-bugs] [Bug 21286] Advanced search for Corporate-name creates Zebra errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21286 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 23:36:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 21:36:21 +0000 Subject: [Koha-bugs] [Bug 21286] Advanced search for Corporate-name creates Zebra errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21286 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121326|0 |1 is obsolete| | --- Comment #9 from David Nind --- Created attachment 121554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121554&action=edit Bug 21286: Add Corporate-name as phrase to zebra indexes When using Zebra for searching, Koha performs a number of searches in order to improve relevancy. This means that even for 'wordlist' search, we perform a phrase search. When selecting 'Corporate-name' as an index, this expansion of the search causes errors and fails the search We can fix this for 'Corporate-name' searches by adding a phrase index To test: 1 - Edit koha-conf.xml and uncomment the zebra debug line and add 'request' to the list 2 - Restart all 3 - tail -f /var/log/koha/kohadev/zebra-output.log 4 - Edit a record to add a 110 field e.g. 'House plants' 5 - Enable syspref IntranetCatalogSearchPulldown 6 - Search for 'Corporate name' and term 'House plants' 7 - No results 8 - View the log, see 'ERROR' and full search terms listed 9 - Apply patch 10 - copy the zebra files to the production instance: cp etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml cp etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl 11 - restart all 12 - rebuild: sudo koha-rebuild-zebra -v -f kohadev 13 - Repeat search 14 - Success! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 2 23:56:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Jun 2021 21:56:46 +0000 Subject: [Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #38 from David Nind --- (In reply to Ivan Dziuba from comment #33) .. > I checked it and it works :). Do you use Koha 21.05? Thanks. .. Hi Ivan. I'm using master - I tried again and still get the same error for the CSS follow-up patch: .. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27113: (follow-up) Move new CSS to main SCSS files error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/css/elasticsearch/autocomplete.css). error: could not build fake ancestor Patch failed at 0001 Bug 27113: (follow-up) Move new CSS to main SCSS files .. I can get the patches to apply if I use interactive, comment out the CSS follow-up patch, then apply again using interactive and then just apply the CSS follow-up patch. I'm assuming the error is because the follow-up CSS is being applied first, but what it is changing doesn't exist yet as it is one of the later patches. I don't know enough about patches to fix this up, but will try and test with what I have. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 02:50:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 00:50:34 +0000 Subject: [Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 02:50:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 00:50:36 +0000 Subject: [Koha-bugs] [Bug 28506] New: Editing purchase suggestion with no library or item type does not save edits Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28506 Bug ID: 28506 Summary: Editing purchase suggestion with no library or item type does not save edits Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org To recreate: 1. Enter a purchase suggestion in the staff client with just a title - no library or document type 2. Edit the purchase suggestion and add publisher or ISBN, etc and save. 3. Notice that the changes are not saved. 4. Edit the record to add publisher and document type and save. 5. On the purchase suggestion summary screen, see that the item type was added, but publisher was not. 6. Edit the purchase suggestion again and see that the document/item type does not show. 7. Add publisher and select a library and save. 8. All data is updated, but the purchase suggestion gets moved to Status Unknown. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 02:50:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 00:50:43 +0000 Subject: [Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120140|0 |1 is obsolete| | --- Comment #39 from David Nind --- Created attachment 121555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121555&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he start search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good for and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 02:50:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 00:50:50 +0000 Subject: [Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120806|0 |1 is obsolete| | --- Comment #40 from David Nind --- Created attachment 121556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121556&action=edit Bug 27113: (follow-up) QA Tests Bug 27113: (follow-up) QA Tests (2) Bug 27113: (follow-up) Fixup warnings. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good for and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 02:50:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 00:50:57 +0000 Subject: [Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121498|0 |1 is obsolete| | --- Comment #41 from David Nind --- Created attachment 121557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121557&action=edit Bug 27113: (follow-up) Correction with Session I have changed CGI::Session->new() from CGI::Session->load() for use session. This condition - 'CGI::Session->load() or die CGI::Session->errstr();' I am not sure that was good idea to use 'die' in this condition...What do you think? Thanks! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 02:51:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 00:51:04 +0000 Subject: [Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120109|0 |1 is obsolete| | --- Comment #42 from David Nind --- Created attachment 121558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121558&action=edit Bug 27113: (follow-up) Move new CSS to main SCSS files This patch removes the separate CSS files added for the autocomplete feature and puts them into the "main" SCSS files. I think a separate file isn't necessary because the amount of CSS it adds is so small. I've also tweaked the style of the autocomplete menu shown when you use the arrow keys to navigate through the autocomplete choices. I think the previous white-on-light-green didn't have enough contrast. To test you must rebuild the OPAC and staff client CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client Follow the previous test plan, being careful to observe how it works when the autocomplete menu has been triggered and you use the arrow keys to navigate through the results. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 02:55:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 00:55:36 +0000 Subject: [Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #43 from David Nind --- I finally got this to work for me, and it is a really nice feature. Nice work! I've signed off, but these are my suggestions for the wording for the new system preferences - the QA Team will probably comment on this is as well, so you may as well get ahead of them!: 1. IntranetAutocompleteElasticSearch: change system preference name to StaffInterfaceAutocompleteElasticsearch - We are using 'staff interface' now, instead of 'intranet' - not sure what the protocol is for system preference names, but for new system preferences we should probably start using StaffInterface; Elasticsearch doesn't have a capital S (see for example the SearchEngine system preference) 2. Wording for IntranetAutocompleteElasticSearch: . Currently: Don't show/Show looking terms based on a provided text by using an ElasticSearch for Intranet. . Suggested: Don't show/Show search suggestions in the staff interface when using Elasticsearch. 3. Wording for OPACAutocompleteElasticSearch: . Currently: Don't show/Show looking terms based on a provided text by using an ElasticSearch for OPAC. . Change to: Don't show/Show search suggestions in the OPAC when using Elasticsearch. Other testing notes (using koha-testing-docker): . Package command to rebuild the index: koha-elasticsearch -d --rebuild -a -b kohadev . Needed to change .env file as a result of recent commits to koha-testing-docker for Elasticsearch (compared default with custom .env file and added new variables) . As indicated earlier, had to apply patch interactively: 1st excluding CSS patch, then again to include CSS patch . Rebuild CSS as per CSS patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 02:57:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 00:57:51 +0000 Subject: [Koha-bugs] [Bug 24539] Build generic authentication module interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24539 --- Comment #21 from David Cook --- The more I think about this... the more I still like it. A Koha Plugin could create a session independently without checkauth(), and then could still leverage the logout hook. I'm still thinking a minimum session created via a Koha::Session object is probably a good idea though... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 03:01:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 01:01:08 +0000 Subject: [Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds release notes| |autocomplete suggestions | |for searches in the OPAC | |and staff interface, | |including the advanced | |search forms (when using | |Elasticsearch). | | | |This is | |enabled using two new | |system preferences: | |- | |StaffInterfaceAutocompleteE | |lasticsearch | |- | |OPACAutocompleteElasticSear | |ch | | | |Note: For this to work | |the search index needs | |rebuilding. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 03:25:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 01:25:03 +0000 Subject: [Koha-bugs] [Bug 28507] New: Create Koha::Session wrapper to create consistent sessions throughout Koha Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28507 Bug ID: 28507 Summary: Create Koha::Session wrapper to create consistent sessions throughout Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org At the moment, there are a couple different places where authenticated sessions get created. One is checkauth() and another is check_api_auth(). I would also like to create consistently structured authenticated sessions from Koha Plugins. There should be a standard API for creating and fetching sessions. I propose a Koha::Session wrapper. It will define Koha's standard session key set and have some automatic population for things like 'ip' and 'lasttime'. There will also be a method for setting the C4::Context->userenv, which is something that gets done repeatedly in checkauth(), check_api_auth(), check_cookie_auth(), and other less relevant places (like checkpw_internal which is bizarre). I think that this is a reasonable step forward as we add AuthN and AuthZ to things like Koha plugins and Mojolicious controllers. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 03:25:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 01:25:18 +0000 Subject: [Koha-bugs] [Bug 28507] Create Koha::Session wrapper to create consistent sessions throughout Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28507 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28325 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 03:25:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 01:25:18 +0000 Subject: [Koha-bugs] [Bug 28325] Build Mojolicious controller replacement for tools-home.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28325 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28507 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 03:25:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 01:25:33 +0000 Subject: [Koha-bugs] [Bug 28507] Create Koha::Session wrapper to create consistent sessions throughout Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28507 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17427 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 03:25:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 01:25:33 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28507 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 03:28:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 01:28:28 +0000 Subject: [Koha-bugs] [Bug 28507] Create Koha::Session wrapper to create consistent sessions throughout Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28507 --- Comment #1 from David Cook --- For instance: Koha::Session->create_user_session({ }); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 03:38:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 01:38:19 +0000 Subject: [Koha-bugs] [Bug 28507] Create Koha::Session wrapper to create consistent sessions throughout Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28507 --- Comment #2 from David Cook --- For instance: Koha::Session->set_user_session({ user => $patron, session => $session, extensions => { desk_id => $desk_id, shibboleth => $shibboleth, }, }); We'd take both the session object and data to put into it. The $session object would have 'ip' and 'lasttime' set automatically. Likewise: Koha::Session->set_userenv({ session => $session, extensions => { id => $userid, } }); The above would use session data or let you override particular key/value pairs using extensions. Although personally I find the concept of C4::Context->userenv to be unnecessary. You just need sessions, but Koha has a dependency on C4::Context->userenv... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 03:38:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 01:38:51 +0000 Subject: [Koha-bugs] [Bug 28507] Create Koha::Session wrapper to create consistent sessions throughout Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28507 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24539 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 03:38:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 01:38:51 +0000 Subject: [Koha-bugs] [Bug 24539] Build generic authentication module interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24539 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28507 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 03:39:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 01:39:04 +0000 Subject: [Koha-bugs] [Bug 28507] Create Koha::Session wrapper to create consistent sessions throughout Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28507 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 03:42:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 01:42:45 +0000 Subject: [Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #44 from David Cook --- I am tempted to mark this as Failed QA, since I'm pretty sure the session handling doesn't work as intended (I think it's saving the session data in a file rather than in the database), but I haven't actually tested it, so leaving it as is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 04:04:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 02:04:17 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #14 from David Cook --- /me still thinks we should've stuck with YAML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 04:12:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 02:12:34 +0000 Subject: [Koha-bugs] [Bug 11083] Authority Search Result Display should be XSLT Driven In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- I wonder sometimes if we should be getting away from using the XSLTs as they seem slow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 04:20:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 02:20:30 +0000 Subject: [Koha-bugs] [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 --- Comment #25 from David Cook --- Still working on this one, Lucas? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 04:36:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 02:36:51 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #344 from Aleisha Amohia --- I agree that hold groups need to be counted as one hold, which probably means modifying existing hold count code to always work like 'count_grouped', rather than adding the new count_grouped subroutine. I think for now there can be no limit to how many holds can be made in one hold group because the borrower will still only get hold out of that group fulfilled, however that can of course be discussed and changed in the future. I'll just work on getting the functionality of placing, fulfilling, and counting hold groups for now. Will also remove the OPAC work acknowledging that that's being tackled in Bug 17217. Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 04:51:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 02:51:40 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #43 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121559&action=edit Bug 27631: (follow-up) circ/branchtransfers.tt Changed file to have one

tag showing that describes the page, rather than the

around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to circ/branchtransfers and check that it has an obvious and descriptive heading 4) Ensure that the heading is

Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 04:56:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 02:56:29 +0000 Subject: [Koha-bugs] [Bug 28508] New: Use "Invoice number" instead of "Invoice no" on the invoice search filter Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28508 Bug ID: 28508 Summary: Use "Invoice number" instead of "Invoice no" on the invoice search filter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org There is not much benefit to using "no" instead of "number", and it makes it less translateable and understandable. This should be fixed in three places that I can see: 1. the search filter form 2. the results table column heading 3. when there are no results, there is text that says 'Search was:' and a label that says 'Invoice no.' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 05:08:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 03:08:45 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #28 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121560&action=edit Bug 27741: circ folder Bug 27631 corrected the

tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

are in the correct order and hierarchy Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 08:06:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 06:06:20 +0000 Subject: [Koha-bugs] [Bug 27463] OAI-PMH date handling in ListBase.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27463 --- Comment #14 from Rudolf Byker --- Ere, I don't see how Bug 27463 is related to this one? The patch is one line, and does not affect the OAI code. Did you mistype the bug number? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 08:09:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 06:09:28 +0000 Subject: [Koha-bugs] [Bug 27463] OAI-PMH date handling in ListBase.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27463 --- Comment #15 from Rudolf Byker --- Sorry, now I copy-pasted the wrong code. Let met try again ... I don't see how Bug 27548 is related to this one? The patch is one line, and does not affect the OAI code. Did you mistype the bug number? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 08:56:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 06:56:14 +0000 Subject: [Koha-bugs] [Bug 24589] Add plugin hook addbiblio_check_record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24589 --- Comment #8 from David Cook --- Actually, it might be nicer just to have a plugin hook that is fired when a bib is created, modified, or deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 08:56:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 06:56:49 +0000 Subject: [Koha-bugs] [Bug 24589] Add plugin hook addbiblio_check_record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24589 --- Comment #9 from David Cook --- (In reply to David Cook from comment #8) > Actually, it might be nicer just to have a plugin hook that is fired when a > bib is created, modified, or deleted. Oh never mind me. That is Bug 22709. I'll see myself out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 09:39:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 07:39:02 +0000 Subject: [Koha-bugs] [Bug 24539] Build generic authentication module interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24539 --- Comment #22 from mark.jaroski at gmail.com --- I don't know enough about Koha to comment on internal workings, but wouldn't you always want a session in most authentication situations? I guess in the Shibboleth scenario you don't need a session because every request comes with the server variable or header, but for things like OpenID-Connect you don't want to do the handshake for every page load. Again, maybe I don't understand how Koha handles sessions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 09:41:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 07:41:34 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |joonas.kylmala at helsinki.fi Severity|critical |major --- Comment #4 from Jonathan Druart --- Lowering severity, if I understand correctly it's an old issue (not a recent regression). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 09:45:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 07:45:18 +0000 Subject: [Koha-bugs] [Bug 28420] Allow login via AzureAD OpenID-Connect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28420 --- Comment #17 from mark.jaroski at gmail.com --- Hi David, I think a lot of the code that you see in the new AzureAD "oidc" code is just left over from the old Google "oidc" code. Remember: my goal was to quickly get something that works and is reasonably secure without making any major changes to existing code. So the patch is purely additive. Basically, I made a copy of the googleopenidauth file and changed a few things to make it work with AzureAD. This also gave me better than even odds of adhering to the coding style, etc. However, I have also brought along whatever problems were there in the old code. I'll post a diff here so you can see which parts are from me and which parts were already there. In any case, this is probably not the *right* way to do it. But it's fast, and probably does no real harm since whatever problems it has are the same as the ones with the google version. Make sense? -mark -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 09:52:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 07:52:21 +0000 Subject: [Koha-bugs] [Bug 28509] New: Koha/Acquisition/Orders.t is failing (randomly?) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 Bug ID: 28509 Summary: Koha/Acquisition/Orders.t is failing (randomly?) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org 03:25:39 koha_1 | # Failed test 'The 2 orders are returned' 03:25:39 koha_1 | # at t/db_dependent/Koha/Acquisition/Orders.t line 152. 03:25:39 koha_1 | # Structures begin differing at: 03:25:39 koha_1 | # $got->[0] = '10' 03:25:39 koha_1 | # $expected->[0] = '9' 03:25:39 koha_1 | # Looks like you failed 1 test of 4. 03:25:39 koha_1 | 03:25:39 koha_1 | # Failed test 'filter_by_id_including_transfers() tests' 03:25:39 koha_1 | # at t/db_dependent/Koha/Acquisition/Orders.t line 160. 03:25:39 koha_1 | # Looks like you failed 1 test of 2. 03:25:39 koha_1 | [01:24:50] t/db_dependent/Koha/Acquisition/Orders.t Koha_21.05_D10 run 6 on Docker_5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 09:52:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 07:52:36 +0000 Subject: [Koha-bugs] [Bug 28509] Koha/Acquisition/Orders.t is failing (randomly?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 09:52:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 07:52:36 +0000 Subject: [Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28509 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 [Bug 28509] Koha/Acquisition/Orders.t is failing (randomly?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 10:16:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 08:16:20 +0000 Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #18 from Jonathan Druart --- Existing notice templates still need to be adjusted. If we cannot adjust them (because modified or translated) we should add a warning if "borrowers.password" or "patron.password" exists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 10:20:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 08:20:29 +0000 Subject: [Koha-bugs] [Bug 28316] Cannot search with square brackets [] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 10:25:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 08:25:20 +0000 Subject: [Koha-bugs] [Bug 28316] Cannot search with square brackets [] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121561|0 |1 is obsolete| | --- Comment #14 from Peter Vashchuk --- Created attachment 121562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121562&action=edit Bug 28316: different QueryRegexEscapeOptions' values work as expected This patch ensures that the behavior with QueryRegexEscapeOptions set to values other than "Escape" still work as expected. It does so by storing the contents of regexes before escaping square and curly brackets and then restores the contents of regexes back to how it was before. Also this patch covers this with tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 10:20:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 08:20:35 +0000 Subject: [Koha-bugs] [Bug 28316] Cannot search with square brackets [] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #13 from Peter Vashchuk --- Created attachment 121561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121561&action=edit Bug 28316: different QueryRegexEscapeOptions' values work as expected This patch ensures that the behavior with QueryRegexEscapeOptions set to values other than "Escape" still work as expected. It does so by storing the contents of regexes before escaping square and curly brackets and then restores the contents of regexes back to how it was before. Also this patch covers this with tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 10:35:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 08:35:36 +0000 Subject: [Koha-bugs] [Bug 28496] Club holds form broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28496 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Keywords| |rel_21_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 11:18:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 09:18:27 +0000 Subject: [Koha-bugs] [Bug 27463] OAI-PMH date handling in ListBase.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27463 --- Comment #16 from Ere Maijala --- Oops, mistyped, it's 27584 (linked in "Depends on" field). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 11:22:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 09:22:51 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Andrew Nugged --- Julian, thanks for patch, can you also add DB changes to kohastructure.sql as well, not just atomic update, so we can then again Sign-off this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 11:27:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 09:27:03 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #16 from Julian Maurice --- (In reply to Andrew Nugged from comment #15) > Julian, thanks for patch, > > can you also add DB changes to kohastructure.sql as well, not just atomic > update, > > so we can then again Sign-off this? Ah yes I forgot that. I'll write the patch ASAP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 11:30:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 09:30:15 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121541|0 |1 is obsolete| | --- Comment #17 from Julian Maurice --- Created attachment 121563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121563&action=edit Bug 28489: Modify sessions.a_session from longtext to longblob This patch modifies kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 11:31:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 09:31:04 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121563|0 |1 is obsolete| | --- Comment #18 from Julian Maurice --- Created attachment 121564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121564&action=edit Bug 28489: Modify sessions.a_session from longtext to longblob This column contains serialized data, it should be a blob. And it fixes encoding issues. Test plan: 1. Apply patch and run updatedatabase 2. In $KOHA_CONF make sure that you have 0 3. Create 2 libraries: a. TESTÄ/Testä b. TEST✓/Test✓ 4. Go to the staff interface, change your library to Testä, then navigate to a few other pages, make sure there is no encoding problem with the library name in the top right corner 5. Do the same with Test✓ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 11:31:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 09:31:08 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #19 from Julian Maurice --- Created attachment 121565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121565&action=edit Bug 28489: Modify sessions.a_session from longtext to longblob (kohastructure.sql) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 11:31:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 09:31:33 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 11:36:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 09:36:09 +0000 Subject: [Koha-bugs] [Bug 28496] Club holds form broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28496 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 11:42:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 09:42:00 +0000 Subject: [Koha-bugs] [Bug 28496] Club holds form broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28496 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 11:42:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 09:42:04 +0000 Subject: [Koha-bugs] [Bug 28496] Club holds form broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28496 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121553|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 121566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121566&action=edit Bug 28496: Club holds pickup locations don't come from the API This patch fixes a issue that is generated by the fact different inputs were reusing the same id. To test: 1. Have a club with some enrollments 2. Make sure you have your circ rules to allow any library be a pickup location. 3. Search for a biblio 4. Try placing a club hold => FAIL: The dropdown only has the (currently) logged in library. 5. Apply this patch 6. Repeat 3-4 => SUCCESS: The dropdown has all the options Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 11:42:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 09:42:41 +0000 Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ElasticSearch: Autocomplete |Elasticsearch: Autocomplete |in input search |in search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 11:46:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 09:46:15 +0000 Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #45 from Katrin Fischer --- As QA: I really like David's suggestions for the rephrasing. I think it makes the use much more clear. But before spending time on these, we probably need to sort out the other requirements/comments. Sessions: * David, can you be a bit more precise about what you think doesn't work? * Tomas, can you help with what you imagined and maybe the sessions bit? Does this need to be fixed here or could it be a follow-up? (In reply to Tomás Cohen Arazi from comment #34) > I agree with Fridolin: we should think of adding API routes for this. There > should be a privileged route, and an unprivileged route. > You shouldn't worry about sessions and all. Just add the required > permissions to interact with the routes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 11:53:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 09:53:34 +0000 Subject: [Koha-bugs] [Bug 21286] Advanced search for Corporate-name creates Zebra errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21286 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 11:56:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 09:56:09 +0000 Subject: [Koha-bugs] [Bug 21286] Advanced search for Corporate-name creates Zebra errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21286 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 11:56:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 09:56:14 +0000 Subject: [Koha-bugs] [Bug 21286] Advanced search for Corporate-name creates Zebra errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21286 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121554|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 121567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121567&action=edit Bug 21286: Add Corporate-name as phrase to zebra indexes When using Zebra for searching, Koha performs a number of searches in order to improve relevancy. This means that even for 'wordlist' search, we perform a phrase search. When selecting 'Corporate-name' as an index, this expansion of the search causes errors and fails the search We can fix this for 'Corporate-name' searches by adding a phrase index To test: 1 - Edit koha-conf.xml and uncomment the zebra debug line and add 'request' to the list 2 - Restart all 3 - tail -f /var/log/koha/kohadev/zebra-output.log 4 - Edit a record to add a 110 field e.g. 'House plants' 5 - Enable syspref IntranetCatalogSearchPulldown 6 - Search for 'Corporate name' and term 'House plants' 7 - No results 8 - View the log, see 'ERROR' and full search terms listed 9 - Apply patch 10 - copy the zebra files to the production instance: cp etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml cp etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl 11 - restart all 12 - rebuild: sudo koha-rebuild-zebra -v -f kohadev 13 - Repeat search 14 - Success! Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 11:56:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 09:56:49 +0000 Subject: [Koha-bugs] [Bug 28452] Add managing librarian to transaction page (boraccount.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28452 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:09:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:09:26 +0000 Subject: [Koha-bugs] [Bug 28452] Add managing librarian to transaction page (boraccount.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28452 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:09:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:09:30 +0000 Subject: [Koha-bugs] [Bug 28452] Add managing librarian to transaction page (boraccount.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28452 --- Comment #4 from Katrin Fischer --- Created attachment 121568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121568&action=edit Bug 28452: Add Managed by column to boraccount.tt To test: -Do some transactions on boraccount.tt. Payments, write-offs.. -Check the transaction tab at boraccount.tt -No info about the librian who did this action -Apply patch -Try doing some more transactions -You should now see the first and last name of the librarian who accepted the payments/did the transactions Signed-off-by: George Williams (NEKLS) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:09:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:09:34 +0000 Subject: [Koha-bugs] [Bug 28452] Add managing librarian to transaction page (boraccount.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28452 --- Comment #5 from Katrin Fischer --- Created attachment 121569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121569&action=edit Bug 28452: (QA follow-up) Remove comma when staff user has on firstname Also removed an old outdated comment line - there are no longer any hardcoded $ signs in the template. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:11:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:11:07 +0000 Subject: [Koha-bugs] [Bug 28452] Add managing librarian to transaction page (boraccount.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28452 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121391|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:15:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:15:50 +0000 Subject: [Koha-bugs] [Bug 28452] Add managing librarian to transaction page (boraccount.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28452 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #6 from Katrin Fischer --- Sorry Lucas, after I thought this was working, there are issues: - Have you tested with another user, not the one who did the transaction? I think using the logged in user here will always make the same name appear instead of the actual user who did the transaction. You need to access the information for the line from the database. - patron-title.inc must be used for displaying the name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:19:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:19:22 +0000 Subject: [Koha-bugs] [Bug 28452] Add managing librarian to transaction page (boraccount.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28452 --- Comment #7 from Katrin Fischer --- Confirmed, the table will always show the logged in user for ALL transactions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:23:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:23:25 +0000 Subject: [Koha-bugs] [Bug 25900] QueryWeightFields creates unnecessary whitespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:26:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:26:03 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:26:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:26:07 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121564|0 |1 is obsolete| | Attachment #121565|0 |1 is obsolete| | --- Comment #20 from Peter Vashchuk --- Created attachment 121570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121570&action=edit Bug 28489: Modify sessions.a_session from longtext to longblob This column contains serialized data, it should be a blob. And it fixes encoding issues. Test plan: 1. Apply patch and run updatedatabase 2. In $KOHA_CONF make sure that you have 0 3. Create 2 libraries: a. TESTÄ/Testä b. TEST✓/Test✓ 4. Go to the staff interface, change your library to Testä, then navigate to a few other pages, make sure there is no encoding problem with the library name in the top right corner 5. Do the same with Test✓ Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:26:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:26:11 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #21 from Peter Vashchuk --- Created attachment 121571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121571&action=edit Bug 28489: Modify sessions.a_session from longtext to longblob (kohastructure.sql) Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:27:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:27:57 +0000 Subject: [Koha-bugs] [Bug 25900] QueryWeightFields creates unnecessary whitespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:28:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:28:03 +0000 Subject: [Koha-bugs] [Bug 25900] QueryWeightFields creates unnecessary whitespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121529|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer --- Created attachment 121572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121572&action=edit Bug 25900: trim spaces in search with Zebra and QueryWeightFields Search with Zebra and system preference QueryWeightFields on builds a query with surrounding double quotes : q=tree => q="tree". Therefore existing double quotes are replaced by a space : q="tree" => q=" tree ". Patch corrects by adding trim on operand after transforming quotes into spaces. Test plan : 1) Use Zebra searchengine and enable system preference QueryWeightFields 2) Go to advanced search 3) Search on two words from a title, surrounded by double quotes. Like "Order of the Phoenix" 4) Check you get same results with an without patch Signed-off-by: Petro Vashchuk Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:29:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:29:04 +0000 Subject: [Koha-bugs] [Bug 25900] QueryWeightFields creates unnecessary whitespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900 --- Comment #22 from Katrin Fischer --- I believe this change makes sense and is harmless. As this is a change to Search.pm we should probably have a unit test verifying it. But I am not sure how hard/easy it would be to test. Leaving final decision to RM. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:30:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:30:21 +0000 Subject: [Koha-bugs] [Bug 28280] Item types configuration page doesn't use Price filter for default replacement cost and processing fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28280 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|itemtypes page |Item types configuration |defaultreplacecost and |page doesn't use Price |processfee aren't using |filter for default |Price filter. |replacement cost and | |processing fee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:33:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:33:08 +0000 Subject: [Koha-bugs] [Bug 28280] Item types configuration page doesn't use Price filter for default replacement cost and processing fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28280 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:33:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:33:12 +0000 Subject: [Koha-bugs] [Bug 28280] Item types configuration page doesn't use Price filter for default replacement cost and processing fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28280 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121502|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 121573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121573&action=edit Bug 28280: itemtype page, add price formatting To Test: 1- create an item type with a 'Default replacement cost' and a 'Processing fee (when lost)' 2- numbers are displayed with 6 decimals. 4- apply patch 5- numbers are displayed with 2 decimals. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:35:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:35:11 +0000 Subject: [Koha-bugs] [Bug 28427] Terminology: Shelf should be list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28427 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:35:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:35:15 +0000 Subject: [Koha-bugs] [Bug 28427] Terminology: Shelf should be list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28427 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121500|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 121574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121574&action=edit Bug 28427: Terminology: Shelf should be list This patch corrects the title element on the download list page in the staff interface. The affected page should never be seen by the user because other error-handling should take precedence. In order to see it you have to set up such an error: - Log into the staff client as a user with existing lists. - Open the Lists page. - Open one of your lists in a new tab. - In the original tab, delete the list you opened. - In the tab showing the contents of the list, click the "Download" menu button and select an option. - You should be redirected to a page with an error message at the top. - The title of this page should be correct: "Download list." Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:36:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:36:37 +0000 Subject: [Koha-bugs] [Bug 28428] Capitalization: Password Updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28428 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:36:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:36:42 +0000 Subject: [Koha-bugs] [Bug 28428] Capitalization: Password Updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28428 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121499|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 121575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121575&action=edit Bug 28428: Capitalization: Password Updated This patch corrects the case of two headings on the "Change password" page in the staff interface. As far as I can tell these strings are never seen because the page redirects to the patron detail page instead of redisplaying after a new password or username is submitted. A visual inspection of the patch may be the only test. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:42:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:42:11 +0000 Subject: [Koha-bugs] [Bug 28467] Add wording to TrackLastPatronActivity description to tell users that it records SIP authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28467 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:42:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:42:16 +0000 Subject: [Koha-bugs] [Bug 28467] Add wording to TrackLastPatronActivity description to tell users that it records SIP authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28467 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121540|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 121576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121576&action=edit Bug 28467: Update wording of TrackLastPatronActivity syspref To Test: 1 - look up TrackLastPatronActivity 2 - Read it, be dissatisfied with it 3 - apply patch, restart, reload page 4 - be happier with the new wording Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:44:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:44:42 +0000 Subject: [Koha-bugs] [Bug 28510] New: Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510 Bug ID: 28510 Summary: Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Right now we skip closed branch's items as we iterate over all items looking for ones to fill a hold. If HoldsQueueSkipClosed is enabled, no items held be a closed library can be targeted, so it would be more efficient if we never selected the items from those branches to begin with. This is how the holds queue works if we are not using the transport cost matrix, so we should make it work the same way if we *are* using the matrix. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:44:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:44:47 +0000 Subject: [Koha-bugs] [Bug 28510] Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:46:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:46:03 +0000 Subject: [Koha-bugs] [Bug 28353] Regression: Batch item deletion no longer shows which items were not removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:54:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:54:47 +0000 Subject: [Koha-bugs] [Bug 28510] Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:54:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:54:51 +0000 Subject: [Koha-bugs] [Bug 28510] Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510 --- Comment #1 from Kyle M Hall --- Created attachment 121578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121578&action=edit Bug 28510: Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled Right now we skip closed branch's items as we iterate over all items looking for ones to fill a hold. If HoldsQueueSkipClosed is enabled, no items held be a closed library can be targeted, so it would be more efficient if we never selected the items from those branches to begin with. This is how the holds queue works if we are not using the transport cost matrix, so we should make it work the same way if we *are* using the matrix. Test Plan: 1) Apply this patch 2) prove prove t/db_dependent/HoldsQueue.t 3) All tests should continue to pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:46:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:46:08 +0000 Subject: [Koha-bugs] [Bug 28353] Regression: Batch item deletion no longer shows which items were not removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121504|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 121577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121577&action=edit Bug 28353: Display a list of items that cannot be deleted We used to display a list of items that cannot be deleted (checked out or on hold) on the Batch item deletion tool. With bug 8132 we improve the error handling, but the info is spread in the table. This patch adds, at the top of the page, the list of items (barcode) that cannot be removed. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:57:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:57:29 +0000 Subject: [Koha-bugs] [Bug 25900] QueryWeightFields creates unnecessary whitespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #23 from Katrin Fischer --- Please add a unit test! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:59:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:59:01 +0000 Subject: [Koha-bugs] [Bug 28510] Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510 --- Comment #2 from Kyle M Hall --- Created attachment 121579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121579&action=edit Bug 28510: Remove marking of closed branches as 'disable_transfer' We no longer need to act as if closed branches were marked as disable_transfer. This allows us to clean up a nice bit of code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 12:52:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 10:52:52 +0000 Subject: [Koha-bugs] [Bug 26316] Add the option to un-lost an item on claim return resolution In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26316 pierre.genty at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:02:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:02:48 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 --- Comment #2 from Jonathan Druart --- Created attachment 121580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121580&action=edit Bug 28487: Remove getletter -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:04:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:04:18 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26420 Version|20.11 |master CC| |jonathan.druart+koha at gmail. | |com, | |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Jonathan Druart --- This patch goes way to far but it's the goal we want to reach to prevent future regressions like that. I will try and see if I can come up with a simpler fix. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26420 [Bug 26420] Overdue notices script does not care about borrower's language, always takes default template -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:04:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:04:18 +0000 Subject: [Koha-bugs] [Bug 26420] Overdue notices script does not care about borrower's language, always takes default template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26420 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28487 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 [Bug 28487] Overdue_notices does not fall back to default language -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:06:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:06:51 +0000 Subject: [Koha-bugs] [Bug 28467] Add wording to TrackLastPatronActivity description to tell users that it records SIP authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28467 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:06:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:06:55 +0000 Subject: [Koha-bugs] [Bug 28467] Add wording to TrackLastPatronActivity description to tell users that it records SIP authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28467 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121576|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 121581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121581&action=edit Bug 28467: Update wording of TrackLastPatronActivity syspref To Test: 1 - look up TrackLastPatronActivity 2 - Read it, be dissatisfied with it 3 - apply patch, restart, reload page 4 - be happier with the new wording Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:08:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:08:36 +0000 Subject: [Koha-bugs] [Bug 28467] Add wording to TrackLastPatronActivity description to tell users that it records SIP authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28467 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121581|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 121582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121582&action=edit Bug 28467: Update wording of TrackLastPatronActivity syspref To Test: 1 - look up TrackLastPatronActivity 2 - Read it, be dissatisfied with it 3 - apply patch, restart, reload page 4 - be happier with the new wording Signed-off-by: David Nind Signed-off-by: Katrin Fischer Current status: Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:08:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:08:40 +0000 Subject: [Koha-bugs] [Bug 28467] Add wording to TrackLastPatronActivity description to tell users that it records SIP authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28467 --- Comment #7 from Katrin Fischer --- Created attachment 121583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121583&action=edit Bug 28467: (QA follow-up) Remove errorenous space in borrowers.lastseen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:09:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:09:22 +0000 Subject: [Koha-bugs] [Bug 28467] Add wording to TrackLastPatronActivity description to tell users that it records SIP authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28467 --- Comment #8 from Katrin Fischer --- Is there a reason why we only update that info once a day? But I verified... it would not update after my first login. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:10:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:10:16 +0000 Subject: [Koha-bugs] [Bug 28454] Add Koha version number to database schema link in reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:13:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:13:06 +0000 Subject: [Koha-bugs] [Bug 28454] Add Koha version number to database schema link in reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- Hi Owen, could you please fix the link on the start page of the reports module as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:14:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:14:58 +0000 Subject: [Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28467 --- Comment #4 from Katrin Fischer --- Hi Nick, please also update the preference description. I am adding a dependency on the recent rephrase that will probably be backported/pushed first to avoid additional confusion. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28467 [Bug 28467] Add wording to TrackLastPatronActivity description to tell users that it records SIP authentication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:14:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:14:58 +0000 Subject: [Koha-bugs] [Bug 28467] Add wording to TrackLastPatronActivity description to tell users that it records SIP authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28467 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28455 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455 [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:15:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:15:09 +0000 Subject: [Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:20:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:20:49 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:20:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:20:53 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121570|0 |1 is obsolete| | --- Comment #22 from Andrew Nugged --- Created attachment 121584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121584&action=edit Bug 28489: Modify sessions.a_session from longtext to longblob This column contains serialized data, it should be a blob. And it fixes encoding issues. Test plan: 1. Apply patch and run updatedatabase 2. In $KOHA_CONF make sure that you have 0 3. Create 2 libraries: a. TESTÄ/Testä b. TEST✓/Test✓ 4. Go to the staff interface, change your library to Testä, then navigate to a few other pages, make sure there is no encoding problem with the library name in the top right corner 5. Do the same with Test✓ Signed-off-by: Petro Vashchuk Signed-off-by: Andrew Nugged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:20:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:20:58 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121571|0 |1 is obsolete| | --- Comment #23 from Andrew Nugged --- Created attachment 121585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121585&action=edit Bug 28489: Modify sessions.a_session from longtext to longblob (kohastructure.sql) Signed-off-by: Petro Vashchuk Signed-off-by: Andrew Nugged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:23:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:23:34 +0000 Subject: [Koha-bugs] [Bug 28482] Floating point math prevents items from being returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28482 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:23:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:23:38 +0000 Subject: [Koha-bugs] [Bug 28482] Floating point math prevents items from being returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28482 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121479|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 121586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121586&action=edit Bug 28482: Unit test Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:23:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:23:43 +0000 Subject: [Koha-bugs] [Bug 28482] Floating point math prevents items from being returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28482 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121480|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 121587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121587&action=edit Bug 28482: Refresh line from DB to get stored value Before checking if the amount is 0 we get the stored value from the DB. This ensures any amounts beyond the 6 digit precision we store will be removed. To test: 1 - Add a processing fee of 15 to an itemtype 2 - Add an item of that type, set the replacement fee to 12.63 3 - Set MarkLostItemsAsReturned to 'On payment' only 4 - Set WhenLostChargeReplacementFee to 'Charge' 5 - Checkout the item to a patron 6 - Mark the item lost 7 - Reload patron and confirm they are charged 27.63 8 - Go to accounting, pay amount, pay 27.63 9 - Item is still lost and not returned 10 - Apply patch 11 - Checkin the item 12 - Checkout to another patron 13 - Mark lost 14 - Patron charged 27.63 15 - Pay amount, 27.63 16 - Item returned! Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:34:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:34:06 +0000 Subject: [Koha-bugs] [Bug 28510] Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510 --- Comment #3 from Kyle M Hall --- Created attachment 121588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121588&action=edit Bug 28510: Remove unnecessary conditional It makes sense to use items by branch to get the list of branches, as it already tells use which branches have available items. We could use branches to pull from instead, but all we would accomplish is added extra ununsed loop iterations. We already know that any additional branches in the branches to pull loop have no items to fill holds. If they did, they would be in the items_by_branch hash. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:52:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:52:28 +0000 Subject: [Koha-bugs] [Bug 27848] Elasticsearch - include 245b subtitle subfield in the default title index mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27848 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.11 |master Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:54:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:54:04 +0000 Subject: [Koha-bugs] [Bug 28238] Add itemcallnumber to ils-di GetAvailability output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |koha at univ-lyon3.fr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:54:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:54:27 +0000 Subject: [Koha-bugs] [Bug 28391] Elasticsearch - Add 264b to publisher index mapping (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28391 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:54:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:54:45 +0000 Subject: [Koha-bugs] [Bug 27507] Search host record using control number identifier / organization code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |joonas.kylmala at helsinki.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:54:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:54:58 +0000 Subject: [Koha-bugs] [Bug 28022] MARC subfield 9 not honoring visibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28022 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |domm at plix.at |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 13:57:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 11:57:57 +0000 Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement lets you |This enhancement lets you release notes|include text that patrons |include text that patrons |need to accept before they |need to accept before they |can place an article |can place an article |request (similar to the |request (similar to the |ILLModuleCopyrightClearance |ILLModuleCopyrightClearance |system preference). |system preference). | | |Add |Add |the text required to the |the text required to the |new system preference |new system preference |ArticleRequestsDisclaimerTe |ArticleRequestsDisclaimerTe |xt. If there is no text in |xt. If there is no text in |the system preference, then |the system preference, then |no message is displayed. |no message is displayed. | | |, | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 14:04:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 12:04:31 +0000 Subject: [Koha-bugs] [Bug 26316] Add the option to un-lost an item on claim return resolution In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26316 Axelle Aix-Marseille Université changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |axelle.clarisse at univ-amu.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 14:09:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 12:09:57 +0000 Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer --- Hi Agustin, we have started moving the HTML system preferences into the news system as this allows to have translated versions of the text. i know this was modeled after the ILLModuleCopyrightClearance that hasn't been moved yet, but would you consider following the new pattern here? opacheader would be an example. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 14:39:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 12:39:42 +0000 Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #46 from Blou --- Ivan has already recoded it without sessions in our codebase. But before pushing that change, we'll be waiting for Tomas' instructions regarding the svc/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 14:41:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 12:41:38 +0000 Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #47 from Katrin Fischer --- (In reply to Blou from comment #46) > Ivan has already recoded it without sessions in our codebase. But before > pushing that change, we'll be waiting for Tomas' instructions regarding the > svc/ Hi Blou, thx for the update! So we can scratch that off the list. I'll ask Tomas to have another look. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 14:41:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 12:41:54 +0000 Subject: [Koha-bugs] [Bug 28292] Searching with colon ":" in the end of query gives internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28292 --- Comment #2 from Joonas Kylmälä --- Searching with "host-item:spr:n" even with this patch gives still error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 14:57:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 12:57:28 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 14:57:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 12:57:32 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117806|0 |1 is obsolete| | Attachment #117807|0 |1 is obsolete| | Attachment #117808|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart --- Created attachment 121589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121589&action=edit Bug 27526: Remove ModItemFromMarc from additem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 14:57:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 12:57:37 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #28 from Jonathan Druart --- Created attachment 121590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121590&action=edit Bug 27526: Remove AddItemFromMarc from additem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 14:57:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 12:57:42 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #29 from Jonathan Druart --- Created attachment 121591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121591&action=edit Bug 27526: Adjust code to use Koha::Items Not that we removed all the transformations of the item and are using Koha::Item from DB to TT (and the other way around), some code needs adjustments. - Retrieve host items can be simplified (see Koha::Biblio->host_items) - Some TT variables have been renamed for better understanding - Koha::Item->columns_to_str return a hashref with the representation string of the columns. A date will return the value how it must be displayed, using output_pref. A subfield linked with a AV will be replaced with the AV's description. - LastCreatedItem cookie serializes and stores Koha::Item->unblessed, no longer the MARC::Record Change in behaviour: If a subfield is linked with a AV cat and the value is not a valid AV, before this patch the column was displayed with an empty value. Now the column is hidden, it's considered empty. In the sample data it happens with itemlost (0) and withdrawn (0). Test plan: 1. Test the Prefill a. Turn PrefillItem on b. Fill in SubfieldsToUseWhenPrefill with some subfield codes c. Catalogue an item, save => The values from subfields listed in SubfieldsToUseWhenPrefill must be kept 2. more subfields a. Add subfields that are not linked with a koha field (k is available) b. Create an item and fill in all the values c. Confirm that non linked subfields are stored and displayed correctly d. Try with a "more subfield" that is linked with an authorised value category 3. Test barcode values 4. Test the different "Add" buttons at the bottom of the form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 15:23:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 13:23:03 +0000 Subject: [Koha-bugs] [Bug 27980] Replace obsolete title-string sorting: Catalog templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27980 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 15:23:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 13:23:13 +0000 Subject: [Koha-bugs] [Bug 27980] Replace obsolete title-string sorting: Catalog templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27980 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 15:23:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 13:23:26 +0000 Subject: [Koha-bugs] [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Keywords| |rel_21_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 15:32:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 13:32:05 +0000 Subject: [Koha-bugs] [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13420 --- Comment #23 from Jonathan Druart --- (In reply to Joonas Kylmälä from comment #11) > Attached solution that should restore exactly the previous behaviour. Let me > know what you think. Regarding bug 13420 it seems that we need to restore the previous behaviour, and not pick Owen's patch (what I was thinking first). commit 0ecf7694eac802f29ea4786502b7bffaaad3a6bf Bug 13420: Fallback to the previous behavior if published date is not used [% IF volinfo %] [% IF itemdate_publisheddate #If there is at least one published date, use it for sorting%] Serial enumeration / chronology [% ELSE %] Serial enumeration / chronology [% END %] [% END %] Maybe we should restore this comment. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 [Bug 13420] Holdings table sorting on volume information incorrect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 15:32:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 13:32:05 +0000 Subject: [Koha-bugs] [Bug 13420] Holdings table sorting on volume information incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28171 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171 [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 15:37:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 13:37:07 +0000 Subject: [Koha-bugs] [Bug 28313] Add street type to alternate address in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28313 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 15:37:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 13:37:13 +0000 Subject: [Koha-bugs] [Bug 28313] Add street type to alternate address in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28313 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120919|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 121592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121592&action=edit Bug 28313: Add street type to alternate address in OPAC 1. Add some values to the ROADTYPE authorized value 2. Go to PatronSelfRegistrationBorrowerUnwantedField and make sure B_streettype is NOT checked 3. Go the self reg form, no alternate address street type field 4. Apply patch 5. Check the self reg form, B_streettype should be there with all the options defined in ROADTYPE a.v. 6. Check the self modification form, B_street type should be there. 7. Make sure PatronSelfRegistrationBorrowerUnwantedField and PatronSelfModificationBorrowerUnwantedField hide the field correctly. 8. Make sure PatronSelfRegistrationBorrowerMandatoryField properly makes the field required. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 15:38:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 13:38:25 +0000 Subject: [Koha-bugs] [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171 --- Comment #24 from Jonathan Druart --- Created attachment 121593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121593&action=edit Bug 28171: Restore comment to remove ambiguity -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 15:38:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 13:38:57 +0000 Subject: [Koha-bugs] [Bug 12936] Road type value doesn't appear in OPAC borrower account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12936 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- Fixed by bug 28313 and dependent bug. *** This bug has been marked as a duplicate of bug 28313 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 15:38:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 13:38:57 +0000 Subject: [Koha-bugs] [Bug 28313] Add street type to alternate address in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28313 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |corinne.hayet at progilone.fr --- Comment #6 from Katrin Fischer --- *** Bug 12936 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 15:41:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 13:41:07 +0000 Subject: [Koha-bugs] [Bug 28511] New: Road types in OPAC should prefer OPAC description if one exists Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28511 Bug ID: 28511 Summary: Road types in OPAC should prefer OPAC description if one exists Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The road type pull down in the OPAC doesn't use the OPAC description. If one is set, it should be used with a fall back to the normal description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 15:43:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 13:43:37 +0000 Subject: [Koha-bugs] [Bug 22673] Road types missing on alternate contact In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22673 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Road types only on one |Road types missing on |address |alternate contact --- Comment #1 from Katrin Fischer --- The alternate address has been fixed, but the alternate contact is still missing the road type. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 15:51:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 13:51:57 +0000 Subject: [Koha-bugs] [Bug 28422] OPAC MARC detail view doesn't correctly evaluate holdability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28422 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 15:52:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 13:52:02 +0000 Subject: [Koha-bugs] [Bug 28422] OPAC MARC detail view doesn't correctly evaluate holdability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28422 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121508|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 121594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121594&action=edit Bug 28422: OPAC MARC detail view doesn't correctly evaluate holdability This patch modifies the MARC detail view in the OPAC so that it evaluates whether a title can be placed on hold in the same way it is done on the "normal" detail page and the ISBD detail page. This allows for consistency in the display of the "Place hold" link. To test, apply the patch and log into the OPAC. - Perform a search which will return results, at least one of which can be placed on hold. - View the detail page, the MARC detail page, and the ISBD detail page. In each case the "Place hold" link should appear in the sidebar. - View the same pages for a record which cannot be placed on hold to confirm that the link doesn't appear. For instance: - All items are not for loan. - All items are lost. - There are no items attached. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 15:55:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 13:55:06 +0000 Subject: [Koha-bugs] [Bug 28422] OPAC MARC detail view doesn't correctly evaluate holdability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28422 --- Comment #4 from Katrin Fischer --- I get a strong feeling that we should centralize the code for this check... but as a bug fix this works really well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 15:59:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 13:59:55 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |victor at tuxayo.net --- Comment #24 from Victor Grousset/tuxayo --- Futher tests. == Master == 1. Try to hold from the OPAC with delivery to TESTÄ/Testä or TEST✓/Test✓ => ERROR: Internal error: incomplete hold request. (odd, nothing in all the logs, just the HTTP request returning 200) 2. Staff interface set library: TESTÄ/Testä transfer item to any another library => Broken FK constraint at /usr/share/perl5/Exception/Class/Base.pm line 88 Oddly it works with TEST✓/Test✓ 3. Staff interface set library: TESTÄ/Testä checkout an item => Broken FK constraint at /usr/share/perl5/Exception/Class/Base.pm line 88 Oddly it works with TEST✓/Test✓ 4. Staff interface set library: NOT TESTÄ/Testä checkout an item set library: TESTÄ/Testä partron page => checkout tab => show checkouts try to check in => it's loads for ever => logs: Broken FK constraint at /usr/share/perl5/Exception/Class/Base.pm line 88 refresh page The item has actually been checked in. (not sure if DB is in a consistent state) 5. Same but use the check in tab of the search box, next to the Koha logo == Does anyone know why TEST✓/Test✓ doesn't cause issue? At least it should cause as much issues as TESTÄ/Testä. == With patches == 1. fails! 2. passes 3. fails! 4. passes 5. fails! (odd) So, QA fails! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 16:01:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 14:01:23 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #25 from Victor Grousset/tuxayo --- Does anyone have more ideas of tests? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 16:04:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 14:04:05 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #16 from Kyle M Hall --- I need to take back a good portion of what I wrote, as I was completely wrong. I should have double checked my memory. Joonas is correct and we should revert bug 26995. It *was* revealed in the ui for non-patron guarantors. I was just looking in the wrong place! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 16:07:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 14:07:12 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #26 from Julian Maurice --- (In reply to Victor Grousset/tuxayo from comment #24) > == With patches == > 1. fails! > 2. passes > 3. fails! > 4. passes > 5. fails! (odd) > > So, QA fails! Looks like it works better with the patch, so why do you say that ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 16:08:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 14:08:55 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #27 from Julian Maurice --- (In reply to Victor Grousset/tuxayo from comment #24) > Does anyone know why TEST✓/Test✓ doesn't cause issue? At least it should > cause as much issues as TESTÄ/Testä. see comment 8 and comment 13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 16:09:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 14:09:02 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #28 from Jonathan Druart --- Cannot recreate 1, but 3: - New library created TESTÄ/TESTÄ - Use it for logged in library - Checkout Invalid value passed, branchcode=\xC4 expected type is string at /usr/share/perl5/Exception/Class/Base.pm line 88 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 16:28:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 14:28:51 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 16:28:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 14:28:55 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121545|0 |1 is obsolete| | Attachment #121546|0 |1 is obsolete| | Attachment #121547|0 |1 is obsolete| | Attachment #121548|0 |1 is obsolete| | Attachment #121549|0 |1 is obsolete| | Attachment #121550|0 |1 is obsolete| | Attachment #121551|0 |1 is obsolete| | Attachment #121552|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 121595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121595&action=edit Bug 28490: Revert "Bug 26995: Remove one remaining occurrence in moremember" This reverts commit c3b50e9e97e917090ce09283807168caaad3de4a. It was part of a patch set that removed actively used data and must be therefore reverted. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 16:29:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 14:29:27 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #18 from Kyle M Hall --- Created attachment 121596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121596&action=edit Bug 28490: Revert "Bug 26995: Remove occurrences in sample_patrons.yml" This reverts commit 690b073478b04c7c801058b49f85275281c502d5. It was part of a patch set that removed actively used data and must be therefore reverted. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 16:29:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 14:29:31 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #19 from Kyle M Hall --- Created attachment 121597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121597&action=edit Bug 28490: Revert "Bug 26995: Fix SQL syntax error on the about page" This reverts commit 1131bb687f14fef7b4cb5f3b194711e85f9227af. It was part of a patch set that removed actively used data and must be therefore reverted. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 16:29:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 14:29:35 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #20 from Kyle M Hall --- Created attachment 121598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121598&action=edit Bug 28490: Revert "Bug 26995: Remove references to relationship column" This reverts commit 1cc8a77c287666ed878ea58f17216793f52ce224. It was part of a patch set that removed actively used data and must be therefore reverted. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 16:29:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 14:29:39 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #21 from Kyle M Hall --- Created attachment 121599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121599&action=edit Bug 28490: Revert "Bug 26995: Drop column relationship from borrowers, deletedborrowers and borrower_modifications tables" This reverts commit ca0e7541ecdff13ada9ba8ffbd992c963959d30f. It was part of a patch set that removed actively used data and must be therefore reverted. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 16:29:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 14:29:43 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #22 from Kyle M Hall --- Created attachment 121600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121600&action=edit Bug 28490: Comment out the relationship data removing DB update step These columns that were actively used to store non-patron guarantor relationship info were dropped incorrectly. In a later patch the relationship fields will be re-added. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 16:29:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 14:29:47 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #23 from Kyle M Hall --- Created attachment 121601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121601&action=edit Bug 28490: Bring back accidentally deleted relationship columns These were in active use before and were accidentally deleted in Bug 26995. This restores those deleted relationship columns. To test: 1) verify the borrower_modifications, borrowers, deletedborrowers contain the column exactly like it was before after applying these patches by comparing to the old kohastructure.sql version Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 16:38:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 14:38:49 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #29 from Victor Grousset/tuxayo --- comment 28 > Cannot recreate 1 Ok, it needs also to have TESTÄ/Testä and TEST✓/Test✓ as the library code. The idea was {Asian, Arabic, Pakistanis, Cyrillic} writing libraries (and more) might not always transliterate. Is that actually correct? Or is that out of scope? Are the test plan also out of scope? Assuming one or more of them still fail with ascii library code. Comment 26 > > So, QA fails! > Looks like it works better with the patch, so why do you say that ? Indeed it works better. That was based on the assumption that these tests are in the scope of this bug. Which is uncertain now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 16:29:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 14:29:52 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #24 from Kyle M Hall --- Created attachment 121602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121602&action=edit Bug 28490: Add DBIx schema changes for testing Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 16:53:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 14:53:22 +0000 Subject: [Koha-bugs] [Bug 26205] News changes aren't logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 16:53:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 14:53:27 +0000 Subject: [Koha-bugs] [Bug 26205] News changes aren't logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121338|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 121603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121603&action=edit Bug 26205: Add logging of news items To test: 1. Apply patch, updatedatabase, restart_all 2. Make sure the system pref 'NewsLog' is turned on. 3. Go to the Koha News tool and create a new news item. 4. View the logs and display only the OPAC News module 5. You should see your new news, it will include the lang ( OPACheader_en ) and the content of the news item. 6. Filter the logs so the only action is 'Add', your new news item should appear 7. Modify some news items 8. They should appear in the logs now as modification. 9. Make sure you can filter the action to 'Modify' and can confirm it works 10. Delete some news items 11. They should appear in the logs now as deletinon 12. Make sure you can filter the action to 'Delete' and can confirm it works Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 16:53:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 14:53:32 +0000 Subject: [Koha-bugs] [Bug 26205] News changes aren't logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 --- Comment #17 from Katrin Fischer --- Created attachment 121604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121604&action=edit Bug 26205: (QA follow-up) Capitalization: OPAC News Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 16:53:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 14:53:38 +0000 Subject: [Koha-bugs] [Bug 26205] News changes aren't logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 --- Comment #18 from Katrin Fischer --- Created attachment 121605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121605&action=edit Bug 26205: (QA follow-up) Change OPACNEWS to just NEWS As news are usable in OPAC and staff interface, I suggest changing the code to just be NEWS instead of OPACNEWS. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 16:53:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 14:53:43 +0000 Subject: [Koha-bugs] [Bug 26205] News changes aren't logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 --- Comment #19 from Katrin Fischer --- Created attachment 121606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121606&action=edit Bug 26205: (QA follow-up) Add punctuation and widen pref description a bit Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 16:56:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 14:56:02 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #30 from Katrin Fischer --- I imagine cyrillic in library codes and library names to be a good test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 16:57:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 14:57:40 +0000 Subject: [Koha-bugs] [Bug 26205] News changes aren't logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 --- Comment #20 from Katrin Fischer --- I kept the follow-ups independent in case not all are wanted. But I feel it would be a good thing to remove the OPAC bits as the news tool can be used for both interfaces. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 17:03:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 15:03:12 +0000 Subject: [Koha-bugs] [Bug 26205] News changes aren't logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 --- Comment #21 from Lucas Gass --- (In reply to Katrin Fischer from comment #20) > I kept the follow-ups independent in case not all are wanted. But I feel it > would be a good thing to remove the OPAC bits as the news tool can be used > for both interfaces. I completely agree! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 17:09:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 15:09:42 +0000 Subject: [Koha-bugs] [Bug 12620] Proxy Add-on for Koha z39.50 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12620 --- Comment #5 from Katrin Fischer --- Reading my own comment from 2018 and just having run into this issue - is anyone aware of a workaround for this problem? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 17:10:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 15:10:46 +0000 Subject: [Koha-bugs] [Bug 26205] News changes aren't logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 --- Comment #22 from Katrin Fischer --- Thx, Lucas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 17:11:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 15:11:24 +0000 Subject: [Koha-bugs] [Bug 12620] Proxy Add-on for Koha z39.50/SRU servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12620 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Proxy Add-on for Koha |Proxy Add-on for Koha |z39.50 |z39.50/SRU servers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 17:22:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 15:22:55 +0000 Subject: [Koha-bugs] [Bug 28512] New: spinelabel-print.tt should include the logged in branchcode Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Bug ID: 28512 Summary: spinelabel-print.tt should include the logged in branchcode Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org spinelabel-print.tt does not include the normal header include therefore there is no information about the current logged in branch. It would be nice to be able to write CSS for labels specific to a given branch. It would be easy to add the logged in branch code as a class on the HTML body. This would allow for branch specific CSS for labels. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 17:28:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 15:28:10 +0000 Subject: [Koha-bugs] [Bug 28512] spinelabel-print.tt should include the logged in branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 17:28:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 15:28:14 +0000 Subject: [Koha-bugs] [Bug 28512] spinelabel-print.tt should include the logged in branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 --- Comment #1 from Lucas Gass --- Created attachment 121607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121607&action=edit Bug 28512: add logged in branch as class to spinelabel-print.tt body To test: -Apply patch and generate a quick spine label. -Inscept the page and notice that the body should contain a new class which corresponds with that the of the logged in branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 17:29:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 15:29:23 +0000 Subject: [Koha-bugs] [Bug 28512] spinelabel-print.tt should include the logged in branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |lucas at bywatersolutions.com |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 18:38:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 16:38:44 +0000 Subject: [Koha-bugs] [Bug 28475] Searching all headings returns no results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 18:39:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 16:39:39 +0000 Subject: [Koha-bugs] [Bug 28475] Searching all headings returns no results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.05.00,20.11.07 |21.05.00,20.11.07,20.05.13 released in| | --- Comment #19 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 18:40:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 16:40:12 +0000 Subject: [Koha-bugs] [Bug 11083] Authority Search Result Display should be XSLT Driven In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083 --- Comment #4 from Katrin Fischer --- I really like the idea of this as currently there is no way to customize the result lists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 18:40:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 16:40:57 +0000 Subject: [Koha-bugs] [Bug 11083] Authority Search Result Display should be XSLT Driven In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083 --- Comment #5 from Katrin Fischer --- Julian - will you provide a sample file for UNIMARC? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 18:42:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 16:42:12 +0000 Subject: [Koha-bugs] [Bug 28367] Wrong plack condition in C4/Auth_with_shibboleth.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28367 --- Comment #9 from Victor Grousset/tuxayo --- Actually it was for v19.11.18-2, a micro release to contain this last moment patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 18:42:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 16:42:30 +0000 Subject: [Koha-bugs] [Bug 28367] Wrong plack condition in C4/Auth_with_shibboleth.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28367 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.06,20.05.12, |21.05.00,20.11.06,20.05.12, released in|19.11.18 |19.11.18-2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 18:46:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 16:46:33 +0000 Subject: [Koha-bugs] [Bug 28302] Koha does not work with CGI::Compile 0.24 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.06,20.05.12, |21.05.00,20.11.06,20.05.12, released in|19.11.18 |19.11.18-2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 18:46:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 16:46:51 +0000 Subject: [Koha-bugs] [Bug 28506] Editing purchase suggestion with no library or item type does not save edits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28506 --- Comment #1 from Katrin Fischer --- I don't manage to add a suggestion without a library in the staff interface, it always reverts the pull down to my logged in library (I think it shouldn't and feel like we had fixed that before?) The Document type list doesn't offer an empty entry by default. Otherwise, all changes I made to the suggestion, did save. Donna, can you share more details on your configuration? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 18:47:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 16:47:01 +0000 Subject: [Koha-bugs] [Bug 28367] Wrong plack condition in C4/Auth_with_shibboleth.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28367 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.06,20.05.12, |21.05.00,20.11.06,20.05.12, released in|19.11.18-2 |19.11.19 --- Comment #10 from Victor Grousset/tuxayo --- And I mixed up the patches. It will be for v19.11.19 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 19:45:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 17:45:46 +0000 Subject: [Koha-bugs] [Bug 28440] Inventory tool tries to put a time into DateLastSeen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28440 --- Comment #4 from Katrin Fischer --- I've tried to replicate the issue on master, but it all seemed to work alright. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 21:13:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 19:13:44 +0000 Subject: [Koha-bugs] [Bug 27949] Batch printing of article request slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 22:09:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 20:09:12 +0000 Subject: [Koha-bugs] [Bug 28497] Display city and zipcode as part of address on user search summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28497 --- Comment #1 from Katrin Fischer --- Hi David, I just checked on master and the city and zip code do show for me in the patron search result list. But I am a little confused by the path you gave, am I looking in the wrong place? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 22:28:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 20:28:03 +0000 Subject: [Koha-bugs] [Bug 28491] field 003 not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #1 from Katrin Fischer --- I am adding Marcel as I know he has been working some on the code we talk about here. My opinion would be to overwrite with MarcOrgCode or empty 003 when we add the Koha number there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 22:30:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 20:30:41 +0000 Subject: [Koha-bugs] [Bug 28488] Javascript error in self-checkout (__ is not defined) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #1 from Katrin Fischer --- Confirmed on /cgi-bin/koha/sco/sco-main.pl I wonder if this could affect translations, as __( is used for Javascript translation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 22:32:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 20:32:01 +0000 Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon or exclamation point is in 245$a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 22:32:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 20:32:18 +0000 Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon or exclamation point is in 245$a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Cataloging |Searching - Elasticsearch QA Contact|testopia at bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 22:38:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 20:38:08 +0000 Subject: [Koha-bugs] [Bug 12316] Can't put text on barcode label In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12316 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|can't put text on barcode |Can't put text on barcode |label |label Severity|normal |enhancement --- Comment #3 from Katrin Fischer --- It appears that 'barcode' only prints a barcode and the number below and nothing else which is set up in the list of fields, may it be text or a field from the database. So I am changing this to an enhancement request. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 22:38:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 20:38:25 +0000 Subject: [Koha-bugs] [Bug 12316] Can't put text and other information on barcode labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12316 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can't put text on barcode |Can't put text and other |label |information on barcode | |labels -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 22:40:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 20:40:06 +0000 Subject: [Koha-bugs] [Bug 28458] Prefill vendor in "Add from subscription" form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28458 --- Comment #1 from Katrin Fischer --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 22:41:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 20:41:49 +0000 Subject: [Koha-bugs] [Bug 28446] Fix encoding of OverDrive content on Your summary, OverDrive Account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28446 --- Comment #2 from Katrin Fischer --- Hm, not sure how this can be tested easily - those with Overdrive accounts might not have the required material with special characters. Magnus, do you have someone who could test this maybe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 22:55:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 20:55:01 +0000 Subject: [Koha-bugs] [Bug 28497] Display city and zipcode as part of address on user search summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28497 --- Comment #2 from David Roberts --- Hi Katrin, actually you might be right. I was working on this page: https://snipboard.io/ANyRQE.jpg However, this is on a 19.11 system so it looks like it might have been fixed in later versions. Sorry about that - I should have checked better! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 22:56:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 20:56:19 +0000 Subject: [Koha-bugs] [Bug 28444] Filter/search box missing above main ILL table on 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28444 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED Depends on| |25614 --- Comment #3 from Katrin Fischer --- I can confirm the change on a 20.11.06 installation as well. I think this was an intentional change caused by bug 25614: - The table of requests should display without a search form or "clear filter" button at the top. - The left-hand sidebar form should now have a "keyword" filter option which searches any column in the table. - Other filter fields should work as before. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25614 [Bug 25614] "Clear filter" button permanently disabled on ILL request list -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 22:56:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 20:56:19 +0000 Subject: [Koha-bugs] [Bug 25614] "Clear filter" button permanently disabled on ILL request list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25614 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28444 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28444 [Bug 28444] Filter/search box missing above main ILL table on 20.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 22:59:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 20:59:27 +0000 Subject: [Koha-bugs] [Bug 28497] Display city and zipcode as part of address on user search summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28497 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Katrin Fischer --- No problem at all! I sometimes file bugs for older versions too to check/confirm later, better than to have things get lost. Acosta, Edna 7896 Library Rd. Portland, OR 44240 Is what I see in the list now - I'll mark the bug as resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 23:01:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 21:01:33 +0000 Subject: [Koha-bugs] [Bug 27949] Batch printing of article request slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 23:01:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 21:01:39 +0000 Subject: [Koha-bugs] [Bug 27949] Batch printing of article request slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 --- Comment #1 from Agustín Moyano --- Created attachment 121608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121608&action=edit Bug 27949: Allow multiple article requests print slip This bug allows for batch printing of multiple article requests slips To test: 1. apply this patch 2. restart_all 3. enable ArticleRequests preference 4. create multiple article requests 5. go to circ/article-requests.pl in staff interface 6. print a single slip from a row CHECK => it works as expected 7. select all rows and print slip from general actions menu (above the table) SUCCESS => all article requests slips are printed 8. select multiple rows (not all) and print slip from general actions menu (above the table) SUCCESS => only selected article requests slips are printed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 23:06:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 21:06:38 +0000 Subject: [Koha-bugs] [Bug 28372] Use variables for 007 controlfield translations in MARC21slim2intranetResults.xsl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28372 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer --- Hi Nick, this reads well. Could you please change the OPAC results file as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 23:09:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 21:09:23 +0000 Subject: [Koha-bugs] [Bug 22591] Allow to temporarily suspend patrons from routing lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22591 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28439 Summary|Allow to temporarily |Allow to temporarily |exclude patrons from |suspend patrons from |routing lists |routing lists -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 23:09:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 21:09:23 +0000 Subject: [Koha-bugs] [Bug 28439] Add ability to suspend club enrollments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28439 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22591 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 23:10:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 21:10:06 +0000 Subject: [Koha-bugs] [Bug 28439] Add ability to suspend club enrollments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28439 --- Comment #1 from Katrin Fischer --- I had a similar request for routing lists a while ago - linking as see also. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 23:14:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 21:14:09 +0000 Subject: [Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 23:14:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 21:14:12 +0000 Subject: [Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455 --- Comment #5 from Andrew Fuerste-Henry --- Created attachment 121609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121609&action=edit Bug 28455: Update wording on TrackLastPatronActivity This patch updates the wording on TrackLackPatronActivity to maintain the corrections from bug 28467 and also reflect the change made in this bug. It should now read: The first time each day that a patron either logs into the OPAC, connects to Koha via SIP, or checks an item out, borrowers.lastseen will update with the current date and time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 23:14:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 21:14:42 +0000 Subject: [Koha-bugs] [Bug 6590] Removing hyphens from ISBN and ISSN when cataloging a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Removing hyphens from isbn |Removing hyphens from ISBN |and issn when cataloging a |and ISSN when cataloging a |biblio |biblio -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 23:14:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 21:14:58 +0000 Subject: [Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455 --- Comment #6 from Andrew Fuerste-Henry --- I added a patch to update the syspref and set this back to Needs Signoff. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 23:14:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 21:14:58 +0000 Subject: [Koha-bugs] [Bug 27774] Always remove hyphens from ISBN when cataloging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27774 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #9 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 6590 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 23:14:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 21:14:58 +0000 Subject: [Koha-bugs] [Bug 6590] Removing hyphens from ISBN and ISSN when cataloging a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590 --- Comment #25 from Katrin Fischer --- *** Bug 27774 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 23:23:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 21:23:29 +0000 Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN too In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.11 |master --- Comment #1 from Katrin Fischer --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 23:48:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 21:48:48 +0000 Subject: [Koha-bugs] [Bug 28373] Items fields not used in default XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 23:48:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 21:48:52 +0000 Subject: [Koha-bugs] [Bug 28373] Items fields not used in default XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121115|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 121610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121610&action=edit Bug 28373: Add PassItemMarcToXSLT system preference Default stylesheets do not reference item fields for XSLT display, however, we spend time translating the values in the item fields. This patch adds a system preference, PassItemMarcToXSLT. and unless enabled we remove item fields before processing To test: 1 - Perform some search on the staff client and opac 2 - Use the console (F12) to view the time spent on the network tab 3 - Note performance 4 - Apply patch, updatedatabase, restart_all 5 - Repeat searches 6 - Note that display has not changed 7 - Note performance, results should display slightly faster -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 23:48:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 21:48:58 +0000 Subject: [Koha-bugs] [Bug 28373] Items fields not used in default XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #11 from Katrin Fischer --- Created attachment 121611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121611&action=edit Bug 28373: (QA follow-up) Fix typo in system preference description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 3 23:49:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 21:49:34 +0000 Subject: [Koha-bugs] [Bug 28373] Items fields not used in default XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #12 from Katrin Fischer --- Tested OPAC, intranet and list result lists. You might want to add a unit test for QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 00:08:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 22:08:37 +0000 Subject: [Koha-bugs] [Bug 19220] Allow XSLT processing for Z39.50 authority targets like for bibliographic targets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220 --- Comment #8 from Katrin Fischer --- Sorry, Matts, I can't get this to work. - I've made sure to search for all different terms - The field I want to delete is still there after I imported the record We really need someone else to give this a try. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 00:31:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 22:31:16 +0000 Subject: [Koha-bugs] [Bug 28360] Link to make article reqests should display on detail page when user is not logged in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28360 --- Comment #1 from Katrin Fischer --- I just retested this in 20.11: ArticleRequestsLinkControl = Always show - Result list: Article request link always shows - Detail page: Article request link only shows when logged in I think this is because of the check on the artreqpossible template variable - I suspect it can only be 1 if the user is logged in: my $artreqpossible = $patron ? $biblio->can_article_request( $patron ) : $itemtype ? $itemtype->may_article_request : q{}; $template->param( artreqpossible => $artreqpossible ); The code for the same variable in the result list is certainly different, but completely mysterious to me: # BZ17530: 'Intelligent' guess if result can be article requested $res->{artreqpossible} = ( $art_req_itypes->{ $res->{itemtype} // q{} } || $art_req_itypes->{ '*' } ) ? 1 : q{}; I am not sure how to fix this :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 00:37:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 22:37:31 +0000 Subject: [Koha-bugs] [Bug 28357] E-mail Verification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28357 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- I believe this is very similar to bug 23908 and both have good ideas. I am copying the comment from here to there and mark them as duplicate. *** This bug has been marked as a duplicate of bug 23908 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 00:37:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 22:37:31 +0000 Subject: [Koha-bugs] [Bug 23908] Require patrons to confirm their email address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23908 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #3 from Katrin Fischer --- *** Bug 28357 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 00:37:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 22:37:42 +0000 Subject: [Koha-bugs] [Bug 23908] Require patrons to confirm their email address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23908 --- Comment #4 from Katrin Fischer --- (In reply to Christopher Brannon from comment #0) > Dead e-mails are a pain to deal with. > > It would be great if e-mail notifications were verified, regardless of > registering online or in person. If an e-mail address is entered by staff, > Koha should have a flag to indicate if the address has been verified. When > an account is saved or updated, it should check if an e-mail address has > been entered. If so, if it has not been verified, it should send a > verification e-mail to the address. When the patron receives it, they > should have to click something or login to complete the verification. The > address is marked in their account as verified. If the address is changed > at all, they have to re-verify. > > Staff who receive notice that the e-mail has problems (dead, full, etc) > should have a flag they can set on the account to mark the address as bad, > and the reason why. The patron would then have to supply a new e-mail > address and verify again. While the account is flagged with a bad e-mail, > notifications to that address should be turned off. If they have another > form of notification, Koha could send them a notification that the e-mail > address they supplied is no longer working, and needs to be corrected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 00:40:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 22:40:52 +0000 Subject: [Koha-bugs] [Bug 22956] Omnibus: Remove type attribute from script tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22956 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Katrin Fischer --- Looks like we are done here? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 00:42:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 22:42:35 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #133 from David Nind --- Created attachment 121612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121612&action=edit Test fails for holds - 2021-06-04 I've attached the test results for prove -v t/db_dependent/Holds.t after the patch is applied - it passed before the patch was applied. I'm testing on a MARC21 installation, does this need to be a UNIMARC setup? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 00:45:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 22:45:32 +0000 Subject: [Koha-bugs] [Bug 12733] Interactive inventory tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12733 --- Comment #7 from Katrin Fischer --- (In reply to Hannah Co from comment #6) > I created a plugin that does scan-as-you-go shelf reading and inventory > updating. https://github.com/hmconorthwestu/koha-plugin-shelfreading > > The sorting is across the whole group of scanned items, not a simple > comparison to previous or next items, which can mark order incorrectly when > shelves get too scrambled. The plugin probably needs DDC sorting added, as > my library only uses LCC and alphanumeric classification. > > I have a brief description on github, with more details, but I'm happy to > answer any questions about it. Hi Hannah, I've added your plugin to the plugin list on the wiki: https://wiki.koha-community.org/wiki/Koha_plugins#Plugins Please feel free to add more! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 00:52:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 22:52:41 +0000 Subject: [Koha-bugs] [Bug 28336] Cannot change matching rules for authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28336 --- Comment #2 from Katrin Fischer --- I could not replicate the database error, but I can confirm that this warn is fixed by the patch and the behaviour is improved: [Thu Jun 03 22:49:45.840349 2021] [cgi:error] [pid 12799] [client 10.0.2.2:55280] AH01215: Use of uninitialized value $item_action in string ne at /home/vagrant/kohaclone/tools/manage-marc-import.pl line 159.: /home/vagrant/kohaclone/tools/manage-marc-import.pl, referer: http://localhost:8081/cgi-bin/koha/tools/manage-marc-import.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 00:53:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 22:53:28 +0000 Subject: [Koha-bugs] [Bug 28336] Cannot change matching rules for authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28336 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 00:53:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 22:53:33 +0000 Subject: [Koha-bugs] [Bug 28336] Cannot change matching rules for authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28336 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120893|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 121613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121613&action=edit Bug 28336: Add missing input for item_action To test: 1 - Stage a marc file of authorities 2 - Manage the staged file 3 - Attempt to change the matching rule 4 - 500 Error, in intranet-error.log: [Wed May 12 16:53:03.046652 2021] [cgi:error] [pid 52072] [client 172.19.0.1:50580] AH01215: C4::ImportBatch::SetImportBatchItemAction(): DBI Exception: DBD::mysql::st execute failed: Column 'item_action' cannot be null [for Statement "UPDATE import_batches SET item_action = ? WHERE import_batch_id = ?" with ParamValues: 0=undef, 1="1"] at /kohadevbox/koha/tools/manage-marc-import.pl line 160: /kohadevbox/koha/tools/manage-marc-import.pl, referer: http://localhost:8081/cgi-bin/koha/tools/manage-marc-import.pl?import_batch_id=1 5 - Apply patch 6 - Reload page and change matching rule 7 - Success! Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 00:55:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 22:55:17 +0000 Subject: [Koha-bugs] [Bug 28336] Cannot change matching rules for authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28336 --- Comment #4 from Katrin Fischer --- I imagine a different fix could be on pl side - we could set the variable when handling an authority import. Not sure if this would be more practical? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 00:56:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 22:56:58 +0000 Subject: [Koha-bugs] [Bug 19852] Add message text box in circulation for patrons does not accept HTML tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19852 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 00:57:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 22:57:25 +0000 Subject: [Koha-bugs] [Bug 19852] Add message text box in circulation for patrons does not accept HTML tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19852 --- Comment #1 from Katrin Fischer --- Verified in master, that HTML is still escaped in messages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 00:58:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 22:58:24 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 00:58:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 22:58:29 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121542|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 121614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121614&action=edit Bug 28503: Unit tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 00:58:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 22:58:36 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121543|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 121615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121615&action=edit Bug 28503: Compare item homebranch to patron branch when hold policy set to 'from_home_library' This fixes an issue in the way we calculate the check for hold policy 'from_home_library' Currently we change the comparison based on ReservesControlBranch, however, that should only control the rule we fetch, not how we compare When ReservesControlBranch is set to "patron's home library" we compare the patron's branch to the patron's branch, this is useless and means we pass the check for all branches all of the time We should instead compare the patron's branch to the item's branch, and only fetch the rule using ReservesControlBranch To test: 1 - Have a record with an item from library A and library B 2 - Set the 'Default checkout, hold and return policy'->Hold policy->From home library for all libraries and ensure you have no branch specific/itemtype specific rules set 3 - Attempt to place a hold on the record for a patron from library B 4 - Note that only the library B item is holdable - place a title level hold (do not choose an item) 5 - Check in the item from library A 6 - It fills the hold - This is incorrect - ignore the hold 7 - Apply patch 8 - Restart all the things 9 - Check in the item from library A 10 - No hold found 11 - Check in the item from library B 12 - Hold found, correctly Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 00:58:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 22:58:44 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121544|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 121616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121616&action=edit Bug 28503: Clarify what ReservesControlBranch controls Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:00:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:00:41 +0000 Subject: [Koha-bugs] [Bug 28311] Holds always placed at biblio level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28311 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 26461 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:00:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:00:41 +0000 Subject: [Koha-bugs] [Bug 26461] Incorrect handling of hold levels in SIP2 code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26461 --- Comment #3 from Katrin Fischer --- *** Bug 28311 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:13:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:13:29 +0000 Subject: [Koha-bugs] [Bug 28328] Editing a record can cause an ISE if data too long for column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28328 --- Comment #1 from Katrin Fischer --- What would be the best solution here? I think we could limit the max size of 010a via the frameworks. But if the LCCN really can be longer than we give them space for now, we should probably change the data type of the column? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:16:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:16:51 +0000 Subject: [Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:16:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:16:56 +0000 Subject: [Koha-bugs] [Bug 24539] Build generic authentication module interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24539 --- Comment #23 from David Cook --- (In reply to mark.jaroski from comment #22) > I don't know enough about Koha to comment on internal workings, but wouldn't > you always want a session in most authentication situations? Yep. > I guess in the Shibboleth scenario you don't need a session because every > request comes with the server variable or header, but for things like > OpenID-Connect you don't want to do the handshake for every page load. I haven't used the built-in Koha Shibboleth integration. I've implemented my own custom Koha Shibboleth integration, so I can't comment on how Koha does it by default. But I just do a once off call to the SAML IdP, create a Koha session, and then use that from there on out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:16:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:16:57 +0000 Subject: [Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121481|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 121617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121617&action=edit Bug 28455: lastseen should be updated at checkout if TrackLastPatronActivity is enabled Signed-off-by: Andrew Fuerste-Henry Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:17:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:17:06 +0000 Subject: [Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121609|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 121618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121618&action=edit Bug 28455: Update wording on TrackLastPatronActivity This patch updates the wording on TrackLackPatronActivity to maintain the corrections from bug 28467 and also reflect the change made in this bug. It should now read: The first time each day that a patron either logs into the OPAC, connects to Koha via SIP, or checks an item out, borrowers.lastseen will update with the current date and time. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:20:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:20:10 +0000 Subject: [Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This updates the 'lastseen' release notes| |date for a patron when | |items are checked out (when | |TrackLastPatronActivity is | |enabled). (The last seen | |date is displayed on the | |patron details page.) CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:22:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:22:56 +0000 Subject: [Koha-bugs] [Bug 28420] Allow login via AzureAD OpenID-Connect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28420 --- Comment #18 from David Cook --- (In reply to mark.jaroski from comment #17) > In any case, this is probably not the *right* way to do it. But it's fast, > and probably does no real harm since whatever problems it has are the same > as the ones with the google version. > > Make sense? Oh yes I understand that. Personally, I was always against the Google version ;). But I hadn't prioritized upstreaming my own OpenID Connect client (which itself isn't perfect either of course), so I couldn't complain too much. Personally, I'm not really keen to have a Google version and an Azure version. I rather just have 1 generic version. But I won't stand in the way of someone else signing off and QAing this enhancement. You might want to sign up to the koha-devel listserv if you haven't already https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel. That can be a good place to try to generate interest for patches. In the meantime, if you update your patch to do your database update as per https://wiki.koha-community.org/wiki/Database_updates your patch will have a better chance of making it through. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:24:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:24:28 +0000 Subject: [Koha-bugs] [Bug 28467] Add wording to TrackLastPatronActivity description to tell users that it records SIP authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28467 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This improves the wording release notes| |for the | |TrackLastPatronActivity | |system preference to | |reflect that the 'last | |seen' date updates when a | |patron logs into the OPAC | |or connects using SIP. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:26:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:26:44 +0000 Subject: [Koha-bugs] [Bug 28420] Allow login via AzureAD OpenID-Connect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28420 --- Comment #19 from David Cook --- I'll keep working on my different auth patches as well. At this point, I think that I could probably do a generic OpenID Connect client just using a Koha Plugin, but I'd like to make some Koha changes too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:31:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:31:52 +0000 Subject: [Koha-bugs] [Bug 23908] Require patrons to confirm their email address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23908 --- Comment #5 from David Cook --- So Keycloak (the open source Identity and Access Management software) has an "Email verified" attribute for users, and there are several ways that it can be enabled. Administrators can manually enable it, a registration email can include an email verification link, you can update it using a REST API. Those are the methods I know of but there might be more. -- In theory, when importing patrons, any patron may or may not have a verified email address. So I think you just include it as a patron attribute when importing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:36:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:36:09 +0000 Subject: [Koha-bugs] [Bug 23908] Require patrons to confirm their email address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23908 --- Comment #6 from David Cook --- (In reply to Lari Taskula from comment #2) > Also, we should keep using their old email for messaging until patron has > verified the new one. So this requires some thought for the design. Perhaps > the whole messaging system should be redesigned so that patron can add n > number of email addresses (that can actually be used for messaging according > to patron's choice) instead of the so-confusing email, emailpro, B_email and > so on. But maybe this is outside the scope of this Bug. This is something I've been saying for years. I haven't found an existing bug for it, but I also haven't looked super heard. Interesting that people used to pack multiple emails into some of these email fields though (see Bug 16786). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:36:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:36:21 +0000 Subject: [Koha-bugs] [Bug 28191] Update wording on batch patron deletion to reflect changes from bug 26517 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28191 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:36:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:36:26 +0000 Subject: [Koha-bugs] [Bug 28191] Update wording on batch patron deletion to reflect changes from bug 26517 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28191 --- Comment #3 from Katrin Fischer --- Created attachment 121619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121619&action=edit Bug 28191: Upate wording on batch patron deletion This adds another point to the list of things that prevent patron deletion:
  • They have permissions assigned to them.
    • In order to test: - Go to tools > patron deletion and anonymization - Verify the new condition shows at the top of the page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:36:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:36:48 +0000 Subject: [Koha-bugs] [Bug 28191] Update wording on batch patron deletion to reflect changes from bug 26517 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28191 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|fridolin.somers at biblibre.co |katrin.fischer at bsz-bw.de |m | --- Comment #4 from Katrin Fischer --- Stealing this one, Frido ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:38:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:38:59 +0000 Subject: [Koha-bugs] [Bug 27348] Error defining INDEXER_PARAMS in /etc/default/koha-common In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27348 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:39:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:39:03 +0000 Subject: [Koha-bugs] [Bug 27348] Error defining INDEXER_PARAMS in /etc/default/koha-common In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27348 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114902|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 121620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121620&action=edit Bug 27348: Fix test on INDEXER_PARAMS in koha-indexer koha-indexer doesn't test INDEXER_PARAMS correctly which causes errors to display when stopping/starting the daemon. This patch fixes the test so that the variable is tested as a string, so that no errors are created and the params are passed correctly. Test plan: 0. Apply patch 1. vi /etc/default/koha-common 2. Add the following to the bottom of the file: INDEXER_PARAMS="-daemon -sleep 6" 3. cp debian/scripts/koha-indexer /usr/sbin/koha-indexer 4. koha-indexer --stop kohadev 5. Note no errors 6. koha-indexer --start kohadev 7. Note no errors 8. ps -efww | grep "indexer" 9. Note that rebuild_zebra.pl has the arguments "-daemon -sleep 6" Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:39:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:39:07 +0000 Subject: [Koha-bugs] [Bug 27348] Error defining INDEXER_PARAMS in /etc/default/koha-common In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27348 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114903|0 |1 is obsolete| | --- Comment #9 from David Nind --- Created attachment 121621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121621&action=edit Bug 27348: Fix test on ALTERNATE_INDEXER_DAEMON in koha-indexer Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:45:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:45:49 +0000 Subject: [Koha-bugs] [Bug 24855] Lost items not marked returned when floating-point math causes amountoutstanding to be not-quite-zero In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24855 --- Comment #6 from Katrin Fischer --- Is this possibly a duplicate of bug 28482? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:46:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:46:28 +0000 Subject: [Koha-bugs] [Bug 24855] Lost items not marked returned when floating-point math causes amountoutstanding to be not-quite-zero In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24855 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28482 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:46:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:46:28 +0000 Subject: [Koha-bugs] [Bug 28482] Floating point math prevents items from being returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28482 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24855 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:48:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:48:39 +0000 Subject: [Koha-bugs] [Bug 28488] Javascript error in self-checkout (__ is not defined) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 --- Comment #2 from David Cook --- I was wondering that as well. What's the difference between __() and _()? I've noticed some cases where they'll both be used close to each other. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:49:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:49:23 +0000 Subject: [Koha-bugs] [Bug 28488] Javascript error in self-checkout (__ is not defined) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 --- Comment #3 from Katrin Fischer --- __() is used in .js files, _() in TT files. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:51:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:51:32 +0000 Subject: [Koha-bugs] [Bug 28422] OPAC MARC detail view doesn't correctly evaluate holdability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28422 --- Comment #5 from David Cook --- (In reply to Katrin Fischer from comment #4) > I get a strong feeling that we should centralize the code for this check... > but as a bug fix this works really well. Agreed. Holds are a total mess. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:52:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:52:12 +0000 Subject: [Koha-bugs] [Bug 28335] Making patron attributes required can cause issues in multi branch systems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28335 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Making Patron Attributes |Making patron attributes |Required Can cause issues |required can cause issues |in multi branch systems |in multi branch systems -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:52:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:52:57 +0000 Subject: [Koha-bugs] [Bug 28335] Making patron attributes required can cause issues in multi branch systems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28335 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:56:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:56:11 +0000 Subject: [Koha-bugs] [Bug 28265] Add option to include and calculate sales tax in Point of Sale In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28265 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:57:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:57:52 +0000 Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #48 from David Cook --- (In reply to Blou from comment #46) > Ivan has already recoded it without sessions in our codebase. But before > pushing that change, we'll be waiting for Tomas' instructions regarding the > svc/ I'll mostly leave it to Tomas, but it might be worth looking over https://wiki.koha-community.org/wiki/Rest_Api_HowTo Basically, the "svc/" API scripts are legacy, so we don't want to be adding new ones. We just want to build up the Mojolicious-based REST API. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 01:58:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Jun 2021 23:58:39 +0000 Subject: [Koha-bugs] [Bug 28488] Javascript error in self-checkout (__ is not defined) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 --- Comment #4 from David Cook --- (In reply to Katrin Fischer from comment #3) > __() is used in .js files, _() in TT files. Ahh interesting. I wish I remembered where I saw the combo.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 02:03:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 00:03:28 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #121 from Katrin Fischer --- (In reply to Gérard Simon Voyer from comment #120) > Hi Alex! > > I'm trying my hand at sign offs. On a koha-docker-testing CT using master > branch, I seem to fall on this error upon entering the ElasticSearch > mappings setup : https://pastebin.com/8Mj7LzvM > > Something I'm doing wrong? I remember this message being addressed in one of > the obsoleted patches. > > Thanks a lot! Hi, you can try Actions > Refresh Schema to see if this fixes the issue. An Actions > Restart services also sometimes doesn't hurt (restarts Plack, Memcached, Apache etc.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 02:09:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 00:09:21 +0000 Subject: [Koha-bugs] [Bug 28263] AUTO_RENEWAL message for 'too_many' is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer --- Hi Lucas, with the new additions in 21.05 we also need to fix AUTO_RENEWALS_DGST now. And for new installations we need sample_notices.yml fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 02:21:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 00:21:46 +0000 Subject: [Koha-bugs] [Bug 27964] Link to subscription in serial collections view is broken - the field subscriptionid is undefined in the subscription object. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27964 --- Comment #2 from Katrin Fischer --- Hi Andreas, could you please include a test plan and problem description in your commit message? Should this be Needs Signoff? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 02:33:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 00:33:02 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #134 from David Cook --- Checking hold limits has been driving me crazy lately. It seems to me that these functions should check all the different hold limits and report back specifically why the book or item can't be reserved. For example, exceeded max reserves, exceeded total holds for the day, exceeded total holds for record, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 02:41:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 00:41:07 +0000 Subject: [Koha-bugs] [Bug 27720] Print Holds List slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27720 --- Comment #1 from Katrin Fischer --- Hi Daniel, could you explain a bit how this slip would be used in the library? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 02:43:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 00:43:51 +0000 Subject: [Koha-bugs] [Bug 27761] Koha is reporting deleted items when a pickup is done by OAI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27761 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #1 from Katrin Fischer --- Hi Jonathan, do you delete the items or mark them withdrawn? What is the setting of your OAI-PMH:DeletedRecord system preference? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 03:03:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 01:03:41 +0000 Subject: [Koha-bugs] [Bug 28373] Items fields not used in default XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 03:29:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 01:29:45 +0000 Subject: [Koha-bugs] [Bug 12620] Proxy Add-on for Koha z39.50/SRU servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12620 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #6 from David Cook --- This is an interesting one, and Dan is in Australia as well, so I'm extra interested. I'd need to know more about the network ecosystem at the school, but it sounds like all outbound network traffic is blocked, unless it uses a HTTP forward proxy. Of course, that means that they'll be restricted to only using HTTP (or maybe just ports 80 and 443 depending on the type of proxy). Since Z39.50 tends to use ports 210 or 7090, that's not going to be an option. SRU could be an option, since it uses HTTP, but the SCIS website seems to suggest it only has Z39.50 for programmatic access (https://www.scisdata.com/products/scis-data/). Looking at https://metacpan.org/pod/ZOOM and https://software.indexdata.com/yaz/doc/zoom.html, there is a proxy option, so if it's not a HTTP forward proxy and is just a TCP proxy... then that could be investigated as an option. Happy to chat with Dan in any case. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 03:48:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 01:48:40 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #29 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121622&action=edit Bug 27741: tools folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 04:15:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 02:15:15 +0000 Subject: [Koha-bugs] [Bug 12620] Proxy Add-on for Koha z39.50/SRU servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12620 --- Comment #7 from David Cook --- It looks like the "proxy" connect option expects the target to be a Z39.50 proxy. However... maybe you could tunnel Z39.50 through HTTP...depending on the proxy... https://en.wikipedia.org/wiki/HTTP_tunnel https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/CONNECT https://datatracker.ietf.org/doc/html/rfc7231#section-4.3.6 It looks like the YAZ toolkit added something for that in 5.10.0 in 2015: https://github.com/indexdata/yaz/blob/master/NEWS#L457 https://github.com/indexdata/yaz/commit/9021ba4aa6fcdbdd177073d44edd03a86d70198f I'm finding the YAZ documentation to be quite poor... so I'm going to reach out to Indexdata and see what they have to say on the topic. This might actually be possible... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 05:08:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 03:08:28 +0000 Subject: [Koha-bugs] [Bug 12620] Proxy Add-on for Koha z39.50/SRU servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12620 --- Comment #8 from David Cook --- (In reply to Galen Charlton from comment #2) > Depending on the nature of the proxy involved, it may not be necessary to > use YAZProxy. In particular, the YAZ toolkit supports a special connection > syntax to direct Z39.50 and SRU traffic through a proxy. > > For example, suppose you have a Squid proxy running on localhost and > listening on port 210, and further suppose that the proxy is configured to > allow connecting to the target Z39.50 server(s). In that case, with > yaz-client you can do something like this: > > yaz-client connect:localhost:3128,tcp:lx2.loc.gov:210/LCDB > > and that will get you a proxied Z39.50 connection to the Library of Congress. It took a bit of digging but I found some information about that syntax that Galen mentioned: https://github.com/indexdata/yaz/blob/master/NEWS#L2365 So in that case you'd be doing "yaz-client connect:EDUPROXY:PROXYPORT,tcp:lx2.loc.gov:210/LCDB". Now ZOOM doesn't explicitly mention support for this syntax (https://metacpan.org/pod/distribution/Net-Z3950-ZOOM/lib/ZOOM.pod). Of course, neither does yaz-client (https://linux.die.net/man/1/yaz-client). As I said, the documentation leaves something to be desired. I'm waiting to hear back from Adam Dickmeiss about that. But looking at C4::Breeding::_create_connection... it looks like Koha would need a little patch to change how we pass in the connection string. Instead of '$obj->connect( $server->{host}, $server->{port} )', we'd want to use something like '$obj->connect($host)' where $host is constructed based on whether or not there is a proxy. (See https://metacpan.org/pod/distribution/Net-Z3950-ZOOM/lib/ZOOM.pod#new()) I could keep digging through source code but I think it'll just be easier to wait for Adam's response. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 05:10:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 03:10:50 +0000 Subject: [Koha-bugs] [Bug 12620] Proxy Add-on for Koha z39.50/SRU servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12620 --- Comment #9 from David Cook --- Note though that this proxying of Z39.50 via a HTTP proxy will only work if your HTTP proxy allows connections to Z39.50 ports (like 210, 7090) and doesn't restrict them to 80 and 443. But still... this has been very illuminating. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 06:09:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 04:09:47 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 06:09:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 04:09:55 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #345 from Aleisha Amohia --- Created attachment 121623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121623&action=edit Bug 15516: (follow-up) Count group holds always -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 06:12:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 04:12:08 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #346 from Aleisha Amohia --- I decided to amend count_grouped() to count_holds() so it sounds more like the standard subroutine it will become. It needs to use count() which is why I couldn't just overwrite count(). Left the OPAC count_holds() in because borrowers might get group holds placed in the staff client then try to place holds via the OPAC so they need that count to calculate their limit. I imagine the most recent patch doesn't catch all of the staff interface cases for placing a hold so feel free to tell me what I've missed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 09:30:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 07:30:14 +0000 Subject: [Koha-bugs] [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171 --- Comment #25 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #23) > Maybe we should restore this comment. Yeah, good idea. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 10:20:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 08:20:24 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #31 from Jonathan Druart --- It can be recreated easily using: use Koha::Cities; use CGI::Session::Serialize::default; #$Data::Dumper::Useperl = 1; use utf8; my $branchname = "TESTÄ/Testä"; my $hash = { branch => $branchname }; my $s = CGI::Session::Serialize::default->freeze($hash); $hash = CGI::Session::Serialize::default->thaw($s); Koha::City->new({city_name => $hash->{branch}})->store; It fails with Incorrect string value: '\xC4/Test...' for column 'city_name' at row 1 But inserts the city correctly if the Useperl line is uncommented. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 10:38:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 08:38:50 +0000 Subject: [Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #29 from Fridolin Somers --- Sorry the commit was not in 20.11.06. I've added it so it will be in 20.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 10:39:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 08:39:00 +0000 Subject: [Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.06 |21.05.00,20.11.07 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 10:45:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 08:45:18 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #32 from Jonathan Druart --- Created attachment 121624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121624&action=edit Bug 28489: Fix issues with umlaut in session vars -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 10:45:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 08:45:54 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #33 from Jonathan Druart --- This last patch seems to fix the problem, can someone test or give their opinions on it please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 11:04:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 09:04:23 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #335 from Jonathan Druart --- Nobody interested in getting this done? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 11:13:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 09:13:10 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #336 from Katrin Fischer --- (In reply to Jonathan Druart from comment #335) > Nobody interested in getting this done? Martin and I are, but more hands would be useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 11:15:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 09:15:30 +0000 Subject: [Koha-bugs] [Bug 28166] Optionally add MARC fields to authority search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12747 Summary|optionally add marc fields |Optionally add MARC fields |to authority search |to authority search Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 [Bug 12747] Add configurable extra column in Z3950 search result -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 11:15:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 09:15:30 +0000 Subject: [Koha-bugs] [Bug 12747] Add configurable extra column in Z3950 search result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28166 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 [Bug 28166] Optionally add MARC fields to authority search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 11:15:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 09:15:55 +0000 Subject: [Koha-bugs] [Bug 28166] Optionally add MARC fields to authority search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120139|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 11:18:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 09:18:12 +0000 Subject: [Koha-bugs] [Bug 28166] Optionally add MARC fields to authority search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120139|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 11:26:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 09:26:54 +0000 Subject: [Koha-bugs] [Bug 28166] Optionally add MARC fields to authority search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Katrin Fischer --- Hi Mark, something is not quite right with the patch set. The first file is not a real patch file, the second only won't apply - I assume they are both needed from looking at the diffs, but as the first has the wrong format, this is not working. Also, the second file contains a lot of unrelated changes in the yaml file. A change to the sysprefs.sql file is missing (https://wiki.koha-community.org/wiki/System_Preferences) Can you provide one cleaned up patch file for master with all required changes? -------------- Apply? [(y)es, (n)o, (i)nteractive] y Traceback (most recent call last): File "/usr/local/bin/git-bz", line 2711, in applied = do_apply(bug_ref) File "/usr/local/bin/git-bz", line 1820, in do_apply users = bug.server.get_xmlrpc_proxy().User.get({ 'names': [patch.attacher] })['users'] File "/usr/lib/python2.7/xmlrpclib.py", line 1243, in __call__ return self.__send(self.__name, args) File "/usr/lib/python2.7/xmlrpclib.py", line 1602, in __request verbose=self.__verbose File "/usr/lib/python2.7/xmlrpclib.py", line 1283, in request return self.single_request(host, handler, request_body, verbose) File "/usr/lib/python2.7/xmlrpclib.py", line 1331, in single_request response.msg, xmlrpclib.ProtocolError: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 11:29:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 09:29:54 +0000 Subject: [Koha-bugs] [Bug 27911] Quick add new patron does not include needed custom fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27911 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Katrin Fischer --- I just tested this on 21.05: If you mark a patron attribute as mandatory, it will show up on the quick add patron form. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 11:32:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 09:32:49 +0000 Subject: [Koha-bugs] [Bug 27929] Regex option in item batch modification is hidden for itemcallnumber if 952$o linked to cn_browser plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27929 --- Comment #3 from Katrin Fischer --- I think it would make sense to show the regex option independent of the cataloguing plugin. Examples I can think of: - dateaccessioned: I could make sense to change them in batch, it's only a date. - barcode: It could make sense. to change a branch prefix maybe? Not sure, but would not hurt. - stocknumber: often also linked to a plugin, batch edit could also make sense for old data here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 11:39:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 09:39:52 +0000 Subject: [Koha-bugs] [Bug 28513] New: Analytic search links formed incorrectly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28513 Bug ID: 28513 Summary: Analytic search links formed incorrectly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: joonas.kylmala at helsinki.fi QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In catalogue/detail.pl we form the analytics links like this: Host-item:$cleaned_title but that means we only search from Host-item field only the first token in the title, other tokens get searched from all fields. Same error is when forming the links to display in koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 11:42:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 09:42:30 +0000 Subject: [Koha-bugs] [Bug 27768] Saving an item with an invalid dateaccessioned or replacementpricedate throws no helpful error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27768 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Saving an item with an |Saving an item with an |invalid dateaccessioned or |invalid dateaccessioned or |replacementpricedate throws |replacementpricedate throws | |no helpful error --- Comment #1 from Katrin Fischer --- I haven't been able to replicate the problem on 21.05/master, but when you enter an invalid date there is no error at all now. The date widget only shows for $d Date acquired, but it would be nice if it showed for the other fields as well. Maybe we could detect the data type in the database or we could add an option to the frameworks to say "is a date". Instead when you open the record again, it shows as 0000-00-00. So there are still some changes needed to have a helpful error message. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 11:46:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 09:46:40 +0000 Subject: [Koha-bugs] [Bug 27866] Cannot create new printer profiles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27866 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|cannot create new printer |Cannot create new printer |profiles |profiles --- Comment #1 from Katrin Fischer --- I think the problem might occur when the printer name is left empty. The first time it kinda uses a default value, the second time, things explode: C4::Creators::Profile::save(): DBI Exception: DBD::mysql::st execute failed: Duplicate entry 'DEFAULT PRINTER-0-Tray 1-Labels' for key 'printername' [for Statement "INSERT INTO printers_profile (template_id, creep_vert, creator, printer_name, creep_horz, units, offset_horz, paper_bin, offset_vert) VALUES (?,?,?,?,?,?,?,?,?);" with ParamValues: 0='', 1=0, 2='Labels', 3='DEFAULT PRINTER', 4=0, 5="POINT", 6=0, 7='Tray 1', 8=0] at /home/vagrant/kohaclone/C4/Labels/Profile.pm line 23 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 If I enter a printer name, things save ok. Lucas, could this be it or are you seeing another issue? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 11:50:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 09:50:58 +0000 Subject: [Koha-bugs] [Bug 27781] Editing Codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27781 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |20.11 --- Comment #3 from Katrin Fischer --- I think it would be quite hard to do in some cases. If we had FK constraints in the database a lot of the change could be handled automatically, but we are not quite there yet. At least for item type codes this could work, I think Not sure about authorised values - they are used so differently in so many tables that it would probably be a lot more risky to get this to work reliably. On the other hand - those codes can already be changed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 11:55:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 09:55:22 +0000 Subject: [Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|when recording local use |When recording local use |with STAT patron items are |with statistical patron |not checked in |items are not checked in --- Comment #3 from Katrin Fischer --- (In reply to Donna from comment #2) > Typically, the items are not going to be checked out, however, items that > are checked out sometimes make their way back to the shelf without being > checked in. > Just like with inventory, when an item is scanned in this scenario, the > status should be updated/checked in. Thx, I agree that it should be checked in. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 11:56:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 09:56:46 +0000 Subject: [Koha-bugs] [Bug 27619] Remove fr-FR installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 --- Comment #1 from Jonathan Druart --- Created attachment 121625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121625&action=edit Bug 27619: FA for UNIMARC and custom for fr-FR -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 12:05:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 10:05:19 +0000 Subject: [Koha-bugs] [Bug 27660] Should getletter not use the fallback to default? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27660 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Should getletter not use |Should getletter not use |the fallback to default ? |the fallback to default? Blocks| |28487 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 [Bug 28487] Overdue_notices does not fall back to default language -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 12:05:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 10:05:19 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27660 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27660 [Bug 27660] Should getletter not use the fallback to default? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 12:06:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 10:06:47 +0000 Subject: [Koha-bugs] [Bug 28204] Table highlighting is broken at the cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Assignee|koha-bugs at lists.koha-commun |stalkernoid at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 12:11:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 10:11:25 +0000 Subject: [Koha-bugs] [Bug 28204] Table highlighting is broken at the cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121336|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 121626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121626&action=edit Bug 28204: Fix table highlighting on the items table Fix table highlighting at /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX Every odd row of the table didn't get highlighted with the yellow color when you tried to edit it previously, this patch fixes that. That happened because every odd row had different coloring style that was overwriting yellow highlight. How to reproduce: 1) Head over to the /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX, where XXXX is id of some bilbio record that has more than one biblio item. 2) Press the "Action" button of the first (or any other odd numbered) biblion item, and from the dropdown menu select "edit" option. 3) Notice that it doesn't highlight it with yellow color. 4) Now do the same but with second biblio item (or any even numbered item). 5) Notice that it highlights it with the yellow color. 6) Apply the patch. Do yarn build to compile css. 7) Make sure that every row of the table that you edit gets properly highlighted with the yellow color. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer JD Amended commit title -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 12:12:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 10:12:21 +0000 Subject: [Koha-bugs] [Bug 11158] Authorities 'starts with' search returns the same as 'contains' when using ICU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11158 --- Comment #12 from Katrin Fischer --- The test plan works ok on current master for me, but I assume this is because the kohadevbox is using ICU by default. I am not sure how to activate ICU there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 12:14:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 10:14:34 +0000 Subject: [Koha-bugs] [Bug 27660] Should getletter not use the fallback to default? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27660 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |INVALID --- Comment #9 from Jonathan Druart --- This is invalid, getletter should not have a fallback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 12:14:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 10:14:35 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Bug 28487 depends on bug 27660, which changed state. Bug 27660 Summary: Should getletter not use the fallback to default? https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27660 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 12:14:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 10:14:53 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27660 Depends on|27660 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27660 [Bug 27660] Should getletter not use the fallback to default? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 12:14:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 10:14:53 +0000 Subject: [Koha-bugs] [Bug 27660] Should getletter not use the fallback to default? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27660 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28487 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28487 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 [Bug 28487] Overdue_notices does not fall back to default language -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 12:21:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 10:21:42 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 12:21:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 10:21:45 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 --- Comment #4 from Jonathan Druart --- Created attachment 121627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121627&action=edit Bug 28487: Fallback to default template in overdue_notices There is no fallback to the "default" language if there is no language-specific template for the lang of the patron. I am not really sure why we are not using GetPreparredLetter here (which defaults), but this needs to be backported into all stable branches and so as small as possible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 12:22:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 10:22:27 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121580|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 12:22:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 10:22:34 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 12:22:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 10:22:35 +0000 Subject: [Koha-bugs] [Bug 24370] Editing purchase suggestion changes the acquisition library to logged-in user's In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24370 --- Comment #13 from Katrin Fischer --- Confirmed, this is still an issue on master :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 12:23:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 10:23:08 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 --- Comment #5 from Jonathan Druart --- Andreas, can you test this patch please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 12:25:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 10:25:06 +0000 Subject: [Koha-bugs] [Bug 14261] Switch 'ask for a discharge' to 'download discharge confirmation' when patron was discharge in OPAC user account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14261 --- Comment #7 from Katrin Fischer --- (In reply to Katrin Fischer from comment #6) > Would still love some help with fixing my patch! Still looking for someone to help me out here :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 12:26:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 10:26:54 +0000 Subject: [Koha-bugs] [Bug 28514] New: C4::Letters::getletter must be rewritten Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 Bug ID: 28514 Summary: C4::Letters::getletter must be rewritten Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 28487 The way we handle notice templates is confusing (see bug 27660, bug 26787, bug 28487). We should remove it and use Koha::Notice::Templates instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 [Bug 28487] Overdue_notices does not fall back to default language -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 12:26:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 10:26:54 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28514 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 [Bug 28514] C4::Letters::getletter must be rewritten -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 12:27:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 10:27:20 +0000 Subject: [Koha-bugs] [Bug 26787] getletter does not fallback to default language - transaction receipts can be blank In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26787 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Jonathan Druart --- getletter must not fallback, see also bug 27660. And bug 28514. *** This bug has been marked as a duplicate of bug 27660 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 12:27:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 10:27:20 +0000 Subject: [Koha-bugs] [Bug 27660] Should getletter not use the fallback to default? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27660 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #10 from Jonathan Druart --- *** Bug 26787 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 12:31:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 10:31:58 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 12:32:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 10:32:02 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 --- Comment #1 from Jonathan Druart --- Created attachment 121628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121628&action=edit Bug 28514: Remove getletter The way we handle notice templates is confusing (see bug 27660, bug 26787, bug 28487). This patch remove C4::Letters::getletter and use either Koha::Notice::Templates->find or the newly created methods ->find_effective_template that will do all necessary to return the correct template. Test plan: - Create and modify notice templates - Make sure you have TranslateNotices turned on and that some notices templates have a translated version - Use holds_reminder.pl and overdue_notices.pl cronjobs and confirm that the generated notices are the expected ones - Test also pos/printreceipt.pl - And finally test some other notices (CHECKIN, RENEWAL for instance) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 12:33:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 10:33:33 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com Blocks| |15449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuff to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 12:33:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 10:33:33 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuff to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28514 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 [Bug 28514] C4::Letters::getletter must be rewritten -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 12:34:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 10:34:20 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 13:25:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 11:25:00 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stalkernoid at gmail.com --- Comment #34 from Peter Vashchuk --- > I imagine cyrillic in library codes and library names to be a good test. I tested naming libraries with cyrillic symbols, like "Бібліотека" and it works fine with and without the patch. Then, I tested a bunch of other special characters from different languages, here's the list of them: These ones work fine without the patch: ааа ААА яяя ЯЯЯ ііі ІІІ ЄЄЄ єєє łłł ŁŁŁ ŽŽŽ Meanwhile these ones get shown as "???" without the patch: äää ÄÄÄ ööö ÖÖÖ ààà ááá æææ ÆÆÆ ååå ÅÅÅ ôôô ÔÔÔ üüü ÜÜÜ ëëë ËËË ççç ććć meanwhile with patch these symbols are displayed correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 13:25:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 11:25:19 +0000 Subject: [Koha-bugs] [Bug 28513] Analytic search links formed incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28513 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 13:25:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 11:25:22 +0000 Subject: [Koha-bugs] [Bug 28513] Analytic search links formed incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28513 --- Comment #1 from Joonas Kylmälä --- Created attachment 121629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121629&action=edit Bug 28513: Fix analytics search links so they don't match unrelated biblios At least when using Searchengine=Elasticsearch what happened was that without () parenthese included the search for Host-item field was done only to the first token, the subsequent ones matched any fields. Adding the parentheses restrict the search to Host-item search field only. To test: 1) Set Searchengine = elasticsearch 2) Make a biblio with 245a = "biológica paranaense." and 773a = "Acta" 3) Go to a biblio with 245a = "Acta biológica paranaense" (in kohadevbox or create one if you need). 4) Notice that the "Acta biológica paranaense" biblio's detail page link "Show analytics" takes to the "biológica paranaense" incorrectly just because the 773a has "Acta" and the words "biológica" and "paranaense" appear elsewhere in the biblio. 5) Apply patch and notice the link is now not created at all -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 13:33:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 11:33:07 +0000 Subject: [Koha-bugs] [Bug 28513] Analytic search links formed incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28513 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Depends on| |15851 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 [Bug 15851] Only display "Analytics: Show analytics" when records have linked analytics -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 13:33:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 11:33:07 +0000 Subject: [Koha-bugs] [Bug 15851] Only display "Analytics: Show analytics" when records have linked analytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28513 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28513 [Bug 28513] Analytic search links formed incorrectly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 14:03:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 12:03:55 +0000 Subject: [Koha-bugs] [Bug 28191] Update wording on batch patron deletion to reflect changes from bug 26517 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28191 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 14:03:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 12:03:58 +0000 Subject: [Koha-bugs] [Bug 28191] Update wording on batch patron deletion to reflect changes from bug 26517 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28191 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121619|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry --- Created attachment 121630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121630&action=edit Bug 28191: Upate wording on batch patron deletion This adds another point to the list of things that prevent patron deletion:
  • They have permissions assigned to them.
    • In order to test: - Go to tools > patron deletion and anonymization - Verify the new condition shows at the top of the page. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 14:06:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 12:06:26 +0000 Subject: [Koha-bugs] [Bug 24855] Lost items not marked returned when floating-point math causes amountoutstanding to be not-quite-zero In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24855 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #7 from Andrew Fuerste-Henry --- *** This bug has been marked as a duplicate of bug 28482 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 14:06:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 12:06:26 +0000 Subject: [Koha-bugs] [Bug 28482] Floating point math prevents items from being returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28482 --- Comment #9 from Andrew Fuerste-Henry --- *** Bug 24855 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 14:06:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 12:06:44 +0000 Subject: [Koha-bugs] [Bug 24855] Lost items not marked returned when floating-point math causes amountoutstanding to be not-quite-zero In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24855 --- Comment #8 from Andrew Fuerste-Henry --- Totally is, thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 14:41:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 12:41:51 +0000 Subject: [Koha-bugs] [Bug 24147] Objects.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24147 --- Comment #17 from Jonathan Druart --- Master_U18 1110 Docker_1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 14:49:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 12:49:18 +0000 Subject: [Koha-bugs] [Bug 28515] New: Make it easy to run batch modification on "all" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28515 Bug ID: 28515 Summary: Make it easy to run batch modification on "all" Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org Batch modification of items and records (and maybe more things as well?) relies on supplying IDs in a file or a list, or coming in from a report. But sometimes you really do want to modify everytghing. Could we make that easier by supplying a "select all" option? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 14:49:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 12:49:34 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #35 from Peter Vashchuk --- > I imagine cyrillic in library codes and library names to be a good test. I tested naming libraries with cyrillic symbols, like "Бібліотека" and it works fine with and without the patch. Then, I tested a bunch of other special characters from different languages, here's the list of them: These ones work fine without the patch: ааа ААА яяя ЯЯЯ ііі ІІІ ЄЄЄ єєє łłł ŁŁŁ ŽŽŽ ććć Meanwhile these ones get shown as "???" without the patch: äää ÄÄÄ ööö ÖÖÖ ààà ááá æææ ÆÆÆ ååå ÅÅÅ ôôô ÔÔÔ üüü ÜÜÜ ëëë ËËË ççç meanwhile with patch all these symbols are displayed correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 14:53:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 12:53:56 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #36 from Katrin Fischer --- Ok, so with the patch all is good...? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 15:03:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 13:03:06 +0000 Subject: [Koha-bugs] [Bug 28516] New: Koha/Patrons/Import.t is failing randomly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 Bug ID: 28516 Summary: Koha/Patrons/Import.t is failing randomly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org 13:51:29 koha_1 | Missing mandatory extended attribute (type=Bg9cq3e) at /kohadevbox/koha/Koha/Patrons/Import.pm line 352, <$fh> line 2. 13:51:29 koha_1 | 13:51:29 koha_1 | # Failed test at t/db_dependent/Koha/Patrons/Import.t line 1108. 13:51:29 koha_1 | # got: '0' 13:51:29 koha_1 | # expected: '1' 13:51:29 koha_1 | 13:51:29 koha_1 | # Failed test at t/db_dependent/Koha/Patrons/Import.t line 1135. 13:51:29 koha_1 | # Structures begin differing at: 13:51:29 koha_1 | # $got->[0] = Does not exist 13:51:29 koha_1 | # $expected->[0] = HASH(0x5637834005a8) 13:51:29 koha_1 | # Looks like you failed 2 tests of 19. 13:51:29 koha_1 | 13:51:29 koha_1 | # Failed test 'update existing patron' 13:51:29 koha_1 | # at t/db_dependent/Koha/Patrons/Import.t line 1112. 13:51:29 koha_1 | # Looks like you failed 1 test of 17. 13:51:29 koha_1 | 13:51:29 koha_1 | # Failed test 'patron_attributes' 13:51:29 koha_1 | # at t/db_dependent/Koha/Patrons/Import.t line 1114. Master_D11 run 315 on Docker_7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 15:03:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 13:03:32 +0000 Subject: [Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28516 --- Comment #40 from Jonathan Druart --- Random failure reported on bug 28516 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 [Bug 28516] Koha/Patrons/Import.t is failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 15:03:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 13:03:32 +0000 Subject: [Koha-bugs] [Bug 28516] Koha/Patrons/Import.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 [Bug 27857] Koha::Patron->extended_attributes skips checks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 15:04:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 13:04:29 +0000 Subject: [Koha-bugs] [Bug 28516] Koha/Patrons/Import.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 --- Comment #1 from Jonathan Druart --- Previously reported on bug 27858: Master_D9 run 1663 11:41:11 koha_1 | [0m[92mKoha::Exceptions::Patron::MissingMandatoryExtendedAttribute[0m { 11:41:11 koha_1 | Parents [92mKoha::Exceptions::Patron[0m 11:41:11 koha_1 | public methods (3) : [92mdescription[0m, [92mFields[0m, [92mtype[0m 11:41:11 koha_1 | private methods (0) 11:41:11 koha_1 | internals: { 11:41:11 koha_1 | [35megid[0m "[93m1000 1000[0m", 11:46:27 koha_1 | [35meuid[0m [94m1001[0m, 11:46:27 koha_1 | [35mgid[0m "[93m1000 1000[0m", 11:46:27 koha_1 | [35mmessage[0m "[93m[0m", 11:46:27 koha_1 | [35mpid[0m [94m4522[0m, 11:46:27 koha_1 | [35mtime[0m [94m1621935671[0m, 11:46:27 koha_1 | [35mtrace[0m [92mDevel::StackTrace[0m, 11:46:27 koha_1 | [35mtype[0m "[93mVfu0SZ[0m", 11:46:27 koha_1 | [35muid[0m [94m1001[0m 11:46:27 koha_1 | } 11:46:27 koha_1 | } 11:46:27 koha_1 | Missing mandatory extended attribute (type=Vfu0SZ) at /kohadevbox/koha/Koha/Patrons/Import.pm line 420, <$fh> line 2. 11:46:27 koha_1 | 11:46:27 koha_1 | # Failed test at t/db_dependent/Koha/Patrons/Import.t line 902. 11:46:27 koha_1 | # got: '0' 11:46:27 koha_1 | # expected: '1' 11:46:27 koha_1 | # Looks like you planned 17 tests but ran 1. 11:46:27 koha_1 | # Looks like you failed 1 test of 1 run. 11:46:27 koha_1 | 11:46:27 koha_1 | # Failed test 'patron_attributes' 11:46:27 koha_1 | # at t/db_dependent/Koha/Patrons/Import.t line 1114. 11:46:27 koha_1 | Can't call method "extended_attributes" on an undefined value at t/db_dependent/Koha/Patrons/Import.t line 905, <$fh> line 2. ----- Got it locally t/db_dependent/Koha/Patrons.t ........................................... 28/42 # No tests run! # Failed test 'No tests run for subtest "extended attributes"' # at t/db_dependent/Koha/Patrons.t line 1770. # Looks like you failed 1 test of 110. t/db_dependent/Koha/Patrons.t ........................................... 33/42 # Failed test 'Test Koha::Patrons::merge' # at t/db_dependent/Koha/Patrons.t line 1774. Missing mandatory extended attribute (type=hGA0QWrb6)# Looks like your test exited with 2 just after 33. ----- Master_D9_My8 586 Docker_7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 15:39:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 13:39:38 +0000 Subject: [Koha-bugs] [Bug 28516] Koha/Patrons/Import.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 15:39:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 13:39:42 +0000 Subject: [Koha-bugs] [Bug 28516] Koha/Patrons/Import.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 --- Comment #2 from Jonathan Druart --- Created attachment 121631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121631&action=edit Bug 28516: Prevent failures if borrower_attribute_types.mandatory=1 TestBuilder will generate an integer for the Koha::Patron::Attribute::Type object, but if 1 is picked some tests are failing randomly At least t/db_dependent/Koha/Patrons.t and t/db_dependent/Koha/Patrons/Import.t The expection "Missing mandatory extended attribute" is raised when the patron is stored. Test plan: The following script should return 0 when the patch is applied: """ use t::lib::TestBuilder; my $builder = t::lib::TestBuilder->new; my $x = $builder->build_object( { class => 'Koha::Patron::Attribute::Types', } ); say $x->mandatory; """ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 15:45:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 13:45:00 +0000 Subject: [Koha-bugs] [Bug 28516] Koha/Patrons/Import.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 15:45:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 13:45:00 +0000 Subject: [Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28516 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 [Bug 28516] Koha/Patrons/Import.t is failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 15:45:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 13:45:04 +0000 Subject: [Koha-bugs] [Bug 28516] Koha/Patrons/Import.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 15:50:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 13:50:24 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #37 from Peter Vashchuk --- (In reply to Victor Grousset/tuxayo from comment #24) > Further tests. > == Master == ... > == With patches == ... Hey, I couldn't reproduce it, I didn't manage to get any errors like that neither on master, nor with two previous patches that were signed off by me previously. Everything seems to magically work on my local koha so I am not sure what the problem is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 16:08:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 14:08:12 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #38 from Jonathan Druart --- Wait a bit, Julian and me are trying to come with a better solution. My last patch is removing the different problems listed previously, but it's 1. ugly and 2. incorrect (we only fix the problem in set_userenv whereas it must be fixed at session level). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 16:11:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 14:11:15 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #39 from Andrew Nugged --- I also don't like direct utf8 flag change on lower level: later it can bring more errors even if we manage for now them not to happen :P. But I also tried with Victor's findings and can't: Jonathan/Julian – have you able to reproduce what Victor said? Hint me how, for me it just worked (comment 24). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 16:13:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 14:13:54 +0000 Subject: [Koha-bugs] [Bug 28275] Cart in OPAC doesn't sent mails if surname or firstname contains diacritics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28275 Filippos Kolovos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |f.kolovos at gmail.com --- Comment #2 from Filippos Kolovos --- Hello, Upon further investigation, the problem does not seem to be solely with the diacritics in the user's name, but with ANY character other than the ones forming an email address in the user's email. The purpose is to form a combination of the user's fullname and the email, in the form John Doe , but it does not pass the Email::Valid->addresses() method in Koha::Email, throwing a BadParameter exception in line 112. I guess that this method is very strict in validating the email address format One quick workaround would be to change the line 62 in /usr/share/koha/opac/cgi-bin/opac/opac-sendbasket.pl from my $email_replyto = $patron->firstname . " " . $patron->surname . " <$user_email>"; to my $email_replyto = $user_email; It was checked and it works. Further work could include to first validate the email address and afterwards to include the user's firstname and lastname along with the "<",">" characters around the email. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 16:47:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 14:47:21 +0000 Subject: [Koha-bugs] [Bug 28517] New: Bad encoding in logged-in-branch-name Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28517 Bug ID: 28517 Summary: Bad encoding in logged-in-branch-name Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: resetka.bedi at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 121632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121632&action=edit Staff page with Set library. The problem is in upper right. There was no problem in previous versions. Now, after installing version 21.05, the library name is displayed incorrectly in the upper right (HTML class logged-in-branch-name). It should be correct as it is in the Set library: Bédiho knihovna. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 17:00:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 15:00:28 +0000 Subject: [Koha-bugs] [Bug 28518] New: "Return to the last advanced search" exclude keywords if more than 3 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 Bug ID: 28518 Summary: "Return to the last advanced search" exclude keywords if more than 3 Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: claes.eriksson at vti.se QA Contact: testopia at bugs.koha-community.org After performing an advanced search with more than 3 keywords I use the option "Return to the last advanced search" on the result page. However, now there are only 3 keywords. When I use a 20.11.05. version, e.g. https://kohaopac.alingsas.se/cgi-bin/koha/opac-search.pl I can use the browser “go back one page” option and all keywords are still there. However, in our 20.11.06 version at https://bibliotek.vti.se/cgi-bin/koha/opac-search.pl we get the same disappointing result using the "Return to the last advanced search" or the "back one page". I have not tested to setup Koha showing more than three keywords by default. If that is a fix it is still not a real fix since both of the options "Return to ..." or "Go back ..." should be working. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 17:01:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 15:01:30 +0000 Subject: [Koha-bugs] [Bug 28482] Floating point math prevents items from being returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28482 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 17:35:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 15:35:46 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #24 from Jonathan Druart --- Created attachment 121633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121633&action=edit Bug 17427: Use JSON serialization -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 17:41:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 15:41:24 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #25 from Jonathan Druart --- We are now aiming to provide a long-term solution for the encoding issue found on bug 28489. Using Data::Session using the JSON serializer seems to be the more robust solution. However there is still an issue if SessionStorage=tmp file Note that sessions.a_session must be longtext. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 17:42:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 15:42:34 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #26 from Jonathan Druart --- (In reply to Jonathan Druart from comment #25) > However there is still an issue if SessionStorage=tmp file root at kohadevbox$ more /var/lib/koha/kohadev/tmp/cgisess_koha_kohadev/cgisess_6967e16ccb3dddff1c32735b7930e967 {"_SESSION_CTIME":1622821220,"_SESSION_ETIME":0,"id":"koha","interface":"intranet","number":51,"ip":"172.20.0.1","lasttime":"1622821226","_SESSION_PTIME":{},"_SESSION_ATIME":1622821226,"flags":1,"surname":"koha" ,"cardnumber":"42","_SESSION_ID":"6967e16ccb3dddff1c32735b7930e967","branchname":"✔️ ❤️ ★","branch":"✔️❤️★"} root at kohadevbox$ file /var/lib/koha/kohadev/tmp/cgisess_koha_kohadev/cgisess_6967e16ccb3dddff1c32735b7930e967 /var/lib/koha/kohadev/tmp/cgisess_koha_kohadev/cgisess_6967e16ccb3dddff1c32735b7930e967: JSON data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 17:47:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 15:47:36 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #40 from Jonathan Druart --- Julian, Andrew and me worked on it today but we have not found a correct solution so far. The only viable solution would be: 1. For master: Replace CGI::Session with Data::Session using JSON serialization (see bug 17427 and note that there is still a problem there) 2. For 21.05: Reintroduce the YAML dependency and use YAML serialization with CGI::Session (we know it is a working solution and we are failing to provide a fix with Data::Dumper) 3. Developers will test Data::Session in master 4. Eventually backport the Data::Session move into 21.05 Note that the proposed solution on bug 17427 does not require a datatype change (sessions.a_session is still longtext). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 17:54:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 15:54:00 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #27 from Katrin Fischer --- Bug 28517 might be related to this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 18:37:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 16:37:14 +0000 Subject: [Koha-bugs] [Bug 28517] Bad encoding in logged-in-branch-name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28517 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 28489 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 18:37:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 16:37:14 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |resetka.bedi at gmail.com --- Comment #41 from Jonathan Druart --- *** Bug 28517 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 21:43:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 19:43:02 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #42 from Andrew Nugged --- Thought on swimming 4K, thought on walking. Such idea: what if we will create own CGI::Session::Serialize::yamlxs and we're good to go then with all for now? Proof of concept: https://github.com/nugged/Koha/commit/2c62d311fba86576321337f2596283300013dd47 in: https://github.com/nugged/Koha/commits/cgi_session_serialize_yamlxs I there created "CGI::Session::Serialize::yamlxs" package just "inside" of C4::Auth file, to show that solution. Jonathan and Dave: and voila, we might have YAML::XS now for sessions! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 21:45:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 19:45:23 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #43 from Andrew Nugged --- Thought on swimming 4K, thought on walking. Such idea: what if we will create own CGI::Session::Serialize::yamlxs and we're good to go then with all for now? Proof of concept: https://github.com/nugged/Koha/commit/2c62d311fba86576321337f2596283300013dd47 in: https://github.com/nugged/Koha/commits/cgi_session_serialize_yamlxs I there created "CGI::Session::Serialize::yamlxs" package just "inside" of C4::Auth file, to show that solution. Jonathan and David: and voila, we might have YAML::XS now for sessions! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 22:12:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 20:12:39 +0000 Subject: [Koha-bugs] [Bug 22329] Parent funds showing incorrect amounts for Ordered, Spent, Available on Acquisitions Home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22329 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26878 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 22:12:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 20:12:39 +0000 Subject: [Koha-bugs] [Bug 26878] Add ability to prevent spending against parent funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26878 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22329 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 22:13:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 20:13:20 +0000 Subject: [Koha-bugs] [Bug 22329] Parent funds showing incorrect amounts for Ordered, Spent, Available on Acquisitions Home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22329 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED --- Comment #4 from Andrew Fuerste-Henry --- Hi folks! I'm reopening this one. It was not actually a duplicate of bug 23767. 23767 was about the total at the bottom of the table on Acq Home. This is about the amount shown in each parent fund's line directly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 23:30:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 21:30:53 +0000 Subject: [Koha-bugs] [Bug 28408] Last modification date for suggestions is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 4 23:30:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 21:30:57 +0000 Subject: [Koha-bugs] [Bug 28408] Last modification date for suggestions is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121482|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 121634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121634&action=edit Bug 28408: Add 'Last updated' column to suggestions table We have specific meanings for the different dates in suggestions Managed - means the status was changed or the suggestion edited, but doesn't change if item type updated Modification - implies an edit of the subscript, not updated if status changed alone Updated - this is the date field in the DB, which is actually a timestamp The cronjob purge_suggestions.pl uses teh 'date' field For a user, a suggestion can look old in the interface, but be considered recent by the script To clear the confusion we should show the timestamp as well To test: 1 - Add a suggestion 2 - In the DB, pretend you set it in the past: UPDATE suggestions SET manageddate='2021-01-01', suggesteddate='2021-01-01', date='2021-01-01 12:12:12'; 3 - Click 'Go' In Organize by: Status 4 - Note the suggestion looks old now 5 - Check the box, and click 'Update item types with:' -> Submit 6 - Prganize by status again 7 - No change? 8 - Check the DB: SELECT date FROM suggestions; 9 - The field is updated 10 - Apply patch 11 - Organize by status again 12 - See the 'Last updated' ate set to today Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 00:25:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 22:25:11 +0000 Subject: [Koha-bugs] [Bug 28513] Analytic search links formed incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28513 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 00:25:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 22:25:17 +0000 Subject: [Koha-bugs] [Bug 28513] Analytic search links formed incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28513 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121629|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 121635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121635&action=edit Bug 28513: Fix analytics search links so they don't match unrelated biblios At least when using Searchengine=Elasticsearch what happened was that without () parenthese included the search for Host-item field was done only to the first token, the subsequent ones matched any fields. Adding the parentheses restrict the search to Host-item search field only. To test: 1) Set Searchengine = elasticsearch 2) Make a biblio with 245a = "biológica paranaense." and 773a = "Acta" 3) Go to a biblio with 245a = "Acta biológica paranaense" (in kohadevbox or create one if you need). 4) Notice that the "Acta biológica paranaense" biblio's detail page link "Show analytics" takes to the "biológica paranaense" incorrectly just because the 773a has "Acta" and the words "biológica" and "paranaense" appear elsewhere in the biblio. 5) Apply patch and notice the link is now not created at all Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 00:45:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 22:45:28 +0000 Subject: [Koha-bugs] [Bug 28350] Order patron search broken (borrowernotes) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28350 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 00:45:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 22:45:32 +0000 Subject: [Koha-bugs] [Bug 28350] Order patron search broken (borrowernotes) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28350 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120937|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 121636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121636&action=edit Bug 28350: Fix borrowernotes sorting for patron search Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 00:48:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 22:48:15 +0000 Subject: [Koha-bugs] [Bug 28350] Order patron search broken (borrowernotes) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28350 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the patron release notes| |search result page so that | |the results can be sorted | |using the 'Circ note' | |column. Before this fix you | |could not sort the results | |by this column. CC| |david at davidnind.com Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 00:52:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Jun 2021 22:52:02 +0000 Subject: [Koha-bugs] [Bug 28350] Order patron search broken (borrowernotes) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28350 --- Comment #4 from David Nind --- Testing notes (koha-testing-docker): - Added some circulation notes for patrons, including notes starting with letters, numbers and symbols - Followed the test plan in Comment #2 Note: also changed the status to normal, rather than an enhancement - if it isn't working I think it should be a standard bug rather than an enhancement -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 14:51:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Jun 2021 12:51:09 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #44 from Jonathan Druart --- Created attachment 121637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121637&action=edit Bug 28489: Add selenium tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 14:53:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Jun 2021 12:53:25 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #45 from Jonathan Druart --- Andrew, Yes, that could work as well. I forgot this possibility! I've written some selenium tests to help us testing the different patches/approach. I am running into the same problem I faced with Data::Session and using the file driver: YAML::XS::Load Error: The problem: control characters are not allowed was found at document: 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 14:53:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Jun 2021 12:53:47 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17427 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 [Bug 17427] Replace CGI::Session with Data::Session -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 14:53:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Jun 2021 12:53:47 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28489 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 15:14:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Jun 2021 13:14:46 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121637|0 |1 is obsolete| | --- Comment #46 from Jonathan Druart --- Created attachment 121638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121638&action=edit Bug 28489: Add selenium tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 15:16:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Jun 2021 13:16:28 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #47 from Jonathan Druart --- And those tests are passing on 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 15:29:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Jun 2021 13:29:09 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121624|0 |1 is obsolete| | --- Comment #48 from Jonathan Druart --- Created attachment 121639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121639&action=edit Bug 28489: POD - CGI::Session::Serialize::yamlxs for CGI::Session -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 15:29:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Jun 2021 13:29:14 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #49 from Jonathan Druart --- Created attachment 121640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121640&action=edit Bug 28489: Don't deal with encoding during the serialization -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 15:31:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Jun 2021 13:31:15 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #50 from Jonathan Druart --- Looks like there is a 100% working solution using longblob and removing the encode/decode from the YAML::XS serializer. Asking for a SO now, but we will need to provide a better solution to embed the serializer code (having it in C4::Auth is not nice). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 15:56:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Jun 2021 13:56:22 +0000 Subject: [Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13307 CC| |jonathan.druart+koha at gmail. | |com Version|20.11 |master Severity|enhancement |normal Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 [Bug 13307] Create a link to the last advanced search in search result page (OPAC) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 15:56:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Jun 2021 13:56:22 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28518 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 16:11:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Jun 2021 14:11:14 +0000 Subject: [Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 16:11:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Jun 2021 14:11:19 +0000 Subject: [Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 --- Comment #1 from Jonathan Druart --- Created attachment 121641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121641&action=edit Bug 28518: Display missing inputs for "Return to the last advanced search" When more than 3 search terms are passed on the advanced search form, the "Return to the last advanced search" feature does not display them. Test plan: Perform an adv search at the OPAC, enter more than 3 terms, launch the search, click the "Return to the last advanced search" link and confirm that all the entries are there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 16:11:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Jun 2021 14:11:37 +0000 Subject: [Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 21:35:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Jun 2021 19:35:23 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #51 from Andrew Nugged --- We discussed with Jonathan about "where better to place the file" but we both agreed (JD, you say) so for a moment we can keep the package in C4/Atuh as additional one for quick-est fix so we can provide working solution for backporting, but the question still open to decide for later (let's create a separate ticket after we accept this for not to forget, like TODO?): of course it's better to keep CGI::Session::Serialize::yamlxs in own file/path, .../CGI/Session/Serialize/yamlxs.pm but that pollutes Koha lib folder - Jonathan said he keeps in mind to create something separate, but that for later discussion. So, mates, for now – let's decide do we accept this 'yamlxs' serializer solution as a temporary but the full fix for this problem and backport, and keep development in master later towards whatever planned (JD said target is Data::Session). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 21:36:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Jun 2021 19:36:27 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #52 from Andrew Nugged --- Jonathan, should we obsolete the first old two patches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 21:56:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Jun 2021 19:56:47 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #53 from Andrew Nugged --- Also, for me after you, Jonathan, removed encoders, I got this error: YAML::XS::Load Error: The problem:: /home/vagrant/kohaclone/mainpage.pl : /home/vagrant/kohaclone/mainpage.pl invalid trailing UTF-8 octet: /home/vagrant/kohaclone/mainpage.pl : /home/vagrant/kohaclone/mainpage.pl was found at document: 0: /home/vagrant/kohaclone/mainpage.pl but with "Encode::decode_utf8(YAML::XS::Dump($data));" so on as it was on beginning – it works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 22:19:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Jun 2021 20:19:52 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #54 from Jonathan Druart --- It works for me with longblob (so with all the patches attached on this bug report). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 22:34:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Jun 2021 20:34:25 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #6 from David Nind --- Could we get a test plan for this, and I will happily attempt to test 8-). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 22:43:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Jun 2021 20:43:16 +0000 Subject: [Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david at davidnind.com --- Comment #6 from David Nind --- Patch no longer applies 8-(.. root at kohadevbox:koha(bz27265)$ git bz apply 27265 Bug 27265 - Process message queue cron should be able to take multiple types as a parameter 115430 - Bug 27265: Enable message queue cron to accept multiple codes and types Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27265: Enable message queue cron to accept multiple codes and types Using index info to reconstruct a base tree... M C4/Letters.pm M misc/cronjobs/process_message_queue.pl Falling back to patching base and 3-way merge... Auto-merging misc/cronjobs/process_message_queue.pl Auto-merging C4/Letters.pm CONFLICT (content): Merge conflict in C4/Letters.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 27265: Enable message queue cron to accept multiple codes and types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 22:45:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Jun 2021 20:45:37 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #55 from Andrew Nugged --- ah, right. Longblob, not longtext, my bad then, then yes, it should work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 5 23:15:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Jun 2021 21:15:43 +0000 Subject: [Koha-bugs] [Bug 27539] Warnings "Use of uninitialized value in split" on "Holds to pull" page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27539 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #2 from David Nind --- Hi Peter. I can't seem to replicate the warning message appearing in any of the log files or the browser console. I have checked the database for the items I have placed holds on and they have NULL as the value for call number, copy number and enumeration. Have tried both a record level and an item level hold. I'm testing using koha-testing-docker and on master. David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 6 06:52:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jun 2021 04:52:29 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #30 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121642&action=edit Bug 27741: acqui folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 6 07:08:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jun 2021 05:08:37 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #31 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121643&action=edit Bug 27741: onboarding folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 6 07:32:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jun 2021 05:32:51 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #32 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121644&action=edit Bug 27741: reserve folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 6 12:50:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jun 2021 10:50:49 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #33 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121645&action=edit Bug 27741: about.tt Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 6 12:57:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jun 2021 10:57:41 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #34 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121646&action=edit Bug 27741: main page Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to the main page of the staff client and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 6 21:02:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jun 2021 19:02:17 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #61 from Victor Grousset/tuxayo --- > 3/ Compare before patch and after for the Details page. IIUC, I should compare between - same as master: before "Update accountline-details page to show all history" - alt 1 at "Update accountline-details page to show all history" - alt 2 at "Further refinements to account-details table" - alt 3 at "Alternative Three - Account Details" Which are all "data compatible" so I can do step 1/ once and switch between the four code-states to be compared. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 6 22:38:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jun 2021 20:38:36 +0000 Subject: [Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 6 22:38:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jun 2021 20:38:40 +0000 Subject: [Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121641|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 121647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121647&action=edit Bug 28518: Display missing inputs for "Return to the last advanced search" When more than 3 search terms are passed on the advanced search form, the "Return to the last advanced search" feature does not display them. Test plan: Perform an adv search at the OPAC, enter more than 3 terms, launch the search, click the "Return to the last advanced search" link and confirm that all the entries are there. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 00:26:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jun 2021 22:26:50 +0000 Subject: [Koha-bugs] [Bug 27198] Sync marc21-retrieval-info-auth-dom.xml with retrieval-info-auth-dom.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27198 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #8 from David Nind --- Hi David. I had a go at testing. Test plan: 1. yaz-client unix:/var/run/koha/kohadev/authoritysocket 2. Enter these commands (see comment #1): . base authorities . format xml . elements zebra::snippet . find e . show 1 3. Result = diagnostic message: Diagnostic message(s) from database: [25] Specified element set name not valid for specified database -- v2 addinfo 'zebra::snippet' 4. Apply the patch 5. Stop and restart zebra (no need to rebuild the Zebra index): . koha-zebra --stop kohadev . pkill zebrasrv . koha-zebra --start kohadev 6. Repeat commands in step 2. 7. Result from show 1 = XML output: Sent presentRequest (1+1). Records: 1 Record type: XML Gontarski, S. E nextResultSetPosition = 2 Elapsed: 0.013929 I still get the results as per step 3. The only thing I noticed is that the version information is different when you connect - 2.0.59 instead of 4.2.30: root at kohadevbox:koha(bz27198)$ yaz-client unix:/var/run/koha/kohadev/authoritysocket Connecting...OK. Sent initrequest. Connection accepted by v3 target. ID : 81 Name : Zebra Information Server/GFS/YAZ Version: 2.0.59/5.27.1 872b6f92a024bb53bc1c11dfeccd47f065f98238 Options: search present delSet triggerResourceCtrl scan sort extendedServices namedResultSets Elapsed: 0.002171 Z> I am using koha-testing-docker. David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 00:39:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jun 2021 22:39:23 +0000 Subject: [Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #13 from David Nind --- Hi Rudolf. Could you write up a test plan so that I could test? This should be a step by step list of things to do, for example: Test plan: 1. [Steps to replicate the issue] 2. Apply the patch 3. [Steps that indicate the issue is fixed, such as repeating steps in 1 and the result expected] Here is a good example: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408#c3 And also: https://wiki.koha-community.org/wiki/Commit_messages#Test_plan Bearing in mind that those testing (like me) may not be developers or familiar with this area of Koha. David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 01:19:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jun 2021 23:19:41 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #56 from David Cook --- (In reply to Andrew Nugged from comment #51) > We discussed with Jonathan about "where better to place the file" but we > both agreed (JD, you say) so for a moment we can keep the package in C4/Atuh > as additional one for quick-est fix so we can provide working solution for > backporting, > > but the question still open to decide for later (let's create a separate > ticket after we accept this for not to forget, like TODO?): of course it's > better to keep CGI::Session::Serialize::yamlxs in own file/path, > .../CGI/Session/Serialize/yamlxs.pm > but that pollutes Koha lib folder - Jonathan said he keeps in mind to create > something separate, but that for later discussion. Please no. This is how we get into trouble in Koha. We don't need more technical debt. The quickest fix is to revert Bug 28317, and to do this right. But I'll look at putting together a patch so that we can avoid this horror. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 01:33:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jun 2021 23:33:21 +0000 Subject: [Koha-bugs] [Bug 12620] Proxy Add-on for Koha z39.50/SRU servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12620 --- Comment #10 from David Cook --- I've heard back from Adam Dickmeiss at Indexdata, and he said "you should be able to use [the connect syntax] for most client software of YAZ". So that's interesting! I'm tempted to do some testing, and build this functionality into Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 01:49:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jun 2021 23:49:14 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #57 from David Cook --- The database upgrade patch breaks the web installer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 01:50:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Jun 2021 23:50:42 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #58 from David Cook --- (In reply to David Cook from comment #57) > The database upgrade patch breaks the web installer. Actually, maybe something else is going on. I'll see what's up... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 03:03:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 01:03:29 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 03:03:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 01:03:33 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #59 from David Cook --- Created attachment 121648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121648&action=edit Bug 28489: Put CGI::Session::Serialize::yamlxs in lib directory This patch adds a "lib" directory to the source tree which gets mapped to the same directory as "C4" and "Koha" for single and standard installations. CGI::Session::Serialize::yamlxs is put into this "lib" directory. This patch also includes some changes so that dev/git installations work as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 03:04:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 01:04:03 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #60 from David Cook --- Dev test plan: 1. vi /etc/apache2/sites-enabled/kohadev.conf 2. Change "SetEnv PERL5LIB "/kohadevbox/koha" to SetEnv PERL5LIB "/kohadevbox/koha:/kohadevbox/koha/lib" 2b. service apache2 reload 3. cp debian/scripts/koha-functions.sh /usr/share/koha/bin/koha-functions.sh 4. koha-plack --restart kohadev 5. Log into http://localhost:8081/cgi-bin/koha/mainpage.pl 6. Go to CGI script http://localhost:8081/cgi-bin/koha/tools/export.pl (Note that this is still run in CGI even when using Plack) NOTE: We'll need to update koha-gitify (https://gitlab.com/koha-community/koha-gitify) to get that Apache configuration. There's no harm in updating it, since this is a backwards compatible change. See https://gitlab.com/koha-community/koha-gitify/-/merge_requests/2. -- Deploy test plan: Dev: 1. perl Makefile.PL 1a. Installation mode: dev 1b. Configuration directory: /opt/koha-dev 2. make 3. ls blib/PERL_MODULE_DIR/ 4. Note the following: C4 CGI cpanfile Koha Koha.pm 5. make install 5b. Note the output says the following: In order to use Koha's command-line batch jobs, you should set the following environment variables: export KOHA_CONF=/opt/koha-dev/etc/koha-conf.xml export PERL5LIB=/kohadevbox/koha:/kohadevbox/koha/lib 6. vi /opt/koha-dev/etc/koha-httpd.conf 7. Note the following: SetEnv PERL5LIB "/kohadevbox/koha:/kohadevbox/koha/lib" 6. rm -rf /opt/koha-dev 7. make clean Single: 1. perl Makefile.PL 1a. Installation mode: single 1b. Please specify the directory in which to install Koha: /opt/koha 2. make 3. ls blib/PERL_MODULE_DIR/ 4. Note the following: C4 CGI cpanfile Koha Koha.pm 5. make install 5b. Note the output says the following: In order to use Koha's command-line batch jobs, you should set the following environment variables: export KOHA_CONF=/opt/koha/etc/koha-conf.xml export PERL5LIB=/opt/koha/lib 6. ls /opt/koha/lib 7. Note the following: C4 CGI cpanfile Koha Koha.pm 8. vi /opt/koha/etc/koha-httpd.conf 9. Note the following: SetEnv PERL5LIB "/opt/koha/lib" 10. rm -rf /opt/koha 11. make clean Standard: 1. perl Makefile.PL 1a. accept all the defaults 2. make 3. ls blib/PERL_MODULE_DIR/ 4. Note the following: C4 CGI cpanfile Koha Koha.pm 5. make install 5b. Note there is a set_koha_ownership failure because of a missing "koha" user, but that's OK since this is an overly intensive process within koha-testing-docker anyway, and the install has already succeeded at this point. 6. ls /usr/share/koha/lib 7. Note the following: C4 CGI cpanfile Koha Koha.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 03:14:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 01:14:24 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #61 from David Cook --- An alternative to my patch would be to create a "PERL_MODULE_LOCAL_DIR" target/dirmap entry/token, and we could use "local_lib" or something like that. Another idea would be to keep PERL_MODULE_DIR as a target/dirmap, but change the token used in etc/misc files to something like "__PERL5LIB_DIRS__". I think that would be more labour intensive though. That said... it looks like "backend_directory" will be broken in etc/koha-conf.xml and misc/bin/sip_run.sh will be broken with my proposed dev install atm... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 03:15:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 01:15:10 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #62 from David Cook --- I really dislike this whole session mess but... I'll move my follow-up to a separate ticket, as it is blowing out a bit... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 03:16:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 01:16:47 +0000 Subject: [Koha-bugs] [Bug 28519] New: Add a 2nd directory for Perl modules Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Bug ID: 28519 Summary: Add a 2nd directory for Perl modules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Bug 28489 looks to add CGI::Session::Serializer::yamlxs, but it wants to hack it into C4::Auth. I rather we put it in a Perl "lib" directory. However, /usr/share/koha/lib only exists in a deployed Koha. There is no "lib" directory in the source tree. But we can fix that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 03:18:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 01:18:04 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28489 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 03:18:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 01:18:04 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 [Bug 28519] Add a 2nd directory for Perl modules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 03:18:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 01:18:39 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 03:19:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 01:19:00 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121648|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 04:23:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 02:23:46 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 04:23:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 02:23:49 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #1 from David Cook --- Created attachment 121649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121649&action=edit Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory This patch adds a "lib" directory to the source tree which gets mapped to the same directory as "C4" and "Koha" for single and standard installations. CGI::Session::Serialize::yamlxs is put into this "lib" directory. This patch also includes some changes so that dev/git installations work as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 04:24:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 02:24:07 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #2 from David Cook --- Dev test plan: 1. vi /etc/apache2/sites-enabled/kohadev.conf 2. Change "SetEnv PERL5LIB "/kohadevbox/koha" to SetEnv PERL5LIB "/kohadevbox/koha:/kohadevbox/koha/lib" 2b. service apache2 reload 3. cp debian/scripts/koha-functions.sh /usr/share/koha/bin/koha-functions.sh 4. koha-plack --restart kohadev 5. Log into http://localhost:8081/cgi-bin/koha/mainpage.pl 6. Go to CGI script http://localhost:8081/cgi-bin/koha/tools/export.pl (Note that this is still run in CGI even when using Plack) NOTE: We'll need to update koha-gitify (https://gitlab.com/koha-community/koha-gitify) to get that Apache configuration. There's no harm in updating it, since this is a backwards compatible change. See https://gitlab.com/koha-community/koha-gitify/-/merge_requests/2. -- Deploy test plan: Dev: 1. perl Makefile.PL 1a. Installation mode: dev 1b. Configuration directory: /opt/koha-dev 2. make 3. ls blib/PERL_MODULE_LIB_DIR/ 4. Note the following: CGI 5. make install 5b. Note the output says the following: In order to use Koha's command-line batch jobs, you should set the following environment variables: export KOHA_CONF=/opt/koha-dev/etc/koha-conf.xml export PERL5LIB=/kohadevbox/koha:/kohadevbox/koha/lib 6a. vi /opt/koha-dev/etc/koha-httpd.conf 6b. Note the following: SetEnv PERL5LIB "/kohadevbox/koha:/kohadevbox/koha/lib" 7a. vi /opt/koha-dev/etc/koha-worker.service 7b. Note the following: Environment=PERL5LIB=/kohadevbox/koha:/kohadevbox/koha/lib 8a. vi /opt/koha-dev/bin/koha-index-daemon-ctl.sh 8b. Note the following: PERL5LIB="/kohadevbox/koha:/kohadevbox/koha/lib" 9a. vi /opt/koha-dev/misc/koha-install-log 9b. Note the following: PERL_MODULE_LIB_DIR=/kohadevbox/koha/lib PERL5LIB_DIRS=/kohadevbox/koha:/kohadevbox/koha/lib 6. rm -rf /opt/koha-dev 7. make clean Single: 1. perl Makefile.PL 1a. Installation mode: single 1b. Please specify the directory in which to install Koha: /opt/koha 2. make 3. ls blib/PERL_MODULE_LIB_DIR/ 4. Note the following: CGI 5. make install 5b. Note the output says the following: In order to use Koha's command-line batch jobs, you should set the following environment variables: export KOHA_CONF=/opt/koha/etc/koha-conf.xml export PERL5LIB=/opt/koha/lib 6a. vi /opt/koha/etc/koha-httpd.conf 6b. Note the following: SetEnv PERL5LIB "/opt/koha/lib" 7a. vi /opt/koha/etc/koha-worker.service 7b. Note the following: Environment=PERL5LIB=/opt/koha/lib 8a. vi /opt/koha/bin/koha-index-daemon-ctl.sh 8b. Note the following: PERL5LIB="/opt/koha/lib" 9a. vi /opt/koha/misc/koha-install-log 9b. Note the following: PERL_MODULE_LIB_DIR=/opt/koha/lib PERL5LIB_DIRS=/opt/koha/lib 10. ls /opt/koha/lib 11. Note the following: C4 CGI cpanfile Koha Koha.pm 12. rm -rf /opt/koha 13. make clean Standard: 1. perl Makefile.PL 1a. accept all the defaults 2. make 3. ls blib/PERL_MODULE_LIB_DIR/ 4. Note the following: CGI 5. make install 5b. Note there is a set_koha_ownership failure because of a missing "koha" user, but that's OK since this is an overly intensive process within koha-testing-docker anyway, and the install has already succeeded at this point. 6a. vi /etc/koha/koha-httpd.conf 6b. Note the following: SetEnv PERL5LIB "/usr/share/koha/lib" 7a. vi /etc/koha/koha-worker.service 7b. Note the following: Environment=PERL5LIB=/usr/share/koha/lib 8a. vi /usr/share/koha/bin/koha-index-daemon-ctl.sh 8b. Note the following: PERL5LIB="/usr/share/koha/lib" 9a. vi /usr/share/koha/misc/koha-install-log 9b. Note the following: PERL_MODULE_LIB_DIR=/usr/share/koha/lib PERL5LIB_DIRS=/usr/share/koha/lib 10. ls /usr/share/koha/lib 11. Note the following: C4 CGI cpanfile Koha Koha.pm 12. make clean -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 04:27:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 02:27:36 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 04:27:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 02:27:40 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121584|0 |1 is obsolete| | --- Comment #63 from David Cook --- Created attachment 121650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121650&action=edit Bug 28489: Modify sessions.a_session from longtext to longblob This column contains serialized data, it should be a blob. And it fixes encoding issues. Test plan: 1. Apply patch and run updatedatabase 2. In $KOHA_CONF make sure that you have 0 3. Create 2 libraries: a. TESTÄ/Testä b. TEST✓/Test✓ 4. Go to the staff interface, change your library to Testä, then navigate to a few other pages, make sure there is no encoding problem with the library name in the top right corner 5. Do the same with Test✓ Signed-off-by: Petro Vashchuk Signed-off-by: Andrew Nugged Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 04:27:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 02:27:45 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121585|0 |1 is obsolete| | --- Comment #64 from David Cook --- Created attachment 121651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121651&action=edit Bug 28489: Modify sessions.a_session from longtext to longblob (kohastructure.sql) Signed-off-by: Petro Vashchuk Signed-off-by: Andrew Nugged Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 04:27:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 02:27:49 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121638|0 |1 is obsolete| | --- Comment #65 from David Cook --- Created attachment 121652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121652&action=edit Bug 28489: Add selenium tests Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 04:27:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 02:27:54 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121639|0 |1 is obsolete| | --- Comment #66 from David Cook --- Created attachment 121653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121653&action=edit Bug 28489: POD - CGI::Session::Serialize::yamlxs for CGI::Session Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 04:27:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 02:27:59 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121640|0 |1 is obsolete| | --- Comment #67 from David Cook --- Created attachment 121654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121654&action=edit Bug 28489: Don't deal with encoding during the serialization Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 04:30:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 02:30:49 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #68 from David Cook --- I don't like the hack of putting CGI::Session::Serialize::yamlxs, but signing off anyway - with the assumption that we'll also push Bug 28519 before doing a stable release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 04:36:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 02:36:50 +0000 Subject: [Koha-bugs] [Bug 27198] Sync marc21-retrieval-info-auth-dom.xml with retrieval-info-auth-dom.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27198 --- Comment #9 from David Cook --- Hmm interesting. Happy for you to mark this as Failed QA. I'm probably not going to review it any time soon, to be honest. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 04:41:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 02:41:08 +0000 Subject: [Koha-bugs] [Bug 11158] Authorities 'starts with' search returns the same as 'contains' when using ICU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11158 --- Comment #13 from David Cook --- (In reply to Katrin Fischer from comment #12) > The test plan works ok on current master for me, but I assume this is > because the kohadevbox is using ICU by default. I am not sure how to > activate ICU there. I think you mean using CHR by default. I wonder if we should change to ICU default some time. It involves updating /etc/koha/zebradb/etc/default.idx and then re-indexing Zebra. Although I didn't have that in my test plan I wonder why... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 07:11:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 05:11:28 +0000 Subject: [Koha-bugs] [Bug 27198] Sync marc21-retrieval-info-auth-dom.xml with retrieval-info-auth-dom.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27198 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 07:19:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 05:19:15 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 07:32:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 05:32:16 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 07:32:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 05:32:23 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121601|0 |1 is obsolete| | Attachment #121602|0 |1 is obsolete| | --- Comment #25 from Joonas Kylmälä --- Created attachment 121655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121655&action=edit Bug 28490: Bring back accidentally deleted relationship columns These were in active use before and were accidentally deleted in Bug 26995. This restores those deleted relationship columns. To test: 1) verify the borrower_modifications, borrowers, deletedborrowers contain the column exactly like it was before after applying these patches by comparing to the old kohastructure.sql version -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 07:32:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 05:32:28 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #26 from Joonas Kylmälä --- Created attachment 121656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121656&action=edit [DO NOT PUSH] Bug 28490: Add DBIx schema changes for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 07:33:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 05:33:28 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #27 from Joonas Kylmälä --- The atomicupdate incorrectly appended the relationship column to end of the tables instead of after borrowernotes column like it was originally. Fixed that now. Ready for sign-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 08:48:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 06:48:56 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 11:05:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 09:05:24 +0000 Subject: [Koha-bugs] [Bug 28520] New: Cancelling a hold that is in transit hides item's transit status Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Bug ID: 28520 Summary: Cancelling a hold that is in transit hides item's transit status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: joonas.kylmala at helsinki.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, martin.renvoize at ptfs-europe.com, nugged at gmail.com, stalkernoid at gmail.com When you cancel a hold that is in transfer to another branch the transfer status disappears from the item info. In the database you can see following transfers created for the items after the cancellation: > mysql> select * from branchtransfers\G > *************************** 1. row *************************** > branchtransfer_id: 1 > itemnumber: 549 > daterequested: 2021-06-07 08:11:05 > datesent: 2021-06-07 08:11:05 > frombranch: MPL > datearrived: NULL > datecancelled: 2021-06-07 08:13:22 > tobranch: CPL > comments: NULL > reason: Reserve > cancellation_reason: CancelReserve > *************************** 2. row *************************** > branchtransfer_id: 2 > itemnumber: 549 > daterequested: 2021-06-07 08:13:22 > datesent: NULL > frombranch: MPL > datearrived: NULL > datecancelled: NULL > tobranch: MPL > comments: NULL > reason: TransferCancellation > cancellation_reason: NULL The code in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt and catalogue/detail.pl checks whether $transfertwhen is defined but since this new code seems to create a transfer *request* there is not yet a datesent/transfertwhen created and so the transfer is not displayed. Bumbing priority to critical because this leads to librarians think availability of an item is different than what in reality it is and could cause miscommunication between the library and patrons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 11:06:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 09:06:03 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 11:26:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 09:26:36 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 --- Comment #7 from Jonathan Druart --- Hi David, Test plan: Hi David, Hi David, - Make sure you have TranslateNotices turned on - Set a default lang for a given patron - Have some overdue rules and translate notice templates - Generate overdues for the patron - Run the overdue_notices.pl script => The translated notice templates is picked - Remove the translated notice templates for the lang of the patron - Run the overdue_notices.pl script => Without this patch no notice is generated => With this patch a notice is generated using the default notice template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 11:31:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 09:31:07 +0000 Subject: [Koha-bugs] [Bug 27929] Regex option in item batch modification is hidden for itemcallnumber if 952$o linked to cn_browser plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27929 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #4 from Jonathan Druart --- See test plan from comment 0. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 11:31:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 09:31:12 +0000 Subject: [Koha-bugs] [Bug 27929] Regex option in item batch modification is hidden for itemcallnumber if 952$o linked to cn_browser plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27929 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 12:00:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 10:00:41 +0000 Subject: [Koha-bugs] [Bug 28462] TT tag on several lines break the translator tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28462 --- Comment #5 from Jonathan Druart --- Victor, what is the value in the PO? I've written this patch on top of 20.11 IIRC, but I am pretty sure it will fail on master if the tag is translated. Basically, after the "translate install" the IF TT tags must not appear in the po. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 12:15:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 10:15:46 +0000 Subject: [Koha-bugs] [Bug 28435] CanBookBeRenewed returns only a single status and falsely indicates renewal can be overridden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28435 --- Comment #1 from Jonathan Druart --- This made me think I tried "that" already on bug 25758. Is it what you meant? https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107894 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 12:18:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 10:18:48 +0000 Subject: [Koha-bugs] [Bug 28417] Authen::CAS::Client always loaded even if CAS is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28417 --- Comment #5 from Jonathan Druart --- (In reply to David Cook from comment #4) > (In reply to Jonathan Druart from comment #3) > > Test plan: confirm that CAS is still working > > What's the suggested way to test CAS? I don't know, Tomas promised me to test this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 12:32:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 10:32:33 +0000 Subject: [Koha-bugs] [Bug 28521] New: [OMNIBUS] Replace svc scripts Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28521 Bug ID: 28521 Summary: [OMNIBUS] Replace svc scripts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com Replace "svc" scripts with REST API calls -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 12:32:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 10:32:49 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28521 [Bug 28521] [OMNIBUS] Replace svc scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 12:32:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 10:32:49 +0000 Subject: [Koha-bugs] [Bug 28521] [OMNIBUS] Replace svc scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28521 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28377 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 [Bug 28377] Use the API to suspend/resume holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 13:35:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 11:35:52 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #28 from Jonathan Druart --- JSON serialization does not work (when SessionStorage=tmp), selenium tests from bug 28489 are failing. With longblob: # Failed test 'logged-in-branch-name set - SessionStorage=mysql, branchname=Test2❤️' # at t/db_dependent/selenium/regressions.t line 306. # got: 'Test2â¤ï¸Â' # expected: 'Test2❤️' With longtext: # Failed test 'logged-in-branch-name set - SessionStorage=tmp, branchname=Test2❤️' # at t/db_dependent/selenium/regressions.t line 306. # got: 'Test2â¤ï¸' # expected: 'Test2❤️' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 13:45:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 11:45:19 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #29 from Jonathan Druart --- And it's not possible to add a serializer that is not in the same dir as others, because of this code in Data::Session: 318 sub get_my_serializers 319 { 320 my($self) = @_; 321 my($path) = $self -> _get_pm_path('Serialize'); 322 323 # Warning: Use sort map{} read_dir, not map{} sort read_dir. But, why? 324 325 my(@serializer) = sort map{s/.pm//; $_} read_dir($path); 326 327 ($#serializer < 0) && die __PACKAGE__ . '. No serializers available'; 328 329 ($self -> verbose > 1) && $self -> log('Serializers: ' . join(', ', @serializer) ); 330 331 $self -> my_serializers(\@serializer); 332 333 } # End of get_my_serializers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 14:03:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 12:03:04 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #30 from Jonathan Druart --- (In reply to Jonathan Druart from comment #28) This comment was confusing, with JSON serialization we have: With longtext it's working with SessionStorage=mysql With longblob it's failing with mysql. But it does not work with SessionStorage=tmp. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 14:14:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 12:14:17 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121337|0 |1 is obsolete| | Attachment #121633|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart --- Created attachment 121657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121657&action=edit Bug 17427: Replace CGI::Session with Data::Session CGI::Session is not maintained for ages and seems quite buggy. It would be the culprit of random logout problems. Another issue is the following crazy code in CGI::Session::Driver::DBI sub DESTROY { my $self = shift; unless ( defined $self->{Handle} && $self->{Handle} -> ping ) { $self->set_error(__PACKAGE__ . '::DESTROY(). Database handle has gone away'); return; } unless ( $self->{Handle}->{AutoCommit} ) { $self->{Handle}->commit; } if ( $self->{_disconnect} ) { $self->{Handle}->disconnect; } } If AutoCommit is off, it will commit anyway... It causes some tests to fail (api) if SessionStorage is set to MySQL Note that PostgreSQL is not supported yet so no need to implement it. Test plan: 0/ The dependencies are not packaged for debian so far, so install it via cpan 1/ Test the 3 different values for SessionStorage 2/ Using different browsers (or sessions) login into Koha with different users. Naviguate => you should not be logged out 3/ Set SessionStorage to Memcached, stop memcached make sure that it defaults to file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 14:14:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 12:14:22 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #32 from Jonathan Druart --- Created attachment 121658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121658&action=edit Bug 17427: Use JSON serialization -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 14:14:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 12:14:27 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #33 from Jonathan Druart --- Created attachment 121659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121659&action=edit Bug 17427: Use our own YAML::XS serializer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 14:15:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 12:15:21 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #34 from Jonathan Druart --- And, FWIW, if I move the YAML::XS serializer (see last patch) in the Data/Session/Serialize directory, all tests pass (longblob). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 14:16:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 12:16:36 +0000 Subject: [Koha-bugs] [Bug 27929] Regex option in item batch modification is hidden for itemcallnumber if 952$o linked to cn_browser plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27929 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 14:16:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 12:16:39 +0000 Subject: [Koha-bugs] [Bug 27929] Regex option in item batch modification is hidden for itemcallnumber if 952$o linked to cn_browser plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27929 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118148|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry --- Created attachment 121660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121660&action=edit Bug 27929: Allow regex for subfield linked with cataloguing plugin Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 14:25:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 12:25:15 +0000 Subject: [Koha-bugs] [Bug 28522] New: Correct eslint errors in staff-global.js Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28522 Bug ID: 28522 Summary: Correct eslint errors in staff-global.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Blocks: 23833 Following coding guideline JS8: "Follow guidelines set by ESLint," some errors should be corrected in staff-global.js. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23833 [Bug 23833] [Omnibus] JavaScript should conform to coding guidelines recommended by ESLint -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 14:25:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 12:25:15 +0000 Subject: [Koha-bugs] [Bug 23833] [Omnibus] JavaScript should conform to coding guidelines recommended by ESLint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23833 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28522 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28522 [Bug 28522] Correct eslint errors in staff-global.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 14:52:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 12:52:35 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 14:52:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 12:52:39 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121595|0 |1 is obsolete| | Attachment #121596|0 |1 is obsolete| | Attachment #121597|0 |1 is obsolete| | Attachment #121598|0 |1 is obsolete| | Attachment #121599|0 |1 is obsolete| | Attachment #121600|0 |1 is obsolete| | Attachment #121655|0 |1 is obsolete| | Attachment #121656|0 |1 is obsolete| | --- Comment #28 from Peter Vashchuk --- Created attachment 121661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121661&action=edit Bug 28490: Revert "Bug 26995: Remove one remaining occurrence in moremember" This reverts commit c3b50e9e97e917090ce09283807168caaad3de4a. It was part of a patch set that removed actively used data and must be therefore reverted. Signed-off-by: Kyle M Hall Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 14:52:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 12:52:44 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #29 from Peter Vashchuk --- Created attachment 121662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121662&action=edit Bug 28490: Revert "Bug 26995: Remove occurrences in sample_patrons.yml" This reverts commit 690b073478b04c7c801058b49f85275281c502d5. It was part of a patch set that removed actively used data and must be therefore reverted. Signed-off-by: Kyle M Hall Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 14:52:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 12:52:49 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #30 from Peter Vashchuk --- Created attachment 121663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121663&action=edit Bug 28490: Revert "Bug 26995: Fix SQL syntax error on the about page" This reverts commit 1131bb687f14fef7b4cb5f3b194711e85f9227af. It was part of a patch set that removed actively used data and must be therefore reverted. Signed-off-by: Kyle M Hall Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 14:52:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 12:52:54 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #31 from Peter Vashchuk --- Created attachment 121664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121664&action=edit Bug 28490: Revert "Bug 26995: Remove references to relationship column" This reverts commit 1cc8a77c287666ed878ea58f17216793f52ce224. It was part of a patch set that removed actively used data and must be therefore reverted. Signed-off-by: Kyle M Hall Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 14:52:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 12:52:59 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #32 from Peter Vashchuk --- Created attachment 121665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121665&action=edit Bug 28490: Revert "Bug 26995: Drop column relationship from borrowers, deletedborrowers and borrower_modifications tables" This reverts commit ca0e7541ecdff13ada9ba8ffbd992c963959d30f. It was part of a patch set that removed actively used data and must be therefore reverted. Signed-off-by: Kyle M Hall Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 14:53:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 12:53:05 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #33 from Peter Vashchuk --- Created attachment 121666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121666&action=edit Bug 28490: Comment out the relationship data removing DB update step These columns that were actively used to store non-patron guarantor relationship info were dropped incorrectly. In a later patch the relationship fields will be re-added. Signed-off-by: Kyle M Hall Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 14:53:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 12:53:16 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #34 from Peter Vashchuk --- Created attachment 121667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121667&action=edit Bug 28490: Bring back accidentally deleted relationship columns These were in active use before and were accidentally deleted in Bug 26995. This restores those deleted relationship columns. To test: 1) verify the borrower_modifications, borrowers, deletedborrowers contain the column exactly like it was before after applying these patches by comparing to the old kohastructure.sql version Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 14:53:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 12:53:17 +0000 Subject: [Koha-bugs] [Bug 28522] Correct eslint errors in staff-global.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28522 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 14:53:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 12:53:20 +0000 Subject: [Koha-bugs] [Bug 28522] Correct eslint errors in staff-global.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28522 --- Comment #1 from Owen Leonard --- Created attachment 121668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121668&action=edit Bug 28522: Correct eslint errors in staff-global.js This patch makes minor corrections to staff-global.js in order to quiet warnings from ESLint. This includes: - Remove unused variables - Declare undeclared variables - Update list of global and exported variables and functions - Correct whitespace - Remove an unused function (paramOfUrl) To test, apply the patch and clear your browser cache if necessary. - Confirm that the first search header form field has focus when switching bewteen pages. - Confirm that text entered in any search header form field persists when you switch search header form tabs, e.g. a word typed into the "Check out" tab is copied to the "Check in" form when you switch to that tab. - Perform a search from the "Search the catalog" tab in the header. On the search results page and any following detail page your search term should remain in the header search form. - From a bibliographic detail page, confirm that selecting a list from the "Add to list" button menu correctly triggers a popup window. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 14:53:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 12:53:21 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #35 from Peter Vashchuk --- Created attachment 121669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121669&action=edit Bug 28490: Add DBIx schema changes for testing Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 15:31:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 13:31:03 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121141|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize --- Created attachment 121670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121670&action=edit Bug 27064: Only allow transferring a hold from the transfers page These patches replace the 'Waiting' button on the transfers page with a 'Transfer' button and correct some other related problem by passing the hold object to the template and using that to fetch patron info as well as passing the reserve_id through to ensure the correct hold is affected at all times To test: 1 - Place a hold for delivery at Library B 2 - Sign in at Library A 3 - Browse to Circulation->Transfers 4 - Attempt to transfer an item on the title with the hold to Library B 5 - You get a notice that hold was found (missing patron/branch info) 6 - You have the option to set the hold waiting - click it 7 - The transfer is generated and marked completed 8 - The hold is marked as waiting, but the item is still at Library A and no transfer is active 9 - The patron is notified that the hold is waiting 10 - Revert the hold or cancel and place a new one 11 - Apply patches 12 - Attempt transfer again 13 - You now have the option to transfer the hold 14 - Click that 15 - Hold is in transit and transfer is generated correctly 16 - Transfer again and choose 'cancel' 17 - Confirm hold is cancelled and transfer generated Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 15:31:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 13:31:07 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121142|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize --- Created attachment 121671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121671&action=edit Bug 27064: (QA follow-up) Do not send tobranchcd twice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 15:31:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 13:31:12 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121143|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize --- Created attachment 121672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121672&action=edit Bug 27064: (QA follow-up) Do not create transfer prior to accepting it This patch prevents the cancellations we were seeing. Transfers were being created pre-emtively for reserves in branchtransfers before the librarian had selected their prefered action. As such, we were getting double lines in the branchtransfers table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 15:31:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 13:31:17 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121144|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize --- Created attachment 121673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121673&action=edit Bug 27064: (QA follow-up) Pass 'replace' through to Koha::Item::Transfer->cancel The `replace` option found in Koha::Item->request_transfer should be passed through to Koha::Item::Transfer->cancel and prevent any reverse transfers from being queued in such cases. This prevents modItemTransfer from adding superflous reverse transfers whenever it is used. Test plan 1/ Run t/db_dependent/Koha/Item.t to prove the new tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 15:31:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 13:31:21 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #37 from Martin Renvoize --- Created attachment 121674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121674&action=edit Bug 27064: (QA follow-up) Remove superflous error message The reserve found error message should not be included in the errmsgloop as it's handled as a question in the previous step. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 16:12:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 14:12:38 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121674|0 |1 is obsolete| | --- Comment #38 from Joonas Kylmälä --- Created attachment 121675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121675&action=edit Bug 27064: (QA follow-up) Add error message only if we have one defined This moves the DestinationEqualsHolding error message addition to if clause so the value is added to %err hash only when there is actually an error. Then we only append to the @errmsgloop array the error message if one was defined. To test: 1) Create a hold request to a pickup library where the item currently is not 2) Add transfer to the pickup library using branchtransfers.pl and notice without this patch we get and empty message box but with this patch we don't get it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 16:44:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 14:44:37 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121670|0 |1 is obsolete| | Attachment #121671|0 |1 is obsolete| | Attachment #121672|0 |1 is obsolete| | Attachment #121673|0 |1 is obsolete| | Attachment #121675|0 |1 is obsolete| | --- Comment #39 from Joonas Kylmälä --- Created attachment 121676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121676&action=edit Bug 27064: Only allow transferring a hold from the transfers page These patches replace the 'Waiting' button on the transfers page with a 'Transfer' button and correct some other related problem by passing the hold object to the template and using that to fetch patron info as well as passing the reserve_id through to ensure the correct hold is affected at all times To test: 1 - Place a hold for delivery at Library B 2 - Sign in at Library A 3 - Browse to Circulation->Transfers 4 - Attempt to transfer an item on the title with the hold to Library B 5 - You get a notice that hold was found (missing patron/branch info) 6 - You have the option to set the hold waiting - click it 7 - The transfer is generated and marked completed 8 - The hold is marked as waiting, but the item is still at Library A and no transfer is active 9 - The patron is notified that the hold is waiting 10 - Revert the hold or cancel and place a new one 11 - Apply patches 12 - Attempt transfer again 13 - You now have the option to transfer the hold 14 - Click that 15 - Hold is in transit and transfer is generated correctly 16 - Transfer again and choose 'cancel' 17 - Confirm hold is cancelled and transfer generated Signed-off-by: Martin Renvoize Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 16:44:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 14:44:43 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #40 from Joonas Kylmälä --- Created attachment 121677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121677&action=edit Bug 27064: (QA follow-up) Do not send tobranchcd twice Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 16:44:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 14:44:48 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #41 from Joonas Kylmälä --- Created attachment 121678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121678&action=edit Bug 27064: (QA follow-up) Do not create transfer prior to accepting it This patch prevents the cancellations we were seeing. Transfers were being created pre-emtively for reserves in branchtransfers before the librarian had selected their prefered action. As such, we were getting double lines in the branchtransfers table. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 16:44:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 14:44:53 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #42 from Joonas Kylmälä --- Created attachment 121679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121679&action=edit Bug 27064: (QA follow-up) Pass 'replace' through to Koha::Item::Transfer->cancel The `replace` option found in Koha::Item->request_transfer should be passed through to Koha::Item::Transfer->cancel and prevent any reverse transfers from being queued in such cases. This prevents modItemTransfer from adding superflous reverse transfers whenever it is used. Test plan 1/ Run t/db_dependent/Koha/Item.t to prove the new tests pass Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 16:44:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 14:44:58 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #43 from Joonas Kylmälä --- Created attachment 121680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121680&action=edit Bug 27064: (QA follow-up) Add error message only if we have one defined This moves the DestinationEqualsHolding error message addition to if clause so the value is added to %err hash only when there is actually an error. Then we only append to the @errmsgloop array the error message if one was defined. To test: 1) Create a hold request to a pickup library where the item currently is not 2) Add transfer to the pickup library using branchtransfers.pl and notice without this patch we get and empty message box but with this patch we don't get it. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 16:45:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 14:45:33 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 16:46:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 14:46:50 +0000 Subject: [Koha-bugs] [Bug 27539] Warnings "Use of uninitialized value in split" on "Holds to pull" page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27539 --- Comment #3 from Peter Vashchuk --- (In reply to David Nind from comment #2) Hey David. Looks like since commit 2285c2d6 the file structure in the master changed pretty drastically, it moved away from raw SQL SELECT to DBIx::Class, which means no more "splits" that produce this exact warning. Basically what you're saying is correct, ticket and patch are obsolete now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 16:47:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 14:47:53 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121676|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize --- Created attachment 121681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121681&action=edit Bug 27064: Only allow transferring a hold from the transfers page These patches replace the 'Waiting' button on the transfers page with a 'Transfer' button and correct some other related problem by passing the hold object to the template and using that to fetch patron info as well as passing the reserve_id through to ensure the correct hold is affected at all times To test: 1 - Place a hold for delivery at Library B 2 - Sign in at Library A 3 - Browse to Circulation->Transfers 4 - Attempt to transfer an item on the title with the hold to Library B 5 - You get a notice that hold was found (missing patron/branch info) 6 - You have the option to set the hold waiting - click it 7 - The transfer is generated and marked completed 8 - The hold is marked as waiting, but the item is still at Library A and no transfer is active 9 - The patron is notified that the hold is waiting 10 - Revert the hold or cancel and place a new one 11 - Apply patches 12 - Attempt transfer again 13 - You now have the option to transfer the hold 14 - Click that 15 - Hold is in transit and transfer is generated correctly 16 - Transfer again and choose 'cancel' 17 - Confirm hold is cancelled and transfer generated Signed-off-by: Martin Renvoize Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 16:47:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 14:47:57 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121677|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize --- Created attachment 121682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121682&action=edit Bug 27064: (QA follow-up) Do not send tobranchcd twice Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 16:48:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 14:48:02 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121678|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize --- Created attachment 121683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121683&action=edit Bug 27064: (QA follow-up) Do not create transfer prior to accepting it This patch prevents the cancellations we were seeing. Transfers were being created pre-emtively for reserves in branchtransfers before the librarian had selected their prefered action. As such, we were getting double lines in the branchtransfers table. Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 16:48:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 14:48:06 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121679|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize --- Created attachment 121684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121684&action=edit Bug 27064: (QA follow-up) Pass 'replace' through to Koha::Item::Transfer->cancel The `replace` option found in Koha::Item->request_transfer should be passed through to Koha::Item::Transfer->cancel and prevent any reverse transfers from being queued in such cases. This prevents modItemTransfer from adding superflous reverse transfers whenever it is used. Test plan 1/ Run t/db_dependent/Koha/Item.t to prove the new tests pass Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 16:48:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 14:48:10 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121680|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize --- Created attachment 121685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121685&action=edit Bug 27064: (QA follow-up) Add error message only if we have one defined This moves the DestinationEqualsHolding error message addition to if clause so the value is added to %err hash only when there is actually an error. Then we only append to the @errmsgloop array the error message if one was defined. To test: 1) Create a hold request to a pickup library where the item currently is not 2) Add transfer to the pickup library using branchtransfers.pl and notice without this patch we get and empty message box but with this patch we don't get it. Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 16:48:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 14:48:56 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #49 from Martin Renvoize --- Excellent, your alternative to mine is much cleaner at the end there Joonas.. Thanks. Added my SO stamp and setting PQA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 17:12:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 15:12:06 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #1 from Martin Renvoize --- Created attachment 121686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121686&action=edit Bug 28520: Update detail to display cancelled in transit transfers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 17:12:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 15:12:38 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22160 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 [Bug 22160] OMNIBUS: Transfers enhancements -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 17:12:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 15:12:38 +0000 Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28520 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 [Bug 28520] Cancelling a hold that is in transit hides item's transit status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 18:03:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 16:03:22 +0000 Subject: [Koha-bugs] [Bug 27720] Print Holds List slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27720 --- Comment #2 from Daniel Gaghan --- The hold list slip would be printed out by a staff member in receipt upon a user's requests for a hardcopy list of items they have on hold and where they are in the current hold queue. We have a number of users who have requested this feature. Currently the only option that comes close to this is the print account summary and this uses a lot of paper for just getting a list of holds and does not give all the information our users require. Our users plan to use the holds list slip to keep track of what they have requested also use it to check against what they currently have on the hold shelf so they do not missing anything. This feature is especially useful for users who do not have internet access. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 18:08:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 16:08:31 +0000 Subject: [Koha-bugs] [Bug 28488] Javascript error in self-checkout (__ is not defined) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 18:10:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 16:10:54 +0000 Subject: [Koha-bugs] [Bug 28488] Javascript error in self-checkout (__ is not defined) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 18:10:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 16:10:58 +0000 Subject: [Koha-bugs] [Bug 28488] Javascript error in self-checkout (__ is not defined) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 --- Comment #5 from Owen Leonard --- Created attachment 121687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121687&action=edit Bug 28488: Javascript error in self-checkout (__ is not defined) This patch adds inclusion of the internationalization JavaScript which is required by the newest version of the DataTables include. It references the double-underscore function provided by i18n.js. To test, apply the patch and log into the self-checkout system as a user with checkouts. The table of checkouts should display correctly and there should be no JavaScript errors in the console. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 18:34:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 16:34:57 +0000 Subject: [Koha-bugs] [Bug 28443] Terminology: Issuing should be Checking out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28443 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 18:40:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 16:40:51 +0000 Subject: [Koha-bugs] [Bug 28443] Terminology: Issuing should be Checking out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28443 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 18:40:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 16:40:54 +0000 Subject: [Koha-bugs] [Bug 28443] Terminology: Issuing should be Checking out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28443 --- Comment #1 from Owen Leonard --- Created attachment 121688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121688&action=edit Bug 28443: Terminology: Issuing should be Checking out This patch modifies the title element of the batch checkout page so that it uses the phrase "Batch check out" instead of "Issuing." To test, apply the patch and enable BatchCheckouts system preference. - Open a patron for checkout who has a category included in the BatchCheckoutsValidCategories system preference. - Click the "Batch check out" tab and confirm that the page's title is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 19:13:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 17:13:09 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #2 from Joonas Kylmälä --- Created attachment 121689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121689&action=edit Bug 28520: Don't allow simply cancelling a transfer If we just cancel a transfer it will be in a state where we don't know where it originated from / was last seen. Let's treat cancelled transfers also as they would be in transit. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 19:13:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 17:13:13 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #3 from Joonas Kylmälä --- Created attachment 121690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121690&action=edit Bug 28520: Allow creating a new transit request for item with cancelled transfer Setting $validTransfer=1 will allow us to trigger automatically a new transfer at check-in time. With this patch applied it is possible to return back home an item with cancelled hold that is in-transit. This is a fix to the regression caused by bug 26078. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 19:13:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 17:13:18 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #4 from Joonas Kylmälä --- Created attachment 121691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121691&action=edit Bug 28520: Don't create a new transfer for a lost item We need to pass 'replace' to cancel() method, otherwise a new transfer (request) is automatically generated back to the original sending branch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 20:23:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 18:23:14 +0000 Subject: [Koha-bugs] [Bug 28511] Road types in OPAC should prefer OPAC description if one exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28511 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|20.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 20:55:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 18:55:38 +0000 Subject: [Koha-bugs] [Bug 28511] Road types in OPAC should prefer OPAC description if one exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28511 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 20:55:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 18:55:41 +0000 Subject: [Koha-bugs] [Bug 28511] Road types in OPAC should prefer OPAC description if one exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28511 --- Comment #1 from Owen Leonard --- Created attachment 121692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121692&action=edit Bug 28511: Road types in OPAC should prefer OPAC description if one exists This patch modifies the patron entry form in the OPAC so that if street types are defined in authorized values, the OPAC description is preferred. To test, apply the patch and go to Administration -> Authorized values. - Add or edit entries in the "ROADTYPE" category. - Some entries should have only the "Description" set, while others should have "Description" and "Description (OPAC)". - In the OPAC, open the patron registration page. Check the "Stree type" drop down in the "Main address" section. - For entries which have an OPAC description, this value should show. - For entries without an OPAC description the default should show. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 20:56:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 18:56:10 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121689|0 |1 is obsolete| | Attachment #121690|0 |1 is obsolete| | Attachment #121691|0 |1 is obsolete| | --- Comment #5 from Joonas Kylmälä --- Created attachment 121693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121693&action=edit Bug 28520: Create cancelled hold's transfer back after previous transfer finishes This fixes regression caused by "Bug 12362: Cancel transfer with hold cancelation" where cancelled hold's transfer didn't show up in intranet and opac because it create a new transfer that was not yet put in in-transit state. The original idea of bug 12362 was to be able to trigger transfer back home if a hold was cancelled. We can do it more simply by setting the $validTransfer variable true in the item check-in code when we are dealing with Reserve transfers. To test: 1) Apply patch 1) Have biblio with item in branch A 2) Create a new hold with a pickup library to branch B 3) Check-in the item at branch A and confirm the hold and transfer 4) Cancel the hold 5) Check-in the hold at branch B and notice it prompt to return it to branch A -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 20:57:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 18:57:56 +0000 Subject: [Koha-bugs] [Bug 28511] Road types in OPAC should prefer OPAC description if one exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28511 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 21:36:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 19:36:39 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 --- Comment #8 from David Nind --- (In reply to Jonathan Druart from comment #7) Thanks Jonathan! For some reason I couldn't get notices to generate for overdue items I created, so will leave for someone else more familiar with this to test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 21:45:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 19:45:58 +0000 Subject: [Koha-bugs] [Bug 27539] Warnings "Use of uninitialized value in split" on "Holds to pull" page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27539 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED --- Comment #4 from David Nind --- Thanks Peter for having a look. It's good that it is fixed! I have changed the status for this bug to resolved. David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 21:45:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 19:45:59 +0000 Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Bug 25790 depends on bug 27539, which changed state. Bug 27539 Summary: Warnings "Use of uninitialized value in split" on "Holds to pull" page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27539 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 21:53:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 19:53:03 +0000 Subject: [Koha-bugs] [Bug 28443] Terminology: Issuing should be Checking out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28443 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 21:53:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 19:53:07 +0000 Subject: [Koha-bugs] [Bug 28443] Terminology: Issuing should be Checking out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28443 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121688|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 121694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121694&action=edit Bug 28443: Terminology: Issuing should be Checking out This patch modifies the title element of the batch checkout page so that it uses the phrase "Batch check out" instead of "Issuing." To test, apply the patch and enable BatchCheckouts system preference. - Open a patron for checkout who has a category included in the BatchCheckoutsValidCategories system preference. - Click the "Batch check out" tab and confirm that the page's title is correct. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 22:05:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 20:05:16 +0000 Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon or exclamation point is in 245$a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484 John Yorio changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jyorio at equinoxinitiative.or | |g --- Comment #1 from John Yorio --- I'm just confirming this error occurs. Staff saw Internal Server Error when trying to view a bib record. Looking in the log files, I saw the "[query_shard_exception] Failed to parse query [(host-item: ...." message as per Bohdan's original post. Editing the bib record by directly bringing it up with addbiblio.pl?biblionumber= worked and I removed the colon at the end of the 245a. The record could then be viewed. Adding the colon back caused the error again. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 22:20:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 20:20:06 +0000 Subject: [Koha-bugs] [Bug 28488] Javascript error in self-checkout (__ is not defined) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 22:20:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 20:20:09 +0000 Subject: [Koha-bugs] [Bug 28488] Javascript error in self-checkout (__ is not defined) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121687|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 121695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121695&action=edit Bug 28488: Javascript error in self-checkout (__ is not defined) This patch adds inclusion of the internationalization JavaScript which is required by the newest version of the DataTables include. It references the double-underscore function provided by i18n.js. To test, apply the patch and log into the self-checkout system as a user with checkouts. The table of checkouts should display correctly and there should be no JavaScript errors in the console. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 22:33:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 20:33:39 +0000 Subject: [Koha-bugs] [Bug 28511] Road types in OPAC should prefer OPAC description if one exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28511 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 22:33:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 20:33:43 +0000 Subject: [Koha-bugs] [Bug 28511] Road types in OPAC should prefer OPAC description if one exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28511 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121692|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 121696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121696&action=edit Bug 28511: Road types in OPAC should prefer OPAC description if one exists This patch modifies the patron entry form in the OPAC so that if street types are defined in authorized values, the OPAC description is preferred. To test, apply the patch and go to Administration -> Authorized values. - Add or edit entries in the "ROADTYPE" category. - Some entries should have only the "Description" set, while others should have "Description" and "Description (OPAC)". - In the OPAC, open the patron registration page. Check the "Stree type" drop down in the "Main address" section. - For entries which have an OPAC description, this value should show. - For entries without an OPAC description the default should show. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 23:03:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 21:03:17 +0000 Subject: [Koha-bugs] [Bug 28523] New: Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523 Bug ID: 28523 Summary: Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8 Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: development at cm-portimao.pt QA Contact: testopia at bugs.koha-community.org CGI::Compile::ROOT::usr_share_koha_intranet_cgi_2dbin_reports_bor_issues_top_2epl::calculate(): DBI Exception: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'RANK, borrowers.borrowernumber AS ID FROM `old_issues` LEFT JO' at line 1 [for Statement "SELECT CONCAT_WS('', borrowers.surname , ",\t", borrowers.firstname), COUNT(*) AS RANK, borrowers.borrowernumber AS ID FROM `old_issues` LEFT JOIN borrowers USING(borrowernumber) LEFT JOIN items USING(itemnumber) LEFT JOIN biblioitems USING(biblioitemnumber) WHERE old_issues.borrowernumber IS NOT NULL AND old_issues.issuedate > '2021-06-01' AND old_issues.issuedate < '2021-06-07' GROUP BY borrowers.borrowernumber ORDER BY RANK DESC LIMIT 5"] at /usr/share/koha/intranet/cgi-bin/reports/bor_issues_top.pl line 70 Rank is a MySQL reserved word defined in MySQL version 8.0.2 https://dev.mysql.com/doc/refman/8.0/en/keywords.html#keywords-8-0-detailed-R -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 23:14:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 21:14:15 +0000 Subject: [Koha-bugs] [Bug 28524] New: Most-circulated items (cat_issues_top.pl) is failing with MySQL 8 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28524 Bug ID: 28524 Summary: Most-circulated items (cat_issues_top.pl) is failing with MySQL 8 Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: development at cm-portimao.pt QA Contact: testopia at bugs.koha-community.org CGI::Compile::ROOT::usr_share_koha_intranet_cgi_2dbin_reports_cat_issues_top_2epl::calculate(): DBI Exception: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'RANK, biblio.biblionumber AS ID, itemcallnumber as CALLNUM, ccode as CCODE, loca' at line 1 [for Statement "SELECT DISTINCT biblio.title, COUNT(biblio.biblionumber) AS RANK, biblio.biblionumber AS ID, itemcallnumber as CALLNUM, ccode as CCODE, location as LOC FROM `old_issues` LEFT JOIN items USING(itemnumber) LEFT JOIN biblio USING(biblionumber) LEFT JOIN biblioitems USING(biblionumber) LEFT JOIN borrowers USING(borrowernumber) WHERE 1 AND old_issues.issuedate > '2021-01-01' AND old_issues.issuedate < '2021-06-30' AND old_issues.branchcode like 'p' group by biblio.biblionumber order by RANK DESC"] at /usr/share/koha/intranet/cgi-bin/reports/cat_issues_top.pl line 67 Rank is a MySQL reserved word defined in MySQL version 8.0.2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 23:43:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 21:43:07 +0000 Subject: [Koha-bugs] [Bug 28502] Changing patron category from child to adult doesn't delete non patron guarantor data. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28502 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 23:46:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 21:46:37 +0000 Subject: [Koha-bugs] [Bug 28335] Making patron attributes required can cause issues in multi branch systems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28335 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 23:58:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 21:58:00 +0000 Subject: [Koha-bugs] [Bug 28522] Correct eslint errors in staff-global.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28522 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 7 23:58:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 21:58:04 +0000 Subject: [Koha-bugs] [Bug 28522] Correct eslint errors in staff-global.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28522 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121668|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 121697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121697&action=edit Bug 28522: Correct eslint errors in staff-global.js This patch makes minor corrections to staff-global.js in order to quiet warnings from ESLint. This includes: - Remove unused variables - Declare undeclared variables - Update list of global and exported variables and functions - Correct whitespace - Remove an unused function (paramOfUrl) To test, apply the patch and clear your browser cache if necessary. - Confirm that the first search header form field has focus when switching bewteen pages. - Confirm that text entered in any search header form field persists when you switch search header form tabs, e.g. a word typed into the "Check out" tab is copied to the "Check in" form when you switch to that tab. - Perform a search from the "Search the catalog" tab in the header. On the search results page and any following detail page your search term should remain in the header search form. - From a bibliographic detail page, confirm that selecting a list from the "Add to list" button menu correctly triggers a popup window. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 00:12:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 22:12:38 +0000 Subject: [Koha-bugs] [Bug 28525] New: TinyMCE for system prefs does some automatic code clean up Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28525 Bug ID: 28525 Summary: TinyMCE for system prefs does some automatic code clean up Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If you look at Bug 24764 and Bug 26942 we adjusted the TinyMCE for the News tool so it will not do some types of automatic code clean up. The TinyMCE editor for system preferences which can be enabled by 'UseWYSIWYGinSystemPreferences' has the same problems. We should make the configurations the same. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 00:12:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 22:12:45 +0000 Subject: [Koha-bugs] [Bug 28525] TinyMCE for system prefs does some automatic code clean up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28525 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 00:22:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 22:22:57 +0000 Subject: [Koha-bugs] [Bug 28525] TinyMCE for system prefs does some automatic code clean up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28525 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 00:23:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 22:23:01 +0000 Subject: [Koha-bugs] [Bug 28525] TinyMCE for system prefs does some automatic code clean up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28525 --- Comment #1 from Lucas Gass --- Created attachment 121698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121698&action=edit Bug 28525: Dont let TinyMCE do code cleanup To Test: 1. Turn on 'UseWYSIWYGinSystemPreferences' 2. Go to a system preference like 'RestrictedPageContent' 3. Try entering something like '' in the Source Code window 4. It gets cleaned up by the editor 5. Try something like 'TEST' 6. It's cleaned up by the editor. 7. Try something like '' 8. Cleaned up by editor. 9. Apply patch 10. Try step 3, 5, and 7 again. 11. It should not be changed by the editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 01:16:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Jun 2021 23:16:14 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #35 from David Cook --- (In reply to Jonathan Druart from comment #34) > And, FWIW, if I move the YAML::XS serializer (see last patch) in the > Data/Session/Serialize directory, all tests pass (longblob). Does this have an unlisted dependency on Bug 28519? I'm just curious since the serializers are in a "lib" directory. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 06:23:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 04:23:45 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121622|0 |1 is obsolete| | --- Comment #35 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121699&action=edit Bug 27741: tools folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 07:27:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 05:27:18 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #36 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121700&action=edit Bug 27741: installer folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 07:29:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 05:29:56 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 07:47:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 05:47:30 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #37 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121701&action=edit Bug 27741: ill folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 07:48:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 05:48:05 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 08:18:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 06:18:09 +0000 Subject: [Koha-bugs] [Bug 12620] Proxy Add-on for Koha z39.50/SRU servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12620 --- Comment #11 from David Cook --- Adam inspired me to test this, and I got a proof-of-concept working in Docker using a Squid proxy. Here are the steps if someone wants to reproduce my efforts: Windows: 1. docker pull sameersbn/squid:3.5.27-2 2. docker run --name squid --publish 3128:3128 sameersbn/squid:3.5.27-2 3. docker cp squid:/etc/squid/squid.conf ./squid.conf.default 4. cp ./squid.conf.default ./squid.conf 5. sed -i 's/http_access deny all/http_access allow all/' ./squid.conf 6. sed -i 's/http_access deny CONNECT/http_access allow CONNECT/' ./squid.conf 7. docker stop squid 8. docker rm squid 9. docker run --name squid --publish 3128:3128 --volume "/$(PWD)/squid.conf:/etc/squid/squid.conf" --net koha_kohanet sameersbn/squid:3.5.27-2 Koha container: 1. http_proxy=squid:3128 curl -v https://www.google.com 2a. yaz-client connect:squid:3128,tcp:lx2.loc.gov:210 2b. base LCDB 2c. find test 2d. show 1 3a. Use ZOOM in a Perl script to connect to Squid proxy 3b. This works (shows 10000 results connecting to LOC LCDB database and searching for as title of ‘test’) 3c. Script included below* * #!/usr/bin/perl use ZOOM; my $conn = new ZOOM::Connection('connect:squid:3128,tcp:lx2.loc.gov:210'); $conn->option( databaseName => 'LCDB' ); my $rs = $conn->search_pqf('@attr 1=4 test'); my $n = $rs->size(); warn $n; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 08:48:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 06:48:42 +0000 Subject: [Koha-bugs] [Bug 12620] Proxy Add-on for Koha z39.50/SRU servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12620 --- Comment #12 from David Cook --- Actually for readability we could change 'connect:squid:3128,tcp:lx2.loc.gov:210' to 'connect:squid:3128,lx2.loc.gov:210'. To get this working for Koha... We would need to change our syntax in C4::Breeding::_create_connection to use '$obj->connect($host)' instead of '$obj->connect( $server->{host}, $server->{port} )'. We would also need some way to specify the HTTP Proxy. Option 1: Add a http_proxy field (or http_proxy_hostname and http_proxy_port fields) to the z3950servers table. Option 2: Specify a http_proxy in the koha-conf.xml. This might be a better option, since it's more centralized. Plus, there might be other parts of Koha that would benefit from being able to go through a HTTP proxy. (For example OverDrive integration?) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 08:52:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 06:52:38 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #6 from Martin Renvoize --- Wont this also prompt for return when the reserve hasn't been cancelled? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 08:53:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 06:53:31 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #7 from Martin Renvoize --- Ah, I see.. we check for resfound later.. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 08:54:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 06:54:06 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #8 from Joonas Kylmälä --- (In reply to Martin Renvoize from comment #6) > Wont this also prompt for return when the reserve hasn't been cancelled? No. I was supposed to write a better commit message but it got late, and working on it now as I got my koha-testing-docker working. Please grep the validTransfer variable and you see later it checks that it doesn't have a hold found. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 08:54:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 06:54:43 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #9 from Martin Renvoize --- But.. this will follow 'ReturnToHome/ReturnToHolding' rather than 'Reverse' the original transfer.. I suppose that doesn't really matter. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 09:39:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 07:39:02 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|28489 |28519 --- Comment #36 from Jonathan Druart --- Yes David. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 [Bug 28519] Add a 2nd directory for Perl modules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 09:39:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 07:39:02 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17427 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 [Bug 17427] Replace CGI::Session with Data::Session -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 09:39:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 07:39:02 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17427 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 [Bug 17427] Replace CGI::Session with Data::Session -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 10:16:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 08:16:55 +0000 Subject: [Koha-bugs] [Bug 25883] Show transfer on checkin screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25883 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 10:17:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 08:17:19 +0000 Subject: [Koha-bugs] [Bug 22614] Request migration from one backend to another should not create new request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22614 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 10:17:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 08:17:37 +0000 Subject: [Koha-bugs] [Bug 27170] ILL availability should be able to display arbitrary links to related resources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 10:26:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 08:26:40 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #51 from Martin Renvoize --- I can't reproduce this error either.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 10:28:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 08:28:06 +0000 Subject: [Koha-bugs] [Bug 28526] New: Impossible to search only zero Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28526 Bug ID: 28526 Summary: Impossible to search only zero Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In staff interface and OPAC, searching only zero leads to advanced search page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 10:28:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 08:28:27 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121071|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize --- Created attachment 121702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121702&action=edit Bug 24434: Reinstate updateWrongTransfer This patch re-instates the call to updateWrongTransfer to ensure the transfer line is updated to reflect the new frombranch. Test plan note: when applying the patches, also update the database 1/ Check an item out from it's home library 2/ Check the item in at another library (with AutomaticItemReturn system preferences enabled) 2a/ Accept the transfer and note we now have a transfer present from the items check-in library to it's home library 3/ Check the item in at a third library 3a/ Note you are asked to return the item to it's home library. 3b/ With the patch applied, the modal title should highlight that a 'Wrong transfer' was detected. 4/ Go to the item record and note the holding library has been updated to reflect where the item was most recently checked in. 4a/ With the patch applied the item status should reflect the last checked in branch as the 'from' branch of the transfer. 5/ check-in from a 4th library, but use the 'Print slip' option for accepting the transfer and confirm that also works. 6/ check-in from a 5th library, but use the 'Cancel' option and check that this results in the item staying at it's current location and the final transfer having been cancelled. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 10:28:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 08:28:31 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121073|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize --- Created attachment 121703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121703&action=edit Bug 24434: Add Unit Tests for relations This patch adds unit tests for the newly introduced to_library (and also add the missing test for the existing from_library). Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 10:28:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 08:28:35 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121074|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize --- Created attachment 121704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121704&action=edit Bug 24434: Unit tests for updateWrongTransfer Add unit tests to cover updateWrongTransfer Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 10:28:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 08:28:40 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121075|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize --- Created attachment 121705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121705&action=edit Bug 24434: Submit on print slip This patch ensures that the print slip option on the WrongTransfer modal also submits the form and thus triggers the actual transfer of the item. We also prevent a double transfer submission (and thus a cancellation line appearing in the branchtransfers table) for the case where a transfer back home is triggered. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 10:28:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 08:28:44 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121515|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize --- Created attachment 121706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121706&action=edit Bug 24434: Add 'WrongTransfer' to cancellation_reasons Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 10:28:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 08:28:49 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 --- Comment #57 from Martin Renvoize --- Created attachment 121707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121707&action=edit Bug 24434: DBIC Update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 10:29:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 08:29:15 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 --- Comment #58 from Martin Renvoize --- Minor rebase, and added the DBIC update patch in case that's what Kyle was missing ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 10:32:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 08:32:05 +0000 Subject: [Koha-bugs] [Bug 28526] Impossible to search only zero In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28526 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 10:40:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 08:40:50 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 10:40:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 08:40:53 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121686|0 |1 is obsolete| | Attachment #121693|0 |1 is obsolete| | --- Comment #10 from Joonas Kylmälä --- Created attachment 121708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121708&action=edit Bug 28520: Revert "Bug 12362: (QA follow-up) Fix ModItemTransfer cancellation handling" This reverts commit fbba09f63f200d3e57a8612554984d807867cf84. This commit was part of a series adding adding reverse transfers, i.e. transfers that were created for transfers that were cancelled and we wanted the item to return back to its sending library. This however hid the information about transfer happening and we need another approach to the problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 10:40:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 08:40:58 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #11 from Joonas Kylmälä --- Created attachment 121709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121709&action=edit Bug 28520: Revert "Bug 12362: Cancel transfer with hold cancelation" This reverts commit 6c105829144cd341a4bc65ad8d0ee1f996b423d4. This commit was part of a series adding adding reverse transfers, i.e. transfers that were created for transfers that were cancelled and we wanted the item to return back to its sending library. This however hid the information about transfer happening and we need another approach to the problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 10:41:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 08:41:02 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #12 from Joonas Kylmälä --- Created attachment 121710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121710&action=edit Bug 28520: Revert "Bug 12362: Reverse transfer upon cancellation" This reverts commit d0407686eb070c5bdf0302147a198027abea5ac0. This commit was part of a series adding adding reverse transfers, i.e. transfers that were created for transfers that were cancelled and we wanted the item to return back to its sending library. This however hid the information about transfer happening and we need another approach to the problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 10:41:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 08:41:07 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #13 from Joonas Kylmälä --- Created attachment 121711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121711&action=edit Bug 28520: Bring back TransferCancellation reason handling from reverted Bug 12362 The code from Bug 12362 was reverted but there might be still in database transfers with the reason 'TransferCancellation' so we need to restore the code to handle displaying that information. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 10:41:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 08:41:12 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #14 from Joonas Kylmälä --- Created attachment 121712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121712&action=edit Bug 28520: Allow creating a transfer back automatically if a hold is canceled during transit This fixes regression caused by "Bug 12362: Cancel transfer with hold cancelation" where cancelled hold's transfer didn't show up in intranet and opac because it create a new transfer that was not yet put in in-transit state. The original idea of bug 12362 was to be able to trigger transfer back home if a hold was cancelled (a regression caused by bug 26078). However, we can do it more simply by setting the $validTransfer variable true in the item check-in code when we are dealing with Reserve transfers. More down in the AddReturn() code there is also a check "and !$resfound" to make sure we only try to trigger the transfer back home automatically if there is no hold waiting at the current location the item arrived in. It should be noted however that now we only display generic message for the automatic transfer reason. Bug 12362 made the return display as the reason "Transfer was cancelled whilst in transit". However, since this fixes the original regressions caused by bug 26078 and restores similar behaviour to that I think giving a more descriptive message for example regarding a hold being cancelled can be considered a further enhancement. To test: 1) Apply patch 1) Have biblio with item in branch A 2) Create a new hold with a pickup library to branch B 3) Check-in the item at branch A and confirm the hold and transfer 4) Cancel the hold 5) Check-in the hold at branch B and notice it prompt to return it to branch A -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 10:44:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 08:44:32 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12362 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26078 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12362 [Bug 12362] Branch transfer records orphaned on cancelled holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 10:44:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 08:44:32 +0000 Subject: [Koha-bugs] [Bug 12362] Branch transfer records orphaned on cancelled holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12362 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28520 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 [Bug 28520] Cancelling a hold that is in transit hides item's transit status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 10:44:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 08:44:32 +0000 Subject: [Koha-bugs] [Bug 26078] "Item returns to issuing library" creates infinite transfer loop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26078 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28520 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 10:52:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 08:52:53 +0000 Subject: [Koha-bugs] [Bug 28526] Impossible to search only zero In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28526 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 10:52:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 08:52:56 +0000 Subject: [Koha-bugs] [Bug 28526] Impossible to search only zero In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28526 --- Comment #1 from Fridolin Somers --- Created attachment 121713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121713&action=edit Bug 28526: Impossible to search only zero In staff interface and OPAC, searching only zero leads to advanced search page. Test plan : 1) Go to opac home page 2) Enter 0 into search field => Without patch you go to advanced search page => With patch you go to results page 3) Idem on staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 11:02:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 09:02:17 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #15 from Joonas Kylmälä --- (In reply to Martin Renvoize from comment #9) > But.. this will follow 'ReturnToHome/ReturnToHolding' rather than 'Reverse' > the original transfer.. I suppose that doesn't really matter. That was actually the original behaviour before bug 26078 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 12:58:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 10:58:28 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121095|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 121714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121714&action=edit Bug 28294: Add 'WrongTransfer' to transfer reason enum This patch adds the 'WrongTransfer' value to the 'reason' enum in the branchtransfers table. This is so we can use it as a reason for the subsequent transfer when a trainsfer is triggered by a checkin at an incorrect branch after transfer has been initiated. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 12:58:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 10:58:32 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121096|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 121715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121715&action=edit Bug 28294: Convert updateWrongTransfer to use request_transfer This patch is an interim patch to prove that the updated request_transfer method achieves the same as updateWrongTransfer. Test plan 1/ Run t/db_dependant/Circulation.t before and after applying this patch. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 12:58:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 10:58:36 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121097|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 121716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121716&action=edit Bug 28294: Remove use of updateWrongTransfer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 12:58:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 10:58:57 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 12:59:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 10:59:02 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 13:00:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 11:00:30 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28382 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 [Bug 28382] 'Reserve' should be passed through as transfer reason appropriately in branchtransfers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 13:00:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 11:00:30 +0000 Subject: [Koha-bugs] [Bug 28382] 'Reserve' should be passed through as transfer reason appropriately in branchtransfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28520 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 [Bug 28520] Cancelling a hold that is in transit hides item's transit status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 13:01:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 11:01:47 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #16 from Martin Renvoize --- Adding 28382 as a dependency, else we won't catch the case where the transfer was actioned by branchtransfers. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 13:07:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 11:07:05 +0000 Subject: [Koha-bugs] [Bug 28527] New: Transfers that are cancelled whilst in transit should still appear as 'in transit' until they are received Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28527 Bug ID: 28527 Summary: Transfers that are cancelled whilst in transit should still appear as 'in transit' until they are received Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If a transfer is cancelled whilst it is in transit (datesent set, but datearrived not) then we should still return it as in transit. Bug 27993 added a condition to the 'in_transit' boolean which should be reverted. We should also update the get_transfer (and get_transfers) methods to catch such cases and return those still active transfers and deal with them appropriately at check-in. (i.e. invoke the reverse transfer or pick the next transfer from the queue and notify the librarian of what subsequent actions they should take). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 13:07:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 11:07:12 +0000 Subject: [Koha-bugs] [Bug 28527] Transfers that are cancelled whilst in transit should still appear as 'in transit' until they are received In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28527 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 13:07:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 11:07:29 +0000 Subject: [Koha-bugs] [Bug 28527] Transfers that are cancelled whilst in transit should still appear as 'in transit' until they are received In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28527 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22160 Depends on| |28520 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 [Bug 22160] OMNIBUS: Transfers enhancements https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 [Bug 28520] Cancelling a hold that is in transit hides item's transit status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 13:07:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 11:07:29 +0000 Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28527 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28527 [Bug 28527] Transfers that are cancelled whilst in transit should still appear as 'in transit' until they are received -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 13:07:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 11:07:29 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28527 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28527 [Bug 28527] Transfers that are cancelled whilst in transit should still appear as 'in transit' until they are received -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 13:07:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 11:07:40 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22160 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 [Bug 22160] OMNIBUS: Transfers enhancements -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 13:07:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 11:07:40 +0000 Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|28520 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 [Bug 28520] Cancelling a hold that is in transit hides item's transit status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 13:08:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 11:08:54 +0000 Subject: [Koha-bugs] [Bug 28528] New: bulkmarcimport delete option doesn't delete biblio_metadata Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28528 Bug ID: 28528 Summary: bulkmarcimport delete option doesn't delete biblio_metadata Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz When using bulkmarcimport with the -d switch should not only delete biblio, biblioitems and items, but also biblio_metadata. I haven't checked if a FK takes care of the data, but if it does, we should still also reset the AUTO_INCREMENT: https://git.koha-community.org/Koha-community/Koha/src/branch/master/misc/migration_tools/bulkmarcimport.pl#L172 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 13:14:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 11:14:16 +0000 Subject: [Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 13:14:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 11:14:19 +0000 Subject: [Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115430|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 121717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121717&action=edit Bug 27265: Enable message queue cron to accept multiple codes and types It would be nice to be able to combine several types in a single run, but exclude others, without having to have multiple cron lines Test Plan: 1) Apply this patch 2) Run process_message_queue.pl with a single -c parameter 3) Note behavior is unchanged 4) Run process_message_queue.pl with multiple -c parameters 5) Note all the codes specified are processed 6) Repeat 2-5 with -t for type limits -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 13:14:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 11:14:39 +0000 Subject: [Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 13:15:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 11:15:53 +0000 Subject: [Koha-bugs] [Bug 28529] New: Max holds per item type ineffective when using AllowHoldItemTypeSelection on bib-level holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529 Bug ID: 28529 Summary: Max holds per item type ineffective when using AllowHoldItemTypeSelection on bib-level holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 15533 introduced a way to constraint biblio-level holds to a specific item type. This is controlled by the AllowHoldItemTypeSelection syspref. On the circulation rules, you are able to set max_holds for an item type. This max_holds setting, seems to be honoured for item-level holds only, and it is not quite correct. To reproduce: 1. Have a patron of category 'Staff' (S) 2. Have 3 records with items with the 'BK' item type, and maybe others 3. Enable AllowHoldItemTypeSelection 4. Set a limit of 2 max holds for that category+item type 5. In the OPAC. Place bibio-level holds, with item type contraint to 'BK' on those 3 records => FAIL: You can place the 3 holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 13:17:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 11:17:19 +0000 Subject: [Koha-bugs] [Bug 28529] Max holds per item type ineffective when using AllowHoldItemTypeSelection on bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24683 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 13:17:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 11:17:19 +0000 Subject: [Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28529 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 13:22:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 11:22:47 +0000 Subject: [Koha-bugs] [Bug 28529] Max holds per item type ineffective when using AllowHoldItemTypeSelection on bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 13:30:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 11:30:42 +0000 Subject: [Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds should honour max_holds as item-level do In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Max holds per item type |Item type-constrained |ineffective when using |biblio-level holds should |AllowHoldItemTypeSelection |honour max_holds as |on bib-level holds |item-level do CC| |jonathan.druart+koha at gmail. | |com, | |katrin.fischer at bsz-bw.de, | |kyle at bywatersolutions.com --- Comment #1 from Tomás Cohen Arazi --- I consider this a bug, but this should be an opt-in change, because the feature never considered circ rules in its conception, and libraries are using them as-is and might see their workflows affected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 13:59:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 11:59:52 +0000 Subject: [Koha-bugs] [Bug 28527] Transfers that are cancelled whilst in transit should still appear as 'in transit' until they are received In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28527 --- Comment #1 from Martin Renvoize --- Bug 28520 is very specific for the Reserve/Holds case, but does not account for transfers triggered by other means or cancelled by other means. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 14:02:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 12:02:00 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Alexander Borkowski changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexander.borkowski at kau.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 14:05:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 12:05:33 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121708|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 121718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121718&action=edit Bug 28520: Revert "Bug 12362: (QA follow-up) Fix ModItemTransfer cancellation handling" This reverts commit fbba09f63f200d3e57a8612554984d807867cf84. This commit was part of a series adding adding reverse transfers, i.e. transfers that were created for transfers that were cancelled and we wanted the item to return back to its sending library. This however hid the information about transfer happening and we need another approach to the problem. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 14:05:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 12:05:37 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121709|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 121719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121719&action=edit Bug 28520: Revert "Bug 12362: Cancel transfer with hold cancelation" This reverts commit 6c105829144cd341a4bc65ad8d0ee1f996b423d4. This commit was part of a series adding adding reverse transfers, i.e. transfers that were created for transfers that were cancelled and we wanted the item to return back to its sending library. This however hid the information about transfer happening and we need another approach to the problem. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 14:05:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 12:05:41 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121710|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 121720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121720&action=edit Bug 28520: Revert "Bug 12362: Reverse transfer upon cancellation" This reverts commit d0407686eb070c5bdf0302147a198027abea5ac0. This commit was part of a series adding adding reverse transfers, i.e. transfers that were created for transfers that were cancelled and we wanted the item to return back to its sending library. This however hid the information about transfer happening and we need another approach to the problem. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 14:05:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 12:05:45 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121711|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 121721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121721&action=edit Bug 28520: Bring back TransferCancellation reason handling from reverted Bug 12362 The code from Bug 12362 was reverted but there might be still in database transfers with the reason 'TransferCancellation' so we need to restore the code to handle displaying that information. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 14:05:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 12:05:49 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121712|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 121722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121722&action=edit Bug 28520: Allow creating a transfer back automatically if a hold is canceled during transit This fixes regression caused by "Bug 12362: Cancel transfer with hold cancelation" where cancelled hold's transfer didn't show up in intranet and opac because it create a new transfer that was not yet put in in-transit state. The original idea of bug 12362 was to be able to trigger transfer back home if a hold was cancelled (a regression caused by bug 26078). However, we can do it more simply by setting the $validTransfer variable true in the item check-in code when we are dealing with Reserve transfers. More down in the AddReturn() code there is also a check "and !$resfound" to make sure we only try to trigger the transfer back home automatically if there is no hold waiting at the current location the item arrived in. It should be noted however that now we only display generic message for the automatic transfer reason. Bug 12362 made the return display as the reason "Transfer was cancelled whilst in transit". However, since this fixes the original regressions caused by bug 26078 and restores similar behaviour to that I think giving a more descriptive message for example regarding a hold being cancelled can be considered a further enhancement. To test: 1) Apply patch 1) Have biblio with item in branch A 2) Create a new hold with a pickup library to branch B 3) Check-in the item at branch A and confirm the hold and transfer 4) Cancel the hold 5) Check-in the hold at branch B and notice it prompt to return it to branch A Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 14:15:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 12:15:08 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #22 from Martin Renvoize --- This resolves the problem as advertised, but it limited to special casing Hold Cancellations.. in the subsequent bug I propose we update the handling to generically resolve this for other cancelled transfers. Signing off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 14:15:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 12:15:19 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |joonas.kylmala at helsinki.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 14:56:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 12:56:01 +0000 Subject: [Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds should honour max_holds as item-level do In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529 --- Comment #2 from Katrin Fischer --- Hi Tomas, I seem to remember that the biblio-level itemtype played into the max holds setting as well (which poses a problem to us, as we usually don't set it). In your test, was there a biblio-level itemtype (942$c) set? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 15:06:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 13:06:08 +0000 Subject: [Koha-bugs] [Bug 28526] Impossible to search only zero In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28526 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 15:06:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 13:06:11 +0000 Subject: [Koha-bugs] [Bug 28526] Impossible to search only zero In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28526 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121713|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 121723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121723&action=edit Bug 28526: Impossible to search only zero In staff interface and OPAC, searching only zero leads to advanced search page. Test plan : 1) Go to opac home page 2) Enter 0 into search field => Without patch you go to advanced search page => With patch you go to results page 3) Idem on staff interface Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 15:07:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 13:07:24 +0000 Subject: [Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds should honour max_holds as item-level do In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529 --- Comment #3 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #2) > Hi Tomas, > I seem to remember that the biblio-level itemtype played into the max holds > setting as well (which poses a problem to us, as we usually don't set it). > > In your test, was there a biblio-level itemtype (942$c) set? There wasn't a 942$c set. If you look at bug 15533 you will notice the purpose of the feature is to define which items on the biblio can fill the hold. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 15:33:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 13:33:26 +0000 Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon or exclamation point is in 245$a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484 --- Comment #2 from John Yorio --- (In reply to John Yorio from comment #1) > I'm just confirming this error occurs. > > Staff saw Internal Server Error when trying to view a bib record. > > Looking in the log files, I saw the "[query_shard_exception] Failed to parse > query [(host-item: ...." message as per Bohdan's original post. > > Editing the bib record by directly bringing it up with > addbiblio.pl?biblionumber= worked and I removed the colon at the end of the > 245a. The record could then be viewed. Adding the colon back caused the > error again. I did some further testing. In my testing of a 245$a ending in a colon, if the colon is preceded by a space, the error does not occur. So, something like "My Title :" works fine, but "My Title:" produces the error. Exclamation points failed regardless. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 15:41:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 13:41:37 +0000 Subject: [Koha-bugs] [Bug 28382] 'Reserve' should be passed through as transfer reason appropriately in branchtransfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 15:41:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 13:41:40 +0000 Subject: [Koha-bugs] [Bug 28382] 'Reserve' should be passed through as transfer reason appropriately in branchtransfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121152|0 |1 is obsolete| | --- Comment #6 from Joonas Kylmälä --- Created attachment 121724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121724&action=edit Bug 28382: Set trigger to 'Reserve' when actioning a reserve transfer This patch sets the transfer trigger to 'Reserve' when the staff user confirms they are transfering to fulfil a reserve. Test plan 1 - Place a hold for delivery at Library B 2 - Sign in at Library A 3 - Browse to Circulation->Transfers 4 - Attempt to transfer an item on the title with the hold to Library B 5 - You get a notice that hold was found 6 - You have the option transfer the for the hold - click it 7 - Confirm hold is set to transit and transfer generated 8 - Check the branchtransfers table and confirm the 'reason' is 'Reserve' not 'Manual'. Signed-off-by: David Nind JK: fix typo resver -> reserve Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 15:42:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 13:42:54 +0000 Subject: [Koha-bugs] [Bug 28382] 'Reserve' should be passed through as transfer reason appropriately in branchtransfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |joonas.kylmala at helsinki.fi QA Contact|testopia at bugs.koha-communit |joonas.kylmala at helsinki.fi |y.org | --- Comment #7 from Joonas Kylmälä --- PQA and switching status to bug because the reason was not right previously. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 16:21:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 14:21:08 +0000 Subject: [Koha-bugs] [Bug 28446] Fix encoding of OverDrive content on Your summary, OverDrive Account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28446 --- Comment #3 from Owen Leonard --- Magnus have you tested this in master? I can't reproduce in master but I'm not sure if it's specific to 20.11.x or if I don't have an exotic-enough OverDrive record. I see: Lyd & Bilde, Skandinavias største hjemmeelektronikkmagasin â nå også i digitalt format på Zinio! Abonner nå â Et tilbud du ikke kan takke nei til! and Le magazine de référence de la photo. Dans PHOTO se côtoient les plus grands photographes internationaux : reportage, mode, pub, sport, nu, portrait... Le magazine PHOTO incarne les tendances esthétiques d'aujourd'hui et vous fait découvrir les talents. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 17:36:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 15:36:01 +0000 Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Brenda changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bowens at washoecounty.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 19:23:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 17:23:55 +0000 Subject: [Koha-bugs] [Bug 28530] New: Allow configuration of floating limits by item type Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Bug ID: 28530 Summary: Allow configuration of floating limits by item type Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When return policy is set to Item Floats, it's possible for patron usage patterns to result in an imbalance in the collection -- more DVDs end up at Branch A and more books at Branch B. This can be especially troublesome when a given branch has limited shelving for a specific item type. I'd like to see a mechanism by which libraries can define a maximum count of items per item type to be allowed to float at a given branch. So, following my example above, Branch A could say that DVDs float when checked in but only up to 1000 items. If a DVD is checked in at Branch A and would be the 1001st DVD there, it instead transfers away. When some DVDs get checked out or transferred away, new returns will again be allowed to remain at Branch A. Setting the float limit to zero for a given item type and branch would make that item type always transfer away from that branch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 20:05:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 18:05:08 +0000 Subject: [Koha-bugs] [Bug 14149] Labels: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14149 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 20:06:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 18:06:46 +0000 Subject: [Koha-bugs] [Bug 10762] Not able to adjust size of barcode numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 20:14:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 18:14:43 +0000 Subject: [Koha-bugs] [Bug 10762] Not able to adjust size of barcode numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 --- Comment #6 from Marjorie Barry-Vila --- Still valid on 20.05 Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 20:48:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 18:48:42 +0000 Subject: [Koha-bugs] [Bug 28187] rowGroup headings are getting their styles overriden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #16 from Victor Grousset/tuxayo --- note: was backported to oldstable (20.11.x) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 20:48:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 18:48:48 +0000 Subject: [Koha-bugs] [Bug 28187] rowGroup headings are getting their styles overriden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 20:49:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 18:49:05 +0000 Subject: [Koha-bugs] [Bug 28187] rowGroup headings are getting their styles overriden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #17 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 20:49:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 18:49:05 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Bug 13985 depends on bug 28187, which changed state. Bug 28187 Summary: rowGroup headings are getting their styles overriden https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 20:49:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 18:49:47 +0000 Subject: [Koha-bugs] [Bug 16785] Autocomplete broken on overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 20:49:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 18:49:54 +0000 Subject: [Koha-bugs] [Bug 16785] Autocomplete broken on overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #14 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 20:49:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 18:49:55 +0000 Subject: [Koha-bugs] [Bug 22956] Omnibus: Remove type attribute from script tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22956 Bug 22956 depends on bug 16785, which changed state. Bug 16785 Summary: Autocomplete broken on overdues report https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 20:56:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 18:56:23 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 --- Comment #62 from Victor Grousset/tuxayo --- 1/ Create some credits and debits and apply them to each other in various combinations * lost item manual invoice * two partial payment of it * final full payment * create credit * 2 partial payouts * void payment * create credit * 1 partial payouts * 1 final payout What are the other action doable with credits and debits ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 21:08:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 19:08:22 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #63 from Victor Grousset/tuxayo --- With - alt 1 at "Update accountline-details page to show all history" I get crashed about FK constraint. It tried a unorthodox method to solve a patch not applying: * sha1 information is lacking or useless git am --show-current-patch=diff | patch -p1 --merge git add THE RELEVANT FILES # when git am is used by git bz git bz apply --continue # check comparing the diff of the resulting commit with the original patch # cat is to remove paging git show db11ac2237 | cat # when it's done, if your BZ had a dependency, check it was added because the # issue might have caused the main patch to be dropped and only the dependency # to be added. --- So it might have not worked. Or there might be an actually issue. Or it's not meant to work on commit ""Update accountline-details page to show all history"" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 21:27:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 19:27:32 +0000 Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #49 from Tomás Cohen Arazi --- (In reply to Blou from comment #46) > Ivan has already recoded it without sessions in our codebase. But before > pushing that change, we'll be waiting for Tomas' instructions regarding the > svc/ I think this is a subject worth discussing in the open, i.e. in koha-devel. As I mentioned (not sure where) I believe we could try adding some filtering capabilities to GET /biblios to accomplish this. I proposed something similar on bug 25870. In that case, I proposed a 'q_ccl' query param that could take a CCL query so we could accept complex queries. The route would then extract the ids (biblionumbers) and return Koha::Biblios->to_api objects as required. I don't think CCL is a cool feature, but it felt like good start: allowing people to query records through the API. The ES syntax might be a high constraint for the feature (leaving Zebra users out), specially if you are querying things like title, author, etc. But that's another possibility: add a query parameter that only works with ES (q_es?). Regarding routes, you need to think what the response would look like. And it will help you figure what you want. Is it ok/enough for GET /biblios? to return JSON representation of the biblio+biblioitems table columns? Unfortunately, the OpenAPI v2.0 schema doesn't provide a way to define different response schemas for different content-type responses, and thus we left GET /biblios/:biblio_id under-documented (it is supported on v3) but you can try GET /biblios/1 and see the response to get an idea of what we already return [1]. It feels like we need to build a good query language, and reuse this routes. [1] This is how we build the JSON representation of a biblio https://git.koha-community.org/Koha-community/Koha/src/branch/master/Koha/Biblio.pm#L867-L892 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 23:05:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 21:05:58 +0000 Subject: [Koha-bugs] [Bug 28393] Elasticsearch - Add 050a to lc-call-number index mapping (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28393 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 23:06:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 21:06:09 +0000 Subject: [Koha-bugs] [Bug 28381] Elasticsearch - Add 710 and 711 to default mappings for author index (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28381 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 23:06:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 21:06:17 +0000 Subject: [Koha-bugs] [Bug 28380] Elasticsearch - correct 024aa in mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28380 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 23:06:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 21:06:25 +0000 Subject: [Koha-bugs] [Bug 28379] Elasticsearch - Add 710 to author-name-corporate index (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28379 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 8 23:06:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 21:06:36 +0000 Subject: [Koha-bugs] [Bug 28378] Elasticsearch - Add 264c to default copydate mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28378 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 01:10:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 23:10:33 +0000 Subject: [Koha-bugs] [Bug 28419] Page addorderiso2709.pl is untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 01:10:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 23:10:49 +0000 Subject: [Koha-bugs] [Bug 28419] Page addorderiso2709.pl is untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.07 |21.05.00,20.11.07,20.05.13 released in| | Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #19 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 01:12:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 23:12:19 +0000 Subject: [Koha-bugs] [Bug 28158] Lost items not charging when marked lost from batch item modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28158 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #32 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 01:12:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 23:12:20 +0000 Subject: [Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 Bug 28445 depends on bug 28158, which changed state. Bug 28158 Summary: Lost items not charging when marked lost from batch item modification https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28158 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 01:19:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 23:19:43 +0000 Subject: [Koha-bugs] [Bug 28091] Add meta tag with Koha version number to staff interface pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28091 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |victor at tuxayo.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 01:19:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 23:19:53 +0000 Subject: [Koha-bugs] [Bug 28091] Add meta tag with Koha version number to staff interface pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28091 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 01:20:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 23:20:33 +0000 Subject: [Koha-bugs] [Bug 27899] Missing description for libraryNotPickupLocation on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #16 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 01:26:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 23:26:47 +0000 Subject: [Koha-bugs] [Bug 28364] koha-z3950-responder breaks because of log4perl.conf permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28364 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |victor at tuxayo.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 01:27:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 23:27:04 +0000 Subject: [Koha-bugs] [Bug 28364] koha-z3950-responder breaks because of log4perl.conf permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28364 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.07 |21.05.00,20.11.07,20.05.13 released in| | Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #8 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 01:31:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 23:31:57 +0000 Subject: [Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 01:32:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Jun 2021 23:32:12 +0000 Subject: [Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.05.00,20.11.07 |21.05.00,20.11.07,20.05.13 released in| | --- Comment #30 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 02:44:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 00:44:28 +0000 Subject: [Koha-bugs] [Bug 28442] Release team 21.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28442 --- Comment #17 from Victor Grousset/tuxayo --- ok, will try to get the chain of deps for 20.05 oldoldstable (hopefully, 19.11 oldoldoldstable will also be able to do so) bug 28442 => bug 28386 => bug 26621 => bug 26394 ^^" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 02:45:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 00:45:46 +0000 Subject: [Koha-bugs] [Bug 26394] .mailmap needs to be updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |victor at tuxayo.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 02:45:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 00:45:52 +0000 Subject: [Koha-bugs] [Bug 26394] .mailmap needs to be updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 02:46:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 00:46:21 +0000 Subject: [Koha-bugs] [Bug 26394] .mailmap needs to be updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00,20.05.13 released in| | Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #8 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 02:47:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 00:47:47 +0000 Subject: [Koha-bugs] [Bug 26621] .mailmap adjustments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26621 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |victor at tuxayo.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 02:47:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 00:47:53 +0000 Subject: [Koha-bugs] [Bug 26621] .mailmap adjustments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26621 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 02:48:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 00:48:05 +0000 Subject: [Koha-bugs] [Bug 26621] .mailmap adjustments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26621 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.11.00 |20.11.00,20.05.13 released in| | --- Comment #15 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 02:50:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 00:50:45 +0000 Subject: [Koha-bugs] [Bug 28386] Replace dev_map.yaml from release_tools with .mailmap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28386 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 03:25:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 01:25:34 +0000 Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background using Koha::BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 03:25:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 01:25:40 +0000 Subject: [Koha-bugs] [Bug 27467] Provide a static URL for tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27467 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 03:26:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 01:26:53 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 03:54:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 01:54:24 +0000 Subject: [Koha-bugs] [Bug 27877] Accessibility: Staff Client - Reduce heading redundancy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27877 --- Comment #2 from wainuiwitikapark at catalyst.net.nz --- Files I specifically noticed may have redundancy: admin/classsources.tt circ/set-library.tt circ/circulation-home.tt pos/pay.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 04:21:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 02:21:01 +0000 Subject: [Koha-bugs] [Bug 27877] Accessibility: Staff Client - Reduce heading redundancy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27877 --- Comment #3 from wainuiwitikapark at catalyst.net.nz --- The only file/page I noticed unnecessary was circ/set-library.tt Adding patch to amend this now... Please let me know if you notice anymore redundant headings that have appeared because of my accessibility heading fixes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 04:30:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 02:30:48 +0000 Subject: [Koha-bugs] [Bug 27877] Accessibility: Staff Client - Reduce heading redundancy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27877 --- Comment #4 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121725&action=edit Bug 27877: circ/set-library.tt Got rid of heading redundancy To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to circ/set-library 4) Check that there are no visible unnecessary redundant/repeated headings 5) Check that there is a legend that has the class "sr-only" which eliminates visible redundancy but leaves descriptions for those who use screen readers Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 04:31:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 02:31:21 +0000 Subject: [Koha-bugs] [Bug 27877] Accessibility: Staff Client - Reduce heading redundancy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27877 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 05:51:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 03:51:15 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions and legends to tables and forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #1 from wainuiwitikapark at catalyst.net.nz --- Starting work on this now... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 07:32:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 05:32:18 +0000 Subject: [Koha-bugs] [Bug 28531] New: 500 internal server error when saving system preference Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28531 Bug ID: 28531 Summary: 500 internal server error when saving system preference Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: iamalon1434 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com i have updated koha version from 19.11 to 20.11 after updating, i am facing 500 internal server error when i try to save system preferences error in console : cgi-bin/koha/svc/config/systempreferences/ [HTTP/1.1 500 Internal Server Error apache2 error log : systempreferences: Can't open /var/log/koha/sip.log (Permission denied) at /usr/local/share/perl/5.22.1/Log/Log4perl/Appender/File.pm line 151 permission : -rw-r--r-- 1 kohauser kohauser 106318 Jun 3 13:31 sip.log -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 07:46:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 05:46:39 +0000 Subject: [Koha-bugs] [Bug 16181] Limit number of tags loaded initially for tag cloud In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16181 --- Comment #6 from George Williams (NEKLS) --- This is still relevant. We have a borrower that has tagged a lot of items. When they load opac-tags.pl it takes over 4 minutes to load. #mytagst has over 1000 rows for this borrower so I'm thinking that if #mytagst was converted to datatable, that would solve the problem. When I load opac-tags.pl for a borrower that only has one or two tags, the tag cloud and the table load quickly. It's when the borrower has a ton of stuff in #mytagst that the page drags. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 07:47:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 05:47:12 +0000 Subject: [Koha-bugs] [Bug 27169] sip2 not enable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27169 --- Comment #8 from Vihaan Gupta --- (In reply to Jonathan Druart from comment #7) > Any news here, did you solve your problem? yes i solve the problem -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 07:50:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 05:50:37 +0000 Subject: [Koha-bugs] [Bug 27169] sip2 not enable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27169 Vihaan Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 09:25:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 07:25:26 +0000 Subject: [Koha-bugs] [Bug 28158] Lost items not charging when marked lost from batch item modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28158 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.07 |21.05.00 released in| | --- Comment #33 from Fridolin Somers --- (In reply to Jonathan Druart from comment #31) > (In reply to Fridolin Somers from comment #30) > > Pushed to 20.11.x for 20.11.07 > > I wouldn't have backported this, it's a big change. Moreover Nick reported > that it was working on 20.11. OK I revert. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 10:28:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 08:28:51 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121627|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 121726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121726&action=edit Bug 28487: Fallback to default template in overdue_notices There is no fallback to the "default" language if there is no language-specific template for the lang of the patron. I am not really sure why we are not using GetPreparredLetter here (which defaults), but this needs to be backported into all stable branches and so as small as possible. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 10:29:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 08:29:06 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121628|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 121727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121727&action=edit Bug 28514: Remove getletter The way we handle notice templates is confusing (see bug 27660, bug 26787, bug 28487). This patch remove C4::Letters::getletter and use either Koha::Notice::Templates->find or the newly created methods ->find_effective_template that will do all necessary to return the correct template. Test plan: - Create and modify notice templates - Make sure you have TranslateNotices turned on and that some notices templates have a translated version - Use holds_reminder.pl and overdue_notices.pl cronjobs and confirm that the generated notices are the expected ones - Test also pos/printreceipt.pl - And finally test some other notices (CHECKIN, RENEWAL for instance) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 10:29:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 08:29:30 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Martin Renvoize --- Code reads well, testing proves it works as expected.. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 10:31:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 08:31:13 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- A solid improvement.. it's reminded me I managed to somehow miss updating the pos receipt printing for GetPreparedLetter.. damn! Also.. the overdues_notices code is rather inefficient I feel.. for a valid letter we lookup the template 3 times before actually using it! Still.. it all works and we can do further cleaning in new bugs.. Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 10:51:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 08:51:02 +0000 Subject: [Koha-bugs] [Bug 28532] New: Accessibility: Staff Client - add legends to forms Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28532 Bug ID: 28532 Summary: Accessibility: Staff Client - add legends to forms Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: wainuiwitikapark at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Many of the forms in the Staff Client do not have legend tags to describe them. This is not accessible and makes it hard for navigation when using a screen-reader. However, adding these legends to forms can create redundancy and appear unnecessary. Therefore, it may be beneficial for these legends to be in the class "sr-only" so that they are not visible, they are just available for those who use screen readers. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 10:51:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 08:51:13 +0000 Subject: [Koha-bugs] [Bug 28532] Accessibility: Staff Client - add legends to forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28532 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 10:51:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 08:51:33 +0000 Subject: [Koha-bugs] [Bug 28532] Accessibility: Staff Client - add legends to forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28532 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |wainuiwitikapark at catalyst.n |ity.org |et.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 10:52:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 08:52:03 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Accessibility: Staff Client |Accessibility: Staff Client |- add captions and legends |- add captions to tables |to tables and forms | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 10:53:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 08:53:37 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #2 from wainuiwitikapark at catalyst.net.nz --- Changing this bug to only deal with captions and tables. Bug 28532 has been made to deal with legends and forms. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 10:54:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 08:54:22 +0000 Subject: [Koha-bugs] [Bug 28532] Accessibility: Staff Client - add legends to forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28532 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27631, 27741, 27877 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27877 [Bug 27877] Accessibility: Staff Client - Reduce heading redundancy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 10:54:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 08:54:22 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28532 [Bug 28532] Accessibility: Staff Client - add legends to forms -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 10:54:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 08:54:22 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28532 [Bug 28532] Accessibility: Staff Client - add legends to forms -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 10:54:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 08:54:22 +0000 Subject: [Koha-bugs] [Bug 27877] Accessibility: Staff Client - Reduce heading redundancy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27877 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28532 [Bug 28532] Accessibility: Staff Client - add legends to forms -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 11:14:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 09:14:02 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 --- Comment #11 from David Nind --- Thanks Martin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 13:09:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 11:09:31 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116986|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 13:09:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 11:09:55 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116978|0 |1 is obsolete| | --- Comment #39 from Andrew Isherwood --- Created attachment 121728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121728&action=edit Bug 27378: Add new 'modaljs' syspref type This commit adds a new 'modaljs' syspref type. This is similar to the existing 'modalselect' syspref type but instead of using a file to create a list of selectable options which are displayed in the modal, it assumes that anything can happen within the modal driven by JS, and whatever happens is going to return a string, that will be saved as the syspref value. In our case, the string will be all the details of the “chunks” concatenated into a string -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 13:09:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 11:09:59 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116979|0 |1 is obsolete| | --- Comment #40 from Andrew Isherwood --- Created attachment 121729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121729&action=edit Bug 27378: Add sysprefs This commit adds 4 new sysprefs: - CookieConsent - the master on/off for this functionality - ConsentJS - The configuration for JS code that requires consent prior to running. - CookieConsentBar: Allows the admin to specify the HTML that will be displayed in the consent bar that appears at the bottom of the page - CookieConsentPopup: Allows the admin to specify the HTML that will be displayed in the cookie consent popup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 13:10:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 11:10:04 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116980|0 |1 is obsolete| | --- Comment #41 from Andrew Isherwood --- Created attachment 121730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121730&action=edit Bug 27378: Add JS to power modaljs This commit adds the Javascript that provides the functionality within the consentJS modaljs modal. It provides the ability to display the current state of any consentJS values and to amend them, as well as add new ones. There is also some refactoring of the existing modalselect functions to allow re-use of existing code between modalselect & modaljs. This refactoring has been minimal and consists of abstracting functionality into functions to allow more wide use. Styles for the consentJS UI were also added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 13:10:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 11:10:08 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116981|0 |1 is obsolete| | --- Comment #42 from Andrew Isherwood --- Created attachment 121731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121731&action=edit Bug 27378: Add cookie consent display to OPAC This commit adds the display of the cookie consent bar and modal to the OPAC. - Adds a new JSConsents template plugin that enables a template to be populated with the contents of the ConsentJS syspref in a prepared, usable form - Adds a new cookieconsent.js script that drives the display and functionality of the cookie consent bar and modal - Adds styles for the cookie consent bar and modal - Adds the creation and population of the cookie consent bar and modal, if appropriate - Adds the ability for both authenticated and unauthenticated users to view and modify their consents either via "your consents" or a new unobtrusive "Your cookies" button in the bottom right of the screen. - Adds unit test for JSConsents.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 13:10:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 11:10:13 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116982|0 |1 is obsolete| | --- Comment #43 from Andrew Isherwood --- Created attachment 121732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121732&action=edit Bug 27378: Add cookie consent display to staff UI This commit adds the display of the cookie consent bar and modal to the staff interface: - Adds a new cookieconsent.js script that drives the display and functionality of the cookie consent bar and modal - Adds styles for the cookie consent bar and modal - Adds the creation and population of the cookie consent bar and modal, if appropriate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 13:10:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 11:10:17 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116983|0 |1 is obsolete| | --- Comment #44 from Andrew Isherwood --- Created attachment 121733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121733&action=edit Bug 27378: Move "Your cookies" to existing bar The new "Your cookies" button that appeared at the bottom right when an unauthenticated user had made their cookie consent selections wasn't ideal. It has now been moved to the top bar, next to "Lists", this feels like a much more sensible place for it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 13:10:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 11:10:22 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116984|0 |1 is obsolete| | --- Comment #45 from Andrew Isherwood --- Created attachment 121734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121734&action=edit Bug 27378: Delete cookies when consent removed We have provided the ability for a user to remove previously granted consent, but we were not removing the cookie associated with that consent. This was a complete oversight on my part. I've introduced an additional bit of metadata for each "consent" defined in the ConsentJS syspref, this allows the admin defining a "consent" to specify a string (which is treated as a regex) that allows us to identify a cookie name associated with that consent. So, for example, if Google Analytics was being added, an identifying string might be '_ga'. This allows us to subsequently remove a cookie that a previously granted consent has set. This commit also adds some missing 'html' filters in koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc and koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 13:10:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 11:10:26 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116985|0 |1 is obsolete| | --- Comment #46 from Andrew Isherwood --- Created attachment 121735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121735&action=edit Bug 27378: Add cookie domain and path A subtlety I missed was that some tracking services, such as Google Analytics, specify a cookie domain and path that differ from the default. E.g. on a site with a domain of demostaff.koha-ptfs.co.uk, the GA cookie will have a domain of '.koha-ptfs.co.uk' and a path of '/', even though the cookie may have been set at a different path. Both of these things makes sense, but of course unless we also specify both of those things when we try to delete a previously set cookie, we cannot. Therefore, I have added two more bits of metadata to each "consent", Cookie Domain and Cookie Path. It is necessary for an admin creating a "consent" entry to know and specify these values. They can be established by looking a cookie set by the service being configured. This adds more complexity to setting up a consent, but we cannot remove previously set cookies without it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 13:11:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 11:11:02 +0000 Subject: [Koha-bugs] [Bug 28508] Use "Invoice number" instead of "Invoice no" on the invoice search filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28508 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 13:11:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 11:11:06 +0000 Subject: [Koha-bugs] [Bug 28508] Use "Invoice number" instead of "Invoice no" on the invoice search filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28508 --- Comment #1 from Owen Leonard --- Created attachment 121736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121736&action=edit Bug 28508: Use "Invoice number" instead of "Invoice no" on the invoice search filter This patch corrects instances of the abbreviated phrase "Invoice no." from the templates, making it "Invoice number." Also corrected: An instance of "Bookseller" is replaced with "Vendor." To test, apply the patch and confirm that the phrase is correct in these cases: - Acquisitions -> Invoices: Check the "Search filters" form in the left-hand sidebar. -> View an invoice: Check the label in the form. - Acquisitions -> Vendor -> Receive shipments: Check the table of invoices. - Acquisitions -> Orders search (in the search header) -> Advanced search: Check the labels in the form. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 13:11:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 11:11:59 +0000 Subject: [Koha-bugs] [Bug 28508] Use "Invoice number" instead of "Invoice no" on the invoice search filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28508 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 13:22:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 11:22:46 +0000 Subject: [Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 13:46:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 11:46:25 +0000 Subject: [Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 13:46:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 11:46:28 +0000 Subject: [Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 --- Comment #1 from Owen Leonard --- Created attachment 121737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121737&action=edit Bug 28495: Improve validation of library entry form This patch adds validation of the "Library code" field so that entry is limited to letters and numbers. Also changed: Updated the email fields to add the "email" type attribute (see also Bug 27805). To test, apply the patch and go to Administration -> Libraries -> New library. - Try entering various strings in the "Library code" field. If you enter anything other than letters and numbers an error message should be displaed on blur or on submit. - Try submitting the form with no data in the "Library code" and/or "Name" field. The fields should be required. - Test entering various strings in the email-type fields: Email, Ill staff email, Reply-To, and Return-Path. Non-email entries should trigger a message, "Please enter a valid email address." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 14:25:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 12:25:31 +0000 Subject: [Koha-bugs] [Bug 28338] Validate item holdability and pickup location separately In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28338 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 14:59:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 12:59:19 +0000 Subject: [Koha-bugs] [Bug 28533] New: Requesting whole field in 'itemcallnumber' system preference causes internal server error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28533 Bug ID: 28533 Summary: Requesting whole field in 'itemcallnumber' system preference causes internal server error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl To recreate: 1 - Set 'itemcallnumber' system preference to 082 2 - Find/Create a record with an 082 field 3 - Add items to the record 4 - Error: Unmatched [ in regex; marked by <-- HERE in m/^[ <-- HERE ]$/ at /usr/share/perl5/MARC/Field.pm line 643. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 15:06:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 13:06:34 +0000 Subject: [Koha-bugs] [Bug 28533] Requesting whole field in 'itemcallnumber' system preference causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28533 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 15:06:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 13:06:37 +0000 Subject: [Koha-bugs] [Bug 28533] Requesting whole field in 'itemcallnumber' system preference causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28533 --- Comment #1 from Nick Clemens --- Created attachment 121738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121738&action=edit Bug 28533: Set subfields to 'undef' if whole field request in itemcallnumebr system preference This patch undefines the CNsubfields variable when the whole field is requested Note that the substr returns '' when no characters are found, so we test if the string eq '' Testing 'truth' doesn't work because "0" is a valid option To test: 1 - Edit a record, add an 082 field 082 0 0 ‡aalpha‡bbeta‡0delta 2 - Set itemcallnumber system preference to 082 3 - Attempt to add/edit items 4 - ISE 5 - Apply patch, restart all the things 6 - Add/edit items - no error 7 - Confirm the itemcallnumber field is populated with "alpha beta delta" 8 - Set itemcallnumber system preference to '0820' 9 - Add/edit items 10 - Confirm itemcallnumber is populated with 'delta' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 15:13:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 13:13:02 +0000 Subject: [Koha-bugs] [Bug 28527] Transfers that are cancelled whilst in transit should still appear as 'in transit' until they are received In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28527 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28294 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 15:13:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 13:13:02 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28527 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28527 [Bug 28527] Transfers that are cancelled whilst in transit should still appear as 'in transit' until they are received -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 15:13:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 13:13:29 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22160 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 [Bug 22160] OMNIBUS: Transfers enhancements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 15:13:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 13:13:29 +0000 Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|28294 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 15:33:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 13:33:36 +0000 Subject: [Koha-bugs] [Bug 28527] Transfers that are cancelled whilst in transit should still appear as 'in transit' until they are received In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28527 --- Comment #2 from Martin Renvoize --- Created attachment 121739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121739&action=edit Bug 28527: Restore cancellation of transfers from Koha::Hold This aptch restores the cancellation of the transfers in transit when a hold is cancelled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 15:33:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 13:33:39 +0000 Subject: [Koha-bugs] [Bug 28527] Transfers that are cancelled whilst in transit should still appear as 'in transit' until they are received In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28527 --- Comment #3 from Martin Renvoize --- Created attachment 121740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121740&action=edit Bug 28527: Update detail to display cancelled in transit transfers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 15:33:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 13:33:43 +0000 Subject: [Koha-bugs] [Bug 28527] Transfers that are cancelled whilst in transit should still appear as 'in transit' until they are received In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28527 --- Comment #4 from Martin Renvoize --- Created attachment 121741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121741&action=edit Bug 28527: Deal with cancelled in transfer transfers when enqueueing Addeding to the queue should be allowed when the active transfer (in_transit) has been cancelled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 15:33:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 13:33:46 +0000 Subject: [Koha-bugs] [Bug 28527] Transfers that are cancelled whilst in transit should still appear as 'in transit' until they are received In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28527 --- Comment #5 from Martin Renvoize --- Created attachment 121742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121742&action=edit Bug 28527: Add handling for cancelled in transit transfers at checkin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 15:34:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 13:34:16 +0000 Subject: [Koha-bugs] [Bug 28527] Transfers that are cancelled whilst in transit should still appear as 'in transit' until they are received In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28527 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 15:34:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 13:34:36 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 15:44:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 13:44:30 +0000 Subject: [Koha-bugs] [Bug 28534] New: pending_offline_circulations table uses MyISAM engine Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 Bug ID: 28534 Summary: pending_offline_circulations table uses MyISAM engine Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org This appears to be a holdover that was never updated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 15:45:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 13:45:59 +0000 Subject: [Koha-bugs] [Bug 28535] New: Show item type for checkouts in OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28535 Bug ID: 28535 Summary: Show item type for checkouts in OPAC Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: rickard.lindfors at sh.se QA Contact: testopia at bugs.koha-community.org In the OPAC, when the user is logged in, checkouts are being showned. We would like to also show the item type on each checked-out item. It seems to possible to do this with the system preference "item-level_itypes", but unfortunately, that seems to affect a lot of other things. It would be to a have a system preference like "ShowItemTypeInOPAC" that only affects just that. (Also, I might miss something, and there might be some other alternatives, of course). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 17:29:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 15:29:14 +0000 Subject: [Koha-bugs] [Bug 7972] GUI for Crons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7972 Daniel Gaghan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.gaghan at pueblolibrary | |.org --- Comment #11 from Daniel Gaghan --- Having this enhancement would be a big help. Scheduling crons is not the biggest need for us (PCCLD) right now. However, knowing if the report is running or if it failed is, IMHO. So I would vote for a GUI that shows the name of the report, when it's scheduled for, when it was last ran and whether it failed or not. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 18:02:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 16:02:07 +0000 Subject: [Koha-bugs] [Bug 24865] Customize the Accountlines Description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 18:02:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 16:02:38 +0000 Subject: [Koha-bugs] [Bug 24865] Customize the Accountlines Description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 18:07:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 16:07:40 +0000 Subject: [Koha-bugs] [Bug 28335] Making patron attributes required can cause issues in multi branch systems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28335 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 18:10:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 16:10:38 +0000 Subject: [Koha-bugs] [Bug 26206] Extended Patron Attributes don't have a stable id on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26206 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 18:12:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 16:12:12 +0000 Subject: [Koha-bugs] [Bug 26206] Extended Patron Attributes don't have a stable id on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26206 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #1 from Christopher Brannon --- It would sure be nice if the id was based on the attribute code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 18:17:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 16:17:00 +0000 Subject: [Koha-bugs] [Bug 21648] Patron Merge duplicates patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org --- Comment #16 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #12) > Christopher, yes I take the easy path, to prevent corrupted data. > > What you are suggesting is, to me, considered as a new enhancement, not a > bug fix. The changes required to implement this behaviour are much more > important and can be done on a separate bug report. It will certainly need > funding if you want to see it implemented. I agree with Jonathan's plan to prevent corrupted data, and then see how we continue with this. I also agree the feature, to be useful, should provide better feedback and options to solve conflicts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 18:20:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 16:20:11 +0000 Subject: [Koha-bugs] [Bug 28439] Add ability to suspend club enrollments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28439 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 18:20:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 16:20:53 +0000 Subject: [Koha-bugs] [Bug 28439] Add ability to suspend club enrollments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28439 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 18:23:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 16:23:59 +0000 Subject: [Koha-bugs] [Bug 28536] New: Move translatable strings into overdrive.js Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28536 Bug ID: 28536 Summary: Move translatable strings into overdrive.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 21156 Strings defined for translation in opac-bottom.inc for use by OverDrive integration code can now be wrapped in the new translation function and put in overdrive.js. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 18:23:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 16:23:59 +0000 Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28536 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28536 [Bug 28536] Move translatable strings into overdrive.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 18:25:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 16:25:50 +0000 Subject: [Koha-bugs] [Bug 7972] GUI for Crons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7972 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 18:26:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 16:26:22 +0000 Subject: [Koha-bugs] [Bug 7972] GUI for Crons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7972 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 18:41:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 16:41:59 +0000 Subject: [Koha-bugs] [Bug 28536] Move translatable strings into overdrive.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28536 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 18:42:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 16:42:02 +0000 Subject: [Koha-bugs] [Bug 28536] Move translatable strings into overdrive.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28536 --- Comment #1 from Owen Leonard --- Created attachment 121743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121743&action=edit Bug 28536: Move translatable strings into overdrive.js This patch takes strings defined as variables in opac-bottom.inc for use in overdrive.js and moves them to overdrive.js, wrapped in the double-underscore translation function. To test you must have valid credentials entered in system preferences for the OverDrive API. Ideally you should test using a patron who has holds and current checkouts in OverDrive. Apply the patch and log in to the OPAC. - On the "Your summary" page, open the "OverDrive Account" tab. - Log in to your OverDrive account. - The contents of the tab should display correctly, with correct labels for controls like "Log out of your OverDrive account", "Check in", "On hold", etc. - Perform a catalog search which will return results also found in your OverDrive collection. - Open the OverDrive results page. - The page should display correctly, with correct labels on controls like "Check out" and "Place hold." To test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation: > gulp po:update > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the strings pulled from JavaScript e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from bootstrap/js/overdrive.js for translation, e.g.: koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js:124 msgid "OverDrive account page" msgstr "" - Edit the "msgstr" string however you want (it's just for testing) - Install the updated translation: > perl translate install fr-FR In the OPAC, switch to the language you're testing. Confirm that your translated strings appear. In the above example, the string should appear at the top of the "Overdrive Account" tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 18:43:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 16:43:40 +0000 Subject: [Koha-bugs] [Bug 28536] Move translatable strings into overdrive.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28536 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121743|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 121744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121744&action=edit Bug 28536: Move translatable strings into overdrive.js This patch takes strings defined as variables in opac-bottom.inc for use in overdrive.js and moves them to overdrive.js, wrapped in the double-underscore translation function. To test you must have valid credentials entered in system preferences for the OverDrive API. Ideally you should test using a patron who has holds and current checkouts in OverDrive. Apply the patch and log in to the OPAC. - On the "Your summary" page, open the "OverDrive Account" tab. - Log in to your OverDrive account. - The contents of the tab should display correctly, with correct labels for controls like "Log out of your OverDrive account", "Check in", "On hold", etc. - Perform a catalog search which will return results also found in your OverDrive collection. - Open the OverDrive results page. - The page should display correctly, with correct labels on controls like "Check out" and "Place hold." To test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation: > gulp po:update > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the strings pulled from JavaScript e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from bootstrap/js/overdrive.js for translation, e.g.: koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js:124 msgid "OverDrive account page" msgstr "" - Edit the "msgstr" string however you want (it's just for testing) - Install the updated translation: > perl translate install fr-FR In the OPAC, switch to the language you're testing. Confirm that your translated strings appear. In the above example, the string should appear at the top of the "Overdrive Account" tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 18:47:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 16:47:07 +0000 Subject: [Koha-bugs] [Bug 28537] New: Improve HTML generated by OverDrive integration Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28537 Bug ID: 28537 Summary: Improve HTML generated by OverDrive integration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 28536 OverDrive integration generates HTML in a couple of different places, and I think it could use some improvements. Especially the "OverDrive Account" tab which shows titles checked out to and on hold for a logged-in patron. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28536 [Bug 28536] Move translatable strings into overdrive.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 18:47:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 16:47:07 +0000 Subject: [Koha-bugs] [Bug 28536] Move translatable strings into overdrive.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28536 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28537 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28537 [Bug 28537] Improve HTML generated by OverDrive integration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 19:59:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 17:59:20 +0000 Subject: [Koha-bugs] [Bug 28538] New: Regression - Date of birth entered without correct format causes internal server error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 Bug ID: 28538 Summary: Regression - Date of birth entered without correct format causes internal server error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 28351 removed the code from Bug 27937 - but it reintroduced the error caused by single date months/days The issue appears to be that the 'Restrictions' section is in the circulation pages, which adds timepicker, this undoes the dateFormat pref and the date fails to be set after validation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 19:59:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 17:59:38 +0000 Subject: [Koha-bugs] [Bug 28538] Regression - Date of birth entered without correct format causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28351, 27937 Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27937 [Bug 27937] Date of birth entered without correct format causes internal server error https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28351 [Bug 28351] Cannot set restrictions when 'dateformat' is other than 'us' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 19:59:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 17:59:38 +0000 Subject: [Koha-bugs] [Bug 27937] Date of birth entered without correct format causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27937 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28538 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 [Bug 28538] Regression - Date of birth entered without correct format causes internal server error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 19:59:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 17:59:38 +0000 Subject: [Koha-bugs] [Bug 28351] Cannot set restrictions when 'dateformat' is other than 'us' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28351 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28538 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 [Bug 28538] Regression - Date of birth entered without correct format causes internal server error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 20:02:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 18:02:58 +0000 Subject: [Koha-bugs] [Bug 28538] Regression - Date of birth entered without correct format causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 20:03:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 18:03:01 +0000 Subject: [Koha-bugs] [Bug 28538] Regression - Date of birth entered without correct format causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 --- Comment #1 from Nick Clemens --- Created attachment 121745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121745&action=edit Bug 28538: Insert formatted date if valid This patch restores the setting of the date from bug 27937 and adds a parsing of the date to ensure the correct format To test: 1 - Follow test plan from bug 27937 - it fails 2 - Follow test plan from bug 28351 - it succeeds 3 - Apply patch 4 - Repeat 1-2 5 - both plans pass now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 20:12:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 18:12:46 +0000 Subject: [Koha-bugs] [Bug 28534] pending_offline_circulations table uses MyISAM engine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 20:12:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 18:12:48 +0000 Subject: [Koha-bugs] [Bug 28534] pending_offline_circulations table uses MyISAM engine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 --- Comment #1 from Nick Clemens --- Created attachment 121746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121746&action=edit Bug 28534: Fix engine for pending_offline_circulations table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 21:01:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 19:01:38 +0000 Subject: [Koha-bugs] [Bug 21877] Show authorized value description for withdrawn in checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 --- Comment #20 from Salman Ali --- Created attachment 121747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121747&action=edit Bug 28177: Add date column and column configuration to uploads This patch adds a "Date added" column to the table showing uploaded files. Column configuration is added to the table, and the date column is hidden by default. To test, apply the patch and restart all. - Go to Tools -> Upload. - If necessary, upload multiple files with the same category. - Use the "Search uploads by category" form to find those uploads. - In the table of uploads, confirm that table settings and other DataTable controls work correctly, including the option to show the "Date added" column. - Go to Administration -> Table settings -> Tools -> upload. - Change the settings for the uploads table. - Return to Uploads and confirm that your changes are reflected in the display of the uploads table. Signed-off-by: Salman Ali -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 21:01:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 19:01:42 +0000 Subject: [Koha-bugs] [Bug 28539] New: allow for negative payments in Point of Sale Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28539 Bug ID: 28539 Summary: allow for negative payments in Point of Sale Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: technology at haineslibrary.org QA Contact: testopia at bugs.koha-community.org Enhancement request: Allow for negative payments in Point of Sale. In Point of Sale module, you are allowed to edit the cost of a sale item, and change the amount tendered. But the system won't allow you to input negative numbers for cost. For example, if we want to refund a patron $20 from their print account, we take $20 out of the register and hand it to the patron. Point of Sale has no way to record this refund, since the money was collected long ago and over many transactions (i.e. there is no specific transaction to refund). As a result, the register in POS will be over by $20. If we could make a sale of an item with a cost of -20.00, we could account for this refund and balance the POS register correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 21:07:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 19:07:39 +0000 Subject: [Koha-bugs] [Bug 28537] Improve HTML generated by OverDrive integration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28537 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 21:07:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 19:07:42 +0000 Subject: [Koha-bugs] [Bug 28537] Improve HTML generated by OverDrive integration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28537 --- Comment #1 from Owen Leonard --- Created attachment 121748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121748&action=edit Bug 28537: Improve HTML generated by OverDrive integration This patch makes changes to the way HTML is generated when showing output from OverDrive integration: - Buttons have Bootstrap button classes - Layout of information is improved. - Handling of cover image thumbnails is improved, especially in cases where images were much larger than expected. - An OverDrive-specific CSS file is added. To test you must have valid credentials entered in system preferences for the OverDrive API. You should test using a patron who has holds and current checkouts in OverDrive. Apply the patch and log in to the OPAC. - On the "Your summary" page, open the "OverDrive Account" tab. - Log in to your OverDrive account. - The contents of the tab should display well, with item thumbnails showing in a column to the left, and item information showing to the right. - Controls should be styled with standard Bootstrap style. - Confirm that operations work correctly: Acessing titles, checking in, canceling holds, etc. - Perform a catalog search which will return results also found in your OverDrive collection. - Open the OverDrive results page. - The page should display correctly, especially thumbnails. - Confirm that operations work correctly: Checking out and placing holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 21:10:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 19:10:36 +0000 Subject: [Koha-bugs] [Bug 28177] Add date column and column configuration to uploads In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28177 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |salman.ali at inLibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 21:31:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 19:31:50 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #69 from Victor Grousset/tuxayo --- Forget my comment 24 stuff. Just tried test 1 on a sandbox and a local master and it fails. I will open a ticket. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 21:33:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 19:33:33 +0000 Subject: [Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from borrower holds list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 21:33:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 19:33:37 +0000 Subject: [Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from borrower holds list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 --- Comment #1 from Nick Clemens --- Created attachment 121749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121749&action=edit Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 9 21:34:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Jun 2021 19:34:17 +0000 Subject: [Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from borrower holds list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |nick at bywatersolutions.com CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 02:23:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 00:23:13 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #3 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121750&action=edit Bug 28243: acqui folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to Acquisitions 4) Go to each of the pages/files and check if they have tables 5) Check that each of the tables have captions to describe them (unless they have special heading tags instead) - some of these will be visible on the page and some will be hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 02:25:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 00:25:17 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 04:50:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 02:50:25 +0000 Subject: [Koha-bugs] [Bug 23609] Tie patron gender to an authorized value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23609 Hayley Pelham changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleypelham at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 12:10:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 10:10:42 +0000 Subject: [Koha-bugs] [Bug 23258] Batch holding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 12:12:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 10:12:51 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc at interleaf.ie --- Comment #116 from Holly --- I'm noticing something in situations where the OPAC is suppressing records that I would appreciate some feedback on. I walk through what I'm seeing below using a general example from a site I'm testing on. In the below example, the system preferences have been set so that the results per page dropdown appears and a search will show 10 results per page for both the OPAC and the staff side.  1. I use the advanced search on the OPAC to search for all items with a specific item type called "General items".  3. The results per page display shows that there should be 10 results on the first and all other pages. 4. There are actually 9 results on the first results page.  5. There are 10 results on all other pages. 6. Doing the same search on the staff side, the results per page display shows that there should be 10 results on the first and all other pages.  7. There are 10 results on the first page and all other pages.  8. The first result on the first page of the staff side does not appear on the OPAC. Looking at it, this seems to be because all items on the bibliographic record are marked as lost.  9. It is fine that the OPAC is not showing the suppressed record, but I would assume in cases like this, instead of showing nine results on the first page, it should show 10, moving the first result from the second page up one, and so on for all the other pages. To summarise, my understanding is that there should be 10 results on the first page of results, assuming that all subsequent pages have 10 or more results on them, even if one of the results for the first page is suppressed. Is anyone else seeing this? Would this require a new bug to be opened? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 12:35:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 10:35:58 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #117 from Katrin Fischer --- Hi Holly, when using OpacHiddenItems the results are filtered "after" paging, is what I was told, so it leaves holes in the result lists like you see. That cannot be changed easily it seems, which is why it was chosen to remove the numbering of results when OpacHiddenItems is used to hide this a bit. See also: bug 23923 and bug 18989 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 12:39:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 10:39:27 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #118 from Katrin Fischer --- Wanted to add: it's not related to this bug or feature. And a tip: When the bug you think is related has already been closed/released, it's always better to open a new one with any findings and link them using depends or see also. Any patches/fixes will need a new bug number. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 12:48:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 10:48:05 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation signs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cannot search with square |Fix ES crashes related to |brackets [] |various punctuation signs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 12:48:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 10:48:55 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix ES crashes related to |Fix ES crashes related to |various punctuation signs |various punctuation | |characters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 12:49:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 10:49:47 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #15 from Peter Vashchuk --- Changed the scope of the ticket, now this ticket is about various punctuation characters, like [], {}, : and !, that cause internal server errors when you use Elastic Search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 12:51:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 10:51:23 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121443|0 |1 is obsolete| | Attachment #121562|0 |1 is obsolete| | --- Comment #16 from Peter Vashchuk --- Created attachment 121751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121751&action=edit Bug 28316: remove unquoted semicolons and screen all followup colons Currently searches like: "book:", ":book" and "host-item:test:n" cause internal server errors. This patch adds additional regexes that strips the colons from the start and end of the query, and another regex that screens all follow-up colons that go after the first colon to avoid errors when searching for "host-item:test:n". To reproduce: 1) using ES, search for the book with title that contains semicolon at the start or at the end of the line, separated with spaces, this should cause internal server error. 2) try doing the same with something like "host-item:test:n", it should result in error as well. 3) apply the patch. 4) repeat steps 1-2, ensure that it works now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 12:51:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 10:51:28 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #17 from Peter Vashchuk --- Created attachment 121752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121752&action=edit Bug 28316: escape brackets in the search query This patch screens square and curly brackets which have no special language meaning, while keeping ranges as they are, allowing ES to search for biblios with titles that contain square and curly brackets and at the same time allows the use of range searches ([1990 TO 2000]). To reproduce: 1) using ES, search for the book with title that contains square and/or curly brackets, like "book [second edition]", which will result in error. 2) apply the patch. 3) search for that book again, ensure that it works now. 4) additionally perform a search using range, for example: "[1999 TO 2020]", ensure that it works correctly too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 12:51:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 10:51:33 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #18 from Peter Vashchuk --- Created attachment 121753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121753&action=edit Bug 28316: escape exclamation signs in the query Currently having exclamation sign at the end of the query makes ES search fail, and when you try to search for a book that has exclamation sign in the tittle (something like "Words! words") won't show results correctly as it tries to negate everything that is after exclamation sign, making it impossible to search for books that have in in the title This patch escapes exclamation signs if it's at the end of the query or has a space after it, resolving both of the issues listed above. To reproduce: 1) with ES enabled, search for the book with title that contains exclamation sight at the end, like "book!", this search should result in error. 2) do another search, but this time find/prepare beforehand book with a title that has exclamation sign with a space after it, e.g "exclamation! sign", it shouldn't find it as ES treats everything after that exclamation sign as negation. 2) apply the patch. 3) perform searches from the steep one and two again. Search from step one should no longer fail, while search from the step two should find that book. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 12:51:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 10:51:38 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #19 from Peter Vashchuk --- Created attachment 121754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121754&action=edit Bug 28316: avoid messing up regexes in the search queries This patch ensures that the behavior with QueryRegexEscapeOptions set to values other than "Escape" still will works as expected. It does so by storing the contents of regexes before escaping special characters and then restores the contents of regexes back to how it was before, ensuring that searching with regex is possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 12:51:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 10:51:43 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #20 from Peter Vashchuk --- Created attachment 121755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121755&action=edit Bug 28316: escape ES ranges if QueryAutoTruncate is enabled if QueryAutoTruncate enabled we will have any special operators ruined for example: "test [6 TO 7]" will be converted to "test* [6* TO* 7]" so no reason to keep ranges when QueryAutoTruncate set to "enabled" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 12:51:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 10:51:48 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #21 from Peter Vashchuk --- Created attachment 121756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121756&action=edit Bug 28316: add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 13:09:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 11:09:13 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121005|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize --- Created attachment 121757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121757&action=edit Bug 22435: Update CREATE offset types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 13:09:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 11:09:18 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121006|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize --- Created attachment 121758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121758&action=edit Bug 22435: Use 'CREATE' offset type in Koha::Account This patch updates the Koha::Account methods for adding debits and credits to use the 'CREATE' offset type for the creation record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 13:09:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 11:09:23 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121007|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize --- Created attachment 121759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121759&action=edit Bug 22435: Use 'CREATE' offset type in Koha::Account::Line This patch updates the Koha::Account::Line methods that result in new account lines to use the 'CREATE' offset type for the creation record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 13:09:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 11:09:27 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121008|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize --- Created attachment 121760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121760&action=edit Bug 22435: Add 'APPLY' to account_offset_types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 13:09:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 11:09:32 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121009|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize --- Created attachment 121761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121761&action=edit Bug 22435: ->apply() should always use 'APPLY' for offset_type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 13:09:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 11:09:36 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121010|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize --- Created attachment 121762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121762&action=edit Bug 22435: Update unit tests This patch updates the unit tests to reflect the changes we have made to offset types. We do two things: 1) Clean up calls to 'apply' to drop passing offset_type 2) Update test code to look for APPLY and CREATE instead of specific offset types. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 13:09:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 11:09:41 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121011|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize --- Created attachment 121763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121763&action=edit Bug 22435: Fix CREATE offset amounts Updateing the tests highlighted a mistake in the original code.. the offsets for the cancel and reduce creation lines were incorrectly signed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 13:09:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 11:09:46 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121012|0 |1 is obsolete| | --- Comment #71 from Martin Renvoize --- Created attachment 121764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121764&action=edit Bug 22435: Fix _set_found_trigger The _set_found_trigger utilised the 'Writeoff' offset type to distinguish between the application of a writeoff and any other form of offset application. This patch updates the trigger to use the full link through from offset to account credit line to get the credit type being offset. Test plan 1/ Run t/db_dependent/Koha/Items.t and prove it fails before the patch, but passes after applying this patch. 2/ Run t/db_dependent/Koha/Account/Offsets.t and prove it passes both before and after applying this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 13:09:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 11:09:50 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121013|0 |1 is obsolete| | --- Comment #72 from Martin Renvoize --- Created attachment 121765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121765&action=edit Bug 22435: Update for bug 27049 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 13:09:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 11:09:55 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121014|0 |1 is obsolete| | --- Comment #73 from Martin Renvoize --- Created attachment 121766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121766&action=edit Bug 22435: Update accountline-details page to show all history The accountline-details page took a simplistic approach to displaying the history of an accountline. This patch drops the now defunct offset_type_description template block from it's respective include files, and then updates the accountline-details teplate and controller to show a full history of what's happend to the accountlines passed, including creation, increment/decrement, payments, cancellation and voids. Test plan 1/ Create some credits and debits and apply them to each other in various combinations 2/ View the 'Details' page for some of the debit/credits 3/ Compare before patch and after for the Details page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 13:09:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 11:09:59 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121015|0 |1 is obsolete| | --- Comment #74 from Martin Renvoize --- Created attachment 121767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121767&action=edit Bug 22435: Improve database update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 13:10:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 11:10:03 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121016|0 |1 is obsolete| | --- Comment #75 from Martin Renvoize --- Created attachment 121768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121768&action=edit Bug 22435: Further refinements to account-details table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 13:10:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 11:10:08 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121028|0 |1 is obsolete| | --- Comment #76 from Martin Renvoize --- Created attachment 121769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121769&action=edit Bug 22435: Alternative Three - Account Details Another alternative to try, feedback welcome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 13:15:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 11:15:26 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #77 from Martin Renvoize --- I've rebased... The final three patches apply one after the other.. so you can do an interactive bz apply and pick all but the last two.. (run the db update) and test.. then do another interactive bz apply and just send the next patch and again for the third. I personally think the third is a nice option so perhaps it might be easier to just test the final full patchset and compare to without master? You've picked a few good actions there.. adding a fee, paying it (fully and partially).. using one payment to pay for multiple debts.. voiding payments (before and after they've been applied in part or in full against some debts).. cancelling debts, partial writeoffs etc. Basically.. we just want to work out if the details page gives a clear description of all the actions that have taken place in a payment/charges history. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 14:06:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 12:06:11 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 14:07:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 12:07:36 +0000 Subject: [Koha-bugs] [Bug 26787] getletter does not fallback to default language - transaction receipts can be blank In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26787 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28374 CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 14:07:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 12:07:36 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26787 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 14:08:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 12:08:07 +0000 Subject: [Koha-bugs] [Bug 26787] getletter does not fallback to default language - transaction receipts can be blank In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26787 --- Comment #2 from Martin Renvoize --- Please also see bug 28374 Nick.. it converts pos/printreciept to use GetPreparedLetter. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 14:17:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 12:17:43 +0000 Subject: [Koha-bugs] [Bug 28541] New: Incorrect default pickup location passed to HTML, causing UI show items unreservable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28541 Bug ID: 28541 Summary: Incorrect default pickup location passed to HTML, causing UI show items unreservable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: joonas.kylmala at helsinki.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, nugged at gmail.com, stalkernoid at gmail.com, tomascohen at gmail.com Depends on: 27071 The default pickup branch for holds through intranet was changed in Bug 27071 to be the branch returned by C4::Reserves::GetReservesControlBranch() function. However, the result of this calculation, $reserves_control_branch, is not passed to to the Template Toolkit template: > # pass the userenv branch if no pickup location selected > $template->param( pickup => $pickup || C4::Context->userenv->{branch} ); Instead the wrong value, currently logged in branch is passed. This causes the UI give false warning triangles about not being able to reserve some items even though the reservation works if you ignore those warnings. We should be passing the same branch as we did the availability calculation with, i.e. $reserves_control_branch. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27071 [Bug 27071] Hold pickup library match not enforced correctly on intranet when using hold groups -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 14:17:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 12:17:43 +0000 Subject: [Koha-bugs] [Bug 27071] Hold pickup library match not enforced correctly on intranet when using hold groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27071 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28541 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28541 [Bug 28541] Incorrect default pickup location passed to HTML, causing UI show items unreservable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 14:27:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 12:27:25 +0000 Subject: [Koha-bugs] [Bug 28541] Incorrect default pickup location passed to HTML, causing UI show items unreservable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28541 --- Comment #1 from Joonas Kylmälä --- Actually... On further thought I don't think that is the explanation for the triangles. I don't think we can use the GetReservesControlBranch to get the default pickup location as was changed in bug 27071 because that doesn't give us a branch with pickup option necessarely. The case we have is that the patrons/item's GetReservesControlBranch returns a branch where you cannot go pickup the item. We would need to be able to fallback to some other branch where pickup is possible I think. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 14:35:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 12:35:46 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #113 from Andrew Fuerste-Henry --- I'm getting a test failure at the end: root at kohadevbox:koha(master)$ prove t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Patrons.t .. 42/42 # Looks like you planned 42 tests but ran 43. t/db_dependent/Koha/Patrons.t .. Dubious, test returned 255 (wstat 65280, 0xff00) All 42 subtests passed Test Summary Report ------------------- t/db_dependent/Koha/Patrons.t (Wstat: 65280 Tests: 43 Failed: 1) Failed test: 43 Non-zero exit status: 255 Parse errors: Bad plan. You planned 42 tests but ran 43. Files=1, Tests=43, 31 wallclock secs ( 0.08 usr 0.01 sys + 23.30 cusr 5.08 csys = 28.47 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:04:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:04:11 +0000 Subject: [Koha-bugs] [Bug 28542] New: Move new authority from Z39.50/SRU to a button Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28542 Bug ID: 28542 Summary: Move new authority from Z39.50/SRU to a button Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Actually in authority tools bar, 'New from Z39.50/SRU' is inside 'New autority' menu. This is different from biblio cataloguing toolbar, and adds a click to access it. I propose to move this to its own button. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:05:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:05:29 +0000 Subject: [Koha-bugs] [Bug 28542] Move new authority from Z39.50/SRU to a button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28542 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:13:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:13:17 +0000 Subject: [Koha-bugs] [Bug 28542] Move new authority from Z39.50/SRU to a button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28542 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:13:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:13:20 +0000 Subject: [Koha-bugs] [Bug 28542] Move new authority from Z39.50/SRU to a button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28542 --- Comment #1 from Fridolin Somers --- Created attachment 121770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121770&action=edit Bug 28542: Move new authority from Z39.50/SRU to a button Actually in authority tools bar, 'New from Z39.50/SRU' is inside 'New autority' menu. This is different from biblio cataloguing toolbar, and adds a click to access it. I propose to move this to its own button. Test plan : 1) Create a Z39.50/SRU server connexion for authorities 2) Go to authorities home page 3) Check you see buttons 'New autority' and 'New from Z39.50/SRU' 4) Click on 'New autority' 5) Check you only see autority types 6) Click on 'New from Z39.50/SRU' 7) Check you go to Z39.50/SRU popup 8) Delete Z39.50/SRU server connexion for authorities 9) Go to authorities home page 10) Check you dont see 'New from Z39.50/SRU' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:19:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:19:01 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120056|0 |1 is obsolete| | --- Comment #247 from Martin Renvoize --- Created attachment 121771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121771&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:19:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:19:08 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120057|0 |1 is obsolete| | --- Comment #248 from Martin Renvoize --- Created attachment 121772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121772&action=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:19:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:19:13 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120058|0 |1 is obsolete| | --- Comment #249 from Martin Renvoize --- Created attachment 121773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121773&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:19:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:19:20 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120059|0 |1 is obsolete| | --- Comment #250 from Martin Renvoize --- Created attachment 121774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121774&action=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:19:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:19:27 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120060|0 |1 is obsolete| | --- Comment #251 from Martin Renvoize --- Created attachment 121775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121775&action=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:19:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:19:33 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120061|0 |1 is obsolete| | --- Comment #252 from Martin Renvoize --- Created attachment 121776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121776&action=edit Bug 20256: Use new methods Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:19:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:19:41 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120062|0 |1 is obsolete| | --- Comment #253 from Martin Renvoize --- Created attachment 121777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121777&action=edit Bug 20256: Add unit tests Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:19:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:19:48 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120063|0 |1 is obsolete| | --- Comment #254 from Martin Renvoize --- Created attachment 121778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121778&action=edit Bug 20256: (QA follow-up) Remove double negative from code Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:19:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:19:55 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120064|0 |1 is obsolete| | --- Comment #255 from Martin Renvoize --- Created attachment 121779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121779&action=edit Bug 20256: (QA follow-up) Change meaning should change code Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:20:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:20:01 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120065|0 |1 is obsolete| | --- Comment #256 from Martin Renvoize --- Created attachment 121780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121780&action=edit Bug 20256: (QA follow-up) test borrowernumber in userenv too Bug 22600 added userenv for scripts, so userenv is defined, but some of values in userenv not Test plan: Run with some params: misc/cronjobs/delete_items.pl --> without this patch you will se error message: Can't call method "can_edit_item" on an undefined value at /home/vagrant/kohaclone/C4/Items.pm line 1748 --> with this patch everything works smoothly Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:20:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:20:08 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120066|0 |1 is obsolete| | --- Comment #257 from Martin Renvoize --- Created attachment 121781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121781&action=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:20:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:20:16 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120067|0 |1 is obsolete| | --- Comment #258 from Martin Renvoize --- Created attachment 121782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121782&action=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:20:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:20:19 +0000 Subject: [Koha-bugs] [Bug 28538] Regression - Date of birth entered without correct format causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:20:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:20:22 +0000 Subject: [Koha-bugs] [Bug 28538] Regression - Date of birth entered without correct format causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121745|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 121784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121784&action=edit Bug 28538: Insert formatted date if valid This patch restores the setting of the date from bug 27937 and adds a parsing of the date to ensure the correct format To test: 1 - Follow test plan from bug 27937 - it fails 2 - Follow test plan from bug 28351 - it succeeds 3 - Apply patch 4 - Repeat 1-2 5 - both plans pass now Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:20:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:20:22 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120068|0 |1 is obsolete| | --- Comment #259 from Martin Renvoize --- Created attachment 121783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121783&action=edit Bug 20256: (QA follow-up) Handle non-existing userenv Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:20:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:20:28 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120069|0 |1 is obsolete| | --- Comment #260 from Martin Renvoize --- Created attachment 121785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121785&action=edit Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:20:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:20:34 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120070|0 |1 is obsolete| | --- Comment #261 from Martin Renvoize --- Created attachment 121786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121786&action=edit Bug 20256: (QA follow-up) Skip batch editing items the user is not allowed to edit Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:20:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:20:41 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120071|0 |1 is obsolete| | --- Comment #262 from Martin Renvoize --- Created attachment 121787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121787&action=edit Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions for Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:20:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:20:47 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120072|0 |1 is obsolete| | --- Comment #263 from Martin Renvoize --- Created attachment 121788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121788&action=edit Bug 20256: Mark ft_limit_item_editing as boolean in schema file Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:20:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:20:54 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120073|0 |1 is obsolete| | --- Comment #264 from Martin Renvoize --- Created attachment 121789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121789&action=edit Bug 20256: (QA follow-up) Fix variable masking warning in additem.pl Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:21:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:21:01 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120074|0 |1 is obsolete| | --- Comment #265 from Martin Renvoize --- Created attachment 121790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121790&action=edit Bug 20256: (QA follow-up) Implement for course reserves Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:21:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:21:09 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120075|0 |1 is obsolete| | --- Comment #266 from Martin Renvoize --- Created attachment 121791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121791&action=edit Bug 20256: (QA follow-up) Implement for item search Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:21:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:21:15 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120076|0 |1 is obsolete| | --- Comment #267 from Martin Renvoize --- Created attachment 121792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121792&action=edit Bug 20256: Update DB Schema [DO NOT PUSH] Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:21:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:21:48 +0000 Subject: [Koha-bugs] [Bug 28541] Incorrect default pickup location passed to HTML, causing UI show items unreservable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28541 --- Comment #2 from Joonas Kylmälä --- I think I found a solution: Let's similary fetch the possible pickup locations like we do in request.tt: > [% PROCESS options_for_libraries libraries => Branches.pickup_locations({ search_params => { biblio => biblionumber, patron => patron }, selected => pickup }) %] And if the request.pl gets called without a pickup location then let's call Koha::Template::Plugin::Branches::pickup_locations($biblionumber, $patron) to get one. This gets a valid pickup location selected in the holds page and if the branch is wrong the user can change it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:23:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:23:55 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #268 from Martin Renvoize --- Minor rebase and added my SO line as I've tested this.. still think it would be good to let Katrin do the final QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:26:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:26:53 +0000 Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron (Single Sign On - SSO) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:27:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:27:31 +0000 Subject: [Koha-bugs] [Bug 28543] New: Clicking on 'New record' will use default framework Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28543 Bug ID: 28543 Summary: Clicking on 'New record' will use default framework Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In biblio records cataloguing, clicking on 'New from z39.50/SRU' will run action with default framework. Clicking on 'New record' sould do the same. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:27:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:27:38 +0000 Subject: [Koha-bugs] [Bug 28543] Clicking on 'New record' will use default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28543 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28542 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:27:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:27:38 +0000 Subject: [Koha-bugs] [Bug 28542] Move new authority from Z39.50/SRU to a button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28542 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28543 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:27:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:27:55 +0000 Subject: [Koha-bugs] [Bug 28543] Clicking on 'New record' will use default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28543 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:44:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:44:20 +0000 Subject: [Koha-bugs] [Bug 28544] New: Add API's for account transactions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28544 Bug ID: 28544 Summary: Add API's for account transactions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org This is an attempt at a refresh of bug 15165.. I hope to create a number of routes to manipulate accounts with both patron and anonymous transactions being taken into account. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:45:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:45:22 +0000 Subject: [Koha-bugs] [Bug 28543] Clicking on 'New record' will use default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28543 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 15:45:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 13:45:25 +0000 Subject: [Koha-bugs] [Bug 28543] Clicking on 'New record' will use default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28543 --- Comment #1 from Fridolin Somers --- Created attachment 121793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121793&action=edit Bug 28543: Clicking on 'New record' will use default framework In biblio records cataloguing, clicking on 'New from z39.50/SRU' will run action with default framework. Clicking on 'New record' should do the same. Test plan : 1) Go to cataloguing home page 2) Check you see 'New record' with a sparator and then a caret (like 'New from z39.50/SRU') 3) Click on button text => You go to record edition with default framework 4) Clik on caret => You see list of framworks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 16:01:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 14:01:49 +0000 Subject: [Koha-bugs] [Bug 28545] New: Noisy uninitialized warn at opac-MARCdetail.pl line 313 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28545 Bug ID: 28545 Summary: Noisy uninitialized warn at opac-MARCdetail.pl line 313 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org 19.11 warning like: Use of uninitialized value in concatenation (.) or string at /usr/share/koha/opac/opac-MARCdetail.pl line 312. Same code, line 313 in master. Trivial fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 16:03:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 14:03:49 +0000 Subject: [Koha-bugs] [Bug 28545] Noisy uninitialized warn at opac-MARCdetail.pl line 313 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 16:04:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 14:04:10 +0000 Subject: [Koha-bugs] [Bug 28545] Noisy uninitialized warn at opac-MARCdetail.pl line 313 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 16:04:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 14:04:13 +0000 Subject: [Koha-bugs] [Bug 28545] Noisy uninitialized warn at opac-MARCdetail.pl line 313 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28545 --- Comment #1 from Marcel de Rooy --- Created attachment 121794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121794&action=edit Bug 28545: Noisy uninitialized warn at opac-MARCdetail.pl line 313 Test plan: You need an item with some null values. Check your logs before and after applying this change. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 16:06:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 14:06:53 +0000 Subject: [Koha-bugs] [Bug 28546] New: Framework default value special var for year in Manual Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28546 Bug ID: 28546 Summary: Framework default value special var for year in Manual Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org There is a mistake (or change) in framework default value special vars. In manual : There are several values that you can use here that will be replaced automatically when a new record is created: <> - the current month, 2 digits <
    > - the current day of month, 2 digits <> - the current year, 4 digits <> - the username of the currently logged in user For example: a default of "<>/<
    >/<>" (without quotes) will print the current date in the form of "01/21/2021" See https://gitlab.com/koha-community/koha-manual/-/blob/master/source/administration.rst But in Koha code in cataloguing/addbiblio.pl : $value =~ s/<>/$year/g; $value =~ s/<>/$shortyear/g; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 16:08:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 14:08:55 +0000 Subject: [Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference does not work with XSLT results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #2 from Lucas Gass --- This appears to still be valid. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 16:09:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 14:09:04 +0000 Subject: [Koha-bugs] [Bug 28545] Noisy uninitialized warn at opac-MARCdetail.pl line 313 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 16:34:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 14:34:40 +0000 Subject: [Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |salman.ali at inLibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 16:43:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 14:43:37 +0000 Subject: [Koha-bugs] [Bug 28247] Add a MARC preview column to to Authority search results table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28247 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120261|0 |1 is obsolete| | --- Comment #3 from Salman Ali --- Created attachment 121795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121795&action=edit Bug 28247: Add a MARC preview column to to Authority search results table To test: 1) Do an authority search 2) Notice the MARC preview column 3) Click "Show" for some of the results. 4) Confirm that the correct details are shown. 5) Sign off. Signed-off-by: Salman Ali -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 16:44:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 14:44:54 +0000 Subject: [Koha-bugs] [Bug 28247] Add a MARC preview column to to Authority search results table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28247 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |salman.ali at inLibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 16:52:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 14:52:36 +0000 Subject: [Koha-bugs] [Bug 28547] New: With anonymous transactions now available, the Koha::Account class is misnamed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28547 Bug ID: 28547 Summary: With anonymous transactions now available, the Koha::Account class is misnamed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org We should move Koha::Account to Koha::Patron::Account to better reflect how it is tied to the patron. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 16:52:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 14:52:43 +0000 Subject: [Koha-bugs] [Bug 28547] With anonymous transactions now available, the Koha::Account class is misnamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28547 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 16:52:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 14:52:43 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28547 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28547 [Bug 28547] With anonymous transactions now available, the Koha::Account class is misnamed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 16:52:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 14:52:49 +0000 Subject: [Koha-bugs] [Bug 28547] With anonymous transactions now available, the Koha::Account class is misnamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28547 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 17:04:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 15:04:20 +0000 Subject: [Koha-bugs] [Bug 28548] New: Clarify "frombranch" flag in overdue_notices.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28548 Bug ID: 28548 Summary: Clarify "frombranch" flag in overdue_notices.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz The cronjob overdue_notices.pl includes this text in its options: " --frombranch Set the from address for the notice to one of 'item-homebranch' or 'item-issuebranch'." While that text suggests that the --frombranch flag will only change which branch's address info is populated in overdue notices, this flag actually controls which branch's triggers will be used as well as which branch's notice content will be used. We should change that text to: Set the branch to use when selecting triggers and populating addresses. Available options are 'item-homebranch' or 'item-issuebranch'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 17:04:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 15:04:38 +0000 Subject: [Koha-bugs] [Bug 28548] Clarify "frombranch" flag in overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28548 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 17:06:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 15:06:40 +0000 Subject: [Koha-bugs] [Bug 28549] New: Add a system preference to duplicate --frombranch flag in overdue_notices.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28549 Bug ID: 28549 Summary: Add a system preference to duplicate --frombranch flag in overdue_notices.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The overdue_notices cron allows one to specify whether the issuing branch or item homebranch should be used to select the triggers to follow. We should allow this choice in a system preference so one can change it without commandline access. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 17:06:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 15:06:40 +0000 Subject: [Koha-bugs] [Bug 28548] Clarify "frombranch" flag in overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28548 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28549 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 17:08:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 15:08:54 +0000 Subject: [Koha-bugs] [Bug 28508] Use "Invoice number" instead of "Invoice no" on the invoice search filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28508 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121736|0 |1 is obsolete| | --- Comment #2 from Salman Ali --- Created attachment 121796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121796&action=edit Bug 28508: Use "Invoice number" instead of "Invoice no" on the invoice search filter This patch corrects instances of the abbreviated phrase "Invoice no." from the templates, making it "Invoice number." Also corrected: An instance of "Bookseller" is replaced with "Vendor." To test, apply the patch and confirm that the phrase is correct in these cases: - Acquisitions -> Invoices: Check the "Search filters" form in the left-hand sidebar. -> View an invoice: Check the label in the form. - Acquisitions -> Vendor -> Receive shipments: Check the table of invoices. - Acquisitions -> Orders search (in the search header) -> Advanced search: Check the labels in the form. Signed-off-by: Salman Ali -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 17:09:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 15:09:32 +0000 Subject: [Koha-bugs] [Bug 28508] Use "Invoice number" instead of "Invoice no" on the invoice search filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28508 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |salman.ali at inLibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 17:10:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 15:10:16 +0000 Subject: [Koha-bugs] [Bug 28550] New: Text on overduerules.pl should explain how triggers are selected Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28550 Bug ID: 28550 Summary: Text on overduerules.pl should explain how triggers are selected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 28549 The onscreen text on the overdue notice and status triggers page should explain which branch will get used. Right now, that defaults to issuing branch, but a flag in the cron can be set to make it use item homebranch instead. I've made this bug depend on 28549, which proposes moving that control into a syspref. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28549 [Bug 28549] Add a system preference to duplicate --frombranch flag in overdue_notices.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 17:10:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 15:10:16 +0000 Subject: [Koha-bugs] [Bug 28549] Add a system preference to duplicate --frombranch flag in overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28549 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28550 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28550 [Bug 28550] Text on overduerules.pl should explain how triggers are selected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 18:14:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 16:14:30 +0000 Subject: [Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from borrower holds list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121749|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 121797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121797&action=edit Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Signed-off-by: marti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 18:15:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 16:15:07 +0000 Subject: [Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from borrower holds list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Martha Fuerst changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 18:19:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 16:19:38 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 18:19:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 16:19:43 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121702|0 |1 is obsolete| | Attachment #121703|0 |1 is obsolete| | Attachment #121704|0 |1 is obsolete| | Attachment #121705|0 |1 is obsolete| | Attachment #121706|0 |1 is obsolete| | Attachment #121707|0 |1 is obsolete| | --- Comment #59 from Kyle M Hall --- Created attachment 121798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121798&action=edit Bug 24434: Reinstate updateWrongTransfer This patch re-instates the call to updateWrongTransfer to ensure the transfer line is updated to reflect the new frombranch. Test plan note: when applying the patches, also update the database 1/ Check an item out from it's home library 2/ Check the item in at another library (with AutomaticItemReturn system preferences enabled) 2a/ Accept the transfer and note we now have a transfer present from the items check-in library to it's home library 3/ Check the item in at a third library 3a/ Note you are asked to return the item to it's home library. 3b/ With the patch applied, the modal title should highlight that a 'Wrong transfer' was detected. 4/ Go to the item record and note the holding library has been updated to reflect where the item was most recently checked in. 4a/ With the patch applied the item status should reflect the last checked in branch as the 'from' branch of the transfer. 5/ check-in from a 4th library, but use the 'Print slip' option for accepting the transfer and confirm that also works. 6/ check-in from a 5th library, but use the 'Cancel' option and check that this results in the item staying at it's current location and the final transfer having been cancelled. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 18:20:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 16:20:15 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 --- Comment #60 from Kyle M Hall --- Created attachment 121799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121799&action=edit Bug 24434: Add Unit Tests for relations This patch adds unit tests for the newly introduced to_library (and also add the missing test for the existing from_library). Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 18:20:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 16:20:20 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 --- Comment #61 from Kyle M Hall --- Created attachment 121800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121800&action=edit Bug 24434: Unit tests for updateWrongTransfer Add unit tests to cover updateWrongTransfer Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 18:20:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 16:20:25 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 --- Comment #62 from Kyle M Hall --- Created attachment 121801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121801&action=edit Bug 24434: Submit on print slip This patch ensures that the print slip option on the WrongTransfer modal also submits the form and thus triggers the actual transfer of the item. We also prevent a double transfer submission (and thus a cancellation line appearing in the branchtransfers table) for the case where a transfer back home is triggered. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 18:20:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 16:20:30 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 --- Comment #63 from Kyle M Hall --- Created attachment 121802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121802&action=edit Bug 24434: Add 'WrongTransfer' to cancellation_reasons Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 18:20:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 16:20:34 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 --- Comment #64 from Kyle M Hall --- Created attachment 121803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121803&action=edit Bug 24434: DBIC Update Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 18:20:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 16:20:39 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 --- Comment #65 from Kyle M Hall --- Created attachment 121804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121804&action=edit Bug 24434: (QA follow-up) Remove tab character Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 18:50:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 16:50:25 +0000 Subject: [Koha-bugs] [Bug 28551] New: Add ability to limit gather_print_notices by patron category Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28551 Bug ID: 28551 Summary: Add ability to limit gather_print_notices by patron category Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It would be great if gather_print_notices could be run with a list of patron categories to include/exclude. I'm imagining one new flag for an allowlist and another new flag for a deny list. The use case at hand is a library that wants to mail printed Hold Available notices to some but not all patrons. HOLD notices generate as print by default, so there's no way to simply turn them off for patrons in the category that should not receive them. A new flag in the gather_print cron would allow us to at least stop emailing them to the library along with the HOLD notices they do want. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 19:09:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 17:09:54 +0000 Subject: [Koha-bugs] [Bug 17506] Offline circ needs to be logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17506 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 19:43:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 17:43:22 +0000 Subject: [Koha-bugs] [Bug 28534] pending_offline_circulations table uses MyISAM engine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 20:11:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 18:11:48 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119717|0 |1 is obsolete| | --- Comment #10 from Salman Ali --- Created attachment 121805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121805&action=edit Bug 27981: (follow-up) Set pref off for existing tests The patches applies now. I have tested it and can confirm that it works as intended. Signed-off-by: Frank Hansen Signed-off-by: Salman Ali -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 20:12:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 18:12:56 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |salman.ali at inLibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 20:19:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 18:19:05 +0000 Subject: [Koha-bugs] [Bug 28542] Move new authority from Z39.50/SRU to a button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28542 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 20:19:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 18:19:08 +0000 Subject: [Koha-bugs] [Bug 28542] Move new authority from Z39.50/SRU to a button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28542 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121770|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 121806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121806&action=edit Bug 28542: Move new authority from Z39.50/SRU to a button Actually in authority tools bar, 'New from Z39.50/SRU' is inside 'New autority' menu. This is different from biblio cataloguing toolbar, and adds a click to access it. I propose to move this to its own button. Test plan : 1) Create a Z39.50/SRU server connexion for authorities 2) Go to authorities home page 3) Check you see buttons 'New autority' and 'New from Z39.50/SRU' 4) Click on 'New autority' 5) Check you only see autority types 6) Click on 'New from Z39.50/SRU' 7) Check you go to Z39.50/SRU popup 8) Delete Z39.50/SRU server connexion for authorities 9) Go to authorities home page 10) Check you dont see 'New from Z39.50/SRU' Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 20:31:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 18:31:07 +0000 Subject: [Koha-bugs] [Bug 28552] New: Internal server error when patron's birthday doesn't include required number of characters Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28552 Bug ID: 28552 Summary: Internal server error when patron's birthday doesn't include required number of characters Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: madamyk at ckls.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When adding or editing a patron record, if the birth date is manually typed in and doesn't include the proper number and type of characters (MM/DD/YYYY), attempting to save the patron record will result in an internal server error. For example, 07/09/1999 will work, but 7/9/1999 will return the error. It would be very helpful if Koha would kick us back to the patron creation screen, preferably with an error or explanation message, rather than returning an internal server error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 20:31:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 18:31:32 +0000 Subject: [Koha-bugs] [Bug 28542] Move new authority from Z39.50/SRU to a button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28542 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This makes the layout for release notes| |creating new authorities | |consistent with creating | |new records - there is now | |a separate button 'New from | |Z39.50/SRU' (rather than | |being part of the drop-down | |list). CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 20:53:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 18:53:25 +0000 Subject: [Koha-bugs] [Bug 28543] Clicking on 'New record' will use default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28543 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 20:53:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 18:53:28 +0000 Subject: [Koha-bugs] [Bug 28543] Clicking on 'New record' will use default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28543 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121793|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 121807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121807&action=edit Bug 28543: Clicking on 'New record' will use default framework In biblio records cataloguing, clicking on 'New from z39.50/SRU' will run action with default framework. Clicking on 'New record' should do the same. Test plan : 1) Go to cataloguing home page 2) Check you see 'New record' with a sparator and then a caret (like 'New from z39.50/SRU') 3) Click on button text => You go to record edition with default framework 4) Clik on caret => You see list of framworks Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 20:59:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 18:59:05 +0000 Subject: [Koha-bugs] [Bug 28533] Requesting whole field in 'itemcallnumber' system preference causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28533 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121738|0 |1 is obsolete| | --- Comment #2 from Salman Ali --- Created attachment 121808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121808&action=edit Bug 28533: Set subfields to 'undef' if whole field request in itemcallnumebr system preference This patch undefines the CNsubfields variable when the whole field is requested Note that the substr returns '' when no characters are found, so we test if the string eq '' Testing 'truth' doesn't work because "0" is a valid option To test: 1 - Edit a record, add an 082 field 082 0 0 ‡aalpha‡bbeta‡0delta 2 - Set itemcallnumber system preference to 082 3 - Attempt to add/edit items 4 - ISE 5 - Apply patch, restart all the things 6 - Add/edit items - no error 7 - Confirm the itemcallnumber field is populated with "alpha beta delta" 8 - Set itemcallnumber system preference to '0820' 9 - Add/edit items 10 - Confirm itemcallnumber is populated with 'delta' Signed-off-by: Salman Ali -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 20:59:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 18:59:32 +0000 Subject: [Koha-bugs] [Bug 28533] Requesting whole field in 'itemcallnumber' system preference causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28533 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |salman.ali at inLibro.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 21:00:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 19:00:30 +0000 Subject: [Koha-bugs] [Bug 28543] Clicking on 'New record' will use default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28543 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This enhancement changes release notes| |the 'New record' button | |when cataloguing. Before | |this change you needed to | |choose the framework - now | |it will use the default | |framework unless you select | |a different framework from | |the drop-down list. This | |makes it consistent with | |creating a new record using | |the 'New from Z39.50/SRU' | |button. | | | |NOTE: This is a | |change in default behavour | |that cataloguers may be | |used to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 21:05:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 19:05:37 +0000 Subject: [Koha-bugs] [Bug 28553] New: Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 Bug ID: 28553 Summary: Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Following bug 18532, one can set a patron's messaging prefs to deliver an auto-renew notice via SMS. However, the auto_renewals cron only knows how to generate email notices. We should not allow the selection of non-functional transport types. We need to either teach the cron to send SMS notices or teach the messaging prefs to not allow you to select SMS. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 21:08:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 19:08:46 +0000 Subject: [Koha-bugs] [Bug 28543] Clicking on 'New record' will use default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28543 --- Comment #3 from David Nind --- I like things to be consistent, so I like this enhancement. However, I am not a cataloguer so was wondering: - Is there a way to set what the default framework used is, for example books? (I couldn't see anything under Administration > Catalog > MARC bibliographic framework, or a system preference.) - Will this cause any issues for cataloguers, as it is potentially a change in their default behavour? For example, cause records to be catalogued by default using the default framework, rather than specific frameworks libraries have setup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 21:11:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 19:11:33 +0000 Subject: [Koha-bugs] [Bug 26838] Improve styling of checkin message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115046|0 |1 is obsolete| | --- Comment #5 from Salman Ali --- Created attachment 121809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121809&action=edit Bug 26838: Improve styling of checkin message This patch makes some changes to the style and use of the "problem" class in the staff interface: - Remove the background color - Remove the extra line height Some changes to the template: - Remove the problem class from the checkin message. The checkin message configuration determines whether the dialog is an alert or a message-style dialog. - Add Font Awesome icons to the "problem" messages in patron details and serials collection. This is to help emphasize the message for users who might have difficulty seeing the color difference. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> Item types and configure a checkin message for an item type: Add a message and select "Message" as the checkin message type. - Check in an item with that item type and confirm that you see the checkin message. It should be displayed in a message-style dialog without any additional styling. - Change the item type configuration to use "Alert" as the checkin message type. Confirm that the correct style is shown in this case as well. - Locate a patron with a NULL value in borrowers.password. View the detail page for that patron. - Under the "Library use" heading, the "Password" line should contain a link with the text "Undefined," preceded by a red-colored Font Awesome icon. - In Serials, locate a subscription which is expired. - View the details for the subscription, and then open "serial collection" from the sidebar menu. - On the serial collection page there should be a cell in the subscription summary table showing the message "Subscription expired" preceded by a red-colored Font Awesome icon. Signed-off-by: Salman Ali -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 21:12:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 19:12:03 +0000 Subject: [Koha-bugs] [Bug 26838] Improve styling of checkin message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |salman.ali at inLibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 10 21:44:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Jun 2021 19:44:37 +0000 Subject: [Koha-bugs] [Bug 28534] pending_offline_circulations table uses MyISAM engine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #2 from David Nind --- I wasn't sure how to test this (using koha-testing-docker), but thought that this would work: 1. Check table structure in the database: . koha-mysql kohadev . show create table pending_offline_operations; . should show as "..ENGINE=MyISAM..." 2. Apply patch 3. Update the database (updatedatabase) 4. Check the table structure as per step 1 - should show as "..ENGINE=INNODB.." It does update if I do a reset_all, but for the existing installations I seem to be missing something... (restarting the container didn't work for me - docker restart koha_db_1)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 09:51:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 07:51:08 +0000 Subject: [Koha-bugs] [Bug 28545] Noisy uninitialized warn at opac-MARCdetail.pl line 313 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 09:51:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 07:51:11 +0000 Subject: [Koha-bugs] [Bug 28545] Noisy uninitialized warn at opac-MARCdetail.pl line 313 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121794|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy --- Created attachment 121810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121810&action=edit Bug 28545: Noisy uninitialized warn at opac-MARCdetail.pl line 313 Test plan: You do not even need a NULL value in a authorised value controlled item field, a zero in damaged or withdrawn is enough to trigger the warnings. (Because only the 1 is linked to an authvalue.) Check your plack-opac-error.log before and after applying this change. Signed-off-by: Marcel de Rooy Without the patch I had at least four warnings per item: withdrawn, lost, damaged and notforloan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 11:28:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 09:28:07 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28292 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 11:28:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 09:28:07 +0000 Subject: [Koha-bugs] [Bug 28292] Searching with colon ":" in the end of query gives internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28292 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28316 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 11:29:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 09:29:35 +0000 Subject: [Koha-bugs] [Bug 28292] Searching with colon ":" in the end of query gives internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28292 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #3 from Peter Vashchuk --- *** This bug has been marked as a duplicate of bug 28316 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 11:29:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 09:29:35 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #22 from Peter Vashchuk --- *** Bug 28292 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 12:24:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 10:24:50 +0000 Subject: [Koha-bugs] [Bug 28383] Log in via the itemsearch URL leads to Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28383 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #1 from Fridolin Somers --- Oh crap indeed. I think it comes from : my $cgi = CGI->new; my %params = $cgi->Vars; ... if (scalar keys %params > 0) { # Parameters given, it's a search In case of authentication, user and password are params. Maybe we can test if $format param is defined. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 12:25:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 10:25:08 +0000 Subject: [Koha-bugs] [Bug 28383] Log in via the itemsearch URL leads to Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28383 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 12:25:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 10:25:16 +0000 Subject: [Koha-bugs] [Bug 28383] Log in via the itemsearch URL leads to Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28383 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 12:25:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 10:25:20 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121661|0 |1 is obsolete| | --- Comment #36 from Emmi Takkinen --- Created attachment 121811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121811&action=edit Bug 28490: Revert "Bug 26995: Remove one remaining occurrence in moremember" This reverts commit c3b50e9e97e917090ce09283807168caaad3de4a. It was part of a patch set that removed actively used data and must be therefore reverted. Signed-off-by: Kyle M Hall Signed-off-by: Petro Vashchuk Signed-off-by: Emmi Takkinen --- koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt index cd416da0ec..eaa0d18841 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt @@ -321,7 +321,7 @@ [% END %] [% END %] [% IF patron.contactfirstname OR patron.contactname %] -
  • [% patron.contactfirstname | html %] [% patron.contactname | html %]
    • +
  • [% patron.contactfirstname | html %] [% patron.contactname | html %][% IF patron.relationship %] ([% patron.relationship | html %])[% END %]
    • [% END %] -- 2.25.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 12:25:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 10:25:37 +0000 Subject: [Koha-bugs] [Bug 25376] Use LANG authorised values for language facet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25376 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 12:25:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 10:25:52 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 12:25:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 10:25:57 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121662|0 |1 is obsolete| | --- Comment #37 from Emmi Takkinen --- Created attachment 121812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121812&action=edit Bug 28490: Revert "Bug 26995: Remove occurrences in sample_patrons.yml" This reverts commit 690b073478b04c7c801058b49f85275281c502d5. It was part of a patch set that removed actively used data and must be therefore reverted. Signed-off-by: Kyle M Hall Signed-off-by: Petro Vashchuk Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 12:26:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 10:26:35 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121663|0 |1 is obsolete| | --- Comment #38 from Emmi Takkinen --- Created attachment 121813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121813&action=edit Bug 28490: Revert "Bug 26995: Fix SQL syntax error on the about page" This reverts commit 1131bb687f14fef7b4cb5f3b194711e85f9227af. It was part of a patch set that removed actively used data and must be therefore reverted. Signed-off-by: Kyle M Hall Signed-off-by: Petro Vashchuk Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 12:27:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 10:27:01 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121664|0 |1 is obsolete| | --- Comment #39 from Emmi Takkinen --- Created attachment 121814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121814&action=edit Bug 28490: Revert "Bug 26995: Remove references to relationship column" This reverts commit 1cc8a77c287666ed878ea58f17216793f52ce224. It was part of a patch set that removed actively used data and must be therefore reverted. Signed-off-by: Kyle M Hall Signed-off-by: Petro Vashchuk Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 12:27:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 10:27:03 +0000 Subject: [Koha-bugs] [Bug 28554] New: In itemsearch sort filters by description Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Bug ID: 28554 Summary: In itemsearch sort filters by description Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In itemsearch form, there are several filters build with authorized values or item types. There values should be sorted by description. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 12:27:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 10:27:13 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 12:27:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 10:27:54 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121665|0 |1 is obsolete| | --- Comment #40 from Emmi Takkinen --- Created attachment 121815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121815&action=edit Bug 28490: Revert "Bug 26995: Drop column relationship from borrowers, deletedborrowers and borrower_modifications tables" This reverts commit ca0e7541ecdff13ada9ba8ffbd992c963959d30f. It was part of a patch set that removed actively used data and must be therefore reverted. Signed-off-by: Kyle M Hall Signed-off-by: Petro Vashchuk Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 12:28:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 10:28:21 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121666|0 |1 is obsolete| | --- Comment #41 from Emmi Takkinen --- Created attachment 121816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121816&action=edit Bug 28490: Comment out the relationship data removing DB update step These columns that were actively used to store non-patron guarantor relationship info were dropped incorrectly. In a later patch the relationship fields will be re-added. Signed-off-by: Kyle M Hall Signed-off-by: Petro Vashchuk Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 12:28:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 10:28:50 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121667|0 |1 is obsolete| | --- Comment #42 from Emmi Takkinen --- Created attachment 121817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121817&action=edit Bug 28490: Bring back accidentally deleted relationship columns These were in active use before and were accidentally deleted in Bug 26995. This restores those deleted relationship columns. To test: 1) verify the borrower_modifications, borrowers, deletedborrowers contain the column exactly like it was before after applying these patches by comparing to the old kohastructure.sql version Signed-off-by: Petro Vashchuk Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 12:29:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 10:29:16 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121669|0 |1 is obsolete| | --- Comment #43 from Emmi Takkinen --- Created attachment 121818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121818&action=edit Bug 28490: Add DBIx schema changes for testing Signed-off-by: Petro Vashchuk Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 12:56:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 10:56:04 +0000 Subject: [Koha-bugs] [Bug 28541] Incorrect default pickup location passed to HTML, causing UI show items unreservable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28541 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |stalkernoid at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 13:27:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 11:27:47 +0000 Subject: [Koha-bugs] [Bug 28383] Log in via the itemsearch URL leads to Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28383 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 13:27:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 11:27:50 +0000 Subject: [Koha-bugs] [Bug 28383] Log in via the itemsearch URL leads to Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28383 --- Comment #2 from Jonathan Druart --- Created attachment 121819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121819&action=edit Bug 28383: Fix itemsearch when accessed from the login form There are params here (credentials), we need to test for the existence of $format. Test plan: logout access /cgi-bin/koha/catalogue/itemsearch.pl Login => Without this patch you get a 500 (because we hit the exit statement) => With this patch you see the items search form. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 13:28:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 11:28:01 +0000 Subject: [Koha-bugs] [Bug 28383] Log in via the itemsearch URL leads to Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28383 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 13:44:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 11:44:29 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 13:44:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 11:44:32 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 --- Comment #1 from Fridolin Somers --- Created attachment 121820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121820&action=edit Bug 28554: In Koha::AuthorisedValues sort by description In itemsearch form, there are several filters build with authorized values. There values should be sorted by description. Test plan : 1) Create several values and descriptions in authorized values LOC 2) Go to itemsearch 3) See filter by location sorts on description and not on value Seems change in search_by_marc_field can not be tested in interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 13:44:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 11:44:48 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 --- Comment #2 from Fridolin Somers --- Created attachment 121821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121821&action=edit Bug 28554: In itemsearch sort item types filter by description In itemsearch form, the item types filter should be sorted by description. Test plan : 1) Create several values and descriptions in item types 2) Go to itemsearch 3) See filter by item types sorts on description and not on value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 13:45:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 11:45:27 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 --- Comment #3 from Fridolin Somers --- If needed I will create a unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 13:47:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 11:47:02 +0000 Subject: [Koha-bugs] [Bug 16881] Apply KohaTable and ColVis plugin on MARCdetail's items table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27467 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 13:47:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 11:47:02 +0000 Subject: [Koha-bugs] [Bug 27467] Provide a static URL for tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27467 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16881 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 13:49:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 11:49:41 +0000 Subject: [Koha-bugs] [Bug 28247] Add a MARC preview column to to Authority search results table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28247 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Owen Leonard --- The "Heading type" and "MARC preview" headings are misaligned with regard to the contents of the table, so the "Show" button is under the "Heading type" column header. To be consistent with other areas of Koha I would ask that the button say "MARC preview." For instance, from the cataloging search results: MARC preview Generally if there are other actions grouped in a menu like there are on the authority search results page I would say put any new actions in that menu too. However on this page the results is (for me at least) always quite narrow so there is plenty of room. I'm interested to hear what others think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 13:50:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 11:50:19 +0000 Subject: [Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 --- Comment #2 from Owen Leonard --- Is this really signed off? It looks like you may have forgotten to attach the signed-off patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 14:22:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 12:22:03 +0000 Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 14:22:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 12:22:06 +0000 Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280 --- Comment #14 from Nick Clemens --- Created attachment 121822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121822&action=edit Bug 8280: Add koha set and item fields to pqf.properties This patch adds a 'koha' set to the pqf properties and maps some basic koha fields to all for searchign To test: 1 - Apply patch 2 - cp etc/z3950/pqf.properties /etc/koha/sites/kohadev/z3950/pqf.properties 3 - sudo koha-z3950-responder --restart kohadev 4 - Test a search: curl -XGET "http://localhost:2100/biblios?version=1.1&operation=searchRetrieve&query=koha.itemtype=BK&maximumRecords=60&recordSchema=marcxml" 5 - Test other fields added: koha.withdrawn koha.lost koha.classification-source koha.materials-specified koha.damaged koha.restricted koha.cn-sort koha.notforloan koha.ccode koha.itemnumber koha.homebranch koha.holdingbranch koha.location koha.barcode koha.onloan koha.itemtype -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 14:22:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 12:22:33 +0000 Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 14:40:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 12:40:10 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 14:40:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 12:40:14 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121811|0 |1 is obsolete| | --- Comment #44 from Nick Clemens --- Created attachment 121823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121823&action=edit Bug 28490: Revert "Bug 26995: Remove one remaining occurrence in moremember" This reverts commit c3b50e9e97e917090ce09283807168caaad3de4a. It was part of a patch set that removed actively used data and must be therefore reverted. Signed-off-by: Kyle M Hall Signed-off-by: Petro Vashchuk Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 14:40:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 12:40:18 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121812|0 |1 is obsolete| | --- Comment #45 from Nick Clemens --- Created attachment 121824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121824&action=edit Bug 28490: Revert "Bug 26995: Remove occurrences in sample_patrons.yml" This reverts commit 690b073478b04c7c801058b49f85275281c502d5. It was part of a patch set that removed actively used data and must be therefore reverted. Signed-off-by: Kyle M Hall Signed-off-by: Petro Vashchuk Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 14:40:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 12:40:23 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121813|0 |1 is obsolete| | --- Comment #46 from Nick Clemens --- Created attachment 121825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121825&action=edit Bug 28490: Revert "Bug 26995: Fix SQL syntax error on the about page" This reverts commit 1131bb687f14fef7b4cb5f3b194711e85f9227af. It was part of a patch set that removed actively used data and must be therefore reverted. Signed-off-by: Kyle M Hall Signed-off-by: Petro Vashchuk Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 14:40:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 12:40:27 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121814|0 |1 is obsolete| | --- Comment #47 from Nick Clemens --- Created attachment 121826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121826&action=edit Bug 28490: Revert "Bug 26995: Remove references to relationship column" This reverts commit 1cc8a77c287666ed878ea58f17216793f52ce224. It was part of a patch set that removed actively used data and must be therefore reverted. Signed-off-by: Kyle M Hall Signed-off-by: Petro Vashchuk Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 14:40:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 12:40:31 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121815|0 |1 is obsolete| | --- Comment #48 from Nick Clemens --- Created attachment 121827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121827&action=edit Bug 28490: Revert "Bug 26995: Drop column relationship from borrowers, deletedborrowers and borrower_modifications tables" This reverts commit ca0e7541ecdff13ada9ba8ffbd992c963959d30f. It was part of a patch set that removed actively used data and must be therefore reverted. Signed-off-by: Kyle M Hall Signed-off-by: Petro Vashchuk Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 14:40:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 12:40:35 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121816|0 |1 is obsolete| | --- Comment #49 from Nick Clemens --- Created attachment 121828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121828&action=edit Bug 28490: Comment out the relationship data removing DB update step These columns that were actively used to store non-patron guarantor relationship info were dropped incorrectly. In a later patch the relationship fields will be re-added. Signed-off-by: Kyle M Hall Signed-off-by: Petro Vashchuk Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 14:40:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 12:40:39 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121817|0 |1 is obsolete| | --- Comment #50 from Nick Clemens --- Created attachment 121829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121829&action=edit Bug 28490: Bring back accidentally deleted relationship columns These were in active use before and were accidentally deleted in Bug 26995. This restores those deleted relationship columns. To test: 1) verify the borrower_modifications, borrowers, deletedborrowers contain the column exactly like it was before after applying these patches by comparing to the old kohastructure.sql version Signed-off-by: Petro Vashchuk Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 14:40:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 12:40:43 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121818|0 |1 is obsolete| | --- Comment #51 from Nick Clemens --- Created attachment 121830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121830&action=edit Bug 28490: Add DBIx schema changes for testing Signed-off-by: Petro Vashchuk Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 14:41:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 12:41:53 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #52 from Nick Clemens --- I can edit patrons, the about page works, all looks correct. I did get some errors from qa tools about DBIC *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'ordernumbers' is trying to create a utility method called ordernumbers_rs. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** I assume this is a clash of 'relationship' columns and Relationship class? things still seem to work, but noting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 14:55:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 12:55:56 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 14:56:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 12:56:01 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121650|0 |1 is obsolete| | --- Comment #70 from Nick Clemens --- Created attachment 121831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121831&action=edit Bug 28489: Modify sessions.a_session from longtext to longblob This column contains serialized data, it should be a blob. And it fixes encoding issues. Test plan: 1. Apply patch and run updatedatabase 2. In $KOHA_CONF make sure that you have 0 3. Create 2 libraries: a. TESTÄ/Testä b. TEST✓/Test✓ 4. Go to the staff interface, change your library to Testä, then navigate to a few other pages, make sure there is no encoding problem with the library name in the top right corner 5. Do the same with Test✓ Signed-off-by: Petro Vashchuk Signed-off-by: Andrew Nugged Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 14:56:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 12:56:06 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121651|0 |1 is obsolete| | --- Comment #71 from Nick Clemens --- Created attachment 121832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121832&action=edit Bug 28489: Modify sessions.a_session from longtext to longblob (kohastructure.sql) Signed-off-by: Petro Vashchuk Signed-off-by: Andrew Nugged Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 14:56:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 12:56:10 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121652|0 |1 is obsolete| | --- Comment #72 from Nick Clemens --- Created attachment 121833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121833&action=edit Bug 28489: Add selenium tests Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 14:56:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 12:56:14 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121653|0 |1 is obsolete| | --- Comment #73 from Nick Clemens --- Created attachment 121834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121834&action=edit Bug 28489: POD - CGI::Session::Serialize::yamlxs for CGI::Session Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 14:56:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 12:56:19 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121654|0 |1 is obsolete| | --- Comment #74 from Nick Clemens --- Created attachment 121835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121835&action=edit Bug 28489: Don't deal with encoding during the serialization Signed-off-by: David Cook Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 15:01:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 13:01:23 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #75 from Nick Clemens --- Note: The libraries added in the selenium tests are not removed during cleanup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 15:13:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 13:13:36 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 15:13:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 13:13:39 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121649|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 121836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121836&action=edit Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory This patch adds a "lib" directory to the source tree which gets mapped to the same directory as "C4" and "Koha" for single and standard installations. CGI::Session::Serialize::yamlxs is put into this "lib" directory. This patch also includes some changes so that dev/git installations work as well. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 15:23:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 13:23:59 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121751|0 |1 is obsolete| | Attachment #121752|0 |1 is obsolete| | Attachment #121753|0 |1 is obsolete| | Attachment #121754|0 |1 is obsolete| | Attachment #121755|0 |1 is obsolete| | Attachment #121756|0 |1 is obsolete| | --- Comment #23 from Peter Vashchuk --- Created attachment 121837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121837&action=edit Bug 28316: screen unquoted semicolons and all followup colons Currently searches like: "book:", ":book" and "host-item:test:n" cause internal server errors. This patch adds additional regexes that screens the colons at the start and end of the query, and another regex that screens all follow-up colons that go after the first colon to avoid errors when searching for "host-item:test:n". To reproduce: 1) using ES, search for the book with title that contains semicolon at the start or at the end of the line, separated with spaces, this should cause internal server error. 2) try doing the same with something like "host-item:test:n", it should result in error as well. 3) apply the patch. 4) repeat steps 1-2, ensure that it works now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 15:24:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 13:24:06 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #24 from Peter Vashchuk --- Created attachment 121838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121838&action=edit Bug 28316: escape brackets in the search query This patch screens square and curly brackets which have no special language meaning, while keeping ranges as they are, allowing ES to search for biblios with titles that contain square and curly brackets and at the same time allows the use of range searches ([1990 TO 2000]). To reproduce: 1) using ES, search for the book with title that contains square and/or curly brackets, like "book [second edition]", which will result in error. 2) apply the patch. 3) search for that book again, ensure that it works now. 4) additionally perform a search using range, for example: "[1999 TO 2020]", ensure that it works correctly too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 15:24:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 13:24:12 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #25 from Peter Vashchuk --- Created attachment 121839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121839&action=edit Bug 28316: escape exclamation signs in the query Currently having exclamation sign at the end of the query makes ES search fail, and when you try to search for a book that has exclamation sign in the tittle (something like "Words! words") won't show results correctly as it tries to negate everything that is after exclamation sign, making it impossible to search for books that have in in the title This patch escapes exclamation signs if it's at the end of the query or has a space after it, resolving both of the issues listed above. To reproduce: 1) with ES enabled, search for the book with title that contains exclamation sight at the end, like "book!", this search should result in error. 2) do another search, but this time find/prepare beforehand book with a title that has exclamation sign with a space after it, e.g "exclamation! sign", it shouldn't find it as ES treats everything after that exclamation sign as negation. 2) apply the patch. 3) perform searches from the steep one and two again. Search from step one should no longer fail, while search from the step two should find that book. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 15:24:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 13:24:17 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #26 from Peter Vashchuk --- Created attachment 121840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121840&action=edit Bug 28316: avoid messing up regexes in the search queries This patch ensures that the behavior with QueryRegexEscapeOptions set to values other than "Escape" still will works as expected. It does so by storing the contents of regexes before escaping special characters and then restores the contents of regexes back to how it was before, ensuring that searching with regex is possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 15:24:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 13:24:23 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #27 from Peter Vashchuk --- Created attachment 121841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121841&action=edit Bug 28316: escape ES ranges if QueryAutoTruncate is enabled if QueryAutoTruncate enabled we will have any special operators ruined for example: "test [6 TO 7]" will be converted to "test* [6* TO* 7]" so no reason to keep ranges when QueryAutoTruncate set to "enabled" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 15:24:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 13:24:28 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #28 from Peter Vashchuk --- Created attachment 121842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121842&action=edit Bug 28316: add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 15:46:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 13:46:41 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 15:46:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 13:46:45 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121718|0 |1 is obsolete| | --- Comment #23 from Nick Clemens --- Created attachment 121843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121843&action=edit Bug 28520: Revert "Bug 12362: (QA follow-up) Fix ModItemTransfer cancellation handling" This reverts commit fbba09f63f200d3e57a8612554984d807867cf84. This commit was part of a series adding adding reverse transfers, i.e. transfers that were created for transfers that were cancelled and we wanted the item to return back to its sending library. This however hid the information about transfer happening and we need another approach to the problem. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 15:46:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 13:46:48 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121719|0 |1 is obsolete| | --- Comment #24 from Nick Clemens --- Created attachment 121844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121844&action=edit Bug 28520: Revert "Bug 12362: Cancel transfer with hold cancelation" This reverts commit 6c105829144cd341a4bc65ad8d0ee1f996b423d4. This commit was part of a series adding adding reverse transfers, i.e. transfers that were created for transfers that were cancelled and we wanted the item to return back to its sending library. This however hid the information about transfer happening and we need another approach to the problem. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 15:46:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 13:46:52 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121720|0 |1 is obsolete| | --- Comment #25 from Nick Clemens --- Created attachment 121845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121845&action=edit Bug 28520: Revert "Bug 12362: Reverse transfer upon cancellation" This reverts commit d0407686eb070c5bdf0302147a198027abea5ac0. This commit was part of a series adding adding reverse transfers, i.e. transfers that were created for transfers that were cancelled and we wanted the item to return back to its sending library. This however hid the information about transfer happening and we need another approach to the problem. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 15:46:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 13:46:55 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121721|0 |1 is obsolete| | --- Comment #26 from Nick Clemens --- Created attachment 121846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121846&action=edit Bug 28520: Bring back TransferCancellation reason handling from reverted Bug 12362 The code from Bug 12362 was reverted but there might be still in database transfers with the reason 'TransferCancellation' so we need to restore the code to handle displaying that information. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 15:46:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 13:46:59 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121722|0 |1 is obsolete| | --- Comment #27 from Nick Clemens --- Created attachment 121847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121847&action=edit Bug 28520: Allow creating a transfer back automatically if a hold is canceled during transit This fixes regression caused by "Bug 12362: Cancel transfer with hold cancelation" where cancelled hold's transfer didn't show up in intranet and opac because it create a new transfer that was not yet put in in-transit state. The original idea of bug 12362 was to be able to trigger transfer back home if a hold was cancelled (a regression caused by bug 26078). However, we can do it more simply by setting the $validTransfer variable true in the item check-in code when we are dealing with Reserve transfers. More down in the AddReturn() code there is also a check "and !$resfound" to make sure we only try to trigger the transfer back home automatically if there is no hold waiting at the current location the item arrived in. It should be noted however that now we only display generic message for the automatic transfer reason. Bug 12362 made the return display as the reason "Transfer was cancelled whilst in transit". However, since this fixes the original regressions caused by bug 26078 and restores similar behaviour to that I think giving a more descriptive message for example regarding a hold being cancelled can be considered a further enhancement. To test: 1) Apply patch 1) Have biblio with item in branch A 2) Create a new hold with a pickup library to branch B 3) Check-in the item at branch A and confirm the hold and transfer 4) Cancel the hold 5) Check-in the hold at branch B and notice it prompt to return it to branch A Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 16:05:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 14:05:07 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121831|0 |1 is obsolete| | Attachment #121832|0 |1 is obsolete| | Attachment #121833|0 |1 is obsolete| | Attachment #121834|0 |1 is obsolete| | Attachment #121835|0 |1 is obsolete| | --- Comment #76 from Jonathan Druart --- Created attachment 121848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121848&action=edit Bug 28489: Modify sessions.a_session from longtext to longblob This column contains serialized data, it should be a blob. And it fixes encoding issues. Test plan: 1. Apply patch and run updatedatabase 2. In $KOHA_CONF make sure that you have 0 3. Create 2 libraries: a. TESTÄ/Testä b. TEST✓/Test✓ 4. Go to the staff interface, change your library to Testä, then navigate to a few other pages, make sure there is no encoding problem with the library name in the top right corner 5. Do the same with Test✓ Signed-off-by: Petro Vashchuk Signed-off-by: Andrew Nugged Signed-off-by: David Cook Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 16:05:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 14:05:13 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #77 from Jonathan Druart --- Created attachment 121849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121849&action=edit Bug 28489: Modify sessions.a_session from longtext to longblob (kohastructure.sql) Signed-off-by: Petro Vashchuk Signed-off-by: Andrew Nugged Signed-off-by: David Cook Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 16:05:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 14:05:18 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #78 from Jonathan Druart --- Created attachment 121850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121850&action=edit Bug 28489: Add selenium tests Signed-off-by: David Cook Signed-off-by: Nick Clemens JD amended patch: Remove libraries the tests created -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 16:05:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 14:05:23 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #79 from Jonathan Druart --- Created attachment 121851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121851&action=edit Bug 28489: POD - CGI::Session::Serialize::yamlxs for CGI::Session Signed-off-by: David Cook Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 16:05:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 14:05:28 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #80 from Jonathan Druart --- Created attachment 121852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121852&action=edit Bug 28489: Don't deal with encoding during the serialization Signed-off-by: David Cook Signed-off-by: Nick Clemens Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 16:05:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 14:05:58 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Keywords| |rel_21_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 16:37:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 14:37:06 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 16:37:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 14:37:09 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121726|0 |1 is obsolete| | --- Comment #12 from Nick Clemens --- Created attachment 121853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121853&action=edit Bug 28487: Fallback to default template in overdue_notices There is no fallback to the "default" language if there is no language-specific template for the lang of the patron. I am not really sure why we are not using GetPreparredLetter here (which defaults), but this needs to be backported into all stable branches and so as small as possible. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 16:49:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 14:49:44 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 16:53:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 14:53:59 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate, | |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 16:54:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 14:54:18 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate, | |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 16:56:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 14:56:37 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 16:59:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 14:59:28 +0000 Subject: [Koha-bugs] [Bug 28555] New: Improve logging for overdue_notices.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28555 Bug ID: 28555 Summary: Improve logging for overdue_notices.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz The logging for this cronjob is a bit overwhelming To recreate: perl misc/cronjobs/overdue_notices.pl -v -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 17:12:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 15:12:12 +0000 Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116635|0 |1 is obsolete| | --- Comment #36 from Salman Ali --- Created attachment 121854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121854&action=edit Bug 13961: Check that borrowernumber isn't a reference Some SendAlerts() tests in Letters.t failed due SQL::Abstract errors, caused by HASH sometimes set as borrowernumber. Added code to check if borrowernumber is defined and it isn't a reference. To test prove t/db_dependent/Letters.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Salman Ali -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 17:13:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 15:13:45 +0000 Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |salman.ali at inLibro.com --- Comment #37 from Salman Ali --- Test needs fixing but patch is working -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 17:15:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 15:15:33 +0000 Subject: [Koha-bugs] [Bug 28555] Improve logging for overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28555 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 17:15:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 15:15:36 +0000 Subject: [Koha-bugs] [Bug 28555] Improve logging for overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28555 --- Comment #1 from Nick Clemens --- Created attachment 121855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121855&action=edit Bug 28555: Improve logging for overdue_notices.pl Currenlty the output with -v from overdue_notices is a bit overwhelming and hard to parse I do a few things here: 1 - Only show SQL if verbose > 1 2 - Add some separators to make it more readab;e 3 - Remove some redundant messages with branchcode and borrowernumber To test: 1: perl misc/cronjobs/overdue_notices.pl -v 2: Notice you get a LOT of information all smushed together 3: Apply patch 4: perl misc/cronjobs/overdue_notices.pl -v 5: Less info, and easier to read 6: perl misc/cronjobs/overdue_notices.pl -v -v 7: All the info, but nicer to read -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 17:15:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 15:15:53 +0000 Subject: [Koha-bugs] [Bug 28555] Improve logging for overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28555 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 17:19:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 15:19:44 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28555 CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 17:19:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 15:19:44 +0000 Subject: [Koha-bugs] [Bug 28555] Improve logging for overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28555 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28487 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 17:24:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 15:24:22 +0000 Subject: [Koha-bugs] [Bug 28443] Terminology: Issuing should be Checking out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28443 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 17:24:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 15:24:25 +0000 Subject: [Koha-bugs] [Bug 28443] Terminology: Issuing should be Checking out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28443 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121694|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 121856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121856&action=edit Bug 28443: Terminology: Issuing should be Checking out This patch modifies the title element of the batch checkout page so that it uses the phrase "Batch check out" instead of "Issuing." To test, apply the patch and enable BatchCheckouts system preference. - Open a patron for checkout who has a category included in the BatchCheckoutsValidCategories system preference. - Click the "Batch check out" tab and confirm that the page's title is correct. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 17:31:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 15:31:20 +0000 Subject: [Koha-bugs] [Bug 28522] Correct eslint errors in staff-global.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28522 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 17:31:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 15:31:23 +0000 Subject: [Koha-bugs] [Bug 28522] Correct eslint errors in staff-global.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28522 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121697|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 121857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121857&action=edit Bug 28522: Correct eslint errors in staff-global.js This patch makes minor corrections to staff-global.js in order to quiet warnings from ESLint. This includes: - Remove unused variables - Declare undeclared variables - Update list of global and exported variables and functions - Correct whitespace - Remove an unused function (paramOfUrl) To test, apply the patch and clear your browser cache if necessary. - Confirm that the first search header form field has focus when switching bewteen pages. - Confirm that text entered in any search header form field persists when you switch search header form tabs, e.g. a word typed into the "Check out" tab is copied to the "Check in" form when you switch to that tab. - Perform a search from the "Search the catalog" tab in the header. On the search results page and any following detail page your search term should remain in the header search form. - From a bibliographic detail page, confirm that selecting a list from the "Add to list" button menu correctly triggers a popup window. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 17:40:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 15:40:22 +0000 Subject: [Koha-bugs] [Bug 28405] Add author info to the holds page (reserve/request.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |salman.ali at inLibro.com --- Comment #7 from Salman Ali --- I think Barbara is right and that the author name should be next to the title because it doesn't feel like it's connected to the title when it's placed below. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 17:47:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 15:47:19 +0000 Subject: [Koha-bugs] [Bug 28479] TestBuilder.pm uses incorrect method for checking if objects to be created exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28479 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 17:47:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 15:47:22 +0000 Subject: [Koha-bugs] [Bug 28479] TestBuilder.pm uses incorrect method for checking if objects to be created exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28479 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121501|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 121858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121858&action=edit Bug 28479: Use primary keys to check object existence in TestBuilder The TestBuilder::build_object function used any foreign keys to check whether an object already exists or not. This brought incorrectly results of unrelated objects because using any other keys other than primary keys don't guarantee our results to point to one single object. For example, as is put here in the unit test, if you created two items with the same biblionumber and then tried to create a hold using build_object() we were using the biblionumber to check whether an item was linked to the hold already. Thus, we were checking whether a random item was already linked to the hold instead of the one we wanted either by passing it explicitly to build_object() or the one build_object() created implicitly. This also resulted in following warnings when there were more than one match: DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at /kohadevbox/koha/t/lib/TestBuilder.pm line 235 To test: $ prove t/db_dependent Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 17:52:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 15:52:19 +0000 Subject: [Koha-bugs] [Bug 28191] Update wording on batch patron deletion to reflect changes from bug 26517 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28191 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 17:52:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 15:52:22 +0000 Subject: [Koha-bugs] [Bug 28191] Update wording on batch patron deletion to reflect changes from bug 26517 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28191 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121630|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 121859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121859&action=edit Bug 28191: Upate wording on batch patron deletion This adds another point to the list of things that prevent patron deletion:
  • They have permissions assigned to them.
    • In order to test: - Go to tools > patron deletion and anonymization - Verify the new condition shows at the top of the page. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 17:58:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 15:58:35 +0000 Subject: [Koha-bugs] [Bug 28350] Order patron search broken (borrowernotes) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28350 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 17:58:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 15:58:38 +0000 Subject: [Koha-bugs] [Bug 28350] Order patron search broken (borrowernotes) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28350 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121636|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 121860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121860&action=edit Bug 28350: Fix borrowernotes sorting for patron search Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 17:59:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 15:59:00 +0000 Subject: [Koha-bugs] [Bug 28350] Order patron search broken (borrowernotes) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28350 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |alexis.ripetti at inLibro.com |ity.org | QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 17:59:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 15:59:17 +0000 Subject: [Koha-bugs] [Bug 28533] Requesting whole field in 'itemcallnumber' system preference causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28533 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 17:59:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 15:59:59 +0000 Subject: [Koha-bugs] [Bug 28513] Analytic search links formed incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28513 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |joonas.kylmala at helsinki.fi |ity.org | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 18:43:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 16:43:02 +0000 Subject: [Koha-bugs] [Bug 27348] Error defining INDEXER_PARAMS in /etc/default/koha-common In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27348 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 18:43:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 16:43:05 +0000 Subject: [Koha-bugs] [Bug 27348] Error defining INDEXER_PARAMS in /etc/default/koha-common In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27348 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121620|0 |1 is obsolete| | --- Comment #10 from Nick Clemens --- Created attachment 121861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121861&action=edit Bug 27348: Fix test on INDEXER_PARAMS in koha-indexer koha-indexer doesn't test INDEXER_PARAMS correctly which causes errors to display when stopping/starting the daemon. This patch fixes the test so that the variable is tested as a string, so that no errors are created and the params are passed correctly. Test plan: 0. Apply patch 1. vi /etc/default/koha-common 2. Add the following to the bottom of the file: INDEXER_PARAMS="-daemon -sleep 6" 3. cp debian/scripts/koha-indexer /usr/sbin/koha-indexer 4. koha-indexer --stop kohadev 5. Note no errors 6. koha-indexer --start kohadev 7. Note no errors 8. ps -efww | grep "indexer" 9. Note that rebuild_zebra.pl has the arguments "-daemon -sleep 6" Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 18:43:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 16:43:09 +0000 Subject: [Koha-bugs] [Bug 27348] Error defining INDEXER_PARAMS in /etc/default/koha-common In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27348 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121621|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 121862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121862&action=edit Bug 27348: Fix test on ALTERNATE_INDEXER_DAEMON in koha-indexer Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 18:46:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 16:46:41 +0000 Subject: [Koha-bugs] [Bug 28511] Road types in OPAC should prefer OPAC description if one exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28511 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 18:46:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 16:46:44 +0000 Subject: [Koha-bugs] [Bug 28511] Road types in OPAC should prefer OPAC description if one exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28511 --- Comment #3 from Nick Clemens --- Created attachment 121863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121863&action=edit Bug 27348: Fix test on ALTERNATE_INDEXER_DAEMON in koha-indexer Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 18:54:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 16:54:57 +0000 Subject: [Koha-bugs] [Bug 28542] Move new authority from Z39.50/SRU to a button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28542 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 18:55:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 16:55:00 +0000 Subject: [Koha-bugs] [Bug 28542] Move new authority from Z39.50/SRU to a button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28542 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121806|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 121864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121864&action=edit Bug 28542: Move new authority from Z39.50/SRU to a button Actually in authority tools bar, 'New from Z39.50/SRU' is inside 'New autority' menu. This is different from biblio cataloguing toolbar, and adds a click to access it. I propose to move this to its own button. Test plan : 1) Create a Z39.50/SRU server connexion for authorities 2) Go to authorities home page 3) Check you see buttons 'New autority' and 'New from Z39.50/SRU' 4) Click on 'New autority' 5) Check you only see autority types 6) Click on 'New from Z39.50/SRU' 7) Check you go to Z39.50/SRU popup 8) Delete Z39.50/SRU server connexion for authorities 9) Go to authorities home page 10) Check you dont see 'New from Z39.50/SRU' Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 18:58:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 16:58:18 +0000 Subject: [Koha-bugs] [Bug 28488] Javascript error in self-checkout (__ is not defined) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 18:58:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 16:58:21 +0000 Subject: [Koha-bugs] [Bug 28488] Javascript error in self-checkout (__ is not defined) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121695|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 121865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121865&action=edit Bug 28488: Javascript error in self-checkout (__ is not defined) This patch adds inclusion of the internationalization JavaScript which is required by the newest version of the DataTables include. It references the double-underscore function provided by i18n.js. To test, apply the patch and log into the self-checkout system as a user with checkouts. The table of checkouts should display correctly and there should be no JavaScript errors in the console. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 19:06:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 17:06:01 +0000 Subject: [Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 19:06:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 17:06:04 +0000 Subject: [Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121647|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 121866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121866&action=edit Bug 28518: Display missing inputs for "Return to the last advanced search" When more than 3 search terms are passed on the advanced search form, the "Return to the last advanced search" feature does not display them. Test plan: Perform an adv search at the OPAC, enter more than 3 terms, launch the search, click the "Return to the last advanced search" link and confirm that all the entries are there. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 19:09:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 17:09:47 +0000 Subject: [Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121737|0 |1 is obsolete| | --- Comment #3 from Salman Ali --- Created attachment 121867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121867&action=edit Bug 28495: Improve validation of library entry form This patch adds validation of the "Library code" field so that entry is limited to letters and numbers. Also changed: Updated the email fields to add the "email" type attribute (see also Bug 27805). To test, apply the patch and go to Administration -> Libraries -> New library. - Try entering various strings in the "Library code" field. If you enter anything other than letters and numbers an error message should be displaed on blur or on submit. - Try submitting the form with no data in the "Library code" and/or "Name" field. The fields should be required. - Test entering various strings in the email-type fields: Email, Ill staff email, Reply-To, and Return-Path. Non-email entries should trigger a message, "Please enter a valid email address." Signed-off-by: Salman Ali -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 19:11:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 17:11:53 +0000 Subject: [Koha-bugs] [Bug 28177] Add date column and column configuration to uploads In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28177 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120767|0 |1 is obsolete| | --- Comment #3 from Salman Ali --- Created attachment 121868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121868&action=edit Bug 28177: Add date column and column configuration to uploads This patch adds a "Date added" column to the table showing uploaded files. Column configuration is added to the table, and the date column is hidden by default. To test, apply the patch and restart all. - Go to Tools -> Upload. - If necessary, upload multiple files with the same category. - Use the "Search uploads by category" form to find those uploads. - In the table of uploads, confirm that table settings and other DataTable controls work correctly, including the option to show the "Date added" column. - Go to Administration -> Table settings -> Tools -> upload. - Change the settings for the uploads table. - Return to Uploads and confirm that your changes are reflected in the display of the uploads table. Signed-off-by: Salman Ali -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 19:17:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 17:17:15 +0000 Subject: [Koha-bugs] [Bug 28513] Analytic search links formed incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28513 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 19:17:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 17:17:18 +0000 Subject: [Koha-bugs] [Bug 28513] Analytic search links formed incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28513 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121635|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 121869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121869&action=edit Bug 28513: Fix analytics search links so they don't match unrelated biblios At least when using Searchengine=Elasticsearch what happened was that without () parenthese included the search for Host-item field was done only to the first token, the subsequent ones matched any fields. Adding the parentheses restrict the search to Host-item search field only. To test: 1) Set Searchengine = elasticsearch 2) Make a biblio with 245a = "biológica paranaense." and 773a = "Acta" 3) Go to a biblio with 245a = "Acta biológica paranaense" (in kohadevbox or create one if you need). 4) Notice that the "Acta biológica paranaense" biblio's detail page link "Show analytics" takes to the "biológica paranaense" incorrectly just because the 773a has "Acta" and the words "biológica" and "paranaense" appear elsewhere in the biblio. 5) Apply patch and notice the link is now not created at all Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 19:45:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 17:45:15 +0000 Subject: [Koha-bugs] [Bug 27929] Regex option in item batch modification is hidden for itemcallnumber if 952$o linked to cn_browser plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27929 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 19:45:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 17:45:19 +0000 Subject: [Koha-bugs] [Bug 27929] Regex option in item batch modification is hidden for itemcallnumber if 952$o linked to cn_browser plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27929 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121660|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 121870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121870&action=edit Bug 27929: Allow regex for subfield linked with cataloguing plugin Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 19:45:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 17:45:22 +0000 Subject: [Koha-bugs] [Bug 27929] Regex option in item batch modification is hidden for itemcallnumber if 952$o linked to cn_browser plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27929 --- Comment #7 from Nick Clemens --- Created attachment 121871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121871&action=edit Bug 27929: (QA follow-up) Hide tag editor on regex Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 19:51:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 17:51:42 +0000 Subject: [Koha-bugs] [Bug 28526] Impossible to search only zero In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28526 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 19:51:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 17:51:45 +0000 Subject: [Koha-bugs] [Bug 28526] Impossible to search only zero In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28526 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121723|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 121872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121872&action=edit Bug 28526: Impossible to search only zero In staff interface and OPAC, searching only zero leads to advanced search page. Test plan : 1) Go to opac home page 2) Enter 0 into search field => Without patch you go to advanced search page => With patch you go to results page 3) Idem on staff interface Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 19:51:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 17:51:48 +0000 Subject: [Koha-bugs] [Bug 28526] Impossible to search only zero In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28526 --- Comment #4 from Nick Clemens --- Created attachment 121873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121873&action=edit Bug 28526: (QA follow-up) Don't search if query is blank Signed-off-by: Nick Clemens Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 19:52:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 17:52:16 +0000 Subject: [Koha-bugs] [Bug 28526] Impossible to search only zero In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28526 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 20:02:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 18:02:59 +0000 Subject: [Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 20:03:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 18:03:02 +0000 Subject: [Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121503|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 121874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121874&action=edit Bug 28480: Add q parameters for GET /patrons This patch adds the q query parameters to the route. To test: 1. Try the route with the following query parameter: q={"patron_id":2} i.e. GET /api/v1/patrons?q={"patron_id":2} => FAIL: You get a bad request respose 2. Apply this patch 3. Restart all 4. Repeat 1 => SUCCESS: You get the patron 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 20:03:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 18:03:06 +0000 Subject: [Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480 --- Comment #4 from Nick Clemens --- Created attachment 121875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121875&action=edit Bug 28482: (QA follow-up) Add unit test Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 21:21:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 19:21:20 +0000 Subject: [Koha-bugs] [Bug 14237] Allow bibs to be added to course without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 21:21:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 19:21:25 +0000 Subject: [Koha-bugs] [Bug 14237] Allow bibs to be added to course without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120129|0 |1 is obsolete| | --- Comment #46 from Nick Clemens --- Created attachment 121876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121876&action=edit Bug 14237: Add individual bibliographic records to course reserves This feature allows a patron to add bibliographic records to course reserves. They can be added individually or in a batch. The courses that have reserved this record will also show on the record's detail page. To test: 1) Update database, refresh schema, and restart services 2) Enable the system preference UseCourseReserves 3) Set up a couple of biblios and a couple of items (attached to different biblios) 4) Go to Course Reserves and add a new course 5) Click Add reserves and put something in both the barcode field and biblionumber field. Click submit and confirm you get an error. 6) Add a barcode in the barcode field and submit. Confirm the item is reserved for the course as expected. 7) Add a biblionumber in the barcode field and submit. Add notes and Save. Confirm the record is reserved for the course as expected and the notes are saved correctly. 8) Edit the record-level course reserve that you just added. Confirm the correct record shows and any edits save as expected. 9) Go back to the course and try removing reserves. Use both the Remove action button for individual reserves and the Remove all reserves button. Confirm both work as expected. 10) Go to Batch add reserves and put something in both the barcodes field and biblionumbers field. Click submit and confirm you get an error. 11) Remove the barcodes and put some biblionumbers in the biblionumbers field. Add notes and Submit. Confirm the records are all added as expected. 12) Click on one of the biblios that has been reserved for the course. Confirm that the course shows under 'Courses that have reserved this title' on the biblio detail page. 13) Go back to the course and click Add reserves. Try and add a biblionumber that is already reserved. Confirm it detects that the biblio has already been reserved. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Christian Stelzenmüller Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 21:21:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 19:21:30 +0000 Subject: [Koha-bugs] [Bug 14237] Allow bibs to be added to course without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120130|0 |1 is obsolete| | --- Comment #47 from Nick Clemens --- Created attachment 121877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121877&action=edit Bug 14237: Database updates This patch adds a biblionumber column to course_items, adds a relationship between course_items.biblionumber and biblio.biblionumber, and changes course_items.itemnumber to allow null values. Signed-off-by: Christian Stelzenmüller Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 21:21:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 19:21:35 +0000 Subject: [Koha-bugs] [Bug 14237] Allow bibs to be added to course without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120131|0 |1 is obsolete| | --- Comment #48 from Nick Clemens --- Created attachment 121878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121878&action=edit Bug 14237: Schema updates Signed-off-by: Christian Stelzenmüller Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 21:21:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 19:21:39 +0000 Subject: [Koha-bugs] [Bug 14237] Allow bibs to be added to course without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120132|0 |1 is obsolete| | --- Comment #49 from Nick Clemens --- Created attachment 121879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121879&action=edit Bug 14237: Tests Confirm all tests pass: t/db_dependent/CourseReserves/CourseItems.t Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 21:21:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 19:21:44 +0000 Subject: [Koha-bugs] [Bug 14237] Allow bibs to be added to course without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120659|0 |1 is obsolete| | --- Comment #50 from Nick Clemens --- Created attachment 121880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121880&action=edit Bug 14237: Set course_items.biblionumber in the DBrev We need to create the new column without the NOT NULL clause, set the correct values, then add the NOT NULL clause. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 21:21:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 19:21:48 +0000 Subject: [Koha-bugs] [Bug 14237] Allow bibs to be added to course without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237 --- Comment #51 from Nick Clemens --- Created attachment 121881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121881&action=edit Bug 14237: (follow-up) Make the routines exclusively take itemnumber, biblionumber, or ci_id This patch changes the parameters for several of the CourseReserves routines to take a single identifier exclusively. Following the existing pattern we simply return if the params are incorrect This patch also: removes an unused 'title' variable adds a prefetch to save some db calls where we fetch related objects adjusts tests Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 21:23:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 19:23:47 +0000 Subject: [Koha-bugs] [Bug 14237] Allow bibs to be added to course without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #52 from Nick Clemens --- (In reply to Kyle M Hall from comment #45) > (In reply to Jonathan Druart from comment #44) > > I think this patch is the way to go (DBrev) > > > > However I am still struggling with something: shouldn't we allow > > biblionumber xor itemnumber for the different C4::CourseReserves subroutines? > > It does not make sense to me to pass the biblionumber when we have already > > the itemnumber. > > > > Asking a QA feedback on this question. > > > > Kyle or Tomas maybe? > > I'm not opposed to that. It should be easy enough to add an exception if > both are passed in. It could be re-engineered to by pk/type as well. I adjusted the calls, followed existing return if bad params - we could add exception on another bug if needed - PQA but feel free to get a second set of eyes on follow-up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 22:06:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 20:06:04 +0000 Subject: [Koha-bugs] [Bug 28538] Regression - Date of birth entered without correct format causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 22:06:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 20:06:07 +0000 Subject: [Koha-bugs] [Bug 28538] Regression - Date of birth entered without correct format causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121784|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 22:06:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 20:06:39 +0000 Subject: [Koha-bugs] [Bug 28538] Regression - Date of birth entered without correct format causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 121882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121882&action=edit Bug 28538: Insert formatted date if valid This patch restores the setting of the date from bug 27937 and adds a parsing of the date to ensure the correct format To test: 1 - Follow test plan from bug 27937 - it fails 2 - Follow test plan from bug 28351 - it succeeds 3 - Apply patch 4 - Repeat 1-2 5 - both plans pass now Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 22:07:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 20:07:57 +0000 Subject: [Koha-bugs] [Bug 28538] Regression - Date of birth entered without correct format causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | --- Comment #4 from Tomás Cohen Arazi --- Both test plans followed and works as expected. i.e. no regressions introduced, and the 'fixed' behaviour is re-introduced. There's an unadvertised input size change, that makes sense :-D No QA complaints. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 22:26:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 20:26:58 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Tomás Cohen Arazi --- I agree, generally. but: 1. You are adding an unadvertised die in C4::Auth (I agree with it!). Please add a test for that behavior. 2. I think you should simplify your patch by just putting the CGI/ dir in the top level. In that case, you would just do what we do for C4, Koha and the OpenILS library directories in Makefile.PL (& friends). No complex hacks. I would love to move all libs to a libs/ dir, but lets do it on a separate bug, and discuss the tradeoffs there (my butt has been kicked a couple times when I proposed it, because of all bugzilla patches not applying if we did that). If you need me to write a follow-up to address my comments, let me know. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 22:42:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 20:42:33 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 22:42:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 20:42:58 +0000 Subject: [Koha-bugs] [Bug 8838] Digest option for HOLD notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 22:44:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 20:44:25 +0000 Subject: [Koha-bugs] [Bug 25534] Add ability to specifying and store a reason when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 22:44:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 20:44:30 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 22:44:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 20:44:40 +0000 Subject: [Koha-bugs] [Bug 27296] Return claims should be filtered by default to show unresolved claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27296 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 11 23:45:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Jun 2021 21:45:23 +0000 Subject: [Koha-bugs] [Bug 28556] New: Make guarantor information available in notices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28556 Bug ID: 28556 Summary: Make guarantor information available in notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org Since the change to accommodate multiple guarantees per borrower, it is impossible to get the garantor's information in notices. It is customary here to send things to the parent as C/O (care of), especially if it's by the mail. I was wondering if it was possible to make the guarantor information available in notices. Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 12 05:07:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 03:07:23 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #37 from Mason James --- hi joubu i've uploaded a libdata-session-perl pkg to koha-staging/dev, for testing root at kohadevbox:/kohadevbox# apt install libdata-session-perl Reading package lists... Done Building dependency tree Reading state information... Done The following additional packages will be installed: libautovivification-perl libdbd-sqlite3-perl libdbix-admin-createtable-perl libfile-slurper-perl libhash-fieldhash-perl libperlio-utf8-strict-perl The following NEW packages will be installed: libautovivification-perl libdata-session-perl libdbd-sqlite3-perl libdbix-admin-createtable-perl libfile-slurper-perl libhash-fieldhash-perl libperlio-utf8-strict-perl 0 upgraded, 7 newly installed, 0 to remove and 2 not upgraded. Need to get 376 kB of archives. root at kohadevbox:/kohadevbox# apt-cache policy libdata-session-perl libdata-session-perl: Installed: 1.18-1 Candidate: 1.18-1 Version table: *** 1.18-1 500 500 http://debian.koha-community.org/koha-staging dev/main amd64 Packages 100 /var/lib/dpkg/status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 12 12:51:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 10:51:45 +0000 Subject: [Koha-bugs] [Bug 27883] Add ability to preserve patron field from being overwritten by import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27883 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119436|0 |1 is obsolete| | Attachment #119437|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 121883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121883&action=edit Bug 27883: Add ability to preserve patron field from being overwritten by import Some libraries would like to be able to preserve particular fields for existing patrons when overwriting them via the patron import tool. Effectively, this means the specified columns of the CSV are used for new patrons, but ignored for existing patrons. Test Plan: 1) Create a patron CSV with one new patron, make the surname and firstname "Test1". Add a cardnumber so we can upload it again later. 2) Import the file 3) Change the firstname and surname in the CSV to "Test2" 4) Return to the patron import tool, choose to match on cardnumber, overwrite existing patrons, and preserve exiting firstnames 5) Import the file with these settings 6) Referesh the patron details for this patron, the patron's surname should still be "Test" while the firstname should now be "Test2" Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 12 12:51:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 10:51:57 +0000 Subject: [Koha-bugs] [Bug 27883] Add ability to preserve patron field from being overwritten by import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27883 --- Comment #17 from Kyle M Hall --- Created attachment 121884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121884&action=edit Bug 27883: (follow-up) Make label match input id This change alters the list of columns under "Preserve existing values," changing the label for each checkbox can be clicked to trigger the checkbox change. To test, apply the patch and refresh the patron import page. Expand the "Preserve existing values" section and click any label in the list. The corresponding checkbox should be checked. Signed-off-by: Kyle M Hall Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 12 13:25:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 11:25:09 +0000 Subject: [Koha-bugs] [Bug 27920] Add ability to update patron expiration dates when importing patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120951|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 121885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121885&action=edit Bug 27920: Add ability to update patron expiration dates when importing patrons Some libraries need to recalculate a patron's expiration date any time they are updated via a patron import from file. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Patrons/Import.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 12 15:04:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 13:04:08 +0000 Subject: [Koha-bugs] [Bug 28242] Accessibility: OPAC - add captions and legends to tables and forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #4 from Tomás Cohen Arazi --- I'm not familiar with accessibility guidelines, but understand this changes. I would like to know if this is on purpose. In this case, the

    tag is removed in the resulting caption: -

    Credits

    +
    + but in some others it is kept: -

    Results

    Credits
    + Maybe there's a reason, but I would like it commented on the commit message, unless it needs to be fixed for consistency. Great work BTW! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 12 15:13:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 13:13:18 +0000 Subject: [Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 12 15:41:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 13:41:10 +0000 Subject: [Koha-bugs] [Bug 27920] Add ability to update patron expiration dates when importing patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121885|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 121886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121886&action=edit Bug 27920: Add ability to update patron expiration dates when importing patrons Some libraries need to recalculate a patron's expiration date any time they are updated via a patron import from file. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Patrons/Import.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 12 15:58:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 13:58:46 +0000 Subject: [Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 12 15:58:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 13:58:58 +0000 Subject: [Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118874|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 12 15:59:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 13:59:09 +0000 Subject: [Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118875|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 12 15:59:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 13:59:58 +0000 Subject: [Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 121887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121887&action=edit Bug 15788: Add delete_borrowers permission Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 12 16:00:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 14:00:23 +0000 Subject: [Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 --- Comment #18 from Tomás Cohen Arazi --- Created attachment 121888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121888&action=edit Bug 15788: Use delete_borrowers permission Link the new delete_borrowers sub-permission to the delete actions. Test plan 1/ Remove the delete_borrowers permission from a staff user 2/ Check that the user cannot use the 'Delete' option from the members menu. Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 12 16:00:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 14:00:29 +0000 Subject: [Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 121889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121889&action=edit Bug 15788: (QA follow-up) Simplify query in update Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 12 16:00:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 14:00:36 +0000 Subject: [Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 121890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121890&action=edit Bug 15788: Make the API require the new permission Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 12 17:56:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 15:56:49 +0000 Subject: [Koha-bugs] [Bug 28557] New: Translation issue in MARC modification templates Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28557 Bug ID: 28557 Summary: Translation issue in MARC modification templates Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt: No MARC modification template is defined. You have to create at least one template for using this tool. Because of the link on "to create" the sentence is broken up into 3 separate strings in the po file: No MARC modification template is defined. You have to create at least one template for using this tools For de-DE (German): https://translate.koha-community.org/de/21.05/translate/#search=%20No%20MARC%20modification%20template&sfields=source,target&soptions=exact,case https://translate.koha-community.org/de/21.05/translate/#search=to%20create&sfields=source,target&soptions=exact,case&unit=17330278&offset=20 https://translate.koha-community.org/de/21.05/translate/#search=at%20least%20one%20template%20for&sfields=source,target&soptions=exact,case This makes it impossible to translate it well, because it's hard to see how things to together and because it's not possible to move the linked words to the end of the sentence as it would be necessary in some languages. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 12 17:56:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 15:56:56 +0000 Subject: [Koha-bugs] [Bug 28557] Translation issue in MARC modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28557 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 13 00:20:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 22:20:47 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 13 00:20:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 22:20:52 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121820|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 121891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121891&action=edit Bug 28554: In Koha::AuthorisedValues sort by description In itemsearch form, there are several filters build with authorized values. There values should be sorted by description. Test plan : 1) Create several values and descriptions in authorized values LOC 2) Go to itemsearch 3) See filter by location sorts on description and not on value Seems change in search_by_marc_field can not be tested in interface Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 13 00:20:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 22:20:57 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121821|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 121892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121892&action=edit Bug 28554: In itemsearch sort item types filter by description In itemsearch form, the item types filter should be sorted by description. Test plan : 1) Create several values and descriptions in item types 2) Go to itemsearch 3) See filter by item types sorts on description and not on value Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 13 00:26:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 22:26:56 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |For item search in the release notes| |staff interface the | |shelving location and item | |type values are now sorted | |by the description, rather | |than the authorized value | |code. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 13 00:34:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 22:34:52 +0000 Subject: [Koha-bugs] [Bug 28383] Log in via the itemsearch URL leads to Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28383 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 13 00:34:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 22:34:56 +0000 Subject: [Koha-bugs] [Bug 28383] Log in via the itemsearch URL leads to Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28383 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121819|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 121893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121893&action=edit Bug 28383: Fix itemsearch when accessed from the login form There are params here (credentials), we need to test for the existence of $format. Test plan: logout access /cgi-bin/koha/catalogue/itemsearch.pl Login => Without this patch you get a 500 (because we hit the exit statement) => With this patch you see the items search form. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 13 00:41:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 22:41:31 +0000 Subject: [Koha-bugs] [Bug 28383] Log in via the itemsearch URL leads to Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28383 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |When trying to access the release notes| |item search form in the | |staff interface | |(/cgi-bin/koha/catalogue/it | |emsearch.pl) when not | |logged in, an internal | |server error (error code | |500) is received after | |entering your login | |details. This fixes the | |problem so that the item | |search form is displayed as | |expected. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 13 00:50:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 22:50:55 +0000 Subject: [Koha-bugs] [Bug 28545] Noisy uninitialized warn at opac-MARCdetail.pl line 313 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28545 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 13 00:51:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 22:51:00 +0000 Subject: [Koha-bugs] [Bug 28545] Noisy uninitialized warn at opac-MARCdetail.pl line 313 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28545 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121810|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 121894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121894&action=edit Bug 28545: Noisy uninitialized warn at opac-MARCdetail.pl line 313 Test plan: You do not even need a NULL value in a authorised value controlled item field, a zero in damaged or withdrawn is enough to trigger the warnings. (Because only the 1 is linked to an authvalue.) Check your plack-opac-error.log before and after applying this change. Signed-off-by: Marcel de Rooy Without the patch I had at least four warnings per item: withdrawn, lost, damaged and notforloan. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 13 00:54:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Jun 2021 22:54:24 +0000 Subject: [Koha-bugs] [Bug 28545] Noisy uninitialized warn at opac-MARCdetail.pl line 313 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28545 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This removes "..Use of release notes| |uninitialized value in | |concatenation (.) or string | |at.." warning messages from | |the plack-opac-error.log | |when accessing the MARC | |view page for a record in | |the OPAC. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 13 06:27:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Jun 2021 04:27:05 +0000 Subject: [Koha-bugs] [Bug 28242] Accessibility: OPAC - add captions and legends to tables and forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 --- Comment #5 from wainuiwitikapark at catalyst.net.nz --- (In reply to Tomás Cohen Arazi from comment #4) > I'm not familiar with accessibility guidelines, but understand this changes. > I would like to know if this is on purpose. In this case, the

    tag is > removed in the resulting caption: > > -

    Credits

    > +
    >

    > + > > but in some others it is kept: > > -

    Results

    >
    Credits
    > + > > Maybe there's a reason, but I would like it commented on the commit message, > unless it needs to be fixed for consistency. > > Great work BTW! Hi Tomás, Thank you for your comment! Yes I understand this is quite confusing. Basically Koha is set up without a lot of accessibility in mind and there is a lot of inconsistency. Therefore, I sort of just chose to do things on a case by case basis and sometimes it is unnecessary to have headings, and sometimes it makes sense to have both captions and headings. I will make a point to try and document these decisions more. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 13 07:02:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Jun 2021 05:02:46 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #4 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121895&action=edit Bug 28243: admin folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to Koha Administration 4) Go to each of the pages/files and check if they have tables 5) Check that each of the tables have captions to describe them (unless they have special heading tags instead) - some of these will be visible on the page and some will be hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 13 07:12:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Jun 2021 05:12:23 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #5 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121896&action=edit Bug 28243: authorities folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to Authorities 4) Go to each of the pages/files and check if they have tables 5) Check that each of the tables have captions to describe them (unless they have special heading tags instead) - some of these will be visible on the page and some will be hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 13 11:14:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Jun 2021 09:14:50 +0000 Subject: [Koha-bugs] [Bug 19220] Allow XSLT processing for Z39.50 authority targets like for bibliographic targets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220 Filippos Kolovos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |f.kolovos at gmail.com --- Comment #9 from Filippos Kolovos --- Dear Katrin, Matthias is right. I just tested it and it does work. What I have noticed, is that for bibliographic records, the import script re-transforms the output XML EVERY time (even if the record is cached from a previous search). For authority records, it prefers to fetch the cached version, as is, from the with the last transformation made (or not made if you didn't specify a custom XSLT). So, you have to run the cleanup_database.pl tool like this (assuming that you have a package installation): koha-foreach --chdir --enabled /usr/share/koha/bin/cronjobs/cleanup_database.pl --confirm --z3950 in order to clear the cached entries from z3950 searches. Otherwise you will always see the last result. I tested it and if I did not run the cleanup tool, the XSL didn't do anything. After I ran it, everytime I had the "XSL-updated" results. Even if you remove the custom XSL from the Z3950 AUTH SERVER setting, then you have to rerun the script for it to work, otherwise it will still display the "XSL-updated" results from your previous queries. I hope that this helps you, -Fk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 13 13:10:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Jun 2021 11:10:07 +0000 Subject: [Koha-bugs] [Bug 19220] Allow XSLT processing for Z39.50 authority targets like for bibliographic targets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Katrin Fischer --- Matts, reading the comment above I feel like the caching will be an issue here - it will cause the transformation to to not work reliably as I have struggled to much with it. And I feel like this will be very confusing to libraries too that want to use the feature. But could we make it work "always", even if you happen to have "seen" the record before? I get that this would also be consistent with how it works for bibliographic records. Just to make sure: My last test was done on a fresh sample database with lots of different names, so I believe there might be another cause too, even if everyone tells me otherwise :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 13 14:43:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Jun 2021 12:43:03 +0000 Subject: [Koha-bugs] [Bug 19220] Allow XSLT processing for Z39.50 authority targets like for bibliographic targets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220 --- Comment #11 from Filippos Kolovos --- Katrin, Just one more thought on that, since you mention that the failure was consistent in your case. Did you always checked the search to be done *only* on the Z3950 server on which you have configured the XSLT? Because everytime the search window is reopened all default search servers are pre-selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 13 14:51:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Jun 2021 12:51:39 +0000 Subject: [Koha-bugs] [Bug 19220] Allow XSLT processing for Z39.50 authority targets like for bibliographic targets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220 --- Comment #12 from Katrin Fischer --- I have 2 authority targets configured, but made sure to only select results from the configured one with the XSLT transformation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 13 18:35:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Jun 2021 16:35:06 +0000 Subject: [Koha-bugs] [Bug 19220] Allow XSLT processing for Z39.50 authority targets like for bibliographic targets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220 --- Comment #13 from Filippos Kolovos --- Created attachment 121897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121897&action=edit Bug 19220 - Allow XSLT processing for Z39.50 authority Matthias and Katrin, I worked on it a bit and I seem to have found where the issue might be. It is in the Breeding.pm module, where for the Authorities if an import_record_id already exists in the import_records table for that authority in the import_auths table, then it simply returns the import_record_id, ignoring the new MARC data that have been returned from the new XSL transformation. If the auth record does not exist in the import_auths table, then the AddAuthToBatch() is called, which adds the auth into import_records, with the marc and marcxml correctly. In the case of biblios, it always runs the AddBiblioToBatch(), even if the biblio is already in the cache, returning the new id, hence the new marc. Please try the patch I have uploaded, where I update the import_records table for the specific import_record_id, with the new marc values (plain marc and marcxml), since they ae both used later on in the Marc Preview and import functionalities. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 13 21:10:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Jun 2021 19:10:08 +0000 Subject: [Koha-bugs] [Bug 28560] New: Slash with non-ascii library code breaks various things Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28560 Bug ID: 28560 Summary: Slash with non-ascii library code breaks various things Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: victor at tuxayo.net QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com == Test plan == create a library with code ko/ha and another with Ä/A A. 1. Try to hold from the OPAC with delivery to ko/ha 2. => ERROR: Internal error: incomplete hold request. (odd, nothing in all the logs, just a happy HTTP request returning 200) B. 1. Staff interface 2. set library: Ä/A (the slash isn't enought to cause issues) 3. transfer item to any another library 4. => Broken FK constraint at /usr/share/perl5/Exception/Class/Base.pm line 88 Oddly it works with ko/ha C. 1. Staff interface 2. set library: Ä/A (the slash isn't enought to cause issues) 3. checkout an item 4. => Broken FK constraint at /usr/share/perl5/Exception/Class/Base.pm line 88 Oddly it works with ko/ha D. 1. Staff interface 2. set library: NOT Ä/A 3. checkout an item 4. set library: Ä/A 5. partron page => checkout tab => show checkouts 6. try to check in 7. => it's loads for ever 8. => logs: Broken FK constraint at /usr/share/perl5/Exception/Class/Base.pm line 88 9. refresh page 10. The item has actually been checked in. (not sure if DB is in a consistent state) E. Same but use the check in tab of the search box, next to the Koha logo -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 13 21:12:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Jun 2021 19:12:08 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #81 from Victor Grousset/tuxayo --- (In reply to Victor Grousset/tuxayo from comment #69) > Forget my comment 24 stuff. Just tried test 1 on a sandbox and a local > master and it fails. > I will open a ticket. bug 28560 That's still a mystery that here I was to only one to trigger it. The same mystery should happen in the above bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 13 21:13:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Jun 2021 19:13:46 +0000 Subject: [Koha-bugs] [Bug 28560] Slash with non-ascii library code breaks various things In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28560 --- Comment #1 from Victor Grousset/tuxayo --- tested on - a sandbox - Debian 11 with MariaDB 10.5 - Debian 10 (or 9) with MariaDB 10.1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 13 22:15:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Jun 2021 20:15:57 +0000 Subject: [Koha-bugs] [Bug 28560] Slash with non-ascii library code breaks various things In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28560 --- Comment #2 from Katrin Fischer --- Could this be the same issue as the CGI::Session issue? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 00:19:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Jun 2021 22:19:58 +0000 Subject: [Koha-bugs] [Bug 28560] Slash with non-ascii library code breaks various things In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28560 --- Comment #3 from Victor Grousset/tuxayo --- I was able to fail these test plans with the patches↓↓ applied. I forgot to say that it was a follow up of bug 28489 comment 24 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 01:05:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Jun 2021 23:05:04 +0000 Subject: [Koha-bugs] [Bug 28141] Accessibility: OPAC Advanced Search fields aren't labelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28141 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 01:06:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Jun 2021 23:06:17 +0000 Subject: [Koha-bugs] [Bug 28142] Accessibility: OPAC Cart/basket checkboxes are not labelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 01:20:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Jun 2021 23:20:18 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #6 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121898&action=edit Bug 28243: basket folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to basket 4) Go to each of the pages/files and check if they have tables 5) Check that each of the tables have captions to describe them (unless they have special heading tags instead) - some of these will be visible on the page and some will be hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 02:26:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 00:26:27 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #7 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121899&action=edit Bug 28243: catalogue folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to catalogue 4) Go to each of the pages/files and check if they have tables 5) Check that each of the tables have captions to describe them (unless they have special heading tags instead) - some of these will be visible on the page and some will be hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 04:07:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 02:07:48 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #8 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121900&action=edit Bug 28243: cataloguing folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to cataloguing 4) Go to each of the pages/files and check if they have tables 5) Check that each of the tables have captions to describe them (unless they have special heading tags instead) - some of these will be visible on the page and some will be hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 04:56:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 02:56:36 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #9 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121901&action=edit Bug 28243: circ folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to Circulation 4) Go to each of the pages/files and check if they have tables 5) Check that each of the tables have captions to describe them (unless they have special heading tags instead) - some of these will be visible on the page and some will be hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 05:03:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 03:03:49 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #10 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121902&action=edit Bug 28243: clubs folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to clubs 4) Go to each of the pages/files and check if they have tables 5) Check that each of the tables have captions to describe them (unless they have special heading tags instead) - some of these will be visible on the page and some will be hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 06:07:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 04:07:33 +0000 Subject: [Koha-bugs] [Bug 28475] Searching all headings returns no results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED --- Comment #20 from wainuiwitikapark at catalyst.net.nz --- Not backported to 19.11.x Couldn't reproduce the bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 06:23:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 04:23:50 +0000 Subject: [Koha-bugs] [Bug 28419] Page addorderiso2709.pl is untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Version(s)|21.05.00,20.11.07,20.05.13 |21.05.00,20.11.07,20.05.13, released in| |19.11.19 CC| |wainuiwitikapark at catalyst.n | |et.nz Resolution|--- |FIXED --- Comment #20 from wainuiwitikapark at catalyst.net.nz --- Backported to 19.11.x for 19.11.19 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 06:59:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 04:59:25 +0000 Subject: [Koha-bugs] [Bug 28531] 500 internal server error when saving system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28531 Londhe A changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |BLOCKED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 08:28:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 06:28:06 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #11 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121903&action=edit Bug 28243: common folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to the common/patron_search page 4) Check that the page has a table 5) Check that the table has a caption to describe it and that it is hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 08:37:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 06:37:20 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #12 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121904&action=edit Bug 28243: course_reserves folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to course_reserves 4) Check that the page has a table 5) Check that the table has a caption to describe it and that it is hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 08:47:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 06:47:46 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #13 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121905&action=edit Bug 28243: labels folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to labels 4) Check that the page has a table 5) Check that the table has a caption to describe it and that it is hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 08:54:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 06:54:08 +0000 Subject: [Koha-bugs] [Bug 19220] Allow XSLT processing for Z39.50 authority targets like for bibliographic targets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220 Filippos Kolovos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121897|0 |1 is obsolete| | --- Comment #14 from Filippos Kolovos --- Created attachment 121906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121906&action=edit Bug 19220- Allow XSLT processing for Z39.50 authority targets like for bibliographic targets A minor correction in the previous patch in Breedin.pm, where it retrieves the marcflavour from preferences. The "shift" operation is not required -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 08:56:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 06:56:54 +0000 Subject: [Koha-bugs] [Bug 19220] Allow XSLT processing for Z39.50 authority targets like for bibliographic targets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220 --- Comment #15 from Filippos Kolovos --- Created attachment 121907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121907&action=edit Bug 19220 Allow XSLT processing for Z39.50 authority version 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 09:30:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 07:30:53 +0000 Subject: [Koha-bugs] [Bug 28247] Add a MARC preview column to to Authority search results table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28247 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 12:44:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 10:44:45 +0000 Subject: [Koha-bugs] [Bug 28531] 500 internal server error when saving system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28531 --- Comment #1 from Katrin Fischer --- Hi Londhe, to get a faster response I'd recommend to ask on the mailing list instead - it has much more readers. Bugzilla should be used for enhancement requests and bug reports only. I think this one is a configuration issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 13:55:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 11:55:30 +0000 Subject: [Koha-bugs] [Bug 28561] New: Order_by triggers a DBIx warning Unable to properly collapse has_many results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561 Bug ID: 28561 Summary: Order_by triggers a DBIx warning Unable to properly collapse has_many results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Make a list, few biblios with multiple items. Check the plack-opac-error.log [2021/06/14 11:51:45] [WARN] Use of uninitialized value $direction in string ne at /usr/share/koha/opac/opac-shelves.pl line 265. [2021/06/14 11:51:45] [WARN] Use of uninitialized value $direction in string ne at /usr/share/koha/opac/opac-shelves.pl line 265. [2021/06/14 11:51:45] [WARN] DBIx::Class::ResultSet::_construct_results(): Unable to properly collapse has_many results in iterator mode due to order criteria - performed an eager cursor slurp underneath. Consider using ->all() instead at /usr/share/koha/Koha/Objects.pm line 335 Koha/Objects Line 335 says: my $result = $self->_resultset()->next(); The warning has to do with the sorting criteria. Disabling the order_by clause removes the warning. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 13:55:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 11:55:43 +0000 Subject: [Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 13:55:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 11:55:52 +0000 Subject: [Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 13:57:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 11:57:03 +0000 Subject: [Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561 --- Comment #1 from Marcel de Rooy --- This query in opac/opac-shelves.pl contains the crux: my $contents = $shelf->get_contents->search( {}, { prefetch => [ { 'biblionumber' => { 'biblioitems' => 'items' } } ], page => $page, rows => $rows, order_by => { "-$direction" => $order_by }, } ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 14:35:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 12:35:59 +0000 Subject: [Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561 --- Comment #2 from Marcel de Rooy --- The code in opac-shelves is far from optimal. The prefetch in the query selects biblio, biblioitems and items. But in the loop starting at L308 we are calling GetBiblioData, GetMarcBiblio, Biblios->find, GetItemsLocationInfo, $biblio->items. Horrible ;) DBIx says about prefetching and collapse the following: If an "order_by" is already declared, and orders the resultset in a way that makes collapsing as described above impossible (e.g. ORDER BY has_many_rel.column or ORDER BY RANDOM()), DBIC will automatically switch to "eager" mode and slurp the entire resultset before constructing the first object returned by "next". So if we are 'sorting' by itemcallnumber in an "has many" table, we will trigger the warning. In that case we can remove the sort anyway. This is a bit lazy 'solution' but this report was not about refactoring opac-shelves. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 14:43:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 12:43:19 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 14:44:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 12:44:10 +0000 Subject: [Koha-bugs] [Bug 28534] pending_offline_circulations table uses MyISAM engine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 --- Comment #3 from Nick Clemens --- Created attachment 121908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121908&action=edit Bug 28534: Atomic update to fix existing installs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 14:47:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 12:47:00 +0000 Subject: [Koha-bugs] [Bug 28534] pending_offline_circulations table uses MyISAM engine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 --- Comment #4 from Nick Clemens --- (In reply to David Nind from comment #2) > I wasn't sure how to test this (using koha-testing-docker), but thought that > this would work: > > 1. Check table structure in the database: > . koha-mysql kohadev > . show create table pending_offline_operations; > . should show as "..ENGINE=MyISAM..." > 2. Apply patch > 3. Update the database (updatedatabase) > 4. Check the table structure as per step 1 - should show as > "..ENGINE=INNODB.." > > It does update if I do a reset_all, but for the existing installations I > seem to be missing something... (restarting the container didn't work for me > - docker restart koha_db_1)? I added an atomic update to fix existing installs. I added a create table as well, one of our sites did not have MyISAM enabled, so the table was not created. To test: 1 - Check current table structure 2 - Apply patch 3 - Update database 4 - Confirm table structure is correct 5 - Drop the table 'DROP TABLE pending_offline_operations' 6 - Update database 7 - Confirm table is created 8 - reset_all 9 - Check the structure and confirm table is created as InnoDB -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 14:54:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 12:54:28 +0000 Subject: [Koha-bugs] [Bug 28562] New: Add date received to basket summary Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28562 Bug ID: 28562 Summary: Add date received to basket summary Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org At the moment you can see that an item was received in the basket summary page by looking at the (received) in front of the title. But there is no easy way to tell when it was received, whch would often be helpful, for example when working with standing orders. We could add the receive date in a new column (hidden by default) or even make it visible in the note: (Received ). Adding a span with a class would then still allow to hide this information if needed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 15:14:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 13:14:00 +0000 Subject: [Koha-bugs] [Bug 27151] SIP2 server doesn't handle broken connections which then kills SIP2 server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27151 Londhe A changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |iamalon1434 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 15:25:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 13:25:00 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WONTFIX |DUPLICATE Status|CLOSED |RESOLVED --- Comment #248 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 27880 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 15:25:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 13:25:00 +0000 Subject: [Koha-bugs] [Bug 27880] Database migrations in separate files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27880 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #2 from Jonathan Druart --- *** Bug 7167 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 15:26:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 13:26:43 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #46 from Jonathan Druart --- This is ready for testing again. I'd like it to be pushed at the beginning of this release cycle, to avoid unnecessary work with updatedatabase.pl Here we are going to: - Move each DBrev into a separate .pl file - Make the display/output nice for CLI and UI - Execute each DBrev in a transaction Improvement to this (on a separate bug report, see bug 27880) could be: - Use the database to store the dbrevs that have been executed already - Remove versioning and use YYYY-MM-DD-bug-42424.pl instead of the version => Easier for backporting => No longer need to be idempotent => Track of the execution (error/success) in the DB -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 15:29:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 13:29:50 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #47 from Jonathan Druart --- Created attachment 121909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121909&action=edit Bug 25078: Put db revs into different files to handle them better This patch suggests to stop using updatedatabase.pl to add new DB revs. Each DB rev will be in a separate pl files (installer/data/mysql/db_revs). The switch should ideally be done from 21.06.00.000. Each DBrev is executed in a try block and a transaction. If something went wrong, the whole DB rev is rolled back. Why do /var/log/koha/kohadev/updatedatabase_*.log (not -error) contain Status: 500 Content-type: text/html

    Software error:

    etc. Test plan: - git checkout 5f9333ffda0 (master on 2021-06-14) - Set the version syspref to 21.0500000: > update systempreferences set value="21.0500000" where variable="version"; - Apply "Bug 25078: [DO NOT PUSH] DB revs for testing" (restart_all) - Read the different DBrevs created as examples - Make sure the different use cases are covered - execute the updatedatabase script (CLI) - Set the version syspref to 21.0500000 - Update the DB from the UI - Set the version syspref to 21.0500000 - execute the updatedatabase script with the --force parameter (for testing purpose) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 15:29:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 13:29:55 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #48 from Jonathan Druart --- Created attachment 121910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121910&action=edit Bug 25078: [DO NOT PUSH] DB revs for testing Use with the --force flag: % updatedatabase --force -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 15:30:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 13:30:24 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116208|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 15:30:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 13:30:25 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116209|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 15:30:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 13:30:26 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117084|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 15:38:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 13:38:30 +0000 Subject: [Koha-bugs] [Bug 27880] Database migrations in separate files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27880 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25078 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 15:38:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 13:38:30 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27880 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 15:39:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 13:39:13 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121910|0 |1 is obsolete| | --- Comment #49 from Jonathan Druart --- Created attachment 121911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121911&action=edit Bug 25078: [DO NOT PUSH] DB revs for testing Use with the --force flag: % updatedatabase --force -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 15:45:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 13:45:46 +0000 Subject: [Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 15:45:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 13:45:50 +0000 Subject: [Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561 --- Comment #3 from Marcel de Rooy --- Created attachment 121912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121912&action=edit Bug 28561: Resolve DBIx's Unable to collapse results-warning [WARN] DBIx::Class::ResultSet::_construct_results(): Unable to properly collapse has_many results in iterator mode due to order criteria - performed an eager cursor slurp underneath. Consider using ->all() instead at /usr/share/koha/Koha/Objects.pm line 335 DBIx tells: If an "order_by" is already declared, and orders the resultset in a way that makes collapsing as described above impossible (e.g. ORDER BY has_many_rel.column or ORDER BY RANDOM()), DBIC will automatically switch to "eager" mode and slurp the entire resultset before constructing the first object returned by "next". The query in opac-shelves here prefetches biblio, biblioitems and items. May order by itemcallnumber (so that is a has_many column). Note that ordering biblio records (having multiple items) by itemcallnumber is formally impossible. This patch pragmatically removes the order_by clause, but I am open for a better solution ;) Test plan: Pick a list with biblios having multiple items. Show the list in OPAC. Change the sortfield. Check your plack-opac-error.log. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 15:45:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 13:45:53 +0000 Subject: [Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561 --- Comment #4 from Marcel de Rooy --- Created attachment 121913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121913&action=edit Bug 28561: Fix noisy warning about $direction too Use of uninitialized value $direction in string ne at /usr/share/koha/opac/opac-shelves.pl line 265. Bonus: Use of uninitialized value $sortfield in string eq at /usr/share/koha/opac/opac-shelves.pl line 264. Test plan: While testing patch 1, check the logs for these warnings with and without this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 15:53:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 13:53:26 +0000 Subject: [Koha-bugs] [Bug 28524] Most-circulated items (cat_issues_top.pl) is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28524 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23997, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28523 Blocks| |23996 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 [Bug 23996] MySQL 8 support [Omnibus] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 15:53:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 13:53:26 +0000 Subject: [Koha-bugs] [Bug 23996] MySQL 8 support [Omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28524 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28524 [Bug 28524] Most-circulated items (cat_issues_top.pl) is failing with MySQL 8 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 15:53:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 13:53:26 +0000 Subject: [Koha-bugs] [Bug 23997] sample_z3950_servers.sql is failing on MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23997 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28524 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 15:53:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 13:53:26 +0000 Subject: [Koha-bugs] [Bug 28523] Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28524 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 15:53:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 13:53:44 +0000 Subject: [Koha-bugs] [Bug 28523] Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23997 CC| |jonathan.druart+koha at gmail. | |com Blocks| |23996 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 [Bug 23996] MySQL 8 support [Omnibus] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 15:53:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 13:53:44 +0000 Subject: [Koha-bugs] [Bug 23996] MySQL 8 support [Omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28523 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523 [Bug 28523] Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 15:53:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 13:53:44 +0000 Subject: [Koha-bugs] [Bug 23997] sample_z3950_servers.sql is failing on MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23997 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28523 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 15:53:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 13:53:59 +0000 Subject: [Koha-bugs] [Bug 28523] Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |unspecified -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 15:54:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 13:54:08 +0000 Subject: [Koha-bugs] [Bug 28524] Most-circulated items (cat_issues_top.pl) is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28524 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |unspecified -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 15:58:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 13:58:41 +0000 Subject: [Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561 --- Comment #5 from Marcel de Rooy --- NOTE: Although this patch significantly reduces the number of warnings on the collapse. I still had some when I sorted on title too. It seems that it does not occur on the other fields as author etc. Not sure why. Caching? [2021/06/14 13:06:59] [WARN] L272title-title at /usr/share/koha/opac/opac-shelves.pl line 272. [2021/06/14 13:06:59] [WARN] DBIx::Class::ResultSet::_construct_results(): Unable to properly collapse has_many results in iterator mode due to order criteria - performed an eager cursor slurp underneath. Consider using ->all() instead at /usr/share/koha/Koha/Objects.pm line 335 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:04:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:04:54 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #5 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #4) > I agree, generally. but: > 1. You are adding an unadvertised die in C4::Auth (I agree with it!). Please > add a test for that behavior. This die is obvious (I added it when I wrote a patch for bug 17427 more than 4y ago - https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56504). Writing a test for it is not trivial and I would not block the whole change for that. > 2. I think you should simplify your patch by just putting the CGI/ dir in > the top level. In that case, you would just do what we do for C4, Koha and > the OpenILS library directories in Makefile.PL (& friends). No complex hacks. I think it makes sense to have it in lib. > I would love to move all libs to a libs/ dir, but lets do it on a separate > bug, and discuss the tradeoffs there (my butt has been kicked a couple times > when I proposed it, because of all bugzilla patches not applying if we did > that). Like having intranet controller scripts in their own directory (bug 9949). Could be part of a roadmap topic, but definitely not something for 21.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:05:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:05:24 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #6 from Jonathan Druart --- The main question to me is: is it safe enough for backport into 21.05.01? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:08:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:08:51 +0000 Subject: [Koha-bugs] [Bug 28350] Sort by "circ note" is broken on the patron search result view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28350 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Summary|Order patron search broken |Sort by "circ note" is |(borrowernotes) |broken on the patron search | |result view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:13:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:13:43 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:15:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:15:03 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Passed QA |Patch doesn't apply --- Comment #28 from Jonathan Druart --- This patchset conflicts with bug 24434, I cannot apply both of them. Can you add a dependency and fix the conflict please? (adding the same comment there) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:15:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:15:18 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 --- Comment #66 from Jonathan Druart --- This patchset conflicts with bug 28520, I cannot apply both of them. Can you add a dependency and fix the conflict please? (adding the same comment there) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:21:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:21:58 +0000 Subject: [Koha-bugs] [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:22:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:22:01 +0000 Subject: [Koha-bugs] [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171 --- Comment #26 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:22:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:22:04 +0000 Subject: [Koha-bugs] [Bug 28204] Table highlighting is broken at the cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:22:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:22:06 +0000 Subject: [Koha-bugs] [Bug 28204] Table highlighting is broken at the cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:22:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:22:09 +0000 Subject: [Koha-bugs] [Bug 28353] Regression: Batch item deletion no longer shows which items were not removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:22:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:22:12 +0000 Subject: [Koha-bugs] [Bug 28353] Regression: Batch item deletion no longer shows which items were not removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 --- Comment #10 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:22:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:22:14 +0000 Subject: [Koha-bugs] [Bug 28482] Floating point math prevents items from being returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28482 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:22:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:22:17 +0000 Subject: [Koha-bugs] [Bug 28482] Floating point math prevents items from being returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28482 --- Comment #10 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:22:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:22:19 +0000 Subject: [Koha-bugs] [Bug 28496] Club holds form broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28496 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:22:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:22:22 +0000 Subject: [Koha-bugs] [Bug 28496] Club holds form broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28496 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:22:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:22:39 +0000 Subject: [Koha-bugs] [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171 --- Comment #27 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:22:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:22:46 +0000 Subject: [Koha-bugs] [Bug 28204] Table highlighting is broken at the cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 --- Comment #9 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:23:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:23:02 +0000 Subject: [Koha-bugs] [Bug 28353] Regression: Batch item deletion no longer shows which items were not removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 --- Comment #11 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:23:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:23:11 +0000 Subject: [Koha-bugs] [Bug 28482] Floating point math prevents items from being returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28482 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #11 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:23:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:23:22 +0000 Subject: [Koha-bugs] [Bug 28496] Club holds form broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28496 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:24:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:24:06 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #7 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #6) > The main question to me is: is it safe enough for backport into 21.05.01? I think it is. I would still skip the lib/ dir for now. But have no problem other than that with the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:36:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:36:43 +0000 Subject: [Koha-bugs] [Bug 23608] Koha::Objects::Limit::Library->get_library_limits can return undef In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23608 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:37:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:37:55 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #50 from Julian Maurice --- Comment on attachment 121909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121909 Bug 25078: Put db revs into different files to handle them better Review of attachment 121909: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25078&attachment=121909) ----------------------------------------------------------------- ::: installer/data/mysql/db_revs/skeleton.pl @@ +3,5 @@ > +{ > + bug_number => "BUG_NUMBER", > + description => "A single line description", > + # description => ["Multi", "lines", "description"], > + # description => sub { return ["Your dynamic description"] }, I think there is something wrong about multi-lines/dynamic description. Why do we need that ? I think that we are confusing the update's "description" (what the update is supposed to do) with the update's "report" (what the update has done). A dynamic description also implies that it should be generated after the update is done, because the 'description' sub might use some data from the 'up' sub, but what if we want to display a list of pending updates before executing them ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:40:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:40:18 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #51 from Jonathan Druart --- (In reply to Julian Maurice from comment #50) > Comment on attachment 121909 [details] [review] > Bug 25078: Put db revs into different files to handle them better > > Review of attachment 121909 [details] [review]: > ----------------------------------------------------------------- > > ::: installer/data/mysql/db_revs/skeleton.pl > @@ +3,5 @@ > > +{ > > + bug_number => "BUG_NUMBER", > > + description => "A single line description", > > + # description => ["Multi", "lines", "description"], > > + # description => sub { return ["Your dynamic description"] }, > > I think there is something wrong about multi-lines/dynamic description. Why > do we need that ? I think that we are confusing the update's "description" > (what the update is supposed to do) with the update's "report" (what the > update has done). How that? I don't understand. We have several examples in the past where we have several lines. Basically a DBrev can contain several things. To prevent long line we split it and display 1 action per bullet point. > A dynamic description also implies that it should be generated after the > update is done, because the 'description' sub might use some data from the > 'up' sub, but what if we want to display a list of pending updates before > executing them ? It's not what is done (and has never been done). We display display the output when the DBrev has been executed. Are you suggesting you should change this behaviour? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:40:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:40:41 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #52 from Jonathan Druart --- (In reply to Jonathan Druart from comment #51) > Are you suggesting you should change this behaviour? s/you should/we should :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:41:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:41:16 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #53 from Jonathan Druart --- TODO: Fix NewVersion()! But it does not prevent testing and feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:41:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:41:59 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #8 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #7) > (In reply to Jonathan Druart from comment #6) > > The main question to me is: is it safe enough for backport into 21.05.01? > > I think it is. I would still skip the lib/ dir for now. But have no problem > other than that with the patch. My question was about the lib dir :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 16:54:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 14:54:37 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121828|0 |1 is obsolete| | --- Comment #53 from Jonathan Druart --- Created attachment 121915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121915&action=edit Bug 28490: Comment out the relationship data removing DB update step These columns that were actively used to store non-patron guarantor relationship info were dropped incorrectly. In a later patch the relationship fields will be re-added. Signed-off-by: Kyle M Hall Signed-off-by: Petro Vashchuk Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens JD Amended patch: Add a "SKIP" note on the DBrev we commented out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:03:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:03:28 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #54 from Julian Maurice --- (In reply to Jonathan Druart from comment #51) > It's not what is done (and has never been done). We display display the > output when the DBrev has been executed. You're right, the output has always been displayed after the execution. What I'm saying is that it would be nice to be able to display a description of the updates before their execution. I know it's not the goal of this bug, but since it changes the structure of database updates, it's a good time to think about future improvements, to avoid changing the structure again later. I'll submit a patch later to show what I have in mind (maybe on a remote git repository to not pollute this bug) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:12:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:12:26 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #55 from Jonathan Druart --- (In reply to Julian Maurice from comment #54) > (In reply to Jonathan Druart from comment #51) > > It's not what is done (and has never been done). We display display the > > output when the DBrev has been executed. > You're right, the output has always been displayed after the execution. What > I'm saying is that it would be nice to be able to display a description of > the updates before their execution. > I know it's not the goal of this bug, but since it changes the structure of > database updates, it's a good time to think about future improvements, to > avoid changing the structure again later. > I'll submit a patch later to show what I have in mind (maybe on a remote git > repository to not pollute this bug) Then we would need 2 kinds of "description", as we want to keep the ability to output something dependent on what is in DB (like raise a warning if we find data inconsistency). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:25:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:25:40 +0000 Subject: [Koha-bugs] [Bug 28563] New: Add AllowHoldItemTypeSelection to HEA Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28563 Bug ID: 28563 Summary: Add AllowHoldItemTypeSelection to HEA Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com This syspref is missing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:25:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:25:46 +0000 Subject: [Koha-bugs] [Bug 28563] Add AllowHoldItemTypeSelection to HEA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28563 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:27:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:27:53 +0000 Subject: [Koha-bugs] [Bug 28563] Add AllowHoldItemTypeSelection to HEA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28563 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 121916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121916&action=edit Bug 28563: Add AllowHoldItemTypeSelection to HEA This patch adds the mentioned syspref to the sysprefs list, shared for statistical purposes. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:28:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:28:25 +0000 Subject: [Koha-bugs] [Bug 28563] Add AllowHoldItemTypeSelection to HEA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28563 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:29:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:29:09 +0000 Subject: [Koha-bugs] [Bug 28564] New: "The many-to-many relationship * is trying to create a utility method" warning Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28564 Bug ID: 28564 Summary: "The many-to-many relationship * is trying to create a utility method" warning Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org I am not sure what triggered this output exactly. To recreate: git checkout this commit (not pushed yet): "Bug 28490: Add DBIx schema changes for testing" qa -c 5 -v 2 --failures It happens when reloading the module in koha-qa.pl: 103 delete $INC{$module}; 104 $module =~ s|/|::|g; 105 $module =~ s|\.pm$||; 106 eval "require $module"; 107 $module->import; During the require, but I cannot recreate in a separate test file. DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'basketnoes' is trying to create a utility method called add_to_basketnoes. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'basketnoes' is trying to create a utility method called remove_from_basketnoes. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'basketnoes' is trying to create a utility method called set_basketnoes. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'basketnoes' is trying to create a utility method called basketnoes_rs. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'budgets' is trying to create a utility method called add_to_budgets. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'budgets' is trying to create a utility method called remove_from_budgets. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'budgets' is trying to create a utility method called set_budgets. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'budgets' is trying to create a utility method called budgets_rs. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'courses' is trying to create a utility method called add_to_courses. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'courses' is trying to create a utility method called remove_from_courses. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'courses' is trying to create a utility method called set_courses. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'courses' is trying to create a utility method called courses_rs. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'ordernumbers' is trying to create a utility method called add_to_ordernumbers. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'ordernumbers' is trying to create a utility method called remove_from_ordernumbers. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'ordernumbers' is trying to create a utility method called set_ordernumbers. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'ordernumbers' is trying to create a utility method called ordernumbers_rs. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:30:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:30:15 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28564 --- Comment #54 from Jonathan Druart --- (In reply to Nick Clemens from comment #52) > I can edit patrons, the about page works, all looks correct. I did get some > errors from qa tools about DBIC > > *************************************************************************** > DBIx::Class::Relationship::ManyToMany::many_to_many(): > *************************************************************************** > The many-to-many relationship 'ordernumbers' is trying to create a utility > method > called ordernumbers_rs. > This will completely overwrite one such already existing method on class > Koha::Schema::Result::Borrower. > > You almost certainly want to rename your method or the many-to-many > relationship, as the functionality of the original method will not be > accessible anymore. > > To disable this warning set to a true value the environment variable > DBIC_OVERWRITE_HELPER_METHODS_OK > > *************************************************************************** > > I assume this is a clash of 'relationship' columns and Relationship class? > things still seem to work, but noting I've logged that on bug 28564. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:30:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:30:15 +0000 Subject: [Koha-bugs] [Bug 28564] "The many-to-many relationship * is trying to create a utility method" warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28564 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28490 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:34:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:34:00 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:34:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:34:03 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #50 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:34:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:34:06 +0000 Subject: [Koha-bugs] [Bug 27931] Add GET /items/:item_id/pickup_locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27931 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:34:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:34:08 +0000 Subject: [Koha-bugs] [Bug 27931] Add GET /items/:item_id/pickup_locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27931 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:34:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:34:11 +0000 Subject: [Koha-bugs] [Bug 28338] Validate item holdability and pickup location separately In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28338 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:34:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:34:13 +0000 Subject: [Koha-bugs] [Bug 28338] Validate item holdability and pickup location separately In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28338 --- Comment #16 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:34:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:34:16 +0000 Subject: [Koha-bugs] [Bug 28350] Sort by "circ note" is broken on the patron search result view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28350 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:34:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:34:18 +0000 Subject: [Koha-bugs] [Bug 28350] Sort by "circ note" is broken on the patron search result view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28350 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:34:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:34:21 +0000 Subject: [Koha-bugs] [Bug 28382] 'Reserve' should be passed through as transfer reason appropriately in branchtransfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:34:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:34:23 +0000 Subject: [Koha-bugs] [Bug 28382] 'Reserve' should be passed through as transfer reason appropriately in branchtransfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:34:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:34:25 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:34:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:34:28 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 --- Comment #13 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:34:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:34:30 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:34:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:34:33 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #82 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:34:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:34:36 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:34:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:34:38 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #55 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:34:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:34:41 +0000 Subject: [Koha-bugs] [Bug 28538] Regression - Date of birth entered without correct format causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:34:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:34:43 +0000 Subject: [Koha-bugs] [Bug 28538] Regression - Date of birth entered without correct format causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:37:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:37:26 +0000 Subject: [Koha-bugs] [Bug 26340] When printing labels from a barcode range, keep zero padding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Ivan Dziuba changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121496|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 17:41:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 15:41:03 +0000 Subject: [Koha-bugs] [Bug 26340] When printing labels from a barcode range, keep zero padding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Ivan Dziuba changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111654|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 18:39:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 16:39:13 +0000 Subject: [Koha-bugs] [Bug 28353] Regression: Batch item deletion no longer shows which items were not removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual Text to go in the| |This restores and improves release notes| |the messages displayed when | |batch deleting items (Tools | |> Catalog > Batch item | |deletion). | | | |The messages | |displayed are: | |- "Warning, | |the following barcodes were | |not found:", followed by a | |list of barcodes | |- | |"Warning, the following | |items cannot be deleted:", | |followed by a list of | |barcodes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 18:50:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 16:50:21 +0000 Subject: [Koha-bugs] [Bug 28534] pending_offline_circulations table uses MyISAM engine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 18:50:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 16:50:25 +0000 Subject: [Koha-bugs] [Bug 28534] pending_offline_circulations table uses MyISAM engine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121746|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 121917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121917&action=edit Bug 28534: Fix engine for pending_offline_circulations table Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 18:50:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 16:50:29 +0000 Subject: [Koha-bugs] [Bug 28534] pending_offline_circulations table uses MyISAM engine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121908|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 121918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121918&action=edit Bug 28534: Atomic update to fix existing installs Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 18:51:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 16:51:40 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #56 from Julian Maurice --- (In reply to Julian Maurice from comment #54) > I'll submit a patch later to show what I have in mind (maybe on a remote git > repository to not pollute this bug) https://gitlab.com/jajm/Koha/-/commit/864372e553d312d1a533a75f389d9a7aa143c62e (In reply to Jonathan Druart from comment #55) > Then we would need 2 kinds of "description", as we want to keep the ability > to output something dependent on what is in DB (like raise a warning if we > find data inconsistency). I agree (but I think that data inconsistency, or any other anomaly detected should stop the update until it's fixed) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 18:53:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 16:53:33 +0000 Subject: [Koha-bugs] [Bug 28534] pending_offline_circulations table uses MyISAM engine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This updates the database release notes| |structure for the | |pending_offline_operations | |table so that it uses the | |InnoDB engine instead of | |the MyISAM engine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 19:14:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 17:14:29 +0000 Subject: [Koha-bugs] [Bug 28563] Add AllowHoldItemTypeSelection to HEA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28563 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 19:14:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 17:14:33 +0000 Subject: [Koha-bugs] [Bug 28563] Add AllowHoldItemTypeSelection to HEA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28563 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121916|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 121919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121919&action=edit Bug 28563: Add AllowHoldItemTypeSelection to HEA This patch adds the mentioned syspref to the sysprefs list, shared for statistical purposes. Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 19:17:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 17:17:20 +0000 Subject: [Koha-bugs] [Bug 28563] Add AllowHoldItemTypeSelection to HEA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28563 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds the release notes| |AllowHoldItemTypeSelection | |system preference to the | |list of system preferences | |usage data that will be | |shared with Hea. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 19:22:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 17:22:43 +0000 Subject: [Koha-bugs] [Bug 28563] Add AllowHoldItemTypeSelection to HEA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28563 --- Comment #3 from David Nind --- Testing notes - was not sure of the best way to test this: - Checked that AllowHoldItemTypeSelection is a valid system preference - Checked the diff for the patch to make sure system preference name was correctly added If sharing statistics is enabled, then, like any other other system preference, its usage will be shared on Hea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 19:51:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 17:51:17 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 19:51:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 17:51:20 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121616|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 19:51:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 17:51:23 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121614|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 19:51:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 17:51:27 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121615|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 19:54:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 17:54:12 +0000 Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from 20.05.xx to 20.11.04-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #12 from skaman.tx at gmail.com --- (In reply to Jonathan Druart from comment #10) > (In reply to skaman.tx from comment #9) > > Understood. Please forgive my ignorance here as I am not a KOHA or perl > > programmer. Where/how do I apply the patch? The rest I understand. > > The patch is adding a new file > "installer/data/mysql/atomicupdate/bug_28267.perl" > Create it with its content at this location. Jonathan, I fear I just am not getting this right. The only "content" to put into the "bug_28267.perl" file is the attachment you provided which looks like a diff file. Thus, I'm not sure what to copy from the patch you wrote into the "bug_28267.per" file. Can you guide me here? I know where the patch file goes from your response above....just not what precise information goes into the file. Sorry for my ignorance here. Scott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 20:18:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 18:18:31 +0000 Subject: [Koha-bugs] [Bug 26878] Add ability to prevent spending against parent funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26878 Rhonda Kuiper changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper at roundrocktexas.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 20:19:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 18:19:41 +0000 Subject: [Koha-bugs] [Bug 28508] Use "Invoice number" instead of "Invoice no" on the invoice search filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28508 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 20:20:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 18:20:33 +0000 Subject: [Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 --- Comment #7 from Nick Clemens --- Created attachment 121920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121920&action=edit Bug 13706: Update some code This updates a few things: - ZebraIndex module does not exist - merge calls ModBiblio, so the records are reindexed during merge - DelAuthority used to remove records - no reindex needed after Remaining issues: - SimpleSearch doesn't work - only 'he' has an entry in ccl.properties - abbreviations for indexes (he-main etc) do not exist anywhere - There should be an option to use 'Match' and automatically generate the search term from the auth record (search_form in Headings.pm) based on the authtype - The default options are unimarc centric - this should be in module and testable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 20:24:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 18:24:43 +0000 Subject: [Koha-bugs] [Bug 28508] Use "Invoice number" instead of "Invoice no" on the invoice search filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28508 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 20:24:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 18:24:46 +0000 Subject: [Koha-bugs] [Bug 28508] Use "Invoice number" instead of "Invoice no" on the invoice search filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28508 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121796|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 20:25:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 18:25:27 +0000 Subject: [Koha-bugs] [Bug 28508] Use "Invoice number" instead of "Invoice no" on the invoice search filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28508 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 121921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121921&action=edit Bug 28508: Use "Invoice number" instead of "Invoice no" on the invoice search filter This patch corrects instances of the abbreviated phrase "Invoice no." from the templates, making it "Invoice number." Also corrected: An instance of "Bookseller" is replaced with "Vendor." To test, apply the patch and confirm that the phrase is correct in these cases: - Acquisitions -> Invoices: Check the "Search filters" form in the left-hand sidebar. -> View an invoice: Check the label in the form. - Acquisitions -> Vendor -> Receive shipments: Check the table of invoices. - Acquisitions -> Orders search (in the search header) -> Advanced search: Check the labels in the form. Signed-off-by: Salman Ali Signed-off-by: Tomas Cohen Arazi Note: I fixed Salman's SO line -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 20:29:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 18:29:04 +0000 Subject: [Koha-bugs] [Bug 28456] Add option to use a WHERE statement in membership_expiry.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 20:29:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 18:29:08 +0000 Subject: [Koha-bugs] [Bug 28456] Add option to use a WHERE statement in membership_expiry.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121397|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 121922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121922&action=edit Bug 28456: Add WHERE option to membership_expiry cronjob Some libraries have a large amount of accounts and want to be able to limit how many email reminders they send. Adding a where statement will allow for flexibility To test: 1 - Set some borrowers to expire soon 2 - Set MembershipExpiryDaysNotice to 10 3 - perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 4 - Note the patrons that yo uadjusted show up 5 - Limit by various patron fields, e.g. perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 --where="lastseen IS NULL" perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 --where="lastseen IS NOT NULL" perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 --where="surname LIKE '%a%'" perl misc/cronjobs/membership_expiry.pl -c -v -n --before 100 --after 100 --where="surname NOT LIKE '%a%'" 6 - Confirm expected results 7 - perl misc/cronjobs/membership_expiry.pl 8 - Confirm the help message makes sense Signed-off-by: Azucena Aguayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 20:42:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 18:42:04 +0000 Subject: [Koha-bugs] [Bug 28242] Accessibility: OPAC - add captions and legends to tables and forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 20:42:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 18:42:13 +0000 Subject: [Koha-bugs] [Bug 26340] When printing labels from a barcode range, keep zero padding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 --- Comment #13 from Ivan Dziuba --- Created attachment 121923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121923&action=edit Bug 26340: When printing labels from a barcode range, keep zero padding TEST PLAN: 1. Go Tools > Label creator 2. Click +New -> Barcode range 3. Print barcode range with zero(s) in the start (Ex. from 00011881 to 00012000 ) 4. Select a template to be applied:: Code à barre 48467 Select a layout to be applied: Code à barres 5. Export 6. Open PDF The prefix is not displayed. We should see 00011881 on the labels, but we see 11881, 11882, ... without zeros in the start of labels. This patch fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 20:42:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 18:42:55 +0000 Subject: [Koha-bugs] [Bug 28242] Accessibility: OPAC - add captions and legends to tables and forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 20:42:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 18:42:58 +0000 Subject: [Koha-bugs] [Bug 28242] Accessibility: OPAC - add captions and legends to tables and forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121203|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 20:43:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 18:43:33 +0000 Subject: [Koha-bugs] [Bug 28242] Accessibility: OPAC - add captions and legends to tables and forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 121924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121924&action=edit Bug 28242: added captions to tables and legends to forms Ensured that in the OPAC, all tables have relevant captions and all forms have relevant legends. Many of these have class="sr-only" so they are not visible but will be available for people who use screen-readers. To test: 1) Go to OPAC 2) Apply patch and dependencies 3) Check that on all pages, any tables have a caption (many of them will not be visible, but will be in the markup code) 4) Check that on all pages, any forms have a legend (many of them will not be visible, but will be in the markup code) 5) Check that the captions are appropriate and relevant 6) Check that the legends are appropriate and relevant Sponsored-by: Catalyst IT Signed-off-by: Lucas Gass Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 20:47:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 18:47:43 +0000 Subject: [Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from borrower holds list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 21:04:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 19:04:36 +0000 Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from 20.05.xx to 20.11.04-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #13 from Katrin Fischer --- You are right that the attachment is a diff file. So you can't use the file as is, but have to recreate the changes listed in it locally. It requires some manual work if you are not using git, like copying the correct lines, creating the file with the name, removing the + at the beginning of the lines... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 21:08:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 19:08:41 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #148 from Salman Ali --- Created attachment 121925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121925&action=edit Bug 28204: Compiled CSS Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 21:15:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 19:15:13 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112161|0 |1 is obsolete| | --- Comment #149 from Salman Ali --- Created attachment 121926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121926&action=edit Bug 12446: Ability to allow guarantor relationship for all patron category types This adds a new field "Can be guarantee" to patron categories so it becomes possible for any category type to have a guarantor. To test: 1) Have a patron category of type 'Adult' and one of type 'Child' 2) Confirm, by searching for the "Patron guarantor" fieldset in the edit/create form, that: => a patron of the first category can't have a guarantor => a patron from the second category can 3) Apply patch and run updatedatabase.pl 4) Edit the categories and note the new "Can be guarantee" field 5) It should have been set to "yes" for the "Child" and to "no" for the "Adult" 5) Repeat step 2. It should behave in the same way. 6) Edit the "Can be guarantee" for any of the category and check that the fieldset only appears when "Can be guarantee" is set to "yes" 7) prove t/db_dependent/Patrons.t => tests should still pass Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 21:15:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 19:15:20 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112162|0 |1 is obsolete| | --- Comment #150 from Salman Ali --- Created attachment 121927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121927&action=edit Bug 12446: Schema update Category.pm Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 21:15:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 19:15:26 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112163|0 |1 is obsolete| | --- Comment #151 from Salman Ali --- Created attachment 121928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121928&action=edit Bug 12446: Limit available categories when using "Add guarantee" button Test plan: 1) Have some patron categories that can and cannot be guarantee 2) Visit a patron's account and click the "Add guarantee" button 3) In the "category" dropdown, note that all categories are available 4) Apply this patch 5) Repeat step 2 and 3; the dropdown now only contains the categories for which "can be guarantee" is set to "Yes". Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 21:15:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 19:15:32 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113583|0 |1 is obsolete| | --- Comment #152 from Salman Ali --- Created attachment 121929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121929&action=edit Bug 12446: Add canbeguarantee value to patron categories sample data This patch changes sample data so patron categories of type 'C' or 'P' can be guarantees by default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 21:16:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 19:16:41 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |salman.ali at inLibro.com --- Comment #153 from Salman Ali --- I rebased the patches, ready to be tested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 21:23:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 19:23:48 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121925|0 |1 is obsolete| | Attachment #121925|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 21:26:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 19:26:30 +0000 Subject: [Koha-bugs] [Bug 28563] Add AllowHoldItemTypeSelection to HEA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28563 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 21:26:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 19:26:34 +0000 Subject: [Koha-bugs] [Bug 28563] Add AllowHoldItemTypeSelection to HEA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28563 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121919|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 121930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121930&action=edit Bug 28563: Add AllowHoldItemTypeSelection to HEA This patch adds the mentioned syspref to the sysprefs list, shared for statistical purposes. Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 21:26:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 19:26:38 +0000 Subject: [Koha-bugs] [Bug 28563] Add AllowHoldItemTypeSelection to HEA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28563 --- Comment #5 from Katrin Fischer --- Created attachment 121931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121931&action=edit Bug 28267: (QA follow-up) Fix unit test Add the new preference to the UsageStats.t To test: - Run t/db_dependent/UsageStats.t - Watch it pass :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 21:33:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 19:33:22 +0000 Subject: [Koha-bugs] [Bug 28383] Log in via the itemsearch URL leads to Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28383 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 21:33:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 19:33:26 +0000 Subject: [Koha-bugs] [Bug 28383] Log in via the itemsearch URL leads to Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28383 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121893|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 121932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121932&action=edit Bug 28383: Fix itemsearch when accessed from the login form There are params here (credentials), we need to test for the existence of $format. Test plan: logout access /cgi-bin/koha/catalogue/itemsearch.pl Login => Without this patch you get a 500 (because we hit the exit statement) => With this patch you see the items search form. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 21:34:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 19:34:11 +0000 Subject: [Koha-bugs] [Bug 28563] Add AllowHoldItemTypeSelection to HEA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28563 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 21:34:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 19:34:15 +0000 Subject: [Koha-bugs] [Bug 28563] Add AllowHoldItemTypeSelection to HEA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28563 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121930|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 121933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121933&action=edit Bug 28563: Add AllowHoldItemTypeSelection to HEA This patch adds the mentioned syspref to the sysprefs list, shared for statistical purposes. Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 21:34:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 19:34:19 +0000 Subject: [Koha-bugs] [Bug 28563] Add AllowHoldItemTypeSelection to HEA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28563 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121931|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 121934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121934&action=edit Bug 28267: (QA follow-up) Fix unit test Add the new preference to the UsageStats.t To test: - Run t/db_dependent/UsageStats.t - Watch it pass :) https://bugs.koha-community.org/show_bug.cgi?id=28563 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 21:39:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 19:39:02 +0000 Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #50 from Ivan Dziuba --- (In reply to Tomás Cohen Arazi from comment #49) > (In reply to Blou from comment #46) > > Ivan has already recoded it without sessions in our codebase. But before > > pushing that change, we'll be waiting for Tomas' instructions regarding the > > svc/ > > I think this is a subject worth discussing in the open, i.e. in koha-devel. > > As I mentioned (not sure where) I believe we could try adding some filtering > capabilities to GET /biblios to accomplish this. I proposed something > similar on bug 25870. In that case, I proposed a 'q_ccl' query param that > could take a CCL query so we could accept complex queries. The route would > then extract the ids (biblionumbers) and return Koha::Biblios->to_api > objects as required. > > I don't think CCL is a cool feature, but it felt like good start: allowing > people to query records through the API. > > The ES syntax might be a high constraint for the feature (leaving Zebra > users out), specially if you are querying things like title, author, etc. > But that's another possibility: add a query parameter that only works with > ES (q_es?). > > Regarding routes, you need to think what the response would look like. And > it will help you figure what you want. Is it ok/enough for GET > /biblios? to return JSON representation of the biblio+biblioitems > table columns? Unfortunately, the OpenAPI v2.0 schema doesn't provide a way > to define different response schemas for different content-type responses, > and thus we left GET /biblios/:biblio_id under-documented (it is supported > on v3) but you can try > > GET /biblios/1 > > and see the response to get an idea of what we already return [1]. > > It feels like we need to build a good query language, and reuse this routes. > > [1] This is how we build the JSON representation of a biblio > https://git.koha-community.org/Koha-community/Koha/src/branch/master/Koha/ > Biblio.pm#L867-L892 I don't understand what is it means `It feels like we need to build a good query language, and reuse these routes.`? Here I use dynamic queries $q, $prefix and a kind of "$token" to understand for which query hints were returned and whether to show or skip them. (depends on the speed of writing). Could you please clarify the structure of URL for that. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 21:45:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 19:45:33 +0000 Subject: [Koha-bugs] [Bug 28563] Add AllowHoldItemTypeSelection to HEA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28563 --- Comment #8 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #7) > Created attachment 121934 [details] [review] > Bug 28267: (QA follow-up) Fix unit test > > Add the new preference to the UsageStats.t > > To test: > - Run t/db_dependent/UsageStats.t > - Watch it pass :) > > https://bugs.koha-community.org/show_bug.cgi?id=28563 > > Signed-off-by: Katrin Fischer Thanks, Katrina. Good catch :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 21:49:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 19:49:19 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 21:49:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 19:49:23 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121891|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 121935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121935&action=edit Bug 28554: In Koha::AuthorisedValues sort by description In itemsearch form, there are several filters build with authorized values. There values should be sorted by description. Test plan : 1) Create several values and descriptions in authorized values LOC 2) Go to itemsearch 3) See filter by location sorts on description and not on value Seems change in search_by_marc_field can not be tested in interface Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 21:49:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 19:49:27 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121892|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 121936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121936&action=edit Bug 28554: In itemsearch sort item types filter by description In itemsearch form, the item types filter should be sorted by description. Test plan : 1) Create several values and descriptions in item types 2) Go to itemsearch 3) See filter by item types sorts on description and not on value Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 22:35:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 20:35:34 +0000 Subject: [Koha-bugs] [Bug 28405] Add author info to the holds page (reserve/request.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121259|0 |1 is obsolete| | --- Comment #8 from Lucas Gass --- Created attachment 121937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121937&action=edit Bug 28405: add author name to request.tt when it exists To test: 1. Place a hold and observe request.tt 2. No author name 3. Apply patch 4. Reload request.tt 5. Author name should appear on the same line as the title. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 22:40:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 20:40:19 +0000 Subject: [Koha-bugs] [Bug 28563] Add AllowHoldItemTypeSelection to HEA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28563 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 22:43:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 20:43:08 +0000 Subject: [Koha-bugs] [Bug 28565] New: Adding a new syspref for sharing through HEA should be simpler Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 Bug ID: 28565 Summary: Adding a new syspref for sharing through HEA should be simpler Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Right now, we need to add the syspref both in C4::UsageStats and in the UsageStats.t file. The tests should use the list from the lib. To test: 1. Add some syspref to the C4::UsageStats::BuildReport loop 2. Run: $ kshell k$ prove t/db_dependent/UsageStats.t => FAIL: The new syspref is not in the tests, things break -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 22:43:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 20:43:26 +0000 Subject: [Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28563 Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 22:43:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 20:43:26 +0000 Subject: [Koha-bugs] [Bug 28563] Add AllowHoldItemTypeSelection to HEA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28563 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28565 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 22:48:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 20:48:14 +0000 Subject: [Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 121938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121938&action=edit Bug 28565: Move the sysprefs to a reusable sub This patch moves the big sysprefs list to a sub. Behavior shouldn't change. To test: 1. Run: $ kshell k$ prove t/db_dependent/UsageStats.t => SUCCESS: Things work as expected, no changes. 2. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 22:48:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 20:48:18 +0000 Subject: [Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 121939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121939&action=edit Bug 28565: Simplify tests This patch makes the tests for UsageStats. This way the tests don't need to be adjusted everytime a syspref is added. To test: 1. Apply the first patch 2. Add some random syspref to C4::UsageStats 3. Run: $ kshell k$ prove t/db_dependent/UsageStats.t => FAIL: Things explode 4. Apply this patch 5. Repeat 3 => SUCCESS: It doesn't explode anymore! 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 14 23:17:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 21:17:19 +0000 Subject: [Koha-bugs] [Bug 28175] Usability improvements to uploads page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28175 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- It's a small thing but I wonder if we could fix it here or should move it to a separate bug. The test plan contains testing the filters for for the upload categories. I noticed when I search for the second category in my list, the filter jumps back to the first entry, so it gives a wrong impression on what was searched for. Could we make the filter stick and also add an empty entry for the initial search screen? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 01:03:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 23:03:28 +0000 Subject: [Koha-bugs] [Bug 28405] Add author info to the holds page (reserve/request.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121937|0 |1 is obsolete| | --- Comment #9 from PTFS Europe Sandboxes --- Created attachment 121940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121940&action=edit Bug 28405: add author name to request.tt when it exists To test: 1. Place a hold and observe request.tt 2. No author name 3. Apply patch 4. Reload request.tt 5. Author name should appear on the same line as the title. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 01:04:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 23:04:17 +0000 Subject: [Koha-bugs] [Bug 28405] Add author info to the holds page (reserve/request.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 01:35:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 23:35:30 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #9 from David Cook --- (In reply to Jonathan Druart from comment #6) > The main question to me is: is it safe enough for backport into 21.05.01? I would say yes especially for Debian package installations. Dev environments are the ones that will experience the most changes, but we can deal with any pain there. Once this change is in place, Koha will be much more powerful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 01:51:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 23:51:23 +0000 Subject: [Koha-bugs] [Bug 28383] Log in via the itemsearch URL leads to Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28383 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #5 from David Cook --- (As a side note, this makes me think about how it would be good if we had 1 login point like "/cgi-bin/koha/login" which then redirected you back to your entrypoint after successful login) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 01:52:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 23:52:25 +0000 Subject: [Koha-bugs] [Bug 28456] Add option to use a WHERE statement in membership_expiry.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 01:53:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 23:53:58 +0000 Subject: [Koha-bugs] [Bug 27880] Database migrations in separate files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27880 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 01:55:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Jun 2021 23:55:01 +0000 Subject: [Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 03:50:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 01:50:46 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #267 from Aleisha Amohia --- Created attachment 121941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121941&action=edit Bug 15565: Work in progress, calculating holds remaining Not ready for testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 03:51:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 01:51:07 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 04:02:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 02:02:56 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121904|0 |1 is obsolete| | --- Comment #14 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121942&action=edit Bug 28243: course_reserves folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to course_reserves 4) Go to each of the pages/files and check if they have tables 5) Check that each of the tables have captions to describe them (unless they have special heading tags instead) - some of these will be visible on the page and some will be hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 04:05:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 02:05:15 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121905|0 |1 is obsolete| | --- Comment #15 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121943&action=edit Bug 28243: labels folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to labels 4) Go to each of the pages/files and check if they have tables 5) Check that each of the tables have captions to describe them (unless they have special heading tags instead) - some of these will be visible on the page and some will be hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 04:11:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 02:11:49 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #16 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121944&action=edit Bug 28243: members folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to members (Patrons module) 4) Go to each of the pages/files and check if they have tables 5) Check that each of the tables have captions to describe them (unless they have special heading tags instead) - some of these will be visible on the page and some will be hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 04:22:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 02:22:12 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #17 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121945&action=edit Bug 28243: offline_circ folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to the offline_circ/list page 4) Check that the page has a table 5) Check that the table has a caption to describe it and that it is hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 04:39:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 02:39:45 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #18 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121946&action=edit Bug 28243: patroncards folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to patroncards 4) Go to each of the pages/files and check if they have tables 5) Check that each of the tables have captions to describe them (unless they have special heading tags instead) - some of these will be visible on the page and some will be hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 04:49:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 02:49:55 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #19 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121947&action=edit Bug 28243: patron_lists folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to patron_lists 4) Go to each of the pages/files and check if they have tables 5) Check that each of the tables have captions to describe them (unless they have special heading tags instead) - some of these will be visible on the page and some will be hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 04:54:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 02:54:32 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #20 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121948&action=edit Bug 28243: plugins folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to the plugins/plugins-home page 4) Check that the page has a table 5) Check that the table has a caption to describe it and that it is hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 05:42:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 03:42:51 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #21 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121949&action=edit Bug 28243: pos folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to pos 4) Go to each of the pages/files and check if they have tables 5) Check that each of the tables have captions to describe them (unless they have special heading tags instead) - some of these will be visible on the page and some will be hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 07:21:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 05:21:17 +0000 Subject: [Koha-bugs] [Bug 26705] System preference NoticeBcc not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26705 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 07:49:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 05:49:56 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #22 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121950&action=edit Bug 28243: reports folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to reports 4) Go to each of the pages/files and check if they have tables 5) Check that each of the tables have captions to describe them (unless they have special heading tags instead) - some of these will be visible on the page and some will be hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 07:52:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 05:52:05 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 07:52:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 05:52:10 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121843|0 |1 is obsolete| | Attachment #121844|0 |1 is obsolete| | Attachment #121845|0 |1 is obsolete| | Attachment #121846|0 |1 is obsolete| | Attachment #121847|0 |1 is obsolete| | --- Comment #29 from Joonas Kylmälä --- Created attachment 121951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121951&action=edit Bug 28520: Revert "Bug 12362: (QA follow-up) Fix ModItemTransfer cancellation handling" This reverts commit fbba09f63f200d3e57a8612554984d807867cf84. This commit was part of a series adding adding reverse transfers, i.e. transfers that were created for transfers that were cancelled and we wanted the item to return back to its sending library. This however hid the information about transfer happening and we need another approach to the problem. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 07:52:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 05:52:15 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #30 from Joonas Kylmälä --- Created attachment 121952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121952&action=edit Bug 28520: Revert "Bug 12362: Cancel transfer with hold cancelation" This reverts commit 6c105829144cd341a4bc65ad8d0ee1f996b423d4. This commit was part of a series adding adding reverse transfers, i.e. transfers that were created for transfers that were cancelled and we wanted the item to return back to its sending library. This however hid the information about transfer happening and we need another approach to the problem. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Rebased-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 07:52:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 05:52:19 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #31 from Joonas Kylmälä --- Created attachment 121953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121953&action=edit Bug 28520: Revert "Bug 12362: Reverse transfer upon cancellation" This reverts commit d0407686eb070c5bdf0302147a198027abea5ac0. This commit was part of a series adding adding reverse transfers, i.e. transfers that were created for transfers that were cancelled and we wanted the item to return back to its sending library. This however hid the information about transfer happening and we need another approach to the problem. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 07:52:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 05:52:24 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #32 from Joonas Kylmälä --- Created attachment 121954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121954&action=edit Bug 28520: Bring back TransferCancellation reason handling from reverted Bug 12362 The code from Bug 12362 was reverted but there might be still in database transfers with the reason 'TransferCancellation' so we need to restore the code to handle displaying that information. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 07:52:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 05:52:28 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #33 from Joonas Kylmälä --- Created attachment 121955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121955&action=edit Bug 28520: Allow creating a transfer back automatically if a hold is canceled during transit This fixes regression caused by "Bug 12362: Cancel transfer with hold cancelation" where cancelled hold's transfer didn't show up in intranet and opac because it create a new transfer that was not yet put in in-transit state. The original idea of bug 12362 was to be able to trigger transfer back home if a hold was cancelled (a regression caused by bug 26078). However, we can do it more simply by setting the $validTransfer variable true in the item check-in code when we are dealing with Reserve transfers. More down in the AddReturn() code there is also a check "and !$resfound" to make sure we only try to trigger the transfer back home automatically if there is no hold waiting at the current location the item arrived in. It should be noted however that now we only display generic message for the automatic transfer reason. Bug 12362 made the return display as the reason "Transfer was cancelled whilst in transit". However, since this fixes the original regressions caused by bug 26078 and restores similar behaviour to that I think giving a more descriptive message for example regarding a hold being cancelled can be considered a further enhancement. To test: 1) Apply patch 1) Have biblio with item in branch A 2) Create a new hold with a pickup library to branch B 3) Check-in the item at branch A and confirm the hold and transfer 4) Cancel the hold 5) Check-in the hold at branch B and notice it prompt to return it to branch A Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 07:53:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 05:53:41 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Depends on| |24434 --- Comment #34 from Joonas Kylmälä --- Ok, rebased on top of bug 24434. Though, let's remove the dependency after pushing because it is not one. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 07:53:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 05:53:41 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28520 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 [Bug 28520] Cancelling a hold that is in transit hides item's transit status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 08:04:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 06:04:19 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #23 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121956&action=edit Bug 28243: reserve folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to the reserve/request page 4) Check that the page has tables 5) Check that the tables have captions to describe them and that they are hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 08:08:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 06:08:56 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #24 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121957&action=edit Bug 28243: reviews folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to the reviews/reviewswaiting page 4) Check that the page has a table 5) Check that the table has a caption to describe it and that it is hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 08:37:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 06:37:02 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #25 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121958&action=edit Bug 28243: rotating_collections folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to rotating_collections 4) Go to each of the pages/files and check if they have tables 5) Check that each of the tables have captions to describe them (unless they have special heading tags instead) - some of these will be visible on the page and some will be hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 09:21:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 07:21:54 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #26 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121959&action=edit Bug 28243: serials folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to serials 4) Go to each of the pages/files and check if they have tables 5) Check that each of the tables have captions to describe them (unless they have special heading tags instead) - some of these will be visible on the page and some will be hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 09:32:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 07:32:57 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121757|0 |1 is obsolete| | --- Comment #78 from Victor Grousset/tuxayo --- Created attachment 121960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121960&action=edit Bug 22435: Update CREATE offset types Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 09:33:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 07:33:02 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121758|0 |1 is obsolete| | --- Comment #79 from Victor Grousset/tuxayo --- Created attachment 121961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121961&action=edit Bug 22435: Use 'CREATE' offset type in Koha::Account This patch updates the Koha::Account methods for adding debits and credits to use the 'CREATE' offset type for the creation record. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 09:33:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 07:33:07 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121759|0 |1 is obsolete| | --- Comment #80 from Victor Grousset/tuxayo --- Created attachment 121962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121962&action=edit Bug 22435: Use 'CREATE' offset type in Koha::Account::Line This patch updates the Koha::Account::Line methods that result in new account lines to use the 'CREATE' offset type for the creation record. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 09:33:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 07:33:12 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121760|0 |1 is obsolete| | --- Comment #81 from Victor Grousset/tuxayo --- Created attachment 121963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121963&action=edit Bug 22435: Add 'APPLY' to account_offset_types Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 09:33:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 07:33:16 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121761|0 |1 is obsolete| | --- Comment #82 from Victor Grousset/tuxayo --- Created attachment 121964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121964&action=edit Bug 22435: ->apply() should always use 'APPLY' for offset_type Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 09:33:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 07:33:21 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121762|0 |1 is obsolete| | --- Comment #83 from Victor Grousset/tuxayo --- Created attachment 121965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121965&action=edit Bug 22435: Update unit tests This patch updates the unit tests to reflect the changes we have made to offset types. We do two things: 1) Clean up calls to 'apply' to drop passing offset_type 2) Update test code to look for APPLY and CREATE instead of specific offset types. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 09:33:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 07:33:26 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121763|0 |1 is obsolete| | --- Comment #84 from Victor Grousset/tuxayo --- Created attachment 121966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121966&action=edit Bug 22435: Fix CREATE offset amounts Updateing the tests highlighted a mistake in the original code.. the offsets for the cancel and reduce creation lines were incorrectly signed. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 09:33:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 07:33:31 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121764|0 |1 is obsolete| | --- Comment #85 from Victor Grousset/tuxayo --- Created attachment 121967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121967&action=edit Bug 22435: Fix _set_found_trigger The _set_found_trigger utilised the 'Writeoff' offset type to distinguish between the application of a writeoff and any other form of offset application. This patch updates the trigger to use the full link through from offset to account credit line to get the credit type being offset. Test plan 1/ Run t/db_dependent/Koha/Items.t and prove it fails before the patch, but passes after applying this patch. 2/ Run t/db_dependent/Koha/Account/Offsets.t and prove it passes both before and after applying this patch. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 09:33:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 07:33:35 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121765|0 |1 is obsolete| | --- Comment #86 from Victor Grousset/tuxayo --- Created attachment 121968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121968&action=edit Bug 22435: Update for bug 27049 Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 09:33:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 07:33:40 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121766|0 |1 is obsolete| | --- Comment #87 from Victor Grousset/tuxayo --- Created attachment 121969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121969&action=edit Bug 22435: Update accountline-details page to show all history The accountline-details page took a simplistic approach to displaying the history of an accountline. This patch drops the now defunct offset_type_description template block from it's respective include files, and then updates the accountline-details teplate and controller to show a full history of what's happend to the accountlines passed, including creation, increment/decrement, payments, cancellation and voids. Test plan 1/ Create some credits and debits and apply them to each other in various combinations 2/ View the 'Details' page for some of the debit/credits 3/ Compare before patch and after for the Details page. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 09:33:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 07:33:45 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121767|0 |1 is obsolete| | --- Comment #88 from Victor Grousset/tuxayo --- Created attachment 121970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121970&action=edit Bug 22435: Improve database update Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 09:33:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 07:33:50 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121768|0 |1 is obsolete| | --- Comment #89 from Victor Grousset/tuxayo --- Created attachment 121971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121971&action=edit Bug 22435: Further refinements to account-details table Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 09:33:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 07:33:54 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121769|0 |1 is obsolete| | --- Comment #90 from Victor Grousset/tuxayo --- Created attachment 121972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121972&action=edit Bug 22435: Alternative Three - Account Details Another alternative to try, feedback welcome. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 09:36:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 07:36:45 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #27 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121973&action=edit Bug 28243: suggestion folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to the suggestion/suggestion page 4) Check that the page has tables 5) Check that the tables have captions to describe them and that they are hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 09:36:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 07:36:47 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #91 from Victor Grousset/tuxayo --- Looks good as far as I understand all this Koha money stuff. Which is not as much as I would like to ^^" Here is a gallery of master VS alternative 3. Since I don't know enough to tell if all the info and presentation is relevant, that will help other reviewers. It will open in gallery mode and the left and right arrows allow to navigate. They are ordered like Transaction 1 with master Transaction 1 with patch alt 3 Transaction 2 with master Transaction 2 with patch alt 3 [...] It's possible to download the images in archives to have them as files and see the names which can help keeping track of the above mentioned structure. It's a temporary hosting for 90 days. https://wtf.roflcopter.fr/pics/gallery#Q87QIysB/u4Zn1DoM.png,TyMWRSvw/zoKtB5MU.png,EZ3ymXo4/tegViGbi.png,2d4ztt1m/2G4MZlXf.png,SqnXeQEg/z9EIAAsp.png,tpqIHe05/sdIdLzoI.png,JOyHDhAd/kg03SVjn.png,qqxjtCsp/IzZmLQaB.png,I9eYXgp8/0S7sxkDZ.png,UvOcry0z/M3jsfjoe.png,auIkyTxQ/7iTjYqq7.png,XxSWPXbh/CsqyYMYh.png,Bp7jBRgo/NuSWhpQR.png,MS54T2vx/slv4blYa.png,D2Kw38dO/TTkgsn6I.png,UwfnG840/jQaEllak.png,RskobMTp/jsdstvq4.png,1wkf3RIq/QfSAsDCQ.png,59CsFLXw/iMDfvN76.png,KLogubC6/c5Fnwq54.png,vXwV3J3Y/FBEt3pPn.png,VoNmDbbn/xF4Kj7R0.png,Jq0Nx6Xi/xHiu1S9h.png,KPx6OBNh/ihggjuny.png,NPMLhU7g/KVhCGEOG.png,d5CwLjXH/k3xLva3p.png,DvIb09up/wITsiD7r.png,gK70Kqzu/1vQlc7Xt.png&gid=1&pid=1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 09:40:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 07:40:29 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 --- Comment #92 from Victor Grousset/tuxayo --- Here are alternatives 1 and 2. With only 3 operations detailed. == 1 === https://wtf.roflcopter.fr/pics/gallery#1NkLBOFC/aHHujYYJ.png,XZE1IKRG/ZOwluV8N.png,6zXftiyA/slGr0IuQ.png,rAKHrc99/Q07IxtMu.png,bP6n93Xy/q3Ev9Laf.png,rSTNMCLN/ibOUW5cN.png&gid=1&pid=2 == 2 == https://wtf.roflcopter.fr/pics/gallery#uj6eTF8G/cbf4sgh4.png,h3yzYYAw/mkUqeWPg.png,puNvDL1X/pEMzQBxJ.png,a40ZrUlU/r9pOQeJ2.png,s6POaFzd/URABzJEO.png,FQBJQ0rP/EjtE5Tkg.png&gid=1&pid=1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 09:41:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 07:41:56 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #28 from wainuiwitikapark at catalyst.net.nz --- Created attachment 121974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121974&action=edit Bug 28243: tags folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to tags 4) Go to each of the pages/files and check if they have tables 5) Check that each of the tables have captions to describe them (unless they have special heading tags instead) - some of these will be visible on the page and some will be hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 09:46:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 07:46:54 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121837|0 |1 is obsolete| | Attachment #121838|0 |1 is obsolete| | Attachment #121839|0 |1 is obsolete| | Attachment #121840|0 |1 is obsolete| | Attachment #121841|0 |1 is obsolete| | Attachment #121842|0 |1 is obsolete| | --- Comment #29 from Peter Vashchuk --- Created attachment 121975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121975&action=edit Bug 28316: screen unquoted semicolons and all followup colons Currently searches like: "book:", ":book" and "host-item:test:n" cause internal server errors. This patch adds additional regexes that remove the colons at the start and end of the query, and another regex that screens all follow-up colons that go after the first colon to avoid errors when searching for "host-item:test:n". To reproduce: 1) using ES, search for the book with title that contains semicolon at the start or at the end of the line, separated with spaces, this should cause internal server error. 2) try doing the same with something like "host-item:test:n", it should result in error as well. 3) apply the patch. 4) repeat steps 1-2, ensure that it works now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 09:47:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 07:47:00 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #30 from Peter Vashchuk --- Created attachment 121976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121976&action=edit Bug 28316: escape brackets in the search query This patch screens square and curly brackets which have no special language meaning, while keeping ranges as they are, allowing ES to search for biblios with titles that contain square and curly brackets and at the same time allows the use of range searches ([1990 TO 2000]). To reproduce: 1) using ES, search for the book with title that contains square and/or curly brackets, like "book [second edition]", which will result in error. 2) apply the patch. 3) search for that book again, ensure that it works now. 4) additionally perform a search using range, for example: "[1999 TO 2020]", ensure that it works correctly too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 09:47:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 07:47:05 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #31 from Peter Vashchuk --- Created attachment 121977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121977&action=edit Bug 28316: escape exclamation signs in the query Currently having exclamation sign at the end of the query makes ES search fail, and when you try to search for a book that has exclamation sign in the tittle (something like "Words! words") won't show results correctly as it tries to negate everything that is after exclamation sign, making it impossible to search for books that have in in the title This patch escapes exclamation signs if it's at the end of the query or has a space after it, resolving both of the issues listed above. To reproduce: 1) with ES enabled, search for the book with title that contains exclamation sight at the end, like "book!", this search should result in error. 2) do another search, but this time find/prepare beforehand book with a title that has exclamation sign with a space after it, e.g "exclamation! sign", it shouldn't find it as ES treats everything after that exclamation sign as negation. 2) apply the patch. 3) perform searches from the steep one and two again. Search from step one should no longer fail, while search from the step two should find that book. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 09:47:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 07:47:10 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #32 from Peter Vashchuk --- Created attachment 121978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121978&action=edit Bug 28316: avoid messing up regexes in the search queries This patch ensures that the behavior with QueryRegexEscapeOptions set to values other than "Escape" still will works as expected. It does so by storing the contents of regexes before escaping special characters and then restores the contents of regexes back to how it was before, ensuring that searching with regex is possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 09:47:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 07:47:15 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #33 from Peter Vashchuk --- Created attachment 121979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121979&action=edit Bug 28316: avoid messing up regexes in the search queries This patch ensures that the behavior with QueryRegexEscapeOptions set to values other than "Escape" still will works as expected. It does so by storing the contents of regexes before escaping special characters and then restores the contents of regexes back to how it was before, ensuring that searching with regex is possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 09:47:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 07:47:20 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #34 from Peter Vashchuk --- Created attachment 121980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121980&action=edit Bug 28316: add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 10:08:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 08:08:00 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #51 from Jonathan Druart --- Failing tests, please fix ASAP kohadev-koha at kohadevbox:/kohadevbox/koha$ prove t/db_dependent/Circulation/transferbook.t [4/69] t/db_dependent/Circulation/transferbook.t .. 2/6 # Failed test 'Transfer of reserved item succeeded without ignore reserves' # at t/db_dependent/Circulation/transferbook.t line 151. # got: '0' # expected: '1' # Looks like you failed 1 test of 5. # Failed test 'transfer already at destination' # at t/db_dependent/Circulation/transferbook.t line 154. # Failed test 'Transfer of reserved item succeeded without ignore reserves' # at t/db_dependent/Circulation/transferbook.t line 208. # got: '0' # expected: '1' # Looks like you failed 1 test of 5. t/db_dependent/Circulation/transferbook.t .. 4/6 # Failed test 'transfer an issued item' # at t/db_dependent/Circulation/transferbook.t line 212. # Failed test 'Transfer of reserved item succeeded without ignore reserves' # at t/db_dependent/Circulation/transferbook.t line 248. # got: '0' # expected: '1' # Failed test 'Transfer of reserved item succeeded with ignore reserves: false' # at t/db_dependent/Circulation/transferbook.t line 260. # got: '0' # expected: '1' # Failed test 'We got the expected failure message: DestinationEqualsHolding' # at t/db_dependent/Circulation/transferbook.t line 273. # Structures begin differing at: # $got->{ResFound} = HASH(0x558e901b2fa0) # $expected->{ResFound} = Does not exist # Failed test 'We did not return that we found a reserve' # at t/db_dependent/Circulation/transferbook.t line 278. # got: 'Reserved' # expected: anything else # Failed test 'We did not return the reserve info' # at t/db_dependent/Circulation/transferbook.t line 279. # got: '989' # expected: anything else # Looks like you failed 5 tests of 10. # Failed test 'ignore_reserves flag' # at t/db_dependent/Circulation/transferbook.t line 280. t/db_dependent/Circulation/transferbook.t .. 6/6 # Looks like you failed 3 tests of 6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 10:16:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 08:16:06 +0000 Subject: [Koha-bugs] [Bug 28142] Accessibility: OPAC Cart/basket checkboxes are not labelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 Henry Bolshaw changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |bolshawh at parliament.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 10:16:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 08:16:50 +0000 Subject: [Koha-bugs] [Bug 28141] Accessibility: OPAC Advanced Search fields aren't labelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28141 Henry Bolshaw changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |bolshawh at parliament.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 10:17:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 08:17:21 +0000 Subject: [Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient [OMNIBUS] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188 Henry Bolshaw changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |bolshawh at parliament.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 10:19:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 08:19:27 +0000 Subject: [Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient [OMNIBUS] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188 Henry Bolshaw changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 10:19:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 08:19:52 +0000 Subject: [Koha-bugs] [Bug 28141] Accessibility: OPAC Advanced Search fields aren't labelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28141 Henry Bolshaw changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 10:20:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 08:20:08 +0000 Subject: [Koha-bugs] [Bug 28142] Accessibility: OPAC Cart/basket checkboxes are not labelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 Henry Bolshaw changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 10:40:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 08:40:54 +0000 Subject: [Koha-bugs] [Bug 22702] Circulation note on patron page should allow for HTML tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22702 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28558 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 10:55:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 08:55:58 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #57 from Jonathan Druart --- (In reply to Julian Maurice from comment #56) > (In reply to Julian Maurice from comment #54) > > I'll submit a patch later to show what I have in mind (maybe on a remote git > > repository to not pollute this bug) > https://gitlab.com/jajm/Koha/-/commit/ > 864372e553d312d1a533a75f389d9a7aa143c62e Yes, good idea! Not sure why you absolutely want to pass $dbh however :) > (In reply to Jonathan Druart from comment #55) > > Then we would need 2 kinds of "description", as we want to keep the ability > > to output something dependent on what is in DB (like raise a warning if we > > find data inconsistency). > I agree (but I think that data inconsistency, or any other anomaly detected > should stop the update until it's fixed) We had example where we removed an "unused" DB column but wanted to prevent deletion if it contains data ("Hey, we were going to remove this column but you have data in it"). We could also stop the update in that case but it's not blocker. 20.06.00.055 is another example ("FK added" or "FK already existed"); Anyway your approach deals with that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 10:58:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 08:58:07 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #58 from Jonathan Druart --- Note to myself, the first patch should: - my $report = update( $files, { force => 1 } ); + my $report = update( $files, { force => $force } ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 11:04:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 09:04:34 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #10 from Julian Maurice --- Comment on attachment 121836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121836 Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory Review of attachment 121836: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=28519&attachment=121836) ----------------------------------------------------------------- ::: Makefile.PL @@ +1804,5 @@ > + if ($path){ > + $unique_map{$path} = 1 unless $unique_map{$path}; > + } > + } > + my @paths = sort keys %unique_map; Just a little suggestion: you can use uniq from List::MoreUtils to make the code smaller and easier to read -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 11:15:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 09:15:59 +0000 Subject: [Koha-bugs] [Bug 28349] Date sorting incorrect reports in en-GB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28349 Lucy Vaux-Harvey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey at ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 11:17:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 09:17:08 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #59 from Julian Maurice --- (In reply to Jonathan Druart from comment #57) > (In reply to Julian Maurice from comment #56) > > https://gitlab.com/jajm/Koha/-/commit/ > > 864372e553d312d1a533a75f389d9a7aa143c62e > > Yes, good idea! > Not sure why you absolutely want to pass $dbh however :) Just anticipating a future where C4::Context->dbh disappear or is moved to Koha namespace. DB update files won't need to be modified if $dbh is passed as a parameter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 11:28:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 09:28:13 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #52 from Joonas Kylmälä --- Created attachment 121981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121981&action=edit Bug 27064: Correct transferbook.t tests to reflect new behaviour of transferbook() The transferbook() behaviour was changed so that it only allows transferring the item with a reserve if ignore_reserves=1 is passed to it. The tests are changed here to reflect that. Note that however the tests were buggy already before this change because the transfer's "from" and "to" branches were the same and so the transfer should have failed due to the error DestinationEqualsHolding, but futher though the transferbook() code was buggy and it override the DestinationEqualsHolding checking totally if there was a transfer! So the tests were earlier working due to a bug in transferbook(). To test): 1) Make sure the new test scenarios make sense 2) prove t/db_dependent/Circulation/transferbook.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 11:28:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 09:28:44 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #53 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #51) > Failing tests, please fix ASAP Attached a patch to correct the test scenarios. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 11:40:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 09:40:59 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121909|0 |1 is obsolete| | --- Comment #60 from Jonathan Druart --- Created attachment 121982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121982&action=edit Bug 25078: Put db revs into different files to handle them better This patch suggests to stop using updatedatabase.pl to add new DB revs. Each DB rev will be in a separate pl files (installer/data/mysql/db_revs). The switch should ideally be done from 21.06.00.000. Each DBrev is executed in a try block and a transaction. If something went wrong, the whole DB rev is rolled back. Why do /var/log/koha/kohadev/updatedatabase_*.log (not -error) contain Status: 500 Content-type: text/html

    Software error:

    etc. Test plan: - git checkout 5f9333ffda0 (master on 2021-06-14) - Set the version syspref to 21.0500000: > update systempreferences set value="21.0500000" where variable="version"; - Apply "Bug 25078: [DO NOT PUSH] DB revs for testing" (restart_all) - Read the different DBrevs created as examples - Make sure the different use cases are covered - execute the updatedatabase script (CLI) - Set the version syspref to 21.0500000 - Update the DB from the UI - Set the version syspref to 21.0500000 - execute the updatedatabase script with the --force parameter (for testing purpose) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 11:41:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 09:41:06 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121911|0 |1 is obsolete| | --- Comment #61 from Jonathan Druart --- Created attachment 121983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121983&action=edit Bug 25078: [DO NOT PUSH] DB revs for testing Use with the --force flag: % updatedatabase --force -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 11:41:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 09:41:14 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #62 from Jonathan Druart --- Created attachment 121984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121984&action=edit Bug 25078: Re-introduce NewVersion This is ugly, we re-add the code we removed in the previous patch. We need to continue supporting "old" versions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 11:47:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 09:47:50 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 --- Comment #8 from Jonathan Druart --- Tomas, this is missing your signed-off-by patches! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 11:56:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 09:56:24 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #35 from Jonathan Druart --- # Failed test 'No tests run for subtest "from_library relation tests"' # at /kohadevbox/koha/t/db_dependent/Koha/Item/Transfer.t line 75. The method Koha::Item::Transfer->from_library is not covered by tests! Looks like there are remaining tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 12:00:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 10:00:04 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 --- Comment #67 from Jonathan Druart --- (In reply to Jonathan Druart from comment #66) > This patchset conflicts with bug 28520, I cannot apply both of them. > Can you add a dependency and fix the conflict please? > (adding the same comment there) Shouldn't we actually keep the sub instead of removing the tests? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 12:00:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 10:00:36 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #36 from Jonathan Druart --- (In reply to Jonathan Druart from comment #35) > # Failed test 'No tests run for subtest "from_library relation tests"' > # at /kohadevbox/koha/t/db_dependent/Koha/Item/Transfer.t line 75. > The method Koha::Item::Transfer->from_library is not covered by tests! > > Looks like there are remaining tests. Shouldn't we actually keep the sub instead of removing the tests? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 12:14:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 10:14:28 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #37 from Joonas Kylmälä --- Created attachment 121985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121985&action=edit Bug 28520: Remove tests for removed from_library function The function was unused and removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 12:15:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 10:15:53 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #38 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #36) > (In reply to Jonathan Druart from comment #35) > > # Failed test 'No tests run for subtest "from_library relation tests"' > > # at /kohadevbox/koha/t/db_dependent/Koha/Item/Transfer.t line 75. > > The method Koha::Item::Transfer->from_library is not covered by tests! > > > > Looks like there are remaining tests. > > Shouldn't we actually keep the sub instead of removing the tests? Nobody is using the code so why keep it around? Creates more work if something needs to be changed that affects this unused code. Attached patch to remove the test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 12:39:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 10:39:47 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #39 from Martin Renvoize --- Ack.. that's a pet hate of mine.. that we don't pass through existing relationships so you have to create them each time if you want to use them (and add tests too). In this case, I do wonder about removing them.. remember, methods can be used by notices too.. so the 'from_library' may well have been helpful for peoples notice templates so personally I'd have kept it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 12:45:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 10:45:23 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #40 from Joonas Kylmälä --- (In reply to Martin Renvoize from comment #39) > In this case, I do wonder about removing them.. remember, methods can be > used by notices too.. so the 'from_library' may well have been helpful for > peoples notice templates so personally I'd have kept it. That sounds bad, I think we should be explicit about the methods allowed to be used in the TT notice templates. And we remove all the time object methods... I'd still remove it and maybe we can open a new feature request for defining some stable methods for TT notices? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 12:48:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 10:48:48 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #41 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #40) > (In reply to Martin Renvoize from comment #39) > > In this case, I do wonder about removing them.. remember, methods can be > > used by notices too.. so the 'from_library' may well have been helpful for > > peoples notice templates so personally I'd have kept it. > > That sounds bad, I think we should be explicit about the methods allowed to > be used in the TT notice templates. And we remove all the time object > methods... I'd still remove it and maybe we can open a new feature request > for defining some stable methods for TT notices? Martin, though, up to you, if you wanna restore it now please feel free to submit patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 12:51:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 10:51:19 +0000 Subject: [Koha-bugs] [Bug 28240] Some classes in register.tt are translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28240 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 12:51:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 10:51:59 +0000 Subject: [Koha-bugs] [Bug 28390] Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 12:52:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 10:52:08 +0000 Subject: [Koha-bugs] [Bug 28390] Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 12:53:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 10:53:45 +0000 Subject: [Koha-bugs] [Bug 28389] One should be able to see details for refunds on the register summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 12:56:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 10:56:28 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 13:06:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 11:06:27 +0000 Subject: [Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #6 from Marcel de Rooy --- Still hesitant if we should proceed like that.. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 13:06:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 11:06:29 +0000 Subject: [Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference does not work with XSLT results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #3 from Nick Clemens --- The preference description is inaccurate: "show/don't show an item's branch, location and call number in OPAC search results." It does not affect display of branch, only location and callnumber. OPACItemLocation has an option for 'only branch' which seems to be equivalent functionality. Can we just link the preferences to display together and indicate one is XSLT and one is not? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 13:10:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 11:10:10 +0000 Subject: [Koha-bugs] [Bug 25711] Add ability to define expiredpickup charge for patron category and item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |joonas.kylmala at helsinki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 13:11:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 11:11:03 +0000 Subject: [Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 13:11:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 11:11:41 +0000 Subject: [Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 13:11:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 11:11:44 +0000 Subject: [Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121938|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 121986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121986&action=edit Bug 28565: Move the sysprefs to a reusable sub This patch moves the big sysprefs list to a sub. Behavior shouldn't change. To test: 1. Run: $ kshell k$ prove t/db_dependent/UsageStats.t => SUCCESS: Things work as expected, no changes. 2. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 13:11:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 11:11:48 +0000 Subject: [Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121939|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 121987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121987&action=edit Bug 28565: Simplify tests This patch makes the tests for UsageStats. This way the tests don't need to be adjusted everytime a syspref is added. To test: 1. Apply the first patch 2. Add some random syspref to C4::UsageStats 3. Run: $ kshell k$ prove t/db_dependent/UsageStats.t => FAIL: Things explode 4. Apply this patch 5. Repeat 3 => SUCCESS: It doesn't explode anymore! 6. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 13:19:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 11:19:16 +0000 Subject: [Koha-bugs] [Bug 25711] Add ability to define expiredpickup charge for patron category and item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|joonas.kylmala at helsinki.fi |testopia at bugs.koha-communit | |y.org --- Comment #21 from Joonas Kylmälä --- Unsetting myself from QA contact, I don't think I am able to find time reviewing this any time soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 13:49:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 11:49:55 +0000 Subject: [Koha-bugs] [Bug 24686] Capturing circulation statistics per number of pieces in an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24686 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #4 from Andrew Fuerste-Henry --- +1 on this. This would be a handy feature. I prefer Daniel's idea of a number stored in the item record so that it's easy to deal with the fact that items are likely to all have different numbers of items. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 13:57:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 11:57:26 +0000 Subject: [Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen at koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 14:03:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 12:03:20 +0000 Subject: [Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from borrower holds list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121797|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 121988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121988&action=edit Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Signed-off-by: marti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 14:13:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 12:13:12 +0000 Subject: [Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from borrower holds list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121988|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi --- Created attachment 121989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121989&action=edit Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Signed-off-by: marti Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 14:15:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 12:15:52 +0000 Subject: [Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from borrower holds list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121989|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 14:16:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 12:16:05 +0000 Subject: [Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from borrower holds list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121988|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 14:18:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 12:18:40 +0000 Subject: [Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference does not work with XSLT results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 --- Comment #4 from Katrin Fischer --- I think a goal is to remove the non-XSLT display this release - so I think better to work towards that. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 14:21:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 12:21:26 +0000 Subject: [Koha-bugs] [Bug 28373] Items fields not used in default XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen at koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 14:27:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 12:27:58 +0000 Subject: [Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from borrower holds list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 14:28:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 12:28:02 +0000 Subject: [Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from borrower holds list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121988|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi --- Created attachment 121990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121990&action=edit Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Signed-off-by: marti Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 14:32:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 12:32:49 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 121991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121991&action=edit Bug 28503: Unit tests Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 14:32:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 12:32:54 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 121992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121992&action=edit Bug 28503: Compare item homebranch to patron branch when hold policy set to 'from_home_library' This fixes an issue in the way we calculate the check for hold policy 'from_home_library' Currently we change the comparison based on ReservesControlBranch, however, that should only control the rule we fetch, not how we compare When ReservesControlBranch is set to "patron's home library" we compare the patron's branch to the patron's branch, this is useless and means we pass the check for all branches all of the time We should instead compare the patron's branch to the item's branch, and only fetch the rule using ReservesControlBranch To test: 1 - Have a record with an item from library A and library B 2 - Set the 'Default checkout, hold and return policy'->Hold policy->From home library for all libraries and ensure you have no branch specific/itemtype specific rules set 3 - Attempt to place a hold on the record for a patron from library B 4 - Note that only the library B item is holdable - place a title level hold (do not choose an item) 5 - Check in the item from library A 6 - It fills the hold - This is incorrect - ignore the hold 7 - Apply patch 8 - Restart all the things 9 - Check in the item from library A 10 - No hold found 11 - Check in the item from library B 12 - Hold found, correctly Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 14:33:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 12:33:00 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 121993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121993&action=edit Bug 28503: Clarify what ReservesControlBranch controls Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 14:33:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 12:33:06 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 121994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121994&action=edit Bug 28503: (follow-up) Get rid of tests warnings Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 14:34:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 12:34:08 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 --- Comment #13 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #8) > Tomas, this is missing your signed-off-by patches! Oops :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 14:52:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 12:52:44 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121728|0 |1 is obsolete| | --- Comment #47 from Andrew Isherwood --- Created attachment 121995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121995&action=edit Bug 27378: Add new 'modaljs' syspref type This commit adds a new 'modaljs' syspref type. This is similar to the existing 'modalselect' syspref type but instead of using a file to create a list of selectable options which are displayed in the modal, it assumes that anything can happen within the modal driven by JS, and whatever happens is going to return a string, that will be saved as the syspref value. In our case, the string will be all the details of the “chunks” concatenated into a string -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 14:52:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 12:52:48 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121729|0 |1 is obsolete| | --- Comment #48 from Andrew Isherwood --- Created attachment 121996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121996&action=edit Bug 27378: Add sysprefs This commit adds 4 new sysprefs: - CookieConsent - the master on/off for this functionality - ConsentJS - The configuration for JS code that requires consent prior to running. - CookieConsentBar: Allows the admin to specify the HTML that will be displayed in the consent bar that appears at the bottom of the page - CookieConsentPopup: Allows the admin to specify the HTML that will be displayed in the cookie consent popup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 14:52:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 12:52:52 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121730|0 |1 is obsolete| | --- Comment #49 from Andrew Isherwood --- Created attachment 121997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121997&action=edit Bug 27378: Add JS to power modaljs This commit adds the Javascript that provides the functionality within the consentJS modaljs modal. It provides the ability to display the current state of any consentJS values and to amend them, as well as add new ones. There is also some refactoring of the existing modalselect functions to allow re-use of existing code between modalselect & modaljs. This refactoring has been minimal and consists of abstracting functionality into functions to allow more wide use. Styles for the consentJS UI were also added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 14:52:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 12:52:57 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121731|0 |1 is obsolete| | --- Comment #50 from Andrew Isherwood --- Created attachment 121998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121998&action=edit Bug 27378: Add cookie consent display to OPAC This commit adds the display of the cookie consent bar and modal to the OPAC. - Adds a new JSConsents template plugin that enables a template to be populated with the contents of the ConsentJS syspref in a prepared, usable form - Adds a new cookieconsent.js script that drives the display and functionality of the cookie consent bar and modal - Adds styles for the cookie consent bar and modal - Adds the creation and population of the cookie consent bar and modal, if appropriate - Adds the ability for both authenticated and unauthenticated users to view and modify their consents either via "your consents" or a new unobtrusive "Your cookies" button in the bottom right of the screen. - Adds unit test for JSConsents.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 14:53:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 12:53:01 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121732|0 |1 is obsolete| | --- Comment #51 from Andrew Isherwood --- Created attachment 121999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121999&action=edit Bug 27378: Add cookie consent display to staff UI This commit adds the display of the cookie consent bar and modal to the staff interface: - Adds a new cookieconsent.js script that drives the display and functionality of the cookie consent bar and modal - Adds styles for the cookie consent bar and modal - Adds the creation and population of the cookie consent bar and modal, if appropriate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 14:53:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 12:53:05 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121733|0 |1 is obsolete| | --- Comment #52 from Andrew Isherwood --- Created attachment 122000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122000&action=edit Bug 27378: Move "Your cookies" to existing bar The new "Your cookies" button that appeared at the bottom right when an unauthenticated user had made their cookie consent selections wasn't ideal. It has now been moved to the top bar, next to "Lists", this feels like a much more sensible place for it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 14:53:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 12:53:10 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121734|0 |1 is obsolete| | --- Comment #53 from Andrew Isherwood --- Created attachment 122001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122001&action=edit Bug 27378: Delete cookies when consent removed We have provided the ability for a user to remove previously granted consent, but we were not removing the cookie associated with that consent. This was a complete oversight on my part. I've introduced an additional bit of metadata for each "consent" defined in the ConsentJS syspref, this allows the admin defining a "consent" to specify a string (which is treated as a regex) that allows us to identify a cookie name associated with that consent. So, for example, if Google Analytics was being added, an identifying string might be '_ga'. This allows us to subsequently remove a cookie that a previously granted consent has set. This commit also adds some missing 'html' filters in koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc and koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 14:53:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 12:53:14 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121735|0 |1 is obsolete| | --- Comment #54 from Andrew Isherwood --- Created attachment 122002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122002&action=edit Bug 27378: Add cookie domain and path A subtlety I missed was that some tracking services, such as Google Analytics, specify a cookie domain and path that differ from the default. E.g. on a site with a domain of demostaff.koha-ptfs.co.uk, the GA cookie will have a domain of '.koha-ptfs.co.uk' and a path of '/', even though the cookie may have been set at a different path. Both of these things makes sense, but of course unless we also specify both of those things when we try to delete a previously set cookie, we cannot. Therefore, I have added two more bits of metadata to each "consent", Cookie Domain and Cookie Path. It is necessary for an admin creating a "consent" entry to know and specify these values. They can be established by looking a cookie set by the service being configured. This adds more complexity to setting up a consent, but we cannot remove previously set cookies without it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 15:16:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 13:16:32 +0000 Subject: [Koha-bugs] [Bug 19266] Add ability to update 005 during import of records and check 001 uniqueness on save to batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19266 --- Comment #8 from Nick Clemens --- Created attachment 122003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122003&action=edit Bug 19266: Allow 001 checking on save to batch and 005 update on import of records To test: 1 - Export a set of records with control numbers from your system 2 - Stage those records 3 - Note during staging a new option to update the 005 4 - Check records after staging 5 - Note 005 is updated or not as the option is selected 6 - Open the advanced cataloging editor 7 - Under settings choose Import Batches 8 - Set the batch you just imported as a save target 9 - Select that batch only as save target 10 - Create a new record, give it the control number of a record in the batch 11 - Attempt to save to the batch 12 - You get an error 13 - Save overriding warnings 14 - The record is then added to the batch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 15:17:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 13:17:07 +0000 Subject: [Koha-bugs] [Bug 19266] Add ability to update 005 during import of records and check 001 uniqueness on save to batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19266 --- Comment #9 from Nick Clemens --- Attempted to rebase and remove dependencies, untested -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 15:22:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 13:22:11 +0000 Subject: [Koha-bugs] [Bug 26704] Koha::Item store triggers should utilise Koha::Object::Messages for message passing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26704 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118548|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 122004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122004&action=edit Bug 26704: Update Koha::Item to use Koha::Object::Messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 15:22:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 13:22:26 +0000 Subject: [Koha-bugs] [Bug 26704] Koha::Item store triggers should utilise Koha::Object::Messages for message passing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26704 --- Comment #4 from Martin Renvoize --- Rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 15:24:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 13:24:00 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel Holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle at bywatersolutions.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 15:24:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 13:24:07 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel Holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 15:28:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 13:28:29 +0000 Subject: [Koha-bugs] [Bug 27879] Koha::Hold::is_at_destination function should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27879 --- Comment #5 from Martin Renvoize --- Is this ready for testing? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 15:32:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 13:32:28 +0000 Subject: [Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference does not work with XSLT results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 --- Comment #5 from Nick Clemens --- (In reply to Katrin Fischer from comment #4) > I think a goal is to remove the non-XSLT display this release - so I think > better to work towards that. So then we simply remove this preference? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 15:46:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 13:46:48 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121953|0 |1 is obsolete| | Attachment #121954|0 |1 is obsolete| | Attachment #121955|0 |1 is obsolete| | Attachment #121985|0 |1 is obsolete| | --- Comment #42 from Jonathan Druart --- Created attachment 122005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122005&action=edit Bug 28520: Revert "Bug 12362: Reverse transfer upon cancellation" This reverts commit d0407686eb070c5bdf0302147a198027abea5ac0. This commit was part of a series adding adding reverse transfers, i.e. transfers that were created for transfers that were cancelled and we wanted the item to return back to its sending library. This however hid the information about transfer happening and we need another approach to the problem. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 15:46:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 13:46:53 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #43 from Jonathan Druart --- Created attachment 122006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122006&action=edit Bug 28520: Bring back TransferCancellation reason handling from reverted Bug 12362 The code from Bug 12362 was reverted but there might be still in database transfers with the reason 'TransferCancellation' so we need to restore the code to handle displaying that information. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 15:46:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 13:46:58 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #44 from Jonathan Druart --- Created attachment 122007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122007&action=edit Bug 28520: Allow creating a transfer back automatically if a hold is canceled during transit This fixes regression caused by "Bug 12362: Cancel transfer with hold cancelation" where cancelled hold's transfer didn't show up in intranet and opac because it create a new transfer that was not yet put in in-transit state. The original idea of bug 12362 was to be able to trigger transfer back home if a hold was cancelled (a regression caused by bug 26078). However, we can do it more simply by setting the $validTransfer variable true in the item check-in code when we are dealing with Reserve transfers. More down in the AddReturn() code there is also a check "and !$resfound" to make sure we only try to trigger the transfer back home automatically if there is no hold waiting at the current location the item arrived in. It should be noted however that now we only display generic message for the automatic transfer reason. Bug 12362 made the return display as the reason "Transfer was cancelled whilst in transit". However, since this fixes the original regressions caused by bug 26078 and restores similar behaviour to that I think giving a more descriptive message for example regarding a hold being cancelled can be considered a further enhancement. To test: 1) Apply patch 1) Have biblio with item in branch A 2) Create a new hold with a pickup library to branch B 3) Check-in the item at branch A and confirm the hold and transfer 4) Cancel the hold 5) Check-in the hold at branch B and notice it prompt to return it to branch A Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 15:47:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 13:47:33 +0000 Subject: [Koha-bugs] [Bug 26978] Add item type criteria to batch extend due date tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26978 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 15:48:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 13:48:01 +0000 Subject: [Koha-bugs] [Bug 26978] Add item type criteria to batch extend due date tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26978 --- Comment #2 from Fiona Borthwick --- Adding an item type filter would be hugely beneficial, -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 15:48:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 13:48:27 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #45 from Jonathan Druart --- I've decided to restore the sub from the patch (patch amended). It makes sense to have from_library if we have to_library. Even if not used yet we are certainly going to need it soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 15:49:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 13:49:38 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 --- Comment #68 from Jonathan Druart --- (In reply to Kyle M Hall from comment #65) > Created attachment 121804 [details] [review] > Bug 24434: (QA follow-up) Remove tab character > > Signed-off-by: Kyle M Hall Patch will be squashed when pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 15:52:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 13:52:16 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121993|Bug 28503: Clarify what |Bug 28503: Clarify what description|ReservesControlBranch |ReservesControlBranch |controls |controls [squashed] --- Comment #14 from Jonathan Druart --- Comment on attachment 121993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121993 Bug 28503: Clarify what ReservesControlBranch controls [squashed] Patch will be squashed when pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 15:52:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 13:52:52 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121804|Bug 24434: (QA follow-up) |Bug 24434: (QA follow-up) description|Remove tab character |Remove tab character | |[squashed] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 15:54:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 13:54:07 +0000 Subject: [Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121866|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 122008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122008&action=edit Bug 28518: Display missing inputs for "Return to the last advanced search" When more than 3 search terms are passed on the advanced search form, the "Return to the last advanced search" feature does not display them. Test plan: Perform an adv search at the OPAC, enter more than 3 terms, launch the search, click the "Return to the last advanced search" link and confirm that all the entries are there. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 15:54:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 13:54:25 +0000 Subject: [Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 --- Comment #5 from Jonathan Druart --- Added missing signed-off-by line from QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 15:55:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 13:55:30 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #65 from Martin Renvoize --- Kyle.. do you think you might have a chance to get back to this.. I'm not sure I will any time soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 15:57:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 13:57:10 +0000 Subject: [Koha-bugs] [Bug 27059] Adding elapsed times/durations to updatedatabase would be nice. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27059 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 16:01:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 14:01:45 +0000 Subject: [Koha-bugs] [Bug 28544] Add API's for account transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28544 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 16:01:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 14:01:45 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28544 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28544 [Bug 28544] Add API's for account transactions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 16:07:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 14:07:44 +0000 Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121822|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 122009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122009&action=edit Bug 8280: Add koha set and item fields to pqf.properties This patch adds a 'koha' set to the pqf properties and maps some basic koha fields to all for searchign To test: 1 - Apply patch 2 - cp etc/z3950/pqf.properties /etc/koha/sites/kohadev/z3950/pqf.properties 3 - sudo koha-z3950-responder --restart kohadev 4 - Test a search: curl -XGET "http://localhost:2100/biblios?version=1.1&operation=searchRetrieve&query=koha.itemtype=BK&maximumRecords=60&recordSchema=marcxml" 5 - Test other fields added: koha.withdrawn koha.lost koha.classification-source koha.materials-specified koha.damaged koha.restricted koha.cn-sort koha.notforloan koha.ccode koha.itemnumber koha.homebranch koha.holdingbranch koha.location koha.barcode koha.onloan koha.itemtype Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 16:09:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 14:09:21 +0000 Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #16 from Martin Renvoize --- This all appears to work as expected, so signing off.. Must admit though.. allot of the knowledge of how this stuff all fits together has now left my brain, so it would be good to get a QA from someone more familiar ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 16:21:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 14:21:07 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #66 from Jonathan Druart --- Wasn't this a "have to" for 20.11.01?... Looks like we completely forgot about it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 16:28:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 14:28:31 +0000 Subject: [Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 16:28:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 14:28:34 +0000 Subject: [Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #43 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 16:28:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 14:28:37 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 16:28:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 14:28:40 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 --- Comment #69 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 16:28:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 14:28:43 +0000 Subject: [Koha-bugs] [Bug 28383] Log in via the itemsearch URL leads to Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28383 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 16:28:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 14:28:46 +0000 Subject: [Koha-bugs] [Bug 28383] Log in via the itemsearch URL leads to Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28383 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 16:28:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 14:28:49 +0000 Subject: [Koha-bugs] [Bug 28467] Add wording to TrackLastPatronActivity description to tell users that it records SIP authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28467 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 16:28:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 14:28:52 +0000 Subject: [Koha-bugs] [Bug 28467] Add wording to TrackLastPatronActivity description to tell users that it records SIP authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28467 --- Comment #9 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 16:28:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 14:28:54 +0000 Subject: [Koha-bugs] [Bug 28488] Javascript error in self-checkout (__ is not defined) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 16:28:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 14:28:57 +0000 Subject: [Koha-bugs] [Bug 28488] Javascript error in self-checkout (__ is not defined) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 16:28:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 14:28:59 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 16:29:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 14:29:02 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 --- Comment #15 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 16:29:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 14:29:05 +0000 Subject: [Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 16:29:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 14:29:07 +0000 Subject: [Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 16:29:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 14:29:10 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 16:29:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 14:29:12 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #46 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 16:29:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 14:29:40 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #54 from Jonathan Druart --- (In reply to Joonas Kylmälä from comment #52) > Created attachment 121981 [details] [review] > Bug 27064: Correct transferbook.t tests to reflect new behaviour of > transferbook() Patch pushed to master, thanks Joonas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 16:34:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 14:34:39 +0000 Subject: [Koha-bugs] [Bug 28566] New: Rename / Relabel StoreLastBorrower Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28566 Bug ID: 28566 Summary: Rename / Relabel StoreLastBorrower Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com We've created a confusing situation with how we label previous borrower data on moredetail.pl. The regular circ history pulled from the issues table is labeled "Last borrower" for the most recent patron to have had and returned the item and "Previous borrower" for the patron before them. This data is wholly unconnected to the StoreLastBorrower system preference. If the StoreLastBorrower system preference is turned on, then moredetail.pl will also include data from the items_last_borrower table. This data is labeled as "Last returned by." It is needlessly confusing that we're using the phrase "last borrower" to refer to two different bits of data. We should *either* rename the syspref *or* switch the labels on moredetail.pl. The former seems like more work to patch but less confusing for users. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 16:45:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 14:45:03 +0000 Subject: [Koha-bugs] [Bug 26704] Koha::Item store triggers should utilise Koha::Object::Messages for message passing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26704 --- Comment #5 from Tomás Cohen Arazi --- This looks nice, and I'm glad the messages do the job! Can you give us a test plan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 17:04:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 15:04:37 +0000 Subject: [Koha-bugs] [Bug 28567] New: Pick-up location is not saved correctly when creating a new library Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28567 Bug ID: 28567 Summary: Pick-up location is not saved correctly when creating a new library Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When adding a new library the pick-up location will always saves as "Yes", even when no was selected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 17:05:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 15:05:08 +0000 Subject: [Koha-bugs] [Bug 19266] Add ability to update 005 during import of records and check 001 uniqueness on save to batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19266 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86387|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 17:06:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 15:06:24 +0000 Subject: [Koha-bugs] [Bug 28567] Pick-up location is not saved correctly when creating a new library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28567 --- Comment #1 from Katrin Fischer --- Spotted in 20.11.06 - haven't confirmed in master yet. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 17:12:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 15:12:35 +0000 Subject: [Koha-bugs] [Bug 19266] Add ability to update 005 during import of records and check 001 uniqueness on save to batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19266 --- Comment #10 from Andrew Fuerste-Henry --- I get a big angry error when trying to go to the cataloging module with Nick's patch applied: Could not compile /kohadevbox/koha/cataloguing/addbooks.pl: Global symbol "$marc_records" requires explicit package name (did you forget to declare "my $marc_records"?) at /kohadevbox/koha/C4/ImportBatch.pm line 455. Global symbol "$num_matched_control_number" requires explicit package name (did you forget to declare "my $num_matched_control_number"?) at /kohadevbox/koha/C4/ImportBatch.pm line 479. Global symbol "$num_matched_control_number" requires explicit package name (did you forget to declare "my $num_matched_control_number"?) at /kohadevbox/koha/C4/ImportBatch.pm line 516. Compilation failed in require at /kohadevbox/koha/C4/Breeding.pm line 29. BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Breeding.pm line 29. Compilation failed in require at /kohadevbox/koha/cataloguing/addbooks.pl line 33. BEGIN failed--compilation aborted at /kohadevbox/koha/cataloguing/addbooks.pl line 33. at /usr/share/perl5/CGI/Compile.pm line 132 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 17:12:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 15:12:57 +0000 Subject: [Koha-bugs] [Bug 19266] Add ability to update 005 during import of records and check 001 uniqueness on save to batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19266 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 19:53:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 17:53:13 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca --- Comment #81 from Agnes Rivers-Moore --- Need a way to turn this off! This patch seems to have been added without any way to suppress the display of patron age or date of birth, and it is all over Koha. This library does not want people's age displayed every time we check out. That is sensitive personal information. Actually we do not collect it, so Koha now wastes screen space showing "No date of birth stored" in multiple places. Please add a preference to suppress this if required by each library. Thank you. ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 20:11:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 18:11:22 +0000 Subject: [Koha-bugs] [Bug 27083] Create ability to record circulation for every item in kits or sets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27083 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |andrew at bywatersolutions.com Status|NEW |RESOLVED --- Comment #1 from Andrew Fuerste-Henry --- *** This bug has been marked as a duplicate of bug 24686 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 20:11:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 18:11:22 +0000 Subject: [Koha-bugs] [Bug 24686] Capturing circulation statistics per number of pieces in an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24686 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #5 from Andrew Fuerste-Henry --- *** Bug 27083 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 21:17:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 19:17:53 +0000 Subject: [Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement simplifies release notes| |the way new system | |preferences are added to | |Hea for statistical | |reporting. Before this | |enhancement the tests | |(t/db_dependent/UsageStats. | |t) required adjusting every | |time a new system | |preference was added. Now | |when a new system | |preference is added to Hea | |they are automatically | |picked up for the tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 22:03:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 20:03:07 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #82 from Katrin Fischer --- (In reply to Agnes Rivers-Moore from comment #81) > Need a way to turn this off! This patch seems to have been added without any > way to suppress the display of patron age or date of birth, and it is all > over Koha. This library does not want people's age displayed every time we > check out. That is sensitive personal information. Actually we do not > collect it, so Koha now wastes screen space showing "No date of birth > stored" in multiple places. Please add a preference to suppress this if > required by each library. Thank you. ;-) Hi Agnes, actually this has a way to turn it off. See here: class='age_years' So all you need to do is add this line to your IntranetUserCSS: .age_years { display:none; } Let me know if that works in all places you need it to and if somewhere is missing, I am sure we can figure it out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 22:11:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 20:11:13 +0000 Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #8 from Nick Clemens --- (In reply to Katrin Fischer from comment #7) > I feel like this would classify more like an enhancement. The feature as is > exists for many years now and while this is understandable request, I > believe it's not a bug. I feel this is a bug, because the view in the catalog, and the view in Z39 are different, as well as the OPAC showing host item on details page and not the results page, but I can see the view of this as an enhancement. > The linking 773 entry is exported? I don't understand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 22:25:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 20:25:15 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com --- Comment #70 from Donna --- This is definitely an ongoing issue - users have no way of telling what was cancelled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 15 23:12:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 21:12:18 +0000 Subject: [Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #3 from Barbara Johnson --- I tested in a sandbox. For Acquisitions -> Vendor -> Basket I'm getting a "Template process failed" error. For all other pages I'm not seeing the additional info from the 245$b, 245$h, 245$n or 245$p subfields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 00:05:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 22:05:36 +0000 Subject: [Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference does not work with XSLT results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 --- Comment #6 from Katrin Fischer --- If we can confirm that there is equal functionality for the XSLT view - I think that would be consequential. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 00:19:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 22:19:10 +0000 Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #9 from Katrin Fischer --- In Koha the host items shown on the child records is just a "view" feature, we store the data differently. The item is actually still only attached to one record. For me Z39.50 is more a "data" than a "view" thing, so I think that's where I was coming from. But of course I can see use cases for this too. If I understand correctly, you will have multiple records with completely the same items (including itemnumber, barcode etc.) after the patch. Depending on what you use Z39.50 for, I wonder if this could cause issues in other systems. I feel an urge to make this at least a configuration switch maybe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 01:07:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 23:07:03 +0000 Subject: [Koha-bugs] [Bug 28364] koha-z3950-responder breaks because of log4perl.conf permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28364 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #9 from wainuiwitikapark at catalyst.net.nz --- Does this need to backported to 19.11.x? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 01:07:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 23:07:45 +0000 Subject: [Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #31 from wainuiwitikapark at catalyst.net.nz --- Does this need to be backported to 19.11.x? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 01:12:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Jun 2021 23:12:40 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Failed QA --- Comment #154 from David Nind --- Tests fail 8-(.. root at kohadevbox:koha(bz12446)$ prove t/db_dependent/Patrons.t t/db_dependent/Patrons.t .. 1/18 # Looks like you planned 26 tests but ran 20. t/db_dependent/Patrons.t .. 18/18 # Failed test 'Update patron categories' # at t/db_dependent/Patrons.t line 215. Can't call method "borrowernumber" on an undefined value at t/db_dependent/Patrons.t line 207. # Looks like your test exited with 11 just after 18. t/db_dependent/Patrons.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 1/18 subtests Test Summary Report ------------------- t/db_dependent/Patrons.t (Wstat: 2816 Tests: 18 Failed: 1) Failed test: 18 Non-zero exit status: 11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 02:02:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 00:02:10 +0000 Subject: [Koha-bugs] [Bug 28421] When refunding lost fees we should not include voided payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28421 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121317|0 |1 is obsolete| | --- Comment #9 from Victor Grousset/tuxayo --- Created attachment 122017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122017&action=edit Bug 28421: Unit Tests This patch adds test test cases for both a Voided Payment and Voided Writeoff. These cases need special handling in the refund process. Test plan 0/ Don't apply 1/ Run t/db_dependent/Koha/Items.t 2/ Prior to this commit the test should pass 3/ Apply this commit but not the dependency(bug 22435) 3/ The test should fail 4/ Bug 22435 should make the test pass again. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 02:02:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 00:02:56 +0000 Subject: [Koha-bugs] [Bug 28421] When refunding lost fees we should not include voided payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28421 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Victor Grousset/tuxayo --- It works :) Amended test plan to show the interaction with bug 22435 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 03:58:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 01:58:53 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121560|0 |1 is obsolete| | --- Comment #38 from wainuiwitikapark at catalyst.net.nz --- Created attachment 122018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122018&action=edit Bug 27741: circ folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 05:31:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 03:31:59 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #11 from David Cook --- (In reply to Julian Maurice from comment #10) > Just a little suggestion: you can use uniq from List::MoreUtils to make the > code smaller and easier to read I don't see how using uniq would make it smaller or easier to read. I also don't like the idea of adding a non-core dependency to Makefile.PL for such a simple task. Further, I don't like List::MoreUtils. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 05:38:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 03:38:05 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #29 from wainuiwitikapark at catalyst.net.nz --- Created attachment 122019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122019&action=edit Bug 28243: tools folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to tools 4) Go to each of the pages/files and check if they have tables 5) Check that each of the tables have captions to describe them (unless they have special heading tags instead) - some of these will be visible on the page and some will be hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 05:47:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 03:47:30 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #30 from wainuiwitikapark at catalyst.net.nz --- Created attachment 122020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122020&action=edit Bug 28243: virtualshelves folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to the virtualshelves/shelves page 4) Check that the page has tables 5) Check that the tables have captions to describe them and that they are hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 05:54:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 03:54:25 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #31 from wainuiwitikapark at catalyst.net.nz --- Created attachment 122021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122021&action=edit Bug 28243: about.tt Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to About Koha 4) Go to each of the pages/files and check if they have tables 5) Check that each of the tables have captions to describe them (unless they have special heading tags instead) - some of these will be visible on the page and some will be hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 05:54:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 03:54:49 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 08:54:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 06:54:54 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #12 from Julian Maurice --- You can replace foreach my $code (@dir_codes){ my $path = $target_dirs->{ $code }; if ($path){ $unique_map{$path} = 1 unless $unique_map{$path}; } } my @paths = sort keys %unique_map; by my @paths = sort uniq map { $target_dirs->{$_} || () } @dir_codes; and if you don't like List::MoreUtils or non-core dependencies, List::Util also has a uniq subroutine. But that was only a suggestion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 10:16:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 08:16:48 +0000 Subject: [Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #44 from Jonathan Druart --- There are tons of tests failing. t/db_dependent/Holds.t, t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t, t/db_dependent/api/v1/holds.t, t/db_dependent/ILSDI_Services.t and t/db_dependent/Reserves/MultiplePerRecord.t. Please fix ASAP or I will revert. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 10:22:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 08:22:59 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #83 from Jonathan Druart --- I also expressed a couple of times that I didn't like the feature. Maybe we should turn it off by default? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 10:35:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 08:35:56 +0000 Subject: [Koha-bugs] [Bug 28568] New: Stocktaking not working well Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28568 Bug ID: 28568 Summary: Stocktaking not working well Change sponsored?: --- Product: Koha Version: 20.05 Hardware: PC OS: Windows Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: damatoy at centralbankmalta.org QA Contact: testopia at bugs.koha-community.org We have a problem with stocktaking. We did a test for a particular collection and it worked fine. Now we started scanning the books which we have for Circulation purposes. The problem is that when we are uploading the file with new scanned book barcodes and run the report to see which books have not been scanned for that particular range it is detecting the books which I did in my test exercise as well. It is like keeping the previous txt file as well and not replacing with the new txt file. Any help please? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 11:13:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 09:13:12 +0000 Subject: [Koha-bugs] [Bug 28569] New: In opac-suggestions.pl preselect user library Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 Bug ID: 28569 Summary: In opac-suggestions.pl preselect user library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In OPAC new purchase suggestion opac-suggestions.pl for library combobox : actually first value is selected, user library should be selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 11:17:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 09:17:48 +0000 Subject: [Koha-bugs] [Bug 28569] In opac-suggestions.pl preselect user library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 11:23:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 09:23:53 +0000 Subject: [Koha-bugs] [Bug 28569] In opac-suggestions.pl preselect user library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 11:23:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 09:23:58 +0000 Subject: [Koha-bugs] [Bug 28569] In opac-suggestions.pl preselect user library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 --- Comment #1 from Fridolin Somers --- Created attachment 122022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122022&action=edit Bug 28569: In opac-suggestions.pl preselect user library In OPAC new purchase suggestion opac-suggestions.pl for library combobox : actually first value is selected, user library should be selected. Test plan : 1) Create a new library named 'ZZZ top' 2) Set this library on a user U1 2) Loggin at OPAC with user U1 3) Create a new suggestion => Check library 'ZZZ top' is preselected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 11:47:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 09:47:27 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #13 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #4) > I would love to move all libs to a libs/ dir, but lets do it on a separate > bug, and discuss the tradeoffs there (my butt has been kicked a couple times > when I proposed it, because of all bugzilla patches not applying if we did > that). Quick remark: this is not true. Git handles that (ie. if a file has been "git mv", a "git am" will follow the move). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 11:52:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 09:52:47 +0000 Subject: [Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #45 from Arthur Suzuki --- Joubu, can you revert? otherwise I cannot apply to master (conflicts) + if solving the problem in master i'm afraid to run into issues applying the patch afterward (fake ancestor). Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 12:11:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 10:11:06 +0000 Subject: [Koha-bugs] [Bug 28569] In opac-suggestions.pl preselect user library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart --- Please remember: - The title of the bug report describes shortly what the *problem is* - The title of the patch describes shortly what the *patch does* https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 12:21:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 10:21:57 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #25 from Alex Buckley --- Hi Henry and Andrew, Just wondering if either of you have had time to re-test the patchset with the follow-up patch in place now? Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 12:29:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 10:29:06 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #26 from Henry Bolshaw --- Sorry Alex, I've not had a chance to look yet but I'll try and do some testing this week. The new functionality sound great though! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 12:51:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 10:51:22 +0000 Subject: [Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 --- Comment #30 from Tadas --- Comment on attachment 114663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114663 Bug 26498: Set default expiration date for holds >From 9fcb4bc1baf12a5471bec6997af4ac41da9a3db7 Mon Sep 17 00:00:00 2001 >From: Emmi Takkinen >Date: Thu, 26 Nov 2020 14:59:42 +0200 >Subject: [PATCH] Bug 26498: Set default expiration date for holds > >Koha doesn't automatically set expiration date for holds >so they can live in the system forever. This patch adds >new sysprefs to control setting of default expiration >date for holds. Note that expiration date is only set >if input field for it is left blank. > >To test: >1. Apply patch and update database. >2. Enable syspref "DefaultHoldExpirationdate" and set some values >to "DefaultHoldExpirationdatePeriod" and >"DefaultHoldExpirationdateUnitOfTime". >3. Add some holds for patron from staff client or OPAC and leave >expiration date input field blank. >=> Holds expiration date should be set according your settings >4. Disable "DefaultHoldExpirationdate" and repeat step 3. >=> Expiration date shouldn't be set. > >Also prove prove t/db_dependent/Hold.t > >Sponsored-by: Koha-Suomi Oy > >Signed-off-by: Andrew Isherwood >--- > Koha/Hold.pm | 15 ++++++++++++ > ...Set_default_expiration_date_for_holds.perl | 12 ++++++++++ > installer/data/mysql/mandatory/sysprefs.sql | 3 +++ > .../admin/preferences/circulation.pref | 18 +++++++++++++++ > t/db_dependent/Hold.t | 23 ++++++++++++++++++- > 5 files changed, 70 insertions(+), 1 deletion(-) > create mode 100644 installer/data/mysql/atomicupdate/Bug-26498-Set_default_expiration_date_for_holds.perl > >diff --git a/Koha/Hold.pm b/Koha/Hold.pm >index 7754691238..33f474cfba 100644 >--- a/Koha/Hold.pm >+++ b/Koha/Hold.pm >@@ -505,6 +505,21 @@ sub cancel { > return $self; > } > >+sub store { >+ my ($self) = @_; >+ >+ if ( C4::Context->preference('DefaultHoldExpirationdate') >+ and ( not defined $self->expirationdate or $self->expirationdate eq '' ) ){ >+ >+ my $period = C4::Context->preference('DefaultHoldExpirationdatePeriod'); >+ my $timeunit = C4::Context->preference('DefaultHoldExpirationdateUnitOfTime'); >+ >+ $self->expirationdate( dt_from_string( $self->reservedate )->add( $timeunit => $period ) ); >+ } >+ >+ $self = $self->SUPER::store; >+} >+ > =head3 _move_to_old > > my $is_moved = $hold->_move_to_old; >diff --git a/installer/data/mysql/atomicupdate/Bug-26498-Set_default_expiration_date_for_holds.perl b/installer/data/mysql/atomicupdate/Bug-26498-Set_default_expiration_date_for_holds.perl >new file mode 100644 >index 0000000000..0fc61b50e4 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/Bug-26498-Set_default_expiration_date_for_holds.perl >@@ -0,0 +1,12 @@ >+$DBversion = 'XXX'; # will be replaced by the RM >+if( CheckVersion( $DBversion ) ) { >+ # you can use $dbh here like: >+ # $dbh->do( "ALTER TABLE biblio ADD COLUMN badtaste int" ); >+ >+ $dbh->do(q{INSERT IGNORE INTO systempreferences (variable,value,options,explanation,type) VALUES ('DefaultHoldExpirationdate','0','','Automatically set default expiration date for holds','YesNo') }); >+ $dbh->do(q{INSERT IGNORE INTO systempreferences (variable,value,options,explanation,type) VALUES ('DefaultHoldExpirationdatePeriod','0','','How long into the future default expiration date is set to be.','integer') }); >+ $dbh->do(q{INSERT IGNORE INTO systempreferences (variable,value,options,explanation,type) VALUES ('DefaultHoldExpirationdateUnitOfTime','days','days|months|years','Which unit of time is used when settimg default expiration date. ','choice') }); >+ >+ # Always end with this (adjust the bug info) >+ NewVersion( $DBversion, 26498, "Bug 26498 - Add option to set a default expire date for holds at reservation time"); >+} >\ No newline at end of file >diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql >index 2ea427bdd2..5b6587ee05 100644 >--- a/installer/data/mysql/mandatory/sysprefs.sql >+++ b/installer/data/mysql/mandatory/sysprefs.sql >@@ -151,6 +151,9 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('decreaseLoanHighHoldsValue',NULL,'','Specifies a threshold for the minimum number of holds needed to trigger a reduction in loan duration (used with decreaseLoanHighHolds)','Integer'), > ('DefaultClassificationSource','ddc',NULL,'Default classification scheme used by the collection. E.g., Dewey, LCC, etc.','ClassSources'), > ('DefaultCountryField008','','','Fill in the default country code for field 008 Range 15-17 of MARC21 - Place of publication, production, or execution. See MARC Code List for Countries','Free'), >+('DefaultHoldExpirationdate','0','','Automatically set expiration date for holds','YesNo'), >+('DefaultHoldExpirationdatePeriod','0','','How long into the future default expiration date is set to be.','integer'), >+('DefaultHoldExpirationdateUnitOfTime','days','days|months|years','Which unit of time is used when settimg default expiration date. ','choice'), > ('DefaultLanguageField008','','','Fill in the default language for field 008 Range 35-37 of MARC21 records (e.g. eng, nor, ger, see MARC Code List for Languages)','Free'), > ('DefaultLongOverdueSkipLostStatuses', '', NULL, 'Skip these lost statuses by default in longoverdue.pl', 'Free'), > ('DefaultLongOverdueChargeValue', '', NULL, "Charge a lost item to the borrower's account when the LOST value of the item changes to n.", 'integer'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >index 9bd26d5aa1..430aaaa25a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >@@ -893,6 +893,24 @@ Circulation: > - pref: UpdateItemWhenLostFromHoldList > type: textarea > syntax: text/x-yaml >+ - >+ - pref: DefaultHoldExpirationdate >+ default: 0 >+ choices: >+ yes: Set >+ no: Don't set >+ - default expiration date for holds automatically. >+ - If enabled, set expiration date >+ - pref: DefaultHoldExpirationdatePeriod >+ default: 0 >+ class: integer >+ - pref: DefaultHoldExpirationdateUnitOfTime >+ default: days >+ choices: >+ days: days >+ months: months >+ years: years >+ - from reserve date. > Interlibrary loans: > - > - pref: ILLModule >diff --git a/t/db_dependent/Hold.t b/t/db_dependent/Hold.t >index 5b71b64292..c86807e3a9 100755 >--- a/t/db_dependent/Hold.t >+++ b/t/db_dependent/Hold.t >@@ -29,7 +29,7 @@ use Koha::Item; > use Koha::DateUtils; > use t::lib::TestBuilder; > >-use Test::More tests => 33; >+use Test::More tests => 34; > use Test::Exception; > use Test::Warn; > >@@ -142,6 +142,27 @@ ok( !$hold->is_at_destination(), "Waiting hold where hold branchcode is not the > $item->holdingbranch( $branches[1]->{branchcode} ); > ok( $hold->is_at_destination(), "Waiting hold where hold branchcode is the same as the item's holdingbranch is at destination" ); > >+# Test setting expiration date >+t::lib::Mocks::mock_preference( 'DefaultHoldExpirationdate', 1 ); >+t::lib::Mocks::mock_preference( 'DefaultHoldExpirationdatePeriod', 2 ); >+t::lib::Mocks::mock_preference( 'DefaultHoldExpirationdateUnitOfTime', 'years' ); >+ >+my $hold_2 = Koha::Hold->new( >+ { >+ biblionumber => $biblionumber, >+ itemnumber => $item->id(), >+ reservedate => '2020-11-30', >+ waitingdate => '2020-11-30', >+ borrowernumber => $borrower->{borrowernumber}, >+ branchcode => $branches[1]->{branchcode}, >+ suspend => 0, >+ } >+); >+$hold_2->store(); >+ >+my $expected_date = dt_from_string( $hold_2->reservedate )->add( years => 2); >+is($hold_2->expirationdate->ymd, $expected_date->ymd,'Expiration date is correctly set.'); >+ > $schema->storage->txn_rollback(); > > subtest "delete() tests" => sub { >-- >2.20.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 13:00:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 11:00:13 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #84 from Katrin Fischer --- I think for off by default we should add an actual preference instead of using CSS. But the CSS will hopefully help for now :) We had no comments this or that way from our mostly academic/special libraries. I imagine the feature might be interesting mostly for publics? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 13:11:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 11:11:56 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #85 from Josef Moravec --- (In reply to Katrin Fischer from comment #84) > I think for off by default we should add an actual preference instead of > using CSS. But the CSS will hopefully help for now :) > > We had no comments this or that way from our mostly academic/special > libraries. I imagine the feature might be interesting mostly for publics? As I remember, the request for this development really came from public library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 13:25:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 11:25:45 +0000 Subject: [Koha-bugs] [Bug 28569] In opac-suggestions.pl preselect user library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 13:25:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 11:25:49 +0000 Subject: [Koha-bugs] [Bug 28569] In opac-suggestions.pl preselect user library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122022|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 122032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122032&action=edit Bug 28569: In opac-suggestions.pl preselect user library In OPAC new purchase suggestion opac-suggestions.pl for library combobox : actually first value is selected, user library should be selected. Test plan : 1) Create a new library named 'ZZZ top' 2) Set this library on a user U1 2) Loggin at OPAC with user U1 3) Create a new suggestion => Check library 'ZZZ top' is preselected Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 13:41:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 11:41:38 +0000 Subject: [Koha-bugs] [Bug 24630] UNIMARC XSLT Update for bug 7611 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 jmbroust changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust at univ-lyo | |n2.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 13:45:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 11:45:49 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 13:45:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 11:45:53 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120954|0 |1 is obsolete| | --- Comment #27 from Andrew Fuerste-Henry --- Created attachment 122033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122033&action=edit Bug 26346: Add option to make public lists editable by all staff If a staff member has access to the staff client (either because 'catalogue' permission is enabled or they're a superlibrarian then that user can add items (from OPAC or staff client) to a list marked 'Staff only' Test plan: 1. In the staff client go to: Lists > 'New list'. Notice under 'Allow changes to contents from' there are three options: Nobody, Owner only, Anyone seeing this list 2. Apply patch and run updatedatabase.pl cd installer/data/mysql sudo koha-shell ./updatedatabase.pl 3. Restart memcached and plack 4. Create a public list and select the new 'Staff only' option under 'Allow changes to contents from' 5. Log out of the staff client and log back in as a different user with the 'Staff access, allows viewing of catalogue in staff interface (catalogue)' permission enabled. 6. Navigate to the Lists module, and click on the name of the list you created in #5 7. Select 'Add items' and enter an item barcode and submit 8. Notice the item has been added to the list 9. Search the catalogue in the staff client. Confirm you can add to the list you created in #5 from both the search result page and biblio record detail page 10. Confirm you can remove items from the list in the OPAC and staff client 11. Login to the OPAC as the same user as #5 12. Perform an OPAC search, Select 'Save to lists' under a biblio record, choose the list from #4 in 'Select a list' and save 13. Confirm in the staff client that the record from #11 has been added to the list 14. Logout of OPAC and login again as a user which does not have 'Staff access, allows viewing of catalogue in staff interface (catalogue)' or superlibrarian enabled 15. Do a OPAC search, hit 'Save to lists' and notice you cannot add the record to the list from #4 16. Run Patron.t and Virtualshelves.t unit tests: sudo koha-shell prove t/db_dependent/Koha/Patron.t prove t/db_dependent/Virtualshelves.t 17. Login to the staff client as the same user as #5 18. Create a new list in the staff client, select 'Category'='Private', 'Allow changes to contents from'='Staff only' 19. Notice 'The Staff only permission has no actual effect while this list is strictly private' message hint is displayed 20. Change 'Category'='Public' and notice the hint is removed 21. Switch back to 'Category'='Private' and 'Allow changes to contents from'='Anyone' 22. Notice the 'The Anyone permission has no actual effect while this list is strictly private.' is displayed 23. Repeat steps 18-22 in the OPAC 24. Create a 'staff only' list in the OPAC and then login as a different user with 'Staff access, allows viewing of catalogue in staff interface (catalogue)' permission enabled. Confirm you are able to add items to this new 'staff only' list. 25. Confirm that the 'Staff only' option is not available to patrons with no special permissions when creating lists in the OPAC Sponsored-by: Horowhenua District Council, New Zealand Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 13:45:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 11:45:57 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121512|0 |1 is obsolete| | --- Comment #28 from Andrew Fuerste-Henry --- Created attachment 122034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122034&action=edit Bug 26346: Add edit_public_lists sub-permission enabling patrons to switch 'owner only' public lists (which they're not the owners of) to 'staff only' lists The first patch on bug 26346 only allowed owners of existing 'owner only' public lists switch those lists to be 'Staff only'. This patch will allow other patrons with the 'edit_public_lists' sub-permission to also make this change. Test plan: 1. Apply the first 26346 patch and follow it's test plan 2. Apply this patch 3. Apply database changes: cd installer/data/mysql sudo koha-shell ./updatedatabase.pl 4. Restart memcached and plack 5. Login to the staff client. Create an 'owner only' public list 6. Create another patron record. Tick the following two permissions: * "Staff access, allows viewing of catalogue in staff interface (catalogue) Required for staff login." permission * Lists > "Edit public lists (edit_public_lists)" sub-permission 7. Logout of the staff client, and login as the user from step #6 8. Navigate to the Lists module, click 'Edit' on the 'owner only' list 9. Confirm you can change the 'Allow changes to contents from:' option to 'Staff only' 10. Confirm you can now add items to this 'staff only' list 11. Login to the OPAC as the patron from step #5 12. Create a 'owner only' public list 13. Logout of OPAC, and login as the patron from step #6 14. Navigate to public lists in the OPAC and edit the OPAC created 'owner only' public list from step # 15. Confirm you can change the 'Allow changes to contents from:" option to 'Staff only' 16. Confirm you can now add items to this 'staff only' list 17. Run Virtualshelves.t unit test: sudo koha-shell prove t/db_dependent/Virtualshelves.t Sponsored-by: Catalyst IT Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 13:48:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 11:48:55 +0000 Subject: [Koha-bugs] [Bug 20718] Add ability to have lists that are available to all list editors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #19 from Andrew Fuerste-Henry --- Bug 26346 has an alternate approach for this, adding a new option of "staff only" for editing so a public list can be set to be editable by just the owner, just staff, or everyone. I prefer that more granular control. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 13:50:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 11:50:43 +0000 Subject: [Koha-bugs] [Bug 20718] Add ability to have lists that are available to all list editors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26346 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 13:50:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 11:50:43 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20718 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 13:57:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 11:57:50 +0000 Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #10 from Nick Clemens --- Created attachment 122035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122035&action=edit Bug 27138: Add preference EmbedHostItemsInSearchEngine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 13:58:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 11:58:39 +0000 Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #11 from Nick Clemens --- (In reply to Katrin Fischer from comment #9) > In Koha the host items shown on the child records is just a "view" feature, > we store the data differently. The item is actually still only attached to > one record. For me Z39.50 is more a "data" than a "view" thing, so I think > that's where I was coming from. > > But of course I can see use cases for this too. > > If I understand correctly, you will have multiple records with completely > the same items (including itemnumber, barcode etc.) after the patch. > Depending on what you use Z39.50 for, I wonder if this could cause issues in > other systems. > > I feel an urge to make this at least a configuration switch maybe? I added a syspref EmbedHostItemsInSearchEngine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 14:45:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 12:45:43 +0000 Subject: [Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This bug fixes the "On |This bug fixes the "On release notes|shelf holds allowed" rules |shelf holds allowed" rules |so that they work correctly |so that they work correctly |when using ILS-DI to place |when using ILS-DI to place |holds. |holds. | | |The expected |The expected |behaviour for "On shelf |behaviour for "On shelf |holds allowed" settings for |holds allowed" settings for |the circulation rules (Koha |the circulation rules (Koha |administration > Patrons |administration > Patrons |and circulation > |and circulation > |Circulation and fines |Circulation and fines |rules) are: |rules) are: |- If set to |- If set to |"Yes", patrons can place |"Yes", patrons can place |holds on items currently |holds on items currently |checked in. |checked in. |- If set to "If |- If set to "If |any unavailable", patrons |any unavailable", patrons |can only place holds on |can only place holds on |items that are not |items that are not |unavailable. |unavailable. |- If set to |- If set to |"If all unavailable", |"If all unavailable", |patrons can only place |patrons can only place |holds on items where *all* |holds on items where *all* |items on the record are |items on the record are |unavailable. |unavailable. | | | |RMNOTE: | |Reverted! Status|Pushed to master |ASSIGNED Version(s)|21.11.00 | released in| | --- Comment #46 from Jonathan Druart --- Patches reverted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 14:53:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 12:53:50 +0000 Subject: [Koha-bugs] [Bug 28524] Most-circulated items (cat_issues_top.pl) is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28524 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 14:53:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 12:53:54 +0000 Subject: [Koha-bugs] [Bug 28524] Most-circulated items (cat_issues_top.pl) is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28524 --- Comment #1 from Jonathan Druart --- Created attachment 122036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122036&action=edit Bug 28524: Escape 'rank' in cat_issues_top.pl It's a MySQL 8 keyword Test plan: Turn off strict_sql_modes (there are other problems in this script) Hit Home Reports > Most-circulated items Submit the form Without this patch you got: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'RANK, biblio.biblionumber AS ID, itemcallnumber as CALLNUM, ccode as CCODE, loca' at line 1 With this patch applied you see the report result view -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 14:54:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 12:54:06 +0000 Subject: [Koha-bugs] [Bug 28524] Most-circulated items (cat_issues_top.pl) is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28524 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 14:56:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 12:56:13 +0000 Subject: [Koha-bugs] [Bug 28523] Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 14:56:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 12:56:18 +0000 Subject: [Koha-bugs] [Bug 28523] Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523 --- Comment #1 from Jonathan Druart --- Created attachment 122037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122037&action=edit Bug 28523: Escape 'rank' in bor_issues_top.pl It's a MySQL 8 keyword Test plan: Turn off strict_sql_modes (there are other problems in this script) Hit Home Reports > Patrons with the most checkouts Submit the form Without this patch you got: You have an error in your SQL syntax; check the manual that corresponds to your MySQL s erver version for the right syntax to use near 'RANK, borrowers.borrowernumber AS ID FROM `old_issues` With this patch applied you see the report result view -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 14:56:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 12:56:24 +0000 Subject: [Koha-bugs] [Bug 28523] Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 15:01:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 13:01:23 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #7 from Jonathan Druart --- Andrew, are you happy with this patchset? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 15:24:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 13:24:02 +0000 Subject: [Koha-bugs] [Bug 28570] New: bor_issues_top.pl using a /tmp file to log debug Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28570 Bug ID: 28570 Summary: bor_issues_top.pl using a /tmp file to log debug Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org $debug and open my $debugfh, '>', '/tmp/bor_issues_top.debug.log'; This must be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 15:25:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 13:25:46 +0000 Subject: [Koha-bugs] [Bug 28570] bor_issues_top.pl using a /tmp file to log debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28570 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 15:25:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 13:25:49 +0000 Subject: [Koha-bugs] [Bug 28570] bor_issues_top.pl using a /tmp file to log debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28570 --- Comment #1 from Jonathan Druart --- Created attachment 122038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122038&action=edit Bug 28570: Remove log to /tmp file from bor_issues_top.pl This is unusual and must not be done. Removing it. Test plan: Use the "Home > Reports > Patrons with the most checkouts" report and confirm that it is working correctly after you applied this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 15:27:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 13:27:39 +0000 Subject: [Koha-bugs] [Bug 28571] New: C4::Auth::_session_log is not used and must be removed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28571 Bug ID: 28571 Summary: C4::Auth::_session_log is not used and must be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org it's logging in a /tmp file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 15:28:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 13:28:46 +0000 Subject: [Koha-bugs] [Bug 28571] C4::Auth::_session_log is not used and must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28571 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 15:28:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 13:28:49 +0000 Subject: [Koha-bugs] [Bug 28571] C4::Auth::_session_log is not used and must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28571 --- Comment #1 from Jonathan Druart --- Created attachment 122039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122039&action=edit Bug 28571: Remove C4::Auth::_session_log It's not used and must be removed Test plan: % git grep _session_log must not return any result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 15:29:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 13:29:31 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116148|0 |1 is obsolete| | --- Comment #50 from Andrew Isherwood --- Created attachment 122040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122040&action=edit Bug 24190: Add acquisition logging Signed-off-by: Maura Stephens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 15:29:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 13:29:36 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116149|0 |1 is obsolete| | --- Comment #51 from Andrew Isherwood --- Created attachment 122041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122041&action=edit Bug 24190: (follow-up) Cancel order del item bug If an order is cancelled but the associated bib / items are unable to be removed, we go into error handling. We still need to log the cancellation though. So this fix moves the logging to just after the cancellation, so it will be logged regardless of the outcome with associated things. Signed-off-by: Maura Stephens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 15:29:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 13:29:40 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116150|0 |1 is obsolete| | --- Comment #52 from Andrew Isherwood --- Created attachment 122042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122042&action=edit Bug 24190: (follow-up) Respond to QA feedback This commit makes changes in response to Jonathan's feedback in comment - Moved from using zero padded strings to store log data to a JSON object - Stopped storing formatted dates in logged data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 15:29:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 13:29:44 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116151|0 |1 is obsolete| | --- Comment #53 from Andrew Isherwood --- Created attachment 122043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122043&action=edit Bug 24190: (follow-up) Add tests In response to Jonathan's request for tests, I have now added additional tests for the methods in C4/Budgets.pm that do logging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 15:29:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 13:29:48 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116153|0 |1 is obsolete| | --- Comment #54 from Andrew Isherwood --- Created attachment 122044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122044&action=edit Bug 24190: (follow-up) Modify order of logging Basket creation involves two steps in Koha, creating the basket then modifying its header. We were logging these two steps in the wrong order. This commit fixes that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 15:29:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 13:29:52 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #55 from Andrew Isherwood --- Created attachment 122045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122045&action=edit Bug 24190: (Follow-up) Rename AcqLog As requested in comment #49, renamed uses of AcqLog to AcquisitionLog -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 15:30:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 13:30:17 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 15:31:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 13:31:26 +0000 Subject: [Koha-bugs] [Bug 28572] New: Replace C4::Debug with Koha::Logger->debug Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Bug ID: 28572 Summary: Replace C4::Debug with Koha::Logger->debug Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: In Discussion Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Should not we replace C4::Debug (and all "$debug && warn" statements) with Koha::Logger->debug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 15:32:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 13:32:13 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |m.de.rooy at rijksmuseum.nl, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 15:34:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 13:34:12 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116152|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 15:49:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 13:49:32 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #8 from Andrew Fuerste-Henry --- Created attachment 122047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122047&action=edit Proposed wording I've attached a screenshot of the resolution interface. The item in question is currently set to the lost status cr. When resolving the claim, I'd like to see it default to maintaining the existing value. Further, it'd be helpful to have the current value noted in this dropdown. I added some wording, which I've marked with a red box. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 16:11:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 14:11:53 +0000 Subject: [Koha-bugs] [Bug 28573] New: Replace authority record with Z39.50/SRU creates new authority record Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Bug ID: 28573 Summary: Replace authority record with Z39.50/SRU creates new authority record Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: sebastian.krieg at tuz-eisenach.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When replacing an authority record with Z39.50/SRU you get a new record and no update of the upgrading record. Test instance: Catalyst IT Ltd. (New Zealand) (https://koha-community.org/demo/) example record: #13 (name: Plato) Steps to reproduce: 1. Menu "Home > Authorities > Details for authority #13 (Personal Name)" 2. Form: https://demo-intra.mykoha.co.nz/cgi-bin/koha/authorities/detail.pl?authid=13 3. Menu "Edit > Replace record via Z39.50/SRU" 4. Field "Name(any)": Homer >> Click "search" 5. choose the second entry "Aschmann, Homer, 1920-" >> click "import" Expected solution: - replace the record #13 with the search data "Aschmann, Homer, 1920-" - Form: https://demo-intra.mykoha.co.nz/cgi-bin/koha/authorities/detail.pl?authid=13 Error: - Menu "Home > Authorities > Adding authority Personal Name" - form: https://demo-intra.mykoha.co.nz/cgi-bin/koha/authorities/authorities.pl?breedingid=58824&authtypecode=PERSO_NAME&index= - Save the record as Record #14 - Menu "Home > Authorities > Details for authority #14 (Personal Name)" Note: I found this error in release 21.05., I use a instance 20.11. to reproduce the error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 16:25:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 14:25:35 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #715 from Nick Clemens --- Notices and DB update conflicts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 16:28:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 14:28:39 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 16:30:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 14:30:32 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Henry Bolshaw changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh at parliament.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 16:31:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 14:31:33 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 Henry Bolshaw changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh at parliament.uk Keywords| |accessibility -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 16:38:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 14:38:15 +0000 Subject: [Koha-bugs] [Bug 28574] New: Double id in source code member.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28574 Bug ID: 28574 Summary: Double id in source code member.pl Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: pierre.genty at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Hi all, The member.pl page (results from patrons search) has two div with the same id : searchheader (checked on 19.11 and 20.11). Is this a problem ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 17:02:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 15:02:36 +0000 Subject: [Koha-bugs] [Bug 28575] New: Add ability to choose if lost fee is refunded based on when lost fee was paid off Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Bug ID: 28575 Summary: Add ability to choose if lost fee is refunded based on when lost fee was paid off Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In bug 20815 we added the NoRefundOnLostReturnedItemsAge system preference to block lost item refunds if the item was lost more than X daya ago. Many libraries would like a comparable system to block refund if the lost item fee has been paid in full more than X days ago. Further, even more libraries have asked for the ability to simply not refund paid lost items at all (they only want to refund/forgive lost fees that are not yet paid). Enabling this new syspref to block refunds on lost items paid off more than 0 days ago would support this behavior. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 17:04:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 15:04:22 +0000 Subject: [Koha-bugs] [Bug 28569] In opac-suggestions.pl preselect user library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 --- Comment #4 from Fridolin Somers --- (In reply to Jonathan Druart from comment #2) > Please remember: > - The title of the bug report describes shortly what the *problem is* > - The title of the patch describes shortly what the *patch does* > > https://wiki.koha-community.org/wiki/Commit_messages Arf indeed, i'll try to do better -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 17:05:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 15:05:55 +0000 Subject: [Koha-bugs] [Bug 28575] Add ability to choose if lost fee is refunded based on when lost fee was paid off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20815 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 17:05:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 15:05:55 +0000 Subject: [Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28575 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 17:23:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 15:23:39 +0000 Subject: [Koha-bugs] [Bug 27059] Adding elapsed times/durations to updatedatabase would be nice. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27059 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Fridolin Somers --- Mmm does not work : $ ./src/installer/data/mysql/updatedatabase.pl Use of uninitialized value $start_time in integer subtraction (-) at ./src/installer/data/mysql/updatedatabase.pl line 24474. Upgrade to 20.12.00.045 done [17:22:25 (451071h:22m:25s)]: Bug 21249 - Adding new system preference SearchLimitLibrary Upgrade to 20.12.00.046 done [17:22:25 (00h:00m:00s)]: Bug 14723 - Additional delivery notes to messages Upgrade to 20.12.00.047 done [17:22:25 (00h:00m:00s)]: Bug 23215 - Remove core PayPal support in favor of the use of plugins Upgrade to 20.12.00.048 done [17:22:25 (00h:00m:00s)]: Bug 26995 - [SKIP] Drop column relationship from borrower tables [not executed] Upgrade to 20.12.00.049 done [17:22:25 (00h:00m:00s)]: Bug 28108 - Move action logs 'SERIAL CLAIM' and 'ACQUISITION CLAIM' to a new 'CLAIMS' module Upgrade to 20.12.00.050 done [17:22:25 (00h:00m:00s)]: Bug 28108 - Add new systempreference OpacHiddenItemsHidesRecord -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 17:53:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 15:53:27 +0000 Subject: [Koha-bugs] [Bug 27879] Koha::Hold::is_at_destination function should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27879 --- Comment #6 from Joonas Kylmälä --- (In reply to Martin Renvoize from comment #5) > Is this ready for testing? Hmm, seems like the patch "Bug 27879: Don't allow set holds to be waiting if not at pickup location" misses unit tests, so those need to be added. I won't be able to spend any time on it now so feel free to add yourself as Co-author in the patches if you will work on this. But besides missing the tests it seems like the patches are OK. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 19:42:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 17:42:35 +0000 Subject: [Koha-bugs] [Bug 28576] New: Add patron image in patron detail section does not specify image size limit Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 Bug ID: 28576 Summary: Add patron image in patron detail section does not specify image size limit Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: salman.ali at inLibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 19:45:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 17:45:55 +0000 Subject: [Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 --- Comment #1 from Salman Ali --- Created attachment 122048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122048&action=edit Bug 28576: Add patron image in patron detail section does not specify image size limit When you try to add an image to a patron in Home/Patrons/anyPatron, it only states the file types that are supported but not the maximum size. If you try to add an image that is bigger than 500 kb, nothing happens and the reason is not presented. This is not the case with the 2 other places where we can add patron images in which they give warnings: Home/Tools/Upload patron images Home/Tools/Patron card creator/Images For now, i simply added the size limit to the file supported message. To test: 1)Search for any patron and go to his page 2)Hover over the image area on the left and click on add 3)Notice the message above the choose file button only specifies file types not size. 4)Add an image bigger than 500 kb 5)Nothing happens 6)Apply patch 7)Repeat steps from 1 to 3 8)Notice the message now includes the maximum size -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 19:50:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 17:50:16 +0000 Subject: [Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |caroline.cyr-la-rose at inlibr | |o.com, | |philippe.blouin at inlibro.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 20:21:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 18:21:31 +0000 Subject: [Koha-bugs] [Bug 23984] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23984 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 20:34:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 18:34:34 +0000 Subject: [Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35885|0 |1 is obsolete| | Attachment #40069|0 |1 is obsolete| | Attachment #121920|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 122049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122049&action=edit Bug 13706: New script dedup_authorities.pl This script allow to deduplicate authorities automatically. Script is in misc/maintenance/ It works this way: 1) authorities are fetched from the database. You can limit fetched results by authtypecode, or directly by specifying WHERE clause 2) for each authority: 2.1) build a Zebra query using the 'search_form' for the heading 2.2) run the query, retrieve the results 2.3) among duplicates, choose the one we want to keep (use --choose-method option). 2.5) use C4::Authorities::merge to merge authorities 3) delete the merged authorities Use --help for more informations on options To be done: 1 - Move to module and cover with tests 2 - Add option to only merge unused authorities 3 - Expand 'ppn' option to be 'control-number' option and allow specifying field 4 - More? 1 & 2 I will attempt - 3 & 4 may be future enhancements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 20:35:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 18:35:09 +0000 Subject: [Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Assignee|alex.arnaud at biblibre.com |nick at bywatersolutions.com Status|Failed QA |ASSIGNED --- Comment #9 from Nick Clemens --- Stealing this one unless Alex or Julian object -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 20:35:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 18:35:29 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #86 from Agnes Rivers-Moore --- (In reply to Jonathan Druart from comment #83) > I also expressed a couple of times that I didn't like the feature. Maybe we > should turn it off by default? Thank you Jonathan! I don't know any reason public libraries would want to see this in day-to-day operations. Some use age to set child or adult patron type, and sending a birthday message might be cute (I find it creepy). None of that is reason to see it daily, but libraries in another country might. (I have worked libraries in England, South Africa and Canada.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 20:40:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 18:40:34 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #87 from Agnes Rivers-Moore --- There are two or three fields we need to suppress. One is the date of birth, one is the age in years, and the third is the message that displays if there is nothing to display. Born: 03/29/1951 (70 years) or No date of birth stored. We tried the CSS that Katrin suggested, and it does not cover all those cases. It would need to hide DOB and Age. Also as we do not collect DOB, we need to hide whatever generates the message if DOB is empty. That would likely be useful for libraries that collect DOB only for children, not adults. Thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 21:11:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 19:11:43 +0000 Subject: [Koha-bugs] [Bug 28577] New: Add column for copynumber on overdue report (overdue.pl) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28577 Bug ID: 28577 Summary: Add column for copynumber on overdue report (overdue.pl) Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at collecto.ca QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Hi, It would be fine to see field copynumber from items on overdue circulation report (/cgi-bin/koha/circ/overdue.pl) and in columns_settings on circ-overdues Thanks, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 21:59:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 19:59:02 +0000 Subject: [Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 21:59:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 19:59:07 +0000 Subject: [Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121021|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 21:59:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 19:59:16 +0000 Subject: [Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121022|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 21:59:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 19:59:23 +0000 Subject: [Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121023|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 22:00:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 20:00:19 +0000 Subject: [Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 122050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122050&action=edit Bug 28299: Unit tests for buildKohaItemsNamespace Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 22:00:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 20:00:24 +0000 Subject: [Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 122051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122051&action=edit Bug 28299: Take OpacHiddenItems into account on opac-shelves hidden_items was not passed to XSLTParse4Display 2 things: * Should we hide the biblio record if OpacHiddenItemsHidesRecord is set? * allow_onshelf_holds is not working like in other scripts, what's the expected behaviour? If hidden should we completely ignore the item? Test plan: 1. Without the patch 2. fill OpacHiddenItems with «damaged: [1]» 3. find a record with several item 4. mark one of them as damaged 5. OPAC: go to the record, you shouldn't see the damaged item 6. add the record to a list 7. see the list 8. in Availability you see the damaged item mentioned, this is the issue 9. apply the patches and restart the services 10. the list should not mention the damaged item :D Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 22:00:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 20:00:28 +0000 Subject: [Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 --- Comment #18 from Tomás Cohen Arazi --- Created attachment 122052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122052&action=edit Bug 28299: Make buildKohaItemsNamespace accept Koha::Items This patch makes buildKohaItemsNamespace (and its only caller, XSLTParse4Display) accept a an optional Koha::Items resultset. This way we don't need to calculate (from the DB) the list of hidden itemnumbers, but solve it in one query. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 22:03:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 20:03:15 +0000 Subject: [Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 --- Comment #19 from Tomás Cohen Arazi --- (In reply to Victor Grousset/tuxayo from comment #11) > Solved minor conflict on the test patch. > > However tests pass even with the patch «Make buildKohaItemsNamespace accept > Koha::Items» > reverted and even with the other one reverted. > > So that means they don't test the change. Sorry for that. The tests only tested the trivial case in which all items for the biblio are passed in the resultset. I now added one more item, that is excluded from the resultset, to better highlight the interaction between both params. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 22:11:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 20:11:17 +0000 Subject: [Koha-bugs] [Bug 9729] Unable to use IT search terms such as C#, .NET, C++ in searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9729 --- Comment #4 from Marjorie Barry-Vila --- Still valid with Zebra and ElasticSearch in 20.05 Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 22:36:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 20:36:38 +0000 Subject: [Koha-bugs] [Bug 26833] Logged in library doesn't show with suggestions count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26833 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 22:39:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 20:39:57 +0000 Subject: [Koha-bugs] [Bug 28125] All OPAC holds blocked when OPACHiddenItems contains incorrect values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 23:33:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 21:33:22 +0000 Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 23:33:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 21:33:28 +0000 Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121505|0 |1 is obsolete| | Attachment #121506|0 |1 is obsolete| | Attachment #121507|0 |1 is obsolete| | --- Comment #8 from Agustín Moyano --- Created attachment 122053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122053&action=edit Bug 27948: Add disclaimer to article request If ArticleRequestsDisclaimerText news is set, a disclaimer text will appear before an article request can be made To test: 1. apply patches 2. enable ArticleRequest syspref 3. in OPAC place an article request for a patron CHECK => No disclaimer text should appear before placing article request 4. add a text in ArticleRequestsDisclaimerText news 5. repeat step 3 SUCCESS => A disclaimer text is shown before you can place an article request Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 23:34:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 21:34:05 +0000 Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 23:38:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 21:38:05 +0000 Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement lets you |This enhancement lets you release notes|include text that patrons |include text that patrons |need to accept before they |need to accept before they |can place an article |can place an article |request (similar to the |request (similar to the |ILLModuleCopyrightClearance |ILLModuleCopyrightClearance |system preference). |system preference). | | |Add |Add |the text required to the |the text required to the |new system preference |new |ArticleRequestsDisclaimerTe |ArticleRequestsDisclaimerTe |xt. If there is no text in |xt entry in the news tool. |the system preference, then | |no message is displayed. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 16 23:38:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 21:38:36 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #164 from Victor Grousset/tuxayo --- IIUC, this needs a rebase and the continuation of comparing the two alternatives. No other blocker than playing with both and getting feedback right? (which is already quite some work ^^) There isn't yet one that has been chosen right? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 00:41:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 22:41:51 +0000 Subject: [Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #32 from Victor Grousset/tuxayo --- It doesn't change how Koha works. It fixes the tests on Debian 11 but for 19.11.x, the CI doesn't use Debian 11 so it won't do anything. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 01:31:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 23:31:34 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #14 from Victor Grousset/tuxayo --- (In reply to David Cook from comment #9) > (In reply to Jonathan Druart from comment #6) > > The main question to me is: is it safe enough for backport into 21.05.01? > > I would say yes especially for Debian package installations. > > Dev environments are the ones that will experience the most changes, but we > can deal with any pain there. > > Once this change is in place, Koha will be much more powerful. There are more than 200 production instances based on git, which changes will they experience? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 01:45:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 23:45:11 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #15 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #14) > (In reply to David Cook from comment #9) > > (In reply to Jonathan Druart from comment #6) > > > The main question to me is: is it safe enough for backport into 21.05.01? > > > > I would say yes especially for Debian package installations. > > > > Dev environments are the ones that will experience the most changes, but we > > can deal with any pain there. > > > > Once this change is in place, Koha will be much more powerful. > > There are more than 200 production instances based on git, which changes > will they experience? It depends on how they do their deployments. If they use symlinks for things like their Apache configuration, then it should be automagical after a "make upgrade". But if they don't, then they'll need to manually update their Apache configuration. (Changes to koha-worker.service and koha-index-daemon-ctl.sh would matter less in the short-term but they would need updates too.) People not using Debian packages are always going to be vulnerable to Apache configuration changes though. I'll note that my PR for koha-gitify needs to be merged in too for users of koha-gitify (like koha-testing-docker): https://gitlab.com/koha-community/koha-gitify/-/merge_requests/2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 01:47:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Jun 2021 23:47:22 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 02:10:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 00:10:28 +0000 Subject: [Koha-bugs] [Bug 9729] Unable to use IT search terms such as C#, .NET, C++ in searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9729 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #5 from David Cook --- (In reply to Marjorie Barry-Vila from comment #4) > Still valid with Zebra and ElasticSearch in 20.05 > > Marjorie It would be interesting to know if it's CHR or ICU indexing for Zebra. These symbols get stripped out in the normalization process. With phrases in ICU, I see we're arbitrarily removing all punctuation. With words in ICU, it looks like we might only be removing punctuation that is preceded by whitespace (which seems to imitate the example chain.xml from https://software.indexdata.com/yaz/doc/yaz.pdf). So that might be OK. In fact I should be able to test that... With CHR indexing, symbols get converted into spaces, so it won't work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 02:12:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 00:12:57 +0000 Subject: [Koha-bugs] [Bug 9729] Unable to use IT search terms such as C#, .NET, C++ in searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9729 --- Comment #6 from David Cook --- Hmm nope... echo "C++" | yaz-icu -c words-icu.xml 1 1 'c+' 'C+' 2 1 '+' '+' echo "C#" | yaz-icu -c words-icu.xml 1 1 'c' 'C' echo ".NET" | yaz-icu -c words-icu.xml 1 1 'net' 'NET' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 02:22:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 00:22:41 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #16 from Victor Grousset/tuxayo --- Thanks for the explanations :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 02:25:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 00:25:51 +0000 Subject: [Koha-bugs] [Bug 9729] Unable to use IT search terms such as C#, .NET, C++ in searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9729 --- Comment #7 from David Cook --- After some experimenting, it seems YAZ ICU will tokenize based on the "+" without any normalization when using the "line" tokenize rule: echo -n "C++" | yaz-icu -c chain.xml 1 1 'c+' 'C+' 2 1 '+' '+' echo -n "C#" | yaz-icu -c chain.xml 1 1 'c#' 'C#' echo -n ".NET" | yaz-icu -c chain.xml 1 1 '.net' '.NET' I wonder if that's a bug in YAZ because it doesn't do that for all punctuation/symbols... echo -n 'C--' | yaz-icu -c chain.xml 1 1 'c--' 'C--' echo -n 'C???' | yaz-icu -c chain.xml 1 1 'c???' 'C???' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 02:27:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 00:27:54 +0000 Subject: [Koha-bugs] [Bug 9729] Unable to use IT search terms such as C#, .NET, C++ in searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9729 --- Comment #8 from David Cook --- (In reply to David Cook from comment #5) > With words in ICU, it > looks like we might only be removing punctuation that is preceded by > whitespace (which seems to imitate the example chain.xml from > https://software.indexdata.com/yaz/doc/yaz.pdf). Ooops. I misread that. Actually, it just strips both whitespace and punctuation regardless of position. Yeah, I don't think this will work with Zebra, since both the word and phrase index registers are supposed to be normalized. I am curious how Google does it. Historically, Google used to normalize its queries and strip out symbols, but the past few years it seems to be more intelligent (it will even convert "+" into "plus" so there is some good AI at work there I reckon). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 03:13:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 01:13:12 +0000 Subject: [Koha-bugs] [Bug 9729] Unable to use IT search terms such as C#, .NET, C++ in searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9729 --- Comment #9 from David Cook --- (In reply to Katrin Fischer from comment #3) > Would be interesting to test with Elasticsearch. I agree. It looks like a bit of a known issue: https://stackoverflow.com/questions/63477160/elastic-analyzer-to-enable-matching-searches-such-as-c-c-a https://discuss.elastic.co/t/searching-and-indexing-of-c-c-net-asp-net-doesnt-work/4070/3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 03:22:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 01:22:36 +0000 Subject: [Koha-bugs] [Bug 9729] Unable to use IT search terms such as C#, .NET, C++ in searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9729 --- Comment #10 from David Cook --- Oh I've had some fun playing with ICU... chain.xml: echo -n '.NET. test' | yaz-icu -c chain.xml 1 1 '.net'' '.NET'' 2 1 'test' 'test' -- Here we tokenize based on the line break (ie space), and then we perform our transliteerate and transform rules as per http://userguide.icu-project.org/transforms/general. With the transliterate, we can use the following syntax: "before_context { text_to_replace } after_context > completed_result | result_to_revisit ;" So here the "text_to_replace" is the [:Punctuation:] and the "after_context" is [:WhiteSpace:], and the completed result is transliterating the punctuation into nothing. So we trim the "." from the end of NET but we don't trim the "." from the start. Of course, that doesn't really work in practice, because it misses sooo many other scenarios: echo -n 'Was that a good idea?' | yaz-icu -c chain.xml 1 1 'was' 'Was' 2 1 'that' 'that' 3 1 'a' 'a' 4 1 'good' 'good' 5 1 'idea?' 'idea?' I'm not really sure how to solve this problem in an efficient way. We could just map "C#", "C++", and ".NET" to "csharp", "cplusplus', and 'dotnet', but that's not a very scalable or comprehensive solution for all Koha users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 03:26:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 01:26:18 +0000 Subject: [Koha-bugs] [Bug 9729] Unable to use IT search terms such as C#, .NET, C++ in searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9729 --- Comment #11 from David Cook --- Of course, some characters also have special significance in the CCL query language as well, so even getting them to Zebra would be part of the first step. Not a simple problem by any stretch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 03:56:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 01:56:24 +0000 Subject: [Koha-bugs] [Bug 28364] koha-z3950-responder breaks because of log4perl.conf permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28364 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.07,20.05.13 |21.05.00,20.11.07,20.05.13, released in| |19.11.19 Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 03:57:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 01:57:04 +0000 Subject: [Koha-bugs] [Bug 28364] koha-z3950-responder breaks because of log4perl.conf permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28364 --- Comment #10 from wainuiwitikapark at catalyst.net.nz --- Backported to 19.11.x for 19.11.19 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 03:58:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 01:58:39 +0000 Subject: [Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #33 from wainuiwitikapark at catalyst.net.nz --- Not backported to 19.11.x Please see Victor's comment above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 04:00:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 02:00:23 +0000 Subject: [Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldoldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 05:08:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 03:08:01 +0000 Subject: [Koha-bugs] [Bug 28532] Accessibility: Staff Client - add legends to forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28532 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28243 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 [Bug 28243] Accessibility: Staff Client - add captions to tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 05:08:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 03:08:01 +0000 Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28532 [Bug 28532] Accessibility: Staff Client - add legends to forms -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 08:21:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 06:21:41 +0000 Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 08:22:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 06:22:13 +0000 Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #9 from Marcel de Rooy --- Could not compile /usr/share/koha/opac/opac-request-article.pl: Bareword "action" not allowed while "strict subs" in use at /usr/share/koha/opac/opac-request-article.pl line 49. How did you test that, Agustin? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 08:29:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 06:29:31 +0000 Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #10 from Marcel de Rooy --- Why not use a construction like: [% PROCESS koha_news_block news => KohaNews.get({ location => 'ArticleRequestsDisclaimerText', lang => lang, library => branchcode, blocktitle => 0 }) %] This is used in other places too to insert text block from news. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 08:30:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 06:30:10 +0000 Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 08:30:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 06:30:17 +0000 Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 08:36:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 06:36:01 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #88 from Marcel de Rooy --- This is privacy issue too. GDPR etc. Note that we (as a special library) removed all birthdates from our system. Hopefully we dont have lots of uninitialized warnings too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 08:40:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 06:40:07 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #1 from Marcel de Rooy --- Great idea. Probably we could miss a lot of such statements too. Remove instead of replace where appropriate? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 08:42:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 06:42:22 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #11 from Marcel de Rooy --- FAIL members/memberentry.pl OK critic FAIL forbidden patterns forbidden pattern: Data::Dumper::Dumper (line 112) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 08:42:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 06:42:58 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #12 from Marcel de Rooy --- Processing additional checks * Signed-off-by line 'Signed-off-by: Salman Ali ' seems invalid This email adress does not work, Salman ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 08:44:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 06:44:29 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #13 from Marcel de Rooy --- Note that the Biblio.t test already fails without this patch.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 08:47:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 06:47:29 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Marcel de Rooy --- + unless($record->field('001')){ + $record->insert_fields_ordered(MARC::Field->new('001', $biblionumber)); + }elsif($record->field('001')->data() eq 'biblionumber'){ + $record->field('001')->update($biblionumber); + } Please explain. Why do you test eq 'biblionumber' ?? Why not always overwrite 001 with $biblionumber if the pref is set ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 08:47:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 06:47:35 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 08:48:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 06:48:40 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #4 from Marcel de Rooy --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 08:51:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 06:51:13 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 --- Comment #5 from Marcel de Rooy --- FAIL Koha/Notice/Templates.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for find_effective_template POD is missing for object_class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 08:52:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 06:52:32 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #89 from Michal Denar --- I don't think that displaying age and date of birth in the interface for librarians is in privacy with security and GDPR. It depends on how the library has the area covered in their documents. Our libraries use the age information in the normal course of business in some cases to verify the reader if they don't have a library card, etc. Certainly this feature can be optional, but it should be available. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 08:53:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 06:53:42 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #90 from Michal Denar --- I don't think that displaying age and date of birth in the interface for librarians is privacy issue or against GDPR rules. It depends on how the library has the area covered in their documents. Our libraries use the age information in the normal course of business in some cases to verify the reader if they don't have a library card, etc. Certainly this feature can be optional, but it should be available. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 09:04:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 07:04:48 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 --- Comment #6 from Marcel de Rooy --- + #$params = {%$params}; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 09:12:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 07:12:23 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #91 from Marcel de Rooy --- (In reply to Michal Denar from comment #90) > I don't think that displaying age and date of birth in the interface for > librarians is privacy issue or against GDPR rules. It depends on how the > library has the area covered in their documents. Our libraries use the age > information in the normal course of business in some cases to verify the > reader if they don't have a library card, etc. Certainly this feature can be > optional, but it should be available. Sure. s/is/could be/ More what I meant. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 09:29:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 07:29:04 +0000 Subject: [Koha-bugs] [Bug 28578] New: Terminology: reserve/reservation should be hold Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28578 Bug ID: 28578 Summary: Terminology: reserve/reservation should be hold Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt:53 %s Set reserve to transit and transfer book to %s: %s %sCancel reservation and then attempt transfer: %s␠ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 09:48:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 07:48:36 +0000 Subject: [Koha-bugs] [Bug 28578] Terminology: reserve/reservation should be hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28578 --- Comment #1 from Katrin Fischer --- ... and book should be item :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 09:59:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 07:59:07 +0000 Subject: [Koha-bugs] [Bug 28579] New: Typo: No record have been imported because they all match an existing record in your catalog. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28579 Bug ID: 28579 Summary: Typo: No record have been imported because they all match an existing record in your catalog. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt:31 No record have been imported because they all match an existing record in your catalog. I think this should either read: "no records have" or "no record has"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:01:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:01:15 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 --- Comment #7 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #6) > + #$params = {%$params}; Hum yes, I remember that. As we modify $params we are modifying the hashref passed (and so unexpected behaviour could happened). I think it should be restored. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:12:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:12:29 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Jonathan Druart --- Skipping QA as we need to move forward (needed for 21.05.01). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:13:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:13:40 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 --- Comment #8 from Marcel de Rooy --- Just seeing a mail problem here (not from this patch): sub inbound_email_address { my ($self) = @_; return $self->branchreplyto || $self->branchemail || C4::Context->preference('ReplytoDefault') || C4::Context->preference('KohaAdminEmailAddress') || undef; ReplyToDefault should imo not be used as the from address. Note that the preferences advertize: KohaAdminEmailAddress Email address for the administrator of Koha: (This is the default From: address for emails unless there is one for the particular library, and is referred to when an internal error occurs.) ReplytoDefault Email address to be set as the replyto in emails: Same for branchreplyto. Note that my server may send mails as library.rijksmuseum.nl and wants replies to rijksmuseum.nl but is not allowed to send as rijksmuseum.nl. So this code is bad and triggers spam lists etc. So actually we should do: return $self->branchemail || C4::Context->preference('KohaAdminEmailAddress'); An || undef makes not much sense? Will open a new report too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:27:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:27:31 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 --- Comment #9 from Martin Renvoize --- (In reply to Marcel de Rooy from comment #8) > Just seeing a mail problem here (not from this patch): > > sub inbound_email_address { > my ($self) = @_; > > return > $self->branchreplyto > || $self->branchemail > || C4::Context->preference('ReplytoDefault') > || C4::Context->preference('KohaAdminEmailAddress') > || undef; > > ReplyToDefault should imo not be used as the from address. > Note that the preferences advertize: > > KohaAdminEmailAddress > Email address for the administrator of Koha: (This is the default From: > address for emails unless there is one for the particular library, and is > referred to when an internal error occurs.) > ReplytoDefault > Email address to be set as the replyto in emails: > > Same for branchreplyto. Note that my server may send mails as > library.rijksmuseum.nl and wants replies to rijksmuseum.nl but is not > allowed to send as rijksmuseum.nl. So this code is bad and triggers spam > lists etc. > > So actually we should do: > return > $self->branchemail > || C4::Context->preference('KohaAdminEmailAddress'); > > An || undef makes not much sense? > > Will open a new report too. Please point out where inbound_email_address is being used as the from address.. that is not it's purpose... the `|| undef` does indeed feel a little odd.. but the rest of the fallthrough chain is correct in my opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:27:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:27:47 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #9 from Jonathan Druart --- Created attachment 122054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122054&action=edit Bug 28271: Add (current status) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:28:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:28:52 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #10 from Jonathan Druart --- (In reply to Andrew Fuerste-Henry from comment #8) > When resolving the claim, I'd like to see it default to maintaining the existing value. This is how it is supposed to work already :) > Further, it'd be helpful to have the current value noted in this dropdown. I added some wording, which I've marked with a red box. I have added "(current status)", without the uppercase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:30:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:30:10 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 --- Comment #10 from Marcel de Rooy --- Koha::Patron general routine not nice sub queue_notice { my ( $self, $params ) = @_; my $letter_params = $params->{letter_params}; my $test_mode = $params->{test_mode}; return unless $letter_params; return unless exists $params->{message_name} xor $params->{message_transports}; # We only want one of these my $library = Koha::Libraries->find( $letter_params->{branchcode} ); my $admin_email_address = $library->inbound_email_address; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:31:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:31:23 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 --- Comment #11 from Marcel de Rooy --- > Please point out where inbound_email_address is being used as the from > address.. that is not it's purpose... the `|| undef` does indeed feel a > little odd.. but the rest of the fallthrough chain is correct in my opinion. The purpose might be unclear. What is an inbound email address actually? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:31:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:31:33 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 --- Comment #12 from Jonathan Druart --- (In reply to Martin Renvoize from comment #9) > the `|| undef` does indeed feel a little odd.. Make sense to me, we will get "NULL" in DB instead of an empty string (or we move the test during the INSERT). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:32:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:32:38 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 --- Comment #13 from Marcel de Rooy --- =head3 inbound_email_address my $to_email = Koha::Library->inbound_email_address; Returns an effective email address which should be accessible to librarians at the branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:33:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:33:11 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 --- Comment #14 from Marcel de Rooy --- > Make sense to me, we will get "NULL" in DB instead of an empty string (or we > move the test during the INSERT). Agreed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:35:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:35:11 +0000 Subject: [Koha-bugs] [Bug 28580] New: Getting random "Database is not empty!" when a job is run on jenkins Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28580 Bug ID: 28580 Summary: Getting random "Database is not empty!" when a job is run on jenkins Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Continuous Integration Assignee: tomascohen at gmail.com Reporter: jonathan.druart+koha at gmail.com Master_D11/319 10:21:00 koha_1 | Running [sudo koha-shell kohadev -p -c 'PERL5LIB=/kohadevbox/koha:/kohadevbox/qa-test-tools perl /kohadevbox/misc4dev/populate_db.pl -v --opac-base-url http://kohadev.myDNSname.org:8080 --intranet-base-url http://kohadev-intra.myDNSname.org:8081 --marcflavour MARC21']... 10:21:00 db_1 | 2021-06-17 8:20:56 9 [Warning] InnoDB: Table mysql/innodb_table_stats has length mismatch in the column name table_name. Please run mysql_upgrade 10:21:00 db_1 | 2021-06-17 8:20:56 9 [Warning] InnoDB: Table mysql/innodb_index_stats has length mismatch in the column name table_name. Please run mysql_upgrade 10:21:00 db_1 | 2021-06-17 8:20:56 9 [Warning] InnoDB: Table mysql/innodb_table_stats has length mismatch in the column name table_name. Please run mysql_upgrade 10:21:00 db_1 | 2021-06-17 8:20:56 9 [Warning] InnoDB: Table mysql/innodb_index_stats has length mismatch in the column name table_name. Please run mysql_upgrade 10:21:00 koha_1 | Database is not empty! at /kohadevbox/misc4dev/populate_db.pl line 101. 10:21:00 koha_koha_1 exited with code 1 10:21:00 Stopping koha_db_1 ... 10:21:00 Stopping koha_memcached_1 ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:35:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:35:22 +0000 Subject: [Koha-bugs] [Bug 28581] New: Patron's queue_notice uses inbound_email_address incorrectly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Bug ID: 28581 Summary: Patron's queue_notice uses inbound_email_address incorrectly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org See also bug 28514 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:35:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:35:33 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28514 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:35:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:35:33 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28581 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:35:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:35:55 +0000 Subject: [Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562 --- Comment #19 from Jawad Makki --- After many test during the last few months, we were able to detect the problem. below are our observations: 1 - the problem is issued definitely from addbiblio.pl 2 - the problem is not related to the size of the record or the number of items 3 - the problem appears when adding a new bibliographic record (and not when editing an existing one) 4 - the problem occurs when we have the "Apostrophe" character in the title (in 245$a) 5 - the source of the problem is coming from the checking for a possible duplicate record function "Duplicate record suspected !". 6 - After disabling the codes of the Duplicate checking in addbiblio.pl, everything is working normally. ------------------- # getting html input my @params = $input->multi_param(); $record = TransformHtmlToMarc( $input, 1 ); # check for a duplicate my ( $duplicatebiblionumber, $duplicatetitle ); # Disable checking for possible duplicates #if ( !$is_a_modif ) { # ( $duplicatebiblionumber, $duplicatetitle ) = FindDuplicate($record); #} ------------------- 7 - the problem is from the "FindDuplicate($record)" function any feedback or suggestion ! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:36:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:36:02 +0000 Subject: [Koha-bugs] [Bug 28580] Getting random "Database is not empty!" when a job is run on jenkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28580 --- Comment #1 from Jonathan Druart --- (In reply to Jonathan Druart from comment #0) > Master_D11/319 This was on Docker_6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:36:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:36:14 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 --- Comment #15 from Marcel de Rooy --- Please move the discussion about inbound email to the other report. Bug 28581 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:37:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:37:56 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 --- Comment #16 from Martin Renvoize --- (In reply to Marcel de Rooy from comment #10) > Koha::Patron > general routine > not nice > > sub queue_notice { > my ( $self, $params ) = @_; > my $letter_params = $params->{letter_params}; > my $test_mode = $params->{test_mode}; > > return unless $letter_params; > return unless exists $params->{message_name} xor > $params->{message_transports}; # We only want one of these > > my $library = Koha::Libraries->find( $letter_params->{branchcode} ); > my $admin_email_address = $library->inbound_email_address; Good catch, that's in incorrect usage I agree.. inbound_email_address was certainly designed to be used as the reply-to and not the from. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:41:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:41:29 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:41:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:41:33 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121727|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy --- Created attachment 122055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122055&action=edit Bug 28514: Remove getletter The way we handle notice templates is confusing (see bug 27660, bug 26787, bug 28487). This patch remove C4::Letters::getletter and use either Koha::Notice::Templates->find or the newly created methods ->find_effective_template that will do all necessary to return the correct template. Test plan: - Create and modify notice templates - Make sure you have TranslateNotices turned on and that some notices templates have a translated version - Use holds_reminder.pl and overdue_notices.pl cronjobs and confirm that the generated notices are the expected ones - Test also pos/printreceipt.pl - And finally test some other notices (CHECKIN, RENEWAL for instance) Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy [EDIT] Amended by removing comment for $params={%$params} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:41:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:41:52 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:42:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:42:13 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize --- Good catch, I agree the use in queue_notice is incorrect. I'll submit a patch to fix that and try to improve the POD of inbound_email_address to further clarify it. Perhaps a 'from_email_address' method might help clarify things too? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:44:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:44:06 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:48:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:48:44 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Marcel de Rooy --- Koha::Patron seems to be the only place where we use the inbound_email routine as a from address. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:54:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:54:49 +0000 Subject: [Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562 --- Comment #20 from Jonathan Druart --- I don't recreate on master. * Did you try a more recent version? * Are you able to recreate the problem on a sandbox? https://wiki.koha-community.org/wiki/Sandboxes * Does the following change fix the problem? diff --git a/C4/Search.pm b/C4/Search.pm index 0db460a8083..17b0ab33f87 100644 --- a/C4/Search.pm +++ b/C4/Search.pm @@ -102,6 +102,7 @@ sub FindDuplicate { $result->{title} =~ s /\\//g; $result->{title} =~ s /\"//g; + $result->{title} =~ s /\'//g; $result->{title} =~ s /\(//g; $result->{title} =~ s /\)//g; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 10:57:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 08:57:51 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #3 from Martin Renvoize --- Created attachment 122056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122056&action=edit Bug 28581: Add 'from_email_address' method and use in Koha::Patron This patch adds a new 'from_email_address' method to Koha::Library to return the appropriate email address to use as the 'from' field for email notices from the library. We then update Koha::Patron->queue_notice to use this new method instead of the incorrect inbound_email_address. I also update the POD for inbound_email_address to clarify it's use case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 11:03:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 09:03:45 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 11:13:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 09:13:51 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122056|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 122057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122057&action=edit Bug 28581: Add 'from_email_address' method and use in Koha::Patron This patch adds a new 'from_email_address' method to Koha::Library to return the appropriate email address to use as the 'from' field for email notices from the library. We then update Koha::Patron->queue_notice to use this new method instead of the incorrect inbound_email_address. I also update the POD for inbound_email_address to clarify it's use case. Test plan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 11:19:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 09:19:01 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 11:19:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 09:19:34 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 11:23:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 09:23:48 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #5 from Marcel de Rooy --- Sorry, still working here too.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 11:33:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 09:33:12 +0000 Subject: [Koha-bugs] [Bug 28582] New: Can't enqueue letter HASH(0x55edf1806850) at /usr/share/koha/Koha/ArticleRequest.pm line 123. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28582 Bug ID: 28582 Summary: Can't enqueue letter HASH(0x55edf1806850) at /usr/share/koha/Koha/ArticleRequest.pm line 123. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org C4::Letters::EnqueueLetter( { letter => $letter, borrowernumber => $self->borrowernumber, message_transport_type => 'email', } ) or warn "can't enqueue letter $letter"; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 11:41:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 09:41:01 +0000 Subject: [Koha-bugs] [Bug 28582] Can't enqueue letter HASH(0x55edf1806850) at /usr/share/koha/Koha/ArticleRequest.pm line 123. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28582 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 11:41:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 09:41:05 +0000 Subject: [Koha-bugs] [Bug 28582] Can't enqueue letter HASH(0x55edf1806850) at /usr/share/koha/Koha/ArticleRequest.pm line 123. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28582 --- Comment #1 from Marcel de Rooy --- Created attachment 122058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122058&action=edit Bug 28582: Fix hashref in a warning message Can't enqueue letter HASH(0x55edf1806850) Test plan: If you cancel an article request when there is no email address (no branch email, no KohaAdminEmailAddress), Koha warns. Verify that the warning now contains the letter code. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 11:41:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 09:41:27 +0000 Subject: [Koha-bugs] [Bug 28582] Can't enqueue letter HASH(0x55edf1806850) at /usr/share/koha/Koha/ArticleRequest.pm line 123. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28582 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | --- Comment #2 from Marcel de Rooy --- Self signoff: trivial++ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 12:02:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 10:02:24 +0000 Subject: [Koha-bugs] [Bug 28583] New: Temporarily disable CSS and Javascript for pages with variable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28583 Bug ID: 28583 Summary: Temporarily disable CSS and Javascript for pages with variable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: severine.queune at bulac.fr QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 14004 introduced the ability to temporarily disable added CSS and Javascript in OPAC and interface by adding ?DISABLE_SYSPREF_IntranetUserCSS=1 for example to the url, but it doesn't work for pages referring to specific ids, for example : -https://kohapro.bulac.fr/cgi-bin/koha/circ/circulation.pl?borrowernumber=xxx -https://kohapro.bulac.fr/cgi-bin/koha/catalogue/detail.pl?biblionumber=xxx I thought I was because two '?' in the same url can't be used and try to replace it by '&' but it still doesn't work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 12:02:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 10:02:48 +0000 Subject: [Koha-bugs] [Bug 28583] Temporarily disable CSS and Javascript for pages with variable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28583 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14004 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14004 [Bug 14004] Add ability to temporarily disable added CSS and Javascript in OPAC and interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 12:02:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 10:02:48 +0000 Subject: [Koha-bugs] [Bug 14004] Add ability to temporarily disable added CSS and Javascript in OPAC and interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14004 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28583 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28583 [Bug 28583] Temporarily disable CSS and Javascript for pages with variable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 12:27:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 10:27:12 +0000 Subject: [Koha-bugs] [Bug 28583] Temporarily disable CSS and Javascript for pages with variable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28583 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 13:03:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 11:03:40 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #92 from Katrin Fischer --- (In reply to Agnes Rivers-Moore from comment #87) > There are two or three fields we need to suppress. One is the date of birth, > one is the age in years, and the third is the message that displays if there > is nothing to display. > > Born: 03/29/1951 (70 years) or > No date of birth stored. > > We tried the CSS that Katrin suggested, and it does not cover all those > cases. It would need to hide DOB and Age. Also as we do not collect DOB, we > need to hide whatever generates the message if DOB is empty. That would > likely be useful for libraries that collect DOB only for children, not > adults. Thank you! Hi Agnes, the date of birth and the message are - as you say - separate issues. But we can also help with CSS there and maybe prefs there. There are some options. In the example above, the years bit should be gone now, correct? And you do collect the date of birth from your patrons, but you don't want to display it in circulation? Check for the HidePersonalPatronDetailOnCirculation system preference. It should do just that :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 13:20:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 11:20:33 +0000 Subject: [Koha-bugs] [Bug 28584] New: Remove hyphens from EAN when adding a new record Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28584 Bug ID: 28584 Summary: Remove hyphens from EAN when adding a new record Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: emmi.takkinen at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In Finland we use EANs to match records. Occassionaly we get double records if record is saved with hyphens in EAN and same record already exists without them or vice versa. To prevent this hyphens should always be removed from EAN in Koha level when record is saved (similary like has been suggested in bug 27774 to ISBN). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 13:22:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 11:22:31 +0000 Subject: [Koha-bugs] [Bug 28584] Remove hyphens from EAN when adding a new record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28584 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |emmi.takkinen at koha-suomi.fi |ity.org | --- Comment #1 from Emmi Takkinen --- Created attachment 122059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122059&action=edit Bug 28584: Remove hyphens from EAN when adding new record Add functionality to TransformMarcToKoha so that hyphens are removed from biblioitem tables "ean" column but EAN value in MARC record is not touched. To test: 1. Apply patch. 2. Create new record with EAN field(s) having hyphen(s) e.g. 74628-8972 3. Check records MARC details => EAN has hyphen 4. Check record from biblioitem table in database => EAN doesn't have hyphen(s) Prove t/db_dependent/Biblio/TransfornMarcToKoha.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 13:24:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 11:24:02 +0000 Subject: [Koha-bugs] [Bug 28582] Can't enqueue letter HASH(0x55edf1806850) at /usr/share/koha/Koha/ArticleRequest.pm line 123. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28582 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122058|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 122060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122060&action=edit Bug 28582: Fix hashref in a warning message Can't enqueue letter HASH(0x55edf1806850) Test plan: If you cancel an article request when there is no email address (no branch email, no KohaAdminEmailAddress), Koha warns. Verify that the warning now contains the letter code. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 13:24:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 11:24:49 +0000 Subject: [Koha-bugs] [Bug 28582] Can't enqueue letter HASH(0x55edf1806850) at /usr/share/koha/Koha/ArticleRequest.pm line 123. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28582 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Works perfectly :). Passing QA I feel like there's a pattern here begging to be adopted for the rest of the 'EnqueueLetter' calls.. but that can wait for another bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 13:25:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 11:25:39 +0000 Subject: [Koha-bugs] [Bug 28584] Remove hyphens from EAN when adding a new record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28584 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6590 --- Comment #2 from Magnus Enger --- But see the discussion on bug 6590. The conclusion there was to not remove the hyphens, I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 13:25:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 11:25:39 +0000 Subject: [Koha-bugs] [Bug 6590] Removing hyphens from ISBN and ISSN when cataloging a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28584 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 13:27:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 11:27:56 +0000 Subject: [Koha-bugs] [Bug 28585] New: Bug in GET /patrons by date_of_birth Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 Bug ID: 28585 Summary: Bug in GET /patrons by date_of_birth Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: hannamari.h.heiniluoma at jyu.fi Querying patrons by their date_of_birth returns an empty response, even though there are patrons with that date of birth in the database. Might be a bug? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 13:30:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 11:30:25 +0000 Subject: [Koha-bugs] [Bug 28584] Remove hyphens from EAN when adding a new record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28584 --- Comment #3 from Emmi Takkinen --- (In reply to Magnus Enger from comment #2) > But see the discussion on bug 6590. The conclusion there was to not remove > the hyphens, I think. I understood it only applied to ISBN and ISSN. Also from that bug comment 15 says: > In UNIMARC, ISBN field is supposed to contain ISBN as written on the > book cover. ISBN without hyphens can be stored in EAN (073) field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 13:36:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 11:36:43 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master --- Comment #18 from Jonathan Druart --- Pushed to master for 21.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 13:37:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 11:37:19 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #19 from Jonathan Druart --- There is change missing in koha-shell root at kohadevbox:koha$ echo $PERL5LIB /kohadevbox/koha:/kohadevbox/koha/lib:/kohadevbox/qa-test-tools root at kohadevbox:koha$ koha-shell kohadev kohadev-koha at kohadevbox:/kohadevbox/koha$ echo $PERL5LIB /kohadevbox/koha:/kohadevbox/qa-test-tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 13:55:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 11:55:10 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #2 from Martin Renvoize --- +1, I love this idea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 14:02:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 12:02:19 +0000 Subject: [Koha-bugs] [Bug 18968] API for online payments using payment plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18968 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #2 from Magnus Enger --- ~4 years later and online payment plugins are now pretty well established. Can this bug be closed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 14:05:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 12:05:24 +0000 Subject: [Koha-bugs] [Bug 18968] API for online payments using payment plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18968 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #3 from Kyle M Hall --- (In reply to Magnus Enger from comment #2) > ~4 years later and online payment plugins are now pretty well established. > Can this bug be closed? Indeed! Considering we are even moving PayPal to be plugin-only, I think it's definitely safe to close this report. Even with activity, we would close it with a request to develop it as a plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 14:09:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 12:09:16 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #3 from Kyle M Hall --- (In reply to Jonathan Druart from comment #0) > Should not we replace C4::Debug (and all "$debug && warn" statements) with > Koha::Logger->debug? +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 14:11:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 12:11:54 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 14:11:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 12:11:58 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122057|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 122061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122061&action=edit Bug 28581: Add 'from_email_address' method and use in Koha::Patron This patch adds a new 'from_email_address' method to Koha::Library to return the appropriate email address to use as the 'from' field for email notices from the library. We then update Koha::Patron->queue_notice to use this new method instead of the incorrect inbound_email_address. I also update the POD for inbound_email_address to clarify it's use case. Test plan Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 14:12:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 12:12:02 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #7 from Marcel de Rooy --- Created attachment 122062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122062&action=edit Bug 28581: Do not send mail without a from address Test plan: Make branch mail empty and KohaAdminEmailAddress. Trigger a message that goes thru the message queue. Check the log for a warning. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 14:12:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 12:12:06 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #8 from Marcel de Rooy --- Created attachment 122063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122063&action=edit Bug 28581: Use from_email_address in the codebase Adding only a few trivial cases now. Test plan: Run password recovery or membership expiry cron. Check sender address. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 14:24:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 12:24:58 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Andrew Fuerste-Henry --- (In reply to Jonathan Druart from comment #10) > (In reply to Andrew Fuerste-Henry from comment #8) > > > When resolving the claim, I'd like to see it default to maintaining the existing value. > > This is how it is supposed to work already :) This is not what it was doing yesterday (see my screenshot, that book was at status "cr" but the resolution popup defaulted to "None"). But it is working correctly as I test this morning. > > Further, it'd be helpful to have the current value noted in this dropdown. I added some wording, which I've marked with a red box. > > I have added "(current status)", without the uppercase. Looks great, thanks! However, this morning I went a step further and actually clicked "Resolve." In both Chrome and Firefox, when I click Resolve I get a little spinning wheel on the button that looks like Koha's working on it, but it just stops there. The browser console says ":8081/api/v1/return_claims/1/resolve:1 Failed to load resource: the server responded with a status of 400 (Bad Request)" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 14:30:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 12:30:30 +0000 Subject: [Koha-bugs] [Bug 20718] Add ability to have lists that are available to all list editors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |MOVED --- Comment #20 from Kyle M Hall --- (In reply to Andrew Fuerste-Henry from comment #19) > Bug 26346 has an alternate approach for this, adding a new option of "staff > only" for editing so a public list can be set to be editable by just the > owner, just staff, or everyone. I prefer that more granular control. Sounds good! Let's close this one for now. It something goes awry with 26346 this can always be resurrected! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 14:37:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 12:37:44 +0000 Subject: [Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115666|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 122064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122064&action=edit Bug 22801: Advance search yr must use date-of-publication and not copydate In advanced search with Elasticsearch the limit on years range is actually using copydate : Koha/SearchEngine/Elasticsearch/QueryBuilder.pm in _fix_limit_special_cases() : if ( $l =~ /^yr,st-numeric,ge=/ ) { my ( $start, $end ) = ( $l =~ /^yr,st-numeric,ge=(.*) and yr,st-numeric,le=(.*)$/ ); next unless defined($start) && defined($end); push @new_lim, "copydate:[$start TO $end]"; } With Zebra it uses date-of-publication and also in Koha/SearchEngine/Elasticsearch/QueryBuilder.pm : our %index_field_convert = ( (...) 'yr' => 'date-of-publication', This patch uses %index_field_convert to perform 'yr' limit. Test plan: 1) Apply patch 2) Use Elasticsearch searchengine 3) Go to advanced search with 'More options' 4) Perform a search with a year limit (value or range) 5) Check results are correct Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 14:37:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 12:37:47 +0000 Subject: [Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 --- Comment #8 from Nick Clemens --- Created attachment 122065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122065&action=edit Bug 22801: (follow-up) Use date-of-publication directly Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 14:38:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 12:38:25 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 14:39:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 12:39:06 +0000 Subject: [Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 --- Comment #9 from Nick Clemens --- Hi Frido, I added a followup to remove: my $yrfield = ( exists $index_field_convert{'yr'} ) ? $index_field_convert{'yr'} : 'yr'; The index_field_convert will always be built the same, so will always resolve to date-of-publication - so we don't need the condition, right? I also update tests to pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 14:40:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 12:40:18 +0000 Subject: [Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 14:40:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 12:40:22 +0000 Subject: [Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122064|0 |1 is obsolete| | --- Comment #10 from David Nind --- Created attachment 122066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122066&action=edit Bug 22801: Advance search yr must use date-of-publication and not copydate In advanced search with Elasticsearch the limit on years range is actually using copydate : Koha/SearchEngine/Elasticsearch/QueryBuilder.pm in _fix_limit_special_cases() : if ( $l =~ /^yr,st-numeric,ge=/ ) { my ( $start, $end ) = ( $l =~ /^yr,st-numeric,ge=(.*) and yr,st-numeric,le=(.*)$/ ); next unless defined($start) && defined($end); push @new_lim, "copydate:[$start TO $end]"; } With Zebra it uses date-of-publication and also in Koha/SearchEngine/Elasticsearch/QueryBuilder.pm : our %index_field_convert = ( (...) 'yr' => 'date-of-publication', This patch uses %index_field_convert to perform 'yr' limit. Test plan: 1) Apply patch 2) Use Elasticsearch searchengine 3) Go to advanced search with 'More options' 4) Perform a search with a year limit (value or range) 5) Check results are correct Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 14:42:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 12:42:45 +0000 Subject: [Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 --- Comment #11 from Nick Clemens --- (In reply to David Nind from comment #10) > Signed-off-by: David Nind Looks like we overlapped, can you test with second patch as well David? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 14:48:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 12:48:56 +0000 Subject: [Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #12 from David Nind --- > Looks like we overlapped, can you test with second patch as well David? Will do! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 14:50:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 12:50:05 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #4 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #0) > Should not we replace C4::Debug (and all "$debug && warn" statements) with > Koha::Logger->debug? +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 14:50:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 12:50:05 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #15 from Nick Clemens --- (In reply to Marcel de Rooy from comment #14) > + unless($record->field('001')){ > + $record->insert_fields_ordered(MARC::Field->new('001', > $biblionumber)); > + }elsif($record->field('001')->data() eq 'biblionumber'){ > + $record->field('001')->update($biblionumber); > + } > > Please explain. > Why do you test eq 'biblionumber' ?? > Why not always overwrite 001 with $biblionumber if the pref is set ? Similar to autobarcode or automembernum - we will default, but if you force a new value we let it stand - I think allowing the librarian to force a different number allows for collections that fall outside the norm. It could be useful for an OAI set for instance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:00:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:00:02 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:00:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:00:06 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122061|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 122067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122067&action=edit Bug 28581: Add 'from_email_address' method and use in Koha::Patron This patch adds a new 'from_email_address' method to Koha::Library to return the appropriate email address to use as the 'from' field for email notices from the library. We then update Koha::Patron->queue_notice to use this new method instead of the incorrect inbound_email_address. I also update the POD for inbound_email_address to clarify it's use case. Test plan Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:00:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:00:10 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122063|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy --- Created attachment 122068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122068&action=edit Bug 28581: Use from_email_address in the codebase Adding only a few (trivial) cases now. Changes in C4::Letters are not trivial after all.. We now add the KohaAdminEmail fallback implicitly when the from address was still empty. The extra check makes us not rely on a do or die action in Email::Stuffer. Test plan: Run password recovery or membership expiry cron. Check sender address. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:01:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:01:56 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122062|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:03:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:03:48 +0000 Subject: [Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122066|0 |1 is obsolete| | --- Comment #13 from David Nind --- Created attachment 122069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122069&action=edit Bug 22801: Advance search yr must use date-of-publication and not copydate In advanced search with Elasticsearch the limit on years range is actually using copydate : Koha/SearchEngine/Elasticsearch/QueryBuilder.pm in _fix_limit_special_cases() : if ( $l =~ /^yr,st-numeric,ge=/ ) { my ( $start, $end ) = ( $l =~ /^yr,st-numeric,ge=(.*) and yr,st-numeric,le=(.*)$/ ); next unless defined($start) && defined($end); push @new_lim, "copydate:[$start TO $end]"; } With Zebra it uses date-of-publication and also in Koha/SearchEngine/Elasticsearch/QueryBuilder.pm : our %index_field_convert = ( (...) 'yr' => 'date-of-publication', This patch uses %index_field_convert to perform 'yr' limit. Test plan: 1) Apply patch 2) Use Elasticsearch searchengine 3) Go to advanced search with 'More options' 4) Perform a search with a year limit (value or range) 5) Check results are correct Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:03:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:03:52 +0000 Subject: [Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122065|0 |1 is obsolete| | --- Comment #14 from David Nind --- Created attachment 122070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122070&action=edit Bug 22801: (follow-up) Use date-of-publication directly Signed-off-by: Nick Clemens Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:05:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:05:34 +0000 Subject: [Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 --- Comment #15 from David Nind --- Testing notes (koha-testing-docker): - tested first using Zebra: works as expected - changed search engine to Elastic and reindexed - change a record so that 008 and 260$c have different values (such as 2009 and 2011) - use the advanced search form > more options > limits > year to search on the 008 value (such as 2009) => record will NOT appear in the search results - search using the 260$c value (such as 2011) => record WILL appear in the search results - apply the patch (and reindex - not sure whether this is necessary, but did anyway) - correct behavour should now occur: . results for limit search should show matching record with 008 value, not 260$c value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:09:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:09:49 +0000 Subject: [Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the advanced release notes| |search form in the OPAC and | |staff interface so that the | |publication date (and | |range) uses the value(s) in | |008 instead of 260$c when | |using Elasticsearch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:14:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:14:25 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #11 from Martin Renvoize --- Created attachment 122071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122071&action=edit Bug 28581: (QA follow-up) Prevent code failure This patch prevents a fatal error when both $params->{from} and $params->{borrowernumber} are undefined. We fallback to KohaAdminEmailAddress before finally falling through to setting a failure status for the message if that last fallback is not found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:26:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:26:54 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122071|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy --- Created attachment 122072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122072&action=edit Bug 28581: (QA follow-up) Prevent code failure This patch prevents a fatal error when both $params->{from} and $params->{borrowernumber} are undefined. We fallback to KohaAdminEmailAddress before finally falling through to setting a failure status for the message if that last fallback is not found. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:30:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:30:08 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Marcel de Rooy --- (In reply to Nick Clemens from comment #15) > (In reply to Marcel de Rooy from comment #14) > > + unless($record->field('001')){ > > + $record->insert_fields_ordered(MARC::Field->new('001', > > $biblionumber)); > > + }elsif($record->field('001')->data() eq 'biblionumber'){ > > + $record->field('001')->update($biblionumber); > > + } > > > > Please explain. > > Why do you test eq 'biblionumber' ?? > > Why not always overwrite 001 with $biblionumber if the pref is set ? > > Similar to autobarcode or automembernum - we will default, but if you force > a new value we let it stand - I think allowing the librarian to force a > different number allows for collections that fall outside the norm. > > It could be useful for an OAI set for instance Maybe you do not understand my point? Read this line: > > + }elsif($record->field('001')->data() eq 'biblionumber'){ You are comparing with the string biblionumber ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:31:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:31:37 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #17 from Marcel de Rooy --- Might start to get what you mean btw.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:34:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:34:15 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #18 from Marcel de Rooy --- The problem with leaving a number might be when you are cloning records with Edit as new. When you do not modify that 001, it is probably wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:35:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:35:28 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #19 from Marcel de Rooy --- This still needs more attention, I am afraid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:37:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:37:10 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #20 from Marcel de Rooy --- + }elsif($record->field('001')->data() eq 'biblionumber'){ How and when will the 001 ever be string biblionumber ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:37:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:37:46 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122067|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 122073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122073&action=edit Bug 28581: Add 'from_email_address' method and use in Koha::Patron This patch adds a new 'from_email_address' method to Koha::Library to return the appropriate email address to use as the 'from' field for email notices from the library. We then update Koha::Patron->queue_notice to use this new method instead of the incorrect inbound_email_address. I also update the POD for inbound_email_address to clarify it's use case. Test plan Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:37:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:37:50 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122068|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 122074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122074&action=edit Bug 28581: Use from_email_address in the codebase Adding only a few (trivial) cases now. Changes in C4::Letters are not trivial after all.. We now add the KohaAdminEmail fallback implicitly when the from address was still empty. The extra check makes us not rely on a do or die action in Email::Stuffer. Test plan: Run password recovery or membership expiry cron. Check sender address. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:37:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:37:54 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122072|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 122075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122075&action=edit Bug 28581: (QA follow-up) Prevent code failure This patch prevents a fatal error when both $params->{from} and $params->{borrowernumber} are undefined. We fallback to KohaAdminEmailAddress before finally falling through to setting a failure status for the message if that last fallback is not found. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:37:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:37:58 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #16 from Martin Renvoize --- Created attachment 122076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122076&action=edit Bug 28581: Use 'from_email_address' where appropriate This patch replaces a few more trivial cases where we were using library->branchemail with a fallback to KohaAdminEmail to just use the new library->from_email_address method directly instead. There were also a couple of cases where we were passing borrowernumber and the patrons library from address too.. this is unneccesary as the code in _send_email_massage will already default to patron library from address if we do not pass an override. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:43:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:43:44 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #20 from Jonathan Druart --- Created attachment 122077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122077&action=edit Bug 28519: Add lib to koha-shell Test plan: % koha-shell kohadev -c 'echo $PERL5LIB' => /kohadevbox/koha:/kohadevbox/koha/lib % koha-shell kohadev echo $PERL5LIB => /kohadevbox/koha:/kohadevbox/koha/lib:/kohadevbox/qa-test-tools Note that this is not consistent but at least we have lib now in both situations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:47:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:47:37 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #17 from Martin Renvoize --- Created attachment 122078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122078&action=edit Bug 28581: Enhance POD for EnqueueLetter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:48:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:48:46 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #18 from Martin Renvoize --- I think between Marcel and I we've signed off each others patches and worked through it together to catch all the edge cases.. Setting to signed off and asking Tomas and Nick to take a look for QA as they've both recently been involved in notice related code close to this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:49:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:49:25 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122077|0 |1 is obsolete| | --- Comment #21 from Tomás Cohen Arazi --- Created attachment 122079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122079&action=edit Bug 28519: Add lib to koha-shell Test plan: % koha-shell kohadev -c 'echo $PERL5LIB' => /kohadevbox/koha:/kohadevbox/koha/lib % koha-shell kohadev echo $PERL5LIB => /kohadevbox/koha:/kohadevbox/koha/lib:/kohadevbox/qa-test-tools Note that this is not consistent but at least we have lib now in both situations Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:53:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:53:01 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:55:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:55:31 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #19 from Marcel de Rooy --- [15:51] ashimema: misc/cronjobs/notice_unprocessed_suggestions.pl [15:52] do you intently leave from now empty ?? [15:52] == magnuse [~magnuse at 89-162-88-217.fiber.signal.no] has joined #koha [15:52] == mode/#koha [+o magnuse] by ChanServ [15:52] + my $admin_email_address = $library->from_email_address [15:52] no comma at the end [15:52] in overdue [15:53] same question for suggestion as for unprocessed sugg [15:53] from is empty now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:58:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:58:55 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122076|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy --- Created attachment 122080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122080&action=edit Bug 28581: Use 'from_email_address' where appropriate This patch replaces a few more trivial cases where we were using library->branchemail with a fallback to KohaAdminEmail to just use the new library->from_email_address method directly instead. There were also a couple of cases where we were passing borrowernumber and the patrons library from address too.. this is unneccesary as the code in _send_email_massage will already default to patron library from address if we do not pass an override. Signed-off-by: Marcel de Rooy Added a semicolon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:58:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:58:59 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122078|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy --- Created attachment 122081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122081&action=edit Bug 28581: Enhance POD for EnqueueLetter Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 15:59:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 13:59:44 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #22 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #19) > [15:51] ashimema: misc/cronjobs/notice_unprocessed_suggestions.pl > [15:52] do you intently leave from now empty ?? > [15:52] == magnuse [~magnuse at 89-162-88-217.fiber.signal.no] has joined #koha > [15:52] == mode/#koha [+o magnuse] by ChanServ > [15:52] + my $admin_email_address = $library->from_email_address > [15:52] no comma at the end > [15:52] in overdue > [15:53] same question for suggestion as for unprocessed sugg > [15:53] from is empty now Semicolon fixed. Two empties are intended; will be filled when sending.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 16:03:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 14:03:09 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #22 from Jonathan Druart --- Follow-up pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 16:07:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 14:07:06 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #67 from Kyle M Hall --- (In reply to Martin Renvoize from comment #64) > Work to date uploaded.. still needs more followups but I wanted to make sure > BZ was in sync with my gitlab before stepping away again What is still on the todo list? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 16:07:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 14:07:11 +0000 Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Marcel de Rooy --- Could you cleanup debug remainders from itemsearch or remove it completely from the patch? +index.koha.itemtype = 1=8031 Should this be itype instead of itemtype ? There is a difference: biblioitems.itemtype or items.itype -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 16:13:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 14:13:56 +0000 Subject: [Koha-bugs] [Bug 28583] Temporarily disable CSS and Javascript for pages with variable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28583 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- It works for me (master) Setting IntranetUserCSS with body{color:red} http://kohadev-intra.mydnsname.org:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=5 => All is red http://kohadev-intra.mydnsname.org:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=5&DISABLE_SYSPREF_IntranetUserCSS=1 => All is black -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 16:15:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 14:15:19 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #68 from Jonathan Druart --- (In reply to Kyle M Hall from comment #67) > (In reply to Martin Renvoize from comment #64) > > Work to date uploaded.. still needs more followups but I wanted to make sure > > BZ was in sync with my gitlab before stepping away again > > What is still on the todo list? I guess it's coming from comments 51-53. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 16:15:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 14:15:35 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #93 from Agnes Rivers-Moore --- (In reply to Katrin Fischer from comment #92) > (In reply to Agnes Rivers-Moore from comment #87) > > There are two or three fields we need to suppress. One is the date of birth, > > one is the age in years, and the third is the message that displays if there > > is nothing to display. > > > > Born: 03/29/1951 (70 years) or > > No date of birth stored. > > > > We tried the CSS that Katrin suggested, and it does not cover all those > > cases. It would need to hide DOB and Age. Also as we do not collect DOB, we > > need to hide whatever generates the message if DOB is empty. That would > > likely be useful for libraries that collect DOB only for children, not > > adults. Thank you! > > Hi Agnes, the date of birth and the message are - as you say - separate > issues. But we can also help with CSS there and maybe prefs there. > > There are some options. In the example above, the years bit should be gone > now, correct? > And you do collect the date of birth from your patrons, but you don't want > to display it in circulation? Check for the > HidePersonalPatronDetailOnCirculation system preference. It should do just > that :) Hi Katrin We have all of it hidden now with a combination of CSS and JS, but there is a flicker when the screen redraws. So, our library has a fix in, but still would like to see this as a preference. We do not collect DOB for all patrons. We don't want to hide ALL personal information - we need phone and email. The preference hides everything. We only want to hide age/DOB. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 16:17:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 14:17:48 +0000 Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 16:17:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 14:17:51 +0000 Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122009|0 |1 is obsolete| | --- Comment #18 from Nick Clemens --- Created attachment 122082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122082&action=edit Bug 8280: Add koha set and item fields to pqf.properties This patch adds a 'koha' set to the pqf properties and maps some basic koha fields to all for searchign To test: 1 - Apply patch 2 - cp etc/z3950/pqf.properties /etc/koha/sites/kohadev/z3950/pqf.properties 3 - sudo koha-z3950-responder --restart kohadev 4 - Test a search: curl -XGET "http://localhost:2100/biblios?version=1.1&operation=searchRetrieve&query=koha.itemtype=BK&maximumRecords=60&recordSchema=marcxml" 5 - Test other fields added: koha.withdrawn koha.lost koha.classification-source koha.materials-specified koha.damaged koha.restricted koha.cn-sort koha.notforloan koha.ccode koha.itemnumber koha.homebranch koha.holdingbranch koha.location koha.barcode koha.onloan koha.itemtype Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 16:22:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 14:22:40 +0000 Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280 --- Comment #19 from Nick Clemens --- (In reply to Marcel de Rooy from comment #17) > Could you cleanup debug remainders from itemsearch or remove it completely > from the patch? ^^ I did a 'git commit -a' when I meant 'git commit' - extra changes removed > +index.koha.itemtype = 1=8031 > > Should this be itype instead of itemtype ? > There is a difference: biblioitems.itemtype or items.itype I think 'itemtype' makes more sense externally - the 'itype'/8031 index contains both the 942$c and the 952$y, so the results here should be as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 16:28:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 14:28:50 +0000 Subject: [Koha-bugs] [Bug 28583] Temporarily disable CSS and Javascript for pages with variable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28583 --- Comment #2 from Fridolin Somers --- I dont reproduce in master With IntranetUserCSS : body { background-color:red; } Using : /cgi-bin/koha/catalogue/detail.pl?biblionumber=1&DISABLE_SYSPREF_IntranetUserCSS=1 It works perfect, no red color. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 16:44:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 14:44:31 +0000 Subject: [Koha-bugs] [Bug 28586] New: Cannot resolve a claim Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Bug ID: 28586 Summary: Cannot resolve a claim Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com [2021-06-17 14:42:51.00970] [909] [warn] OpenAPI <<< PUT api/v1/return_claims/1/resolve [{"message":"Properties not allowed: updated_by.","path":"\/body"}] To recreate: Checkout Claim it Go to claims Action > resolve > resolve claim -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 16:45:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 14:45:10 +0000 Subject: [Koha-bugs] [Bug 28586] Cannot resolve a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 16:45:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 14:45:18 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Depends on| |28586 --- Comment #12 from Jonathan Druart --- It's a bug in master, opened bug 28586. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 [Bug 28586] Cannot resolve a claim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 16:45:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 14:45:18 +0000 Subject: [Koha-bugs] [Bug 28586] Cannot resolve a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28271 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 [Bug 28271] Add the ability to set a new lost status when a claim is resolved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 16:49:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 14:49:07 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 Ray Delahunty changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 16:49:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 14:49:35 +0000 Subject: [Koha-bugs] [Bug 28509] Koha/Acquisition/Orders.t is failing (randomly?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 --- Comment #1 from Jonathan Druart --- Master_D9_MDB_Latest/612 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 17:32:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 15:32:40 +0000 Subject: [Koha-bugs] [Bug 28586] Cannot resolve a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 17:48:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 15:48:46 +0000 Subject: [Koha-bugs] [Bug 28586] Cannot resolve a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 17:51:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 15:51:03 +0000 Subject: [Koha-bugs] [Bug 28586] Cannot resolve a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 17:51:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 15:51:08 +0000 Subject: [Koha-bugs] [Bug 28586] Cannot resolve a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 122083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122083&action=edit Bug 28586: Pass the right parameter to resolve claim Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 17:55:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 15:55:30 +0000 Subject: [Koha-bugs] [Bug 28586] Cannot resolve a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 --- Comment #2 from Tomás Cohen Arazi --- This is yet another case highlighted by adding additionalProperties: false. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 18:19:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 16:19:43 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 18:30:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 16:30:21 +0000 Subject: [Koha-bugs] [Bug 28587] New: ldap auth fails unless Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28587 Bug ID: 28587 Summary: ldap auth fails unless Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: marceau at unh.edu QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org This is related/similar to bug 28385. Apologies if this should be posted there instead. The fix there only works if ldapserver id is set to "ldapserver" and not anything else (such as ). In previous versions ldapserver id could be set to anything. There is nothing in the release notes noting this behavior change so it seems to be a bug. To reproduce simply set ldapserver id to something else and restart plack. There should be lots of errors in the plack-error.log, most useful is: No ldapserver "hostname" defined in KOHA_CONF: /etc/koha/sites/instance/koha-conf.xml The problem is in Auth_with_ldap.pm, specifically: if ( exists $ldap->{ldapserver} ) { $ldap = $ldap->{ldapserver} or die ldapserver_error('id="ldapserver"'); } The code is assuming the id is "ldapserver". Better behavior would be to evaluate $ldap and find what the id is set to. It should be the only key in $ldap, and then do: $ldap=$ldap->{$ldapserveridname} The easy fix is just to set the id to ldapserver, but again, that isn't documented anywhere. I can probably provide a patch in in the next few days. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 19:03:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 17:03:53 +0000 Subject: [Koha-bugs] [Bug 24125] Deleting an authority clears the record heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24125 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 19:29:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 17:29:31 +0000 Subject: [Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged, withdrawn, or not-for-loan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 Daniel Gaghan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.gaghan at pueblolibrary | |.org --- Comment #33 from Daniel Gaghan --- Our staff members mentioned this recently. When they select the Showing only available items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 19:40:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 17:40:53 +0000 Subject: [Koha-bugs] [Bug 28473] Add REST endpoint for searching extended patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28473 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 19:41:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 17:41:19 +0000 Subject: [Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged, withdrawn, or not-for-loan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 --- Comment #34 from Daniel Gaghan --- Sorry network issue when posting a comment. This is what the final message should have read. Our staffers still consider this an issue, can we have any items with the not for loan statuses appear further down in the search results and have have available status appear first? So any material with a Not for Loan status <>0, displays after material with a Not for loan status of 0 or NULL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 20:20:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 18:20:57 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121926|0 |1 is obsolete| | --- Comment #155 from Salman Ali --- Created attachment 122084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122084&action=edit Bug 12446: Ability to allow guarantor relationship for all patron category types This adds a new field "Can be guarantee" to patron categories so it becomes possible for any category type to have a guarantor. To test: 1) Have a patron category of type 'Adult' and one of type 'Child' 2) Confirm, by searching for the "Patron guarantor" fieldset in the edit/create form, that: => a patron of the first category can't have a guarantor => a patron from the second category can 3) Apply patch and run updatedatabase.pl 4) Edit the categories and note the new "Can be guarantee" field 5) It should have been set to "yes" for the "Child" and to "no" for the "Adult" 5) Repeat step 2. It should behave in the same way. 6) Edit the "Can be guarantee" for any of the category and check that the fieldset only appears when "Can be guarantee" is set to "yes" 7) prove t/db_dependent/Patrons.t => tests should still pass Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 20:21:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 18:21:04 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121927|0 |1 is obsolete| | --- Comment #156 from Salman Ali --- Created attachment 122085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122085&action=edit Bug 12446: Schema update Category.pm Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 20:21:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 18:21:11 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121928|0 |1 is obsolete| | --- Comment #157 from Salman Ali --- Created attachment 122086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122086&action=edit Bug 12446: Limit available categories when using "Add guarantee" button Test plan: 1) Have some patron categories that can and cannot be guarantee 2) Visit a patron's account and click the "Add guarantee" button 3) In the "category" dropdown, note that all categories are available 4) Apply this patch 5) Repeat step 2 and 3; the dropdown now only contains the categories for which "can be guarantee" is set to "Yes". Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 20:21:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 18:21:17 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121929|0 |1 is obsolete| | --- Comment #158 from Salman Ali --- Created attachment 122087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122087&action=edit Bug 12446: Add canbeguarantee value to patron categories sample data This patch changes sample data so patron categories of type 'C' or 'P' can be guarantees by default. Signed-off-by: Salman Ali -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 20:25:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 18:25:56 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122084|0 |1 is obsolete| | --- Comment #159 from Salman Ali --- Created attachment 122088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122088&action=edit Bug 12446: Ability to allow guarantor relationship for all patron category types This adds a new field "Can be guarantee" to patron categories so it becomes possible for any category type to have a guarantor. To test: 1) Have a patron category of type 'Adult' and one of type 'Child' 2) Confirm, by searching for the "Patron guarantor" fieldset in the edit/create form, that: => a patron of the first category can't have a guarantor => a patron from the second category can 3) Apply patch and run updatedatabase.pl 4) Edit the categories and note the new "Can be guarantee" field 5) It should have been set to "yes" for the "Child" and to "no" for the "Adult" 5) Repeat step 2. It should behave in the same way. 6) Edit the "Can be guarantee" for any of the category and check that the fieldset only appears when "Can be guarantee" is set to "yes" 7) prove t/db_dependent/Patrons.t => tests should still pass Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 20:26:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 18:26:04 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122085|0 |1 is obsolete| | --- Comment #160 from Salman Ali --- Created attachment 122089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122089&action=edit Bug 12446: Schema update Category.pm Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 20:26:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 18:26:11 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122086|0 |1 is obsolete| | --- Comment #161 from Salman Ali --- Created attachment 122090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122090&action=edit Bug 12446: Limit available categories when using "Add guarantee" button Test plan: 1) Have some patron categories that can and cannot be guarantee 2) Visit a patron's account and click the "Add guarantee" button 3) In the "category" dropdown, note that all categories are available 4) Apply this patch 5) Repeat step 2 and 3; the dropdown now only contains the categories for which "can be guarantee" is set to "Yes". Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 20:26:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 18:26:18 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122087|0 |1 is obsolete| | --- Comment #162 from Salman Ali --- Created attachment 122091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122091&action=edit Bug 12446: Add canbeguarantee value to patron categories sample data This patch changes sample data so patron categories of type 'C' or 'P' can be guarantees by default. Signed-off-by: Salman Ali Signed-off-by: Salman Ali -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 20:30:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 18:30:20 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Salman Ali changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #163 from Salman Ali --- I rebased the patches, tests are succesful now, ready to be tested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 21:07:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 19:07:30 +0000 Subject: [Koha-bugs] [Bug 28586] Cannot resolve a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 122092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122092&action=edit Bug 28586: (follow-up) updated_by should be set This patch makes the route set the 'updated_by' attribute as well, when resolving a return claim through the API. Tests are added for this behavior. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/return_claims.t => SUCCESS: Tests pass! updated_by is set correctly! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 21:13:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 19:13:11 +0000 Subject: [Koha-bugs] [Bug 28587] ldap auth fails unless In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28587 --- Comment #1 from Dobrica Pavlinusic --- Thanks for reporting this. My proposed fix for this is in comment 7 on original bug: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28385#c7 POD documentation in C4::Auth_with_ldap does suggest that id should be ldapserver, so I made assumption that all configurations will have it, which in retrospect seems to be incorrect. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 21:16:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 19:16:29 +0000 Subject: [Koha-bugs] [Bug 28588] New: Add Koha::Checkouts::ReturnClaim->resolve Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 Bug ID: 28588 Summary: Add Koha::Checkouts::ReturnClaim->resolve Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Right now it is all solved in the controller. We need some low-level implementation that could be reused (cronjobs?) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 21:16:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 19:16:44 +0000 Subject: [Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28271 Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 [Bug 28271] Add the ability to set a new lost status when a claim is resolved -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 21:16:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 19:16:44 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28588 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 21:54:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 19:54:57 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120336|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 21:55:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 19:55:01 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122054|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 21:55:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 19:55:06 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120406|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 21:55:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 19:55:10 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120335|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 21:56:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 19:56:02 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #13 from Tomás Cohen Arazi --- Created attachment 122093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122093&action=edit Bug 28271: Add the ability to set a new lost status when a claim is resolved When a claim is resolved the librarian should be able to edit the lost status of the item. It is also letting a way out when BlockReturnOfLostItems is set (the lost status is stuck on ClaimReturnedLostValue as we remove the option to edit itemlost on the item edit form). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 21:56:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 19:56:11 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 122094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122094&action=edit Bug 28271: Adjust API spec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 21:56:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 19:56:23 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 122095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122095&action=edit Bug 28271: Preselect the current item lost value Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 21:56:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 19:56:31 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 122096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122096&action=edit Bug 28271: Add (current status) Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 17 22:17:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 20:17:10 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #29 from Alex Buckley --- Thanks Henry and Andrew for your continued interest in this patchset, I really appreciate it! Thanks for the test and signoff Andrew! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 01:31:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 23:31:44 +0000 Subject: [Koha-bugs] [Bug 28587] ldap auth fails unless In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28587 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 01:32:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 23:32:37 +0000 Subject: [Koha-bugs] [Bug 28587] ldap auth fails unless In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28587 --- Comment #2 from David Cook --- (This is a totally unrealted tangent but curious how the University of New Hampshire uses Koha! Doesn't seem to be for the university library?) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 01:36:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Jun 2021 23:36:20 +0000 Subject: [Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 03:16:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 01:16:37 +0000 Subject: [Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #76 from Mason James --- (In reply to Victor Grousset/tuxayo from comment #74) > Should this patch be backported? > I just had a test failure on Ubuntu 18.04 due to not being able to reach the > schema file at swagger.io hi Victor, we really need this backported, back to 19.11.x https://swagger.io/v2/schema.json was down recently and still causing breakage i'll set the ticket back to open -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 03:17:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 01:17:00 +0000 Subject: [Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 03:34:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 01:34:40 +0000 Subject: [Koha-bugs] [Bug 26394] .mailmap needs to be updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #9 from wainuiwitikapark at catalyst.net.nz --- Not backported to 19.11.x Enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 03:34:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 01:34:55 +0000 Subject: [Koha-bugs] [Bug 26394] .mailmap needs to be updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 03:34:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 01:34:56 +0000 Subject: [Koha-bugs] [Bug 26621] .mailmap adjustments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26621 Bug 26621 depends on bug 26394, which changed state. Bug 26394 Summary: .mailmap needs to be updated https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 03:36:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 01:36:11 +0000 Subject: [Koha-bugs] [Bug 26621] .mailmap adjustments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26621 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #16 from wainuiwitikapark at catalyst.net.nz --- Not backported to 19.11.x Enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 03:36:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 01:36:32 +0000 Subject: [Koha-bugs] [Bug 26621] .mailmap adjustments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26621 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldoldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 03:36:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 01:36:32 +0000 Subject: [Koha-bugs] [Bug 28386] Replace dev_map.yaml from release_tools with .mailmap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28386 Bug 28386 depends on bug 26621, which changed state. Bug 26621 Summary: .mailmap adjustments https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26621 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 04:23:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 02:23:11 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #268 from David Cook --- I think I found another problem. >From the results page, it looks like you can place multiple item holds for multiple bibs, but it doesn't work. It just places a hold on the first item for each bib. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 04:26:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 02:26:50 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #269 from David Cook --- It looks like the "Unlimited" bug happens on the staff interface but not the OPAC... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 04:29:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 02:29:19 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #347 from David Cook --- I haven't tried the latest follow-up, but got a fatal error trying to create a hold group using multiple items from the same bib via the detail page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 06:05:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 04:05:27 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #348 from David Cook --- Created attachment 122097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122097&action=edit Bug 15516: Fix hold groups for multi items for one bib -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 06:12:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 04:12:50 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #349 from David Cook --- We should probably rename this one and change the notes, because it's not accurate. This change lets you place a hold on the next available item from a group of titles from the search result page, but it also lets you place a hold on a group of items for one bib from the detail page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 07:26:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 05:26:21 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #270 from David Cook --- In the OPAC, you can select multiple specific items for multiple records at the same time from the result page, but not all of your selections make it into the holds. It looks like just the first selection. I'm looking at patching this now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 08:09:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 06:09:17 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #271 from David Cook --- Created attachment 122098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122098&action=edit Bug 15565: Allow multiple hold for multiple bib in OPAC This patch allows an OPAC user to select multiple item holds from multiple bibs when placing holds/reserves from the OPAC search result page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 08:13:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 06:13:29 +0000 Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280 --- Comment #20 from Marcel de Rooy --- diff --git a/catalogue/itemsearch.pl b/catalogue/itemsearch.pl index 0329f4b1d8..07cc591c93 100755 --- a/catalogue/itemsearch.pl +++ b/catalogue/itemsearch.pl @@ -254,10 +254,8 @@ if ( defined $format ) { $template->param(sEcho => scalar $cgi->param('sEcho')); output_with_http_headers $cgi, $cookie, $template->output, 'json'; } - exit; } - # Display the search form my @branches = map { value => $_->branchcode, label => $_->branchname }, Koha::Libraries->search( {}, { order_by => 'branchname' } ); @@ -309,5 +307,4 @@ $template->param( items_search_fields => \@items_search_fields, authorised_values_json => to_json($authorised_values), ); - output_html_with_http_headers $cgi, $cookie, $template->output; Strange tool git, heh ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 08:14:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 06:14:32 +0000 Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122082|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy --- Created attachment 122099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122099&action=edit Bug 8280: Add koha set and item fields to pqf.properties This patch adds a 'koha' set to the pqf properties and maps some basic koha fields to all for searchign To test: 1 - Apply patch 2 - cp etc/z3950/pqf.properties /etc/koha/sites/kohadev/z3950/pqf.properties 3 - sudo koha-z3950-responder --restart kohadev 4 - Test a search: curl -XGET "http://localhost:2100/biblios?version=1.1&operation=searchRetrieve&query=koha.itemtype=BK&maximumRecords=60&recordSchema=marcxml" 5 - Test other fields added: koha.withdrawn koha.lost koha.classification-source koha.materials-specified koha.damaged koha.restricted koha.cn-sort koha.notforloan koha.ccode koha.itemnumber koha.homebranch koha.holdingbranch koha.location koha.barcode koha.onloan koha.itemtype Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 08:14:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 06:14:53 +0000 Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 08:22:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 06:22:27 +0000 Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280 --- Comment #22 from Marcel de Rooy --- (In reply to Nick Clemens from comment #19) > I think 'itemtype' makes more sense externally - the 'itype'/8031 index > contains both the 942$c and the 952$y, so the results here should be as > expected. No blocker for me, but it is confusing too to map itemtype to the internal itype index. Confusion creates bugs. If only we had e.g. defaultitemtype and itemtype and we could get rid of itype ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 08:30:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 06:30:03 +0000 Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280 --- Comment #23 from Marcel de Rooy --- And now the big question: How would you get this to work if you put it in etc/z3950 ? It should be in etc/zebradb ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 08:33:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 06:33:39 +0000 Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280 --- Comment #24 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #23) > And now the big question: How would you get this to work if you put it in > etc/z3950 ? > It should be in etc/zebradb ! Probably both. The new daemon is not that on my radar yet.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 08:54:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 06:54:47 +0000 Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 08:54:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 06:54:51 +0000 Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280 --- Comment #25 from Marcel de Rooy --- Created attachment 122100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122100&action=edit Bug 8280: Sync whitespace differences between pqf config files Test plan: Diff etc/zebradb/pqf.properties with the etc/z3950 one. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 08:54:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 06:54:54 +0000 Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122099|0 |1 is obsolete| | --- Comment #26 from Marcel de Rooy --- Created attachment 122101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122101&action=edit Bug 8280: Add koha set and item fields to pqf.properties This patch adds a 'koha' set to the pqf properties and maps some basic koha fields to all for searchign To test: 1 - Apply patch 2 - cp etc/z3950/pqf.properties /etc/koha/sites/kohadev/z3950/pqf.properties 3 - sudo koha-z3950-responder --restart kohadev 4 - Test a search: curl -XGET "http://localhost:2100/biblios?version=1.1&operation=searchRetrieve&query=koha.itemtype=BK&maximumRecords=60&recordSchema=marcxml" 5 - Test other fields added: koha.withdrawn koha.lost koha.classification-source koha.materials-specified koha.damaged koha.restricted koha.cn-sort koha.notforloan koha.ccode koha.itemnumber koha.homebranch koha.holdingbranch koha.location koha.barcode koha.onloan koha.itemtype Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy [EDIT] Copied the changes from z3950 to zebradb too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 09:27:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 07:27:53 +0000 Subject: [Koha-bugs] [Bug 28573] Replace authority record with Z39.50/SRU creates new authority record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Sebastian Krieg changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Priority|P5 - low |P3 OS|All |Linux --- Comment #1 from Sebastian Krieg --- Specify the fields "Hardware" and "Importance". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 09:27:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 07:27:58 +0000 Subject: [Koha-bugs] [Bug 26394] .mailmap needs to be updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 --- Comment #10 from Jonathan Druart --- (In reply to wainuiwitikapark from comment #9) > Not backported to 19.11.x > > Enhancement I would backport it, even if it's an enhancement, it's safe. You may need it at some point, the release_tools scripts are using it now. Same for bug 26621, bug 28386 and bug 28442 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 09:28:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 07:28:11 +0000 Subject: [Koha-bugs] [Bug 27949] Batch printing of article request slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 --- Comment #2 from Marcel de Rooy --- I was on the edge of testing this until someone deciced to add a second perllib and my setup no longer works, aarggg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 09:34:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 07:34:01 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #350 from David Cook --- Created attachment 122102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122102&action=edit Bug 15516: Add ability to create hold groups from OPAC This patch adds a "Treat as hold group" to opac-reserve.pl, which lets OPAC users create a hold group which can include 1+ bibs and either bib-level holds, or item-level holds, or both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 09:35:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 07:35:01 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #351 from David Cook --- I can't guarantee that my last patches actually apply on master, but I'm firing them off as I'm writing them. I can come back to clean them up... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 09:36:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 07:36:02 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #352 from David Cook --- I think Bug 17217 is hopeless, so I figure we may as well just do the OPAC side here. It's not that much more work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 09:49:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 07:49:03 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121975|0 |1 is obsolete| | Attachment #121976|0 |1 is obsolete| | Attachment #121977|0 |1 is obsolete| | Attachment #121978|0 |1 is obsolete| | Attachment #121979|0 |1 is obsolete| | Attachment #121980|0 |1 is obsolete| | --- Comment #35 from Peter Vashchuk --- Created attachment 122103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122103&action=edit Bug 28316: screen unquoted semicolons and all followup colons Currently searches like: "book:", ":book" and "host-item:test:n" cause internal server errors. This patch adds additional regexes that remove the colons at the start and end of the query, and another regex that screens all follow-up colons that go after the first colon to avoid errors when searching for "host-item:test:n". To reproduce: 1) using ES, search for the book with title that contains semicolon at the start or at the end of the line, separated with spaces, this should cause internal server error. 2) try doing the same with something like "host-item:test:n", it should result in error as well. 3) apply the patch. 4) repeat steps 1-2, ensure that it works now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 09:49:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 07:49:09 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #36 from Peter Vashchuk --- Created attachment 122104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122104&action=edit Bug 28316: escape brackets in the search query This patch screens square and curly brackets which have no special language meaning, while keeping ranges as they are, allowing ES to search for biblios with titles that contain square and curly brackets and at the same time allows the use of range searches ([1990 TO 2000]). To reproduce: 1) using ES, search for the book with title that contains square and/or curly brackets, like "book [second edition]", which will result in error. 2) apply the patch. 3) search for that book again, ensure that it works now. 4) additionally perform a search using range, for example: "[1999 TO 2020]", ensure that it works correctly too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 09:49:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 07:49:15 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #37 from Peter Vashchuk --- Created attachment 122105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122105&action=edit Bug 28316: escape exclamation signs in the query Currently having exclamation sign at the end of the query makes ES search fail, and when you try to search for a book that has exclamation sign in the tittle (something like "Words! words") won't show results correctly as it tries to negate everything that is after exclamation sign, making it impossible to search for books that have in in the title This patch escapes exclamation signs if it's at the end of the query or has a space after it, resolving both of the issues listed above. To reproduce: 1) with ES enabled, search for the book with title that contains exclamation sight at the end, like "book!", this search should result in error. 2) do another search, but this time find/prepare beforehand book with a title that has exclamation sign with a space after it, e.g "exclamation! sign", it shouldn't find it as ES treats everything after that exclamation sign as negation. 2) apply the patch. 3) perform searches from the steep one and two again. Search from step one should no longer fail, while search from the step two should find that book. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 09:49:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 07:49:20 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #38 from Peter Vashchuk --- Created attachment 122106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122106&action=edit Bug 28316: avoid messing up regexes in the search queries This patch ensures that the behavior with QueryRegexEscapeOptions set to values other than "Escape" still will works as expected. It does so by storing the contents of regexes before escaping special characters and then restores the contents of regexes back to how it was before, ensuring that searching with regex is possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 09:49:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 07:49:26 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #39 from Peter Vashchuk --- Created attachment 122107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122107&action=edit Bug 28316: avoid messing up regexes in the search queries This patch ensures that the behavior with QueryRegexEscapeOptions set to values other than "Escape" still will works as expected. It does so by storing the contents of regexes before escaping special characters and then restores the contents of regexes back to how it was before, ensuring that searching with regex is possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 09:49:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 07:49:32 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #40 from Peter Vashchuk --- Created attachment 122108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122108&action=edit Bug 28316: add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 09:59:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 07:59:04 +0000 Subject: [Koha-bugs] [Bug 28589] New: Move C4 and Koha to lib Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 Bug ID: 28589 Summary: Move C4 and Koha to lib Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: In Discussion Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 28519 Git handles that perfectly in both ways: * a patch has been created with a file in /Koha, and is applied later when it's moved to /lib/Koha * a file is modified in /lib/Koha and backported into branches which have the file in /Koha Are we ready for this move? Is it something we really want? Who is willing to spend time on working on this (testing mostly)? We can push it in the next month if there are volunteers. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 [Bug 28519] Add a 2nd directory for Perl modules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 09:59:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 07:59:04 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28589 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 [Bug 28589] Move C4 and Koha to lib -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 10:01:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 08:01:53 +0000 Subject: [Koha-bugs] [Bug 28589] Move C4 and Koha to lib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au, | |julian.maurice at biblibre.com | |, | |kyle at bywatersolutions.com, | |m.de.rooy at rijksmuseum.nl, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com, | |tomascohen at gmail.com --- Comment #1 from Jonathan Druart --- And, most of all, what are the possible side-effects and changes needed in side-projects? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 10:26:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 08:26:19 +0000 Subject: [Koha-bugs] [Bug 28590] New: get_shelves_userenv and set_shelves_userenv not used Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28590 Bug ID: 28590 Summary: get_shelves_userenv and set_shelves_userenv not used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org We should remove them, the get is never used, and the set is storing info in userenv that is never read. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 10:30:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 08:30:06 +0000 Subject: [Koha-bugs] [Bug 28590] get_shelves_userenv and set_shelves_userenv not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28590 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 10:30:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 08:30:10 +0000 Subject: [Koha-bugs] [Bug 28590] get_shelves_userenv and set_shelves_userenv not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28590 --- Comment #1 from Jonathan Druart --- Created attachment 122109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122109&action=edit Bug 28590: Remove get_shelves_userenv and set_shelves_userenv They are no longer used since bug 7310, now we are using Koha::Virtualshelves->get_some_shelves Test plan: Create some lists, login at the OPAC and confirm that you see the list in the navbar (top) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 10:30:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 08:30:20 +0000 Subject: [Koha-bugs] [Bug 28590] get_shelves_userenv and set_shelves_userenv not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28590 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7310 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310 [Bug 7310] Improving permissions on lists (virtual shelves) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 10:30:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 08:30:20 +0000 Subject: [Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28590 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28590 [Bug 28590] get_shelves_userenv and set_shelves_userenv not used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 10:30:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 08:30:48 +0000 Subject: [Koha-bugs] [Bug 28590] get_shelves_userenv and set_shelves_userenv not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28590 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 10:42:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 08:42:38 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #23 from Marcel de Rooy --- (In reply to David Cook from comment #0) > Bug 28489 looks to add CGI::Session::Serializer::yamlxs, but it wants to > hack it into C4::Auth. > > I rather we put it in a Perl "lib" directory. However, /usr/share/koha/lib > only exists in a deployed Koha. There is no "lib" directory in the source > tree. But we can fix that. Not opposing this change, but isnt this a hack too? We could have fooled Koha too by making our own package and install it in a regular perllib ? Just curious why we exactly need lib. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 10:45:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 08:45:10 +0000 Subject: [Koha-bugs] [Bug 28589] Move C4 and Koha to lib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 --- Comment #2 from Marcel de Rooy --- What is the benefit exactly? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 11:07:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 09:07:55 +0000 Subject: [Koha-bugs] [Bug 27949] Batch printing of article request slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 --- Comment #3 from Marcel de Rooy --- What if I would like to have these notices on a separate page? I would be inclined to look for a solution with NoticeCSS and a page-break-after. Should this development respect NoticeCSS ? Please have a look at: Koha/Patron/Discharge.pm, sub generate_as_pdf misc/cronjobs/gather_print_notices.pl, sub generate_html Both are using: koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 11:08:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 09:08:46 +0000 Subject: [Koha-bugs] [Bug 28589] Move C4 and Koha to lib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 --- Comment #3 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #2) > What is the benefit exactly? Now that we have it (the lib directory), it makes sense to use if of our lib :) It follows the standard for perl projects. Ideally we also would like to tidy the whole root directory and move the intranet controller scripts to a single directory (see bug 9949). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 11:08:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 09:08:53 +0000 Subject: [Koha-bugs] [Bug 28589] Move C4 and Koha to lib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9949 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 11:11:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 09:11:05 +0000 Subject: [Koha-bugs] [Bug 28589] Move C4 and Koha to lib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 --- Comment #4 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #3) > (In reply to Marcel de Rooy from comment #2) > > What is the benefit exactly? > > Now that we have it (the lib directory), it makes sense to use if of our lib > :) > It follows the standard for perl projects. > > Ideally we also would like to tidy the whole root directory and move the > intranet controller scripts to a single directory (see bug 9949). Haha, yeah thats what I expected :) Note that I asked David for this lib folder on the other report too.. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 11:16:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 09:16:15 +0000 Subject: [Koha-bugs] [Bug 25995] Log changes to due date using bulk edit tool in circulation log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25995 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 11:16:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 09:16:18 +0000 Subject: [Koha-bugs] [Bug 26036] Suggestion for the "Batch extend due dates" result screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26036 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 11:16:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 09:16:52 +0000 Subject: [Koha-bugs] [Bug 26978] Add item type criteria to batch extend due date tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26978 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 11:17:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 09:17:40 +0000 Subject: [Koha-bugs] [Bug 28586] Cannot resolve a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122083|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 122110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122110&action=edit Bug 28586: Pass the right parameter to resolve claim Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 11:17:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 09:17:43 +0000 Subject: [Koha-bugs] [Bug 28586] Cannot resolve a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122092|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 122111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122111&action=edit Bug 28586: (follow-up) updated_by should be set This patch makes the route set the 'updated_by' attribute as well, when resolving a return claim through the API. Tests are added for this behavior. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/return_claims.t => SUCCESS: Tests pass! updated_by is set correctly! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 11:18:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 09:18:46 +0000 Subject: [Koha-bugs] [Bug 28586] Cannot resolve a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 11:18:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 09:18:48 +0000 Subject: [Koha-bugs] [Bug 27248] Allow to use list of barcodes/itemnumbers with Batch extend due dates tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27248 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 11:23:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 09:23:09 +0000 Subject: [Koha-bugs] [Bug 28491] field 003 not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 --- Comment #2 from Marcel de Rooy --- I understand your point. If we change 001, we should change 003 as well. But note that we have a lot of discussion for years going on if we should change 001 at biblio level. As you mentioned, the 003 is created for a new auth record but not for an import. LOC: Whenever the number in field 001 is changed, agencies must assure that the MARC code in field 003 applies to the number found in the 001 field. I am all for changing 003 here as well. But could imagine that others would rather refrain from changing 001? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 11:27:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 09:27:31 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #30 from Marcel de Rooy --- FAIL pod coverage POD is missing for 'host_items' FAIL pod coverage POD is missing for 'columns_to_str' FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt FAIL filters missing_filter at line 174 ( ) missing_filter at line 177 ( ) missing_filter at line 195 ( ) missing_filter at line 197 ( ) missing_filter at line 203 ( ) missing_filter at line 205 ( ) missing_filter at line 215 ( ) missing_filter at line 217 ( ) missing_filter at line 221 ( ) missing_filter at line 223 ( ) missing_filter at line 228 ( ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 11:34:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 09:34:05 +0000 Subject: [Koha-bugs] [Bug 28591] New: debug pass to get_template_and_user but not used Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28591 Bug ID: 28591 Summary: debug pass to get_template_and_user but not used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org There is a "debug" parameter we are passing from the controller scripts to C4::Auth::get_template_and_user, but it's not actually used! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 11:34:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 09:34:32 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28591, 28570 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28570 [Bug 28570] bor_issues_top.pl using a /tmp file to log debug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28591 [Bug 28591] debug pass to get_template_and_user but not used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 11:34:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 09:34:32 +0000 Subject: [Koha-bugs] [Bug 28570] bor_issues_top.pl using a /tmp file to log debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28570 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28572 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 [Bug 28572] Replace C4::Debug with Koha::Logger->debug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 11:34:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 09:34:32 +0000 Subject: [Koha-bugs] [Bug 28591] debug pass to get_template_and_user but not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28591 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28572 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 [Bug 28572] Replace C4::Debug with Koha::Logger->debug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 11:41:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 09:41:07 +0000 Subject: [Koha-bugs] [Bug 28591] debug passed to get_template_and_user but not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28591 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|debug pass to |debug passed to |get_template_and_user but |get_template_and_user but |not used |not used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 11:56:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 09:56:32 +0000 Subject: [Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 12:00:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 10:00:14 +0000 Subject: [Koha-bugs] [Bug 27170] ILL availability should be able to display arbitrary links to related resources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114256|0 |1 is obsolete| | --- Comment #5 from Andrew Isherwood --- Created attachment 122112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122112&action=edit Bug 27170: Add support for new 'links' property This commit adds support for the new 'links' property that will allow an availability plugin to return an array of links for a result. These links are parsed and appended to the title field of a results record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 12:00:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 10:00:17 +0000 Subject: [Koha-bugs] [Bug 27170] ILL availability should be able to display arbitrary links to related resources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 --- Comment #6 from Andrew Isherwood --- Created attachment 122113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122113&action=edit Bug 27170: Fix bug with undefined 'links' If a row object doesn't have a 'links' property, calling 'length' on it will fail. This commit fixes this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 12:10:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 10:10:44 +0000 Subject: [Koha-bugs] [Bug 27170] ILL availability should be able to display arbitrary links to related resources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122112|0 |1 is obsolete| | --- Comment #7 from Andrew Isherwood --- Created attachment 122114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122114&action=edit Bug 27170: Add support for new 'links' property This commit adds support for the new 'links' property that will allow an availability plugin to return an array of links for a result. These links are parsed and appended to the title field of a results record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 12:10:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 10:10:45 +0000 Subject: [Koha-bugs] [Bug 28591] debug passed to get_template_and_user but not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28591 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 12:10:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 10:10:49 +0000 Subject: [Koha-bugs] [Bug 27170] ILL availability should be able to display arbitrary links to related resources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122113|0 |1 is obsolete| | --- Comment #8 from Andrew Isherwood --- Created attachment 122115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122115&action=edit Bug 27170: Fix bug with undefined 'links' If a row object doesn't have a 'links' property, calling 'length' on it will fail. This commit fixes this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 12:10:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 10:10:51 +0000 Subject: [Koha-bugs] [Bug 28591] debug passed to get_template_and_user but not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28591 --- Comment #1 from Jonathan Druart --- Created attachment 122116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122116&action=edit Bug 28591: Don't pass debug to get_template_and_user There is a "debug" parameter we are passing from the controller scripts to C4::Auth::get_template_and_user, but it's not actually used! Test plan: Confirm the assumption Review the changes from this patch Generated with: perl -p -i -e 's#\s*debug\s*=\>\s*(0|1),?\s*##gms' **/*.pl git checkout misc/devel/update_dbix_class_files.pl # Wrong catch + Manual fix in acqui/neworderempty.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 12:10:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 10:10:53 +0000 Subject: [Koha-bugs] [Bug 27170] ILL availability should be able to display arbitrary links to related resources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 --- Comment #9 from Andrew Isherwood --- Created attachment 122117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122117&action=edit Bug 27170: Fix bug fix This commit fixes the incorrect bug fix from the previous commit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 12:11:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 10:11:22 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 12:11:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 10:11:27 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #5 from Jonathan Druart --- Created attachment 122118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122118&action=edit Bug 28572: Remove C4::Debug We are using Koha::Logger when it makes sense to keep the info, otherwise we simply remove it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 12:11:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 10:11:42 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 12:23:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 10:23:38 +0000 Subject: [Koha-bugs] [Bug 28586] Cannot resolve a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 --- Comment #6 from David Nind --- Testing notes (koha-testing-docker): - To reproduce the issue: . Set a value for ClaimReturnedLostValue, for example: 4 . Check out an item to a patron . Go to the patron's check out page > show check outs . In the 'Return claims' column select 'Claim returned', enter a note and click 'Make claim" . Go to to the Claim(s) tab and select Actions > Resolve > select a resolution reason from the drop down list > Click on 'Resolve claim' . Select a reason and enter some text - Before the patch is applied the page just hangs and there is the [warn] message (see bug description) in /var/log/koha/kohadev/plack-error.log - After the patch is applied (and browser cache cleared) the browser no longer hangs and there is no warning message in the log -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 12:36:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 10:36:29 +0000 Subject: [Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561 --- Comment #7 from Jonathan Druart --- Created attachment 122119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122119&action=edit [ALTERNATIVE PATCH] Bug 28561: Remove DBIC warning in opac-shelves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 12:37:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 10:37:22 +0000 Subject: [Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561 --- Comment #8 from Jonathan Druart --- We don't actually need to prefetch as we are only using the biblionumber. Using join and distinct seems to remove the warning and produce the same results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 12:39:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 10:39:20 +0000 Subject: [Koha-bugs] [Bug 28482] Floating point math prevents items from being returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28482 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 12:40:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 10:40:01 +0000 Subject: [Koha-bugs] [Bug 28482] Floating point math prevents items from being returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28482 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable --- Comment #12 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 12:45:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 10:45:36 +0000 Subject: [Koha-bugs] [Bug 28496] Club holds form broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28496 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.01 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #6 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 13:08:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 11:08:53 +0000 Subject: [Koha-bugs] [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #28 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 13:10:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 11:10:18 +0000 Subject: [Koha-bugs] [Bug 28204] Table highlighting is broken at the cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.01 released in| | --- Comment #10 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 13:13:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 11:13:10 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #55 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 13:14:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 11:14:36 +0000 Subject: [Koha-bugs] [Bug 28382] 'Reserve' should be passed through as transfer reason appropriately in branchtransfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.01 released in| | --- Comment #9 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 13:32:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 11:32:10 +0000 Subject: [Koha-bugs] [Bug 28592] New: ISE after paying through opac payment plugin Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28592 Bug ID: 28592 Summary: ISE after paying through opac payment plugin Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org After upgrading to 20.11.06, we have a problem with using the koha-plugin-dibs-payments plugin for online payments: https://github.com/Libriotech/koha-plugin-dibs-payments After authenticating with the remote service the user is redirected back to /cgi-bin/koha/opac-account-pay-return.pl However, this page presents a login form, and the user is forced to log in. It looks like this happens because the value of the CGISESSID cookie is changed somewhere along the way. Or does it change because the login screen is presented? Not sure of what is cause and what is effect here. After logging in, the user is redirected (with a 303 status) to the same URL, but this time all the parameters that were POSTed the first time around are now included in the URL as one kind of weird GET parameter (note the semicolons between parameters): ?orderid=123;payment_method=Koha%3A%3APlugin%3A%3ACom%3A%3ABibLibre%3A%3ADIBSPayments;transact=123;authkey=abc etc The payment is recorded in the accountlines table, but koha_plugin_com_biblibre_dibspayments_dibs_transactions.accountline_id is left empty. As far as I can tell, checkauth is only used in two places in the opac, opac-account-pay-return.pl and opac-ratings.pl: $ sudo grep -rn "checkauth" /usr/share/koha/opac/cgi-bin/opac/opac-* /usr/share/koha/opac/cgi-bin/opac/opac-account-pay-return.pl:29:my ( $userid, $cookie, $sessionID, $flags ) = checkauth( $cgi, 0, {}, 'opac' ); /usr/share/koha/opac/cgi-bin/opac/opac-messaging.pl:24:use C4::Auth; # checkauth, getborrowernumber. /usr/share/koha/opac/cgi-bin/opac/opac-passwd.pl:25:use C4::Auth; # checkauth, getborrowernumber. /usr/share/koha/opac/cgi-bin/opac/opac-privacy.pl:22:use C4::Auth; # checkauth, getborrowernumber. /usr/share/koha/opac/cgi-bin/opac/opac-ratings.pl:40:my ($userid, $cookie, $sessionID) = checkauth( $query, 0, {}, 'opac' ); /usr/share/koha/opac/cgi-bin/opac/opac-reserve.pl:24:use C4::Auth; # checkauth, getborrowernumber. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 13:35:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 11:35:54 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #83 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 13:50:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 11:50:00 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 13:50:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 11:50:03 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122093|0 |1 is obsolete| | --- Comment #17 from Andrew Fuerste-Henry --- Created attachment 122120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122120&action=edit Bug 28271: Add the ability to set a new lost status when a claim is resolved When a claim is resolved the librarian should be able to edit the lost status of the item. It is also letting a way out when BlockReturnOfLostItems is set (the lost status is stuck on ClaimReturnedLostValue as we remove the option to edit itemlost on the item edit form). Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 13:50:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 11:50:07 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122094|0 |1 is obsolete| | --- Comment #18 from Andrew Fuerste-Henry --- Created attachment 122121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122121&action=edit Bug 28271: Adjust API spec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 13:50:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 11:50:11 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122095|0 |1 is obsolete| | --- Comment #19 from Andrew Fuerste-Henry --- Created attachment 122122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122122&action=edit Bug 28271: Preselect the current item lost value Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 13:50:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 11:50:15 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122096|0 |1 is obsolete| | --- Comment #20 from Andrew Fuerste-Henry --- Created attachment 122123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122123&action=edit Bug 28271: Add (current status) Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 13:51:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 11:51:17 +0000 Subject: [Koha-bugs] [Bug 28586] Cannot resolve a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122110|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry --- Created attachment 122124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122124&action=edit Bug 28586: Pass the right parameter to resolve claim Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 13:51:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 11:51:21 +0000 Subject: [Koha-bugs] [Bug 28586] Cannot resolve a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122111|0 |1 is obsolete| | --- Comment #8 from Andrew Fuerste-Henry --- Created attachment 122125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122125&action=edit Bug 28586: (follow-up) updated_by should be set This patch makes the route set the 'updated_by' attribute as well, when resolving a return claim through the API. Tests are added for this behavior. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/return_claims.t => SUCCESS: Tests pass! updated_by is set correctly! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 13:59:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 11:59:14 +0000 Subject: [Koha-bugs] [Bug 28593] New: Add ability to charge lost fee when applying new lost status when resolving a claim Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28593 Bug ID: 28593 Summary: Add ability to charge lost fee when applying new lost status when resolving a claim Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 28271 Bug 28271 added the ability to apply a new lost status when resolving a claim. We should also add the ability to charge a replacement fee. Many libraries do not charge a replacement fee when a claim is generated. If the item is not found within the time period allowed by library policy, then the item is assumed lost, the claim is resolved, and the item is set to lost. At that point, the library would like to charge the patron. As things stand, there is not a way to generate a lost fee tied to that issue_id. You'd have to either create a manual invoice or return the item, check it back out to the patron, and mark it lost again. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 [Bug 28271] Add the ability to set a new lost status when a claim is resolved -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 13:59:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 11:59:14 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28593 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28593 [Bug 28593] Add ability to charge lost fee when applying new lost status when resolving a claim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 14:02:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 12:02:45 +0000 Subject: [Koha-bugs] [Bug 26316] Add the option to un-lost an item on claim return resolution In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26316 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |andrew at bywatersolutions.com Status|NEW |RESOLVED --- Comment #2 from Andrew Fuerste-Henry --- *** This bug has been marked as a duplicate of bug 28271 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 14:02:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 12:02:45 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #21 from Andrew Fuerste-Henry --- *** Bug 26316 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 14:06:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 12:06:52 +0000 Subject: [Koha-bugs] [Bug 28594] New: Add ability to mark an item as retuned when resolving a claim Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28594 Bug ID: 28594 Summary: Add ability to mark an item as retuned when resolving a claim Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com This is the inverse of bug 27753. While 27753 says we should be able to automatically resolve a claim when checking in an item, we should also be able to automatically mark an item as returned when resolving its claim. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 14:06:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 12:06:52 +0000 Subject: [Koha-bugs] [Bug 27753] Automate resolution of return claim when checking in an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28594 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 14:12:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 12:12:08 +0000 Subject: [Koha-bugs] [Bug 28594] Add ability to mark an item as retuned when resolving a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28594 --- Comment #1 from Andrew Fuerste-Henry --- (and if we do mark is as returned, there will be cases in which the effective return date should be the resolution date and other cases in which the effective return date should be the claim date) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 14:12:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 12:12:32 +0000 Subject: [Koha-bugs] [Bug 28595] New: Add ability to map preselected behavior to claims returned resolution statuses Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28595 Bug ID: 28595 Summary: Add ability to map preselected behavior to claims returned resolution statuses Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 28271, 28593, 28594 When resolving a claim, a library may or may not want to: - mark the item as returned (bug 28594) - apply a new lost status (bug 28271) - apply a new replacement fee (bug 28593) A great next step would be the option to map choices for those three variables to the various claim resolution options. So, for example, if the claim is resolved because the item was found in the stacks, then we want to mark it returned, forgive any fees, and not charge new fees. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 [Bug 28271] Add the ability to set a new lost status when a claim is resolved https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28593 [Bug 28593] Add ability to charge lost fee when applying new lost status when resolving a claim https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28594 [Bug 28594] Add ability to mark an item as retuned when resolving a claim -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 14:12:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 12:12:32 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28595 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28595 [Bug 28595] Add ability to map preselected behavior to claims returned resolution statuses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 14:12:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 12:12:32 +0000 Subject: [Koha-bugs] [Bug 28593] Add ability to charge lost fee when applying new lost status when resolving a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28593 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28595 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28595 [Bug 28595] Add ability to map preselected behavior to claims returned resolution statuses -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 14:12:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 12:12:32 +0000 Subject: [Koha-bugs] [Bug 28594] Add ability to mark an item as retuned when resolving a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28594 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28595 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28595 [Bug 28595] Add ability to map preselected behavior to claims returned resolution statuses -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 14:32:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 12:32:00 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.01 released in| | --- Comment #56 from Kyle M Hall --- Pushed to 20.05.x for 20.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 14:42:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 12:42:58 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | Status|Signed Off |Passed QA --- Comment #22 from Tomás Cohen Arazi --- 1+1 = 2, this is PQA :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 14:43:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 12:43:33 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #14 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 14:44:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 12:44:01 +0000 Subject: [Koha-bugs] [Bug 28538] Regression - Date of birth entered without correct format causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.01 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #6 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 14:45:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 12:45:55 +0000 Subject: [Koha-bugs] [Bug 28586] Cannot resolve a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com QA Contact| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 14:46:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 12:46:54 +0000 Subject: [Koha-bugs] [Bug 28586] Cannot resolve a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|nick at bywatersolutions.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 14:50:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 12:50:06 +0000 Subject: [Koha-bugs] [Bug 27931] Add GET /items/:item_id/pickup_locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27931 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.01 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #9 from Kyle M Hall --- Additional REST API with no breaking changes Pushed to 20.05.x for 20.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 14:50:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 12:50:40 +0000 Subject: [Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 14:50:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 12:50:44 +0000 Subject: [Koha-bugs] [Bug 28586] Cannot resolve a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 14:50:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 12:50:47 +0000 Subject: [Koha-bugs] [Bug 28586] Cannot resolve a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122124|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 122126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122126&action=edit Bug 28586: Pass the right parameter to resolve claim Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 14:50:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 12:50:52 +0000 Subject: [Koha-bugs] [Bug 28586] Cannot resolve a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122125|0 |1 is obsolete| | --- Comment #10 from Nick Clemens --- Created attachment 122127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122127&action=edit Bug 28586: (follow-up) updated_by should be set This patch makes the route set the 'updated_by' attribute as well, when resolving a return claim through the API. Tests are added for this behavior. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/return_claims.t => SUCCESS: Tests pass! updated_by is set correctly! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 14:53:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 12:53:33 +0000 Subject: [Koha-bugs] [Bug 27931] Add GET /items/:item_id/pickup_locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27931 --- Comment #10 from Tomás Cohen Arazi --- (In reply to Kyle M Hall from comment #9) > Additional REST API with no breaking changes > > Pushed to 20.05.x for 20.05.01 \o/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:02:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:02:19 +0000 Subject: [Koha-bugs] [Bug 28569] In opac-suggestions.pl preselect user library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:02:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:02:47 +0000 Subject: [Koha-bugs] [Bug 28569] In opac-suggestions.pl preselect user library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:02:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:02:50 +0000 Subject: [Koha-bugs] [Bug 28569] In opac-suggestions.pl preselect user library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122032|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 122128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122128&action=edit Bug 28569: In opac-suggestions.pl preselect user library In OPAC new purchase suggestion opac-suggestions.pl for library combobox : actually first value is selected, user library should be selected. Test plan : 1) Create a new library named 'ZZZ top' 2) Set this library on a user U1 2) Loggin at OPAC with user U1 3) Create a new suggestion => Check library 'ZZZ top' is preselected Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:04:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:04:51 +0000 Subject: [Koha-bugs] [Bug 28586] Cannot resolve a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122126|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 122129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122129&action=edit Bug 28586: Pass the right parameter to resolve claim Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:04:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:04:55 +0000 Subject: [Koha-bugs] [Bug 28586] Cannot resolve a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122127|0 |1 is obsolete| | --- Comment #12 from Nick Clemens --- Created attachment 122130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122130&action=edit Bug 28586: (follow-up) updated_by should be set This patch makes the route set the 'updated_by' attribute as well, when resolving a return claim through the API. Tests are added for this behavior. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/return_claims.t => SUCCESS: Tests pass! updated_by is set correctly! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:05:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:05:54 +0000 Subject: [Koha-bugs] [Bug 28596] New: i am not able to login in Staff interface of ByWater Solutions (USA) it shows Invalid user name and password since morning today Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28596 Bug ID: 28596 Summary: i am not able to login in Staff interface of ByWater Solutions (USA) it shows Invalid user name and password since morning today Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: Windows Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: yogiram34 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 122131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122131&action=edit Login page shows Invalid user name and password since morning today. I am student trying demo version of koha MARC 21 version 20.05 by ByWater Solutions (USA). i am not able to login in Staff interface of ByWater Solutions (USA) it shows Invalid user name and password since morning today. I am student trying demo version of koha MARC 21 version 20.05 by ByWater Solutions (USA). I practice half of the services in this koha demo. Please provide me solution of invalid user name and password issue. Thanks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:09:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:09:21 +0000 Subject: [Koha-bugs] [Bug 28597] New: Opac suggestions do not display news for logged in branch Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 Bug ID: 28597 Summary: Opac suggestions do not display news for logged in branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The parameter 'branchcode' is never set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:09:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:09:57 +0000 Subject: [Koha-bugs] [Bug 28596] i am not able to login in Staff interface of ByWater Solutions (USA) it shows Invalid user name and password since morning today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28596 YOGI changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yogiram34 at gmail.com URL| |https://intranet.bywatersol | |utions.com/cgi-bin/koha/mai | |npage.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:11:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:11:15 +0000 Subject: [Koha-bugs] [Bug 28598] New: Changing date or time format on a production server will NOT create duplicate fines and we should remove the syspref warnings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28598 Bug ID: 28598 Summary: Changing date or time format on a production server will NOT create duplicate fines and we should remove the syspref warnings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 13104 Both DateFormat and TimeFormat say they will create duplicate fines if changed on a production system. But we explicitly fixed that in bug 13104. We should remove those warnings. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 [Bug 13104] Changing date or time format on a production server will create duplicate fines! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:11:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:11:15 +0000 Subject: [Koha-bugs] [Bug 13104] Changing date or time format on a production server will create duplicate fines! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28598 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28598 [Bug 28598] Changing date or time format on a production server will NOT create duplicate fines and we should remove the syspref warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:11:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:11:47 +0000 Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122053|0 |1 is obsolete| | --- Comment #11 from Agustín Moyano --- Created attachment 122132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122132&action=edit Bug 27948: Add disclaimer to article request If ArticleRequestsDisclaimerText news is set, a disclaimer text will appear before an article request can be made To test: 1. apply patches 2. enable ArticleRequest syspref 3. in OPAC place an article request for a patron CHECK => No disclaimer text should appear before placing article request 4. add a text in ArticleRequestsDisclaimerText news 5. repeat step 3 SUCCESS => A disclaimer text is shown before you can place an article request Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:12:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:12:22 +0000 Subject: [Koha-bugs] [Bug 28597] Opac suggestions do not display news for logged in branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:12:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:12:25 +0000 Subject: [Koha-bugs] [Bug 28597] Opac suggestions do not display news for logged in branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 --- Comment #1 from Nick Clemens --- Created attachment 122133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122133&action=edit Bug 28597: Fetch the logged in branchcode for OpacSuggestioninstructions To test: 1 - Set two news items with location 'OpacSuggestioninstructions' 2 - One should be for all libraries 3 - One should be for a specific library 4 - Sign in to opac with user from the specific library 5 - Add a suggestion 6 - The instructions only show the all libraries item 7 - Apply patch 8 - Reload 9 - All libraries and specific library items are shown 10 - Allow anonymous suggestions: AnonSuggestions - Allow 11 - Sign out of opac 12 - Add a suggestion 13 - Only all librares news is visible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:13:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:13:29 +0000 Subject: [Koha-bugs] [Bug 28597] Opac suggestions do not display news for logged in branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:14:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:14:39 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:15:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:15:35 +0000 Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:15:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:15:40 +0000 Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122132|0 |1 is obsolete| | --- Comment #12 from Agustín Moyano --- Created attachment 122134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122134&action=edit Bug 27948: Add disclaimer to article request If ArticleRequestsDisclaimerText news is set, a disclaimer text will appear before an article request can be made To test: 1. apply patches 2. enable ArticleRequest syspref 3. in OPAC place an article request for a patron CHECK => No disclaimer text should appear before placing article request 4. add a text in ArticleRequestsDisclaimerText news 5. repeat step 3 SUCCESS => A disclaimer text is shown before you can place an article request Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:17:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:17:42 +0000 Subject: [Koha-bugs] [Bug 28598] Changing date or time format on a production server will NOT create duplicate fines and we should remove the syspref warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28598 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:17:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:17:45 +0000 Subject: [Koha-bugs] [Bug 28598] Changing date or time format on a production server will NOT create duplicate fines and we should remove the syspref warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28598 --- Comment #1 from Andrew Fuerste-Henry --- Created attachment 122135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122135&action=edit Bug 28598: Update DateFormat and TimeFormat descriptions to remove warnings To test, confirm that the warnings are present without the patch and gone with it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:17:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:17:57 +0000 Subject: [Koha-bugs] [Bug 27990] Replace obsolete title-string sorting: Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27990 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:19:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:19:03 +0000 Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #13 from Agustín Moyano --- (In reply to Marcel de Rooy from comment #9) > Could not compile /usr/share/koha/opac/opac-request-article.pl: Bareword > "action" not allowed while "strict subs" in use at > /usr/share/koha/opac/opac-request-article.pl line 49. > > How did you test that, Agustin? :) Sorry, moved the if from the end of line to a proper if statement and forgot $ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:21:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:21:21 +0000 Subject: [Koha-bugs] [Bug 27990] Replace obsolete title-string sorting: Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27990 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:31:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:31:32 +0000 Subject: [Koha-bugs] [Bug 28599] New: Add ability to void purchase in point of sale Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28599 Bug ID: 28599 Summary: Add ability to void purchase in point of sale Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Depends on: 23354 If one enters a purchase incorrectly in the point of sale module, one can refund the payments on that purchase in order to correct Koha's understanding of the amount of money the library has taken in. However, those refunds don't do anything to correct the record of how many items were sold. That means that accurate reporting on number of items sold needs to be verifying that none of the payments tied to the purchase have been refunded. It'd be better to be able to just void the whole sale, setting the amounts on the original purchase(s) and payments all to zero, zeroing out the note in the purchase (since we're using that for the quantity of the sale), and giving them a VOID status. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 [Bug 23354] Add a 'Point of sale' screen to allow anonymous payments -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:31:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:31:32 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Point of sale' screen to allow anonymous payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28599 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28599 [Bug 28599] Add ability to void purchase in point of sale -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:33:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:33:37 +0000 Subject: [Koha-bugs] [Bug 28596] i am not able to login in Staff interface of ByWater Solutions (USA) it shows Invalid user name and password since morning today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28596 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID CC| |andrew at bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- I'm closing this, as it's not a koha bug, but we at bywater will give our demo site a look. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:39:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:39:52 +0000 Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #14 from Agustín Moyano --- (In reply to Marcel de Rooy from comment #10) > Why not use a construction like: > > [% PROCESS koha_news_block news => KohaNews.get({ location => > 'ArticleRequestsDisclaimerText', lang => lang, library => branchcode, > blocktitle => 0 }) %] > > This is used in other places too to insert text block from news. Basically that construction does not allow for you to have a default language. If you add a disclaimer in english, but you do not have it in other languages, users with english lang will see the disclaimer text, but other users will not. With the construction I coded, it first checks for a disclaimer text in the language of the template, and if not found, uses english as default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:43:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:43:18 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:43:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:43:22 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122073|0 |1 is obsolete| | --- Comment #23 from Nick Clemens --- Created attachment 122136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122136&action=edit Bug 28581: Add 'from_email_address' method and use in Koha::Patron This patch adds a new 'from_email_address' method to Koha::Library to return the appropriate email address to use as the 'from' field for email notices from the library. We then update Koha::Patron->queue_notice to use this new method instead of the incorrect inbound_email_address. I also update the POD for inbound_email_address to clarify it's use case. Test plan Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:43:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:43:25 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122074|0 |1 is obsolete| | --- Comment #24 from Nick Clemens --- Created attachment 122137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122137&action=edit Bug 28581: Use from_email_address in the codebase Adding only a few (trivial) cases now. Changes in C4::Letters are not trivial after all.. We now add the KohaAdminEmail fallback implicitly when the from address was still empty. The extra check makes us not rely on a do or die action in Email::Stuffer. Test plan: Run password recovery or membership expiry cron. Check sender address. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:43:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:43:28 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122075|0 |1 is obsolete| | --- Comment #25 from Nick Clemens --- Created attachment 122138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122138&action=edit Bug 28581: (QA follow-up) Prevent code failure This patch prevents a fatal error when both $params->{from} and $params->{borrowernumber} are undefined. We fallback to KohaAdminEmailAddress before finally falling through to setting a failure status for the message if that last fallback is not found. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:43:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:43:33 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122080|0 |1 is obsolete| | --- Comment #26 from Nick Clemens --- Created attachment 122139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122139&action=edit Bug 28581: Use 'from_email_address' where appropriate This patch replaces a few more trivial cases where we were using library->branchemail with a fallback to KohaAdminEmail to just use the new library->from_email_address method directly instead. There were also a couple of cases where we were passing borrowernumber and the patrons library from address too.. this is unneccesary as the code in _send_email_massage will already default to patron library from address if we do not pass an override. Signed-off-by: Marcel de Rooy Added a semicolon. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:43:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:43:36 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122081|0 |1 is obsolete| | --- Comment #27 from Nick Clemens --- Created attachment 122140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122140&action=edit Bug 28581: Enhance POD for EnqueueLetter Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:53:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:53:37 +0000 Subject: [Koha-bugs] [Bug 28338] Validate item holdability and pickup location separately In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28338 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.01 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #17 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 15:54:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 13:54:30 +0000 Subject: [Koha-bugs] [Bug 28350] Sort by "circ note" is broken on the patron search result view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28350 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.01 released in| | --- Comment #7 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:04:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:04:28 +0000 Subject: [Koha-bugs] [Bug 27519] Normalize Show/Don't show vs Display/Don't display in system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com Assignee|koha-bugs at lists.koha-commun |philippe.blouin at inlibro.com |ity.org | --- Comment #1 from Blou --- No comment? We'll use display/not display accross the board. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:16:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:16:47 +0000 Subject: [Koha-bugs] [Bug 28600] New: Variable "$patron" is not available Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600 Bug ID: 28600 Summary: Variable "$patron" is not available Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: OPAC Assignee: tomascohen at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 18989 In the logs: Variable "$patron" is not available at /kohadevbox/koha/opac/opac-detail.pl line 282 Coming from commit 8de3d9a95f2f3a01b5ed309805d81c698ac8e550 Bug 18989: (QA follow-up) Make controllers use Koha::Biblio->hidden_in_opac - 'category' => $borcat + 'category' => ($patron) ? $patron->categorycode : q{} It's in a sub, and patron is declared outside. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 [Bug 18989] Allow displaying biblios with all items hidden by OpacHiddenItems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:16:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:16:47 +0000 Subject: [Koha-bugs] [Bug 18989] Allow displaying biblios with all items hidden by OpacHiddenItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600 [Bug 28600] Variable "$patron" is not available -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:17:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:17:02 +0000 Subject: [Koha-bugs] [Bug 28600] Variable "$patron" is not available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:18:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:18:10 +0000 Subject: [Koha-bugs] [Bug 12561] Remove non-XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Omnibus: Deprecate non-XSLT |Remove non-XSLT views |detail and result views | Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:18:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:18:42 +0000 Subject: [Koha-bugs] [Bug 11426] Make HighlightOwnItemsOnOPAC work with XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11426 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #14 from Jonathan Druart --- This non-XSLT feature will be removed on bug 12561. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:18:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:18:43 +0000 Subject: [Koha-bugs] [Bug 12561] Remove non-XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Bug 12561 depends on bug 11426, which changed state. Bug 11426 Summary: Make HighlightOwnItemsOnOPAC work with XSLT https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11426 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:20:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:20:24 +0000 Subject: [Koha-bugs] [Bug 28349] Date sorting incorrect reports in en-GB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28349 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc at interleaf.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:22:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:22:32 +0000 Subject: [Koha-bugs] [Bug 12561] Remove non-XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:22:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:22:37 +0000 Subject: [Koha-bugs] [Bug 12561] Remove non-XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 --- Comment #7 from Jonathan Druart --- Created attachment 122141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122141&action=edit Bug 12561: Remove HighlightOwnItemsOnOPAC and HighlightOwnItemsOnOPACWhich This is the only remaining non-XSLT only feature. We should remove the non-XSLT views that have been deprecated for a while now, and remove this feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:22:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:22:42 +0000 Subject: [Koha-bugs] [Bug 12561] Remove non-XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 --- Comment #8 from Jonathan Druart --- Created attachment 122142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122142&action=edit Bug 12561: Remove non-XSLT views -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:22:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:22:46 +0000 Subject: [Koha-bugs] [Bug 12561] Remove non-XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 --- Comment #9 from Jonathan Druart --- Created attachment 122143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122143&action=edit Bug 12561: Change prototype of XSLTParse4Display Use a hash for better readability and reusability. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:22:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:22:51 +0000 Subject: [Koha-bugs] [Bug 12561] Remove non-XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 --- Comment #10 from Jonathan Druart --- Created attachment 122144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122144&action=edit Bug 12561: Add warning on about page If a default xslt file has been removed or if the one filled in one of the syspref does not exist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:23:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:23:33 +0000 Subject: [Koha-bugs] [Bug 12561] Remove non-XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:25:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:25:10 +0000 Subject: [Koha-bugs] [Bug 12561] Remove non-XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority Severity|normal |enhancement --- Comment #11 from Jonathan Druart --- After 7 years, we are going to remove them, yeah \o/ Test plan: Play with the different sysprefs and confirm that: - empty or "default" means the same => the default xslt file is used - Have a look at the about page, if you are pointing to a file that has been removed you should see a warning there QA will take care of catching inconsistencies in the code, and eventually code that was used for the non-XSLT views only and must be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:27:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:27:43 +0000 Subject: [Koha-bugs] [Bug 28570] bor_issues_top.pl using a /tmp file to log debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28570 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122038|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 122145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122145&action=edit Bug 28570: Remove log to /tmp file from bor_issues_top.pl This is unusual and must not be done. Removing it. Test plan: Use the "Home > Reports > Patrons with the most checkouts" report and confirm that it is working correctly after you applied this patch Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:28:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:28:03 +0000 Subject: [Koha-bugs] [Bug 28591] debug passed to get_template_and_user but not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28591 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122116|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 122146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122146&action=edit Bug 28591: Don't pass debug to get_template_and_user There is a "debug" parameter we are passing from the controller scripts to C4::Auth::get_template_and_user, but it's not actually used! Test plan: Confirm the assumption Review the changes from this patch Generated with: perl -p -i -e 's#\s*debug\s*=\>\s*(0|1),?\s*##gms' **/*.pl git checkout misc/devel/update_dbix_class_files.pl # Wrong catch + Manual fix in acqui/neworderempty.pl Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:28:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:28:24 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122118|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 122147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122147&action=edit Bug 28572: Remove C4::Debug We are using Koha::Logger when it makes sense to keep the info, otherwise we simply remove it Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:28:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:28:52 +0000 Subject: [Koha-bugs] [Bug 28570] bor_issues_top.pl using a /tmp file to log debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28570 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- Clear improvement, no regressions found.. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:29:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:29:28 +0000 Subject: [Koha-bugs] [Bug 28591] debug passed to get_template_and_user but not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28591 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Obvious clarity improvement.. straight PQA from me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:29:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:29:34 +0000 Subject: [Koha-bugs] [Bug 28591] debug passed to get_template_and_user but not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28591 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:29:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:29:54 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Martin Renvoize --- Great work.. signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:35:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:35:21 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #8 from Martin Renvoize --- No regressions found.. I went through the patches inspecting what had been removed/replaced and I agree with all the decisions Jonathan made.. be great to get a second opinion from QA, but I don't think there's anything controversial here.. it'll be great to see this go and hopefully it'll encourage a little more use of Koha::Logger by hiding dropping this alternative.. would be great to see more of the bare warns updated too at some point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:36:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:36:44 +0000 Subject: [Koha-bugs] [Bug 28569] In opac-suggestions.pl preselect user library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #6 from Jonathan Druart --- (In reply to Fridolin Somers from comment #4) > (In reply to Jonathan Druart from comment #2) > > Please remember: > > - The title of the bug report describes shortly what the *problem is* > > - The title of the patch describes shortly what the *patch does* > > > > https://wiki.koha-community.org/wiki/Commit_messages > > Arf indeed, i'll try to do better Do it please. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:42:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:42:20 +0000 Subject: [Koha-bugs] [Bug 28589] Move C4 and Koha to lib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 --- Comment #5 from Martin Renvoize --- I'd love to see this.. it would certainly move us towards being a bit more 'normal' in the perl world.. might mean we can start adopting other more widely supported perl solutions for other things too.. not sure what, but there's loads of perl tooling out there that expects to find things in '/lib' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:44:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:44:42 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #70 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:46:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:46:40 +0000 Subject: [Koha-bugs] [Bug 27903] Script to move atomic updates to updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27903 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- Very cool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:47:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:47:24 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.01 released in| | --- Comment #47 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:49:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:49:42 +0000 Subject: [Koha-bugs] [Bug 28467] Add wording to TrackLastPatronActivity description to tell users that it records SIP authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28467 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.01 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:51:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:51:42 +0000 Subject: [Koha-bugs] [Bug 28383] Log in via the itemsearch URL leads to Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28383 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:52:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:52:57 +0000 Subject: [Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.01 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #7 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:54:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:54:30 +0000 Subject: [Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 --- Comment #8 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 16:56:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 14:56:34 +0000 Subject: [Koha-bugs] [Bug 28488] Javascript error in self-checkout (__ is not defined) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.01 released in| | --- Comment #9 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:01:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:01:50 +0000 Subject: [Koha-bugs] [Bug 28127] POS register details tables should have a transaction date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28127 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #6 from Andrew Fuerste-Henry --- I'd love to see this backported to 20.05 if possible. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:18:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:18:08 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #16 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:19:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:19:30 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:19:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:19:34 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121960|0 |1 is obsolete| | --- Comment #93 from Nick Clemens --- Created attachment 122148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122148&action=edit Bug 22435: Update CREATE offset types Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:19:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:19:38 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121961|0 |1 is obsolete| | --- Comment #94 from Nick Clemens --- Created attachment 122149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122149&action=edit Bug 22435: Use 'CREATE' offset type in Koha::Account This patch updates the Koha::Account methods for adding debits and credits to use the 'CREATE' offset type for the creation record. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:19:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:19:43 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121962|0 |1 is obsolete| | --- Comment #95 from Nick Clemens --- Created attachment 122150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122150&action=edit Bug 22435: Use 'CREATE' offset type in Koha::Account::Line This patch updates the Koha::Account::Line methods that result in new account lines to use the 'CREATE' offset type for the creation record. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:19:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:19:48 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121963|0 |1 is obsolete| | --- Comment #96 from Nick Clemens --- Created attachment 122151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122151&action=edit Bug 22435: Add 'APPLY' to account_offset_types Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:19:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:19:53 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121964|0 |1 is obsolete| | --- Comment #97 from Nick Clemens --- Created attachment 122152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122152&action=edit Bug 22435: ->apply() should always use 'APPLY' for offset_type Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:19:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:19:58 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121965|0 |1 is obsolete| | --- Comment #98 from Nick Clemens --- Created attachment 122153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122153&action=edit Bug 22435: Update unit tests This patch updates the unit tests to reflect the changes we have made to offset types. We do two things: 1) Clean up calls to 'apply' to drop passing offset_type 2) Update test code to look for APPLY and CREATE instead of specific offset types. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:20:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:20:03 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121966|0 |1 is obsolete| | --- Comment #99 from Nick Clemens --- Created attachment 122154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122154&action=edit Bug 22435: Fix CREATE offset amounts Updateing the tests highlighted a mistake in the original code.. the offsets for the cancel and reduce creation lines were incorrectly signed. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:20:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:20:08 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121967|0 |1 is obsolete| | --- Comment #100 from Nick Clemens --- Created attachment 122155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122155&action=edit Bug 22435: Fix _set_found_trigger The _set_found_trigger utilised the 'Writeoff' offset type to distinguish between the application of a writeoff and any other form of offset application. This patch updates the trigger to use the full link through from offset to account credit line to get the credit type being offset. Test plan 1/ Run t/db_dependent/Koha/Items.t and prove it fails before the patch, but passes after applying this patch. 2/ Run t/db_dependent/Koha/Account/Offsets.t and prove it passes both before and after applying this patch. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:20:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:20:13 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121968|0 |1 is obsolete| | --- Comment #101 from Nick Clemens --- Created attachment 122156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122156&action=edit Bug 22435: Update for bug 27049 Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:20:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:20:19 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121969|0 |1 is obsolete| | --- Comment #102 from Nick Clemens --- Created attachment 122157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122157&action=edit Bug 22435: Update accountline-details page to show all history The accountline-details page took a simplistic approach to displaying the history of an accountline. This patch drops the now defunct offset_type_description template block from it's respective include files, and then updates the accountline-details teplate and controller to show a full history of what's happend to the accountlines passed, including creation, increment/decrement, payments, cancellation and voids. Test plan 1/ Create some credits and debits and apply them to each other in various combinations 2/ View the 'Details' page for some of the debit/credits 3/ Compare before patch and after for the Details page. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:20:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:20:23 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121970|0 |1 is obsolete| | --- Comment #103 from Nick Clemens --- Created attachment 122158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122158&action=edit Bug 22435: Improve database update Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:20:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:20:28 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121971|0 |1 is obsolete| | --- Comment #104 from Nick Clemens --- Created attachment 122159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122159&action=edit Bug 22435: Further refinements to account-details table Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:20:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:20:34 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121972|0 |1 is obsolete| | --- Comment #105 from Nick Clemens --- Created attachment 122160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122160&action=edit Bug 22435: Alternative Three - Account Details Another alternative to try, feedback welcome. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:20:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:20:39 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 --- Comment #106 from Nick Clemens --- Created attachment 122161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122161&action=edit Bug 22435: (QA follow-up) Fix test file and adjust test Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:22:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:22:38 +0000 Subject: [Koha-bugs] [Bug 28421] When refunding lost fees we should not include voided payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28421 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:22:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:22:42 +0000 Subject: [Koha-bugs] [Bug 28421] When refunding lost fees we should not include voided payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28421 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122017|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 122162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122162&action=edit Bug 28421: Unit Tests This patch adds test test cases for both a Voided Payment and Voided Writeoff. These cases need special handling in the refund process. Test plan 0/ Don't apply 1/ Run t/db_dependent/Koha/Items.t 2/ Prior to this commit the test should pass 3/ Apply this commit but not the dependency(bug 22435) 3/ The test should fail 4/ Bug 22435 should make the test pass again. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:25:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:25:04 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #107 from Nick Clemens --- I ran through all I could think of, things look good after these patches and tests pass, code reads well, this is a good early candidate to push for further testing Nice work, Martin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:32:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:32:13 +0000 Subject: [Koha-bugs] [Bug 28570] bor_issues_top.pl using a /tmp file to log debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28570 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:32:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:32:16 +0000 Subject: [Koha-bugs] [Bug 28570] bor_issues_top.pl using a /tmp file to log debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28570 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122145|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 122163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122163&action=edit Bug 28570: Remove log to /tmp file from bor_issues_top.pl This is unusual and must not be done. Removing it. Test plan: Use the "Home > Reports > Patrons with the most checkouts" report and confirm that it is working correctly after you applied this patch Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:38:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:38:15 +0000 Subject: [Koha-bugs] [Bug 28545] Noisy uninitialized warn at opac-MARCdetail.pl line 313 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28545 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:38:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:38:18 +0000 Subject: [Koha-bugs] [Bug 28545] Noisy uninitialized warn at opac-MARCdetail.pl line 313 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28545 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121894|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 122164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122164&action=edit Bug 28545: Noisy uninitialized warn at opac-MARCdetail.pl line 313 Test plan: You do not even need a NULL value in a authorised value controlled item field, a zero in damaged or withdrawn is enough to trigger the warnings. (Because only the 1 is linked to an authvalue.) Check your plack-opac-error.log before and after applying this change. Signed-off-by: Marcel de Rooy Without the patch I had at least four warnings per item: withdrawn, lost, damaged and notforloan. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:40:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:40:17 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.01 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #24 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:45:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:45:17 +0000 Subject: [Koha-bugs] [Bug 28601] New: Wrong breadcrumb for 'Home' on circulation-home Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601 Bug ID: 28601 Summary: Wrong breadcrumb for 'Home' on circulation-home Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com To recreate: 1 - Got to 'Circulation' 2 - Click 'Home' in breadcrumbs 3 - You are still in circulation home -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:47:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:47:06 +0000 Subject: [Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:47:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:47:09 +0000 Subject: [Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601 --- Comment #1 from Nick Clemens --- Created attachment 122165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122165&action=edit Bug 28601: Fix 'Home' breadcrumd on circulation-home.pl To test: 1 - Got to 'Circulation' 2 - Click 'Home' in breadcrumbs 3 - You are still in circulation home 4 - Apply patch 5 - reload page 6 - Click 'Home' 7 - Success! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:47:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:47:31 +0000 Subject: [Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 17:50:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 15:50:27 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #63 from Martin Renvoize --- This has moved a bit.. looking good. I wonder about the --force option we've introduced a little.. might be good to have a 'force_once' or something so allow the user to pick to ignore the first error but have subsequent errors still catch. Generally, I think I'm happy here.. I do think Julians $report way of doing multi-line description blocks is cleaner looking somehow.. and I can see his point about passing dbh rather than suggesting we rely on C4::Context.. it is somewhat future-proofing (and it's a familiar concept to me to pass dbh around this way as it's how DBIx::Class::DeploymentHandler does it (though in that case.. they often also pass a dbic schema for the before and after upgrade step so you can use dbic during upgrades.. takes some getting used to, but is pretty cool) Also, bug 27880 looks really interesting too.. I hope we could quickly work through that after this.. feels like they lend themselves to being pushed in quick sucession. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 18:12:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 16:12:31 +0000 Subject: [Koha-bugs] [Bug 28127] POS register details tables should have a transaction date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28127 --- Comment #7 from Lucas Gass --- Created attachment 122166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122166&action=edit Bug 28127: [20.05.x] Add transaction timestamp to register details tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 18:22:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 16:22:27 +0000 Subject: [Koha-bugs] [Bug 27170] ILL availability should be able to display arbitrary links to related resources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122114|0 |1 is obsolete| | --- Comment #10 from Andrew Isherwood --- Created attachment 122167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122167&action=edit Bug 27170: Add support for new 'links' property This commit adds support for the new 'links' property that will allow an availability plugin to return an array of links for a result. These links are parsed and appended to the title field of a results record. Signed-off-by: Holly Cooper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 18:22:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 16:22:30 +0000 Subject: [Koha-bugs] [Bug 27170] ILL availability should be able to display arbitrary links to related resources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122115|0 |1 is obsolete| | --- Comment #11 from Andrew Isherwood --- Created attachment 122168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122168&action=edit Bug 27170: Fix bug with undefined 'links' If a row object doesn't have a 'links' property, calling 'length' on it will fail. This commit fixes this. Signed-off-by: Holly Cooper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 18:22:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 16:22:35 +0000 Subject: [Koha-bugs] [Bug 27170] ILL availability should be able to display arbitrary links to related resources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122117|0 |1 is obsolete| | --- Comment #12 from Andrew Isherwood --- Created attachment 122169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122169&action=edit Bug 27170: Fix bug fix This commit fixes the incorrect bug fix from the previous commit Signed-off-by: Holly Cooper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 18:22:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 16:22:51 +0000 Subject: [Koha-bugs] [Bug 27170] ILL availability should be able to display arbitrary links to related resources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 19:04:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 17:04:05 +0000 Subject: [Koha-bugs] [Bug 28602] New: Circulate multiple items with one barcode in a bookbag or kit Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28602 Bug ID: 28602 Summary: Circulate multiple items with one barcode in a bookbag or kit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Some libraries group multiple items into one kit or bag. Scanning one barcode for the kit into circulation results in a checkout for each attached item. Items grouped into a kits are not assumed to be on the same bib record. Individual items may or may not also have their own barcodes and could be checked out individually. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 19:47:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 17:47:21 +0000 Subject: [Koha-bugs] [Bug 28586] Cannot resolve a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an issue with release notes| |the 'Returned claims' | |feature (enabled by setting | |a value for | |ClaimReturnedLostValue)- | |resolving returned claims | |now works as expected. | | | |Before this fix, an attempt | |to resolve a claim resulted | |in the page hanging and the | |claim not being able to be | |resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 19:59:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 17:59:58 +0000 Subject: [Koha-bugs] [Bug 26838] Improve styling of checkin message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 20:00:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 18:00:01 +0000 Subject: [Koha-bugs] [Bug 26838] Improve styling of checkin message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121809|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 122170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122170&action=edit Bug 26838: Improve styling of checkin message This patch makes some changes to the style and use of the "problem" class in the staff interface: - Remove the background color - Remove the extra line height Some changes to the template: - Remove the problem class from the checkin message. The checkin message configuration determines whether the dialog is an alert or a message-style dialog. - Add Font Awesome icons to the "problem" messages in patron details and serials collection. This is to help emphasize the message for users who might have difficulty seeing the color difference. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> Item types and configure a checkin message for an item type: Add a message and select "Message" as the checkin message type. - Check in an item with that item type and confirm that you see the checkin message. It should be displayed in a message-style dialog without any additional styling. - Change the item type configuration to use "Alert" as the checkin message type. Confirm that the correct style is shown in this case as well. - Locate a patron with a NULL value in borrowers.password. View the detail page for that patron. - Under the "Library use" heading, the "Password" line should contain a link with the text "Undefined," preceded by a red-colored Font Awesome icon. - In Serials, locate a subscription which is expired. - View the details for the subscription, and then open "serial collection" from the sidebar menu. - On the serial collection page there should be a cell in the subscription summary table showing the message "Subscription expired" preceded by a red-colored Font Awesome icon. Signed-off-by: Salman Ali Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 20:18:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 18:18:11 +0000 Subject: [Koha-bugs] [Bug 28600] Variable "$patron" is not available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600 --- Comment #1 from Tomás Cohen Arazi --- Ha, $borcat (which I replaced with $patron) was defined as (our) -our $borcat= q{}; -if ( C4::Context->preference('OpacHiddenItemsExceptions') ) { - $borcat = $patron ? $patron->categorycode : q{}; -} I guess I overlooked it. Patch coming. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 20:26:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 18:26:02 +0000 Subject: [Koha-bugs] [Bug 28593] Add ability to charge lost fee when applying new lost status when resolving a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28593 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #1 from Tomás Cohen Arazi --- This should be done on top of bug 28588, for sure. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 20:39:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 18:39:14 +0000 Subject: [Koha-bugs] [Bug 28523] Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #2 from David Nind --- I attempted to test this. With MySQL 8 I was able to get this to work following the test plan (starting KTD with ku=my8). However, if I change back to MariaDB (starting KTD with ku) I get a different error message: CGI::Compile::ROOT::kohadevbox_koha_reports_bor_issues_top_2epl::calculate(): DBI Exception: DBD::mysql::st execute failed: 'koha_kohadev.borrowers.surname' isn't in GROUP BY [for Statement "SELECT CONCAT_WS('', borrowers.surname , ",\t", borrowers.firstname), COUNT(*) AS `RANK`, borrowers.borrowernumber AS ID FROM `old_issues` LEFT JOIN borrowers USING(borrowernumber) LEFT JOIN items USING(itemnumber) LEFT JOIN biblioitems USING(biblioitemnumber) WHERE old_issues.borrowernumber IS NOT NULL AND old_issues.issuedate > '2021-06-01' AND old_issues.issuedate < '2021-06-30' AND old_issues.returndate > '2021-06-01' AND old_issues.returndate < '2021-06-30' GROUP BY borrowers.borrowernumber ORDER BY `RANK` DESC LIMIT 5"] at /kohadevbox/koha/reports/bor_issues_top.pl line 70 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 Testing notes (koha-testing-docker): - Start KTD with MySQL 8 (rather than MariaDB): ku-my8 - Turn off strict mode (https://www.linode.com/community/questions/17070/how-can-i-disable-mysql-strict-mode): . access database container: docker exec -it koha_db_1 bash . mysql -uroot -ppassword . SET GLOBAL sql_mode = 'NO_ENGINE_SUBSTITUTION'; . SELECT @@GLOBAL.sql_mode; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 20:50:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 18:50:44 +0000 Subject: [Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 20:59:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 18:59:27 +0000 Subject: [Koha-bugs] [Bug 28600] Variable "$patron" is not available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 122171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122171&action=edit Bug 28600: Resolve variable scope issue This patch fixes a scope issue. Originally, a variable declared as our $borcat was replaced by my $patron This patch makes the method not rely on global variables, but have a parameter for the patron, and thus things are clearer. To test: 1. Open the OPAC detail page for a record => FAIL: The logs show some errors about the $patron variable not available in the scope 2. Apply this patch 3. Repeat 1 => SUCCESS: No errors 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 21:23:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 19:23:48 +0000 Subject: [Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 21:23:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 19:23:52 +0000 Subject: [Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122165|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 122172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122172&action=edit Bug 28601: Fix 'Home' breadcrumd on circulation-home.pl To test: 1 - Got to 'Circulation' 2 - Click 'Home' in breadcrumbs 3 - You are still in circulation home 4 - Apply patch 5 - reload page 6 - Click 'Home' 7 - Success! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 21:27:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 19:27:54 +0000 Subject: [Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This fixes the breadcrumb release notes| |link to the the staff | |interface home page from | |the circulation area - it | |now links correctly to the | |staff interface home page, | |rather than the circulation | |page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 21:29:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 19:29:43 +0000 Subject: [Koha-bugs] [Bug 28571] C4::Auth::_session_log is not used and must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28571 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 21:29:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 19:29:47 +0000 Subject: [Koha-bugs] [Bug 28571] C4::Auth::_session_log is not used and must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28571 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122039|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 122173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122173&action=edit Bug 28571: Remove C4::Auth::_session_log It's not used and must be removed Test plan: % git grep _session_log must not return any result. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 21:37:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 19:37:43 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28593, 28595 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28593 [Bug 28593] Add ability to charge lost fee when applying new lost status when resolving a claim https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28595 [Bug 28595] Add ability to map preselected behavior to claims returned resolution statuses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 21:37:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 19:37:43 +0000 Subject: [Koha-bugs] [Bug 28593] Add ability to charge lost fee when applying new lost status when resolving a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28593 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|28271 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 [Bug 28271] Add the ability to set a new lost status when a claim is resolved -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 21:37:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 19:37:43 +0000 Subject: [Koha-bugs] [Bug 28595] Add ability to map preselected behavior to claims returned resolution statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28595 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|28271 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 [Bug 28271] Add the ability to set a new lost status when a claim is resolved -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 21:38:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 19:38:01 +0000 Subject: [Koha-bugs] [Bug 28603] New: check-url-quick.pl does not encode spaces in urls Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 Bug ID: 28603 Summary: check-url-quick.pl does not encode spaces in urls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz To recreate: 1 - Add an 856$u to a record with: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti&q=street shuffle 2 - perl misc/cronjobs/check-url-quick.pl > test.txt 2>&1 3 - grep shuffle test.txt 4 - 303 http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti&q=street shuffle 596 Connection timed out 'URL' => 'http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti&q=street shuffle' 303 http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti&q=street shuffle 596 Connection timed out -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 21:38:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 19:38:06 +0000 Subject: [Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Blocks| |28593, 28595 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28593 [Bug 28593] Add ability to charge lost fee when applying new lost status when resolving a claim https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28595 [Bug 28595] Add ability to map preselected behavior to claims returned resolution statuses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 21:38:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 19:38:06 +0000 Subject: [Koha-bugs] [Bug 28593] Add ability to charge lost fee when applying new lost status when resolving a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28593 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28588 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 21:38:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 19:38:06 +0000 Subject: [Koha-bugs] [Bug 28595] Add ability to map preselected behavior to claims returned resolution statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28595 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28588 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 21:39:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 19:39:01 +0000 Subject: [Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 122174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122174&action=edit Bug 28588: Unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 21:39:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 19:39:05 +0000 Subject: [Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 122175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122175&action=edit Bug 28588: Add Koha::Checkouts::ReturnClaim->resolve This patch introduces a high-level method for resolving claims. The behavior intends to replace the code in the API controller that is used for resolving a claim. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Checkouts/ReturnClaim.t => SUCCESS: Tests pass 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 21:39:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 19:39:09 +0000 Subject: [Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 122176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122176&action=edit Bug 28588: (follow-up) Make the API use the new method This patch adapts the controller method for resolving a return claim so it uses the Koha::Checkouts::ReturnClaim method instead. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/return_claims.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 21:39:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 19:39:34 +0000 Subject: [Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 21:43:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 19:43:15 +0000 Subject: [Koha-bugs] [Bug 28603] check-url-quick.pl does not encode spaces in urls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 21:43:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 19:43:18 +0000 Subject: [Koha-bugs] [Bug 28603] check-url-quick.pl does not encode spaces in urls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 --- Comment #1 from Nick Clemens --- Created attachment 122177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122177&action=edit Bug 28603: Encode spaces in urls in url checker To test: 1 - Add a url to a record like: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti&q=street%20shuffle 2 - perl misc/cronjobs/check-url-quick.pl -v > test.txt 3 - grep shuffle test.txt 4 - 303 http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti&q=street shuffle 596 Connection timed out 5 - Apply patch 6 - perl misc/cronjobs/check-url-quick.pl -v > test.txt 7 - grep shuffle test.txt 8 - 303 http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti&q=street%20shuffle 200 OK -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 21:43:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 19:43:33 +0000 Subject: [Koha-bugs] [Bug 28603] check-url-quick.pl does not encode spaces in urls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 21:56:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 19:56:14 +0000 Subject: [Koha-bugs] [Bug 28597] Opac suggestions do not display news for logged in branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 21:56:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 19:56:19 +0000 Subject: [Koha-bugs] [Bug 28597] Opac suggestions do not display news for logged in branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122133|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 122178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122178&action=edit Bug 28597: Fetch the logged in branchcode for OpacSuggestioninstructions To test: 1 - Set two news items with location 'OpacSuggestioninstructions' 2 - One should be for all libraries 3 - One should be for a specific library 4 - Sign in to opac with user from the specific library 5 - Add a suggestion 6 - The instructions only show the all libraries item 7 - Apply patch 8 - Reload 9 - All libraries and specific library items are shown 10 - Allow anonymous suggestions: AnonSuggestions - Allow 11 - Sign out of opac 12 - Add a suggestion 13 - Only all librares news is visible Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 22:10:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 20:10:01 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Previously overdue notices release notes| |exclusively used the | |default language, but bug | |26420 changed this to the | |opposite - to exclusively | |use the language chosen by | |the patron. | | | |However, if | |there is no translation for | |the overdue notice for the | |language chosen by the | |patron then no message is | |sent. | | | |This fixes this so | |that if there is no | |translation of the overdue | |notice for the language | |chosen by the patron, then | |the default language notice | |is used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 22:16:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 20:16:12 +0000 Subject: [Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 22:16:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 20:16:16 +0000 Subject: [Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122174|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 122179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122179&action=edit Bug 28588: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 22:16:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 20:16:20 +0000 Subject: [Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122175|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 122180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122180&action=edit Bug 28588: Add Koha::Checkouts::ReturnClaim->resolve This patch introduces a high-level method for resolving claims. The behavior intends to replace the code in the API controller that is used for resolving a claim. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Checkouts/ReturnClaim.t => SUCCESS: Tests pass 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 22:16:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 20:16:25 +0000 Subject: [Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122176|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 122181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122181&action=edit Bug 28588: (follow-up) Make the API use the new method This patch adapts the controller method for resolving a return claim so it uses the Koha::Checkouts::ReturnClaim method instead. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/return_claims.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 22:33:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 20:33:46 +0000 Subject: [Koha-bugs] [Bug 28604] New: bad encoding when using marc-in-json Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 Bug ID: 28604 Summary: bad encoding when using marc-in-json Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com There are some UTF-8 encoding problems when using marc-in-json that have diacritics in them, I encountered this when using the '/api/v1/public/biblios/' API route. To recreate: -Add some diacritics to a MARC field, I am using the 538$a and added the note 'Tést nöte'. -Look at the what the API returns, I used this: curl --location --request GET 'http://localhost:8080/api/v1/public/biblios/144' \ --header 'Accept: application/marc-in-json' The 538$a note comes out looking like this: Tést nöte -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 22:35:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 20:35:07 +0000 Subject: [Koha-bugs] [Bug 28603] check-url-quick.pl does not encode spaces in urls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 22:35:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 20:35:11 +0000 Subject: [Koha-bugs] [Bug 28603] check-url-quick.pl does not encode spaces in urls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122177|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 122182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122182&action=edit Bug 28603: Encode spaces in urls in url checker To test: 1 - Add a url to a record like: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti&q=street%20shuffle 2 - perl misc/cronjobs/check-url-quick.pl -v > test.txt 3 - grep shuffle test.txt 4 - 303 http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti&q=street shuffle 596 Connection timed out 5 - Apply patch 6 - perl misc/cronjobs/check-url-quick.pl -v > test.txt 7 - grep shuffle test.txt 8 - 303 http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=ti&q=street%20shuffle 200 OK Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 22:45:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 20:45:47 +0000 Subject: [Koha-bugs] [Bug 28598] Changing date or time format on a production server will NOT create duplicate fines and we should remove the syspref warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28598 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 22:45:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 20:45:51 +0000 Subject: [Koha-bugs] [Bug 28598] Changing date or time format on a production server will NOT create duplicate fines and we should remove the syspref warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28598 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122135|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 122183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122183&action=edit Bug 28598: Update DateFormat and TimeFormat descriptions to remove warnings To test, confirm that the warnings are present without the patch and gone with it. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 23:30:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 21:30:35 +0000 Subject: [Koha-bugs] [Bug 28604] bad encoding when using marc-in-json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Status|NEW |Needs Signoff CC| |tomascohen at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 23:32:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 21:32:50 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 23:32:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 21:32:56 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122088|0 |1 is obsolete| | --- Comment #164 from David Nind --- Created attachment 122184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122184&action=edit Bug 12446: Ability to allow guarantor relationship for all patron category types This adds a new field "Can be guarantee" to patron categories so it becomes possible for any category type to have a guarantor. To test: 1) Have a patron category of type 'Adult' and one of type 'Child' 2) Confirm, by searching for the "Patron guarantor" fieldset in the edit/create form, that: => a patron of the first category can't have a guarantor => a patron from the second category can 3) Apply patch and run updatedatabase.pl 4) Edit the categories and note the new "Can be guarantee" field 5) It should have been set to "yes" for the "Child" and to "no" for the "Adult" 5) Repeat step 2. It should behave in the same way. 6) Edit the "Can be guarantee" for any of the category and check that the fieldset only appears when "Can be guarantee" is set to "yes" 7) prove t/db_dependent/Patrons.t => tests should still pass Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 23:33:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 21:33:03 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122089|0 |1 is obsolete| | --- Comment #165 from David Nind --- Created attachment 122185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122185&action=edit Bug 12446: Schema update Category.pm Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 23:33:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 21:33:10 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122090|0 |1 is obsolete| | --- Comment #166 from David Nind --- Created attachment 122186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122186&action=edit Bug 12446: Limit available categories when using "Add guarantee" button Test plan: 1) Have some patron categories that can and cannot be guarantee 2) Visit a patron's account and click the "Add guarantee" button 3) In the "category" dropdown, note that all categories are available 4) Apply this patch 5) Repeat step 2 and 3; the dropdown now only contains the categories for which "can be guarantee" is set to "Yes". Signed-off-by: Kyle M Hall Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 23:33:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 21:33:18 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122091|0 |1 is obsolete| | --- Comment #167 from David Nind --- Created attachment 122187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122187&action=edit Bug 12446: Add canbeguarantee value to patron categories sample data This patch changes sample data so patron categories of type 'C' or 'P' can be guarantees by default. Signed-off-by: Salman Ali Signed-off-by: Salman Ali Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 23:47:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 21:47:31 +0000 Subject: [Koha-bugs] [Bug 28604] bad encoding when using marc-in-json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 122188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122188&action=edit Bug 28604: Regression tests This patch introduces regression tests for the encoding issue with MiJ output. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 23:47:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 21:47:34 +0000 Subject: [Koha-bugs] [Bug 28604] bad encoding when using marc-in-json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 122189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122189&action=edit Bug 28604: Prevent double encoding of MARC::Record::MiJ->to_mij output This patch fixes a double-encoding issue with MiJ output. Mojolicious' *text* renderer encodes the passed information according to the request context. [1] MARC::Record::MiJ->to_mij, conveniently encodes the string before output [2]. This causes double encoding. So the solution to this situation, is to use the *data* renderer, which doesn't perform any encoding [3]. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Tests contain diacritics and fail! 3. Have a record with diacritics 4. Try the API routes for fetching a biblio: $ curl --location --request GET 'http://localhost:8080/api/v1/public/biblios/144' \ --header 'Accept: application/marc-in-json' (replace the record id with the one you've chosen) => FAIL: Boo, double encoding 5. Bonus point: you can try it on the non-public route, but you need more configuration boilerplate (basic auth, permissions). If you look at the fix, you will understand the tests cover it and no need to complicate yourself. 6. Apply this patch 7. Repeat 2 => SUCCESS: Tests pass! 8. Repeat 4 (and maybe 5) => SUCCESS: No double encoding! Yay! 9. Sign off :-D [1] https://metacpan.org/release/MRAMBERG/Convos-0.5/view/local/lib/perl5/Mojolicious/Guides/Rendering.pod#Rendering-text [2] https://metacpan.org/dist/MARC-File-MiJ/source/lib/MARC/Record/MiJ.pm#L111 [3] https://metacpan.org/release/MRAMBERG/Convos-0.5/view/local/lib/perl5/Mojolicious/Guides/Rendering.pod#Rendering-data Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 18 23:47:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 21:47:52 +0000 Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|bad encoding when using |Bad encoding when using |marc-in-json |marc-in-json -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 19 00:09:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 22:09:37 +0000 Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 19 00:09:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 22:09:39 +0000 Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 --- Comment #3 from Lucas Gass --- Created attachment 122190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122190&action=edit Bug 28604: Regression tests This patch introduces regression tests for the encoding issue with MiJ output. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 19 00:09:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 22:09:43 +0000 Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122189|0 |1 is obsolete| | --- Comment #4 from Lucas Gass --- Created attachment 122191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122191&action=edit Bug 28604: Prevent double encoding of MARC::Record::MiJ->to_mij output This patch fixes a double-encoding issue with MiJ output. Mojolicious' *text* renderer encodes the passed information according to the request context. [1] MARC::Record::MiJ->to_mij, conveniently encodes the string before output [2]. This causes double encoding. So the solution to this situation, is to use the *data* renderer, which doesn't perform any encoding [3]. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Tests contain diacritics and fail! 3. Have a record with diacritics 4. Try the API routes for fetching a biblio: $ curl --location --request GET 'http://localhost:8080/api/v1/public/biblios/144' \ --header 'Accept: application/marc-in-json' (replace the record id with the one you've chosen) => FAIL: Boo, double encoding 5. Bonus point: you can try it on the non-public route, but you need more configuration boilerplate (basic auth, permissions). If you look at the fix, you will understand the tests cover it and no need to complicate yourself. 6. Apply this patch 7. Repeat 2 => SUCCESS: Tests pass! 8. Repeat 4 (and maybe 5) => SUCCESS: No double encoding! Yay! 9. Sign off :-D [1] https://metacpan.org/release/MRAMBERG/Convos-0.5/view/local/lib/perl5/Mojolicious/Guides/Rendering.pod#Rendering-text [2] https://metacpan.org/dist/MARC-File-MiJ/source/lib/MARC/Record/MiJ.pm#L111 [3] https://metacpan.org/release/MRAMBERG/Convos-0.5/view/local/lib/perl5/Mojolicious/Guides/Rendering.pod#Rendering-data Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 19 00:10:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Jun 2021 22:10:16 +0000 Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122188|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 19 12:48:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jun 2021 10:48:32 +0000 Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #15 from Katrin Fischer --- Hi Augustin, I think we should not hardcode a fallback to English and it would be not correct with the other behaviour in Koha, like the templating system. Actually I think the fallback is usually to the first language in the list I think which is why you can reorder them? Maybe adding a fallback/default should be a separate bug - In general I agree it would be nice to have one in general. Bug 24766 might be related. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 19 12:48:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jun 2021 10:48:39 +0000 Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 19 13:01:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jun 2021 11:01:11 +0000 Subject: [Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #61 from Victor Grousset/tuxayo --- > 6 - Change rule to 'force' > 7 - Item-level hold can be placed in all interfaces Odd, in staff I get «Too many holds: Jane Doe has too many holds.» So no holds at all can be placed. OPAC: «This title cannot be requested.» Also > 4 - Attempt to place hold from opac or api > 5 - Hold is not allowed I can't place at all an OPAC hold when "OPAC item level holds" : don't allow I get «There are no items that can be placed on hold.» Did it work for you? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 19 13:17:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jun 2021 11:17:07 +0000 Subject: [Koha-bugs] [Bug 28491] field 003 not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 --- Comment #3 from Katrin Fischer --- > I am all for changing 003 here as well. But could imagine that others would > rather refrain from changing 001? I usually would, but in this case it's already the default behaviour of the authority import script :) So when we already change it, I think changing 003 as well just makes it 'right'. Bibliographic records should be a separate discussion I think. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 19 13:17:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jun 2021 11:17:40 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|field 003 not updated after |Field 003 in authority |import |records not updated after | |import -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 19 13:28:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jun 2021 11:28:45 +0000 Subject: [Koha-bugs] [Bug 28574] Double id in source code member.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28574 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Component|Circulation |Templates --- Comment #1 from Katrin Fischer --- Hi Pierre, it can cause issues when addressing these with jQuery, so definitely good to have this one files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 19 13:37:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jun 2021 11:37:44 +0000 Subject: [Koha-bugs] [Bug 28583] Temporarily disable CSS and Javascript for pages doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28583 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Temporarily disable CSS and |Temporarily disable CSS and |Javascript for pages with |Javascript for pages |variable |doesn't work --- Comment #3 from Katrin Fischer --- Could the difference be related to setup? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 19 13:39:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jun 2021 11:39:36 +0000 Subject: [Koha-bugs] [Bug 28585] Bug in GET /patrons by date_of_birth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #1 from Katrin Fischer --- Hi Hanna, could you include a sample for your query? Which date format was used? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 19 13:39:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jun 2021 11:39:58 +0000 Subject: [Koha-bugs] [Bug 28585] Bug in GET /patrons by date_of_birth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 --- Comment #2 from Katrin Fischer --- (In reply to Katrin Fischer from comment #1) > Hi Hanna, could you include a sample for your query? Which date format was > used? Sorry, Hannamari! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 19 13:46:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jun 2021 11:46:36 +0000 Subject: [Koha-bugs] [Bug 28587] ldap auth fails unless In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28587 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28385 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28385 [Bug 28385] LDAP server configuration broken since migration from XML::Simple -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 19 13:46:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jun 2021 11:46:36 +0000 Subject: [Koha-bugs] [Bug 28385] LDAP server configuration broken since migration from XML::Simple In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28385 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28587 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28587 [Bug 28587] ldap auth fails unless -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 19 21:13:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jun 2021 19:13:51 +0000 Subject: [Koha-bugs] [Bug 28215] software error when updating a record - /cgi-bin/koha/cataloguing/addbiblio.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28215 --- Comment #3 from cfhong2000 at gmail.com --- Here is the log from intranet-error.log addbiblio.pl: Use of uninitialized value $biblionumber in concatenation (.) or string at /usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl line 857.: /usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl, referer: http://xxx/cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode=FA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 19 21:16:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jun 2021 19:16:44 +0000 Subject: [Koha-bugs] [Bug 28215] software error when updating a record - /cgi-bin/koha/cataloguing/addbiblio.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28215 --- Comment #4 from cfhong2000 at gmail.com --- Here is the log from intranet-error.log addbiblio.pl: Use of uninitialized value $biblionumber in concatenation (.) or string at /usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl line 857.: /usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl, referer: http://xxx/cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode=FA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 19 22:45:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Jun 2021 20:45:11 +0000 Subject: [Koha-bugs] [Bug 28215] software error when updating a record - /cgi-bin/koha/cataloguing/addbiblio.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28215 --- Comment #5 from cfhong2000 at gmail.com --- Sat Jun 19 16:34:26.054527 2021] [cgi:error] [pid 9169] [client 1xxx.xxx.xxx:54867] AH01215: [Sat Jun 19 16:34:26 2021] addbiblio.pl: [Request] ** [http://localhost:9200]-[400] [illegal_argument_exception] Fielddata is disabled on text fields by default. Set fielddata=true on [local-number__sort] in order to load fielddata in memory by uninverting the inverted index. Note that this can however use significant memory. Alternatively use a keyword field instead., called from sub Search::Elasticsearch::Role::Client::Direct::__ANON__ at /usr/share/koha/lib/Koha/SearchEngine/Elasticsearch/Search.pm line 96. With vars: {'status_code' => 400,'body' => {'status' => 400,'error' => {'failed_shards' => [{'shard' => 0,'index' => 'koha_acccnlib_authorities','node' => 'XixKhqGwRtinFdkt7uwTWw','reason' => {'reason' => 'Fielddata is disabled on text fields by default. Set fielddata=true on [local-number__sort] in order to load fielddata in memory by uninverting the inverted index. Note that this can however use significant memory. Alternatively use a keyword field instead.','type' => 'illegal_argument_exception'}}],'reason' => 'all shards failed','type' => 'search_phase_execution_exception','phase' => 'query','root_cause' => [{'type' => 'illegal_argument_exception','reason' => 'Fielddata is disabled on text fields by default. Set fielddata=true on [local-number__sort] in order to load fielddata in memory by uninverting the inverted index. Note that this can however use significant memory. Alternatively use a keyword field instead.'}],'caused_by' => {'type' => 'illegal_argument_exception','reason' => 'Fielddata is disabled on text fields by default. Set fielddata=true on [local-number__sort] in order to load fielddata in memory by uninverting the inverted index. Note that this can however use significant memory. Alternatively use a keyword field instead.','caused_by' => {'type' => 'illegal_argument_exception','reason' => 'Fielddata is disabled on text fields by default. Set fielddata=true on [local-number__sort] in order to load fielddata in memory by uninverting the inverted index. Note that this can however use significant memory. Alternatively use a keyword field instead.'}},'grouped' => bless( do{\\(my $o = 1)}, 'JSON::PP::Boolean' )}},'request' => {'body' => {'size' => 20,'sort' => [{'local-number__sort' => 'asc'}],'from' => 0,'query' => {'bool' => {'filter' => {'term' => {'authtype.raw' => 'PERSO_NAME'}},'must' => [{'term' => {'match-heading.ci_raw' => "\\x{9ec3}\\x{5049}\\x{5eb7}"}}]}}},'mime_type' => 'application/json','path' => '/koha_acccnlib_authorities/_search','serialize' => 'std','qs' => {},'ignore' => [],'method' => 'GET'}}: /usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl, referer: http://xxx:8080/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=4935&searchid=scs_1624134776827 [Sat Jun 19 16:34:26.054698 2021] [cgi:error] [pid 9169] [client xx.xxx.xx:54867] AH01215: [Sat Jun 19 16:34:26 2021] addbiblio.pl: Unable to perform your search. Please try again.: /usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl, referer: http://xxx:8080/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=4935&searchid=scs_1624134776827 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 20 07:56:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jun 2021 05:56:32 +0000 Subject: [Koha-bugs] [Bug 26394] .mailmap needs to be updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 --- Comment #11 from wainuiwitikapark at catalyst.net.nz --- Backported to 19.11.x for 19.11.19 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 20 07:57:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jun 2021 05:57:11 +0000 Subject: [Koha-bugs] [Bug 26394] .mailmap needs to be updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00,20.05.13 |20.11.00,20.05.13,19.11.19 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 20 13:18:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jun 2021 11:18:20 +0000 Subject: [Koha-bugs] [Bug 28215] software error when updating a record - /cgi-bin/koha/cataloguing/addbiblio.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28215 --- Comment #6 from Katrin Fischer --- It looks like Elasticsearch might be involved here? At the moment I am not able to test with Elasticseach, maybe someone else could give this a go? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 20 13:41:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jun 2021 11:41:26 +0000 Subject: [Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 20 13:41:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jun 2021 11:41:31 +0000 Subject: [Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122048|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 122192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122192&action=edit Bug 28576: Add patron image in patron detail section does not specify image size limit When you try to add an image to a patron in Home/Patrons/anyPatron, it only states the file types that are supported but not the maximum size. If you try to add an image that is bigger than 500 kb, nothing happens and the reason is not presented. This is not the case with the 2 other places where we can add patron images in which they give warnings: Home/Tools/Upload patron images Home/Tools/Patron card creator/Images For now, i simply added the size limit to the file supported message. To test: 1)Search for any patron and go to his page 2)Hover over the image area on the left and click on add 3)Notice the message above the choose file button only specifies file types not size. 4)Add an image bigger than 500 kb 5)Nothing happens 6)Apply patch 7)Repeat steps from 1 to 3 8)Notice the message now includes the maximum size Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 20 13:43:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jun 2021 11:43:49 +0000 Subject: [Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This updates the add patron release notes| |image screen to specify | |that the maximum image size | |is 500KB. If it is larger, | |the patron image is not | |added. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 20 21:14:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jun 2021 19:14:56 +0000 Subject: [Koha-bugs] [Bug 28510] Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 20 21:15:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jun 2021 19:15:01 +0000 Subject: [Koha-bugs] [Bug 28510] Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121578|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 122193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122193&action=edit Bug 28510: Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled Right now we skip closed branch's items as we iterate over all items looking for ones to fill a hold. If HoldsQueueSkipClosed is enabled, no items held be a closed library can be targeted, so it would be more efficient if we never selected the items from those branches to begin with. This is how the holds queue works if we are not using the transport cost matrix, so we should make it work the same way if we *are* using the matrix. Test Plan: 1) Apply this patch 2) prove prove t/db_dependent/HoldsQueue.t 3) All tests should continue to pass Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 20 21:15:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jun 2021 19:15:04 +0000 Subject: [Koha-bugs] [Bug 28510] Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121579|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 122194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122194&action=edit Bug 28510: Remove marking of closed branches as 'disable_transfer' We no longer need to act as if closed branches were marked as disable_transfer. This allows us to clean up a nice bit of code. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 20 21:15:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jun 2021 19:15:08 +0000 Subject: [Koha-bugs] [Bug 28510] Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121588|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 122195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122195&action=edit Bug 28510: Remove unnecessary conditional It makes sense to use items by branch to get the list of branches, as it already tells use which branches have available items. We could use branches to pull from instead, but all we would accomplish is added extra ununsed loop iterations. We already know that any additional branches in the branches to pull loop have no items to fill holds. If they did, they would be in the items_by_branch hash. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 20 21:32:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jun 2021 19:32:41 +0000 Subject: [Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 20 21:32:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jun 2021 19:32:45 +0000 Subject: [Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122050|0 |1 is obsolete| | --- Comment #20 from David Nind --- Created attachment 122196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122196&action=edit Bug 28299: Unit tests for buildKohaItemsNamespace Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 20 21:32:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jun 2021 19:32:50 +0000 Subject: [Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122051|0 |1 is obsolete| | --- Comment #21 from David Nind --- Created attachment 122197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122197&action=edit Bug 28299: Take OpacHiddenItems into account on opac-shelves hidden_items was not passed to XSLTParse4Display 2 things: * Should we hide the biblio record if OpacHiddenItemsHidesRecord is set? * allow_onshelf_holds is not working like in other scripts, what's the expected behaviour? If hidden should we completely ignore the item? Test plan: 1. Without the patch 2. fill OpacHiddenItems with «damaged: [1]» 3. find a record with several item 4. mark one of them as damaged 5. OPAC: go to the record, you shouldn't see the damaged item 6. add the record to a list 7. see the list 8. in Availability you see the damaged item mentioned, this is the issue 9. apply the patches and restart the services 10. the list should not mention the damaged item :D Signed-off-by: Victor Grousset/tuxayo Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 20 21:32:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jun 2021 19:32:55 +0000 Subject: [Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122052|0 |1 is obsolete| | --- Comment #22 from David Nind --- Created attachment 122198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122198&action=edit Bug 28299: Make buildKohaItemsNamespace accept Koha::Items This patch makes buildKohaItemsNamespace (and its only caller, XSLTParse4Display) accept a an optional Koha::Items resultset. This way we don't need to calculate (from the DB) the list of hidden itemnumbers, but solve it in one query. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 20 21:42:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jun 2021 19:42:23 +0000 Subject: [Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an issue where release notes| |items that should be hidden | |from display in the OPAC | |(using the rules in | |OpacHiddenItems, for | |example: where damaged) | |were displayed under | |availability in OPAC lists. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 20 21:48:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jun 2021 19:48:20 +0000 Subject: [Koha-bugs] [Bug 28464] Cancelling a waiting hold via SIP returns a failed response even when cancellation succeeds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28464 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 20 21:48:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jun 2021 19:48:24 +0000 Subject: [Koha-bugs] [Bug 28464] Cancelling a waiting hold via SIP returns a failed response even when cancellation succeeds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28464 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121437|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 122199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122199&action=edit Bug 28464: Add unit tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 20 21:48:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jun 2021 19:48:27 +0000 Subject: [Koha-bugs] [Bug 28464] Cancelling a waiting hold via SIP returns a failed response even when cancellation succeeds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28464 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121438|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 122200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122200&action=edit Bug 28464: Remove useless check that gives the incorrect error message Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 20 21:49:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jun 2021 19:49:54 +0000 Subject: [Koha-bugs] [Bug 28464] Cancelling a waiting hold via SIP returns a failed response even when cancellation succeeds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28464 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind --- Testing notes (koha-testing-docker): - Ran prove t/db_dependent/SIP/ILS.t before and after patches applied - Tests passed both before and after - Hope that is sufficient to test! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 20 22:50:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jun 2021 20:50:51 +0000 Subject: [Koha-bugs] [Bug 28299] OpacHiddenItems not working in OPAC lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OpacHiddenItems not working |OpacHiddenItems not working |on opac-shelves |in OPAC lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 01:11:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jun 2021 23:11:21 +0000 Subject: [Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 01:11:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jun 2021 23:11:29 +0000 Subject: [Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 01:12:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Jun 2021 23:12:14 +0000 Subject: [Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to oldoldstable Version(s)|20.11.00 |20.11.00,20.05.13 released in| | --- Comment #77 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 03:33:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 01:33:21 +0000 Subject: [Koha-bugs] [Bug 26621] .mailmap adjustments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26621 --- Comment #17 from wainuiwitikapark at catalyst.net.nz --- Backported to 19.11.x for 19.11.19 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 03:34:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 01:34:19 +0000 Subject: [Koha-bugs] [Bug 26621] .mailmap adjustments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26621 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00,20.05.13 |20.11.00,20.05.13,19.11.19 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 05:32:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 03:32:35 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #41 from Victor Grousset/tuxayo --- > 4) additionally perform a search using range, for example: "[1999 TO 2020]", ensure that it works correctly too. What values should be in the record for the search to yield it? It doesn't say anymore "You did not specify any search criteria." So it's better. But it says that there are not matches. I'm not sure ranges actually work. (because i don't know how to use them ^^") I tried «date-of-publication:[1950:2020]» Is that a correct query for a record with [1984] or 1984 in 260$c -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 05:33:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 03:33:48 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #42 from Victor Grousset/tuxayo --- errata: «date-of-publication:[1950 TO 2020]» -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 06:04:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 04:04:51 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #25 from David Cook --- (In reply to Marcel de Rooy from comment #23) > (In reply to David Cook from comment #0) > > Bug 28489 looks to add CGI::Session::Serializer::yamlxs, but it wants to > > hack it into C4::Auth. > > > > I rather we put it in a Perl "lib" directory. However, /usr/share/koha/lib > > only exists in a deployed Koha. There is no "lib" directory in the source > > tree. But we can fix that. > > Not opposing this change, but isnt this a hack too? We could have fooled > Koha too by making our own package and install it in a regular perllib ? > Just curious why we exactly need lib. It's the opposite of a hack. C4 and Koha should never have been top-level directories in the source tree. We should always have had a "lib" top-level directory in which to place modules. This change is about creating a better standard and using it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 06:07:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 04:07:44 +0000 Subject: [Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #78 from wainuiwitikapark at catalyst.net.nz --- This does not apply cleanly to 19.11.x please submit one formatted for 19.11.x The merge conflict in Koha/REST/V1.pm is quite large and complex so we weren't confident trying to fix it. (I did fix the merge conflict in Koha/REST/Plugin/PluginRoutes.pm okay though) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 06:23:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 04:23:22 +0000 Subject: [Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #79 from wainuiwitikapark at catalyst.net.nz --- The above comment refers to the first patch: Bug 23653: use local copy of swagger v2 schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 06:28:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 04:28:03 +0000 Subject: [Koha-bugs] [Bug 28589] Move C4 and Koha to lib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 --- Comment #6 from David Cook --- (In reply to Jonathan Druart from comment #0) > > Are we ready for this move? Is it something we really want? Who is willing > to spend time on working on this (testing mostly)? > What better time than now? - It will mean we can keep all our Perl modules together in a place where any (new or old) developer could predict to find them - It will also make it easier to work with multiple namespaces. - It will provide a smaller target for git/dev installs (rather than having "lib" be the entire source tree) - It also provides a mechanism for overriding modules. There are cases where you might want to use a library but want to customize the behaviour of a submodule. It doesn't necessarily make sense to fork an entire library, but you can override a single module, since the Koha "lib" directory is sourced earlier in @INC - It provides a first step to cleaning up the top-level directory - It provides an opportunity to find little hacks where we load modules based on file system location rather than their presence in @INC. I can put some time into this. I imagine most issues would be related to C4 and SIP. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 07:26:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 05:26:08 +0000 Subject: [Koha-bugs] [Bug 28585] Bug in GET /patrons by date_of_birth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 --- Comment #3 from Hannamari Heiniluoma --- Hi! My query was /patrons/?date_of_birth=2000-01-01. That returns status code 200 and an empty response []. If I change the date format, eg. /patrons/?date_of_birth=2000/01/01 (or any other format I can think of), I get 500 and { "error": "Something went wrong, check Koha logs for details." } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 07:56:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 05:56:39 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122108|0 |1 is obsolete| | --- Comment #43 from Victor Grousset/tuxayo --- Created attachment 122201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122201&action=edit Bug 28316: add tests Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 07:56:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 05:56:45 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122103|0 |1 is obsolete| | --- Comment #44 from Victor Grousset/tuxayo --- Created attachment 122202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122202&action=edit Bug 28316: screen unquoted semicolons and all followup colons Currently searches like: "book:", ":book" and "host-item:test:n" cause internal server errors. This patch adds additional regexes that remove the colons at the start and end of the query, and another regex that screens all follow-up colons that go after the first colon to avoid errors when searching for "host-item:test:n". To reproduce: 1) using ES, search for the book with title that contains semicolon at the start or at the end of the line, separated with spaces, this should cause internal server error. 2) try doing the same with something like "host-item:test:n", it should result in error as well. 3) apply the patch. 4) repeat steps 1-2, ensure that it works now. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 07:56:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 05:56:50 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122104|0 |1 is obsolete| | --- Comment #45 from Victor Grousset/tuxayo --- Created attachment 122203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122203&action=edit Bug 28316: escape brackets in the search query This patch screens square and curly brackets which have no special language meaning, while keeping ranges as they are, allowing ES to search for biblios with titles that contain square and curly brackets and at the same time allows the use of range searches ([1990 TO 2000]). To reproduce: 1) using ES, search for the book with title that contains square and/or curly brackets, like "book [second edition]", which will result in error. 2) apply the patch. 3) search for that book again, ensure that it works now. 4) additionally perform a search using range, for example: "[1999 TO 2020]", ensure that it works correctly too. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 07:56:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 05:56:55 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122105|0 |1 is obsolete| | --- Comment #46 from Victor Grousset/tuxayo --- Created attachment 122204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122204&action=edit Bug 28316: escape exclamation signs in the query Currently having exclamation sign at the end of the query makes ES search fail, and when you try to search for a book that has exclamation sign in the tittle (something like "Words! words") won't show results correctly as it tries to negate everything that is after exclamation sign, making it impossible to search for books that have in in the title This patch escapes exclamation signs if it's at the end of the query or has a space after it, resolving both of the issues listed above. To reproduce: 1) with ES enabled, search for the book with title that contains exclamation sight at the end, like "book!", this search should result in error. 2) do another search, but this time find/prepare beforehand book with a title that has exclamation sign with a space after it, e.g "exclamation! sign", it shouldn't find it as ES treats everything after that exclamation sign as negation. 2) apply the patch. 3) perform searches from the steep one and two again. Search from step one should no longer fail, while search from the step two should find that book. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 07:57:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 05:57:00 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122106|0 |1 is obsolete| | Attachment #122107|0 |1 is obsolete| | --- Comment #47 from Victor Grousset/tuxayo --- Created attachment 122205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122205&action=edit Bug 28316: avoid messing up regexes in the search queries This patch ensures that the behavior with QueryRegexEscapeOptions set to values other than "Escape" still will works as expected. It does so by storing the contents of regexes before escaping special characters and then restores the contents of regexes back to how it was before, ensuring that searching with regex is possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 07:57:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 05:57:06 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #48 from Victor Grousset/tuxayo --- Created attachment 122206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122206&action=edit Bug 28316: avoid messing up regexes in the search queries This patch ensures that the behavior with QueryRegexEscapeOptions set to values other than "Escape" still will works as expected. It does so by storing the contents of regexes before escaping special characters and then restores the contents of regexes back to how it was before, ensuring that searching with regex is possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 08:00:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 06:00:40 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #49 from Victor Grousset/tuxayo --- The test plan yielded good results :) Patches were reordered to make it easier to check the tests (they indeed fail when the implementation is missing) Do these commits need a test plan? Bug 28316: avoid messing up regexes in the search queries Bug 28316: avoid messing up regexes in the search queries (they have the same name and description, suspicious ^^) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 08:15:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 06:15:59 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #50 from Andrew Nugged --- You right, Victor, I see also that description messed up and diverged after lot of reworks, let's Petro fix this, Petro, I assume patch 122205 explanation should be without "QueryRegexEscapeOptions" paragraph, and patch 122206 related to: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316#c27 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316#c45 so it should be about "range", not regex, about hiding ranges from escaping actually, I see most description from 122206 appears in 122203, and 122203 is just about "replacing brackets which not have special meaning" only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 09:34:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 07:34:27 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #64 from Jonathan Druart --- (In reply to Martin Renvoize from comment #63) > This has moved a bit.. looking good. > > I wonder about the --force option we've introduced a little.. might be good > to have a 'force_once' or something so allow the user to pick to ignore the > first error but have subsequent errors still catch. I added the --force for testing purpose, we can remove it. > Generally, I think I'm happy here.. I do think Julians $report way of doing > multi-line description blocks is cleaner looking somehow.. and I can see his > point about passing dbh rather than suggesting we rely on C4::Context.. it > is somewhat future-proofing (and it's a familiar concept to me to pass dbh > around this way as it's how DBIx::Class::DeploymentHandler does it (though > in that case.. they often also pass a dbic schema for the before and after > upgrade step so you can use dbic during upgrades.. takes some getting used > to, but is pretty cool) Julian, could you attach a patch here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 09:44:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 07:44:12 +0000 Subject: [Koha-bugs] [Bug 28580] Getting random "Database is not empty!" when a job is run on jenkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28580 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |MOVED Status|NEW |RESOLVED --- Comment #2 from Jonathan Druart --- Moved to https://gitlab.com/koha-community/koha-testing-docker/-/issues/262 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 09:54:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 07:54:11 +0000 Subject: [Koha-bugs] [Bug 21821] We should bundle an up to date RangeMessage.xml for Business::ISBN In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21821 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14287 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 09:54:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 07:54:11 +0000 Subject: [Koha-bugs] [Bug 14287] Preserve valid ISBN-13 identifiers if they start with something else than 978 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14287 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21821 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 09:54:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 07:54:21 +0000 Subject: [Koha-bugs] [Bug 21821] We should bundle an up to date RangeMessage.xml for Business::ISBN In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21821 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13192 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 09:54:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 07:54:21 +0000 Subject: [Koha-bugs] [Bug 13192] Hard-coded value (ISBN Prefix '978') in cataloguing::value_builder::unimarc_field_010 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13192 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21821 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 09:55:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 07:55:26 +0000 Subject: [Koha-bugs] [Bug 28600] Variable "$patron" is not available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 09:58:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 07:58:58 +0000 Subject: [Koha-bugs] [Bug 28600] Variable "$patron" is not available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 09:59:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 07:59:02 +0000 Subject: [Koha-bugs] [Bug 28600] Variable "$patron" is not available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122171|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 122207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122207&action=edit Bug 28600: Resolve variable scope issue This patch fixes a scope issue. Originally, a variable declared as our $borcat was replaced by my $patron This patch makes the method not rely on global variables, but have a parameter for the patron, and thus things are clearer. To test: 1. Open the OPAC detail page for a record => FAIL: The logs show some errors about the $patron variable not available in the scope 2. Apply this patch 3. Repeat 1 => SUCCESS: No errors 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 10:01:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 08:01:17 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #65 from Julian Maurice --- Created attachment 122208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122208&action=edit Bug 25078: Separate update "report" from its description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 10:05:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 08:05:03 +0000 Subject: [Koha-bugs] [Bug 24147] Objects.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24147 --- Comment #18 from Jonathan Druart --- Master_U_Stable 196 Docker_1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 10:06:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 08:06:19 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #66 from Julian Maurice --- Comment on attachment 122208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122208 Bug 25078: Separate update "report" from its description Review of attachment 122208: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25078&attachment=122208) ----------------------------------------------------------------- ::: C4/Installer.pm @@ +724,5 @@ > > my $error; > > + my $out = ''; > + open my $outfh, '>', \$out; About that feature of 'open', perldoc says: This feature works only when Perl is built with PerlIO -- the default, except with older (pre-5.16) Perl installations that were configured to not include it (e.g. via Configure -Uuseperlio). You can see whether your Perl was built with PerlIO by running perl -V:useperlio. If it says 'define', you have PerlIO; otherwise you don't. But it also says: For Perls 5.8.0 and later, PerlIO is (most often) the default It tested up to 5.10 (with docker images at https://hub.docker.com/_/perl) and it works well. If we want to be extra safe we can increase the minimum perl version required to 5.16 but I don't think it's necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 10:32:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 08:32:10 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 10:32:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 08:32:13 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 --- Comment #4 from Marcel de Rooy --- Created attachment 122209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122209&action=edit Bug 28491: Only whitespace changes for AddAuthority Only fixes indentation at highest level in sub. Includes warnings from qa tools: forbidden pattern: trailing space char (line 600) forbidden pattern: trailing space char (line 602) forbidden pattern: trailing space char (line 608) forbidden pattern: trailing space char (line 613) Test plan: Nothing to test really. No compile warnings? Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 10:32:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 08:32:17 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 --- Comment #5 from Marcel de Rooy --- Created attachment 122210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122210&action=edit Bug 28491: Always update field 003 in AddAuthority (MARC21) Test plan: Add or modify a record. Verify that the 003 always become the branch or system orgcode. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 10:32:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 08:32:20 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 --- Comment #6 from Marcel de Rooy --- Created attachment 122211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122211&action=edit Bug 28491: Add unit test Test plan: Run t/db_dependent/AuthoritiesMarc.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 10:32:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 08:32:52 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 10:40:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 08:40:53 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #28 from Jonathan Druart --- Comment on attachment 122139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122139 Bug 28581: Use 'from_email_address' where appropriate Review of attachment 122139: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=28581&attachment=122139) ----------------------------------------------------------------- ::: C4/Reserves.pm @@ +1849,4 @@ > > my $library = Koha::Libraries->find( $hold->branchcode )->unblessed; > > + my $admin_email_address = $library->from_email_address; Hum, $library is a hashref here. # Failed test 'Set waiting flag' # at /kohadevbox/koha/t/db_dependent/Circulation.t line 3475. Can't call method "from_email_address" on unblessed reference at /kohadevbox/koha/C4/Reserves.pm line 1852. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 10:41:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 08:41:01 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 10:42:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 08:42:31 +0000 Subject: [Koha-bugs] [Bug 26205] News changes aren't logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Passed QA |Failed QA --- Comment #23 from Jonathan Druart --- Please fix author's email and name of the patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 10:49:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 08:49:47 +0000 Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart+koha at gmail. | |com --- Comment #8 from Jonathan Druart --- One test is failing with those 2 patches applied: # Failed test at t/db_dependent/AuthorisedValues.t line 236. # Structures begin differing at: # $got->[0]{opac_description} = 'opac display value 0' # $expected->[0]{opac_description} = 'opac display value undef' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 10:51:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 08:51:04 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 10:51:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 08:51:08 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #29 from Marcel de Rooy --- Created attachment 122212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122212&action=edit Bug 28581: (QA follow-up) Fix method on unblessed reference Speaks for itself. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 10:52:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 08:52:24 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #30 from Marcel de Rooy --- Test still fails on problem with Renewal but waiting flag passes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 10:53:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 08:53:48 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #31 from Marcel de Rooy --- # Subtest: AddRenewal and AddIssuingCharge tests 1..13 not ok 1 - Exception is thrown when renewal update to issues fails # Failed test 'Exception is thrown when renewal update to issues fails' # at t/db_dependent/Circulation.t line 3912. # expecting: Koha::Exceptions::Checkout::FailedRenewal # found: normal exit ok 2 - renew log not added because of the syspref RenewalLog ok 3 - AddRenewal should set the renewal date with the time part not ok 4 # Failed test at t/db_dependent/Circulation.t line 3935. # got: '3' # expected: '2' ok 5 - The issue of item with issuing charge generates an accountline of the correct type ok 6 - AddIssuingCharge correctly sets branchcode ok 7 - AddIssue does not set a hardcoded description for the accountline ok 8 - The renewal of item with issuing charge generates an accountline of the correct type ok 9 - AddRenewal correctly sets branchcode ok 10 - AddRenewal does not set a hardcoded description for the accountline ok 11 - renew log successfully added ok 12 - renew statistic successfully added with passed branch not ok 13 - Passing skipfinecalc causes fine calculation on renewal to be skipped # Failed test 'Passing skipfinecalc causes fine calculation on renewal to be skipped' # at t/db_dependent/Circulation.t line 3972. # got: '6' # expected: '5' # Looks like you failed 3 tests of 13. not ok 42 - AddRenewal and AddIssuingCharge tests # Failed test 'AddRenewal and AddIssuingCharge tests' # at t/db_dependent/Circulation.t line 3974. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 10:54:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 08:54:31 +0000 Subject: [Koha-bugs] [Bug 28313] Add street type to alternate address in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28313 --- Comment #7 from Jonathan Druart --- Created attachment 122213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122213&action=edit Bug 28313: (follow-up) Define roadtypes It's not necessarily defined at this point -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 11:10:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 09:10:31 +0000 Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #16 from Marcel de Rooy --- Please note the fallback in NewsChannels too: (opac_news.lang = '' OR opac_news.lang = ?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 11:19:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 09:19:34 +0000 Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #17 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #16) > Please note the fallback in NewsChannels too: > > (opac_news.lang = '' OR opac_news.lang = ?) But it is not very useful here ;) I agree with Katrin that a fallback in cases like this would be nice, but it is not the scope of this report. Given how Koha now operates, I think we could well do without the fallback for now. If you did not define the disclaimer in a language that you do offer, you dont have a disclaimer. As soon as a solution for GetNewsToDisplay is found, it will resolve this case too.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 11:27:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 09:27:33 +0000 Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 --- Comment #18 from Katrin Fischer --- > Given how Koha now operates, I think we could well do without the fallback > for now. If you did not define the disclaimer in a language that you do > offer, you dont have a disclaimer. > As soon as a solution for GetNewsToDisplay is found, it will resolve this > case too.. +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 11:28:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 09:28:31 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Marcel de Rooy --- Just mentioning one compile error: perl -c tools/viewlog.pl Global symbol "$debug" requires explicit package name (did you forget to declare "my $debug"?) at /usr/share/koha/C4/Context.pm line 788. BEGIN not safe after errors--compilation aborted at /usr/share/koha/C4/Context.pm line 853. Compilation failed in require at /usr/share/koha/C4/Auth.pm line 30. BEGIN failed--compilation aborted at /usr/share/koha/C4/Auth.pm line 30. Compilation failed in require at tools/viewlog.pl line 23. BEGIN failed--compilation aborted at tools/viewlog.pl line 23. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 11:29:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 09:29:39 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #10 from Marcel de Rooy --- sub get_shelves_userenv { my $active; unless ($active = $context->{userenv}->{$context->{activeuser}}) { $debug and warn "get_shelves_userenv cannot retrieve context->{userenv}->{context->{activeuser}}"; return; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 11:35:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 09:35:04 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #11 from Marcel de Rooy --- - $debug and warn "Error ExportFramework $@\n"; + Koha::Logger->get->warn("Error ExportFramework $@"); Warn instead of debug ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 11:35:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 09:35:25 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #12 from Marcel de Rooy --- More cases of the former too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 11:39:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 09:39:53 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #13 from Marcel de Rooy --- -BEGIN { - $DEBUG = ($ENV{DEBUG}) ? 1 : 0; -} We still have other cases of using $ENV{DEBUG} ? What about them? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 11:45:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 09:45:33 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #14 from Marcel de Rooy --- git grep "C4::Debug" misc/admin/koha-preferences:use C4::Debug; misc/admin/koha-preferences: print STDERR $message . "\n" if ( $C4::Debug::debug ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 11:46:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 09:46:33 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 11:47:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 09:47:23 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Passed QA |Failed QA --- Comment #108 from Jonathan Druart --- 1. Can you summarize what is done in this patchset please? A full test plan would be nice too. 2. APPLY is not in account_offset_types.sql 3. + $dbh->do( "UPDATE account_offsets SET type = 'APPLY' WHERE type != 'OVERDUE_INCREASE' AND type != 'OVERDUE_DECREASE' AND type != 'CREATE'" ); Hum, is this query correct? Aren't we missing a condition? 4. Tests missing for Koha::Account::Line->manager -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 11:51:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 09:51:44 +0000 Subject: [Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480 --- Comment #5 from Jonathan Druart --- Aren't they missing for other routes as well? Shouldn't we have a test to catch missing occurrences? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 11:52:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 09:52:48 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #26 from Marcel de Rooy --- Hi David, I understand 'We do not have a lib folder' point. But still wondering (especially since this report just creates a CGI::Session variant in lib): > We could have fooled Koha too by making our own package and install it in a > regular perllib ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 11:54:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 09:54:05 +0000 Subject: [Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480 --- Comment #6 from Jonathan Druart --- Second patch has a wrong bug number. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 11:58:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 09:58:17 +0000 Subject: [Koha-bugs] [Bug 28605] New: Code to calculate item's holdability must be moved to Koha::Item Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28605 Bug ID: 28605 Summary: Code to calculate item's holdability must be moved to Koha::Item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 28422 Code is duplicated in opac/opac-ISBDdetail.pl, opac/opac-MARCdetail.pl and opac/opac-detail.pl (at least). It must be moved to a Koha::Item method 721 $norequests = 0 722 if $norequests 723 && !$itm->{'withdrawn'} 724 && !$itm->{'itemlost'} 725 && ($itm->{'itemnotforloan'}<0 || not $itm->{'itemnotforloan'}) 726 && !$itemtypes->{$itm->{'itype'}}->{notforloan} 727 && $itm->{'itemnumber'}; search for '$norequests' in those 3 files. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28422 [Bug 28422] OPAC MARC detail view doesn't correctly evaluate holdability -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 11:58:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 09:58:17 +0000 Subject: [Koha-bugs] [Bug 28422] OPAC MARC detail view doesn't correctly evaluate holdability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28422 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28605 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28605 [Bug 28605] Code to calculate item's holdability must be moved to Koha::Item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 11:59:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 09:59:35 +0000 Subject: [Koha-bugs] [Bug 28511] Road types in OPAC should prefer OPAC description if one exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28511 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Attachment #121863|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:00:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:00:36 +0000 Subject: [Koha-bugs] [Bug 28511] Road types in OPAC should prefer OPAC description if one exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28511 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121696|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 122214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122214&action=edit Bug 28511: Road types in OPAC should prefer OPAC description if one exists This patch modifies the patron entry form in the OPAC so that if street types are defined in authorized values, the OPAC description is preferred. To test, apply the patch and go to Administration -> Authorized values. - Add or edit entries in the "ROADTYPE" category. - Some entries should have only the "Description" set, while others should have "Description" and "Description (OPAC)". - In the OPAC, open the patron registration page. Check the "Stree type" drop down in the "Main address" section. - For entries which have an OPAC description, this value should show. - For entries without an OPAC description the default should show. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:00:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:00:42 +0000 Subject: [Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:00:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:00:46 +0000 Subject: [Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561 --- Comment #9 from Marcel de Rooy --- Created attachment 122215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122215&action=edit Bug 28561: Remove DBIC warning in opac-shelves Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:01:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:01:28 +0000 Subject: [Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:01:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:01:30 +0000 Subject: [Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121912|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:01:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:01:32 +0000 Subject: [Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122119|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:03:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:03:26 +0000 Subject: [Koha-bugs] [Bug 28476] Update info in docs/teams.yaml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28476 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #5 from Jonathan Druart --- Patches will be squashed when pushed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:03:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:03:32 +0000 Subject: [Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561 --- Comment #10 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #8) > We don't actually need to prefetch as we are only using the biblionumber. > Using join and distinct seems to remove the warning and produce the same > results. So simple.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:05:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:05:09 +0000 Subject: [Koha-bugs] [Bug 21286] Advanced search for Corporate-name creates Zebra errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21286 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:05:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:05:11 +0000 Subject: [Koha-bugs] [Bug 21286] Advanced search for Corporate-name creates Zebra errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21286 --- Comment #11 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:05:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:05:14 +0000 Subject: [Koha-bugs] [Bug 27348] Error defining INDEXER_PARAMS in /etc/default/koha-common In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27348 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:05:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:05:16 +0000 Subject: [Koha-bugs] [Bug 27348] Error defining INDEXER_PARAMS in /etc/default/koha-common In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27348 --- Comment #12 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:05:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:05:18 +0000 Subject: [Koha-bugs] [Bug 27929] Regex option in item batch modification is hidden for itemcallnumber if 952$o linked to cn_browser plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27929 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:05:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:05:21 +0000 Subject: [Koha-bugs] [Bug 27929] Regex option in item batch modification is hidden for itemcallnumber if 952$o linked to cn_browser plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27929 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:05:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:05:23 +0000 Subject: [Koha-bugs] [Bug 28191] Update wording on batch patron deletion to reflect changes from bug 26517 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28191 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:05:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:05:26 +0000 Subject: [Koha-bugs] [Bug 28191] Update wording on batch patron deletion to reflect changes from bug 26517 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28191 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:05:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:05:28 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:05:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:05:31 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #23 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:05:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:05:33 +0000 Subject: [Koha-bugs] [Bug 28280] Item types configuration page doesn't use Price filter for default replacement cost and processing fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28280 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:05:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:05:35 +0000 Subject: [Koha-bugs] [Bug 28280] Item types configuration page doesn't use Price filter for default replacement cost and processing fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28280 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:05:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:05:38 +0000 Subject: [Koha-bugs] [Bug 28313] Add street type to alternate address in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28313 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:05:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:05:41 +0000 Subject: [Koha-bugs] [Bug 28313] Add street type to alternate address in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28313 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:05:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:05:43 +0000 Subject: [Koha-bugs] [Bug 28344] One should be able to issue refunds against payments that have already been cashed up. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28344 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:05:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:05:46 +0000 Subject: [Koha-bugs] [Bug 28344] One should be able to issue refunds against payments that have already been cashed up. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28344 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:05:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:05:48 +0000 Subject: [Koha-bugs] [Bug 28388] Search result set is lost when viewing the MARC plain view (opac-showmarc.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28388 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:05:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:05:51 +0000 Subject: [Koha-bugs] [Bug 28388] Search result set is lost when viewing the MARC plain view (opac-showmarc.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28388 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:05:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:05:53 +0000 Subject: [Koha-bugs] [Bug 28422] OPAC MARC detail view doesn't correctly evaluate holdability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28422 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:05:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:05:56 +0000 Subject: [Koha-bugs] [Bug 28422] OPAC MARC detail view doesn't correctly evaluate holdability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28422 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:05:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:05:59 +0000 Subject: [Koha-bugs] [Bug 28423] JavaScript error on MARC modifications page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28423 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:06:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:06:01 +0000 Subject: [Koha-bugs] [Bug 28423] JavaScript error on MARC modifications page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28423 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:06:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:06:04 +0000 Subject: [Koha-bugs] [Bug 28427] Terminology: Shelf should be list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28427 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:06:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:06:06 +0000 Subject: [Koha-bugs] [Bug 28427] Terminology: Shelf should be list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28427 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:06:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:06:09 +0000 Subject: [Koha-bugs] [Bug 28428] Capitalization: Password Updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28428 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:06:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:06:11 +0000 Subject: [Koha-bugs] [Bug 28428] Capitalization: Password Updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28428 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:06:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:06:13 +0000 Subject: [Koha-bugs] [Bug 28443] Terminology: Issuing should be Checking out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28443 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:06:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:06:15 +0000 Subject: [Koha-bugs] [Bug 28443] Terminology: Issuing should be Checking out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28443 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:06:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:06:17 +0000 Subject: [Koha-bugs] [Bug 28476] Update info in docs/teams.yaml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28476 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:06:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:06:20 +0000 Subject: [Koha-bugs] [Bug 28476] Update info in docs/teams.yaml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28476 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:06:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:06:23 +0000 Subject: [Koha-bugs] [Bug 28479] TestBuilder.pm uses incorrect method for checking if objects to be created exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28479 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:06:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:06:26 +0000 Subject: [Koha-bugs] [Bug 28479] TestBuilder.pm uses incorrect method for checking if objects to be created exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28479 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:06:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:06:28 +0000 Subject: [Koha-bugs] [Bug 28511] Road types in OPAC should prefer OPAC description if one exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28511 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:06:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:06:30 +0000 Subject: [Koha-bugs] [Bug 28511] Road types in OPAC should prefer OPAC description if one exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28511 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:06:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:06:33 +0000 Subject: [Koha-bugs] [Bug 28513] Analytic search links formed incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28513 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:06:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:06:35 +0000 Subject: [Koha-bugs] [Bug 28513] Analytic search links formed incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28513 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:06:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:06:38 +0000 Subject: [Koha-bugs] [Bug 28522] Correct eslint errors in staff-global.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:06:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:06:40 +0000 Subject: [Koha-bugs] [Bug 28522] Correct eslint errors in staff-global.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28522 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:06:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:06:42 +0000 Subject: [Koha-bugs] [Bug 28526] Impossible to search only zero In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28526 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:06:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:06:45 +0000 Subject: [Koha-bugs] [Bug 28526] Impossible to search only zero In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28526 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:06:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:06:47 +0000 Subject: [Koha-bugs] [Bug 28542] Move new authority from Z39.50/SRU to a button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28542 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:06:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:06:50 +0000 Subject: [Koha-bugs] [Bug 28542] Move new authority from Z39.50/SRU to a button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28542 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:06:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:06:52 +0000 Subject: [Koha-bugs] [Bug 28545] Noisy uninitialized warn at opac-MARCdetail.pl line 313 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28545 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:06:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:06:55 +0000 Subject: [Koha-bugs] [Bug 28545] Noisy uninitialized warn at opac-MARCdetail.pl line 313 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28545 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:06:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:06:57 +0000 Subject: [Koha-bugs] [Bug 28582] Can't enqueue letter HASH(0x55edf1806850) at /usr/share/koha/Koha/ArticleRequest.pm line 123. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28582 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:07:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:07:00 +0000 Subject: [Koha-bugs] [Bug 28582] Can't enqueue letter HASH(0x55edf1806850) at /usr/share/koha/Koha/ArticleRequest.pm line 123. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28582 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:07:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:07:02 +0000 Subject: [Koha-bugs] [Bug 28586] Cannot resolve a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:07:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:07:05 +0000 Subject: [Koha-bugs] [Bug 28586] Cannot resolve a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 --- Comment #13 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:08:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:08:14 +0000 Subject: [Koha-bugs] [Bug 28496] Club holds form broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28496 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:08:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:08:16 +0000 Subject: [Koha-bugs] [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:08:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:08:18 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:08:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:08:20 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:08:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:08:21 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:08:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:08:23 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:21:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:21:18 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28590 --- Comment #15 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #9) > Just mentioning one compile error: > > perl -c tools/viewlog.pl Oops, there was a missing dependency on bug 28590. (In reply to Marcel de Rooy from comment #11) > - $debug and warn "Error ExportFramework $@\n"; > + Koha::Logger->get->warn("Error ExportFramework $@"); > > Warn instead of debug ? Yes, those are warnings (export errors). We can lower them later if it's too noisy. (In reply to Marcel de Rooy from comment #13) > -BEGIN { > - $DEBUG = ($ENV{DEBUG}) ? 1 : 0; > -} > > We still have other cases of using $ENV{DEBUG} ? What about them? This report was about C4::Debug only, we could extend it to DEBUG. (In reply to Marcel de Rooy from comment #14) > git grep "C4::Debug" > misc/admin/koha-preferences:use C4::Debug; > misc/admin/koha-preferences: print STDERR $message . "\n" if ( > $C4::Debug::debug ); Oops, my 'git grep' alias is not picking files without extension it seems! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28590 [Bug 28590] get_shelves_userenv and set_shelves_userenv not used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:21:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:21:18 +0000 Subject: [Koha-bugs] [Bug 28590] get_shelves_userenv and set_shelves_userenv not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28590 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28572 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 [Bug 28572] Replace C4::Debug with Koha::Logger->debug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:23:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:23:13 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #16 from Jonathan Druart --- Created attachment 122216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122216&action=edit Bug 28572: Replace missing occurrence in misc/admin/koha-preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:29:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:29:51 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #17 from Jonathan Druart --- (In reply to Jonathan Druart from comment #15) > (In reply to Marcel de Rooy from comment #9) > > -BEGIN { > > - $DEBUG = ($ENV{DEBUG}) ? 1 : 0; > > -} > > > > We still have other cases of using $ENV{DEBUG} ? What about them? > > This report was about C4::Debug only, we could extend it to DEBUG. Pfiou, that's painful. I would prefer to do that on a separate bug report, unless someone else is volunteering. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:30:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:30:00 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 12:41:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 10:41:32 +0000 Subject: [Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from borrower holds list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |jonathan.druart+koha at gmail. | |com --- Comment #6 from Jonathan Druart --- Should not we stop using syspref for the messages we display on the interface? Should we use "news" instead? See bug 26050. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 13:15:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 11:15:56 +0000 Subject: [Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 13:23:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 11:23:33 +0000 Subject: [Koha-bugs] [Bug 28516] Koha/Patrons/Import.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 --- Comment #3 from Jonathan Druart --- Koha_Master_D9/1684 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 13:29:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 11:29:06 +0000 Subject: [Koha-bugs] [Bug 28563] Add AllowHoldItemTypeSelection to HEA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28563 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23849 CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 13:29:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 11:29:06 +0000 Subject: [Koha-bugs] [Bug 23849] Update the list of sysprefs to share with Hea In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23849 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28563 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 13:32:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 11:32:04 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 13:32:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 11:32:08 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122147|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy --- Created attachment 122217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122217&action=edit Bug 28572: Remove C4::Debug We are using Koha::Logger when it makes sense to keep the info, otherwise we simply remove it Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 13:32:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 11:32:12 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122216|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy --- Created attachment 122218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122218&action=edit Bug 28572: Replace missing occurrence in misc/admin/koha-preferences Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 13:32:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 11:32:43 +0000 Subject: [Koha-bugs] [Bug 28590] get_shelves_userenv and set_shelves_userenv not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28590 --- Comment #2 from Marcel de Rooy --- Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 13:35:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 11:35:36 +0000 Subject: [Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 13:35:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 11:35:40 +0000 Subject: [Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122179|0 |1 is obsolete| | Attachment #122180|0 |1 is obsolete| | Attachment #122181|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 122219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122219&action=edit Bug 28588: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 13:35:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 11:35:53 +0000 Subject: [Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 --- Comment #8 from Kyle M Hall --- Created attachment 122220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122220&action=edit Bug 28588: Add Koha::Checkouts::ReturnClaim->resolve This patch introduces a high-level method for resolving claims. The behavior intends to replace the code in the API controller that is used for resolving a claim. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Checkouts/ReturnClaim.t => SUCCESS: Tests pass 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 13:35:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 11:35:56 +0000 Subject: [Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 --- Comment #9 from Kyle M Hall --- Created attachment 122221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122221&action=edit Bug 28588: (follow-up) Make the API use the new method This patch adapts the controller method for resolving a return claim so it uses the Koha::Checkouts::ReturnClaim method instead. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/return_claims.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 13:40:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 11:40:38 +0000 Subject: [Koha-bugs] [Bug 28590] get_shelves_userenv and set_shelves_userenv not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28590 --- Comment #3 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #1) > They are no longer used since bug 7310, now we are using > Koha::Virtualshelves->get_some_shelves Hmm. That wasnt yesterday ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 13:41:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 11:41:11 +0000 Subject: [Koha-bugs] [Bug 28590] get_shelves_userenv and set_shelves_userenv not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28590 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 13:41:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 11:41:15 +0000 Subject: [Koha-bugs] [Bug 28590] get_shelves_userenv and set_shelves_userenv not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28590 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122109|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 122222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122222&action=edit Bug 28590: Remove get_shelves_userenv and set_shelves_userenv They are no longer used since bug 7310, now we are using Koha::Virtualshelves->get_some_shelves Test plan: Create some lists, login at the OPAC and confirm that you see the list in the navbar (top) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 13:41:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 11:41:41 +0000 Subject: [Koha-bugs] [Bug 28590] get_shelves_userenv and set_shelves_userenv not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28590 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |Passed QA --- Comment #5 from Marcel de Rooy --- QA in one pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 13:42:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 11:42:55 +0000 Subject: [Koha-bugs] [Bug 26838] Improve styling of checkin message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122170|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 122223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122223&action=edit Bug 26838: Improve styling of checkin message This patch makes some changes to the style and use of the "problem" class in the staff interface: - Remove the background color - Remove the extra line height Some changes to the template: - Remove the problem class from the checkin message. The checkin message configuration determines whether the dialog is an alert or a message-style dialog. - Add Font Awesome icons to the "problem" messages in patron details and serials collection. This is to help emphasize the message for users who might have difficulty seeing the color difference. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> Item types and configure a checkin message for an item type: Add a message and select "Message" as the checkin message type. - Check in an item with that item type and confirm that you see the checkin message. It should be displayed in a message-style dialog without any additional styling. - Change the item type configuration to use "Alert" as the checkin message type. Confirm that the correct style is shown in this case as well. - Locate a patron with a NULL value in borrowers.password. View the detail page for that patron. - Under the "Library use" heading, the "Password" line should contain a link with the text "Undefined," preceded by a red-colored Font Awesome icon. - In Serials, locate a subscription which is expired. - View the details for the subscription, and then open "serial collection" from the sidebar menu. - On the serial collection page there should be a cell in the subscription summary table showing the message "Subscription expired" preceded by a red-colored Font Awesome icon. Signed-off-by: Salman Ali Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 13:43:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 11:43:22 +0000 Subject: [Koha-bugs] [Bug 26838] Improve styling of checkin message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #8 from Jonathan Druart --- Last patch fixes Salman's signed-off-by line (email address). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 13:48:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 11:48:10 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122055|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 122224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122224&action=edit Bug 28514: Remove getletter The way we handle notice templates is confusing (see bug 27660, bug 26787, bug 28487). This patch remove C4::Letters::getletter and use either Koha::Notice::Templates->find or the newly created methods ->find_effective_template that will do all necessary to return the correct template. Test plan: - Create and modify notice templates - Make sure you have TranslateNotices turned on and that some notices templates have a translated version - Use holds_reminder.pl and overdue_notices.pl cronjobs and confirm that the generated notices are the expected ones - Test also pos/printreceipt.pl - And finally test some other notices (CHECKIN, RENEWAL for instance) Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy [EDIT] Amended by removing comment for $params={%$params} JD amended patch: * Add missing POD * Fix spelling (dont ==> don't) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 13:49:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 11:49:18 +0000 Subject: [Koha-bugs] [Bug 28516] Koha/Patrons/Import.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 --- Comment #4 from Jonathan Druart --- Will also fix 13:40:55 koha_1 | # Failed test 'No tests run for subtest "extended attributes"' 13:40:55 koha_1 | # at t/db_dependent/Koha/Patrons.t line 1770. 13:40:55 koha_1 | # Looks like you failed 1 test of 110. 13:40:55 koha_1 | 13:40:55 koha_1 | # Failed test 'Test Koha::Patrons::merge' 13:40:55 koha_1 | # at t/db_dependent/Koha/Patrons.t line 1774. 13:40:55 koha_1 | Missing mandatory extended attribute (type=cX9Fk5KL)# Looks like your test exited with 11 just after 33. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 13:50:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 11:50:19 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122224|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 122225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122225&action=edit Bug 28514: Remove getletter The way we handle notice templates is confusing (see bug 27660, bug 26787, bug 28487). This patch remove C4::Letters::getletter and use either Koha::Notice::Templates->find or the newly created methods ->find_effective_template that will do all necessary to return the correct template. Test plan: - Create and modify notice templates - Make sure you have TranslateNotices turned on and that some notices templates have a translated version - Use holds_reminder.pl and overdue_notices.pl cronjobs and confirm that the generated notices are the expected ones - Test also pos/printreceipt.pl - And finally test some other notices (CHECKIN, RENEWAL for instance) Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy [EDIT] Amended by removing comment for $params={%$params} JD amended patch: * Add missing POD * Fix spelling (dont ==> don't) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 13:53:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 11:53:43 +0000 Subject: [Koha-bugs] [Bug 25477] The responsive design in opac-main.tt should be correct In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |CLOSED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 13:55:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 11:55:17 +0000 Subject: [Koha-bugs] [Bug 28242] Accessibility: OPAC - add captions and legends to tables and forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 13:58:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 11:58:11 +0000 Subject: [Koha-bugs] [Bug 28247] Add a MARC preview column to to Authority search results table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28247 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #5 from Timothy Alexis Vass --- koha-testing-docker isn't working on my computer and I'm going on holiday, so I won't be able to complete this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 13:58:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 11:58:45 +0000 Subject: [Koha-bugs] [Bug 26267] Add jQuery validator to memberentrygen.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26267 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Patch doesn't apply |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:01:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:01:14 +0000 Subject: [Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #21 from Jonathan Druart --- Looks like we are missing renew and merge. It would have been good to split this bug report. Pushing as it anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:03:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:03:16 +0000 Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:03:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:03:19 +0000 Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280 --- Comment #27 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:03:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:03:22 +0000 Subject: [Koha-bugs] [Bug 12169] Improve reliability of sip_shutdown script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12169 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:03:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:03:24 +0000 Subject: [Koha-bugs] [Bug 12169] Improve reliability of sip_shutdown script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12169 --- Comment #16 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:03:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:03:27 +0000 Subject: [Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:03:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:03:30 +0000 Subject: [Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 --- Comment #22 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:03:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:03:33 +0000 Subject: [Koha-bugs] [Bug 26838] Improve styling of checkin message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:03:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:03:36 +0000 Subject: [Koha-bugs] [Bug 26838] Improve styling of checkin message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838 --- Comment #9 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:03:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:03:38 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:03:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:03:41 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 --- Comment #18 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:03:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:03:43 +0000 Subject: [Koha-bugs] [Bug 27498] Add a link for the hold ratios to acquisitions home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:03:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:03:46 +0000 Subject: [Koha-bugs] [Bug 27498] Add a link for the hold ratios to acquisitions home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 --- Comment #23 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:03:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:03:49 +0000 Subject: [Koha-bugs] [Bug 27600] SIP2: renew_all shouldn't perform a password check In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:03:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:03:51 +0000 Subject: [Koha-bugs] [Bug 27600] SIP2: renew_all shouldn't perform a password check In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27600 --- Comment #20 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:03:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:03:54 +0000 Subject: [Koha-bugs] [Bug 27882] Move external search results links out of page heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27882 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:03:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:03:57 +0000 Subject: [Koha-bugs] [Bug 27882] Move external search results links out of page heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27882 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:04:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:04:00 +0000 Subject: [Koha-bugs] [Bug 28242] Accessibility: OPAC - add captions and legends to tables and forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:04:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:04:02 +0000 Subject: [Koha-bugs] [Bug 28242] Accessibility: OPAC - add captions and legends to tables and forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:04:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:04:05 +0000 Subject: [Koha-bugs] [Bug 28264] Transaction type is empty is cash register statistics wizard report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28264 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:04:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:04:07 +0000 Subject: [Koha-bugs] [Bug 28264] Transaction type is empty is cash register statistics wizard report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28264 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:04:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:04:10 +0000 Subject: [Koha-bugs] [Bug 28418] Show template_id of MARC modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28418 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:04:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:04:12 +0000 Subject: [Koha-bugs] [Bug 28418] Show template_id of MARC modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28418 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:04:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:04:15 +0000 Subject: [Koha-bugs] [Bug 28508] Use "Invoice number" instead of "Invoice no" on the invoice search filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28508 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:04:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:04:17 +0000 Subject: [Koha-bugs] [Bug 28508] Use "Invoice number" instead of "Invoice no" on the invoice search filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28508 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:04:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:04:20 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:04:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:04:22 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 --- Comment #20 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:04:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:04:25 +0000 Subject: [Koha-bugs] [Bug 28563] Add AllowHoldItemTypeSelection to HEA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28563 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:04:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:04:27 +0000 Subject: [Koha-bugs] [Bug 28563] Add AllowHoldItemTypeSelection to HEA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28563 --- Comment #9 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:04:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:04:47 +0000 Subject: [Koha-bugs] [Bug 28264] Transaction type is empty is cash register statistics wizard report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28264 --- Comment #6 from Jonathan Druart --- Congratulations, Ivan, for your first patch pushed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:06:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:06:05 +0000 Subject: [Koha-bugs] [Bug 28563] Add AllowHoldItemTypeSelection to HEA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28563 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121934|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 122226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122226&action=edit Bug 28563: (QA follow-up) Fix unit test Add the new preference to the UsageStats.t To test: - Run t/db_dependent/UsageStats.t - Watch it pass :) Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:06:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:06:27 +0000 Subject: [Koha-bugs] [Bug 28563] Add AllowHoldItemTypeSelection to HEA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28563 --- Comment #11 from Jonathan Druart --- Fixed bug number on second patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:08:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:08:25 +0000 Subject: [Koha-bugs] [Bug 28606] New: Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 Bug ID: 28606 Summary: Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 28572 Same as bug 28572 for $ENV{DEBUG} and $DEBUG. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 [Bug 28572] Replace C4::Debug with Koha::Logger->debug -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:08:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:08:25 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28606 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:17:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:17:33 +0000 Subject: [Koha-bugs] [Bug 28482] Floating point math prevents items from being returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28482 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.01 |21.11.00,21.05.01,20.11.07 released in| | --- Comment #13 from Fridolin Somers --- Pushed to 20.11.x for 20.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:19:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:19:29 +0000 Subject: [Koha-bugs] [Bug 28523] Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523 --- Comment #3 from Jonathan Druart --- Hi David, The "isn't in GROUP BY" error is happening when strict modes are set. To turn them off you need to edit $KOHA_CONF and set the value for to 0. Setting them globally is not enough as we are setting them when we initiate the connection to the DB: https://git.koha-community.org/Koha-community/Koha/src/commit/d3ab8dbeec188ad21c468d82ba8692e89df77a59/Koha/Database.pm#L77 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:24:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:24:57 +0000 Subject: [Koha-bugs] [Bug 28496] Club holds form broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28496 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m Status|Pushed to stable |RESOLVED --- Comment #7 from Fridolin Somers --- Depends on Bug 28273 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:24:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:24:58 +0000 Subject: [Koha-bugs] [Bug 28215] software error when updating a record - /cgi-bin/koha/cataloguing/addbiblio.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28215 --- Comment #7 from Jonathan Druart --- Which exact version of Koha are you using? And which version of Elastic? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:28:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:28:47 +0000 Subject: [Koha-bugs] [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m --- Comment #29 from Fridolin Somers --- Depends on Bug 27980 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:30:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:30:02 +0000 Subject: [Koha-bugs] [Bug 28353] Regression: Batch item deletion no longer shows which items were not removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.01,20.11.07 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #12 from Fridolin Somers --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:30:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:30:18 +0000 Subject: [Koha-bugs] [Bug 28353] Regression: Batch item deletion no longer shows which items were not removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Fridolin Somers --- Pushed to 20.11.x for 20.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:32:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:32:21 +0000 Subject: [Koha-bugs] [Bug 28598] Changing date or time format on a production server will NOT create duplicate fines and we should remove the syspref warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28598 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:32:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:32:24 +0000 Subject: [Koha-bugs] [Bug 28598] Changing date or time format on a production server will NOT create duplicate fines and we should remove the syspref warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28598 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122183|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 122227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122227&action=edit Bug 28598: Update DateFormat and TimeFormat descriptions to remove warnings To test, confirm that the warnings are present without the patch and gone with it. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:33:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:33:16 +0000 Subject: [Koha-bugs] [Bug 28204] Table highlighting is broken at the cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28204 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin Somers --- > 3) Notice that it doesn't highlight it with yellow color. Without patch, problem seems not to affect 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:34:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:34:47 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #56 from Fridolin Somers --- Depends on Bug 12362 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:34:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:34:48 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Bug 28294 depends on bug 27064, which changed state. Bug 27064 Summary: Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:34:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:34:48 +0000 Subject: [Koha-bugs] [Bug 28382] 'Reserve' should be passed through as transfer reason appropriately in branchtransfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 Bug 28382 depends on bug 27064, which changed state. Bug 27064 Summary: Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:35:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:35:28 +0000 Subject: [Koha-bugs] [Bug 28382] 'Reserve' should be passed through as transfer reason appropriately in branchtransfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED --- Comment #10 from Fridolin Somers --- Depends on Bug 27064 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:35:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:35:29 +0000 Subject: [Koha-bugs] [Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object method calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 Bug 25753 depends on bug 28382, which changed state. Bug 28382 Summary: 'Reserve' should be passed through as transfer reason appropriately in branchtransfers https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:35:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:35:29 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Bug 28520 depends on bug 28382, which changed state. Bug 28382 Summary: 'Reserve' should be passed through as transfer reason appropriately in branchtransfers https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:36:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:36:26 +0000 Subject: [Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |fridolin.somers at biblibre.co | |m --- Comment #84 from Fridolin Somers --- Depends on Bug 28317 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:36:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:36:27 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Bug 28519 depends on bug 28489, which changed state. Bug 28489 Summary: CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:37:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:37:34 +0000 Subject: [Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m Status|Pushed to stable |RESOLVED --- Comment #57 from Fridolin Somers --- Depends on Bug 26995 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:43:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:43:36 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.01 |21.11.00,21.05.01,20.11.07 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #15 from Fridolin Somers --- Pushed to 20.11.x for 20.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:47:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:47:17 +0000 Subject: [Koha-bugs] [Bug 28538] Regression - Date of birth entered without correct format causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.01 |21.11.00,21.05.01,20.11.07 released in| | --- Comment #7 from Fridolin Somers --- Pushed to 20.11.x for 20.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:48:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:48:20 +0000 Subject: [Koha-bugs] [Bug 27931] Add GET /items/:item_id/pickup_locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27931 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin Somers --- Enhancement not pushed to 20.11.x, and depends on Bug 27894 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:48:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:48:47 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 --- Comment #21 from Jonathan Druart --- There is a random failure 14:32:04 koha_1 | # Failed test 'no lang passed, default is returned' 14:32:04 koha_1 | # at t/db_dependent/Koha/Notices.t line 105. 14:32:04 koha_1 | # got: 'es-ES' 14:32:04 koha_1 | # expected: 'default' 14:32:04 koha_1 | # Looks like you failed 1 test of 7. 14:32:04 koha_1 | 14:32:04 koha_1 | # Failed test 'find_effective_template' 14:32:04 koha_1 | # at t/db_dependent/Koha/Notices.t line 135. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:49:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:49:09 +0000 Subject: [Koha-bugs] [Bug 28338] Validate item holdability and pickup location separately In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28338 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED --- Comment #18 from Fridolin Somers --- Depends on Bug 27931 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:57:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:57:33 +0000 Subject: [Koha-bugs] [Bug 28350] Sort by "circ note" is broken on the patron search result view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28350 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.01 |21.11.00,21.05.01,20.11.07 released in| | --- Comment #8 from Fridolin Somers --- Pushed to 20.11.x for 20.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 14:58:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 12:58:42 +0000 Subject: [Koha-bugs] [Bug 28607] New: Error: Session timed out. Please log in again Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28607 Bug ID: 28607 Summary: Error: Session timed out. Please log in again Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: xuan at klc.edu.sg QA Contact: testopia at bugs.koha-community.org Created attachment 122228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122228&action=edit error prompt once user login, unable to click on buttons as it redirect us to this timeout error. please advise. http://23.239.31.27:8080/cgi-bin/koha/admin/authorised_values.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 15:05:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 13:05:19 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #71 from Fridolin Somers --- Does not apply on 20.11.x, maybe because of Bug 26481 or its children. Please provide rebased patches if needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 15:11:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 13:11:51 +0000 Subject: [Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |fridolin.somers at biblibre.co | |m --- Comment #48 from Fridolin Somers --- Depends on Bug 12362 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 15:11:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 13:11:52 +0000 Subject: [Koha-bugs] [Bug 28527] Transfers that are cancelled whilst in transit should still appear as 'in transit' until they are received In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28527 Bug 28527 depends on bug 28520, which changed state. Bug 28520 Summary: Cancelling a hold that is in transit hides item's transit status https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 15:27:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 13:27:37 +0000 Subject: [Koha-bugs] [Bug 28383] Log in via the itemsearch URL leads to Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28383 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.01 |21.11.00,21.05.01,20.11.07 released in| | --- Comment #8 from Fridolin Somers --- Pushed to 20.11.x for 20.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 15:29:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 13:29:07 +0000 Subject: [Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.01 |21.11.00,21.05.01,20.11.07 released in| | Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin Somers --- Pushed to 20.11.x for 20.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 15:30:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 13:30:14 +0000 Subject: [Koha-bugs] [Bug 28488] Javascript error in self-checkout (__ is not defined) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.01 |21.11.00,21.05.01,20.11.07 released in| | --- Comment #10 from Fridolin Somers --- Pushed to 20.11.x for 20.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 15:43:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 13:43:04 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.01 |21.11.00,21.05.01,20.11.07 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #17 from Fridolin Somers --- Pushed to 20.11.x for 20.11.07 I added a followup on tests because 20.11.x does not contain Bug 27069 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 15:45:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 13:45:19 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #27 from Fridolin Somers --- Depends on Bug 28489 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 15:53:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 13:53:40 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Marcel de Rooy --- Agustin: I still have some doubts about the atomicupdate. You do an UPDATE for notice AR_PENDING and an insert for the new AR_REQUESTED. Generally we should be very careful with UPDATES on existing notices. This one is too generic and will unnecessarily? remove customized texts. The insert could be an INSERT IGNORE btw. I would suggest to use a new name for the former AR_PENDING notice and only rename it in the atomicupdate. Like AR_RECEIVED. Do not touch the text. And after that add a 'new' notice AR_PENDING (..) with the new text. In the second patch you add AR_REQUESTED but note that you insert the text for the PENDING state ! So you mix them up here. Obviously, the changes for patch1 should reflect in patch2. Changing status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 16:03:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 14:03:26 +0000 Subject: [Koha-bugs] [Bug 28608] New: Creating a biblio record leads to item creation even if framework has no items field Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 Bug ID: 28608 Summary: Creating a biblio record leads to item creation even if framework has no items field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Some framework for biblio records have no items field (952 in MARC21, 995 in UNIMARC). Records can not have items for example a serial article. In this case creating a record should not lead to item creation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 16:05:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 14:05:21 +0000 Subject: [Koha-bugs] [Bug 28608] Creating a biblio record leads to item creation even if framework has no items field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 16:07:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 14:07:38 +0000 Subject: [Koha-bugs] [Bug 26205] News changes aren't logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 16:07:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 14:07:42 +0000 Subject: [Koha-bugs] [Bug 26205] News changes aren't logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121603|0 |1 is obsolete| | Attachment #121604|0 |1 is obsolete| | Attachment #121605|0 |1 is obsolete| | Attachment #121606|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 122229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122229&action=edit Bug 26205: Add logging of news items To test: 1. Apply patch, updatedatabase, restart_all 2. Make sure the system pref 'NewsLog' is turned on. 3. Go to the Koha News tool and create a new news item. 4. View the logs and display only the OPAC News module 5. You should see your new news, it will include the lang ( OPACheader_en ) and the content of the news item. 6. Filter the logs so the only action is 'Add', your new news item should appear 7. Modify some news items 8. They should appear in the logs now as modification. 9. Make sure you can filter the action to 'Modify' and can confirm it works 10. Delete some news items 11. They should appear in the logs now as deletinon 12. Make sure you can filter the action to 'Delete' and can confirm it works Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 16:08:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 14:08:31 +0000 Subject: [Koha-bugs] [Bug 28609] New: Popularity sort is broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28609 Bug ID: 28609 Summary: Popularity sort is broken Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de Bug 13976 reported that the sort by popularity was only alphabetic and not numeric. I cannot confirm that... because now it's broken. When sorting by popularity the result list is sorted by biblionumber instead, which is the usual fallback when values are identical. When searching issues:74 or popluarity:74 records where the items have this number of issues are found correctly. So it appears the index is there and filled, but somehow not working when used for sorting? Verified in 18.11 and 20.11. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 16:14:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 14:14:04 +0000 Subject: [Koha-bugs] [Bug 28608] Creating a biblio record leads to item creation even if framework has no items field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 16:14:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 14:14:09 +0000 Subject: [Koha-bugs] [Bug 28608] Creating a biblio record leads to item creation even if framework has no items field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 --- Comment #1 from Fridolin Somers --- Created attachment 122230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122230&action=edit Bug 28608: Creating a biblio record must not lead to item creation when framework has no items field Some framework for biblio records have no items field (952 in MARC21, 995 in UNIMARC). Records can not have items for example a serial article. In this case creating a record should not lead to item creation. This patch adds a condition next to items edition permission to have only one save button when framework has no items field. 1) Create a biblio framework without items field (952 in MARC21, 995 in UNIMARC) 2) Create a biblio record with this framework 3) Click on "Save" => Without patch you see items creation page (with no inputs in form) => With patch you see record details page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 16:16:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 14:16:25 +0000 Subject: [Koha-bugs] [Bug 28608] Creating a biblio record leads to item creation even if framework has no items field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 --- Comment #2 from Fridolin Somers --- We may hide other things when framework has no items field. Maybe we will create a method has_items() in Koha::BiblioFramework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 16:35:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 14:35:29 +0000 Subject: [Koha-bugs] [Bug 26205] News changes aren't logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122229|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall --- Created attachment 122231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122231&action=edit Bug 26205: Add logging of news items To test: 1. Apply patch, updatedatabase, restart_all 2. Make sure the system pref 'NewsLog' is turned on. 3. Go to the Koha News tool and create a new news item. 4. View the logs and display only the OPAC News module 5. You should see your new news, it will include the lang ( OPACheader_en ) and the content of the news item. 6. Filter the logs so the only action is 'Add', your new news item should appear 7. Modify some news items 8. They should appear in the logs now as modification. 9. Make sure you can filter the action to 'Modify' and can confirm it works 10. Delete some news items 11. They should appear in the logs now as deletinon 12. Make sure you can filter the action to 'Delete' and can confirm it works Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 16:35:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 14:35:42 +0000 Subject: [Koha-bugs] [Bug 26205] News changes aren't logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 --- Comment #26 from Kyle M Hall --- Created attachment 122232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122232&action=edit Bug 26205: (QA follow-up) Capitalization: OPAC News Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 16:35:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 14:35:45 +0000 Subject: [Koha-bugs] [Bug 26205] News changes aren't logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 --- Comment #27 from Kyle M Hall --- Created attachment 122233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122233&action=edit Bug 26205: (QA follow-up) Change OPACNEWS to just NEWS As news are usable in OPAC and staff interface, I suggest changing the code to just be NEWS instead of OPACNEWS. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 16:35:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 14:35:49 +0000 Subject: [Koha-bugs] [Bug 26205] News changes aren't logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 --- Comment #28 from Kyle M Hall --- Created attachment 122234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122234&action=edit Bug 26205: (QA follow-up) Add punctuation and widen pref description a bit Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 16:50:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 14:50:45 +0000 Subject: [Koha-bugs] [Bug 28587] ldap auth fails unless In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28587 --- Comment #3 from Jerry Marceau --- For Dobrica - thanks for the response. It doesn't really matter to me if this gets 'fixed' or not - I put the bug in so other people could find it if they had the same situation. Making the change in koha-conf.xml is trivial. You're right that the documentation has id="ldapserver", but I don't think it is clear that it has to be set that way. I read the id="ldapserver" as variable - you'd set this to whatever you wanted to call your ldapserver (in our case the short server name). This seems to fit better with HTML and XML in general - you wouldn't have
    , you'd want the ID to be unique to set it apart. But in this case there aren't going to be multiple ldapservers, so maybe it doesn't matter. David - you're right - it is not for the main/official libraries. We have a few 'media lab' spaces that circulate AV gear - still and video cameras, microphones, etc. They found the library's system (millennium, I think) didn't work well for this sort of equipment. They did the research and settled on Koha - it has worked well for them and hasn't been too much work for me as an administrator. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 17:02:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 15:02:54 +0000 Subject: [Koha-bugs] [Bug 19684] Colon char in MARC data breaks facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19684 --- Comment #8 from Fridolin Somers --- Still valid ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 17:25:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 15:25:21 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement serves to |This enhancement serves to release notes|clarify how the account |clarify how the account |offsets table functions. |offsets table functions. |We record all account |We record all account |actions in this table, |actions in this table, |including accountline |including accountline |creations, modifications |creations, modifications |and offsets. |and offsets. | | |Prior to this |Prior to this |patch we had a large number |patch we had a large number |of different offset types, |of different offset types, |one for each accountline. |one for each accountline |But we didn't clearly |type. But we didn't clearly |define what the offset was |define what the offset was |actually "doing". This |actually "doing". This |patch replaces the existing |patch replaces the existing |offset types with a refined |offset types with a refined |list; `CREATE`, `APPLY`, |list; `CREATE`, `APPLY`, |`OVERDUE_INCREASE` and |`OVERDUE_INCREASE`, |`OVERDUE_DECREASE`. |`OVERDUE_DECREASE` and | |`VOID`. |The | |accountline details page, |The accountline |accessible from the |details page, accessible |borrower account |from the borrower account |transactions table is |transactions table is |updated to display the |updated to display the |whole history of the |whole history of the |selected accountline. |selected accountline, | |including creation | |(CREATE), increments | |(OVERDUE_INCREASE/DECREASE) | |and offsets (Application of | |payments, cancellations, | |voids, writeoffs and | |refunds). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 17:59:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 15:59:59 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122148|0 |1 is obsolete| | --- Comment #109 from Martin Renvoize --- Created attachment 122235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122235&action=edit Bug 22435: Update CREATE offset types Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 18:00:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 16:00:04 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122149|0 |1 is obsolete| | --- Comment #110 from Martin Renvoize --- Created attachment 122236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122236&action=edit Bug 22435: Use 'CREATE' offset type in Koha::Account This patch updates the Koha::Account methods for adding debits and credits to use the 'CREATE' offset type for the creation record. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 18:00:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 16:00:09 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122150|0 |1 is obsolete| | --- Comment #111 from Martin Renvoize --- Created attachment 122237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122237&action=edit Bug 22435: Use 'CREATE' offset type in Koha::Account::Line This patch updates the Koha::Account::Line methods that result in new account lines to use the 'CREATE' offset type for the creation record. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 18:00:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 16:00:14 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122151|0 |1 is obsolete| | --- Comment #112 from Martin Renvoize --- Created attachment 122238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122238&action=edit Bug 22435: Add 'APPLY' to account_offset_types Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 18:00:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 16:00:19 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122152|0 |1 is obsolete| | --- Comment #113 from Martin Renvoize --- Created attachment 122239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122239&action=edit Bug 22435: ->apply() should always use 'APPLY' for offset_type Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 18:00:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 16:00:24 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122153|0 |1 is obsolete| | --- Comment #114 from Martin Renvoize --- Created attachment 122240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122240&action=edit Bug 22435: Update unit tests This patch updates the unit tests to reflect the changes we have made to offset types. We do two things: 1) Clean up calls to 'apply' to drop passing offset_type 2) Update test code to look for APPLY and CREATE instead of specific offset types. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 18:00:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 16:00:29 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122154|0 |1 is obsolete| | --- Comment #115 from Martin Renvoize --- Created attachment 122241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122241&action=edit Bug 22435: Fix CREATE offset amounts Updateing the tests highlighted a mistake in the original code.. the offsets for the cancel and reduce creation lines were incorrectly signed. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 18:00:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 16:00:34 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122155|0 |1 is obsolete| | --- Comment #116 from Martin Renvoize --- Created attachment 122242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122242&action=edit Bug 22435: Fix _set_found_trigger The _set_found_trigger utilised the 'Writeoff' offset type to distinguish between the application of a writeoff and any other form of offset application. This patch updates the trigger to use the full link through from offset to account credit line to get the credit type being offset. Test plan 1/ Run t/db_dependent/Koha/Items.t and prove it fails before the patch, but passes after applying this patch. 2/ Run t/db_dependent/Koha/Account/Offsets.t and prove it passes both before and after applying this patch. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 18:00:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 16:00:39 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122156|0 |1 is obsolete| | --- Comment #117 from Martin Renvoize --- Created attachment 122243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122243&action=edit Bug 22435: Update for bug 27049 Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 18:00:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 16:00:45 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122157|0 |1 is obsolete| | --- Comment #118 from Martin Renvoize --- Created attachment 122244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122244&action=edit Bug 22435: Update accountline-details page to show all history The accountline-details page took a simplistic approach to displaying the history of an accountline. This patch drops the now defunct offset_type_description template block from it's respective include files, and then updates the accountline-details template and controller to show the full history of what's happend to the accountline passed. This includes the creation, any increments/decrements (for fines), and finally any offsets against the total (payments, cancellations, voids). Test plan 1/ Create some credits and debits and apply them to each other in various combinations. 2/ View the 'Details' page for some of the debit/credits 3/ Compare before patch and after for the Details page. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 18:00:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 16:00:50 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122158|0 |1 is obsolete| | --- Comment #119 from Martin Renvoize --- Created attachment 122245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122245&action=edit Bug 22435: Improve database update Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 18:00:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 16:00:55 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122161|0 |1 is obsolete| | --- Comment #120 from Martin Renvoize --- Created attachment 122246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122246&action=edit Bug 22435: (QA follow-up) Fix test file and adjust test Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 18:01:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 16:01:01 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 --- Comment #121 from Martin Renvoize --- Created attachment 122247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122247&action=edit Bug 22435: (follow-up) Update POS for reduced offset types This patch updates the Koha::Charges::Sales class to use the 'CREATE' and 'APPLY' offset types. Test plan 1/ Run t/db_dependent/Koha/Charges/Sales.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 18:01:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 16:01:06 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 --- Comment #122 from Martin Renvoize --- Created attachment 122248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122248&action=edit Bug 22435: (follow-up) Drop account_offset_types table This patch drops the now defunkt account_offset_types table and ensure the type field in account_offsets is instead an enum type column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 18:01:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 16:01:11 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 --- Comment #123 from Martin Renvoize --- Created attachment 122249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122249&action=edit Bug 22435: (QA follow-up) Add missing test for manager relation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 18:01:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 16:01:16 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 --- Comment #124 from Martin Renvoize --- Created attachment 122250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122250&action=edit Bug 22435: (QA follow-up) Fix test for offset total This patch updates the test for the offset total method to adhere to the new restricted set of offset types available. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 18:01:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 16:01:21 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 --- Comment #125 from Martin Renvoize --- Created attachment 122251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122251&action=edit Bug 22435: Update DBIC Schema's -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 18:12:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 16:12:23 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122159|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 18:12:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 16:12:33 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122160|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 18:13:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 16:13:02 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 --- Comment #126 from Martin Renvoize --- Created attachment 122252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122252&action=edit Bug 22435: (QA follow-up) Fix returned offsets in moredetail This patch updates the offsets query for lost item returns displayed in the catalogue/moredetail controller. Test plan 1/ Check item detail display for a lost item at various stages of lost and charged for (Lost, Writeoff, Forgiven, Paid, Found) 2/ Compare before the patchset and after - There should be no difference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 18:21:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 16:21:58 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 18:23:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 16:23:28 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 --- Comment #127 from Martin Renvoize --- So, I managed to miss a commit from Bugzilla.. but whilst retrieving it I spotted a couple of issues which I've also dealt with as follow-ups here (as well as including a Schema Update for ease of testing). I've also updated the 'Text for release notes' a bit to embellish the details a little more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 19:33:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 17:33:20 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 --- Comment #128 from Martin Renvoize --- Created attachment 122253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122253&action=edit Bug 22435: (QA follow-up) More test updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 19:53:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 17:53:12 +0000 Subject: [Koha-bugs] [Bug 28608] Creating a biblio record leads to item creation even if framework has no items field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 --- Comment #3 from Hakam Almotlak --- Created attachment 122254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122254&action=edit Issue #6 - list of bugs applied must be global https://bugs.koha-community.org/show_bug.cgi?id=28608 Signed-off-by: hakam -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 19:56:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 17:56:37 +0000 Subject: [Koha-bugs] [Bug 28608] Creating a biblio record leads to item creation even if framework has no items field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hakam.almotlak at inLibro.com Attachment #122254|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 19:59:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 17:59:38 +0000 Subject: [Koha-bugs] [Bug 28608] Creating a biblio record leads to item creation even if framework has no items field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122230|0 |1 is obsolete| | --- Comment #4 from Hakam Almotlak --- Created attachment 122255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122255&action=edit Bug 28608: Creating a biblio record must not lead to item creation when framework has no items field Some framework for biblio records have no items field (952 in MARC21, 995 in UNIMARC). Records can not have items for example a serial article. In this case creating a record should not lead to item creation. This patch adds a condition next to items edition permission to have only one save button when framework has no items field. 1) Create a biblio framework without items field (952 in MARC21, 995 in UNIMARC) 2) Create a biblio record with this framework 3) Click on "Save" => Without patch you see items creation page (with no inputs in form) => With patch you see record details page Signed-off-by: hakam -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 20:00:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 18:00:21 +0000 Subject: [Koha-bugs] [Bug 28608] Creating a biblio record leads to item creation even if framework has no items field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 21:17:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 19:17:22 +0000 Subject: [Koha-bugs] [Bug 27498] Add a link for the hold ratios to acquisitions home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 21:17:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 19:17:59 +0000 Subject: [Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 21:19:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 19:19:23 +0000 Subject: [Koha-bugs] [Bug 28542] Move new authority from Z39.50/SRU to a button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28542 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 21:23:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 19:23:04 +0000 Subject: [Koha-bugs] [Bug 28423] JavaScript error on MARC modifications page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28423 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch makes a minor release notes| |change to the MARC | |modifications template | |(Staff interface > | |Administration > MARC | |modification templates) so | |that the "mmtas" variable | |isn't defined if there is | |no JSON to be assigned as | |its value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 21:23:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 19:23:50 +0000 Subject: [Koha-bugs] [Bug 28422] OPAC MARC detail view doesn't correctly evaluate holdability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28422 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 21:27:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 19:27:05 +0000 Subject: [Koha-bugs] [Bug 28280] Item types configuration page doesn't use Price filter for default replacement cost and processing fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28280 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the display of release notes| |'Default replacement cost' | |and a | |'Processing fee (when | |lost)' when adding item | |types so that amounts use | |two decimals instead of | |six. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 21:37:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 19:37:55 +0000 Subject: [Koha-bugs] [Bug 21286] Advanced search for Corporate-name creates Zebra errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21286 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the advanced release notes| |search in the staff | |interface so that searching | |using the 'Corporate name' | |index now works correctly | |when the QueryAutoTruncate | |system preference is not | |enabled. Before this a | |search (using Zebra) for a | |name such as 'House plants' | |would not return any | |results and generate error | |messages in the log files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 22:14:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 20:14:38 +0000 Subject: [Koha-bugs] [Bug 28609] Popularity sort is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28609 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 22:52:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 20:52:05 +0000 Subject: [Koha-bugs] [Bug 27540] Allow local definition of gender options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27540 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Andrew Fuerste-Henry --- *** This bug has been marked as a duplicate of bug 23609 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 22:52:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 20:52:05 +0000 Subject: [Koha-bugs] [Bug 23609] Tie patron gender to an authorized value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23609 --- Comment #1 from Andrew Fuerste-Henry --- *** Bug 27540 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 23:05:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 21:05:59 +0000 Subject: [Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from borrower holds list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 --- Comment #7 from Katrin Fischer --- (In reply to Jonathan Druart from comment #6) > Should not we stop using syspref for the messages we display on the > interface? Should we use "news" instead? > > See bug 26050. Actually, I think you are right. It would also be fair, since we had a similar thing just rewritten and this is a quite new patch set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 21 23:26:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 21:26:49 +0000 Subject: [Koha-bugs] [Bug 28264] Transaction type is empty in cash register statistics wizard report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Transaction type is empty |Transaction type is empty |is cash register statistics |in cash register statistics |wizard report |wizard report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 00:16:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 22:16:48 +0000 Subject: [Koha-bugs] [Bug 28563] Add AllowHoldItemTypeSelection to HEA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28563 --- Comment #12 from Katrin Fischer --- (In reply to Jonathan Druart from comment #11) > Fixed bug number on second patch. Argh, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 00:47:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 22:47:41 +0000 Subject: [Koha-bugs] [Bug 28215] software error when updating a record - /cgi-bin/koha/cataloguing/addbiblio.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28215 --- Comment #8 from cfhong2000 at gmail.com --- I am running Koha version 20.11.03 and Elasticsearch version 6.8.9. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 01:13:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 23:13:31 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #28 from David Cook --- (In reply to Marcel de Rooy from comment #26) > Hi David, > I understand 'We do not have a lib folder' point. > But still wondering (especially since this report just creates a > CGI::Session variant in lib): > > > We could have fooled Koha too by making our own package and install it in a > > regular perllib ? I still don't know what you mean by "we could have fooled Koha", or "our own package", or "regular perllib". Do you mean a Perl package or a Debian package? What do you mean by "perllib"? Do you mean PERL5LIB, site Perl, vendor Perl, Koha's top-level directory where we store C4 and Koha dirs, or something else? How would it be fooling Koha? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 01:22:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 23:22:35 +0000 Subject: [Koha-bugs] [Bug 28608] Creating a biblio record leads to item creation even if framework has no items field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #5 from David Cook --- Interesting! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 01:27:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 23:27:14 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #20 from David Cook --- Awesome. I don't think C4::Debug even works that well with Plack? Looking forward to seeing this one in action.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 01:30:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 23:30:25 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 01:31:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Jun 2021 23:31:27 +0000 Subject: [Koha-bugs] [Bug 28600] Variable "$patron" is not available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 02:51:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 00:51:22 +0000 Subject: [Koha-bugs] [Bug 28482] Floating point math prevents items from being returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28482 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.11.00,21.05.01,20.11.07 |21.11.00,21.05.01,20.11.07, released in| |20.05.13 --- Comment #14 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 02:57:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 00:57:13 +0000 Subject: [Koha-bugs] [Bug 28353] Regression: Batch item deletion no longer shows which items were not removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #14 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 03:04:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 01:04:56 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.11.00,21.05.01,20.11.07 |21.11.00,21.05.01,20.11.07, released in| |20.05.13 CC| |victor at tuxayo.net --- Comment #16 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 03:06:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 01:06:47 +0000 Subject: [Koha-bugs] [Bug 28538] Regression - Date of birth entered without correct format causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.11.00,21.05.01,20.11.07 |21.11.00,21.05.01,20.11.07, released in| |20.05.13 --- Comment #8 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 03:07:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 01:07:32 +0000 Subject: [Koha-bugs] [Bug 28350] Sort by "circ note" is broken on the patron search result view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28350 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 03:07:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 01:07:58 +0000 Subject: [Koha-bugs] [Bug 28383] Log in via the itemsearch URL leads to Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28383 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 03:08:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 01:08:57 +0000 Subject: [Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #10 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 03:09:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 01:09:18 +0000 Subject: [Koha-bugs] [Bug 28488] Javascript error in self-checkout (__ is not defined) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #11 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 04:43:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 02:43:02 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.11.00,21.05.01,20.11.07 |21.11.00,21.05.01,20.11.07, released in| |20.05.13 --- Comment #18 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 06:31:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 04:31:33 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED --- Comment #19 from Victor Grousset/tuxayo --- Nope. t/db_dependent/Circulation.t .. 1/50 # Failed test 'Cannot renew, reserved' # at t/db_dependent/Circulation.t line 353. # got: '1' # expected: '0' # Failed test 'Cannot renew, reserved (returned error is on_reserve)' # at t/db_dependent/Circulation.t line 354. # got: undef # expected: 'on_reserve' # Looks like you failed 2 tests of 5. t/db_dependent/Circulation.t .. 15/50 # Failed test 'CanBookBeRenewed AllowRenewalIfOtherItemsAvailable multiple borrowers and items tests' -------------- Please investigate this failure if these patches are needed for 20.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 07:23:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 05:23:15 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.01,20.11.07, |21.11.00,21.05.01,20.11.07 released in|20.05.13 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 08:47:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 06:47:23 +0000 Subject: [Koha-bugs] [Bug 28609] Popularity sort is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28609 Christian Stelzenmüller changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christian.stelzenmueller at bs | |z-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 09:33:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 07:33:22 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #51 from Victor Grousset/tuxayo --- I forgot I tested this in the past. What should be expected to be different from comment 11 results? - Should I still have to quote stuff (the cases of comment 8) - Should some stuff return results instead of none? - No crash I guess? Speaking of that: With QueryAutoTruncate=only if * For a search of the following and a record named the following: The reserved characters are: + - = && || > < ! ( ) { } [ ] ^ " ~ * ? : \ / => Error: Unable to perform your search With QueryAutoTruncate=auto For a search of the following and a record named the following: The reserved characters are: + - = && || > < ! ( ) { } [ ] ^ " ~ * ? : \ / => Error: Unable to perform your search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 09:52:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 07:52:00 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122235|0 |1 is obsolete| | --- Comment #129 from Martin Renvoize --- Created attachment 122256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122256&action=edit Bug 22435: Update CREATE offset types Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 09:52:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 07:52:05 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122236|0 |1 is obsolete| | --- Comment #130 from Martin Renvoize --- Created attachment 122257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122257&action=edit Bug 22435: Use 'CREATE' offset type in Koha::Account This patch updates the Koha::Account methods for adding debits and credits to use the 'CREATE' offset type for the creation record. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 09:52:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 07:52:10 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122237|0 |1 is obsolete| | --- Comment #131 from Martin Renvoize --- Created attachment 122258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122258&action=edit Bug 22435: Use 'CREATE' offset type in Koha::Account::Line This patch updates the Koha::Account::Line methods that result in new account lines to use the 'CREATE' offset type for the creation record. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 09:52:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 07:52:15 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122238|0 |1 is obsolete| | --- Comment #132 from Martin Renvoize --- Created attachment 122259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122259&action=edit Bug 22435: Add 'APPLY' to account_offset_types Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 09:52:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 07:52:20 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122239|0 |1 is obsolete| | --- Comment #133 from Martin Renvoize --- Created attachment 122260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122260&action=edit Bug 22435: ->apply() should always use 'APPLY' for offset_type Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 09:52:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 07:52:25 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122240|0 |1 is obsolete| | --- Comment #134 from Martin Renvoize --- Created attachment 122261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122261&action=edit Bug 22435: Update unit tests This patch updates the unit tests to reflect the changes we have made to offset types. We do two things: 1) Clean up calls to 'apply' to drop passing offset_type 2) Update test code to look for APPLY and CREATE instead of specific offset types. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 09:52:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 07:52:30 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122241|0 |1 is obsolete| | --- Comment #135 from Martin Renvoize --- Created attachment 122262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122262&action=edit Bug 22435: Fix CREATE offset amounts Updateing the tests highlighted a mistake in the original code.. the offsets for the cancel and reduce creation lines were incorrectly signed. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 09:52:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 07:52:35 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122242|0 |1 is obsolete| | --- Comment #136 from Martin Renvoize --- Created attachment 122263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122263&action=edit Bug 22435: Fix _set_found_trigger The _set_found_trigger utilised the 'Writeoff' offset type to distinguish between the application of a writeoff and any other form of offset application. This patch updates the trigger to use the full link through from offset to account credit line to get the credit type being offset. Test plan 1/ Run t/db_dependent/Koha/Items.t and prove it fails before the patch, but passes after applying this patch. 2/ Run t/db_dependent/Koha/Account/Offsets.t and prove it passes both before and after applying this patch. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 09:52:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 07:52:41 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122243|0 |1 is obsolete| | --- Comment #137 from Martin Renvoize --- Created attachment 122264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122264&action=edit Bug 22435: Update for bug 27049 Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 09:52:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 07:52:46 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122244|0 |1 is obsolete| | --- Comment #138 from Martin Renvoize --- Created attachment 122265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122265&action=edit Bug 22435: Update accountline-details page to show all history The accountline-details page took a simplistic approach to displaying the history of an accountline. This patch drops the now defunct offset_type_description template block from it's respective include files, and then updates the accountline-details template and controller to show the full history of what's happend to the accountline passed. This includes the creation, any increments/decrements (for fines), and finally any offsets against the total (payments, cancellations, voids). Test plan 1/ Create some credits and debits and apply them to each other in various combinations. 2/ View the 'Details' page for some of the debit/credits 3/ Compare before patch and after for the Details page. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 09:52:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 07:52:51 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122245|0 |1 is obsolete| | --- Comment #139 from Martin Renvoize --- Created attachment 122266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122266&action=edit Bug 22435: Improve database update Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 09:52:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 07:52:56 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122246|0 |1 is obsolete| | --- Comment #140 from Martin Renvoize --- Created attachment 122267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122267&action=edit Bug 22435: (QA follow-up) Fix test file and adjust test Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 09:53:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 07:53:01 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122247|0 |1 is obsolete| | --- Comment #141 from Martin Renvoize --- Created attachment 122268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122268&action=edit Bug 22435: (follow-up) Update POS for reduced offset types This patch updates the Koha::Charges::Sales class to use the 'CREATE' and 'APPLY' offset types. Test plan 1/ Run t/db_dependent/Koha/Charges/Sales.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 09:53:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 07:53:06 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122248|0 |1 is obsolete| | --- Comment #142 from Martin Renvoize --- Created attachment 122269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122269&action=edit Bug 22435: (follow-up) Drop account_offset_types table This patch drops the now defunkt account_offset_types table and ensure the type field in account_offsets is instead an enum type column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 09:53:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 07:53:11 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122249|0 |1 is obsolete| | --- Comment #143 from Martin Renvoize --- Created attachment 122270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122270&action=edit Bug 22435: (QA follow-up) Add missing test for manager relation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 09:53:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 07:53:16 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122250|0 |1 is obsolete| | --- Comment #144 from Martin Renvoize --- Created attachment 122271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122271&action=edit Bug 22435: (QA follow-up) Fix test for offset total This patch updates the test for the offset total method to adhere to the new restricted set of offset types available. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 09:53:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 07:53:21 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122251|0 |1 is obsolete| | --- Comment #145 from Martin Renvoize --- Created attachment 122272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122272&action=edit Bug 22435: Update DBIC Schema's -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 09:53:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 07:53:26 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122252|0 |1 is obsolete| | --- Comment #146 from Martin Renvoize --- Created attachment 122273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122273&action=edit Bug 22435: (QA follow-up) Fix returned offsets in moredetail This patch updates the offsets query for lost item returns displayed in the catalogue/moredetail controller. Test plan (Same as bug 19919) Test plan: 1) Pay off a LOST item 2) Check for the associated display of 'Paidfor?:' on the itemdetails page 3) Writeoff a LOST item 4) Check that a 'Paidfor?:' is not displayed on the itemdetails page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 09:53:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 07:53:32 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122253|0 |1 is obsolete| | --- Comment #147 from Martin Renvoize --- Created attachment 122274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122274&action=edit Bug 22435: (QA follow-up) More test updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 09:58:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 07:58:06 +0000 Subject: [Koha-bugs] [Bug 23035] Intranet search is slow if thousands of items are in the biblios shown in the search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23035 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |emmi.takkinen at koha-suomi.fi |ity.org | Status|NEW |ASSIGNED CC| |emmi.takkinen at koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 10:31:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 08:31:15 +0000 Subject: [Koha-bugs] [Bug 23035] Intranet search is slow if thousands of items are in the biblios shown in the search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23035 --- Comment #3 from Emmi Takkinen --- (In reply to Jonathan Druart from comment #1) > A quick and (hopefully) efficient change would be to replace the SELECT from > authorised_values by a call to C4::Koha::GetAuthorisedValues (the cache is > used there). This does indeed improve search speed quite a bit. Tested this in test environment where biblios usually have from ten to thousand items and in most cases search time was halved. I think this change along side with syspref introduced in bug 28373 would be a good start to make search work faster. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 11:03:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 09:03:52 +0000 Subject: [Koha-bugs] [Bug 25684] ElasticSearch 7 start crash: at least one of [discovery.seed_hosts, discovery.seed_providers, cluster.initial_master_nodes] must be configured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25684 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin.carnes at ub.lu.se --- Comment #2 from Kevin Carnes --- Adding "- discovery.type=single-node" under environment in docker-compose.es7.yml fixed the problem for me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 11:24:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 09:24:51 +0000 Subject: [Koha-bugs] [Bug 28610] New: Elasticsearch 7 - hits.total is now an object Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610 Bug ID: 28610 Summary: Elasticsearch 7 - hits.total is now an object Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: kevin.carnes at ub.lu.se In Elasticsearch 7 hits.total is now an object (https://www.elastic.co/guide/en/elasticsearch/reference/7.0/breaking-changes-7.0.html#hits-total-now-object-search-response). The total is now in $result->{hits}->{total}->{value} instead of $result->{hits}->{total}. There is also $result->{hits}->{total}->{relation} which specifies if the value is exact or if it's a lower bound. So it's possible to say "Your search returned > 10000 results." You can always get an exact total by adding a track_total_hits parameter set to true when using the Elasticsearch search method (https://www.elastic.co/guide/en/elasticsearch/reference/7.0/breaking-changes-7.0.html#track-total-hits-10000-default). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 11:25:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 09:25:46 +0000 Subject: [Koha-bugs] [Bug 28610] Elasticsearch 7 - hits.total is now an object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25439 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 11:25:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 09:25:46 +0000 Subject: [Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28610 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610 [Bug 28610] Elasticsearch 7 - hits.total is now an object -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 11:27:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 09:27:41 +0000 Subject: [Koha-bugs] [Bug 28610] Elasticsearch 7 - hits.total is now an object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 11:41:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 09:41:13 +0000 Subject: [Koha-bugs] [Bug 23035] Intranet search is slow if thousands of items are in the biblios shown in the search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23035 --- Comment #4 from Emmi Takkinen --- Created attachment 122275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122275&action=edit Bug 23035: Use GetAuthorisedValues in transformMARCXML4XSLT Intranet search is slow if thousands of items are in the biblios shown in the search results. Using GetAuthorisedValues (which uses cache) instead of GetAuthorisedValueDesc in transformMARCXML4XSLT significantly speeds up search time. To test: 1. Add biblio or biblios with hundreds/thousands items. 2. Tab F12 and select 'Network' to view time spent on search. 3. Perform search, note how long search takes to finnish. 4. Apply patch. 5. Repeat search. => Note that search should now work faster. Also prove t/db_dependent/XSLT.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 11:46:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 09:46:06 +0000 Subject: [Koha-bugs] [Bug 28611] New: Incorrect Select2 width Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 Bug ID: 28611 Summary: Incorrect Select2 width Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Cataloging Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The width picked by Select2 is not correct, the longest option's size is used but: * it is sometimes split on two lines * the close button hides the end of the value https://snipboard.io/v4P7HN.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 11:47:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 09:47:57 +0000 Subject: [Koha-bugs] [Bug 28611] Incorrect Select2 width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 --- Comment #1 from Jonathan Druart --- Created attachment 122276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122276&action=edit Bug 28611: Fix width to 50% for additem form elements This patch suggests to set the width of select and input to 50% -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 11:49:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 09:49:01 +0000 Subject: [Koha-bugs] [Bug 28611] Incorrect Select2 width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |oleonard at myacpl.org Status|ASSIGNED |In Discussion --- Comment #2 from Jonathan Druart --- With this patch applied: https://snipboard.io/rME6z3.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 11:51:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 09:51:37 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 11:57:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 09:57:49 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 --- Comment #22 from Jonathan Druart --- Created attachment 122277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122277&action=edit Bug 28514: Set lang to default is not passed It fixes the following test: # Failed test 'no lang passed, default is returned' # at t/db_dependent/Koha/Notices.t line 105. # got: 'es-ES' # expected: 'default' # Looks like you failed 1 test of 7. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 12:04:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 10:04:22 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #21 from Jonathan Druart --- Second patch will be squashed when pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 12:05:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 10:05:40 +0000 Subject: [Koha-bugs] [Bug 28598] Changing date or time format on a production server will NOT create duplicate fines and we should remove the syspref warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28598 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Assignee|koha-bugs at lists.koha-commun |andrew at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 12:06:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 10:06:19 +0000 Subject: [Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 12:14:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 10:14:45 +0000 Subject: [Koha-bugs] [Bug 28570] bor_issues_top.pl using a /tmp file to log debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28570 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 12:14:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 10:14:48 +0000 Subject: [Koha-bugs] [Bug 28570] bor_issues_top.pl using a /tmp file to log debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28570 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 12:14:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 10:14:50 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 12:14:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 10:14:53 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #22 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 12:14:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 10:14:56 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 12:14:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 10:14:58 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #32 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 12:14:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 10:14:59 +0000 Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 --- Comment #23 from Jonathan Druart --- Follow-up pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 12:15:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 10:15:01 +0000 Subject: [Koha-bugs] [Bug 28590] get_shelves_userenv and set_shelves_userenv not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28590 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 12:15:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 10:15:03 +0000 Subject: [Koha-bugs] [Bug 28590] get_shelves_userenv and set_shelves_userenv not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28590 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 12:15:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 10:15:06 +0000 Subject: [Koha-bugs] [Bug 28591] debug passed to get_template_and_user but not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28591 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 12:15:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 10:15:08 +0000 Subject: [Koha-bugs] [Bug 28591] debug passed to get_template_and_user but not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28591 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 12:15:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 10:15:11 +0000 Subject: [Koha-bugs] [Bug 28598] Changing date or time format on a production server will NOT create duplicate fines and we should remove the syspref warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28598 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 12:15:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 10:15:13 +0000 Subject: [Koha-bugs] [Bug 28598] Changing date or time format on a production server will NOT create duplicate fines and we should remove the syspref warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28598 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 12:59:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 10:59:02 +0000 Subject: [Koha-bugs] [Bug 28612] New: Log manager_id with multipayment Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28612 Bug ID: 28612 Summary: Log manager_id with multipayment Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: black23 at gmail.com QA Contact: testopia at bugs.koha-community.org Hello, if an individual payment is made and the corresponding logging is enabled, the manager_id is also saved when the fee is paid. This is then displayed in the Koha staff interface. However, if multiple fees are paid at the same time, the manager_id is stored as NULL in the database. The interface then does not display information about when the items were handled. https://prnt.sc/1347jik Thank you. Michal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 13:00:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 11:00:23 +0000 Subject: [Koha-bugs] [Bug 28612] Log manager_id with multipayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28612 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com, | |dcook at prosentient.com.au, | |jonathan.druart+koha at gmail. | |com, | |josef.moravec at gmail.com, | |katrin.fischer at bsz-bw.de, | |rbit at rbit.cz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 13:27:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 11:27:35 +0000 Subject: [Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480 --- Comment #7 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #5) > Aren't they missing for other routes as well? Shouldn't we have a test to > catch missing occurrences? Do you want a follow-up? Here? Separate bug? I can take care of that. I think we could have a test on the QA tools raise a warning, as some routes are not yet (maybe never) implemented using our stack (e.g. /ill_backends and /illrequests). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 13:49:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 11:49:43 +0000 Subject: [Koha-bugs] [Bug 28613] New: Several objects.search-based routes missing parameters Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28613 Bug ID: 28613 Summary: Several objects.search-based routes missing parameters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com The objects.search helper provides convenient ways to paginate and a 'q' filter parameter to build complex queries on this Koha::Objects-based routes. Some routes were created prior to this feature getting introduced. We need to adjust the parameters for all existing objects.search-based routes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 13:49:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 11:49:58 +0000 Subject: [Koha-bugs] [Bug 28613] Several objects.search-based routes missing parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28613 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28480 Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480 [Bug 28480] GET /patrons missing q parameters on the spec -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 13:49:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 11:49:58 +0000 Subject: [Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28613 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28613 [Bug 28613] Several objects.search-based routes missing parameters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 13:55:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 11:55:46 +0000 Subject: [Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA QA Contact| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 13:56:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 11:56:51 +0000 Subject: [Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 122278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122278&action=edit Bug 28613: Add missing parameters to objects.search-based routes The objects.search helper provides convenient ways to paginate and a 'q' filter parameter to build complex queries on this Koha::Objects-based routes. Some routes were created prior to this feature getting introduced. We need to adjust the parameters for all existing objects.search-based routes. This patch adds that. The only GET (as in list) routes that would still be missing the parameters are those about ILL, that are not objects.search based, and probably need to be rewritten. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 13:57:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 11:57:23 +0000 Subject: [Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122278|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 13:57:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 11:57:51 +0000 Subject: [Koha-bugs] [Bug 28613] Several objects.search-based routes missing parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28613 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 122279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122279&action=edit Bug 28613: Add missing parameters to objects.search-based routes The objects.search helper provides convenient ways to paginate and a 'q' filter parameter to build complex queries on this Koha::Objects-based routes. Some routes were created prior to this feature getting introduced. We need to adjust the parameters for all existing objects.search-based routes. This patch adds that. The only GET (as in list) routes that would still be missing the parameters are those about ILL, that are not objects.search based, and probably need to be rewritten. https://bugs.koha-community.org/show_bug.cgi?id=28480 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 14:00:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 12:00:20 +0000 Subject: [Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 14:07:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 12:07:46 +0000 Subject: [Koha-bugs] [Bug 28613] Several objects.search-based routes missing parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28613 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 14:23:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 12:23:00 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.01,20.11.07 |21.11.00,21.05.01 released in| | --- Comment #20 from Fridolin Somers --- I revert from 20.11.x in order to have a safe release 20.11.07 I could not find a good reason of this failure. If needed, please provide patches for 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 14:23:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 12:23:14 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 14:23:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 12:23:22 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 14:23:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 12:23:30 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 14:23:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 12:23:37 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 14:23:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 12:23:50 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 14:33:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 12:33:03 +0000 Subject: [Koha-bugs] [Bug 28612] Log manager_id with multipayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28612 --- Comment #1 from Jonathan Druart --- Please provide more details, I don't recreate. On master: * Create 2 manual invoices * Make a payment * Select the 2 invoices * "Pay selected" => accountlines.manager_id is filled with the correct borrowernumber. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 14:36:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 12:36:34 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |ASSIGNED Version(s)|21.11.00 | released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 14:37:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 12:37:21 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #33 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #30) > Test still fails on problem with Renewal but waiting flag passes. Not pushing then. I don't recreate however. How did you get it failing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 14:37:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 12:37:51 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #29 from Kyle M Hall --- (In reply to David Cook from comment #28) > (In reply to Marcel de Rooy from comment #26) > > Hi David, > > I understand 'We do not have a lib folder' point. > > But still wondering (especially since this report just creates a > > CGI::Session variant in lib): > > > > > We could have fooled Koha too by making our own package and install it in a > > > regular perllib ? > > I still don't know what you mean by "we could have fooled Koha", or "our own > package", or "regular perllib". Do you mean a Perl package or a Debian > package? What do you mean by "perllib"? Do you mean PERL5LIB, site Perl, > vendor Perl, Koha's top-level directory where we store C4 and Koha dirs, or > something else? How would it be fooling Koha? I think he means having our own debian package for CGI::Session::Serialize::yamlxs that would be installed to /usr/share/perl5/CGI/Session/Serialize/yamlxs.pm This seems like a bad thing to do though, as it would possibly break other Perl applications, right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 14:43:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 12:43:11 +0000 Subject: [Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 --- Comment #5 from Jonathan Druart --- What's the point of this test? :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 14:43:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 12:43:44 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #34 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #33) > (In reply to Marcel de Rooy from comment #30) > > Test still fails on problem with Renewal but waiting flag passes. > > Not pushing then. I don't recreate however. How did you get it failing? It fails with me without this patch set too. Not sure. Bad data? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 14:45:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 12:45:15 +0000 Subject: [Koha-bugs] [Bug 27877] Accessibility: Staff Client - Reduce heading redundancy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27877 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hakam.almotlak at inLibro.com --- Comment #5 from Hakam Almotlak --- Could you just explain the problem before the patch please so we can see the difference between the code before and after? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 14:48:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 12:48:52 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #30 from Marcel de Rooy --- (In reply to Kyle M Hall from comment #29) > I think he means having our own debian package for > CGI::Session::Serialize::yamlxs that would be installed to > /usr/share/perl5/CGI/Session/Serialize/yamlxs.pm > > This seems like a bad thing to do though, as it would possibly break other > Perl applications, right? Hi Kyle, Right. Not that hard. This should not break other Perl apps as it should not break Koha :) We put it in our PERL5LIB path! Note that if you do not set the serializer parameter to this new one, you probably wont ever notice it is there. And when it is only in a specific Koha container, even more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 14:49:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 12:49:49 +0000 Subject: [Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 --- Comment #6 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #5) > What's the point of this test? :D I was wondering :-D I guess we want the test if we are not leaking things (bug 23849) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 14:53:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 12:53:14 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA --- Comment #35 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #34) > (In reply to Jonathan Druart from comment #33) > > (In reply to Marcel de Rooy from comment #30) > > > Test still fails on problem with Renewal but waiting flag passes. > > > > Not pushing then. I don't recreate however. How did you get it failing? > > It fails with me without this patch set too. Not sure. Bad data? Yes I think so, maybe a pref did not have the default value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 14:57:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 12:57:13 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #31 from Jonathan Druart --- Not directly related to the discussion, but see also bug 17427 comment 29. When we will move (finally) to Data::Session we will hit a problem with the package not in /usr/share/perl5/CGI/Session/Serialize/ (not along with Serialize.pm at least). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 14:58:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 12:58:15 +0000 Subject: [Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 --- Comment #7 from Jonathan Druart --- But it's not the test that will catch it, even less if the list is in a single place now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:00:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:00:51 +0000 Subject: [Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 --- Comment #8 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #7) > But it's not the test that will catch it, even less if the list is in a > single place now. I'm fine with dropping the test instead of my patches here. Let me know if you want me to do that. My first instinct was to keep what we have, but make it simpler to maintain. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:03:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:03:26 +0000 Subject: [Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:04:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:04:24 +0000 Subject: [Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au, | |kyle at bywatersolutions.com, | |m.de.rooy at rijksmuseum.nl, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:04:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:04:35 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:04:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:04:39 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #21 from Nick Clemens --- Created attachment 122280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122280&action=edit Bug 27981: (follow-up) Handle duplciation and remove debug There were some additional lines in the commits on accident I add a 'duplication' option to svc/bib and pass the parameter from rancor to remove the 001 if autoControlNumber is set I add code to addbiblio.pl to remove 001 in standard editor To test: 1 - Follow above test plan 2 - Edit a record as duplicate when using the advanced editor 3 - Confirm the 001 does not load, but record saves correctly 4 - Edit the record 5 - Switch to 'basic editor' 6 - Save, then view record 7 - Edit as duplicate in basic editor 8 - Confirm the 001 is removed 9 - Confirm the 001 is added on save -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:05:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:05:26 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #22 from Nick Clemens --- (In reply to Marcel de Rooy from comment #20) > + }elsif($record->field('001')->data() eq 'biblionumber'){ > > How and when will the 001 ever be string biblionumber ? Either I was thinking this would be a way to force it, or I was editing my conditionals and got confused between syspref and record data. Removed in any case -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:05:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:05:46 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #23 from Nick Clemens --- (In reply to Marcel de Rooy from comment #18) > The problem with leaving a number might be when you are cloning records with > Edit as new. When you do not modify that 001, it is probably wrong. New patch, back to NSO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:10:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:10:27 +0000 Subject: [Koha-bugs] [Bug 28516] Koha/Patrons/Import.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:10:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:10:29 +0000 Subject: [Koha-bugs] [Bug 28516] Koha/Patrons/Import.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121631|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:17:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:17:07 +0000 Subject: [Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:17:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:17:12 +0000 Subject: [Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 --- Comment #1 from Jonathan Druart --- Created attachment 122281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122281&action=edit Bug 28606: Remove $DEBUG and $ENV{DEBUG} We should remove the debug statements or use Koha::Logger when we want to keep it. Test plan: Confirm that occurrences of remaining occurrences of DEBUG need to be kept (historical scripts for instance) Confirm that the occurrences removed by this patch can be removed Confirm that the occurrences replaced by Koha::Logger are correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:18:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:18:48 +0000 Subject: [Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 --- Comment #9 from Jonathan Druart --- I would keep the first patch but remove the tests in a second patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:27:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:27:51 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121992|0 |1 is obsolete| | --- Comment #21 from Nick Clemens --- Created attachment 122282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122282&action=edit Bug 28503: Compare item homebranch to patron branch when hold policy set to 'from_home_library' This fixes an issue in the way we calculate the check for hold policy 'from_home_library' Currently we change the comparison based on ReservesControlBranch, however, that should only control the rule we fetch, not how we compare When ReservesControlBranch is set to "patron's home library" we compare the patron's branch to the patron's branch, this is useless and means we pass the check for all branches all of the time We should instead compare the patron's branch to the item's branch, and only fetch the rule using ReservesControlBranch To test: 1 - Have a record with an item from library A and library B 2 - Set the 'Default checkout, hold and return policy'->Hold policy->From home library for all libraries and ensure you have no branch specific/itemtype specific rules set 3 - Attempt to place a hold on the record for a patron from library B 4 - Note that only the library B item is holdable - place a title level hold (do not choose an item) 5 - Check in the item from library A 6 - It fills the hold - This is incorrect - ignore the hold 7 - Apply patch 8 - Restart all the things 9 - Check in the item from library A 10 - No hold found 11 - Check in the item from library B 12 - Hold found, correctly Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Bug 28503: Clarify what ReservesControlBranch controls Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 19660a25fa9421373a41fb6aba71215d71c541be) Signed-off-by: Fridolin Somers Bug 28503: Unit tests Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit a4cdeaae3f82ea47fe3fba5e79f419e6911fb524) Signed-off-by: Fridolin Somers Bug 28503: (follow-up) Get rid of tests warnings Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 1e677a8755dfa4b5df3ff8df8f2644aedf388eb3) Signed-off-by: Fridolin Somers Bug 28503: [20.11.x] fix unit tests Impact of Bug 27069 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27069 Bug 28503: [20.11.x] Adjust bad test assumption The tests set holdpolicy to 'from home library', this is the case we were fixing Adjusted test to set policy to 'any library' and tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:30:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:30:53 +0000 Subject: [Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 --- Comment #24 from Jonathan Druart --- Aren't we missing damaged (and AllowHoldsOnDamagedItems) here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:32:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:32:05 +0000 Subject: [Koha-bugs] [Bug 28516] Koha/Patrons/Import.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 122283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122283&action=edit Bug 28516: Prevent failures if borrower_attribute_types.mandatory=1 TestBuilder will generate an integer for the Koha::Patron::Attribute::Type object, but if 1 is picked some tests are failing randomly At least t/db_dependent/Koha/Patrons.t and t/db_dependent/Koha/Patrons/Import.t The expection "Missing mandatory extended attribute" is raised when the patron is stored. Test plan: The following script should return 0 when the patch is applied: """ use t::lib::TestBuilder; my $builder = t::lib::TestBuilder->new; my $x = $builder->build_object( { class => 'Koha::Patron::Attribute::Types', } ); say $x->mandatory; """ Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:35:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:35:05 +0000 Subject: [Koha-bugs] [Bug 28516] Koha/Patrons/Import.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:37:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:37:30 +0000 Subject: [Koha-bugs] [Bug 28605] Code to calculate item's holdability must be moved to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28605 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 3142 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:37:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:37:30 +0000 Subject: [Koha-bugs] [Bug 3142] standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #3 from Jonathan Druart --- *** Bug 28605 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:38:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:38:12 +0000 Subject: [Koha-bugs] [Bug 3142] standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:40:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:40:17 +0000 Subject: [Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 --- Comment #25 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #24) > Aren't we missing damaged (and AllowHoldsOnDamagedItems) here? In get_items_that_can_fill? If so, there also a lot more things missing. As per my original suggestion we should not re-invent the reservability checking but use CanItemBeReserved, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:54:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:54:24 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 --- Comment #22 from Fridolin Somers --- BTW changes misc/cronjobs/update_patrons_category.pl : Options: + --help brief help message Minor but maybe not on purpose. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:57:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:57:05 +0000 Subject: [Koha-bugs] [Bug 3142] standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #4 from Jonathan Druart --- Created attachment 122284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122284&action=edit Bug 3142: Add itemlost, withdrawn and onloan -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:57:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:57:09 +0000 Subject: [Koha-bugs] [Bug 3142] standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #5 from Jonathan Druart --- Created attachment 122285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122285&action=edit Bug 3142: Exclude damaged items -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:57:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:57:14 +0000 Subject: [Koha-bugs] [Bug 3142] standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #6 from Jonathan Druart --- Created attachment 122286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122286&action=edit Bug 3142: Add itype -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:57:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:57:18 +0000 Subject: [Koha-bugs] [Bug 3142] standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #7 from Jonathan Druart --- Created attachment 122287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122287&action=edit Bug 3142: Use filter_by_for_holds where holdability is calculated -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:57:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:57:35 +0000 Subject: [Koha-bugs] [Bug 16882] Circ restrictions caused by long overdue should be removed when the offending item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16882 --- Comment #6 from Andrew Fuerste-Henry --- +1 here, I've spoken to many libraries that would prefer the restriction be specific to the item(s) that triggered the notice. This could be a new syspref tied to AutoRemoveOverduesRestrictions so it asks: "(Do / Do not) allow OVERDUES restrictions triggered by sent notices to be cleared automatically when (all / triggering) overdue items are returned by a patron." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:58:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:58:27 +0000 Subject: [Koha-bugs] [Bug 3142] standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion CC| |joonas.kylmala at helsinki.fi --- Comment #8 from Jonathan Druart --- Patches for discussion. This look like it's going into the right direction, are these patches correct? (Tests are missing of course) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 15:59:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 13:59:56 +0000 Subject: [Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 --- Comment #26 from Jonathan Druart --- (In reply to Joonas Kylmälä from comment #25) > (In reply to Jonathan Druart from comment #24) > > Aren't we missing damaged (and AllowHoldsOnDamagedItems) here? > > In get_items_that_can_fill? If so, there also a lot more things missing. As > per my original suggestion we should not re-invent the reservability > checking but use CanItemBeReserved, etc. I've attached some patches on bug 3142. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 16:00:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 14:00:02 +0000 Subject: [Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |3142 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 [Bug 3142] standardize how OPAC and staff determine requestability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 16:00:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 14:00:02 +0000 Subject: [Koha-bugs] [Bug 3142] standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27131 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 [Bug 27131] Move code from circ/pendingreserves.pl to modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 16:18:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 14:18:56 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121591|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart --- Created attachment 122288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122288&action=edit Bug 27526: Adjust code to use Koha::Items Not that we removed all the transformations of the item and are using Koha::Item from DB to TT (and the other way around), some code needs adjustments. - Retrieve host items can be simplified (see Koha::Biblio->host_items) - Some TT variables have been renamed for better understanding - Koha::Item->columns_to_str return a hashref with the representation string of the columns. A date will return the value how it must be displayed, using output_pref. A subfield linked with a AV will be replaced with the AV's description. - LastCreatedItem cookie serializes and stores Koha::Item->unblessed, no longer the MARC::Record Change in behaviour: If a subfield is linked with a AV cat and the value is not a valid AV, before this patch the column was displayed with an empty value. Now the column is hidden, it's considered empty. In the sample data it happens with itemlost (0) and withdrawn (0). Test plan: 1. Test the Prefill a. Turn PrefillItem on b. Fill in SubfieldsToUseWhenPrefill with some subfield codes c. Catalogue an item, save => The values from subfields listed in SubfieldsToUseWhenPrefill must be kept 2. more subfields a. Add subfields that are not linked with a koha field (k is available) b. Create an item and fill in all the values c. Confirm that non linked subfields are stored and displayed correctly d. Try with a "more subfield" that is linked with an authorised value category 3. Test barcode values 4. Test the different "Add" buttons at the bottom of the form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 16:19:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 14:19:41 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #32 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #30) Added the missing html filters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 16:36:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 14:36:17 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 --- Comment #23 from Fridolin Somers --- so in 20.11.x there is also a change in t/db_dependent/Circulation.t : diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t index 46d629d65f..23c034bd44 100755 --- a/t/db_dependent/Circulation.t +++ b/t/db_dependent/Circulation.t @@ -291,7 +291,7 @@ subtest "CanBookBeRenewed AllowRenewalIfOtherItemsAvailable multiple borrowers a branchcode => undef, itemtype => undef, rule_name => 'holdallowed', - rule_value => 1 + rule_value => 2 } ); Koha::CirculationRules->set_rule( Can we explain here why ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 16:42:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 14:42:01 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 16:43:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 14:43:32 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #5 from Marcel de Rooy --- Tested. Looks like it would work when configured correctly. But found some cases that need to be addressed in some form. Adding a few comments for it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 16:43:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 14:43:58 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #6 from Marcel de Rooy --- [1] No item link. Shouldnt we save a link to item in the accounts when the article request contains one ? I added two article requests, one with an item and one without. Both were in the database without an item reference. Accountlines table has an itemnumber column. Showing up sometimes as a barcode on a form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 16:44:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 14:44:22 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #7 from Marcel de Rooy --- [2] Warning Use of uninitialized value in string eq at /usr/share/koha/Koha/ArticleRequest.pm line 110. my $line = Koha::Account::Lines->find($self->debit_line_id); $line->cancel( { branch => C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef, staff_id => C4::Context->userenv ? C4::Context->userenv->{'number'} : undef, } ) unless $line->status eq 'CANCELLED' || $line->amount != $line->amountoutstanding; } => status == NULL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 16:45:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 14:45:10 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #8 from Marcel de Rooy --- [3] Cancel a fee after paying it Started with fee 0.35. Added one request. Changed fee to 35. Added four requests. Balance is now 140.35. I pay 105. Results in 35.35. OK I cancel in OPAC one of the requests (which already had amountoutstanding == 0 but you cant see that). What happened ? The balance stays 35.35 ! Wrong ! It should have gone down. NEEDS FIXING I change the fee again to 10. Add a request. Balance 45.35. OK Change fee back to 35. Now cancel the last request. Balance goes back to 35.35 Great. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 16:45:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 14:45:59 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #9 from Marcel de Rooy --- Read: cancel an article request after paying fee .. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 16:46:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 14:46:55 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #10 from Marcel de Rooy --- [4] Test by putting negative amount in fee on patron category => add_debit should throw an exception.. Seems that I cannot save that value with category on the list view. value="[% category.article_request_fee | $Price on_editing => 1 %]" Koha::Number::Price->new( $value )->format_for_editing $VAR1 = '-10.00'; But -10 is saved in the DATABASE ! Not shown in STAFF (list view shows only a minus; detail form does show -10) So, yes adding a request now crashes: Debit amount passed is not positive at /usr/share/perl5/Exception/Class/Base.pm line 88 Conclusion: The categories form should enforce the amount to be zero or POSITIVE. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 16:48:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 14:48:53 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #11 from Marcel de Rooy --- [5] There should be a limit where you cant add requests anymore. Similar to maxoutstanding OR OPACFineNoRenewals OR MaxFine OR noissuescharge. Even RentalsInNoissuesCharge. NOTE: This leaves the most room for discussion about scope borders.. $self->borrower->account->add_debit DOES NOT check a limit. Please note: Your account has outstanding fees & charges of 35.35. Holds are blocked because your fine balance is over the limit. Please note: You cannot renew your books online. Reason: Your fines exceed 100.00. Reducing fine for item $itemnum borrower $borrowernumber from $amount to $maxIncrease - MaxFine reached But I can just keep adding article requests without any limit applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 16:51:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 14:51:04 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 --- Comment #24 from Fridolin Somers --- I will release 20.11.07 without this so we can have time to validate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 16:51:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 14:51:06 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Marcel de Rooy --- Some of these 5 points justify a status change here now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 16:51:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 14:51:41 +0000 Subject: [Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 16:51:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 14:51:44 +0000 Subject: [Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121987|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 16:52:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 14:52:29 +0000 Subject: [Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 122289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122289&action=edit Bug 28565: Refactor tests Tests were too complex with no gain. They even deleted the whole DB to run (inside a transaction). I refactored to test the same thing, and make it rely (mostly) on existing data. _count behavior is tested implicitly by comparing with Koha::*->count. To test: 1. Run: $ kshell k$ prove t/db_dependent/UsageStats.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 16:58:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 14:58:24 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #23 from Jonathan Druart --- Created attachment 122290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122290&action=edit Bug 28572: Fix misc/admin/koha-preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 16:58:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 14:58:28 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #24 from Jonathan Druart --- Created attachment 122291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122291&action=edit Bug 28572: Fix Search.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 17:00:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 15:00:19 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate |additional_work_needed --- Comment #25 from Jonathan Druart --- (In reply to Jonathan Druart from comment #24) > Created attachment 122291 [details] [review] > Bug 28572: Fix Search.t This does not work, "Can't open /var/log/z3950-error.log (Permission denied)" We need to mock the log4perl configuration for tests or we are going to face a lot of issues. Any good ideas? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 17:34:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 15:34:22 +0000 Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122190|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 122292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122292&action=edit Bug 28604: Regression tests This patch introduces regression tests for the encoding issue with MiJ output. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 17:34:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 15:34:25 +0000 Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122191|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 122293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122293&action=edit Bug 28604: Prevent double encoding of MARC::Record::MiJ->to_mij output This patch fixes a double-encoding issue with MiJ output. Mojolicious' *text* renderer encodes the passed information according to the request context. [1] MARC::Record::MiJ->to_mij, conveniently encodes the string before output [2]. This causes double encoding. So the solution to this situation, is to use the *data* renderer, which doesn't perform any encoding [3]. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Tests contain diacritics and fail! 3. Have a record with diacritics 4. Try the API routes for fetching a biblio: $ curl --location --request GET 'http://localhost:8080/api/v1/public/biblios/144' \ --header 'Accept: application/marc-in-json' (replace the record id with the one you've chosen) => FAIL: Boo, double encoding 5. Bonus point: you can try it on the non-public route, but you need more configuration boilerplate (basic auth, permissions). If you look at the fix, you will understand the tests cover it and no need to complicate yourself. 6. Apply this patch 7. Repeat 2 => SUCCESS: Tests pass! 8. Repeat 4 (and maybe 5) => SUCCESS: No double encoding! Yay! 9. Sign off :-D [1] https://metacpan.org/release/MRAMBERG/Convos-0.5/view/local/lib/perl5/Mojolicious/Guides/Rendering.pod#Rendering-text [2] https://metacpan.org/dist/MARC-File-MiJ/source/lib/MARC/Record/MiJ.pm#L111 [3] https://metacpan.org/release/MRAMBERG/Convos-0.5/view/local/lib/perl5/Mojolicious/Guides/Rendering.pod#Rendering-data Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 17:34:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 15:34:49 +0000 Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize --- All works well, QA script is happy, Tests pass. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 18:04:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 16:04:50 +0000 Subject: [Koha-bugs] [Bug 20206] Inventory: barcodes without or with extra leading zeroes are reported not found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20206 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hakam.almotlak at inLibro.com --- Comment #15 from Hakam Almotlak --- Hey i applied the patch and created an item with 0123456 then another item with 00123456 and i tried to check in with the code 123456 and it says no item with this code. i checked the database and the code 0123456 and 00123456 exist in the database, but i can`t find it when i check in it does not exclude the zeros at the begging of the code. that is the database output: MariaDB [koha_master_dev_inlibro]> select barcode from items; +----------+ | barcode | +----------+ | NULL | | 00123456 | | 0123456 | | 111 | | 77777 | | 88888 | | 99999 | +----------+ 7 rows in set (0.001 sec) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 18:56:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 16:56:34 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122209|0 |1 is obsolete| | --- Comment #7 from Hakam Almotlak --- Created attachment 122294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122294&action=edit Bug 28491: Only whitespace changes for AddAuthority Only fixes indentation at highest level in sub. Includes warnings from qa tools: forbidden pattern: trailing space char (line 600) forbidden pattern: trailing space char (line 602) forbidden pattern: trailing space char (line 608) forbidden pattern: trailing space char (line 613) Test plan: Nothing to test really. No compile warnings? Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 18:58:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 16:58:51 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hakam.almotlak at inLibro.com Attachment #122294|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 19:01:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 17:01:11 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122211|0 |1 is obsolete| | --- Comment #8 from Hakam Almotlak --- Created attachment 122295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122295&action=edit Bug 28491: Add unit test Test plan: Run t/db_dependent/AuthoritiesMarc.t Signed-off-by: Marcel de Rooy Signed-off-by: hakam -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 19:02:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 17:02:08 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122210|0 |1 is obsolete| | --- Comment #9 from Hakam Almotlak --- Created attachment 122296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122296&action=edit Bug 28491: Always update field 003 in AddAuthority (MARC21) Test plan: Add or modify a record. Verify that the 003 always become the branch or system orgcode. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 19:02:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 17:02:24 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 19:03:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 17:03:44 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122294|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 19:29:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 17:29:18 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 --- Comment #10 from Hakam Almotlak --- Created attachment 122297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122297&action=edit Bug 20206: Find barcodes with more or less leading zeroes Test plan: Pick an item, change barcode to e.g. 0123456 Create a barcode file with 123456. Run inventory with it. Should be found and modified. Change barcode file by modifying 123456 to 00123456. Same result. Change barcode of another item to 000123456. Run inventory again on same barcode file: 0 modified, warn on duplicates? Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 19:30:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 17:30:05 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122297|0 |1 is obsolete| | --- Comment #11 from Hakam Almotlak --- Created attachment 122298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122298&action=edit Bug 20206: Find barcodes with more or less leading zeroes Test plan: Pick an item, change barcode to e.g. 0123456 Create a barcode file with 123456. Run inventory with it. Should be found and modified. Change barcode file by modifying 123456 to 00123456. Same result. Change barcode of another item to 000123456. Run inventory again on same barcode file: 0 modified, warn on duplicates? Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 19:31:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 17:31:09 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122296|0 |1 is obsolete| | --- Comment #12 from Hakam Almotlak --- Created attachment 122299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122299&action=edit Bug 28491: Always update field 003 in AddAuthority (MARC21) Test plan: Add or modify a record. Verify that the 003 always become the branch or system orgcode. Signed-off-by: Marcel de Rooy Signed-off-by: hakam -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 19:32:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 17:32:03 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122299|0 |1 is obsolete| | --- Comment #13 from Hakam Almotlak --- Created attachment 122300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122300&action=edit Bug 28491: Always update field 003 in AddAuthority (MARC21) Test plan: Add or modify a record. Verify that the 003 always become the branch or system orgcode. Signed-off-by: Marcel de Rooy Signed-off-by: hakam -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 20:00:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 18:00:38 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122280|0 |1 is obsolete| | --- Comment #24 from Hakam Almotlak --- Created attachment 122301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122301&action=edit Bug 27981: (follow-up) Handle duplciation and remove debug There were some additional lines in the commits on accident I add a 'duplication' option to svc/bib and pass the parameter from rancor to remove the 001 if autoControlNumber is set I add code to addbiblio.pl to remove 001 in standard editor To test: 1 - Follow above test plan 2 - Edit a record as duplicate when using the advanced editor 3 - Confirm the 001 does not load, but record saves correctly 4 - Edit the record 5 - Switch to 'basic editor' 6 - Save, then view record 7 - Edit as duplicate in basic editor 8 - Confirm the 001 is removed 9 - Confirm the 001 is added on save Signed-off-by: hakam -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 20:27:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 18:27:41 +0000 Subject: [Koha-bugs] [Bug 21498] Possibility to renew early when automatic renewals are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21498 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |andrew at bywatersolutions.com Status|NEW |RESOLVED --- Comment #2 from Andrew Fuerste-Henry --- Closing this as a dupe of 22018, as 22018 has further discussion on it. *** This bug has been marked as a duplicate of bug 22018 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 20:27:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 18:27:41 +0000 Subject: [Koha-bugs] [Bug 22018] Add an option to 'AllowEarlyRenewal' to enable users to renew before the autorenew date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22018 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |information at newcastle.gov.u | |k --- Comment #10 from Andrew Fuerste-Henry --- *** Bug 21498 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 21:13:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 19:13:26 +0000 Subject: [Koha-bugs] [Bug 28175] Usability improvements to uploads page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28175 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 21:13:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 19:13:30 +0000 Subject: [Koha-bugs] [Bug 28175] Usability improvements to uploads page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28175 --- Comment #5 from Owen Leonard --- Created attachment 122302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122302&action=edit Bug 28175: (follow-up) Preselect correct category after search This patch modifies the script and template so that if the user submits a search by category, that category will be preselected on the search results page. Also added is an empty "Choose" option so that a search category isn't selected by default. To test, apply the patch and view the uploads page. - In the category search form, a "Choose" option should be selected. Submitting the form without selecting a category should not work. - Search using one of your existing categories. On the search results page the category you selected should remain selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 21:19:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 19:19:00 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #26 from Tomás Cohen Arazi --- Created attachment 122303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122303&action=edit Bug 28572: Set missing __LOG_DIR__ variable in zebra_config.pl This patch makes zebra_config.pl create a temporary directory for logs and sets it in ENV so, when called, rewrite-config.PL sets it correctly. It also adds the new syspref Reference_NFL_Statuses to the big mock to silence many warnings introduced by bug 21260. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 21:25:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 19:25:36 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #27 from Tomás Cohen Arazi --- Ok, Search.t got too noisy. It is because of undefined stuffs. It can be trivially fixed, but I also noticed that some warns that got replaced by calls to the logger, got the if $DEBUG; removed. Is that intended? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 21:26:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 19:26:47 +0000 Subject: [Koha-bugs] [Bug 28614] New: 500 error on Stage MARC records for import, Staged MARC record management, Upload local cover image Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28614 Bug ID: 28614 Summary: 500 error on Stage MARC records for import, Staged MARC record management, Upload local cover image Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: - go to Tools (/cgi-bin/koha/tools/tools-home.pl) - click on Stage MARC records for import, Staged MARC record management, or Upload local cover image - get an error -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 21:41:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 19:41:04 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #28 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #27) > Ok, Search.t got too noisy. It is because of undefined stuffs. It can be > trivially fixed, but I also noticed that some warns that got replaced by > calls to the logger, got the if $DEBUG; removed. Is that intended? I wasn't paying attention :-D Koha::Logger, log level. he. Patch coming. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 21:42:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 19:42:21 +0000 Subject: [Koha-bugs] [Bug 28614] 500 error on Stage MARC records for import, Staged MARC record management, Upload local cover image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28614 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 21:45:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 19:45:41 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #29 from Tomás Cohen Arazi --- Created attachment 122304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122304&action=edit Bug 28572: Avoid useless warnings There are too many warnings about uninitialized variables in Search.pm. This patch deals with that, the same way it is dealt accross the file: by setting an empty string when things are not defined. To test: 1. Run: $ kshell k$ prove t/db_dependent/Search.t => FAIL: Wow, too many warnings. Some related to this bug, some not. 2. Apply this patch 3. Repeat 1 => SUCCESS: No more warnings! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 21:52:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 19:52:41 +0000 Subject: [Koha-bugs] [Bug 28462] TT tag on several lines break the translator tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28462 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hakam.almotlak at inLibro.com --- Comment #6 from Hakam Almotlak --- Hey i did the test plan step by step but then i was unable to find any error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 21:59:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 19:59:36 +0000 Subject: [Koha-bugs] [Bug 26340] When printing labels from a barcode range, keep zero padding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121923|0 |1 is obsolete| | --- Comment #14 from Hakam Almotlak --- Created attachment 122305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122305&action=edit Bug 26340: When printing labels from a barcode range, keep zero padding TEST PLAN: 1. Go Tools > Label creator 2. Click +New -> Barcode range 3. Print barcode range with zero(s) in the start (Ex. from 00011881 to 00012000 ) 4. Select a template to be applied:: Code à barre 48467 Select a layout to be applied: Code à barres 5. Export 6. Open PDF The prefix is not displayed. We should see 00011881 on the labels, but we see 11881, 11882, ... without zeros in the start of labels. This patch fix it. Signed-off-by: hakam -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 21:59:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 19:59:54 +0000 Subject: [Koha-bugs] [Bug 26340] When printing labels from a barcode range, keep zero padding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hakam.almotlak at inLibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 22:12:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 20:12:11 +0000 Subject: [Koha-bugs] [Bug 28615] New: Add a simple way to mock Koha::Logger Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 Bug ID: 28615 Summary: Add a simple way to mock Koha::Logger Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Now we are getting rid of $ENV{DEBUG} and C4::Debug with the correct use of Koha::Logger, we need an easy way to make sure we don't get problems with log permissions in the context of tests and, why not, being able to test those $logger->debug calls. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 22:12:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 20:12:45 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com Assignee|chris at bigballofwax.co.nz |tomascohen at gmail.com Depends on| |28572 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 [Bug 28572] Replace C4::Debug with Koha::Logger->debug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 22:12:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 20:12:45 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28615 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 [Bug 28615] Add a simple way to mock Koha::Logger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 22:53:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 20:53:18 +0000 Subject: [Koha-bugs] [Bug 28612] Log manager_id with multipayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28612 --- Comment #2 from Michal Denar --- Jonathan, I'm sorry. It's not the way I described it. I'll try to describe the problem and then we'll decide whether to close this bug or take a different course of action. The problem occurs when the CalculateFinesOnReturn option is set to "Do". Then the cron calculates the fines on return and the manager_id is correctly NULL. The interface is then unable to determine who collected the payment from the borrower. This info is only in the individual account lines, not in the green total. Is this correct or not? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 22:58:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 20:58:10 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 122306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122306&action=edit Bug 28615: Add a simple way to mock Koha::Logger This patch introduces a new method for mocking the Koha::Logger. As the POD says, it is used by calling t::lib::Mocks::mock_logger({ warn => 1 }); The warn parameter is optional, and controls wether any use of the logger will warn. The idea is that we can use that to write tests (that catch those warnings and thus the codepaths that trigger the call are properly tested, the same for the parameters to the call). I did a $ git grep 'Koha::Logger->get->debug' $ git grep 'Koha::Logger->get->warn' In order to find places in which we use the logger, and then find a test that would trigger it... to provide a useful test case. But I didn't... I tried with Overdues.t and Circulation.t and Export/Record.t but none worked [1]. So this is my test plan: 1. Apply this patch 2. Add the following line to t/db_dependent/Search.t just below the imports: t::lib::Mocks::mock_logger({ warn => 1 }); 3. Run: $ kshell k$ prove t/db_dependent/Search.t => SUCCESS: Suddenly every call to the logger is printing the parameter it got passed. 4. Sign off :-D [1] This is actually frustrating, because it means those codepaths are not traversed by the tests... Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 22:58:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 20:58:15 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 122307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122307&action=edit Bug 28615: Add POD Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 22:58:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 20:58:36 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 22 23:38:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 21:38:49 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #25 from Katrin Fischer --- Hi Hakam, should this be switched to signed off? I notice you only reattached the last patch. Usually we will add sign-off lines to all patches and then reattach them all with them. If you need help on how to do so, please let us know. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 01:16:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 23:16:07 +0000 Subject: [Koha-bugs] [Bug 3142] standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #9 from David Cook --- Comment on attachment 122284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122284 Bug 3142: Add itemlost, withdrawn and onloan Review of attachment 122284: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=3142&attachment=122284) ----------------------------------------------------------------- ::: Koha/Items.pm @@ +53,5 @@ > + itemlost => 0, > + withdrawn => 0, > + notforloan => { '<=' => 0 } > + , # items with negative or zero notforloan value are holdable > + onloan => undef, Why is onloan undef here? If I recall correctly, there are some rules/system preferences for determining holdability based on loan status. For instance, some settings only allow you to place holds if an item is already checked out. But then there is "allow on shelf holds" where "onloan" would be irrelevant. So it's probably a better idea to create the hashref earlier in the function and then changing the hashref based on rules/settings. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 01:35:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 23:35:54 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #32 from David Cook --- (In reply to Jonathan Druart from comment #31) > Not directly related to the discussion, but see also bug 17427 comment 29. > When we will move (finally) to Data::Session we will hit a problem with the > package not in /usr/share/perl5/CGI/Session/Serialize/ (not along with > Serialize.pm at least). That's a good point (although wouldn't it be "/usr/share/perl5/Data/Session/Serialize"?). That said, I feel like this is an argument against moving to Data::Session. That get_my_serializers function is a dreadful bit of code. I'm not seeing any packages for Data::Session in Debian or Ubuntu and it seems like it has a lot of dependencies. Also, Ron Savage took over CGI::Session and self-declared that his Data::Session was the successor to CGI::Session. Do we have any evidence that anyone actually uses it? I'd be tempted to either use Plack::Middleware::Session and finally put the nail in CGI, or write our own Koha::Session module. It doesn't need to be very complicated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 01:43:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 23:43:50 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- Why do we need to mock the logger? Regarding log permissions, we'd just need to make sure to pass it the right configuration. I don't see why mocking would help in terms of testing $logger->debug calls? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 01:44:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 23:44:34 +0000 Subject: [Koha-bugs] [Bug 28614] 500 error on Stage MARC records for import, Staged MARC record management, Upload local cover image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28614 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 01:45:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 23:45:03 +0000 Subject: [Koha-bugs] [Bug 28175] Usability improvements to uploads page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28175 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 01:46:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 23:46:07 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 --- Comment #4 from Tomás Cohen Arazi --- (In reply to David Cook from comment #3) > Why do we need to mock the logger? > > Regarding log permissions, we'd just need to make sure to pass it the right > configuration. > > I don't see why mocking would help in terms of testing $logger->debug calls? How would you test a function call added a warning under certain conditions? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 01:48:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 23:48:18 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 --- Comment #5 from David Cook --- (In reply to Tomás Cohen Arazi from comment #4) > (In reply to David Cook from comment #3) > > Why do we need to mock the logger? > > > > Regarding log permissions, we'd just need to make sure to pass it the right > > configuration. > > > > I don't see why mocking would help in terms of testing $logger->debug calls? > > How would you test a function call added a warning under certain conditions? I'd re-create those certain conditions. I can understand mocking a third-party integration, but I don't see why it would be needed for the logger. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 01:51:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Jun 2021 23:51:47 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 --- Comment #6 from Tomás Cohen Arazi --- (In reply to David Cook from comment #5) > (In reply to Tomás Cohen Arazi from comment #4) > > (In reply to David Cook from comment #3) > > > Why do we need to mock the logger? > > > > > > Regarding log permissions, we'd just need to make sure to pass it the right > > > configuration. > > > > > > I don't see why mocking would help in terms of testing $logger->debug calls? > > > > How would you test a function call added a warning under certain conditions? > > I'd re-create those certain conditions. I can understand mocking a > third-party integration, but I don't see why it would be needed for the > logger. Of course you need to recreate the conditions. But would you prefer to set the logger in the tests and verify the file was written? Or better mock like this and catch the warn? The use case: you want to add a test (which is actually missing) to test C4::Acquisition::UpdateFine calls the logger with ->debug and passes some stuff to it. This is what I come up with. But I'm not attached to my ideas when better exist! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 02:04:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 00:04:34 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 --- Comment #7 from David Cook --- (In reply to Tomás Cohen Arazi from comment #6) > Of course you need to recreate the conditions. But would you prefer to set > the logger in the tests and verify the file was written? Or better mock like > this and catch the warn? I don't understand what you're asking here. I'd configure the logger to print to STDERR and capture that. I actually did that recently although I'm having trouble remembering where. I'll keep looking to see if I can find my example. > The use case: you want to add a test (which is actually missing) to test > C4::Acquisition::UpdateFine calls the logger with ->debug and passes some > stuff to it. This is what I come up with. But I'm not attached to my ideas > when better exist! I'll take a look for my code snippet and see if it helps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 02:09:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 00:09:35 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 --- Comment #8 from David Cook --- Ah, here we go: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28477 That unit test code could be refined but it works without any mocking. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 02:25:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 00:25:50 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 --- Comment #9 from Tomás Cohen Arazi --- (In reply to David Cook from comment #8) > Ah, here we go: > > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28477 > > That unit test code could be refined but it works without any mocking. My goal is to make it trivial for devs to test behavior. There's nothing intrinsically bad about mocking the logger. Or doing it your way. You are actually mocking some other part of the same thing (the configuration) and manually capturing STDOUT/STDERR instead of 'the warn trick'. Your code is correct, and makes my point. Compare that boilerplate for just testing the logger is called, to just calling: t::lib::Mocks::mock_logger({warn=>1}); warning_is {}... Anyways, I always like different opinions and am open about this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 04:27:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 02:27:10 +0000 Subject: [Koha-bugs] [Bug 28616] New: Add libdata-printer-perl package Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28616 Bug ID: 28616 Summary: Add libdata-printer-perl package Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org CC: mtj at kohaaloha.com On 23/06/21 4:14 am, Michael Kuhn wrote: > Hi Himanshu > > > image.png > > This is the error i am getting when I click on import Patrons module. > > Koha version is 21.05. this is the reason I asked. > > Error 500 is a very unspecific HTTP message that can have many different reasons. You will have to search for the reason in the log files. > > However, this error has nothing to do with the (meanwhile solved) problem described in my posting "[Koha] Reoccurring DBMS auto increment issue". > > Just for your information: I just checked in my own demo installation ( http://koha.adminkuhn.ch:8080 ) which uses Koha 21.05 - it also gives me Error 500 when clicking Koha menu "Tools > Import patrons". In my case log file "plack-error.log" shows the following: > > Could not compile /usr/share/koha/intranet/cgi-bin/tools/import_borrowers.pl: Can't locate Data/Printer.pm in @INC (you may need to install the Data::Printer module) (@INC contains: /usr/share/koha/lib /usr/share/koha/installer /usr/share/koha/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base /var/lib/koha/sandkasten/plugins) at /usr/share/koha/lib/Koha/Patrons/Import.pm line 352. > BEGIN failed--compilation aborted at /usr/share/koha/lib/Koha/Patrons/Import.pm line 352. > Compilation failed in require at /usr/share/koha/intranet/cgi-bin/tools/import_borrowers.pl line 50. > BEGIN failed--compilation aborted at /usr/share/koha/intranet/cgi-bin/tools/import_borrowers.pl line 50. > > Maybe this is just a new bug you found. > > Best wishes: Michael hi Michael , this does seem to be a bug in 21.05 (at least) the following command should fix the problem, if the libdata-printer-perl package is not installed $ sudo apt install libdata-printer-perl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 04:30:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 02:30:17 +0000 Subject: [Koha-bugs] [Bug 28616] Add libdata-printer-perl package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28616 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 04:30:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 02:30:20 +0000 Subject: [Koha-bugs] [Bug 28616] Add libdata-printer-perl package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28616 --- Comment #1 from Mason James --- Created attachment 122308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122308&action=edit Bug 28616: Add libdata-printer-perl package to test... 1/ run /intranet/cgi-bin/tools/import_borrowers.pl, get error 2/ add patch, build package, install package 3/ run /intranet/cgi-bin/tools/import_borrowers.pl, get no error -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 04:31:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 02:31:45 +0000 Subject: [Koha-bugs] [Bug 28616] Add libdata-printer-perl package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28616 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 04:33:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 02:33:47 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 --- Comment #10 from David Cook --- (In reply to Tomás Cohen Arazi from comment #9) > My goal is to make it trivial for devs to test behavior. There's nothing > intrinsically bad about mocking the logger. Or doing it your way. > > You are actually mocking some other part of the same thing (the > configuration) and manually capturing STDOUT/STDERR instead of 'the warn > trick'. I wouldn't refer to configuration as mocking. And you don't have to manually capture STDOUT/STDERR. You can use brian d foy's module Test::Output. I use that on other Perl projects for my unit tests. Koha doesn't require it, so I couldn't use it for my tests. > Your code is correct, and makes my point. Compare that boilerplate for just > testing the logger is called, to just calling: I was in a hurry to get that unit test done that day, but Test::Output can be used so that you don't have all that boiler plate. Using Test::Output and Test::Warn would be a more accurate test of how the code actually works in production. > Anyways, I always like different opinions and am open about this. Same. I like to avoid mocks wherever possible and use the real thing, but I figure code speaks louder than words, and I'm not planning on working on my logging testing any time soon or adding Test::Output as a dependency. I thought that I would offer an alternative though, especially since I think we really should stop using Log4Perl to log to files and instead log to STDERR. It'll solve log file permission issues and allow us to leverage built-in web server functionality for logging. But that's just my opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 06:17:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 04:17:56 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #33 from Victor Grousset/tuxayo --- Found something very strange - master - no need to touch any setting - add an item and fill "g - Cost, normal purchase price" with a number - save - apply patches & restart services - refresh the add item page (additem.pl?biblionumber=295) (a refresh without resending the POST request) Template process failed: undef error - The given date (503.00) does not match the date format (iso) - got back to master & restart services - refresh the add item page (additem.pl?biblionumber=295) - it works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 06:24:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 04:24:45 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #353 from Victor Grousset/tuxayo --- (In reply to David Cook from comment #351) > I can't guarantee that my last patches actually apply on master Indeed lol :P > Patch failed at 0001 Bug 15516: Add ability to create hold groups from OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 06:26:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 04:26:58 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17217 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 06:26:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 04:26:58 +0000 Subject: [Koha-bugs] [Bug 17217] Allow to reserve first available item from a group of titles (OPAC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17217 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15516 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 06:32:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 04:32:49 +0000 Subject: [Koha-bugs] [Bug 28462] TT tag on several lines break the translator tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28462 --- Comment #7 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart from comment #5) > Victor, what is the value in the PO? "Pesquisar TEST translated" I changed the original source to "Search TEST source" And it showed in the .po and it's translation was filed. And it ended up in the translated template, thus showing that the whole process is working. But page hasn't been broken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 06:37:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 04:37:27 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 --- Comment #11 from David Cook --- Actually, if I recall correctly, we can't go with STDERR for Koha::Logger because Starman runs both the staff interface and the OPAC and it would put STDERR in just 1 file, so we'd lose the app separation by using STDERR. Right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 06:37:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 04:37:45 +0000 Subject: [Koha-bugs] [Bug 28462] TT tag on several lines break the translator tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28462 --- Comment #8 from Victor Grousset/tuxayo --- Just did a quick minimal retry - master - misc/translator/translate update pt-BR - misc/translator/translate install pt-BR - enable pt-BR in sysprefs - in pt-BR, go to OPAC://cgi-bin/koha/opac-search.pl - no error ¯\ (°_o)/¯ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 07:05:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 05:05:33 +0000 Subject: [Koha-bugs] [Bug 23035] Intranet search is slow if thousands of items are in the biblios shown in the search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23035 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 07:07:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 05:07:33 +0000 Subject: [Koha-bugs] [Bug 28462] TT tag on several lines break the translator tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28462 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Victor Grousset/tuxayo --- Wait, I see what you mean. It's just that the current .po doesn't reproduce the error. Because the IF statement translation is the same. So it hides the issue. Ok, so I can reproduce. I just need to alter the translation of the IF statement in the .po to sabotage it. It works! :D The old .po content if still there but commented #, c-format #~ msgid "" #~ "%s %s [%% IF ( OpacAdvSearchMoreOptions and OpacAdvSearchMoreOptions.size " #~ "> 0 and expanded_options ) or ( OpacAdvSearchOptions and " #~ "OpacAdvSearchOptions.size > 0 and not expanded_options ) %%] " #~ msgstr "" #~ "%s %s [%% SABOTAGEEEEEEEEEE ( OpacAdvSearchMoreOptions and " #~ "OpacAdvSearchMoreOptions.size > 0 and expanded_options ) or " #~ "( OpacAdvSearchOptions and OpacAdvSearchOptions.size > 0 and not " #~ "expanded_options ) %%] " test plan updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 07:08:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 05:08:17 +0000 Subject: [Koha-bugs] [Bug 28462] TT tag on several lines break the translator tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28462 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121434|0 |1 is obsolete| | --- Comment #10 from Victor Grousset/tuxayo --- Created attachment 122309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122309&action=edit Bug 28462: Remove TT tag on several lines - opac-advsearch.tt It fixes the translation in case the operators have been translated Test plan: 1. misc/translator/translate update pt-BR 2. In pt-BR-opac-bootstrap.po , find OpacAdvSearchMoreOptions 3. sabotage the translation part, like replacing IF with something else 4. misc/translator/translate install pt-BR 5. enable and use pt-BR and hit opac-advsearch.pl 6. Notice the error Template process failed: file error - parse error - /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/pt-BR/modules/opac-advsearch.tt line 409: unexpected token (e) [% IF (OpacAdvSearchMoreOptions and OpacAdvSearchMoreOptions.size> 0 e extended_options) ou (OpacAdvSearchOptions and OpacAdvSearchOptions.size> 0 e n expandido_options) %] at /kohadevbox/koha/C4/Templates.pm 7. Apply the patch and redo update and install of the language 8. Note that it's now working Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 07:42:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 05:42:05 +0000 Subject: [Koha-bugs] [Bug 27495] The "Accessibility advocate" role is not yet listed in the about page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27495 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.07 released in| | --- Comment #9 from Fridolin Somers --- Pushed to 20.11.x for 20.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 07:42:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 05:42:17 +0000 Subject: [Koha-bugs] [Bug 27495] The "Accessibility advocate" role is not yet listed in the about page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27495 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 07:42:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 05:42:55 +0000 Subject: [Koha-bugs] [Bug 28386] Replace dev_map.yaml from release_tools with .mailmap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28386 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.07 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #46 from Fridolin Somers --- Pushed to 20.11.x for 20.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 07:43:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 05:43:22 +0000 Subject: [Koha-bugs] [Bug 28442] Release team 21.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28442 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.07 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #18 from Fridolin Somers --- Pushed to 20.11.x for 20.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 07:43:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 05:43:30 +0000 Subject: [Koha-bugs] [Bug 28442] Release team 21.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28442 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 08:42:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 06:42:59 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #33 from Julian Maurice --- I think I agree with David here: writing our own Koha::Session should be relatively easy, and it would remove the need of a separate {CGI|Data}::Session::Serialize::yamlxs. And having less dependencies is a good thing IMO. But using Plack::Middleware::Session would prevent using koha with mojolicious servers like morbo or hypnotoad, right ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 09:05:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 07:05:35 +0000 Subject: [Koha-bugs] [Bug 28462] TT tag on several lines break the translator tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28462 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #11 from Victor Grousset/tuxayo --- There are more cases of the issue. git grep "\bIF\b" misc/translator/po | grep -v '#' | grep '\bpt-BR' (just taking pt-BR as an example, any language would do) Here is an example: https://git.koha-community.org/Koha-community/Koha/src/commit/feaeff330cfa9d49c99a0d70da0df87f5316652b/koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc#L104 That seems to be all long lines split but not in an organized, aligned way. 1. So same fix as for the current patch right? 2. Shall I summit a patch for them here or in a followup? 3. The grep is just searching the "IF" and if we want to ban all multi-line TT tags there are other things to grep right? (in discussion, so QA doesn't pick it yet, and might skip and forget it) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 09:36:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 07:36:35 +0000 Subject: [Koha-bugs] [Bug 28616] Add libdata-printer-perl package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28616 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28220 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 [Bug 28220] Exception not caught when importing patrons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 09:36:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 07:36:35 +0000 Subject: [Koha-bugs] [Bug 28220] Exception not caught when importing patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28616 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28616 [Bug 28616] Add libdata-printer-perl package -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 09:37:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 07:37:10 +0000 Subject: [Koha-bugs] [Bug 28616] Add libdata-printer-perl package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28616 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 09:39:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 07:39:02 +0000 Subject: [Koha-bugs] [Bug 28616] Add libdata-printer-perl package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28616 --- Comment #2 from Katrin Fischer --- Is there a chance to still get this in .01? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 09:41:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 07:41:49 +0000 Subject: [Koha-bugs] [Bug 28616] Add libdata-printer-perl package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28616 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122308|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 122310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122310&action=edit Bug 28616: (bug 28220 follow-up) Replace Data::Printer with simple warn $_ is an exception that will be stringify in scalar context. We don't need Data::Printer here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 09:42:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 07:42:11 +0000 Subject: [Koha-bugs] [Bug 28616] Remove Data::Printer dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28616 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add libdata-printer-perl |Remove Data::Printer |package |dependency -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 09:42:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 07:42:17 +0000 Subject: [Koha-bugs] [Bug 28616] Remove Data::Printer dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28616 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 09:42:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 07:42:19 +0000 Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|standardize how OPAC and |Standardize how OPAC and |staff determine |staff determine |requestability |requestability -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 09:53:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 07:53:21 +0000 Subject: [Koha-bugs] [Bug 28462] TT tag on several lines break the translator tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28462 --- Comment #12 from Jonathan Druart --- Created attachment 122311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122311&action=edit Bug 28462: Remove line breaks in TT tags Same as previous patch for other files. Looks like the problem exists only with IF. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 09:54:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 07:54:40 +0000 Subject: [Koha-bugs] [Bug 28462] TT tag on several lines break the translator tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28462 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #13 from Jonathan Druart --- Several runs of the following command did it for me: perl -p -i -e 's#(^\s*\[%[^%]*)\n#$1#gms' **/*.inc **/*.tt Ignoring sample.tt and country-list.inc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 09:55:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 07:55:49 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122298|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy --- Comment on attachment 122298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122298 Bug 20206: Find barcodes with more or less leading zeroes This one should not be here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 10:00:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 08:00:33 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122304|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart --- Comment on attachment 122304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122304 Bug 28572: Avoid useless warnings Patch moved to bug 28483 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 10:01:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 08:01:42 +0000 Subject: [Koha-bugs] [Bug 28483] Warnings from Search.t must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 10:01:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 08:01:45 +0000 Subject: [Koha-bugs] [Bug 28483] Warnings from Search.t must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483 --- Comment #1 from Jonathan Druart --- Created attachment 122312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122312&action=edit Bug 28483: Avoid useless warnings There are too many warnings about uninitialized variables in Search.pm. This patch deals with that, the same way it is dealt accross the file: by setting an empty string when things are not defined. To test: 1. Run: $ kshell k$ prove t/db_dependent/Search.t => FAIL: Wow, too many warnings. Some related to this bug, some not. 2. Apply this patch 3. Repeat 1 => SUCCESS: No more warnings! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 10:02:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 08:02:02 +0000 Subject: [Koha-bugs] [Bug 28483] Warnings from Search.t must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |tomascohen at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 10:02:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 08:02:52 +0000 Subject: [Koha-bugs] [Bug 28483] Warnings from Search.t must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122312|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 122313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122313&action=edit Bug 28483: Remove warnings from Search.t There are too many warnings about uninitialized variables in Search.pm. This patch deals with that, the same way it is dealt accross the file: by setting an empty string when things are not defined. To test: 1. Run: $ kshell k$ prove t/db_dependent/Search.t => FAIL: Wow, too many warnings. Some related to this bug, some not. 2. Apply this patch 3. Repeat 1 => SUCCESS: No more warnings! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 10:04:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 08:04:09 +0000 Subject: [Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 --- Comment #31 from Jonathan Druart --- c2fb056d7dc Bug 28572: Set missing __LOG_DIR__ variable in zebra_config.pl 3d1a92b6e1c Bug 28572: Fix Search.t 438cfbe1fc3 Bug 28572: Fix misc/admin/koha-preferences Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 10:04:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 08:04:30 +0000 Subject: [Koha-bugs] [Bug 28616] Remove Data::Printer dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28616 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 10:04:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 08:04:37 +0000 Subject: [Koha-bugs] [Bug 28616] Remove Data::Printer dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28616 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 10:04:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 08:04:59 +0000 Subject: [Koha-bugs] [Bug 28616] Remove Data::Printer dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28616 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 10:17:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 08:17:38 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 --- Comment #12 from Jonathan Druart --- Wondering if we shouldn't use a mix of: * https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120417 * what we have in t/Logger.t Basically it would mock log4perl_conf for the current prove command. But it needs to be "more global" or it won't work. Should not we actually copy $KOHA_CONF, modify it, and set KOHA_CONF to the new file for the current prove command? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 10:28:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 08:28:35 +0000 Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122284|0 |1 is obsolete| | Attachment #122285|0 |1 is obsolete| | Attachment #122286|0 |1 is obsolete| | Attachment #122287|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 122314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122314&action=edit Bug 3142: Add itemlost, withdrawn and notforloan -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 10:28:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 08:28:40 +0000 Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #11 from Jonathan Druart --- Created attachment 122315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122315&action=edit Bug 3142: Exclude damaged items -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 10:28:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 08:28:45 +0000 Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #12 from Jonathan Druart --- Created attachment 122316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122316&action=edit Bug 3142: Add itype -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 10:28:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 08:28:49 +0000 Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #13 from Jonathan Druart --- Created attachment 122317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122317&action=edit Bug 3142: Use filter_by_for_holds where holdability is calculated -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 10:29:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 08:29:32 +0000 Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #14 from Jonathan Druart --- (In reply to David Cook from comment #9) > Comment on attachment 122284 [details] [review] > Bug 3142: Add itemlost, withdrawn and onloan > > Review of attachment 122284 [details] [review]: > ----------------------------------------------------------------- > > ::: Koha/Items.pm > @@ +53,5 @@ > > + itemlost => 0, > > + withdrawn => 0, > > + notforloan => { '<=' => 0 } > > + , # items with negative or zero notforloan value are holdable > > + onloan => undef, > > Why is onloan undef here? I removed it and kept it in Koha::Items->filter_by_for_hold -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 10:36:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 08:36:51 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 10:36:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 08:36:56 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #34 from Jonathan Druart --- Created attachment 122318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122318&action=edit Bug 27526: Improve grep for date fields 'replacementpricedate' should not catch 'price' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 10:37:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 08:37:28 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #35 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #33) > Found something very strange Yes, silly error in the code. Should be fixed now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 10:44:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 08:44:46 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #34 from Jonathan Druart --- * Mason already packaged Data::Session (on bug 17427) * CGI::Session is no longer maintained and has a bad bug (see bug 17427 comment 0) * Patch is there on bug 17427 (not fully working but close), when we are talking about an hypothetical rewrite * Less dependency but more code to maintain on our side. * Getting such feedback after the 3+ years 17427 has been written is a bit frustrating... That being said I would support you if you are volunteering for an alternative (writing Koha::Session or using Plack::Middleware::Session), I will test, provide feedback and make it ready for 21.11. But it needs to be top priority for you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 10:45:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 08:45:07 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #35 from Jonathan Druart --- (discussion should continue on bug 17427) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 11:28:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 09:28:32 +0000 Subject: [Koha-bugs] [Bug 28560] Slash with non-ascii library code breaks various things In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28560 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #4 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #0) > == Test plan == > create a library with code ko/ha and another with Ä/A > > A. > 1. Try to hold from the OPAC with delivery to ko/ha > 2. => ERROR: Internal error: incomplete hold request. > (odd, nothing in all the logs, just a happy HTTP request returning 200) There is something silly in opac-reserve.pl 211 my $branch = $query->param('branch'); 212 $selectedItems = "$bib/$item/$branch/"; 213 } 214 215 $selectedItems =~ s!/$!!; 216 my @selectedItems = split /\//, $selectedItems, -1; 217 218 # Make sure there is a biblionum/itemnum/branch triplet for each item. 219 # The itemnum can be 'any', meaning next available. 220 my $selectionCount = @selectedItems; 221 if (($selectionCount == 0) || (($selectionCount % 3) != 0)) { We are using '/' to separate the hold info. Because multi holds code does the same in .tt Around 642 $(".confirmjs:checked").each(function() { The whole thing needs a rewrite and its own bug report. > B. > 1. Staff interface > 2. set library: Ä/A (the slash isn't enought to cause issues) > 3. transfer item to any another library > 4. => Broken FK constraint at /usr/share/perl5/Exception/Class/Base.pm line > 88 > Oddly it works with ko/ha Please detail the steps. > C. > 1. Staff interface > 2. set library: Ä/A (the slash isn't enought to cause issues) > 3. checkout an item > 4. => Broken FK constraint at /usr/share/perl5/Exception/Class/Base.pm line > 88 > Oddly it works with ko/ha Cannot recreate this. > D. > 1. Staff interface > 2. set library: NOT Ä/A > 3. checkout an item > 4. set library: Ä/A > 5. partron page => checkout tab => show checkouts > 6. try to check in > 7. => it's loads for ever > 8. => logs: Broken FK constraint at /usr/share/perl5/Exception/Class/Base.pm > line 88 > 9. refresh page > 10. The item has actually been checked in. (not sure if DB is in a > consistent state) Cannot recreate. > E. > Same but use the check in tab of the search box, next to the Koha logo Cannot recreate. The question is, do we really want to support / in code? I don't think so. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 11:32:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 09:32:23 +0000 Subject: [Koha-bugs] [Bug 28215] software error when updating a record - /cgi-bin/koha/cataloguing/addbiblio.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28215 --- Comment #9 from Jonathan Druart --- Did you fully reindex the records? % koha-elasticsearch --rebuild --delete --biblios --authorities $KOHA_INSTANCE -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 11:45:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 09:45:44 +0000 Subject: [Koha-bugs] [Bug 28617] New: Is misc/kohalib.pl still useful? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 Bug ID: 28617 Summary: Is misc/kohalib.pl still useful? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org This script is used by command line scripts to load the Koha lib. Should not we rely on PERL5LIB instead? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 11:45:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 09:45:44 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28617 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 11:46:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 09:46:37 +0000 Subject: [Koha-bugs] [Bug 28617] Is misc/kohalib.pl still useful? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au, | |m.de.rooy at rijksmuseum.nl, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 11:50:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 09:50:28 +0000 Subject: [Koha-bugs] [Bug 28617] Is misc/kohalib.pl still useful? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 --- Comment #1 from Jonathan Druart --- This is not an enforced rule for all our CLI scripts, if it was really useful for someone we would have heard about them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 11:56:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 09:56:09 +0000 Subject: [Koha-bugs] [Bug 28618] New: Move t/lib modules to lib/Koha/Test Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28618 Bug ID: 28618 Summary: Move t/lib modules to lib/Koha/Test Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 11:56:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 09:56:16 +0000 Subject: [Koha-bugs] [Bug 28618] Move t/lib modules to lib/Koha/Test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28589 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 [Bug 28589] Move C4 and Koha to lib -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 11:56:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 09:56:16 +0000 Subject: [Koha-bugs] [Bug 28589] Move C4 and Koha to lib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28618 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28618 [Bug 28618] Move t/lib modules to lib/Koha/Test -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 11:58:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 09:58:17 +0000 Subject: [Koha-bugs] [Bug 28619] New: Move misc/translator/ modules to lib/C4/Translate (?) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28619 Bug ID: 28619 Summary: Move misc/translator/ modules to lib/C4/Translate (?) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 28589 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 [Bug 28589] Move C4 and Koha to lib -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 11:58:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 09:58:17 +0000 Subject: [Koha-bugs] [Bug 28589] Move C4 and Koha to lib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28619 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28619 [Bug 28619] Move misc/translator/ modules to lib/C4/Translate (?) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 12:18:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 10:18:28 +0000 Subject: [Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 12:20:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 10:20:54 +0000 Subject: [Koha-bugs] [Bug 28589] Move C4 and Koha to lib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 --- Comment #7 from Jonathan Druart --- Created attachment 122319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122319&action=edit Bug 28589: git mv C4 lib && git mv Koha lib -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 12:20:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 10:20:59 +0000 Subject: [Koha-bugs] [Bug 28589] Move C4 and Koha to lib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 --- Comment #8 from Jonathan Druart --- Created attachment 122320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122320&action=edit Bug 28589: lib dir adjustements -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 12:21:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 10:21:50 +0000 Subject: [Koha-bugs] [Bug 28589] Move C4 and Koha to lib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 --- Comment #9 from Jonathan Druart --- What else would be needed? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 12:34:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 10:34:16 +0000 Subject: [Koha-bugs] [Bug 28617] Is misc/kohalib.pl still useful? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 --- Comment #2 from Martin Renvoize --- Must admit, I've never entirely understood what this script was all about and why we didn't set PERL5LIB somewhere instead.. I'm not sure recent scripts have included it and I've not come across issues using those (either as standard, dev or package installs). Perhaps ask Galen if he knows of a reason to keep it? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 12:34:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 10:34:32 +0000 Subject: [Koha-bugs] [Bug 28617] Is misc/kohalib.pl still useful? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmc at esilibrary.com, | |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 12:41:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 10:41:10 +0000 Subject: [Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122281|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 122321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122321&action=edit Bug 28606: Remove $DEBUG and $ENV{DEBUG} We should remove the debug statements or use Koha::Logger when we want to keep it. Test plan: Confirm that occurrences of remaining occurrences of DEBUG need to be kept (historical scripts for instance) Confirm that the occurrences removed by this patch can be removed Confirm that the occurrences replaced by Koha::Logger are correct Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 12:42:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 10:42:11 +0000 Subject: [Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Another nice bit of cleanup here. There are a few cases of "$debug and warn..." lines, but they appear to hard code setting `$debug = 0` internally and can be handled in another report I think. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 13:09:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 11:09:43 +0000 Subject: [Koha-bugs] [Bug 28617] Is misc/kohalib.pl still useful? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 --- Comment #3 from Marcel de Rooy --- We should remove it and replace all occurrences like: eval { require "$FindBin::Bin/../kohalib.pl" }; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 13:16:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 11:16:55 +0000 Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 --- Comment #15 from Marcel de Rooy --- Thx Hakam for your signoff btw -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 13:18:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 11:18:48 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121982|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize --- Created attachment 122322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122322&action=edit Bug 25078: Put db revs into different files to handle them better This patch suggests to stop using updatedatabase.pl to add new DB revs. Each DB rev will be in a separate pl files (installer/data/mysql/db_revs). The switch should ideally be done from 21.06.00.000. Each DBrev is executed in a try block and a transaction. If something went wrong, the whole DB rev is rolled back. Why do /var/log/koha/kohadev/updatedatabase_*.log (not -error) contain Status: 500 Content-type: text/html

    Software error:

    etc. Test plan: - git checkout 5f9333ffda0 (master on 2021-06-14) - Set the version syspref to 21.0500000: > update systempreferences set value="21.0500000" where variable="version"; - Apply "Bug 25078: [DO NOT PUSH] DB revs for testing" (restart_all) - Read the different DBrevs created as examples - Make sure the different use cases are covered - execute the updatedatabase script (CLI) - Set the version syspref to 21.0500000 - Update the DB from the UI - Set the version syspref to 21.0500000 - execute the updatedatabase script with the --force parameter (for testing purpose) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 13:18:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 11:18:53 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121983|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize --- Created attachment 122323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122323&action=edit Bug 25078: [DO NOT PUSH] DB revs for testing Use with the --force flag: % updatedatabase --force Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 13:18:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 11:18:57 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121984|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize --- Created attachment 122324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122324&action=edit Bug 25078: Re-introduce NewVersion This is ugly, we re-add the code we removed in the previous patch. We need to continue supporting "old" versions. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 13:19:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 11:19:02 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122208|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize --- Created attachment 122325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122325&action=edit Bug 25078: Separate update "report" from its description Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 13:19:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 11:19:10 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #71 from Martin Renvoize --- Created attachment 122326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122326&action=edit Bug 25078: (follow-up) Update 'NewVersion' for output_version changes This patch updates the NewVersion compatability method to add arrayref description handling to split it into description + report. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 13:19:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 11:19:26 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #26 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #25) > Hi Hakam, should this be switched to signed off? > > I notice you only reattached the last patch. Usually we will add sign-off > lines to all patches and then reattach them all with them. If you need help > on how to do so, please let us know. Hakam signed off on two patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 13:19:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 11:19:53 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #72 from Martin Renvoize --- Looking good to me, signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 13:20:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 11:20:08 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #27 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #25) > Hi Hakam, should this be switched to signed off? > > I notice you only reattached the last patch. Usually we will add sign-off > lines to all patches and then reattach them all with them. If you need help > on how to do so, please let us know. Oops it is somebody else :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 13:20:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 11:20:58 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #28 from Marcel de Rooy --- I will pickup QA again here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 13:29:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 11:29:25 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #29 from Marcel de Rooy --- # Subtest: AddBiblio 1..5 not ok 1 - expected warnings when adding too long LCCN # Failed test 'expected warnings when adding too long LCCN' # at t/db_dependent/Biblio.t line 61. # found warning: Use of uninitialized value in string eq at /usr/share/koha/C4/Biblio.pm line 2632. # expected to find warning: (?^u:Data too long for column 'lccn') # expected to find warning: (?^u:Data too long for column 'lccn') not ok 2 - AddBiblio returns undef for biblionumber if something went wrong # Failed test 'AddBiblio returns undef for biblionumber if something went wrong' # at t/db_dependent/Biblio.t line 63. # got: '129' # expected: undef not ok 3 - AddBiblio returns undef for biblioitemnumber if something went wrong # Failed test 'AddBiblio returns undef for biblioitemnumber if something went wrong' # at t/db_dependent/Biblio.t line 65. # got: '129' # expected: undef not ok 4 - No biblio should have been added if something went wrong # Failed test 'No biblio should have been added if something went wrong' # at t/db_dependent/Biblio.t line 68. # got: '3' # expected: '2' not ok 5 - The biblionumber is correctly passed to BiblioAutoLink # Failed test 'The biblionumber is correctly passed to BiblioAutoLink' # at t/db_dependent/Biblio.t line 81. # found warning: Use of uninitialized value in string eq at /usr/share/koha/C4/Biblio.pm line 2632. # found warning: My biblionumber is 130 and my frameworkcode is at t/db_dependent/Biblio.t line 78. # expected to find warning: (?^u:My biblionumber is \d+ and my frameworkcode is ) # Looks like you failed 5 tests of 5. not ok 2 - AddBiblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 13:32:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 11:32:27 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #30 from Marcel de Rooy --- Please cleanup your patches! diff --git a/members/memberentry.pl b/members/memberentry.pl index abae2ec53e..da8a324c78 100755 --- a/members/memberentry.pl +++ b/members/memberentry.pl @@ -109,9 +109,7 @@ $template->param( relationships => scalar $patron->guarantor_relationships ) if my @relations = split /\|/, C4::Context->preference('borrowerRelationship'), -1; @relations = ('') unless @relations; -warn Data::Dumper::Dumper( \@relations ); my $empty_relationship_allowed = grep {$_ eq ""} @relations; -warn $empty_relationship_allowed; $template->param( empty_relationship_allowed => $empty_relationship_allowed ); my $guarantor_id = $input->param('guarantor_id'); This really does not need to be in any of these patches. Please amend the first patch where you delete the buggy lines too ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 13:37:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 11:37:26 +0000 Subject: [Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #4 from Marcel de Rooy --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 13:37:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 11:37:29 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 --- Comment #13 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #12) > Wondering if we shouldn't use a mix of: > * https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120417 > * what we have in t/Logger.t > > Basically it would mock log4perl_conf for the current prove command. > > But it needs to be "more global" or it won't work. Should not we actually > copy $KOHA_CONF, modify it, and set KOHA_CONF to the new file for the > current prove command? I don't fully understand the added value of having a full blown log4perl setup when we only want to test if log4perl is called and how. Maybe we are thinking about different things. If we were to use something like that, I'd suggest using Test::Output as suggested by David so writing tests for those calls is less painful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 13:44:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 11:44:11 +0000 Subject: [Koha-bugs] [Bug 28617] Is misc/kohalib.pl still useful? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 --- Comment #4 from Tomás Cohen Arazi --- I think the idea was to prevent some lib being replaced by a malicious one on a different path. Pretty much like the . fix Perl added. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 13:51:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 11:51:29 +0000 Subject: [Koha-bugs] [Bug 28620] New: Remove trailing space when logging Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28620 Bug ID: 28620 Summary: Remove trailing space when logging Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 13:58:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 11:58:36 +0000 Subject: [Koha-bugs] [Bug 28620] Remove trailing space when logging with log4perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28620 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove trailing space when |Remove trailing space when |logging |logging with log4perl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 13:59:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 11:59:01 +0000 Subject: [Koha-bugs] [Bug 28620] Remove trailing space when logging with log4perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28620 --- Comment #1 from Marcel de Rooy --- Using %n in the config means space newline. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 13:59:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 11:59:14 +0000 Subject: [Koha-bugs] [Bug 28620] Remove trailing space when logging with log4perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28620 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:03:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:03:02 +0000 Subject: [Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:03:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:03:05 +0000 Subject: [Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 --- Comment #5 from Marcel de Rooy --- Created attachment 122327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122327&action=edit Bug 28620: Remove trailing space when logging with log4perl Trivial change. Do sed -i -r -e'/log4perl/ s/\s%n$/%n/' on the log4perl configs. Test plan: Update your own config. Trigger some logging and check that logfile. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:03:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:03:45 +0000 Subject: [Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 --- Comment #6 from Marcel de Rooy --- Oops -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:03:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:03:54 +0000 Subject: [Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:04:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:04:09 +0000 Subject: [Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122327|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Comment on attachment 122327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122327 Bug 28620: Remove trailing space when logging with log4perl Not here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:04:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:04:35 +0000 Subject: [Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28620 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:04:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:04:35 +0000 Subject: [Koha-bugs] [Bug 28620] Remove trailing space when logging with log4perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28620 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28606 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:04:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:04:59 +0000 Subject: [Koha-bugs] [Bug 28620] Remove trailing space when logging with log4perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28620 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:05:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:05:02 +0000 Subject: [Koha-bugs] [Bug 28620] Remove trailing space when logging with log4perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28620 --- Comment #2 from Marcel de Rooy --- Created attachment 122328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122328&action=edit Bug 28620: Remove trailing space when logging with log4perl Trivial change. Do sed -i -r -e'/log4perl/ s/\s%n$/%n/' on the log4perl configs. Test plan: Update your own config. Trigger some logging and check that logfile. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:05:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:05:30 +0000 Subject: [Koha-bugs] [Bug 28620] Remove trailing space when logging with log4perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28620 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:09:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:09:38 +0000 Subject: [Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 --- Comment #8 from Marcel de Rooy --- +#warn "Got ", scalar(@mapkeys), " ldap mapkeys ( total ): ", join ' ', @mapkeys, "\n"; @mapkeys = grep {defined $mapping{$_}->{is}} @mapkeys; -$debug and print STDERR "Got ", scalar(@mapkeys), " ldap mapkeys (populated): ", join ' ', @mapkeys, "\n"; +#warn "Got ", scalar(@mapkeys), " ldap mapkeys (populated): ", join ' ', @mapkeys, "\n"; Any plans here ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:10:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:10:11 +0000 Subject: [Koha-bugs] [Bug 18796] Allow to print notice while claiming serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18796 --- Comment #5 from Fridolin Somers --- Needs a huge rebase :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:10:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:10:17 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #73 from Martin Renvoize --- Created attachment 122329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122329&action=edit Bug 25078: Another Test for the backward shim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:10:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:10:44 +0000 Subject: [Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 --- Comment #9 from Marcel de Rooy --- + warn #"Finished \%memberhash has ", scalar(keys %memberhash), " keys\n", "Referencing \%mapping with ", scalar(keys %mapping), " keys\n"; Typo typo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:11:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:11:22 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #74 from Martin Renvoize --- Just added a follow-up atomicupdate (do not push it) to show how I tested that backwards compatibility stuff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:16:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:16:16 +0000 Subject: [Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 --- Comment #10 from Marcel de Rooy --- Just a side note: - if ($pkt =~ /AZ(....)$/) { - $debug and warn "verify_cksum: sum ($1) detected"; - } else { + unless ($pkt =~ /AZ(....)$/) { I have something with unless. When the ifs go down and the unlesses go up, Koha gets more complicated ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:24:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:24:17 +0000 Subject: [Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 --- Comment #11 from Marcel de Rooy --- -$ENV{DEBUG} = 1; -warning_like { in_iprange("192.168.1.1/36") } - qr/cidrlookup failed for/, - 'noisy simple invalid ip range/36 with remote ip in it'; Why removed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:26:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:26:03 +0000 Subject: [Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:26:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:26:07 +0000 Subject: [Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122321|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy --- Created attachment 122330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122330&action=edit Bug 28606: Remove $DEBUG and $ENV{DEBUG} We should remove the debug statements or use Koha::Logger when we want to keep it. Test plan: Confirm that occurrences of remaining occurrences of DEBUG need to be kept (historical scripts for instance) Confirm that the occurrences removed by this patch can be removed Confirm that the occurrences replaced by Koha::Logger are correct Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Looks good to me, noting a few minor points on BZ. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:26:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:26:18 +0000 Subject: [Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:31:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:31:55 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:34:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:34:32 +0000 Subject: [Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 --- Comment #13 from Jonathan Druart --- (In reply to Martin Renvoize from comment #3) > Another nice bit of cleanup here. > > There are a few cases of "$debug and warn..." lines, but they appear to hard > code setting `$debug = 0` internally and can be handled in another report I > think. Yes, it is expected. It's from scripts, not module. I thought it would be good to keep them. (In reply to Marcel de Rooy from comment #8) > +#warn "Got ", scalar(@mapkeys), " ldap mapkeys ( total ): ", join ' ', > @mapkeys, "\n"; > @mapkeys = grep {defined $mapping{$_}->{is}} @mapkeys; > -$debug and print STDERR "Got ", scalar(@mapkeys), " ldap mapkeys > (populated): ", join ' ', @mapkeys, "\n"; > +#warn "Got ", scalar(@mapkeys), " ldap mapkeys (populated): ", join ' ', > @mapkeys, "\n"; > > Any plans here ? I don't think they should be logged, but they sounded useful, in case someone need to debug LDAP. (In reply to Marcel de Rooy from comment #9) > + warn #"Finished \%memberhash has ", scalar(keys %memberhash), " keys\n", > "Referencing \%mapping with ", > scalar(keys %mapping), " keys\n"; > > Typo typo Oops, will fix. (In reply to Marcel de Rooy from comment #10) > Just a side note: > - if ($pkt =~ /AZ(....)$/) { > - $debug and warn "verify_cksum: sum ($1) detected"; > - } else { > + unless ($pkt =~ /AZ(....)$/) { > > I have something with unless. When the ifs go down and the unlesses go up, > Koha gets more complicated ;) I like unless :) (In reply to Marcel de Rooy from comment #11) > -$ENV{DEBUG} = 1; > -warning_like { in_iprange("192.168.1.1/36") } > - qr/cidrlookup failed for/, > - 'noisy simple invalid ip range/36 with remote ip in it'; > > Why removed? Heh, it was not trivial to keep as we are now using Koha::Logger, and didn't think very useful to keep anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:37:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:37:01 +0000 Subject: [Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122330|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 122331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122331&action=edit Bug 28606: Remove $DEBUG and $ENV{DEBUG} We should remove the debug statements or use Koha::Logger when we want to keep it. Test plan: Confirm that occurrences of remaining occurrences of DEBUG need to be kept (historical scripts for instance) Confirm that the occurrences removed by this patch can be removed Confirm that the occurrences replaced by Koha::Logger are correct Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Looks good to me, noting a few minor points on BZ. JD amended patch: replace "warn #Finished" with "#warn Finished", and put the statement on a single line -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:37:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:37:37 +0000 Subject: [Koha-bugs] [Bug 28620] Remove trailing space when logging with log4perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28620 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:46:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:46:22 +0000 Subject: [Koha-bugs] [Bug 20460] Changing password through the patron edit form does not reset failedloginattempts or log change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20460 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #13 from Andrew Fuerste-Henry --- Hi all! This issue has been resolved in later versions of Koha. I'm closing this bug. Feel free to reopen as needed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:51:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:51:50 +0000 Subject: [Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057 --- Comment #6 from Jonathan Druart --- Blou, can you signoff this one please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:55:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:55:49 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 --- Comment #14 from Marcel de Rooy --- t/db_dependent/Koha/REST/Plugin/PluginRoutes.t my $logger = Test::MockModule->new('Koha::Logger'); $logger->mock('error', sub { shift; warn @_; }); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 14:58:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 12:58:37 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 --- Comment #15 from Marcel de Rooy --- t::lib::Mocks::mock_logger({ warn => 1 }); Koha::Logger->get->info('test'); Koha::Logger->get->warn('warn'); This does not seem to work, because we are too late. Do you expect users of mock_logger to mock in a BEGIN block? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 15:00:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 13:00:45 +0000 Subject: [Koha-bugs] [Bug 26205] News changes aren't logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 --- Comment #29 from Jonathan Druart --- This needs to be called "additional contents", see bug 24387. I am inclined to push as it, but keep it in mind for next time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 15:06:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 13:06:37 +0000 Subject: [Koha-bugs] [Bug 26205] News changes aren't logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 15:06:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 13:06:40 +0000 Subject: [Koha-bugs] [Bug 26205] News changes aren't logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 --- Comment #30 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 15:06:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 13:06:43 +0000 Subject: [Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 15:06:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 13:06:45 +0000 Subject: [Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480 --- Comment #9 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 15:06:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 13:06:48 +0000 Subject: [Koha-bugs] [Bug 28516] Koha/Patrons/Import.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 15:06:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 13:06:51 +0000 Subject: [Koha-bugs] [Bug 28516] Koha/Patrons/Import.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 15:06:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 13:06:53 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 15:06:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 13:06:55 +0000 Subject: [Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #36 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 15:06:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 13:06:58 +0000 Subject: [Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 15:07:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 13:07:01 +0000 Subject: [Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 --- Comment #10 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 15:07:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 13:07:03 +0000 Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 15:07:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 13:07:06 +0000 Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 15:08:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 13:08:07 +0000 Subject: [Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121875|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 122332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122332&action=edit Bug 28480: (QA follow-up) Add unit test Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Fixed bug number -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 15:26:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 13:26:28 +0000 Subject: [Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #80 from Jonathan Druart --- Created attachment 122333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122333&action=edit Bug 23653: [19.11] use local copy of swagger v2 schema By default, JSON::Validator::OpenAPI tries to fetch the swagger v2 schema from http://swagger.io/v2/schema.json. If you've installed from CPAN, JSON::Validator::OpenAPI will come with a cached copy, so it won't try to fetch it over HTTP. However, if you've installed from libjson-validator-perl from Debian/Ubuntu, the Debian package excludes the cached copy, so JSON::Validator::OpenAPI tries to fetch it over HTTP. Unfortunately, today and other days in the past, the file at http://swagger.io/v2/schema.json has been unavailable, and this causes Koha to crash in a perpetual loop. This patch includes a copy of the swagger v2 schema, and it loads it locally rather than fetching over HTTP. The changes to Koha/REST/Plugin/PluginRoutes.pm are not required, since the validator isn't currently called there, but I've added a patch to future proof it. To Test: 0a) Remove /usr/share/perl5/JSON/Validator/cache/36d1bd12eeed51e86c8695bd8876a9df if it exists 0b) Block external access to http://swagger.io/v2/schema.json or test during an outage when it's unavailable 0c) Do not apply patch 1) koha-plack --restart kohadev 2) Note that it crashes in a loop and is unavailable in web browser 3) Apply patch 4) koha-plack --restart kohadev 5) Note that Koha comes up and there are no errors in the Plack logs Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 15:26:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 13:26:34 +0000 Subject: [Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #81 from Jonathan Druart --- Created attachment 122334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122334&action=edit Bug 23653: [19.11] Remove uneeded cond test rel_file returns the path anyway Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 15:26:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 13:26:40 +0000 Subject: [Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #82 from Jonathan Druart --- Created attachment 122335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122335&action=edit Bug 23653: [19.11] Add license information in about.pl Signed-off-by: Tomas Cohen Arazi JD Amended patch

    The included api/swagger-v2-schema.json file is licensed under the[-the-] Apache License, Version 2.0, by the OpenAPI Initiative [-(OAI)

    -]{+(OAI).

    +} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 15:27:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 13:27:27 +0000 Subject: [Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #83 from Jonathan Druart --- Wainui, I rebased the patches for 19.11.x but I'd like someone with a plugin injecting REST API route to test the patches before you push them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 15:29:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 13:29:21 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 --- Comment #16 from Jonathan Druart --- There is Test::Log4perl, but we will need to adjust all our test files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 15:32:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 13:32:37 +0000 Subject: [Koha-bugs] [Bug 28587] ldap auth fails unless In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28587 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Version|21.05 |unspecified -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 15:34:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 13:34:02 +0000 Subject: [Koha-bugs] [Bug 20206] Inventory: barcodes without or with extra leading zeroes are reported not found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20206 --- Comment #16 from Marcel de Rooy --- (In reply to Hakam Almotlak from comment #15) > Hey i applied the patch and created an item with 0123456 then another item > with 00123456 and i tried to check in with the code 123456 and it says no > item with this code. > i checked the database and the code 0123456 and 00123456 exist in the > database, but i can`t find it when i check in it does not exclude the zeros > at the begging of the code. Hi Hakam, Thx for testing. This patch only deals with the Tools/Inventory program. So it does not include the regular checkin. Please try the barcodes you created in the test plan of this patch with the tools/inventory script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 15:44:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 13:44:47 +0000 Subject: [Koha-bugs] [Bug 27151] SIP2 server doesn't handle broken connections which then kills SIP2 server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 15:45:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 13:45:03 +0000 Subject: [Koha-bugs] [Bug 28621] New: Make circulation conditions visible for patrons in patron account Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28621 Bug ID: 28621 Summary: Make circulation conditions visible for patrons in patron account Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org It would be a nice feature if it was possible to display the circulation conditions, like loan periods, number of possible renewals etc. for a patron in the patron account. The display should take the home library and patron category into account, so it doesn't have to be maintained manually and is as specific as possible, leaving anything out that doesn't apply to the patron looking at it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:02:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:02:49 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hakam.almotlak at inLibro.com --- Comment #62 from Hakam Almotlak --- patch does not apply Applying: Bug 14367: Add MARC record history Using index info to reconstruct a base tree... M C4/Biblio.pm Falling back to patching base and 3-way merge... Auto-merging C4/Biblio.pm CONFLICT (content): Merge conflict in C4/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 14367: Add MARC record history hint: Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14367-Add-MARC-record-history-1fUpWI.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:08:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:08:23 +0000 Subject: [Koha-bugs] [Bug 28622] New: selected branchcode not passed to adv search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622 Bug ID: 28622 Summary: selected branchcode not passed to adv search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 15758 From commit df97814f3034a3d5015546c4eca21f08ae951e37 Bug 15758: Koha::Libraries - Remove GetBranches selected_branchcode => ( C4::Context->IsSuperLibrarian ? C4::Context->userenv : '' ), We must pass C4::Context->userenv->{branch} Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:08:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:08:23 +0000 Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28622 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622 [Bug 28622] selected branchcode not passed to adv search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:09:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:09:17 +0000 Subject: [Koha-bugs] [Bug 23656] Add search box to top of page on cataloguing/editor.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121421|0 |1 is obsolete| | --- Comment #4 from Hakam Almotlak --- Created attachment 122336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122336&action=edit Bug 23656: Add hidden search bar to addbiblio and allow toggling This patch adds the search header to the cataloging editor page, defaulted as hidden A new link is added to show the bar, or hide the bar To test: 1 - Apply patch 2 - Load the basic cataloging editor for a book 3 - Note new link near top 'Show search box' 4 - Click it 5 - Search box appears 6 - Click now visible 'Hide search box' 7 - Search box hides 8 - Confirm search box works as expected Signed-off-by: hakam -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:12:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:12:08 +0000 Subject: [Koha-bugs] [Bug 23656] Add search box to top of page on cataloguing/editor.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122336|0 |1 is obsolete| | --- Comment #5 from Hakam Almotlak --- Created attachment 122337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122337&action=edit Bug 23656: Add hidden search bar to addbiblio and allow toggling This patch adds the search header to the cataloging editor page, defaulted as hidden A new link is added to show the bar, or hide the bar To test: 1 - Apply patch 2 - Load the basic cataloging editor for a book 3 - Note new link near top 'Show search box' 4 - Click it 5 - Search box appears 6 - Click now visible 'Hide search box' 7 - Search box hides 8 - Confirm search box works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:13:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:13:33 +0000 Subject: [Koha-bugs] [Bug 28211] Replace use of call_recursive() with call() In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28211 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #6 from Marcel de Rooy --- I would recommend to merge this report with the call_recursive report. Both are signed off. We could eliminate the code we actually do not want to push. The call_recursive name was a bit misleading too btw. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:14:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:14:21 +0000 Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to Koha::Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #13 from Marcel de Rooy --- Please merge with the other one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:16:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:16:40 +0000 Subject: [Koha-bugs] [Bug 23656] Add search box to top of page on cataloguing/editor.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hakam.almotlak at inLibro.com --- Comment #6 from Hakam Almotlak --- the button works and everything but when i try to search something or click on anything in the search bar, the search bar disappear even if i press on the options in the search bar like check in and check out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:21:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:21:29 +0000 Subject: [Koha-bugs] [Bug 28600] Variable "$patron" is not available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:21:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:21:33 +0000 Subject: [Koha-bugs] [Bug 28600] Variable "$patron" is not available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122207|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 122338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122338&action=edit Bug 28600: Resolve variable scope issue This patch fixes a scope issue. Originally, a variable declared as our $borcat was replaced by my $patron This patch makes the method not rely on global variables, but have a parameter for the patron, and thus things are clearer. To test: 1. Open the OPAC detail page for a record => FAIL: The logs show some errors about the $patron variable not available in the scope 2. Apply this patch 3. Repeat 1 => SUCCESS: No errors 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:21:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:21:43 +0000 Subject: [Koha-bugs] [Bug 28622] selected branchcode not passed to adv search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:21:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:21:47 +0000 Subject: [Koha-bugs] [Bug 28622] selected branchcode not passed to adv search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622 --- Comment #1 from Jonathan Druart --- Created attachment 122339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122339&action=edit Bug 28622: (bug 15758 follow-up) Remove incorrect branch selection in adv search From commit df97814f3034a3d5015546c4eca21f08ae951e37 Bug 15758: Koha::Libraries - Remove GetBranches + selected_branchcode => ( C4::Context->IsSuperLibrarian ? C4::Context->userenv : '' ), And - [% PROCESS options_for_libraries libraries => Branches.all() %] + [%# FIXME Should not we filter the libraries displayed? %] + [% PROCESS options_for_libraries libraries => Branches.all( selected => selected_branchcode, unfiltered => 1 ) %] The change in the pl is wrong as it should pass C4::Context->userenv->{branch}, but prior to this commit it seems that we didn't select the logged in library anyway. Looks like we should remove this code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:21:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:21:53 +0000 Subject: [Koha-bugs] [Bug 28600] Variable "$patron" is not available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:22:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:22:31 +0000 Subject: [Koha-bugs] [Bug 28622] Selected branchcode not passed to adv search? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|selected branchcode not |Selected branchcode not |passed to adv search |passed to adv search? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:27:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:27:04 +0000 Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hakam.almotlak at inLibro.com --- Comment #4 from Hakam Almotlak --- patch does not apply error: sha1 information is lacking or useless (Koha/BackgroundJob.pm). error: could not build fake ancestor Patch failed at 0001 Bug 26080: Use the task queue for batch delete biblios hint: Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-26080-Use-the-task-queue-for-batch-delete-bibl-KTCIJD.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:27:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:27:20 +0000 Subject: [Koha-bugs] [Bug 26383] Koha::Patron->is_superlibrarian is not optimal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26383 --- Comment #1 from Jonathan Druart --- Just had another look at this one. The problem is that we are calling it from modules, and have to Koha::Patrons->find($userenv->{number}) when, before, we had just to return $flags % 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:28:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:28:01 +0000 Subject: [Koha-bugs] [Bug 23656] Add search box to top of page on cataloguing/editor.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122337|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 122340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122340&action=edit Bug 23656: Add hidden search bar to addbiblio and allow toggling This patch adds the search header to the cataloging editor page, defaulted as hidden A new link is added to show the bar, or hide the bar To test: 1 - Apply patch 2 - Load the basic cataloging editor for a book 3 - Note new link near top 'Show search box' 4 - Click it 5 - Search box appears 6 - Click now visible 'Hide search box' 7 - Search box hides 8 - Confirm search box works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:29:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:29:12 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:29:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:29:59 +0000 Subject: [Koha-bugs] [Bug 26383] Koha::Patron->is_superlibrarian is not optimal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26383 --- Comment #2 from Jonathan Druart --- Created attachment 122341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122341&action=edit Bug 26383: WIP Replace C4::Context->IsSuperLibrarian with Koha::Patron->is_superlibrarian -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:31:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:31:20 +0000 Subject: [Koha-bugs] [Bug 26383] Koha::Patron->is_superlibrarian is not optimal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26383 --- Comment #3 from Jonathan Druart --- I am not convinced here, we may want to replace it from .pl but keep C4::Context->IsSuperLibrarian for modules. Then we are not able to remove it and still use the code in two places. Any suggestions? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:34:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:34:24 +0000 Subject: [Koha-bugs] [Bug 28571] C4::Auth::_session_log is not used and must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28571 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:34:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:34:28 +0000 Subject: [Koha-bugs] [Bug 28571] C4::Auth::_session_log is not used and must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28571 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122173|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 122342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122342&action=edit Bug 28571: Remove C4::Auth::_session_log It's not used and must be removed Test plan: % git grep _session_log must not return any result. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:34:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:34:40 +0000 Subject: [Koha-bugs] [Bug 28571] C4::Auth::_session_log is not used and must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28571 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:38:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:38:49 +0000 Subject: [Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:38:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:38:52 +0000 Subject: [Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122172|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 122343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122343&action=edit Bug 28601: Fix 'Home' breadcrumd on circulation-home.pl To test: 1 - Got to 'Circulation' 2 - Click 'Home' in breadcrumbs 3 - You are still in circulation home 4 - Apply patch 5 - reload page 6 - Click 'Home' 7 - Success! Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:39:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:39:05 +0000 Subject: [Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:42:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:42:41 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:42:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:42:45 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119704|0 |1 is obsolete| | Attachment #121805|0 |1 is obsolete| | Attachment #122301|0 |1 is obsolete| | --- Comment #31 from Nick Clemens --- Created attachment 122344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122344&action=edit Bug 27981: Add option to automatically set 001 to the biblionumber This patch adds a new system preference: autoControlNumber The option "biblionumber" will set field 001 to the biblionumber when you create a new record or edit an existing record If set to 'OFF' the 001 field wil not be touched When duplicating a record the 001 will be removed if autoControlNumber is set A 'duplication' option is add to svc/bib and rancor passes the parameter, the basic editor simply removes the field To test: 1 - Apply patches and updatedatabase 2 - Create a new record with no 001 field 3 - Save and view the MAC, confirm there is no 001 4 - Set the system preference to 'biblionumber' 5 - Edit the record you created previously 6 - Note the 001 is prepopulated with the biblionumber 7 - Delete the field 8 - Save the record 9 - View the MARC, the 001 is filled with biblionumber 10 - Edit the record 11 - Set the 001 to a different value "Not the biblionumber" 12 - Save 13 - View the marc and confirm the value you entered is retained 14 - Edit a record with an existing 001 that is not the biblionumber 15 - Save and confirm 001 is not updated To testi duplication: 1 - Edit a record as duplicate when using the advanced editor 2 - Confirm the 001 does not load, but record saves correctly 3 - Edit the record 4 - Switch to 'basic editor' 5 - Save, then view record 6 - Edit as duplicate in basic editor 7 - Confirm the 001 is removed 8 - Confirm the 001 is added on save -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:45:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:45:25 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #32 from Nick Clemens --- (In reply to Marcel de Rooy from comment #30) > Please cleanup your patches! > Please amend the first patch where you delete the buggy lines too ;) Patches squashed, back to NSO (In reply to Marcel de Rooy from comment #29) > # found warning: Use of uninitialized value in string eq at > /usr/share/koha/C4/Biblio.pm line 2632. > # found warning: My biblionumber is 130 and my frameworkcode is at > t/db_dependent/Biblio.t line 78. > # expected to find warning: (?^u:My biblionumber is \d+ and my > frameworkcode is ) > # Looks like you failed 5 tests of 5. > not ok 2 - AddBiblio I get the extra warning if i run the test before the DB update, but all is good after -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:47:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:47:25 +0000 Subject: [Koha-bugs] [Bug 28603] check-url-quick.pl does not encode spaces in urls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- $url = encode_utf8($url); + $url = uri_escape( $url, " " ); Normally we escape with uri_escape_utf8. This appears to be not exactly the same. Please explain why we should do so? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:48:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:48:12 +0000 Subject: [Koha-bugs] [Bug 28603] check-url-quick.pl does not encode spaces in urls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 --- Comment #4 from Marcel de Rooy --- uri_escape_utf8( $string, $unsafe ) Works like uri_escape(), but will encode chars as UTF-8 before escaping them. This makes this function able to deal with characters with code above 255 in $string. Note that chars in the 128 .. 255 range will be escaped differently by this function compared to what uri_escape() would. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:51:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:51:04 +0000 Subject: [Koha-bugs] [Bug 28356] Consolidate header catalogue search box code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120978|0 |1 is obsolete| | --- Comment #3 from Hakam Almotlak --- Created attachment 122345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122345&action=edit Bug 28356: Consolidate catalogue search box code To test: 1 - Apply patch 2 - Confirm searchign the catalog works from: Administration->Budgets Cataloging Circulation->Check in Administration->Cities and towns Acquisitions->{Vendor}->Contracts Administration->Currencies Administration->Circulation desks (requires UseCirculationDesks preference) Home Tools->Notices and slips Patrons Adminstration Serials Acquisitions->Suggestions Administration->Z39.50/SRU servers Signed-off-by: hakam -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:51:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:51:34 +0000 Subject: [Koha-bugs] [Bug 28356] Consolidate header catalogue search box code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122345|0 |1 is obsolete| | --- Comment #4 from Hakam Almotlak --- Created attachment 122346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122346&action=edit Bug 28356: Consolidate catalogue search box code To test: 1 - Apply patch 2 - Confirm searchign the catalog works from: Administration->Budgets Cataloging Circulation->Check in Administration->Cities and towns Acquisitions->{Vendor}->Contracts Administration->Currencies Administration->Circulation desks (requires UseCirculationDesks preference) Home Tools->Notices and slips Patrons Adminstration Serials Acquisitions->Suggestions Administration->Z39.50/SRU servers Signed-off-by: hakam -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:55:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:55:22 +0000 Subject: [Koha-bugs] [Bug 28483] Warnings from Search.t must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- When seeing this, I wonder right away why not the other one? - my $query = $operands[0]; + my $query = $operands[0] // ""; my $simple_query = $operands[0]; And looking a bit later, I see: for ($query_cgi,$simple_query) { s/"//g; } Shouldnt this trigger a warn too when undefined? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 16:56:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 14:56:13 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #19 from Martin Renvoize --- Oh, totally forgot about this one, I'm really sorry Emmi. I actually introduced a similar method in bug 11983 though.. so perhaps worth comparing. I'll try to bring that one back up to date, updating tests etc.. it's been on my list for a long time :S -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 17:02:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 15:02:20 +0000 Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107483|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 122347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122347&action=edit Bug 26080: Use the task queue for batch delete biblios This patch takes advantage of the task queue to delegate the batch delete biblios tool. Test plan: Delete bibliographic records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 17:02:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 15:02:25 +0000 Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107484|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 122348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122348&action=edit Bug 26080: Some refactoring A new include file is created per background job to avoid background_jobs.tt to grow too much -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 17:02:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 15:02:29 +0000 Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107485|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 122349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122349&action=edit Bug 26080: Use the task queue for batch delete authorities Same as the first patch, for authorities Test plan: Delete authority records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 17:24:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 15:24:26 +0000 Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 17:24:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 15:24:36 +0000 Subject: [Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 17:24:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 15:24:52 +0000 Subject: [Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 17:24:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 15:24:58 +0000 Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 17:26:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 15:26:31 +0000 Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to Koha::Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026 --- Comment #14 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #13) > Please merge with the other one I'm not sure what bug you are referring too, but this is a series of 4 bugs now, so I don't think that would be practical. It would require modifying two bugs that are already passed qa. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 17:30:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 15:30:16 +0000 Subject: [Koha-bugs] [Bug 28211] Replace use of call_recursive() with call() In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28211 --- Comment #7 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #6) > I would recommend to merge this report with the call_recursive report. Both > are signed off. We could eliminate the code we actually do not want to push. > > The call_recursive name was a bit misleading too btw. The two bugs are on the other sides of 26351 and 26352. Merging them would require modifying the patches for those bugs, both of which have passed qa. I think we should simply push the four bugs as a unit rather than risk introducing regressions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 17:35:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 15:35:18 +0000 Subject: [Koha-bugs] [Bug 28623] New: Fails to connect to server do not get response Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28623 Bug ID: 28623 Summary: Fails to connect to server do not get response Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs at lists.koha-community.org Reporter: hblancoca at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl I'm trying to connect to koha through a z3950 client, when I telnet to port 2200 it works ok, but if I connect from a software like marcedit I get a "connection lost" error and I can't recover any records I try doing tcpdump about conection and found that only incoming but not outgoing traffic found #tcpdump port 2200 | grep 10.212.134.96 10:32:29.617092 IP 10.212.134.96.60735 > srvkoha.urosario.edu.2200: Flags [S], seq 4015169908, win 64896, options [mss 1352,nop,wscale 8,nop,nop,sackOK], length 0 10:32:29.617106 IP srvkoha.urosario.edu.2200 > 10.212.134.96.60735: Flags [S.], seq 2610785618, ack 4015169909, win 64240, options [mss 1460,nop,nop,sackOK,nop,wscale 7], length 0 10:32:29.628422 IP 10.212.134.96.60735 > srvkoha.urosario.edu.2200: Flags [.], ack 1, win 6147, length 0 10:32:29.628528 IP 10.212.134.96.60735 > srvkoha.urosario.edu.2200: Flags [P.], seq 1:89, ack 1, win 6147, length 88 10:32:29.628534 IP srvkoha.urosario.edu.2200 > 10.212.134.96.60735: Flags [.], ack 89, win 502, length 0 10:32:29.698466 IP srvkoha.urosario.edu.2200 > 10.212.134.96.60735: Flags [F.], seq 1, ack 89, win 502, length 0 10:32:29.703413 IP 10.212.134.96.60735 > srvkoha.urosario.edu.2200: Flags [.], ack 2, win 6147, length 0 10:32:29.703477 IP 10.212.134.96.60735 > srvkoha.urosario.edu.2200: Flags [F.], seq 89, ack 2, win 6147, length 0 10:32:29.703486 IP srvkoha.urosario.edu.2200 > 10.212.134.96.60735: Flags [.], ack 90, win 502, length 0 Any idea? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 17:54:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 15:54:20 +0000 Subject: [Koha-bugs] [Bug 28196] In page anchors on additem.pl don't always go to the right place In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28196 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hakam.almotlak at inLibro.com --- Comment #7 from Hakam Almotlak --- without the patch the problem exist when you try to search within the catalogues but it does not exist when you search for a catalogue then you try to edit an item from the same catalogue. after the patch it does not fix the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 20:19:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 18:19:27 +0000 Subject: [Koha-bugs] [Bug 27426] Plugin barcode must keep leading zeros In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27426 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hakam.almotlak at inLibro.com --- Comment #4 from Hakam Almotlak --- hey i applied the patch and it did`t work i still get the last bar code number plus one and without the zeros at the begging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 20:41:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 18:41:35 +0000 Subject: [Koha-bugs] [Bug 22038] When exporting account table to excel, decimal is lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22038 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114376|0 |1 is obsolete| | --- Comment #7 from Hakam Almotlak --- Created attachment 122350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122350&action=edit Bug 22038: Fix excel export if CurrencyFormat is FR DataTables excel export is broken if number decimal separator is a comma. Test plan: 1 - Set syspref CurrencyFormat to US 2 - Export as excel a table with decimal numbers, patrons list with fines for example. 3 - Open in libreoffice or excel, numbers are ok. 4 - Set syspref CurrencyFormat to FR 5 - Export and open again, number are wrong 25,10 is imported as 2510 6 - Apply patch 7 - Redo 1 to 4 8 - Excel export, number is 25,10 Signed-off-by: hakam -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 20:58:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 18:58:18 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hakam.almotlak at inLibro.com --- Comment #20 from Hakam Almotlak --- patch does not apply on master Applying: Bug 15156: Get all patrons with owings Using index info to reconstruct a base tree... M Koha/Patrons.pm M t/db_dependent/Koha/Patrons.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/Patrons.t CONFLICT (content): Merge conflict in t/db_dependent/Koha/Patrons.t Auto-merging Koha/Patrons.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 15156: Get all patrons with owings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 20:59:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 18:59:45 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #21 from Tomás Cohen Arazi --- Please fix the test name while rebasing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 21:00:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 19:00:56 +0000 Subject: [Koha-bugs] [Bug 28623] Fails to connect to server do not get response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28623 --- Comment #1 from Humberto Blanco --- I try to connect from console with yaz-client but get the same error /etc/koha/sites/catalog# yaz-client tcp:localhost:2200 Connecting...OK. Sent initrequest. Target closed connection I believe that maybe need another conf in koha-conf.xml or z3950/config.xml -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 21:03:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 19:03:07 +0000 Subject: [Koha-bugs] [Bug 26614] Diacritics taken into account in facet sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26614 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hakam.almotlak at inLibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Hakam Almotlak --- patch does not apply. Using index info to reconstruct a base tree... M C4/Search.pm Falling back to patching base and 3-way merge... Auto-merging C4/Search.pm CONFLICT (content): Merge conflict in C4/Search.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 26614 - Diacritics taken into account in facet sorting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 22:20:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 20:20:20 +0000 Subject: [Koha-bugs] [Bug 20206] Inventory: barcodes without or with extra leading zeroes are reported not found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20206 --- Comment #17 from Hakam Almotlak --- thanks for the explaining i tested it and it works perfectly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 22:21:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 20:21:25 +0000 Subject: [Koha-bugs] [Bug 20206] Inventory: barcodes without or with extra leading zeroes are reported not found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20206 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109369|0 |1 is obsolete| | --- Comment #18 from Hakam Almotlak --- Created attachment 122351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122351&action=edit Bug 20206: Find barcodes with more or less leading zeroes Test plan: Pick an item, change barcode to e.g. 0123456 Create a barcode file with 123456. Run inventory with it. Should be found and modified. Change barcode file by modifying 123456 to 00123456. Same result. Change barcode of another item to 000123456. Run inventory again on same barcode file: 0 modified, warn on duplicates? Signed-off-by: Marcel de Rooy Signed-off-by: hakam -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 22:22:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 20:22:00 +0000 Subject: [Koha-bugs] [Bug 20206] Inventory: barcodes without or with extra leading zeroes are reported not found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20206 Hakam Almotlak changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #19 from Hakam Almotlak --- thanks for the explaining i tested it and it works perfectly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 22:29:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 20:29:43 +0000 Subject: [Koha-bugs] [Bug 28386] Replace dev_map.yaml from release_tools with .mailmap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28386 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.07 |21.05.00,20.11.07,20.05.13 released in| | Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #47 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.13 After around 130 conflicts! (How did Frido, Kyle and Nick dealt with this?) Hint in case Wainui gets the same thing: Solve the individual conflicts as usual. When getting a 60 conflicts pack, just rapidly skim through then without solving to confirm that it will be safe to do `git checkout --theirs MY_FILE` It was safe in my case (noticed after manually solving the 60 ones...) There is another 60 conflicts pack, do the same as above. The timeline in the about page isn't broken, so that seems to work ^^ and Jonathan told me that we should keep the commit numbers from upstream, not the one from our branch. And it's not used anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 22:33:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 20:33:44 +0000 Subject: [Koha-bugs] [Bug 27495] The "Accessibility advocate" role is not yet listed in the about page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27495 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor at tuxayo.net Version(s)|21.05.00,20.11.07 |21.05.00,20.11.07,20.05.13 released in| | --- Comment #10 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 22:36:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 20:36:42 +0000 Subject: [Koha-bugs] [Bug 28442] Release team 21.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28442 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.07 |21.05.00,20.11.07,20.05.13 released in| | Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #19 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 23:10:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 21:10:52 +0000 Subject: [Koha-bugs] [Bug 28621] Make circulation conditions visible for patrons in patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28621 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- Do you mean, like, a place in the patron account section of the OPAC where a patron could see how the circ rules apply to them for various item types? That sounds really cool! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 23 23:50:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 21:50:05 +0000 Subject: [Koha-bugs] [Bug 28621] Make circulation conditions visible for patrons in patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28621 --- Comment #2 from Katrin Fischer --- Yes, one of our libraries suggested this today - so not mine, but I got to file it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 00:06:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 22:06:38 +0000 Subject: [Koha-bugs] [Bug 28196] In page anchors on additem.pl don't always go to the right place In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28196 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120027|0 |1 is obsolete| | --- Comment #8 from Lucas Gass --- Created attachment 122352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122352&action=edit Bug 28196: make sure URL hash is appended last TO test: 1 Do a search within the staff client 2 Click on any results and go to the detail page 3 Click the edit button on any item in that record, it should take you to a URL like this: '/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=55&itemnumber=117#edititem&searchid=scs_1619109565224' 4 Apply patch 5 Do steps 1 & 2 again Click the edit button on any item in that record, it should take you to a URL like this: '/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=55&itemnum ber=117&searchid=scs_1619109565224#edititem' 6. If they URL hash is last the anchor should work and you'll be placed on the h2 element with and ID of edititem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 00:41:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 22:41:17 +0000 Subject: [Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121986|0 |1 is obsolete| | --- Comment #11 from David Nind --- Created attachment 122353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122353&action=edit Bug 28565: Move the sysprefs to a reusable sub This patch moves the big sysprefs list to a sub. Behavior shouldn't change. To test: 1. Run: $ kshell k$ prove t/db_dependent/UsageStats.t => SUCCESS: Things work as expected, no changes. 2. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 00:41:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 22:41:21 +0000 Subject: [Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122289|0 |1 is obsolete| | --- Comment #12 from David Nind --- Created attachment 122354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122354&action=edit Bug 28565: Refactor tests Tests were too complex with no gain. They even deleted the whole DB to run (inside a transaction). I refactored to test the same thing, and make it rely (mostly) on existing data. _count behavior is tested implicitly by comparing with Koha::*->count. To test: 1. Run: $ kshell k$ prove t/db_dependent/UsageStats.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 01:31:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 23:31:41 +0000 Subject: [Koha-bugs] [Bug 27426] Plugin barcode must keep leading zeros In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27426 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from David Cook --- I should've actually marked this as Failed QA previously. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 01:37:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 23:37:30 +0000 Subject: [Koha-bugs] [Bug 26383] Koha::Patron->is_superlibrarian is not optimal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26383 --- Comment #4 from David Cook --- Comment on attachment 122341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122341 Bug 26383: WIP Replace C4::Context->IsSuperLibrarian with Koha::Patron->is_superlibrarian Review of attachment 122341: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=26383&attachment=122341) ----------------------------------------------------------------- ::: C4/Circulation.pm @@ +1073,5 @@ > + > + my $userenv = C4::Context->userenv; > + if ( C4::Context->preference("IndependentBranches") && $userenv ) { > + my $logged_in_user = Koha::Patrons->find($userenv->{number}); > + unless ( $logged_in_user->is_superlibrarian ) { Technically, the session stores the flags value, so we could just do the calculation off the session data. The only downside of doing that is that we probably only set the flags session data at login time, so if someone's permissions change while they're logged in, it won't be detected until they've logged out and logged back in. But... it would mean fewer database calls. If we're doing a multi-checkout, the number of database calls would increase by that factor... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 01:39:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 23:39:03 +0000 Subject: [Koha-bugs] [Bug 26383] Koha::Patron->is_superlibrarian is not optimal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26383 --- Comment #5 from David Cook --- Comment on attachment 122341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122341 Bug 26383: WIP Replace C4::Context->IsSuperLibrarian with Koha::Patron->is_superlibrarian Review of attachment 122341: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=26383&attachment=122341) ----------------------------------------------------------------- ::: C4/Circulation.pm @@ +1073,5 @@ > + > + my $userenv = C4::Context->userenv; > + if ( C4::Context->preference("IndependentBranches") && $userenv ) { > + my $logged_in_user = Koha::Patrons->find($userenv->{number}); > + unless ( $logged_in_user->is_superlibrarian ) { I suppose a more optimal design would be to pass the issuer to CanBookBeIssued via a parameter, but that would probably be too dramatic a refactor for us to do at this point... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 01:50:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 23:50:16 +0000 Subject: [Koha-bugs] [Bug 26383] Koha::Patron->is_superlibrarian is not optimal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26383 --- Comment #6 from David Cook --- (In reply to Jonathan Druart from comment #3) > I am not convinced here, we may want to replace it from .pl but keep > C4::Context->IsSuperLibrarian for modules. Then we are not able to remove it > and still use the code in two places. > > Any suggestions? Another option could be something like this: my $is_superlibrarian = Koha::Auth->is_superlibrarian({ borrowernumber => $borrowernumber, }); my $is_superlibrarian = Koha::Auth->is_superlibrarian({ patron => $patron, }); The only downside of that would be needing to add "use Koha::Auth", although I suppose we could add that into C4::Auth, which is called in the .pl scripts because they need the "get_template_and_user" function. Alternatively, you could write Koha::Patron->is_superlibrarian to be used as either a class method or an object method. You just check whether $self is a string or a reference to an object. If it's a class method (ie $self is a string), you could require a "patron" or "borrowernumber" parameter. That way you're keeping the code in one place but you're allowing for 2 different ways of calling it. There's some ideas :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 01:54:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Jun 2021 23:54:11 +0000 Subject: [Koha-bugs] [Bug 28617] Is misc/kohalib.pl still useful? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 --- Comment #5 from David Cook --- (In reply to Jonathan Druart from comment #0) > This script is used by command line scripts to load the Koha lib. > Should not we rely on PERL5LIB instead? +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 04:05:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 02:05:16 +0000 Subject: [Koha-bugs] [Bug 28482] Floating point math prevents items from being returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28482 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #15 from wainuiwitikapark at catalyst.net.nz --- Should this be backported to 19.11.x? For 19.11.19? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 04:06:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 02:06:31 +0000 Subject: [Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #17 from wainuiwitikapark at catalyst.net.nz --- Should this be backported to 19.11.x? For 19.11.19? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 04:07:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 02:07:34 +0000 Subject: [Koha-bugs] [Bug 28538] Regression - Date of birth entered without correct format causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #9 from wainuiwitikapark at catalyst.net.nz --- Should this be backported to 19.11.x? For 19.11.19? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 04:12:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 02:12:51 +0000 Subject: [Koha-bugs] [Bug 27495] The "Accessibility advocate" role is not yet listed in the about page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27495 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 04:26:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 02:26:13 +0000 Subject: [Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #84 from wainuiwitikapark at catalyst.net.nz --- (In reply to Jonathan Druart from comment #83) > Wainui, I rebased the patches for 19.11.x but I'd like someone with a plugin > injecting REST API route to test the patches before you push them. Thanks Jonathan. They applied cleanly to my branch, but I won't test and push them up until the next release (19.11.20). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 04:29:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 02:29:49 +0000 Subject: [Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #25 from wainuiwitikapark at catalyst.net.nz --- Should this be backported to 19.11.x? For 19.11.20 (next release in July)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 04:31:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 02:31:28 +0000 Subject: [Koha-bugs] [Bug 28386] Replace dev_map.yaml from release_tools with .mailmap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28386 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #48 from wainuiwitikapark at catalyst.net.nz --- Should this be backported to 19.11.x? For 19.11.20 (next release in July)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 04:37:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 02:37:02 +0000 Subject: [Koha-bugs] [Bug 27495] The "Accessibility advocate" role is not yet listed in the about page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27495 --- Comment #11 from wainuiwitikapark at catalyst.net.nz --- Should this be backported to 19.11.x? If so, this would be for 19.11.20 (next release in July) as I believe there is currently a string freeze so this bug should not be backported now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 04:39:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 02:39:50 +0000 Subject: [Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #85 from Tomás Cohen Arazi --- (In reply to wainuiwitikapark from comment #84) > (In reply to Jonathan Druart from comment #83) > > Wainui, I rebased the patches for 19.11.x but I'd like someone with a plugin > > injecting REST API route to test the patches before you push them. > > Thanks Jonathan. They applied cleanly to my branch, but I won't test and > push them up until the next release (19.11.20). I can test in the morning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 04:40:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 02:40:05 +0000 Subject: [Koha-bugs] [Bug 28442] Release team 21.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28442 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #20 from wainuiwitikapark at catalyst.net.nz --- Will backport for 19.11.20 (next release in July) as I believe there is currently a string freeze so this bug should not be backported now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 07:49:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 05:49:27 +0000 Subject: [Koha-bugs] [Bug 28621] Make circulation conditions visible for patrons in patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28621 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #3 from Magnus Enger --- This is an awesome idea! We have the data, we just need to figure out how to display it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 07:49:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 05:49:56 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110886|0 |1 is obsolete| | --- Comment #22 from Emmi Takkinen --- Created attachment 122355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122355&action=edit Bug 15156: Get all patrons with owings This patch adds method to return set of unique patrons with accountlines matching filtering params. To test: prove t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 08:02:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 06:02:59 +0000 Subject: [Koha-bugs] [Bug 28211] Replace use of call_recursive() with call() In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28211 --- Comment #8 from Marcel de Rooy --- (In reply to Kyle M Hall from comment #7) > (In reply to Marcel de Rooy from comment #6) > > I would recommend to merge this report with the call_recursive report. Both > > are signed off. We could eliminate the code we actually do not want to push. > > > > The call_recursive name was a bit misleading too btw. > > The two bugs are on the other sides of 26351 and 26352. Merging them would > require modifying the patches for those bugs, both of which have passed qa. > I think we should simply push the four bugs as a unit rather than risk > introducing regressions. Okay. I missed the other two ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 09:07:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 07:07:25 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #33 from Marcel de Rooy --- Created attachment 122356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122356&action=edit Bug 27981: (QA follow-up) Adjust atomic update [1] Insert ignore. [2] Remove references to bug 9921. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 09:08:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 07:08:40 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #34 from Marcel de Rooy --- (In reply to Nick Clemens from comment #32) > I get the extra warning if i run the test before the DB update, but all is > good after Still have it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 09:13:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 07:13:53 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Needs Signoff |Failed QA --- Comment #35 from Marcel de Rooy --- > A 'duplication' option is add to svc/bib and rancor passes the parameter, > the basic editor simply removes the field I dont think that we should go that way. The changes to svc/bib do not look good to me. The strange d parameter in the path svc/bib/d1 is rather hacky. Personally, I would rather go away from the whole path_info tric to get the biblionumber and just have a real biblionumber parameter. But we should not spend too much time on this old service script when we have an API. Instead of changing svc/bib, could you move the change to where rancor saves a duplicated record? Adding Jonathan to the discussion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 09:38:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 07:38:40 +0000 Subject: [Koha-bugs] [Bug 28616] Remove Data::Printer dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28616 --- Comment #5 from Jonathan Druart --- Added a QA test for Data::Printer - https://gitlab.com/koha-community/qa-test-tools/-/merge_requests/39 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 09:44:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 07:44:10 +0000 Subject: [Koha-bugs] [Bug 28624] New: Smart::Comments not used and not installed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28624 Bug ID: 28624 Summary: Smart::Comments not used and not installed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org about.pl:#use Smart::Comments '####'; admin/preferences.pl:# use Smart::Comments; labels/spinelabel-home.pl:# use Smart::Comments; members/printslip.pl:#use Smart::Comments; members/update-child.pl:# use Smart::Comments; serials/subscription-add.pl:#use Smart::Comments; But there are no '###' in those files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 09:48:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 07:48:29 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #36 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #34) > (In reply to Nick Clemens from comment #32) > > I get the extra warning if i run the test before the DB update, but all is > > good after > > Still have it. Forget this one: strict sql mode stuff.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 09:49:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 07:49:10 +0000 Subject: [Koha-bugs] [Bug 28624] Smart::Comments not used and not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28624 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 09:49:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 07:49:14 +0000 Subject: [Koha-bugs] [Bug 28624] Smart::Comments not used and not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28624 --- Comment #1 from Jonathan Druart --- Created attachment 122357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122357&action=edit Bug 28624: Remove Smart::Comments It's not used in those files (there is no occurrence of ###), and it's not installed anyway (it is by koha-testing-docker however). We should remove those lines. Test plan: Confirm the above -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 10:16:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 08:16:59 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #21 from Marcel de Rooy --- This development is actually very important for us and received no interest from anyone since 2018. Obviously it did and does not apply anymore at some point in time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 10:21:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 08:21:12 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #22 from Marcel de Rooy --- CONFLICT (modify/delete): installer/data/mysql/uk-UA/mandatory/sample_notices.sql deleted in HEAD and modified in Bug 20472: Update translated AR notices. Version Bug 20472: Update translated AR notices of installer/data/mysql/uk-UA/mandatory/sample_notices.sql left in tree. CONFLICT (modify/delete): installer/data/mysql/ru-RU/mandatory/sample_notices.sql deleted in HEAD and modified in Bug 20472: Update translated AR notices. Version Bug 20472: Update translated AR notices of installer/data/mysql/ru-RU/mandatory/sample_notices.sql left in tree. CONFLICT (modify/delete): installer/data/mysql/pl-PL/mandatory/sample_notices.sql deleted in HEAD and modified in Bug 20472: Update translated AR notices. Version Bug 20472: Update translated AR notices of installer/data/mysql/pl-PL/mandatory/sample_notices.sql left in tree. I will leave these out now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 10:25:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 08:25:29 +0000 Subject: [Koha-bugs] [Bug 27426] Plugin barcode must keep leading zeros In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27426 --- Comment #6 from Jonathan Druart --- (In reply to David Cook from comment #3) > Btw, we can't use ABS() here because it interprets exponents. For instance, > "select abs(978e0143019375)" will actually create an error or "Inf" if it's > already stored in a database column. How do we process then, David? The patch here has test to prove it is working. I can base it on top of yours, but you need to do what's needed to remove its FQA status. (In reply to Hakam Almotlak from comment #4) > hey i applied the patch and it did`t work i still get the last bar code > number plus one and without the zeros at the begging Please detail what you tried exactly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 10:25:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 08:25:44 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #23 from Marcel de Rooy --- CONFLICT (modify/delete): installer/data/mysql/it-IT/necessari/notices.sql deleted in HEAD and modified in Bug 20472: Update translated AR notices. Version Bug 20472: Update translated AR notices of installer/data/mysql/it-IT/necessari/notices.sql left in tree. CONFLICT (modify/delete): installer/data/mysql/de-DE/mandatory/sample_notices.sql deleted in HEAD and modified in Bug 20472: Update translated AR notices. Version Bug 20472: Update translated AR notices of installer/data/mysql/de-DE/mandatory/sample_notices.sql left in tree. Could be added back later on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:00:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:00:07 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121309|0 |1 is obsolete| | Attachment #121310|0 |1 is obsolete| | Attachment #121311|0 |1 is obsolete| | Attachment #121312|0 |1 is obsolete| | Attachment #121313|0 |1 is obsolete| | Attachment #121314|0 |1 is obsolete| | --- Comment #92 from Jonathan Druart --- Created attachment 122360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122360&action=edit Bug 17600: Standardize our EXPORT_OK On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. There are still a lot of things to do, it would be good to write a script to do what's need to be done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:00:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:00:16 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #93 from Jonathan Druart --- Created attachment 122361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122361&action=edit Bug 17600: After export.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:00:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:00:23 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #94 from Jonathan Druart --- Created attachment 122362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122362&action=edit Bug 17600: After perlimports find . -name '*.pm' -o -name '*.pl' -exec perl App-perlimports/script/perlimports --inplace-edit --no-preserve-unused --filename {} \; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:00:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:00:29 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #95 from Jonathan Druart --- Created attachment 122363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122363&action=edit Bug 17600: Manual changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:00:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:00:37 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #96 from Jonathan Druart --- Created attachment 122364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122364&action=edit Bug 17600: after perlimports pm Was missing the pm find . \( -name "*.pl" -o -name "*.pm" \) -exec perl App-perlimports/script/perlimports --inplace-edit --no-preserve-unused --filename {} \; TODO: Restore permissions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:00:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:00:42 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #97 from Jonathan Druart --- Created attachment 122365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122365&action=edit Bug 17600: Other manual changes after second perlimports run -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:02:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:02:43 +0000 Subject: [Koha-bugs] [Bug 28625] New: Acquisitions section could be further split up Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28625 Bug ID: 28625 Summary: Acquisitions section could be further split up Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Currently, the Acquisitions 'Placing orders' section is confusing. We start well by giving each 'from' it's own section title, but then the process of closing a basket and actually placing the order appears to be mingled into the bottom section.. we should split that out. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:06:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:06:11 +0000 Subject: [Koha-bugs] [Bug 28626] New: Scrolling through the docs doesn't highlight the section heading on the left Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28626 Bug ID: 28626 Summary: Scrolling through the docs doesn't highlight the section heading on the left Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org As you scroll through the documentation, it would be good if the bold highlighting on the navigation links tracked with the page location. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:12:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:12:40 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122360|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:12:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:12:46 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122361|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:12:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:12:52 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122362|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:12:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:12:55 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122363|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:12:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:12:59 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122364|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:13:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:13:02 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122365|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:13:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:13:13 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #98 from Jonathan Druart --- Please test the remote branch - https://gitlab.com/joubu/Koha/-/tree/bug_17600_new -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:24:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:24:52 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:24:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:24:54 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111473|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:24:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:24:57 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111474|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:24:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:24:59 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111475|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:25:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:25:01 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111476|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:25:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:25:03 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111477|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:25:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:25:06 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111478|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:25:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:25:08 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111479|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:25:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:25:33 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:27:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:27:30 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #24 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #9) > The plan changed ;) This patch set has run in production on 16.11 and 18.05. > And I rebased for 19.11 and master now. So I had this stuff on 16.11, 18.05, 19.11, 20.06 and 21.06 now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:29:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:29:20 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #25 from Marcel de Rooy --- Note for QA: Should we try to update existing notices here too ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:31:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:31:42 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:31:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:31:46 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #26 from Marcel de Rooy --- Created attachment 122366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122366&action=edit Bug 20472: Add new fields article_requests.format and urls The field 'format' will allow to make a distinction between requests for photocopies and digital scans. The field 'urls' will be used to save the URLs that allow the client to download the scanned materials. Test plan: Run new install or upgrade existing install with atomic update. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:31:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:31:49 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #27 from Marcel de Rooy --- Created attachment 122367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122367&action=edit Bug 20472: Db rev for new preference ArticleRequestsSupportedFormats This preference controls which formats are actually offered to patrons of the library via the Article Request feature. By default, it only contains PHOTOCOPY. This is default behavior. The request format SCAN will be made possible by this report and can be added by changing the preference. Test plan: Run the dbrev. Check the new pref on Administration. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:31:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:31:53 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #28 from Marcel de Rooy --- Created attachment 122368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122368&action=edit Bug 20472: Add format field to the interface We need to add the format to the forms entering new requests: opac/opac-request-article circ/request-article If the pref contains multiple formats like SCAN|PHOTOCOPY, the first listed format will be preselected on the request form. If there is only one option, we should not disable the select however. (Possibly hide it.) If we have no mandatory fields, we should not allow the submit of a complete empty form (check on OPAC). And we need to show the format of pending requests on forms: opac/opac-user circ/request-article (biblio detail tab) circ/article-requests (staff form to handle requests) members/moremember (Article requests tab at the bottom) circ/circulation (Checkout/Article requests tab) Note: The last two forms use the same include file. Test plan: [1] Add an article request via opac or staff. Choose Scan. [2] Verify that you see the Scan format on opac-user and the above-mentioned staff forms. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:31:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:31:57 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #29 from Marcel de Rooy --- Created attachment 122369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122369&action=edit Bug 20472: Edit URL field on staff form This patch makes the following changes: Add menu option Edit URLs. Edit modal form to edit URLs. Save URLs via ajax call to svc/article_request (Add action update_urls). Add URL column to pending and processing table. Allow Edit URLs for pending table too (just as Complete). Do not allow 'Complete request' if a scan request has no URL(s). Test plan: [1] Add a few scan and photocopy requests. [2] Fill url-A and url-B in two separate scan requests. [3] Verify that these two urls are really saved (refresh form). [4] Check that you cannot complete a scan request without URL and that you cannot add a URL to a photocopy request. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:32:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:32:00 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #30 from Marcel de Rooy --- Created attachment 122370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122370&action=edit Bug 20472: Add format to sample notices NOTE: We are only changing English here. A follow-up will care for the translated languages. (English is in yml format, the remainder not yet.) We need to change the following notices: AR_SLIP, AR_CANCELED, AR_PROCESSING, AR_PENDING and AR_COMPLETED. In AR_COMPLETED the last sentence about picking up has been modified too. Test plan: Reinstall Koha. Choose English. Check notice text. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:32:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:32:04 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #31 from Marcel de Rooy --- Created attachment 122371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122371&action=edit Bug 20472: Update translated AR notices Originally, we had: de-DE/mandatory/sample_notices.sql fr-CA/obligatoire/sample_notices.sql fr-FR/1-Obligatoire/sample_notices.sql it-IT/necessari/notices.sql nb-NO/1-Obligatorisk/sample_notices.sql pl-PL/mandatory/sample_notices.sql ru-RU/mandatory/sample_notices.sql uk-UA/mandatory/sample_notices.sql Obviously, the landscape changed in the meantime. We still have: fr-CA, fr-FR, nb-NO. Test plan: Reinstall notices for one of the languages above. Signed-off-by: Marcel de Rooy Have run all sql files thru mysql on the command line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:32:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:32:08 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #32 from Marcel de Rooy --- Created attachment 122372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122372&action=edit Bug 20472: [DO NOT PUSH] DBIx schema changes Refreshed 24-06-21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:45:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:45:57 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #50 from Marcel de Rooy --- HELP Who wants to assist in getting this fURTHER ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:50:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:50:23 +0000 Subject: [Koha-bugs] [Bug 28622] Selected branchcode not passed to adv search? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:54:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:54:16 +0000 Subject: [Koha-bugs] [Bug 28571] C4::Auth::_session_log is not used and must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28571 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:54:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:54:19 +0000 Subject: [Koha-bugs] [Bug 28571] C4::Auth::_session_log is not used and must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28571 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:54:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:54:21 +0000 Subject: [Koha-bugs] [Bug 28600] Variable "$patron" is not available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:54:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:54:23 +0000 Subject: [Koha-bugs] [Bug 28600] Variable "$patron" is not available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:54:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:54:26 +0000 Subject: [Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:54:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:54:28 +0000 Subject: [Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:54:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:54:31 +0000 Subject: [Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 11:54:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 09:54:33 +0000 Subject: [Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 --- Comment #15 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 12:07:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 10:07:54 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122366|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize --- Created attachment 122373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122373&action=edit Bug 20472: Add new fields article_requests.format and urls The field 'format' will allow to make a distinction between requests for photocopies and digital scans. The field 'urls' will be used to save the URLs that allow the client to download the scanned materials. Test plan: Run new install or upgrade existing install with atomic update. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 12:07:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 10:07:58 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122367|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize --- Created attachment 122374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122374&action=edit Bug 20472: Db rev for new preference ArticleRequestsSupportedFormats This preference controls which formats are actually offered to patrons of the library via the Article Request feature. By default, it only contains PHOTOCOPY. This is default behavior. The request format SCAN will be made possible by this report and can be added by changing the preference. Test plan: Run the dbrev. Check the new pref on Administration. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 12:08:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 10:08:03 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122368|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize --- Created attachment 122375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122375&action=edit Bug 20472: Add format field to the interface We need to add the format to the forms entering new requests: opac/opac-request-article circ/request-article If the pref contains multiple formats like SCAN|PHOTOCOPY, the first listed format will be preselected on the request form. If there is only one option, we should not disable the select however. (Possibly hide it.) If we have no mandatory fields, we should not allow the submit of a complete empty form (check on OPAC). And we need to show the format of pending requests on forms: opac/opac-user circ/request-article (biblio detail tab) circ/article-requests (staff form to handle requests) members/moremember (Article requests tab at the bottom) circ/circulation (Checkout/Article requests tab) Note: The last two forms use the same include file. Test plan: [1] Add an article request via opac or staff. Choose Scan. [2] Verify that you see the Scan format on opac-user and the above-mentioned staff forms. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 12:08:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 10:08:06 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122369|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize --- Created attachment 122376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122376&action=edit Bug 20472: Edit URL field on staff form This patch makes the following changes: Add menu option Edit URLs. Edit modal form to edit URLs. Save URLs via ajax call to svc/article_request (Add action update_urls). Add URL column to pending and processing table. Allow Edit URLs for pending table too (just as Complete). Do not allow 'Complete request' if a scan request has no URL(s). Test plan: [1] Add a few scan and photocopy requests. [2] Fill url-A and url-B in two separate scan requests. [3] Verify that these two urls are really saved (refresh form). [4] Check that you cannot complete a scan request without URL and that you cannot add a URL to a photocopy request. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 12:08:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 10:08:10 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122370|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize --- Created attachment 122377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122377&action=edit Bug 20472: Add format to sample notices NOTE: We are only changing English here. A follow-up will care for the translated languages. (English is in yml format, the remainder not yet.) We need to change the following notices: AR_SLIP, AR_CANCELED, AR_PROCESSING, AR_PENDING and AR_COMPLETED. In AR_COMPLETED the last sentence about picking up has been modified too. Test plan: Reinstall Koha. Choose English. Check notice text. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 12:08:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 10:08:14 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122371|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize --- Created attachment 122378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122378&action=edit Bug 20472: Update translated AR notices Originally, we had: de-DE/mandatory/sample_notices.sql fr-CA/obligatoire/sample_notices.sql fr-FR/1-Obligatoire/sample_notices.sql it-IT/necessari/notices.sql nb-NO/1-Obligatorisk/sample_notices.sql pl-PL/mandatory/sample_notices.sql ru-RU/mandatory/sample_notices.sql uk-UA/mandatory/sample_notices.sql Obviously, the landscape changed in the meantime. We still have: fr-CA, fr-FR, nb-NO. Test plan: Reinstall notices for one of the languages above. Signed-off-by: Marcel de Rooy Have run all sql files thru mysql on the command line. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 12:08:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 10:08:19 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122372|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize --- Created attachment 122379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122379&action=edit Bug 20472: [DO NOT PUSH] DBIx schema changes Refreshed 24-06-21 Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 12:09:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 10:09:16 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #40 from Martin Renvoize --- This works really nicely and the code is nice and clean.. Signing off. However.. QA script highlights some missing filters.. a quick follow-up should resolve those ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 12:12:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 10:12:54 +0000 Subject: [Koha-bugs] [Bug 28627] New: Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 Bug ID: 28627 Summary: Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Currently, the order receive page (orderreceive.tt) displays unitprice_tax_included/unitprice_tax_excluded in the 'Actual cost' field. However, if the user has not set a unitprice previously in the acquisitions workflow then the 'Actual cost' is displayed with a value of 0.000 In Koha 20.05.x the 'Actual cost' was displayed as ecost_tax_included/ecost_tax_excluded if unitprice was not defined. Like in Bug 25750 , Koha should fallback to using ecost_tax_included and ecost_tax_excluded if unitprice is not defined. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 12:13:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 10:13:01 +0000 Subject: [Koha-bugs] [Bug 28623] Fails to connect to server do not get response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28623 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID CC| |jonathan.druart+koha at gmail. | |com Status|NEW |RESOLVED --- Comment #2 from Jonathan Druart --- This is a support question, please ask the mailing list. https://koha-community.org/support/koha-mailing-lists/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 12:14:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 10:14:47 +0000 Subject: [Koha-bugs] [Bug 28614] 500 error on Stage MARC records for import, Staged MARC record management, Upload local cover image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28614 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- It works for me, which error do you get? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 12:34:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 10:34:08 +0000 Subject: [Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 --- Comment #1 from Alex Buckley --- Created attachment 122380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122380&action=edit Bug 28627: Fallback to displaying ecost_tax_included, ecost_tax_excluded in orderreceive.pl Test plan: 1. Create a basket and adding items to it. Set the 'Vendor price' to '20', do not add an 'Actual cost' 2. Close the basket 3. Select 'Receive shipment' 4. Set a value for vendor invoice 5. Receive the order you created 6. Observe 'Actual cost' is = 0.00 7. Apply patch 8. Refresh the order receival page, and confirm the 'Actual cost' = 20.00 Sponsored-By: South Taranaki District Council, NZ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 12:44:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 10:44:10 +0000 Subject: [Koha-bugs] [Bug 28585] Cannot search on date fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bug in GET /patrons by |Cannot search on date |date_of_birth |fields Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Severity|normal |major Version|21.05 |unspecified CC| |jonathan.druart+koha at gmail. | |com Status|NEW |ASSIGNED --- Comment #4 from Jonathan Druart --- DBIC is receiving dateofbirth { like "%1980-04-24T00:00:00%" } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 12:47:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 10:47:34 +0000 Subject: [Koha-bugs] [Bug 28585] Cannot search on date fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 --- Comment #5 from Jonathan Druart --- Created attachment 122381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122381&action=edit Bug 28585: Fix search on date field We should not rfc3339 format the date if it's not a datetime -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 12:48:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 10:48:00 +0000 Subject: [Koha-bugs] [Bug 28585] Cannot search on date fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 --- Comment #6 from Jonathan Druart --- Tomas, looks like this could be a fix. Do you see something else? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 12:50:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 10:50:23 +0000 Subject: [Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #16 from Jonathan Druart --- t/Auth_with_shibboleth.t is failing 12:06:13 koha_1 | Log::Log4perl configuration looks suspicious: No loggers defined at /usr/share/perl5/Log/Log4perl/Config.pm line 325. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 12:51:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 10:51:07 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 --- Comment #17 from Jonathan Druart --- Since bug 28606 t/Auth_with_shibboleth.t is failing 12:06:13 koha_1 | Log::Log4perl configuration looks suspicious: No loggers defined at /usr/share/perl5/Log/Log4perl/Config.pm line 325. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 13:33:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 11:33:22 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 --- Comment #18 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #17) > Since bug 28606 t/Auth_with_shibboleth.t is failing > > 12:06:13 koha_1 | Log::Log4perl configuration looks suspicious: No > loggers defined at /usr/share/perl5/Log/Log4perl/Config.pm line 325. Tests in t/ should not depend on a setup (i.e. should be mocked). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 14:13:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 12:13:02 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122379|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy --- Created attachment 122382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122382&action=edit Bug 20472: (QA follow-up) Add few TT filters Signed-off-by: Marcel de Rooy No more warns from qa tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 14:13:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 12:13:05 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #42 from Marcel de Rooy --- Created attachment 122383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122383&action=edit Bug 20472: [DO NOT PUSH] DBIx schema changes Refreshed 24-06-21 Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 14:48:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 12:48:10 +0000 Subject: [Koha-bugs] [Bug 28614] 500 error on Stage MARC records for import, Staged MARC record management, Upload local cover image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28614 --- Comment #2 from Andrew Fuerste-Henry --- Huh. I'm on Koha Testing Docker, running master, on Chrome. When I click the Stage MARC Records for Import link in Tools it tries to load this url: http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl. After a couple seconds I get an error page that says: An error has occurred! Error 500 This message may have been caused by any of the following reasons: You made use of an external link to an item that is no longer available You followed an outdated link e.g. from a search engine or a bookmark You tried to access a page that needs authentication An internal link in the client is broken and the page does not exist -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 14:48:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 12:48:09 +0000 Subject: [Koha-bugs] [Bug 28196] In page anchors on additem.pl don't always go to the right place In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28196 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 14:48:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 12:48:13 +0000 Subject: [Koha-bugs] [Bug 28196] In page anchors on additem.pl don't always go to the right place In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28196 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122352|0 |1 is obsolete| | --- Comment #9 from David Nind --- Created attachment 122384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122384&action=edit Bug 28196: make sure URL hash is appended last TO test: 1 Do a search within the staff client 2 Click on any results and go to the detail page 3 Click the edit button on any item in that record, it should take you to a URL like this: '/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=55&itemnumber=117#edititem&searchid=scs_1619109565224' 4 Apply patch 5 Do steps 1 & 2 again Click the edit button on any item in that record, it should take you to a URL like this: '/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=55&itemnum ber=117&searchid=scs_1619109565224#edititem' 6. If they URL hash is last the anchor should work and you'll be placed on the h2 element with and ID of edititem Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 14:57:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 12:57:08 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 --- Comment #19 from Jonathan Druart --- The following line: t::lib::Mocks::mock_logger({ warn => 1 }); needs to be: my $m = t::lib::Mocks::mock_logger({ warn => 1 }); Or the module won't be mocked correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 15:11:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 13:11:54 +0000 Subject: [Koha-bugs] [Bug 28399] batchRebuildItemsTables.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28399 --- Comment #1 from Jonathan Druart --- Created attachment 122385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122385&action=edit Bug 28399: Remove txn error from batchRebuildItemsTables.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 15:12:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 13:12:45 +0000 Subject: [Koha-bugs] [Bug 28399] batchRebuildItemsTables.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28399 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Version|20.11 |unspecified CC| |jonathan.druart+koha at gmail. | |com Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com --- Comment #2 from Jonathan Druart --- Hi Julien, I am not familiar with the script so hard to fully test it, but this patch should remove the error you got. Can you confirm? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 15:13:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 13:13:38 +0000 Subject: [Koha-bugs] [Bug 28614] 500 error on Stage MARC records for import, Staged MARC record management, Upload local cover image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28614 --- Comment #3 from Jonathan Druart --- Anything relevant in the Koha log files? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 15:14:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 13:14:36 +0000 Subject: [Koha-bugs] [Bug 28628] New: Elasticsearch - Heading search form does'nt match related indexed heading Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28628 Bug ID: 28628 Summary: Elasticsearch - Heading search form does'nt match related indexed heading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: alex.arnaud at biblibre.com When an authority is created using LinkBibHeadingsToAuthorities the heading created "700 $aVidard $bMathieu $f1971-..." (unimarc) is saved as "Vidard Mathieu 1971-..", indexed as "Vidard Mathieu 1971-.." and searched as "Vidard Mathieu 1971" => no match. So the link bib does'nt work. Test plan (UNIMARC exemple): - create a biblio with the following data in tag 700: - $a Vidard - $b Mathieu - $d 1971-... - save. => a new authority is created with the following heading "Vidard Mathieu 1971-.." - create an other biblio with the same value in tag 700. => again a new authority is created with the same heading. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 15:15:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 13:15:01 +0000 Subject: [Koha-bugs] [Bug 28628] Elasticsearch - Heading search form does'nt match related indexed heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28628 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 15:15:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 13:15:07 +0000 Subject: [Koha-bugs] [Bug 28614] 500 error on Stage MARC records for import, Staged MARC record management, Upload local cover image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28614 --- Comment #4 from Lucas Gass --- I am also able to recreate this in master, same 500 error as Andrew. These pages seem to be the ones effected: "/cgi-bin/koha/offline_circ/process_koc.pl" "/cgi-bin/koha/tools/background-job-progress.pl" "/cgi-bin/koha/tools/export.pl" "/cgi-bin/koha/tools/manage-marc-import.pl" "/cgi-bin/koha/tools/stage-marc-import.pl" "/cgi-bin/koha/tools/upload-cover-image.pl" "/cgi-bin/koha/svc/cataloguing/metasearch" These files are all listed in apache-shared-intranet-plack.conf with the comment: # FIXME: These scripts should be fixed so they # don't break under plack/starman Perhaps related? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 15:21:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 13:21:14 +0000 Subject: [Koha-bugs] [Bug 28628] Elasticsearch - Heading search form does'nt match related indexed heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28628 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |19.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 15:31:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 13:31:21 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #43 from Martin Renvoize --- (In reply to Marcel de Rooy from comment #25) > Note for QA: > > Should we try to update existing notices here too ? No we have logs for notices changes, we could theoretically try.. but I don't see that as a blocker for this either. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 15:44:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 13:44:01 +0000 Subject: [Koha-bugs] [Bug 28614] 500 error on Stage MARC records for import, Staged MARC record management, Upload local cover image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28614 --- Comment #5 from Lucas Gass --- I am seeing this error in the intranet-error.log: [Thu Jun 24 13:42:19.781481 2021] [cgi:error] [pid 35597] [client 172.19.0.1:64816] AH01215: new(): failed: couldn't load CGI::Session::Serialize::yamlxs: Can't locate CGI/Session/Serialize/yamlxs.pm in @INC (you may need to install the CGI::Session::Serialize::yamlxs module) (@INC contains: /kohadevbox/koha /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base /var/lib/koha/kohadev/plugins) at (eval 1661) line 2.: /kohadevbox/koha/tools/stage-marc-import.pl [Thu Jun 24 13:42:19.823176 2021] [cgi:error] [pid 35597] [client 172.19.0.1:64816] End of script output before headers: stage-marc-import.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 15:46:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 13:46:33 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119108|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy --- Created attachment 122386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122386&action=edit Bug 26302: OPAC XSLT Results: List variable number of itemcallnumbers We define a local preference resultsMaxItems and add it to the xml passed to the results XSLT (in C4::XSLT). Instead of showing one item, we add this number of items for the available for loan and reference segments. Test plan: Play with the value of local pref resultsMaxItems. Check if it matches with displayed callnumbers. Try home and holdingbranch for results location. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 15:46:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 13:46:36 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119109|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy --- Created attachment 122387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122387&action=edit Bug 26302: Add syspref resultsMaxItemsUnavailable This is the number of call numbers displayed for unavailable categories in the results XSLT. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 15:46:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 13:46:40 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119111|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy --- Created attachment 122388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122388&action=edit Bug 26302: Use resultsMaxItemsUnavailable in stylesheet We start here with Checked out until On hold. Not sure if we should do exactly the same for the remaining not for loan categories. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 15:46:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 13:46:43 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #15 from Marcel de Rooy --- Created attachment 122389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122389&action=edit Bug 26302: Add dbrev for two new prefs Formalizing the local prefs introduced in the former patches: resultsMaxItems resultsMaxItemsUnavailable Test plan: Check Preferences/OPAC/Appearance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 15:48:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 13:48:56 +0000 Subject: [Koha-bugs] [Bug 28614] 500 error on Stage MARC records for import, Staged MARC record management, Upload local cover image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28614 --- Comment #6 from Jonathan Druart --- Update ktd and pull the latest docker images. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 15:51:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 13:51:30 +0000 Subject: [Koha-bugs] [Bug 28442] Release team 21.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28442 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.07,20.05.13 |21.05.00,20.11.07 released in| | --- Comment #21 from Victor Grousset/tuxayo --- You are right! Nice catch, thanks. It's indeed string freeze. Reverted. Yesterday I even though about paying attention to that. But happily forgot it when actually backporting stuff ^^" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 15:54:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 13:54:35 +0000 Subject: [Koha-bugs] [Bug 28386] Replace dev_map.yaml from release_tools with .mailmap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28386 --- Comment #49 from Victor Grousset/tuxayo --- Yes, in bug 28442 it's mentioned that it will have to be backported to all stables. And this one it a dependency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 16:00:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 14:00:03 +0000 Subject: [Koha-bugs] [Bug 28611] Incorrect Select2 width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 16:00:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 14:00:06 +0000 Subject: [Koha-bugs] [Bug 28611] Incorrect Select2 width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122276|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 122390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122390&action=edit Bug 28611: Fix width to 50% for additem form elements This patch suggests to set the width of select and input to 50% Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 16:04:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 14:04:57 +0000 Subject: [Koha-bugs] [Bug 28616] Remove Data::Printer dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28616 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|20.11.00 |20.11.00,20.05.01 released in| | --- Comment #6 from Kyle M Hall --- Pushed to 21.05.x for 20.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 16:06:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 14:06:52 +0000 Subject: [Koha-bugs] [Bug 28523] Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523 --- Comment #4 from David Nind --- Thanks Jonathan! I can now get this to work with MySQL 8 (ku-my8). With the patch applied in master with MariaDB (ku), I need to turn off strict mode to get this to work. Is that what is expected, or is another bug going to fix this? David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 16:27:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 14:27:04 +0000 Subject: [Koha-bugs] [Bug 28624] Smart::Comments not used and not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28624 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from David Nind --- Patch no longer applies 8-(... Looks like members/printslip.pl is already fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 16:29:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 14:29:36 +0000 Subject: [Koha-bugs] [Bug 28628] Elasticsearch - Heading search form does'nt match related indexed heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28628 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 16:34:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 14:34:51 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #16 from Marcel de Rooy --- Created attachment 122391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122391&action=edit Bug 26302: Apply resultsMaxItemsUnavailable to the NFLs too Test plan: Add some not for loan categories, add some items for them. Check search results. Verify that results match expectation. Signed-off-by: Marcel de Rooy Tested the combination of pref values for results 2/1 with NFL categories TEST, MOVING: Availability: Items available for loan: Centerville (3) [Call number: PERL A 2, PERL A 3, ...] Items available for reference: Centerville Staff Collection (1) [Call number: PERL A 10]. Not available: TEST (2) [ PERL A 11, .. ]. MOVING (1) [ PERL A 13 ]. Withdrawn (2) [ PERL A 5, .. ]. Damaged (3) [ PERL A 7, .. ]. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 16:35:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 14:35:33 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #17 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #11) > We start here with Checked out until On hold. > Not sure if we should do exactly the same for the remaining > not for loan categories. Note that the last patch now fills that gap. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 16:36:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 14:36:29 +0000 Subject: [Koha-bugs] [Bug 28614] 500 error on Stage MARC records for import, Staged MARC record management, Upload local cover image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28614 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #7 from Andrew Fuerste-Henry --- That did it, thanks! Apologies for not thinking to do that first. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 16:38:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 14:38:24 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 16:38:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 14:38:28 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122355|0 |1 is obsolete| | --- Comment #23 from David Nind --- Created attachment 122392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122392&action=edit Bug 15156: Get all patrons with owings This patch adds method to return set of unique patrons with accountlines matching filtering params. To test: prove t/db_dependent/Koha/Patrons.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 16:41:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 14:41:58 +0000 Subject: [Koha-bugs] [Bug 28628] Elasticsearch - Heading search form does'nt match related indexed heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28628 --- Comment #1 from Alex Arnaud --- Created attachment 122393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122393&action=edit Bug 28628: Make heading search form match related indexed heading Test plan (UNIMARC exemple): - create a biblio with the following data in tag 700: - $a Vidard - $b Mathieu - $d 1971-... - save. => a new authority is created with the following heading "Vidard Mathieu 1971-.." - create an other biblio with the same value in tag 700. => again a new authority is created with the same heading. - apply this patch and repeat the test plan - The 2nd 700 tag should map to the same authority. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 16:44:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 14:44:26 +0000 Subject: [Koha-bugs] [Bug 28628] Elasticsearch - Heading search form does'nt match related indexed heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28628 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Alex Arnaud --- Bug 18017 solved this for 20.11.06 but not backported. Wish this for 20.05 and 19.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 18:41:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 16:41:16 +0000 Subject: [Koha-bugs] [Bug 28524] Most-circulated items (cat_issues_top.pl) is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28524 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 18:41:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 16:41:19 +0000 Subject: [Koha-bugs] [Bug 28524] Most-circulated items (cat_issues_top.pl) is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28524 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122036|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 122394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122394&action=edit Bug 28524: Escape 'rank' in cat_issues_top.pl It's a MySQL 8 keyword Test plan: Turn off strict_sql_modes (there are other problems in this script) Hit Home Reports > Most-circulated items Submit the form Without this patch you got: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'RANK, biblio.biblionumber AS ID, itemcallnumber as CALLNUM, ccode as CCODE, loca' at line 1 With this patch applied you see the report result view Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 18:44:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 16:44:36 +0000 Subject: [Koha-bugs] [Bug 28523] Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 18:44:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 16:44:39 +0000 Subject: [Koha-bugs] [Bug 28523] Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122037|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 122395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122395&action=edit Bug 28523: Escape 'rank' in bor_issues_top.pl It's a MySQL 8 keyword Test plan: Turn off strict_sql_modes (there are other problems in this script) Hit Home Reports > Patrons with the most checkouts Submit the form Without this patch you got: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'RANK, borrowers.borrowernumber AS ID FROM `old_issues` With this patch applied you see the report result view Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 19:10:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 17:10:14 +0000 Subject: [Koha-bugs] [Bug 27495] The "Accessibility advocate" role is not yet listed in the about page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27495 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.07,20.05.13 |21.05.00,20.11.07 released in| | --- Comment #12 from Victor Grousset/tuxayo --- Nice catch, thanks. It's indeed string freeze. Reverted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 20:38:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 18:38:50 +0000 Subject: [Koha-bugs] [Bug 14090] Add link to basket from invoice and vice versa In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14090 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |andrew at bywatersolutions.com --- Comment #2 from Andrew Fuerste-Henry --- *** This bug has been marked as a duplicate of bug 28449 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 20:38:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 18:38:50 +0000 Subject: [Koha-bugs] [Bug 28449] Link from basket summary to invoice for an order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28449 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #1 from Andrew Fuerste-Henry --- *** Bug 14090 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 20:40:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 18:40:32 +0000 Subject: [Koha-bugs] [Bug 28449] Link from basket summary to invoice for an order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28449 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #2 from Andrew Fuerste-Henry --- +1 on this. Currently on needs to follow a needlessly cumbersome chain of links from the basket to the bib to the invoice. There's no reason not to make that easier. I'm in favor of either of Katrin's options (a new column or a link off of the "received" note). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 23:27:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 21:27:26 +0000 Subject: [Koha-bugs] [Bug 28575] Add ability to choose if lost fee is refunded based on when lost fee was paid off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Cheryl changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman at fargolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 24 23:31:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Jun 2021 21:31:53 +0000 Subject: [Koha-bugs] [Bug 28575] Add ability to choose if lost fee is refunded based on when lost fee was paid off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 06:37:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 04:37:15 +0000 Subject: [Koha-bugs] [Bug 27426] Plugin barcode must keep leading zeros In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27426 --- Comment #7 from David Cook --- (In reply to Jonathan Druart from comment #6) > (In reply to David Cook from comment #3) > > Btw, we can't use ABS() here because it interprets exponents. For instance, > > "select abs(978e0143019375)" will actually create an error or "Inf" if it's > > already stored in a database column. > > How do we process then, David? The patch here has test to prove it is > working. I can base it on top of yours, but you need to do what's needed to > remove its FQA status. Do you mean for Bug 26328? That tester never responded to my questions. I could re-test it myself, but it could be good to get someone new to test too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 06:40:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 04:40:20 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #36 from David Cook --- (In reply to Julian Maurice from comment #33) > But using Plack::Middleware::Session would prevent using koha with > mojolicious servers like morbo or hypnotoad, right ? Probably -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 06:43:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 04:43:19 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #38 from David Cook --- (In reply to Jonathan Druart from comment #34) > And, FWIW, if I move the YAML::XS serializer (see last patch) in the > Data/Session/Serialize directory, all tests pass (longblob). Wait this works despite https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427#c29 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 06:45:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 04:45:33 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #39 from David Cook --- (In reply to David Cook from comment #38) > (In reply to Jonathan Druart from comment #34) > > And, FWIW, if I move the YAML::XS serializer (see last patch) in the > > Data/Session/Serialize directory, all tests pass (longblob). > > Wait this works despite > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427#c29 ? Oh maybe I misunderstand what you're saying... you meant in the vendor perl not the Koha perl lib... right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 06:46:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 04:46:04 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #37 from David Cook --- (In reply to Jonathan Druart from comment #34) > But it needs to be top priority for you. Fair enough. I have very little to give to Koha at the moment... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 06:46:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 04:46:50 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #354 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #353) > (In reply to David Cook from comment #351) > > I can't guarantee that my last patches actually apply on master > > Indeed lol :P > > > Patch failed at 0001 Bug 15516: Add ability to create hold groups from OPAC I can look at fixing that in early July I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 08:26:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 06:26:29 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #191 from Marcel de Rooy --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 08:26:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 06:26:39 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle at bywatersolutions.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 08:27:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 06:27:48 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #192 from Marcel de Rooy --- +

    We removed timestamp from opac_news on bug 21066. Familiar author? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 08:30:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 06:30:40 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #40 from Jonathan Druart --- (In reply to David Cook from comment #39) > (In reply to David Cook from comment #38) > > (In reply to Jonathan Druart from comment #34) > > > And, FWIW, if I move the YAML::XS serializer (see last patch) in the > > > Data/Session/Serialize directory, all tests pass (longblob). > > > > Wait this works despite > > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427#c29 ? > > Oh maybe I misunderstand what you're saying... you meant in the vendor perl > not the Koha perl lib... right? Yes, I copied it to /path/Data/Session/Serialize/yamlxs.pm where /path/Data/Session/ is `pmpath Data::Session`. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 08:34:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 06:34:26 +0000 Subject: [Koha-bugs] [Bug 27426] Plugin barcode must keep leading zeros In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27426 --- Comment #8 from Jonathan Druart --- It could be nice to provide a test first :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 08:45:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 06:45:58 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #193 from Marcel de Rooy --- Subject: [PATCH 18/20] Bug 22544: Fix OpacLoginInstructions What does this patch actually fix ? - [% IF ( OpacLoginInstructions ) %] + [% IF OpacLoginInstructions %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 08:46:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 06:46:53 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #194 from Marcel de Rooy --- + my $published_on_dt = output_pref({ dt => dt_from_string( $all->{pubished_on} ), dateonly => 1 }); Will amend the patch now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:04:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:04:41 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:04:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:04:46 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120377|0 |1 is obsolete| | --- Comment #195 from Marcel de Rooy --- Created attachment 122396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122396&action=edit Bug 22544: Move get_opac_new to Koha namespace Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:04:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:04:52 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120378|0 |1 is obsolete| | --- Comment #196 from Marcel de Rooy --- Created attachment 122397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122397&action=edit Bug 22544: Move get_opac_news to Koha namespace Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:04:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:04:57 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120379|0 |1 is obsolete| | --- Comment #197 from Marcel de Rooy --- Created attachment 122398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122398&action=edit Bug 22544: Move del_opac_new to Koha namespace Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:05:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:05:03 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120380|0 |1 is obsolete| | --- Comment #198 from Marcel de Rooy --- Created attachment 122399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122399&action=edit Bug 22544: Move upd_opac_new to Koha namespace Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:05:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:05:09 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120381|0 |1 is obsolete| | --- Comment #199 from Marcel de Rooy --- Created attachment 122400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122400&action=edit Bug 22544: Move add_opac_item to Koha namespace Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:05:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:05:14 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120382|0 |1 is obsolete| | --- Comment #200 from Marcel de Rooy --- Created attachment 122401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122401&action=edit Bug 22544: Move GetNewsToDisplay to Koha namespace Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:05:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:05:20 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120383|0 |1 is obsolete| | --- Comment #201 from Marcel de Rooy --- Created attachment 122402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122402&action=edit Bug 22544: Add tests Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:05:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:05:25 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120384|0 |1 is obsolete| | --- Comment #202 from Marcel de Rooy --- Created attachment 122403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122403&action=edit Bug 22544: Refactor searching of news items Test plan: 1) Go to tools and define some news 2) Try different parameters, try to edit new items, and delete some 3) Go to all places where news are presented and ensure that there are the right ones shown: opac main page - based on language opac righ column (formerly syspref OpacNavRight) - based on language opac news rss feed circulation slip (not quick slip) intranet main page 4) run tests: prove t/db_dependent/Koha/News.t Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:05:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:05:30 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120385|0 |1 is obsolete| | --- Comment #203 from Marcel de Rooy --- Created attachment 122404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122404&action=edit Bug 22544: (QA follow-up) Fix spelling Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:05:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:05:36 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120386|0 |1 is obsolete| | --- Comment #204 from Marcel de Rooy --- Created attachment 122405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122405&action=edit Bug 22544: Update to current codebase Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:05:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:05:41 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120387|0 |1 is obsolete| | --- Comment #205 from Marcel de Rooy --- Created attachment 122406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122406&action=edit Bug 22544: Update search_for_display to be able to take more types Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:05:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:05:46 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120388|0 |1 is obsolete| | --- Comment #206 from Marcel de Rooy --- Created attachment 122407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122407&action=edit Bug 22544: Fix filtering by location on tools -> news management Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:05:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:05:52 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120389|0 |1 is obsolete| | --- Comment #207 from Marcel de Rooy --- Created attachment 122408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122408&action=edit Bug 22544: Clarify documentation and change param 'type' to 'location' Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:05:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:05:57 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120390|0 |1 is obsolete| | --- Comment #208 from Marcel de Rooy --- Created attachment 122409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122409&action=edit Bug 22544: Enhance exception description Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:06:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:06:03 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120391|0 |1 is obsolete| | --- Comment #209 from Marcel de Rooy --- Created attachment 122410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122410&action=edit Bug 22544: Add default language value to KohaNews template plugin Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:06:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:06:08 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120392|0 |1 is obsolete| | --- Comment #210 from Marcel de Rooy --- Created attachment 122411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122411&action=edit Bug 22544: Use template plugin for news author display Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:06:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:06:13 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120393|0 |1 is obsolete| | --- Comment #211 from Marcel de Rooy --- Created attachment 122412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122412&action=edit Bug 22544: TT plugin should return hashref only if news exist It restore the header and fix the RSS feeds (see comment 103) Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:06:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:06:19 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120394|0 |1 is obsolete| | --- Comment #212 from Marcel de Rooy --- Created attachment 122413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122413&action=edit Bug 22544: Fix OpacLoginInstructions Moved recently Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:06:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:06:24 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120395|0 |1 is obsolete| | --- Comment #213 from Marcel de Rooy --- Created attachment 122414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122414&action=edit Bug 22544: Restore newdate and timestamp for slip notices Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy [EDIT] Fixed typo pubished_on -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:06:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:06:29 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120396|0 |1 is obsolete| | --- Comment #214 from Marcel de Rooy --- Created attachment 122415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122415&action=edit Bug 22544: fix count call - to squash Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:07:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:07:08 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #215 from Marcel de Rooy --- Great work ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:11:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:11:36 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #41 from David Cook --- (In reply to Jonathan Druart from comment #40) > > Oh maybe I misunderstand what you're saying... you meant in the vendor perl > > not the Koha perl lib... right? > > Yes, I copied it to /path/Data/Session/Serialize/yamlxs.pm where > /path/Data/Session/ is `pmpath Data::Session`. But that's not a real solution for production. Shouldn't "Needs Signoff" be changed back to 'Assigned' or "In Discussion"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:13:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:13:29 +0000 Subject: [Koha-bugs] [Bug 28524] Most-circulated items (cat_issues_top.pl) is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28524 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:13:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:13:33 +0000 Subject: [Koha-bugs] [Bug 28524] Most-circulated items (cat_issues_top.pl) is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28524 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122394|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 122416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122416&action=edit Bug 28524: Escape 'rank' in cat_issues_top.pl It's a MySQL 8 keyword Test plan: Turn off strict_sql_modes (there are other problems in this script) Hit Home Reports > Most-circulated items Submit the form Without this patch you got: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'RANK, biblio.biblionumber AS ID, itemcallnumber as CALLNUM, ccode as CCODE, loca' at line 1 With this patch applied you see the report result view Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:13:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:13:49 +0000 Subject: [Koha-bugs] [Bug 28524] Most-circulated items (cat_issues_top.pl) is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28524 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:15:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:15:31 +0000 Subject: [Koha-bugs] [Bug 28523] Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:15:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:15:35 +0000 Subject: [Koha-bugs] [Bug 28523] Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122395|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 122417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122417&action=edit Bug 28523: Escape 'rank' in bor_issues_top.pl It's a MySQL 8 keyword Test plan: Turn off strict_sql_modes (there are other problems in this script) Hit Home Reports > Patrons with the most checkouts Submit the form Without this patch you got: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'RANK, borrowers.borrowernumber AS ID FROM `old_issues` With this patch applied you see the report result view Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:16:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:16:00 +0000 Subject: [Koha-bugs] [Bug 28523] Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:32:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:32:38 +0000 Subject: [Koha-bugs] [Bug 27268] Move C4::Biblio::GetMarcNotes to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27268 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #8 from Jonathan Druart --- This patch introduces a bad side-effect. >From the mailing list https://lists.katipo.co.nz/pipermail/koha/2021-June/056413.html If you have a note in 590$z that is linked with an authorised value, then the code will be displayed instead of the description. What's happening? Before this patch we did (the big lines): my $record = GetMarcBiblio({ biblionumber => $biblionumber }); XSLTParse4Display($record); my $notes = GetMarcNotes($record); => XSLTParse4Display *is modifying* the record (see the $field->replace_with call in transformMARCXML4XSLT) and so GetMarcNotes returned the descriptions of the notes After this patch: my $notes = $biblio->get_marc_notes; => We are no longer using the descriptions! Aleisha, Can you please fix this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:35:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:35:35 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #216 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #193) > Subject: [PATCH 18/20] Bug 22544: Fix OpacLoginInstructions > > What does this patch actually fix ? > > - [% IF ( OpacLoginInstructions ) %] > + [% IF OpacLoginInstructions %] Nothing, it should be skipped. It has been fixed in the meanwhile by commit c45d15e231efd11d5f19f3a1186013daef19d300 Bug 28193: (follow-up) Correct OpacLoginInstructions in login modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:41:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:41:35 +0000 Subject: [Koha-bugs] [Bug 28384] Add 'no_items' option to TransformMarcToKoha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28384 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |BLOCKED CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:44:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:44:20 +0000 Subject: [Koha-bugs] [Bug 28384] Add 'no_items' option to TransformMarcToKoha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28384 --- Comment #3 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 09:44:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 07:44:27 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #11 from Jonathan Druart --- I am suggesting: * Codebase will use "additional_contents", Koha::AdditionalContents * UI will split: Tools > News (same as now) Tools > HTML customization Would that work for everybody? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 10:08:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 08:08:40 +0000 Subject: [Koha-bugs] [Bug 28629] New: Koha does not like zero in a title (and other fields) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28629 Bug ID: 28629 Summary: Koha does not like zero in a title (and other fields) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Title 0 (zero) is No title in the breadcrumbs Callnumber 0 does not show up either in the item tables. Probably we could find more of these things, resulting probably from testing $a instead of defined($a) and $a ne '' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 10:11:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 08:11:59 +0000 Subject: [Koha-bugs] [Bug 28629] Koha does not like zero in a title (and other fields) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28629 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 10:31:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 08:31:00 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #42 from Jonathan Druart --- Ok, let's discuss then. What do we do? I am ok with having our module where Data::Session is expecting it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 10:40:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 08:40:11 +0000 Subject: [Koha-bugs] [Bug 28399] batchRebuildItemsTables.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28399 Julien Sicot (Univ. Rennes 2) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Julien Sicot (Univ. Rennes 2) --- Hi Jonathan, Patch applied in master I confirm it removes errors. Many thanks, Julien -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 10:47:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 08:47:22 +0000 Subject: [Koha-bugs] [Bug 28384] Add 'no_items' option to TransformMarcToKoha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28384 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 10:47:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 08:47:25 +0000 Subject: [Koha-bugs] [Bug 28384] Add 'no_items' option to TransformMarcToKoha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28384 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121150|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 122418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122418&action=edit Bug 28384: Add 'no_items' option to TransformMarcToKoha This patch adds a new option 'no_items' and uses it in the C4::Search::searchResults routine. We don't use the item info fetched here, so skipping those lines saves us time. Additionally, I fix an incorrect FIXME comment, and pass the ISBN returned by the routine above into GetNormalizedISBN to save another lookup TO test: 1 - Enable AmazonCoverImages system preference 2 - Search staff client with a term that returns books with covers 3 - Apply patch 4 - prove -v t/db_dependent/Biblio/TransformMarcToKoha.t 5 - Confirm searching works 6 - Confirm Amazon images display (normalized_isbn is used for these) Signed-off-by: David Nind Signed-off-by: Marcel de Rooy [EDIT] Amended, replacing a tab character. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 10:47:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 08:47:28 +0000 Subject: [Koha-bugs] [Bug 28384] Add 'no_items' option to TransformMarcToKoha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28384 --- Comment #5 from Marcel de Rooy --- Created attachment 122419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122419&action=edit Bug 28384: (QA follow-up) Rearranging unit tests This does two things: [1] Rearranging makes clearing the cache twice no longer needed. [2] Preparing the ground for an additional refinement in the TransformMarcToKoha routine. Test plan: Run TransformMarcToKoha.t. Should fail now for: not ok 1 - Biblio field 510a not ok 5 - Biblio field returned when "no_items" passed Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 10:47:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 08:47:32 +0000 Subject: [Koha-bugs] [Bug 28384] Add 'no_items' option to TransformMarcToKoha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28384 --- Comment #6 from Marcel de Rooy --- Created attachment 122420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122420&action=edit Bug 28384: (follow-up) TransformMarcToKohaOneField should allow zeroes Until now, the test did not pass false values like '0' or ''. But we should pass '0' and not ''. Note that the test for control fields is a bit theoretical since we dont have control fields bound to Koha fields currently. The adjusted unit test in the former patch should now pass. Test plan: Run TransformMarcToKoha.t Signed-off-by: Marcel de Rooy Since this change theoretically has a larger impact, I also tested the cataloguing editor, item editor. And run quite a few tests referring to AddBiblio or ModBiblio. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 10:47:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 08:47:54 +0000 Subject: [Koha-bugs] [Bug 28630] New: ILSDI::AuthenticatePatron should set borrowers.lastseen Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Bug ID: 28630 Summary: ILSDI::AuthenticatePatron should set borrowers.lastseen Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Currently, the ILSDI authentication route does not set the lastseen date for a borrower record. It should. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 10:51:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 08:51:37 +0000 Subject: [Koha-bugs] [Bug 28384] Add 'no_items' option to TransformMarcToKoha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28384 --- Comment #7 from Marcel de Rooy --- (In reply to Nick Clemens from comment #0) > In C4::Search::searchResults - we ignore the item info returned, skipping > processing item lines can save us time The time savings will be absolutely minimal since this whole process runs in memory using cached values etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 10:52:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 08:52:36 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 --- Comment #1 from Martin Renvoize --- Created attachment 122421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122421&action=edit Bug 28630: Add track_login_daily to ILSDI::AuthenticatePatron This patch adds a call to track_login_daily for the AuthenticatePatron method in ILSDI. Many libraries use this ILSDI endpoint for electron book borrowing and need to maintain the lastseen based on this type of lending. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 10:54:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 08:54:17 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 10:54:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 08:54:22 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 10:54:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 08:54:41 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, | |david.roberts at ptfs-europe.c | |om, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 10:55:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 08:55:10 +0000 Subject: [Koha-bugs] [Bug 28211] Replace use of call_recursive() with call() In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28211 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #9 from Marcel de Rooy --- Applying: Bug 26351: Clean up includes in Circulation.pm error: sha1 information is lacking or useless (C4/Circulation.pm). error: could not build fake ancestor Patch failed at 0001 Bug 26351: Clean up includes in Circulation.pm hint: Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-26351-Clean-up-includes-in-Circulationpm-DpTlZT.patch Cannot apply cleanly patches from bug 26351. Everything will be left dirty. git bz apply --continue will not continue the process if patches from other bug reports need to be applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 10:56:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 08:56:20 +0000 Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to Koha::Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 10:59:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 08:59:10 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #10 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #9) > Tests pass, QA scripts pass and the code looks reasonable. > > I'm not entirely sure about the method name.. we now have: > > Koha::Biblio->get_marc_notes; > > and > > Koha::Biblio->get_authors_from_MARC; > > For consistency, I think I'd prefer this patch to introduce > > Koha::Biblio->get_marc_authors; > > But... I think we can leave that decision to the RM.. so Passing QA :) I would also prefer get_marc_authors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 10:59:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 08:59:49 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #48 from Marcel de Rooy --- Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 11:00:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 09:00:06 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15504 --- Comment #2 from Magnus Enger --- See also bug 15504, comment 28 and comment 29. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 11:00:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 09:00:06 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28630 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 11:06:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 09:06:52 +0000 Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED --- Comment #77 from Jonathan Druart --- Kyle, this is still blocked by bug 28026. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 11:06:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 09:06:57 +0000 Subject: [Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 11:09:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 09:09:19 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #37 from Jonathan Druart --- Yes, that's definitely hacky and it will complicate the move when we will replace svc/bib with a REST API call. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 11:19:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 09:19:45 +0000 Subject: [Koha-bugs] [Bug 28384] Add 'no_items' option to TransformMarcToKoha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28384 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122419|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 11:19:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 09:19:59 +0000 Subject: [Koha-bugs] [Bug 28384] Add 'no_items' option to TransformMarcToKoha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28384 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122420|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 11:20:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 09:20:30 +0000 Subject: [Koha-bugs] [Bug 28384] Add 'no_items' option to TransformMarcToKoha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28384 --- Comment #8 from Marcel de Rooy --- Removed the follow-ups. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 11:27:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 09:27:13 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #49 from Marcel de Rooy --- There is a problem with these mails. I do not have an attachment, but this is in the body: This is a multi-part message in MIME format. --_----------=_1624613146275290 Content-Disposition: inline Content-Length: 1127 Content-Transfer-Encoding: binary Content-Type: text/html; charset="utf-8" References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #50 from Marcel de Rooy --- + my $user_email = $patron->first_valid_email_address || C4::Context->preference('KohaAdminEmailAddress'); You might wonder if we should send this mail if the first_valid_email_address would be empty. Why should the recipient reply to the library here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 11:29:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 09:29:01 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #51 from Marcel de Rooy --- This would be a great improvement imo. But it still needs soem attention.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 11:35:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 09:35:08 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 --- Comment #3 from Martin Renvoize --- Created attachment 122422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122422&action=edit Bug 28630: Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 11:36:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 09:36:19 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15504 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 [Bug 15504] Track Patron's Last Activity -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 11:36:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 09:36:19 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28630 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 11:37:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 09:37:15 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 11:41:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 09:41:18 +0000 Subject: [Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- tools/picture-upload.pl if ( $size > 550000 ) { Hardcoded. Not so nice.. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 11:41:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 09:41:44 +0000 Subject: [Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |salman.ali at inLibro.com |ity.org | QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 11:44:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 09:44:36 +0000 Subject: [Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 11:44:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 09:44:53 +0000 Subject: [Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122192|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 122423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122423&action=edit Bug 28576: Add patron image in patron detail section does not specify image size limit When you try to add an image to a patron in Home/Patrons/anyPatron, it only states the file types that are supported but not the maximum size. If you try to add an image that is bigger than 500 kb, nothing happens and the reason is not presented. This is not the case with the 2 other places where we can add patron images in which they give warnings: Home/Tools/Upload patron images Home/Tools/Patron card creator/Images For now, i simply added the size limit to the file supported message. To test: 1)Search for any patron and go to his page 2)Hover over the image area on the left and click on add 3)Notice the message above the choose file button only specifies file types not size. 4)Add an image bigger than 500 kb 5)Nothing happens 6)Apply patch 7)Repeat steps from 1 to 3 8)Notice the message now includes the maximum size Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 11:46:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 09:46:42 +0000 Subject: [Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 --- Comment #5 from Marcel de Rooy --- From: Salman Ali This is no valid email address -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 11:46:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 09:46:50 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18625 CC| |martin.renvoize at ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625 [Bug 18625] Update borrower last seen from SIP -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 11:46:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 09:46:50 +0000 Subject: [Koha-bugs] [Bug 18625] Update borrower last seen from SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15504 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 [Bug 15504] Track Patron's Last Activity -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 11:55:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 09:55:10 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #38 from Marcel de Rooy --- Nick: There is also another point still. If we update 001, we should update the orgcode too in 003. See also bug 28491 for authority counterpart. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 12:11:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 10:11:09 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #99 from Martin Renvoize --- This remote branch is looking great to me.. it just 'feels cleaner' as a whole. I'm just running the test suit against it locally and playing around a bit to see if I spot any obvious issues now.. Thanks for all the hard work Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 12:12:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 10:12:01 +0000 Subject: [Koha-bugs] [Bug 28592] ISE after paying through opac payment plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28592 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22543 CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- This is caused by: commit d20c9ff5882377793d311f3a7a4621c4bdc31469 Bug 22543: Prevent "back and refresh attack" Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22543 [Bug 22543] Patron might be logged in again using browser back button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 12:12:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 10:12:01 +0000 Subject: [Koha-bugs] [Bug 22543] Patron might be logged in again using browser back button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22543 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28592 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28592 [Bug 28592] ISE after paying through opac payment plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 12:15:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 10:15:13 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize at ptfs-europe |testopia at bugs.koha-communit |.com |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 12:21:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 10:21:39 +0000 Subject: [Koha-bugs] [Bug 28631] New: Holds History title link returns "not found" error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28631 Bug ID: 28631 Summary: Holds History title link returns "not found" error Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: bc at interleaf.ie QA Contact: testopia at bugs.koha-community.org When a user is logged into the OPAC and OPACHoldsHistory is enabled a list of holds and old holds is displayed. If a user selects one of these titles a "not found" error is displayed. opac-holdshistory.tt line 105: This is an intranet URL so the OPAC user will not have access. opac-holdshistory should be: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 12:22:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 10:22:17 +0000 Subject: [Koha-bugs] [Bug 28592] ISE after paying through opac payment plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28592 --- Comment #2 from Jonathan Druart --- To recreate easily: * OPAC > Login > Privacy (/cgi-bin/koha/opac-privacy.pl) * MariaDB > delete from sessions; * Submit the form * Login again Notice the GET parameters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 12:22:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 10:22:46 +0000 Subject: [Koha-bugs] [Bug 28592] ISE after paying through opac payment plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28592 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.11 |unspecified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 12:29:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 10:29:28 +0000 Subject: [Koha-bugs] [Bug 28567] Pick-up location is not saved correctly when creating a new library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28567 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Depends on| |16154 Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com --- Comment #2 from Jonathan Druart --- commit f3e4b5bbb6b02d7bb6e89d84c0379666eb1e704f Bug 16154: CGI->multi_param - Force scalar context 124 my $library = Koha::Library->new( 125 { branchcode => $branchcode, 126 ( map { $_ => scalar $input->param($_) || undef } @fields ) 127 } 128 ); Branches.pickup_location has a default = 1 in DB. We should not set to undef if 0. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154 [Bug 16154] Replace CGI->param with CGI->multi_param in list context -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 12:29:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 10:29:28 +0000 Subject: [Koha-bugs] [Bug 16154] Replace CGI->param with CGI->multi_param in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28567 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28567 [Bug 28567] Pick-up location is not saved correctly when creating a new library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 12:35:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 10:35:28 +0000 Subject: [Koha-bugs] [Bug 28567] Pick-up location is not saved correctly when creating a new library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28567 --- Comment #3 from Jonathan Druart --- This is (very?) bad. When a new library is created, all the non-filled (empty string) fields that are "text" at DB level will be set to NULL. BUT after they are edited, they are set to an empty string. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 12:49:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 10:49:23 +0000 Subject: [Koha-bugs] [Bug 28567] Pick-up location is not saved correctly when creating a new library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28567 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 12:49:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 10:49:27 +0000 Subject: [Koha-bugs] [Bug 28567] Pick-up location is not saved correctly when creating a new library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28567 --- Comment #4 from Jonathan Druart --- Created attachment 122424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122424&action=edit Bug 28567: Fix 0 vs "" vs undef on the admin library form There are two things here: * Branches.pickup_location has a default = 1 in DB, we should not set to undef if 0 or it will be set to 1 when stored. * The other fields are all text (varchar, mediumtext or longtext) and can be NULL. They are correct set to NULL when a new library is created but set to an empty string when the library is modified. That's not consistent Test plan: 0. Don't apply the patch 1. Create a new library, set pickup location to "No" 2. Save => Pickup location is set to YES => In DB notice that the different values you didn't fill in are set to NULL 3. Edit the library 4. Save => In DB notice that the different values you didn't fill in are now set to an empty string 5. Apply the patch, restart_all 6. Run the updatedatabase script => In DB all the empty string values are set to NULL 7. Repeat 1 to 4 and confirm that everything is now working as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 12:50:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 10:50:25 +0000 Subject: [Koha-bugs] [Bug 28567] Pick-up location is not saved correctly when creating a new library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28567 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7534 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 [Bug 7534] Add an option on library level to indicate if a library can be chosen as pick-up location -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 12:50:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 10:50:25 +0000 Subject: [Koha-bugs] [Bug 7534] Add an option on library level to indicate if a library can be chosen as pick-up location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28567 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28567 [Bug 28567] Pick-up location is not saved correctly when creating a new library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 13:26:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 11:26:58 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 --- Comment #4 from Andrew Fuerste-Henry --- In bug 28467 I just updated the working on TrackLastPatronActivity to accurately describe the current behavior. Please include an update there to tell people it now includes ILS-DI. The comment Magnus links off to also mentions API actions. I agree we should also cover that with lastseen. I don't see a separate bug for that. Martin, are you up for folding that in here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 13:27:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 11:27:08 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 13:37:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 11:37:56 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, nick at bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28455 --- Comment #32 from Andrew Fuerste-Henry --- Bug 28455, signed off, adds checkouts to lastseen. So we're kinda working in two different directions here. I'm in favor of a simple approach here: a single field with a datetime that updates each time a patron does any of the listed actions (log in to OPAC, SIP, ILSDI, API, checkout, checkin). The batch patron deletion tool already knows how to filter by both lastseen and circ activity. The need I run into here relates to reports rather than the deletion tool itself. We get regular requests for a report that will give a column of the last date on which a patron either logged in to something or checked something in or out. That's much messier SQL than it needs to be with the current data structure. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 13:37:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 11:37:56 +0000 Subject: [Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15504 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 13:58:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 11:58:48 +0000 Subject: [Koha-bugs] [Bug 28593] Add ability to charge lost fee when applying new lost status when resolving a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28593 --- Comment #2 from Tomás Cohen Arazi --- Andrew, how do you think this should work? From the user perspective? Should it be the replacement cost? Should it be added manually in the claim resolution modal? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 13:59:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 11:59:12 +0000 Subject: [Koha-bugs] [Bug 28211] Replace use of call_recursive() with call() In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28211 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #10 from Kyle M Hall --- Patches applied fine for me. Did you apply on top of 26352? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 14:00:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 12:00:10 +0000 Subject: [Koha-bugs] [Bug 28211] Replace use of call_recursive() with call() In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28211 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120882|0 |1 is obsolete| | Attachment #120883|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 122425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122425&action=edit Bug 28211: Replace use of call_recursive() with call() This is based on Julian's idea on bug 28026 where we could get rid of call_recursive by passing refs as arguments to call. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Plugins/Plugins.t 3) prove t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 14:01:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 12:01:02 +0000 Subject: [Koha-bugs] [Bug 28211] Replace use of call_recursive() with call() In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28211 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122425|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 122426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122426&action=edit Bug 28211: Replace use of call_recursive() with call() This is based on Julian's idea on bug 28026 where we could get rid of call_recursive by passing refs as arguments to call. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Plugins/Plugins.t 3) prove t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 14:01:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 12:01:44 +0000 Subject: [Koha-bugs] [Bug 28211] Replace use of call_recursive() with call() In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28211 --- Comment #13 from Kyle M Hall --- Created attachment 122427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122427&action=edit Bug 28211: Fix count of plugins that should be installed for unit test Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 14:03:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 12:03:36 +0000 Subject: [Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118691|0 |1 is obsolete| | Attachment #118692|0 |1 is obsolete| | Attachment #118693|0 |1 is obsolete| | Attachment #118694|0 |1 is obsolete| | Attachment #118695|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall --- Created attachment 122428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122428&action=edit Bug 26352: Add plugin hooks to transform patron barcodes Some of our partners have unusual barcode requirements that have required us to transform scanned barcodes using javascript. This is not the most reliable method. It would make more sense to have Koha transform the barcodes on the backend using a plugin. We should add hooks to transform and generate new item and patron barcodes. Test Plan: 1) Apply this patch 2) Download and install the Barcode Transformer plugin https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/download/v1.0.1/koha-plugin-barcode-transformer-v1.0.1.kpz 3) Go to the plugin configuration page, set the configuration to the example configuration from the same page 4) In the patron search and anywhere else you can scan a patron cardnumber, type in some cardnumbers but prefix them with A and postfix them with A or B, e.g. A12345A, A12345B 5) Note the letters are removed by Koha! 6) Try a cardnumber like X123456Y 7) Note Koha converts it to Z13456Z Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 14:03:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 12:03:48 +0000 Subject: [Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352 --- Comment #30 from Kyle M Hall --- Created attachment 122429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122429&action=edit Bug 26352: Add unit test Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 14:03:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 12:03:51 +0000 Subject: [Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352 --- Comment #31 from Kyle M Hall --- Created attachment 122430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122430&action=edit Bug 26352: Replace call to barcode_generate with call to patron_barcode_transform Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 14:03:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 12:03:55 +0000 Subject: [Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352 --- Comment #32 from Kyle M Hall --- Created attachment 122431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122431&action=edit Bug 26352: (QA follow-up) Add additional tests This patch adds additional unit tests for autoMemberNum handling and corrects the implimentation there. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 14:03:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 12:03:58 +0000 Subject: [Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352 --- Comment #33 from Kyle M Hall --- Created attachment 122432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122432&action=edit Bug 26352: Switch from using call() to call_recursive() Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 14:05:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 12:05:31 +0000 Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118681|0 |1 is obsolete| | Attachment #118682|0 |1 is obsolete| | Attachment #118683|0 |1 is obsolete| | Attachment #118684|0 |1 is obsolete| | Attachment #118685|0 |1 is obsolete| | Attachment #118686|0 |1 is obsolete| | Attachment #118687|0 |1 is obsolete| | Attachment #118688|0 |1 is obsolete| | Attachment #118689|0 |1 is obsolete| | Attachment #118690|0 |1 is obsolete| | --- Comment #78 from Kyle M Hall --- Created attachment 122433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122433&action=edit Bug 26351: Add plugin hooks to transform item barcodes Some of our partners have unusual barcode requirements that have required us to transform scanned barcodes using javascript. This is not the most reliable method. It would make more sense to have Koha transform the barcodes on the backend using a plugin. We should add hooks to transform and generate new item and patron barcodes. Test Plan: 1) Apply this patch 2) Download and install the Barcode Transformer plugin https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/ 3) Go to the plugin configuration page, set the configuration to the example configuration from the same page 4) In the item barcode field on the checkin and checkout pages, and anywhere else you can scan an item barcode, type in some valid barcodes, but prefix them with X and postfix them with Y, e.g. X123456Y 5) Note the letters are removed by Koha! Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 14:05:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 12:05:44 +0000 Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #79 from Kyle M Hall --- Created attachment 122434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122434&action=edit Bug 26351: (QA follow-up) Fix QA script issue * Fixes issue with barcode generate stub so perlcritic is happy * Removes extra semicolon from return call in configure method Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 14:05:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 12:05:47 +0000 Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #80 from Kyle M Hall --- Created attachment 122435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122435&action=edit Bug 26351: Add unit tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 14:05:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 12:05:51 +0000 Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #81 from Kyle M Hall --- Created attachment 122436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122436&action=edit Bug 26351: (QA follow-up) Remove unused method barcode_transform Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 14:05:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 12:05:55 +0000 Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #82 from Kyle M Hall --- Created attachment 122437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122437&action=edit Bug 26351: (QA follow-up) Rename barcode_transform to item_barcode_transform Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 14:05:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 12:05:59 +0000 Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #83 from Kyle M Hall --- Created attachment 122438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122438&action=edit Bug 26351: (QA follow-up) Barcodes inputted into Koha should always pass though barcodedecode Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 14:06:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 12:06:03 +0000 Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #84 from Kyle M Hall --- Created attachment 122439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122439&action=edit Bug 26351: (QA follow-up) Catch one last case of itemBarcodeInputFilter Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 14:06:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 12:06:07 +0000 Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #85 from Kyle M Hall --- Created attachment 122440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122440&action=edit Bug 26351: (QA follow-up) Fix Checkouts.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 14:06:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 12:06:11 +0000 Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #86 from Kyle M Hall --- Created attachment 122441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122441&action=edit Bug 26351: Use call_recursive() as a replacement for call() The method `call()` is not sufficient for barcode transformations. It's possible that more than one barcode transformation plugin will be installed. The `call_recursive()` method takes the output of the first plugin and uses it as the input for the next plugin and so on. This allowes each plugin to see the current version of the barcode and modify it if necessary. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 14:06:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 12:06:15 +0000 Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #87 from Kyle M Hall --- Created attachment 122442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122442&action=edit Bug 26351: Clean up includes in Circulation.pm Circulation.pm has so many includes that the same module is getting used multiple times without developers noticing it is already beuing used. This commit separates use lines by namespace and sorts them, removing duplicate and unnecessary use lines. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 14:10:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 12:10:18 +0000 Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to Koha::Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 14:10:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 12:10:21 +0000 Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to Koha::Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118680|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 122443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122443&action=edit Bug 28026: Add call_recursive() as a supliment for call() The method call() is not sufficient for all plugin hook types. It's possible that more than one plugin will be installed that wants to return the arguaments passed in an updated form. These transformation plugins need to work recursively rather than independantly. This patch adss a `call_recursive()` method that takes the output of the first plugin and uses it as the input for the next plugin and so on. This allowes each plugin to see the current version of the arguament list and modify it as necessary. Test plan 1/ Run the included tests - t/db_dependent/Koha/Plugins/Plugins.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 14:30:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 12:30:41 +0000 Subject: [Koha-bugs] [Bug 28593] Add ability to charge lost fee when applying new lost status when resolving a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28593 --- Comment #3 from Andrew Fuerste-Henry --- It should be the replacement fee (plus processing fee, if any). We've got ClaimReturnedChargeFee with the options of do charge a fee, don't charge a fee, or give the choice to the user as they claim something. I'd like a parallel syspref for ClaimReturnedResolutionChargeFee with the options to charge, don't charge, or give the choice to the user as they resolve something. It should not ever create a *second* lost fee if the library is already charging at the point of Claim, and it should only charge at resolution if you're moving the item from Claims Returned to some other non-zero lost status. And the wording of the syspref should make that clear. "When resolving a claim and setting an item to lost (charge a lost fee / don't charge a lost fee / ask if a lost fee should be charged). If a fee was already generated based on ClaimReturnedChargeFee, this preference will not generate an additional fee." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 15:00:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 13:00:14 +0000 Subject: [Koha-bugs] [Bug 28585] Cannot search on date fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 --- Comment #7 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #6) > Tomas, looks like this could be a fix. Do you see something else? I wrote regression tests and this doesn't work, because it fails for date-time parameters. I'll take care. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 15:31:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 13:31:12 +0000 Subject: [Koha-bugs] [Bug 28600] Variable "$patron" is not available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.01 released in| | --- Comment #6 from Kyle M Hall --- (In reply to Jonathan Druart from comment #5) > Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 15:32:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 13:32:05 +0000 Subject: [Koha-bugs] [Bug 28586] Cannot resolve a claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #14 from Kyle M Hall --- (In reply to Jonathan Druart from comment #13) > Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 15:32:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 13:32:17 +0000 Subject: [Koha-bugs] [Bug 28600] Variable "$patron" is not available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 15:42:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 13:42:33 +0000 Subject: [Koha-bugs] [Bug 28542] Move new authority from Z39.50/SRU to a button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28542 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Kyle M Hall --- Pushed to 21.05.x for 21.05.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 15:44:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 13:44:15 +0000 Subject: [Koha-bugs] [Bug 27929] Regex option in item batch modification is hidden for itemcallnumber if 952$o linked to cn_browser plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27929 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.02 released in| | CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- Pushed to 21.05.x for 21.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 15:48:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 13:48:57 +0000 Subject: [Koha-bugs] [Bug 24023] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 e.betemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 15:50:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 13:50:16 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED --- Comment #24 from Kyle M Hall --- Enhancement not backported to 20.05 Jonathan, if you think this should be backported as a bug fix, let us know! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 15:50:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 13:50:16 +0000 Subject: [Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 Bug 28588 depends on bug 28271, which changed state. Bug 28271 Summary: Add the ability to set a new lost status when a claim is resolved https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 15:51:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 13:51:57 +0000 Subject: [Koha-bugs] [Bug 28513] Analytic search links formed incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28513 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.02 released in| | --- Comment #5 from Kyle M Hall --- Pushed to 21.05.x for 21.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 15:56:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 13:56:47 +0000 Subject: [Koha-bugs] [Bug 28191] Update wording on batch patron deletion to reflect changes from bug 26517 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28191 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.02 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #8 from Kyle M Hall --- Pushed to 21.05.x for 21.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 15:58:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 13:58:07 +0000 Subject: [Koha-bugs] [Bug 28313] Add street type to alternate address in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28313 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #9 from Kyle M Hall --- Pushed to 21.05.x for 21.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 16:09:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 14:09:55 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #8 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #4) > Please run qa tools. I see this failure: > FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt > FAIL valid_template > Attempt to reload Koha/Template/Plugin/Biblio.pm aborted. > Compilation failed in require at > /usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Plugins.pm line 206. > => Is this related to biblio-view-menu.inc ? The following change should fix that. diff --git a/Koha/ArticleRequest.pm b/Koha/ArticleRequest.pm index 3ea325d83dc..692099ca6bd 100644 --- a/Koha/ArticleRequest.pm +++ b/Koha/ArticleRequest.pm @@ -27,6 +27,7 @@ use Koha::Biblios; use Koha::Items; use Koha::Libraries; use Koha::DateUtils qw(dt_from_string); +use Koha::ArticleRequest::Status; use base qw(Koha::Object); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 16:13:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 14:13:32 +0000 Subject: [Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #25 from Jonathan Druart --- (In reply to Kyle M Hall from comment #24) > Enhancement not backported to 20.05 > > Jonathan, if you think this should be backported as a bug fix, let us know! Ask Andrew, but I think it would be good to have it into 21.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 16:48:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 14:48:06 +0000 Subject: [Koha-bugs] [Bug 28585] Cannot search on date fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 16:49:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 14:49:42 +0000 Subject: [Koha-bugs] [Bug 28585] Cannot search on date fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 16:49:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 14:49:52 +0000 Subject: [Koha-bugs] [Bug 28585] Cannot search on date fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122381|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 16:50:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 14:50:11 +0000 Subject: [Koha-bugs] [Bug 28592] ISE after paying through opac payment plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28592 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #3 from Kyle M Hall --- (In reply to Jonathan Druart from comment #2) > To recreate easily: > * OPAC > Login > Privacy (/cgi-bin/koha/opac-privacy.pl) > * MariaDB > delete from sessions; > * Submit the form > * Login again > > Notice the GET parameters It isn't passing a 'userid' or 'password' field back, so the code from that bug should not be trigger. My question is; are you sure the Koha FQDN you are starting at is the same FQDN as the return URL? Check your opac base url. If you are starting from a url that does not match the opac base url, this exact scenario will happen because the cookie is for one FQDN but the redirect goes back to another! Even though two FQDNs can point to the same Koha instance, they will have separate cookies and thus logging into one will not mean you are logged in to the other! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 16:53:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 14:53:21 +0000 Subject: [Koha-bugs] [Bug 28585] Cannot search on date fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 122444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122444&action=edit Bug 28585: Regression tests This patch adds tests for filtering GET calls with date/date-time parameters. Tests fail because the feature is not working Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 16:53:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 14:53:25 +0000 Subject: [Koha-bugs] [Bug 28585] Cannot search on date fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 122445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122445&action=edit Bug 28585: Use the datetime_parser for handling API dates This patchset takes the GET /patrons route as a sample usage for filtering on date and date-time (including timestamp) fields. It then makes Koha::Object->attributes_from_api use the DB storage datetime parser for format the parameters correctly. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: It doesn't find the patron when filtering by date 3. Apply this patch 4. Repeat 2 => SUCCESS: It works now! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 16:53:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 14:53:29 +0000 Subject: [Koha-bugs] [Bug 28585] Cannot search on date fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 122446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122446&action=edit Bug 28585: (follow-up) Tests for q= supporting date/date-time parameters Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 17:17:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 15:17:03 +0000 Subject: [Koha-bugs] [Bug 28585] Cannot search on date fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 --- Comment #11 from Tomás Cohen Arazi --- I made the q= tests a follow-up, because I'm not sure bug 28480 will be backported to affected stable branches, and so ease backporting this important fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 17:23:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 15:23:54 +0000 Subject: [Koha-bugs] [Bug 28632] New: patrons.t fragile on slow boxes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632 Bug ID: 28632 Summary: patrons.t fragile on slow boxes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com Playing some music and a Netflix movie on my (not that speedy) box, made t/db_dependent/api/v1/patrons.t fail consistently because of a 1 sec difference on the borrowers.updated_on attribute (set to current_timestamp on UPDATE). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 17:24:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 15:24:00 +0000 Subject: [Koha-bugs] [Bug 28632] patrons.t fragile on slow boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 17:24:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 15:24:14 +0000 Subject: [Koha-bugs] [Bug 28632] patrons.t fragile on slow boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28585 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 17:24:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 15:24:14 +0000 Subject: [Koha-bugs] [Bug 28585] Cannot search on date fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28632 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 17:30:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 15:30:50 +0000 Subject: [Koha-bugs] [Bug 28632] patrons.t fragile on slow boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 122447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122447&action=edit Bug 28632: Make patrons.t robust in terms of elapsed time between tests This patch changes the tests so they don't try to compare updated_on from many tests ago, so it is less fragile. I added a warn on the unmatched fields for convenience. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! 2. Make your computer very slow 3. Repeat 1 => FAIL: You get things like: t/db_dependent/api/v1/patrons.t .. 3/7 # Failed test 'Returned patron from update matches expected' # at t/db_dependent/api/v1/patrons.t line 513. # Structures begin differing at: # $got->{updated_on} = '2021-06-25T14:26:20+00:00' # $expected->{updated_on} = '2021-06-25T14:26:19+00:00' # Looks like you failed 1 test of 42. 4. Apply this patch 5. Repeat 1 => SUCCESS: Tests pass again! 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 17:31:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 15:31:04 +0000 Subject: [Koha-bugs] [Bug 28632] patrons.t fragile on slow boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 19:02:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 17:02:07 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115193|0 |1 is obsolete| | Attachment #115194|0 |1 is obsolete| | Attachment #115195|0 |1 is obsolete| | Attachment #115196|0 |1 is obsolete| | Attachment #115197|0 |1 is obsolete| | Attachment #115198|0 |1 is obsolete| | Attachment #115199|0 |1 is obsolete| | Attachment #115200|0 |1 is obsolete| | Attachment #115201|0 |1 is obsolete| | --- Comment #69 from Kyle M Hall --- Created attachment 122448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122448&action=edit Bug 26282: Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold Bug 25534 adds the option to send hold cancellation notices when a reason was given. It would be nice if you could give a reason but still decide not to send to the patron. Say the patron called and will not be able to pick up numerous holds for some time. You cancel them all with "patron requested cancellation" but don't want to send multiple notices. I could imagine a checkbox next to the reason to activate/deactivate sending the notice. Test Plan: 1) Apply this patch 2) Visit each area in Koha where a hold can be canceled with a reason 3) Note the new 'Notify patron' checkbox 4) Test canceling a hold with and without this checkbox checked 5) Verify leaving it unchecked does not trigger a notice to be sent to the patron Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 19:02:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 17:02:26 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #70 from Kyle M Hall --- Created attachment 122449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122449&action=edit Bug 26282: (QA follow-up) Implement for moremember.pl and circulation.pl Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 19:02:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 17:02:30 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #71 from Kyle M Hall --- Created attachment 122450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122450&action=edit Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 19:02:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 17:02:35 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #72 from Kyle M Hall --- Created attachment 122451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122451&action=edit Bug 26282: (QA follow-up) Allow notification via cancel_expired_holds Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 19:02:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 17:02:39 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #73 from Kyle M Hall --- Created attachment 122452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122452&action=edit Bug 26282: (QA follow-up) Update POD Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 19:02:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 17:02:43 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #74 from Kyle M Hall --- Created attachment 122453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122453&action=edit Bug 26282: (QA follow-up) Unit tests This patch adds tests for the behaviour change. It tests if letter processing takes place when notify_patron is passed. It tests all combinations. Bonus: it tweaks the POD to acknowledge this new parameter. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => FAIL: Tests fail! 3. Apply the rest of the patches 4. Repeat 2 => SUCCESS: Tests pass! No warnings! 5. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 19:02:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 17:02:47 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #75 from Kyle M Hall --- Created attachment 122454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122454&action=edit Bug 26282: (QA follow-up) Update test Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 19:02:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 17:02:51 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #76 from Kyle M Hall --- Created attachment 122455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122455&action=edit Bug 26282: (QA follow-up) Restore default notice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 19:02:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 17:02:55 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #77 from Kyle M Hall --- Created attachment 122456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122456&action=edit Bug 26282: Show reason only if notice exists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 21:29:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 19:29:04 +0000 Subject: [Koha-bugs] [Bug 28633] New: Add a preferred_name field and an effective_name method to patrons Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Bug ID: 28633 Summary: Add a preferred_name field and an effective_name method to patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Some institutions store legal names in their directories and for patron imports, but would also like to be able to record 'preferred' names in the patro records. It would be nice to have a field for preferred_name and a method to select the preferred name when it exists, and the firstname when it doesn't Following the item we would suggest 'effective_name' - the additional method can be used in patron-title.inc and in notices to simplify name choice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 25 21:29:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 19:29:09 +0000 Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 26 01:32:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 23:32:31 +0000 Subject: [Koha-bugs] [Bug 28585] Cannot search on date fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 26 01:32:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 23:32:35 +0000 Subject: [Koha-bugs] [Bug 28585] Cannot search on date fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122444|0 |1 is obsolete| | --- Comment #12 from David Nind --- Created attachment 122457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122457&action=edit Bug 28585: Regression tests This patch adds tests for filtering GET calls with date/date-time parameters. Tests fail because the feature is not working Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 26 01:32:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 23:32:39 +0000 Subject: [Koha-bugs] [Bug 28585] Cannot search on date fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122445|0 |1 is obsolete| | --- Comment #13 from David Nind --- Created attachment 122458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122458&action=edit Bug 28585: Use the datetime_parser for handling API dates This patchset takes the GET /patrons route as a sample usage for filtering on date and date-time (including timestamp) fields. It then makes Koha::Object->attributes_from_api use the DB storage datetime parser for format the parameters correctly. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: It doesn't find the patron when filtering by date 3. Apply this patch 4. Repeat 2 => SUCCESS: It works now! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 26 01:32:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Jun 2021 23:32:43 +0000 Subject: [Koha-bugs] [Bug 28585] Cannot search on date fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122446|0 |1 is obsolete| | --- Comment #14 from David Nind --- Created attachment 122459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122459&action=edit Bug 28585: (follow-up) Tests for q= supporting date/date-time parameters Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 26 02:32:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jun 2021 00:32:31 +0000 Subject: [Koha-bugs] [Bug 28632] patrons.t fragile on slow boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 26 02:32:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jun 2021 00:32:34 +0000 Subject: [Koha-bugs] [Bug 28632] patrons.t fragile on slow boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122447|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 122460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122460&action=edit Bug 28632: Make patrons.t robust in terms of elapsed time between tests This patch changes the tests so they don't try to compare updated_on from many tests ago, so it is less fragile. I added a warn on the unmatched fields for convenience. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! 2. Make your computer very slow 3. Repeat 1 => FAIL: You get things like: t/db_dependent/api/v1/patrons.t .. 3/7 # Failed test 'Returned patron from update matches expected' # at t/db_dependent/api/v1/patrons.t line 513. # Structures begin differing at: # $got->{updated_on} = '2021-06-25T14:26:20+00:00' # $expected->{updated_on} = '2021-06-25T14:26:19+00:00' # Looks like you failed 1 test of 42. 4. Apply this patch 5. Repeat 1 => SUCCESS: Tests pass again! 6. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 26 02:34:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jun 2021 00:34:54 +0000 Subject: [Koha-bugs] [Bug 28632] patrons.t fragile on slow boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes (koha-testing-docker): - I can normally get things to slow right down by playing YouTube, using koha-testing-docker, and then opening another browser or two (such as Google Chrome) - Managed to do this for this bug before (got tests to fail) and after (didn't manage to get it to fail) - (not very scientific!) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 26 02:56:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jun 2021 00:56:00 +0000 Subject: [Koha-bugs] [Bug 28567] Pick-up location is not saved correctly when creating a new library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28567 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind --- Created attachment 122461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122461&action=edit Bug 28567 - Screenshot - no change I didn't notice any change after apply the patch (updatedatabase, flush_memcached, restart_all): - Still sets to Yes - Displays Address with empty information - see screenshot - Editing removes this information and can change pickup location to No -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 26 02:56:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jun 2021 00:56:13 +0000 Subject: [Koha-bugs] [Bug 28567] Pick-up location is not saved correctly when creating a new library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28567 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 26 13:05:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jun 2021 11:05:55 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #217 from Katrin Fischer --- Thx, Marcel. Quite happy to see this one move forward. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 26 13:06:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jun 2021 11:06:30 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #12 from Katrin Fischer --- (In reply to Jonathan Druart from comment #11) > I am suggesting: > > * Codebase will use "additional_contents", Koha::AdditionalContents > > * UI will split: > Tools > News (same as now) > Tools > HTML customization > > Would that work for everybody? +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 27 01:17:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jun 2021 23:17:50 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 27 01:17:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jun 2021 23:17:54 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122386|0 |1 is obsolete| | --- Comment #18 from David Nind --- Created attachment 122462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122462&action=edit Bug 26302: OPAC XSLT Results: List variable number of itemcallnumbers We define a local preference resultsMaxItems and add it to the xml passed to the results XSLT (in C4::XSLT). Instead of showing one item, we add this number of items for the available for loan and reference segments. Test plan: Play with the value of local pref resultsMaxItems. Check if it matches with displayed callnumbers. Try home and holdingbranch for results location. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 27 01:17:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jun 2021 23:17:58 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122387|0 |1 is obsolete| | --- Comment #19 from David Nind --- Created attachment 122463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122463&action=edit Bug 26302: Add syspref resultsMaxItemsUnavailable This is the number of call numbers displayed for unavailable categories in the results XSLT. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 27 01:18:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jun 2021 23:18:02 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122388|0 |1 is obsolete| | --- Comment #20 from David Nind --- Created attachment 122464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122464&action=edit Bug 26302: Use resultsMaxItemsUnavailable in stylesheet We start here with Checked out until On hold. Not sure if we should do exactly the same for the remaining not for loan categories. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 27 01:18:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jun 2021 23:18:06 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122389|0 |1 is obsolete| | --- Comment #21 from David Nind --- Created attachment 122465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122465&action=edit Bug 26302: Add dbrev for two new prefs Formalizing the local prefs introduced in the former patches: resultsMaxItems resultsMaxItemsUnavailable Test plan: Check Preferences/OPAC/Appearance. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 27 01:18:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jun 2021 23:18:10 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122391|0 |1 is obsolete| | --- Comment #22 from David Nind --- Created attachment 122466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122466&action=edit Bug 26302: Apply resultsMaxItemsUnavailable to the NFLs too Test plan: Add some not for loan categories, add some items for them. Check search results. Verify that results match expectation. Signed-off-by: Marcel de Rooy Tested the combination of pref values for results 2/1 with NFL categories TEST, MOVING: Availability: Items available for loan: Centerville (3) [Call number: PERL A 2, PERL A 3, ...] Items available for reference: Centerville Staff Collection (1) [Call number: PERL A 10]. Not available: TEST (2) [ PERL A 11, .. ]. MOVING (1) [ PERL A 13 ]. Withdrawn (2) [ PERL A 5, .. ]. Damaged (3) [ PERL A 7, .. ]. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 27 01:20:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jun 2021 23:20:18 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #23 from David Nind --- Testing notes (using koha-testing-docker): Revised test plan: 1. Setup records and items to test: . Have records with multiple items and call numbers (one with 20 items and one with 50) that will appear in the OPAC results using the same keyword (use 'Add multiple copies of this item' option at the bottom of the add item form to bulk add multiple items). . Make sure (using batch item editing) that there are a mix of libraries, not for loan categories, call numbers, and damaged status' . As a bonus, add some additional not for loan categories (Administration > Basic parameters > Authorized values), such as 'Not for Loan' and 'Staff Collection' . Check out some items to patrons 2. Confirm the current behavour when searching in the OPAC (see the example at the end): . The first call number per branch is displayed under availablility in the results (for items available for loan and items available for reference) . Where there are multiple call numbers for an item, "..." is used to indicate more call numbers . For items not available, such as damaged: no call numbers are displayed. 3. Apply the patch 4. Update the database (updatedatabase when using koha-testing-docker) 5. Run flush_memcached and restart_all (when using koha-testing-docker) 6. Without changing the default values for the new system preferences, check that the current behavour still works (as per step 2). Note: the default setting is to display 2 call numbers for items available (only 1 was displayed before) and 1 call number for items not available (no call numbers were displayed before). 7. Experiment with different values for the new system preferences (for example 10 for resultsMaxItems and 0 for resultsMaxItemsUnavailable): . resultsMaxItems - Maximum number of available items displayed in search results . resultsMaxItemsUnavailable - Maximum number of unavailable items displayed in search results 8. Confirm that the correct number of call numbers are displayed. 9. Sign off! Example ------- Before patch applied: ~~~~~~~~~~~~~~~~~~~~~ Availability: Items available for loan: Centerville (16) Call number: PERL A1, .., Fairview (1) Call number: PERL A1, Franklin (7) Call number: PERL B2, .., Midway (9) Call number: 560.897 ZAK, .., Springfield (6) Call number: 965.009 PLO, ... Items available for reference: Fairview Not For Loan (1) Call number: PERL A1, Franklin Not For Loan (1) Call number: PERL B2, Midway Not For Loan (2) Call number: 560.897 ZAK, .., Centerville Not For Loan (1) Call number: PERL B2, Springfield Not For Loan (3) Call number: 965.009 PLO, ... Not available: Damaged (7). Patch applied: ~~~~~~~~~~~~~~ Availability: Items available for loan: Centerville (16) Call number: PERL A1, PERL A1, .., Fairview (1) Call number: PERL A1, PERL A1, Franklin (7) Call number: PERL A1, PERL A1, .., Midway (9) Call number: PERL A1, PERL A1, .., Springfield (6) Call number: PERL A1, PERL A1, ... Items available for reference: Fairview Not For Loan (1) Call number: PERL A1, PERL B2, Franklin Not For Loan (1) Call number: PERL A1, PERL B2, Midway Not For Loan (2) Call number: PERL A1, PERL B2, Centerville Not For Loan (1) Call number: PERL A1, PERL B2, Springfield Not For Loan (3) Call number: PERL A1, PERL B2, ... Not available: Damaged (7) [ PERL A1, .. ]. Note differences: - Default number of call numbers peated for items available for loan (before patch was applied they didn't), - Not available items didn't originally dispaly Call numbers for Damaged Different values ~~~~~~~~~~~~~~~~ Results with: - resultsMaxItems: 10 - resultsMaxItemsUnavailable: 0 Availability: Items available for loan: Centerville (16) Call number: PERL A1, PERL A1, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, 560.897 ZAK, .., Fairview (1) Call number: PERL A1, PERL A1, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, 560.897 ZAK, Franklin (7) Call number: PERL A1, PERL A1, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, 560.897 ZAK, Midway (9) Call number: PERL A1, PERL A1, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, 560.897 ZAK, Springfield (6) Call number: PERL A1, PERL A1, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, 560.897 ZAK. Items available for reference: Fairview Not For Loan (1) Call number: PERL A1, PERL B2, 560.897 ZAK, 560.897 ZAK, PERL B2, 965.009 PLO, 965.009 PLO, 965.009 PLO, Franklin Not For Loan (1) Call number: PERL A1, PERL B2, 560.897 ZAK, 560.897 ZAK, PERL B2, 965.009 PLO, 965.009 PLO, 965.009 PLO, Midway Not For Loan (2) Call number: PERL A1, PERL B2, 560.897 ZAK, 560.897 ZAK, PERL B2, 965.009 PLO, 965.009 PLO, 965.009 PLO, Centerville Not For Loan (1) Call number: PERL A1, PERL B2, 560.897 ZAK, 560.897 ZAK, PERL B2, 965.009 PLO, 965.009 PLO, 965.009 PLO, Springfield Not For Loan (3) Call number: PERL A1, PERL B2, 560.897 ZAK, 560.897 ZAK, PERL B2, 965.009 PLO, 965.009 PLO, 965.009 PLO. Not available: Damaged (7). Results with: - resultsMaxItems: 1 - resultsMaxItemsUnavailable: 0 Availability: Items available for loan: Centerville (16) Call number: PERL A1, .., Fairview (1) Call number: PERL A1, Franklin (7) Call number: PERL A1, .., Midway (9) Call number: PERL A1, .., Springfield (6) Call number: PERL A1, ... Items available for reference: Fairview Not For Loan (1) Call number: PERL A1, Franklin Not For Loan (1) Call number: PERL A1, Midway Not For Loan (2) Call number: PERL A1, .., Centerville Not For Loan (1) Call number: PERL A1, Springfield Not For Loan (3) Call number: PERL A1, ... Not available: Damaged (7). Results with: - resultsMaxItems: 0 - resultsMaxItemsUnavailable: 0 Availability: Items available for loan: Centerville (16) Call number: PERL A1, .., Franklin (7) Call number: PERL A1, .., Midway (9) Call number: PERL A1, .., Springfield (6) Call number: PERL A1, ... Items available for reference: Fairview Not For Loan (1) Call number: PERL A1, Franklin Not For Loan (1) Call number: PERL A1, Midway Not For Loan (2) Call number: PERL A1, .., Centerville Not For Loan (1) Call number: PERL A1, Springfield Not For Loan (3) Call number: PERL A1, ... Not available: Checked out (1). Damaged (7). Note: no change from setting to 1 and 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 27 01:21:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jun 2021 23:21:50 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Allows customizing the |This enhancement allows release notes|number of call numbers |customizing the number of |listed on the OPAC search |call numbers displayed for |results by changing the |OPAC search results for |prefs: |items available and not |resultsMaxItems |available by changing two |resultsMaxItemsUnavailable |new system preferences: |The latter now applies to |- |the categories Checked out, |resultsMaxItems: maximum |Damaged, ..., On hold. |number of available items | |displayed in search results | |(default = 2) | |- | |resultsMaxItemsUnavailable | |- maximum number of | |unavailable items displayed | |in search results (such as | |when checked out and | |damaged) (default = 1) | | | |This is useful when records | |have a large number of | |items, for example larger | |libraries with many | |branches, union catalogues, | |and university libraries | |with course text books. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 27 01:29:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Jun 2021 23:29:05 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #24 from David Nind --- A couple of things I noted: 1. Should the call number be repeated if it is the same? That is, should only distinct call numbers be displayed for items available by library branch or not available categories? 2. Should using 0 for resultsMaxItems suppress the display of call numbers? That is the behavour when resultsMaxItemsUnavailable is 0. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 27 23:08:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jun 2021 21:08:45 +0000 Subject: [Koha-bugs] [Bug 28622] Selected branchcode not passed to adv search? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 27 23:08:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jun 2021 21:08:49 +0000 Subject: [Koha-bugs] [Bug 28622] Selected branchcode not passed to adv search? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122339|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 122467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122467&action=edit Bug 28622: (bug 15758 follow-up) Remove incorrect branch selection in adv search From commit df97814f3034a3d5015546c4eca21f08ae951e37 Bug 15758: Koha::Libraries - Remove GetBranches + selected_branchcode => ( C4::Context->IsSuperLibrarian ? C4::Context->userenv : '' ), And - [% PROCESS options_for_libraries libraries => Branches.all() %] + [%# FIXME Should not we filter the libraries displayed? %] + [% PROCESS options_for_libraries libraries => Branches.all( selected => selected_branchcode, unfiltered => 1 ) %] The change in the pl is wrong as it should pass C4::Context->userenv->{branch}, but prior to this commit it seems that we didn't select the logged in library anyway. Looks like we should remove this code. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 27 23:13:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Jun 2021 21:13:30 +0000 Subject: [Koha-bugs] [Bug 28622] Selected branchcode not passed to adv search? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes (koha-testing-docker): - Before applying patch behavour is: . Set library in staff interface . Go to the advanced search interface . For 'Location and availability', 'All libraries' is the default choice - After patch is applied, it now defaults to whatever is set as the library - Changed library (used drop down list > Set library) and then went back to advanced search page: library should reflect the new library set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 02:57:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 00:57:01 +0000 Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to Koha::Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #16 from David Cook --- I think "call_pipeline" would've been better than "call_recursive", since I would expect "call_recursive" to invoke itself, instead of just pipelining results through a series of plugin calls. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 03:21:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 01:21:59 +0000 Subject: [Koha-bugs] [Bug 21250] Auto-self-checkout not fully compatible with multi-branch library setup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21250 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #20 from David Cook --- At the moment, we use a local customization where you use a URL with a branch parameter, and then some local system preferences to use branch-specific users. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 03:31:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 01:31:54 +0000 Subject: [Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 --- Comment #43 from David Cook --- (In reply to Jonathan Druart from comment #42) > Ok, let's discuss then. What do we do? > > I am ok with having our module where Data::Session is expecting it. How do you propose to do that in production though? The only reasonable option I see would be creating our Data::Session::Serializer::yamlxs as a standalone library (with its own git repository), and then packaging that and storing it in the Koha Community APT repo, and then adding it as a Koha dependency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 05:45:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 03:45:35 +0000 Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from 20.05.xx to 20.11.04-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #14 from skaman.tx at gmail.com --- So I am not a developer and I do not know how to patch the koha files using git. Thus, as Kartin suggested I would have to do, I manually edited the diff file Jonathan posted and I created the installer/data/mysql/atomicupdate/bug_28267.perl file with the following contents: $DBversion = 'XXX'; # will be replaced by the RM if( CheckVersion( $DBversion ) ) { my $fields = { itemcallnumber => 255, coded_location_qualifier => 10, location => 80, permanent_location => 80, cn_source => 10, cn_sort => 255, ccode => 80, itype => 10, copynumber => 32, stocknumber => 32, new_status => 32, }; # Index on items for my $index ( qw( itemstocknumberidx itemcallnumber items_location items_ccode itype_idx ) ) { next unless index_exists('items', $index); $dbh->do(qq| ALTER TABLE items DROP INDEX $index |); } # Index on deleteditems for my $index ( qw( delitemstocknumberidx itype_idx ) ) { next unless index_exists('deleteditems', $index); $dbh->do(qq| ALTER TABLE deleteditems DROP INDEX $index |); } while ( my ( $f, $size ) = each %$fields ) { my $datatype = ( $size >= 24 ) ? 'TEXT' : 'TINYTEXT'; my $size_index = ( $size == 255 ) ? 191 : $size; $dbh->do(qq| ALTER TABLE items MODIFY $f $datatype DEFAULT NULL |); # Re-add index on items unless ( index_exists( 'items', sprintf("%s_idx", $f) ) ) { $dbh->do(sprintf q| ALTER TABLE items ADD INDEX %s_idx( %s(%s) ) |, $f, $f, $size_index); } $dbh->do(qq| ALTER TABLE deleteditems MODIFY $f $datatype DEFAULT NULL |); } # Re-add index on deleteditems unless ( index_exists( 'deleteditems', 'itype_idx' ) ) { $dbh->do(q| ALTER TABLE deleteditems ADD INDEX itype_idx( itype(10)) |); } unless ( index_exists( 'deleteditems', 'stocknumber_idx' ) ) { $dbh->do(q| ALTER TABLE deleteditems ADD INDEX stocknumber_idx( itype(32)) |); } NewVersion( $DBversion, 28267, "Switch items VARCHAR fields to TINYTEXT or MEDIUMTEXT"); } I then manually edited the kohastructure.sql file adding the "+" lines from the diff file and removing the "-" lines. I made sure all the added lines instances of "default NULL" were "default NULL," as well. I set the following variables via the debian command line: export PERL5LIB=/usr/share/koha/lib export KOHA_CONF=/etc/koha/sites/library/koha-conf.xml And then I ran: perl /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl Alas, I get the following error. {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Row size too large. The maximum row size for the used table type, not counting BLOBs, is 8126. This includes storage overhead, check the manual. You have to change some columns to TEXT or BLOBs [for Statement " ALTER TABLE `items` ADD COLUMN `exclude_from_local_holds_priority` tinyint(1) default NULL AFTER `new_status` "] at /usr/share/perl5/DBIx/Class/Schema.pm line 1118. DBIx::Class::Schema::throw_exception(Koha::Schema=HASH(0x5616a4e90248), "DBI Exception: DBD::mysql::db do failed: Row size too large. "...) called at /usr/share/perl5/DBIx/Class/Storage.pm line 113 DBIx::Class::Storage::throw_exception(DBIx::Class::Storage::DBI::mysql=HASH(0x5616a3f14ff8), "DBI Exception: DBD::mysql::db do failed: Row size too large. "...) called at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1501 DBIx::Class::Storage::DBI::__ANON__("DBD::mysql::db do failed: Row size too large. The maximum row"..., DBI::db=HASH(0x5616a5993ba8), undef) called at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 22720 Any further thoughts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 07:24:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 05:24:02 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #25 from Marcel de Rooy --- (In reply to David Nind from comment #24) > A couple of things I noted: > > 1. Should the call number be repeated if it is the same? That is, should > only distinct call numbers be displayed for items available by library > branch or not available categories? > > 2. Should using 0 for resultsMaxItems suppress the display of call numbers? > That is the behavour when resultsMaxItemsUnavailable is 0. Thx for testing, David! Great comments. Will be looking further shortly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 07:32:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 05:32:30 +0000 Subject: [Koha-bugs] [Bug 26841] Koha staff interface - all items reservable (against the rule: If all unavailable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26841 --- Comment #5 from Rickard Lindfors --- I've tested this a little bit now, and the same happens if there's only one item. That item is available, and problem is still the same. We have specific library rules (but only one library) and they clearly seems to be used around the system in other cases. This is is not a big problem for us, as the the Staff normally can overwrite this if they have a reason for it. It is just that a warning should appear and indicate that you probably should not do it :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 08:26:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 06:26:33 +0000 Subject: [Koha-bugs] [Bug 26839] Add a 'date published' feature to the facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26839 e.betemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 08:29:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 06:29:19 +0000 Subject: [Koha-bugs] [Bug 26840] Add a 'date added' feature to the facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26840 e.betemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 08:52:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 06:52:40 +0000 Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to Koha::Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026 --- Comment #17 from Mark Hofstetter --- call_pipeline is a very fine name for me, I finally found the time to setup a proper devel system for koha. if somebody could find the time (30minutes) to chat with me how to do commit/package it/test it up to community standards I'd be happy to work on the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 10:42:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 08:42:00 +0000 Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to Koha::Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026 --- Comment #18 from Martin Renvoize --- Please see discussion and resulting bug 28211 where call_recursive is subsequently removed again in preference to passing references. If you don't believe this can fulfil your requirements Mark please let us know here to Julian and Kyle can chip in. Many thanks, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 10:52:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 08:52:07 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #51 from Martin Renvoize --- Oops, I started looking at this on Friday but got pulled away into other things.. I hope to get back to it later this week. One comment so far however.. I think the 'host_record' relationship accessor could be generalised a little more to make it less specific to this feature and thus adoptable by other uses in the future. I'm happy to undertake this as a QA follow-up. I think we should move the item count test and syspref check out of the module method and into the controllers instead.. as much as this goes against the instinct to make sure it's testable I think this will lead to a much more flexible low level object method... I wonder if we could move the test into the integration tests so it's still caught but at the controller level rather than the object? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 10:53:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 08:53:10 +0000 Subject: [Koha-bugs] [Bug 28634] New: ILL partner request notices are attached to the request creator rather than the partner recipient Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28634 Bug ID: 28634 Summary: ILL partner request notices are attached to the request creator rather than the partner recipient Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com When send an ILL request to a partner, the borrowernumber of the entry in message_queue should be the ID of the recipient of the notices, instead the ID of the user who created the ILL request is used instead. The upshot of this is that although the notice goes to the correct recipient, it is attached to the wrong user. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 10:53:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 08:53:40 +0000 Subject: [Koha-bugs] [Bug 28634] ILL partner request notices are attached to the request creator rather than the partner recipient In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28634 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 11:46:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 09:46:55 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #52 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #51) > Oops, I started looking at this on Friday but got pulled away into other > things.. I hope to get back to it later this week. > > One comment so far however.. I think the 'host_record' relationship accessor > could be generalised a little more to make it less specific to this feature > and thus adoptable by other uses in the future. I'm happy to undertake this > as a QA follow-up. I think we should move the item count test and syspref > check out of the module method and into the controllers instead.. as much as > this goes against the instinct to make sure it's testable I think this will > lead to a much more flexible low level object method... I wonder if we could > move the test into the integration tests so it's still caught but at the > controller level rather than the object? Great, Martin. Please note that this patch is already dating from 2018 and unless there are specific developments underway that could directly be tied in, I would prefer to get this further instead of making it more generic for some future development not yet identified. In short, please add some more details or references to other bugs that you have in mind. Thanks for your support. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 11:50:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 09:50:19 +0000 Subject: [Koha-bugs] [Bug 28635] New: upgrade from Koha 20.05.06.000 to latest version failing with Row size too large Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28635 Bug ID: 28635 Summary: upgrade from Koha 20.05.06.000 to latest version failing with Row size too large Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: mesfin.teshome at africainternational.edu QA Contact: testopia at bugs.koha-community.org {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Row size too large. The maximum row size for the used table type, not counting BLOBs, is 8126. This incldues storage overhead, check the manual. You have to change some columns to TEXT or BLOBs [for Statement " ALTER TABLE `items` ADD COLUMN `exclude_from_local_holds_priority` tinyint(1) default NULL AFTER `new_status` "] at /usr/share/perl5/DBIx/Class/Schema.pm line 1118. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 12:47:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 10:47:02 +0000 Subject: [Koha-bugs] [Bug 28634] ILL partner request notices are attached to the request creator rather than the partner recipient In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28634 --- Comment #1 from Andrew Isherwood --- Created attachment 122468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122468&action=edit Bug 28634: Fix notice borrowernumber This commit fixes the bug described in this bug. - When a partner is selected, pass their borrowernumber rather than email to the receiving script - Iterate all selected partners, send a notice to each, using the recipient's borrowernumber in the notice, the recipient's email is derived from their patron object TEST PLAN: 1. DO NOT apply the patch. 2. Follow the following setup: *** Setup start *** - Create a report using the following SQL in order to verify that notices are being generated: SELECT borrowernumber, subject, content, message_transport_type, to_address, from_address FROM message_queue WHERE letter_code LIKE 'ILL%' ORDER BY message_id DESC - Create two "partners". These are patrons that belong to a patron category that has a code that matches the value in your koha-conf.xml (default is ILLLIBS). Patrons in this category must have a primary email defined. Patrons defined in this way are offered as request partners within the ILL interface. - Go to "Koha administration", search for "ILLModule" syspref, ensure it is set to "Enable" - Go to "Koha administration", search for "IllLog" syspref, ensure it is set to "Log" BRANCH CONFIG - Go to "Koha administration" > "Libraries" - Choose a library and "Edit" it - Ensure the "Email" field for the library is populated SENDING REQUEST TO PARTNERS - Go to the "Manage ILL request" screen for a request, create a request if one does not exist - Choose "Place request with partners" - Select both partners that were defined earlier, then click "Send email" - Run the report created earlier => TEST: Observe that a notice was created and the borrowernumber is that of the request creator, not the recipient *** Setup end *** 3. Apply the patch a. Go to the "Manage ILL request" screen for a request, create a request if one does not exist b. Choose "Place request with partners" c. Select both partners that were defined earlier, then click "Send email" d. Run the report created earlier => TEST: Observe that once notice per partner is created, the borrowernumber column for each notice contains the borrower number of the recipient, not the request creator -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 12:47:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 10:47:21 +0000 Subject: [Koha-bugs] [Bug 28634] ILL partner request notices are attached to the request creator rather than the partner recipient In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28634 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 13:58:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 11:58:05 +0000 Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from 20.05.xx to 20.11.04-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28635 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 13:58:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 11:58:05 +0000 Subject: [Koha-bugs] [Bug 28635] upgrade from Koha 20.05.06.000 to latest version failing with Row size too large In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28635 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28267 CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 14:09:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 12:09:55 +0000 Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from 20.05.xx to 20.11.04-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #15 from Mason James --- (In reply to skaman.tx from comment #14) > > Any further thoughts? hi skaman running this SQL before the upgrade might fix the error... ALTER TABLE `items` ROW_FORMAT=DYNAMIC; more info... https://mariadb.com/kb/en/troubleshooting-row-size-too-large-errors-with-innodb/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 14:46:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 12:46:38 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #26 from Marcel de Rooy --- David, This is the culprit: $sp ||= 1 if $syspref eq 'resultsMaxItems'; # needs default A zero becomes a 1 here. We should probably test for defined here with //. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 15:10:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 13:10:08 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118976|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize --- Created attachment 122469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122469&action=edit Bug 20310: Introduce Koha::Biblio->host_record This is a more generic method that allows you to get to the host record as defined in MARC21 field 773$w. This control number is looked up in the search engine (MARC21 field 001). Note: The current implementation is based on MARC21 and does not change behavior for UNIMARC. This includes the follow-up originally submitted separately on Bugzilla, dealing with multiple 773 fields. Test plan: Run t/db_dependent/Koha/Biblio/host_record.t Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 15:10:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 13:10:12 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118977|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize --- Created attachment 122470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122470&action=edit Bug 20310: Redirect article record without items for article requests If an article record has been catalogued separately, has no items and contains a reference to its host via MARC21 field 773 (host item entry), this patch makes an article request redirect to the host record while copying title, author and page info (from 773$g). This is accomplished by using the new Koha::Biblio->host_record method. Note: Subfield 773$g may contain additional information on volume and issue number etc. It will be very hard or perhaps impossible to parse $g and copy these details into the corresponding fields of the article request form for all possible variations used in libraries. A similar remark can be made for selecting the correct item (when item level is used). We could try this on a future report, but will probably need at least a preference to define the expected format. Test plan: [1] Enable article requests. Add rules for an ART and a SER itemtype. [2] Create a SER host biblio record. [3] Create an ART biblio record, no items. Include a 773w pointing to the SER record with '(MARCorgcode)[recno]' (keep the parentheses, remove the square brackets when inserting the biblionumber). Include text in 773$g too. [4] Place an article request on the ART record. Verify that it redirects you to the SER record while copying title, author, page info. Signed-off-by: Marcel de Rooy Signed-off-by: Hugo Agud Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 15:10:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 13:10:16 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118978|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize --- Created attachment 122471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122471&action=edit Bug 20310: (follow-up) Add or remove orgcode in second try We did remove an orgcode, but we could also do the other way around. Note: Hard to include in the unit test since it mocks the whole search engine part. Test plan: [1] Run t/db_dependent/Koha/Biblio/host_record.t [2] Test host 001 = number and child 773 = (org)number [3] Test host 001 = (org)number and child 773 = number Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 15:10:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 13:10:20 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118979|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize --- Created attachment 122472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122472&action=edit Bug 20310: Adding a pref to control behavior If people want to control the redirection, we could add a pref like ArticleRequestsHostRedirection. If it is not enabled, the party is over. Test plan: Test if redirection stops on a child and host when you disable. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 15:10:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 13:10:24 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119346|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize --- Created attachment 122473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122473&action=edit Bug 20310: (follow-up) Check if biblio exists; 755 host_record.t In order to prevent an error like: Can't call method "host_record" on an undefined value at opac/opac-request-article.pl Also chmod's host_record.t to 755 (File must have the exec flag) Test plan: Change the URL so that the biblionumber does not exist. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 15:10:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 13:10:28 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #58 from Martin Renvoize --- Created attachment 122474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122474&action=edit Bug 20310: (follow-up) Move syspref check into controller I believe the syspref check is better placed in the controller. This way the host_record method is not so closely tied to the articel requests feature and may subsequently prove useful to future use cases. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 15:10:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 13:10:50 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 15:14:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 13:14:54 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #59 from Martin Renvoize --- Created attachment 122475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122475&action=edit Bug 20310: (follow-up) Rename method to get_marc_host This method is a mix of database relationship accessor and marc field accessor. We have get_marc_notes already and other patches in the queue are also starting to introduce get_marc_* named methods. This patch updates the method name to conform with that scheme. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 15:34:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 13:34:07 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #60 from Martin Renvoize --- This all appears to work reasonably well.. I've not dug deeply into how these patches relate to bug 11175, so that may be worth considering during QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 15:35:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 13:35:51 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #100 from Martin Renvoize --- We have the compile test failing at the moment.. I'll try to find a moment to dig further into this.. but I'm not sure when that will happen :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 15:37:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 13:37:08 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 --- Comment #20 from Martin Renvoize --- I started refining this a bit to work a little more along the lines of Test::Warnings or Test::Mojo.. I've handed my work over to Tomas again now.. bit of teamwork going on in the background. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 15:42:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 13:42:50 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122421|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 122476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122476&action=edit Bug 28630: Add track_login_daily to ILSDI::AuthenticatePatron This patch adds a call to track_login_daily for the AuthenticatePatron method in ILSDI. Many libraries use this ILSDI endpoint for electron book borrowing and need to maintain the lastseen based on this type of lending. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 15:42:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 13:42:54 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122422|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 122477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122477&action=edit Bug 28630: Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 15:42:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 13:42:57 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 --- Comment #7 from Martin Renvoize --- Created attachment 122478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122478&action=edit Bug 28630: (follow-up) Update wording of syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 15:46:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 13:46:49 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 --- Comment #8 from Martin Renvoize --- (In reply to Andrew Fuerste-Henry from comment #4) > In bug 28467 I just updated the working on TrackLastPatronActivity to > accurately describe the current behavior. Please include an update there to > tell people it now includes ILS-DI. I've added a follow-up with the wording change, thanks for pointing it out :) > The comment Magnus links off to also mentions API actions. I agree we should > also cover that with lastseen. I don't see a separate bug for that. Martin, > are you up for folding that in here? Whilst I sort of agree with Magnus, there isn't really an 'IdentifyUser/AuthenticateUser' route in the API as yet and as such not a clear location to tie this too.. the REST API is still more closely tied to third part integrators acting on someone's behalf and doesn't really denote a user interaction which I feel lastseen is for. So yeah.. I'd wait until such a time that OAuth code grant or similar is introduced which would more clearly denote an actual user login. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 16:10:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 14:10:54 +0000 Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to Koha::Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026 --- Comment #19 from Martin Renvoize --- Also, In bug 27066 comment 10 I talked about the concept of 'before', 'after' and 'around' as a hook naming convention.. I feel the hook names should be tied to their actions and effects.. So, in many ways I think 'before' should be passed the data prior to an action taking place and it's use should not affect said days, after should be passed the data after the action has taken place and again not affect that data.. around could be used for the case where we want to intercept and alter that data in the plugin... thoughts on such a naming convention would be great. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 16:14:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 14:14:12 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 --- Comment #61 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #60) > This all appears to work reasonably well.. I've not dug deeply into how > these patches relate to bug 11175, so that may be worth considering during > QA. Thx for signing off. That is an interesting reference indeed. It adds $biblio->components, actually going the other way around from host to children. Looking for records that contain a 773 with that biblionumber or associated control number. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 19:29:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 17:29:48 +0000 Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com --- Comment #1 from Lisette Scheer --- Yes, this would be lovely. We use the "Other Name" field sort of like this and train staff to use the other name. I'm currently working on updating our notices with TT to send the other name instead of first name if it is present but that doesn't help on the OPAC side where a patron will still see their legal name. Lisette -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 20:09:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 18:09:09 +0000 Subject: [Koha-bugs] [Bug 28636] New: t:lib::Mocks is missing POD Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28636 Bug ID: 28636 Summary: t:lib::Mocks is missing POD Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 20:15:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 18:15:02 +0000 Subject: [Koha-bugs] [Bug 28636] t:lib::Mocks is missing POD In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28636 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Status|NEW |Needs Signoff CC| |jonathan.druart+koha at gmail. | |com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 20:15:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 18:15:52 +0000 Subject: [Koha-bugs] [Bug 28636] t:lib::Mocks is missing POD In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28636 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28615 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 20:15:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 18:15:52 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28636 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 20:18:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 18:18:47 +0000 Subject: [Koha-bugs] [Bug 28636] t:lib::Mocks is missing POD In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28636 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 122479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122479&action=edit Bug 28636: Add POD to t:lib::Mocks There's no POD. This patch adds it. I wrote it as part of bug 28615 but then it took another direction, so submitting here. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 20:30:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 18:30:14 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28618 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28618 [Bug 28618] Move t/lib modules to lib/Koha/Test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 20:30:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 18:30:14 +0000 Subject: [Koha-bugs] [Bug 28618] Move t/lib modules to lib/Koha/Test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28618 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28615 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 [Bug 28615] Add a simple way to mock Koha::Logger -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 20:31:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 18:31:02 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #21 from Tomás Cohen Arazi --- New revamped implementation coming -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 20:31:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 18:31:05 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122306|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 20:31:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 18:31:11 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122307|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 20:33:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 18:33:57 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 122480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122480&action=edit Bug 28615: Add a simple way to mock Koha::Logger This patch introduces a new way to mock and test Koha::Logger. As the POD says, it is used by calling my $logger = t::lib::Mocks::Logger->new(); It then provides convenient methods for testing the logging itself per log-level: * warn_is * warn_like * debug_is * debug_like ... Methods for counting the logging activity and also for clearing the mock buffer are provided as well. This is covered in the POD and also on the follow-up, that makes use of this to fix Auth_with_shibboleth.t To test: 1. Run: $ kshell k$ prove t/Auth_with_shibboleth.t => FAIL: Tests fail! It expects some warns but they are not returned by the lib 2. Apply this patches 3. Repeat 1 => SUCCESS: Tests pass! The tests now use the new lib, and they correctly find the logging Auth_with_shibboleth.pm does on function calls. 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 20:34:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 18:34:03 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 122481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122481&action=edit Bug 28615: Fix t/Auth_with_shibboleth.t This patch makes t/Auth_with_shibboleth.t use the new t::lib::Mocks::Logger tools Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 20:34:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 18:34:45 +0000 Subject: [Koha-bugs] [Bug 28636] t:lib::Mocks is missing POD In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28636 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28618 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28618 [Bug 28618] Move t/lib modules to lib/Koha/Test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 20:34:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 18:34:45 +0000 Subject: [Koha-bugs] [Bug 28618] Move t/lib modules to lib/Koha/Test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28618 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28636 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28636 [Bug 28636] t:lib::Mocks is missing POD -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 28 21:44:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 19:44:11 +0000 Subject: [Koha-bugs] [Bug 24597] Add ability to add note on all payment/writeoff screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24597 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 01:41:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Jun 2021 23:41:41 +0000 Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to Koha::Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026 --- Comment #20 from David Cook --- (In reply to Martin Renvoize from comment #18) > Please see discussion and resulting bug 28211 where call_recursive is > subsequently removed again in preference to passing references. I was wondering why call_recursive was copying data rather than passing references hehe. (In reply to Martin Renvoize from comment #19) > Also, In bug 27066 comment 10 I talked about the concept of 'before', > 'after' and 'around' as a hook naming convention.. I feel the hook names > should be tied to their actions and effects.. > > So, in many ways I think 'before' should be passed the data prior to an > action taking place and it's use should not affect said days, after should > be passed the data after the action has taken place and again not affect > that data.. around could be used for the case where we want to intercept and > alter that data in the plugin... thoughts on such a naming convention would > be great. +1 from me. I use before/after/around with frameworks on other system, and it's very easy. I like the predictability of knowing when before/after/around hooks are called. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 03:01:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 01:01:22 +0000 Subject: [Koha-bugs] [Bug 28618] Move t/lib modules to lib/Koha/Test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28618 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- I've thought a little about this in the past, but I don't see any advantage to doing this, since we'd be embedding test modules in the deployed application. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 03:02:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 01:02:32 +0000 Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- We've certainly had libraries ask for something like this, although it would also need to take into account patron searching, as I've had librarians say they want to be able to search for patrons using their preferred name rather than their legal name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 03:03:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 01:03:51 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 08:16:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 06:16:14 +0000 Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to Koha::Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026 --- Comment #21 from Mark Hofstetter --- As stated before I consider the plugin system to explicit ie you have to "tell" every function/method that there may be a plugin. For example something I am currently working on: Problem: Customer wants to change how patron cardnumbers are autogenerated, (a prefix and a fixed padded length) One could make a plugin for Koha::Patron::fixup_cardnumber OR, my suggestion (semi pseudo code, I hop my intentions are clear) extend the base class(es) in this case Koha::Object->_new_from_dbic(); if () { require KohaObjectHooks; # whatever } KohaObjectHooks use Hook::LexWrap; wrap 'Koha::Patron::fixup_cardnumber', post => sub { my ( $self ) = @_; $self->cardnumber( sprintf("LB%09d", $self->cardnumber)); }; Hook::LexWrap hat pre/post a around hook may be implemented easily I know this a major change, but solves a least some problems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 09:17:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 07:17:12 +0000 Subject: [Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121617|0 |1 is obsolete| | CC| |emmi.takkinen at koha-suomi.fi --- Comment #9 from Emmi Takkinen --- Created attachment 122482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122482&action=edit Bug 28455: lastseen should be updated at checkout if TrackLastPatronActivity is enabled Signed-off-by: Andrew Fuerste-Henry Signed-off-by: David Nind Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 09:17:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 07:17:45 +0000 Subject: [Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121618|0 |1 is obsolete| | --- Comment #10 from Emmi Takkinen --- Created attachment 122483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122483&action=edit Bug 28455: Update wording on TrackLastPatronActivity This patch updates the wording on TrackLackPatronActivity to maintain the corrections from bug 28467 and also reflect the change made in this bug. It should now read: The first time each day that a patron either logs into the OPAC, connects to Koha via SIP, or checks an item out, borrowers.lastseen will update with the current date and time. Signed-off-by: David Nind Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 10:10:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 08:10:33 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122480|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize --- Created attachment 122484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122484&action=edit Bug 28615: Add a simple way to mock Koha::Logger This patch introduces a new way to mock and test Koha::Logger. As the POD says, it is used by calling my $logger = t::lib::Mocks::Logger->new(); It then provides convenient methods for testing the logging itself per log-level: * warn_is * warn_like * debug_is * debug_like ... Methods for counting the logging activity and also for clearing the mock buffer are provided as well. This is covered in the POD and also on the follow-up, that makes use of this to fix Auth_with_shibboleth.t To test: 1. Run: $ kshell k$ prove t/Auth_with_shibboleth.t => FAIL: Tests fail! It expects some warns but they are not returned by the lib 2. Apply this patches 3. Repeat 1 => SUCCESS: Tests pass! The tests now use the new lib, and they correctly find the logging Auth_with_shibboleth.pm does on function calls. 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 10:10:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 08:10:38 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122481|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize --- Created attachment 122485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122485&action=edit Bug 28615: Fix t/Auth_with_shibboleth.t This patch makes t/Auth_with_shibboleth.t use the new t::lib::Mocks::Logger tools Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 10:11:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 08:11:33 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #26 from Martin Renvoize --- This is great and should lead to much simpler testing in the future.. I think we've arrived at a great end point. Thanks for taking the baton and completing the work Tomas. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 10:12:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 08:12:48 +0000 Subject: [Koha-bugs] [Bug 28636] t:lib::Mocks is missing POD In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28636 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122479|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 122486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122486&action=edit Bug 28636: Add POD to t:lib::Mocks There's no POD. This patch adds it. I wrote it as part of bug 28615 but then it took another direction, so submitting here. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 10:13:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 08:13:21 +0000 Subject: [Koha-bugs] [Bug 28636] t:lib::Mocks is missing POD In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28636 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Really glad this didn't get lost in the rework of bug 28615.. great improvement. Straight PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 10:13:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 08:13:27 +0000 Subject: [Koha-bugs] [Bug 28636] t:lib::Mocks is missing POD In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28636 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 11:10:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 09:10:22 +0000 Subject: [Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #38 from Victor Grousset/tuxayo --- I guess this should go in the technical release notes? Here is a first try: ### Perl modules A new lib directory has been added for Perl modules. This might requires some changes in your webserver configuration if you don't install Koha via the Debian packages. Here are more info about these changes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519#c2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519#c15 This ticket says: «Pushed to 21.05.x for 21.05.01» Shouldn't it be also in the 21.05 tech release notes? I guess they are published and immutable? https://annuel.framapad.org/p/koha_21.11_tech_release_notes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 12:36:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 10:36:41 +0000 Subject: [Koha-bugs] [Bug 12561] Remove non-XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #12 from Martin Renvoize --- Sorry Jonathan.. I get 'sha1 information is lacking or useless' on the third patch. They look good but I can't SO without testing ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 13:18:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 11:18:13 +0000 Subject: [Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from borrower holds list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED --- Comment #8 from Magnus Enger --- *** This bug has been marked as a duplicate of bug 22286 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 13:18:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 11:18:13 +0000 Subject: [Koha-bugs] [Bug 22286] When OpacHiddenItems are checked out, link in list of checkouts leads to 404 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22286 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfuerst at hmcpl.org --- Comment #1 from Magnus Enger --- *** Bug 27734 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 13:21:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 11:21:05 +0000 Subject: [Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from borrower holds list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- --- Comment #9 from Magnus Enger --- Sorry, I got the duplicity backwards! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 13:21:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 11:21:40 +0000 Subject: [Koha-bugs] [Bug 22286] When OpacHiddenItems are checked out, link in list of checkouts leads to 404 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22286 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Magnus Enger --- *** This bug has been marked as a duplicate of bug 27734 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 13:21:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 11:21:40 +0000 Subject: [Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from borrower holds list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 --- Comment #10 from Magnus Enger --- *** Bug 22286 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 13:21:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 11:21:40 +0000 Subject: [Koha-bugs] [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403 Bug 24403 depends on bug 22286, which changed state. Bug 22286 Summary: When OpacHiddenItems are checked out, link in list of checkouts leads to 404 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22286 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 13:24:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 11:24:39 +0000 Subject: [Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from borrower holds list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 13:34:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 11:34:35 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #9 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #8) > (In reply to Marcel de Rooy from comment #4) > > Please run qa tools. I see this failure: > > FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt > > FAIL valid_template > > Attempt to reload Koha/Template/Plugin/Biblio.pm aborted. > > Compilation failed in require at > > /usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Plugins.pm line 206. > > => Is this related to biblio-view-menu.inc ? > > The following change should fix that. > > diff --git a/Koha/ArticleRequest.pm b/Koha/ArticleRequest.pm > index 3ea325d83dc..692099ca6bd 100644 > --- a/Koha/ArticleRequest.pm > +++ b/Koha/ArticleRequest.pm > @@ -27,6 +27,7 @@ use Koha::Biblios; > use Koha::Items; > use Koha::Libraries; > use Koha::DateUtils qw(dt_from_string); > +use Koha::ArticleRequest::Status; > > use base qw(Koha::Object); Sorry, but it does not with me: diff --git a/Koha/ArticleRequest.pm b/Koha/ArticleRequest.pm index 3ea325d83d..692099ca6b 100644 --- a/Koha/ArticleRequest.pm +++ b/Koha/ArticleRequest.pm @@ -27,6 +27,7 @@ use Koha::Biblios; use Koha::Items; use Koha::Libraries; use Koha::DateUtils qw(dt_from_string); +use Koha::ArticleRequest::Status; use base qw(Koha::Object); FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt FAIL valid_template Attempt to reload Koha/Template/Plugin/Biblio.pm aborted. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl5/5.28/Template/Plugins.pm line 206. There is still something else triggering a compile warn or error? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 14:27:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 12:27:21 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #27 from Marcel de Rooy --- Created attachment 122487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122487&action=edit Bug 26302: (follow-up) Handle zero callnumbers-case As David observed while testing, we should differentiate between the pref value 1 and 0 (or undef). This patch does no longer convert the value to 1 as default. And it removes an empty [ Call number: ] suffix. Test plan: Set resultsMaxItems or ..Unavailable to zero and check search results. Verify that you see something like: Availability: Items available for loan: Centerville (3) . Items available for reference: Centerville Staff Collection (1) . Not available: TEST (2). MOVING (1). Withdrawn (2). Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 14:40:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 12:40:45 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #28 from Marcel de Rooy --- (In reply to David Nind from comment #24) > 1. Should the call number be repeated if it is the same? That is, should > only distinct call numbers be displayed for items available by library > branch or not available categories? This is far from trivially adding a distinct keyword. We are relying here on the output of the xslt key function. Making this change would require a bit more than we are doing here now to control the number displayed. > 2. Should using 0 for resultsMaxItems suppress the display of call numbers? > That is the behavour when resultsMaxItemsUnavailable is 0. The follow-up now resolves this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 14:41:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 12:41:39 +0000 Subject: [Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28630 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 14:41:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 12:41:39 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28455 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 14:43:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 12:43:20 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 14:43:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 12:43:24 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122484|0 |1 is obsolete| | Attachment #122485|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall --- Created attachment 122488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122488&action=edit Bug 28615: Add a simple way to mock Koha::Logger This patch introduces a new way to mock and test Koha::Logger. As the POD says, it is used by calling my $logger = t::lib::Mocks::Logger->new(); It then provides convenient methods for testing the logging itself per log-level: * warn_is * warn_like * debug_is * debug_like ... Methods for counting the logging activity and also for clearing the mock buffer are provided as well. This is covered in the POD and also on the follow-up, that makes use of this to fix Auth_with_shibboleth.t To test: 1. Run: $ kshell k$ prove t/Auth_with_shibboleth.t => FAIL: Tests fail! It expects some warns but they are not returned by the lib 2. Apply this patches 3. Repeat 1 => SUCCESS: Tests pass! The tests now use the new lib, and they correctly find the logging Auth_with_shibboleth.pm does on function calls. 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 14:43:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 12:43:35 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 --- Comment #28 from Kyle M Hall --- Created attachment 122489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122489&action=edit Bug 28615: Fix t/Auth_with_shibboleth.t This patch makes t/Auth_with_shibboleth.t use the new t::lib::Mocks::Logger tools Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 15:07:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 13:07:48 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 15:07:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 13:07:52 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122476|0 |1 is obsolete| | --- Comment #9 from Andrew Fuerste-Henry --- Created attachment 122490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122490&action=edit Bug 28630: Add track_login_daily to ILSDI::AuthenticatePatron This patch adds a call to track_login_daily for the AuthenticatePatron method in ILSDI. Many libraries use this ILSDI endpoint for electron book borrowing and need to maintain the lastseen based on this type of lending. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 15:07:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 13:07:55 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122477|0 |1 is obsolete| | --- Comment #10 from Andrew Fuerste-Henry --- Created attachment 122491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122491&action=edit Bug 28630: Add unit tests Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 15:07:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 13:07:58 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122478|0 |1 is obsolete| | --- Comment #11 from Andrew Fuerste-Henry --- Created attachment 122492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122492&action=edit Bug 28630: (follow-up) Update wording of syspref Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 15:09:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 13:09:04 +0000 Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 --- Comment #12 from Andrew Fuerste-Henry --- Tested and signed off, but I should have thought sooner about how this was going to run into bug 28455, also signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 15:09:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 13:09:56 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master --- Comment #29 from Tomás Cohen Arazi --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 16:01:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 14:01:05 +0000 Subject: [Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Blocks| |15504 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 [Bug 15504] Track Patron's Last Activity -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 16:01:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 14:01:05 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28455 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455 [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 16:07:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 14:07:46 +0000 Subject: [Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122482|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 122493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122493&action=edit Bug 28455: lastseen should be updated at checkout if TrackLastPatronActivity is enabled Signed-off-by: Andrew Fuerste-Henry Signed-off-by: David Nind Signed-off-by: Emmi Takkinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 16:07:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 14:07:50 +0000 Subject: [Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122483|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 122494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122494&action=edit Bug 28455: Update wording on TrackLastPatronActivity This patch updates the wording on TrackLackPatronActivity to maintain the corrections from bug 28467 and also reflect the change made in this bug. It should now read: The first time each day that a patron either logs into the OPAC, connects to Koha via SIP, or checks an item out, borrowers.lastseen will update with the current date and time. Signed-off-by: David Nind Signed-off-by: Emmi Takkinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 16:08:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 14:08:46 +0000 Subject: [Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Martin Renvoize --- Works as expected, makes sense. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 16:14:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 14:14:41 +0000 Subject: [Koha-bugs] [Bug 28211] Replace use of call_recursive() with call() In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28211 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 17:19:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 15:19:19 +0000 Subject: [Koha-bugs] [Bug 28263] AUTO_RENEWAL message for 'too_many' is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 17:19:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 15:19:22 +0000 Subject: [Koha-bugs] [Bug 28263] AUTO_RENEWAL message for 'too_many' is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120315|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 122495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122495&action=edit Bug 28263: Fix too_many auto renewal message To test: 1. Make an item eligible for auto_renewal. 2. Set circ rule so only 1 auto_renewal is allowd. 3. Run auto_renew once, get a successful message. 4. Run it again and get the too_many error "You have reached the maximum number of checkouts possible." 5. This has nothing to do with the number of checkouts 6. Apply patch and updatedatabase. 7. Do 1-4 again. 8. Message is now "You have reached the maximum number of renewals possible." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 17:30:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 15:30:06 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 --- Comment #30 from Tomás Cohen Arazi --- Created attachment 122496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122496&action=edit Bug 28615: (follow-up) Newer Test::MockModule forbid ->mock In strict mode, ->mock is forbidden and ->redefine needs to be used instead. I tested this on buster to see if it breaks something, but it doesn't. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 17:30:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 15:30:11 +0000 Subject: [Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 --- Comment #31 from Tomás Cohen Arazi --- Created attachment 122497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122497&action=edit Bug 28615: (follow-up) Disable strict mode explicitly So Debian 9's version of Test::MockModule doens't have ->redefine, and Ubuntu 20.04's doesn't recognise qw(nostrict). So the only solution is to just remove the keywords use completely and move back to using ->mock, as the rest of the codebase. FIXME: using ->mock might be hiding some errors (like a method not being defined/removed) and should be avoided. ->redefine will explode if the method doesn't already exist, which is what we want, to catch this kind of errors. That's why ->mock in strict mode is forbidden. We should try packaging a newer Test::MockModule ourselves. Tested on master-buster, master-stretch and master-focal. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 18:16:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 16:16:26 +0000 Subject: [Koha-bugs] [Bug 27495] The "Accessibility advocate" role is not yet listed in the about page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27495 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.07 |21.05.00,20.11.07,20.05.14 released in| | --- Comment #13 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 18:16:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 16:16:40 +0000 Subject: [Koha-bugs] [Bug 28442] Release team 21.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28442 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.07 |21.05.00,20.11.07,20.05.14 released in| | --- Comment #22 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 19:36:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 17:36:11 +0000 Subject: [Koha-bugs] [Bug 28637] New: Record notes on transactions in register details page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28637 Bug ID: 28637 Summary: Record notes on transactions in register details page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: martin.renvoize at ptfs-europe.com The page at /cgi-bin/koha/pos/register.pl shows historic transactions at one's register. Libraries would like to be able to save and edit notes on these transactions from this screen. Since these all relate back to accountlines, there is a notes field available if we had a way to access it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 21:50:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 19:50:27 +0000 Subject: [Koha-bugs] [Bug 28638] New: Provide authority records via OAI-PMH Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28638 Bug ID: 28638 Summary: Provide authority records via OAI-PMH Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: black23 at gmail.com QA Contact: testopia at bugs.koha-community.org Hi, Now Koha only offers bibliographic records via OAI-PMH. We would like to extend the functionality for authority records as well. Michal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 21:51:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 19:51:19 +0000 Subject: [Koha-bugs] [Bug 28638] Provide authority records via OAI-PMH In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28638 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com, | |dcook at prosentient.com.au, | |ere.maijala at helsinki.fi, | |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 23:50:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 21:50:31 +0000 Subject: [Koha-bugs] [Bug 28462] TT tag on several lines break the translator tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28462 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122309|0 |1 is obsolete| | --- Comment #14 from Victor Grousset/tuxayo --- Created attachment 122498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122498&action=edit Bug 28462: Remove TT tag on several lines - opac-advsearch.tt It fixes the translation in case the operators have been translated Test plan: 1. misc/translator/translate update pt-BR 2. In pt-BR-opac-bootstrap.po , find OpacAdvSearchMoreOptions 3. sabotage the translation part, like replacing IF with something else 4. misc/translator/translate install pt-BR 5. enable and use pt-BR and hit opac-advsearch.pl 6. Notice the error Template process failed: file error - parse error - /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/pt-BR/modules/opac-advsearch.tt line 409: unexpected token (e) [% IF (OpacAdvSearchMoreOptions and OpacAdvSearchMoreOptions.size> 0 e extended_options) ou (OpacAdvSearchOptions and OpacAdvSearchOptions.size> 0 e n expandido_options) %] at /kohadevbox/koha/C4/Templates.pm 7. Apply the patch and redo update and install of the language 8. Note that it's now working Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 29 23:50:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Jun 2021 21:50:36 +0000 Subject: [Koha-bugs] [Bug 28462] TT tag on several lines break the translator tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28462 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122311|0 |1 is obsolete| | --- Comment #15 from Victor Grousset/tuxayo --- Created attachment 122499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122499&action=edit Bug 28462: Remove line breaks in TT tags Same as previous patch for other files. Looks like the problem exists only with IF. == test plan == 1. See the problematic strings in a given language git grep "\bIF\b" misc/translator/po | grep -v '#' | grep '\bzh-Hant-TW' 2. update the language misc/translator/translate update zh-Hant-TW 3. Recheck the problematic strings, they aren't here anymore 4. Check the diff: git diff and search the if's with «/-.* IF » to see how the deleted strings look like and that it makes sense. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 07:29:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 05:29:26 +0000 Subject: [Koha-bugs] [Bug 28386] Replace dev_map.yaml from release_tools with .mailmap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28386 --- Comment #50 from wainuiwitikapark at catalyst.net.nz --- Backported to 19.11.x for 19.11.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 07:30:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 05:30:11 +0000 Subject: [Koha-bugs] [Bug 28386] Replace dev_map.yaml from release_tools with .mailmap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28386 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.07,20.05.13 |21.05.00,20.11.07,20.05.13, released in| |19.11.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 07:30:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 05:30:38 +0000 Subject: [Koha-bugs] [Bug 28386] Replace dev_map.yaml from release_tools with .mailmap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28386 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldoldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 07:30:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 05:30:38 +0000 Subject: [Koha-bugs] [Bug 28442] Release team 21.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28442 Bug 28442 depends on bug 28386, which changed state. Bug 28386 Summary: Replace dev_map.yaml from release_tools with .mailmap https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28386 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 07:41:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 05:41:48 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Didier Gautheron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |didier.gautheron at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 07:44:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 05:44:59 +0000 Subject: [Koha-bugs] [Bug 28442] Release team 21.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28442 --- Comment #23 from wainuiwitikapark at catalyst.net.nz --- Backported to 19.11.x for 19.11.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 07:45:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 05:45:39 +0000 Subject: [Koha-bugs] [Bug 28442] Release team 21.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28442 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.07,20.05.14 |21.05.00,20.11.07,20.05.14, released in| |19.11.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 07:46:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 05:46:04 +0000 Subject: [Koha-bugs] [Bug 28442] Release team 21.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28442 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 07:47:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 05:47:32 +0000 Subject: [Koha-bugs] [Bug 27495] The "Accessibility advocate" role is not yet listed in the about page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27495 --- Comment #14 from wainuiwitikapark at catalyst.net.nz --- Should this be backported to 19.11.x? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 11:11:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 09:11:03 +0000 Subject: [Koha-bugs] [Bug 27495] The "Accessibility advocate" role is not yet listed in the about page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27495 --- Comment #15 from Victor Grousset/tuxayo --- It was backported to avoid a conflict when backporting bug 28442. Fridolin found that out. Even if the conflict shouldn't be hard to solve, it felt easier to backport this without giving much though about it. Since it doesn't seem a risky change. And it's nice to have the accessibility advocate role listed. So it can be either be backported or not to 19.11.x , both would work ^^ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 11:43:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 09:43:33 +0000 Subject: [Koha-bugs] [Bug 28639] New: Embed see-from headings (from authorities) into bibliographic records at OAI repository level Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Bug ID: 28639 Summary: Embed see-from headings (from authorities) into bibliographic records at OAI repository level Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: julien.sicot at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org Hi, It could be interesting to enrich the bibliographic records exposed in OAI with see-from headings, this would allow users who use koha with a discovery tool to be able to manage, normalize and index some authorities data ? This is something that could be done directly in C4::Biblio::GetMarcBiblio following the same method used for embedding items. We could use an optional parameter like embed_items (embed_seefromheading) and a function similar to C4::Biblio::EmbedItemsInMarcBiblio by reusing what was made for zebra with EmbedSeeFromHeadings (bug #7417). Thanks for feedback, Best Julien Sicot Systems Librarian, Université Rennes 2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 12:04:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 10:04:10 +0000 Subject: [Koha-bugs] [Bug 28639] Embed see-from headings (from authorities) into bibliographic records at OAI repository level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Julien Sicot (Univ. Rennes 2) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julien.sicot at univ-rennes2.f | |r --- Comment #1 from Julien Sicot (Univ. Rennes 2) --- Created attachment 122500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122500&action=edit Bug 28639 - Embed see-from headings (from authorities) into bibliographic records at OAI repository level Test plan: 1. Create an authority with at least a 1XX$a and a 4XX$a, for instance: 100 $a Foo 400 $a Bar 2. Create a biblio and add a link to this authority using the cataloguing plugin 3. Enable OAI-PMH syspref and fill OAI-PMH:archiveID syspref with "oai:sandbox" 4. Go to OAI repository and display the previously created record (at /cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=oai:sandbox:{biblionumber} 5. The record should not contain see-from headings 6. Enable OAI-PMH:EmbedSeeFromInBibRecord 7. Go again to the OAI record, you should see alternative forms at the end of the record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 12:33:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 10:33:28 +0000 Subject: [Koha-bugs] [Bug 21507] Decimal separators issues in patrons payments/fines, simplified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21507 Henri-Damien LAURENT changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hdlaurent at afi-sa.net --- Comment #12 from Henri-Damien LAURENT --- Dears, Your solution seems to fit your environment. But let me state that some countries, like France have different signs for thousand delimiter and decimal delimiter. And I can see no real support for those "oddities" in the proposed js code. Worse, there seems to be no way to parametrize those 'locales' for currency. For instance, if someone copy pastes 123,13 €, it would be converted into 12,313.00 which is counter intuitive for usual french folks. Moreover, it seems that there is no way to add more decimals... (which should be enable for some rates, if there is a fine per page printed for instance, it could be 0.013 cents per page) To that aim, decimal_fill (hardcoded at the moment in Koha::Number::Price could be parametrized). And the way the proposed patch fixed that would take a system variable for number format into account. So it has my favour. Can it be discussed some time ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 14:16:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 12:16:16 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 14:16:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 12:16:28 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121406|0 |1 is obsolete| | --- Comment #480 from Ere Maijala --- Created attachment 122501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122501&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Sponsored-by: The National Library of Finland Co-authored-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 14:16:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 12:16:38 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121407|0 |1 is obsolete| | --- Comment #481 from Ere Maijala --- Created attachment 122502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122502&action=edit Bug 20447: Add holding_id to REST API item definition Allows items to be properly returned, including the holding_id field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 14:16:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 12:16:46 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121408|0 |1 is obsolete| | --- Comment #482 from Ere Maijala --- Created attachment 122503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122503&action=edit Bug 20447: Add a batch rebuild script for holdings table This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 14:16:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 12:16:55 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121409|0 |1 is obsolete| | --- Comment #483 from Ere Maijala --- Created attachment 122504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122504&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 14:17:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 12:17:03 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121410|0 |1 is obsolete| | --- Comment #484 from Ere Maijala --- Created attachment 122505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122505&action=edit Bug 20447: DBIX schema changes Rebased-by: Andrew Nugged Rebased-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 14:19:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 12:19:29 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #485 from Ere Maijala --- Known issues identified in #466 and #479 should now be fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 14:27:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 12:27:25 +0000 Subject: [Koha-bugs] [Bug 28640] New: Add EDI order status to basket details display Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28640 Bug ID: 28640 Summary: Add EDI order status to basket details display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org One can close the basket without going via the 'Create EDIFACT order' button and then wonder why the order has not proceeded. We should add the EDI status to the basket page so end users can track the progress on a basket to an edi order and beyond. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 14:36:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 12:36:51 +0000 Subject: [Koha-bugs] [Bug 28640] Add EDI order status to basket details display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28640 --- Comment #1 from Martin Renvoize --- Created attachment 122506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122506&action=edit Bug 28640: Expose EDI Status on basket details page This patch adds the edi_order relationship method to Koha::Acquisition::Basket to return the most recently attached edi_message of type 'ORDER' for the basket. NOTE: EDI currently returns raw DBIC results. I have opted to maintain that approach here, but would like to work on upgradeing the Koha::EDIFACT::Order class to be a subclass of Koha::Object at a later date. We then use this new relationship in acqui/basket to display the EDI status for such baskets. Test plan 1/ Setup a vendor with EDI Ordering enabled 2/ Add a new basket for the vendor. 3/ Note the new 'EDI status' field displays and reads 'Not ordered' 4/ Close the basker 5/ The 'EDI status' should continue to display 'Not ordered' 6/ Re-open the basket 7/ Close the basket via 'Create EDIFACT order' 8/ Navigate back to the now closed basket 9/ Note the 'EDI status' field now displays 'Pending' and the transfer date. 10/ Progress the EDI order by running the edi_cron.pl script 11/ The EDI status field should now reflect that the message has been sent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 14:37:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 12:37:07 +0000 Subject: [Koha-bugs] [Bug 28640] Add EDI order status to basket details display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28640 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 14:37:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 12:37:12 +0000 Subject: [Koha-bugs] [Bug 28640] Add EDI order status to basket details display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28640 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 14:37:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 12:37:47 +0000 Subject: [Koha-bugs] [Bug 28640] Add EDI order status to basket details display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28640 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.j.brown at lboro.ac.uk, | |J.P.Knight at lboro.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 14:38:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 12:38:11 +0000 Subject: [Koha-bugs] [Bug 28640] Add EDI order status to basket details display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28640 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 15:27:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 13:27:13 +0000 Subject: [Koha-bugs] [Bug 28640] Add EDI order status to basket details display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28640 --- Comment #2 from Martin Renvoize --- Created attachment 122507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122507&action=edit Bug 28640: Unit tests for edi_order relation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 15:27:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 13:27:16 +0000 Subject: [Koha-bugs] [Bug 28640] Add EDI order status to basket details display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28640 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122506|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 122508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122508&action=edit Bug 28640: Expose EDI Status on basket details page This patch adds the edi_order relationship method to Koha::Acquisition::Basket to return the most recently attached edi_message of type 'ORDER' for the basket. NOTE: EDI currently returns raw DBIC results. I have opted to maintain that approach here, but would like to work on upgradeing the Koha::EDIFACT::Order class to be a subclass of Koha::Object at a later date. We then use this new relationship in acqui/basket to display the EDI status for such baskets. Test plan 1/ Setup a vendor with EDI Ordering enabled 2/ Add a new basket for the vendor. 3/ Note the new 'EDI status' field displays and reads 'Not ordered' 4/ Close the basker 5/ The 'EDI status' should continue to display 'Not ordered' 6/ Re-open the basket 7/ Close the basket via 'Create EDIFACT order' 8/ Navigate back to the now closed basket 9/ Note the 'EDI status' field now displays 'Pending' and the transfer date. 10/ Progress the EDI order by running the edi_cron.pl script 11/ The EDI status field should now reflect that the message has been sent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 16:19:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 14:19:18 +0000 Subject: [Koha-bugs] [Bug 28637] Record notes on transactions in register details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28637 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 16:34:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 14:34:39 +0000 Subject: [Koha-bugs] [Bug 28641] New: ILLHiddenRequestStatuses does not consider custom statuses Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28641 Bug ID: 28641 Summary: ILLHiddenRequestStatuses does not consider custom statuses Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com The ILLHiddenRequestStatuses syspref does a good job of filtering out requests that have statuses matching the specified values, but it doesn't take into account custom statuses. To demonstrate this, create a custom ILL status authorised value, give a request that value, then specify the status code in ILLHiddenRequestStatuses. Then view the list of requests, the list will contain the request with the custom status. Additional filtering needs to be added to filter out requests with a custom status code matching the specified values. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 16:35:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 14:35:01 +0000 Subject: [Koha-bugs] [Bug 28641] ILLHiddenRequestStatuses does not consider custom statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28641 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no Depends on| |23391 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 [Bug 23391] Hide finished ILL requests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 16:35:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 14:35:01 +0000 Subject: [Koha-bugs] [Bug 23391] Hide finished ILL requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28641 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28641 [Bug 28641] ILLHiddenRequestStatuses does not consider custom statuses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 16:56:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 14:56:00 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Jason Boyer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |JBoyer at equinoxOLI.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 17:03:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 15:03:15 +0000 Subject: [Koha-bugs] [Bug 28642] New: Add IndependentBranches syspref to hide other items and libraries Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28642 Bug ID: 28642 Summary: Add IndependentBranches syspref to hide other items and libraries Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: michael.hafen at washk12.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Independent Branches should not see items from other libraries in the staff client. Also don't show other libraries in the many library selects. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 17:07:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 15:07:12 +0000 Subject: [Koha-bugs] [Bug 28642] Add IndependentBranches syspref to hide other items and libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28642 --- Comment #1 from Michael Hafen --- Created attachment 122509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122509&action=edit Proposed patch Proposed patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 17:08:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 15:08:14 +0000 Subject: [Koha-bugs] [Bug 28642] Add IndependentBranches syspref to hide other items and libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28642 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12793 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 17:08:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 15:08:14 +0000 Subject: [Koha-bugs] [Bug 12793] Breaking up IndependentBranches syspref to support finer staff permissions granularity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12793 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28642 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 17:42:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 15:42:12 +0000 Subject: [Koha-bugs] [Bug 28631] Holds History title link returns "not found" error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28631 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 17:50:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 15:50:51 +0000 Subject: [Koha-bugs] [Bug 28631] Holds History title link returns "not found" error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28631 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 17:50:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 15:50:55 +0000 Subject: [Koha-bugs] [Bug 28631] Holds History title link returns "not found" error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28631 --- Comment #1 from Owen Leonard --- Created attachment 122510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122510&action=edit Bug 28631: Holds History title link returns "not found" error This patch corrects a broken path in the OPAC holds history page. This patch also corrects the breadcrumb markup which didn't conform to the new Bootstrap 4 pattern. To test, apply the patch and log into the OPAC as a patron who has past or current holds. - View the "your holds history" page. - Click a title link in the table of holds. It should take you to the correct bibliographic detail page. - Check the breadcrumbs of the page. They should look consistent with breadcrumb navigation on other pages in the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 17:51:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 15:51:12 +0000 Subject: [Koha-bugs] [Bug 28631] Holds History title link returns "not found" error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28631 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 19:07:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 17:07:14 +0000 Subject: [Koha-bugs] [Bug 28640] Add EDI order status to basket details display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28640 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Kyle M Hall --- Instead of just printing the value of edi_order.status in the template, please use and IF/ELSIF/ELSE block for all the possible statuses, so they may be translated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 19:07:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 17:07:20 +0000 Subject: [Koha-bugs] [Bug 28640] Add EDI order status to basket details display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28640 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 20:09:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 18:09:58 +0000 Subject: [Koha-bugs] [Bug 27268] Move C4::Biblio::GetMarcNotes to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27268 Elaine Bradtke changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eb at efdss.org --- Comment #9 from Elaine Bradtke --- Here's what I posted on the list regarding our 590 fields. There is a subfield x Non Public Note which contains information for the staff regarding the content of the work, and a subfield z Public note that contains a generic statement governed by an authorized value. What we see in the normal view in both the staff interface and the OPAC is the Non Public note and the code for the authorized value for the public note. In the OPAC, it displays correctly in labeled MARC. In plain MARC it only displays the authorized value code. See https://catalogue.efdss.org/cgi-bin/koha/opac-detail.pl?biblionumber=65305 for an example. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 20:30:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 18:30:33 +0000 Subject: [Koha-bugs] [Bug 23499] Show subtitle in serials search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23499 --- Comment #3 from Andrew Fuerste-Henry --- We should also show the subtitle in the claims screen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 20:30:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 18:30:47 +0000 Subject: [Koha-bugs] [Bug 23499] Show subtitle in serials interface generally In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23499 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show subtitle in serials |Show subtitle in serials |search |interface generally -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 20:31:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 18:31:43 +0000 Subject: [Koha-bugs] [Bug 23499] Show subtitle in serials interface generally In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23499 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 30 20:53:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Jun 2021 18:53:53 +0000 Subject: [Koha-bugs] [Bug 28643] New: On import, if login_attempts is not specified, it throws an error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28643 Bug ID: 28643 Summary: On import, if login_attempts is not specified, it throws an error Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: enica at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When importing borrowers in the staff client, it requires you to specify a borrowers.login_attempts value of '0'. DBD::mysql::st execute failed: Column 'login_attempts' cannot be null [for Statement "INSERT INTO `borrowers` File has branchcode, cardnumber, categorycode, surname, firstname, sort1. Work around: add login_attempts with '0' value. Import works. Might be related to bug 25664? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.