[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #338 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to David Cook from comment #334)
> (In reply to Aleisha Amohia from comment #326)
> > Ah I remember now - yes, a hold group is supposed to be treated as one hold
> > because when one item from that group is confirmed to fill the hold, the
> > rest of the group is deleted.
> > 
> > I'll fix this up.
> 
> After reading through the code and further testing and thinking, I don't
> think that's feasible. It would require much more refactoring to achieve
> that, and I'm not sure that it's worth it. 
> 
> So I think if we pull out the count_grouped() code, then this could actually
> pass QA, so long as the intention is to create a group of holds, and that
> fulfilling one hold will clear the other holds. That works well. 
> 
> The counting of the hold group as 1 hold does not work at all though, so
> perhaps that concept should be abandoned (for now at least).

I'm not sure if I am following correctly or not.  Is the group hold going to
count as one placed hold or count for every item in the group?? If it is going
to show as multiple holds, then it becomes a problem for anyone that uses it. 
The group hold HAS to count as a single hold for this to be useful and not
exploited by patrons.

Without looking at the code, logically, it seems like if you have each group
hold count as some kind of of proxy hold in the hold system, when Koha looks to
see how many holds there are, it should also see how many group holds there
are, and each group for that user should just reflect as one hold.  I may be
over simplifying this.

-- 
You are receiving this mail because:
You are watching all bug changes.