[Koha-bugs] [Bug 28503] New: When ReservesControlBranch set to "patron's home library" and Hold policy set to "From home library" all holds are allowed

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503

            Bug ID: 28503
           Summary: When ReservesControlBranch set to "patron's home
                    library" and Hold policy set to "From home library"
                    all holds are allowed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

In C4::Reserves::CheckReserves we have:
next if (($branchitemrule->{'holdallowed'} eq 'from_home_library') && ($branch
ne $patron->branchcode));

Where $branch is the return of 
my $branch = GetReservesControlBranch( $item->unblessed, $patron->unblessed );

When ReservesControlBranch is set to "patron's home library" this boils down
to:
$patron->branchcode ne $patron->branchcode which will never be true

In all other locations we ue ReservesControlBranch to fetch the rule, but
always compare the item's homebranch to the patron's branchcode:
 543     if (   $branchitemrule->{holdallowed} eq 'from_home_library'
 544         && $borrower->{branchcode} ne $item->homebranch )
 545     {
 546         return { status => 'cannotReserveFromOtherBranches' };
 547     }

1409             || $branchitemrule->{holdallowed} eq 'from_home_library' &&
$param->{patron}->branchcode ne $i->homebranch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.