[Koha-bugs] [Bug 28504] New: Hold pickup library match (hold_fulfillment_policy) not enforced when filling holds if set to "patron's group" / 'patrongroup'

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28504

            Bug ID: 28504
           Summary: Hold pickup library match (hold_fulfillment_policy)
                    not enforced when filling holds if set to "patron's
                    group" / 'patrongroup'
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The case is simply not covered in the code

In C4::Reserves::CheckReserves:

 908 my $hold_fulfillment_policy = $branchitemrule->{hold_fulfillment_policy};
 909 next if ( ($hold_fulfillment_policy eq 'holdgroup') &&
(!$library->validate_hold_sibling({branchcode => $res->{branchcode}})) );
 910 next if ( ($hold_fulfillment_policy eq 'homebranch') &&
($res->{branchcode} ne $item->$hold_fulfillment_policy) );
 911 next if ( ($hold_fulfillment_policy eq 'holdingbranch') &&
($res->{branchcode} ne $item->$hold_fulfillment_policy) );
 912 next unless $item->can_be_transferred( { to => Koha::Libraries->find(
$res->{branchcode} ) }      );

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.