[Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064

--- Comment #43 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
Created attachment 121680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121680&action=edit
Bug 27064: (QA follow-up) Add error message only if we have one defined

This moves the DestinationEqualsHolding error message addition to if
clause so the value is added to %err hash only when there is actually
an error. Then we only append to the @errmsgloop array the error
message if one was defined.

To test:
 1) Create a hold request to a pickup library where the item currently
 is not
 2) Add transfer to the pickup library using branchtransfers.pl and
 notice without this patch we get and empty message box but with this
 patch we don't get it.

Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.