[Koha-bugs] [Bug 28541] New: Incorrect default pickup location passed to HTML, causing UI show items unreservable

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28541

            Bug ID: 28541
           Summary: Incorrect default pickup location passed to HTML,
                    causing UI show items unreservable
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: joonas.kylmala at helsinki.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, nugged at gmail.com,
                    stalkernoid at gmail.com, tomascohen at gmail.com
        Depends on: 27071

The default pickup branch for holds through intranet was changed in Bug 27071
to be the branch returned by C4::Reserves::GetReservesControlBranch() function.
However, the result of this calculation, $reserves_control_branch, is not
passed to to the Template Toolkit template:

> # pass the userenv branch if no pickup location selected
> $template->param( pickup => $pickup || C4::Context->userenv->{branch} );

Instead the wrong value, currently logged in branch is passed. This causes the
UI give false warning triangles about not being able to reserve some items even
though the reservation works if you ignore those warnings. We should be passing
the same branch as we did the availability calculation with, i.e.
$reserves_control_branch.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27071
[Bug 27071] Hold pickup library match not enforced correctly on intranet when
using hold groups
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.