[Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078

--- Comment #50 from Julian Maurice <julian.maurice at biblibre.com> ---
Comment on attachment 121909
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121909
Bug 25078: Put db revs into different files to handle them better

Review of attachment 121909:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25078&attachment=121909)
-----------------------------------------------------------------

::: installer/data/mysql/db_revs/skeleton.pl
@@ +3,5 @@
> +{
> +    bug_number => "BUG_NUMBER",
> +    description => "A single line description",
> +    # description => ["Multi", "lines", "description"],
> +    # description => sub { return ["Your dynamic description"] },

I think there is something wrong about multi-lines/dynamic description. Why do
we need that ? I think that we are confusing the update's "description" (what
the update is supposed to do) with the update's "report" (what the update has
done).
A dynamic description also implies that it should be generated after the update
is done, because the 'description' sub might use some data from the 'up' sub,
but what if we want to display a list of pending updates before executing them
?

-- 
You are receiving this mail because:
You are watching all bug changes.