[Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078

--- Comment #57 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Julian Maurice from comment #56)
> (In reply to Julian Maurice from comment #54)
> > I'll submit a patch later to show what I have in mind (maybe on a remote git
> > repository to not pollute this bug)
> https://gitlab.com/jajm/Koha/-/commit/
> 864372e553d312d1a533a75f389d9a7aa143c62e

Yes, good idea!
Not sure why you absolutely want to pass $dbh however :)

> (In reply to Jonathan Druart from comment #55)
> > Then we would need 2 kinds of "description", as we want to keep the ability
> > to output something dependent on what is in DB (like raise a warning if we
> > find data inconsistency).
> I agree (but I think that data inconsistency, or any other anomaly detected
> should stop the update until it's fixed)

We had example where we removed an "unused" DB column but wanted to prevent
deletion if it contains data ("Hey, we were going to remove this column but you
have data in it"). We could also stop the update in that case but it's not
blocker.

20.06.00.055 is another example ("FK added" or "FK already existed");

Anyway your approach deals with that!

-- 
You are receiving this mail because:
You are watching all bug changes.