[Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064

--- Comment #52 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
Created attachment 121981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121981&action=edit
Bug 27064: Correct transferbook.t tests to reflect new behaviour of
transferbook()

The transferbook() behaviour was changed so that it only allows
transferring the item with a reserve if ignore_reserves=1 is passed to
it. The tests are changed here to reflect that. Note that however the
tests were buggy already before this change because the transfer's
"from" and "to" branches were the same and so the transfer should have
failed due to the error DestinationEqualsHolding, but futher though
the transferbook() code was buggy and it override the
DestinationEqualsHolding checking totally if there was a transfer! So
the tests were earlier working due to a bug in transferbook().

To test):
   1) Make sure the new test scenarios make sense
   2) prove t/db_dependent/Circulation/transferbook.t

-- 
You are receiving this mail because:
You are watching all bug changes.