[Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jun 15 12:15:53 CEST 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520

--- Comment #38 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
(In reply to Jonathan Druart from comment #36)
> (In reply to Jonathan Druart from comment #35)
> > #   Failed test 'No tests run for subtest "from_library relation tests"'
> > #   at /kohadevbox/koha/t/db_dependent/Koha/Item/Transfer.t line 75.
> > The method Koha::Item::Transfer->from_library is not covered by tests!
> > 
> > Looks like there are remaining tests.
> 
> Shouldn't we actually keep the sub instead of removing the tests?

Nobody is using the code so why keep it around? Creates more work if something
needs to be changed that affects this unused code. Attached patch to remove the
test.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list