[Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Marcel de Rooy from comment #8)
> Just seeing a mail problem here (not from this patch):
> 
> sub inbound_email_address {
>     my ($self) = @_;
> 
>     return
>          $self->branchreplyto
>       || $self->branchemail
>       || C4::Context->preference('ReplytoDefault')
>       || C4::Context->preference('KohaAdminEmailAddress')
>       || undef;
> 
> ReplyToDefault should imo not be used as the from address.
> Note that the preferences advertize:
> 
> KohaAdminEmailAddress 	
> Email address for the administrator of Koha: (This is the default From:
> address for emails unless there is one for the particular library, and is
> referred to when an internal error occurs.)
> ReplytoDefault 	
> Email address to be set as the replyto in emails: 
> 
> Same for branchreplyto. Note that my server may send mails as
> library.rijksmuseum.nl and wants replies to rijksmuseum.nl but is not
> allowed to send as rijksmuseum.nl. So this code is bad and triggers spam
> lists etc.
> 
> So actually we should do:
>     return
>       $self->branchemail
>       || C4::Context->preference('KohaAdminEmailAddress');
> 
> An || undef makes not much sense?
> 
> Will open a new report too.

Please point out where inbound_email_address is being used as the from
address.. that is not it's purpose... the `|| undef` does indeed feel a little
odd.. but the rest of the fallthrough chain is correct in my opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.