[Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Jun 18 15:43:33 CEST 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122080|0                           |1
        is obsolete|                            |

--- Comment #26 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 122139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122139&action=edit
Bug 28581: Use 'from_email_address' where appropriate

This patch replaces a few more trivial cases where we were using
library->branchemail with a fallback to KohaAdminEmail to just use the
new library->from_email_address method directly instead.

There were also a couple of cases where we were passing borrowernumber
and the patrons library from address too.. this is unneccesary as the
code in _send_email_massage will already default to patron library from
address if we do not pass an override.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Added a semicolon.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list