[Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078

--- Comment #63 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This has moved a bit.. looking good.

I wonder about the --force option we've introduced a little.. might be good to
have a 'force_once' or something so allow the user to pick to ignore the first
error but have subsequent errors still catch.

Generally, I think I'm happy here.. I do think Julians $report way of doing
multi-line description blocks is cleaner looking somehow.. and I can see his
point about passing dbh rather than suggesting we rely on C4::Context.. it is
somewhat future-proofing (and it's a familiar concept to me to pass dbh around
this way as it's how DBIx::Class::DeploymentHandler does it (though in that
case.. they often also pass a dbic schema for the before and after upgrade step
so you can use dbic during upgrades.. takes some getting used to, but is pretty
cool)

Also, bug 27880 looks really interesting too.. I hope we could quickly work
through that after this.. feels like they lend themselves to being pushed in
quick sucession.

-- 
You are receiving this mail because:
You are watching all bug changes.