[Koha-bugs] [Bug 28510] Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sun Jun 20 21:15:01 CEST 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #121578|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 122193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122193&action=edit
Bug 28510: Skip processing holds queue items from closed libraries when
HoldsQueueSkipClosed is enabled

Right now we skip closed branch's items as we iterate over all items looking
for ones to fill a hold. If HoldsQueueSkipClosed is enabled, no items held be a
closed library can be targeted, so it would be more efficient if we never
selected the items from those branches to begin with. This is how the holds
queue works if we are not using the transport cost matrix, so we should make it
work the same way if we *are* using the matrix.

Test Plan:
1) Apply this patch
2) prove prove t/db_dependent/HoldsQueue.t
3) All tests should continue to pass

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list