[Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078

--- Comment #66 from Julian Maurice <julian.maurice at biblibre.com> ---
Comment on attachment 122208
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122208
Bug 25078: Separate update "report" from its description

Review of attachment 122208:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25078&attachment=122208)
-----------------------------------------------------------------

::: C4/Installer.pm
@@ +724,5 @@
>  
>          my $error;
>  
> +        my $out = '';
> +        open my $outfh, '>', \$out;

About that feature of 'open', perldoc says:

This feature works only when Perl is built with PerlIO -- the default, except
with older (pre-5.16) Perl installations that were configured to not include it
(e.g. via Configure -Uuseperlio). You can see whether your Perl was built with
PerlIO by running perl -V:useperlio. If it says 'define', you have PerlIO;
otherwise you don't.

But it also says:

For Perls 5.8.0 and later, PerlIO is (most often) the default

It tested up to 5.10 (with docker images at https://hub.docker.com/_/perl) and
it works well.
If we want to be extra safe we can increase the minimum perl version required
to 5.16 but I don't think it's necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.