[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
             Status|Passed QA                   |Failed QA

--- Comment #108 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
1. Can you summarize what is done in this patchset please? A full test plan
would be nice too.

2. APPLY is not in account_offset_types.sql

3.
+    $dbh->do( "UPDATE account_offsets SET type = 'APPLY' WHERE type !=
'OVERDUE_INCREASE' AND type != 'OVERDUE_DECREASE' AND type != 'CREATE'" );

Hum, is this query correct? Aren't we missing a condition?

4. Tests missing for Koha::Account::Line->manager

-- 
You are receiving this mail because:
You are watching all bug changes.