[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |28590

--- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Marcel de Rooy from comment #9)
> Just mentioning one compile error:
> 
> perl -c tools/viewlog.pl

Oops, there was a missing dependency on bug 28590.

(In reply to Marcel de Rooy from comment #11)
> -                $debug and warn "Error ExportFramework $@\n";
> +                Koha::Logger->get->warn("Error ExportFramework $@");
> 
> Warn instead of debug ?

Yes, those are warnings (export errors). We can lower them later if it's too
noisy.

(In reply to Marcel de Rooy from comment #13)
> -BEGIN {
> -    $DEBUG = ($ENV{DEBUG}) ? 1 : 0;
> -}
> 
> We still have other cases of using $ENV{DEBUG} ? What about them?

This report was about C4::Debug only, we could extend it to DEBUG.

(In reply to Marcel de Rooy from comment #14)
> git grep "C4::Debug"
> misc/admin/koha-preferences:use C4::Debug;
> misc/admin/koha-preferences:    print STDERR $message . "\n" if (
> $C4::Debug::debug );

Oops, my 'git grep' alias is not picking files without extension it seems!


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28590
[Bug 28590] get_shelves_userenv and set_shelves_userenv not used
-- 
You are receiving this mail because:
You are watching all bug changes.