[Koha-bugs] [Bug 27268] Move C4::Biblio::GetMarcNotes to Koha namespace

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27268

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
This patch introduces a bad side-effect.

>From the mailing list
https://lists.katipo.co.nz/pipermail/koha/2021-June/056413.html

If you have a note in 590$z that is linked with an authorised value, then the
code will be displayed instead of the description.

What's happening?
Before this patch we did (the big lines):

my $record = GetMarcBiblio({ biblionumber => $biblionumber });
XSLTParse4Display($record);
my $notes = GetMarcNotes($record);

=> XSLTParse4Display *is modifying* the record (see the $field->replace_with
call in transformMARCXML4XSLT) and so GetMarcNotes returned the descriptions of
the notes

After this patch:
my $notes = $biblio->get_marc_notes;

=> We are no longer using the descriptions!

Aleisha, Can you please fix this?

-- 
You are receiving this mail because:
You are watching all bug changes.