[Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Jun 25 10:59:10 CEST 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Martin Renvoize from comment #9)
> Tests pass, QA scripts pass and the code looks reasonable.
> 
> I'm not entirely sure about the method name.. we now have:
> 
> Koha::Biblio->get_marc_notes;
> 
> and
> 
> Koha::Biblio->get_authors_from_MARC;
> 
> For consistency, I think I'd prefer this patch to introduce
> 
> Koha::Biblio->get_marc_authors;
> 
> But... I think we can leave that decision to the RM.. so Passing QA :)

I would also prefer get_marc_authors.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list