[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #23 from David Nind <david at davidnind.com> ---
Testing notes (using koha-testing-docker):

Revised test plan:

1. Setup records and items to test:
   . Have records with multiple items and call numbers (one with 20 items and
one with 50) that will appear in the OPAC results using the same keyword (use
'Add multiple copies of this item' option at the bottom of the add item form to
bulk add multiple items).
   . Make sure (using batch item editing) that there are a mix of libraries,
not for loan categories, call numbers, and damaged status'
   . As a bonus, add some additional not for loan categories (Administration >
Basic parameters > Authorized values), such as 'Not for Loan' and 'Staff
Collection'
   . Check out some items to patrons
2. Confirm the current behavour when searching in the OPAC (see the example at
the end):
   . The first call number per branch is displayed under availablility in the
results (for items available for loan and items available for reference)
   . Where there are multiple call numbers for an item, "..." is used to
indicate more call numbers
   . For items not available, such as damaged: no call numbers are displayed.
3. Apply the patch
4. Update the database (updatedatabase when using koha-testing-docker)
5. Run flush_memcached and restart_all (when using koha-testing-docker)
6. Without changing the default values for the new system preferences, check
that the current behavour still works (as per step 2). Note: the default
setting is to display 2 call numbers for items available (only 1 was displayed
before) and 1 call number for items not available (no call numbers were
displayed before).
7. Experiment with different values for the new system preferences (for example
10 for resultsMaxItems and 0 for resultsMaxItemsUnavailable):
   . resultsMaxItems - Maximum number of available items displayed in search
results
   . resultsMaxItemsUnavailable - Maximum number of unavailable items displayed
in search results
8. Confirm that the correct number of call numbers are displayed.
9. Sign off!

Example
-------

Before patch applied:
~~~~~~~~~~~~~~~~~~~~~

Availability: Items available for loan: Centerville (16) Call number: PERL A1,
.., Fairview (1) Call number: PERL A1, Franklin (7) Call number: PERL B2, ..,
Midway (9) Call number: 560.897 ZAK, .., Springfield (6) Call number: 965.009
PLO, ... Items available for reference: Fairview Not For Loan (1) Call number:
PERL A1, Franklin Not For Loan (1) Call number: PERL B2, Midway Not For Loan
(2) Call number: 560.897 ZAK, .., Centerville Not For Loan (1) Call number:
PERL B2, Springfield Not For Loan (3) Call number: 965.009 PLO, ... Not
available: Damaged (7). 

Patch applied:
~~~~~~~~~~~~~~

Availability: Items available for loan: Centerville (16) Call number: PERL A1,
PERL A1, .., Fairview (1) Call number: PERL A1, PERL A1, Franklin (7) Call
number: PERL A1, PERL A1, .., Midway (9) Call number: PERL A1, PERL A1, ..,
Springfield (6) Call number: PERL A1, PERL A1, ... Items available for
reference: Fairview Not For Loan (1) Call number: PERL A1, PERL B2, Franklin
Not For Loan (1) Call number: PERL A1, PERL B2, Midway Not For Loan (2) Call
number: PERL A1, PERL B2, Centerville Not For Loan (1) Call number: PERL A1,
PERL B2, Springfield Not For Loan (3) Call number: PERL A1, PERL B2, ... Not
available: Damaged (7) [ PERL A1, .. ]. 

Note differences:
- Default number of call numbers peated for items available for loan (before
patch was applied they didn't), 
- Not available items didn't originally dispaly Call numbers for Damaged

Different values
~~~~~~~~~~~~~~~~

Results with:
- resultsMaxItems: 10
- resultsMaxItemsUnavailable: 0

Availability: Items available for loan: Centerville (16) Call number: PERL A1,
PERL A1, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, 560.897
ZAK, .., Fairview (1) Call number: PERL A1, PERL A1, PERL B2, PERL B2, PERL B2,
PERL B2, PERL B2, PERL B2, PERL B2, 560.897 ZAK, Franklin (7) Call number: PERL
A1, PERL A1, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2,
560.897 ZAK, Midway (9) Call number: PERL A1, PERL A1, PERL B2, PERL B2, PERL
B2, PERL B2, PERL B2, PERL B2, PERL B2, 560.897 ZAK, Springfield (6) Call
number: PERL A1, PERL A1, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2,
PERL B2, 560.897 ZAK. Items available for reference: Fairview Not For Loan (1)
Call number: PERL A1, PERL B2, 560.897 ZAK, 560.897 ZAK, PERL B2, 965.009 PLO,
965.009 PLO, 965.009 PLO, Franklin Not For Loan (1) Call number: PERL A1, PERL
B2, 560.897 ZAK, 560.897 ZAK, PERL B2, 965.009 PLO, 965.009 PLO, 965.009 PLO,
Midway Not For Loan (2) Call number: PERL A1, PERL B2, 560.897 ZAK, 560.897
ZAK, PERL B2, 965.009 PLO, 965.009 PLO, 965.009 PLO, Centerville Not For Loan
(1) Call number: PERL A1, PERL B2, 560.897 ZAK, 560.897 ZAK, PERL B2, 965.009
PLO, 965.009 PLO, 965.009 PLO, Springfield Not For Loan (3) Call number: PERL
A1, PERL B2, 560.897 ZAK, 560.897 ZAK, PERL B2, 965.009 PLO, 965.009 PLO,
965.009 PLO. Not available: Damaged (7). 

Results with:
- resultsMaxItems: 1
- resultsMaxItemsUnavailable: 0

Availability: Items available for loan: Centerville (16) Call number: PERL A1,
.., Fairview (1) Call number: PERL A1, Franklin (7) Call number: PERL A1, ..,
Midway (9) Call number: PERL A1, .., Springfield (6) Call number: PERL A1, ...
Items available for reference: Fairview Not For Loan (1) Call number: PERL A1,
Franklin Not For Loan (1) Call number: PERL A1, Midway Not For Loan (2) Call
number: PERL A1, .., Centerville Not For Loan (1) Call number: PERL A1,
Springfield Not For Loan (3) Call number: PERL A1, ... Not available: Damaged
(7). 

Results with:
- resultsMaxItems: 0
- resultsMaxItemsUnavailable: 0

Availability: Items available for loan: Centerville (16) Call number: PERL A1,
.., Franklin (7) Call number: PERL A1, .., Midway (9) Call number: PERL A1, ..,
Springfield (6) Call number: PERL A1, ... Items available for reference:
Fairview Not For Loan (1) Call number: PERL A1, Franklin Not For Loan (1) Call
number: PERL A1, Midway Not For Loan (2) Call number: PERL A1, .., Centerville
Not For Loan (1) Call number: PERL A1, Springfield Not For Loan (3) Call
number: PERL A1, ... Not available: Checked out (1). Damaged (7). 

Note: no change from setting to 1 and 0

-- 
You are receiving this mail because:
You are watching all bug changes.