[Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record?

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310

--- Comment #52 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Martin Renvoize from comment #51)
> Oops, I started looking at this on Friday but got pulled away into other
> things.. I hope to get back to it later this week.
> 
> One comment so far however.. I think the 'host_record' relationship accessor
> could be generalised a little more to make it less specific to this feature
> and thus adoptable by other uses in the future.  I'm happy to undertake this
> as a QA follow-up. I think we should move the item count test and syspref
> check out of the module method and into the controllers instead.. as much as
> this goes against the instinct to make sure it's testable I think this will
> lead to a much more flexible low level object method... I wonder if we could
> move the test into the integration tests so it's still caught but at the
> controller level rather than the object?

Great, Martin.
Please note that this patch is already dating from 2018 and unless there are
specific developments underway that could directly be tied in, I would prefer
to get this further instead of making it more generic for some future
development not yet identified.
In short, please add some more details or references to other bugs that you
have in mind.
Thanks for your support.

-- 
You are receiving this mail because:
You are watching all bug changes.