[Koha-bugs] [Bug 21507] Decimal separators issues in patrons payments/fines, simplified

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jun 30 12:33:28 CEST 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21507

Henri-Damien LAURENT <hdlaurent at afi-sa.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hdlaurent at afi-sa.net

--- Comment #12 from Henri-Damien LAURENT <hdlaurent at afi-sa.net> ---
Dears,

Your solution seems to fit your environment. But let me state that some
countries, like France have different signs for thousand delimiter and decimal
delimiter.

And I can see no real support for those "oddities" in the proposed js code.
Worse, there seems to be no way to parametrize those 'locales' for currency.

For instance, if someone copy pastes 123,13 €, it would be converted into
12,313.00 which is counter intuitive for usual french folks.  

Moreover, it seems that there is no way to add more decimals... (which should
be enable for some rates, if there is a fine per page printed for instance, it
could be 0.013 cents per page)

To that aim, decimal_fill (hardcoded at the moment in Koha::Number::Price could
be parametrized).
And the way the proposed patch fixed that would take a system variable for
number format into account.
So it has my favour.

Can it be discussed some time ?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list