From bugzilla-daemon at bugs.koha-community.org Sat May 1 00:01:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Apr 2021 22:01:22 +0000
Subject: [Koha-bugs] [Bug 28248] Exception when getting all orders
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28248
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #120318|0 |1
is obsolete| |
--- Comment #7 from Victor Grousset/tuxayo ---
Created attachment 120349
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120349&action=edit
Bug 28248: aqorders.created_by is nullable
This patch introduces a change to the spec to acknowledge that the field
is nullable. This is fixed in 21.05+ as part of bug 20212.
To test:
1. Have an order with created_by = NULL
2. Use your favourite REST tool (Advanced REST Client(libre), Postman?) to
fetch the order
=> FAIL: It throws a nasty error about non-nullable field being null
3. Apply this patch
4. Reload all
5. Repeat 2
=> SUCCESS: It returns things, created_by is NULL, as it should
6. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Victor Grousset/tuxayo
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat May 1 00:02:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Apr 2021 22:02:46 +0000
Subject: [Koha-bugs] [Bug 28248] Exception when getting all orders
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28248
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |victor at tuxayo.net
--- Comment #8 from Victor Grousset/tuxayo ---
Works :)
Testing notes:
- don't forget it's for 20.11.x, not master.
- Testing without REST client can be done via
http://localhost:8081/api/v1/acquisitions/orders/1
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat May 1 00:06:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Apr 2021 22:06:19 +0000
Subject: [Koha-bugs] [Bug 28248] Exception when getting all orders
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28248
--- Comment #9 from Victor Grousset/tuxayo ---
Code looks good, QA script happy. Count my QA stamp in :)
Signoff still needed if you can Stefan.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat May 1 01:36:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Apr 2021 23:36:33 +0000
Subject: [Koha-bugs] [Bug 25449] Make itemtype mandatory by default
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |victor at tuxayo.net
--- Comment #6 from Victor Grousset/tuxayo ---
Should this ticket be "in discussion" or "assigned"(i.e. needs work)
If not, what would be a test plan for the current patch?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat May 1 02:47:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 May 2021 00:47:01 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |victor at tuxayo.net
--- Comment #23 from Victor Grousset/tuxayo ---
> c. Confirm that non linked subfields are stored and displayed correctly
- item edition list
- MARC details
- OPAC marc view
Is that it?
> d. Try with a "more subfield" that is linked with an authorised value
category
what is a "more subfield"?
> 3. Test barcode values
just put a barcode and using it afterwards?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat May 1 16:02:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 May 2021 14:02:11 +0000
Subject: [Koha-bugs] [Bug 18984] Remove support for NORMARC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Patch doesn't apply
CC| |victor at tuxayo.net
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat May 1 16:53:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 May 2021 14:53:32 +0000
Subject: [Koha-bugs] [Bug 11919] Staff should be able to place (and capture)
holds on items that cannot fill hold requests for patrons
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11919
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|staff should be able to |Staff should be able to
|place (and capture) holds |place (and capture) holds
|on items that cannot fill |on items that cannot fill
|hold requests for patrons |hold requests for patrons
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat May 1 17:39:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 May 2021 15:39:34 +0000
Subject: [Koha-bugs] [Bug 28275] New: Cart in OPAC doesn't sent mails if
surname or firstname contains diacritics
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28275
Bug ID: 28275
Summary: Cart in OPAC doesn't sent mails if surname or
firstname contains diacritics
Change sponsored?: ---
Product: Koha
Version: 20.11
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: verolencinas at yahoo.com.ar
QA Contact: testopia at bugs.koha-community.org
If surname or firstname have diacritics, users can't send their carts in the
OPAC.
Test:
1) Create a user with diacritics in surname or firstname
2) Log in the OPAC with this user
3) Send records through the cart.
You get an error in the cart and in the opac-error.log this error message:
opac-sendbasket.pl: Error sending mail: Invalid 'reply_to' parameter: ... at
/usr/share/koha/opac/cgi-bin/opac/opac-sendbasket.pl line 174
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat May 1 18:44:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 May 2021 16:44:17 +0000
Subject: [Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor
change for backwards compatibility
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #120035|0 |1
is obsolete| |
--- Comment #7 from Victor Grousset/tuxayo ---
Created attachment 120350
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120350&action=edit
Bug 28200: Add workaround for Net::Netmask abbreviated values
This patch adds the shortnet workaround to allow Net::Netmask to
parse abbreviated values.
To test:
1) Apply patch on a Debian 11 Koha
2) Run unit tests
prove t/Koha/Middleware/RealIP.t
3) redo for a Debian 9
Signed-off-by: Victor Grousset/tuxayo
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat May 1 18:46:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 May 2021 16:46:09 +0000
Subject: [Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor
change for backwards compatibility
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |victor at tuxayo.net
--- Comment #8 from Victor Grousset/tuxayo ---
Works as expected on Debian 11 and Debian 9, tested with and without the patch
env: koha-testing-docker
Not switching to signoff because the ticket is kinda "In discussion"
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat May 1 20:15:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 May 2021 18:15:15 +0000
Subject: [Koha-bugs] [Bug 24852] XSLT paths not adjusted for dev installs
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |victor at tuxayo.net
--- Comment #17 from Victor Grousset/tuxayo ---
> 2. Restart all the things and refresh a bibliographic record detail page
> Notice that you see the change from the "htdocs", outside of the git repo
That's puzzling, I see the git repo version. Can't find the issue after double
checking.
> 6. Repeat 2.
> Notice that you now see the change from htdocs
Still git version.
So with and without the patch. With dev_install 1 and dev_install 0, I always
see the git repo version.
A diff between the two files confirmed the difference.
Does anyone else has the same issue?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat May 1 23:43:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 May 2021 21:43:49 +0000
Subject: [Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage
should use ReplytoDefault if set
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |minor
--- Comment #14 from Katrin Fischer ---
Actually more of a bugfix I think - in our case at the moment always a
'noreply@' is shown.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 00:02:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 May 2021 22:02:22 +0000
Subject: [Koha-bugs] [Bug 27562] itiva notices break if record title
contains quotes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27562
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #115909|0 |1
is obsolete| |
--- Comment #2 from Victor Grousset/tuxayo ---
Created attachment 120351
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120351&action=edit
Bug 27562: itiva notices break if record title contains quotes
itiva has reported to us that quotes in the title of a record cause the call to
not be made to the patron. The fix is to remove quotes from the title, as
quotes are not spoken anyway ( That is, "Queens" and "Queen's" are pronounced
the same ).
Test Plan:
1) Set up itiva to send phone notes
2) Find a record with quotes in the title
3) Trigger an itiva notice ( checkout, checkin, place hold, etc )
using the itiva outbound cronjob
4) View the CSV, note the title has the quotes in it
5) Apply this patch
6) Repeat steps 2-3
7) View the CSV, note the title contains no quotes!
Signed-off-by: Victor Grousset/tuxayo
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 00:05:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 May 2021 22:05:40 +0000
Subject: [Koha-bugs] [Bug 27562] itiva notices break if record title
contains quotes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27562
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |victor at tuxayo.net
--- Comment #3 from Victor Grousset/tuxayo ---
works :)
git author needs a fix:
* Author 'Koha user' seems invalid
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 00:18:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 May 2021 22:18:13 +0000
Subject: [Koha-bugs] [Bug 28155] Guided report save goes to 403
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28155
--- Comment #9 from Katrin Fischer ---
(In reply to Kim Colbourne from comment #8)
> Apologies for previous double post. Changed WAF to detection only and
> everything runs fine. So it's something in the ruleset, nothing to do with
> Koha. Apologies again.
No problem, glad a solution could be found!
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 02:54:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 00:54:54 +0000
Subject: [Koha-bugs] [Bug 27844] koha-worker systemd service should run as
%i-koha in package install
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27844
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |victor at tuxayo.net
--- Comment #7 from Victor Grousset/tuxayo ---
/kohadevbox/run.sh yields the following error.
Note: Writing koha-zebra.8
Running [sudo rm /usr/share/man/man8/koha-*.8.gz]...
Running [sudo gzip /usr/share/man/man8/koha-*.8]...
See kohadev-db-request.txt for database creation request.
Please forward it to the right person, and then run
/usr/sbin/koha-create --populate-db kohadev
Thanks.
Failed to connect to bus: No such file or directory
[....] Restarting apache2 (via systemctl): apache2.serviceFailed to connect to
bus: No such file or directory
failed!
######
/h/d/d/k/koha-testing-docker ❯❯❯ cat Dockerfile-27844
FROM koha/koha-testing:master
RUN apt-get update \
&& apt-get -y install systemd systemd-sysv
CMD ["/sbin/init"]
######
git diff docker-compose.yml
koha:
- image: koha/koha-testing:${KOHA_IMAGE}
+ image: container-bug-27844
depends_on:
[...]
-
/home/datumoj/dev/koha/koha-testing-docker/persistent-files/bash_history-koha:/var/lib/koha/kohadev/.bash_history
+ - /sys/fs/cgroup:/sys/fs/cgroup:ro
tmpfs:
#####
build command
docker build -t container-bug-27844 -f Dockerfile-27844 .
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 05:38:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 03:38:59 +0000
Subject: [Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage
should use ReplytoDefault if set
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086
--- Comment #15 from Tomás Cohen Arazi ---
I think we should have a new configuration for this particular use case (email
address to be displayed in OPAC when some error needs to be reported).
If I was to pick one, I would say the admin address is the right one, and
libraries should set different values for each branch. But I see Katrin's
point/need.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 05:57:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 03:57:04 +0000
Subject: [Koha-bugs] [Bug 27849] Koha::Token may access undefined
C4::Context->userenv
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27849
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |victor at tuxayo.net
--- Comment #2 from Victor Grousset/tuxayo ---
Saluton :)
Ĉu estas bona maniero por testi?
Is that a good way to test:
Add the following code:
Koha::Token->new->check_csrf({
session_id => scalar $query->cookie('CGISESSID'),
token => scalar $query->param('csrf_token'),
});
In opac/opac-user.pl
After
C4::Context->preference('casAuthentication') and
C4::Auth_with_cas::logout_if_required($query);
And before
my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
It seems to be the case since it crashes without the patch and work with it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 14:25:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 12:25:32 +0000
Subject: [Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage
should use ReplytoDefault if set
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086
--- Comment #16 from Katrin Fischer ---
(In reply to Tomás Cohen Arazi from comment #15)
> I think we should have a new configuration for this particular use case
> (email address to be displayed in OPAC when some error needs to be reported).
>
> If I was to pick one, I would say the admin address is the right one, and
> libraries should set different values for each branch. But I see Katrin's
> point/need.
It's not only my need actually. I think as the reply-to address is used when
you reply to emails, it makes a lot of sense to use it first. If you don't want
to use it, you don't have to set it at all. I believe this is all the
configuration we need here. It's optional and probably will only be set when
you have a use case that requires it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 14:44:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 12:44:29 +0000
Subject: [Koha-bugs] [Bug 27203] Order unitprice is not set anymore and
totals are 0
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Order unitprice is not set |Order unitprice is not set
|anymore and totals are 0. |anymore and totals are 0
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 14:44:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 12:44:44 +0000
Subject: [Koha-bugs] [Bug 28259] Checking at branch B an item in waiting
hold state at branch A kill Koha
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28259
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Checking at branch B an |Checking at branch B an
|item in waiting hold state |item in waiting hold state
|at branch A kill koha |at branch A kill Koha
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 14:47:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 12:47:05 +0000
Subject: [Koha-bugs] [Bug 28276] New: Do not fetch config ($KOHA_CONF) from
memcached
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28276
Bug ID: 28276
Summary: Do not fetch config ($KOHA_CONF) from memcached
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: ASSIGNED
Severity: normal
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: julian.maurice at biblibre.com
Reporter: julian.maurice at biblibre.com
QA Contact: testopia at bugs.koha-community.org
memcached address and namespace are in $KOHA_CONF, so it is required to read it
before being able to access the cache. And after that, configuration is kept in
memory forever. Storing this in memcached is useless and even
counter-productive, since Koha reads both the file and the cache.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 14:47:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 12:47:40 +0000
Subject: [Koha-bugs] [Bug 28276] Do not fetch config ($KOHA_CONF) from
memcached
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28276
--- Comment #1 from Julian Maurice ---
Created attachment 120352
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120352&action=edit
Bug 28276: Do not fetch config ($KOHA_CONF) from memcached
memcached address and namespace are in $KOHA_CONF, so it is required to
read it before being able to access the cache. And after that,
configuration is kept in memory forever. Storing this in memcached is
useless and even counter-productive, since Koha reads both the file and
the cache
This patch addresses this issue by removing the cache-related code from
C4::Context->new.
It means that C4::Context->new will always read the configuration file,
so this patch also replaces inappropriate calls to
C4::Context->new->config by appropriate calls to C4::Context->config
It also fixes a bug where C4::Context->new would ignore the filepath
given in parameters if there was something in cache.
It also removes a problematic call to Koha::Caches->get_instance.
Because this call was outside of any subroutine, it would have happened
before the initialization of $C4::Context::context (which happen in
C4::Context::import)
Test plan:
1. Do not apply the patch yet
2. Add the following line at the beginning of Koha::Config::read_from_file
warn "read_from_file($file)";
This will allow you to check how many times the file is read.
3. Flush memcached and restart starman
4. Check the logs, you should see "read_from_file" a bunch of times
5. Apply the patch
6. Re-add the line from step 2
7. Flush memcached and restart starman
8. Check the logs, you should see "read_from_file" only once
9. Make sure the memcached config from $KOHA_CONF (memcached_servers,
memcached_namespace) is taken into account by checking the About page
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 14:47:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 12:47:52 +0000
Subject: [Koha-bugs] [Bug 28276] Do not fetch config ($KOHA_CONF) from
memcached
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28276
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 16:01:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 14:01:23 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records,
and assign items to volumes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Patch doesn't apply
--- Comment #270 from Katrin Fischer ---
As this had been waiting so long I've tried to fix the conflict in
kohastructure.sql myself, but then ran into the next one in paths.json...
Can you please rebase?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 16:03:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 14:03:25 +0000
Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired
waiting holds to fill the next hold
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Patch doesn't apply
--- Comment #44 from Katrin Fischer ---
I am sorry, this no longer applies:
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 14364 - Allow automatically canceled expired waiting holds to
fill the next hold
Using index info to reconstruct a base tree...
M C4/Reserves.pm
M Koha/Hold.pm
M installer/data/mysql/mandatory/sysprefs.sql
M installer/data/mysql/pl-PL/mandatory/sample_notices.sql
M
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
Falling back to patching base and 3-way merge...
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
Auto-merging installer/data/mysql/pl-PL/mandatory/sample_notices.sql
CONFLICT (content): Merge conflict in
installer/data/mysql/pl-PL/mandatory/sample_notices.sql
Auto-merging installer/data/mysql/mandatory/sysprefs.sql
Auto-merging Koha/Hold.pm
CONFLICT (content): Merge conflict in Koha/Hold.pm
Auto-merging C4/Reserves.pm
CONFLICT (content): Merge conflict in C4/Reserves.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 14364 - Allow automatically canceled expired waiting
holds to fill the next hold
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-14364---Allow-automatically-canceled-expired-w-834arw.patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 16:11:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 14:11:52 +0000
Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in
export_records.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551
--- Comment #36 from Katrin Fischer ---
>
> 5). There actually is a "deleteditems" table so I guess it would be possible
> to include these, even though it's hard to imagine why you would want to do
> this. Since the default is to include items perhaps it would be best to
> leave this as is and never include items for deleted biblios, or you will
> get more data than you probably want by default. It would also increase code
> complexity, probably with little benefit. If someone requests this it can be
> fixed later perhaps. Will point it out in the documentation that items are
> not included.
I think introducing the export of deleted records and deleted items separately
would be a good idea. Let's start with this well defined feature and think
about the deleted items some more.
While records have a flag to say "deleted", we don't have the same for items.
So we could start exporting deleted items that belonged to deleted records, but
what about other deleted items on existing records? How to "mark" them as
deleted?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 16:12:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 14:12:55 +0000
Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in
export_records.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #37 from Katrin Fischer ---
I am sorry, but tests are failing :(
kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove
t/db_dependent/Exporter/Record.t
t/db_dependent/Exporter/Record.t .. 1/6 Use of uninitialized value in
concatenation (.) or string at /usr/share/perl5/MARC/File/XML.pm line 397,
<$fh> chunk 7.
# Failed test 'Deleted record has the correct leader value'
# at t/db_dependent/Exporter/Record.t line 179.
# got: '00134dam a22000617a 4500'
# expected: '00136dam a22000617a 4500'
# Looks like you failed 1 test of 4.
# Failed test 'export xml'
# at t/db_dependent/Exporter/Record.t line 180.
# Failed test 'Deleted record has the correct leader value'
# at t/db_dependent/Exporter/Record.t line 211.
# got: '00134dam a22000617a 4500'
# expected: '00136dam a22000617a 4500'
# Looks like you failed 1 test of 4.
# Failed test 'export iso2709'
# at t/db_dependent/Exporter/Record.t line 212.
# Looks like you failed 2 tests of 6.
t/db_dependent/Exporter/Record.t .. Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/6 subtests
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 16:14:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 14:14:38 +0000
Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Patch doesn't apply
--- Comment #135 from Katrin Fischer ---
I am really sorry, but this patch set no longer applies and I can't fix it:
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 13952: Import and export authority types
Applying: Bug 13952: (follow-up) Fixing authority type import
error: sha1 information is lacking or useless (C4/ImportExportFramework.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 13952: (follow-up) Fixing authority type import
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-13952-follow-up-Fixing-authority-type-import-NMOJ0F.patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 17:45:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 15:45:23 +0000
Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search
creates UX inconsistency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #117535|0 |1
is obsolete| |
--- Comment #13 from Katrin Fischer ---
Created attachment 120353
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120353&action=edit
Bug 26247: Make retaining search terms in staff client optional
This patch adds a new system preference 'StaffRetainSearchTerms' - if enabled
header searches will be retained on the results page as current behvaiour. If
disabled
the search box will be empty after searching
To test:
1 - Search in staff client from header
2 - Confirm search terms are retained
3 - Apply patch, update database
4 - Search again, terms still retained
5 - Disable StaffRetainSearchTerms preference
6 - Search again
7 - Search box is cleared
Signed-off-by: Sally
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 17:45:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 15:45:28 +0000
Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search
creates UX inconsistency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #117536|0 |1
is obsolete| |
--- Comment #14 from Katrin Fischer ---
Created attachment 120354
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120354&action=edit
Bug 26247: Consolidate search box code
This cleans up the various search bar templates to use a single template
for the 'Search the catalog box'
To test:
1 - Apply patch
2 - Confirm the 'Search the catalog' appears and works from modules:
Budgets
Cataloging
Circulation
Currencies
Contracts
Home page
Notices and slips
Patrons
Administration
Serials
Acquisitions -> suggestions
Z3950 Admin
Signed-off-by: Sally
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 17:45:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 15:45:33 +0000
Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search
creates UX inconsistency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #117537|0 |1
is obsolete| |
--- Comment #15 from Katrin Fischer ---
Created attachment 120355
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120355&action=edit
Bug 26247: Only copy header inputs if marked sticky
This alters the 'keep_text' function to require 'head-searchbox' elements
to be marked with class 'sticky' ti have values carry over
There have been complaints about the stickiness of retained search terms, this
patch attempts to mitigate that while preserving stickiness for other searches
To test:
1 - Enable 'StaffRetainSearchTerms' (or don't apply previous patches)
2 - Search in staff client from header
3 - Search term is retained in the search box
4 - Click abother tab like 'checkin'
5 - Search term is copied to new tab
6 - Apply patch
7 - Reload the page
8 - Search in header
9 - Search term still retained
10 - Click on another header tab
11 - Search term is not copied
Signed-off-by: Sally
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 17:45:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 15:45:39 +0000
Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search
creates UX inconsistency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #117538|0 |1
is obsolete| |
--- Comment #16 from Katrin Fischer ---
Created attachment 120356
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120356&action=edit
Bug 26247: Make search terms optionally sticky
This patch adds a configurable option for retaining stickiness of search terms
across search tabs
To test:
1 - Apply all patches except this one, enable StaffRetainSearchTerms
2 - Search in staff client from header
3 - Confirm behaviour is that term is retained, but not copied when switching
header search tab
4 - Apply this patch, updatedatabase
5 - Search again
6 - Previous behaviour is restored, search terms are sticky between tabs
7 - Disable preference StaffStickySearchTerms
8 - Search again
9 - Search terms retained, but not sticky
Signed-off-by: Sally
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 17:45:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 15:45:44 +0000
Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search
creates UX inconsistency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #117539|0 |1
is obsolete| |
--- Comment #17 from Katrin Fischer ---
Created attachment 120357
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120357&action=edit
Bug 26247: Atomic update
Signed-off-by: Sally
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 17:45:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 15:45:49 +0000
Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search
creates UX inconsistency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247
--- Comment #18 from Katrin Fischer ---
Created attachment 120358
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120358&action=edit
Bug 26247: (QA follow-up) Fix tab chars
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 17:45:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 15:45:55 +0000
Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search
creates UX inconsistency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247
--- Comment #19 from Katrin Fischer ---
Created attachment 120359
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120359&action=edit
Bug 26247: (QA follow-up) Fix 0/1 and terminology in preferences
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 17:46:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 15:46:01 +0000
Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search
creates UX inconsistency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247
--- Comment #20 from Katrin Fischer ---
Created attachment 120360
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120360&action=edit
Bug 26247: (QA follow-up) Move prefs from Search > Results display to Search >
Search form
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 17:58:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 15:58:05 +0000
Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search
creates UX inconsistency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #21 from Katrin Fischer ---
Hi Nick,
I've done some small follow-ups and some testing:
Tested with: copy & retain
1) Budgets
/cgi-bin/koha/admin/aqbudgetperiods.pl
When I add a search term to catalog search or checkout tab, it's not copied to
the other tab.
2) Cataloging
/cgi-bin/koha/cataloguing/addbooks.pl
This seems to work ok. But only the catalog search retains the search term,
cataloging seach does not. I think this is intentional, but would probably be a
good addition?
3) Circulation
4) Currencies
5) Contracts
6) Home page
7 Notices and slips
8) Patrons
9) Administration
10) Serials
When I enter an ISSN or Title in the first tab, it isn't copied to the other
tabs.
11) Acquisitions -> suggestions
12) Z3950 Admin
13) Then I have set "don't copy" and "don't retain". But the only tab this seem
to affect is the catalog search tab? If I enter a search term in "check out",
it will still be copied to checkin, renew, search patrons. Only when switching
to catalog search it will be emptied.
This appears a bit of strange behaviour, if it's intentional, we should change
the pref description.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 18:00:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 16:00:05 +0000
Subject: [Koha-bugs] [Bug 26392] Wrap all translatable strings in
opac-main.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #43 from Katrin Fischer ---
I feel like this might be better as "in discussion", but it should really be
discussed.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 18:14:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 16:14:20 +0000
Subject: [Koha-bugs] [Bug 27837] Permanent location is reverted to location
when location updated and permanent_location mapped to MARC field
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
--- Comment #21 from Katrin Fischer ---
I've tested, QA script and unit tests pass.
Also the following test plan checks out:
Test plan:
1 - Map permanent_location to a marc field
2 - Expose that field in the item editor
3 - Edit an item, changing location to X and permanent location to Y, save
4 - confirm record shows location=x, permanent_location=y
5 - Edit item again, change location to Z, do not change permanent location,
save
6 - confirm location and permanent_location both equal Z
7 - apply patch, restart
8 - repeat steps 3-5
9 - confirm location=Z, permanent location=Y
10 - prove t/db_dependent/Items.t
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 18:16:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 16:16:30 +0000
Subject: [Koha-bugs] [Bug 27837] Permanent location is reverted to location
when location updated and permanent_location mapped to MARC field
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 18:16:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 16:16:34 +0000
Subject: [Koha-bugs] [Bug 27837] Permanent location is reverted to location
when location updated and permanent_location mapped to MARC field
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #117728|0 |1
is obsolete| |
--- Comment #22 from Katrin Fischer ---
Created attachment 120361
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120361&action=edit
Bug 27837: Update permanent location if passed into ModItemFromMarc
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Rhonda Kuiper
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 18:16:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 16:16:40 +0000
Subject: [Koha-bugs] [Bug 27837] Permanent location is reverted to location
when location updated and permanent_location mapped to MARC field
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #117729|0 |1
is obsolete| |
--- Comment #23 from Katrin Fischer ---
Created attachment 120362
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120362&action=edit
Bug 27837: Add unit tests
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Rhonda Kuiper
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 18:16:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 16:16:46 +0000
Subject: [Koha-bugs] [Bug 27837] Permanent location is reverted to location
when location updated and permanent_location mapped to MARC field
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #117730|0 |1
is obsolete| |
--- Comment #24 from Katrin Fischer ---
Created attachment 120363
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120363&action=edit
Bug 27837: Prevent the tests to fail is the field is mapped
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 18:16:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 16:16:51 +0000
Subject: [Koha-bugs] [Bug 27837] Permanent location is reverted to location
when location updated and permanent_location mapped to MARC field
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #117738|0 |1
is obsolete| |
--- Comment #25 from Katrin Fischer ---
Created attachment 120364
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120364&action=edit
Bug 27837: Permanent location to be empty string, check if key exists
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 18:20:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 16:20:12 +0000
Subject: [Koha-bugs] [Bug 27837] Permanent location is reverted to location
when location updated and permanent_location mapped to MARC field
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Failed QA
--- Comment #26 from Katrin Fischer ---
(In reply to Jonathan Druart from comment #20)
> Can you explain this follow-up, Kyle?
> What's the use case, how did you find it?
> We certainly need a couple of tests to cover it.
I read this as that we need 2 more unit tests that cover some more cases?
Setting to failed QA to alert Kyle.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun May 2 18:21:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 16:21:57 +0000
Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from
items_last_borrower
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Patch doesn't apply
--- Comment #102 from Katrin Fischer ---
I am sorry, this patch set no longer applies and I can't fix it:
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 23260: Make borrowernumber nullable in items_last_borrower
Applying: Bug 23260: Inline code to anonymise_issue_history
Applying: Bug 23260: Simplify tests
Applying: Bug 23260: (follow-up) Remove last_borrower updates from issues count
Applying: Bug 23260: Add a new test
Applying: Bug 23260: Proposed preference driven filtering
Applying: Bug 23260: (follow-up) Add AnonymiseLastBorrower and
AnonymiseLastBorrowerDays sysprefs
Applying: Bug 23260: (follow-up) Update test
error: sha1 information is lacking or useless (t/db_dependent/Koha/Patrons.t).
error: could not build fake ancestor
Patch failed at 0001 Bug 23260: (follow-up) Update test
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-23260-follow-up-Update-test-oyzp2x.patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 01:11:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 23:11:22 +0000
Subject: [Koha-bugs] [Bug 28189] Move the base swagger file to YAML
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28189
--- Comment #9 from David Cook ---
I'm not sure I'm following the flow but I'm guessing Jonathan was referring to
th swagger.json line in the fallback section?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 01:16:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 23:16:14 +0000
Subject: [Koha-bugs] [Bug 27844] koha-worker systemd service should run as
%i-koha in package install
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27844
--- Comment #8 from David Cook ---
Bizarre. I'm probably not going to look at this again any time soon, so you
might want to try a non-containerized Docker environment.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 01:21:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 23:21:28 +0000
Subject: [Koha-bugs] [Bug 28276] Do not fetch config ($KOHA_CONF) from
memcached
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28276
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 01:25:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 23:25:39 +0000
Subject: [Koha-bugs] [Bug 28189] Move the base swagger file to YAML
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28189
--- Comment #10 from Tomás Cohen Arazi ---
(In reply to David Cook from comment #9)
> I'm not sure I'm following the flow but I'm guessing Jonathan was referring
> to th swagger.json line in the fallback section?
Yes, it was a busy Friday. Will fix it tomorrow.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 01:59:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 May 2021 23:59:50 +0000
Subject: [Koha-bugs] [Bug 28277] New: MARCOrgCode has bad default value
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28277
Bug ID: 28277
Summary: MARCOrgCode has bad default value
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs at lists.koha-community.org
Reporter: dcook at prosentient.com.au
QA Contact: testopia at bugs.koha-community.org
Apparently, for Koha's recorded history, MARCOrgCode has always defaulted to
OSt. (See commit f8e9fb6445dadbdef91e13a253c9c6bcb75e0eec)
I never really thought about it too much but I just took a look at
https://www.loc.gov/marc/organizations/org-search.php and OSt is "Stow Public
Library" in Ohio in the USA.
Really we should default to an empty/blank value rather than a wrong value.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 02:00:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 00:00:02 +0000
Subject: [Koha-bugs] [Bug 28277] MARCOrgCode has an incorrect default value
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28277
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|MARCOrgCode has bad default |MARCOrgCode has an
|value |incorrect default value
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 02:05:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 00:05:22 +0000
Subject: [Koha-bugs] [Bug 28277] MARCOrgCode has an incorrect default value
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28277
--- Comment #1 from David Cook ---
It's kind of interesting seeing how many Koha libraries around the world have a
003 of OSt...
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 02:40:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 00:40:00 +0000
Subject: [Koha-bugs] [Bug 28277] MARCOrgCode has an incorrect default value
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28277
--- Comment #2 from David Cook ---
Likewise the DEFAULT framework should not have 003 as mandatory...
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 03:32:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 01:32:35 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same
record in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #117131|0 |1
is obsolete| |
--- Comment #250 from David Cook ---
Created attachment 120365
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120365&action=edit
Bug 15565: Koha::Biblio->allowed_holds and tests
Signed-off-by: David Cook
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 03:32:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 01:32:44 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same
record in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #117132|0 |1
is obsolete| |
--- Comment #251 from David Cook ---
Created attachment 120366
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120366&action=edit
Bug 15565: Place multiple holds on one record on staff client
Test plan:
1) Apply patch and restart services
2) Set the maxreserves system preference to 3
3) Set the following circulation rules:
holds allowed (total) = 10
holds allowed (daily) = 10
holds per record (count) = 10
3) Set up a record with 4 items
4) Go to place a hold on this record
5) Notice that the items table under 'Place a hold on a specific item'
now uses checkboxes instead of radio buttons
6) Check all 4 checkboxes. Confirm that when you check the 4th checkbox,
an alert pops up warning the you've reached the maximum. Confirm
that when you close the alert, the checkbox unchecks itself.
7) Try setting different values for the above circulation rules that are
lower than the number of items on this record. Confirm the alert pops up
as expected.
8) Set the circulation rules and syspref all to 4+. Check some items and
confirm the holds.
9) Confirm that item-level holds are placed on all selected items.
Sponsored-by: Catalyst IT
Signed-off-by: David Cook
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 03:32:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 01:32:52 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same
record in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #117133|0 |1
is obsolete| |
--- Comment #252 from David Cook ---
Created attachment 120367
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120367&action=edit
Bug 15565: Place multiple holds on one record on OPAC
Test plan:
1) Apply patch and restart services
2) Set the maxreserves system preference to 3
3) Set the following circulation rules:
holds allowed (total) = 10
holds allowed (daily) = 10
holds per record (count) = 10
3) Set up a record with 4 items
4) Go to place a hold on this record
5) Notice that the items table under 'Place a hold on a specific item'
now uses checkboxes instead of radio buttons
6) Check all 4 checkboxes. Confirm that when you check the 4th checkbox,
an alert pops up warning the you've reached the maximum. Confirm
that when you close the alert, the checkbox unchecks itself.
7) Try setting different values for the above circulation rules that are
lower than the number of items on this record. Confirm the alert pops up
as expected.
8) Set the circulation rules and syspref all to 4+. Check some items and
confirm the holds.
9) Confirm that item-level holds are placed on all selected items.
Sponsored-by: Catalyst IT
Signed-off-by: David Cook
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 03:33:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 01:33:59 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same
record in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #253 from David Cook ---
Slightly updated test plan. Everything is working well in koha-testing-docker.
Test plan:
0) git bz apply 15565
1) restart_all
2) Set the maxreserves system preference to 3 (from 50)
3) Set the following circulation rules:
holds allowed (total) = 10 (from unlimited)
holds allowed (daily) = 10 (from unlimited)
holds per record (count) = 10 (from 2)
3) Set up a record with 4 items
E.g. add 3 items to
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29
4) Go to place a hold on this record in Staff Interface
5) Notice that the items table under 'Place a hold on a specific item'
now uses checkboxes instead of radio buttons
6) Check all 4 checkboxes. Confirm that when you check the 4th checkbox,
an alert pops up warning the you've reached the maximum. Confirm
that when you close the alert, the checkbox is not checked.
7) Set the following circulation rules:
holds allowed (total) = 2 (from 10)
holds allowed (daily) = 2 (from 10)
holds per record (count) = 2 (from 10)
8) Perform the same above actions on the OPAC
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 03:53:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 01:53:39 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
item from a group of titles
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
--- Comment #300 from David Cook ---
The patch works as expected using the following test plan.
My test plan:
0a. Apply the patch
0b. perl ./installer/data/mysql/updatedatabase.pl
0c. perl misc/devel/update_dbix_class_files.pl --koha-conf
/etc/koha/sites/kohadev/koha-conf.xml
0d. restart_all
1. Go to intranet search, display some results, click on some checkboxes
and click on 'Place hold' button at the top of the results.
(e.g. http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test)
2. Search for a patron
3. Check the 'Treat as hold group' checkbox
4. Click on 'Place hold'
5. In the next screen you should see all the holds you placed with the
additional text '(part of a hold group)' in Details column.
6. Click on the "hold group" link. A modal window should appear with
the content of the hold group (a list of holds)
7. Check in an item of one of the reserved biblios and confirm the hold
(e.g. Check in 39999000001310 )
8. The hold status is changed to Waiting, and all other holds are deleted.
Note: the "hold group" link is displayed in the following pages:
- reserve/request.pl
- circ/circulation.pl
- members/moremember.pl
- circ/pendingreserves.pl
Note: A hold group is counted as only one hold
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 03:54:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 01:54:51 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
item from a group of titles
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #118350|0 |1
is obsolete| |
--- Comment #301 from David Cook ---
Created attachment 120368
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120368&action=edit
Bug 15516: Database and installer updates
Signed-off-by: Michal Denar
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 03:54:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 01:54:59 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
item from a group of titles
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #118351|0 |1
is obsolete| |
--- Comment #302 from David Cook ---
Created attachment 120369
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120369&action=edit
Bug 15516: Relevant controller changes and tests
Signed-off-by: Michal Denar
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 03:55:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 01:55:08 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
item from a group of titles
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #118352|0 |1
is obsolete| |
--- Comment #303 from David Cook ---
Created attachment 120370
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120370&action=edit
Bug 15516: Allow to reserve first available item from a group of titles
It can be useful, for instance, if a library has the same title from
different publishers (so 1 title but several biblio records) but the
user only wants a copy of the book, regardless of the publisher.
This feature only applies to the staff client.
Test plan:
0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl
1. Go to intranet search, display some results, click on some checkboxes
and click on 'Place hold' button at the top of the results.
2. Search for a patron
3. Check the 'Treat as hold group' checkbox
4. Click on 'Place hold'
5. In the next screen you should see all the holds you placed with the
additional text '(part of a hold group)' in Details column.
6. Click on the "hold group" link. A modal window should appear with
the content of the hold group (a list of holds)
7. Check in an item of one of the reserved biblios and confirm the hold
8. The hold status is changed to Waiting, and all other holds are deleted.
Note: the "hold group" link is displayed in the following pages:
- reserve/request.pl
- circ/circulation.pl
- members/moremember.pl
- circ/pendingreserves.pl
Note: A hold group is counted as only one hold
Sponsored-by: Catalyst IT
Signed-off-by: Michal Denar
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 03:55:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 01:55:17 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
item from a group of titles
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #118353|0 |1
is obsolete| |
--- Comment #304 from David Cook ---
Created attachment 120371
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120371&action=edit
Bug 15516: Schema updates
Signed-off-by: Michal Denar
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 03:55:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 01:55:24 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
item from a group of titles
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #118354|0 |1
is obsolete| |
--- Comment #305 from David Cook ---
Created attachment 120372
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120372&action=edit
Bug 15516: (follow-up) Add hold group message to holds queue
A hold that is part of a hold group will be indicated as such in the
holds queue.
Signed-off-by: Michal Denar
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 03:55:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 01:55:33 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
item from a group of titles
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #118355|0 |1
is obsolete| |
--- Comment #306 from David Cook ---
Created attachment 120373
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120373&action=edit
Bug 15516: (follow-up) Remove other holds in hold_group from holds_queue
When one hold is fulfilled or set waiting
Signed-off-by: Michal Denar
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 03:56:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 01:56:20 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
item from a group of titles
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |dcook at prosentient.com.au
|y.org |
--- Comment #307 from David Cook ---
Rebased and works as expected with following test plan:
My test plan:
0a. Apply the patch
0b. perl ./installer/data/mysql/updatedatabase.pl
0c. perl misc/devel/update_dbix_class_files.pl --koha-conf
/etc/koha/sites/kohadev/koha-conf.xml
0d. restart_all
1. Go to intranet search, display some results, click on some checkboxes
and click on 'Place hold' button at the top of the results.
(e.g. http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test)
2. Search for a patron
3. Check the 'Treat as hold group' checkbox
4. Click on 'Place hold'
5. In the next screen you should see all the holds you placed with the
additional text '(part of a hold group)' in Details column.
6. Click on the "hold group" link. A modal window should appear with
the content of the hold group (a list of holds)
7. Check in an item of one of the reserved biblios and confirm the hold
(e.g. Check in 39999000001310 )
8. The hold status is changed to Waiting, and all other holds are deleted.
Note: the "hold group" link is displayed in the following pages:
- reserve/request.pl
- circ/circulation.pl
- members/moremember.pl
- circ/pendingreserves.pl
Note: A hold group is counted as only one hold
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 03:57:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 01:57:00 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
item from a group of titles
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
--- Comment #308 from David Cook ---
However, it's failing the QA test tools:
root at kohadevbox:koha(bug_15516)$ qa
testing 6 commit(s) (applied to 8fe090f 'e3 Bug 27864: (QA follow-up) Select2
')
Processing files before patches
Argument "" isn't numeric in numeric gt (>) at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
line 331.
|========================>| 27 / 27 (100.00%)
Processing files after patches
Argument "" isn't numeric in numeric gt (>) at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
line 331.
|========================>| 27 / 27 (100.00%)
OK C4/Reserves.pm
FAIL Koha/Hold.pm
FAIL critic
# Subroutines::ProhibitExplicitReturnUndef: Got 1 violation(s).
OK Koha/HoldGroup.pm
OK Koha/HoldGroups.pm
OK Koha/Holds.pm
FAIL Koha/Schema/Result/HoldGroup.pm
FAIL pod coverage
POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666
OK Koha/Schema/Result/OldReserve.pm
OK Koha/Schema/Result/Reserve.pm
OK circ/view_holdsqueue.pl
OK installer/data/mysql/kohastructure.sql
OK koha-tmpl/intranet-tmpl/prog/en/includes/hold-group-modal.inc
FAIL koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
FAIL filters
wrong_html_filter at line 181 (
)
OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
FAIL filters
wrong_html_filter at line 185 (
)
OK koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reserve/hold-group.tt
FAIL filters
missing_filter at line 23 (
[% hold.priority
%]
)
missing_filter at line 24 (
[%
hold.reservenotes %]
)
FAIL forbidden patterns
forbidden pattern: Title elements must start with the unique
information (bug 26703) (line 2)
OK koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
OK koha-tmpl/intranet-tmpl/prog/js/hold-group.js
OK koha-tmpl/intranet-tmpl/prog/js/holds.js
OK opac/opac-reserve.pl
FAIL reserve/hold-group.pl
FAIL critic
Subroutine "new" called using indirect syntax at line 25,
column 11. See page 349 of PBP.
FAIL file permissions
File must have the exec flag
FAIL forbidden patterns
forbidden pattern: Script permissions is authnotrequired => 0,
it could be correct for an OPAC script if it is was you really want error (bug
24663) (line 30)
OK reserve/placerequest.pl
OK reserve/request.pl
OK svc/holds
OK t/db_dependent/Koha/Holds.t
FAIL t/db_dependent/Reserves/HoldGroup.t
FAIL file permissions
File must have the exec flag
Processing additional checks OK!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 04:08:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 02:08:10 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
item from a group of titles
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #309 from David Cook ---
Code looks all right just looking at the diff, so I think fixing the QA test
tool failures should resolve things.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 06:13:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 04:13:29 +0000
Subject: [Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor
change for backwards compatibility
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200
--- Comment #9 from David Cook ---
If we are going to drop support for the abbreviated format, then we can update
this bug to just change the unit test and maybe print a warning in the release
notes or something.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 07:20:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 05:20:57 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
item from a group of titles
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
--- Comment #310 from David Cook ---
Comment on attachment 120368
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120368
Bug 15516: Database and installer updates
Review of attachment 120368:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15516&attachment=120368)
-----------------------------------------------------------------
::: installer/data/mysql/kohastructure.sql
@@ +4350,3 @@
> CONSTRAINT `reserves_ibfk_4` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE,
> CONSTRAINT `reserves_ibfk_5` FOREIGN KEY (`itemtype`) REFERENCES `itemtypes` (`itemtype`) ON DELETE CASCADE ON UPDATE CASCADE,
> CONSTRAINT `reserves_ibfk_6` FOREIGN KEY (`desk_id`) REFERENCES `desks` (`desk_id`) ON DELETE SET NULL ON UPDATE CASCADE
There is a missing comma here which causes this error:
Something went wrong loading file
/kohadevbox/koha/installer/data/mysql/kohastructure.sql ([SQL ERROR]: CREATE
TABLE `reserves` (
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 08:04:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 06:04:40 +0000
Subject: [Koha-bugs] [Bug 21249] Syspref to choose whether to search
homebranch, holding branch or both for library groups in advanced search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #36 from David Cook ---
"home library and holding library" doesn't work for individual libraries.
It's generating the following PQF:
@attrset Bib-1 @or @and @attr 1=8023 @attr 4=6 @attr 5=1 @attr 2=102
39999000001310 @attr 1=homebranch CPL @attr 1=8012 CPL
The Library Group option generates the following which is correct:
@attrset Bib-1 @and @attr 1=8023 @attr 4=6 @attr 5=1 @attr 2=102 39999000001310
@or @attr 1=homebranch CPL @attr 1=8012 CPL
The key is the parentheses in your query.
For the group you're doing this:
"(%s or %s)"
For the individual you're doing this:
"$homebranchlimit or $holdingbranchlimit"
If you change that last one to the following it should work:
"($homebranchlimit or $holdingbranchlimit)"
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 08:40:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 06:40:22 +0000
Subject: [Koha-bugs] [Bug 19237] PERSO_NAME authority file ignores first
indicator value of new headings saved
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19237
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |WORKSFORME
Status|NEW |RESOLVED
CC| |dcook at prosentient.com.au
--- Comment #4 from David Cook ---
Indicator 1 for PERSO_NAME is being imported correctly in master.
I'm going to mark this as invalid unless someone indicates a current supported
version that has this problem.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 08:43:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 06:43:07 +0000
Subject: [Koha-bugs] [Bug 19236] UNIF_TITLE authority ignores 2nd indicator
value for all new headings saved
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19236
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
Resolution|--- |WORKSFORME
Status|NEW |RESOLVED
--- Comment #2 from David Cook ---
I thought I was having this problem in 19.11 but I can't reproduce it now, and
it's working fine in master.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 09:01:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 07:01:36 +0000
Subject: [Koha-bugs] [Bug 28278] New: Improve $KOHA_CONF parsing speed by
using XML::LibXML
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28278
Bug ID: 28278
Summary: Improve $KOHA_CONF parsing speed by using XML::LibXML
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: ASSIGNED
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: julian.maurice at biblibre.com
Reporter: julian.maurice at biblibre.com
QA Contact: testopia at bugs.koha-community.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 09:03:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 07:03:12 +0000
Subject: [Koha-bugs] [Bug 28278] Improve $KOHA_CONF parsing speed by using
XML::LibXML
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28278
--- Comment #1 from Julian Maurice ---
Created attachment 120374
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120374&action=edit
Bug 28278: Add unit test for Koha::Config::read_from_file
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 09:03:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 07:03:16 +0000
Subject: [Koha-bugs] [Bug 28278] Improve $KOHA_CONF parsing speed by using
XML::LibXML
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28278
--- Comment #2 from Julian Maurice ---
Created attachment 120375
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120375&action=edit
Bug 28278: Improve $KOHA_CONF parsing speed by using XML::LibXML
- Without the patch:
$ hyperfine --warmup 1 \
'perl -MKoha::Config -e "Koha::Config->read_from_file(\$ENV{KOHA_CONF}) for
(1..1000)"'
Time (mean ± σ): 3.585 s ± 0.018 s [User: 3.531 s, System: 0.049 s]
Range (min … max): 3.547 s … 3.612 s 10 runs
- With the patch:
$ hyperfine --warmup 1 \
'perl -MKoha::Config -e "Koha::Config->read_from_file(\$ENV{KOHA_CONF}) for
(1..1000)"'
Time (mean ± σ): 1.122 s ± 0.028 s [User: 1.104 s, System: 0.014 s]
Range (min … max): 1.095 s … 1.189 s 10 runs
Test plan:
1. Apply the first patch (the one with the unit tests) and make sure
tests pass: `prove t/Koha/Config.t`
2. Apply the rest of the patches and verify that tests still pass:
`prove t/Koha/Config.t`.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 09:03:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 07:03:26 +0000
Subject: [Koha-bugs] [Bug 28278] Improve $KOHA_CONF parsing speed by using
XML::LibXML
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28278
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 09:21:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 07:21:58 +0000
Subject: [Koha-bugs] [Bug 28268] Improve memory usage when indexing
authorities in Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28268
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
URL| |https://lists.katipo.co.nz/
| |pipermail/koha/2021-April/0
| |56140.html
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 09:57:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 07:57:44 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723
--- Comment #50 from Emmi Takkinen ---
Created attachment 120376
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120376&action=edit
Bug 14723: Use DATETIME instead DATE
Letters.t tests failed since time_queued didn't
include timecode. Use DATETIME when inserting
into message_queue.
To test prove t/db_dependent/Letters.t
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 09:57:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 07:57:55 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723
Emmi Takkinen changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 10:03:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 08:03:39 +0000
Subject: [Koha-bugs] [Bug 28179] Use a lightbox gallery to display the
images - detail page, staff interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Change sponsored?|Unsponsored |Sponsored
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 10:22:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 08:22:57 +0000
Subject: [Koha-bugs] [Bug 28278] Improve $KOHA_CONF parsing speed by using
XML::LibXML
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28278
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart+koha at gmail.
| |com
Blocks| |7170
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170
[Bug 7170] Remove use of XML::Simple
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 10:22:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 08:22:57 +0000
Subject: [Koha-bugs] [Bug 7170] Remove use of XML::Simple
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |28278
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28278
[Bug 28278] Improve $KOHA_CONF parsing speed by using XML::LibXML
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 10:26:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 08:26:34 +0000
Subject: [Koha-bugs] [Bug 28103] Barcode fails when adding item during order
receive
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28103
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Barcode fails when adding |Barcode fails when adding
|item during order receival |item during order receive
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:19:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:19:05 +0000
Subject: [Koha-bugs] [Bug 24147] Objects.t is failing randomly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24147
--- Comment #14 from Jonathan Druart ---
Again on U16 run 276 on Docker_6
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:23:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:23:38 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #24 from Jonathan Druart ---
(In reply to Victor Grousset/tuxayo from comment #23)
> > c. Confirm that non linked subfields are stored and displayed correctly
>
> - item edition list
> - MARC details
> - OPAC marc view
>
> Is that it?
This patch set is affecting the add item form only.
> > d. Try with a "more subfield" that is linked with an authorised value
> category
>
> what is a "more subfield"?
A subfield that is not mapped with a DB column (and so stored in
items.more_subfields_xml)
> > 3. Test barcode values
>
> just put a barcode and using it afterwards?
barcode generated by a plugin
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:36:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:36:49 +0000
Subject: [Koha-bugs] [Bug 28230] Renewing/Checking out record with AE or OE
letter in title can make Koha totally unfunctional
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28230
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_21_05_candidate |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:36:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:36:52 +0000
Subject: [Koha-bugs] [Bug 27566] CSS rule not applying to HTML select /
option - displays with serif font ignoring rules
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_21_05_candidate |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:41:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:41:03 +0000
Subject: [Koha-bugs] [Bug 28135] Replace use of input type number in
additem.js
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28135
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_21_05_candidate
CC| |jonathan.druart+koha at gmail.
| |com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:41:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:41:15 +0000
Subject: [Koha-bugs] [Bug 28134] Replace use of input type number in
onboarding templates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28134
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart+koha at gmail.
| |com
Keywords| |rel_21_05_candidate
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:42:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:42:18 +0000
Subject: [Koha-bugs] [Bug 25424] Document our exceptions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25424
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_21_05_candidate |
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:42:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:42:35 +0000
Subject: [Koha-bugs] [Bug 25412] [OMNIBUS] Enhance POD in Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25412
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_21_05_candidate |
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:43:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:43:57 +0000
Subject: [Koha-bugs] [Bug 24387] Rename News tool
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_21_05_candidate |rel_21_11_candidate
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:45:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:45:04 +0000
Subject: [Koha-bugs] [Bug 22890] Add a chronological changelog
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_21_05_candidate |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:45:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:45:17 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_21_05_candidate, |rel_21_11_candidate
|RM_priority |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:53:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:53:13 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:53:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:53:19 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #118087|0 |1
is obsolete| |
Attachment #118088|0 |1
is obsolete| |
Attachment #118089|0 |1
is obsolete| |
Attachment #118090|0 |1
is obsolete| |
Attachment #118091|0 |1
is obsolete| |
Attachment #118092|0 |1
is obsolete| |
Attachment #118093|0 |1
is obsolete| |
Attachment #118094|0 |1
is obsolete| |
Attachment #118095|0 |1
is obsolete| |
Attachment #118096|0 |1
is obsolete| |
Attachment #118097|0 |1
is obsolete| |
Attachment #118098|0 |1
is obsolete| |
Attachment #118099|0 |1
is obsolete| |
Attachment #118100|0 |1
is obsolete| |
Attachment #118101|0 |1
is obsolete| |
Attachment #118102|0 |1
is obsolete| |
Attachment #118103|0 |1
is obsolete| |
Attachment #118104|0 |1
is obsolete| |
Attachment #118105|0 |1
is obsolete| |
Attachment #118106|0 |1
is obsolete| |
--- Comment #171 from Jonathan Druart ---
Created attachment 120377
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120377&action=edit
Bug 22544: Move get_opac_new to Koha namespace
Signed-off-by: David Nind
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:53:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:53:26 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544
--- Comment #172 from Jonathan Druart ---
Created attachment 120378
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120378&action=edit
Bug 22544: Move get_opac_news to Koha namespace
Signed-off-by: David Nind
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:53:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:53:32 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544
--- Comment #173 from Jonathan Druart ---
Created attachment 120379
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120379&action=edit
Bug 22544: Move del_opac_new to Koha namespace
Signed-off-by: David Nind
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:53:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:53:38 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544
--- Comment #174 from Jonathan Druart ---
Created attachment 120380
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120380&action=edit
Bug 22544: Move upd_opac_new to Koha namespace
Signed-off-by: David Nind
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:53:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:53:44 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544
--- Comment #175 from Jonathan Druart ---
Created attachment 120381
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120381&action=edit
Bug 22544: Move add_opac_item to Koha namespace
Signed-off-by: David Nind
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:53:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:53:50 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544
--- Comment #176 from Jonathan Druart ---
Created attachment 120382
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120382&action=edit
Bug 22544: Move GetNewsToDisplay to Koha namespace
Signed-off-by: David Nind
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:53:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:53:52 +0000
Subject: [Koha-bugs] [Bug 22407] OMNIBUS: Use DBIC relations to fetch
related object rather than searching for the object
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22407
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_21_05_candidate |rel_21_11_candidate
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:53:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:53:56 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544
--- Comment #177 from Jonathan Druart ---
Created attachment 120383
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120383&action=edit
Bug 22544: Add tests
Signed-off-by: David Nind
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:54:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:54:02 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544
--- Comment #178 from Jonathan Druart ---
Created attachment 120384
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120384&action=edit
Bug 22544: Refactor searching of news items
Test plan:
1) Go to tools and define some news
2) Try different parameters, try to edit new items, and delete some
3) Go to all places where news are presented and ensure that there are
the right ones shown:
opac main page - based on language
opac righ column (formerly syspref OpacNavRight) - based on language
opac news rss feed
circulation slip (not quick slip)
intranet main page
4) run tests:
prove t/db_dependent/Koha/News.t
Signed-off-by: David Nind
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:54:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:54:08 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544
--- Comment #179 from Jonathan Druart ---
Created attachment 120385
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120385&action=edit
Bug 22544: (QA follow-up) Fix spelling
Signed-off-by: Josef Moravec
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:54:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:54:13 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544
--- Comment #180 from Jonathan Druart ---
Created attachment 120386
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120386&action=edit
Bug 22544: Update to current codebase
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:54:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:54:19 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544
--- Comment #181 from Jonathan Druart ---
Created attachment 120387
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120387&action=edit
Bug 22544: Update search_for_display to be able to take more types
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:54:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:54:25 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544
--- Comment #182 from Jonathan Druart ---
Created attachment 120388
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120388&action=edit
Bug 22544: Fix filtering by location on tools -> news management
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:54:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:54:31 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544
--- Comment #183 from Jonathan Druart ---
Created attachment 120389
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120389&action=edit
Bug 22544: Clarify documentation and change param 'type' to 'location'
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:54:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:54:37 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544
--- Comment #184 from Jonathan Druart ---
Created attachment 120390
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120390&action=edit
Bug 22544: Enhance exception description
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:54:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:54:44 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544
--- Comment #185 from Jonathan Druart ---
Created attachment 120391
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120391&action=edit
Bug 22544: Add default language value to KohaNews template plugin
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:54:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:54:51 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544
--- Comment #186 from Jonathan Druart ---
Created attachment 120392
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120392&action=edit
Bug 22544: Use template plugin for news author display
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:54:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:54:58 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544
--- Comment #187 from Jonathan Druart ---
Created attachment 120393
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120393&action=edit
Bug 22544: TT plugin should return hashref only if news exist
It restore the header and fix the RSS feeds (see comment 103)
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:55:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:55:05 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544
--- Comment #188 from Jonathan Druart ---
Created attachment 120394
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120394&action=edit
Bug 22544: Fix OpacLoginInstructions
Moved recently
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:55:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:55:11 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544
--- Comment #189 from Jonathan Druart ---
Created attachment 120395
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120395&action=edit
Bug 22544: Restore newdate and timestamp for slip notices
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:55:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:55:17 +0000
Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544
--- Comment #190 from Jonathan Druart ---
Created attachment 120396
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120396&action=edit
Bug 22544: fix count call - to squash
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:58:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:58:07 +0000
Subject: [Koha-bugs] [Bug 18984] Remove support for NORMARC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:58:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:58:29 +0000
Subject: [Koha-bugs] [Bug 18984] Remove support for NORMARC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #115514|0 |1
is obsolete| |
Attachment #115515|0 |1
is obsolete| |
--- Comment #4 from Jonathan Druart ---
Created attachment 120397
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120397&action=edit
Bug 18984: Remove NORMARC support
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:58:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:58:35 +0000
Subject: [Koha-bugs] [Bug 18984] Remove support for NORMARC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984
--- Comment #5 from Jonathan Druart ---
Created attachment 120398
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120398&action=edit
Bug 18984: Remove ES mapping for NORMARC
perl misc/search_tools/export_elasticsearch_mappings.pl >
admin/searchengine/elasticsearch/mappings.yaml
grep -v 'mandatory: ~' admin/searchengine/elasticsearch/mappings.yaml|grep -v
'opac: 1'|grep -v 'staff_client: 1'
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:58:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:58:49 +0000
Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke
syntax to Template Toolkit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_21_05_candidate |rel_21_11_candidate
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 11:59:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 09:59:11 +0000
Subject: [Koha-bugs] [Bug 18984] Remove support for NORMARC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_21_05_candidate |rel_21_11_candidate
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 12:02:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 10:02:25 +0000
Subject: [Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records
even when there is no need
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_21_05_candidate |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 12:08:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 10:08:08 +0000
Subject: [Koha-bugs] [Bug 26995] Drop column relationship from borrower
tables
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26995
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 12:08:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 10:08:12 +0000
Subject: [Koha-bugs] [Bug 26995] Drop column relationship from borrower
tables
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26995
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #115537|0 |1
is obsolete| |
Attachment #115538|0 |1
is obsolete| |
Attachment #115539|0 |1
is obsolete| |
--- Comment #8 from Jonathan Druart ---
Created attachment 120399
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120399&action=edit
Bug 26995: Drop column relationship from borrowers, deletedborrowers and
borrower_modifications tables
Bug 14570 added a borrower_relationships table but it didn't remove the
relationship column from the following tables:
- deletedborrowers
- borrowers
- borrower_modifications
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 12:08:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 10:08:16 +0000
Subject: [Koha-bugs] [Bug 26995] Drop column relationship from borrower
tables
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26995
--- Comment #9 from Jonathan Druart ---
Created attachment 120400
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120400&action=edit
Bug 26995: Remove references to relationship column
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 12:08:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 10:08:42 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_21_05_candidate |rel_21_11_candidate
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 12:13:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 10:13:25 +0000
Subject: [Koha-bugs] [Bug 12561] Omnibus: Deprecate non-XSLT detail and
result views
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_21_05_candidate |rel_21_11_candidate
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 12:14:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 10:14:09 +0000
Subject: [Koha-bugs] [Bug 24975] Refactor database translations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_21_05_candidate |rel_21_11_candidate
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 12:14:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 10:14:30 +0000
Subject: [Koha-bugs] [Bug 11426] Make HighlightOwnItemsOnOPAC work with XSLT
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11426
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_21_05_candidate |rel_21_11_candidate
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 12:28:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 10:28:48 +0000
Subject: [Koha-bugs] [Bug 28135] Replace use of input type number in
additem.js
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28135
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 12:36:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 10:36:14 +0000
Subject: [Koha-bugs] [Bug 26398] Credit and Debit types on creating a manual
credits and manual invoices are not translatable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398
Marjorie Barry-Vila changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |marjorie.barry-vila at collect
| |o.ca
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 12:36:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 10:36:28 +0000
Subject: [Koha-bugs] [Bug 26926] Omnibus: Update all occurrences of to apply ACC2 coding guideline
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|Academy |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 12:52:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 10:52:33 +0000
Subject: [Koha-bugs] [Bug 25325] ElasticSearch mapping export lacks
staff_client/opac fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25325
--- Comment #19 from Fridolin Somers ---
I say we should update mapping.yaml, it is a reference when starting to manage
Elasticsearch with files.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 12:53:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 10:53:00 +0000
Subject: [Koha-bugs] [Bug 28275] Cart in OPAC doesn't sent mails if surname
or firstname contains diacritics
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28275
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|20.11 |master
Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun
| |ity.org
--- Comment #1 from Owen Leonard ---
Confirmed in master.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 13:29:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 11:29:10 +0000
Subject: [Koha-bugs] [Bug 26587] detail.pl is very slow for records with
many items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587
Björn Nylén changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #120300|0 |1
is obsolete| |
--- Comment #12 from Björn Nylén ---
Created attachment 120401
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120401&action=edit
Cache authorised values in C4::Items::GetItemsInfo (corrected)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 13:30:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 11:30:18 +0000
Subject: [Koha-bugs] [Bug 26587] detail.pl is very slow for records with
many items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587
Björn Nylén changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #120311|0 |1
is obsolete| |
--- Comment #13 from Björn Nylén ---
Created attachment 120402
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120402&action=edit
Cache Koha::Library object in Branches template plugin (modified per sug.)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 13:40:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 11:40:39 +0000
Subject: [Koha-bugs] [Bug 26587] detail.pl is very slow for records with
many items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587
--- Comment #14 from Björn Nylén ---
(In reply to David Cook from comment #11)
> Hey Björn, have you tested these patches?
>
> I haven't tested them, but at a glance it looks like they contain errors.
>
> 1)
> For instance, in the first one, $av_cache doesn't look like it's declared
> anywhere. I think that will probably throw a fatal error (or at best a
> warning). You should be declaring that before the loop in GetItemsInfo.
>
> You're also using fairly deep hash structures which could break. For
> instance:
> $av_cache->{$data->{frameworkcode}}->{'items.stack'}->{$data->{stack}}-
> >{lib} = $data->{stack};
>
> If $data->{frameworkcode} or more likely $data->{stack} don't exist , then
> you're going to probably get a fatal error. You might want to wrap some of
> this cache code in a function with more checks/conditions in it.
>
> 2)
> I think that the second patch will generate either fatal errors or warnings
> as well since you're not testing for the existence of $self->{branches}
> before tyring $self->{branches}->{$branchcode}.
>
> You can either create $self->{branches} in a "sub new" function or just test
> for it first. Something like "$self->{branches} = {} unless
> $self->{branches}". Then You can test for $self->{branches}->{$branchcode}
> because you've initialized $self->{branches} as a hashref.
Yeah, I tested and developed in a separate repo and tried to just copy paste
the code to the one with Koha-master code and missed the variable declaration.
About GetItemsInfo:
Removed the deep hashes as they were unneccesary. (Framwork is the same for all
items in biblio) Autovivification should do the trick with the undefined
hash-keys but added them more explicitly. It's more obvious what's done that
way.The only warnings I got were the item-values that are NULL in the database
so I check for those.
Branches:
Added a "new" sub to init the cache in a more explicit manner. Autovivification
did it before but is a bit more obscure.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 14:59:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 12:59:44 +0000
Subject: [Koha-bugs] [Bug 26273] Expose cashup summary history for a cash
register
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273
--- Comment #59 from Tomás Cohen Arazi ---
Created attachment 120403
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120403&action=edit
Bug 28273: Unit tests
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 14:59:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 12:59:50 +0000
Subject: [Koha-bugs] [Bug 26273] Expose cashup summary history for a cash
register
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273
--- Comment #60 from Tomás Cohen Arazi ---
Created attachment 120404
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120404&action=edit
Bug 28273: Add Koha::Biblios->pickup_locations
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 15:00:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 13:00:47 +0000
Subject: [Koha-bugs] [Bug 28279] New: mappings.yaml no longer in sync
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28279
Bug ID: 28279
Summary: mappings.yaml no longer in sync
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: ASSIGNED
Severity: normal
Priority: P5 - low
Component: System Administration
Assignee: jonathan.druart+koha at gmail.com
Reporter: jonathan.druart+koha at gmail.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
Depends on: 19482, 27316, 20589, 25325
We are missing some changes in the mappings.yaml file:
* missing staff_client/opac (bug 25325 and bug 20589)
* missing mandatory (bug 19482)
* sort (bug 27316) became a boolean field
Which means export_elasticsearch_mappings.pl generates a file that differs a
lot from the one we have in our codebase.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482
[Bug 19482] Elasticsearch - prevent removal / editing of required indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
[Bug 20589] Add field boosting and use elastic query fields parameter instead
of deprecated _all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25325
[Bug 25325] ElasticSearch mapping export lacks staff_client/opac fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316
[Bug 27316] In mappings use yes/no for sortable
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 15:00:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 13:00:47 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
of required indexes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |28279
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28279
[Bug 28279] mappings.yaml no longer in sync
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 15:00:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 13:00:47 +0000
Subject: [Koha-bugs] [Bug 27316] In mappings use yes/no for sortable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |28279
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28279
[Bug 28279] mappings.yaml no longer in sync
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 15:00:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 13:00:47 +0000
Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query
fields parameter instead of deprecated _all
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |28279
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28279
[Bug 28279] mappings.yaml no longer in sync
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 15:00:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 13:00:47 +0000
Subject: [Koha-bugs] [Bug 25325] ElasticSearch mapping export lacks
staff_client/opac fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25325
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |28279
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28279
[Bug 28279] mappings.yaml no longer in sync
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 15:06:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 13:06:08 +0000
Subject: [Koha-bugs] [Bug 27856] Update mappings.yaml after bug 27316
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27856
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|27316 |
Status|Passed QA |RESOLVED
Resolution|--- |DUPLICATE
--- Comment #8 from Jonathan Druart ---
*** This bug has been marked as a duplicate of bug 28279 ***
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316
[Bug 27316] In mappings use yes/no for sortable
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 15:06:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 13:06:08 +0000
Subject: [Koha-bugs] [Bug 28279] mappings.yaml no longer in sync
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28279
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #1 from Jonathan Druart ---
*** Bug 27856 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 15:06:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 13:06:08 +0000
Subject: [Koha-bugs] [Bug 27316] In mappings use yes/no for sortable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|27856 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27856
[Bug 27856] Update mappings.yaml after bug 27316
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 15:06:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 13:06:42 +0000
Subject: [Koha-bugs] [Bug 28279] mappings.yaml no longer in sync
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28279
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 15:06:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 13:06:47 +0000
Subject: [Koha-bugs] [Bug 28279] mappings.yaml no longer in sync
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28279
--- Comment #2 from Jonathan Druart ---
Created attachment 120405
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120405&action=edit
Bug 28279: Re-sync mappings.yaml
We are missing some changes in the mappings.yaml file:
* missing staff_client/opac (bug 25325 and bug 20589)
* missing mandatory (bug 19482)
* sort (bug 27316) became a boolean field
Which means export_elasticsearch_mappings.pl generates a file that differs a
lot from the one we have in our codebase.
There are also indentation changes certainly caused by the replacement
of YAML with YAML::XS
Test plan:
1. reset_all without this patch
2. export the mappings to a non-tracked file (ie. don't erate
mappings.yaml from source)
3. Apply this patch
4. Compare both file
=> No change expected
5. Reset the mappings (so using the mappings.yaml after the changes from
this patch)
6. Compare the tables on the UI (with and without the patch applied)
=> No change expected
QA will use --word-diff to make sure only mandatory, sort and
staff_client/opac are modified
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon May 3 15:10:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 May 2021 13:10:02 +0000
Subject: [Koha-bugs] [Bug 25885] Show list of hits for one search result
In-Reply-To: