[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #308 from David Cook <dcook at prosentient.com.au> ---
However, it's failing the QA test tools:

root at kohadevbox:koha(bug_15516)$ qa
testing 6 commit(s) (applied to 8fe090f 'e3 Bug 27864: (QA follow-up) Select2
')

Processing files before patches
Argument "" isn't numeric in numeric gt (>) at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
line 331.
|========================>| 27 / 27 (100.00%)
Processing files after patches
Argument "" isn't numeric in numeric gt (>) at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
line 331.
|========================>| 27 / 27 (100.00%)

 OK     C4/Reserves.pm
 FAIL   Koha/Hold.pm
   FAIL   critic
                # Subroutines::ProhibitExplicitReturnUndef: Got 1 violation(s).

 OK     Koha/HoldGroup.pm
 OK     Koha/HoldGroups.pm
 OK     Koha/Holds.pm
 FAIL   Koha/Schema/Result/HoldGroup.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666

 OK     Koha/Schema/Result/OldReserve.pm
 OK     Koha/Schema/Result/Reserve.pm
 OK     circ/view_holdsqueue.pl
 OK     installer/data/mysql/kohastructure.sql
 OK     koha-tmpl/intranet-tmpl/prog/en/includes/hold-group-modal.inc
 FAIL   koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
   FAIL   filters
                wrong_html_filter at line 181 (                    <div>(part
of a <a href="/cgi-bin/koha/reserve/hold-group.pl?hold_group_id=[%
hold.hold_group_id %]" class="hold-group">hold group</a>)</div>)
                missing_filter at line 181 (                    <div>(part of a
<a href="/cgi-bin/koha/reserve/hold-group.pl?hold_group_id=[%
hold.hold_group_id %]" class="hold-group">hold group</a>)</div>)

 OK     koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
 OK     koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
   FAIL   filters
                wrong_html_filter at line 185 (                    <div>(part
of a <a href="/cgi-bin/koha/reserve/hold-group.pl?hold_group_id=[%
itemsloo.hold_group_id %]" class="hold-group">hold group</a>)</div>)
                missing_filter at line 185 (                    <div>(part of a
<a href="/cgi-bin/koha/reserve/hold-group.pl?hold_group_id=[%
itemsloo.hold_group_id %]" class="hold-group">hold group</a>)</div>)

 OK     koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/reserve/hold-group.tt
   FAIL   filters
                missing_filter at line 23 (              <td>[% hold.priority
%]</td>)
                missing_filter at line 24 (              <td>[%
hold.reservenotes %]</td>)
   FAIL   forbidden patterns
                forbidden pattern: Title elements must start with the unique
information (bug 26703) (line 2)

 OK     koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
 OK     koha-tmpl/intranet-tmpl/prog/js/hold-group.js
 OK     koha-tmpl/intranet-tmpl/prog/js/holds.js
 OK     opac/opac-reserve.pl
 FAIL   reserve/hold-group.pl
   FAIL   critic
                Subroutine "new" called using indirect syntax at line 25,
column 11. See page 349 of PBP.
   FAIL   file permissions
                File must have the exec flag
   FAIL   forbidden patterns
                forbidden pattern: Script permissions is authnotrequired => 0,
it could be correct for an OPAC script if it is was you really want error (bug
24663) (line 30)

 OK     reserve/placerequest.pl
 OK     reserve/request.pl
 OK     svc/holds
 OK     t/db_dependent/Koha/Holds.t
 FAIL   t/db_dependent/Reserves/HoldGroup.t
   FAIL   file permissions
                File must have the exec flag


Processing additional checks OK!

-- 
You are receiving this mail because:
You are watching all bug changes.