[Koha-bugs] [Bug 27944] Add new stages to the article request process

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #119022|0                           |1
        is obsolete|                            |

--- Comment #5 from Agustín Moyano <agustinmoyano at theke.io> ---
Hi Marcel, I'll reply between lines

(In reply to Marcel de Rooy from comment #4)
> Hi Augustin,
> 
> I have some questions here:
> 
> The tab is called Requested, but since all entries are requests, wouldnt it
> be more logical to call it New ?

I'll change it right away. For me "new" sounded like it was recently created,
but I thought you may have old unprocessed requests, so in that context it
seemed reasonable to call it "requested".

> 
> If I pick a request to process, it would be handy to move it to Processing
> immediately from the New tab? Instead of an additional move thru Pending.

I wasn't told that was allowed, but it can be added.

> 
> Can you explain the mail for a move to Pending? Since the patron gets an
> email when he submitted the request and will have an email when we hit
> Processing, does this mail saying 'We are doing nothing yet' make him happy
> :) ?
> 

I believe it's better to give as much feedback to patrons as we can.. Even if
that message means "Your request was moved from the drawer of the left, to the
drawer on the right". It might save the librarian a call like "what happend
with my request"

> Please run qa tools. I see this failure:
>  FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt
>    FAIL   valid_template
>                 Attempt to reload Koha/Template/Plugin/Biblio.pm aborted.
> Compilation failed in require at
> /usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Plugins.pm line 206.
> => Is this related to biblio-view-menu.inc ?

I believe it's a bug in qa tools, but I really got no idea why this error
appears. I'll check it out once more

--- Comment #6 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 120454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120454&action=edit
Bug 27944: Add "requested" stage in article request process

This patch adds the stage "requested" in article request process, which
is previous to pending stage.

To test:
1. apply this patch
2. updatedatabase
3. enable ArticleRequests syspref
4. from staff inteface and from opac search for a record and place an
   article request
5. koha-mysql kohadev
6. query: select subject, content, letter_code from message_queue;
CHECK => There is a message for each article request with code
AR_REQUESTED
      => In opac-user.pl, in "Article requests" tab you should see a row
in the table with "Requested" status
5. in staff go to Circulation -> Article Requests
SUCCESS => You should see 3 tabs, one for Requested stage (with two
requests), one for Pending stage and one for Processing stage.
6. play with actions buttons
CHECK => you should see a new action called "Set request as pending"
SUCCESS => All action buttons behave as expected, and tab counts updates
correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.