[Koha-bugs] [Bug 28286] New: Place hold button not displayed when biblio has only Ordered items

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28286

            Bug ID: 28286
           Summary: Place hold button not displayed when biblio has only
                    Ordered items
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: joonas.kylmala at helsinki.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, nugged at gmail.com,
                    stalkernoid at gmail.com

The "Place hold" button doesn't show up if there are only Ordered items, but it
should since it is possible to place a hold for Ordered item. To reproduce go
to /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX and add first 1 item with
notforloan = 0 and notice the "Place hold" button shows, then change the
notforloan value to -1 / Ordered and notice the hold button disappears.

The bug happens because in 

koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc

we decide whether to show the button based on if there are loanable items and
not holdable items:

>     [% IF Context.Scalar(Context.Scalar(items, "filter_by_for_loan"), "count") %]

The call here should be changed to "filter_by_for_hold" in order to fix the
issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.