[Koha-bugs] [Bug 28276] Do not fetch config ($KOHA_CONF) from memcached

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28276

--- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
(In reply to Julian Maurice from comment #3)
> You probably added the warn too early. It should be just after getting the
> parameters:
> my ($class, $file) = @_;
> warn "read_from_file($file)";

oops, how careless, now it's obvious ^^"
thanks :)

> You should see it once per worker. I see that there are two "read_from_file"
> in plack-error.log (after the patch). So if you have two workers that's
> normal.

Potential issue found, I added the following:
warn "######## read_from_file($file)" . "###" . int(rand(10000000)) . "######";
The rand to identify each unique call of the function.
Output with the patch:
============================== restart command ======================
Starting Z39.50/SRU daemon for kohadev:#################
read_from_file(/etc/koha/sites/kohadev/koha-conf.xml)###9584085###### at
/kohadevbox/koha/Koha/Config.pm line 37.
=============================== all logs =============================
==> /var/log/koha/kohadev/plack-error.log <==
Starman: Accepting connections at
unix://localhost:/var/run/koha/kohadev/plack.sock/
#################
read_from_file(/etc/koha/sites/kohadev/koha-conf.xml)###6082019###### at
/kohadevbox/koha/Koha/Config.pm line 37.
#################
read_from_file(/etc/koha/sites/kohadev/koha-conf.xml)###9302336###### at
/kohadevbox/koha/Koha/Config.pm line 37.

==> /var/log/koha/kohadev/sip-output.log <==
#################
read_from_file(/etc/koha/sites/kohadev/koha-conf.xml)###3475587###### at
/kohadevbox/koha/Koha/Config.pm line 37.

==> /var/log/koha/kohadev/indexer-output.log <==
#################
read_from_file(/etc/koha/sites/kohadev/koha-conf.xml)###5666078###### at
/kohadevbox/koha/Koha/Config.pm line 37.

==> /var/log/koha/kohadev/worker-output.log <==
#################
read_from_file(/etc/koha/sites/kohadev/koha-conf.xml)###488901###### at
/kohadevbox/koha/Koha/Config.pm line 37.

There are two for plack, one per worker. But are the other calls expected?
And the one in the restart_all output?


> Please make sure there are no "read_from_file" after startup, when you use
> koha web interface.

Selenium tests didn't show calls to read_from_file in the logs.
Though the call to prove did but I guess it's because the test code load Koha
stuff right?
https://paste.chapril.org/?39fdfda86050ed4c#8zBSp79ACPT6PRs29DKGzR4QbB3HWH9ycqxs2b9BXGiv

Then I messed a bit with the OPAC, I can't reproduce how that happended but I
ended up doing this query:
http://localhost:8080/opac-search.pl?idx=&q=test&weight_search=1
Which calls read_from_file.
I guess it's not an issue since not having cgi-bin/koha is expected to change
stuff.
The real issue would how did I end up with such an URL, which I didn't find.

-- 
You are receiving this mail because:
You are watching all bug changes.