[Koha-bugs] [Bug 28291] koha-translate install script producing incorrectly encoded YAML translation files

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28291

--- Comment #1 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
Created attachment 120532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120532&action=edit
Bug 28291: Make koha-translate script produce valid UTF-8 YAML files

We had two problems in the LangInstaller.pm module:
 1) the PO file was read as bytes instead of as a UTF-8 text stream
 2) The YAML file being outputted was double encoded, once by setting
    the file handle to output UTF-8 and other time in the DumpFile
    function internally

To test:
1. Before applying patch do the following
$ cd misc/translator
$ ./translate update pl-PL
$ ./translate install pl-PL
$ cd -
$ less
installer/data/mysql/pl-PL/marcflavour/marc21/mandatory/authorities_normal_marc21.yml
2. Notice the output of the authorities_normal_marc21.yml contains
invalid looking UTF-8 characters
3. $ git clean -d -f # to remove the old translation files
4. Apply patch and repeat the steps and notice the
authorities_normal_marc21.yml contains valid looking UTF-8 characters

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.