[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #313 from David Cook <dcook at prosentient.com.au> ---
Still failing the QA tools.

I think the pod coverage one can be ignored, as I think that's a QA tool bug.

You do need to "chmod +x reserve/hold-group.pl
t/db_dependent/Reserves/HoldGroup.t".

And it looks like the <title> elements needs to be ordered specific to general.
I recall that being a fairly recent requirement:
https://wiki.koha-community.org/wiki/Coding_Guidelines#ACC3:_Title_elements_should_contain_unique_information_information_first

root at kohadevbox:koha(bug_15516)$ qa
testing 7 commit(s) (applied to 640ba47 'cf Bug 28288: Prevent XSISBN.t to
fai')

Processing files before patches
Argument "" isn't numeric in numeric gt (>) at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
line 331.
|========================>| 27 / 27 (100.00%)
Processing files after patches
Argument "" isn't numeric in numeric gt (>) at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
line 331.
|========================>| 27 / 27 (100.00%)

 OK     C4/Reserves.pm
 OK     Koha/Hold.pm
 OK     Koha/HoldGroup.pm
 OK     Koha/HoldGroups.pm
 OK     Koha/Holds.pm
 FAIL   Koha/Schema/Result/HoldGroup.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666

 OK     Koha/Schema/Result/OldReserve.pm
 OK     Koha/Schema/Result/Reserve.pm
 OK     circ/view_holdsqueue.pl
 OK     installer/data/mysql/kohastructure.sql
 OK     koha-tmpl/intranet-tmpl/prog/en/includes/hold-group-modal.inc
 OK     koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
 OK     koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
 OK     koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt
 OK     koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
 OK     koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/reserve/hold-group.tt
   FAIL   forbidden patterns
                forbidden pattern: Title elements must start with the unique
information (bug 26703) (line 2)

 OK     koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
 OK     koha-tmpl/intranet-tmpl/prog/js/hold-group.js
 OK     koha-tmpl/intranet-tmpl/prog/js/holds.js
 OK     opac/opac-reserve.pl
 FAIL   reserve/hold-group.pl
   FAIL   file permissions
                File must have the exec flag

 OK     reserve/placerequest.pl
 OK     reserve/request.pl
 OK     svc/holds
 OK     t/db_dependent/Koha/Holds.t
 FAIL   t/db_dependent/Reserves/HoldGroup.t
   FAIL   file permissions
                File must have the exec flag


Processing additional checks OK!

-- 
You are receiving this mail because:
You are watching all bug changes.