[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #327 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #324)
> 1. See comment 321

Replied above

> 2. We don't hide the admin page if the pref is off, is that expected?

Whilst I agree with what you're saying here, I think if memory serves this was
discussed earlier in the bug and the authors wanted the ability to create their
rules and then enable them.. so they wanted to display the page regardless or
whether the pref was on or off (the page does warn you at the top if the pref
is off).. having said that.. I'd be happy to follow-up to change that.. or, in
my opinion in a later bug we could drop the pref and instead have an 'enabled'
flag at the rule level.

> 3. Should we link the pref to the admin page?

Not sure what you're saying here?

> 4. We need a wiki page, or at least more info/examples for the release notes.
> There is only 2 very succinct example in the test plan but the feature
> allows much more.

I agree, it took me a fair while to wrap my head around the rules.. I think a
wiki page would be great and would be happy to start one.

> 5. Can you explain me what this rule means?
> 
> | id | tag | module | filter   | add | append | remove | delete |
> |  1 | 12  | source | batchmod |   1 |      0 |      0 |      0 |

With 'batchmod', only add tag 12 is if exists only in the incoming record.

> 6. How does it interface with the marc modification templates when batch
> editing bibliographic records?

Investigating.. I have a feeling his patchset predates it and I missed this
case ! :(

-- 
You are receiving this mail because:
You are watching all bug changes.