[Koha-bugs] [Bug 23406] Authorized Value for Suppression when added to Frameworks doesn't show Suppress in Staff Client

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23406

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am sorry, but I don't believe this is a good solution. 
This will fail the second someone translates the authorised value (trust me, we
do that! :) )

Looking at this, I wonder if we should handle this differently:

We run into this issue because as soon as something is linked to an authorised
value, the code will be replaced by the description in the XSLT. And this
should not happen:

XSLT.pm (see bug 14377):

+  # Replace the field value with the authorised value *except* for
MARC21/NORMARC field 942$n (suppression in opac)
if ( !( $tag eq '942' && $subfield eq 'n' ) || $marcflavour eq 'UNIMARC' ) {
 $value = GetAuthorisedValueDesc( $tag, $letter, $value, '', $tagslib )

So even when linked to an authorised value, we should still be seeing a 1 and
the check should be working.

Please check why this is not working as expected.

I also feel like the depends on bug 26116 is wrong here - should be a blocks.

-- 
You are receiving this mail because:
You are watching all bug changes.