[Koha-bugs] [Bug 28308] New: Select 'Days in advance' = 0 for Advance notice effectively disables PREDUE notices

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28308

            Bug ID: 28308
           Summary: Select 'Days in advance' = 0 for Advance notice
                    effectively disables PREDUE notices
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Looking at the code below, it seems that on the day an item is due we will only
send the DUE notices, predues will not be sent

In the advance_notices.pl cron:
276     if ( 0 == $upcoming->{'days_until_due'} ) {
277         # This item is due today. Send an 'item due' message.
...
323     } else {
324         $borrower_preferences =
C4::Members::Messaging::GetMessagingPreferences( { borrowernumber =>
$upcoming->{'borrowernumber'},
325                                                                            
       message_name   => 'advance_notice' } );
326         next UPCOMINGITEM unless $borrower_preferences && exists
$borrower_preferences->{'days_in_advance'};
327         next UPCOMINGITEM unless $borrower_preferences->{'days_in_advance'}
== $upcoming->{'days_until_due'};

In this case, allowing the user to choose '0' is effectively disabling the
notice. 

I think we need to remove 0 as an option, and uncheck all transports for
patrons who have '0' set for days in advance

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.