[Koha-bugs] [Bug 28317] Remove CGI::Session::Serialize::yaml dependency by using the default serializer

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28317

--- Comment #26 from David Cook <dcook at prosentient.com.au> ---
(In reply to Julian Maurice from comment #24)
> (In reply to David Cook from comment #20)
> > I have third-party apps that can use Koha session data by parsing the YAML.
> > It looks like I'll have to think of something much more complicated to deal
> > with the change in serialization.
> It's not very complicated, you just have to use
> `CGI::Session::Serialize::default->thaw($session_data)`

My third-party apps neither use Perl nor have the capacity to use Perl, so
that's not an option :p. 

> > We could fork CGI::Session::Serialize::yaml and make a
> > CGI::Session::Serialize::Koha.
> > 
> > Ahhh CGI::Session::Serialize::yaml also has an undocumented feature. If you
> > look at the source code, you'll see that you can set
> > $CGI::Session::Serialize::yaml::Flavour to whatever YAML module you want
> > that can use Dump/Load methods. (Note that you'd have to preload it yourself
> > with 'use' or 'require'.)
> > 
> > So... it looks like CGI::Session::Serialize::yaml can work with YAML::XS.
> > 
> > Personally, it would be awesome if we could retain the use of
> > CGI::Session::Serialize::yaml. 
> If we really want to stick with YAML, I'd prefer Koha to have its own
> implementation rather than relying on an undocumented "feature" (from my
> point of view that is not a feature, this is just messing with a module's
> internal variables)

It's not an internal variable. It's a package variable. That's why they have
scoped it that way. Based on my conversations with the
CGI::Session::Serialize::yaml maintainer, we'll probably add a class method for
explicitly choosing the YAML implementation.

-- 
You are receiving this mail because:
You are watching all bug changes.