[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120953|0                           |1
        is obsolete|                            |

--- Comment #17 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 120954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120954&action=edit
Bug 26346: Add option to make public lists editable by all staff

If a staff member has access to the staff client (either because
'catalogue' permission is enabled or they're a superlibrarian
then that user can add items (from OPAC or staff client) to a list
marked 'Staff only'

Test plan:
1. In the staff client go to: Lists > 'New list'. Notice under 'Allow changes
to contents
from' there are three options: Nobody, Owner only, Anyone seeing this
list

2. Apply patch and run updatedatabase.pl
cd installer/data/mysql
sudo koha-shell <instance>
./updatedatabase.pl

3. Restart memcached and plack

4. Create a public list and select the new 'Staff only' option under
'Allow changes to contents from'

5. Log out of the staff client and log back in as a different user with
the 'Staff access, allows viewing of catalogue in staff interface
(catalogue)' permission enabled.

6. Navigate to the Lists module, and click on the name of the list you
created in #5

7. Select 'Add items' and enter an item barcode and submit

8. Notice the item has been added to the list

9. Search the catalogue in the staff client. Confirm you can add to the
list you created in #5 from both the search result page and biblio
record detail page

10. Confirm you can remove items from the list in the OPAC and staff
client

11. Login to the OPAC as the same user as #5

12. Perform an OPAC search, Select 'Save to lists' under a biblio
record, choose the list from #4 in 'Select a list' and save

13. Confirm in the staff client that the record from #11 has been added to the
list

14. Logout of OPAC and login again as a user which does not have 'Staff
access, allows viewing of catalogue in staff interface (catalogue)' or
superlibrarian enabled

15. Do a OPAC search, hit 'Save to lists' and notice you cannot add the
record to the list from #4

16. Run Patron.t and Virtualshelves.t unit tests:
sudo koha-shell <instance>
prove t/db_dependent/Koha/Patron.t
prove t/db_dependent/Virtualshelves.t

17. Login to the staff client as the same user as #5

18. Create a new list in the staff client, select 'Category'='Private',
    'Allow changes to contents from'='Staff only'

19. Notice 'The Staff only permission has no actual effect while this
list is strictly private' message hint is displayed

20. Change 'Category'='Public' and notice the hint is removed

21. Switch back to 'Category'='Private' and 'Allow changes to contents
from'='Anyone'

22. Notice the 'The Anyone permission has no actual effect while this
list is strictly private.' is displayed

23. Repeat steps 18-22 in the OPAC

24. Create a 'staff only' list in the OPAC and then login as a different
user with 'Staff access, allows viewing of catalogue in staff interface
(catalogue)' permission enabled. Confirm you are able to add items to
this new 'staff only' list.

25. Confirm that the 'Staff only' option is not available to
patrons with no special permissions when creating lists in the OPAC

Sponsored-by: Horowhenua District Council, New Zealand

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.