[Koha-bugs] [Bug 28369] additionalProperties missing in holds routes

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28369

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Joonas Kylmälä from comment #3)
> Could we please add first a deprecation notice and create the PATCH route in
> addition to the PUT instead of simply renaming the PUT? We have already code
> using this API (at least
> https://github.com/NatLibFi/NDL-VuFind2/blob/dev/module/Finna/src/Finna/ILS/
> Driver/KohaRest.php) and I'm thinking there might also other people using
> this API we are not aware of, so things might unexpectedly break on the next
> update if we simply remove the PUT method without any migration period.

Yes! Can certainly do!

But as I mentioned, the PUT route is using (in the code) different attribute
names than the API spec, so you need to check if it isn't broken already
(20.11). I couldn't find the references to the API routes on that PHP code.

-- 
You are receiving this mail because:
You are watching all bug changes.