[Koha-bugs] [Bug 28369] additionalProperties missing in holds routes
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Thu May 20 14:21:07 CEST 2021
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28369
--- Comment #18 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
Created attachment 121237
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121237&action=edit
Bug 28369: Set additionalProperties: false and fix things
This patch performs a cleanup on the holds routes:
- It adds additionalProperties: false to all missing routes
- It syncs the spec with the guidelines
- additionalProperties: false highlighted some attributes read in the
controlled weren't declared on the spec, adding them
- PUT /holds/:hold_id is moved to PATCH, as it makes more sense and
gathered opinions lean towards that
To test:
1. Apply the tests patch
2. Run:
$ kshell
k$ prove t/db_dependent/api/v1/holds.t
=> FAIL: Lots of things are wrong with the API
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list