[Koha-bugs] [Bug 28370] Routes still missing additionalProperties in spec

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri May 21 22:21:47 CEST 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28370

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 121286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121286&action=edit
Bug 28370: Rewrite tests

This patch rewrites the tests, and also doesn't enforce
additionalProperties to be false. We could need it, and there are routes
that need to be reviewed that would break otherwise now: error.json, for
example, is used everywhere, and some routes add some payload to it.

The main change this patch introduces is using the resolved spec instead
of finding each .json file, which wasn't even correct as we have .yaml
files already. Parameters and responses are tested.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove xt/api.t
=> SUCCESS: Tests fail! A nice report on the failures is printed

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list