[Koha-bugs] [Bug 28435] New: CanBookBeRenewed returns only a single status and falsely indicates renewal can be overridden

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28435

            Bug ID: 28435
           Summary: CanBookBeRenewed returns only a single status and
                    falsely indicates renewal can be overridden
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Similar to bug 22866 - depending on system settings you may or may not be able
to override a hold to renew an item.

For instance - if an item is on hold, and the renewal limit has been reached
CanBookBeRenewed returns 'TooMany'

Checking the 'Override renewal restrictions' button makes the hold appear
renewable.

Executing the renewal fails because of 'On hold'

Returning all status would allow us to sort which can be overridden and which
cannot, however, there would be a performance cost for patrons with many
checkouts.

We could also develop an API route to check when the override button is
checked, calculating if renewal is possible with override and only allowing the
checkbox if so.

Alternately, we could add a system preference to always return all statuses and
allow the library to choose performance vs completeness of response.

I am not sure the bets path and am filing this bug for discussion.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.