[Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Passed QA

--- Comment #37 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to David Cook from comment #35)
> (In reply to David Cook from comment #34)
> > This doesn't make sense to me.
> > 
> > It means that you need to have a sysadmin change a cronjob for ALL instances
> > if there's just 1 instance that wants to be able to use the system
> > preference "CleanUpDatabaseReturnClaims".
> 
> To me, that means a custom crontab for vendors, which is not nice from a
> management perspective.
> 
> And it means that people who rely on volunteers or shared sysadmins (or no
> sysadmins) can't get the functionality.

(In reply to David Cook from comment #34)
> Comment on attachment 120930 [details] [review]
> Bug 25429: Require command line switch to enable, control DAYS via syspref
> 
> Review of attachment 120930 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: misc/cronjobs/cleanup_database.pl
> @@ +532,4 @@
> >      }
> >  }
> >  
> > +$return_claims = C4::Context->preference('CleanUpDatabaseReturnClaims') if $return_claims;
> 
> This doesn't make sense to me.
> 
> It means that you need to have a sysadmin change a cronjob for ALL instances
> if there's just 1 instance that wants to be able to use the system
> preference "CleanUpDatabaseReturnClaims".

You are incorrect. It means that an administrator can disable that behavior for
all instances. However, if the option is enabled on the command line, the
system preference then takes over as the control. If the syspref is empty, the
feature is disabled. If the syspref has a value, the feature is enabled.

This specific behavior was requested by a member of the QA team.

-- 
You are receiving this mail because:
You are watching all bug changes.