From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 04:31:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 03:31:55 +0000 Subject: [Koha-bugs] [Bug 29383] New: Vendors with lots of orders causes timeouts when receiving Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29383 Bug ID: 29383 Summary: Vendors with lots of orders causes timeouts when receiving Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Some of our libraries have noticed that when upgrading to Koha 20.11.x or higher, Koha will take a very long time and often eventually time out when attempting to receive orders from vendors with many (i.e. more than 100) open orders. To reproduce: 1. Have a vendor 2. Create a basket for that vendor 3. Add at least 100 orders to the basket and close it 4. Receive from the vendor 5. Add invoice details and continue 6. This is when the slowness or timeout will occur -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 04:32:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 03:32:20 +0000 Subject: [Koha-bugs] [Bug 29383] Vendors with lots of orders causes timeouts when receiving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29383 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 08:08:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 07:08:23 +0000 Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 --- Comment #38 from Andrew Nugged --- Created attachment 127142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127142&action=edit Bug 28959: (QA follow-up) One more lost 'category' to 'public' change -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 09:08:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 08:08:13 +0000 Subject: [Koha-bugs] [Bug 21860] Marc modification templates cannot check or change indicators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 09:16:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 08:16:20 +0000 Subject: [Koha-bugs] [Bug 29380] Auto renewing, batch due date extension tool and checkout note previews are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29380 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127126|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 127143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127143&action=edit Bug 29380: Correct table name in joins to prevent errors The commit "Bug 29290: Rename relationships borrower => patron" (d46492ac23) renamed the relation for the borrowers table from 'borrower' to 'patron' but the joins were not updated accordingly so a few scripts got broken. To test: 1) Notice that $ perl misc/cronjobs/automatic_renewals.pl -c -s -v returns 255 error code on exit 2) Apply patch 3) Notice the automatic_renewals.pl works now and exit code is 0 4) Make sure /cgi-bin/koha/tools/batch_extend_due_dates.pl works. 5) Try to grep for 'borrower' in Koha source code and see if there are any other join done using the Koha::Checkout or Koha::Old::Checkout objects. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 09:17:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 08:17:19 +0000 Subject: [Koha-bugs] [Bug 29380] Auto renewing, batch due date extension tool and checkout note previews are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29380 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Damn, annoyed I missed this during QA of the cause bug :(. This appears to catch all cases, I couldn't find any more myself. Passing QA, thanks for the quick spot and fix Joonas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 09:17:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 08:17:30 +0000 Subject: [Koha-bugs] [Bug 29380] Auto renewing, batch due date extension tool and checkout note previews are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29380 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 09:22:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 08:22:53 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127011|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 127144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127144&action=edit Bug 27360: Add public field to branches table Signed-off-by: Barbara Johnson Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 09:22:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 08:22:57 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127012|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 127145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127145&action=edit Bug 27360: DBIC Build Signed-off-by: Barbara Johnson Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 09:23:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 08:23:00 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127013|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 127146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127146&action=edit Bug 27360: Use 'public' to filter libraries for opac display This patch adds the ability to set a library as 'public' or not; this allows librarians to hide back office library branches from the opac. Test plan 1/ Set a library as public from `admin > libraries`. 2/ Navigate to the `Libraries` page in the OPAC 3/ Note that only `public` libraries are displayed. Signed-off-by: Barbara Johnson Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 09:23:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 08:23:04 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 --- Comment #21 from Martin Renvoize --- Created attachment 127147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127147&action=edit Bug 27360: (follow-up) Mark public as boolean -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 09:23:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 08:23:41 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #22 from Martin Renvoize --- Thanks Kyle, all fixed :) Thanks for the quick testing everyone, glad the email field wasn't a blocker. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 09:26:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 08:26:42 +0000 Subject: [Koha-bugs] [Bug 28729] Return-path header not set in emails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 --- Comment #57 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #55) > (In reply to Marcel de Rooy from comment #53) > > The fix works fine on itself, but it feels like a fix on the wrong place. > > And a fix that more or less assumes that we are not calling send_or_die with > > the from parameter; this seems to the case in the current codebase where we > > only pass transport. > > Not sure what you mean here.. we account for 'from' being passed... the key > challenge is understanding that the 'from' you might pass send_or_die is the > envelope address and not the email from. > > > We should be fixing create too (origin of this problem). I will postpone > > these things to 29365. The test passes, could be improved too. > > > > This serves as a minimal fix, allowing backports. > > I'm not sure what you mean about fixing create? Sender is a bad name for > this parameter and it was used due to a weird internal workaround provided > by Mail::Sendmail.. I don't know that you could easily move the fix into > create.. short of create producing the wrapper and returning a structure > that's all nested one level deeper. Lets see on the new report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 09:27:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 08:27:34 +0000 Subject: [Koha-bugs] [Bug 25883] Show transfer on checkin screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25883 --- Comment #14 from Martin Renvoize --- (In reply to Katrin Fischer from comment #13) > I have 2 issues with this change that I in fact like a lot! > > 1) The table configuration was not updated, so it still has "holdingbranch" > for the returns table. Ooops, I'll get right on to that. > 2) I wonder if replacing "holdingbranch" with "transfer to" works for all > libraries and all use cases. If we think about rotating collections, > floating collection, stock rotation and similar, seeing the holding library > might still be useful. At the moment, the "transfer to" column will remain > empty when there is no tranfer/hold, so this information is gone from > display. Could we agree to add "transfer to" in addition to holdingbranch? > With the table settings this would make it a flexible solution. Holding branch is always set to match the current branch at check-in so it will always display the branch you are checking in at. I'm not sure how useful that information is and that's why I replaced it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 09:31:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 08:31:50 +0000 Subject: [Koha-bugs] [Bug 25883] Show transfer on checkin screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25883 --- Comment #15 from Martin Renvoize --- Created attachment 127148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127148&action=edit Bug 25883: (follow-up) Update columns_settings Replace 'holdinglibrary' with 'transferlibrary' in checkedin columns_settings description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 09:32:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 08:32:23 +0000 Subject: [Koha-bugs] [Bug 25883] Show transfer on checkin screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25883 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 09:47:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 08:47:22 +0000 Subject: [Koha-bugs] [Bug 28729] Return-path header not set in emails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA --- Comment #58 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #54) > We cover ReturnPathDefault but do not fallback to Admin like here: > > + $args->{from} = $self->email->header("Sender") || > C4::Context->preference('KohaAdminEmailAddress'); > > I am keeping it in blocked over the weekend.. Dont think we should do that here. If you keep the pref ReturnpathDefault empty, return path falls back correctly to sender. And we already use AdminEmail as a fallback. The fix is fine as-is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 09:50:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 08:50:43 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED --- Comment #9 from Marcel de Rooy --- Will give it a try now -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 09:55:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 08:55:13 +0000 Subject: [Koha-bugs] [Bug 29384] New: Advance Notice and Overdue Missing (Default messaging preferences for this patron category) after upgrade from old database (ver 3.2) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29384 Bug ID: 29384 Summary: Advance Notice and Overdue Missing (Default messaging preferences for this patron category) after upgrade from old database (ver 3.2) Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: saajith at seu.ac.lk QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 127149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127149&action=edit Default Messaging preferences after database migration -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 10:54:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 09:54:54 +0000 Subject: [Koha-bugs] [Bug 28904] Update information on Newsletter editor on about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28904 --- Comment #13 from Martin Renvoize --- Created attachment 127150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127150&action=edit Bug 28904: Fix typo and display Fix typo in template: Newletter => Newsletter Fix latest newsletter editor definition.. it's a has not an array. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 10:56:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 09:56:24 +0000 Subject: [Koha-bugs] [Bug 28904] Update information on Newsletter editor on about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28904 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #14 from Martin Renvoize --- Good catch Katrin!.. I'd made a couple of mistakes... A typo in the template.. it's "Newsletter" not "Newletter".. and I'd defined the most recent editor in an array not a hash key.. hence not displaying as expected. Follow-up fixes both issues. Back to NQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 11:09:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 10:09:58 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #10 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #9) > Will give it a try now Yes, it looks like David was right. This might not be a minimal fix. The add_attachments stuff in C4::Letters does not seem to work well with Email::Stuffer. Imo we should go back to Email::MIME in Koha::Email. More comments on bug 29365 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 11:11:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 10:11:05 +0000 Subject: [Koha-bugs] [Bug 22343] Add configuration options for SMTP servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28729, 29365 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 [Bug 28729] Return-path header not set in emails https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29365 [Bug 29365] Koha::Email issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 11:11:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 10:11:05 +0000 Subject: [Koha-bugs] [Bug 28729] Return-path header not set in emails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22343 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 [Bug 22343] Add configuration options for SMTP servers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 11:11:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 10:11:05 +0000 Subject: [Koha-bugs] [Bug 29365] Koha::Email issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29365 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22343 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 [Bug 22343] Add configuration options for SMTP servers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 11:12:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 10:12:01 +0000 Subject: [Koha-bugs] [Bug 22343] Add configuration options for SMTP servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #236 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #233) > This Koha::Email revamp was pushed a bit too early, i am afraid. This really was an understatement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 11:12:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 10:12:45 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|m.de.rooy at rijksmuseum.nl |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 11:14:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 10:14:21 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #11 from Marcel de Rooy --- The good thing is that we hardly use add_attachments only for overdue messages collected for patrons without email address or so. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 11:14:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 10:14:32 +0000 Subject: [Koha-bugs] [Bug 29383] Vendors with lots of orders causes timeouts when receiving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29383 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20212 --- Comment #1 from Katrin Fischer --- Hi Aleisha, there is a big change between 20.11 and 21.05 with Bug 20212 - Improve performance of acquisitions receive page Is the issue you see tied to the before or the after display? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 11:14:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 10:14:32 +0000 Subject: [Koha-bugs] [Bug 20212] Improve performance of acquisitions receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29383 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 11:16:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 10:16:41 +0000 Subject: [Koha-bugs] [Bug 29365] Koha::Email needs to be refactored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29365 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha::Email issues |Koha::Email needs to be | |refactored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 11:18:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 10:18:29 +0000 Subject: [Koha-bugs] [Bug 24406] Remove patron category category type codes from patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125989|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 127151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127151&action=edit Bug 24406: Wrap patron category type code in a span on patron search results The patron category type code (A, C, O, ...) is currently displayed in the patron module search and the patron card creator and acquisition patron searches. This information is not useful for most users, as these are internal codes that cannot be easily "decoded". And while you might be able to guess A as Adult in English, it doesn't translate to other languages. This patch wraps a span around the patron category type code shown in () after the patron category. To test: - Verify for each of the following three searches, that the patron category code displays in the search results, but is wrapped in a span with the class patron_category_type - Tools > Patron card creator - New > New card batch > Add patrons - Search for patrons - Patrons - Search for patrons - Acquisitions - Add a budget - Add a fund for the budget - Search for a user or owner to add Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 11:19:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 10:19:22 +0000 Subject: [Koha-bugs] [Bug 24406] Remove patron category category type codes from patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Trivial patch that provides a suitable work around.. It would be nice to see another bug reported to do a nicer job of allowing conversion of these type codes to translatable descriptions. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 11:20:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 10:20:54 +0000 Subject: [Koha-bugs] [Bug 21860] Marc modification templates cannot check or change indicators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #8 from Martin Renvoize --- Are you working on this one Hayley? Would be lovely to see some code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 11:23:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 10:23:57 +0000 Subject: [Koha-bugs] [Bug 29365] Koha::Email needs to be refactored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29365 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Depends on| |26705 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26705 [Bug 26705] System preference NoticeBcc not working -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 11:23:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 10:23:57 +0000 Subject: [Koha-bugs] [Bug 26705] System preference NoticeBcc not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26705 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29365 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29365 [Bug 29365] Koha::Email needs to be refactored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 11:27:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 10:27:50 +0000 Subject: [Koha-bugs] [Bug 29365] Koha::Email needs to be refactored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29365 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29330 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 11:27:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 10:27:50 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29365 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29365 [Bug 29365] Koha::Email needs to be refactored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 11:35:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 10:35:01 +0000 Subject: [Koha-bugs] [Bug 29365] Koha::Email needs to be refactored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29365 --- Comment #1 from Marcel de Rooy --- Here are a few of my findings when working on bug 28729, 29330. [1] We should move away from Email::Stuffer imo. We are wrapping a wrapper around a wrapper around Email::MIME. Just go there and use Koha::Email as your wrapper. Stuffer is too simple. We are already calling $message->email often enough to illustrate that point. [2] Bug 28729 fixed an issue with Sender/Returnpath. We c/should solve this already in Koha::Email->create. [3] Currently we call Stuffer::send_or_die and not send. We are only fixing stuff in the former one. We should do the same for send or let it explode. [4] We are never passing from and to parameters to send_or_die only transport. Should we support them, or keep it in create only? Move the bcc handling to create? [5] Attachments do not work. See bug 29330. We should refactor the code in Letters for that. Move it to Koha::Email? How do we save them in the database while they are pending? [6] When doing these things, we can probably rearrange so that create can call Email::MIME at the end, and the result does not need further tweaking? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 11:36:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 10:36:45 +0000 Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 11:52:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 10:52:57 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 11:53:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 10:53:11 +0000 Subject: [Koha-bugs] [Bug 10603] Make required fields on course reserves configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10603 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #3 from Kelly McElligott --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 11:56:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 10:56:27 +0000 Subject: [Koha-bugs] [Bug 29302] API DataTables Wrapper should allow picking match type by column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29302 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 12:02:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 11:02:49 +0000 Subject: [Koha-bugs] [Bug 28904] Update information on Newsletter editor on about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28904 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 12:02:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 11:02:53 +0000 Subject: [Koha-bugs] [Bug 28904] Update information on Newsletter editor on about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28904 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127019|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 127152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127152&action=edit Bug 28904: Add newsletter editor to about page display Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 12:02:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 11:02:57 +0000 Subject: [Koha-bugs] [Bug 28904] Update information on Newsletter editor on about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28904 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127020|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 127153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127153&action=edit Bug 28904: Update team list to include newsletter editors It seems we stopped recording the newsletter editor as part of the team for a while :(. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 12:03:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 11:03:01 +0000 Subject: [Koha-bugs] [Bug 28904] Update information on Newsletter editor on about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28904 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127150|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 127154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127154&action=edit Bug 28904: Fix typo and display Fix typo in template: Newletter => Newsletter Fix latest newsletter editor definition.. it's a has not an array. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 12:03:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 11:03:38 +0000 Subject: [Koha-bugs] [Bug 29351] Add missing cn_source parameter to reports parameter menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This patch adds a link for release notes| |the previously-hidden | |option of using a runtime | |parameter for selecting | |"Source of classification | |or shelving scheme." Now | |when composing an SQL | |report you can click the | |"Insert runtime parameter" | |button to see a menu that | |includes this option. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 12:04:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 11:04:03 +0000 Subject: [Koha-bugs] [Bug 25883] Show transfer on checkin screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25883 --- Comment #16 from Katrin Fischer --- > > 2) I wonder if replacing "holdingbranch" with "transfer to" works for all > > libraries and all use cases. If we think about rotating collections, > > floating collection, stock rotation and similar, seeing the holding library > > might still be useful. At the moment, the "transfer to" column will remain > > empty when there is no tranfer/hold, so this information is gone from > > display. Could we agree to add "transfer to" in addition to holdingbranch? > > With the table settings this would make it a flexible solution. > > Holding branch is always set to match the current branch at check-in so it > will always display the branch you are checking in at. I'm not sure how > useful that information is and that's why I replaced it. You are right, thx for the reply! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 12:04:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 11:04:59 +0000 Subject: [Koha-bugs] [Bug 25883] Show transfer on checkin screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25883 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 12:05:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 11:05:03 +0000 Subject: [Koha-bugs] [Bug 25883] Show transfer on checkin screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25883 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126279|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 127155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127155&action=edit Bug 25883: Replace 'holdingbranch' with 'transfer to' in returns This patch replaces the "Holding library" column in the returns table with a 'Transfer to' column that displays the destination for the item awaiting transfer if a transfer exists. Signed-off-by: Ben Daeuber Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 12:05:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 11:05:07 +0000 Subject: [Koha-bugs] [Bug 25883] Show transfer on checkin screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25883 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127148|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer --- Created attachment 127156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127156&action=edit Bug 25883: (follow-up) Update columns_settings Replace 'holdinglibrary' with 'transferlibrary' in checkedin columns_settings description. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 12:05:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 11:05:19 +0000 Subject: [Koha-bugs] [Bug 25883] Show transfer on checkin screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25883 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual, | |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 12:12:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 11:12:13 +0000 Subject: [Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize --- I'd love to see a unit test for this... but I'm not entirely sure how we'd go about that. :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 12:12:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 11:12:36 +0000 Subject: [Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127111|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 127157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127157&action=edit Bug 26871: Flush SIP2 cache on every SIP request SIP connections tend to be long lived, weeks if not months, in the libraries I see. Basically the connection per SIP machine is initiated once when the SIP machine boots and then never closed until maintanance needs to be done. Therefore we need to reset the Koha's L1 caches on every SIP request to get the latest sysprefs and configs from the memcached cache that is shared between all the Koha programs (intranet, opac, sip, cronjobs) and is guaranteed to be up to date. To test: 0. Have kohadevbox 1. Enable IssueLog 2. In one terminal run the command "perl C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml" 3. Checkin and return a book using telnet: $ telnet localhost 6001 9300CNterm1|COterm1|CPCPL| 11YN20211010 10565320211010 105653AOCPL|AA1|AB3999900000001|ACterm1|BON|BIN| 09N20211010 10564420211010 105644APCPL|AOCPL|AB3999900000001|ACterm1|BIN| 4. Keep the telnet connection open and go to http://localhost:8081/cgi-bin/koha/tools/viewlog.pl and check that the *checkout* entry is in the circulation rules 5. 6. Disable IssueLog 7. Move back to the telnet prompt and check out and return a book again 11YN20211010 10565320211010 105653AOCPL|AA1|AB3999900000001|ACterm1|BON|BIN| 09N20211010 10564420211010 105644APCPL|AOCPL|AB3999900000001|ACterm1|BIN| 8. Go check out the circulation logs and notice a new entry was added when it shouldn't have according to the IssueLog syspref! 9. Apply patch and repeat steps to notice that the syspref is now followed correctly. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 12:15:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 11:15:01 +0000 Subject: [Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize --- OK.. well this works as expected and resolves some serious problems for users (We have been restarting SIP nightly for years ourselves.. but we shouldn't all need to do that!). I would love to see Unit Tests for this change.. and I'd love to see some POD updates for the SIPServer code as hardly any of these functions are properly documented and I think had they been we might have fixed this earlier. Passing QA for now, as the code works.. I'll leave it up to the RM to require a Unit Test if he feels it's a) important and b) attainable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 12:15:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 11:15:43 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 --- Comment #23 from Katrin Fischer --- While I am testing this: I am not sure about using "Public" to describe this feature as it only affects the libraries page in the OPAC right now. I think we should at least add a hint about what it really does to the input/edit form for libraries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 12:21:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 11:21:14 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 --- Comment #24 from Martin Renvoize --- Created attachment 127158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127158&action=edit Bug 27360: (follow-up) Add hint -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 12:26:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 11:26:57 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 12:27:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 11:27:02 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127144|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer --- Created attachment 127159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127159&action=edit Bug 27360: Add public field to branches table Signed-off-by: Barbara Johnson Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 12:27:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 11:27:07 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127145|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer --- Created attachment 127160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127160&action=edit Bug 27360: DBIC Build Signed-off-by: Barbara Johnson Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 12:27:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 11:27:11 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127146|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer --- Created attachment 127161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127161&action=edit Bug 27360: Use 'public' to filter libraries for opac display This patch adds the ability to set a library as 'public' or not; this allows librarians to hide back office library branches from the opac. Test plan 1/ Set a library as public from `admin > libraries`. 2/ Navigate to the `Libraries` page in the OPAC 3/ Note that only `public` libraries are displayed. Signed-off-by: Barbara Johnson Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 12:27:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 11:27:15 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127147|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer --- Created attachment 127162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127162&action=edit Bug 27360: (follow-up) Mark public as boolean Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 12:27:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 11:27:19 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 --- Comment #29 from Katrin Fischer --- Created attachment 127163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127163&action=edit Bug 27360: Add hint to input field Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 12:27:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 11:27:30 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127158|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 13:12:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 12:12:48 +0000 Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Katrin Fischer --- I am sorry, but I am having a bit of trouble with this one: prove t/db_dependent/Illrequests.t t/db_dependent/Illrequests.t .. 3/13 # Failed test 'new node + core_status_graph = bigger status graph' # at t/db_dependent/Illrequests.t line 272. # Compared array length of $data->{"GENREQ"}{"next_actions"} # got : array with 3 element(s) # expect : array with 2 element(s) # { # 'CANCREQ' => { # 'id' => 'CANCREQ', # 'method' => 0, # 'name' => 'Cancellation requested', # 'next_actions' => [ # 'KILL', # 'REQ' # ], # 'prev_actions' => [ # 'NEW' # ], # 'ui_method_icon' => 0, # 'ui_method_name' => 0 # }, # 'CHK' => { # 'id' => 'CHK', # 'method' => 'check_out', # 'name' => 'Checked out', # 'needs_all' => [ # sub { "DUMMY" } # ], # 'needs_perms' => [ # 'user_circulate_circulate_remaining_permissions' # ], # 'needs_prefs' => [ # 'CirculateILL' # ], # 'next_actions' => [], # 'prev_actions' => [ # 'REQ', # 'GENREQ', # 'COMP' # ], # 'ui_method_icon' => 'fa-upload', # 'ui_method_name' => 'Check out' # }, # 'COMP' => { # 'id' => 'COMP', # 'method' => 'mark_completed', # 'name' => 'Completed', # 'next_actions' => [ # 'CHK' # ], # 'prev_actions' => [ # 'REQ' # ], # 'ui_method_icon' => 'fa-check', # 'ui_method_name' => 'Mark completed' # }, # 'GENREQ' => { # 'id' => 'GENREQ', # 'method' => 'generic_confirm', # 'name' => 'Requested from partners', # 'next_actions' => [ # 'COMP', # 'CHK', # 'GENREQ' # ], # 'prev_actions' => [ # 'NEW', # 'REQREV', # 'GENREQ' # ], # 'ui_method_icon' => 'fa-send-o', # 'ui_method_name' => 'Place request with partners' # }, # 'KILL' => { # 'id' => 'KILL', # 'method' => 'delete', # 'name' => 0, # 'next_actions' => [], # 'prev_actions' => [ # 'QUEUED', # 'REQREV', # 'NEW', # 'CANCREQ' # ], # 'ui_method_icon' => 'fa-trash', # 'ui_method_name' => 'Delete request' # }, # 'NEW' => { # 'id' => 'NEW', # 'method' => 'create', # 'name' => 'New request', # 'next_actions' => [ # 'REQ', # 'GENREQ', # 'KILL' # ], # 'prev_actions' => [], # 'ui_method_icon' => 'fa-plus', # 'ui_method_name' => 'New request' # }, # 'QUEUED' => { # 'id' => 'QUEUED', # 'method' => 0, # 'name' => 'Queued request', # 'next_actions' => [ # 'REQ', # 'KILL' # ], # 'prev_actions' => [], # 'ui_method_icon' => 0, # 'ui_method_name' => 0 # }, # 'REQ' => { # 'id' => 'REQ', # 'method' => 'confirm', # 'name' => 'Requested', # 'next_actions' => [ # 'REQREV', # 'COMP', # 'CHK' # ], # 'prev_actions' => [ # 'NEW', # 'REQREV', # 'QUEUED', # 'CANCREQ' # ], # 'ui_method_icon' => 'fa-check', # 'ui_method_name' => 'Confirm request' # }, # 'REQREV' => { # 'id' => 'REQREV', # 'method' => 'cancel', # 'name' => 'Request reverted', # 'next_actions' => [ # 'REQ', # 'GENREQ', # 'KILL' # ], # 'prev_actions' => [ # 'REQ' # ], # 'ui_method_icon' => 'fa-times', # 'ui_method_name' => 'Revert Request' # }, # 'RET' => { # 'id' => 'RET', # 'method' => 'check_in', # 'name' => 'Returned to library', # 'next_actions' => [ # 'COMP' # ], # 'prev_actions' => [ # 'CHK' # ], # 'ui_method_icon' => 'fa-download', # 'ui_method_name' => 'Check in' # }, # 'TEST' => { # 'id' => 'TEST', # 'next_actions' => [], # 'prev_actions' => [] # } # } # Looks like you failed 1 test of 5. t/db_dependent/Illrequests.t .. 5/13 # Failed test 'Status Graph tests' # at t/db_dependent/Illrequests.t line 380. t/db_dependent/Illrequests.t .. 11/13 # Looks like you planned 3 tests but ran 5. # Failed test 'Custom statuses' # at t/db_dependent/Illrequests.t line 1343. t/db_dependent/Illrequests.t .. 13/13 # Looks like you failed 2 tests of 13. t/db_dependent/Illrequests.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/13 subtests Test Summary Report ------------------- t/db_dependent/Illrequests.t (Wstat: 512 Tests: 13 Failed: 2) Failed tests: 5, 12 Non-zero exit status: 2 There are also some minor QA fails (tab characters and missing TT filters). I would have fixed those, but holding off now as the tests might need a little work anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 13:28:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 12:28:10 +0000 Subject: [Koha-bugs] [Bug 28879] Display of metadata with long label names looks terrible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28879 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 13:28:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 12:28:14 +0000 Subject: [Koha-bugs] [Bug 28879] Display of metadata with long label names looks terrible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28879 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125276|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 127164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127164&action=edit Bug 28879: Fix display of request metadata This commit adjusts the CSS surrounding the display of request metadata, it improves the display for metadata with long key names. Test plan: - Do not apply patch - Create a FreeForm ILL request with a custom metadata field with a long name - View the created request - Observe that the long metadata name breaks the display of the metadata - Apply the patch - View the created request => TEST: Observe that the display is no longer broken Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 13:31:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 12:31:17 +0000 Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #46 from Katrin Fischer --- I am sorry, but this is currently blocked by bug 24609 being Failed QA. Please reset status as soon as the dependency has cleared up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 13:35:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 12:35:46 +0000 Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 --- Comment #47 from Katrin Fischer --- There is actually quite a long dependency tree above this one we'll need to work through first. I still ran the qa tools here and here is a little glitch: FAIL koha-tmpl/intranet-tmpl/prog/js/checkouts.js FAIL ES template literals ES template literals found ( url: `/api/v1/checkouts/${checkoutId}`,) - See bug 24625 OK git manipulation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 13:40:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 12:40:03 +0000 Subject: [Koha-bugs] [Bug 29280] Add OPACStarRatings to opac-shelves.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer --- Sorry, not trying to throw this out, but: +$template->param( + OpacStarRatings => C4::Context->preference("OpacStarRatings") +); + Should we not remove this in favor of using TT in the template? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 13:40:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 12:40:37 +0000 Subject: [Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add OPACStarRatings to |Add star ratings to OPAC |opac-shelves.tt |lists display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 13:54:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 12:54:27 +0000 Subject: [Koha-bugs] [Bug 28453] Update pagination subroutine to generate Bootstrap markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer --- I am sorry, but I believe there are some translation issues hiding here. In Output.pm: + . ' First' . ''; + . '" rel="prev">' . ' Previous' . ''; . '" rel="next">' . 'Next ' . ''; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 14:04:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 13:04:36 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #24 from Katrin Fischer --- Hi Emmi, my apply script shows a bit of ending whitespace and the QA test tools show an error I haven't seen before: 1) QA tools error FAIL Koha/Patron/Debarments.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling FAIL valid Inconsistent hierarchy during C3 merge of class 'Koha::Patron::Debarments': current merge results [ Koha::Patron::Debarments, ] merging failed on 'Exporter' Could you please check this out? I've also done a first code review: 2) Please always use INSERT IGNORE when adding system preferences. This helps to keep them idempotent. + $dbh->do("INSERT INTO systempreferences (variable, value, options, explanation, type) VALUES ('DebarmentsToLiftAfterPayment', '', '', 'Lift these debarments after Borrower has paid his/her fees', 'textarea')"); 3) Gender neutral code comments etc. In English, you can use they/them/their to make your text gender neutral (wish it was that easy in German...) Like here: Lift these debarments after Borrower has paid his/her fees You can say: Lift these debarments after patron has paid their charges. See: https://wiki.koha-community.org/wiki/Terminology - prefer patron instead of borrower - prefer charges instead of fines/fees (not added yet, but changed in GUI) Similar for the written out pref text in the .yml file. 4) Unit tests pass :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 14:19:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 13:19:21 +0000 Subject: [Koha-bugs] [Bug 29058] Add option to not load existing holds table automatically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125487|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 14:21:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 13:21:14 +0000 Subject: [Koha-bugs] [Bug 29058] Add option to not load existing holds table automatically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #9 from Katrin Fischer --- There is still something odd with the patches here. When I started, there was only the follow-up patch, I reactivated the main patch, but I get a conflict on applying: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29058: Add 'Always show holds' checkbox to request.pl Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt M reserve/request.pl Falling back to patching base and 3-way merge... Auto-merging reserve/request.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 29058: Add 'Always show holds' checkbox to request.pl The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-29058-Add-Always-show-holds-checkbox-to-reques-BjIBIP.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 14:29:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 13:29:15 +0000 Subject: [Koha-bugs] [Bug 26326] Add Koha Objects for Import Records and Import Record Matches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 14:29:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 13:29:20 +0000 Subject: [Koha-bugs] [Bug 26326] Add Koha Objects for Import Records and Import Record Matches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124171|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer --- Created attachment 127165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127165&action=edit Bug 26326: Add Koha Objects for Import Records and Import Record Matches To test: 1 - Apply patches 2 - Update database 3 - Generate schema files (dbic) 4 - prove -v t/db_dependent/Koha/Import/Records.t 5 - prove -v t/db_dependent/Koha/Import/Record/Matches.t Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 14:29:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 13:29:25 +0000 Subject: [Koha-bugs] [Bug 26326] Add Koha Objects for Import Records and Import Record Matches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124172|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer --- Created attachment 127166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127166&action=edit Bug 26326: (follow-up) Add ability to check for existence of any primary key Before dropping a primary key we need to see if one exists - this updates the installer method to allow searching for existence of key Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 14:29:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 13:29:29 +0000 Subject: [Koha-bugs] [Bug 26326] Add Koha Objects for Import Records and Import Record Matches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124173|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer --- Created attachment 127167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127167&action=edit Bug 26326: DO NOT PUSH Schema changes Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 14:29:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 13:29:34 +0000 Subject: [Koha-bugs] [Bug 26326] Add Koha Objects for Import Records and Import Record Matches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126979|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer --- Created attachment 127168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127168&action=edit Bug 26326: (follow-up) Address qa script failures Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 14:44:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 13:44:19 +0000 Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through Stage Marc Record Import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate Status|Signed Off |Failed QA --- Comment #47 from Katrin Fischer --- I've PQA on the base patch for adding the new classes, but I'll probably need some help here especially for the API parts of the patch. 1) Translatability You did great with View a few lines above, but here "Ignore matches" is not translatable: + $('td:eq(4) ul', nRow).prepend('
    • '); Also here: + }).fail(function(){ alert("Unable to update match choices"); return false; }); 2) Unrelated file change reports/acquisitions_stats.pl + warn $strcalc; I am marking this as a candidate for early inclusion in 22.05 as this enh is a bit bigger and we have already reached soft feature freeze. I am a little worried about side effects, like with the CLI tools for staged MARC import, so would like to see those tested as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 14:50:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 13:50:17 +0000 Subject: [Koha-bugs] [Bug 23479] Hold cancellation confirmation too generic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 --- Comment #16 from Katrin Fischer --- (In reply to Barbara Johnson from comment #15) > Confirmed that title IS showing. I like the idea of making title and name > bold. It's just really bad for translations because we end up with single words like "for" that can have a multiple of meanings/translations in other languages. Using styling on single words "breaks" sentences into pieces right now. I am open for better solutions that keep things in context for translations while preserving the styling. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 14:53:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 13:53:01 +0000 Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #8 from Lucas Gass --- (In reply to Katrin Fischer from comment #7) > Having a look here - I can' test BakerTaylor content, so having a real close > look at the code. > > As Owen pointed out this was not present before, so I think the small thing > here is that the pref description was wrong before, but the big thing is > that we add the content to staff! So I took the liberty to adjust the pref > description a bit (change back if you hate it) > > As we rename the pref for the OPAC, I expected a lot more name changes > there. Checking with git grep I believe some were missed: > > koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc:[% IF ( > BakerTaylorEnabled ) %] > koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc: > [% IF ( OPACLocalCoverImages || OPACAmazonCoverImages || ( SyndeticsEnabled > && SyndeticsCoverImages ) || GoogleJackets || BakerTaylorEnabled || ( > Koha.Preference('OpacCoce') && Koha.Preference('CoceProviders') ) || ( > Koha.Preference('OPACCustomCoverImages') AND > Koha.Preference('CustomCoverImagesURL') ) ) %] > koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc: > [% IF ( BakerTaylorEnabled ) %] > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt:[% IF ( > BakerTaylorEnabled ) %][% IF bt_id %]See Baker & > Taylor[% END > %][% END %] > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt: > [% IF BakerTaylorEnabled %] > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt: > [% IF ( BakerTaylorEnabled && !BakerTaylorBookstoreURL ) %] > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt: > [% IF ( BakerTaylorEnabled && BakerTaylorBookstoreURL ) %] > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: > [% IF ( Koha.Preference('BakerTaylorEnabled') && > !Koha.Preference('BakerTaylorBookstoreURL') ) %] > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: > [% IF ( Koha.Preference('BakerTaylorEnabled') && > Koha.Preference('BakerTaylorBookstoreURL') ) %] > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews-rss.tt:[% IF ( > BakerTaylorEnabled && bt_id ) %]See Baker & Taylor[% END %] > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt: > [% IF ( BakerTaylorEnabled ) %] > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt: > [% IF ( BakerTaylorEnabled ) %] > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt: > [% IF ( BakerTaylorEnabled ) %] > > Only seeing this one was changed: > > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt: > [% IF ( OPACBakerTaylorEnabled && bt_id ) %] > > I think the issue is in the test plan, it should be: Disable staff interface > and only enable OPAC. Verify it all still shows correctly. Excuse my confusion here, I'd like to see this one move on. Do we need to edit code or only the test plan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 14:54:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 13:54:27 +0000 Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #9 from Katrin Fischer --- We definitely need a follow-up patch (code change) for all the places the syspref rename has not taken into account. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 14:55:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 13:55:43 +0000 Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #10 from Katrin Fischer --- To explain a bit more: we have a pref now that is "Opac...", but in the OPAC scripts the old name is still used almost everywhere. I believe the test plan should maybe be altered to in that you have to verify that the OPAC displays B&T content correctly, when BakerTaylorEnabled (staff side) is turned off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 15:14:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 14:14:33 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127051|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy --- Created attachment 127169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127169&action=edit Bug 29336: Identify the fields with wrong length (or name) first This report will fix the bad lengths first. And mark the 'bad' names with a TODO for follow-up. Bad name means: refers to value, should be category. Scanning kohastructure.sql. Note: Bug 29347 has been opened to fix the names. Test plan: Search for another AV category field with length<>32. Bonus: Reinstall and check database. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 15:14:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 14:14:37 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127053|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy --- Created attachment 127170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127170&action=edit Bug 29336: Database revision Resizes the six fields identified earlier: additional_fields.authorised_value_category 16=>32 auth_subfield_structure.authorised_value 10=>32 auth_tag_structure.authorised_value 10=>32 club_template_enrollment_fields.authorised_value_category 16=>32 club_template_fields.authorised_value_category 16=>32 marc_tag_structure.authorised_value 10=>32 Test plan: Run dbrev, check database. Bonus: Connect an AV category with a long name to a authority subfield. Check if you see its values in the authority editor. (This was the way I found the problem.) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 15:14:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 14:14:40 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #13 from Marcel de Rooy --- Created attachment 127171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127171&action=edit Bug 29336: Allow to check on FK existence with field name Sometimes easier (or even safer) to check for FK on specific field name rather than constraint name (which may be created automatically). Test plan: Run t/db_dependent/Installer.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 15:14:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 14:14:43 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #14 from Marcel de Rooy --- Created attachment 127172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127172&action=edit Bug 29336: Add a few missing FK constraints to authorised values Test plan: Run dbrev or new install. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 15:15:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 14:15:40 +0000 Subject: [Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer --- I am sorry, but there is a little issue here. Maybe some variables are not reset? - Place multiple holds for different patrons on a record - Click on the X to cancel a single hold, verify the question has the correct information and abort with cancel. - Use the checkboxes to mark multiple holds for cancelling - Use the "Cancel selected" button - The confirmation will still ask about cancelling the hold for the perevious user, although you are cancelling multiple for different users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 15:15:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 14:15:50 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #15 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #10) > (In reply to Jonathan Druart from comment #9) > > Why not adding the FK on the way? > > Missed the missing ones :) Focused on length > Will do Bit more work than anticipated. But there we go. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 15:17:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 14:17:32 +0000 Subject: [Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #14 from Katrin Fischer --- Wrong bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 15:17:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 14:17:49 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #16 from Marcel de Rooy --- Wait! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 15:17:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 14:17:50 +0000 Subject: [Koha-bugs] [Bug 23479] Hold cancellation confirmation too generic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Katrin Fischer --- I am sorry, but there is a little issue here. Maybe some variables are not reset? - Place multiple holds for different patrons on a record - Click on the X to cancel a single hold, verify the question has the correct information and abort with cancel. - Use the checkboxes to mark multiple holds for cancelling - Use the "Cancel selected" button - The confirmation will still ask about cancelling the hold for the perevious user, although you are cancelling multiple for different users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 15:20:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 14:20:43 +0000 Subject: [Koha-bugs] [Bug 29385] New: Add missing cash register support to SIP2 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29385 Bug ID: 29385 Summary: Add missing cash register support to SIP2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: joy at bywatersolutions.com, testopia at bugs.koha-community.org Depends on: 23321, 24828 Blocks: 13985 +++ This bug was initially created as a clone of Bug #24828 +++ We add support for defining cash registers for SIP with bug 24828, however, we missed the case when specific fees are being paid. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 [Bug 23321] Add 'cash registers' to the accounts system https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24828 [Bug 24828] Add cash register support to SIP2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 15:20:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 14:20:43 +0000 Subject: [Koha-bugs] [Bug 23321] Add 'cash registers' to the accounts system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29385 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29385 [Bug 29385] Add missing cash register support to SIP2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 15:20:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 14:20:43 +0000 Subject: [Koha-bugs] [Bug 24828] Add cash register support to SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24828 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29385 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29385 [Bug 29385] Add missing cash register support to SIP2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 15:20:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 14:20:43 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29385 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29385 [Bug 29385] Add missing cash register support to SIP2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 15:23:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 14:23:14 +0000 Subject: [Koha-bugs] [Bug 29385] Add missing cash register support to SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29385 --- Comment #1 from Martin Renvoize --- Created attachment 127173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127173&action=edit Bug 29385: Catch register_id for payments against fees This patch adds the missing cash_register definition in the call to pay with a set of lines defined. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 15:23:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 14:23:38 +0000 Subject: [Koha-bugs] [Bug 29385] Add missing cash register support to SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29385 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com Severity|enhancement |major Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 15:25:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 14:25:07 +0000 Subject: [Koha-bugs] [Bug 29385] Add missing cash register support to SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29385 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 15:49:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 14:49:50 +0000 Subject: [Koha-bugs] [Bug 28236] Selecting database columns for system preferences in standard and dev installs is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 15:50:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 14:50:05 +0000 Subject: [Koha-bugs] [Bug 28236] Selecting database columns for system preferences in standard and dev installs is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 15:54:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 14:54:04 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 --- Comment #14 from Tomás Cohen Arazi --- This fix is too simple and is correct regarding the current codebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 15:55:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 14:55:08 +0000 Subject: [Koha-bugs] [Bug 28573] Replace authority record with Z39.50/SRU creates new authority record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 --- Comment #13 from Martin Renvoize --- Created attachment 127174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127174&action=edit Bug 28573: Replace authority record with Z39.50/SRU creates new authority record When trying to replace an authority record with Z39.50/SRU then a new authority record is created without deleting the old one and not link the new one with any record. This patch fixes that. Test plan: 1) Try to catalogue a new authority record from cataloguing form. 2) Try to replace that authority record with Z39.50/SRU, then a new authority record is created and also you have that one that you tried to replace. 3) Apply the patch. 4) Try to replace the authority from step1 with Z39.50/SRU, then is working as expected. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Eric Phetteplace Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 15:55:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 14:55:31 +0000 Subject: [Koha-bugs] [Bug 28573] Replace authority record with Z39.50/SRU creates new authority record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #14 from Martin Renvoize --- Nice work.. Works as expected, no regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 15:55:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 14:55:43 +0000 Subject: [Koha-bugs] [Bug 28573] Replace authority record with Z39.50/SRU creates new authority record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126594|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 15:59:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 14:59:16 +0000 Subject: [Koha-bugs] [Bug 29168] Only show "Request article" if allowed on the detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 15:59:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 14:59:20 +0000 Subject: [Koha-bugs] [Bug 29168] Only show "Request article" if allowed on the detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125920|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 127175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127175&action=edit Bug 29168: Only show 'Request article' if allowed on the detail view This patch adds a check for the patron being able to place the request, in the case of logged in patron. The anonymous patron will still be displayed the link, and redirected to the login page as required. To test: 1. Set the article request limit to 1 2. Place a request on behalf of a known patron 3. With the patron session, in the OPAC, try to place a new article request from the detail page => SUCCESS: There's no link 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 15:59:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 14:59:42 +0000 Subject: [Koha-bugs] [Bug 29168] Only show "Request article" if allowed on the detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168 --- Comment #13 from Katrin Fischer --- I expected a big complicated patch and was pleasantly disappointed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 16:15:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 15:15:32 +0000 Subject: [Koha-bugs] [Bug 28474] Pass process_message_queue.pl params to before_send_messages plugin hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28474 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer --- I got a little stuck here. I activated plugins and installed the kitchensink plugin from the link below. But I am not sure about the parameters to run the misc/cronjobs/process_message_queue.pl with and where in the plugin the output would show. If I click on "Run report" from the plugin management screen, the plugin dies: The method Koha::Patron::Categories->search_limited is not covered by tests! Run tool appears to work. Sending back to Kyle for clarification. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 16:19:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 15:19:23 +0000 Subject: [Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices between different orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125689|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 127176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127176&action=edit Bug 14999: Make sure order prices are not mixed-up We were shifting the price and replacement price for imported orders only after the line: > $duplinbatch = $import_batch_id and next if $duplifound; This lead to the "replacementprice" and "price" query parameters not being shifted/removed from the list if a duplicate record came across and caused the prices be applied to the next record being imported. To reproduce: 1) Download two records from koha to marcxml file, then cat those: cat bib1.marcxml bib2.marcxml > bibs.marcxml 2) Delete bib2 from koha 3) Stage bibs.marcxml for import 4) Create a new order basket, then "Add to basket" using "From a staged file" option 5) Select both bib1 and bib2 and set price & replacement price for bib1 to be 99.00 and for bib2 to be 88.00 6) Click save and notice bib2 was imported with the wrong prices, 99.00! 7) Apply patch and notice the prices are now correctly set to 88.00. Signed-off-by: Emmi Takkinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 16:20:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 15:20:13 +0000 Subject: [Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices between different orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #14 from Martin Renvoize --- That took a bit of wrapping my head around.. all appears good and no regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 16:20:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 15:20:18 +0000 Subject: [Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices between different orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 16:21:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 15:21:02 +0000 Subject: [Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 --- Comment #18 from Katrin Fischer --- Created attachment 127177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127177&action=edit Moved up dividers in breadcrumbs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 16:24:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 15:24:15 +0000 Subject: [Koha-bugs] [Bug 28694] Check alert in cataloguing should be a static message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch changes the way release notes| |error form validation error | |messages are displayed when | |using the basic MARC editor | |in cataloging. Instead of a | |JavaScript alert, errors | |are now shown on the page | |itself, with links in the | |message to take you to the | |corresponding field. A new | |"Errors" button in the | |toolbar allows the user to | |jump back to the list of | |errors for easy reference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 17:23:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 16:23:10 +0000 Subject: [Koha-bugs] [Bug 28474] Pass process_message_queue.pl params to before_send_messages plugin hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28474 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #4 from Kyle M Hall --- (In reply to Katrin Fischer from comment #3) > I got a little stuck here. > > I activated plugins and installed the kitchensink plugin from the link below. > > But I am not sure about the parameters to run the > misc/cronjobs/process_message_queue.pl with and where in the plugin the > output would show. > > If I click on "Run report" from the plugin management screen, the plugin > dies: > The method Koha::Patron::Categories->search_limited is not covered by tests! > > Run tool appears to work. > > Sending back to Kyle for clarification. Pass something parameter like "-t email" and you should see it in the plugin output. That error on the report side shouldn't affect it, but I'll take a look at that too! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 17:24:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 16:24:08 +0000 Subject: [Koha-bugs] [Bug 28474] Pass process_message_queue.pl params to before_send_messages plugin hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28474 --- Comment #5 from Katrin Fischer --- > > Pass something parameter like "-t email" and you should see it in the plugin > output. That error on the report side shouldn't affect it, but I'll take a > look at that too! Sorry... what and where is the plugin output? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 17:32:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 16:32:19 +0000 Subject: [Koha-bugs] [Bug 29385] Add missing cash register support to SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29385 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 17:32:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 16:32:22 +0000 Subject: [Koha-bugs] [Bug 29385] Add missing cash register support to SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29385 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127173|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 127178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127178&action=edit Bug 29385: Catch register_id for payments against fees This patch adds the missing cash_register definition in the call to pay with a set of lines defined. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 17:34:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 16:34:56 +0000 Subject: [Koha-bugs] [Bug 29255] Built-in offline circulation broken with SQL error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126373|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 127179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127179&action=edit Bug 29255: Built-in offline circulation broken with SQL error This patch makes a minor correction to one of the queries used when synchronizing transactions in the built-in offline circulation system. This fixes the error: DBD::mysql::st execute failed: Column 'branchcode' in field list is ambiguous at /kohadevbox/koha/offline_circ/download.pl line 84 To test you must be using a browser which still supports applicationCache (Firefox before version 81, Chrome before version 94). - Apply the patch and restart services. - Enable the AllowOfflineCirculation system preference. - Go to Circulation -> Built-in offline circulation interface. - Click "Synchronize." - Click the "Download records" button. - After the page refreshes you should see updated dates where it lists "last synced" information. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 17:35:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 16:35:08 +0000 Subject: [Koha-bugs] [Bug 29255] Built-in offline circulation broken with SQL error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 17:37:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 16:37:52 +0000 Subject: [Koha-bugs] [Bug 29152] Change to default search behavior when limiting by branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29152 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125799|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 127180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127180&action=edit Bug 29152: Change default value for SearchLimitLibrary to 'homebranch' Behvaiour before this option was added was 'homebranch' We should preserve this rather than introduce a change No atomic update added as liobraries may have already set/changed the value, but safer to default to previous behvaiour Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 17:38:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 16:38:18 +0000 Subject: [Koha-bugs] [Bug 29152] Change to default search behavior when limiting by branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29152 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 17:38:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 16:38:44 +0000 Subject: [Koha-bugs] [Bug 29152] Change to default search behavior when limiting by branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29152 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Martin Renvoize --- Trivial fix, no errors in testing. PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 17:43:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 16:43:01 +0000 Subject: [Koha-bugs] [Bug 24370] Editing purchase suggestion changes the acquisition library to logged-in user's In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24370 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125866|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize --- Created attachment 127181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127181&action=edit Bug 24370: Don't reset library when editing a suggestion When editing a suggestion, the library will be reset to the currently logged in librarian's homebranch, no matter what the libray was before. This fixes this, the library selection will remain at the db value when edited. To test: - Create a suggestion with Any library. - Edit the suggestion - it will show your homebranch as library - Change to any library but your homebranch - The summary should show the correct value after saving - Edit the suggestoin again - it's set back to your homebranch again - Apply patch - Repeat the steps, the pull down should now show the correct library at all times. Caveat: I think there is a somewhat separate issue/bug in that once a library was saved, you cannot switch back to "Any". I haven't been able to fix this and suggest to maybe file a separate bug. Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 17:43:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 16:43:05 +0000 Subject: [Koha-bugs] [Bug 24370] Editing purchase suggestion changes the acquisition library to logged-in user's In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24370 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125867|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize --- Created attachment 127182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127182&action=edit Bug 24370: (QA follow-up) Make new suggestions default to the library you re viewing It looks like this problem was caused by code from bug 25033, we were attempting to have the dropdown either be the current branch filter, or the suggestion's branch code, but the variables here are confusing and it didn't work This explicitly sets the branchcode when creating a new suggestion to allow fixing current behaviour and show the correct value when creating new To test: 1 - Be signed in as branch A 2 - Browse to suggestions and limit to branch "Any" 3 - Click 'New suggestion" 4 - Defaults to Any 5 - Cancel and limit to branch B 6 - New suggestion defaults to branch B Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 17:43:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 16:43:10 +0000 Subject: [Koha-bugs] [Bug 24370] Editing purchase suggestion changes the acquisition library to logged-in user's In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24370 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125868|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize --- Created attachment 127183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127183&action=edit Bug 24370: Allow resetting library to ANY Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 17:43:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 16:43:48 +0000 Subject: [Koha-bugs] [Bug 24370] Editing purchase suggestion changes the acquisition library to logged-in user's In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24370 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #25 from Martin Renvoize --- Patches are clear as a set, code works as expected during testing, QA script is happy.. Passing QA here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 17:43:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 16:43:54 +0000 Subject: [Koha-bugs] [Bug 24370] Editing purchase suggestion changes the acquisition library to logged-in user's In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24370 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 18:19:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 17:19:39 +0000 Subject: [Koha-bugs] [Bug 27884] Add html mail support for email report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125755|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 127184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127184&action=edit Bug 27884: Add html support for report mails To test: 1) Create a new notice, for example with Koha module "Patrons", name/code TEST and message body "testing". 2) Create a new sql report, the query could be someting like: SELECT "" as `borrowernumber`, "to at example.com", as `email`, "from at example.com" as `from`; where "" is a valid borrowernumber. 3) Run patron_emailer.pl --report= --notice=TEST --module=members -commit where is the report id. 4) Check the message_queue table that the content_type column has been set to text/html; charset="UTF-8". 5) Ideally process the message queue and veriy that the sent email is displayed as rendered html. 6) Run tests in t/db_dependent/Reports/Guided.t Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 18:19:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 17:19:43 +0000 Subject: [Koha-bugs] [Bug 27884] Add html mail support for email report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125756|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 127185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127185&action=edit Bug 27884: Add tests Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 18:20:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 17:20:15 +0000 Subject: [Koha-bugs] [Bug 27884] Add html mail support for email report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #14 from Martin Renvoize --- Trivial fix covered by tests.. works well.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 18:20:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 17:20:20 +0000 Subject: [Koha-bugs] [Bug 27884] Add html mail support for email report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 18:21:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 17:21:53 +0000 Subject: [Koha-bugs] [Bug 27884] Add HTML mail support for patron emailer script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add html mail support for |Add HTML mail support for |email report |patron emailer script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 18:23:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 17:23:49 +0000 Subject: [Koha-bugs] [Bug 25459] In patron cards layout, barcode position doesn't respect units In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25459 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126474|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 127186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127186&action=edit Bug 25459: Makes barcode position respect units in patron cards layout When using any unit besides postscript points, barcode positionning doesn't work correctly. There is an error in the calculation: the unit factor must be applied to the individual card part only and not to the full page position. This patch moves the unit part of the calculation to the right place. To test : 1. Create a working patron card setup, using postscript points: card template, layout and card batch. Use barcode and at least one other element (text or images) in the layout. => Some tips for testing: - activate guides for the layout - use a template and a batch containing more than one card; the displacement will be different for each card and depend on the barcode position relative to the bottom left of the entire page. 2. Change units from postscript points to any other unit. => At least for the layout, but changing it in the template will scale the page as well. 4. Export the card batch. 3. Note the guides are scaled to fit the new unit and the lower left corner of text and images are still correctly placed relative to the guides, but the barcode is not. => In some cases, the barcode even seem to not print at all since it's new coordinates are out of screen. 4. Apply patch. 5. Generate the batch again. 6. Note the barcode now appears exactly where it should. Signed-off-by: George Veranis Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 18:24:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 17:24:31 +0000 Subject: [Koha-bugs] [Bug 25459] In patron cards layout, barcode position doesn't respect units In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25459 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Must admit, I don't use this feature myself very often.. but the fix does appear to all work and QA scripts are happy.. I can't spot any regressions. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 18:26:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 17:26:31 +0000 Subject: [Koha-bugs] [Bug 29355] Pickup location list limited by RESTdefaultPageSize syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29355 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127074|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 127187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127187&action=edit Bug 29355: Make pickup location dropdowns RESTdefaultPageSize agnostic This patch makes the select2 dropdowns for pickup locations not be limited to the RESTdefaultPageSize syspref limit. To test: 1. Have less than 20 libraries in your system as valid pickup locations 2. Place a hold via the staff client => SUCCESS: See that all your libraries appear in the pickup location dropdowns at the bib and item level 3. Update RESTdefaultPageSize, set the value to something lower than your count of pickup libraries 4. place another hold => FAIL: Your pickup location list gets cut off and only shows as many locations as RESTdefaultPageSize allows 5. Apply this patch 6. Repeat 4 => SUCCESS: All your pickup locations show 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 18:27:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 17:27:10 +0000 Subject: [Koha-bugs] [Bug 29355] Pickup location list limited by RESTdefaultPageSize syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29355 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize --- Cool.. I wasn't aware passing -1 for page size worked to disable the limits.. nice. Works as expected, QA scripts are happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 18:29:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 17:29:35 +0000 Subject: [Koha-bugs] [Bug 29356] Search for pickup library when placing a hold should be truncated in both directions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29356 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127077|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 127188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127188&action=edit Bug 29356: Pickup location dropdowns should perform 'contains' searches When placing a hold, the dropdowns for selecting a pickup library automatically right-truncate, so one can type "cen" and find Centerville. On the Libraries page in Admin, however, the search box both left- and right-truncates, so one can type "en" and find Centerville. This patch makes the search perform 'contains' searches. To test: 1. Try placing a hold. Make sure your rules allow Centerville to be a valid pickup location. 2. Search 'cen' => SUCCESS: Centerville shows 3. Search 'en => FAIL: Centerville doesn't show 4. Apply this patch and reload 5. Repeat 2 => SUCCESS: Works! 6. Repeat 3 => SUCCSS: Centerville shows! 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 18:30:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 17:30:21 +0000 Subject: [Koha-bugs] [Bug 29356] Search for pickup library when placing a hold should be truncated in both directions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29356 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Must admit, I find this a little weird and prefer 'starts-with'.. but, consistency is good. Works as described, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 18:33:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 17:33:56 +0000 Subject: [Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126865|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 127189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127189&action=edit Bug 27992: Call AddReturn if borrower is statistical patron To test: 1. Create a Statistical Patron 2. Check out an item to the Stat Patron, that is checked out to another user 3. See that the local use is recorded, but the item does not get checked in 4. Check out an item that has a lost status and note that the local use is recorded, and the lost status is cleared 5. Item is NOT checked in 6. Apply patch 7. Repeat steps 2 - 4. 8. Item is checked in and now seen as available Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 18:34:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 17:34:00 +0000 Subject: [Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 --- Comment #10 from Lucas Gass --- (In reply to Katrin Fischer from comment #9) > Sorry, not trying to throw this out, but: > > +$template->param( > + OpacStarRatings => C4::Context->preference("OpacStarRatings") > +); > + > > Should we not remove this in favor of using TT in the template? Indeed, we should! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 18:35:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 17:35:41 +0000 Subject: [Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize --- Works as described, no obvious regressions and the QA scripts are happy. I'm not sure how any outstanding fines, lost item charges should be handled in this case.. but I feel that could be handled as a follow-up bug if we discover a need. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 18:36:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 17:36:12 +0000 Subject: [Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 18:36:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 17:36:15 +0000 Subject: [Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 --- Comment #11 from Lucas Gass --- Created attachment 127190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127190&action=edit Bug 29280: (follow-up) Move OpacStarRating logic to template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 18:36:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 17:36:40 +0000 Subject: [Koha-bugs] [Bug 29223] Auto-renewals can fail when not digested per branch and patron requests digest In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29223 --- Comment #8 from Nick Clemens --- (In reply to Joonas Kylmälä from comment #7) > (In reply to Joonas Kylmälä from comment #6) > > Passing QA. > > Have to take back the PQA. The letter template is changed from global to the > patron's library specific one. For the individual messages we use currently > the global letter template. The line > > > branchcode => $params->{branchcode}, > > should be restored basically so we will use the default template when > $params->{branchcode} is undef. As discussed in the bug 23296 we should > probably use the branch defined by CircControl but that development can be > continued in bug 23296. I think this change is correct, defaulting to the borrowers branch for a digest and falling back to general only if one is not defined -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 18:55:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 17:55:08 +0000 Subject: [Koha-bugs] [Bug 28474] Pass process_message_queue.pl params to before_send_messages plugin hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28474 --- Comment #6 from Kyle M Hall --- (In reply to Katrin Fischer from comment #5) > > > > Pass something parameter like "-t email" and you should see it in the plugin > > output. That error on the report side shouldn't affect it, but I'll take a > > look at that too! > > Sorry... what and where is the plugin output? if you run something like "./misc/cronjobs/process_message_queue.pl -t email" you should see some output from the script like: Plugin hook before_send_message called with the params: $VAR1 = { 'limit' => undef, 'letter_code' => undef, 'verbose' => undef, 'type' => 'email' }; on the command line -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 19:06:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 18:06:13 +0000 Subject: [Koha-bugs] [Bug 29339] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29339 maxwellmarco1727 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxwellmarco1727 at gmail.com URL| |https://www.allassignmenthe | |lp.com/pay-someone-to-take- | |my-online-class.html -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 19:22:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 18:22:14 +0000 Subject: [Koha-bugs] [Bug 29339] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29339 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://www.allassignmenthe | |lp.com/pay-someone-to-take- | |my-online-class.html | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 19:28:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 18:28:12 +0000 Subject: [Koha-bugs] [Bug 29223] Auto-renewals can fail when not digested per branch and patron requests digest In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29223 --- Comment #9 from Joonas Kylmälä --- (In reply to Nick Clemens from comment #8) > I think this change is correct, defaulting to the borrowers branch for a > digest and falling back to general only if one is not defined Hmm, I see. I guess the feature change introduced in this bug fix is not too bad: the user can just remove the branch specific digest messages and it will use the global one. So the same behaviour can be gained even after this change. I'm unobsoleting the patch I signed off and marking this as PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 19:29:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 18:29:11 +0000 Subject: [Koha-bugs] [Bug 29223] Auto-renewals can fail when not digested per branch and patron requests digest In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29223 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127137|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 19:29:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 18:29:29 +0000 Subject: [Koha-bugs] [Bug 29223] Auto-renewals can fail when not digested per branch and patron requests digest In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29223 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 19:29:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 18:29:54 +0000 Subject: [Koha-bugs] [Bug 29223] Auto-renewals can fail when not digested per branch and patron requests digest In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29223 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126228|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 19:48:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 18:48:03 +0000 Subject: [Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #82 from Arthur Suzuki --- (In reply to Victor Grousset/tuxayo from comment #81) > > Hope this one can go to stable and old-stable as well :) > > Do you confirm that it's not changing any behavior somewhere else? Like it's > just adding routes, right? Yes, it just adds routes to make the Suggestions accessible from the API. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 21:32:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 20:32:03 +0000 Subject: [Koha-bugs] [Bug 21860] Marc modification templates cannot check or change indicators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #9 from Hayley Pelham --- Hi Martin, I am in the process of trying to get client sign off on some work that'd been done in this area. Anyone feel free to pick it up in the meantime if you have some time! Cheers, Hayley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 21:50:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 20:50:34 +0000 Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 --- Comment #21 from Katrin Fischer --- Testing this again and all seems to work as advertised, but there are some things that keep irritating me (unrelated to this patch, so not blocker): * If I have a record level hold and I have 2 items for the record, that are identical apart from collection, how is the collection that shows on holds queue chosen? Only one shows and I can only filter on the one that shows... * We can limit on library, so then I know which library I am looking at. But... when I choose "All", there seems to be no clue in the table about the library that owns the item and is supposed to provide it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 22:02:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 21:02:07 +0000 Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 22:02:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 21:02:11 +0000 Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125422|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer --- Created attachment 127191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127191&action=edit Bug 29015: (follow-up) Show sidebar filter form with results This patch adds the new filter form in the sidebar when showing results. To do so the form markup is moved into a BLOCK so that it can be reused. This patch also adds pre-selection of submitted options on the filter form so that it reflects the user's choices. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Circulation -> Holds queue. - Submit the form with one or more filters selected. - On the results page the queue should be correctly filtered and the sidebar should show your search fields preselected. - Test with the CircSidebar preference enabled and disabled. The circulation menu should appear correctly, with the filter form only displaying in the sidebar after submitting the form. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 22:02:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 21:02:16 +0000 Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125423|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer --- Created attachment 127192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127192&action=edit Bug 29015: (follow-up) Default to logged in branch unless viewing queue Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 22:02:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 21:02:20 +0000 Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 --- Comment #24 from Katrin Fischer --- Created attachment 127193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127193&action=edit Bug 29015: (QA follow-up) Change collection code to be just collection We did some clean-up in that area a little while ago, agreeing that as we acutally display the descriptions, the label should be just "collection". This patch also removes some (): Before: 4 items found for Centerville and item type:(Books) and collection: (Reference) and shelving location: (General Stacks) Now: 4 items found for Centerville and item type: Books and collection: Reference and shelving location: General Stacks Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 22:04:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 21:04:49 +0000 Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125420|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer --- Created attachment 127194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127194&action=edit Bug 29015: Add options for itemtype, collection, and shelving location to view_holdsqueue.pl This patch makes the code for itemtypeslimit work, and adds options for shelving location and collection code This also remove the 'post' method from the form to allow easy bookmarking To test: 1 - Add holds to your system 2 - Run the holds queue builder 3 - Browse to Circulation->Holds queue 4 - Note the library dropdown 5 - Apply patch 6 - Reload and note new options 7 - Test that both limits and 'All' options work as expected 8 - Note that description at top includes options when selected "### items found for All libraries and item type:(Books)" Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 22:04:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 21:04:52 +0000 Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125421|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer --- Created attachment 127195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127195&action=edit Bug 29015: Unit tests Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 22:04:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 21:04:57 +0000 Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127191|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer --- Created attachment 127196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127196&action=edit Bug 29015: (follow-up) Show sidebar filter form with results This patch adds the new filter form in the sidebar when showing results. To do so the form markup is moved into a BLOCK so that it can be reused. This patch also adds pre-selection of submitted options on the filter form so that it reflects the user's choices. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Circulation -> Holds queue. - Submit the form with one or more filters selected. - On the results page the queue should be correctly filtered and the sidebar should show your search fields preselected. - Test with the CircSidebar preference enabled and disabled. The circulation menu should appear correctly, with the filter form only displaying in the sidebar after submitting the form. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 22:05:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 21:05:01 +0000 Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127192|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer --- Created attachment 127197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127197&action=edit Bug 29015: (follow-up) Default to logged in branch unless viewing queue Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 22:05:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 21:05:05 +0000 Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127193|0 |1 is obsolete| | --- Comment #29 from Katrin Fischer --- Created attachment 127198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127198&action=edit Bug 29015: (QA follow-up) Change collection code to be just collection We did some clean-up in that area a little while ago, agreeing that as we acutally display the descriptions, the label should be just "collection". This patch also removes some (): Before: 4 items found for Centerville and item type:(Books) and collection: (Reference) and shelving location: (General Stacks) Now: 4 items found for Centerville and item type: Books and collection: Reference and shelving location: General Stacks Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 22:08:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 21:08:11 +0000 Subject: [Koha-bugs] [Bug 28474] Pass process_message_queue.pl params to before_send_messages plugin hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28474 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 22:08:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 21:08:15 +0000 Subject: [Koha-bugs] [Bug 28474] Pass process_message_queue.pl params to before_send_messages plugin hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28474 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126090|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 127199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127199&action=edit Bug 28474: Pass process_message_queue.pl params to before_send_messages plugin hooks It would be useful to send most of the process_message_queue.pl script parameters to any plugin before_send_messages hooks. For example, the Twilio Voice plugin uses before_send_messages to send phone messages, but if the script is called with "-t email", it doesn't know and will make phone calls! If that info were passed in, the plugin could be made aware of it and only make calls if no "-t" or a "-t phone" were set in the parameters. Test Plan: 1) Apply this patch 2) Install Kitchen Sink plugin v2.2.0 or later https://github.com/bywatersolutions/dev-koha-plugin-kitchen-sink/releases/download/v2.2.0/dev-koha-plugin-kitchen-sink-2.2.0.kpz 3) Run misc/cronjobs/process_message_queue.pl with any or all non-email related paramters 4) Note the plugin output shows the parameters were passed to the plugin Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 22:18:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 21:18:08 +0000 Subject: [Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 22:18:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 21:18:12 +0000 Subject: [Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126899|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 127200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127200&action=edit Bug 29280: Add OpacStarRatings to opac-shelves.tt To test: -Apply patch and restart everything -Set the system preference 'OpacStarRatings' to 'results, detail, lists, and patron' -Build a public lists with some items that have ratings -View the list page and you should see the ratings appear -Make sure that the ratings and the number of votes are acurate -Ratings on the opac-shelves should look and function just like those on the OPAC results page -Turn the 'OpacStarRatings' system pref to 'only detials' and 'no', making sure they do not show in the lists display Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 22:18:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 21:18:16 +0000 Subject: [Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126900|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 127201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127201&action=edit Bug 29280: (follow-up) add event handler when clicking on star ratings Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 22:18:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 21:18:20 +0000 Subject: [Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127190|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 127202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127202&action=edit Bug 29280: (follow-up) Move OpacStarRating logic to template Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 22:32:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 21:32:45 +0000 Subject: [Koha-bugs] [Bug 26402] Add --framework parameter to commit_file.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26402 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 22:32:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 21:32:49 +0000 Subject: [Koha-bugs] [Bug 26402] Add --framework parameter to commit_file.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26402 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127093|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 127203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127203&action=edit Bug 26402: Add --framework parameter to commit_file.pl This patch adds the option to pass a frameworkcode to the commit_file.pl script. To test: 1. Stage a MARC file using stage_file.pl. For instance using the devbox: cd ~/kohaclone sudo koha-shell -c 'perl misc/stage_file.pl --file t/db_dependent/www/data/marc21record.mrc' kohadev 2. Note the assigned batch number and commit the batch using --framework parameter to commit_file.pl. For example using the devbox: sudo koha-shell -c 'perl misc/commit_file.pl --batch-number 1 --framework ACQ' kohadev 3. Verify that the framework code was correctly assigned: sudo koha-mysql kohadev -e 'SELECT frameworkcode FROM biblio ORDER BY timestamp DESC LIMIT 1;' => SUCCESS: It picked it Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 22:34:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 21:34:17 +0000 Subject: [Koha-bugs] [Bug 29010] Weight input pattern wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29010 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |domm at plix.at |ity.org | --- Comment #6 from Katrin Fischer --- Don't forget to assign a patch to yourself using the Assignee field once you start working on a patch :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 23:13:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 22:13:58 +0000 Subject: [Koha-bugs] [Bug 29383] Vendors with lots of orders causes timeouts when receiving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29383 --- Comment #2 from Aleisha Amohia --- Hi Katrin Thanks for this, it might be! I'll give it a go and see if it solves our problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 23:20:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 22:20:30 +0000 Subject: [Koha-bugs] [Bug 29365] Koha::Email needs to be refactored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29365 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 23:23:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 22:23:43 +0000 Subject: [Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- I can't even get auto-renewal digest messages to send... Isn't "--send-notices" a deprecated option? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 23:29:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 22:29:09 +0000 Subject: [Koha-bugs] [Bug 29010] Weight input pattern wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29010 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18316 --- Comment #7 from Katrin Fischer --- I was checking how we handle other decimal fields and for accounting we have: The patch has: >From documentation I think if we want to support decimals we should change the inputmode from numeric to decimal and maybe make the pattern a bit more specific. For example see: https://developer.mozilla.org/de/docs/Web/HTML/Global_attributes/inputmode What do you think? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 [Bug 18316] Add weighting/relevancy options to ElasticSearch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 23:29:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 22:29:09 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29010 [Bug 29010] Weight input pattern wrong -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 1 23:58:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Nov 2021 22:58:26 +0000 Subject: [Koha-bugs] [Bug 29380] Auto renewing, batch due date extension tool and checkout note previews are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29380 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 01:32:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 00:32:43 +0000 Subject: [Koha-bugs] [Bug 27883] Add ability to preserve patron field from being overwritten by import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27883 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | CC| |david at davidnind.com Text to go in the| |This enhancement to the release notes| |patron import tool lets you | |keep current values for | |selected fields. When the | |data is imported the | |selected fields are not | |overwritten for existing | |patrons. | | | |When importing: | |- | |match to existing patrons | |using either their card | |number or user name | |- | |select the fields that will | |not be overwritten under | |'Preserve existing values'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 03:33:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 02:33:06 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #12 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #10) > (In reply to Marcel de Rooy from comment #9) > > Will give it a try now > > Yes, it looks like David was right. This might not be a minimal fix. The > add_attachments stuff in C4::Letters does not seem to work well with > Email::Stuffer. Imo we should go back to Email::MIME in Koha::Email. > > More comments on bug 29365 Koha::Email used to be just a wrapper for a hashref used to build something suitable for passing to Mail::Sendmail. We didn't use Email::MIME. Multi-part emails with attachments were built by concatenating manually crafted strings... That said, there's room for improvement. Using Email::MIME is hard, and error prone. That's why the author (of both libraries, and Email::Simple, Email::Sender, etc) suggests using Email::Stuffer. I don't think it is urgent to replace Email::Stuffer because its API has design issues. In fact, if required we can add MIME content manually. I hadn't payed attention to this bugs and will now. If the problem is how emails are serialized on the db, maybe we can use Koha::Email->to_string (inherited from Email::Stuffer). But as I said, I've just discovered this bugs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 09:30:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 08:30:54 +0000 Subject: [Koha-bugs] [Bug 29261] Translation script breaks members/tables/members_results.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29261 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #8 from Jonathan Druart --- This didn't work, the original problem is still there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 09:31:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 08:31:15 +0000 Subject: [Koha-bugs] [Bug 29261] Translation script breaks members/tables/members_results.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29261 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed, | |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 09:46:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 08:46:43 +0000 Subject: [Koha-bugs] [Bug 29261] Translation script breaks members/tables/members_results.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29261 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 09:46:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 08:46:47 +0000 Subject: [Koha-bugs] [Bug 29261] Translation script breaks members/tables/members_results.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29261 --- Comment #9 from Jonathan Druart --- Created attachment 127204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127204&action=edit Bug 29261: (bug 15812 follow-up 3) Fix translation issue in include file This is getting messy. No idea how I tested the previous patches but it was not working, the problem still persisted. This patch is using the I18N TT plugin to make things easier and fix the original problem. Test plan: Apply the patch perl translate update fi-FI Edit misc/translator/po/fi-FI-messages.po Locate and translate "Check out" 61 #: koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt:20 62 msgid "Check out" 63 msgstr "Laina" Locate and transate "View" 182 #: koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt:22 183 msgid "View" 184 msgstr "Nayta" Apply the change to the fi-FI templates perl translate install fi-FI Now enable the fi-FI in the lang syspref, search for patron and confirm that the result view is displayed correctly. Note that the "Check out" and "View" strings are correctly translated (when you hover the cardnumbers or patron's names) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 09:59:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 08:59:59 +0000 Subject: [Koha-bugs] [Bug 29386] New: baground jobs table data field is a TEXT which is too small Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 Bug ID: 29386 Summary: baground jobs table data field is a TEXT which is too small Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: didier.gautheron at biblibre.com QA Contact: testopia at bugs.koha-community.org Depends on: 22417 Hi, With a big enough batch record modification list you end with an error: Template process failed: undef error - , or } expected while parsing object/hash, at character offset 65535 (before "(end of string)") at /home/koha/src/Koha/BackgroundJob.pm line 179. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 [Bug 22417] Add a task queue -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 09:59:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 08:59:59 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Didier Gautheron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29386 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 [Bug 29386] baground jobs table data field is a TEXT which is too small -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 10:00:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 09:00:07 +0000 Subject: [Koha-bugs] [Bug 27883] Add ability to preserve patron field from being overwritten by import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27883 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement to the |This enhancement to the release notes|patron import tool lets you |patron import tool lets you |keep current values for |keep current values for |selected fields. When the |selected fields for |data is imported the |existing patrons - when the |selected fields are not |data is imported the |overwritten for existing |selected fields are not |patrons. |overwritten. | | |When importing: |When |- |importing: |match to existing patrons |- match to |using either their card |existing patrons using |number or user name |either their card number or |- |user name |select the fields that will |- select the |not be overwritten under |fields that will not be |'Preserve existing values'. |overwritten under 'Preserve | |existing values'. Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 10:07:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 09:07:17 +0000 Subject: [Koha-bugs] [Bug 25464] Add ability to specify client IP and SIP account used in SIP2 logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25464 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This enhancement adds the release notes| |ability to specify the | |incoming IP address used | |for a given log statement | |via SIP, as well as the | |SIP2 account that was in | |use at the time. This data | |is very helpful for | |debugging purposes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 10:34:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 09:34:42 +0000 Subject: [Koha-bugs] [Bug 28242] Accessibility: OPAC - add captions and legends to tables and forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |As part of improving OPAC release notes| |accessibility this change | |ensures that all tables | |have relevant captions and | |all forms have relevant | |legends - this makes | |navigation easier for | |people using a screen | |reader. | | | |Note: Many of the | |captions and legends have | |class="sr-only" so they are | |not visible, but are | |available for people who | |use a screen reader. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 10:38:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 09:38:59 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 --- Comment #25 from Emmi Takkinen --- Thanks Katrin for feedback! Points 2 and 3 are easy fix, but I don't really know what that QA tool error means or how to fix it (seems like similar error occurred in bug 23271, something about circular dependency). I'll look more into it, if someone knows how to fix this feel free to do so. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 10:42:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 09:42:54 +0000 Subject: [Koha-bugs] [Bug 29387] New: BatchUpdateBiblio does not handle exception correctly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 Bug ID: 29387 Summary: BatchUpdateBiblio does not handle exception correctly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Tools Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 22417 If an exception is raised by one the methods/subroutines called when batch biblio update, the job will fail in the middle and some records won't be processed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 [Bug 22417] Add a task queue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 10:42:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 09:42:54 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29387 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 [Bug 29387] BatchUpdateBiblio does not handle exception correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 10:48:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 09:48:06 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 10:48:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 09:48:09 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 --- Comment #1 from Jonathan Druart --- Created attachment 127205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127205&action=edit Bug 29387: Stringify exception when logging error during a batch mod biblio If an exception is raised by one the methods/subroutines called when batch biblio update, the job will fail in the middle and some records won't be processed. Test plan: 0. Don't apply the patch In KTD you can run the a batch mod biblio on the 100 first records and the worker will fail with """ countered object 'C4::Biblio::_koha_modify_biblioitem_nonmarc(): DBI Exception: DBD::mysql::st execute failed: Data too long for column 'lccn' at row 1 at /kohadevbox/koha/C4/Biblio.pm line 423 ', but neither allow_blessed, convert_blessed nor allow_tags settings are enabled (or TO_JSON/FREEZE method missing) at /kohadevbox/koha/Koha/BackgroundJob/BatchUpdateBiblio.pm line 120. """ The UI is not saying anything about this problem. Generate 100 biblionumbers: perl -e 'for (1..100){print "$_\n"}' 1. Apply the patch and confirm than now you see the detail of the batch update and that biblionumber 72 is marked as not been modified with the correct error (raw DBI error) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 10:48:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 09:48:21 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 11:05:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 10:05:14 +0000 Subject: [Koha-bugs] [Bug 29386] baground jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- I was going to open this bug report! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 11:05:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 10:05:27 +0000 Subject: [Koha-bugs] [Bug 29386] baground jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 11:08:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 10:08:31 +0000 Subject: [Koha-bugs] [Bug 26852] Add missing X11$e and remove relator term subfields from MARC21 headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This patch adds $e to 111 release notes| |and 611, but removes it | |from 100 and 110 as it's | |used for the relator term | |there and should not be | |copied. Same for 111$j. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 11:12:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 10:12:41 +0000 Subject: [Koha-bugs] [Bug 29386] baground jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 --- Comment #2 from Jonathan Druart --- I have been running some tests BatchUpdateBiblio will have data with 230 chars for 1 record 836 chars for 10 records 7065 chars for 100 records 28470 chars for 400 records Seems linear so currently the tool has a limit of 800 records. Switching to MEDIUMTEXT will allow ~230k records Switching to LONGTEXT will allow ~60M records This is only an estimate (and the maximum), as the tool can log error, extra info, etc. which will take more characters. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 11:19:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 10:19:25 +0000 Subject: [Koha-bugs] [Bug 29386] baground jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 --- Comment #3 from Jonathan Druart --- BatchUpdateItem 1 item => 185 chars 10 items => 277 chars 100 items => 1171 chars 500 items => 5097 chars -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 11:20:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 10:20:22 +0000 Subject: [Koha-bugs] [Bug 29386] background jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|baground jobs table data |background jobs table data |field is a TEXT which is |field is a TEXT which is |too small |too small -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 11:41:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 10:41:17 +0000 Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 --- Comment #39 from Jonathan Druart --- Created attachment 127206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127206&action=edit Bug 28959: Fix occurrence in tools/batch_record_modification.pl No method count found for Koha::Virtualshelves DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'category' in 'where clause' at /kohadevbox/koha/Koha/Objects.pm line 601 at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt line 80. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 11:41:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 10:41:50 +0000 Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 11:44:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 10:44:25 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127205|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 127207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127207&action=edit Bug 29387: Stringify exception when logging error during a batch mod biblio If an exception is raised by one the methods/subroutines called when batch biblio update, the job will fail in the middle and some records won't be processed. Test plan: 0. Don't apply the patch In KTD you can run the a batch mod biblio on the 100 first records and the worker will fail with """ countered object 'C4::Biblio::_koha_modify_biblioitem_nonmarc(): DBI Exception: DBD::mysql::st execute failed: Data too long for column 'lccn' at row 1 at /kohadevbox/koha/C4/Biblio.pm line 423 ', but neither allow_blessed, convert_blessed nor allow_tags settings are enabled (or TO_JSON/FREEZE method missing) at /kohadevbox/koha/Koha/BackgroundJob/BatchUpdateBiblio.pm line 120. """ The UI is not saying anything about this problem. Generate 100 biblionumbers: perl -e 'for (1..100){print "$_\n"}' 1. Apply the patch and confirm than now you see the detail of the batch update and that biblionumber 72 is marked as not been modified with the correct error (raw DBI error) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 11:59:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 10:59:56 +0000 Subject: [Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #83 from Jonathan Druart --- "Just add routes" is not as trivial as it sounds. We could introduce permission issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 12:00:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 11:00:09 +0000 Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124521|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 127208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127208&action=edit Bug 28782: Use query param list instead of splitting elements using '/' This removes the need to handle single and multiple cases separately, thus removing bunch if-else cases and simplifying our code. This coding style is also in line with our other .pl scripts. To test: 1) Make sure placing a hold still works from the following pages: /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX /cgi-bin/koha/catalogue/search.pl?q=a /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=XXXX /cgi-bin/koha/clubs/clubs.pl (create a new club and add a patron there and through the clubs.pl create a hold to a bib) Signed-off-by: Hayley Pelham Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 12:00:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 11:00:13 +0000 Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127112|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize --- Created attachment 127209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127209&action=edit Bug 28782: (follow-up) Pass real array to query_form() It excepts to receive a real array and not a list, in order to be able to generate the query parameters. Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 12:00:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 11:00:44 +0000 Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #17 from Martin Renvoize --- Nice improvement, no regressions found.. QA scripts happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 12:11:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 11:11:21 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #46 from Jonathan Druart --- Comment on attachment 125960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125960 Bug 15812: (follow-up) Enable click cell to select Review of attachment 125960: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15812&attachment=125960) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt @@ +13,4 @@ > { > [% IF CAN_user_borrowers_edit_borrowers || CAN_user_tools_manage_patron_lists %] > "dt_borrowernumber": > + "", This is a bit weird, we are adding a new string "Select patron" that will never be displayed (but is translatable however). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 12:19:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 11:19:33 +0000 Subject: [Koha-bugs] [Bug 29010] Weight input pattern wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29010 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 12:25:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 11:25:22 +0000 Subject: [Koha-bugs] [Bug 28453] Update pagination subroutine to generate Bootstrap markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 12:25:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 11:25:25 +0000 Subject: [Koha-bugs] [Bug 28453] Update pagination subroutine to generate Bootstrap markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 --- Comment #10 from Owen Leonard --- Created attachment 127210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127210&action=edit Bug 28453: (follow-up) Make pagination labels translatable This patch moves the English strings out of Output.pm and adds classes to the pagination markup which can be used as hooks for JavaScript. The global JS include is modified to look for these hooks and add text labels to the links. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 12:26:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 11:26:55 +0000 Subject: [Koha-bugs] [Bug 29388] New: No need to decode data from misc/background_jobs_worker.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29388 Bug ID: 29388 Summary: No need to decode data from misc/background_jobs_worker.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org >From misc/background_jobs_worker.pl we are decoding the data, and pass it as an argument to ->process, this is a bit weird as we are fetching the job from ->process we could retrieve the data from there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 12:27:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 11:27:01 +0000 Subject: [Koha-bugs] [Bug 29388] No need to decode data from misc/background_jobs_worker.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29388 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22417 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 [Bug 22417] Add a task queue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 12:27:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 11:27:01 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29388 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29388 [Bug 29388] No need to decode data from misc/background_jobs_worker.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 12:27:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 11:27:42 +0000 Subject: [Koha-bugs] [Bug 29388] No need to decode data from misc/background_jobs_worker.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29388 --- Comment #1 from Jonathan Druart --- Created attachment 127211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127211&action=edit Bug 29388: don't decode data from misc/background_jobs_worker.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 12:29:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 11:29:59 +0000 Subject: [Koha-bugs] [Bug 29388] No need to decode data from misc/background_jobs_worker.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29388 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |INVALID --- Comment #2 from Jonathan Druart --- Logging that here as I won't do the same mistake again. This is actually invalid, see the FIXME: 59 # FIXME This means we need to have create the DB entry before 60 # It could work in a first step, but then we will want to handle job that will be created from the message received 61 my $job = Koha::BackgroundJobs->find($args->{job_id}); We actually need a way to enqueue without creating the row in DB, sending the request to RabbitMQ would be enough. Isn't it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 12:31:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 11:31:44 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #47 from Martin Renvoize --- It's for screen readers I believe... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 12:39:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 11:39:21 +0000 Subject: [Koha-bugs] [Bug 29168] Only show "Request article" if allowed on the detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168 --- Comment #14 from Jonathan Druart --- This is getting complicated. I think it should be simplified. Isn't the following correct/enough? if ( $patron && $patron->can_request_article ) { $artreqpossible = $biblio->can_article_request( $patron ); } elsif ( $itemtype ) { $artreqpossible = $itemtype->may_article_request } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 12:57:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 11:57:07 +0000 Subject: [Koha-bugs] [Bug 29389] New: Add holding branch to holds queue report Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29389 Bug ID: 29389 Summary: Add holding branch to holds queue report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When viewing 'All' branches for the holds queue, it would be nice to be able to see which branch the item is located in -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:01:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:01:11 +0000 Subject: [Koha-bugs] [Bug 29389] Add holding branch to holds queue report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29389 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29015 Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 [Bug 29015] Add option to limit Holds Queue report by shelving location / collection -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:01:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:01:11 +0000 Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29389 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29389 [Bug 29389] Add holding branch to holds queue report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:01:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:01:14 +0000 Subject: [Koha-bugs] [Bug 29389] Add holding branch to holds queue report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29389 --- Comment #1 from Nick Clemens --- Created attachment 127212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127212&action=edit Bug 29389: Add holding branch to the holds queue report This patch adds the holding branch to the hold queue report. It is added as hidden by default, when running per branch it is not needed To test: 1 - Place some holds in your system 2 - perl misc/cronjobs/holds/build_holdsqueue.pl 3 - View the holds queue 4 - Note there is no holding branch column 5 - Apply patch 6 - Reload 7 - Note the column is not there 8 - Click column setting gear 9 - Check the column and confirm it appears 10 - Confirmthe filter works -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:02:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:02:25 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:02:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:02:29 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #6 from Jonathan Druart --- Created attachment 127213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127213&action=edit Bug 29341: Don't modify the branchcode for stats -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:02:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:02:41 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #7 from Jonathan Druart --- (In reply to Joonas Kylmälä from comment #5) > This messes up the statistic table, people are expecting there to be > 'OPACRenew' as the value and not NULL. If you don't want to make this a huge > patch I would suggest to just drop the foreign key for the > 'transaction_branchcode' in pseudonymized_transactions table. I also assume > people don't want there to be foreign key relation in order to be able to > delete branches and still keep the stats in place. > > However, if you want to go the original patch's route, which I think not, > then the change should be done in Koha::Item::renewal_branchcode instead. > The syspref documentation and database upgrade would need to be provided as > well. Oops, my bad! Thanks! I think we want to keep the FK, this patch (can be squashed) is modifying the branchcode AFTER the stat entry has been created. Sonia, Lyon 3, can you confirm the expected behaviour please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:04:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:04:23 +0000 Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 --- Comment #30 from Nick Clemens --- (In reply to Katrin Fischer from comment #21) > Testing this again and all seems to work as advertised, but there are some > things that keep irritating me (unrelated to this patch, so not blocker): > > * If I have a record level hold and I have 2 items for the record, that are > identical apart from collection, how is the collection that shows on holds > queue chosen? Only one shows and I can only filter on the one that shows... Yes, the holds queue chooses a single item to fill the hold, so you see the one chosen. The script uses a lot of logic to determine which is the 'best' item, and we choose only one so that only one library attempts to fill the hold > * We can limit on library, so then I know which library I am looking at. > But... when I choose "All", there seems to be no clue in the table about the > library that owns the item and is supposed to provide it? Bug 29389 filed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:05:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:05:28 +0000 Subject: [Koha-bugs] [Bug 29307] marc record fetched twice in detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 --- Comment #5 from Jonathan Druart --- (In reply to Joonas Kylmälä from comment #4) > They don't do quite the same thing, GetMarcBiblio calls > C4::Biblio::_koha_marc_update_bib_ids() and $biblio->metadata->record > doesn't. What differences do you expect? The point of those tests is to not explode later basically, so we must know if the record has a valid MARCXML stored in the biblio_metadata table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:08:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:08:46 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 --- Comment #15 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #0) > To test: > my @patrons = Koha::Patrons->new->empty; > Dumper(@patrons); What is the practical use of doing so? I would prefer my @patrons; Was there some intention to use empty with chaining? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:12:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:12:48 +0000 Subject: [Koha-bugs] [Bug 29290] Add routes to fetch checkouts for a given biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29290 --- Comment #21 from Jonathan Druart --- (In reply to Joonas Kylmälä from comment #20) > This broke a few scripts, please review bug 29380 which contains fixes for > those. I completely overlooked that patch. It was definitely a candidate for its own bug, it needs to be advertised in the release notes as well (may break plugins, notice templates, custom scripts, etc.). Also it would have been nice to rename other ->borrower methods then. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:16:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:16:06 +0000 Subject: [Koha-bugs] [Bug 29380] Auto renewing, batch due date extension tool and checkout note previews are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29380 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #6 from Jonathan Druart --- This one seems valid as well: circ/renew.pl 66 $borrower = $issue->borrower(); Can't locate object method "borrower" via package "Koha::Schema::Result::Issue" at /kohadevbox/koha/circ/renew.pl line 66 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:28:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:28:46 +0000 Subject: [Koha-bugs] [Bug 29390] New: Authorised values: Why not adding the FK on the way? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 Bug ID: 29390 Summary: Authorised values: Why not adding the FK on the way? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Because it is too much work :) Moving patches from 29336 to this one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:29:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:29:15 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29390 --- Comment #17 from Marcel de Rooy --- I am spending too much time right now on this. I have stumbled over several things, might be too long constraint names, etc. Now in the installer the order of the tables must be rearranged in kohastructure to get FKs in. Will move the FK stuff to another report. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 [Bug 29390] Authorised values: Why not adding the FK on the way? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:29:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:29:15 +0000 Subject: [Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29336 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 [Bug 29336] Some authorised_value FKs are too short -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:29:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:29:33 +0000 Subject: [Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] Omnibus: Add explicit foreign key constraints -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:29:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:29:33 +0000 Subject: [Koha-bugs] [Bug 5334] Omnibus: Add explicit foreign key constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29390 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 [Bug 29390] Authorised values: Why not adding the FK on the way? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:29:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:29:52 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|5334 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] Omnibus: Add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:29:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:29:52 +0000 Subject: [Koha-bugs] [Bug 5334] Omnibus: Add explicit foreign key constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29336 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 [Bug 29336] Some authorised_value FKs are too short -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:30:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:30:23 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:30:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:30:25 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127171|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:30:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:30:27 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127172|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:32:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:32:12 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 --- Comment #16 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #15) > (In reply to Tomás Cohen Arazi from comment #0) > > To test: > > my @patrons = Koha::Patrons->new->empty; > > Dumper(@patrons); > > What is the practical use of doing so? You should git grep '\->empty' The existence of ->empty is meant for consistency in results, and also to avoid querying the DB for empty results when we know in advance that we need an empty resultset. > I would prefer my @patrons; Right, but my example was too simple. Sometimes ->empty is called implicitly somewhere else, far from the code you're looking at. > Was there some intention to use empty with chaining? empty is there so you don't need to do things like: if ( $result->count > 0 ) { $result = $result->filter_by_something_else; } you just chain your queries and know it will work... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:32:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:32:57 +0000 Subject: [Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 --- Comment #1 from Marcel de Rooy --- Created attachment 127214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127214&action=edit Bug 29390: Allow to check on FK existence with field name Sometimes easier (or even safer) to check for FK on specific field name rather than constraint name (which may be created automatically). Test plan: Run t/db_dependent/Installer.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:33:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:33:01 +0000 Subject: [Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 --- Comment #2 from Marcel de Rooy --- Created attachment 127215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127215&action=edit Bug 29390: Add a few missing FK constraints to authorised values Test plan: Run dbrev or new install. WORK IN PROGRESS -- POSTPONED 02-11-2021 * Fix constraint names * Fix table order -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:33:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:33:51 +0000 Subject: [Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | CC| |jonathan.druart+koha at gmail. | |com Status|NEW |ASSIGNED --- Comment #3 from Marcel de Rooy --- Any advice, Jonathan, as to best way to proceed here ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:39:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:39:14 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #18 from Marcel de Rooy --- Still nice to have in 21.11 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:40:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:40:59 +0000 Subject: [Koha-bugs] [Bug 28926] Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:43:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:43:10 +0000 Subject: [Koha-bugs] [Bug 29290] Add routes to fetch checkouts for a given biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29290 --- Comment #22 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #21) > (In reply to Joonas Kylmälä from comment #20) > > This broke a few scripts, please review bug 29380 which contains fixes for > > those. > > I completely overlooked that patch. > > It was definitely a candidate for its own bug, it needs to be advertised in > the release notes as well (may break plugins, notice templates, custom > scripts, etc.). Also it would have been nice to rename other ->borrower > methods then. I usually add new relationships, I have overlooked it myself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:43:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:43:19 +0000 Subject: [Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #84 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:43:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:43:28 +0000 Subject: [Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:43:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:43:30 +0000 Subject: [Koha-bugs] [Bug 16652] Omnibus: RestfulAPI supporting services for Vufind and for xnciptoolkit drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652 Bug 16652 depends on bug 17314, which changed state. Bug 17314 Summary: Routes to create, list and delete a purchase suggestion https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:43:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:43:44 +0000 Subject: [Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:43:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:43:51 +0000 Subject: [Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:43:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:43:58 +0000 Subject: [Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:44:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:44:06 +0000 Subject: [Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:58:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:58:17 +0000 Subject: [Koha-bugs] [Bug 19206] How should we sort 19xx when order is pubdate? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19206 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24674 --- Comment #3 from Marcel de Rooy --- Adding a See also to 24674 (about copyrightdate field) while this report deals with 008. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 13:58:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 12:58:17 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19206 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 14:07:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 13:07:31 +0000 Subject: [Koha-bugs] [Bug 29391] New: Improve output of reservoir search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29391 Bug ID: 29391 Summary: Improve output of reservoir search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl I'd like to make three changes to the output of search results from the bibliographic reservoir: - Make it a configurable DataTable. - Remove unused columns: the date and edition columns are not in the query so will never have data. - Add a column for import date. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 14:24:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 13:24:16 +0000 Subject: [Koha-bugs] [Bug 29391] Improve output of reservoir search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29391 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 14:24:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 13:24:19 +0000 Subject: [Koha-bugs] [Bug 29391] Improve output of reservoir search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29391 --- Comment #1 from Owen Leonard --- Created attachment 127216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127216&action=edit Bug 29391: Improve output of reservoir search This patch makes the cataloging reservoir search results a configurable DataTable. The empty edition and date columns are removed, and an import data column is added. To test, apply the patch and go to Cataloging. - Perform a cataloging search which will return results from the reservoir. - The table of reservoir search results should be a DataTable with paging, navigation, filtering, column configuration, etc. - Confirm that all DataTable controls work correctly. - Go to Administration -> Table settings -> Cataloging -> addbooks. - Try modifying the default configuration and confirm that the settings take effect. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 14:38:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 13:38:43 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, tomascohen at gmail.com --- Comment #26 from Katrin Fischer --- Adding Joubu und Tomas, maybe one of them can help with this one: FAIL Koha/Patron/Debarments.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling FAIL valid Inconsistent hierarchy during C3 merge of class 'Koha::Patron::Debarments': current merge results [ Koha::Patron::Debarments, ] merging failed on 'Exporter' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 14:47:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 13:47:34 +0000 Subject: [Koha-bugs] [Bug 19696] HoldsQueue.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19696 --- Comment #7 from Jonathan Druart --- Koha_Master/1805 Another new failure that seems related # Failed test 'Request is correctly advertised as item-level' # at t/db_dependent/HoldsQueue.t line 1343. # got: '0' # expected: '1' # Failed test 'Request is correctly advertised as biblio-level' # at t/db_dependent/HoldsQueue.t line 1348. # got: '1' # expected: '0' # Looks like you failed 2 tests of 4. . # Failed test 'Item level holds info is preserved (Bug 25738)' # at t/db_dependent/HoldsQueue.t line 1350. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 14:54:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 13:54:04 +0000 Subject: [Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 14:55:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 13:55:03 +0000 Subject: [Koha-bugs] [Bug 29319] Errors when doing a cataloging search which starts with a number + letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29319 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 14:55:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 13:55:57 +0000 Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate CC| |jonathan.druart+koha at gmail. | |com Severity|normal |enhancement --- Comment #28 from Jonathan Druart --- Considering this a new enhancement. And postponing to 22.05, this script bring us too much mess this cycle. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 14:57:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 13:57:17 +0000 Subject: [Koha-bugs] [Bug 29242] Flatpickr - Turn autocomplete off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Flatpickr - Should |Flatpickr - Turn |autocomplete be turned off? |autocomplete off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 15:33:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 14:33:05 +0000 Subject: [Koha-bugs] [Bug 29392] New: Add plugin hooks before merging biblios or authorities Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392 Bug ID: 29392 Summary: Add plugin hooks before merging biblios or authorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org For when we want to modify the final record of a merge operation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 15:33:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 14:33:53 +0000 Subject: [Koha-bugs] [Bug 29392] Add plugin hooks before merging biblios or authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392 --- Comment #1 from Julian Maurice --- Created attachment 127217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127217&action=edit Bug 29392: Add plugin hooks before merging biblios or authorities Hooks are called 'before_biblio_action' and 'before_authority_action' and they both take an 'action' parameter whose value is 'merge'. Other parameters include the record id (biblionumber or authid), the object itself (Koha::Biblio or Koha::Authority), the MARC::Record about to be saved (so plugins can modify it), and the list of record ids that will be deleted after the merge. Test plan: 1. Create a plugin with these two methods. For instance: sub before_biblio_action { my ($self, $args) = @_; my $action = $args->{action}; return unless $action eq 'merge'; my $record = $args->{record}; my $merged_biblio_ids = $args->{merged_biblio_ids}; if ($record && $merged_biblio_ids) { my @fields = map { MARC::Field->new('035', ' ', ' ', 'z' => $_) } @$merged_biblio_ids; $record->insert_fields_ordered(@fields); } } sub before_authority_action { my ($self, $args) = @_; my $action = $args->{action}; return unless $action eq 'merge'; my $record = $args->{record}; my $merged_authority_ids = $args->{merged_authority_ids}; if ($record && $merged_authority_ids) { my @fields = map { MARC::Field->new('035', ' ', ' ', 'z' => $_) } @$merged_authority_ids; $record->insert_fields_ordered(@fields); } } This will copy the identifier of deleted records inside 035$z of the final record. (035$z is for "Canceled/invalid system control number") 2. Add the plugin path to your $KOHA_CONF 3. Run misc/devel/install_plugins.pl. It should say: Installed version 4. Apply patch and restart starman 5. Create two or more biblios with the same title. Make sure they are indexed in your search engine. 6. Search for them. In the results check their corresponding boxes and click on "Edit -> Merge records" 7. Merge them and verify that your plugin code was called. If you used the example above, verify that it added a 035$z for each deleted record. 8. Do the same for authorities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 15:34:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 14:34:12 +0000 Subject: [Koha-bugs] [Bug 29392] Add plugin hooks before merging biblios or authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 15:40:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 14:40:35 +0000 Subject: [Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #10 from Jonathan Druart --- That's definitely where it should have been put originally. It was due to my lack of understanding of C4::SIP code and how SIP machines work. I thought that "process_request" was used to... process the request, but it's actually used at connection time. Having used misc/sip_cli_emulator.pl instead of telnet in the test plan of bug 23640 was also misleading. I also thought that a connection was made for each request. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 15:41:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 14:41:48 +0000 Subject: [Koha-bugs] [Bug 29389] Add holding branch to holds queue report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29389 --- Comment #2 from Katrin Fischer --- Thx :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 15:44:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 14:44:00 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 --- Comment #17 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #16) > You should git grep '\->empty' Just say it :) Koha/Acquisition/Order.pm: return Koha::Holds->new->empty; => It returns a I resultset. So that should be no longer the case in LIST context ? Koha/Biblio.pm: return Koha::Items->new->empty * return Koha::Items->new->empty unless C4::Context->preference('EasyAnalyticalRecords'); * return Koha::Items->search( { itemnumber => { -in => \@itemnumbers } } ); => Far fetched, but we might have empty list or empty result set ? Koha/Item.pm: return Koha::Libraries->new()->empty if $branchitemrule->{holdallowed} eq 'from_local_hold_group' && !$self->home_branch->validate_hold_sibling( {branchcode => $patron->branchcode} ); Koha/Item.pm: return Koha::Libraries->new()->empty if $branchitemrule->{holdallowed} eq 'from_home_library' && $self->home_branch->branchcode ne $patron->branchcode; => So pickup locations will return () or result set that could be empty ? Looks a bit inconsistent. Or do I miss something ;) > you just chain your queries and know it will work... Chain is scalar context. So no difference between current state and your patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 15:45:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 14:45:40 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 --- Comment #18 from Marcel de Rooy --- In other words, please show me a better example where it does not work now in list context. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 15:51:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 14:51:52 +0000 Subject: [Koha-bugs] [Bug 27684] Serial add is confused by authorized values with a code of '0' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- Does it make sense to leave in the unless.. can you explain? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 15:56:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 14:56:32 +0000 Subject: [Koha-bugs] [Bug 28913] Automatic checkin setting in item type setup should note required cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28913 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #4 from Jonathan Druart --- I don't know if it's a big deal but, to me, the note reads like: the cronjob is not setup correctly. Whereas we don't know and maybe no action is required. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 15:58:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 14:58:20 +0000 Subject: [Koha-bugs] [Bug 28913] Automatic checkin setting in item type setup should note required cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28913 --- Comment #5 from Katrin Fischer --- It's phrased like the system preferences, but I understand what you mean. What if we just leave otu the "Ask..." part? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:01:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:01:41 +0000 Subject: [Koha-bugs] [Bug 29075] OPAC info should not be displayed in libraries table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC info should not be raw |OPAC info should not be |in libraries table |displayed in libraries | |table CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:04:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:04:18 +0000 Subject: [Koha-bugs] [Bug 29393] New: Ability to send emails from patron details page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 Bug ID: 29393 Summary: Ability to send emails from patron details page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: alex.arnaud at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:04:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:04:36 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:06:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:06:28 +0000 Subject: [Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart+koha at gmail. | |com --- Comment #9 from Jonathan Druart --- Tests are missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:17:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:17:01 +0000 Subject: [Koha-bugs] [Bug 29394] New: Remove flatpickr instantiations from .tt files Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 Bug ID: 29394 Summary: Remove flatpickr instantiations from .tt files Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org The instantiation must be done by the JS from calendar.inc, based on the classes of the inputs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:17:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:17:15 +0000 Subject: [Koha-bugs] [Bug 29270] Use flatpickr and futuredate on reserve/request.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29270 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29239 |29394 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 [Bug 29394] Remove flatpickr instantiations from .tt files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:17:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:17:15 +0000 Subject: [Koha-bugs] [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29270 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29270 [Bug 29270] Use flatpickr and futuredate on reserve/request.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:17:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:17:15 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29270 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29270 [Bug 29270] Use flatpickr and futuredate on reserve/request.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:18:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:18:01 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29239 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:18:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:18:01 +0000 Subject: [Koha-bugs] [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29394 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 [Bug 29394] Remove flatpickr instantiations from .tt files -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:19:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:19:08 +0000 Subject: [Koha-bugs] [Bug 28973] Improve Koha::Patron::can_see_patron_infos efficiency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28973 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124656|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 127218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127218&action=edit Bug 28973: Improve Koha::Patron::can_see_patron_infos efficiency The method can_see_patron_infos looks up a row in the branches table by branchcode just to get the branchcode it already has. This seems inefficient. Test Plan: 1) Apply this patch 2) No changes should be noted Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:19:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:19:18 +0000 Subject: [Koha-bugs] [Bug 28973] Improve Koha::Patron::can_see_patron_infos efficiency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28973 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:19:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:19:35 +0000 Subject: [Koha-bugs] [Bug 28973] Improve Koha::Patron::can_see_patron_infos efficiency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28973 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- This is a no brainer.. straight to PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:19:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:19:42 +0000 Subject: [Koha-bugs] [Bug 28973] Improve Koha::Patron::can_see_patron_infos efficiency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28973 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:22:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:22:28 +0000 Subject: [Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121054|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 127219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127219&action=edit Bug 28365: Add unit test Run prove t/db_dependent/Search.t Without fix you get error : # Failed test 'buildQuery should keep 0 value in query_cgi' # at t/db_dependent/Search.t line 670. # got: 'idx=su%2Cphr' # expected: 'idx=su%2Cphr&q=0' This patch also adds a test for query_desc in case it is broken in the future. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:22:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:22:31 +0000 Subject: [Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121055|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 127220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127220&action=edit Bug 28365: (Bug 19873 follow-up) Make it possible to search on value 0 Bug 19873 fixed search with value 0. It works in first page but not in other pages. This patch fixes query_cgi var. Test plan: - create a st-numeric index in zebra conf related to a numeric field i.e: yourindex 1=yourindex 4=109 - fill a field with 0 in several biblio records, - reindex your biblios, - search yourindex=0 and go to second page of results, - should not work, - apply this patch, - test again, - should work Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:22:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:22:49 +0000 Subject: [Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:23:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:23:15 +0000 Subject: [Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Super trivial fix, with test coverage and no regressions. Going straight for QA.. Passed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:24:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:24:35 +0000 Subject: [Koha-bugs] [Bug 29355] Pickup location list limited by RESTdefaultPageSize syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29355 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #8 from Jonathan Druart --- I am not sure it makes sense, there is a filter to retrieve those not displayed. What about Koha installations with hundreds of libraries? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:24:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:24:53 +0000 Subject: [Koha-bugs] [Bug 29355] Pickup location list limited by RESTdefaultPageSize syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29355 --- Comment #9 from Jonathan Druart --- (will push anyway) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:32:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:32:40 +0000 Subject: [Koha-bugs] [Bug 27684] Serial add is confused by authorized values with a code of '0' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684 --- Comment #4 from Didier Gautheron --- (In reply to Martin Renvoize from comment #3) > Does it make sense to leave in the unless.. can you explain? No it doesn't. Regards Didier -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:32:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:32:59 +0000 Subject: [Koha-bugs] [Bug 29355] Pickup location list limited by RESTdefaultPageSize syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29355 --- Comment #10 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #8) > I am not sure it makes sense, there is a filter to retrieve those not > displayed. What about Koha installations with hundreds of libraries? My feeling was the same. That changing the query to 'contains' would make their libraries show up even with the limit. For the record: this was requested by a library with hundreds of branches, that has difficulties to find the branches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:37:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:37:48 +0000 Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Comparing version numbers is fraught with peril :(.. This error message has annoyed me too on a number of occasions. Do you realise we already have a '_version_compare' routine in Koha::Plugins::Base? Was it a deliberate choice not to use it? Also, In my own plugins, I've started to use Perl version objects for comparisons : https://metacpan.org/dist/version/view/lib/version.pod. I'm wondering if one of these approaches might be more reliable for us? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:41:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:41:24 +0000 Subject: [Koha-bugs] [Bug 27684] Serial add is confused by authorized values with a code of '0' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684 Didier Gautheron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124169|0 |1 is obsolete| | --- Comment #5 from Didier Gautheron --- Created attachment 127221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127221&action=edit Bug 27684: Serial 0 is valid default value. To test: 1- Create a NOT_LOAN VA: code = 0 lib = available 2- Add a serial with one item 3- Check that in items modification 952$7 is on 'available' 4- Receive this serial. 5- Add item 6- check that not for loan is empty 6- Apply patch 7- redo 4,5 8- check that not for loan is on 'available' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:41:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:41:50 +0000 Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008 --- Comment #7 from Martin Renvoize --- As an example.. I have ``` use version; sub _version_check { my ( $self, $minversion ) = @_; my $kohaversion = Koha::version(); return ( version->parse($kohaversion) > version->parse($minversion) ); } ``` Which is what I've found to be most reliable to date. In the past I've have ``` sub _version_check { my ( $self, $minversion ) = @_; $minversion =~ s/(.*\..*)\.(.*)\.(.*)/$1$2$3/; my $kohaversion = Koha::version(); # remove the 3 last . to have a Perl number $kohaversion =~ s/(.*\..*)\.(.*)\.(.*)/$1$2$3/; return ( $kohaversion > $minversion ); } ``` The core one is ``` sub _version_compare { my @args = @_; if ( $args[0]->isa('Koha::Plugins::Base') ) { shift @args; } my $ver1 = shift @args || 0; my $ver2 = shift @args || 0; my @v1 = split /[.+:~-]/, $ver1; my @v2 = split /[.+:~-]/, $ver2; for ( my $i = 0 ; $i < max( scalar(@v1), scalar(@v2) ) ; $i++ ) { # Add missing version parts if one string is shorter than the other # i.e. 0 should be lt 0.2.1 and not equal, so we append .0 # 0.0.0 <=> 0.2.1 = -1 push( @v1, 0 ) unless defined( $v1[$i] ); push( @v2, 0 ) unless defined( $v2[$i] ); if ( int( $v1[$i] ) > int( $v2[$i] ) ) { return 1; } elsif ( int( $v1[$i] ) < int( $v2[$i] ) ) { return -1; } } return 0; } ``` And they're all different from what you're doing here... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:46:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:46:02 +0000 Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:46:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:46:05 +0000 Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #11 from Owen Leonard --- Created attachment 127222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127222&action=edit Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled This patch adds the new OPACBakerTaylorEnabled preferences to OPAC templates and scripts which were missed in the first patch. The patch also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql. Check these pages in the OPAC: - Catalog -> Search results - And search results -> RSS - Catalog -> Bibliographic details page -> Shelf browser - Catalog -> Lists -> List contents - Catalog -> Recent comments - And recent comments -> RSS - Your summary -> Checkouts and Overdues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:46:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:46:44 +0000 Subject: [Koha-bugs] [Bug 29329] stray "s" in opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29329 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20168 CC| |jonathan.druart+koha at gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:46:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:46:44 +0000 Subject: [Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29329 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29329 [Bug 29329] stray "s" in opac-detail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:52:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:52:32 +0000 Subject: [Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices between different orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:52:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:52:34 +0000 Subject: [Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices between different orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 --- Comment #15 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:52:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:52:37 +0000 Subject: [Koha-bugs] [Bug 24370] Editing purchase suggestion changes the acquisition library to logged-in user's In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24370 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:52:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:52:40 +0000 Subject: [Koha-bugs] [Bug 24370] Editing purchase suggestion changes the acquisition library to logged-in user's In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24370 --- Comment #26 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:52:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:52:43 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:52:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:52:46 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #106 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:52:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:52:48 +0000 Subject: [Koha-bugs] [Bug 25459] In patron cards layout, barcode position doesn't respect units In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25459 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:52:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:52:51 +0000 Subject: [Koha-bugs] [Bug 25459] In patron cards layout, barcode position doesn't respect units In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25459 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:52:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:52:53 +0000 Subject: [Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:52:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:52:56 +0000 Subject: [Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 --- Comment #11 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:52:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:52:59 +0000 Subject: [Koha-bugs] [Bug 27884] Add HTML mail support for patron emailer script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:53:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:53:02 +0000 Subject: [Koha-bugs] [Bug 27884] Add HTML mail support for patron emailer script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 --- Comment #15 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:53:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:53:05 +0000 Subject: [Koha-bugs] [Bug 28263] AUTO_RENEWALS message for 'too_many' is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:53:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:53:07 +0000 Subject: [Koha-bugs] [Bug 28263] AUTO_RENEWALS message for 'too_many' is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 --- Comment #10 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:53:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:53:09 +0000 Subject: [Koha-bugs] [Bug 28573] Replace authority record with Z39.50/SRU creates new authority record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:53:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:53:13 +0000 Subject: [Koha-bugs] [Bug 28573] Replace authority record with Z39.50/SRU creates new authority record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 --- Comment #15 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:53:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:53:15 +0000 Subject: [Koha-bugs] [Bug 28729] Return-path header not set in emails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:53:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:53:18 +0000 Subject: [Koha-bugs] [Bug 28729] Return-path header not set in emails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 --- Comment #59 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:53:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:53:21 +0000 Subject: [Koha-bugs] [Bug 28901] showCart incorrectly calculates position if content above navbar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28901 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:53:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:53:23 +0000 Subject: [Koha-bugs] [Bug 28901] showCart incorrectly calculates position if content above navbar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28901 --- Comment #14 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:53:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:53:26 +0000 Subject: [Koha-bugs] [Bug 28904] Update information on Newsletter editor on about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28904 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:53:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:53:28 +0000 Subject: [Koha-bugs] [Bug 28904] Update information on Newsletter editor on about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28904 --- Comment #18 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:53:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:53:31 +0000 Subject: [Koha-bugs] [Bug 28910] Correct eslint errors in OPAC basket.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28910 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:53:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:53:33 +0000 Subject: [Koha-bugs] [Bug 28910] Correct eslint errors in OPAC basket.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28910 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:53:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:53:35 +0000 Subject: [Koha-bugs] [Bug 28913] Automatic checkin setting in item type setup should note required cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28913 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:53:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:53:38 +0000 Subject: [Koha-bugs] [Bug 28913] Automatic checkin setting in item type setup should note required cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28913 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:53:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:53:40 +0000 Subject: [Koha-bugs] [Bug 28926] Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:53:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:53:42 +0000 Subject: [Koha-bugs] [Bug 28926] Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:53:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:53:45 +0000 Subject: [Koha-bugs] [Bug 29075] OPAC info should not be displayed in libraries table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:53:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:53:47 +0000 Subject: [Koha-bugs] [Bug 29075] OPAC info should not be displayed in libraries table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 --- Comment #9 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:53:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:53:50 +0000 Subject: [Koha-bugs] [Bug 29152] Change to default search behavior when limiting by branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29152 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:53:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:53:52 +0000 Subject: [Koha-bugs] [Bug 29152] Change to default search behavior when limiting by branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29152 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:53:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:53:54 +0000 Subject: [Koha-bugs] [Bug 29223] Auto-renewals can fail when not digested per branch and patron requests digest In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29223 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:53:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:53:57 +0000 Subject: [Koha-bugs] [Bug 29223] Auto-renewals can fail when not digested per branch and patron requests digest In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29223 --- Comment #10 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:00 +0000 Subject: [Koha-bugs] [Bug 29242] Flatpickr - Turn autocomplete off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:02 +0000 Subject: [Koha-bugs] [Bug 29242] Flatpickr - Turn autocomplete off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29242 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:05 +0000 Subject: [Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:07 +0000 Subject: [Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:10 +0000 Subject: [Koha-bugs] [Bug 29319] Errors when doing a cataloging search which starts with a number + letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29319 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:10 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #149 from Jonathan Druart --- (In reply to Owen Leonard from comment #148) > Created attachment 127056 [details] [review] > Bug 17600: Fix imports for GetClassSources in guided_reports.pl > > This will fix the broken option to use cn_source as a runtime > parameter, e.g. <> Pushed to master, thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:12 +0000 Subject: [Koha-bugs] [Bug 29319] Errors when doing a cataloging search which starts with a number + letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29319 --- Comment #10 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:14 +0000 Subject: [Koha-bugs] [Bug 29328] Add missing list parameter to reports parameter menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29328 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:17 +0000 Subject: [Koha-bugs] [Bug 29328] Add missing list parameter to reports parameter menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29328 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:19 +0000 Subject: [Koha-bugs] [Bug 29329] stray "s" in opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29329 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:20 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|REOPENED |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:21 +0000 Subject: [Koha-bugs] [Bug 29351] Add missing cn_source parameter to reports parameter menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 Bug 29351 depends on bug 17600, which changed state. Bug 17600 Summary: Standardize the EXPORT https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:21 +0000 Subject: [Koha-bugs] [Bug 28722] tools/batchMod.pl needs to import C4::Auth::haspermission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28722 Bug 28722 depends on bug 17600, which changed state. Bug 17600 Summary: Standardize the EXPORT https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:22 +0000 Subject: [Koha-bugs] [Bug 28731] Subroutines not explicitly imported in reports svc (opac and staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28731 Bug 28731 depends on bug 17600, which changed state. Bug 17600 Summary: Standardize the EXPORT https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:22 +0000 Subject: [Koha-bugs] [Bug 28750] Undefined subroutines in svc/cataloguing/framework (caused by bug 17600) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 Bug 28750 depends on bug 17600, which changed state. Bug 17600 Summary: Standardize the EXPORT https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:22 +0000 Subject: [Koha-bugs] [Bug 28758] Undefined subroutines in C4/ImportBatch.pm (bug 17600) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28758 Bug 28758 depends on bug 17600, which changed state. Bug 17600 Summary: Standardize the EXPORT https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:23 +0000 Subject: [Koha-bugs] [Bug 28763] Undefined subroutine XSLTParse4Display (bug 17600) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28763 Bug 28763 depends on bug 17600, which changed state. Bug 17600 Summary: Standardize the EXPORT https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:23 +0000 Subject: [Koha-bugs] [Bug 28931] use EXPORT_OK in Koha::DateUtils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931 Bug 28931 depends on bug 17600, which changed state. Bug 17600 Summary: Standardize the EXPORT https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:23 +0000 Subject: [Koha-bugs] [Bug 29329] stray "s" in opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29329 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:23 +0000 Subject: [Koha-bugs] [Bug 29197] commit_file.pl missing import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29197 Bug 29197 depends on bug 17600, which changed state. Bug 17600 Summary: Standardize the EXPORT https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:24 +0000 Subject: [Koha-bugs] [Bug 29207] Restore Getopt::Long config to not ignore cases In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29207 Bug 29207 depends on bug 17600, which changed state. Bug 17600 Summary: Standardize the EXPORT https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:27 +0000 Subject: [Koha-bugs] [Bug 29350] TT method 'delete' don't need to be escaped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29350 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:29 +0000 Subject: [Koha-bugs] [Bug 29350] TT method 'delete' don't need to be escaped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29350 --- Comment #2 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:31 +0000 Subject: [Koha-bugs] [Bug 29351] Add missing cn_source parameter to reports parameter menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:35 +0000 Subject: [Koha-bugs] [Bug 29351] Add missing cn_source parameter to reports parameter menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:37 +0000 Subject: [Koha-bugs] [Bug 29352] Runtime parameter labels should not be said to be optional In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29352 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:38 +0000 Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #40 from Jonathan Druart --- Last two patches pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:39 +0000 Subject: [Koha-bugs] [Bug 29352] Runtime parameter labels should not be said to be optional In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29352 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:42 +0000 Subject: [Koha-bugs] [Bug 29355] Pickup location list limited by RESTdefaultPageSize syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29355 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:44 +0000 Subject: [Koha-bugs] [Bug 29355] Pickup location list limited by RESTdefaultPageSize syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29355 --- Comment #11 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:47 +0000 Subject: [Koha-bugs] [Bug 29356] Search for pickup library when placing a hold should be truncated in both directions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29356 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:54:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:54:49 +0000 Subject: [Koha-bugs] [Bug 29356] Search for pickup library when placing a hold should be truncated in both directions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29356 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:56:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:56:48 +0000 Subject: [Koha-bugs] [Bug 28913] Automatic checkin setting in item type setup should note required cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28913 --- Comment #7 from Jonathan Druart --- (In reply to Katrin Fischer from comment #5) > It's phrased like the system preferences, but I understand what you mean. > What if we just leave otu the "Ask..." part? Sorry, didn't see your comment before I pushed it. Feel free to submit a follow-up here! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 16:59:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 15:59:20 +0000 Subject: [Koha-bugs] [Bug 29355] Pickup location list limited by RESTdefaultPageSize syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29355 --- Comment #12 from Martin Renvoize --- Must admit I was also surprised by this one.. but it did what is says on the box as it were. I thought Select2 supported 'infinite scrolling' using API paging.. https://select2.org/data-sources/ajax#pagination.. doesn't that work here without calling '-1'? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 17:00:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 16:00:52 +0000 Subject: [Koha-bugs] [Bug 27684] Serial add is confused by authorized values with a code of '0' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684 --- Comment #6 from Jonathan Druart --- You need a test and certainly to modify this other place: Koha/UI/Form/Builder/Item.pm 122 $value = $subfield->{defaultvalue}; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 17:10:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 16:10:27 +0000 Subject: [Koha-bugs] [Bug 7972] GUI for Crons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7972 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 17:19:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 16:19:41 +0000 Subject: [Koha-bugs] [Bug 29395] New: Use EXPORT_OK in Koha::Patron::Debarments Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29395 Bug ID: 29395 Summary: Use EXPORT_OK in Koha::Patron::Debarments Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 17600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 [Bug 17600] Standardize the EXPORT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 17:19:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 16:19:41 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29395 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29395 [Bug 29395] Use EXPORT_OK in Koha::Patron::Debarments -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 17:19:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 16:19:41 +0000 Subject: [Koha-bugs] [Bug 28931] use EXPORT_OK in Koha::DateUtils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29395 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 17:20:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 16:20:20 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29395 --- Comment #27 from Jonathan Druart --- (In reply to Katrin Fischer from comment #26) > Adding Joubu und Tomas, maybe one of them can help with this one: > > FAIL Koha/Patron/Debarments.pm > OK critic > OK forbidden patterns > OK git manipulation > OK pod > OK pod coverage > OK spelling > FAIL valid > Inconsistent hierarchy during C3 merge of class 'Koha::Patron::Debarments': > current merge results [ > Koha::Patron::Debarments, > ] > merging failed on 'Exporter' Ignore it if it does not break the UI or tests. It should be fixed by bug 29395. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 17:20:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 16:20:20 +0000 Subject: [Koha-bugs] [Bug 29395] Use EXPORT_OK in Koha::Patron::Debarments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16223 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 17:30:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 16:30:58 +0000 Subject: [Koha-bugs] [Bug 29396] New: "Search to hold" should not rely on cardnumber Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29396 Bug ID: 29396 Summary: "Search to hold" should not rely on cardnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The "Search to hold" feature doesn't work for patrons without cardnumbers. To recreate: - create a patron without a cardnumber - from the patron record, click "Search to hold" - perform a search - in your search results, note the option "Place hold for [your patron name]()" - click "Place hold for [your patron name]()", see it takes you to request.pl without a patron selected - on request.pl, search for your patron by name and confirm you're able to place a hold that way, even without a cardnumber This feature shouldn't rely on cardnumber when cardnumber is not assumed to be required in all systems. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 17:32:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 16:32:14 +0000 Subject: [Koha-bugs] [Bug 29397] New: Add a select2 wrapper for the API Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Bug ID: 29397 Summary: Add a select2 wrapper for the API Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org It should handle the 'data' and 'processResults' data transformations, and allow being passed a function for converting the result data into something suitable for using on each use case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 17:32:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 16:32:28 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29355 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 17:32:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 16:32:28 +0000 Subject: [Koha-bugs] [Bug 29355] Pickup location list limited by RESTdefaultPageSize syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29355 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29397 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 17:41:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 16:41:32 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #107 from Jonathan Druart --- There is a test failing because of this: t/db_dependent/Koha/Object.t .. 9/21 # No tests run! # Failed test 'No tests run for subtest "date and date-time handling tests"' # at t/db_dependent/Koha/Object.t line 649. # Looks like you planned 2 tests but ran 1. # Looks like you failed 1 test of 1 run. # Failed test 'attributes_from_api() tests' # at t/db_dependent/Koha/Object.t line 669. [A bad parameter was given]# Looks like your test exited with 255 just after 14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 17:41:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 16:41:46 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 17:44:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 16:44:09 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #108 from Jonathan Druart --- And many more actually, see the last builds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 17:51:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 16:51:09 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #109 from Jonathan Druart --- (In reply to Jonathan Druart from comment #108) > And many more actually, see the last builds So for Object.t it's failing on date_or_birth because of: The given date (2019-12-27) does not match the date format (rfc3339) at /kohadevbox/koha/Koha/DateUtils.pm line 193. We lost the fallback, certainly caused by 'Bug 24850: Don't fallback when date_format is passed' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 17:55:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 16:55:22 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #110 from Jonathan Druart --- We could assume that 'date' won't be rfc3339, but I am not sure it's correct. The following patches seem to fix the tests. diff --git a/Koha/Object.pm b/Koha/Object.pm index 5d0f3f720ff..ec1316c45d7 100644 --- a/Koha/Object.pm +++ b/Koha/Object.pm @@ -751,7 +751,7 @@ sub attributes_from_api { elsif ( _date_or_datetime_column_type( $columns_info->{$koha_field_name}->{data_type} ) ) { try { if ( $columns_info->{$koha_field_name}->{data_type} eq 'date' ) { - $value = $dtf->format_date(dt_from_string($value, 'rfc3339')) + $value = $dtf->format_date(dt_from_string($value)) if defined $value; } else { -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 19:01:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 18:01:56 +0000 Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125743|0 |1 is obsolete| | Attachment #125744|0 |1 is obsolete| | Attachment #127222|0 |1 is obsolete| | --- Comment #12 from Owen Leonard --- Created attachment 127223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127223&action=edit Bug 28307: Make BakerTaylorEnabled preference separate for staff and OPAC This patch updates the system preferences controlling Baker & Taylor content so that there are separate preferences for the OPAC and the staff interface. The patch also adds Baker & Taylor cover images to the staff client. To test, apply the patch and run the database update. - Go to Admnistration -> System preferences -> Enhanced content - You should see a BakerTaylorEnabled and a OPACBakerTaylorEnabled preference. The OPACBakerTaylorEnabled should have the same setting you previously had for BakerTaylorEnabled. The BakerTaylorEnabled preference should be turned off. - Note that the description of the preferences have been updated to include links to the Baker & Taylor username and password preferences. - Enable both and make sure you have a valid Baker & Taylor username and password entered. - Perform a search in both the OPAC and staff interface. A Baker & Taylor cover image should appear on the bibliographic detail page in the OPAC, and on the search results and bibliographic detail page in the staff interface. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 19:01:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 18:01:59 +0000 Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #13 from Owen Leonard --- Created attachment 127224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127224&action=edit Bug 28307: (follow-up) Add proper check for BakerTaylorEnabled This patch adds a missing check for the BakerTaylorEnabled system preference in staff interface search results. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 19:02:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 18:02:03 +0000 Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #14 from Owen Leonard --- Created attachment 127225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127225&action=edit Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled This patch adds the new OPACBakerTaylorEnabled preferences to OPAC templates and scripts which were missed in the first patch. The patch also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql. Check these pages in the OPAC: - Catalog -> Search results - And search results -> RSS - Catalog -> Bibliographic details page -> Shelf browser - Catalog -> Lists -> List contents - Catalog -> Recent comments - And recent comments -> RSS - Your summary -> Checkouts and Overdues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 21:29:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 20:29:20 +0000 Subject: [Koha-bugs] [Bug 29380] Auto renewing, batch due date extension tool and checkout note previews are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29380 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 21:29:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 20:29:24 +0000 Subject: [Koha-bugs] [Bug 29380] Auto renewing, batch due date extension tool and checkout note previews are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29380 --- Comment #7 from Joonas Kylmälä --- Created attachment 127226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127226&action=edit Bug 29380: (follow-up) Fix renewal feature in staff interface The commit "Bug 29290: Rename relationships borrower => patron" (d46492ac23) renamed the relation for the borrowers table from 'borrower' to 'patron' but the usage in the renew.pl script was not updated. To test: 1) Try to renew a book in intranet through the renewal tab 2) Notice it gives error 3) Apply patch 4) Notice the error is now gone Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 21:30:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 20:30:01 +0000 Subject: [Koha-bugs] [Bug 5927] Show series information in search results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5927 Hannah Olsen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |holsen at duncanville.com --- Comment #29 from Hannah Olsen --- Hi, what about the 800/830, where the authorized form of series resides? That's the info that we need in search results. The 490s we have are half junk that we put in so that the 800/830s would display (there's a separate bug about that issue). -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 21:30:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 20:30:15 +0000 Subject: [Koha-bugs] [Bug 29380] Auto renewing, batch due date extension tool and checkout note previews are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29380 --- Comment #8 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #6) > This one seems valid as well: > circ/renew.pl fixed. I grepped another time for similar ones to this but couldn't find more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 21:35:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 20:35:19 +0000 Subject: [Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 --- Comment #4 from Joonas Kylmälä --- (In reply to David Cook from comment #3) > I can't even get auto-renewal digest messages to send... Not sure where you got stuck. To test you can check the Notices tab of the patron via staff interface as well, no need to have have a working email setup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 22:06:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 21:06:41 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual CC| |david at davidnind.com Text to go in the| |When article requests come release notes| |in they may require | |additional processing, for | |example: determining the | |type of request or other | |workflows. | | | |This | |enhancement adds a | |requested stage before the | |pending and processing | |stages for the article | |request process. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 22:07:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 21:07:51 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #111 from Tomás Cohen Arazi --- This commit broke all the things: 398f7b45f074b023b03e5075821f0abb08cda66c -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 22:10:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 21:10:12 +0000 Subject: [Koha-bugs] [Bug 5927] Show series information in search results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5927 --- Comment #30 from Katrin Fischer --- (In reply to Hannah Olsen from comment #29) > Hi, what about the 800/830, where the authorized form of series resides? > That's the info that we need in search results. The 490s we have are half > junk that we put in so that the 800/830s would display (there's a separate > bug about that issue). If you have a 490 that is marked as "traced" the 800/830 will show. Koha assumes that for traced series pairs of 490/8xx will be catalogued. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 22:12:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 21:12:22 +0000 Subject: [Koha-bugs] [Bug 13754] Missing changelogs for debian package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13754 --- Comment #4 from Pablo AB --- It seems there was/is? a gap on the changelog generation process: $ apt-get changelog koha-common | grep . | head Get:1 store: koha 20.11.11-1 Changelog koha (20.11.11-1) 20.11; urgency=medium * New upstream release (20.11.11) -- Mason James Sat, 30 Oct 2021 00:05:45 +1300 koha (16.05.02) squeeze; urgency=medium * New upstream release (16.05.02) -- Mirko Tietgen Tue, 02 Aug 2016 15:04:49 +0200 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 22:23:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 21:23:18 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #112 from Tomás Cohen Arazi --- That's what we're getting. The given date (2021-11-02) does not match the date format (rfc3339) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 22:30:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 21:30:27 +0000 Subject: [Koha-bugs] [Bug 29297] BorrowerMandatoryField doesn't include sort1 and sort2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29297 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 28936 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 22:30:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 21:30:27 +0000 Subject: [Koha-bugs] [Bug 28936] Sort1 and Sort2 should be included in BorrowerUnwantedField and related sysprefs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28936 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud at orex.es --- Comment #9 from Katrin Fischer --- *** Bug 29297 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 2 22:32:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 21:32:34 +0000 Subject: [Koha-bugs] [Bug 29362] Opac detail error while shown in search list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29362 --- Comment #1 from Katrin Fischer --- Did you fix the issue? At the moment there is only one result for the search posted below in your catalogue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 00:43:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 23:43:24 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 00:43:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 23:43:27 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 --- Comment #12 from Joonas Kylmälä --- Created attachment 127227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127227&action=edit Bug 27708: (QA follow-up) Add a few tests for Koha::Edifact::Order 1. This adds a simple regression test to make sure order_line() method executes correctly with basket create_items set to "ordering" and "receiving". 2. A simple test for the filename method is added To test: 1) prove t/db_dependent/Koha/Edifact/Order.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 00:44:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 23:44:39 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117723|0 |1 is obsolete| | Attachment #127227|0 |1 is obsolete| | --- Comment #13 from Joonas Kylmälä --- Created attachment 127228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127228&action=edit Bug 27708: Unify two item object creation blocks to be stored as hash Previously for existing item data was stored as an object reference and then treated as one, but for not yet existing item data was stored as keys in hash reference in the same variable and later it was treated like an object, hence why it crashed with "no method". This patch unifies that variable in both cases filled as hash and treated as such. To reproduce: 1) Go to "Administration->System preferences" and change "AcqCreateItem" to "receiving an order." 2) Now, go to "Acquisitions" and create a new Vendor, or use an existing one. 3) Next, go to "Administration->EDI Account" and add EDI account (pick that Vendor that you created recently, or the one that you will use for this test). 4) Also in "Administration->Library EANs" add EAN if you didn't have one previously. 5) Go back to "Acquisitions" and add a new basket to your Vendor that you will use for this test. 6) Press "Create EDIFACT order" button. It should throw "Can't call method "homebranch" on unblessed reference..." software error. 7) Apply the patch. 8) Reload the page that threw software error previously (or repeat steps 5, 6 if you need another basket), it should go through now. Signed-off-by: David Nind Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 00:44:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 23:44:43 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 --- Comment #14 from Joonas Kylmälä --- Created attachment 127229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127229&action=edit Bug 27708: (QA follow-up) Add a few tests for Koha::Edifact::Order 1. This adds a simple regression test to make sure order_line() method executes correctly with basket create_items set to "ordering" and "receiving". 2. A simple test for the filename method is added To test: 1) prove t/db_dependent/Koha/Edifact/Order.t Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 00:46:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Nov 2021 23:46:55 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi --- Comment #15 from Joonas Kylmälä --- Added the missing unit test to make this pass QA, however the test is quite big so I would like to have separate sign-off and qa sign-off for the unit test patch. You can count my sign-off for the first patch as QA sign-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 02:15:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 01:15:14 +0000 Subject: [Koha-bugs] [Bug 29398] New: Importing Authority Records without Renumbering Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29398 Bug ID: 29398 Summary: Importing Authority Records without Renumbering Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: cmkelleymls at gmail.com QA Contact: testopia at bugs.koha-community.org Problem: When authority records are import ("Stage MARC records for import"), each authority record is assigned a new record number instead of retaining its original record number as recorded in 001 $a. This links bibliographic records to the wrong authority records, and the only way to restore the original linkage is to manual change biblographic $9 with the new authority record 100 $a; or vice versa. So, for example, Clements, Samuel Langhorne old authority (before migration) #9742 new authority (after migration) #8665 100 1 $a Clements, Samuel Langhorne $e [author] $9 9742 245 10 $a Huckleberry Finn / $cMark Twain. ... The bib. record 100 $9 remains 9742 even though that authority record is now assigned to Shakespeare, William. When clicking on the link in the Huck Finn book, the link finds works by William Shakespeare instead. Enhancement request: Authority records 001 $a retain assigned 001 $a instead of being assigned a new authority record number. I have had limited success with building an authority record's 942 $c from the 100 $a, but a more comprehensive solution is in order. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 06:53:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 05:53:33 +0000 Subject: [Koha-bugs] [Bug 29399] New: Best sites to download free antivirus Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29399 Bug ID: 29399 Summary: Best sites to download free antivirus Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: imaddycripson at gmail.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Hello, I'm Addy, and I'm a Microsoft expert, if you want help related to technical problems then you can visit our websites. http://webrootdownload.me/ http://mcafeecomactivatec.com/ http://nortoncomsetupz.com/ http://nortoncomsetupl.com/ http://mybtmailx.com/ https://sites.google.com/view/goaolmail/ https://sites.google.com/view/bitdefender-central-usa https://sites.google.com/view/netgearextendersetup-process https://sites.google.com/view/tomtomupdate-guide https://sites.google.com/view/avastlogindesk https://sites.google.com/view/myavastcom-desk https://sites.google.com/view/mywifiext-setupp https://sites.google.com/view/extenderlinksyscom-setup https://sites.google.com/view/office365loginhere https://sites.google.com/view/nortonlogindesk https://sites.google.com/view/belkinrangehelp https://sites.google.com/view/ijstartcannonsetup-guide https://sites.google.com/view/webrootdownloadus https://sites.google.com/view/belkinn300setup-guide -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 07:53:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 06:53:14 +0000 Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008 --- Comment #8 from Fridolin Somers --- Ohhh thanks for your alert. I'm sort of lost in those codes. Can you provide a path please ? I'll sign -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 07:53:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 06:53:21 +0000 Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 08:27:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 07:27:08 +0000 Subject: [Koha-bugs] [Bug 28236] Selecting database columns for system preferences in standard and dev installs is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Fridolin Somers --- >From Martin request, I test this since we use dev install in production servers. We usually use Nginx but we have some Apache installs (because of Sibboleth). Works fine, I reproduce the HTTP 403 without this patch. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 10:05:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 09:05:01 +0000 Subject: [Koha-bugs] [Bug 29395] Use EXPORT_OK in Koha::Patron::Debarments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 10:05:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 09:05:05 +0000 Subject: [Koha-bugs] [Bug 29395] Use EXPORT_OK in Koha::Patron::Debarments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29395 --- Comment #1 from Jonathan Druart --- Created attachment 127230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127230&action=edit Bug 29395: use EXPORT_OK from Koha::Patron::Debarments Missed from bug 17600. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 10:05:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 09:05:16 +0000 Subject: [Koha-bugs] [Bug 29395] Use EXPORT_OK in Koha::Patron::Debarments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 10:05:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 09:05:23 +0000 Subject: [Koha-bugs] [Bug 29395] Use EXPORT_OK in Koha::Patron::Debarments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 10:09:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 09:09:26 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #113 from Jonathan Druart --- Created attachment 127231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127231&action=edit Bug 24850: Date only are not RFC3339 We removed the fallback on 'Bug 24850: Don't fallback when date_format is passed', and the dates passed for date only (YYYY-MM-DD) are not RFC3339 formatted but ISO8601. We must assume that all dates will be YYYY-MM-DD, without fallback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 10:10:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 09:10:22 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127231|0 |1 is obsolete| | --- Comment #114 from Jonathan Druart --- Created attachment 127232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127232&action=edit Bug 24850: Date only are not RFC3339 We removed the fallback on 'Bug 24850: Don't fallback when date_format is passed', and the dates passed for date only (YYYY-MM-DD) are not RFC3339 formatted but ISO8601. We must assume that all dates will be YYYY-MM-DD, without fallback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 10:17:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 09:17:29 +0000 Subject: [Koha-bugs] [Bug 29400] New: Android 12, Its New Features, And APIs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29400 Bug ID: 29400 Summary: Android 12, Its New Features, And APIs Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: QA tools Assignee: jonathan.druart+koha at gmail.com Reporter: lucas.parkker21 at gmail.com Android 12 is live now! Its source code is available to the Android Open Source Project (AOSP) Git repositories. Usually, Google uploads source code after releasing its stable build for Android devices. But this time, breaking the release tradition, Google has rolled out the Android 12 build after releasing the source code. And it’s available for the Pixel series.  https://mobisoftinfotech.com/resources/blog/android-12/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 10:18:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 09:18:57 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #115 from Tomás Cohen Arazi --- Date-only is part of RFC 3339. It is the full-date spec which matches ISO 8601 [1] Maybe we need a dateonly param so things are clear? [1] https://xml2rfc.tools.ietf.org/public/rfc/html/rfc3339.html#anchor14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 10:27:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 09:27:28 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 10:27:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 09:27:32 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127228|0 |1 is obsolete| | --- Comment #16 from David Nind --- Created attachment 127233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127233&action=edit Bug 27708: Unify two item object creation blocks to be stored as hash Previously for existing item data was stored as an object reference and then treated as one, but for not yet existing item data was stored as keys in hash reference in the same variable and later it was treated like an object, hence why it crashed with "no method". This patch unifies that variable in both cases filled as hash and treated as such. To reproduce: 1) Go to "Administration->System preferences" and change "AcqCreateItem" to "receiving an order." 2) Now, go to "Acquisitions" and create a new Vendor, or use an existing one. 3) Next, go to "Administration->EDI Account" and add EDI account (pick that Vendor that you created recently, or the one that you will use for this test). 4) Also in "Administration->Library EANs" add EAN if you didn't have one previously. 5) Go back to "Acquisitions" and add a new basket to your Vendor that you will use for this test. 6) Press "Create EDIFACT order" button. It should throw "Can't call method "homebranch" on unblessed reference..." software error. 7) Apply the patch. 8) Reload the page that threw software error previously (or repeat steps 5, 6 if you need another basket), it should go through now. Signed-off-by: David Nind Signed-off-by: Joonas Kylmälä Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 10:27:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 09:27:51 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127229|0 |1 is obsolete| | --- Comment #17 from David Nind --- Created attachment 127234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127234&action=edit Bug 27708: (QA follow-up) Add a few tests for Koha::Edifact::Order 1. This adds a simple regression test to make sure order_line() method executes correctly with basket create_items set to "ordering" and "receiving". 2. A simple test for the filename method is added To test: 1) prove t/db_dependent/Koha/Edifact/Order.t Signed-off-by: Joonas Kylmälä Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 10:33:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 09:33:30 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #116 from Martin Renvoize --- I actually read it the other way around.. RFC3339 is full date-time specific and is a subspec of ISO8609 which is looser and allows for date only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 10:34:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 09:34:46 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #117 from Martin Renvoize --- https://stackoverflow.com/questions/522251/whats-the-difference-between-iso-8601-and-rfc-3339-date-formats Highlighting the bit that raised my thoughts: `Most notably RFC 3339 specifies a complete representation of date and time (only fractional seconds are optional)` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 10:35:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 09:35:50 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #118 from Martin Renvoize --- But yes.. I did wonder if we should actually have a 'date only' parameter we can pass so our iso fallback can explicitly ban time parts for this case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 10:37:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 09:37:50 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #119 from Martin Renvoize --- But, for here.. I think passing 'iso' as the format explicitly for date only where Jonathans follow-up does seems like the most pragmatic solution in the time.. Adding a 'date-only' parameter should be in a desperate bug in my opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 10:45:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 09:45:55 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #120 from Jonathan Druart --- There is still one test failing: # Failed test '404 Not Found' # at t/db_dependent/api/v1/holds.t line 220. # got: '400' # expected: '404' # Failed test 'has value for JSON Pointer "/error"' # at t/db_dependent/api/v1/holds.t line 220. I don't understand it and it's a mess to debug (We definitely need to improve our error handling when testing the REST API). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 10:46:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 09:46:15 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #121 from Jonathan Druart --- Created attachment 127235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127235&action=edit Bug 24850: Fix api/v1/holds.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 10:46:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 09:46:50 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #122 from Jonathan Druart --- Read those 2 comments the other way around, there is still one test failing :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 10:48:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 09:48:24 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #123 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #119) > But, for here.. I think passing 'iso' as the format explicitly for date only > where Jonathans follow-up does seems like the most pragmatic solution in the > time.. Adding a 'date-only' parameter should be in a desperate bug in my > opinion. I agree, what I meant to say is that passing an ISO full-date formatted date is correct in the Swagger 2.0 spec, and we should better have explicit params. My attempt yesterday night was to add something explicit: $value = $dtf->format_datetime(dt_from_string($value, 'iso')) but either works, as long as we document this conversation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 10:55:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 09:55:39 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #124 from Tomás Cohen Arazi --- Created attachment 127236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127236&action=edit Bug 24850: suspended_until is a date-time Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 11:01:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 10:01:35 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #125 from Jonathan Druart --- 77 "suspended_until": { 78 "type": ["string", "null"], 79 "format": "date-time", 80 "description": "Date until which the hold has been suspended" 81 }, But the code is converting everything to date-only... What do we want here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 11:14:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 10:14:09 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #126 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #125) > 77 "suspended_until": { > 78 "type": ["string", "null"], > 79 "format": "date-time", > 80 "description": "Date until which the hold has been suspended" > 81 }, > > But the code is converting everything to date-only... > > What do we want here? The spec was written taking the DB structure into account. If you think the spec is wrong and this field should be date-only, let's do it on a separate bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 11:19:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 10:19:50 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 --- Comment #1 from Alex Arnaud --- Created attachment 127237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127237&action=edit Bug 29393 - Ability to send emails from patron details page Test plan - apply Bug 12802 - go to a patron's details page - click on "Add message" in tools bar - choose "Email" in "Add a message for" - Select a notice (module members) or manualy fill the message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 11:22:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 10:22:31 +0000 Subject: [Koha-bugs] [Bug 29400] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29400 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Android 12, Its New |SPAM |Features, And APIs | Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 11:22:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 10:22:36 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127237|0 |1 is obsolete| | --- Comment #2 from Alex Arnaud --- Created attachment 127238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127238&action=edit Bug 29393 - Ability to send emails from patron details page Test plan - apply Bug 12802 - go to a patron's details page - click on "Add message" in tools bar - choose "Email" in "Add a message for" - Select a notice (module members) or manualy fill the message - Save - Check the message is saved in message_queue table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 11:23:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 10:23:21 +0000 Subject: [Koha-bugs] [Bug 29399] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29399 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Summary|Best sites to download free |SPAM |antivirus | Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 11:23:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 10:23:48 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12802 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 [Bug 12802] Send notices using several email addresses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 11:23:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 10:23:48 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29393 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 [Bug 29393] Ability to send emails from patron details page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 11:24:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 10:24:04 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 11:27:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 10:27:46 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 --- Comment #3 from Alex Arnaud --- This adds the ability to send email via patron messages (/cgi-bin/koha/circ/add_message.pl). This feature depends on bug 12802. Recipients are defined by AutoEmailPrimaryAddress. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 11:28:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 10:28:41 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #127 from Jonathan Druart --- /suspension is expecting a date other routes are expecting a datetime That seems inconsistent and wrong. IMO we should open a separate bug report and base the test fix on top of it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 12:00:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 11:00:27 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127232|0 |1 is obsolete| | --- Comment #128 from Jonathan Druart --- Created attachment 127239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127239&action=edit Bug 24850: Date only are not RFC3339 We removed the fallback on 'Bug 24850: Don't fallback when date_format is passed', and the dates passed for date only (YYYY-MM-DD) are not RFC3339 formatted but ISO8601. We must assume that all dates will be YYYY-MM-DD, without fallback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 12:08:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 11:08:45 +0000 Subject: [Koha-bugs] [Bug 29401] New: Hold suspensions should match the resolution of other holds date fields Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29401 Bug ID: 29401 Summary: Hold suspensions should match the resolution of other holds date fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The suspenduntil field is a datetime, but all other fields in the reserves table are date only... we even have code to undo the 'time' resolution.. we should instead just make the database field a date instead of datetime to match the other fields.. Or.. if hourly resolution is really needed, we should update all the fields to respect that and add the corresponding code :S -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 12:08:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 11:08:52 +0000 Subject: [Koha-bugs] [Bug 29401] Hold suspensions should match the resolution of other holds date fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29401 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 12:09:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 11:09:02 +0000 Subject: [Koha-bugs] [Bug 29401] Hold suspensions should match the resolution of other holds date fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29401 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24850 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 12:09:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 11:09:02 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29401 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29401 [Bug 29401] Hold suspensions should match the resolution of other holds date fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 12:16:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 11:16:44 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #129 from Jonathan Druart --- Created attachment 127240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127240&action=edit Bug 24850: Correctly handle suspended_until for PUT if we are passing suspended_until to the body, it should be a rfc3339 (what the spec is expecting) but $hold->suspend_until will be iso -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 12:24:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 11:24:31 +0000 Subject: [Koha-bugs] [Bug 29401] Hold suspensions should match the resolution of other holds date fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29401 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- What I would do first is to make the REST API consistent. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 12:33:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 11:33:24 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard --- I worry that too many of the available notices depend on logic or circumstances which aren't taken into account for here. - ACCTDETAILS Account Details Template - DEFAULT -- This one is useful, although it's not good that our sample notice includes the encrypted password. - MEMBERSHIP_EXPIRY Account expiration -- I can see this being useful as well. - OPAC_REG_VERIFY Opac Self-Registration Verification Email -- This would be useful if it could be done, but can it? If you require email verification for self-registrations the patron record isn't created until verified. Meaning you couldn't find the patron record to re-send the verification. - PASSWORD_RESET Online password reset -- Useful, but doesn't work. There is no link in the message. - DISCHARGE Discharge -- This notice is usually generated as a PDF, not sent via email. Does an email work for the discharge process? These notices don't make sense because there's not enough context for the message: PROBLEM_REPORT OPAC Problem Report SHARE_ACCEPT Notification about an accepted share SHARE_INVITE Invitation for sharing a list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 12:36:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 11:36:03 +0000 Subject: [Koha-bugs] [Bug 29402] New: We should add a 'dateonly' switch option to dt_from_string Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29402 Bug ID: 29402 Summary: We should add a 'dateonly' switch option to dt_from_string Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Currently, our dateformat is only 'strict' with the rfc3339 format. ISO dates may optionally contain a time portion, but that time portion is incompatible with refc3339 formatted dates. We should add a dateonly option to dt_from_string so we can explicitly fail if an iso date string is passed with a time element that we should drop due to a failed match. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 12:36:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 11:36:30 +0000 Subject: [Koha-bugs] [Bug 29402] We should add a 'dateonly' switch option to dt_from_string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29402 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 12:38:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 11:38:57 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127235|0 |1 is obsolete| | --- Comment #130 from Martin Renvoize --- Created attachment 127241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127241&action=edit Bug 24850: Fix api/v1/holds.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 12:39:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 11:39:02 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127236|0 |1 is obsolete| | --- Comment #131 from Martin Renvoize --- Created attachment 127242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127242&action=edit Bug 24850: suspended_until is a date-time Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 12:39:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 11:39:07 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127239|0 |1 is obsolete| | --- Comment #132 from Martin Renvoize --- Created attachment 127243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127243&action=edit Bug 24850: Date only are not RFC3339 We removed the fallback on 'Bug 24850: Don't fallback when date_format is passed', and the dates passed for date only (YYYY-MM-DD) are not RFC3339 formatted but ISO8601. We must assume that all dates will be YYYY-MM-DD, without fallback. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 12:39:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 11:39:11 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127240|0 |1 is obsolete| | --- Comment #133 from Martin Renvoize --- Created attachment 127244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127244&action=edit Bug 24850: Correctly handle suspended_until for PUT if we are passing suspended_until to the body, it should be a rfc3339 (what the spec is expecting) but $hold->suspend_until will be iso Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 12:39:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 11:39:44 +0000 Subject: [Koha-bugs] [Bug 29402] We should add a 'dateonly' switch option to dt_from_string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29402 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24850 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 12:39:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 11:39:44 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29402 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29402 [Bug 29402] We should add a 'dateonly' switch option to dt_from_string -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 12:40:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 11:40:35 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 --- Comment #19 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #18) > In other words, please show me a better example where it does not work now > in list context. This sub: sub items_fetch { return Koha::Items->search(...); } will respect list context and do the appropriate thing i.e. my @items = items_fetch(); will perform the DB query, and have @items be assigned a list of Koha::Item objects. As ->empty is expected to be returned sometimes, and (why not) chained with other queries, it needs to behave the same as ->search. This is the ->empty counterpart of what I raised on bug 28883. Look at t/db_dependendent/Koha/Biblio.t:419 the addition of ->as_list there, is a consequence of the possibility Koha::Libraries->new->empty is returned in some scenarios. So Koha::Biblio->pickup_locations can honour list context sometimes, and sometimes not. With this patch the programmer can be sure ->pickup_locations has a predictable behavior and avoid coding for exceptional cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 12:41:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 11:41:36 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #134 from Martin Renvoize --- OK.. I've tested the follow-ups and agree that, although not perfect in the wider scheme, they are what we should push for now.. as such I've signed off. I have added two new bugs depending on this one however, to continue the work to clarify and improve our date handling situation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 12:43:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 11:43:07 +0000 Subject: [Koha-bugs] [Bug 29389] Add holding branch to holds queue report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29389 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 12:43:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 11:43:52 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 --- Comment #20 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #19) > So Koha::Biblio->pickup_locations can honour list context sometimes, and > sometimes not. With this patch the programmer can be sure ->pickup_locations > has a predictable behavior and avoid coding for exceptional cases. That said, removing the use of wantarray entirely (with which I agree after the debate, and because of the tradeoffs, not for the behavior), would make this patch unnecessary. But that doesn't look like it is gonna happen soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 12:52:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 11:52:30 +0000 Subject: [Koha-bugs] [Bug 29389] Add holding branch to holds queue report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29389 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard --- I don't think the new column should be first. Title is almost always first in tables like this and I think we should keep it consistent. The new column should be called "Current library" to be consistent with the detail page and holds awaiting pickup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 12:55:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 11:55:38 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 13:11:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 12:11:10 +0000 Subject: [Koha-bugs] [Bug 28450] Make Account summary print tables configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28450 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127122|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 127245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127245&action=edit Bug 28450: Make Account summary print tables configurable This patch adds table settings for the three tables which appear on the patron's "Print summary" view. This will allow the administrator to set a default configuration for columns on the print summary page. To test, apply the patch and restart-all to load the revised columns settings YAML. Rebuild the staff interface SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> Table settings -> Circulation. - Under the "Circulation tables" heading you should see a "Jump to" link to "print_summary." - In the settings for the print_summary page you should see three tables: print-summary-checkouts, print-summary-fines, and print-summary-holds. - Locate a patron account which has checkouts, fines, and holds. - From the patron detail view click "Print -> Print summary." - A new window should open with the print summary view. All tables should display correctly. - Test that the "Columns" buttons work correctly to show and hide columns. - Make changes to the default settings for these tables to confirm that they work on the print summary page. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 13:11:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 12:11:19 +0000 Subject: [Koha-bugs] [Bug 28450] Make Account summary print tables configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28450 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #6 from Jonathan Druart --- Last patch removes changes to staff-global.css (it contains git conflict markers). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 13:14:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 12:14:32 +0000 Subject: [Koha-bugs] [Bug 29403] New: dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Bug ID: 29403 Summary: dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Our dt_from_string regex for time is optional.. as such we allow for non-matches.. but we don't check that the string as a whole matches a valid date/datetime string.. thus we don't fail when we should. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 13:16:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 12:16:26 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #1 from Martin Renvoize --- Created attachment 127246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127246&action=edit Bug 29403: Unit tests Add a unit test for proper iso date handling -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 13:16:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 12:16:29 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #2 from Martin Renvoize --- Created attachment 127247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127247&action=edit Bug 29403: Match the whole string This patch wraps the constructed regex such that we expect the entire regex to match and don't allow leading or trailing garbage. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 13:17:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 12:17:03 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 13:17:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 12:17:09 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 13:17:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 12:17:45 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #3 from Martin Renvoize --- This should be tested in conjunction with the existing API tests.. I'm betting by making this more strict we could be exposing a few issues ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 13:18:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 12:18:02 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 13:18:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 12:18:38 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24850 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 13:18:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 12:18:38 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 13:26:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 12:26:42 +0000 Subject: [Koha-bugs] [Bug 28236] Selecting database columns for system preferences in standard and dev installs is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126645|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 127248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127248&action=edit Bug 28236: Allow access to json files from apache config This patch grants json files from koha-tmpl. Otherwise systempreferences won't be able to fetch them. TEST PLAN: 1) Try to set systempreference BorrowerUnwantedField. 2) The modal is empty. 3) Modify Apache configurations like in this patch. 4) Try again set the systempreference. 5) The modal should show list of parameters. Sponsored-by: Koha-Suomi Oy Signed-off-by: Martin Renvoize JD Amended patch: replace tab characters and reword commit title -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 13:30:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 12:30:18 +0000 Subject: [Koha-bugs] [Bug 28362] Add 'Preferred language' to self-registration form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28362 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #1 from Magnus Enger --- Since lang is just a field in the borrowers table, I'm kind of surprised this is missing. It is also missing from the list of fields that can be selected/deselected for PatronSelfRegistrationBorrowerUnwantedField. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 13:30:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 12:30:19 +0000 Subject: [Koha-bugs] [Bug 29380] Auto renewing, batch due date extension tool and checkout note previews are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29380 --- Comment #9 from Jonathan Druart --- Patches will be squashed when pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 13:32:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 12:32:48 +0000 Subject: [Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #6 from Jonathan Druart --- Not a big deal as the sub is private and only called once, but it would have good to test for the existence of the key, to avoid a warning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 13:32:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 12:32:56 +0000 Subject: [Koha-bugs] [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171 --- Comment #30 from Katrin Fischer --- It looks like we have the "clever" sorting only on staff side, any reason why we shoudl not do the same for the OPAC? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 13:40:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 12:40:42 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 --- Comment #26 from Jonathan Druart --- Is that correct to assume that nothing has been published before year 1000? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 13:43:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 12:43:08 +0000 Subject: [Koha-bugs] [Bug 28417] Authen::CAS::Client always loaded even if CAS is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28417 --- Comment #15 from Jonathan Druart --- Tomas, I think your patch is adding back the problem in opac-user.pl. What about the following change? diff --git a/opac/opac-user.pl b/opac/opac-user.pl index 6feb144e508..e610cabc2ab 100755 --- a/opac/opac-user.pl +++ b/opac/opac-user.pl @@ -57,8 +57,10 @@ my $query = CGI->new; # CAS single logout handling # Will print header and exit -require C4::Auth_with_cas; -C4::Context->preference('casAuthentication') and C4::Auth_with_cas::logout_if_required($query); +if ( C4::Context->preference('casAuthentication') ) { + require C4::Auth_with_cas; + C4::Auth_with_cas::logout_if_required($query); +} my ( $template, $borrowernumber, $cookie ) = get_template_and_user( { -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 13:43:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 12:43:49 +0000 Subject: [Koha-bugs] [Bug 28417] Authen::CAS::Client always loaded even if CAS is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28417 --- Comment #16 from Jonathan Druart --- Created attachment 127249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127249&action=edit Bug 28417: Don't require C4::Auth_with_cas from opac-user if not needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 13:45:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 12:45:24 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com --- Comment #5 from Donna --- I feel this would benefit from having a permission attached to it. Many libraries will not want all staff to have this ability and will want an easy way to disable it, without blocking staff from being able to use the Add message functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 13:46:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 12:46:40 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 --- Comment #6 from Alex Arnaud --- (In reply to Owen Leonard from comment #4) > I worry that too many of the available notices depend on logic or > circumstances which aren't taken into account for here. > Hello Owen, I would say that it is the responsibility of the user/librarian to use the appropriate letter. Is there any security/system/GDPR risk according to you ? The goal here is to allow librarian to have some predefined letters to be used in the "Add message" feature. I choose "members" as letters category for this. Would a new module be better ? And thank you for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:08:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:08:48 +0000 Subject: [Koha-bugs] [Bug 29402] We should add a 'dateonly' switch option to dt_from_string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29402 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29403 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:08:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:08:48 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29402 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:10:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:10:07 +0000 Subject: [Koha-bugs] [Bug 29402] We should add a 'dateonly' switch option to dt_from_string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29402 --- Comment #1 from Martin Renvoize --- Bug 29403 improves the situation regards date strings with unexpected data prepended/appended.. but it doesn't strictly prevent a valid datetime being accepted when only a date was expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:11:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:11:03 +0000 Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart+koha at gmail. | |com --- Comment #18 from Jonathan Druart --- 1. This one seems wrong: koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt: link = `request.pl?biblionumbers=[% biblionumbers | url %]&action=cancelBulk&ids=${$('.holds_table .select_hold:checked').toArray().map(el => $(el).data('id')).join(',')}`; I don't have the time to confirm now but could do later. 2. This one is wrong: koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc: [% SET data_url = "/cgi-bin/koha/reserve/request.pl?borrowernumber=" _ borrower.borrowernumber _ "&multi_hold=1&biblionumbers=" _ biblionumbers %] to recreate: search, select at least 2 records, place holds, search for patron (which will give you several results), select one => url is /reserve/request.pl?borrowernumber=19&multi_hold=1&biblionumbers=ARRAY(0x55def41723e8) 3. The occurrences of biblionumers in virtualshelves/addbybiblionumber.tt seem wrong but not related (?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:14:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:14:03 +0000 Subject: [Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:14:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:14:07 +0000 Subject: [Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #14 from Owen Leonard --- Created attachment 127250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127250&action=edit Bug 29212: (follow-up) Fixes to suspend hold process This patch reworks the process of suspending an individual hold from the patron's hold list. Instead of repeating the modal markup in each line of the holds table, a single modal is re-used. A "focus: false" is added to the modal via a data-attribute in order to overcome problems with selecting months and using keyboard navigation in the calendar popup. To test, apply the patch and log into the OPAC as a user with holds. - View the holds tab under "Your summary." - Click the "Suspend" button next to one of the holds. - You should see a modal which shows the title of the item in question. - Test that the date picker works correctly: - Test selecting a month and year - Test selecting a date both with the mouse and by using arrow keys. - Test that you can clear the selected date both by clicking the X and by clicking the text link. - Select a date and close the modal without submitting the suspension. - Click the "Suspend" link on another title to confirm that the date picker still works correctly. - Submit a suspension and confirm that the it completes successfully. - -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:21:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:21:34 +0000 Subject: [Koha-bugs] [Bug 28417] Authen::CAS::Client always loaded even if CAS is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127249|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 127251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127251&action=edit Bug 28417: Don't require C4::Auth_with_cas from opac-user if not needed Note that without the use URI::QueryParam statement in C4::Auth we get: Can't locate object method "query_param_delete" via package "URI::_generic" at /kohadevbox/koha/C4/Auth.pm line 1254 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:25:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:25:39 +0000 Subject: [Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Passed QA |Failed QA --- Comment #16 from Jonathan Druart --- (In reply to Katrin Fischer from comment #15) > I am inclined to pass this change as is, but we are missing a specific test > for the new feature. Maybe someone would be willing to step up here? Yes, I am sorry, no more exceptions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:27:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:27:28 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 --- Comment #28 from Emmi Takkinen --- Created attachment 127252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127252&action=edit Bug 16223: Fix QA issues To test repeat original test plan and prove t/db_dependent/Patron/Borrower_Debarments.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:27:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:27:36 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:29:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:29:42 +0000 Subject: [Koha-bugs] [Bug 28474] Pass process_message_queue.pl params to before_send_messages plugin hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28474 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:31:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:31:25 +0000 Subject: [Koha-bugs] [Bug 29355] Pickup location list limited by RESTdefaultPageSize syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29355 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:32:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:32:38 +0000 Subject: [Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart+koha at gmail. | |com --- Comment #15 from Jonathan Druart --- Code is copy/pasted from somewhere else. I cannot push it like that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:33:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:33:53 +0000 Subject: [Koha-bugs] [Bug 29404] New: Add infinite scrolling to pickup location dropdowns Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 Bug ID: 29404 Summary: Add infinite scrolling to pickup location dropdowns Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com As mentioned on bug 29355 comment 12, we should've made the pickup locations dropdowns use the infinite scrolling feature from Select2. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:34:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:34:11 +0000 Subject: [Koha-bugs] [Bug 27173] Add plugin hooks for authority record changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #13 from Jonathan Druart --- Please add it to the wiki page: https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:34:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:34:29 +0000 Subject: [Koha-bugs] [Bug 29404] Add infinite scrolling to pickup location dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, | |jonathan.druart+koha at gmail. | |com, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com Depends on| |29355 Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29355 [Bug 29355] Pickup location list limited by RESTdefaultPageSize syspref -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:34:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:34:29 +0000 Subject: [Koha-bugs] [Bug 29355] Pickup location list limited by RESTdefaultPageSize syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29355 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29404 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 [Bug 29404] Add infinite scrolling to pickup location dropdowns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:34:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:34:43 +0000 Subject: [Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 --- Comment #16 from Lucas Gass --- (In reply to Jonathan Druart from comment #15) > Code is copy/pasted from somewhere else. I cannot push it like that. I took most of this code from the OPACStarRatings on the results page. What needs to be amended? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:35:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:35:04 +0000 Subject: [Koha-bugs] [Bug 29404] Add infinite scrolling to pickup location dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:38:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:38:58 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Keywords| |release-notes-needed --- Comment #30 from Jonathan Druart --- We could think it will hide them from Hea, but it won't! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:39:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:39:34 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 --- Comment #31 from Jonathan Druart --- Created attachment 127253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127253&action=edit Bug 27360: Prevent crash if branchcode does not exist -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:40:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:40:22 +0000 Subject: [Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 --- Comment #17 from Lucas Gass --- (In reply to Lucas Gass from comment #16) > (In reply to Jonathan Druart from comment #15) > > Code is copy/pasted from somewhere else. I cannot push it like that. Are you asking me to put the repeated code in an include? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:44:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:44:07 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #4 from Martin Renvoize --- Created attachment 127254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127254&action=edit Bug 29403: Fix api/v1/patrons.t t::lib::Dates::compare expects either correct DateTime objects, or a system formatted datetime strings to be passed.. but as we're testing the API, we are consistently using RFC3339 strings for date-times and ISO8601 strings for dates. We need to therefore pre-process the strings into DateTime objects for the comparison. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:44:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:44:16 +0000 Subject: [Koha-bugs] [Bug 29404] Add infinite scrolling to pickup location dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 127255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127255&action=edit Bug 29404: Add infinite scrolling to pickup location dropdowns This patch adds infinite scrolling to the pickup locations select2 dropdowns on the staff interface. It does so by adding a new transport function (in select2.js) to read the response headers Koha's API sends back, and converting to the right data structure Select2 expects for the feature to work. This is manually used in the different pickup locations dropdowns. There's a separate bug that will introduce a select2 wrapper that will probably embed this function in it. To test: 1. Run the [DO NOT PUSH] script inside koha-shell to generate random pickup locations: $ kshell k$ perl generate_pickup_locations.pl 2. Try placing holds. Notice the visible pickup locations dropdowns display some pickup locations based on the matches you got. They are all fetched once => SUCCESS: It works 3. Repeat for the current holds page and the patron holds listing => SUCCESS: Same behavior 4. Apply this patch 5. Repeat 2 and 3 => SUCCESS: Things work, but pickup locations are retrieved as needed, while you scroll. 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:44:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:44:19 +0000 Subject: [Koha-bugs] [Bug 26326] Add Koha Objects for Import Records and Import Record Matches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #27 from Jonathan Druart --- +sub unset_chosen { + my ( $self ) = @_; + while ( my $match = $self->next ){ + $match->chosen(0)->store; + } +} This is not used, not covered by tests, and actually could be replaced by a single $set->update call. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:45:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:45:51 +0000 Subject: [Koha-bugs] [Bug 29404] Add infinite scrolling to pickup location dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 127256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127256&action=edit [DO NOT PUSH] Bug 29404: Helper script to generate pickup locations Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:47:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:47:03 +0000 Subject: [Koha-bugs] [Bug 29405] New: The patron spec for date_renewed is missing it's format definition Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29405 Bug ID: 29405 Summary: The patron spec for date_renewed is missing it's format definition Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com As the title says -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:47:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:47:14 +0000 Subject: [Koha-bugs] [Bug 29405] The patron spec for date_renewed is missing it's format definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29405 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:48:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:48:12 +0000 Subject: [Koha-bugs] [Bug 26326] Add Koha Objects for Import Records and Import Record Matches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127165|0 |1 is obsolete| | Attachment #127166|0 |1 is obsolete| | Attachment #127167|0 |1 is obsolete| | Attachment #127168|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart --- Created attachment 127257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127257&action=edit Bug 26326: Add Koha Objects for Import Records and Import Record Matches To test: 1 - Apply patches 2 - Update database 3 - Generate schema files (dbic) 4 - prove -v t/db_dependent/Koha/Import/Records.t 5 - prove -v t/db_dependent/Koha/Import/Record/Matches.t Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer JD Amended patch: remove unused unset_chosen method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:48:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:48:17 +0000 Subject: [Koha-bugs] [Bug 26326] Add Koha Objects for Import Records and Import Record Matches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 --- Comment #29 from Jonathan Druart --- Created attachment 127258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127258&action=edit Bug 26326: (follow-up) Add ability to check for existence of any primary key Before dropping a primary key we need to see if one exists - this updates the installer method to allow searching for existence of key Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Bug 26326: (follow-up) Address qa script failures Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:48:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:48:22 +0000 Subject: [Koha-bugs] [Bug 26326] Add Koha Objects for Import Records and Import Record Matches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 --- Comment #30 from Jonathan Druart --- Created attachment 127259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127259&action=edit Bug 26326: DO NOT PUSH Schema changes Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:48:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:48:32 +0000 Subject: [Koha-bugs] [Bug 29405] The patron spec for date_renewed is missing it's format definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29405 --- Comment #1 from Martin Renvoize --- Created attachment 127260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127260&action=edit Bug 29405: Fix spec This patch just adds the 'date' format string to ensure we are validating the input/output of the date_renewed field correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:48:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:48:59 +0000 Subject: [Koha-bugs] [Bug 29405] The patron spec for date_renewed is missing it's format definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29405 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:49:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:49:09 +0000 Subject: [Koha-bugs] [Bug 29405] The patron spec for date_renewed is missing it's format definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29405 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:49:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:49:20 +0000 Subject: [Koha-bugs] [Bug 29405] The patron spec for date_renewed is missing it's format definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29405 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:52:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:52:17 +0000 Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127195|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart --- Created attachment 127261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127261&action=edit Bug 29015: Unit tests Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer JD Amended patch: perltidy! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:52:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:52:52 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 --- Comment #32 from Martin Renvoize --- (In reply to Jonathan Druart from comment #30) > We could think it will hide them from Hea, but it won't! Does the hint not help enough with that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:54:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:54:02 +0000 Subject: [Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 --- Comment #18 from Jonathan Druart --- (In reply to Lucas Gass from comment #17) > (In reply to Lucas Gass from comment #16) > > (In reply to Jonathan Druart from comment #15) > > > Code is copy/pasted from somewhere else. I cannot push it like that. > > Are you asking me to put the repeated code in an include? Yes, please? It can be done on a separate bug report if you prefer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:56:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:56:48 +0000 Subject: [Koha-bugs] [Bug 29404] Add infinite scrolling to pickup location dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:57:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:57:27 +0000 Subject: [Koha-bugs] [Bug 29404] Add infinite scrolling to pickup location dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127255|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 127262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127262&action=edit Bug 29404: Add infinite scrolling to pickup location dropdowns This patch adds infinite scrolling to the pickup locations select2 dropdowns on the staff interface. It does so by adding a new transport function (in select2.js) to read the response headers Koha's API sends back, and converting to the right data structure Select2 expects for the feature to work. This is manually used in the different pickup locations dropdowns. There's a separate bug that will introduce a select2 wrapper that will probably embed this function in it. To test: 1. Run the [DO NOT PUSH] script inside koha-shell to generate random pickup locations: $ kshell k$ perl generate_pickup_locations.pl 2. Try placing holds. Notice the visible pickup locations dropdowns display some pickup locations based on the matches you got. They are all fetched once => SUCCESS: It works 3. Repeat for the current holds page and the patron holds listing => SUCCESS: Same behavior 4. Apply this patch 5. Repeat 2 and 3 => SUCCESS: Things work, but pickup locations are retrieved as needed, while you scroll. 6. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:58:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:58:02 +0000 Subject: [Koha-bugs] [Bug 29168] Only show "Request article" if allowed on the detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:58:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:58:08 +0000 Subject: [Koha-bugs] [Bug 29404] Add infinite scrolling to pickup location dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize --- Works as expected :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 14:59:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 13:59:32 +0000 Subject: [Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124659|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 127263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127263&action=edit Bug 13706: New script dedup_authorities.pl This script allow to deduplicate authorities automatically. Script is in misc/maintenance/ It works this way: 1) authorities are fetched from the database. You can limit fetched results by authtypecode, or directly by specifying WHERE clause 2) for each authority: 2.1) build a Zebra query using the 'search_form' for the heading 2.2) run the query, retrieve the results 2.3) among duplicates, choose the one we want to keep (use --choose-method option). 2.5) use C4::Authorities::merge to merge authorities 3) delete the merged authorities Use --help for more informations on options To be done: 1 - Move to module and cover with tests 2 - Add option to only merge unused authorities 3 - Expand 'ppn' option to be 'control-number' option and allow specifying field 4 - More? 1 & 2 I will attempt - 3 & 4 may be future enhancements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:05:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:05:12 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 --- Comment #27 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #26) > Is that correct to assume that nothing has been published before year 1000? Certainly not :) But thats really an negligible edge case here. The advantage of defaulting to 4 positions for the large majority is greater. And still 300? works. Another edge case is years B.C. with -300 or so. Dont think we should focus on rare exceptions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:06:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:06:13 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127234|0 |1 is obsolete| | --- Comment #18 from Peter Vashchuk --- Created attachment 127264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127264&action=edit Bug 27708: (QA follow-up) Add a few tests for Koha::Edifact::Order 1. This adds a simple regression test to make sure order_line() method executes correctly with basket create_items set to "ordering" and "receiving". 2. A simple test for the filename method is added To test: 1) prove t/db_dependent/Koha/Edifact/Order.t Signed-off-by: Joonas Kylmälä Signed-off-by: David Nind Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:13:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:13:30 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 --- Comment #33 from Jonathan Druart --- (In reply to Martin Renvoize from comment #32) > (In reply to Jonathan Druart from comment #30) > > We could think it will hide them from Hea, but it won't! > > Does the hint not help enough with that? I guess it does. But a "non public library" could have their info shared with Hea. I just wanted to highlight it, not requested something :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:14:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:14:45 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 --- Comment #28 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #27) > (In reply to Jonathan Druart from comment #26) > > Is that correct to assume that nothing has been published before year 1000? > > Certainly not :) But thats really an negligible edge case here. The > advantage of defaulting to 4 positions for the large majority is greater. > And still 300? works. > > Another edge case is years B.C. with -300 or so. > > Dont think we should focus on rare exceptions. Maybe entire libraries are using mostly those exceptions :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:29:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:29:47 +0000 Subject: [Koha-bugs] [Bug 24406] Remove patron category category type codes from patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:29:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:29:50 +0000 Subject: [Koha-bugs] [Bug 24406] Remove patron category category type codes from patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:29:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:29:53 +0000 Subject: [Koha-bugs] [Bug 25883] Show transfer on checkin screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25883 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:29:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:29:56 +0000 Subject: [Koha-bugs] [Bug 25883] Show transfer on checkin screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25883 --- Comment #19 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:29:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:29:59 +0000 Subject: [Koha-bugs] [Bug 26326] Add Koha Objects for Import Records and Import Record Matches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:30:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:30:02 +0000 Subject: [Koha-bugs] [Bug 26326] Add Koha Objects for Import Records and Import Record Matches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 --- Comment #31 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:30:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:30:04 +0000 Subject: [Koha-bugs] [Bug 26402] Add --framework parameter to commit_file.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26402 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:30:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:30:07 +0000 Subject: [Koha-bugs] [Bug 26402] Add --framework parameter to commit_file.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26402 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:30:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:30:10 +0000 Subject: [Koha-bugs] [Bug 27173] Add plugin hooks for authority record changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:30:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:30:13 +0000 Subject: [Koha-bugs] [Bug 27173] Add plugin hooks for authority record changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173 --- Comment #14 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:30:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:30:16 +0000 Subject: [Koha-bugs] [Bug 27296] Return claims should be filtered by default to show unresolved claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27296 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:30:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:30:19 +0000 Subject: [Koha-bugs] [Bug 27296] Return claims should be filtered by default to show unresolved claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27296 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:30:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:30:21 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:30:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:30:24 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 --- Comment #34 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:30:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:30:27 +0000 Subject: [Koha-bugs] [Bug 27375] Set YAML file settings in .editorconfig In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27375 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:30:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:30:30 +0000 Subject: [Koha-bugs] [Bug 27375] Set YAML file settings in .editorconfig In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27375 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:30:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:30:32 +0000 Subject: [Koha-bugs] [Bug 27823] List upcoming steps during installation process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27823 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:30:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:30:35 +0000 Subject: [Koha-bugs] [Bug 27823] List upcoming steps during installation process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27823 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:30:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:30:37 +0000 Subject: [Koha-bugs] [Bug 28236] Selecting database columns for system preferences in standard and dev installs is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:30:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:30:40 +0000 Subject: [Koha-bugs] [Bug 28236] Selecting database columns for system preferences in standard and dev installs is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 --- Comment #9 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:30:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:30:43 +0000 Subject: [Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:30:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:30:47 +0000 Subject: [Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:30:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:30:49 +0000 Subject: [Koha-bugs] [Bug 28417] Authen::CAS::Client always loaded even if CAS is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:30:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:30:52 +0000 Subject: [Koha-bugs] [Bug 28417] Authen::CAS::Client always loaded even if CAS is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28417 --- Comment #18 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:30:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:30:55 +0000 Subject: [Koha-bugs] [Bug 28450] Make Account summary print tables configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28450 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:30:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:30:58 +0000 Subject: [Koha-bugs] [Bug 28450] Make Account summary print tables configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28450 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:31:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:31:01 +0000 Subject: [Koha-bugs] [Bug 28474] Pass process_message_queue.pl params to before_send_messages plugin hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28474 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:31:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:31:04 +0000 Subject: [Koha-bugs] [Bug 28474] Pass process_message_queue.pl params to before_send_messages plugin hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28474 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:31:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:31:08 +0000 Subject: [Koha-bugs] [Bug 28537] Improve HTML generated by OverDrive integration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28537 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:31:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:31:12 +0000 Subject: [Koha-bugs] [Bug 28537] Improve HTML generated by OverDrive integration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28537 --- Comment #10 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:31:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:31:15 +0000 Subject: [Koha-bugs] [Bug 28694] Check alert in cataloguing should be a static message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:31:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:31:19 +0000 Subject: [Koha-bugs] [Bug 28694] Check alert in cataloguing should be a static message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694 --- Comment #14 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:31:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:31:22 +0000 Subject: [Koha-bugs] [Bug 28816] Improve the display of multiple holds during hold process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:31:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:31:25 +0000 Subject: [Koha-bugs] [Bug 28816] Improve the display of multiple holds during hold process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:31:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:31:29 +0000 Subject: [Koha-bugs] [Bug 28879] Display of metadata with long label names looks terrible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28879 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:31:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:31:33 +0000 Subject: [Koha-bugs] [Bug 28879] Display of metadata with long label names looks terrible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28879 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:31:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:31:36 +0000 Subject: [Koha-bugs] [Bug 28973] Improve Koha::Patron::can_see_patron_infos efficiency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28973 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:31:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:31:39 +0000 Subject: [Koha-bugs] [Bug 28973] Improve Koha::Patron::can_see_patron_infos efficiency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28973 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:31:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:31:42 +0000 Subject: [Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:31:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:31:45 +0000 Subject: [Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 --- Comment #11 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:31:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:31:49 +0000 Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:31:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:31:52 +0000 Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 --- Comment #32 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:31:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:31:56 +0000 Subject: [Koha-bugs] [Bug 29201] biblio_framework missing form list of runtime parameters when editing SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29201 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:31:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:31:59 +0000 Subject: [Koha-bugs] [Bug 29201] biblio_framework missing form list of runtime parameters when editing SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29201 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:32:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:32:02 +0000 Subject: [Koha-bugs] [Bug 29265] Can't pick editor to use when adding new news or HTML customization entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29265 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:32:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:32:04 +0000 Subject: [Koha-bugs] [Bug 29265] Can't pick editor to use when adding new news or HTML customization entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29265 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:32:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:32:08 +0000 Subject: [Koha-bugs] [Bug 29369] Use Flatpickr in dateaccessioned cataloging plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29369 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:32:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:32:13 +0000 Subject: [Koha-bugs] [Bug 29369] Use Flatpickr in dateaccessioned cataloging plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29369 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:32:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:32:16 +0000 Subject: [Koha-bugs] [Bug 29380] Auto renewing, batch due date extension tool and checkout note previews are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29380 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:32:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:32:20 +0000 Subject: [Koha-bugs] [Bug 29380] Auto renewing, batch due date extension tool and checkout note previews are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29380 --- Comment #10 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:32:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:32:24 +0000 Subject: [Koha-bugs] [Bug 29395] Use EXPORT_OK in Koha::Patron::Debarments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:32:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:32:26 +0000 Subject: [Koha-bugs] [Bug 29395] Use EXPORT_OK in Koha::Patron::Debarments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29395 --- Comment #2 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:35:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:35:32 +0000 Subject: [Koha-bugs] [Bug 28236] Selecting database columns for system preferences in standard and dev installs is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 --- Comment #10 from Jonathan Druart --- Congratulations for your first patch pushed, Johanna! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:36:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:36:26 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed, | |rel_21_11_candidate | --- Comment #135 from Jonathan Druart --- Last patches pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:37:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:37:32 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 --- Comment #29 from Marcel de Rooy --- Try this: use Modern::Perl; use Data::Dumper qw/Dumper/; use C4::Biblio; print C4::Biblio::_adjust_pubyear('2xx'); 19.11 => 2000 master (without this patch) => Use of uninitialized value in print at zz line 5. (Changes between 19,11 and master: now returns undef) Both cases are not what we expected. This passed QA. I would recommend to push it. Further fixes may follow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:38:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:38:50 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #17 from Owen Leonard --- (In reply to Katrin Fischer from comment #16) > - > + This change is correct, so if it can be slipped in here I would approve. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:39:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:39:49 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #18 from Owen Leonard --- Haha because I did it. Of course I would approve. I have no memory of this patch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:41:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:41:28 +0000 Subject: [Koha-bugs] [Bug 29261] Translation script breaks members/tables/members_results.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29261 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed, | |rel_21_11_candidate | --- Comment #10 from Jonathan Druart --- Last patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:41:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:41:36 +0000 Subject: [Koha-bugs] [Bug 29261] Translation script breaks members/tables/members_results.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29261 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:41:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:41:55 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 --- Comment #1 from Martin Renvoize --- Created attachment 127265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127265&action=edit Bug 29397: Add .kohaSelect select2 wrapper function This patch adds a kohaSelect wrapper function to simplify paging/infinite scrolling with select2 using the Koha RESTful api's. Invoke select2 select boxes as you normally would from JS, but instead of calling .select2(config) use .kohaSelect(config). If an 'ajax' property is defined in your config object, we wrap the transport such that responses include a pagination key as expected by select2. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:42:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:42:09 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:44:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:44:50 +0000 Subject: [Koha-bugs] [Bug 27173] Add plugin hooks for authority record changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173 --- Comment #15 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #13) > Please add it to the wiki page: > https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks Done -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 15:49:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 14:49:25 +0000 Subject: [Koha-bugs] [Bug 29386] background jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 16:09:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 15:09:09 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 16:10:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 15:10:27 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 16:10:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 15:10:34 +0000 Subject: [Koha-bugs] [Bug 29386] background jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 --- Comment #4 from Andrew Nugged --- What things hold us from allowing this to be LONGTEXT? Will fields occupy much more space on disk as I thought and only? I had only things one from "cons" and here people already thought the same: "The only difference is the length field in the row data. Using MEDIUMTEXT instead of LONGTEXT saves 1 byte per record. If you have 100 million records, that saves 100 MB." https://stackoverflow.com/questions/58225898/mysql-is-there-a-lack-of-performance-by-using-longtext-instead-of-mediumtext no more cons from having LONGTEXT? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 16:15:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 15:15:58 +0000 Subject: [Koha-bugs] [Bug 24609] Add routes for updating checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 16:16:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 15:16:16 +0000 Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off Keywords| |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 16:18:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 15:18:38 +0000 Subject: [Koha-bugs] [Bug 29406] New: Improve display of OPAC suppression message Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29406 Bug ID: 29406 Summary: Improve display of OPAC suppression message Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 14377 Created attachment 127266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127266&action=edit Screenshot of a search results entry for a suppressed record In both staff interface search results and on the bibliographic detail page the "Suppressed in OPAC" message is shown at the top of the record. I think it makes more sense to show it with the other bibliographic details. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 [Bug 14377] Indicate that a record is suppressed in staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 16:18:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 15:18:38 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29406 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29406 [Bug 29406] Improve display of OPAC suppression message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 16:19:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 15:19:19 +0000 Subject: [Koha-bugs] [Bug 29406] Improve display of OPAC suppression message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29406 --- Comment #1 from Owen Leonard --- Created attachment 127267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127267&action=edit Screenshot of a detail view for a suppressed record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 16:24:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 15:24:25 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22206 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 [Bug 22206] Add routes to enable suspension or resumption of holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 16:24:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 15:24:25 +0000 Subject: [Koha-bugs] [Bug 22206] Add routes to enable suspension or resumption of holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28377 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 [Bug 28377] Use the API to suspend/resume holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 16:24:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 15:24:42 +0000 Subject: [Koha-bugs] [Bug 29386] background jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 --- Comment #5 from Andrew Nugged --- Jonathan: if to take into account your estimations, we have also limits with items: Switching to MEDIUMTEXT will allow ~1.5M items to be queued Switching to LONGTEXT will allow ~420M items to be queued -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 16:25:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 15:25:34 +0000 Subject: [Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 --- Comment #19 from Lucas Gass --- (In reply to Jonathan Druart from comment #18) > (In reply to Lucas Gass from comment #17) > > (In reply to Lucas Gass from comment #16) > > > (In reply to Jonathan Druart from comment #15) > > > > Code is copy/pasted from somewhere else. I cannot push it like that. > > > > Are you asking me to put the repeated code in an include? > > Yes, please? It can be done on a separate bug report if you prefer. No need for a separate bug, I will do it on this one! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 16:31:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 15:31:11 +0000 Subject: [Koha-bugs] [Bug 29386] background jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 --- Comment #6 from Andrew Nugged --- In any case, going MEDIUMTEXT already makes Koha much more "stable", we already have some problematic users worldwide now since announcing of this queueing feature (I have three customers whose batch processing hiddenly failed because of this since spring not once (sic!) ), so for me setting this to MEDIUMTEXT at least gives "relatively much more stability", but: Do we need to allow for operators to operate with >200K biblio-records and >1.5M items in a batch? Because this is more business logic question, on which we can't answer but life, let's make it "trials and errors" way but LET'S MAKE VISIBLE the problem, i.e. I propose this: 1. set to MEDIUMTEXT, and ADD UI analysis/feedback with some "length estimator and limiter", which is to fail with UI errors like: - "ERROR: batch processing of >200K biblios not yet supported" - "ERROR: batch processing of >1.5M items not yet supported" saying even "yet" to signal to "feedback" from customers back to the community, i.e. make it hard-fail on bigger amounts, to prevent HIDDEN ERRORS which is now happening. Then if we will have requests from worldwide users - that can be considered to be switched to LONGTEXT, if no other choice. Anyway seems even with LONGTEXT it seems proper to make some "hard limited" number of queued items or bilbios (accordingly) because otherwise, this will become a "hidden error" anyway (ok, "potential" and "big numbers", but anyway). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 16:37:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 15:37:29 +0000 Subject: [Koha-bugs] [Bug 29406] Improve display of OPAC suppression message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29406 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 16:37:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 15:37:32 +0000 Subject: [Koha-bugs] [Bug 29406] Improve display of OPAC suppression message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29406 --- Comment #2 from Owen Leonard --- Created attachment 127268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127268&action=edit Bug 29406: Improve display of OPAC suppression message This patch changes the way the "Suppressed in OPAC" message is shown on the staff interface search results and the bibliographic detail page. Now the information is displayed like other bibliographic details. To test, apply the patch and restart services. - Enable the OpacSuppression system preference and modify at least one record to be suppressed in the OPAC (942$n in MARC21). - Perform a catalog search which will return this record in the staff client. - The entry for that record in the search results should include the message "Suppressed in OPAC" at the bottom of the list of other bibliographic details. - View the details for that record. You should see a line labeled "OPAC view" It should say "Suppressed in OPAC." - Test a record which is not suppressed. If you have OPACBaseURL populated you should see "OPAC view: Open in new window." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 16:41:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 15:41:01 +0000 Subject: [Koha-bugs] [Bug 29407] New: Make the pickup locations dropdown JS reusable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Bug ID: 29407 Summary: Make the pickup locations dropdown JS reusable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 16:41:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 15:41:19 +0000 Subject: [Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29404 Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 [Bug 29404] Add infinite scrolling to pickup location dropdowns -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 16:41:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 15:41:19 +0000 Subject: [Koha-bugs] [Bug 29404] Add infinite scrolling to pickup location dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29407 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 [Bug 29407] Make the pickup locations dropdown JS reusable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 16:41:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 15:41:49 +0000 Subject: [Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 127269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127269&action=edit Bug 29407: Make the pickup locations dropdown JS reusable This patch generates a function to be used in places where select2 dropdowns are usesd for choosing pickup locations. This cleans repeated/almost identical code introduced by different bugs. To test: 1. Make sure choosing pickup locations works 2. Apply this patch 3. Repeat 1 => SUCCESS: No functional changes 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 16:42:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 15:42:14 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125057|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 127270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127270&action=edit Bug 28377: Use the API to suspend/resume holds This patch makes the patron page (detail and circulation) use the API to suspend/resume holds on the holds tab. It previously used the old svc/ scripts we plan to replace. To test 1. Have a patron with some holds 2. Play with suspending/resuming holds. Include the indefinite suspension. => SUCCESS: Everything works as usual 3. Apply this patch 4. Repeat 2 => SUCCESS: Nothing changed, a soft breeze surprises you 5. Sign off :-D Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 16:42:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 15:42:19 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125058|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 127271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127271&action=edit Bug 28377: (follow-up) Remove svc/hold/{resume|suspend} This files are no longer used and thus removed. Their functionality is already present on the API POST /holds/:hold_id/suspension DELETE /holds/:hold_id/suspension To test: 1. Apply this patch 2. Run: $ git grep 'hold/suspend' $ git grep 'hold/resume' => SUCCESS: No references to the scripts 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 16:43:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 15:43:14 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Martin Renvoize --- OK, great work.. all works as expected :). Passing QA.. I thought it OK to remove the /svc scripts without a deprecation warning as in theory /svc was always a private api. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 16:43:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 15:43:35 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 17:10:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 16:10:45 +0000 Subject: [Koha-bugs] [Bug 29392] Add plugin hooks before merging biblios or authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 17:18:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 16:18:10 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #29 from Martin Renvoize --- Sorry guys.. this is a fail for me. I think you need to move the function call from Koha::Account::pay to Koha::Account::Line::apply.. that way you'll catch any and all calls to apply payments (where you have it now, you'll miss any calls directly to apply, or calls to payin_amount.. and you'll miss cases where there's any additional outstanding credit to be applied from the payment). Also, when autorenewal of items upon payment was added (a similar feature in my opinion).. we required that the user was given feedback of the change.. I'd love to see that here too. I realise this is an old development being worked through.. but at least the first issue needs resolving prior to push in my opinion.. though I'd love to see the second dealt with.. I'd personally be OK with that being in a follow-up bug. Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 17:24:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 16:24:20 +0000 Subject: [Koha-bugs] [Bug 29408] New: The datatables api wrapper is badly named Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Bug ID: 29408 Summary: The datatables api wrapper is badly named Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The dataTables Koha REST wrapper we added recently is badly named.. currently, it's the very unspecific 'api'.. we should start using a consistent naming convention for such JS wrapper functions. In bug 29397 we introduce a minimal select2 wrapper and call it kohaSelect.. I propose we take that as inspiration and rename the dataTables function from 'api' to 'kohaTable'. Thus, creating a new API driven dataTable would become: $(".selector").kohaTable(usual stuff here); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 17:24:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 16:24:26 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is badly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 17:34:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 16:34:35 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is badly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 --- Comment #1 from Martin Renvoize --- Created attachment 127272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127272&action=edit Bug 29408: Rename Koha dataTables wrapper This patch renames the Koha REST JS dataTables wrapper from the ambigious 'api' to the clearer 'kohaTable'. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 17:34:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 16:34:38 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is badly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 --- Comment #2 from Martin Renvoize --- Created attachment 127273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127273&action=edit Bug 29408: Update all existing uses of .api to .kohaTable This patch goes through the codebase and updates existing revelant calls to .api referencing the Koha REST dataTables wrapper to use the name name 'kohaTable'. Test plan. 1) Ensure the tables on the following pages all continue to work as expected a) acqui/parcel b) admin/branches c) admin/cities d) admin/smtp_servers e) pos/register f) tools/quotes Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 17:34:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 16:34:56 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is badly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 17:35:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 16:35:17 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is badly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 17:35:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 16:35:31 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is badly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 17:40:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 16:40:26 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is badly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29397 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 17:40:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 16:40:26 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29408 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 17:43:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 16:43:02 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is badly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com, | |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 17:44:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 16:44:14 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The datatables api wrapper |The datatables api wrapper |is badly named |is ambiguously named -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 17:48:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 16:48:41 +0000 Subject: [Koha-bugs] [Bug 29409] New: Update for bug 25334 can fail due to bad data or constraints Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29409 Bug ID: 29409 Summary: Update for bug 25334 can fail due to bad data or constraints Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The update does not check for the existence of the foreign key before deleting it Additionally we have seen many sites with problematic data that stops the update, will offer a check for what we have seen here -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 17:49:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 16:49:06 +0000 Subject: [Koha-bugs] [Bug 29409] Update for bug 25333 can fail due to bad data or constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29409 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update for bug 25334 can |Update for bug 25333 can |fail due to bad data or |fail due to bad data or |constraints |constraints -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 17:54:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 16:54:05 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 --- Comment #3 from Martin Renvoize --- Created attachment 127274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127274&action=edit Bug 29408: Begginings of JSDoc documentation I'd love to see the parameters clearly documented... I've started it off but need some help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 17:54:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 16:54:41 +0000 Subject: [Koha-bugs] [Bug 29409] Update for bug 25333 can fail due to bad data or constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29409 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 17:54:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 16:54:44 +0000 Subject: [Koha-bugs] [Bug 29409] Update for bug 25333 can fail due to bad data or constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29409 --- Comment #1 from Nick Clemens --- Created attachment 127275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127275&action=edit Bug 29409: Check for existence of constraint before deletion https://bugs.koha-community.org/show_bug.cgi?id=29049 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 17:54:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 16:54:48 +0000 Subject: [Koha-bugs] [Bug 29409] Update for bug 25333 can fail due to bad data or constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29409 --- Comment #2 from Nick Clemens --- Created attachment 127276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127276&action=edit Bug 29409: Check for data that violates a constraint to avoid update problems https://bugs.koha-community.org/show_bug.cgi?id=29049 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 17:55:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 16:55:00 +0000 Subject: [Koha-bugs] [Bug 29409] Update for bug 25333 can fail due to bad data or constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29409 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25333 Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25333 [Bug 25333] Change message transport type for Talking Tech from "phone" to "itiva" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 17:55:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 16:55:00 +0000 Subject: [Koha-bugs] [Bug 25333] Change message transport type for Talking Tech from "phone" to "itiva" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25333 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29409 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29409 [Bug 29409] Update for bug 25333 can fail due to bad data or constraints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 18:20:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 17:20:34 +0000 Subject: [Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 18:25:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 17:25:42 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29404 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 [Bug 29404] Add infinite scrolling to pickup location dropdowns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 18:25:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 17:25:42 +0000 Subject: [Koha-bugs] [Bug 29404] Add infinite scrolling to pickup location dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29397 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 [Bug 29397] Add a select2 wrapper for the API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 18:27:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 17:27:43 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29404 |29407 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 [Bug 29404] Add infinite scrolling to pickup location dropdowns https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 [Bug 29407] Make the pickup locations dropdown JS reusable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 18:27:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 17:27:43 +0000 Subject: [Koha-bugs] [Bug 29404] Add infinite scrolling to pickup location dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29397 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 [Bug 29397] Add a select2 wrapper for the API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 18:27:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 17:27:43 +0000 Subject: [Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29397 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 [Bug 29397] Add a select2 wrapper for the API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 18:31:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 17:31:33 +0000 Subject: [Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127269|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi --- Created attachment 127277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127277&action=edit Bug 29407: Make the pickup locations dropdown JS reusable This patch generates a function to be used in places where select2 dropdowns are usesd for choosing pickup locations. This cleans repeated/almost identical code introduced by different bugs. To test: 1. Make sure choosing pickup locations works 2. Apply this patch 3. Repeat 1 => SUCCESS: No functional changes 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 18:39:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 17:39:17 +0000 Subject: [Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127277|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi --- Created attachment 127278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127278&action=edit Bug 29407: Make the pickup locations dropdown JS reusable This patch generates a function to be used in places where select2 dropdowns are usesd for choosing pickup locations. This cleans repeated/almost identical code introduced by different bugs. To test: 1. Make sure choosing pickup locations works 2. Apply this patch 3. Repeat 1 => SUCCESS: No functional changes 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 18:39:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 17:39:50 +0000 Subject: [Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 --- Comment #4 from Tomás Cohen Arazi --- Small style fixes in the comments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 18:59:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 17:59:05 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 18:59:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 17:59:11 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127265|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi --- Created attachment 127279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127279&action=edit Bug 29397: Add .kohaSelect select2 wrapper function This patch adds a kohaSelect wrapper function to simplify paging/infinite scrolling with select2 using the Koha RESTful api's. Invoke select2 select boxes as you normally would from JS, but instead of calling .select2(config) use .kohaSelect(config). If an 'ajax' property is defined in your config object, we wrap the transport such that responses include a pagination key as expected by select2. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 18:59:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 17:59:18 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 127280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127280&action=edit Bug 29397: Add function documentation Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 18:59:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 17:59:24 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 127281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127281&action=edit Bug 29397: Use kohaSelect for pickup locations This patch makes the pickup location dropdowns that rely on Select2 and the API use the new wrapper. The original transport function is removed as it is now embedded in the wrapper. To test: 1. Follow bug 29404 test plan => SUCCESS: All works 2. Apply this patches 3. Repeat 1 => SUCCESS: All works! 4. sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 19:05:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 18:05:48 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127272|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi --- Created attachment 127282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127282&action=edit Bug 29408: Rename Koha dataTables wrapper This patch renames the Koha REST JS dataTables wrapper from the ambigious 'api' to the clearer 'kohaTable'. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 19:05:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 18:05:56 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127273|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi --- Created attachment 127283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127283&action=edit Bug 29408: Update all existing uses of .api to .kohaTable This patch goes through the codebase and updates existing revelant calls to .api referencing the Koha REST dataTables wrapper to use the name name 'kohaTable'. Test plan. 1) Ensure the tables on the following pages all continue to work as expected a) acqui/parcel b) admin/branches c) admin/cities d) admin/smtp_servers e) pos/register f) tools/quotes Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 19:06:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 18:06:03 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127274|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi --- Created attachment 127284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127284&action=edit Bug 29408: Begginings of JSDoc documentation I'd love to see the parameters clearly documented... I've started it off but need some help. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 19:06:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 18:06:34 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 19:08:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 18:08:25 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 --- Comment #7 from Tomás Cohen Arazi --- I did git grep '\.api(' and the cases I found are correct (i.e. JS accessing the .api() method from DataTables. All looks good and works as before this patchset. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 19:13:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 18:13:05 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #19 from Joonas Kylmälä --- Passing QA as all the patches have the required sign-offs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 19:16:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 18:16:06 +0000 Subject: [Koha-bugs] [Bug 28068] Cash register should not record writeoff as cash received In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28068 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 19:28:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 18:28:11 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 --- Comment #8 from Martin Renvoize --- Thanks for testing.. yup, those two calls to .api( that still exist are one of the reasons I was really keen to make this change :-). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 19:29:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 18:29:19 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 19:51:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 18:51:38 +0000 Subject: [Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127018|0 |1 is obsolete| | --- Comment #29 from David Gustafsson --- Created attachment 127285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127285&action=edit Bug 20262: Add ability to refund lost item fees without creating credits Some libraries handle refunding of paid lost fees at a financial office and not within Koha. To facilitate this, it would be good for Koha to have the option to not generate lost returned credits by skipping fully paid lost items, and only refunding the outstanding balance on partially paid lost fees. Test Plan: 1) Apply this patch 2) Set your lost item refund on return policies to 'Only if unpaid' 3) Mark an item lost, charging the lost fee 4) Return the item, a full refund should occur 5) Mark another item lost, charging the lost fee 6) Make a partial payment on this lost fee 7) Return the item 8) The remaining balance of that fee should be 0, but the patron should not recieve a credit for the already paid balance 8) Mark another item lost, charging the lost fee 9) Fully pay the lost fee 10) Return the item. The paid lost fee should be unaffected. 11) Run tests in t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 19:52:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 18:52:11 +0000 Subject: [Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #30 from David Gustafsson --- Now added tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 19:54:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 18:54:12 +0000 Subject: [Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127285|0 |1 is obsolete| | --- Comment #31 from David Gustafsson --- Created attachment 127286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127286&action=edit Bug 20262: Add ability to refund lost item fees without creating credits Some libraries handle refunding of paid lost fees at a financial office and not within Koha. To facilitate this, it would be good for Koha to have the option to not generate lost returned credits by skipping fully paid lost items, and only refunding the outstanding balance on partially paid lost fees. Test Plan: 1) Apply this patch 2) Set your lost item refund on return policies to 'Only if unpaid' 3) Mark an item lost, charging the lost fee 4) Return the item, a full refund should occur 5) Mark another item lost, charging the lost fee 6) Make a partial payment on this lost fee 7) Return the item 8) The remaining balance of that fee should be 0, but the patron should not recieve a credit for the already paid balance 8) Mark another item lost, charging the lost fee 9) Fully pay the lost fee 10) Return the item. The paid lost fee should be unaffected. 11) Run tests in t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 20:26:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 19:26:07 +0000 Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 --- Comment #19 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #18) > 1. This one seems wrong: > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt: > link = `request.pl?biblionumbers=[% biblionumbers | url > %]&action=cancelBulk&ids=${$('.holds_table > .select_hold:checked').toArray().map(el => $(el).data('id')).join(',')}`; > > I don't have the time to confirm now but could do later. it is wrong, have to re-do the patch, there was some changes pushed to master from Bug 23678 that are not compatible with this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 21:06:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 20:06:26 +0000 Subject: [Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #85 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart from comment #83) > "Just add routes" is not as trivial as it sounds. We could introduce > permission issues. Indeed! I just checked and the tests check unauthorized accesses cases. Is that enough to not worry about issues in case the way permissions work between master and 21.05 and 20.11 has changed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 21:47:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 20:47:39 +0000 Subject: [Koha-bugs] [Bug 26868] biblio and biblio_metadata tables timestamp do not update when moving an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26868 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 23:27:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 22:27:35 +0000 Subject: [Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 --- Comment #5 from David Cook --- (In reply to Joonas Kylmälä from comment #4) > (In reply to David Cook from comment #3) > > I can't even get auto-renewal digest messages to send... > > Not sure where you got stuck. To test you can check the Notices tab of the > patron via staff interface as well, no need to have have a working email > setup. Ah sorry. I wasn't referring to your patches. I meant that I can't get auto-renewal digest messages to send in production in Koha haha. I can't tell if Koha is broken or if I'm doing something wrong, but it sounds like you're able to send auto-renewal digest messages... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 23:27:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 22:27:35 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 --- Comment #30 from Katrin Fischer --- I've been bitten by Koha assuming years are after 1000 for the date range search in the past - might be nice to tackle separately. When dealing with rare items and manuscripts < 1000 is totally realistic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 3 23:29:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Nov 2021 22:29:59 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #19 from Katrin Fischer --- (In reply to Owen Leonard from comment #18) > Haha because I did it. Of course I would approve. I have no memory of this > patch! I didn't notice either when asking you to have look... what does that say about us? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 02:18:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 01:18:04 +0000 Subject: [Koha-bugs] [Bug 28526] Impossible to search only zero In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28526 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28365 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 02:18:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 01:18:04 +0000 Subject: [Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28526 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 02:42:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 01:42:54 +0000 Subject: [Koha-bugs] [Bug 28573] Replace authority record with Z39.50/SRU creates new authority record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Hayley Pelham changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleypelham at catalyst.net.n | |z, kyle.m.hall at gmail.com, | |nick at bywatersolutions.com --- Comment #16 from Hayley Pelham --- Hello, As this is a major bug and the button doesn't do as it says, could this please be backported to 21.05.x? Cheers, Hayley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 04:34:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 03:34:54 +0000 Subject: [Koha-bugs] [Bug 29410] New: Dates compared arithmetically in MsgType.pm (warns: Argument isn't numeric in numeric ne) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29410 Bug ID: 29410 Summary: Dates compared arithmetically in MsgType.pm (warns: Argument isn't numeric in numeric ne) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: nugged at gmail.com QA Contact: testopia at bugs.koha-community.org Regular warnings a-la: Argument "2021-11-04" isn't numeric in numeric ne (!=) at /usr/share/koha/lib/C4/SIP/Sip/MsgType.pm line 1265. emitted in C4::SIP::Sip::MsgType handle_item_information sub. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 04:35:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 03:35:14 +0000 Subject: [Koha-bugs] [Bug 29410] Dates compared arithmetically in MsgType.pm (warns: Argument isn't numeric in numeric ne) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29410 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 07:50:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 06:50:32 +0000 Subject: [Koha-bugs] [Bug 29411] New: Single result for checkout search by name should redirect to check out tab Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 Bug ID: 29411 Summary: Single result for checkout search by name should redirect to check out tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In bug 15812 the code was switched to redirect to members.pl if a single hit was not found by barcode. The members results page redirects to moremember if a single result is returned to the template. In the case of a 'circsearch' we should redirect to checkout, not member details -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 07:53:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 06:53:46 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 07:53:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 06:53:49 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 --- Comment #1 from Nick Clemens --- Created attachment 127287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127287&action=edit Bug 29411: Redirect to circulation if circsearch is true TO test: 1 - Have a patron with a unique surname i.e. Acosta 2 - Enter the surename into 'Search patrons' box on staff homepage 3 - You are redirected to 'members/moremember.pl' 4 - Enter the surname into 'Check out' box at top of page 5 - You are redirected to 'members/moremember.pl' 6 - Apply patch 7 - Enter the surename into 'Search patrons' box on staff homepage 8 - You are redirected to 'members/moremember.pl' 9 - Enter the surname into 'Check out' box at top of page 10 - You are redirected to 'circ/circulationr.pl' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 07:54:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 06:54:04 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15812 Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 07:54:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 06:54:04 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29411 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 [Bug 29411] Single result for checkout search by name should redirect to check out tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 08:03:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 07:03:03 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Fines and fees |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 08:03:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 07:03:49 +0000 Subject: [Koha-bugs] [Bug 29177] Remove TODO in acqui/finishreceive.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29177 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 08:06:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 07:06:42 +0000 Subject: [Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Provides a small release notes| |performance enhancement and | |allows prefetching and | |embedding to work in the | |API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 08:06:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 07:06:50 +0000 Subject: [Koha-bugs] [Bug 29084] Update article requests-related Koha::Biblio methods to use relationships In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29084 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Provides a small release notes| |performance enhancement and | |allows prefetching and | |embedding to work in the | |API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 08:07:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 07:07:36 +0000 Subject: [Koha-bugs] [Bug 29082] Add filtering methods to Koha::ArticleRequests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29082 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Add re-usable pre-filtered release notes| |searches to the Article | |Requests system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 08:07:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 07:07:56 +0000 Subject: [Koha-bugs] [Bug 28931] use EXPORT_OK in Koha::DateUtils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 08:11:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 07:11:18 +0000 Subject: [Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Text to go in the| |This enhancement adds a release notes| |info image to the carredart | |icon set for item types. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 08:12:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 07:12:11 +0000 Subject: [Koha-bugs] [Bug 27520] Adding new itemtype images boardgame, zoom-in, and zoom-out to carredart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Text to go in the| |This enhancement adds release notes| |boardgame, zoom-in and | |zoom-out images to the | |carredart icon set for item | |types. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 08:25:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 07:25:50 +0000 Subject: [Koha-bugs] [Bug 18631] `cleanup_database.pl` should take an option for modules in action_logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18631 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cleanup_database.pl should |`cleanup_database.pl` |take an option for modules |should take an option for |in action_logs |modules in action_logs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 08:28:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 07:28:22 +0000 Subject: [Koha-bugs] [Bug 18631] Cleanup_database.pl should take an option for modules in action_logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18631 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|`cleanup_database.pl` |Cleanup_database.pl should |should take an option for |take an option for modules |modules in action_logs |in action_logs Text to go in the| |This patch adds two new release notes| |optional parameters to the | |`cleanup_database.pl` | |script. | | | |`--log-modules` - | |A repeatable option to | |specify which action log | |module lines to truncate. | |`--preserve-log` - A | |repeatable option to | |specify which action log | |module lines to keep. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 08:28:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 07:28:33 +0000 Subject: [Koha-bugs] [Bug 18631] `cleanup_database.pl` should take an option for modules in action_logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18631 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cleanup_database.pl should |`cleanup_database.pl` |take an option for modules |should take an option for |in action_logs |modules in action_logs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 08:29:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 07:29:04 +0000 Subject: [Koha-bugs] [Bug 25429] `cleanup_database.pl` remove resolved claims returned from db after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Summary|Cleanup Database - remove |`cleanup_database.pl` |resolved claims returned |remove resolved claims |from db after X days |returned from db after X | |days -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 08:30:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 07:30:19 +0000 Subject: [Koha-bugs] [Bug 25429] `cleanup_database.pl` should remove resolved claims returned after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|`cleanup_database.pl` |`cleanup_database.pl` |remove resolved claims |should remove resolved |returned from db after X |claims returned after X |days |days -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 08:32:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 07:32:04 +0000 Subject: [Koha-bugs] [Bug 25429] `cleanup_database.pl` should remove resolved claims returned after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds the release notes| |new | |`CleanUpDatabaseReturnClaim | |s` system preference | |allowing administrators to | |specify how many days after | |resolution a claimed return | |record should be deleted | |from the database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 08:34:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 07:34:06 +0000 Subject: [Koha-bugs] [Bug 28068] Cash register should not record writeoff as cash received In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28068 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24786 --- Comment #2 from Nick Clemens --- Fixed in master by 24786 Before that bug, we had: 80 my $cash_register_id; 81 if ( C4::Context->preference('UseCashRegisters') ) { 82 $cash_register_id = $input->param('cash_register'); ... 93 if ( !$cash_register_id ) { 94 my $default_register = Koha::Cash::Registers->find( 95 { branch => $library_id, branch_default => 1 } ); 96 $cash_register_id = $default_register->id if $default_register; 97 } 98 $cash_register_id = $registers->next->id if !$cash_register_id; Which would set the cash register even for a write-off After that patch we get the value from the template - and don't set it for WRITEOFF -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 08:34:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 07:34:06 +0000 Subject: [Koha-bugs] [Bug 24786] Allow setting a cash register for a login session and configuring library-default cash registers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28068 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 08:35:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 07:35:11 +0000 Subject: [Koha-bugs] [Bug 25429] `cleanup_database.pl` should remove resolved claims returned after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds the |This enhancement adds the release notes|new |new |`CleanUpDatabaseReturnClaim |`CleanUpDatabaseReturnClaim |s` system preference |s` system preference |allowing administrators to |allowing administrators to |specify how many days after |specify how many days after |resolution a claimed return |resolution a claimed return |record should be deleted |record should be deleted |from the database. |from the database. | | | |For | |this functionality to be | |enabled, the | |`cleanup_database.pl` must | |be scheduled to run | |regularly with the new | |`--returns_claims` | |parameter passed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 08:36:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 07:36:53 +0000 Subject: [Koha-bugs] [Bug 28456] Add option to use a WHERE statement in membership_expiry.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Text to go in the| |Add an optional `--where` release notes| |parameter to the | |`membership_expiry.pl` | |task. This allows for | |arbitrarily complex SQL | |where statements to be | |passed to the script to | |filter affected patrons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 08:42:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 07:42:19 +0000 Subject: [Koha-bugs] [Bug 25883] Highlight transfers on checkin screen table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25883 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show transfer on checkin |Highlight transfers on |screen |checkin screen table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 08:45:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 07:45:27 +0000 Subject: [Koha-bugs] [Bug 25883] Highlight transfers on checkin screen table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25883 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch replaces the release notes| |`Holding library` field in | |the check-in table with a | |new `Transfer to` field. | | | |The `Holding library` would | |always match the current | |branch, as holding branch | |is updated by the check-in | |process. We now highlight | |transfers by populating the | |new `Transfer to` field | |with the destination | |library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 08:46:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 07:46:04 +0000 Subject: [Koha-bugs] [Bug 29386] background jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate Severity|normal |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 08:46:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 07:46:31 +0000 Subject: [Koha-bugs] [Bug 29386] background jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 08:48:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 07:48:55 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds a new release notes| |field, `Public` to the | |definable library | |information. When enabled, | |the library details will be | |displayed in the libraries | |page on the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 08:49:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 07:49:18 +0000 Subject: [Koha-bugs] [Bug 25883] Highlight transfers on checkin screen table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25883 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 08:49:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 07:49:25 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 09:06:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 08:06:17 +0000 Subject: [Koha-bugs] [Bug 29386] background jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize --- I think I'd go for LONGTEXT straight away personally.. in the grand scheme, disk space isn't usually the limiting factor these days.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 09:08:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 08:08:03 +0000 Subject: [Koha-bugs] [Bug 29386] background jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 --- Comment #8 from Martin Renvoize --- (In reply to Martin Renvoize from comment #7) > I think I'd go for LONGTEXT straight away personally.. in the grand scheme, > disk space isn't usually the limiting factor these days.. Lets justify that slightly.. my thoughts are there aren't going to be lots of reports against this data and the queries we're using on this table are specific enough and not on that particular field such that it shouldn't have any other knock on performance issues... where it would count is if we did another utf8-mb4 type upgrade down the line.. that would be a slow process for such a large field if there were lots of rows in it.. but that's all reasonably easy to resolve. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 09:22:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 08:22:21 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #30 from Christian Stelzenmüller --- I don't know if it's the mentioned bug, but im getting an error on step 5 from the test plan. Error trace Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_acqui_addorder_2epl::dt_from_string called at /kohadevbox/koha/acqui/addorder.pl line 318 in (eval) at /kohadevbox/koha/acqui/addorder.pl line 318 315: } 316: ); 317: 318: $orderinfo->{estimated_delivery_date} = $orderinfo->{estimated_delivery_date} ? dt_from_string($orderinfo->{estimated_delivery_date}) : undef; 319: 320: # if we already have $ordernumber, then it's an ordermodif 321: my $order = Koha::Acquisition::Order->new($orderinfo); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 09:34:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 08:34:20 +0000 Subject: [Koha-bugs] [Bug 29412] New: Fix uncertain years before 1000 AD in copyrightdate Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29412 Bug ID: 29412 Summary: Fix uncertain years before 1000 AD in copyrightdate Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org See bug 24674. Things like 2xx still dont work as expected. We should find a way to deal with interpretation of e.g. 17x: 170 of 1700? Etc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 09:34:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 08:34:56 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 --- Comment #31 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #30) > I've been bitten by Koha assuming years are after 1000 for the date range > search in the past - might be nice to tackle separately. When dealing with > rare items and manuscripts < 1000 is totally realistic. I'm willing to work on it. See bug 29412. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 09:35:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 08:35:29 +0000 Subject: [Koha-bugs] [Bug 29412] Fix uncertain years before 1000 AD in copyrightdate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29412 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 09:35:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 08:35:38 +0000 Subject: [Koha-bugs] [Bug 29412] Fix uncertain years before 1000 AD in copyrightdate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29412 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 09:36:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 08:36:06 +0000 Subject: [Koha-bugs] [Bug 29412] Fix uncertain years before 1000 AD in copyrightdate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29412 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24674 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 09:36:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 08:36:06 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29412 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29412 [Bug 29412] Fix uncertain years before 1000 AD in copyrightdate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 10:14:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 09:14:55 +0000 Subject: [Koha-bugs] [Bug 29413] New: CataloguingLog doesn't allow to see changes for first edit of an item Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29413 Bug ID: 29413 Summary: CataloguingLog doesn't allow to see changes for first edit of an item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When a new item is added the logs only show "item" in info. When an item is edited, the complete contents of the fields will be logged with the new values. Because we are missing the "original" values, there is no way to tell what has been changed between both log entries. The logging mechanism should be changed to log the full item on adding as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 10:45:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 09:45:16 +0000 Subject: [Koha-bugs] [Bug 29386] background jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 10:45:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 09:45:20 +0000 Subject: [Koha-bugs] [Bug 29386] background jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 --- Comment #9 from Jonathan Druart --- Created attachment 127288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127288&action=edit Bug 29386: Extend background_jobs.data to LONGTEXT TEXT is too small, we must extend it to allow bigger jobs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 11:19:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 10:19:56 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125692|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 127289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127289&action=edit Bug 28700: Get from storage before log actions To make sure we have logging the values from DB. It will reduce DB action_log table size when we log the full object and it contains DateTime object. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 11:24:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 10:24:24 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #18 from Jonathan Druart --- This patch is more or less the same as Petro, but 1. it calls get_from_storage and 2. deals with any Koha::Object we will pass. There is much more to do for logging correctly, this patch is only impacting calls where Dumper($object->unblessed) were passed to logaction. We certainly need to improve the whole thing and pass an object from everywhere, deal with logic in logaction (depending on the objects we have), log a pre/post stringified versions of the object in 2 different columns (to allow a nice diff from the UI), and finally stringify using JSON (that is currently done only for acquisition logs and patron modification, which is quite inconsistent). This is definitely for a separate bug report, but I think we should focus on it (as a team) for 22.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 11:24:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 10:24:51 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority |rel_21_11_candidate Assignee|stalkernoid at gmail.com |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 11:26:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 10:26:29 +0000 Subject: [Koha-bugs] [Bug 28700] "Unblessed" method in Object.pm has blessed values for keys in some cases In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | --- Comment #44 from Jonathan Druart --- Regarding the move on bug 28692 and the recent discussions we had, I think we should drop those patches and mark the bug report as invalid. We should use JSON::to_json for logging objects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 11:26:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 10:26:31 +0000 Subject: [Koha-bugs] [Bug 29414] New: Add "last changed" to sort options in the staff interface (MARC21 005) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29414 Bug ID: 29414 Summary: Add "last changed" to sort options in the staff interface (MARC21 005) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Sometimes it would be nice for catalogers to be able to easily check which records were changed last in a search. MARC21 005 contains a standardized timestamp that should sort well alphabetically and would make a great addition to the sorting options in staff. https://www.loc.gov/marc/bibliographic/bd005.html 005 19940223151047.0 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 11:26:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 10:26:51 +0000 Subject: [Koha-bugs] [Bug 29192] DefaultHoldExpirationDate sends a DateTime object to logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29192 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #8 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 28700 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 11:26:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 10:26:51 +0000 Subject: [Koha-bugs] [Bug 28700] "Unblessed" method in Object.pm has blessed values for keys in some cases In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700 --- Comment #45 from Jonathan Druart --- *** Bug 29192 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 11:28:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 10:28:40 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression, | |rel_21_11_candidate CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 11:31:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 10:31:17 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 --- Comment #2 from Owen Leonard --- I see one issue with this: If you open the Patrons page and use the sidebar form to search, a single result redirects to circulation instead of details. I don't think this would make my staff complain at all but I think it's not what is technically expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 11:31:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 10:31:24 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 11:37:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 10:37:53 +0000 Subject: [Koha-bugs] [Bug 22671] Built-in offline circulation applicationCache errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22671 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 11:38:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 10:38:51 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 11:46:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 10:46:30 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 11:46:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 10:46:33 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127282|0 |1 is obsolete| | Attachment #127283|0 |1 is obsolete| | Attachment #127284|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 127290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127290&action=edit Bug 29408: Rename Koha dataTables wrapper This patch renames the Koha REST JS dataTables wrapper from the ambigious 'api' to the clearer 'kohaTable'. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 11:46:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 10:46:49 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 --- Comment #10 from Kyle M Hall --- Created attachment 127291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127291&action=edit Bug 29408: Update all existing uses of .api to .kohaTable This patch goes through the codebase and updates existing revelant calls to .api referencing the Koha REST dataTables wrapper to use the name name 'kohaTable'. Test plan. 1) Ensure the tables on the following pages all continue to work as expected a) acqui/parcel b) admin/branches c) admin/cities d) admin/smtp_servers e) pos/register f) tools/quotes Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 11:46:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 10:46:52 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 --- Comment #11 from Kyle M Hall --- Created attachment 127292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127292&action=edit Bug 29408: Beginnings of JSDoc documentation I'd love to see the parameters clearly documented... I've started it off but need some help. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 11:47:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 10:47:36 +0000 Subject: [Koha-bugs] [Bug 25387] Avoid merge different type of authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25387 --- Comment #9 from Katrin Fischer --- Could it be an option to only allow merging when the 'losing' record is unused? In this case there would be no data loss and a warning would not be necessary. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:00:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:00:29 +0000 Subject: [Koha-bugs] [Bug 25387] Avoid merge different type of authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25387 --- Comment #10 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #9) > Could it be an option to only allow merging when the 'losing' record is > unused? In this case there would be no data loss and a warning would not be > necessary. I dont think so. Manual relinking wont be fun. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:17:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:17:16 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:17:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:17:19 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127287|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 127293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127293&action=edit Bug 29411: Redirect to circulation if circsearch is true TO test: 1 - Have a patron with a unique surname i.e. Acosta 2 - Enter the surename into 'Search patrons' box on staff homepage 3 - You are redirected to 'members/moremember.pl' 4 - Enter the surname into 'Check out' box at top of page 5 - You are redirected to 'members/moremember.pl' 6 - Apply patch 7 - Enter the surename into 'Search patrons' box on staff homepage 8 - You are redirected to 'members/moremember.pl' 9 - Enter the surname into 'Check out' box at top of page 10 - You are redirected to 'circ/circulationr.pl' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:21:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:21:50 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:21:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:21:54 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127293|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 127294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127294&action=edit Bug 29411: Redirect to circulation if circsearch is true TO test: 1 - Have a patron with a unique surname i.e. Acosta 2 - Enter the surename into 'Search patrons' box on staff homepage 3 - You are redirected to 'members/moremember.pl' 4 - Enter the surname into 'Check out' box at top of page 5 - You are redirected to 'members/moremember.pl' 6 - Apply patch 7 - Enter the surename into 'Search patrons' box on staff homepage 8 - You are redirected to 'members/moremember.pl' 9 - Enter the surname into 'Check out' box at top of page 10 - You are redirected to 'circ/circulation.pl' Signed-off-by: Owen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:44:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:44:33 +0000 Subject: [Koha-bugs] [Bug 29168] Only show "Request article" if allowed on the detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168 --- Comment #15 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #14) > This is getting complicated. I think it should be simplified. > > Isn't the following correct/enough? > > if ( $patron && $patron->can_request_article ) { > $artreqpossible = $biblio->can_article_request( $patron ); > } elsif ( $itemtype ) { > $artreqpossible = $itemtype->may_article_request > } It looks similar to me, a bit shorter. Do you want me to resubmit the patch in this form? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:49:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:49:50 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 --- Comment #12 from Jonathan Druart --- We already have "KohaTable", isn't this more ambiguous? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:51:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:51:17 +0000 Subject: [Koha-bugs] [Bug 29168] Only show "Request article" if allowed on the detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168 --- Comment #16 from Jonathan Druart --- Shorter and less unnecessary calls in some cases. Yes please resubmit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:55:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:55:09 +0000 Subject: [Koha-bugs] [Bug 28926] Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:55:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:55:11 +0000 Subject: [Koha-bugs] [Bug 28904] Update information on Newsletter editor on about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28904 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:55:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:55:13 +0000 Subject: [Koha-bugs] [Bug 28236] Selecting database columns for system preferences in standard and dev installs is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:55:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:55:19 +0000 Subject: [Koha-bugs] [Bug 29380] Auto renewing, batch due date extension tool and checkout note previews are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29380 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:55:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:55:29 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125547|0 |1 is obsolete| | Attachment #125548|0 |1 is obsolete| | Attachment #125549|0 |1 is obsolete| | Attachment #125550|0 |1 is obsolete| | Attachment #125551|0 |1 is obsolete| | Attachment #125552|0 |1 is obsolete| | Attachment #125553|0 |1 is obsolete| | Attachment #125554|0 |1 is obsolete| | Attachment #125555|0 |1 is obsolete| | Attachment #125556|0 |1 is obsolete| | Attachment #125557|0 |1 is obsolete| | Attachment #125558|0 |1 is obsolete| | Attachment #125559|0 |1 is obsolete| | Attachment #125560|0 |1 is obsolete| | Attachment #125561|0 |1 is obsolete| | Attachment #125562|0 |1 is obsolete| | Attachment #125563|0 |1 is obsolete| | Attachment #125564|0 |1 is obsolete| | --- Comment #63 from Owen Leonard --- Created attachment 127295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127295&action=edit Bug 27631: Changed

    around logo to
    To test: 1) Look at Staff Client and the logo 2) Apply patch 3) Check Koha logo moves to the middle of the page when zooming in 4) Ensure page source shows logo inside
    and not

    Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:55:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:55:34 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #64 from Owen Leonard --- Created attachment 127296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127296&action=edit Bug 27631: circ folder Changed each of the pages in the circ folder to have one

    tag showing that describes the page, rather than the

    describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the circ folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is

    Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:55:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:55:38 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #65 from Owen Leonard --- Created attachment 127297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127297&action=edit Bug 27631: labels and members folders Changed each of the pages in the labels and members folders to have one

    tag showing that describes the page, rather than the

    describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the labels and members folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is

    Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:55:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:55:43 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #66 from Owen Leonard --- Created attachment 127298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127298&action=edit Bug 27631: authorities, clubs, common, course_reserves folders Changed each of the pages in the authorities, clubs, common, course_reserves folders to have one

    tag showing that describes the page, rather than the

    describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the authorities, clubs, common, course_reserves folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is

    Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:55:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:55:47 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #67 from Owen Leonard --- Created attachment 127299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127299&action=edit Bug 27631: installer and onboarding folders Changed each of the pages in the installer and onboarding folders to have one

    tag showing that describes the page, rather than the

    describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Ensure that the page source shows logo inside
    and not inside

    4) Go to each of the pages in the installer and onboarding folders and check that they have an obvious and descriptive heading 5) Ensure that the heading in the page is

    Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:55:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:55:53 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #68 from Owen Leonard --- Created attachment 127300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127300&action=edit Bug 27631: offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders Changed each of the pages in the offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders to have one

    tag showing that describes the page, rather than the

    describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is

    Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:55:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:55:57 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #69 from Owen Leonard --- Created attachment 127301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127301&action=edit Bug 27631: catalogue and tags folders Changed each of the pages in the catalogue and tags folders to have one

    tag showing that describes the page, rather than the

    describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the catalogue and tags folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is

    Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:56:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:56:01 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #70 from Owen Leonard --- Created attachment 127302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127302&action=edit Bug 27631: tools and virtualshelves folders Changed each of the pages in the tools and virtualshelves folders to have one

    tag showing that describes the page, rather than the

    describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the tools and virtualshelves folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is

    Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:56:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:56:05 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #71 from Owen Leonard --- Created attachment 127303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127303&action=edit Bug 27631: reports and serials folders Changed each of the pages in the reports and serials folders to have one

    tag showing that describes the page, rather than the

    describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the reports and serials folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is

    Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:56:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:56:10 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #72 from Owen Leonard --- Created attachment 127304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127304&action=edit Bug 27631: cataloguing folder Changed each of the pages in the cataloguing folder to have one

    tag showing that describes the page, rather than the

    describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the cataloguing folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is

    Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:56:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:56:15 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #73 from Owen Leonard --- Created attachment 127305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127305&action=edit Bug 27631: acqui folder Changed each of the pages in the acqui folder to have one

    tag showing that describes the page, rather than the

    describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the acqui folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is

    Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:56:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:56:20 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #74 from Owen Leonard --- Created attachment 127306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127306&action=edit Bug 27631: Hidden

    on intranet-main.tt This patch visually hides a

    on intranet-main.tt so that the heading is available to be read out by screenreaders in the summary of headings on the page. Test plan: 1) Ensure the

    "Koha home" heading on the staff client main/home page is hidden visually, but in the source code you can see it Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:56:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:56:24 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #75 from Owen Leonard --- Created attachment 127307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127307&action=edit Bug 27631: admin folder Changed each of the pages in the admin folder to have one

    tag showing that describes the page, rather than the

    describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the admin folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is

    Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:56:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:56:28 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #76 from Owen Leonard --- Created attachment 127308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127308&action=edit Bug 27631: (follow-up) course_reserves/course-details.tt Changed file to have one

    tag showing that describes the page, rather than the

    around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to course_reserves/course-details and check that it has an obvious and descriptive heading 4) Ensure that the heading is

    Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:56:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:56:32 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #77 from Owen Leonard --- Created attachment 127309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127309&action=edit Bug 27631: (follow-up) tools/marc_modification_templates.tt Changed file to have one

    tag showing that describes the page, rather than the

    around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to tools/marc_modification_templates and check that it has an obvious and descriptive heading 4) Ensure that the heading is

    Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:56:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:56:36 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #78 from Owen Leonard --- Created attachment 127310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127310&action=edit Bug 27631: (follow-up) reports/guided_reports_start.tt Changed file to have one

    tag showing that describes the page, rather than the

    around the logo. The hierarchy of other heading tags may be wrong, but this wil be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to reports/guided_reports_start and check that it has an obvious and descriptive heading 4) Ensure that the heading is

    Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:56:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:56:40 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #79 from Owen Leonard --- Created attachment 127311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127311&action=edit Bug 27631: (follow-up) circ/branchtransfers.tt Changed file to have one

    tag showing that describes the page, rather than the

    around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to circ/branchtransfers and check that it has an obvious and descriptive heading 4) Ensure that the heading is

    Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:56:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:56:45 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #80 from Owen Leonard --- Created attachment 127312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127312&action=edit Bug 27631: (follow-up) Some minor corrections This patch makes some corrections to issues found during testing: Some duplicate headings, a markup error in labeledMARCdetail.tt, a change of the transfers heading from "Branch transfers" to "Item transfers." This patch also undoes the changes to the position of the toolbar on several pages. I think those changes don't belong in this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:57:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:57:48 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #81 from Owen Leonard --- Rebased. Only the last patch needs signoff! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:59:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:59:11 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #13 from Martin Renvoize --- (In reply to Jonathan Druart from comment #12) > We already have "KohaTable", isn't this more ambiguous? I think the difference between `KohaTable('selector', settings)` and `$('selector').kohaTable(settings)` is clearer than the current `$('selector').api(settings)`.. what is `.api()`.. the jQuery API, the selected elements api.. it also doesn't help that datatables itself has an api() method to get back the datatables api object. I think we should slowly be migrating from template-driven datatables (KohaTable) to api driven datatable (kohaTable).. so to me, the similarity is deliberate and the distinction is clear. Also, by starting to add JSDoc, my hope is people will reach for kohaTable first in the future ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 12:59:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 11:59:55 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 --- Comment #14 from Martin Renvoize --- I do have a couple of improvements to make on that last patch though.. I clarified a few things with Tomas this morning, but Kyle was super quick to review what was already there before I got to update it ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:03:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:03:25 +0000 Subject: [Koha-bugs] [Bug 28694] Check alert in cataloguing should be a static message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:03:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:03:42 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | --- Comment #13 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #7) > Sorry, now I am confused. Can you describe what features are affected by the > problem and thus broken? Sending attachments works, the cart, the list, etc. It all was tested, and works. And Email::Stuffer can handle attachments correctly. The problem is messages that go to the message queue, with attachments, and how the email is rebuilt to be sent. Can anyone provide 'steps to reproduce' the problem? thanks. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:04:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:04:32 +0000 Subject: [Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:04:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:04:35 +0000 Subject: [Koha-bugs] [Bug 18631] `cleanup_database.pl` should take an option for modules in action_logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18631 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:04:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:04:39 +0000 Subject: [Koha-bugs] [Bug 25464] Add ability to specify client IP and SIP account used in SIP2 logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25464 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:04:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:04:49 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:05:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:05:33 +0000 Subject: [Koha-bugs] [Bug 26852] Add missing X11$e and remove relator term subfields from MARC21 headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:05:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:05:37 +0000 Subject: [Koha-bugs] [Bug 28242] Accessibility: OPAC - add captions and legends to tables and forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:06:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:06:37 +0000 Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This feature adds a way to release notes| |define a list of possible | |cancellation reasons for | |article requests. That way, | |they can be chosen upon | |cancellation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:06:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:06:45 +0000 Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:08:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:08:42 +0000 Subject: [Koha-bugs] [Bug 27949] Batch printing of article request slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This developments adds a release notes| |way to select several | |article requests and print | |slips for them in batch. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:10:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:10:24 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127290|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 127313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127313&action=edit Bug 29408: Rename Koha dataTables wrapper This patch renames the Koha REST JS dataTables wrapper from the ambigious 'api' to the clearer 'kohaTable'. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:10:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:10:29 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127291|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize --- Created attachment 127314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127314&action=edit Bug 29408: Update all existing uses of .api to .kohaTable This patch goes through the codebase and updates existing revelant calls to .api referencing the Koha REST dataTables wrapper to use the name name 'kohaTable'. Test plan. 1) Ensure the tables on the following pages all continue to work as expected a) acqui/parcel b) admin/branches c) admin/cities d) admin/smtp_servers e) pos/register f) tools/quotes Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:10:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:10:33 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 --- Comment #17 from Martin Renvoize --- Created attachment 127315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127315&action=edit Bug 29408: Add JSDoc documentation for kohaTable function This patch adds some JSDoc formatted parameter documentation for the kohaTable function. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:10:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:10:50 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127292|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:10:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:10:56 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:11:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:11:20 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 --- Comment #18 from Martin Renvoize --- Amendments to documentation made, with agreements from Tomas.. back to PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:21:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:21:01 +0000 Subject: [Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:21:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:21:05 +0000 Subject: [Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127278|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 127316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127316&action=edit Bug 29407: Make the pickup locations dropdown JS reusable This patch generates a function to be used in places where select2 dropdowns are usesd for choosing pickup locations. This cleans repeated/almost identical code introduced by different bugs. To test: 1. Make sure choosing pickup locations works 2. Apply this patch 3. Repeat 1 => SUCCESS: No functional changes 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:21:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:21:34 +0000 Subject: [Koha-bugs] [Bug 29404] Add infinite scrolling to pickup location dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:21:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:21:38 +0000 Subject: [Koha-bugs] [Bug 29404] Add infinite scrolling to pickup location dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127262|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 127317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127317&action=edit Bug 29404: Add infinite scrolling to pickup location dropdowns This patch adds infinite scrolling to the pickup locations select2 dropdowns on the staff interface. It does so by adding a new transport function (in select2.js) to read the response headers Koha's API sends back, and converting to the right data structure Select2 expects for the feature to work. This is manually used in the different pickup locations dropdowns. There's a separate bug that will introduce a select2 wrapper that will probably embed this function in it. To test: 1. Run the [DO NOT PUSH] script inside koha-shell to generate random pickup locations: $ kshell k$ perl generate_pickup_locations.pl 2. Try placing holds. Notice the visible pickup locations dropdowns display some pickup locations based on the matches you got. They are all fetched once => SUCCESS: It works 3. Repeat for the current holds page and the patron holds listing => SUCCESS: Same behavior 4. Apply this patch 5. Repeat 2 and 3 => SUCCESS: Things work, but pickup locations are retrieved as needed, while you scroll. 6. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:39:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:39:39 +0000 Subject: [Koha-bugs] [Bug 27985] Add option for using a MARC modification template on a single record from the details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27985 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This development allows for release notes| |sending a single record to | |'batch' modification in | |order to process a MARC | |modification template | |against the record. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:41:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:41:29 +0000 Subject: [Koha-bugs] [Bug 28153] Add 'Hold reminder' messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28153 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This enhancement allows release notes| |staff/patrons to control | |individual preferences for | |holds reminder noticess in | |the patron's messaging | |preferences area. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:45:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:45:59 +0000 Subject: [Koha-bugs] [Bug 28211] Replace use of call_recursive() with call() In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28211 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement changes release notes| |the way plugin hooks are | |called to transform data. | |We now pass object to be | |modified as a reference, | |thus allowing several | |plugins to operate | |cumulatively on the same | |object. Keywords|release-notes-needed | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:49:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:49:19 +0000 Subject: [Koha-bugs] [Bug 28474] Pass process_message_queue.pl params to before_send_messages plugin hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28474 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement passes the release notes| |parameters received by | |process_message_queue.pl | |through to the | |before_send_messages plugin | |calls. This allows plugins | |to respect calls that | |should only affect certain | |letter codes etc. Keywords|release-notes-needed | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 13:54:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 12:54:40 +0000 Subject: [Koha-bugs] [Bug 24147] Objects.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24147 --- Comment #21 from Jonathan Druart --- Koha_Master_D11_My8/686 Docker_2 13:24:48 koha_1 | # Failed test 'Koha::Objects->search_related should work as expected' 13:24:48 koha_1 | # at t/db_dependent/Koha/Objects.t line 163. 13:24:48 koha_1 | 13:24:48 koha_1 | # Failed test 'Koha::Objects->search_related should work as expected' 13:24:48 koha_1 | # at t/db_dependent/Koha/Objects.t line 183. 13:24:48 koha_1 | # Looks like you failed 2 tests of 6. 13:24:48 koha_1 | 13:24:48 koha_1 | # Failed test 'search_related' 13:24:48 koha_1 | # at t/db_dependent/Koha/Objects.t line 186. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:18:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:18:25 +0000 Subject: [Koha-bugs] [Bug 29413] CataloguingLog doesn't allow to see changes for first edit of an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29413 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28692 CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- See also bug 28692 comment 18. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:18:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:18:25 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29413 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:31:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:31:36 +0000 Subject: [Koha-bugs] [Bug 29259] Url contains slash '/' instead of encoded slash '%2F' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29259 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 28782 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:31:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:31:36 +0000 Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andriiverem at gmail.com --- Comment #20 from Jonathan Druart --- *** Bug 29259 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:39:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:39:49 +0000 Subject: [Koha-bugs] [Bug 29311] Do not allow editing of bibliographic information when entering suggestion from existing bibs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 [Bug 14963] Add the ability to suggest purchase from existing titles -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:39:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:39:49 +0000 Subject: [Koha-bugs] [Bug 14963] Add the ability to suggest purchase from existing titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29311 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 [Bug 29311] Do not allow editing of bibliographic information when entering suggestion from existing bibs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:40:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:40:42 +0000 Subject: [Koha-bugs] [Bug 29415] New: Wrong number of received items/quantity shown in several places Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29415 Bug ID: 29415 Summary: Wrong number of received items/quantity shown in several places Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org For standing orders there is something not correct with the way the number of items received is calculated. A Order 1) Create a basket as standing order 2) Create an order for any record in your catalog 3) Verify quantity is 1 (always for standing orders) B Receive 1) Receive shipment for your order 2) Make sure to change quantity received to something higher than 1 3) Finish receiving C Verify display 1) Search for your invoice on the invoices page 2) Verify it shows quantity received as entered 3) Got to invoice details page /cgi-bin/koha/acqui/invoice.pl?invoiceid=1 4) Verify it still shows 1 as quantity - should show the received quantity 5) Click on the record's title to go to the detail page 6) Switch to acquistion detail tab 7) Verify it shows 1 too - should differentiate between ordered/received I think the first (invoice) is clearly a bug, the second might be seen as a display error, but we should specify which quantity is shown and possibly add a display for ordered / received. If the status is received the info on the acq tab is definitely misleading. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:41:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:41:57 +0000 Subject: [Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:42:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:42:06 +0000 Subject: [Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 --- Comment #5 from Jonathan Druart --- Created attachment 127318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127318&action=edit Bug 29180: Rename syspref RequestOnOpac with OPACHoldRequests It is a confusing name because we have 'Article Request' as a feature, and this does not follow Koha terminology. Test plan: `updatedatabase` and confirm that the syspref has been renamed `git grep RequestOnOpac` => No occurrence in the code QA: The syspref's value is always retrieved using Koha.Preference from .tt files, we don't need to send it from controllers or C4::Auth -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:42:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:42:24 +0000 Subject: [Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:43:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:43:04 +0000 Subject: [Koha-bugs] [Bug 29195] Highlighting broken on odd rows in circ-patron-search-results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29195 --- Comment #3 from Jonathan Druart --- Do we go with the '!important'? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:44:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:44:09 +0000 Subject: [Koha-bugs] [Bug 29123] Add Dataly Tech to About page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29123 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:45:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:45:08 +0000 Subject: [Koha-bugs] [Bug 29416] New: Regression: information from existing bib no longer populating on suggest for purchase Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 Bug ID: 29416 Summary: Regression: information from existing bib no longer populating on suggest for purchase Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Depends on: 14963 Blocks: 29311 When suggesting an existing title for purchase, we should copy bib information from the record into the suggestion. This used to happen, but has broken in master and 21.05 (I think 21.05.04 and later). Maybe due to bug 28941? That's a shot in the dark, but is the last update to opac-suggestions.pl. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 [Bug 14963] Add the ability to suggest purchase from existing titles https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 [Bug 29311] Do not allow editing of bibliographic information when entering suggestion from existing bibs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:45:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:45:08 +0000 Subject: [Koha-bugs] [Bug 14963] Add the ability to suggest purchase from existing titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29416 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:45:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:45:08 +0000 Subject: [Koha-bugs] [Bug 29311] Do not allow editing of bibliographic information when entering suggestion from existing bibs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29416 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:45:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:45:22 +0000 Subject: [Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127316|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 127319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127319&action=edit Bug 29407: Make the pickup locations dropdown JS reusable This patch generates a function to be used in places where select2 dropdowns are usesd for choosing pickup locations. This cleans repeated/almost identical code introduced by different bugs. To test: 1. Make sure choosing pickup locations works 2. Apply this patch 3. Repeat 1 => SUCCESS: No functional changes 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:45:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:45:57 +0000 Subject: [Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize --- Nice bit of code cleanup and DRYing out. No regressions found, QA script is happy, and code is clear. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:46:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:46:25 +0000 Subject: [Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 --- Comment #1 from Jonathan Druart --- If anybody is interested in this, please have a look at bug 15812 comment 37. IMO we shouldn't follow what has been done on bug 15812. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:47:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:47:54 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 --- Comment #5 from Martin Renvoize --- Thanks for the documentation follow-up Tomas :).. nice to see the pickup_locations code show this in use too :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:47:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:47:59 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #19 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #18) > Still nice to have in 21.11 ? I would prefer to not rush it and wait for 22.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:49:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:49:05 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127279|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 127320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127320&action=edit Bug 29397: Add .kohaSelect select2 wrapper function This patch adds a kohaSelect wrapper function to simplify paging/infinite scrolling with select2 using the Koha RESTful api's. Invoke select2 select boxes as you normally would from JS, but instead of calling .select2(config) use .kohaSelect(config). If an 'ajax' property is defined in your config object, we wrap the transport such that responses include a pagination key as expected by select2. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:49:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:49:08 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127280|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 127321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127321&action=edit Bug 29397: Add function documentation Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:49:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:49:12 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127281|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 127322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127322&action=edit Bug 29397: Use kohaSelect for pickup locations This patch makes the pickup location dropdowns that rely on Select2 and the API use the new wrapper. The original transport function is removed as it is now embedded in the wrapper. To test: 1. Follow bug 29404 test plan => SUCCESS: All works 2. Apply this patches 3. Repeat 1 => SUCCESS: All works! 4. sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:49:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:49:31 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 --- Comment #9 from Martin Renvoize --- Tested and signed off on the follow-up :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:49:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:49:55 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:51:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:51:30 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127294|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 127323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127323&action=edit Bug 29411: Redirect to circulation if circsearch is true TO test: 1 - Have a patron with a unique surname i.e. Acosta 2 - Enter the surename into 'Search patrons' box on staff homepage 3 - You are redirected to 'members/moremember.pl' 4 - Enter the surname into 'Check out' box at top of page 5 - You are redirected to 'members/moremember.pl' 6 - Apply patch 7 - Enter the surename into 'Search patrons' box on staff homepage 8 - You are redirected to 'members/moremember.pl' 9 - Enter the surname into 'Check out' box at top of page 10 - You are redirected to 'circ/circulation.pl' Signed-off-by: Owen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:51:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:51:49 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize --- All works as expected, nice fix. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 14:59:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 13:59:53 +0000 Subject: [Koha-bugs] [Bug 20172] Add a search bar in list tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20172 Sarah Cornell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell at cityofportsmouth. | |com --- Comment #5 from Sarah Cornell --- Agreed! Especially considering the work being done on bugs 26446 and 19501 to make the lists module a robust staff tool. Staff will want to be able to search within the lists. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 15:01:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 14:01:45 +0000 Subject: [Koha-bugs] [Bug 19501] New list category to restrict specific lists to staff & hide from OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Sarah Cornell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell at cityofportsmouth. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 15:02:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 14:02:37 +0000 Subject: [Koha-bugs] [Bug 11889] Disown a list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Sarah Cornell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell at cityofportsmouth. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 15:04:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 14:04:27 +0000 Subject: [Koha-bugs] [Bug 28795] ability to add metadata to lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28795 Sarah Cornell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell at cityofportsmouth. | |com --- Comment #1 from Sarah Cornell --- Agreed! We have public lists that we would like to describe for users, indicating when they are updated or their association with a program, etc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 15:07:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 14:07:04 +0000 Subject: [Koha-bugs] [Bug 25498] Cannot change owner of list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Sarah Cornell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell at cityofportsmouth. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 15:12:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 14:12:35 +0000 Subject: [Koha-bugs] [Bug 27647] Allowing Lists to have a Hierarchical Structure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27647 Sarah Cornell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell at cityofportsmouth. | |com --- Comment #1 from Sarah Cornell --- We are also interested in being able to organize lists hierarchically as well, at a public library. At our main branch we have adult, teen, and youth lists, and each of our 5 schools also makes lists. Currently they are in one LONG LIST. And the pull-down menus are a nightmare when trying to find a particular one. I envision something like the reports module, where we can assign a group and a subgroup, maybe even metadata/notes suggested in bug 28795. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 15:16:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 14:16:58 +0000 Subject: [Koha-bugs] [Bug 29417] New: Automatically update 77x fields when records are merged Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29417 Bug ID: 29417 Summary: Automatically update 77x fields when records are merged Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When 2 records are merged that are linked to analytical records using 773 (or potentially other 7xx) fields, it would be great, if Koha could update the links in the records linked to the losing recoed automatically, similar to how this is done for authorities. If the library is using UseControlNumber this should also include the $w subfields. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 15:39:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 14:39:53 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Christian Stelzenmüller changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christian.stelzenmueller at bs | |z-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 16:23:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 15:23:21 +0000 Subject: [Koha-bugs] [Bug 26621] .mailmap adjustments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26621 Ahmed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ahmedsayeed1982 at yahoo.com --- Comment #18 from Ahmed --- /gdb/arch/arc.c:117:43: required from here http://www.compilatori.com/ /usr/include/c++/4.8.2/bits/hashtable_policy.h:195:39: error: no matching https://www.mktrade.fi/ function for call to ‘std::pair >::pair(const arc_arch_features&, target_desc*&)’ : _M_v(std::forward<_Args>(__args)...) { } http://www.acpirateradio.co.uk/ ^ /usr/include/c++/4.8.2/bits/hashtable_policy.h:195:39: note: candidates are: https://www.webb-dev.co.uk/ In file included from /usr/include/c++/4.8.2/utility:70:0, from /usr/include/c++/4.8.2/tuple:38, http://www.logoarts.co.uk/ from /usr/include/c++/4.8.2/functional:55, from ../../gdb/../gdbsupport/ptid.h:35, https://komiya-dental.com/ from ../../gdb/../gdbsupport/common-defs.h:123, from ../../gdb/arch/arc.c:19: http://www.slipstone.co.uk/ /usr/include/c++/4.8.2/bits/stl_pair.h:206:9: note: template std::pair<_T1, http://embermanchester.uk/ _T2>::pair(std::tuple<_Args1 ...>&, std::tuple<_Args2 ...>&, std::_Index_tuple http://fishingnewsletters.co.uk/ <_Indexes1 ...>, std::_Index_tuple<_Indexes2 ...>) pair(tuple<_Args1...>&, tuple<_Args2...>&, http://connstr.net/ ^ -------->8--------- http://joerg.li/ Thanks to Tome de Vries' investigation, same fix applies in ARC's case as well: --------8<--------- http://www.jopspeech.com/ diff --git a/gdb/arch/arc.c b/gdb/arch/arc.c index 3808f9f..a5385ce 100644 http://www.go-mk-websites.co.uk/ --- a/gdb/arch/arc.c +++ b/gdb/arch/arc.c http://www.wearelondonmade.com/ @@ -114,7 +114,7 @@ struct arc_arch_features_hasher target_desc *tdesc = arc_create_target_description (features); https://waytowhatsnext.com/ /* Add the newly created target description to the repertoire. */ http://www.mconstantine.co.uk/ - arc_tdesc_cache.emplace (features, tdesc); http://www.iu-bloomington.com/ + arc_tdesc_cache.emplace (features, target_desc_up (tdesc)); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 16:23:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 15:23:23 +0000 Subject: [Koha-bugs] [Bug 26394] .mailmap needs to be updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 Ahmed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ahmedsayeed1982 at yahoo.com --- Comment #12 from Ahmed --- no longer builds on aarch64 (native build) after updating to glibc-2.33. http://www-look-4.com/services/usb-type-a/ Due to a glibc 2.33 header file change, the file http://the-hunters.org/category/computers/ nat/aarch64-linux-hw-point.c no longer builds on OSes using this version of glibc. https://komiya-dental.com/services/huawei-service/ An enum for PTRACE_SYSEMU is now provided by . In the past, PTRACE_SYSEMU was defined only in . This is http://www.iu-bloomington.com/property/properties-in-turkey/ what it looks like... In : https://waytowhatsnext.com/crypto/cryptocurrency-taxes/ #define PTRACE_SYSEMU 31 http://www.wearelondonmade.com/health/check-ups/ In : http://www.jopspeech.com/services/surface-duo/ enum __ptrace_request { http://joerg.li/services/kia-rio-price/ ... PTRACE_SYSEMU = 31, #define PT_SYSEMU PTRACE_SYSEMU ... http://connstr.net/services/mobile-games/ } When and are both included in a source http://fishingnewsletters.co.uk/category/computers/ file, we run into the following build problem when the former is included before the latter: http://embermanchester.uk/tech/google-drive/ In file included from nat/aarch64-linux-hw-point.c:26: http://www.go-mk-websites.co.uk/category/computers/ /usr/include/sys/ptrace.h:86:3: error: expected identifier before numeric constant 86 | PTRACE_SYSEMU = 31, http://www.slipstone.co.uk/technology/cars-interior/ | ^~~~~~~~~~~~~ (There are more errors after this one too.) http://www.logoarts.co.uk/technology/robot-vacuums/ The file builds without error when is included after http://www.mconstantine.co.uk/category/computers/ . I found that this is already done in http://www.acpirateradio.co.uk/health/transportation-security/ nat/aarch64-sve-linux-ptrace.h (which is included by nat/aarch64-linux-ptrace.c). http://www.compilatori.com/health/premium-subscription/ A commit for this bug is already on the trunk: https://www.webb-dev.co.uk/computers/crypto-apps/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 17:23:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 16:23:29 +0000 Subject: [Koha-bugs] [Bug 17798] Checking out an item on hold for another patron prints a slip but does not update hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 17:29:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 16:29:46 +0000 Subject: [Koha-bugs] [Bug 29357] "Results" in the results browser is untranslatable (intranet) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29357 Marie-Luce Laflamme changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie-luce.laflamme at inlibro | |.com --- Comment #2 from Marie-Luce Laflamme --- I may have found it in Pootle: fr_CA > Koha version > fr-CA-messages-js.po Search the word "Results" location = koha-tmpl/intranet-tmpl/prog/js/browser.js:97 Thanks to Philippe, who pointed me out the file location fr-CA-messages-js.po Translations were missing in Koha 20.05, and 20.11 only. It was already in the 21.05 version. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 18:26:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 17:26:32 +0000 Subject: [Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 18:26:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 17:26:36 +0000 Subject: [Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127318|0 |1 is obsolete| | --- Comment #6 from Andrew Fuerste-Henry --- Created attachment 127324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127324&action=edit Bug 29180: Rename syspref RequestOnOpac with OPACHoldRequests It is a confusing name because we have 'Article Request' as a feature, and this does not follow Koha terminology. Test plan: `updatedatabase` and confirm that the syspref has been renamed `git grep RequestOnOpac` => No occurrence in the code QA: The syspref's value is always retrieved using Koha.Preference from .tt files, we don't need to send it from controllers or C4::Auth Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 18:27:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 17:27:09 +0000 Subject: [Koha-bugs] [Bug 28926] Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 --- Comment #6 from Mason James --- (In reply to Jonathan Druart from comment #2) > root at kohadevbox:koha(master)$ apt-cache policy libjson-validator-perl > libjson-validator-perl: > Installed: 3.25+dfsg-1+koha3 > Candidate: 3.25+dfsg-1+koha3 > Version table: > *** 3.25+dfsg-1+koha3 500 > 500 http://debian.koha-community.org/koha-staging dev/main amd64 > Packages > 100 /var/lib/dpkg/status > 0.92+dfsg-1 500 > 500 http://httpredir.debian.org/debian stretch/main amd64 Packages > > > Why is JSON::Validator 3.14? the package name has now been updated/corrected to handle deb12 $ apt-cache policy libjson-validator-perl libjson-validator-perl: Installed: 4.99.1+really3.14-koha3 Candidate: 4.99.1+really3.14-koha3 Version table: *** 4.99.1+really3.14-koha3 500 500 http://debian.koha-community.org/koha 20.11/main amd64 Packages 100 /var/lib/dpkg/status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 19:00:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 18:00:37 +0000 Subject: [Koha-bugs] [Bug 29418] New: Zebra clean_search_term does not clean search and so results in error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Bug ID: 29418 Summary: Zebra clean_search_term does not clean search and so results in error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com In fixing/moving analytics search code, zebra was set to simply pass the title through. For any title with a subtitle, correct marc for subfield a ends with a semicolon. This is treated as a field delimiter and the search fails This is causing a spurious warning for many records under zebra: There was an error searching for analytic records, please see the logs for details. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 19:01:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 18:01:52 +0000 Subject: [Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean search and so results in error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 --- Comment #1 from Nick Clemens --- Created attachment 127325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127325&action=edit Bug 29418: Screen ending colons from search term -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 19:03:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 18:03:34 +0000 Subject: [Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean search and so results in error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 19:05:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 18:05:01 +0000 Subject: [Koha-bugs] [Bug 29419] New: suggest for purchase clears itemtype if bib exists Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29419 Bug ID: 29419 Summary: suggest for purchase clears itemtype if bib exists Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org >From the Submit a New Purchase Suggestion function, if the system recognizes the title in one way or another, the system will give the patron the message s message before proceeding with the purchase suggestion: A similar document already exists. Click on confirm your suggestion to ignore this message. At this point, the (document)item type has gone back to, "None." If the patron scrolls down and clicks on "Confirm your suggestion" anyways, and doesn't change the item type a second time, then this is where the system allows for the suggestion to be submitted without the item type. The item type needs to be retained. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 19:08:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 18:08:58 +0000 Subject: [Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean search and so results in error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127325|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 127326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127326&action=edit Bug 29418: Screen ending colons from search term -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 19:17:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 18:17:14 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #14 from Katrin Fischer --- Maybe a solution could then be to change the email to be send directly then instead of via the message queue? The overdue_notices.pl script creates an email with attached overdue messages to be sent to the library when a user should receive an overdue notice, but has no email address. How I would test: * You'll need a patron without email address with overdues. * Notice triggers where one or more of the delays match the overdue item. * Run the overdue_notices.pl with -t (use triggers) * You don't need to set up fines. I believe the code is all in the (very long) overdue_notices.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 22:59:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 21:59:35 +0000 Subject: [Koha-bugs] [Bug 28573] Replace authority record with Z39.50/SRU creates new authority record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Rhonda Kuiper changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper at roundrocktexas.gov --- Comment #17 from Rhonda Kuiper --- Please backport this to 21.05. The problem fixed by this bug is creating a lot of extra work for our catalogers that we didn't have to do when we were on 20.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 4 23:41:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 22:41:44 +0000 Subject: [Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 00:00:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 23:00:11 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #15 from David Cook --- (In reply to Katrin Fischer from comment #14) > Maybe a solution could then be to change the email to be send directly then > instead of via the message queue? > You're probably right about that being the best way, although it is nice to have an entry in the message queue for reviewing/logging. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 00:09:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 23:09:19 +0000 Subject: [Koha-bugs] [Bug 29391] Improve output of reservoir search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29391 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127216|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 127327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127327&action=edit Bug 29391: Improve output of reservoir search This patch makes the cataloging reservoir search results a configurable DataTable. The empty edition and date columns are removed, and an import data column is added. To test, apply the patch and go to Cataloging. - Perform a cataloging search which will return results from the reservoir. - The table of reservoir search results should be a DataTable with paging, navigation, filtering, column configuration, etc. - Confirm that all DataTable controls work correctly. - Go to Administration -> Table settings -> Cataloging -> addbooks. - Try modifying the default configuration and confirm that the settings take effect. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 00:11:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 23:11:20 +0000 Subject: [Koha-bugs] [Bug 29391] Improve output of reservoir search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29391 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #3 from Barbara Johnson --- Very nice update. I especially like that the import date was added. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 00:29:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 23:29:56 +0000 Subject: [Koha-bugs] [Bug 27101] Remove fr-CA installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27101 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement removes release notes| |fr-CA installer data. | |Installer data and | |translations are now in | |YAML format and there is no | |need for localized | |installer files. Keywords|release-notes-needed | CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 00:45:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 23:45:26 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #133 from Victor Grousset/tuxayo --- I can still reproduce easily comment 128 's *f* test on Firefox and Chromium. I can reproduce c. using Chromium, going in the network dev tab, network conditions (wireless icon), network throttling, adding a custom profile with 2 seconds of latency. That 2 second latency allows me to reproduce d. also. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 00:46:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 23:46:48 +0000 Subject: [Koha-bugs] [Bug 27622] Remove nb-NO installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27622 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This removes the SQL release notes| |installer directory from | |the Koha source code. | |Installing Norwegian sample | |data will still be | |possible, but translations | |have been moved into Koha's | |translation system using | |.po files maintained on | |https://translate.koha-comm | |unity.org. Keywords|release-notes-needed | CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 00:49:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 23:49:34 +0000 Subject: [Koha-bugs] [Bug 27101] Remove fr-CA installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27101 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement removes |This enhancement removes release notes|fr-CA installer data. |fr-CA installer data. |Installer data and |Installer data is now in |translations are now in |YAML format and there is no |YAML format and there is no |need for localized |need for localized |installer files (these are |installer files. |now translated using Koha's | |translation system using | |.po files maintained on | |https://translate.koha-comm | |unity.org). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 00:50:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 23:50:13 +0000 Subject: [Koha-bugs] [Bug 27622] Remove nb-NO installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27622 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This removes the SQL |This enhancement removes release notes|installer directory from |Norwegian installer data. |the Koha source code. |Installer data is now in |Installing Norwegian sample |YAML format and there is no |data will still be |need for localized |possible, but translations |installer files (these are |have been moved into Koha's |now translated using Koha's |translation system using |translation system using |.po files maintained on |.po files maintained on |https://translate.koha-comm |https://translate.koha-comm |unity.org. |unity.org). -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 00:53:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 23:53:53 +0000 Subject: [Koha-bugs] [Bug 18984] Remove support for NORMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |The National library of release notes| |Norway has replaced NORMARC | |with MARC21. Koha instances | |that use NORMARC have | |either been converted to | |MARC21, or will need to | |convert as part of any | |upgrade (from Koha 21.11 | |onwards). Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 00:55:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Nov 2021 23:55:20 +0000 Subject: [Koha-bugs] [Bug 29420] New: 401 Unauthorized pages come back as 200 OK under plack Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 Bug ID: 29420 Summary: 401 Unauthorized pages come back as 200 OK under plack Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: wizzyrea at gmail.com QA Contact: testopia at bugs.koha-community.org We have a use case where we define Aliases in Apache for things like some.koha.url/files that are .htpasswd protected. In 21.05 and later, 401 Unauthorized responses go through Koha and become 200 OK. We should make the 401 Unauthorized pages come back as 401 Unauthorized, so that browsers know what to do when BasicAuth is requested. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 01:01:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 00:01:39 +0000 Subject: [Koha-bugs] [Bug 29420] 401 Unauthorized pages come back as 200 OK under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 --- Comment #1 from Liz Rea --- Created attachment 127328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127328&action=edit Bug 29420 - 401 Unauthorized pages come back is 200 OK under plack To test: - create an alias in your /etc/koha/sites/.conf file for something like files Alias /files "/var/lib/koha/kohadev/public_html/" Options +Indexes AuthUserFile /var/lib/koha/kohadev/.htpasswd AuthName ByPassword AuthType Basic require valid-user - make a .htpasswd file: https://hostingcanada.org/htpasswd-generator/ and put it in /var/lib/koha/kohadev - restart apache - navigate to http:///files, note that the response header in the browser inspector says "200 OK" and the basic auth user/pass is not shown - Apply this patch, restart the things - navigate to http:///files, note that the response header in the browser inspector says "401 Unauthorized" and the basic auth user/pass is now shown -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 01:01:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 00:01:55 +0000 Subject: [Koha-bugs] [Bug 29420] 401 Unauthorized pages come back as 200 OK under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |wizzyrea at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 01:09:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 00:09:37 +0000 Subject: [Koha-bugs] [Bug 12561] Remove non-XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Keywords|release-notes-needed | Text to go in the| |This removes the non-XSLT release notes| |views feature that was | |deprecated from July 2014. | | | |As part of this change: | |- | |system preferences | |HighlightOwnItemsOnOPAC and | |HighlightOwnItemsOnOPACWhic | |h are removed | |- a warning | |is added to the about page | |if a default XSLT file was | |removed, or if a file | |referenced in one of the | |system preferences does not | |exist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 01:26:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 00:26:58 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds release notes| |additional logging of | |acquisition-related changes | |including: | |- Order line | |creation and cancellation | |- | |Invoice adjustment | |additions, amendments and | |deletions | |- Order line | |receipts against an invoice | |- Budget adjustments | |- Fund | |adjustments | |- Order release | |date | | | |The name of the | |system preference that | |enables logging of | |acquisition-related changes | |was changed from AcqLog to | |AcquisitionLog. | | | |Note: | |Acquisition logging was | |added in Koha 21.05. CC| |david at davidnind.com Keywords|release-notes-needed |Manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 01:31:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 00:31:00 +0000 Subject: [Koha-bugs] [Bug 28769] tabloop not used in cataloguing plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28769 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This technical change release notes| |removes the "tabloop" | |variable that is passed | |from the add item form | |logic to the cataloguing | |plugins, as it is never | |used. Keywords|release-notes-needed | CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 01:58:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 00:58:38 +0000 Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Keywords|release-notes-needed | Text to go in the| |This enhancement to the release notes| |OPAC enables the display of | |multiple cover images on | |the detail page for a | |record in a light box. | |Previously only one image | |was displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 02:09:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 01:09:21 +0000 Subject: [Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This enhancement changes release notes| |the batch item modification | |and deletion tools so that | |they now use the task queue | |feature (added in Koha | |21.05) instead of using | |background jobs. For the | |library staff member this | |provides more information | |on the progress of the | |task. Keywords|release-notes-needed |Manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 04:11:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 03:11:14 +0000 Subject: [Koha-bugs] [Bug 28413] background job worker is running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127081|0 |1 is obsolete| | --- Comment #16 from Victor Grousset/tuxayo --- Created attachment 127329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127329&action=edit Bug 28413: Reduce background job worker memory footprint It's loading the modules in RAM then forks. Then do not need it to have them loaded in the parent process (the worker/daemon). Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 04:11:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 03:11:47 +0000 Subject: [Koha-bugs] [Bug 28413] background job worker is running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #17 from Victor Grousset/tuxayo --- works (tested on bib record, auth, item and hold cancel, ram usage decreased), QA script happy, code look ok. Passed! It's surprising that these classes take dozens of MB of RAM to load. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 04:11:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 03:11:53 +0000 Subject: [Koha-bugs] [Bug 28413] background job worker is running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 04:13:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 03:13:40 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #134 from Victor Grousset/tuxayo --- and issue a. is fixed :D thanks for the other fixes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 08:17:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 07:17:08 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #40 from Marcel de Rooy --- Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 08:45:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 07:45:56 +0000 Subject: [Koha-bugs] [Bug 29421] New: Remove C4::Biblio::GetBiblioData Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29421 Bug ID: 29421 Summary: Remove C4::Biblio::GetBiblioData Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org See also bug 27266 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 08:46:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 07:46:22 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29421 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29421 [Bug 29421] Remove C4::Biblio::GetBiblioData -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 08:46:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 07:46:22 +0000 Subject: [Koha-bugs] [Bug 29421] Remove C4::Biblio::GetBiblioData In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29421 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27266 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 08:46:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 07:46:54 +0000 Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement to the |This enhancement to the release notes|OPAC enables the display of |OPAC enables the display of |multiple cover images on |multiple cover images on |the detail page for a |the detail page for a |record in a light box. |record or items in a |Previously only one image |gallery. |was displayed. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 08:52:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 07:52:47 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #16 from Jonathan Druart --- (In reply to Katrin Fischer from comment #14) > Maybe a solution could then be to change the email to be send directly then > instead of via the message queue? I always thought we were aiming to sent all the notices from the DB table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:07:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:07:43 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #17 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #16) > (In reply to Katrin Fischer from comment #14) > > Maybe a solution could then be to change the email to be send directly then > > instead of via the message queue? > > I always thought we were aiming to sent all the notices from the DB table. I agree. Please note that this overdues case is really an edge case. We should resolve sending attachments in 22.05? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:08:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:08:51 +0000 Subject: [Koha-bugs] [Bug 28413] background job worker is running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413 --- Comment #18 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #17) > works (tested on bib record, auth, item and hold cancel, ram usage > decreased), QA script happy, code look ok. > > Passed! Thanks! > It's surprising that these classes take dozens of MB of RAM to load. If you load one, you load all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:13:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:13:17 +0000 Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from 20.05.xx to 20.11.04-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | Assignee|jonathan.druart+koha at gmail. |koha-bugs at lists.koha-commun |com |ity.org Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:13:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:13:19 +0000 Subject: [Koha-bugs] [Bug 29302] The dataTables Koha RESTful API wrapper should allow picking match type at the column level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29302 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|API DataTables Wrapper |The dataTables Koha RESTful |should allow picking match |API wrapper should allow |type by column |picking match type at the | |column level -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:13:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:13:23 +0000 Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from 20.05.xx to 20.11.04-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:15:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:15:37 +0000 Subject: [Koha-bugs] [Bug 29302] The dataTables Koha RESTful API wrapper should allow picking match type at the column level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29302 --- Comment #3 from Martin Renvoize --- I'm tempted to rename the key too.. 'criteria' isn't hugely clear and it took me reading the code to figure out. Perhaps 'comparator or 'comparison_operator' would more clearly reflect its function? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:27:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:27:52 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:27:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:27:56 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126539|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy --- Created attachment 127330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127330&action=edit Bug 27266: Move GetMarcAuthors to Koha namespace This patch moves C4::Biblio::GetMarcAuthors to Koha::Biblio->get_authors_from_MARC. This is so the method can be used in templates and notices. To test: 1. Find a record that has an author in the added entry field (700-720). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm authors show as normal. 4. Click 'send' and confirm the email sent shows the authors as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. xslt) 6. Log in to the OPAC. Find the record and add it to the cart and a list 7. View the cart and click 'more details'. Confirm authors show as normal. 8. Click 'send' and confirm the email sent shows the authors as normal. 9. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 10. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:28:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:28:00 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126540|0 |1 is obsolete| | --- Comment #42 from Marcel de Rooy --- Created attachment 127331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127331&action=edit Bug 27266: (QA follow-up) Rename to get_marc_authors Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:28:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:28:04 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126541|0 |1 is obsolete| | --- Comment #43 from Marcel de Rooy --- Created attachment 127332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127332&action=edit Bug 27266: (follow-up) Remove instances of GetMarcAuthors Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:28:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:28:09 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126542|0 |1 is obsolete| | --- Comment #44 from Marcel de Rooy --- Created attachment 127333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127333&action=edit Bug 27266: (follow-up) Using biblio frameworkcode to get rid of FIXME Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:28:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:28:12 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126543|0 |1 is obsolete| | --- Comment #45 from Marcel de Rooy --- Created attachment 127334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127334&action=edit Bug 27266: (follow-up) Remove get_marc_authors from opac-detail There's no way to use 'no' XSLT now, so don't need to use this to show authors on the detail page. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:28:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:28:17 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #46 from Marcel de Rooy --- Created attachment 127335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127335&action=edit Bug 27266: (QA follow-up) Remove GetBiblioData from basket scripts We are adding (or already doing) a Koha::Biblios->find, so we should get rid of GetBiblioData, fetching the same data. It returned a few extra columns, but unused here: $dat->{bnotes}, $dat->{bi_notforloan} Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:28:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:28:21 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #47 from Marcel de Rooy --- Created attachment 127336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127336&action=edit Bug 27266: (QA follow-up) Indentation in opac-sendshelf Minimal fix to improve bad indentation a bit, moving to 2 spaces. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:28:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:28:25 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #48 from Marcel de Rooy --- Created attachment 127337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127337&action=edit Bug 27266: (QA follow-up) Remove GetBiblioData from sendshelf too Applies to opac and intranet script. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:30:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:30:51 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #83 from Jonathan Druart --- Created attachment 127338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127338&action=edit Bug 24223: Fix borrowernumber from opac-readingrecord.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:31:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:31:18 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:32:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:32:13 +0000 Subject: [Koha-bugs] [Bug 29421] Remove C4::Biblio::GetBiblioData In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29421 --- Comment #1 from Marcel de Rooy --- git grep -l GetBiblioData C4/Biblio.pm C4/Search.pm acqui/neworderempty.pl catalogue/ISBDdetail.pl catalogue/MARCdetail.pl catalogue/detail.pl catalogue/labeledMARCdetail.pl catalogue/moredetail.pl cataloguing/merge.pl misc/release_notes/release_notes_17_11_00.html misc/release_notes/release_notes_17_11_00.md opac/opac-detail.pl opac/opac-reserve.pl opac/opac-sendbasket.pl opac/opac-shelves.pl t/db_dependent/Biblio.t t/db_dependent/Letters.t tags/list.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:32:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:32:18 +0000 Subject: [Koha-bugs] [Bug 28768] OPAC reading history page (opac-readingrecord.pl) wont display news items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28768 --- Comment #9 from Jonathan Druart --- Created attachment 127339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127339&action=edit Bug 28768: Fix borrowernumber from opac-readingrecord.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:32:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:32:20 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127338|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:32:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:32:38 +0000 Subject: [Koha-bugs] [Bug 28768] OPAC reading history page (opac-readingrecord.pl) wont display news items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28768 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #10 from Jonathan Druart --- (In reply to Jonathan Druart from comment #8) > That's not an insignificant change, the different include must be checked to > make sure none is using one patron's attribute. Done, didn't find anything else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:38:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:38:50 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127335|0 |1 is obsolete| | --- Comment #49 from Marcel de Rooy --- Created attachment 127340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127340&action=edit Bug 27266: (QA follow-up) Remove GetBiblioData from basket scripts We are adding (or already doing) a Koha::Biblios->find, so we should get rid of GetBiblioData, fetching the same data. It returned a few extra columns, but unused here: $dat->{bnotes}, $dat->{bi_notforloan} Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:38:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:38:54 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127336|0 |1 is obsolete| | --- Comment #50 from Marcel de Rooy --- Created attachment 127341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127341&action=edit Bug 27266: (QA follow-up) Indentation in opac-sendshelf Minimal fix to improve bad indentation a bit, moving to 2 spaces. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:38:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:38:58 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127337|0 |1 is obsolete| | --- Comment #51 from Marcel de Rooy --- Created attachment 127342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127342&action=edit Bug 27266: (QA follow-up) Remove GetBiblioData from sendshelf too Applies to opac and intranet script. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:41:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:41:15 +0000 Subject: [Koha-bugs] [Bug 29421] Remove C4::Biblio::GetBiblioData In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29421 --- Comment #2 from Marcel de Rooy --- opac/opac-sendbasket.pl has been removed now on bug 27266 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:50:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:50:57 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126484|0 |1 is obsolete| | --- Comment #84 from Jonathan Druart --- Created attachment 127343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127343&action=edit Bug 24223: Convert OpacNav system preference to additional content This patch builds on Bug 22318 to move the OpacNav system preference into the "Additional contents" system, making it possible to have language- and library-specific content. To test you should have some content in the OpacNav system preference. To make testing easier it's also a good idea to have content in the OpacNavBottom preference. - Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from OpacNav is now stored there. When you edit the entry you should see content for each of the enabled translations in your system under each tab. - Confirm that the previous contents of OpacNav were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNav preference has been removed. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - View the OPAC and confirm that the contents of the OpacNav system preference displays in the left-hand sidebar. - Test as many pages as possible to confirm that wherever the OpacNavBottom content is displayed, OpacNav is also displayed. - Test also using the updated translation. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Bug 24223: (follow-up) Add date to OpacNav additional content entries This follow-up modifies the atomic update so that it inserts today's date as the "Published on" date. Without that information the system considers the item unpublished and will not display the content. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Bug 24223: (follow-up) Make logged-in user's branchcode available to template This patch makes a couple of corrections for problems I discovered while working on Bug 24224: The variables required for correct display of news items by branch and language were not consistently available to the templates. In opac-readingrecord.pl, the "lang" variable was being overwritten. On this and other pages the logged-in patron's brachcode was not made available. I've corrected instances of KohaNews.get() to use the globally-available "logged_in_user.branchcode" instead. To test, apply the patch and follow the original test plan, with the addition of instances of the OpacNav additional contents item which have a specific library selected. Confirm that such items are correctly displayed according to the logged-in user's home library. If there is no logged-in user the library-specific OpacNav should not display. Signed-off-by: Marcel de Rooy Bug 24223: (follow-up) Updates to conform to new practices - The patch now works with new "Additional contents" system - The database update follows new skeleton.pl - Add "OpacNav" option to the additional contents template Signed-off-by: Marcel de Rooy Bug 24223: (follow-up) Add missing "return" to atomicupdate Signed-off-by: Marcel de Rooy Bug 24223: (QA follow-up) Link OpacNav to HTML customizations now In the pref description of OpacNavBottom. (Before obsoleting that one too somewhere soon.) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:51:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:51:04 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126488|0 |1 is obsolete| | --- Comment #85 from Jonathan Druart --- Created attachment 127344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127344&action=edit Bug 24223: (follow-up) Do not add id 'opacnav' in navigation.inc Id attribut will be defined by 'koha_news_block'. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:51:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:51:07 +0000 Subject: [Koha-bugs] [Bug 29113] Required new "code" field for additional contents appears unnecessary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #12 from Marcel de Rooy --- + for my $lang ( sort {$a ne 'default'} @lang ) { # Process 'default' first Hmm. Nice coding pattern. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:51:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:51:11 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126490|0 |1 is obsolete| | --- Comment #86 from Jonathan Druart --- Created attachment 127345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127345&action=edit Bug 24223: Get languages for OPAC There were 2 warnings Use of uninitialized value $interface in concatenation (.) or string at /kohadevbox/koha/C4/Languages.pm line 121. Use of uninitialized value $theme in concatenation (.) or string at /kohadevbox/koha/C4/Languages.pm line 121. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:51:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:51:16 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126491|0 |1 is obsolete| | --- Comment #87 from Jonathan Druart --- Created attachment 127346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127346&action=edit Bug 24223: (QA follow-up) Do not copy to other languages By majority on Bugzilla, we dont want to have the existing text in all translatable languages. Note: Removing the news_123 as code here, switching to OpacNav now. Another report should handle/improve the use of code, assuming that it is meant to provide some form of grouping. There is now confusion between the fields code and location. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:51:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:51:55 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126489|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:51:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:51:59 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126492|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:52:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:52:03 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126485|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:52:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:52:06 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126486|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:52:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:52:10 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126487|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:52:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:52:27 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #88 from Jonathan Druart --- Patches rebased and some squashed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:56:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:56:37 +0000 Subject: [Koha-bugs] [Bug 29113] Required new "code" field for additional contents appears unnecessary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #13 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #9) > Created attachment 125861 [details] [review] > Bug 29113: Fix random assignation Unclear commit message, no test plan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:57:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:57:10 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #89 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #81) > (In reply to Jonathan Druart from comment #80) > > 1. I may be missing something but I don't understand why we are setting > > OpacNav from the .tt when we need it in .inc. Why don't we > > AdditionalContents.get from there? > > Is there any best practice about the place of TT's [% USE %] directives? > Note that we still didnt tackle the load aborted errors on template plugins > where we also use includes.. The correct answer was: to avoid double fetch. We are actually doing: SET OpacNav = AdditionalContents.get [...] [% IF OpacNav %] [% INCLUDE navigation.inc %] [% END %] And reusing OpacNav from navigation.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:57:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:57:32 +0000 Subject: [Koha-bugs] [Bug 29113] Required new "code" field for additional contents appears unnecessary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #14 from Marcel de Rooy --- If the title says that it is unnecessary, why not remove it? Or should you better adjust the title? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 09:57:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 08:57:51 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #90 from Jonathan Druart --- Is that weird to have OpacNav without OpacNavBottom part of 21.11? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:01:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:01:34 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #91 from Jonathan Druart --- (In reply to Jonathan Druart from comment #90) > Is that weird to have OpacNav without OpacNavBottom part of 21.11? Well, we have OpacNavRight already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:02:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:02:16 +0000 Subject: [Koha-bugs] [Bug 24224] Convert OpacNavBottom system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Keywords| |rel_21_11_candidate --- Comment #1 from Jonathan Druart --- Can we rush this for 21.11? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:02:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:02:20 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #92 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #90) > Is that weird to have OpacNav without OpacNavBottom part of 21.11? Yes, at least a bit. But these refactoring operations cross release borders. So defendable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:11:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:11:47 +0000 Subject: [Koha-bugs] [Bug 29410] Dates compared arithmetically in MsgType.pm (warns: Argument isn't numeric in numeric ne) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29410 --- Comment #1 from Andrew Nugged --- there are two pieces of the code: if ( ( $i = $item->recall_date ) != 0 ) { $resp .= add_field( FID_RECALL_DATE, timestamp($i), $server ); } if ( ( $i = $item->hold_pickup_date ) != 0 ) { $resp .= add_field( FID_HOLD_PICKUP_DATE, timestamp($i), $server ); } when those emits the error, Argument "2021-11-04" isn't numeric in numeric ne (!=) at /usr/share/koha/lib/C4/SIP/Sip/MsgType.pm I that dumped, 'C4::SIP::ILS::Item=HASH(0x556838ade6a8)' comes with hold_pickup_date '2021-11-04' which is 'SCALAR' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:12:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:12:20 +0000 Subject: [Koha-bugs] [Bug 29410] Dates compared arithmetically in MsgType.pm (warns: Argument isn't numeric in numeric ne) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29410 --- Comment #2 from Andrew Nugged --- there are two pieces of the code: if ( ( $i = $item->recall_date ) != 0 ) { $resp .= add_field( FID_RECALL_DATE, timestamp($i), $server ); } if ( ( $i = $item->hold_pickup_date ) != 0 ) { $resp .= add_field( FID_HOLD_PICKUP_DATE, timestamp($i), $server ); } when those emits the warning, Argument "2021-11-04" isn't numeric in numeric ne (!=) at /usr/share/koha/lib/C4/SIP/Sip/MsgType.pm I that dumped, 'C4::SIP::ILS::Item=HASH(0x556838ade6a8)' comes with hold_pickup_date '2021-11-04' which is 'SCALAR' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:14:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:14:31 +0000 Subject: [Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28941 CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- Yes, caused by commit 586bed1319592e05f5dc3acf64a1dba8cae69d6b Bug 28941: Filter suggestion inputs at the OPAC Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28941 [Bug 28941] No filtering on suggestion at the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:14:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:14:31 +0000 Subject: [Koha-bugs] [Bug 28941] No filtering on suggestion at the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28941 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29416 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:14:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:14:39 +0000 Subject: [Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart+koha at gmail. | |com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:18:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:18:30 +0000 Subject: [Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:18:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:18:34 +0000 Subject: [Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 --- Comment #2 from Jonathan Druart --- Created attachment 127347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127347&action=edit Bug 29416: (bug 28941 follow-up) Restore suggestion prefill >From commit 586bed1319592e05f5dc3acf64a1dba8cae69d6b Bug 28941: Filter suggestion inputs at the OPAC But later in the script we send { suggestion => %$suggestion } to the template and so erase the variable previously passed. Test plan: Login at the OPAC Go to the bibliographic detail page Suggest for purchase => The form must be prefilled! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:19:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:19:32 +0000 Subject: [Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major Keywords| |regression, | |rel_20_11_candidate, | |rel_21_05_candidate, | |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:23:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:23:43 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancment moves release notes| |C4::Biblio::GetMarcAuthors | |to | |Koha::Biblio->get_authors_f | |rom_MARC. This is so the | |method can be used in | |templates and notices. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:24:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:24:23 +0000 Subject: [Koha-bugs] [Bug 29113] Required new "code" field for additional contents appears unnecessary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #15 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #14) > If the title says that it is unnecessary, why not remove it? Or should you > better adjust the title? We need it, to group rows together (rows have different languages, but represent the same content). However the end users don't need it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:26:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:26:26 +0000 Subject: [Koha-bugs] [Bug 29113] Required new "code" field for additional contents appears unnecessary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #16 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #15) > (In reply to Marcel de Rooy from comment #14) > > If the title says that it is unnecessary, why not remove it? Or should you > > better adjust the title? > > We need it, to group rows together (rows have different languages, but > represent the same content). However the end users don't need it. Adjust the title then? If title and commit messages are unclear, getting it further may be more complicated? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:27:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:27:28 +0000 Subject: [Koha-bugs] [Bug 29113] Required new "code" field for additional contents appears unnecessary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #17 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #13) > (In reply to Jonathan Druart from comment #9) > > Created attachment 125861 [details] [review] [review] > > Bug 29113: Fix random assignation > > Unclear commit message, no test plan Because of the sort we cannot shift. So we need to specify and retrieve explicitly what we need (using $lang) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:28:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:28:40 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Required new "code" field |New "code" field for |for additional contents |additional contents is not |appears unnecessary |useful for the end users --- Comment #18 from Jonathan Druart --- (In reply to Jonathan Druart from comment #17) > (In reply to Marcel de Rooy from comment #13) > > (In reply to Jonathan Druart from comment #9) > > > Created attachment 125861 [details] [review] [review] [review] > > > Bug 29113: Fix random assignation > > > > Unclear commit message, no test plan > > Because of the sort we cannot shift. So we need to specify and retrieve > explicitly what we need (using $lang) Done, commit message read good to me however. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:28:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:28:44 +0000 Subject: [Koha-bugs] [Bug 29386] background jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #10 from Marcel de Rooy --- Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:28:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:28:52 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #19 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #16) > (In reply to Jonathan Druart from comment #15) > > (In reply to Marcel de Rooy from comment #14) > > > If the title says that it is unnecessary, why not remove it? Or should you > > > better adjust the title? > > > > We need it, to group rows together (rows have different languages, but > > represent the same content). However the end users don't need it. > > Adjust the title then? > If title and commit messages are unclear, getting it further may be more > complicated? Done, commit message read good to me however. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:29:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:29:59 +0000 Subject: [Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Florian changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:30:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:30:03 +0000 Subject: [Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Florian changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123819|0 |1 is obsolete| | --- Comment #3 from Florian --- Created attachment 127348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127348&action=edit Bug 28853: Fix authority plugin when textarea in biblio record editor In biblio record editor, when subfield value contains more than 100 characters the editor uses a textarea instead of an input. On a field using authority plugin, this breaks the JavaScript because it only searches for input tags : In /koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt : > this.getElementsByTagName('input')[1].value = values[i]; Test plan : 1) Prepare : 1.1) Create a new biblio record with a field using authority plugin, for example 606 1.2) Do not use authority plugin but enter in 606$x more than 100 chars 1.3) Save record 1.4) Create a new autority for 606 biblio field with $a and a $x containing more than 100 chars 2) Test 1 : 2.1) Edit again the biblio record, you see a text area for 606$x 2.2) Use authority plugin on field 606 2.3) Search and choose the new autority 2.4) Check $a,$x and $9 are well filled 3) Test 2 : 3.1) Empty field 606 3.2) Create a second $x subfield and fill it with a random value 3.3) Use authority plugin again on field 606 3.4) Search and choose the new autority 3.5) Check $a and $9 are well filled 3.6) Check first $x contains the value from autority and second $x is empty Signed-off-by: Florian Bontemps -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:31:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:31:09 +0000 Subject: [Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Florian changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |florian.bontemps at biblibre.c | |om --- Comment #4 from Florian --- I know Fridolin and i work in the same company but this patch has gone unattended for a couple months now. Feel free to ask for another signoff if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:32:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:32:50 +0000 Subject: [Koha-bugs] [Bug 29386] background jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:32:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:32:54 +0000 Subject: [Koha-bugs] [Bug 29386] background jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127288|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy --- Created attachment 127349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127349&action=edit Bug 29386: Extend background_jobs.data to LONGTEXT TEXT is too small, we must extend it to allow bigger jobs. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:33:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:33:21 +0000 Subject: [Koha-bugs] [Bug 29386] background jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #12 from Marcel de Rooy --- Trivial. Combining SO and QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:36:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:36:25 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:38:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:38:34 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #8 from Marcel de Rooy --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 10:41:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 09:41:43 +0000 Subject: [Koha-bugs] [Bug 22347] Translatability of ILSDI results for getavaibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22347 marion.durand at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |marion.durand at biblibre.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 11:08:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 10:08:46 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #9 from Marcel de Rooy --- Maybe those people using OPACRenewalBranch, should add that branchcode too in their system ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 11:17:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 10:17:02 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 11:17:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 10:17:06 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127078|0 |1 is obsolete| | Attachment #127213|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy --- Created attachment 127350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127350&action=edit Bug 29341: Prevent OPAC renew to crash if Pseudonymization is set If OpacRenewalBranch = opacrenew then we try to insert a wrong branchcode into pseudonymized_transactions.transaction_branchcode We are trying to insert 'OPACRenew' Test plan: Setup Pseudonymization Set OpacRenewalBranch = opacrenew Renew an item from the OPAC Notice that pseudonymized_transactions.transaction_branchcode is set to NULL Signed-off-by: David Nind [SQUASHED] Bug 29341: Don't modify the branchcode for stats Signed-off-by: Marcel de Rooy [EDIT] Amended test for 'as is' and a reference to OPACRenew in test script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 11:18:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 10:18:05 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #11 from Marcel de Rooy --- There is still time for another QA stamp. But if there would not be, I am fine with passing QA too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 11:23:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 10:23:46 +0000 Subject: [Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #3 from Marcel de Rooy --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 11:27:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 10:27:14 +0000 Subject: [Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 11:27:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 10:27:17 +0000 Subject: [Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127324|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 127351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127351&action=edit Bug 29180: Rename syspref RequestOnOpac with OPACHoldRequests It is a confusing name because we have 'Article Request' as a feature, and this does not follow Koha terminology. Test plan: `updatedatabase` and confirm that the syspref has been renamed `git grep RequestOnOpac` => No occurrence in the code QA: The syspref's value is always retrieved using Koha.Preference from .tt files, we don't need to send it from controllers or C4::Auth Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 11:27:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 10:27:20 +0000 Subject: [Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 --- Comment #8 from Nick Clemens --- Created attachment 127352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127352&action=edit Bug 29180: (QA follow-up) Alphabetize sysprefs.sql Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 11:27:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 10:27:23 +0000 Subject: [Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 --- Comment #9 from Nick Clemens --- Created attachment 127353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127353&action=edit Bug 29180: (QA follow-up) Don't alter old DB up date Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 11:27:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 10:27:44 +0000 Subject: [Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 11:38:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 10:38:59 +0000 Subject: [Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 --- Comment #4 from Marcel de Rooy --- Out of scope, just seeing this: { last unless ($op eq 'add'); # ETC } Normally we only use last in a loop (for, while). Perl allows this and says: "Note that a block by itself is semantically identical to a loop that executes once. Thus last can be used to effect an early exit out of such a block." But surely this should just have been: if( $op eq 'add' ) { # ETC } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 11:46:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 10:46:08 +0000 Subject: [Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 11:46:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 10:46:12 +0000 Subject: [Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127347|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 127354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127354&action=edit Bug 29416: (bug 28941 follow-up) Restore suggestion prefill >From commit 586bed1319592e05f5dc3acf64a1dba8cae69d6b Bug 28941: Filter suggestion inputs at the OPAC But later in the script we send { suggestion => %$suggestion } to the template and so erase the variable previously passed. Test plan: Login at the OPAC Go to the bibliographic detail page Suggest for purchase => The form must be prefilled! Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 11:47:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 10:47:59 +0000 Subject: [Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 --- Comment #6 from Marcel de Rooy --- Tested, seems to work ;) Can be backported as a minimal fix now. But surely this code should get more attention in terms of quality. Advanced hacking. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 11:48:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 10:48:16 +0000 Subject: [Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy at rijksmuseum.nl |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 11:50:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 10:50:32 +0000 Subject: [Koha-bugs] [Bug 29265] Can't pick editor to use when adding new news or HTML customization entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29265 --- Comment #5 from Jonathan Druart --- Created attachment 127355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127355&action=edit Bug 29265: Add missing category parameter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 11:52:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 10:52:00 +0000 Subject: [Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 11:52:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 10:52:04 +0000 Subject: [Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127354|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 127356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127356&action=edit Bug 29416: (bug 28941 follow-up) Restore suggestion prefill >From commit 586bed1319592e05f5dc3acf64a1dba8cae69d6b Bug 28941: Filter suggestion inputs at the OPAC But later in the script we send { suggestion => %$suggestion } to the template and so erase the variable previously passed. Test plan: Login at the OPAC Go to the bibliographic detail page Suggest for purchase => The form must be prefilled! Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:02:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:02:11 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29302 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29302 [Bug 29302] The dataTables Koha RESTful API wrapper should allow picking match type at the column level -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:02:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:02:11 +0000 Subject: [Koha-bugs] [Bug 29302] The dataTables Koha RESTful API wrapper should allow picking match type at the column level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29302 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29408 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 [Bug 29408] The datatables api wrapper is ambiguously named -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:02:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:02:43 +0000 Subject: [Koha-bugs] [Bug 29265] Can't pick editor to use when adding new news or HTML customization entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29265 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127355|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 127357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127357&action=edit Bug 29265: Add missing category parameter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:05:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:05:27 +0000 Subject: [Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 --- Comment #8 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #4) > Out of scope, just seeing this: > > { > last unless ($op eq 'add'); > # ETC > } > > Normally we only use last in a loop (for, while). Perl allows this and says: > "Note that a block by itself is semantically identical to a loop that > executes once. Thus last can be used to effect an early exit out of such a > block." > > But surely this should just have been: > > if( $op eq 'add' ) { > # ETC > } Please add a bug report for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:07:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:07:30 +0000 Subject: [Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 --- Comment #10 from Jonathan Druart --- Thanks Nick, good catches! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:14:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:14:33 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:14:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:14:36 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 --- Comment #32 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:14:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:14:39 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:14:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:14:42 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 --- Comment #20 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:14:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:14:44 +0000 Subject: [Koha-bugs] [Bug 28413] background job worker is running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:14:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:14:47 +0000 Subject: [Koha-bugs] [Bug 28413] background job worker is running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413 --- Comment #19 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:14:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:14:49 +0000 Subject: [Koha-bugs] [Bug 28768] OPAC reading history page (opac-readingrecord.pl) wont display news items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28768 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:14:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:14:52 +0000 Subject: [Koha-bugs] [Bug 28768] OPAC reading history page (opac-readingrecord.pl) wont display news items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28768 --- Comment #11 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:14:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:14:54 +0000 Subject: [Koha-bugs] [Bug 29123] Add Dataly Tech to About page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29123 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:14:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:14:57 +0000 Subject: [Koha-bugs] [Bug 29123] Add Dataly Tech to About page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29123 --- Comment #12 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:15:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:15:00 +0000 Subject: [Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:15:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:15:03 +0000 Subject: [Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 --- Comment #11 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:15:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:15:06 +0000 Subject: [Koha-bugs] [Bug 29386] background jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:15:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:15:08 +0000 Subject: [Koha-bugs] [Bug 29386] background jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 --- Comment #13 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:15:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:15:11 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:15:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:15:13 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:15:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:15:16 +0000 Subject: [Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:15:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:15:18 +0000 Subject: [Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 --- Comment #9 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:15:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:15:45 +0000 Subject: [Koha-bugs] [Bug 29265] Can't pick editor to use when adding new news or HTML customization entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29265 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #7 from Jonathan Druart --- (In reply to Jonathan Druart from comment #6) > Created attachment 127357 [details] [review] > Bug 29265: Add missing category parameter Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:18:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:18:30 +0000 Subject: [Koha-bugs] [Bug 29302] The dataTables Koha RESTful API wrapper should allow picking match type at the column level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29302 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126673|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 127358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127358&action=edit Bug 29302: Allow passing of 'criteria' at the column level This patch adds the option to pass 'criteria' at the 'column' definition level which means you can set 'contains', 'starts_with', 'ends_with' and 'exact' match types for each different column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:25:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:25:40 +0000 Subject: [Koha-bugs] [Bug 29422] New: Add additional match types to dataTables api wrapper Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29422 Bug ID: 29422 Summary: Add additional match types to dataTables api wrapper Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: jonathan.druart+koha at gmail.com, testopia at bugs.koha-community.org, tomascohen at gmail.com Depends on: 29302, 29408 The `criteria` key in the dataTables wrapper allows the developer to pick the type of comparison that is used in searches. However, it is currently limited to `contains`, `starts_with`, `ends_with` and `exact`. I propose to add some additional comparisons for numeric and date comparisons. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29302 [Bug 29302] The dataTables Koha RESTful API wrapper should allow picking match type at the column level https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 [Bug 29408] The datatables api wrapper is ambiguously named -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:25:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:25:40 +0000 Subject: [Koha-bugs] [Bug 29302] The dataTables Koha RESTful API wrapper should allow picking match type at the column level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29302 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29422 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29422 [Bug 29422] Add additional match types to dataTables api wrapper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:25:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:25:40 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29422 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29422 [Bug 29422] Add additional match types to dataTables api wrapper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:25:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:25:56 +0000 Subject: [Koha-bugs] [Bug 29422] Add additional match types to dataTables api wrapper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29422 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29408 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 [Bug 29408] The datatables api wrapper is ambiguously named -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:25:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:25:56 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29422 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29422 [Bug 29422] Add additional match types to dataTables api wrapper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:31:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:31:08 +0000 Subject: [Koha-bugs] [Bug 29422] Add additional match types to dataTables api wrapper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29422 --- Comment #1 from Martin Renvoize --- Created attachment 127359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127359&action=edit Bug 29422: Add `before`, `after` and `between` match options This patch adds three new comparison operators to the datatables api wrapper. The allow for date (and numberic) type comparisons in searches. The special case `between` operator expects a string value of the form `start:end` and will fall back to `after` comparisons if only a start number/date is passed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:34:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:34:01 +0000 Subject: [Koha-bugs] [Bug 29423] New: link of opac-detail.pl use biblioitemnumber Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29423 Bug ID: 29423 Summary: link of opac-detail.pl use biblioitemnumber Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: rcoelho at net.ipl.pt QA Contact: testopia at bugs.koha-community.org Hi. We found that in some situations when we click on a link instead of the correct record appearing, another record appears. After some analysis I found that for this record the biblioitemnumber is different from the biblionumber. When the link is built instead of placing the biblionumber, the biblioitemnumber is placed generating the error. How can I put the biblionumber in the construction of the link to the record detail? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:38:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:38:34 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29422 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29422 [Bug 29422] Add additional match types to dataTables api wrapper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:38:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:38:34 +0000 Subject: [Koha-bugs] [Bug 29422] Add additional match types to dataTables api wrapper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29422 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:39:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:39:42 +0000 Subject: [Koha-bugs] [Bug 24224] Convert OpacNavBottom system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:39:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:39:45 +0000 Subject: [Koha-bugs] [Bug 24224] Convert OpacNavBottom system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 --- Comment #2 from Owen Leonard --- Created attachment 127360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127360&action=edit Bug 24224: Convert OpacNavBottom system preference to additional content This patch builds on Bug 22318 to move the OpacNavBottom system preference into the "Additional contents" system, making it possible to have language- and library-specific content. To test you should have some content in the OpacNavBottom system preference. To make testing easier it's also a good idea to have content in the OpacNav preference. - Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from OpacNavBottom is now stored there. When you edit the entry you should see content from the OpacNavBottom system preference under the "default" tab. - The publication date for the entry should be today's date. - Confirm that the previous contents of OpacNavBottom were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNavBottom preference has been removed. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - View the OPAC and confirm that the contents of the OpacNavBottom system preference displays in the left-hand sidebar. - Test as many pages as possible to confirm that wherever the OpacNavBottom content is displayed, OpacNavBottom is also displayed. - Test also using the updated translation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:43:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:43:56 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29397 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 [Bug 29397] Add a select2 wrapper for the API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:43:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:43:56 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:44:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:44:49 +0000 Subject: [Koha-bugs] [Bug 29422] Add additional match types to dataTables api wrapper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29422 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:44:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:44:54 +0000 Subject: [Koha-bugs] [Bug 29422] Add additional match types to dataTables api wrapper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29422 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:49:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:49:13 +0000 Subject: [Koha-bugs] [Bug 29423] link of opac-detail.pl use biblioitemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29423 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #1 from Owen Leonard --- Can you describe exactly how to reproduce this bug? Which link isn't working correctly? What version of Koha are you using? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 12:57:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 11:57:02 +0000 Subject: [Koha-bugs] [Bug 29423] link of opac-detail.pl use biblioitemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29423 --- Comment #2 from Rui Coelho --- For example the link https://estc.biblio.ipl.pt/cgi-bin/koha/opac-detail.pl?biblionumber=101587&query_desc=au%2Cwrdl%3A%20Isabela%20Figueiredo is not working correctly because it is pointing to record 101587 when it should be pointing to 101594. The record has biblionumber = 101594 and biblioitemnumber = 101587. We using koha version 16.11.14.000. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:00:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:00:51 +0000 Subject: [Koha-bugs] [Bug 29363] TestBuilder.t failing if biblionumber=123 does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29363 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #3 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:01:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:01:00 +0000 Subject: [Koha-bugs] [Bug 29423] link of opac-detail.pl use biblioitemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29423 --- Comment #3 from Owen Leonard --- Unfortunately 16.11.x is very old and unsupported. Your best option is to upgrade so that you know you're not dealing with a bug that has already been fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:02:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:02:33 +0000 Subject: [Koha-bugs] [Bug 29364] Search.t not reverting changes made to the framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29364 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:03:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:03:30 +0000 Subject: [Koha-bugs] [Bug 29368] Zebra index not correctly mocked from tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29368 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:05:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:05:12 +0000 Subject: [Koha-bugs] [Bug 29374] searchResults explodes if biblio record has been deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29374 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:22:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:22:10 +0000 Subject: [Koha-bugs] [Bug 28573] Replace authority record with Z39.50/SRU creates new authority record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #18 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:22:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:22:50 +0000 Subject: [Koha-bugs] [Bug 29195] Highlighting broken on odd rows in circ-patron-search-results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29195 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:22:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:22:52 +0000 Subject: [Koha-bugs] [Bug 24370] Editing purchase suggestion changes the acquisition library to logged-in user's In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24370 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:22:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:22:54 +0000 Subject: [Koha-bugs] [Bug 29195] Highlighting broken on odd rows in circ-patron-search-results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29195 --- Comment #4 from Owen Leonard --- Created attachment 127361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127361&action=edit Bug 29195: Fix highlighting on odd rows in circ-patron-search-results This patch adds "!important" to the CSS rule governing the background color of table cells when hovered. It only applies to tables with the "selections-table" class. Although "!important" is not usually recommended, in this case the appliation is narrow enough that I think it outweighs the complicated selector that would be required to make it work otherwise. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Locate a record in the catalog and being the process of placing a hold. - When you're asked to enter a card number or search by name, search using a name which will return multiple results. - In the table of results, hovering the mouse over the table should highlight the row in yellow. - Perform the same test when searching for a club by name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:28:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:28:56 +0000 Subject: [Koha-bugs] [Bug 29391] Improve output of reservoir search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29391 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:30:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:30:06 +0000 Subject: [Koha-bugs] [Bug 24224] Convert OpacNavBottom system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24223 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 [Bug 24223] Convert OpacNav system preference to news block -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:30:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:30:06 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24224 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 [Bug 24224] Convert OpacNavBottom system preference to news block -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:34:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:34:09 +0000 Subject: [Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices between different orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #16 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:35:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:35:59 +0000 Subject: [Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #12 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:37:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:37:13 +0000 Subject: [Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #6 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:44:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:44:36 +0000 Subject: [Koha-bugs] [Bug 29195] Highlighting broken on odd rows in circ-patron-search-results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29195 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:44:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:44:39 +0000 Subject: [Koha-bugs] [Bug 29195] Highlighting broken on odd rows in circ-patron-search-results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29195 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127361|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 127362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127362&action=edit Bug 29195: Fix highlighting on odd rows in circ-patron-search-results This patch adds "!important" to the CSS rule governing the background color of table cells when hovered. It only applies to tables with the "selections-table" class. Although "!important" is not usually recommended, in this case the appliation is narrow enough that I think it outweighs the complicated selector that would be required to make it work otherwise. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Locate a record in the catalog and being the process of placing a hold. - When you're asked to enter a card number or search by name, search using a name which will return multiple results. - In the table of results, hovering the mouse over the table should highlight the row in yellow. - Perform the same test when searching for a club by name. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:45:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:45:00 +0000 Subject: [Koha-bugs] [Bug 29195] Highlighting broken on odd rows in circ-patron-search-results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29195 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:47:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:47:56 +0000 Subject: [Koha-bugs] [Bug 24224] Convert OpacNavBottom system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127360|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 127363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127363&action=edit Bug 24224: Convert OpacNavBottom system preference to additional content This patch builds on Bug 22318 to move the OpacNavBottom system preference into the "Additional contents" system, making it possible to have language- and library-specific content. To test you should have some content in the OpacNavBottom system preference. To make testing easier it's also a good idea to have content in the OpacNav preference. - Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from OpacNavBottom is now stored there. When you edit the entry you should see content from the OpacNavBottom system preference under the "default" tab. - The publication date for the entry should be today's date. - Confirm that the previous contents of OpacNavBottom were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNavBottom preference has been removed. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - View the OPAC and confirm that the contents of the OpacNavBottom system preference displays in the left-hand sidebar. - Test as many pages as possible to confirm that wherever the OpacNavBottom content is displayed, OpacNavBottom is also displayed. - Test also using the updated translation. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:48:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:48:41 +0000 Subject: [Koha-bugs] [Bug 24224] Convert OpacNavBottom system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- This looks great.. signing off. One query.. koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt That adds OpacNav too here.. shouldn't that have been caught in the dependency bug already? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:52:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:52:17 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #136 from Kyle M Hall --- Unit tests fail in 21.05.x, please rebase and ping me if this is needed for 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:52:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:52:18 +0000 Subject: [Koha-bugs] [Bug 24609] Add routes for updating checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Bug 24609 depends on bug 24850, which changed state. Bug 24850 Summary: Koha::DateUtils ignores offsets in RFC3339 datetimes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:52:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:52:18 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Bug 28377 depends on bug 24850, which changed state. Bug 24850 Summary: Koha::DateUtils ignores offsets in RFC3339 datetimes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:52:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:52:19 +0000 Subject: [Koha-bugs] [Bug 29401] Hold suspensions should match the resolution of other holds date fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29401 Bug 29401 depends on bug 24850, which changed state. Bug 24850 Summary: Koha::DateUtils ignores offsets in RFC3339 datetimes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:52:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:52:19 +0000 Subject: [Koha-bugs] [Bug 29402] We should add a 'dateonly' switch option to dt_from_string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29402 Bug 29402 depends on bug 24850, which changed state. Bug 24850 Summary: Koha::DateUtils ignores offsets in RFC3339 datetimes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:52:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:52:19 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Bug 29403 depends on bug 24850, which changed state. Bug 24850 Summary: Koha::DateUtils ignores offsets in RFC3339 datetimes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 13:58:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 12:58:55 +0000 Subject: [Koha-bugs] [Bug 29152] Change to default search behavior when limiting by branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29152 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #5 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 14:08:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 13:08:57 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #20 from Martin Renvoize --- This is one of the reasons I was keen to have distinct tables for these features rather than combine them I think.. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387#c30 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 14:11:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 13:11:04 +0000 Subject: [Koha-bugs] [Bug 29420] 401 Unauthorized pages come back as 200 OK under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 14:11:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 13:11:07 +0000 Subject: [Koha-bugs] [Bug 29420] 401 Unauthorized pages come back as 200 OK under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127328|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 127364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127364&action=edit Bug 29420 - 401 Unauthorized pages come back is 200 OK under plack To test: - create an alias in your /etc/koha/sites/.conf file for something like files Alias /files "/var/lib/koha/kohadev/public_html/" Options +Indexes AuthUserFile /var/lib/koha/kohadev/.htpasswd AuthName ByPassword AuthType Basic require valid-user - make a .htpasswd file: https://hostingcanada.org/htpasswd-generator/ and put it in /var/lib/koha/kohadev - restart apache - navigate to http:///files, note that the response header in the browser inspector says "200 OK" and the basic auth user/pass is not shown - Apply this patch, restart the things - navigate to http:///files, note that the response header in the browser inspector says "401 Unauthorized" and the basic auth user/pass is now shown Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 14:12:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 13:12:36 +0000 Subject: [Koha-bugs] [Bug 29420] 401 Unauthorized pages come back as 200 OK under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Assignee|koha-bugs at lists.koha-commun |liz at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 14:12:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 13:12:41 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #21 from Martin Renvoize --- Sorry, sha1 errors, I can't get this one to apply. My feeling is.. this hides an issue nicely as an interim measure.. I still feel that we should split the features to allow them to develop independently and at that point we can drop the superfluous 'code' field for this particular use case. I'm still keen on 'News', 'Blocks' and 'Pages' at the end of the day -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 14:27:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 13:27:54 +0000 Subject: [Koha-bugs] [Bug 29424] New: Replace the table on 'HTML customisations' administration with a visual alternative. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29424 Bug ID: 29424 Summary: Replace the table on 'HTML customisations' administration with a visual alternative. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org There are a fixed set of 'Blocks' available for HTML Customisations.. I propose that instead of a table, we have a more visual representation of where these blocks will appear once content is added to them. Something more akin to the image we have in the Manual that is used to display where the blocks reside: https://koha-community.org/manual/21.05/en/html/tools.html?highlight=customisation#html-customizations But with the "Green blocks" being clickable to enter the editing process. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 14:28:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 13:28:11 +0000 Subject: [Koha-bugs] [Bug 29424] Replace the table on 'HTML customisations' administration with a visual alternative. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29424 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24387 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 [Bug 24387] Rename News tool -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 14:28:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 13:28:11 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29424 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29424 [Bug 29424] Replace the table on 'HTML customisations' administration with a visual alternative. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 14:28:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 13:28:49 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125861|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart --- Created attachment 127365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127365&action=edit Bug 29113: Fix random assignation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 14:30:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 13:30:14 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #23 from Jonathan Druart --- (In reply to Martin Renvoize from comment #21) > Sorry, sha1 errors, I can't get this one to apply. > > My feeling is.. this hides an issue nicely as an interim measure.. I still > feel that we should split the features to allow them to develop > independently and at that point we can drop the superfluous 'code' field for > this particular use case. > > I'm still keen on 'News', 'Blocks' and 'Pages' at the end of the day Which issue is hidden? We need this column, even if we split the features (what would we gain?). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 14:34:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 13:34:23 +0000 Subject: [Koha-bugs] [Bug 29425] New: Rename SAN in the Library EDI Accounts Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29425 Bug ID: 29425 Summary: Rename SAN in the Library EDI Accounts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It would be nice to have more clarification to the column "SAN" in the EDI account setup. If this column could be called "Buyer SAN", this would be more clear to libraries when setting up EDI. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 14:43:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 13:43:37 +0000 Subject: [Koha-bugs] [Bug 29386] background jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 14:43:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 13:43:41 +0000 Subject: [Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 14:43:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 13:43:42 +0000 Subject: [Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 14:43:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 13:43:47 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|regression, | |rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 14:43:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 13:43:50 +0000 Subject: [Koha-bugs] [Bug 29123] Add Dataly Tech to About page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29123 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 14:43:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 13:43:52 +0000 Subject: [Koha-bugs] [Bug 28413] background job worker is running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:04:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:04:39 +0000 Subject: [Koha-bugs] [Bug 7374] Add remote image option for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:19:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:19:11 +0000 Subject: [Koha-bugs] [Bug 29424] Replace the table on 'HTML customisations' administration with a visual alternative. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29424 --- Comment #1 from Martin Renvoize --- Created attachment 127366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127366&action=edit Image from manual -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:20:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:20:17 +0000 Subject: [Koha-bugs] [Bug 28913] Automatic checkin setting in item type setup should note required cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28913 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:22:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:22:51 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #24 from Jonathan Druart --- To go further: 1. We should add "pages" to this table (and so don't split the table or we will end up with 3 identical tables). This is related to bug 27527. 2. I actually think we should put the notice templates into this table (merge them at least) 3. What we need to avoid this code is to normalize and have 2 tables, linked together. additional_contents - id - category - published_on - updated_on - expirationdate - number Another table for translations: - fk - lang (or eventually fk to a lang table) - title - content And, this is similar to the itemtypes, av, etc. translation story. Translations in the DB must be reconsidered, but it's another topic... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:24:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:24:07 +0000 Subject: [Koha-bugs] [Bug 29350] TT method 'delete' don't need to be escaped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29350 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #3 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:30:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:30:43 +0000 Subject: [Koha-bugs] [Bug 29319] Errors when doing a cataloging search which starts with a number + letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29319 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #11 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:32:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:32:59 +0000 Subject: [Koha-bugs] [Bug 28926] Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:40:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:40:56 +0000 Subject: [Koha-bugs] [Bug 29426] New: borrower_debarments.created is "ON UPDATE current_timestamp()" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29426 Bug ID: 29426 Summary: borrower_debarments.created is "ON UPDATE current_timestamp()" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org https://git.koha-community.org/Koha-community/Koha/src/branch/master/installer/data/mysql/kohastructure.sql Currently, the table borrower_debarments is created like this: CREATE TABLE `borrower_debarments` ( `borrower_debarment_id` int(11) NOT NULL AUTO_INCREMENT COMMENT 'unique key for the restriction', `borrowernumber` int(11) NOT NULL COMMENT 'foreign key for borrowers.borrowernumber for patron who is restricted', `expiration` date DEFAULT NULL COMMENT 'expiration date of the restriction', `type` enum('SUSPENSION','OVERDUES','MANUAL','DISCHARGE') COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT 'MANUAL' COMMENT 'type of restriction', `comment` mediumtext COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'comments about the restriction', `manager_id` int(11) DEFAULT NULL COMMENT 'foreign key for borrowers.borrowernumber for the librarian managing the restriction', `created` timestamp NOT NULL DEFAULT current_timestamp() ON UPDATE current_timestamp() COMMENT 'date the restriction was added', `updated` timestamp NULL DEFAULT NULL COMMENT 'date the restriction was updated', PRIMARY KEY (`borrower_debarment_id`), KEY `borrowernumber` (`borrowernumber`), CONSTRAINT `borrower_debarments_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; Looks like there has been a mixup between the created and the updated columns? We have this: `created` timestamp NOT NULL DEFAULT current_timestamp() ON UPDATE current_timestamp() COMMENT 'date the restriction was added', `updated` timestamp NULL DEFAULT NULL COMMENT 'date the restriction was updated', Would it not make more sense to have this: `created` timestamp NOT NULL DEFAULT current_timestamp() COMMENT 'date the restriction was added', `updated` timestamp NULL DEFAULT NULL ON UPDATE current_timestamp() COMMENT 'date the restriction was updated', ...so that the updated column is actually updated when the row is updated? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:44:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:44:37 +0000 Subject: [Koha-bugs] [Bug 28910] Correct eslint errors in OPAC basket.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28910 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #5 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:46:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:46:48 +0000 Subject: [Koha-bugs] [Bug 28901] showCart incorrectly calculates position if content above navbar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28901 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle at bywatersolutions.com --- Comment #15 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:47:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:47:20 +0000 Subject: [Koha-bugs] [Bug 29242] Flatpickr - Turn autocomplete off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29242 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:47:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:47:20 +0000 Subject: [Koha-bugs] [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 Bug 29239 depends on bug 29242, which changed state. Bug 29242 Summary: Flatpickr - Turn autocomplete off https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29242 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:52:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:52:36 +0000 Subject: [Koha-bugs] [Bug 29328] Add missing list parameter to reports parameter menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29328 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #5 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:55:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:55:13 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122613|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 127367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127367&action=edit Bug 28374: Convert printreceipt to use GetPreparedLetter This patch converts the point of sale receipt printer controller to using GetPreparedLetter instead of calling getletter directly. Test plan 1/ Try printing a point of sale receipt before and after applying the patch 2/ No change should result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:55:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:55:17 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 --- Comment #6 from Martin Renvoize --- Created attachment 127368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127368&action=edit Bug 28374: Update existing notices This patch updates the default slip to include KohaDates, Branches and Price plugins as required and prepends the same to existing notices at upgrade time. We also, switch the HTML flag on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:56:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:56:13 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Martin Renvoize --- Sorry.. it took me ages to get back to this.. the fix was trivial too :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:57:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:57:35 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:57:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:57:39 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121344|0 |1 is obsolete| | Attachment #121346|0 |1 is obsolete| | Attachment #121347|0 |1 is obsolete| | Attachment #121348|0 |1 is obsolete| | Attachment #121349|0 |1 is obsolete| | Attachment #121350|0 |1 is obsolete| | Attachment #121351|0 |1 is obsolete| | Attachment #121357|0 |1 is obsolete| | Attachment #121358|0 |1 is obsolete| | Attachment #121365|0 |1 is obsolete| | Attachment #121400|0 |1 is obsolete| | Attachment #121402|0 |1 is obsolete| | Attachment #121403|0 |1 is obsolete| | Attachment #121404|0 |1 is obsolete| | Attachment #121509|0 |1 is obsolete| | Attachment #121510|0 |1 is obsolete| | Attachment #121521|0 |1 is obsolete| | Attachment #121534|0 |1 is obsolete| | Attachment #121642|0 |1 is obsolete| | Attachment #121643|0 |1 is obsolete| | Attachment #121644|0 |1 is obsolete| | Attachment #121645|0 |1 is obsolete| | Attachment #121646|0 |1 is obsolete| | Attachment #121699|0 |1 is obsolete| | Attachment #121700|0 |1 is obsolete| | Attachment #121701|0 |1 is obsolete| | Attachment #122018|0 |1 is obsolete| | --- Comment #40 from Owen Leonard --- Created attachment 127369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127369&action=edit Bug 27741: admin folder Bug 27631 corrected the

    tags in each of the pages in the staf client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:57:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:57:43 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #41 from Owen Leonard --- Created attachment 127370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127370&action=edit Bug 27741: authorities folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:57:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:57:47 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #42 from Owen Leonard --- Created attachment 127371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127371&action=edit Bug 27741: basket folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:57:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:57:50 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #43 from Owen Leonard --- Created attachment 127372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127372&action=edit Bug 27741: catalogue folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:57:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:57:54 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #44 from Owen Leonard --- Created attachment 127373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127373&action=edit Bug 27741: cataloguing folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:57:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:57:58 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #45 from Owen Leonard --- Created attachment 127374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127374&action=edit Bug 27741: clubs folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:58:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:58:02 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #46 from Owen Leonard --- Created attachment 127375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127375&action=edit Bug 27741: common folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:58:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:58:06 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #47 from Owen Leonard --- Created attachment 127376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127376&action=edit Bug 27741: virtualshelves folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:58:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:58:10 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #48 from Owen Leonard --- Created attachment 127377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127377&action=edit Bug 27741: patron_lists folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:58:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:58:14 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #49 from Owen Leonard --- Created attachment 127378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127378&action=edit Bug 27741: pos folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:58:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:58:18 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #50 from Owen Leonard --- Created attachment 127379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127379&action=edit Bug 27741: suggestion folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:58:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:58:23 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #51 from Owen Leonard --- Created attachment 127380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127380&action=edit Bug 27741: tags folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:58:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:58:27 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #52 from Owen Leonard --- Created attachment 127381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127381&action=edit Bug 27741: patroncards folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:58:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:58:31 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #53 from Owen Leonard --- Created attachment 127382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127382&action=edit Bug 27741: labels folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:58:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:58:35 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #54 from Owen Leonard --- Created attachment 127383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127383&action=edit Bug 27741: serials folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:58:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:58:39 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #55 from Owen Leonard --- Created attachment 127384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127384&action=edit Bug 27741: onboarding folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:58:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:58:44 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #56 from Owen Leonard --- Created attachment 127385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127385&action=edit Bug 27741: about.tt Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:58:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:58:48 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #57 from Owen Leonard --- Created attachment 127386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127386&action=edit Bug 27741: main page Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to the main page of the staff client and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:58:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:58:52 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #58 from Owen Leonard --- Created attachment 127387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127387&action=edit Bug 27741: installer folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:58:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:58:56 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #59 from Owen Leonard --- Created attachment 127388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127388&action=edit Bug 27741: ill folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:59:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:59:00 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #60 from Owen Leonard --- Created attachment 127389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127389&action=edit Bug 27741: tools folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:59:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:59:04 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #61 from Owen Leonard --- Created attachment 127390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127390&action=edit Bug 27741: circ folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:59:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:59:07 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #62 from Owen Leonard --- Created attachment 127391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127391&action=edit Bug 27741: reserve folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:59:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:59:12 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #63 from Owen Leonard --- Created attachment 127392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127392&action=edit Bug 27741: reports folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:59:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:59:19 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #64 from Owen Leonard --- Created attachment 127393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127393&action=edit Bug 27741: acqui folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:59:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:59:23 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #65 from Owen Leonard --- Created attachment 127394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127394&action=edit Bug 27741: members folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 15:59:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 14:59:29 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #66 from Owen Leonard --- Created attachment 127395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127395&action=edit Bug 27741: course_reserves folder Bug 27631 corrected the

    tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under

    are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:05:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:05:42 +0000 Subject: [Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29321 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:05:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:05:42 +0000 Subject: [Koha-bugs] [Bug 29321] My new bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29321 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29416 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:06:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:06:00 +0000 Subject: [Koha-bugs] [Bug 29321] Remove a last without loop context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29321 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|My new bug |Remove a last without loop | |context -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:06:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:06:14 +0000 Subject: [Koha-bugs] [Bug 29321] Remove a last without loop context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29321 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:06:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:06:38 +0000 Subject: [Koha-bugs] [Bug 29321] Remove a last without loop context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29321 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:06:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:06:41 +0000 Subject: [Koha-bugs] [Bug 29321] Remove a last without loop context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29321 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126919|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 127396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127396&action=edit Bug 29321: Remove a last without loop context This reads better when converted to regular if. Note that last within such a block is allowed in Perl, but it feels better to use it only in a loop context. Test plan: Read the patch ;) Bonus: Test if you enter the block by using pref OPACSuggestionMandatoryFields when adding a suggestion from opac. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:09:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:09:46 +0000 Subject: [Koha-bugs] [Bug 29321] Remove a last without loop context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29321 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Marcel de Rooy --- Self signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:23:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:23:04 +0000 Subject: [Koha-bugs] [Bug 29352] Runtime parameter labels should not be said to be optional In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:25:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:25:37 +0000 Subject: [Koha-bugs] [Bug 29351] Add missing cn_source parameter to reports parameter menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:36:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:36:26 +0000 Subject: [Koha-bugs] [Bug 29355] Pickup location list limited by RESTdefaultPageSize syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29355 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:36:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:36:27 +0000 Subject: [Koha-bugs] [Bug 29356] Search for pickup library when placing a hold should be truncated in both directions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29356 Bug 29356 depends on bug 29355, which changed state. Bug 29355 Summary: Pickup location list limited by RESTdefaultPageSize syspref https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29355 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:36:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:36:27 +0000 Subject: [Koha-bugs] [Bug 29404] Add infinite scrolling to pickup location dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 Bug 29404 depends on bug 29355, which changed state. Bug 29355 Summary: Pickup location list limited by RESTdefaultPageSize syspref https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29355 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:46:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:46:01 +0000 Subject: [Koha-bugs] [Bug 29427] New: Debug mode not honoured in SMTP transport Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Bug ID: 29427 Summary: Debug mode not honoured in SMTP transport Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:46:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:46:15 +0000 Subject: [Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Depends on| |22343 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 [Bug 22343] Add configuration options for SMTP servers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:46:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:46:15 +0000 Subject: [Koha-bugs] [Bug 22343] Add configuration options for SMTP servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29427 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 [Bug 29427] Debug mode not honoured in SMTP transport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:51:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:51:49 +0000 Subject: [Koha-bugs] [Bug 29356] Search for pickup library when placing a hold should be truncated in both directions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29356 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:52:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:52:43 +0000 Subject: [Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:52:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:52:47 +0000 Subject: [Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 127397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127397&action=edit Bug 29427: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:52:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:52:52 +0000 Subject: [Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 127398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127398&action=edit Bug 29427: Make SMTP transport set debug mode correctly This patch makes the _transport_ method in Koha::SMTP::Server pass the debug flag correctly to the Email::Sender::Transport::SMTP->new constructor. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/SMTP/Server.t => FAIL: Oh noes! debug is not passed to the constructor! 3. Apply this patch 4. Repeat 2 => SUCCESS: Hey! It is being set! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:53:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:53:07 +0000 Subject: [Koha-bugs] [Bug 28263] AUTO_RENEWALS message for 'too_many' is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:53:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:53:47 +0000 Subject: [Koha-bugs] [Bug 25459] In patron cards layout, barcode position doesn't respect units In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25459 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:53:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:53:58 +0000 Subject: [Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |kyle at bywatersolutions.com, | |liz at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:55:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:55:08 +0000 Subject: [Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The debug flag on the SMTP release notes| |servers configuration was | |not being used correctly. | |This patch implements the | |expected behavior. | | | |Note: | |Enabling this will lead to | |lots of logging for each | |SMTP connection Koha does. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:55:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:55:12 +0000 Subject: [Koha-bugs] [Bug 27884] Add HTML mail support for patron emailer script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #16 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:58:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:58:22 +0000 Subject: [Koha-bugs] [Bug 29428] New: Where is css/holds.css ? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29428 Bug ID: 29428 Summary: Where is css/holds.css ? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org [2021/11/05 15:54:43] [WARN] File not found : css/holds.css at /usr/share/koha/Koha/Template/Plugin/Asset.pm line 107. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:59:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:59:07 +0000 Subject: [Koha-bugs] [Bug 29329] stray "s" in opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29329 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 16:59:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 15:59:44 +0000 Subject: [Koha-bugs] [Bug 28904] Update information on Newsletter editor on about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28904 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle at bywatersolutions.com --- Comment #19 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 17:03:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 16:03:15 +0000 Subject: [Koha-bugs] [Bug 29428] Where is css/holds.css ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29428 --- Comment #1 from Marcel de Rooy --- Coming from reserve/requests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 17:07:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 16:07:51 +0000 Subject: [Koha-bugs] [Bug 28729] Return-path header not set in emails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #60 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 17:23:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 16:23:33 +0000 Subject: [Koha-bugs] [Bug 29395] Use EXPORT_OK in Koha::Patron::Debarments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29395 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 17:28:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 16:28:02 +0000 Subject: [Koha-bugs] [Bug 29429] New: Cannot close budgets Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29429 Bug ID: 29429 Summary: Cannot close budgets Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: florian.bontemps at biblibre.com QA Contact: testopia at bugs.koha-community.org When closing budgets, we get an error trace : Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_admin_aqbudgetperiods_2epl::GetBudgetHierarchy called at /kohadevbox/koha/admin/aqbudgetperiods.pl line 230 admin/aqbudgetperiods. isn't calling GetBudgetHierarchy at line 58. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 17:30:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 16:30:12 +0000 Subject: [Koha-bugs] [Bug 28236] Selecting database columns for system preferences in standard and dev installs is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 17:34:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 16:34:09 +0000 Subject: [Koha-bugs] [Bug 29380] Auto renewing, batch due date extension tool and checkout note previews are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29380 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 17:35:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 16:35:13 +0000 Subject: [Koha-bugs] [Bug 29429] Cannot close budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29429 Florian changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 17:35:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 16:35:16 +0000 Subject: [Koha-bugs] [Bug 29429] Cannot close budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29429 --- Comment #1 from Florian --- Created attachment 127399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127399&action=edit Bug 29429: Cannot close budgets Adds GetBudgetHierarchy to the functions called by C4::Budgets Plan : 1. Create a budget with a random amount, save it. 2. Try to close the budget. 3. You should get an Error Trace. 4. Apply the patch 5. Close the budget again 6. It should work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 17:37:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 16:37:18 +0000 Subject: [Koha-bugs] [Bug 29428] Where is css/holds.css ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29428 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28816 --- Comment #2 from Owen Leonard --- Bug 28816, "Improve the display of multiple holds during hold process" added a new SCSS file, holds.scss, and it looks like the compiled version wasn't added. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816 [Bug 28816] Improve the display of multiple holds during hold process -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 17:37:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 16:37:18 +0000 Subject: [Koha-bugs] [Bug 28816] Improve the display of multiple holds during hold process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29428 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29428 [Bug 29428] Where is css/holds.css ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 17:54:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 16:54:03 +0000 Subject: [Koha-bugs] [Bug 27550] "Duplicate budget" does not keep users associated with that budget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 --- Comment #2 from Jérémy Breuillard --- Created attachment 127400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127400&action=edit Bug 27550: "Duplicate budget" does not keep users associated with that budget Once a budget is duplicated, all the parameters are copied except the Users Test plan : Home > Administration > Budgets 1)Create a budget to allow (active or inactive) 2)Give it some funds by filling up the form, especially Owner and User(s) 3)Submit then you go back to the Budgets dashboard 4)Duplicate the Budget and click on its name 5)Edit it and notice that User(s) is empty 6)Apply the patch 7)Repeat from 1) to 5) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 18:03:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 17:03:39 +0000 Subject: [Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean search and so results in error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28316 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 [Bug 28316] Fix ES crashes related to various punctuation characters -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 18:03:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 17:03:39 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29418 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 [Bug 29418] Zebra clean_search_term does not clean search and so results in error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 18:07:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 17:07:25 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #20 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #19) > (In reply to Marcel de Rooy from comment #18) > > Still nice to have in 21.11 ? > > I would prefer to not rush it and wait for 22.05 Could you please tell me what is the fundamental difference with the patches on bug 29386, that got pushed today ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:09:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:09:23 +0000 Subject: [Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #8 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:10:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:10:04 +0000 Subject: [Koha-bugs] [Bug 28973] Improve Koha::Patron::can_see_patron_infos efficiency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28973 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:14:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:14:14 +0000 Subject: [Koha-bugs] [Bug 26402] Add --framework parameter to commit_file.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26402 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:15:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:15:08 +0000 Subject: [Koha-bugs] [Bug 28879] Display of metadata with long label names looks terrible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28879 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:17:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:17:12 +0000 Subject: [Koha-bugs] [Bug 29430] New: Table cell click doesn't activate buttons in patron search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29430 Bug ID: 29430 Summary: Table cell click doesn't activate buttons in patron search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Patrons Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 15812 In patron search results, if you check one or more checkboxes it changes the state of the "Add to patron list" and "Merge patrons" buttons. The same doesn't happen if you click the table cell. When JS was added to allow a click of the table cell to toggle the checkbox inside it didn't take into account the change function which would need to be triggered. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:17:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:17:12 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29430 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29430 [Bug 29430] Table cell click doesn't activate buttons in patron search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:18:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:18:51 +0000 Subject: [Koha-bugs] [Bug 27375] Set YAML file settings in .editorconfig In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27375 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:19:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:19:10 +0000 Subject: [Koha-bugs] [Bug 28417] Authen::CAS::Client always loaded even if CAS is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28417 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:19:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:19:11 +0000 Subject: [Koha-bugs] [Bug 28410] Reduce memory footprint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410 Bug 28410 depends on bug 28417, which changed state. Bug 28417 Summary: Authen::CAS::Client always loaded even if CAS is not used https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:19:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:19:46 +0000 Subject: [Koha-bugs] [Bug 24406] Remove patron category category type codes from patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:20:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:20:46 +0000 Subject: [Koha-bugs] [Bug 28474] Pass process_message_queue.pl params to before_send_messages plugin hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28474 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #9 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:21:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:21:02 +0000 Subject: [Koha-bugs] [Bug 28474] Pass process_message_queue.pl params to before_send_messages plugin hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28474 --- Comment #10 from Kyle M Hall --- Backported for plugins compatibility. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:22:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:22:26 +0000 Subject: [Koha-bugs] [Bug 27173] Add plugin hooks for authority record changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #16 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:22:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:22:36 +0000 Subject: [Koha-bugs] [Bug 29431] New: Hold queue does not consider expiration date Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29431 Bug ID: 29431 Summary: Hold queue does not consider expiration date Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The holds queue does not take a hold expiration date into consideration. If a hold has an expiration date, the title will show on the queue as needed to be pulled, and when staff check it in, the hold is expired. For libraries that do not auto expire waiting holds, this is a problem. If a hold has an expiration date prior to the current date, it should not show as needing to be pulled, or have some sort of indicator the expiration date of the hold is passed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:22:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:22:42 +0000 Subject: [Koha-bugs] [Bug 27173] Add plugin hooks for authority record changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173 --- Comment #17 from Kyle M Hall --- Backported for plugins compatibility -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:24:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:24:01 +0000 Subject: [Koha-bugs] [Bug 25883] Highlight transfers on checkin screen table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25883 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:24:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:24:02 +0000 Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 Bug 22160 depends on bug 25883, which changed state. Bug 25883 Summary: Highlight transfers on checkin screen table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25883 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:24:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:24:25 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:24:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:24:59 +0000 Subject: [Koha-bugs] [Bug 26326] Add Koha Objects for Import Records and Import Record Matches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:24:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:24:59 +0000 Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through Stage Marc Record Import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Bug 22785 depends on bug 26326, which changed state. Bug 26326 Summary: Add Koha Objects for Import Records and Import Record Matches https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:25:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:25:34 +0000 Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:25:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:25:35 +0000 Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Bug 28966 depends on bug 29015, which changed state. Bug 29015 Summary: Add option to limit Holds Queue report by shelving location / collection https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:25:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:25:35 +0000 Subject: [Koha-bugs] [Bug 29389] Add holding branch to holds queue report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29389 Bug 29389 depends on bug 29015, which changed state. Bug 29015 Summary: Add option to limit Holds Queue report by shelving location / collection https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:25:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:25:53 +0000 Subject: [Koha-bugs] [Bug 27296] Return claims should be filtered by default to show unresolved claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27296 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:27:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:27:28 +0000 Subject: [Koha-bugs] [Bug 27823] List upcoming steps during installation process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27823 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:27:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:27:43 +0000 Subject: [Koha-bugs] [Bug 28450] Make Account summary print tables configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28450 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:27:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:27:57 +0000 Subject: [Koha-bugs] [Bug 28537] Improve HTML generated by OverDrive integration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28537 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:28:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:28:10 +0000 Subject: [Koha-bugs] [Bug 28694] Check alert in cataloguing should be a static message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:28:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:28:23 +0000 Subject: [Koha-bugs] [Bug 28816] Improve the display of multiple holds during hold process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:28:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:28:23 +0000 Subject: [Koha-bugs] [Bug 29428] Where is css/holds.css ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29428 Bug 29428 depends on bug 28816, which changed state. Bug 28816 Summary: Improve the display of multiple holds during hold process https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:28:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:28:37 +0000 Subject: [Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:28:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:28:37 +0000 Subject: [Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Bug 29212 depends on bug 28982, which changed state. Bug 28982 Summary: Use Flatpickr on onboarding pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:28:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:28:37 +0000 Subject: [Koha-bugs] [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 Bug 29239 depends on bug 28982, which changed state. Bug 28982 Summary: Use Flatpickr on onboarding pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:28:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:28:52 +0000 Subject: [Koha-bugs] [Bug 29369] Use Flatpickr in dateaccessioned cataloging plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29369 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:28:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:28:53 +0000 Subject: [Koha-bugs] [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 Bug 29239 depends on bug 29369, which changed state. Bug 29369 Summary: Use Flatpickr in dateaccessioned cataloging plugin https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29369 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:29:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:29:09 +0000 Subject: [Koha-bugs] [Bug 29201] biblio_framework missing form list of runtime parameters when editing SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29201 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:29:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:29:26 +0000 Subject: [Koha-bugs] [Bug 29265] Can't pick editor to use when adding new news or HTML customization entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29265 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:29:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:29:52 +0000 Subject: [Koha-bugs] [Bug 29430] Table cell click doesn't activate buttons in patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29430 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:29:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:29:55 +0000 Subject: [Koha-bugs] [Bug 29430] Table cell click doesn't activate buttons in patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29430 --- Comment #1 from Owen Leonard --- Created attachment 127401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127401&action=edit Bug 29430: Table cell click doesn't activate buttons in patron search Bug 15812 included a change which allows a click on the patron search results table cell to toggle the checkbox it contains. This patch modifies that click event so that it fires the change() event which is required for toggling the "Add to patron list" and "Merge patrons" buttons. To reproduce this problem, perform a patron search in the staff client which will return multiple results. - In the first column containing checkboxes, click in the empty part of the table cell. The checkbox should be checked. - However, the "Add to patron list" button remains disabled. - Clicking a table cell to check another checkbox should result in the "Merge selected patrons" button being enabled, but it doesn't. To test, apply the patch and repeat the process above. The behavior of the buttons should be the same whether you're clicking the checkbox itself or the table cell it's in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:54:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:54:41 +0000 Subject: [Koha-bugs] [Bug 24406] Remove patron category category type codes from patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The patron category type release notes| |code (A, C, O, ...) is | |currently displayed in the | |patron module search, | |patron card creator, and | |acquisition patron | |searches. | | | |This information | |is not useful for most | |users, as these are | |internal codes that cannot | |be easily "decoded". And | |while you might be able to | |guess A as Adult in | |English, it doesn't | |translate to other | |languages. | | | |This patch | |wraps a span around the | |patron category type code | |shown in () after the | |patron category. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:59:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:59:08 +0000 Subject: [Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:59:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:59:11 +0000 Subject: [Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127397|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 127402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127402&action=edit Bug 29427: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 19:59:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 18:59:15 +0000 Subject: [Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127398|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 127403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127403&action=edit Bug 29427: Make SMTP transport set debug mode correctly This patch makes the _transport_ method in Koha::SMTP::Server pass the debug flag correctly to the Email::Sender::Transport::SMTP->new constructor. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/SMTP/Server.t => FAIL: Oh noes! debug is not passed to the constructor! 3. Apply this patch 4. Repeat 2 => SUCCESS: Hey! It is being set! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 20:39:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 19:39:49 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 20:39:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 19:39:53 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #18 from Tomás Cohen Arazi --- Created attachment 127404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127404&action=edit Bug 29330: Add Koha::Email->new_from_string This patch introduces a new method to Koha::Email. This method allows us to parse a MIME email to initialize the Koha::Email object. This is particularly important when we are restoring emails from the DB. i.e. from the *message_queue* table. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/Email.t => SUCCESS: Tests pass! Koha::Email->new_from_string is the correct counterpart for Koha::Email->as_string! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 20:39:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 19:39:57 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 127405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127405&action=edit Bug 29330: Restore handling of serialized MIME messages in message_queue This patch changes how multipart MIME messages are handled on the message_queue table. The email, with the required attachments, is now generated using Koha::Email, and serialized using Koha::Email->as_string. This bug also adds Koha::Email->new_from_string which is used to read that data from the DB, and produce a Koha::Email object, that can be further augmented/modified using regular Koha::Email methods. This implementation should be considered a middle ground, with backportability in mind. higher-level methods should encapsulate setting the default headers and addresses, to clean the area a bit further. Preparation: - You need a valid SMTP configuration in koha-conf.xml. If you use Gmail you can generate an 'app password' and set things like this: smtp.gmail.com 587 5 STARTTLS youraddress at gmail.com youpassword 1 - Set KohaAdminAddress to your address. To test: 1. Pick a patron. Make sure it doesn't have any email address (Acevedo?) 2. Set an overdue notice trigger for its category 3. Check something out, with due date in the past to force an overdue 4. Run: $ kshell k$ misc/cronjobs/overdue_notices.pl -v k$ exit $ koha-mysql kohadev > SELECT * FROM message_queue WHERE borrowernumber=the_borrowernumber; => SUCCESS: A notice has been created 5. Run: $ kshell k$ misc/cronjobs/process_message_queue.pl --verbose => SUCCESS: SMTP is ok => Email is sent => FAIL: Your inbox shows an email with weird content 6. Apply this patches 7. Run: $ koha-mysql kohadev > DELETE FROM message_queue; 8. Repeat 4 and 5 => SUCCESS: You got an email with an attachment! => SUCCESS: The attachment contains an email that couldn't be delivered! 9. Try all the things that enqueue messages :-D => SUCCESS: No behavior change 10. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 20:45:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 19:45:32 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #20 from Tomás Cohen Arazi --- Ok, here's my attempt. I tried several things, and this is the simplest I could come up with. Thinking of a backportable patch. I chose 'MIME' as the content_type because Email::MIME doesn't seem to return the same thing MIME::Lite returns. and, well. On bug 29365 we could implement high level methods for setting 'the addresses' and 'the default headers' and removing the FIXME I introduce. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 20:50:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 19:50:26 +0000 Subject: [Koha-bugs] [Bug 29404] Add infinite scrolling to pickup location dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 21:35:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 20:35:25 +0000 Subject: [Koha-bugs] [Bug 29406] Improve display of OPAC suppression message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29406 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127268|0 |1 is obsolete| | --- Comment #3 from PTFS Europe Sandboxes --- Created attachment 127406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127406&action=edit Bug 29406: Improve display of OPAC suppression message This patch changes the way the "Suppressed in OPAC" message is shown on the staff interface search results and the bibliographic detail page. Now the information is displayed like other bibliographic details. To test, apply the patch and restart services. - Enable the OpacSuppression system preference and modify at least one record to be suppressed in the OPAC (942$n in MARC21). - Perform a catalog search which will return this record in the staff client. - The entry for that record in the search results should include the message "Suppressed in OPAC" at the bottom of the list of other bibliographic details. - View the details for that record. You should see a line labeled "OPAC view" It should say "Suppressed in OPAC." - Test a record which is not suppressed. If you have OPACBaseURL populated you should see "OPAC view: Open in new window." Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 21:41:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 20:41:35 +0000 Subject: [Koha-bugs] [Bug 29406] Improve display of OPAC suppression message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29406 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #4 from Barbara Johnson --- There is a bug (#26861) to indicate that a record is using OpacHiddenItems in staff client. Once that functionality gets created it seems like the display for "Hidden in OPAC" could be handled in the same way as this bug. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26861 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 21:46:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 20:46:50 +0000 Subject: [Koha-bugs] [Bug 29430] Table cell click doesn't activate buttons in patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29430 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127401|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 127407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127407&action=edit Bug 29430: Table cell click doesn't activate buttons in patron search Bug 15812 included a change which allows a click on the patron search results table cell to toggle the checkbox it contains. This patch modifies that click event so that it fires the change() event which is required for toggling the "Add to patron list" and "Merge patrons" buttons. To reproduce this problem, perform a patron search in the staff client which will return multiple results. - In the first column containing checkboxes, click in the empty part of the table cell. The checkbox should be checked. - However, the "Add to patron list" button remains disabled. - Clicking a table cell to check another checkbox should result in the "Merge selected patrons" button being enabled, but it doesn't. To test, apply the patch and repeat the process above. The behavior of the buttons should be the same whether you're clicking the checkbox itself or the table cell it's in. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 21:48:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 20:48:46 +0000 Subject: [Koha-bugs] [Bug 29406] Improve display of OPAC suppression message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29406 --- Comment #5 from Barbara Johnson --- This is trivial but I just noticed that there is an unnecessary period at the end of "Open in new window." which I don't think really needs to be there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 5 21:49:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 20:49:11 +0000 Subject: [Koha-bugs] [Bug 29430] Table cell click doesn't activate buttons in patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29430 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 00:25:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Nov 2021 23:25:10 +0000 Subject: [Koha-bugs] [Bug 22528] Add tab with current/active ILL requests to patron circulation page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22528 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gveranis at dataly.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 02:37:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 01:37:29 +0000 Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from 20.05.xx to 20.11.04-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #19 from Mason James --- > From 10.2.x, the default has been Dynamic. > > I think this bug report could probably be closed, although perhaps we could > have an audit script for double-checking some MySQL settings before > upgrading I guess... that's a bit fraught though. this seems like a great idea, perhaps a warning on the about.pl pages too? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 02:38:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 01:38:20 +0000 Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from 20.05.xx to 20.11.04-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 02:38:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 01:38:31 +0000 Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from 20.05.xx to 20.11.04-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 03:30:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 02:30:48 +0000 Subject: [Koha-bugs] [Bug 29432] New: Item type deletion should test frameworks Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29432 Bug ID: 29432 Summary: Item type deletion should test frameworks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Actually the test to allow deleting an item type is : sub can_be_deleted { my ($self) = @_; my $nb_items = Koha::Items->search( { itype => $self->itemtype } )->count; my $nb_biblioitems = Koha::Biblioitems->search( { itemtype => $self->itemtype } )->count; return $nb_items + $nb_biblioitems == 0 ? 1 : 0; } But using item types on biblioitems.itemtype is not mandatory (for items.itype I do not know), so we should test if this DB column is configured in frameworks to use item types. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 05:07:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 04:07:43 +0000 Subject: [Koha-bugs] [Bug 28143] @INC filled with duplicates of opachtdocs and intrahtdocs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28143 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 07:36:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 06:36:58 +0000 Subject: [Koha-bugs] [Bug 29433] New: situs judi qq online terpercaya Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29433 Bug ID: 29433 Summary: situs judi qq online terpercaya Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Continuous Integration Assignee: tomascohen at gmail.com Reporter: demur.1984 at mail.ru Maka dari itu kita perlu ingat user id dan kata sandi kita biar tidak lupa ya. Begitu lah maksud saya soal judul kali ini ya semampang ada kata kata salah saya minta amnesti ya. https://www.tootcar.com/advert/situs-judi-online-terbesar/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 07:39:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 06:39:38 +0000 Subject: [Koha-bugs] [Bug 29433] situs judi qq online terpercaya In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29433 situsjuditerbaik changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |NeedsMoreQA URL| |https://www.tootcar.com/adv | |ert/situs-judi-online-terbe | |sar/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 07:40:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 06:40:19 +0000 Subject: [Koha-bugs] [Bug 29433] situs judi qq online terpercaya In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29433 situsjuditerbaik changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://www.tootcar.com/adv |https://111.90.151.74/ |ert/situs-judi-online-terbe | |sar/ | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 09:50:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 08:50:49 +0000 Subject: [Koha-bugs] [Bug 11083] Authority Search Result Display should be XSLT Driven In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083 e.betemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 13:26:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 12:26:08 +0000 Subject: [Koha-bugs] [Bug 29429] Cannot close budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29429 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi |y.org | Depends on| |17600 Severity|minor |normal CC| |joonas.kylmala at iki.fi Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 [Bug 17600] Standardize the EXPORT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 13:26:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 12:26:08 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29429 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29429 [Bug 29429] Cannot close budgets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 13:30:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 12:30:41 +0000 Subject: [Koha-bugs] [Bug 29429] Cannot close budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29429 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 13:31:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 12:31:02 +0000 Subject: [Koha-bugs] [Bug 29429] Cannot close budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29429 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 13:31:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 12:31:05 +0000 Subject: [Koha-bugs] [Bug 29429] Cannot close budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29429 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127399|0 |1 is obsolete| | --- Comment #2 from Joonas Kylmälä --- Created attachment 127408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127408&action=edit Bug 29429: Cannot close budgets Adds GetBudgetHierarchy to the functions called by C4::Budgets Plan : 1. Create a budget with a random amount, save it. 2. Try to close the budget. 3. You should get an Error Trace. 4. Apply the patch 5. Close the budget again 6. It should work. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 13:31:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 12:31:50 +0000 Subject: [Koha-bugs] [Bug 29429] Cannot close budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29429 --- Comment #3 from Joonas Kylmälä --- Very trivial fix to the issue caused by bug 17600, moving to PQA directly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 13:34:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 12:34:32 +0000 Subject: [Koha-bugs] [Bug 11083] Authority Search Result Display should be XSLT Driven In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 13:48:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 12:48:14 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |joonas.kylmala at iki.fi --- Comment #3 from Joonas Kylmälä --- This only fixes the bug from one place, these need the same fix: ./Koha/BackgroundJob/BatchDeleteAuthority.pm60: error => ($@ ? $@ : 0), ./Koha/BackgroundJob/BatchUpdateAuthority.pm93: error => ($@ ? $@ : 0), ./Koha/BackgroundJob/BatchCancelHold.pm97: ? ( $@ ? $@ : 0 ) ./Koha/BackgroundJob/BatchDeleteBiblio.pm139: error => ($@ ? $@ : $error), -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 14:46:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 13:46:39 +0000 Subject: [Koha-bugs] [Bug 29410] Dates compared arithmetically in MsgType.pm (warns: Argument isn't numeric in numeric ne) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29410 --- Comment #3 from Andrew Nugged --- more notes: $item->due_date comes in as DateTime object once, '2021-12-03T23:59:00', ref: 'DateTime' but it also comes as scalar '0'. $item->hold_pickup_date comes in as scalar '2021-11-11', ref: '' it also comes as scalar '0'. $item->recall_date comes as scalar '0', I didn't yet figure out in which kind it comes when it has non-zero. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 15:11:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 14:11:57 +0000 Subject: [Koha-bugs] [Bug 29204] Error 500 when execute Circulation report with date period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29204 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 15:12:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 14:12:01 +0000 Subject: [Koha-bugs] [Bug 29204] Error 500 when execute Circulation report with date period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29204 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126475|0 |1 is obsolete| | --- Comment #8 from Joonas Kylmälä --- Created attachment 127409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127409&action=edit Bug 29204: Fix reports/issues_stats.pl for MySQL 8 Error was: Incorrect DATETIME value: '' Test plan Go to Reports -> Circulation On Period select "Row" or "Column" and choose a date Submit Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 15:13:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 14:13:17 +0000 Subject: [Koha-bugs] [Bug 29204] Error 500 when execute Circulation report with date period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29204 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi --- Comment #9 from Joonas Kylmälä --- To be able to test this please remove the strict mode from koha-conf.xml: 0 Spent a while figuring out why the column/row radio button selection doesn't work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 15:19:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 14:19:41 +0000 Subject: [Koha-bugs] [Bug 29204] Error 500 when execute Circulation report with date period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29204 --- Comment #10 from Joonas Kylmälä --- Created attachment 127410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127410&action=edit Bug 29204: (QA follow-up) Fix variable name The patch "Bug 29204: Fix reports/issues_stats.pl for MySQL 8" accidentally changed the variable name from $strsth2 to $strsth Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 17:01:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 16:01:33 +0000 Subject: [Koha-bugs] [Bug 26587] detail.pl is very slow for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120401|0 |1 is obsolete| | Attachment #120402|0 |1 is obsolete| | --- Comment #18 from Joonas Kylmälä --- Created attachment 127411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127411&action=edit Bug 26587: Cache libraries in Koha/Template/Plugins/Branches.pm to improve performance This patch caches the Koha::Library object in a hashmap in the Branches object (GetName, GetURL) to avoid multiple database lookups while looping many items. To test: 1. Have a biblio with many items (1000's). 2. View in staff (detail.pl) and opac (opac-detail.pl). Note how long it takes to load. 3. Apply patch. 4. Repeat 2. Note that pages load faster. Sponsored-by: Lund University Library JK: replaced tab indendation with spaces Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 17:07:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 16:07:42 +0000 Subject: [Koha-bugs] [Bug 26587] detail.pl is very slow for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |joonas.kylmala at iki.fi --- Comment #19 from Joonas Kylmälä --- The library caching patch looks good, I tested with 600 items and the load time went from 22 seconds to 17 seconds on my machine. Björn, could you please move the other patch to a new bug report as also suggested by Fridolin? I mean the patch "Cache Koha::Library object in Branches template plugin (modified per sug.)". You can get the obsolete patch by clicking on Bugzilla on the "Show obsolete" in the attachment section. I obsoleted the patch so that we can now get the finished patch in that we have here, it is quite critical for bigger libraries. I think the other patch still needs more work / discussion as it is using already the caching mechanism there but it is not enough so we need to figure out why and make a better global caching mechanism instead of fixing it only in C4/Items.pm (but that is something to do in the other bug report). Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 17:27:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 16:27:23 +0000 Subject: [Koha-bugs] [Bug 29430] Table cell click doesn't activate buttons in patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29430 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 17:27:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 16:27:26 +0000 Subject: [Koha-bugs] [Bug 29430] Table cell click doesn't activate buttons in patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29430 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127407|0 |1 is obsolete| | --- Comment #3 from Joonas Kylmälä --- Created attachment 127412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127412&action=edit Bug 29430: Table cell click doesn't activate buttons in patron search Bug 15812 included a change which allows a click on the patron search results table cell to toggle the checkbox it contains. This patch modifies that click event so that it fires the change() event which is required for toggling the "Add to patron list" and "Merge patrons" buttons. To reproduce this problem, perform a patron search in the staff client which will return multiple results. - In the first column containing checkboxes, click in the empty part of the table cell. The checkbox should be checked. - However, the "Add to patron list" button remains disabled. - Clicking a table cell to check another checkbox should result in the "Merge selected patrons" button being enabled, but it doesn't. To test, apply the patch and repeat the process above. The behavior of the buttons should be the same whether you're clicking the checkbox itself or the table cell it's in. Signed-off-by: Barbara Johnson Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 17:28:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 16:28:32 +0000 Subject: [Koha-bugs] [Bug 29430] Table cell click doesn't activate buttons in patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29430 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 17:32:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 16:32:28 +0000 Subject: [Koha-bugs] [Bug 29307] marc record fetched twice in detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 --- Comment #6 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #5) > (In reply to Joonas Kylmälä from comment #4) > > They don't do quite the same thing, GetMarcBiblio calls > > C4::Biblio::_koha_marc_update_bib_ids() and $biblio->metadata->record > > doesn't. > > What differences do you expect? Commenting on this just based on the code I read: Before this patch the detail page included biblionumbers if they were not in the original data, after this patch it doesn't. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 17:41:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 16:41:34 +0000 Subject: [Koha-bugs] [Bug 28143] @INC filled with duplicates of opachtdocs and intrahtdocs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28143 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED CC| |joonas.kylmala at iki.fi --- Comment #2 from Joonas Kylmälä --- Fixed already by bug 28303. *** This bug has been marked as a duplicate of bug 28303 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 17:41:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 16:41:34 +0000 Subject: [Koha-bugs] [Bug 28303] Having multiple pluginsdir causes plugin_upload to try to write to the opac-tmpl folder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28303 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #16 from Joonas Kylmälä --- *** Bug 28143 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 23:38:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 22:38:53 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 23:38:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 22:38:59 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127404|0 |1 is obsolete| | --- Comment #21 from David Nind --- Created attachment 127413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127413&action=edit Bug 29330: Add Koha::Email->new_from_string This patch introduces a new method to Koha::Email. This method allows us to parse a MIME email to initialize the Koha::Email object. This is particularly important when we are restoring emails from the DB. i.e. from the *message_queue* table. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/Email.t => SUCCESS: Tests pass! Koha::Email->new_from_string is the correct counterpart for Koha::Email->as_string! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 23:39:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 22:39:04 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127405|0 |1 is obsolete| | --- Comment #22 from David Nind --- Created attachment 127414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127414&action=edit Bug 29330: Restore handling of serialized MIME messages in message_queue This patch changes how multipart MIME messages are handled on the message_queue table. The email, with the required attachments, is now generated using Koha::Email, and serialized using Koha::Email->as_string. This bug also adds Koha::Email->new_from_string which is used to read that data from the DB, and produce a Koha::Email object, that can be further augmented/modified using regular Koha::Email methods. This implementation should be considered a middle ground, with backportability in mind. higher-level methods should encapsulate setting the default headers and addresses, to clean the area a bit further. Preparation: - You need a valid SMTP configuration in koha-conf.xml. If you use Gmail you can generate an 'app password' and set things like this: smtp.gmail.com 587 5 STARTTLS youraddress at gmail.com youpassword 1 - Set KohaAdminAddress to your address. To test: 1. Pick a patron. Make sure it doesn't have any email address (Acevedo?) 2. Set an overdue notice trigger for its category 3. Check something out, with due date in the past to force an overdue 4. Run: $ kshell k$ misc/cronjobs/overdue_notices.pl -v k$ exit $ koha-mysql kohadev > SELECT * FROM message_queue WHERE borrowernumber=the_borrowernumber; => SUCCESS: A notice has been created 5. Run: $ kshell k$ misc/cronjobs/process_message_queue.pl --verbose => SUCCESS: SMTP is ok => Email is sent => FAIL: Your inbox shows an email with weird content 6. Apply this patches 7. Run: $ koha-mysql kohadev > DELETE FROM message_queue; 8. Repeat 4 and 5 => SUCCESS: You got an email with an attachment! => SUCCESS: The attachment contains an email that couldn't be delivered! 9. Try all the things that enqueue messages :-D => SUCCESS: No behavior change 10. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 6 23:40:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Nov 2021 22:40:15 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #23 from David Nind --- Testing notes (using koha-testing-docker): - To set notice triggers (step 2): Tools > Overdue notice/status triggers - Additional test for email (step 9) . [NON QUEUED] Sending cart and lists to email address from the OPAC . [NON QUEUED] Password recovery (enable OpacResetPassword) . Sent overdue message as an HTML message (added paragraph tags and bolded some text) . Sent messages for items checked in and checked out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 7 08:58:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Nov 2021 07:58:04 +0000 Subject: [Koha-bugs] [Bug 28926] Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_candidate Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #7 from Mason James --- (In reply to Jonathan Druart from comment #5) > Pushed to master for 21.11, thanks to everybody involved! hi, can we get this can be backported thru to 19.11? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 7 20:59:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Nov 2021 19:59:01 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize at ptfs-europe |david at davidnind.com |.com | Status|Needs Signoff |Failed QA CC| |david at davidnind.com --- Comment #8 from David Nind --- Created attachment 127415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127415&action=edit Bug 28374 - Print receipt is blank after patches applied After the patches are applied (and database update) the receipt has no details - see the attachment. Testing notes (koha-testing-docker): 1. Setup for testing: i. Enable EnablePointOfSale and UseCashRegisters system preferences ii. Add a new cash register (Administration > Accounting > Cash registers) ii. Add one or two products for sale (Administration > Accounting > Debit types, make sure 'Can be sold?' is ticked) 2. Go to Home > Point of sale 3. Add some items for purchase to a sale 4. Click confirm 5. Click on 'Print receipt' and save the PDF file somewhere 6. Apply patches 7. Update database: updatedatabase 8. Repeat steps 2-5 9. Compare receipt PDFs - should be no changes 10. Check that the default RECEIPT is updated - for print, HTML should be ticked (Tools > 11. Sign off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 7 21:12:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Nov 2021 20:12:47 +0000 Subject: [Koha-bugs] [Bug 28573] Replace authority record with Z39.50/SRU creates new authority record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 --- Comment #19 from Hayley Pelham --- (In reply to Kyle M Hall from comment #18) > Pushed to 21.05.x for 21.05.05 21.05.06? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 7 21:18:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Nov 2021 20:18:42 +0000 Subject: [Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 7 21:18:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Nov 2021 20:18:50 +0000 Subject: [Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127141|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 127416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127416&action=edit Bug 29381: Prevent sending of automatic renewal messages on every cron run Currently the auto-renewal digest messages are sent on every cron run even if there was nothing to renew or no renewal errors. This regression was introduced in the commit "Bug 18532: Add individual issues to digest notice and hide auto_renewals messaging preference when not needed". To test: 1) set syspref AutoRenewalNotices to be according to patron preferences 2) Enable renewal digest messages on a patron's messaging preferences 3) Checkout a book for patron, during the checkout use the Checkout settings menu to check the box "Automatic renewal" 4) Run $ perl misc/cronjobs/automatic_renewals.pl --send-notices --confirm --digest-per-branch $ perl misc/cronjobs/automatic_renewals.pl --send-notices --confirm --digest-per-branch 5) Notice you have now two renewal messages for the patron 6) Apply patch 7) repeat step 4) and notice you don't get anymore these unnecessary renewal messages Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 7 21:24:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Nov 2021 20:24:18 +0000 Subject: [Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an issue with release notes| |automatic renewal digest | |messages - these were being | |sent on every cron run, | |even if there was nothing | |to renew or no renewal | |errors. | | | |(This error was | |caused by a regression in | |21.05 from Bug 18532: Add | |individual issues to digest | |notice and hide | |auto_renewals messaging | |preference when not | |needed.) CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 7 22:22:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Nov 2021 21:22:03 +0000 Subject: [Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #86 from Arthur Suzuki --- I just checked by git logging into C4/Auth.pm, and reading commits messages, I don't see significant changes nor breaking changes about how permissions works since 20.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 7 22:44:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Nov 2021 21:44:40 +0000 Subject: [Koha-bugs] [Bug 29405] The patron spec for date_renewed is missing it's format definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29405 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 7 22:44:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Nov 2021 21:44:46 +0000 Subject: [Koha-bugs] [Bug 29405] The patron spec for date_renewed is missing it's format definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29405 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127260|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 127417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127417&action=edit Bug 29405: Fix spec This patch just adds the 'date' format string to ensure we are validating the input/output of the date_renewed field correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 7 22:51:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Nov 2021 21:51:50 +0000 Subject: [Koha-bugs] [Bug 29405] The patron spec for date_renewed is missing it's format definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29405 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- This is how I tested using koha-testing-docker - hope this is sufficient! Test plan: 1. Search http://127.0.0.1:8080/api/v1/.html for date_renewed 2. You should find seven occurrences displayed like this (note that other date fields have a line with "format": "date", as part of their definition): "date_renewed": { "description": "date the patron's card was last renewed", "type": [ "string", "null" ] }, 3. Apply the patch. 4. Reload the page in step 1 and search again for date_rendered. The seven occurrences should now include "format": "date", : "date_renewed": { "description": "date the patron's card was last renewed", "format": "date", "type": [ "string", "null" ] }, 5. Sign off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 7 22:55:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Nov 2021 21:55:03 +0000 Subject: [Koha-bugs] [Bug 29405] The patron spec for date_renewed is missing it's format definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29405 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fix adds the date release notes| |format string to the | |date_renewed field. This is | |to ensure that the | |date_renewed field can be | |correctly validated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 00:11:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Nov 2021 23:11:52 +0000 Subject: [Koha-bugs] [Bug 22204] Leading spaces in barcode should not allowed in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22204 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david at davidnind.com --- Comment #14 from David Nind --- Patch no longer applies 8-(... (using koha-testing-docker and 21.05): 126430 - [21.05] Bug 22204: Use barcodedecode in additem.pl Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22204: Use barcodedecode in additem.pl Using index info to reconstruct a base tree... M cataloguing/additem.pl Falling back to patching base and 3-way merge... Auto-merging cataloguing/additem.pl CONFLICT (content): Merge conflict in cataloguing/additem.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 22204: Use barcodedecode in additem.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 06:59:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 05:59:31 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127413|0 |1 is obsolete| | --- Comment #24 from Victor Grousset/tuxayo --- Created attachment 127418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127418&action=edit Bug 29330: Add Koha::Email->new_from_string This patch introduces a new method to Koha::Email. This method allows us to parse a MIME email to initialize the Koha::Email object. This is particularly important when we are restoring emails from the DB. i.e. from the *message_queue* table. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/Email.t => SUCCESS: Tests pass! Koha::Email->new_from_string is the correct counterpart for Koha::Email->as_string! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 06:59:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 05:59:36 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127414|0 |1 is obsolete| | --- Comment #25 from Victor Grousset/tuxayo --- Created attachment 127419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127419&action=edit Bug 29330: Restore handling of serialized MIME messages in message_queue This patch changes how multipart MIME messages are handled on the message_queue table. The email, with the required attachments, is now generated using Koha::Email, and serialized using Koha::Email->as_string. This bug also adds Koha::Email->new_from_string which is used to read that data from the DB, and produce a Koha::Email object, that can be further augmented/modified using regular Koha::Email methods. This implementation should be considered a middle ground, with backportability in mind. higher-level methods should encapsulate setting the default headers and addresses, to clean the area a bit further. Preparation: - You need a valid SMTP configuration in koha-conf.xml. If you use Gmail you can generate an 'app password' and set things like this: smtp.gmail.com 587 5 STARTTLS youraddress at gmail.com youpassword 1 - Set KohaAdminAddress to your address. To test: 1. Pick a patron. Make sure it doesn't have any email address (Acevedo?) 2. Set an overdue notice trigger for its category 3. Check something out, with due date in the past to force an overdue 4. Run: $ kshell k$ misc/cronjobs/overdue_notices.pl -v k$ exit $ koha-mysql kohadev > SELECT * FROM message_queue WHERE borrowernumber=the_borrowernumber; => SUCCESS: A notice has been created 5. Run: $ kshell k$ misc/cronjobs/process_message_queue.pl --verbose => SUCCESS: SMTP is ok => Email is sent => FAIL: Your inbox shows an email with weird content 6. Apply this patches 7. Run: $ koha-mysql kohadev > DELETE FROM message_queue; 8. Repeat 4 and 5 => SUCCESS: You got an email with an attachment! => SUCCESS: The attachment contains an email that couldn't be delivered! 9. Try all the things that enqueue messages :-D => SUCCESS: No behavior change 10. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo «Try all the things that enqueue messages»: I only testes an overdue notice email. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 07:13:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 06:13:07 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #26 from Victor Grousset/tuxayo --- Thanks David, you were faster ^^ As for QA all I can help about is say is that the QA script is happy :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 08:07:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 07:07:36 +0000 Subject: [Koha-bugs] [Bug 28876] No renewal before advisory text not wrapped in selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28876 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- I tested for six of the classes and these all worked as expected: 1. no-renew-hold - Not renewable (on hold) [check out an item with renewals allowed, place an item level hold] 2. no-renew-too-many - Not renewable (too many renwals) [change circulation rules so only one renewal allowed (change 'Renewals allowed (count)' to 1), check out an item, from the patron's account summary in the OPAC select renew and refresh the page] 3. no-renew-unseen - Item must be renewed at the library [set UnseenRenewals to allow, change circulation rules so that Unseen renewals allowed (count) = 1, check out an item, in the OPAC summary renew, message now says 'Item must be renewed at the library.'] 4. no-renew-overdue - Not allowed (overdue) [set OverduesBlockRenewing = block renewing for all the patron's items, check out an item with renewals allowed, make check out date before current date] 5. no-renewal-before - No renewal before [date] [set circulation rules: circulation period = 21 and No renewal before = 20; check out an item, in OPAC renew from summary page] 6. automatic-renewal - Automatic renewal [check out an item with renewals] I wasn't able to figure out how to test for the remaining classes: - no-renew-too-late - No longer renewable - auto-renew-fines - Automatic renewal failed, you have unpaid fines - auto-renew-expired - Automatic renewal failed, your account is expired - no-renew-too-late - No longer renewable Happy to sign off if this is sufficient, otherwise I will leave for someone else who knows how to test the remaining classes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 08:10:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 07:10:57 +0000 Subject: [Koha-bugs] [Bug 29434] New: In UNIMARC instances, the authority finder uses MARC21 relationship codes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434 Bug ID: 29434 Summary: In UNIMARC instances, the authority finder uses MARC21 relationship codes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: a.roussos at dataly.gr QA Contact: testopia at bugs.koha-community.org Background information ---------------------- As per the IFLA UNIMARC Manual for Authorities format [1], the 5-- Functional Block (a.k.a. Related Access Point Block) "contains related authorized access points from which a reference is to be made to see also the access point of the record". To put it simply, this allows for linking authority records with other authority records in order to form, for example, broader/narrower term hierarchies (see sreenshots 1 and 2). Control Subfield $5 ("Relationship Control" in IFLA speak, whereas the UNIMARC Authorities framework in Koha uses the term "Tracing Control") is key to this idea, because it is used to store a single-character value that denotes the type of relationship between the authorities being linked. The actual problem ------------------ When using the authority finder plugin (authorities/auth_finder.pl), you can pick an entry from the 'Special relationship:' dropdown menu in order to set the relationship between authorities. However, in UNIMARC instances the relationship codes listed are those for MARC21 [2] (see screenshots 3 and 4). The correct codes for UNIMARC are listed in pages 93-94 of the IFLA UNIMARC Manual for Authorities. [1] https://repository.ifla.org/handle/123456789/861 [2] https://www.loc.gov/marc/authority/adtracing.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 08:14:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 07:14:38 +0000 Subject: [Koha-bugs] [Bug 29434] In UNIMARC instances, the authority finder uses MARC21 relationship codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434 --- Comment #1 from Andreas Roussos --- Created attachment 127420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127420&action=edit list of sample authorities in the Staff client -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 08:15:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 07:15:23 +0000 Subject: [Koha-bugs] [Bug 29434] In UNIMARC instances, the authority finder uses MARC21 relationship codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434 --- Comment #2 from Andreas Roussos --- Created attachment 127421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127421&action=edit hierarchical view of sample authorities -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 08:16:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 07:16:26 +0000 Subject: [Koha-bugs] [Bug 29434] In UNIMARC instances, the authority finder uses MARC21 relationship codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434 --- Comment #3 from Andreas Roussos --- Created attachment 127422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127422&action=edit relationship codes for MARC21 in the authority finder -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 08:17:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 07:17:04 +0000 Subject: [Koha-bugs] [Bug 29434] In UNIMARC instances, the authority finder uses MARC21 relationship codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434 --- Comment #4 from Andreas Roussos --- Created attachment 127423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127423&action=edit the official source (LoC) of MARC21 relationship codes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 08:18:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 07:18:13 +0000 Subject: [Koha-bugs] [Bug 29434] In UNIMARC instances, the authority finder uses MARC21 relationship codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |a.roussos at dataly.gr |ity.org | URL| |authorities/auth_finder.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 08:22:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 07:22:29 +0000 Subject: [Koha-bugs] [Bug 29434] In UNIMARC instances, the authority finder uses MARC21 relationship codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 08:22:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 07:22:31 +0000 Subject: [Koha-bugs] [Bug 29434] In UNIMARC instances, the authority finder uses MARC21 relationship codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434 --- Comment #5 from Andreas Roussos --- Created attachment 127424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127424&action=edit Bug 29434: add UNIMARC relationship codes for authorities When using the authority finder plugin (authorities/auth_finder.pl), you can pick an entry from the 'Special relationship:' dropdown menu in order to set the relationship between authorities. However, in UNIMARC instances the relationship codes listed are those for MARC21. The correct codes for UNIMARC are listed in pages 93-94 of the IFLA UNIMARC Manual for Authorities. Test plan: 1) In a UNIMARC instance, launch authorities/auth_finder.pl in the Staff client, by clicking on the 'Tag editor' button. Notice how the 'Special relationship:' dropdown menu lists the relationship codes for MARC21 instead of UNIMARC. 2) Apply this patch. 3) Launch the authority finder again; this time the correct values should be listed in the 'Special relationship:' dropdown menu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 09:02:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 08:02:48 +0000 Subject: [Koha-bugs] [Bug 29264] SIP config allows use of non-branchcode institution ids causes workers to die without responding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29264 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 09:02:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 08:02:53 +0000 Subject: [Koha-bugs] [Bug 29264] SIP config allows use of non-branchcode institution ids causes workers to die without responding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29264 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126432|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 127425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127425&action=edit Bug 29264: SIP config allows use of non-branchcode institution ids causes workers to die without responding If is entirely possible to create an SIP institution whose ID does not match a valid branchcode in Koha's SIP config. In fact, Koha's example SIP config contains an example of this ( kohalibrary / kohalibrary2 ). If a SIP login uses an institution with an id that doesn't match a valid branchcode, everything will appear to work, but the SIP worker will die anywhere that Koha gets the branch from the userenv and assumes it is valid. The repercussions of this are that actions such as the checkout message simply die and do not return a response message to the requestor. At the very least, we should output a warning to the SIP log. I think we should strongly consider disallowing institution ids in the SIP config that do not match valid branchcodes. In this scenario, attempting to start the SIP server should result in a error message with the SIP server exiting immediately. Test Plan: 1) Apply this patch 2) Make a sip login that uses an instution whose id is *not* a valid branchcode 3) Start the SIP server 4) Check sip.log, you should see a warning similar to the following: [2021/10/18 12:18:29] [2068079] [ERROR] ERROR: Institution kohalibrary does does not match a branchcode. This can cause unexpected behavior. C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 09:10:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 08:10:15 +0000 Subject: [Koha-bugs] [Bug 29264] SIP config allows use of non-branchcode institution ids causes workers to die without responding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29264 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Test notes: - koha-testing-docker has institutions already setup that have invalid branch codes (see /etc/koha/sites/kohadev/SIPconfig.xml - MAIN, kohalibrary and kohalibrary2). - Before the patch is applied there are no errors in /var/log/koha/kohadev/sip.log after restarting everything (or koha-sip --stop kohadev and koha-sip --start kohadev) - After the patch is applied and everything restarted, the error messages as per step 4 of the test plan appear in the sip log file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 09:26:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 08:26:43 +0000 Subject: [Koha-bugs] [Bug 29435] New: The OPAC authority details page is broken when AuthDisplayHierarchy is enabled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29435 Bug ID: 29435 Summary: The OPAC authority details page is broken when AuthDisplayHierarchy is enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: a.roussos at dataly.gr QA Contact: testopia at bugs.koha-community.org When the 'AuthDisplayHierarchy' System Preference is set to 'Enable', the OPAC authority details page is broken and the following message appears in the logs: Undefined subroutine GenerateHierarchy called at opac-authoritiesdetail.pl line 83 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 09:27:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 08:27:08 +0000 Subject: [Koha-bugs] [Bug 29435] The OPAC authority details page is broken when AuthDisplayHierarchy is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29435 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |a.roussos at dataly.gr |ity.org | URL| |opac/opac-authoritiesdetail | |.pl Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 09:35:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 08:35:16 +0000 Subject: [Koha-bugs] [Bug 29435] The OPAC authority details page is broken when AuthDisplayHierarchy is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29435 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 09:35:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 08:35:18 +0000 Subject: [Koha-bugs] [Bug 29435] The OPAC authority details page is broken when AuthDisplayHierarchy is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29435 --- Comment #1 from Andreas Roussos --- Created attachment 127426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127426&action=edit Bug 29435: include missing subroutine from C4::AuthoritiesMarc The OPAC authority details page is broken when the 'AuthDisplayHierarchy' System Preference is set to 'Enable', This patch fixes that. Test plan: 1) Set AuthDisplayHierarchy to 'Enable' and try to view the details page of an authority in the OPAC -- the page is broken. 2) Apply this patch. 3) Refresh the page; this time the authority details are displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 09:52:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 08:52:34 +0000 Subject: [Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127402|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 127427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127427&action=edit Bug 29427: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 09:52:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 08:52:38 +0000 Subject: [Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127403|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 127428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127428&action=edit Bug 29427: Make SMTP transport set debug mode correctly This patch makes the _transport_ method in Koha::SMTP::Server pass the debug flag correctly to the Email::Sender::Transport::SMTP->new constructor. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/SMTP/Server.t => FAIL: Oh noes! debug is not passed to the constructor! 3. Apply this patch 4. Repeat 2 => SUCCESS: Hey! It is being set! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 09:53:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 08:53:15 +0000 Subject: [Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize --- Trivial fix, works as expected.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 09:53:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 08:53:21 +0000 Subject: [Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 10:10:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 09:10:38 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127418|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize --- Created attachment 127429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127429&action=edit Bug 29330: Add Koha::Email->new_from_string This patch introduces a new method to Koha::Email. This method allows us to parse a MIME email to initialize the Koha::Email object. This is particularly important when we are restoring emails from the DB. i.e. from the *message_queue* table. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/Email.t => SUCCESS: Tests pass! Koha::Email->new_from_string is the correct counterpart for Koha::Email->as_string! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 10:10:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 09:10:42 +0000 Subject: [Koha-bugs] [Bug 28926] Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate CC| |fridolin.somers at biblibre.co | |m, | |nick at bywatersolutions.com, | |victor at tuxayo.net, | |wainuiwitikapark at catalyst.n | |et.nz --- Comment #8 from Jonathan Druart --- (In reply to Mason James from comment #7) > (In reply to Jonathan Druart from comment #5) > > Pushed to master for 21.11, thanks to everybody involved! > > hi, can we get this can be backported thru to 19.11? CCing RMaints for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 10:10:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 09:10:43 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127419|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize --- Created attachment 127430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127430&action=edit Bug 29330: Restore handling of serialized MIME messages in message_queue This patch changes how multipart MIME messages are handled on the message_queue table. The email, with the required attachments, is now generated using Koha::Email, and serialized using Koha::Email->as_string. This bug also adds Koha::Email->new_from_string which is used to read that data from the DB, and produce a Koha::Email object, that can be further augmented/modified using regular Koha::Email methods. This implementation should be considered a middle ground, with backportability in mind. higher-level methods should encapsulate setting the default headers and addresses, to clean the area a bit further. Preparation: - You need a valid SMTP configuration in koha-conf.xml. If you use Gmail you can generate an 'app password' and set things like this: smtp.gmail.com 587 5 STARTTLS youraddress at gmail.com youpassword 1 - Set KohaAdminAddress to your address. To test: 1. Pick a patron. Make sure it doesn't have any email address (Acevedo?) 2. Set an overdue notice trigger for its category 3. Check something out, with due date in the past to force an overdue 4. Run: $ kshell k$ misc/cronjobs/overdue_notices.pl -v k$ exit $ koha-mysql kohadev > SELECT * FROM message_queue WHERE borrowernumber=the_borrowernumber; => SUCCESS: A notice has been created 5. Run: $ kshell k$ misc/cronjobs/process_message_queue.pl --verbose => SUCCESS: SMTP is ok => Email is sent => FAIL: Your inbox shows an email with weird content 6. Apply this patches 7. Run: $ koha-mysql kohadev > DELETE FROM message_queue; 8. Repeat 4 and 5 => SUCCESS: You got an email with an attachment! => SUCCESS: The attachment contains an email that couldn't be delivered! 9. Try all the things that enqueue messages :-D => SUCCESS: No behavior change 10. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 10:10:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 09:10:49 +0000 Subject: [Koha-bugs] [Bug 28926] Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 10:10:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 09:10:56 +0000 Subject: [Koha-bugs] [Bug 28926] Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 10:11:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 09:11:03 +0000 Subject: [Koha-bugs] [Bug 28926] Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 10:11:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 09:11:10 +0000 Subject: [Koha-bugs] [Bug 28926] Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 10:16:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 09:16:15 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #29 from Martin Renvoize --- Testing yields positive results in all cases I tried.. QA scripts is happy. That's some somewhat fnky looking code here, but I understand it's in aide of backports.. we can clean up during the next cycle I think. The only bit that raised slight alarm bells.. but that's only because my email understanding isn't at 'expert god level' is the internal content type of the attachments being hardcoded to `application/octet-stream`.. in all my testing I couldn't find a problem with that.. but I don't understand it either so would love a comment from Tomas explaining? Passing QA anyway as this does indeed fix the issues as described and doesn't raise and real red flags. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 10:23:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 09:23:36 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 10:23:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 09:23:40 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 --- Comment #4 from Jonathan Druart --- Created attachment 127431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127431&action=edit Bug 29387: Strinfigy exceptions for other background job modules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 10:30:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 09:30:24 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #21 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #20) > (In reply to Jonathan Druart from comment #19) > > (In reply to Marcel de Rooy from comment #18) > > > Still nice to have in 21.11 ? > > > > I would prefer to not rush it and wait for 22.05 > > Could you please tell me what is the fundamental difference with the patches > on bug 29386, that got pushed today ? Bug 29386 fixes a critical bug that must be backported into stable branches ASAP. This one should be pushed along with bug 29390 in my opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 10:48:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 09:48:19 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127312|0 |1 is obsolete| | --- Comment #82 from David Nind --- Created attachment 127432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127432&action=edit Bug 27631: (follow-up) Some minor corrections This patch makes some corrections to issues found during testing: Some duplicate headings, a markup error in labeledMARCdetail.tt, a change of the transfers heading from "Branch transfers" to "Item transfers." This patch also undoes the changes to the position of the toolbar on several pages. I think those changes don't belong in this bug. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 10:59:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 09:59:56 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #83 from David Nind --- Created attachment 127433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127433&action=edit Bug 27631 - Koha header - logo + main actions and search display I have only reviewed and signed off Owen's minor corrections patch. I reviewed the patch and accessed pages I could to checked that they displayed correctly. Layout change - I'm assuming that the change where the Koha logo is displayed on its own and then the main search box (check out, check in, renew, search the catalog etc) directly under this is intentional, and will be fixed later. Screenshot attached of what I mean. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 11:00:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 10:00:23 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 11:17:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 10:17:58 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #15 from Jonathan Druart --- "Suspend until" is not saved. + var suspend_until_date = $("#suspend-modal-until").datepicker("getDate"); We are not using flatpickr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 11:18:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 10:18:28 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #16 from Jonathan Druart --- + if (jqXHR.status === 404) { What about other errors? We shouldn't ignore them IMO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 11:34:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 10:34:12 +0000 Subject: [Koha-bugs] [Bug 24224] Convert OpacNavBottom system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Jonathan Druart --- (In reply to Martin Renvoize from comment #4) > This looks great.. signing off. > > One query.. > > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt > > That adds OpacNav too here.. shouldn't that have been caught in the > dependency bug already? Yes, line will be moved on push. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 11:52:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 10:52:18 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127367|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 127434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127434&action=edit Bug 28374: Convert printreceipt to use GetPreparedLetter This patch converts the point of sale receipt printer controller to using GetPreparedLetter instead of calling getletter directly. Test plan 1. Setup for testing: i. Enable EnablePointOfSale and UseCashRegisters system preferences ii. Add a new cash register (Administration > Accounting > Cash registers) iii. Add one or two products for sale (Administration > Accounting > Debit types, make sure 'Can be sold?' is ticked) 2. Go to Home > Point of sale 3. Add some items for purchase to a sale 4. Click confirm 5. Click on 'Print receipt' and save the PDF file somewhere 6. Apply patches 7. Update database: updatedatabase 8. Repeat steps 2-5 9. Compare receipt PDFs - should be no changes 10. Check that the default RECEIPT is updated - for print, HTML should be ticked 11. Sign off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 11:52:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 10:52:21 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127368|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 127435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127435&action=edit Bug 28374: Update existing notices This patch updates the default slip to include KohaDates, Branches and Price plugins as required and prepends the same to existing notices at upgrade time. We also, switch the HTML flag on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 11:52:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 10:52:42 +0000 Subject: [Koha-bugs] [Bug 29404] Add infinite scrolling to pickup location dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 --- Comment #6 from Jonathan Druart --- Hard call, really. It can be considered an enhancement for libraries with hundreds of branches, but for those with very few? You have to wait 1 sec for the result every time you interact with the dropdown, it would be immediate if the filtering is done by JS locally. I can imagine easily it could become unusable if the server is a bit overloaded (and this will help the server to become even more overloaded...) I am willing to push it for 21.11 in order to get feedback from end users, but we should be ready to revert this behaviour if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 11:54:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 10:54:06 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #11 from Martin Renvoize --- Thankyou so much for testing David!.. I'm quite embarrassed I got so much wrong in that first submission.. it seems my local notices are all significantly ahead of this patch set. I've uploaded a fresh set of patches.. they should work for new installs and installs with an existing notice that closely resembles the original one installed. Many thanks again, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 11:56:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 10:56:17 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #30 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #29) > The only bit that raised slight alarm bells.. but that's only because my > email understanding isn't at 'expert god level' is the internal content type > of the attachments being hardcoded to `application/octet-stream`.. in all my > testing I couldn't find a problem with that.. but I don't understand it > either so would love a comment from Tomas explaining? Good catch, Martin. I'll post a follow-up patch for that. application/octet-stream is the fallback in Email::Stuffer when it cannot make a better guess on the content. I overlooked it because the email clients I tested didn't care about that and displayed things correctly. But we should explicitly pass text/plain. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:02:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:02:03 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Keywords| |rel_22_05_candidate --- Comment #38 from Jonathan Druart --- As bug 15157 is not ready for 21.11 it does not make sense to have this one part of 21.11. Postponed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:06:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:06:49 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate --- Comment #42 from Jonathan Druart --- I am sorry, this one missed 21.11 (because of me, last week was crazy). There are too many changes in a controller with fragile code, I am not confident with doing an exception with these patches. Postponed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:09:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:09:42 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate --- Comment #65 from Jonathan Druart --- I am very sorry but I am not confident in pushing this for 21.11. Also sorry to have been so slow to provide you feedback. I think it should get more eyes from the QA team. Postponed and letting the next RM decide. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:11:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:11:23 +0000 Subject: [Koha-bugs] [Bug 29429] Cannot close budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29429 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #4 from Jonathan Druart --- Florian, please have a look at this wiki page https://wiki.koha-community.org/wiki/Commit_messages The commit message is often different from the bug title. Your commit message must describe what your patch does, when the bug report title is describing the problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:11:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:11:36 +0000 Subject: [Koha-bugs] [Bug 29429] Cannot close budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29429 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |florian.bontemps at biblibre.c |ity.org |om -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:12:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:12:53 +0000 Subject: [Koha-bugs] [Bug 29303] quick add form duplicates HTML ID's In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29303 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 127436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127436&action=edit Bug 29330: (QA follow-up) Use passed MIME type Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:14:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:14:15 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #31 from Tomás Cohen Arazi --- Created attachment 127437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127437&action=edit Bug 29330: (QA follow-up) Use passed MIME type Signed-off-by: Tomas Cohen Arazi https://bugs.koha-community.org/show_bug.cgi?id=29303 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:14:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:14:48 +0000 Subject: [Koha-bugs] [Bug 29303] quick add form duplicates HTML ID's In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29303 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:14:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:14:50 +0000 Subject: [Koha-bugs] [Bug 29303] quick add form duplicates HTML ID's In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29303 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127436|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:17:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:17:39 +0000 Subject: [Koha-bugs] [Bug 29429] Cannot close budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29429 --- Comment #5 from Florian --- (In reply to Jonathan Druart from comment #4) > Florian, please have a look at this wiki page > https://wiki.koha-community.org/wiki/Commit_messages > The commit message is often different from the bug title. Your commit > message must describe what your patch does, when the bug report title is > describing the problem. Ah, thank you Jonathan. Very new to Koha and Bugzilla here, I'll work on my mistakes! :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:19:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:19:23 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:19:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:19:26 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #93 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:19:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:19:29 +0000 Subject: [Koha-bugs] [Bug 24224] Convert OpacNavBottom system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:19:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:19:31 +0000 Subject: [Koha-bugs] [Bug 24224] Convert OpacNavBottom system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:19:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:19:34 +0000 Subject: [Koha-bugs] [Bug 29195] Highlighting broken on odd rows in circ-patron-search-results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29195 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:19:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:19:37 +0000 Subject: [Koha-bugs] [Bug 29195] Highlighting broken on odd rows in circ-patron-search-results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29195 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:19:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:19:39 +0000 Subject: [Koha-bugs] [Bug 29404] Add infinite scrolling to pickup location dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:19:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:19:42 +0000 Subject: [Koha-bugs] [Bug 29404] Add infinite scrolling to pickup location dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:19:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:19:44 +0000 Subject: [Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:19:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:19:47 +0000 Subject: [Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:19:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:19:49 +0000 Subject: [Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:19:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:19:52 +0000 Subject: [Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:19:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:19:55 +0000 Subject: [Koha-bugs] [Bug 29429] Cannot close budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29429 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:19:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:19:57 +0000 Subject: [Koha-bugs] [Bug 29429] Cannot close budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29429 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:20:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:20:00 +0000 Subject: [Koha-bugs] [Bug 29430] Table cell click doesn't activate buttons in patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29430 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:20:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:20:02 +0000 Subject: [Koha-bugs] [Bug 29430] Table cell click doesn't activate buttons in patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29430 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:20:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:20:19 +0000 Subject: [Koha-bugs] [Bug 29429] Cannot close budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29429 --- Comment #7 from Jonathan Druart --- Congratulations, Florian, for your first patch pushed! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:34:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:34:23 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:34:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:34:28 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127434|0 |1 is obsolete| | --- Comment #12 from David Nind --- Created attachment 127438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127438&action=edit Bug 28374: Convert printreceipt to use GetPreparedLetter This patch converts the point of sale receipt printer controller to using GetPreparedLetter instead of calling getletter directly. Test plan 1. Setup for testing: i. Enable EnablePointOfSale and UseCashRegisters system preferences ii. Add a new cash register (Administration > Accounting > Cash registers) iii. Add one or two products for sale (Administration > Accounting > Debit types, make sure 'Can be sold?' is ticked) 2. Go to Home > Point of sale 3. Add some items for purchase to a sale 4. Click confirm 5. Click on 'Print receipt' and save the PDF file somewhere 6. Apply patches 7. Update database: updatedatabase 8. Repeat steps 2-5 9. Compare receipt PDFs - should be no changes 10. Check that the default RECEIPT is updated - for print, HTML should be ticked 11. Sign off! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:34:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:34:33 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127435|0 |1 is obsolete| | --- Comment #13 from David Nind --- Created attachment 127439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127439&action=edit Bug 28374: Update existing notices This patch updates the default slip to include KohaDates, Branches and Price plugins as required and prepends the same to existing notices at upgrade time. We also, switch the HTML flag on. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:48:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:48:34 +0000 Subject: [Koha-bugs] [Bug 29435] The OPAC authority details page is broken when AuthDisplayHierarchy is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29435 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 12:48:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 11:48:38 +0000 Subject: [Koha-bugs] [Bug 29435] The OPAC authority details page is broken when AuthDisplayHierarchy is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29435 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127426|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 127440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127440&action=edit Bug 29435: include missing subroutine from C4::AuthoritiesMarc The OPAC authority details page is broken when the 'AuthDisplayHierarchy' System Preference is set to 'Enable', This patch fixes that. Test plan: 1) Set AuthDisplayHierarchy to 'Enable' and try to view the details page of an authority in the OPAC -- the page is broken. 2) Apply this patch. 3) Refresh the page; this time the authority details are displayed. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 13:00:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 12:00:50 +0000 Subject: [Koha-bugs] [Bug 29168] Only show "Request article" if allowed on the detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127175|0 |1 is obsolete| | --- Comment #17 from Tomás Cohen Arazi --- Created attachment 127441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127441&action=edit Bug 29168: Only show 'Request article' if allowed on the detail view This patch adds a check for the patron being able to place the request, in the case of logged in patron. The anonymous patron will still be displayed the link, and redirected to the login page as required. To test: 1. Set the article request limit to 1 2. Place a request on behalf of a known patron 3. With the patron session, in the OPAC, try to place a new article request from the detail page => SUCCESS: There's no link 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 13:01:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 12:01:40 +0000 Subject: [Koha-bugs] [Bug 29168] Only show "Request article" if allowed on the detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 13:02:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 12:02:05 +0000 Subject: [Koha-bugs] [Bug 29204] Error 500 when execute Circulation report with date period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29204 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127409|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 127442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127442&action=edit Bug 29204: Fix reports/issues_stats.pl for MySQL 8 Error was: Incorrect DATETIME value: '' Test plan Go to Reports -> Circulation On Period select "Row" or "Column" and choose a date Submit Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 13:02:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 12:02:08 +0000 Subject: [Koha-bugs] [Bug 29204] Error 500 when execute Circulation report with date period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29204 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127410|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 127443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127443&action=edit Bug 29204: (QA follow-up) Fix variable name The patch "Bug 29204: Fix reports/issues_stats.pl for MySQL 8" accidentally changed the variable name from $strsth2 to $strsth Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 13:02:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 12:02:35 +0000 Subject: [Koha-bugs] [Bug 29204] Error 500 when execute Circulation report with date period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29204 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #13 from Martin Renvoize --- Nice simple fix.. all works as expected. PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 13:09:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 12:09:56 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127437|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize --- Created attachment 127444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127444&action=edit Bug 29330: (QA follow-up) Use passed MIME type Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 13:10:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 12:10:35 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #33 from Martin Renvoize --- Thanks for the explanation and follow-up.. adding my QA stamp to the final patch :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 13:15:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 12:15:17 +0000 Subject: [Koha-bugs] [Bug 29405] The patron spec for date_renewed is missing it's format definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29405 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 13:15:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 12:15:23 +0000 Subject: [Koha-bugs] [Bug 29405] The patron spec for date_renewed is missing it's format definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29405 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 127445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127445&action=edit Bug 29405: Fix date_renewed attribute format in patron spec This patch just adds the 'date' format string to ensure we are validating the input/output of the date_renewed field correctly. Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 13:17:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 12:17:19 +0000 Subject: [Koha-bugs] [Bug 29405] The patron spec for date_renewed is missing it's format definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29405 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 13:17:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 12:17:21 +0000 Subject: [Koha-bugs] [Bug 29405] The patron spec for date_renewed is missing it's format definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29405 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127417|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 13:19:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 12:19:44 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 --- Comment #19 from Martin Renvoize --- Created attachment 127446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127446&action=edit Bug 28692: Get from storage before log actions To make sure we have logging the values from DB. It will reduce DB action_log table size when we log the full object and it contains DateTime object. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 13:20:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 12:20:02 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127289|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 13:21:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 12:21:05 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #20 from Martin Renvoize --- Great, this is a good first step and enough at this late stage in the cycle for the next release in my opinion. I'd have been tempted to drop the 'item' prepension, but that would lead to questions like "Should we run a DB update to fix existing cases" Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 13:39:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 12:39:17 +0000 Subject: [Koha-bugs] [Bug 28416] Email::Sender::Transport::SMTP is using 10Mo of RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28416 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #4 from Tomás Cohen Arazi --- (In reply to David Cook from comment #3) > This one is probably especially good to do, since it looks like transport() > is often called within a try/catch block anyway. I agree with this assertion. I'd add that we probably don't want this lib loaded on user facing places, as we are leaning towards using the message_queue more often than we do now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 13:39:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 12:39:58 +0000 Subject: [Koha-bugs] [Bug 29183] Add query options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29183 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 13:46:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 12:46:07 +0000 Subject: [Koha-bugs] [Bug 29183] Add query options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29183 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 13:46:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 12:46:11 +0000 Subject: [Koha-bugs] [Bug 29183] Add query options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29183 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126176|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi --- Created attachment 127447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127447&action=edit Bug 29183: Add some documentation around query filtering Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 13:46:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 12:46:15 +0000 Subject: [Koha-bugs] [Bug 29183] Add query options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29183 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 127448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127448&action=edit Bug 29183: (follow-up) Add x-koha-query option Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 13:58:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 12:58:13 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |tomascohen at gmail.com --- Comment #41 from Tomás Cohen Arazi --- Nice work! Please re-do/rebase some of those. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 13:58:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 12:58:32 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 13:58:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 12:58:37 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #84 from Owen Leonard --- Created attachment 127449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127449&action=edit Bug 27631: (follow-up) Modify logo CSS to give better alignment This patch modifies the CSS of the Koha logo and its container so that it more closely matches the previous version and so that alignment is handled better at various browser widths. To test, apply the patch and build the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Check various pages in the staff interface to confirm that the position of the Koha logo is correct. Adjust your browser width to confirm that the alignment adapts at narrow widths. Test also on pages where the header search form can be expanded, e.g. Patrons -> [+] to expand search options. Or Acquisitions -> Orders search -> [+]. Confirm that logo alignment is correct on these pages too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 13:58:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 12:58:52 +0000 Subject: [Koha-bugs] [Bug 29183] Add query options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29183 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 13:59:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 12:59:55 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #85 from Owen Leonard --- (In reply to David Nind from comment #83) > Layout change - I'm assuming that the change where the Koha logo is > displayed on its own and then the main search box (check out, check in, > renew, search the catalog etc) directly under this is intentional Your screenshot shows the layout when the CSS hasn't been rebuilt, but it helped me notice that the alignment is still a little off even after rebuilding. My follow-up should make it better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 14:05:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 13:05:48 +0000 Subject: [Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 --- Comment #6 from Tomás Cohen Arazi --- When dealing with an 'item' object it is legit to set item_type to null. Returning the effective (calculated if absent on the item) item type might confuse the consumer to think it has an item_type set. I'd prefer we add the option to embed the effective item_type like in: x-koha-embed: effective_item_type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 14:34:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 13:34:45 +0000 Subject: [Koha-bugs] [Bug 29395] Use EXPORT_OK in Koha::Patron::Debarments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 14:35:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 13:35:31 +0000 Subject: [Koha-bugs] [Bug 28022] MARC subfield 9 not honoring visibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28022 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 14:36:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 13:36:13 +0000 Subject: [Koha-bugs] [Bug 28636] t:lib::Mocks is missing POD In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28636 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 14:36:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 13:36:49 +0000 Subject: [Koha-bugs] [Bug 28898] Context for translation: term (word) vs. term (semester) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 14:39:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 13:39:38 +0000 Subject: [Koha-bugs] [Bug 29369] Use Flatpickr in dateaccessioned cataloging plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29369 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org CC| |gmcharlt at gmail.com, | |jonathan.druart+koha at gmail. | |com Component|OPAC |Staff Client -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 14:39:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 13:39:59 +0000 Subject: [Koha-bugs] [Bug 28376] Flatpickr introduction for datetime picker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org Component|Templates |Staff Client -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 14:40:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 13:40:34 +0000 Subject: [Koha-bugs] [Bug 28376] Flatpickr introduction for datetime picker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff Client |Templates Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 14:41:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 13:41:10 +0000 Subject: [Koha-bugs] [Bug 29270] Use flatpickr and futuredate on reserve/request.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29270 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff Client |Templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 14:44:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 13:44:57 +0000 Subject: [Koha-bugs] [Bug 29183] Add query options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29183 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Text to go in the| |This patch adds release notes| |documentation of the | |different filtering methods | |the REST API provides. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 15:12:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 14:12:50 +0000 Subject: [Koha-bugs] [Bug 29183] Add query options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29183 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 15:12:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 14:12:54 +0000 Subject: [Koha-bugs] [Bug 29183] Add query options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29183 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127447|0 |1 is obsolete| | Attachment #127448|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 127450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127450&action=edit Bug 29183: Add some documentation around query filtering Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 15:13:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 14:13:06 +0000 Subject: [Koha-bugs] [Bug 29183] Add query options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29183 --- Comment #6 from Kyle M Hall --- Created attachment 127451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127451&action=edit Bug 29183: (follow-up) Add x-koha-query option Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 15:16:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 14:16:44 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 --- Comment #7 from Alex Arnaud --- Created attachment 127452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127452&action=edit Bug 29393 - Use patron language in letters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 15:37:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 14:37:32 +0000 Subject: [Koha-bugs] [Bug 28360] Link to make article reqests should display on detail page when user is not logged in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28360 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |tomascohen at gmail.com --- Comment #3 from Tomás Cohen Arazi --- *** This bug has been marked as a duplicate of bug 29168 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 15:37:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 14:37:32 +0000 Subject: [Koha-bugs] [Bug 29168] Only show "Request article" if allowed on the detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #18 from Tomás Cohen Arazi --- *** Bug 28360 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 15:49:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 14:49:17 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #12 from Koha Team University Lyon 3 --- Hi, I haven't tested it yet because I'm still fighting with my kohadevbox. But, in theory, It's a pity to store NULL value in pseudonymized_transactions instead of a value that gives us the information the it's a renew done on the OPAC. It's not possible to store the same value that the one in the statistics table? Sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 16:33:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 15:33:52 +0000 Subject: [Koha-bugs] [Bug 29436] New: Cannot reorder facets in staff interface elasticsearch configuration Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 Bug ID: 29436 Summary: Cannot reorder facets in staff interface elasticsearch configuration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com On master: Move author to bottom of list, click save "An error occurred when updating mappings: . " On 21.05 we are seeing that nothing happens when clicking the 'Save' button -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 16:48:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 15:48:44 +0000 Subject: [Koha-bugs] [Bug 27613] Pipe separated online resource links are hard to customize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116328|0 |1 is obsolete| | Attachment #125742|0 |1 is obsolete| | --- Comment #9 from Owen Leonard --- Created attachment 127453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127453&action=edit Bug 27613: Change pipe seperated online resource links to psuedo elements To test: 1. Have a record with many 856 links 2. Look at the links on both the results and detail pages. 3. Look at the '|' and notice it is outside any HTML element, making it hard to remove. 4. Apply the patch and regenerate the CSS 5. Look at both the pages again and notice that the '|' is now a psuedo element. 6. It should look identical to the way it did without the patch 7. Switch the system pref OPACURLOpenInNewWindow to 'do' and make sure the the links look and function right still. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 16:48:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 15:48:48 +0000 Subject: [Koha-bugs] [Bug 27613] Pipe separated online resource links are hard to customize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 --- Comment #10 from Owen Leonard --- Created attachment 127454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127454&action=edit Bug 27613: (follow-up) Modify additional repeating entries for consistency This patch makes further changes to the detail and results XSLT in the OPAC so that previously pipe-separated fields are styled with CSS. The following tags are modified on the detail page: 020 ISBN 022 ISSN 050 LOC classification 060 NLM classification 082 DDC classification 084 Other classification 130/240/730 Uniform titles 246 Other title 336 Content type 337 Media type 338 Carrier type 385 Audience 508 Production credits 583 Action note 586 Awards 655 Genre/Form 700/710/711 Contained works 700/710/711 Related works 770 Supplement 772 Supplement to 856 Online resources These are modified on the results page: 028 Publisher number 246 Other title To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). In order to better see the effect of the CSS change you can add something ike this to your OPACUserCSS system preference: .resource_list li::after { content: "♦"; } View catalog search results and detail pages for records which contain repeated entries from the tag list above. The entries should be separated by "|" without customization, or the symbol from your OPACUserCSS if you specified one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 16:51:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 15:51:36 +0000 Subject: [Koha-bugs] [Bug 24512] Should be able to have 'hidden'/'administrative' branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24512 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |hc at interleaf.ie Resolution|--- |DUPLICATE --- Comment #1 from Holly --- *** This bug has been marked as a duplicate of bug 10567 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 16:51:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 15:51:36 +0000 Subject: [Koha-bugs] [Bug 10567] Ability to add a hidden/suppressed library branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10567 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #3 from Holly --- *** Bug 24512 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 16:54:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 15:54:48 +0000 Subject: [Koha-bugs] [Bug 27627] Fix invalid HTML in OPAC results XSLT: change spans to divs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 16:54:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 15:54:52 +0000 Subject: [Koha-bugs] [Bug 27627] Fix invalid HTML in OPAC results XSLT: change spans to divs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116332|0 |1 is obsolete| | Attachment #116334|0 |1 is obsolete| | Attachment #116438|0 |1 is obsolete| | --- Comment #9 from Owen Leonard --- Created attachment 127455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127455&action=edit Bug 27627: Fix invalid HTMl in OPAC results XSLT: change spans to divs This patch modifies the XSL template for OPAC search results in order to improve HTML validation: Changing some s to
    s will prevent an error when those s contain block-level elements. To test, apply the patch and restart_all if necessary. - Confirm that OPACXSLTResultsDisplay is set to "default" - Perform a catalog search in the OPAC. - Validate the page source and confirm that there are no errors about "Element ul not allowed as child of element span in this context" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 16:54:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 15:54:52 +0000 Subject: [Koha-bugs] [Bug 27067] Add option to hide branch from opac-library page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27067 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |hc at interleaf.ie --- Comment #2 from Holly --- *** This bug has been marked as a duplicate of bug 26834 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 16:54:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 15:54:52 +0000 Subject: [Koha-bugs] [Bug 26834] Hiding Branches from the Libraries Link on the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26834 --- Comment #2 from Holly --- *** Bug 27067 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 17:59:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 16:59:49 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127449|0 |1 is obsolete| | --- Comment #86 from David Nind --- Created attachment 127456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127456&action=edit Bug 27631: (follow-up) Modify logo CSS to give better alignment This patch modifies the CSS of the Koha logo and its container so that it more closely matches the previous version and so that alignment is handled better at various browser widths. To test, apply the patch and build the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Check various pages in the staff interface to confirm that the position of the Koha logo is correct. Adjust your browser width to confirm that the alignment adapts at narrow widths. Test also on pages where the header search form can be expanded, e.g. Patrons -> [+] to expand search options. Or Acquisitions -> Orders search -> [+]. Confirm that logo alignment is correct on these pages too. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 18:11:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 17:11:03 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #87 from David Nind --- (In reply to Owen Leonard from comment #85) > Your screenshot shows the layout when the CSS hasn't been rebuilt, but it > helped me notice that the alignment is still a little off even after > rebuilding. My follow-up should make it better. Thanks Owen - I didn't think about rebuilding the CSS! The only thing I noticed is that as it is now centered, when the screen becomes too narrow the left side of the block with the search box, submit button are off the screen, rather than left aligned as it is currently - but there are always tradeoffs, and would be unusable at this size anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 18:16:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 17:16:21 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement, as part release notes| |of improving the | |accessibility of the staff | |interface, makes the main | |topic/title of the page the | |

    rather than the logo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 18:17:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 17:17:08 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

    on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Accessibility: Staff Client |Accessibility: Staff |-

    on each page is Logo |interface -

    on each |but should be page |page is Logo but should be |description/title |page description/title -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 18:43:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 17:43:01 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 18:43:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 17:43:04 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 --- Comment #5 from Owen Leonard --- Created attachment 127457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127457&action=edit Bug 26296: (follow-up) Make sure title remains mandatory This patch adds a flag to the OPAC preferences file marking suggestion title as mandatory OPACSuggestionMandatoryFields and excluded from OPACSuggestionUnwantedFields. The patch also modifies the markup around required fields in the OPAC suggestion form to comply with changes made in Bug 27668 to mandatory field styling. To test, apply the patch and restart services. - Test the OPACSuggestionMandatoryFields preference. In the modal, "title" should be checked and the label in red. It should not be possible to uncheck the checkbox. - Test that the "Select all" and "Clear all" links don't affect the "title" checkbox. - Confirm that your selections are still saved correctly. - Test the OPACSuggestionUnwantedFields preference. In the modal, "title" should be unchecked and disabled. - Test that the "Select all" and "Clear all" links don't affect the "title" checkbox. - Confirm that your selections are saved correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 18:50:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 17:50:02 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Nathan Walker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nathan.walker at citruslibrari | |es.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 19:20:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 18:20:33 +0000 Subject: [Koha-bugs] [Bug 25387] Avoid merge different type of authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25387 --- Comment #11 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #10) > (In reply to Katrin Fischer from comment #9) > > Could it be an option to only allow merging when the 'losing' record is > > unused? In this case there would be no data loss and a warning would not be > > necessary. > > I dont think so. Manual relinking wont be fun. Not sure if we understood each other. What I mean it merging an authority record that is not linked (used) in any bibliographic record. So no relinking would be necessary. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 19:24:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 18:24:46 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 19:24:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 18:24:49 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123504|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 19:24:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 18:24:52 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123505|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 19:24:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 18:24:55 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123506|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 19:24:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 18:24:58 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123507|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 19:25:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 18:25:02 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123503|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 19:47:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 18:47:59 +0000 Subject: [Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 19:52:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 18:52:11 +0000 Subject: [Koha-bugs] [Bug 29303] Quick add form duplicates HTML ID's In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29303 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|quick add form duplicates |Quick add form duplicates |HTML ID's |HTML ID's -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 20:24:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 19:24:14 +0000 Subject: [Koha-bugs] [Bug 29437] New: 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 Bug ID: 29437 Summary: 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When performing a cataloging search we take the query and test to see if it is a valid isbn: If not, we perform a SQL search for the term as author or title If so, we pass it to BreedingSearch as an ISBN - we then normailize it to ISBN 10 - then perform aSQL search for ISBN In the ISBN case, if it cannot be converted to a 10 digit ISBN we nullify the term - the SQL then has no where statement and fails in plack-error.log: C4::Breeding::BreedingSearch(): DBI Exception: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '' at line 5 at /kohadevbox/koha/cataloguing/addbooks.pl line 117 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 20:31:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 19:31:37 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 20:31:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 19:31:41 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 --- Comment #1 from Nick Clemens --- Created attachment 127458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127458&action=edit Bug 29437: Search reservoir for term as title, author, or variations of ISBN The code in the script and the module attempt to determine whether a term is an isbn, or not. Rather than try to do this, we can simply search it on the three fields: isbn, title, author Additionally, we should search as any of the ISBN variations to broaden our matches Note: Curently only an ISBN 10 is stored in import biblios, so for an ISBN13 that doesn't convert the value will be blank - this is another bug To test: 1 - Perform a cataloging search for a valid ISBN 13 with no ISBN10 counterpart: 9798200834976 2 - 500 error 3 - Apply patch 4 - Repeat, no results 5 - Import some records 6 - Search by title/author/isbn 7 - Confirm searching works as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 20:32:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 19:32:17 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Depends on| |29319 --- Comment #2 from Nick Clemens --- Needs unit tests for QA, but can be tested Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29319 [Bug 29319] Errors when doing a cataloging search which starts with a number + letter -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 20:32:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 19:32:17 +0000 Subject: [Koha-bugs] [Bug 29319] Errors when doing a cataloging search which starts with a number + letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29319 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29437 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 20:41:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 19:41:50 +0000 Subject: [Koha-bugs] [Bug 29438] New: Importing a record with an ISBN13 with no ISBN10 counterpart does not save the ISBN Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29438 Bug ID: 29438 Summary: Importing a record with an ISBN13 with no ISBN10 counterpart does not save the ISBN Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When importing a record we call 'NormalizeISBN' This routine returns nothing when an ISBN13 cannot be converted to an ISBN10 - we should have a fallback to return the original value -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 20:41:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 19:41:58 +0000 Subject: [Koha-bugs] [Bug 29438] Importing a record with an ISBN13 with no ISBN10 counterpart does not save the ISBN In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29438 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29437 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 20:41:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 19:41:58 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29438 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 20:56:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 19:56:39 +0000 Subject: [Koha-bugs] [Bug 3342] Changes to holds priority list should be logged for accountability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3342 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 21:10:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 20:10:22 +0000 Subject: [Koha-bugs] [Bug 3342] Changes to holds priority list should be logged for accountability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3342 Noémie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |noemie.labine at collecto.ca --- Comment #3 from Noémie --- Still valid, when we change the priority with the arrows, this modification doesn't appear in the logs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 21:28:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 20:28:33 +0000 Subject: [Koha-bugs] [Bug 29439] New: Add browse interface to staff client Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29439 Bug ID: 29439 Summary: Add browse interface to staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com We should port the browse interface form the OPAC to the staff client -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 21:30:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 20:30:17 +0000 Subject: [Koha-bugs] [Bug 29439] Add browse interface to staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29439 --- Comment #1 from Nick Clemens --- Created attachment 127459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127459&action=edit Bug 29439: WIP This is a copy and paste to get a 'working' start Needs updates for styling/code/etc -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 21:30:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 20:30:50 +0000 Subject: [Koha-bugs] [Bug 29439] Add browse interface to staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29439 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27200, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14567 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 21:30:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 20:30:50 +0000 Subject: [Koha-bugs] [Bug 27200] "Browse search" is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29439 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 21:30:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 20:30:50 +0000 Subject: [Koha-bugs] [Bug 14567] Add an elasticsearch driven browse interface to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29439 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 23:45:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 22:45:20 +0000 Subject: [Koha-bugs] [Bug 17505] Add routes for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505 Margaret Hade changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret at bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 23:47:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 22:47:14 +0000 Subject: [Koha-bugs] [Bug 17505] Add routes for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 23:55:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 22:55:09 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 8 23:55:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 22:55:15 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127458|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 127460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127460&action=edit Bug 29437: Search reservoir for term as title, author, or variations of ISBN The code in the script and the module attempt to determine whether a term is an isbn, or not. Rather than try to do this, we can simply search it on the three fields: isbn, title, author Additionally, we should search as any of the ISBN variations to broaden our matches Note: Curently only an ISBN 10 is stored in import biblios, so for an ISBN13 that doesn't convert the value will be blank - this is another bug To test: 1 - Perform a cataloging search for a valid ISBN 13 with no ISBN10 counterpart: 9798200834976 2 - 500 error 3 - Apply patch 4 - Repeat, no results 5 - Import some records 6 - Search by title/author/isbn 7 - Confirm searching works as expected Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 00:06:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Nov 2021 23:06:06 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |david at davidnind.com --- Comment #4 from David Nind --- (In reply to Nick Clemens from comment #2) > Needs unit tests for QA, but can be tested Changed status back to needs signoff - everything work as per the test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 01:11:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 00:11:53 +0000 Subject: [Koha-bugs] [Bug 29439] Add browse interface to staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29439 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #2 from Victor Grousset/tuxayo --- As for refining the working start, would includes be a good way to share the code between staff and OPAC? For the .pl controller, is that simple for the OPAC one to call the staff one? It might be tricky about permissions though. I wonder what would be the other traps that could prevent any deduplication. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 02:50:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 01:50:30 +0000 Subject: [Koha-bugs] [Bug 29319] Errors when doing a cataloging search which starts with a number + letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29319 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an error that release notes| |occurs in cataloging search | |when entering a search term | |with ten characters (like | |"7th Heaven" or "2nd | |editio") - Koha thinks you | |are entering an ISBN10 | |number, gets confused and | |delivers an error page. | |Searching now works as | |expected for ISBN13/ISBN10 | |(without the '-'s), title | |and author searches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 02:54:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 01:54:35 +0000 Subject: [Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |System preference release notes| |RequestOnOpac renamed to | |OPACHoldRequests. It could | |be confused with the | |'Article Request' feature | |and does not follow Koha | |terminology - OPAC related | |system preferences normally | |start with OPAC. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 02:55:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 01:55:09 +0000 Subject: [Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed |Manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 09:05:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 08:05:02 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #13 from Jonathan Druart --- (In reply to Koha Team University Lyon 3 from comment #12) > Hi, > I haven't tested it yet because I'm still fighting with my kohadevbox. > > But, in theory, It's a pity to store NULL value in > pseudonymized_transactions instead of a value that gives us the information > the it's a renew done on the OPAC. > It's not possible to store the same value that the one in the statistics > table? > > Sonia I wasn't aware of this behaviour, but it does not sound correct. "Branch" must contain the branchcode, and be a foreign key. If we want to keep this additional information it should be stored into a separate column. Note that Marcel's workaround should work, if you create a branch with branchcode="OPACRenew" that should be inserted instead of NULL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 09:17:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 08:17:45 +0000 Subject: [Koha-bugs] [Bug 28236] Selecting database columns for system preferences in standard and dev installs is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 --- Comment #11 from Johanna Räisä --- (In reply to Jonathan Druart from comment #10) > Congratulations for your first patch pushed, Johanna! Nice, thank you very much. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 10:38:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 09:38:24 +0000 Subject: [Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 --- Comment #7 from Martin Renvoize --- Hmm.. difficult. I can see where you're coming from... but I'd be tempted to not require an embed to enable it's return and rather return it as a standard field.. so itype + effective_itype fields both always present in the result? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 10:40:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 09:40:57 +0000 Subject: [Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 --- Comment #8 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #7) > Hmm.. difficult. I can see where you're coming from... but I'd be tempted to > not require an embed to enable it's return and rather return it as a > standard field.. so itype + effective_itype fields both always present in > the result? Yes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 10:58:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 09:58:38 +0000 Subject: [Koha-bugs] [Bug 28957] Many plugins require the full plugins permission set to run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28957 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |testopia at bugs.koha-communit | |y.org Product|Koha security |Koha Group|Koha security | Component|Koha |Plugin architecture -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 11:05:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 10:05:46 +0000 Subject: [Koha-bugs] [Bug 28712] Printed slips for fees come up empty if no notice is defined for the user's preferred language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28712 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- OK.. I did some digging.. it's actually bug 28514 that resolves this further down the line. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 11:15:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 10:15:01 +0000 Subject: [Koha-bugs] [Bug 28994] Make writeoff_debts.pl use amountoutstanding, not amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28994 --- Comment #1 from Martin Renvoize --- Created attachment 127461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127461&action=edit Bug 28994: Fix logical errors with amount vs amoutoutstanding The writeoff debts script contained an error whereby we could writeoff more than the current outstanding debt of a charge. This patch corrects that mistake by passing amountoutstanding in place of amount in the writeoff and offset creation lines. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 11:15:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 10:15:34 +0000 Subject: [Koha-bugs] [Bug 28994] Make writeoff_debts.pl use amountoutstanding, not amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28994 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 11:15:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 10:15:38 +0000 Subject: [Koha-bugs] [Bug 28994] Make writeoff_debts.pl use amountoutstanding, not amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28994 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 11:16:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 10:16:28 +0000 Subject: [Koha-bugs] [Bug 28994] Make writeoff_debts.pl use amountoutstanding, not amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28994 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from Martin Renvoize --- Magnus is completely right here.. my mistake :(. I've just implemented the patch he suggested so I'll give him credit and then do a fast QA on it as I feel it's actually a pretty big bug that needs resolving. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 11:17:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 10:17:37 +0000 Subject: [Koha-bugs] [Bug 28994] Make writeoff_debts.pl use amountoutstanding, not amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28994 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127461|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 127462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127462&action=edit Bug 28994: Fix logical errors with amount vs amoutoutstanding The writeoff debts script contained an error whereby we could writeoff more than the current outstanding debt of a charge. This patch corrects that mistake by passing amountoutstanding in place of amount in the writeoff and offset creation lines. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 11:17:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 10:17:48 +0000 Subject: [Koha-bugs] [Bug 28994] Make writeoff_debts.pl use amountoutstanding, not amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28994 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 11:17:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 10:17:57 +0000 Subject: [Koha-bugs] [Bug 28994] Make writeoff_debts.pl use amountoutstanding, not amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28994 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 11:18:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 10:18:06 +0000 Subject: [Koha-bugs] [Bug 28994] Make writeoff_debts.pl use amountoutstanding, not amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28994 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 11:34:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 10:34:09 +0000 Subject: [Koha-bugs] [Bug 28995] Add --added_after to writeoff_debts.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28995 --- Comment #1 from Martin Renvoize --- Created attachment 127463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127463&action=edit Bug 28995: Add `--added_after` filter to writeoff_debts script This adds, as requested, the `added_after` filter option to writeoff_debts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 11:34:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 10:34:21 +0000 Subject: [Koha-bugs] [Bug 28995] Add --added_after to writeoff_debts.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28995 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 11:34:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 10:34:27 +0000 Subject: [Koha-bugs] [Bug 28995] Add --added_after to writeoff_debts.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28995 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 11:34:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 10:34:40 +0000 Subject: [Koha-bugs] [Bug 28995] Add --added_after to writeoff_debts.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28995 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|27049 |28994 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27049 [Bug 27049] Add a script to bulk writeoff debts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28994 [Bug 28994] Make writeoff_debts.pl use amountoutstanding, not amount -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 11:34:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 10:34:40 +0000 Subject: [Koha-bugs] [Bug 27049] Add a script to bulk writeoff debts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27049 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28995 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28995 [Bug 28995] Add --added_after to writeoff_debts.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 11:34:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 10:34:40 +0000 Subject: [Koha-bugs] [Bug 28994] Make writeoff_debts.pl use amountoutstanding, not amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28994 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28995 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28995 [Bug 28995] Add --added_after to writeoff_debts.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 11:49:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 10:49:16 +0000 Subject: [Koha-bugs] [Bug 28712] Printed slips for fees come up empty if no notice is defined for the user's preferred language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28712 --- Comment #5 from Martin Renvoize --- Created attachment 127464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127464&action=edit Bug 28712: Add fallback to default for missing language template -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 11:49:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 10:49:29 +0000 Subject: [Koha-bugs] [Bug 28712] Printed slips for fees come up empty if no notice is defined for the user's preferred language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28712 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 11:49:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 10:49:36 +0000 Subject: [Koha-bugs] [Bug 28712] Printed slips for fees come up empty if no notice is defined for the user's preferred language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28712 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 11:50:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 10:50:40 +0000 Subject: [Koha-bugs] [Bug 28712] Printed slips for fees come up empty if no notice is defined for the user's preferred language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28712 --- Comment #6 from Martin Renvoize --- Taking inspiration from bug 28487 to produce a fix for older versions here.. this is already resolved in 21.11 onwards by bug 28514. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 12:33:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 11:33:19 +0000 Subject: [Koha-bugs] [Bug 24885] Remove guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24885 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 12:52:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 11:52:43 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119854|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize --- Created attachment 127465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127465&action=edit Bug 24295: Remove GetTransfer from Z3950Responder Replace the GetTrasfer call in Z3950Responder/Session.pm with a call to the Koha::Item method 'get_transfer'. Test plan 1/ Configure your system to use the Z3950 responder 2/ Trigger an item transfer for an item 3/ Search for the item via Z3950 and varify the transfer status is set 4/ Apply the patch 5/ Repeat step 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 12:52:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 11:52:47 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119855|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize --- Created attachment 127466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127466&action=edit Bug 24295: Remove GetTransfers from opac-reserve.pl This patch replaces the call to GetTransfers in opac-reserve with the get_transfer method available from the Koha::Item object Test plan 1/ Place a reserve on an item at a different branch 2/ Trigger the transfer of the item 3/ Check the opac-reserves page for the display of the current transfer status 4/ Apply patch 5/ Repeat step 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 12:52:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 11:52:51 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119856|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize --- Created attachment 127467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127467&action=edit Bug 24295: Remove GetTransfers from opac-detail.pl This patch replaces the call to GetTransfers in opac-detail with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the opac-detail page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 12:52:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 11:52:55 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119857|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize --- Created attachment 127468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127468&action=edit Bug 24295: Remove GetTransfers from opac-basket.pl This patch replaces the call to GetTransfers in opac-basket with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the opac-basket page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 12:52:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 11:52:59 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #46 from Martin Renvoize --- Created attachment 127469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127469&action=edit Bug 24295: Remove GetTransfers from request.pl This patch replaces the call to GetTransfers in reserve.pl with the get_transfer method available from the Koha::Item object Test plan 1/ Place a reserve on an item at a different branch 2/ Trigger the transfer of the item 3/ Check the reserves page for the display of the current transfer status 4/ Apply patch 5/ Repeat step 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 12:53:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 11:53:03 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119859|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize --- Created attachment 127470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127470&action=edit Bug 24295: Remove GetTransfers from detail.pl This patch replaces the call to GetTransfers in detail.pl with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the detail page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 12:53:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 11:53:07 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119860|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize --- Created attachment 127471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127471&action=edit Bug 24295: Remove GetTransfers from svc/holds This patch replaces the call to C4::GetTransfers in svc/holds with a call to the get_transfer method in the Koha::Item object. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 12:53:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 11:53:11 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119861|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize --- Created attachment 127472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127472&action=edit Bug 24295: Replace mock in t/db_dependent/Search.t Replace the mock of GetTransfers in this test with a mock of transfers data Test plan 1/ Run t/db_dependent/Search.t 2/ Confirm it passes 3/ Apply patch 4/ Repeat steps 1-2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 12:53:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 11:53:15 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119862|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize --- Created attachment 127473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127473&action=edit Bug 24295: Replace mock in t/db_dependent/Circulation/transferbook.t Replace the call to GetTransfers with the get_transfer method in Koha::Item in transferbook.t Test plan 1/ Run t/db_dependent/Circulation/transferbook.t 2/ Confirm it passes 3/ Apply patch 4/ Repeat steps 1-2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 12:53:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 11:53:19 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119863|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize --- Created attachment 127474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127474&action=edit Bug 24295: Remove GetTransfers call from C4/HoldsQueue.pm This patch removes the GetTransfers call from GetItemsAvailableToFillHoldRequestsForBib instead replacing it with an inline JOIN in the initial query. Test plan 1/ Run the holds queue 2/ Check the results 3/ Put one of the items in the holds queue into transit 4/ Run the holds queue again 5/ Check that the results do not contain the item that is in transit 6/ Apply the patch 7/ Run the holds queue again 8/ Check that the results still do not contain the item that is in transit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 12:53:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 11:53:23 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119866|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize --- Created attachment 127475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127475&action=edit Bug 24295: Remove GetTransfers from C4/Search.pm This patch removes the final use of GetTransfers from C4::Search. Test plan 1/ Perform a search that will include results for some items that have transfers of various states assigned to them 2/ Check the results match expectations (before and after applying the patch should look the same) 3/ Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 12:53:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 11:53:27 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119867|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize --- Created attachment 127476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127476&action=edit Bug 24295: Finally remove GetTransfers from C4/Circulation This patch handles the final removal of GetTransfers from C4::Circulation. Test plan 1/ Check that there is no mention of the GetTransfers method codebase wide now 2/ Run the circulation and transfers tests and check nothing fails.. perhaps even run the full test suit in k-t-d 3/ Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 12:53:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 11:53:32 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #54 from Martin Renvoize --- Created attachment 127477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127477&action=edit Bug 24295: Remove GetTransfers from circ/transferstoreceive.pl Just drop the import of GetTransfers from circ/transferstoreceive.pl is it's never actually used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 12:54:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 11:54:01 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119858|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 12:54:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 11:54:11 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 12:55:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 11:55:08 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #55 from Martin Renvoize --- Rebased.. remarkably, it wasn't too terrible a rebase.. just needed pretty much every patch touching to drop the GetTransfers import introduced with our EXPORT bug. Back to NSO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 13:20:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 12:20:12 +0000 Subject: [Koha-bugs] [Bug 25387] Avoid merge different type of authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25387 --- Comment #12 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #11) > (In reply to Marcel de Rooy from comment #10) > > (In reply to Katrin Fischer from comment #9) > > > Could it be an option to only allow merging when the 'losing' record is > > > unused? In this case there would be no data loss and a warning would not be > > > necessary. > > > > I dont think so. Manual relinking wont be fun. > > Not sure if we understood each other. What I mean it merging an authority > record that is not linked (used) in any bibliographic record. So no > relinking would be necessary. We understand each other :) And I would say: No, thats a bad idea. Manual relinking the ones who are used, wont be fun. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 13:24:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 12:24:06 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #40 from Marcel de Rooy --- Tomas, I am keen to signoff this one, but wouldnt it be helpful if you would add patches ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 13:24:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 12:24:40 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #41 from Marcel de Rooy --- And what about the dependency ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 13:29:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 12:29:27 +0000 Subject: [Koha-bugs] [Bug 29440] New: Refactor/clean up bulkmarcimport.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 Bug ID: 29440 Summary: Refactor/clean up bulkmarcimport.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: glasklas at gmail.com QA Contact: testopia at bugs.koha-community.org In order to address various issues with and add some new features to bulkmarcimport.pl I found it necessary to first clean up the script. At our library we run a modified version of bulkmarcimport.pl that for practical reasons was squashed into one commit. I have split this commit into various feature branches, all which depends on the clean up version of the script. So in the first commit of this issue I tried to isolate all the changes that should not affect current script behavior and are mostly related to code formatting, structure and optimizations. The next commits (for this issue) will contain changes that do affect script behavior, but that I would argue should be the default behavior and where the current could be considered confusing and/or buggy. I will later create new related issues for the newly added features mentioned above (and it's possible there is stuff in this patch that should have been broken out and I have overlooked). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 13:37:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 12:37:24 +0000 Subject: [Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238 --- Comment #17 from marion.durand at biblibre.com --- Created attachment 127478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127478&action=edit Bug 28238: (follow-up) Add tests Add specific tests for the tag itemcallnumber in GetAvailability output. Sponsored-by: University Lyon 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 13:37:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 12:37:57 +0000 Subject: [Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238 marion.durand at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 13:45:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 12:45:09 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 --- Comment #1 from David Gustafsson --- Created attachment 127479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127479&action=edit Bug 29440: Make authorities import behavior consistent with biblios The current behavior for when importing authorities, when match option is enabled, is to insert as a new authority fetching from db fails. This is both a bit confusing and not consistent with the biblio case where an error is generated. Also clean up error and log messages so both messages/errors and when messages/errors are issued are more consistent for the biblio and authority case. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 13:46:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 12:46:41 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 --- Comment #2 from David Gustafsson --- Created attachment 127480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127480&action=edit Bug 29440: Refactor and clean up bulkmarcimport.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 13:46:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 12:46:45 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127479|0 |1 is obsolete| | --- Comment #3 from David Gustafsson --- Created attachment 127481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127481&action=edit Bug 29440: Make authorities import behavior consistent with biblios The current behavior for when importing authorities, when match option is enabled, is to insert as a new authority fetching from db fails. This is both a bit confusing and not consistent with the biblio case where an error is generated. Also clean up error and log messages so both messages/errors and when messages/errors are issued are more consistent for the biblio and authority case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 13:50:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 12:50:23 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14957 |29440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 [Bug 14957] Write protecting MARC fields based on source of import https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 [Bug 29440] Refactor/clean up bulkmarcimport.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 13:50:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 12:50:23 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25539 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 [Bug 25539] Remove AddBiblio "defer_marc_save" option -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 13:50:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 12:50:23 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25539 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 [Bug 25539] Remove AddBiblio "defer_marc_save" option -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 13:54:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 12:54:09 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 --- Comment #24 from David Gustafsson --- I have now started to work on breaking up the patch earlier mentioned in this thread into more manageable parts. At least separating the new features from the major cleanup. Created a new issue (bug 29440) which is now a dependency for this. I will later update the patches in this issue so are rebased upon the patch-set in 29440. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 13:57:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 12:57:31 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 --- Comment #4 from David Gustafsson --- To make this easier to review I will make a rough summary/motivation of the major changes, just did not have the time to do so right now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:08:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:08:44 +0000 Subject: [Koha-bugs] [Bug 28855] Purging Suggestions test should not being on timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 --- Comment #2 from marion.durand at biblibre.com --- Created attachment 127482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127482&action=edit Bug 28855: Purging suggestions test should not be on timestamp DelSuggestionsOlderThan is on "date", a timestamp. It can be a problem because "date" is updated when we update the database, in consequences all the suggestions take the same date. This patch use 'manageddate' instead. In order to test this patch, you will need to have some suggestions where "Managed on" (suggestions.manageddate in the database) is older from "Last updated" (suggestions.date in the database). This can append during some specific update. If you don't have such data, you will have to add them via SQL request. Example of sql for insertion (ID is the patron id of a librarian which can manage suggestions): INSERT INTO suggestions (suggestedby, suggesteddate, managedby, manageddate, acceptedby, accepteddate, STATUS, title) VALUES (1, '2020-10-13', 1, '2020-10-26', 1, '2020-10-26', 'ACCEPTED', 'title'); Test plan: 1- Choose a date and find (or add) a suggestion where: - "Last updated" is not older than this date - "Managed on" is older than this date - "Status" is different from "Pending" ("ASKED" in database) Calculate number_days = today's date - chosen date Example: (Today's date 28/10/2021, chosen date : 28/10/2020, number_days=365) Suggestion | .. | Managed on | .. | Last updated | .. | Status title | .. | 10/26/2020 | .. | 05/15/2021 | .. | Accepted 2- Run cron job /home/koha/src/misc/cronjobs/purge_suggestions.pl --confirm --days number_days 3- Check that this suggestion has not been deleted 4- Apply the patch 5- Repeat steps 1 and 2 6- Check that this suggestion has been deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:10:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:10:09 +0000 Subject: [Koha-bugs] [Bug 5697] Automatic linking in guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117765|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:10:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:10:12 +0000 Subject: [Koha-bugs] [Bug 5697] Automatic linking in guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117766|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:10:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:10:16 +0000 Subject: [Koha-bugs] [Bug 5697] Automatic linking in guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117988|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:10:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:10:19 +0000 Subject: [Koha-bugs] [Bug 5697] Automatic linking in guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118022|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:14:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:14:29 +0000 Subject: [Koha-bugs] [Bug 28855] Purging Suggestions test should not being on timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 --- Comment #3 from marion.durand at biblibre.com --- Created attachment 127483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127483&action=edit Bug 28855: (follow-up) adapt specific test Adapt the test of function DelSuggestionsOlderThan to match the new behaviour of the function. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:17:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:17:49 +0000 Subject: [Koha-bugs] [Bug 5697] Automatic linking in guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:17:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:17:53 +0000 Subject: [Koha-bugs] [Bug 5697] Automatic linking in guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 --- Comment #28 from Owen Leonard --- Created attachment 127484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127484&action=edit Bug 5697: Automatic linking in guided reports This patch modifies the output of reports so that if certain columns are returned the data in the colums automatically offer menus of actions: - borrowernumber: View, edit, check out - cardnumber: Check out - itemnumber: View, edit - biblionumber: View, edit Like the menu of batch operations, this functionality is available only if the column is returned with its original name (e.g. biblionumber or [[biblionumber|Biblio number]] but not "biblionumber AS `Biblio number`). To test, apply the patch and run a report which will return examples of each kind of data. I used: SELECT biblio.biblionumber , biblio.title, items.itemnumber, items.itemcallnumber, items.barcode, borrowers.firstname, borrowers.surname, borrowers.borrowernumber, borrowers.cardnumber FROM issues LEFT JOIN borrowers ON borrowers.borrowernumber=issues.borrowernumber LEFT JOIN items ON issues.itemnumber=items.itemnumber LEFT JOIN biblio ON items.biblionumber=biblio.biblionumber ORDER BY RAND() LIMIT 50 When the report runs you should see that the data in each affected column is displayed as a link, each of which should trigger the correct menu. Test each case to confirm that the correct page is opened. Test the "toggle data menus" control. Clicking it should hide and show the menus in the report results. The selection persists until the user logs out. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:21:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:21:07 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127480|0 |1 is obsolete| | --- Comment #5 from David Gustafsson --- Created attachment 127485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127485&action=edit Bug 29440: Refactor and clean up bulkmarcimport.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:21:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:21:10 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127481|0 |1 is obsolete| | --- Comment #6 from David Gustafsson --- Created attachment 127486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127486&action=edit Bug 29440: Make authorities import behavior consistent with biblios The current behavior for when importing authorities, when match option is enabled, is to insert as a new authority fetching from db fails. This is both a bit confusing and not consistent with the biblio case where an error is generated. Also clean up error and log messages so both messages/errors and when messages/errors are issued are more consistent for the biblio and authority case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:25:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:25:33 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #52 from Martin Renvoize --- I get Applying: Bug 27266: (follow-up) Remove get_marc_authors from opac-detail error: sha1 information is lacking or useless (opac/opac-detail.pl). error: could not build fake ancestor Patch failed at 0001 Bug 27266: (follow-up) Remove get_marc_authors from opac-detail Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:35:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:35:18 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #42 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #41) > And what about the dependency ? I'm moving the cancellation handling to a separate bug. Martin and I have talked about working together on the dependency bug just after the release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:44:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:44:09 +0000 Subject: [Koha-bugs] [Bug 29441] New: We should make our method returns consistent in Koha::Biblio Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29441 Bug ID: 29441 Summary: We should make our method returns consistent in Koha::Biblio Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org We now have a few of 'get_marc_*' accessors in Koha::Biblio, but their returns are really inconsistent. I feel like we aught to try and make them as consistent as possible so future developers can use them without having to dig through the code to see what they return. In `get_marc_notes` we return an array of note strings from the marc record.. these may be selective subfield concatenations and could be in various orders. In `get_marc_host` we return either a Koha::Biblio object or the Biblio object + the subfield g, as a string, from the current records marc21 773 field we used to find the host. In `get_marc_components` we return an array of MARCXML strings. I think we could do better here.. certainly with the `_components` and `_host` routines either consistently returning Koha::Biblio/Koha::Biblios or MARCXML string/strings for example. As for `get_marc_notes`, this is a little different.. we could possibly return an array of MARC::Field objects for later processing, or perhaps we aught to have a second naming scheme for returning strings from MARC/Metadata vs retuning a marc/metadata object/string itself? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:44:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:44:27 +0000 Subject: [Koha-bugs] [Bug 29441] We should make our method returns consistent in Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29441 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27266 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:44:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:44:27 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29441 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:44:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:44:46 +0000 Subject: [Koha-bugs] [Bug 29441] We should make our method returns consistent in Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29441 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11175 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:44:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:44:46 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29441 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:45:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:45:28 +0000 Subject: [Koha-bugs] [Bug 29441] We should make our method returns consistent in Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29441 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20310 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:45:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:45:28 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Use details from the host record when submitting an article request on an analytic record without attached items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29441 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:46:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:46:12 +0000 Subject: [Koha-bugs] [Bug 29441] We should make our method returns consistent in Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29441 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27268 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:46:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:46:12 +0000 Subject: [Koha-bugs] [Bug 27268] Move C4::Biblio::GetMarcNotes to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27268 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29441 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:47:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:47:16 +0000 Subject: [Koha-bugs] [Bug 29441] We should make our method returns consistent in Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29441 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26314 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:47:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:47:16 +0000 Subject: [Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29441 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:52:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:52:04 +0000 Subject: [Koha-bugs] [Bug 29441] We should make our method returns consistent in Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29441 --- Comment #1 from Martin Renvoize --- On first look.. I feel like 'MARCXML' strings or 'MARC::Record' objects would be the right thing to return from the `get_marc_` accessors.. and then the consumer uses this response to do the next thing.. be that parse the string with XSLT for display, or get the Koha::Biblio using the data within.. I suggest this as it's what's returned from the search engine used for the two existing calls and thus reduces reduces further calls internally that may not be required. As for get_marc_notes.. perhaps we would be better going back to 'get_notes' or 'get_notes_from_marc' to set a distinction between 'something that returns a MARC thing' and 'something that returns string/s from inside the MARC' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:52:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:52:46 +0000 Subject: [Koha-bugs] [Bug 29441] We should make our method returns consistent in Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29441 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27270 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:52:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:52:46 +0000 Subject: [Koha-bugs] [Bug 27270] Move C4::Biblio::GetMarcSeries to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27270 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29441 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:52:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:52:54 +0000 Subject: [Koha-bugs] [Bug 29441] We should make our method returns consistent in Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29441 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27271 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:52:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:52:54 +0000 Subject: [Koha-bugs] [Bug 27271] Move C4::Biblio::GetMarcUrls to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27271 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29441 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:53:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:53:12 +0000 Subject: [Koha-bugs] [Bug 29441] We should make our method returns consistent in Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29441 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27269 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:53:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:53:12 +0000 Subject: [Koha-bugs] [Bug 27269] Move C4::Biblio::GetMarcSubjects to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29441 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 14:54:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 13:54:14 +0000 Subject: [Koha-bugs] [Bug 29441] We should make our method returns consistent in Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29441 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |kyle at bywatersolutions.com, | |m.de.rooy at rijksmuseum.nl, | |nick at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 15:02:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 14:02:51 +0000 Subject: [Koha-bugs] [Bug 24866] Display budget hierarchy in the budget dropdown menu used when placing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866 --- Comment #15 from Florian --- Created attachment 127487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127487&action=edit Bug 24866: (follow-up) Replaced tabulations by dashes The rendering of SELECT elements is up to the browser. But Bug 16123 CSS code 'style="padding-left: xx' doesn't work on modern browsers. Based on the previous contribution, this fix replaces CSS style attribute with dashes, creating a leveled structure that should work with most browsers. Tested on Linux Ubuntu with Firefox 94.0, Chromium 95.0.4 and Opera 81.0.1 TEST PLAN : 1. Go to the Administration module 2. Add a new budget (ie : Budget 2022) 3. Add a fund to this budget (ie : Book) 4. Add a sub-fund to fund Book (ie : Fiction) 5. Add another sub-fund, this time to sub-fund Book (ie : Adult fiction) You will have this hierarchy : Budget 2022 |____ Book |_____ Fiction |_____ Adult fiction 6. Go to the Acquisition module 7. Select a vendor and create a new basket 8. Place an order 9. Check the budget dropdown menu BEFORE PATCH Book Fiction Adult fiction OR Book Fiction Adult fiction AFTER PATCH Book -- Fiction -- -- Adult fiction Co-authored-by: Didier Gautheron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 15:04:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 14:04:03 +0000 Subject: [Koha-bugs] [Bug 24866] Display budget hierarchy in the budget dropdown menu used when placing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866 Florian changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |florian.bontemps at biblibre.c | |om Status|Failed QA |Needs Signoff --- Comment #16 from Florian --- If that new patch could be signed-off by people using Mac/windows, that'd be great. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 15:04:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 14:04:57 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 --- Comment #25 from Martin Renvoize --- That's great news David, thankyou for getting back onto this.. Do feel free to grab me to take a look when you need review etc :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 15:09:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 14:09:32 +0000 Subject: [Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean search and so results in error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Sheri Waite changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |swaite at marshallpl.org --- Comment #3 from Sheri Waite --- This error message also seems to be appearing with ! and () and maybe addtional punctuation in the 245 field. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 15:45:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 14:45:29 +0000 Subject: [Koha-bugs] [Bug 29442] New: Show DefaultClassificationSource selection on Classification Sources page (classsources.pl) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29442 Bug ID: 29442 Summary: Show DefaultClassificationSource selection on Classification Sources page (classsources.pl) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com On the classification sources page in Admin, it would be handy to have the selection from the DefaultClassificationSource visible somehow. Maybe a simple line of text at the top of the page, with a link to the system preference? Or some sort of icon or highlighting in the Classification Sources table? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 15:47:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 14:47:16 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #20 from Björn Nylén --- Created attachment 127488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127488&action=edit (QA followup) Unit tests Got around to doing unit tests (a bit of a noob at this still).... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 16:02:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 15:02:03 +0000 Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126944|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 127489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127489&action=edit Bug 29325: Fix commit_file.pl This patch fixes the broken commit_file.pl script. It doesn't deal with commiting the import from the UI. To test: 1. Pick a file for staging: $ kshell k$ misc/stage_file.pl --file TestDataImportKoha.mrc => SUCCESS: All good 2. Commit! k$ misc/commit_file.pl --batch-number 1 => FAIL: You see DBIx::Class::Storage::DBI::_exec_txn_begin(): DBI Exception: DBD::mysql::db begin_work failed: Already in a transaction at /kohadevbox/koha/C4/Biblio.pm line 303 3. Apply this patch 4. Repeat 2 => SUCCESS: Commit succeeds 5. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 16:03:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 15:03:15 +0000 Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from Martin Renvoize --- This also worked for me.. though I'm not really sure why when reading the code.. we seem to mix up commit calls and nest forks inside txn_do subs.. which all confuses me. But.. it seems to work.. so signing off and leaving for bigger brains to QA ;P -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 16:26:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 15:26:07 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Björn Nylén changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123709|0 |1 is obsolete| | --- Comment #21 from Björn Nylén --- Created attachment 127490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127490&action=edit Bug 14783: (follow-up revised) Move pickup library form into modal Replacing the modal-followup, removing the change of x -> × as it is already done in a recent patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 16:47:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 15:47:10 +0000 Subject: [Koha-bugs] [Bug 29362] Opac detail error while shown in search list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29362 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 16:47:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 15:47:19 +0000 Subject: [Koha-bugs] [Bug 29406] Improve display of OPAC suppression message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29406 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 16:47:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 15:47:22 +0000 Subject: [Koha-bugs] [Bug 29406] Improve display of OPAC suppression message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29406 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127406|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 127491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127491&action=edit Bug 29406: Improve display of OPAC suppression message This patch changes the way the "Suppressed in OPAC" message is shown on the staff interface search results and the bibliographic detail page. Now the information is displayed like other bibliographic details. To test, apply the patch and restart services. - Enable the OpacSuppression system preference and modify at least one record to be suppressed in the OPAC (942$n in MARC21). - Perform a catalog search which will return this record in the staff client. - The entry for that record in the search results should include the message "Suppressed in OPAC" at the bottom of the list of other bibliographic details. - View the details for that record. You should see a line labeled "OPAC view" It should say "Suppressed in OPAC." - Test a record which is not suppressed. If you have OPACBaseURL populated you should see "OPAC view: Open in new window." Signed-off-by: Barbara Johnson Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 16:47:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 15:47:54 +0000 Subject: [Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean search and so results in error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #4 from Liz Rea --- And question marks (?) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 16:50:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 15:50:28 +0000 Subject: [Koha-bugs] [Bug 17735] Merge boraccount and pay pages into one In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17735 --- Comment #3 from Martin Renvoize --- I'm reconsidering this again.. Right now I'm thinking 'Charges' on one page, with the ability to expand the row much like the current; 'details page displays offsets now, but inline. 'Deductions/Credits' on a page to show from the opposite view.. payments, write-offs, outstanding credits etc. Perhaps a new 'Transactions' page that mimics the point of sale and uses dates in offsets to display the application of credit against debits over time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 16:52:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 15:52:57 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #22 from Björn Nylén --- Created attachment 127492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127492&action=edit (QA followup, suggestion) Change "Pick up location" to "Pickup location" Adding a followup patch to change "Pick up location" to "Pickup location" in holds-table.inc I belive that's used elsewhere. As for the syspref, from what I see the wording and syspref is already as suggested? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 16:53:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 15:53:36 +0000 Subject: [Koha-bugs] [Bug 29289] 'Show fines to guarantor' should have its own id on patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|'Show fines to guarantor' |'Show fines to guarantor' |should have it's own class |should have its own id on |on staff patron detail page |patron detail page Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 16:54:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 15:54:56 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Björn Nylén changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #23 from Björn Nylén --- Setting back to signed off, for another round of QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 17:00:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 16:00:23 +0000 Subject: [Koha-bugs] [Bug 29289] 'Show fines to guarantor' should have its own id on patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 17:00:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 16:00:27 +0000 Subject: [Koha-bugs] [Bug 29289] 'Show fines to guarantor' should have its own id on patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 --- Comment #2 from Owen Leonard --- Created attachment 127493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127493&action=edit Bug 29289: 'Show fines to guarantor' should have its own id on patron detail page This patch adds an id attribute to the list item containing the "Show fines to guarantor" information on the patron detail page in the staff interface. This makes it consistent with the markup for the similar "Show checkouts to guarantor" list item. To test, apply the patch and view a patron's details in the staff client. Inspect the source to confirm that the "Show fines to guarantor" line has an id, "patron-privacy_guarantor_fines". Alternatively, add this to the IntranetUserCSS system preference: #patron-privacy_guarantor_fines { background-color: pink; } The line on the patron details page should be highlighted in pink. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 17:02:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 16:02:24 +0000 Subject: [Koha-bugs] [Bug 29443] New: Expired patrons should not be allowed to place ILL request on OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29443 Bug ID: 29443 Summary: Expired patrons should not be allowed to place ILL request on OPAC Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: dch at interleaf.ie Expired patrons should not be allowed to place ILL request on OPAC. The SysPref BlockExpiredPatronOPACActions should be checked and if it is set to 'Block' the patron should be blocked from placing ILL request as well as the other OPAC actions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 17:04:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 16:04:13 +0000 Subject: [Koha-bugs] [Bug 29443] Expired patrons should not be allowed to place ILL request on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29443 Daphne Hoolahan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dch at interleaf.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 18:44:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 17:44:24 +0000 Subject: [Koha-bugs] [Bug 29444] New: 404 Not Found pages come back as 200 OK under plack Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29444 Bug ID: 29444 Summary: 404 Not Found pages come back as 200 OK under plack Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org See bug 29420 and old bug 3797 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 18:44:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 17:44:34 +0000 Subject: [Koha-bugs] [Bug 29444] 404 Not Found pages come back as 200 OK under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29444 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |3797 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29420 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3797 [Bug 3797] The opac 404 page is sent with 200 headers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 18:44:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 17:44:34 +0000 Subject: [Koha-bugs] [Bug 3797] The opac 404 page is sent with 200 headers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3797 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29444 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29444 [Bug 29444] 404 Not Found pages come back as 200 OK under plack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 18:44:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 17:44:34 +0000 Subject: [Koha-bugs] [Bug 29420] 401 Unauthorized pages come back as 200 OK under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29444 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 20:07:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 19:07:52 +0000 Subject: [Koha-bugs] [Bug 29289] 'Show fines to guarantor' should have its own id on patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127493|0 |1 is obsolete| | --- Comment #3 from PTFS Europe Sandboxes --- Created attachment 127494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127494&action=edit Bug 29289: 'Show fines to guarantor' should have its own id on patron detail page This patch adds an id attribute to the list item containing the "Show fines to guarantor" information on the patron detail page in the staff interface. This makes it consistent with the markup for the similar "Show checkouts to guarantor" list item. To test, apply the patch and view a patron's details in the staff client. Inspect the source to confirm that the "Show fines to guarantor" line has an id, "patron-privacy_guarantor_fines". Alternatively, add this to the IntranetUserCSS system preference: #patron-privacy_guarantor_fines { background-color: pink; } The line on the patron details page should be highlighted in pink. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 20:08:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 19:08:15 +0000 Subject: [Koha-bugs] [Bug 29289] 'Show fines to guarantor' should have its own id on patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 20:18:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 19:18:00 +0000 Subject: [Koha-bugs] [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 Myka Kennedy Stephens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens at lancasterseminar | |y.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 20:36:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 19:36:39 +0000 Subject: [Koha-bugs] [Bug 29445] New: Checking replace cover image should actually replace cover image Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29445 Bug ID: 29445 Summary: Checking replace cover image should actually replace cover image Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: estherm at sodaspringsid.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl To duplicate: In this scenario, the Coce image service pulls the incorrect cover image. 1. System setting AllowMultipleCovers is set to allow and CoceProviders is set to all. 2. Upload a new image cover and select replace cover image. 3. Check the normal view in the staff client and see that the new image displays as the default image and the Coce image displays as a second hidden image that can be selected to view. 4. Check OPAC view, both images continue to be displayed. Repeat these steps but set AllowMultipleCovers to not allow. Both images continue to be displayed. I would have expected that by checking replace cover image that the cover image is actually replaced. Instead it looks like ticking that box sort of makes the image the first image that is displayed but doesn't actually replace. As for the setting AllowMultiple Covers - this needs clarification. Ideally a bib record should allow multiple images but with the option to select the default cover image and the ability to not show the Coce image if it is not correct. This may be related to ticket 29359 and 26933. It looks like additional cover image tools or preferences are needed. Selecting a default image, actually replacing a cover image in place of the Coce image, deleting an image, selecting how many images show, etc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 20:41:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 19:41:19 +0000 Subject: [Koha-bugs] [Bug 29445] Checking replace cover image should actually replace cover image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29445 --- Comment #1 from Esther Melander --- Created attachment 127495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127495&action=edit An example of image not being replaced. The uploaded image is on top, the Coce image is below. We would like the Coce image to go away. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 20:48:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 19:48:00 +0000 Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #1 from Liz Rea --- This vulnerability really seems like it could be not great, we use the mentioned methods a lot. This will be a fairly big job I reckon? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 21:00:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 20:00:51 +0000 Subject: [Koha-bugs] [Bug 29446] New: Add ability to delete image from item edit drop down Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29446 Bug ID: 29446 Summary: Add ability to delete image from item edit drop down Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: estherm at sodaspringsid.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 127496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127496&action=edit Edit image drop down It would be nice to add a delete image option to the edit drop down. Currently the only way to delete the image is to go through Tools -> Upload menu. This requires remembering the file name or acquiring the image number. After many years of uploading images this would be difficult. Also, does deleting the item automatically delete the attached images? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 21:09:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 20:09:09 +0000 Subject: [Koha-bugs] [Bug 29447] New: authority that begins with a number isn't found in tag editor search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29447 Bug ID: 29447 Summary: authority that begins with a number isn't found in tag editor search Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: noemie.labine at collecto.ca QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl To recreate : 1. Have an authority that starts with a number. Exemple : uniform title, 1000 feuilles 2. Create or modify a bibliographic record 3. In the tag editor (wether it's in tag 130, 630, 730, 830 the result is the same), search for the authority 1000 feuilles. The result is the same with any of the field (Search main heading ($a) only, Search main heading, Search all headings or Search entire record) 4. We obtain No results found. 5. Erase the number 1000 and keep feuilles only, we obtain the authority 1000 feuilles. Same goes with other authorities, such as meeting name, person name or corporate name, not only uniform title. When we search in Authorities, we can find the authority with any of the indexes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 21:13:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 20:13:35 +0000 Subject: [Koha-bugs] [Bug 29447] authority that begins with a number isn't found in tag editor search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29447 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 21:47:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 20:47:07 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass --- Any chance we can get a 21.05 backport of this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 23:07:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 22:07:00 +0000 Subject: [Koha-bugs] [Bug 27753] Automate resolution of return claim when checking in an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Daniel Gaghan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.gaghan at pueblolibrary | |.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 23:39:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 22:39:37 +0000 Subject: [Koha-bugs] [Bug 29448] New: Statistics 1 and 2 are not filled with default values when ordering from file Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29448 Bug ID: 29448 Summary: Statistics 1 and 2 are not filled with default values when ordering from file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org Created attachment 127497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127497&action=edit MARC file with one record for testing Hi everyone, I don't know if I'm misunderstanding the purpose of the "Default accounting details" when ordering from a new or staged file. To me, we should be able to set the default accounting details, and these defaults will be copied to all orders, where we can change one or two values if we need to. But I noticed that while the fund is copied to orders, the statistics 1 and 2 are not. Is this by design? If so, what is the purpose of copying one (the fund) and not the other (the statistics)? Or is this a bug? Here's how to replicate (I apologize for how long this is, I tried to include everything) : 1. Make sure that you have a budget with a fund that asks for statistics 1.1 Go to Acquisitions > Funds 1.2 Click Actions > Edit next to a fund 1.3 In Statistic 1 done on, choose an authorized value category (that has values, e.g. LOC) 1.4 In Statistic 2 done on, choose an authorized value category (that has values, e.g. YES_NO) 1.5 Click Submit 2. Create an order from a new or staged file 2.1 Go to Acquisitions 2.2 Search for a vendor 2.3 If you don't already have an open basket, create a basket 2.4 Click Add to basket 2.5 Click From a new file 2.6 Stage a MARC file (I attached a file with one record, you can use this one if you don't already have one on hand) 2.7 Click Add staged files to basket 3. Set default accounting details 3.1 Go to the Default accounting details tab 3.2 Choose your fund 3.3 Choose values for statistics 1 and 2 4. Check individual orders 4.1 Go to the Select to import tab 4.2 Click Select all --> Notice that the fund you chose is selected --> Notice that the statistics you chose are NOT selected and the drop down menus don't even appear Thanks! Caroline -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 23:49:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 22:49:19 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 Esther Melander changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |estherm at sodaspringsid.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 23:50:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 22:50:54 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #34 from David Cook --- Cool workaround. I had looked at Email::MIME->new(), but wasn't sure how we'd make it work. Haven't tried out the code but thanks for working on this, Tomas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 9 23:51:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 22:51:30 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Esther Melander changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |estherm at sodaspringsid.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 00:02:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Nov 2021 23:02:37 +0000 Subject: [Koha-bugs] [Bug 29444] 404 Not Found pages come back as 200 OK under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29444 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 01:10:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 00:10:45 +0000 Subject: [Koha-bugs] [Bug 29420] 401 Unauthorized pages come back as 200 OK under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- Looking at Bug 26048, it looks like I added 200 OK for a reason, although it's not 100% clear to me why now. I suspect something weird with the HTTPExceptions or ErrorDocument modules. I suspect that this patch will stop Bug 26048 from working for 401. So if you're not using HTTP Basic Auth, you'll probably get the Plack generic error page instead of the Koha 401 error page. But I haven't checked yet. I'd suggest to QA to check whether the Koha error page flows through or if it's the Plack generic error message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 02:32:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 01:32:03 +0000 Subject: [Koha-bugs] [Bug 28611] Incorrect Select2 width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #17 from David Cook --- (In reply to Katrin Fischer from comment #10) > I understand the argument, but the visual was already changed by the newer > version of select2 that made the input fields too short in many cases. I > have seen library pull downs only showing like 3 letters of the branch names > :( I just saw this for the first time today and it's driving me crazy... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 02:43:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 01:43:08 +0000 Subject: [Koha-bugs] [Bug 29444] 404 Not Found pages come back as 200 OK under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29444 --- Comment #1 from David Cook --- This may really be a duplicate of Bug 29420, since the mechanism that uses status 200 OK might just need review with how it plays with other Plack middleware. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 08:42:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 07:42:50 +0000 Subject: [Koha-bugs] [Bug 24224] Convert OpacNavBottom system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 08:42:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 07:42:52 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 09:26:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 08:26:07 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Andreas Jonsson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson at kreablo.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 09:45:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 08:45:17 +0000 Subject: [Koha-bugs] [Bug 25387] Avoid merge different type of authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25387 --- Comment #13 from Katrin Fischer --- But why would you have to manually relink those if the used record is the winner? No changes in the bibliographic record woudl be necessary. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 09:47:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 08:47:50 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 --- Comment #7 from Katrin Fischer --- Hi David, that reads great. If you have a lot of patches coming, you could also use this as an omnibus bug and link the bugs that belong to it using the blocks and depends on fields. You can also use these fields to build a hierarchy that will be used when applying patches using git bz. Thx for your work, I know that script has grown a lot over the years! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 09:55:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 08:55:10 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126166|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize --- Created attachment 127498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127498&action=edit Bug 28854: Database update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 09:55:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 08:55:16 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126167|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize --- Created attachment 127499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127499&action=edit Bug 28854: DBIC Schema Updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 09:55:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 08:55:21 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126168|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize --- Created attachment 127500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127500&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point 1) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 2) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 3) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. TODO: Add Object Tests + API Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 09:55:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 08:55:26 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126169|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize --- Created attachment 127501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127501&action=edit Bug 28854: Add bundle content display to OPAC TODO: Move expand button to right like staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 09:55:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 08:55:31 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126170|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize --- Created attachment 127502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127502&action=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 09:55:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 08:55:36 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126171|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize --- Created attachment 127503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127503&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that the patron who lost the item is displayed 4) Checkin the lost item * The item should be marked as found and the items_lost_issue table should no longer contain a link to the issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 09:55:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 08:55:40 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126172|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize --- Created attachment 127504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127504&action=edit Bug 28854: Respect WhenLostChargeReplacementFee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 09:55:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 08:55:45 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126173|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize --- Created attachment 127505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127505&action=edit Bug 28854: Highlight bundle rows to clarify UI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 10:17:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 09:17:51 +0000 Subject: [Koha-bugs] [Bug 29343] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29343 stuardboard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stuardboard083 at gmail.com URL| |https://www.primotechy.com/ | |chime-customer-service/ --- Comment #1 from stuardboard --- Do you need a chime customer service number? Have you been searching for the chime customer service number then you need to stop your search because you have found the right site to get the chime customer service phone number. At this site you will get the chime customer service phone number within a click, yes you just have to click on this given link to get the customer service phone number. https://www.primotechy.com/chime-customer-service/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 10:20:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 09:20:50 +0000 Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #23 from Koha Team University Lyon 3 --- Hello, Is someone still working on this one? Indeed, the librarians from Lyon 3 university libraries complain about the retain of the barcode after the search.. Thanks Sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 10:31:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 09:31:23 +0000 Subject: [Koha-bugs] [Bug 29445] Checking replace cover image should actually replace cover image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29445 --- Comment #2 from Katrin Fischer --- Hi Esther, the "replace cover image" feature only applies for local cover images as they are stored in your database. You cannot use it to change covers that come from the Coce cover web service. Coce itself doesn't store cover images, but only caches the URLs to be able to provide them faster than having to check with the provider each time. What you'd need for that is a way to "alert" the Coce server about wrong images that are supplied by one of the providers it checks to "blacklist" them there. Or a way to say: never show a Coce cover for this record in Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 10:33:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 09:33:21 +0000 Subject: [Koha-bugs] [Bug 29445] Provide an option to not show Coce cover images on specific records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29445 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Checking replace cover |Provide an option to not |image should actually |show Coce cover images on |replace cover image |specific records -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 10:58:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 09:58:34 +0000 Subject: [Koha-bugs] [Bug 28611] Incorrect Select2 width In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 --- Comment #18 from Katrin Fischer --- (In reply to David Cook from comment #17) > (In reply to Katrin Fischer from comment #10) > > I understand the argument, but the visual was already changed by the newer > > version of select2 that made the input fields too short in many cases. I > > have seen library pull downs only showing like 3 letters of the branch names > > :( > > I just saw this for the first time today and it's driving me crazy... We set them to a wide width by default here, still waiting for aproper fix in the library I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 11:00:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 10:00:08 +0000 Subject: [Koha-bugs] [Bug 29343] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29343 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://www.primotechy.com/ | |chime-customer-service/ | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 11:11:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 10:11:38 +0000 Subject: [Koha-bugs] [Bug 29449] New: Show userid on "your personal details" tab Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 Bug ID: 29449 Summary: Show userid on "your personal details" tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org In the OPAC, the "your personal details" tab of a logged in user shows the card number, but not the userid. This is extra confusing for users who have their username generated in the firstname.surname form. I can't think of cases where a library would want to hide the userid from patrons, but if there are any arguments for this, there would have to be a syspref (or a per patron category setting?) to enable/disable the display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 11:13:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 10:13:16 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #35 from Katrin Fischer --- I tried to apply on 21.11.11 for testing and there are lots of conflicts right now - might need work for the maintenance branches: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29330: Add Koha::Email->new_from_string Using index info to reconstruct a base tree... M Koha/Email.pm M t/Koha/Email.t Falling back to patching base and 3-way merge... Auto-merging t/Koha/Email.t CONFLICT (content): Merge conflict in t/Koha/Email.t Auto-merging Koha/Email.pm CONFLICT (content): Merge conflict in Koha/Email.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 29330: Add Koha::Email->new_from_string The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-29330-Add-KohaEmail-newfromstring-R_84LL.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 11:19:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 10:19:34 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #36 from Katrin Fischer --- Actually these first conflicts are not so bad, the one in Letters.pm is the bad one I am failing to resolve. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 11:28:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 10:28:32 +0000 Subject: [Koha-bugs] [Bug 24382] Wrong information showing on detail pages for fines/fees and payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24382 --- Comment #1 from Martin Renvoize --- Bug 22435 considerably improved the clarity of the details page.. I think we can mark this one as resolved. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 11:28:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 10:28:40 +0000 Subject: [Koha-bugs] [Bug 24382] Wrong information showing on detail pages for fines/fees and payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24382 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 22435 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 11:28:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 10:28:40 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 --- Comment #219 from Martin Renvoize --- *** Bug 24382 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 11:28:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 10:28:41 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Bug 14825 depends on bug 24382, which changed state. Bug 24382 Summary: Wrong information showing on detail pages for fines/fees and payments https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24382 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 11:34:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 10:34:50 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 --- Comment #8 from Alex Arnaud --- Created attachment 127506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127506&action=edit Bug 29393 - add a dedicated letters module for add message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 11:49:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 10:49:22 +0000 Subject: [Koha-bugs] [Bug 29450] New: Allow flatPickr to instantiate in any order Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29450 Bug ID: 29450 Summary: Allow flatPickr to instantiate in any order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Currently, we automatically instantiate a flatPickr instance for any input fields that have the flatpickr class. This instantiation is handling within a loop and works well in most cases. However, if the the input is paired so we have a start/end date pair and the start date is pre-populated with the template you are faced with javascript errors. This is because the pre-populated value triggers our onClose function that resides in the instantiation settings. The onClose looks for the associated 'end' input and grabs the flatpickr instance to set the minDate property.. but as we've not yet hit the end input field the flatpicker instance for that field doesn't yet exist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 12:06:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 11:06:18 +0000 Subject: [Koha-bugs] [Bug 29450] Allow flatPickr to instantiate in any order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29450 --- Comment #1 from Martin Renvoize --- Created attachment 127507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127507&action=edit Bug 29450: Allow flatpickr to instantiate in any order This patch updates the flatpickr wrapper code to allow for cases where the startdate/enddate pickers are pre-populated and thus the onClose event of the startdate pickr may be fired before the enddate flatpickr is instantiated.. which leads to an error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 12:08:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 11:08:44 +0000 Subject: [Koha-bugs] [Bug 29450] Allow flatPickr to instantiate in any order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29450 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 12:08:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 11:08:44 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29450 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29450 [Bug 29450] Allow flatPickr to instantiate in any order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 12:08:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 11:08:52 +0000 Subject: [Koha-bugs] [Bug 29450] Allow flatPickr to instantiate in any order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29450 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 12:08:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 11:08:58 +0000 Subject: [Koha-bugs] [Bug 29450] Allow flatPickr to instantiate in any order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29450 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 12:15:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 11:15:38 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 --- Comment #8 from David Gustafsson --- Yes, I will make sure to mark the other patches (will probably only be one or two more besides 25539) as depending on this one, as far as I understand this is all I have to do to make this an omnibus bug? For reviewers of this patch, here is a short summary of the changes: Added an option 'defer_search_engine_indexing' to ModBiblio/Modbiblio marc, which is used in the script for avoiding indexing each item individually and to do so in bulk when changes are committed to the database. This is more efficient, and you don't run the same risk of ending up with junk data in the index if the script crashes and the current database transaction is rolled back. Instead of processing records in one loop, the processing is split up into two loops. The first one for pre-processing tasks (transcoding, filtering out broken records etc) that does not touch the database. This makes the code in the import loop cleaner, and it's also nice to have the option of bailing out before any database changes are committed (could for example add the option to abort the whole import if contains one or more invalid records). The rest of the changes more or less of fixing formatting/indentation, renaming some variables for clarity purposes, making error/log messages more consistent and generally just cleaning up the code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 12:17:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 11:17:01 +0000 Subject: [Koha-bugs] [Bug 29451] New: Merging records and authorities - log details for the delete action so it could be recreated Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29451 Bug ID: 29451 Summary: Merging records and authorities - log details for the delete action so it could be recreated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When logging is enabled for cataloging (CataloguingLog) and authorities (AuthoritiesLog), no details are shown for the deleted record or authority. The logs record a delete (with no details) and a modify entry for the merged item (with details). When merging records and authorities it would be good to have some of these available (depending on how complex they are to do): i) show for the log action that the delete and modify actions were as a result of a merge, not a standard deletion or modification, for example: Delete (merge), Modify (merge) ii) record the details in the log of the deleted item (just before it was deleted) so it could be restored or recreated (for example: if it was accidentally merged) iii) have a compare function (see bugs listed below) iv) have an undo merge function See this Twitter thread for more details: https://twitter.com/elafrula/status/1457650198939897856 Other bugs I could see which have some elements of this: * Bug 10417 - Add table to keep deleted authorities * Bug 26207 - Compare values of system preference log entries * Bug 26736 - Compare values of reports log entries * Bug 14233 - Add logging support to notices and slips management * Bug 28714 - Bib record change tracking action log -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 12:17:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 11:17:23 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127485|0 |1 is obsolete| | --- Comment #9 from David Gustafsson --- Created attachment 127508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127508&action=edit Bug 29440: Refactor and clean up bulkmarcimport.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 12:17:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 11:17:27 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127486|0 |1 is obsolete| | --- Comment #10 from David Gustafsson --- Created attachment 127509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127509&action=edit Bug 29440: Make authorities import behavior consistent with biblios The current behavior for when importing authorities, when match option is enabled, is to insert as a new authority fetching from db fails. This is both a bit confusing and not consistent with the biblio case where an error is generated. Also clean up error and log messages so both messages/errors and when messages/errors are issued are more consistent for the biblio and authority case. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 12:24:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 11:24:32 +0000 Subject: [Koha-bugs] [Bug 29447] authority that begins with a number isn't found in tag editor search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29447 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 12:44:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 11:44:54 +0000 Subject: [Koha-bugs] [Bug 29449] Show userid on "your personal details" tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 --- Comment #1 from Katrin Fischer --- We already have the "*unwanted*" prefs for the OPAC and they also already list userid, but it's not displayed according to it, like you say. I'd almost say that this is a bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 13:10:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 12:10:10 +0000 Subject: [Koha-bugs] [Bug 29451] Merging records and authorities - log details for the delete action so it could be recreated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29451 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28714 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 13:10:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 12:10:10 +0000 Subject: [Koha-bugs] [Bug 28714] Bib record change tracking action log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28714 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29451 CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 13:45:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 12:45:59 +0000 Subject: [Koha-bugs] [Bug 29435] OPAC authority details page broken when AuthDisplayHierarchy is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29435 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The OPAC authority details |OPAC authority details page |page is broken when |broken when |AuthDisplayHierarchy is |AuthDisplayHierarchy is |enabled |enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 13:51:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 12:51:56 +0000 Subject: [Koha-bugs] [Bug 29435] OPAC authority details page broken when AuthDisplayHierarchy is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29435 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 13:51:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 12:51:59 +0000 Subject: [Koha-bugs] [Bug 29435] OPAC authority details page broken when AuthDisplayHierarchy is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29435 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127440|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 127510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127510&action=edit Bug 29435: include missing subroutine from C4::AuthoritiesMarc The OPAC authority details page is broken when the 'AuthDisplayHierarchy' System Preference is set to 'Enable', This patch fixes that. Test plan: 1) Set AuthDisplayHierarchy to 'Enable' and try to view the details page of an authority in the OPAC -- the page is broken. 2) Apply this patch. 3) Refresh the page; this time the authority details are displayed. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 13:52:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 12:52:26 +0000 Subject: [Koha-bugs] [Bug 29435] OPAC authority details page broken when AuthDisplayHierarchy is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29435 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Depends on| |17600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 [Bug 17600] Standardize the EXPORT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 13:52:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 12:52:26 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29435 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29435 [Bug 29435] OPAC authority details page broken when AuthDisplayHierarchy is enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 14:09:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 13:09:56 +0000 Subject: [Koha-bugs] [Bug 29435] OPAC authority details page broken when AuthDisplayHierarchy is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29435 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 14:22:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 13:22:07 +0000 Subject: [Koha-bugs] [Bug 29452] New: unnecessary warns in the logs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29452 Bug ID: 29452 Summary: unnecessary warns in the logs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: christophe.croullebois at biblibre.com QA Contact: testopia at bugs.koha-community.org many lines : [WARN] Use of uninitialized value $value in substitution (s///) at /home/koha/src/C4/SIP/Sip.pm line 108 A simple add in sub maybe_add could correct that issue -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 14:23:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 13:23:20 +0000 Subject: [Koha-bugs] [Bug 29452] unnecessary warns in the logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29452 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |didier.gautheron at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 14:45:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 13:45:49 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 --- Comment #9 from Alex Arnaud --- Created attachment 127511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127511&action=edit Bug 29393 - Add send_messages_to_borrowers permission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 14:47:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 13:47:55 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 14:47:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 13:47:58 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 --- Comment #5 from Nick Clemens --- Created attachment 127512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127512&action=edit Bug 29437: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 14:48:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 13:48:02 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127460|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 127513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127513&action=edit Bug 29437: Search reservoir for term as title, author, or variations of ISBN The code in the script and the module attempt to determine whether a term is an isbn, or not. Rather than try to do this, we can simply search it on the three fields: isbn, title, author Additionally, we should search as any of the ISBN variations to broaden our matches Note: Curently only an ISBN 10 is stored in import biblios, so for an ISBN13 that doesn't convert the value will be blank - this is another bug To test: 1 - Perform a cataloging search for a valid ISBN 13 with no ISBN10 counterpart: 9798200834976 2 - 500 error 3 - Apply patch 4 - Repeat, no results 5 - Import some records 6 - Search by title/author/isbn 7 - Confirm searching works as expected WNC amended to fix spelling Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 15:09:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 14:09:11 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 15:41:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 14:41:15 +0000 Subject: [Koha-bugs] [Bug 16467] Discharge requests pending count should appear on patrons home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16467 --- Comment #3 from Katrin Fischer --- Hi Owen, I just stumbled on this again. I think what we could use something like this: Patron has requested to be discharged. Patron has requested a discharge. It's quite unfortunate, that it's not visible at all right now. The discharge debarment has it's own type we could use for making the message that displays after taking care of the request a bit more specific too: "Patron has been discharged" Does that work in English? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 16:21:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 15:21:32 +0000 Subject: [Koha-bugs] [Bug 28663] One should not be able to apply a discount to a VOID accountline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28663 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 16:21:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 15:21:43 +0000 Subject: [Koha-bugs] [Bug 28664] One should not be able to issue a refund against a VOID accountline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28664 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 16:21:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 15:21:53 +0000 Subject: [Koha-bugs] [Bug 28663] One should not be able to apply a discount to a VOID accountline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28663 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 16:21:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 15:21:57 +0000 Subject: [Koha-bugs] [Bug 28664] One should not be able to issue a refund against a VOID accountline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28664 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 16:26:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 15:26:59 +0000 Subject: [Koha-bugs] [Bug 27787] Point of Sale Receipt extra line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27787 --- Comment #6 from Martin Renvoize --- Bug 28374 resolves this too.. The issues is with how we record 'CREATE' offsets. You can either add in a condition to filter it out in the template or use the debits relation instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 16:27:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 15:27:21 +0000 Subject: [Koha-bugs] [Bug 27787] Point of Sale Receipt extra line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27787 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 16:27:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 15:27:22 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Bug 13985 depends on bug 27787, which changed state. Bug 27787 Summary: Point of Sale Receipt extra line https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27787 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 16:28:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 15:28:01 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, | |lucas at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 16:30:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 15:30:01 +0000 Subject: [Koha-bugs] [Bug 28544] Add API's for account transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28544 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 16:30:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 15:30:01 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28544 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28544 [Bug 28544] Add API's for account transactions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 16:30:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 15:30:34 +0000 Subject: [Koha-bugs] [Bug 28544] Add API's for account transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28544 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 |17596 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 [Bug 17596] Simplify accounting UI in staff client [OMNIBUS] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 16:30:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 15:30:34 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|28544 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28544 [Bug 28544] Add API's for account transactions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 16:30:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 15:30:34 +0000 Subject: [Koha-bugs] [Bug 17596] Simplify accounting UI in staff client [OMNIBUS] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28544 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28544 [Bug 28544] Add API's for account transactions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 16:32:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 15:32:21 +0000 Subject: [Koha-bugs] [Bug 28544] Add API's for account transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28544 --- Comment #1 from Martin Renvoize --- https://wiki.koha-community.org/wiki/Patrons_account_lines_endpoint_RFC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 16:32:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 15:32:58 +0000 Subject: [Koha-bugs] [Bug 29452] unnecessary warns in the logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29452 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |christophe.croullebois at bibl |ity.org |ibre.com CC| |christophe.croullebois at bibl | |ibre.com Status|NEW |Needs Signoff --- Comment #1 from Christophe Croullebois --- Created attachment 127514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127514&action=edit remove unnecessary warns in the logs Test plan : 1° do for example '9900802.00' as a self-check machine. 2° check the SIP logs (usually in /var/log/syslog) without the patch you must have many : [WARN] Use of uninitialized value $value in substitution (s///) at /home/koha/src/C4/SIP/Sip.pm line 108 3° apply the patch 4° re do '9900802.00' 5° check the logs => no more unnecessary warns thx -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 16:43:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 15:43:39 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 --- Comment #26 from David Gustafsson --- (In reply to Martin Renvoize from comment #25) > That's great news David, thankyou for getting back onto this.. Do feel free > to grab me to take a look when you need review etc :) Thanks a lot, that would be really helpful! Will let you know when is ready for review. Have pulled out code some code without properly testing that did not break things, so first try to do some manual testing. After that the patch in bug 29440 should be ready for review/sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 16:49:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 15:49:08 +0000 Subject: [Koha-bugs] [Bug 11873] Upgrade jstree jQuery plugin to the latest version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |--- Status|CLOSED |REOPENED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 16:49:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 15:49:39 +0000 Subject: [Koha-bugs] [Bug 11873] Upgrade jstree jQuery plugin to the latest version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff Client |Templates Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Blocks| |29155 Status|REOPENED |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155 [Bug 29155] Upgrade jquery version -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 16:49:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 15:49:39 +0000 Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11873 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 [Bug 11873] Upgrade jstree jQuery plugin to the latest version -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 16:53:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 15:53:56 +0000 Subject: [Koha-bugs] [Bug 11873] Upgrade jstree jQuery plugin to the latest version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29435 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29435 [Bug 29435] OPAC authority details page broken when AuthDisplayHierarchy is enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 16:53:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 15:53:56 +0000 Subject: [Koha-bugs] [Bug 29435] OPAC authority details page broken when AuthDisplayHierarchy is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29435 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11873 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 [Bug 11873] Upgrade jstree jQuery plugin to the latest version -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 17:08:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 16:08:40 +0000 Subject: [Koha-bugs] [Bug 29453] New: Add routes to fetch patron credits/debits Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 Bug ID: 29453 Summary: Add routes to fetch patron credits/debits Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com As the title says.. we should have API routes for fetching a patrons credits and debits by now ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 17:08:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 16:08:53 +0000 Subject: [Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28544 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28544 [Bug 28544] Add API's for account transactions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 17:08:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 16:08:53 +0000 Subject: [Koha-bugs] [Bug 28544] Add API's for account transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28544 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29453 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 [Bug 29453] Add routes to fetch patron credits/debits -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 17:08:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 16:08:58 +0000 Subject: [Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 17:17:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 16:17:31 +0000 Subject: [Koha-bugs] [Bug 11873] Upgrade jstree jQuery plugin to the latest version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 17:50:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 16:50:31 +0000 Subject: [Koha-bugs] [Bug 29454] New: Stash branches and itemtypes in plugin objects to reduce DB calls Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29454 Bug ID: 29454 Summary: Stash branches and itemtypes in plugin objects to reduce DB calls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Moved from bug 28436 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 17:51:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 16:51:20 +0000 Subject: [Koha-bugs] [Bug 29454] Stash branches and itemtypes in plugin objects to reduce DB calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29454 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 17:51:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 16:51:23 +0000 Subject: [Koha-bugs] [Bug 29454] Stash branches and itemtypes in plugin objects to reduce DB calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29454 --- Comment #1 from Nick Clemens --- Created attachment 127515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127515&action=edit Bug 29454: Add local cache to Template Plugins for branches and itemtypes This patch simply stores the branches an itemtypes in a hash for lookup. This improves efficiency on pages where we are loading many items To test: 1 - Add ~1000 items to a record 2 - Note load time 3 - Apply patch 4 - Reload and note faster load 5 - Edit a branchname/itemtype description 6 - Reload page 7 - Confirm the updated name is reflected in display -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 17:51:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 16:51:33 +0000 Subject: [Koha-bugs] [Bug 28436] Cache relatively static info that is used often and on many pages (instead of fetching from DB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28436 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124655|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 17:52:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 16:52:43 +0000 Subject: [Koha-bugs] [Bug 28436] Cache relatively static info that is used often and on many pages (instead of fetching from DB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28436 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nick at bywatersolutions.com |koha-bugs at lists.koha-commun | |ity.org Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 17:52:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 16:52:50 +0000 Subject: [Koha-bugs] [Bug 28436] Cache relatively static info that is used often and on many pages (instead of fetching from DB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28436 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 17:53:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 16:53:07 +0000 Subject: [Koha-bugs] [Bug 29454] Stash branches and itemtypes in plugin objects to reduce DB calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29454 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28436 Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 17:53:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 16:53:07 +0000 Subject: [Koha-bugs] [Bug 28436] Cache relatively static info that is used often and on many pages (instead of fetching from DB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28436 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29454 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 18:25:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 17:25:52 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127512|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 127516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127516&action=edit Bug 29437: Unit tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 18:25:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 17:25:56 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127513|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 127517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127517&action=edit Bug 29437: Search reservoir for term as title, author, or variations of ISBN The code in the script and the module attempt to determine whether a term is an isbn, or not. Rather than try to do this, we can simply search it on the three fields: isbn, title, author Additionally, we should search as any of the ISBN variations to broaden our matches Note: Curently only an ISBN 10 is stored in import biblios, so for an ISBN13 that doesn't convert the value will be blank - this is another bug To test: 1 - Perform a cataloging search for a valid ISBN 13 with no ISBN10 counterpart: 9798200834976 2 - 500 error 3 - Apply patch 4 - Repeat, no results 5 - Import some records 6 - Search by title/author/isbn 7 - Confirm searching works as expected WNC amended to fix spelling Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 18:28:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 17:28:32 +0000 Subject: [Koha-bugs] [Bug 11873] Upgrade jstree jQuery plugin to the latest version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 --- Comment #2 from Owen Leonard --- This patch is too large to attach, so I've pushed it to a GitLab branch: https://gitlab.com/koha-dev/koha-dev/-/tree/bug-11783-upgrade-jstree Bug 11873: Upgrade jstree jQuery plugin to the latest version This patch upgrades the jstree plugin in the OPAC and the staff interface. The old version had compatibility issues with the latest jQuery. Also changed: When viewing an authority record in the OPAC's MARC view, clicking one of the hierarchy links should now open the MARC view again rather than reverting to the normal view. To test, apply the patch and rebuild the staff interface and OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). To test you must have the AuthDisplayHierarchy system preference enabled, and you must have some authorities data which can be displayed as a hierarchy. From the test plan for Bug 8523: "Create authority records with a hierarchy of see also fields (in MARC21/NORMARC, you'll be using 5xx fields for this, with a subfield $w = 'g' for broader terms and subfield $w = 'h' for narrower terms)" - Perform an authority search in the OPAC which will return one of your modified authority records. - View the record. - There should be an expanded tree menu at the top of the authority information. - Clicking the arrows in the tree should correctly expand and collapse the nodes. - Clicking the authority record link in the node should load that record. - Test also from the OPAC's MARC view of the authority record. - Confirm that clicking an authority record link in the MARC view opens the corresponding record in MARC view again. - Perform the same tests in the staff interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 18:29:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 17:29:29 +0000 Subject: [Koha-bugs] [Bug 29455] New: 505$t - change in line break/display Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29455 Bug ID: 29455 Summary: 505$t - change in line break/display Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: sbrown at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In 20.05, multiple $t (or $t then $r) entries on the catalog detail page displayed on separate lines within the same 505 tag. On 21.05 they no longer do so - either ' -- ’ has to be added at the end of each $t to force a line break within the same 505, or they need to be separated into multiple 505s. This affects both the staff interface and the OPAC. Bug 19616 indicates that this is a correction rather than a new bug, but it’s an unexpected change in display/behavior nonetheless. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 18:29:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 17:29:29 +0000 Subject: [Koha-bugs] [Bug 19616] Add MARC21 505$g - Formatted Contents Note / Miscellaneous information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19616 Sara Brown changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29455 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 18:31:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 17:31:05 +0000 Subject: [Koha-bugs] [Bug 29455] 505$t - change in line break/display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29455 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 20:17:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 19:17:12 +0000 Subject: [Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean search and so results in error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 --- Comment #5 from Andrew Fuerste-Henry --- If you're not using analytics at all and want to just hide this error, you could put this in your intranetuserCSS: /* Hide analytics error */ .analytics_error { display: none; } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 20:41:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 19:41:32 +0000 Subject: [Koha-bugs] [Bug 29456] New: Notice overview on Patron Category Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Bug ID: 29456 Summary: Notice overview on Patron Category Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 127518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127518&action=edit visual When looking at the Patron Category overview, a library gets a glimpse at all the pieces of that patron category. One of the pieces is the summary of notices, currently, the last notice that is listed is called "unknown'- which should be named "auto-renew- see screenshot. This should have the correct text instead of unknown. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 20:45:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 19:45:23 +0000 Subject: [Koha-bugs] [Bug 28663] One should not be able to apply a discount to a VOID accountline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28663 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #2 from David Nind --- Created attachment 127519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127519&action=edit Bug 28663 - Screenshot - For me (see screenshot) there is no apply discount button for the void transaction. Also, the patch doesn't apply 8-(.. Applying: Bug 28663: Prevent discounts against void lines Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 28663: Prevent discounts against void lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 20:45:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 19:45:41 +0000 Subject: [Koha-bugs] [Bug 28663] One should not be able to apply a discount to a VOID accountline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28663 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 20:46:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 19:46:41 +0000 Subject: [Koha-bugs] [Bug 28663] One should not be able to apply a discount to a VOID accountline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28663 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127519|Bug 28663 - Screenshot - |Bug 28663 - Screenshot description| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 20:56:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 19:56:49 +0000 Subject: [Koha-bugs] [Bug 28664] One should not be able to issue a refund against a VOID accountline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28664 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david at davidnind.com --- Comment #2 from David Nind --- Patch doesn't apply 8-(.. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 28664: Prevent redunfs against void lines Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 28664: Prevent redunfs against void lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 22:18:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 21:18:09 +0000 Subject: [Koha-bugs] [Bug 20397] Implement Content Security Policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 22:28:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 21:28:40 +0000 Subject: [Koha-bugs] [Bug 20397] Implement Content Security Policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #1 from Liz Rea --- This is feeling more urgent nowadays, who has a thought on how they'd like to go about it? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 10 22:44:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 21:44:18 +0000 Subject: [Koha-bugs] [Bug 28712] Printed slips for fees come up empty if no notice is defined for the user's preferred language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28712 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #7 from David Nind --- I had a go at testing on 21.05, but I wasn't able to reproduce the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:04:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:04:30 +0000 Subject: [Koha-bugs] [Bug 29454] Stash branches and itemtypes in plugin objects to reduce DB calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29454 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:04:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:04:34 +0000 Subject: [Koha-bugs] [Bug 29454] Stash branches and itemtypes in plugin objects to reduce DB calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29454 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127515|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 127520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127520&action=edit Bug 29454: Add local cache to Template Plugins for branches and itemtypes This patch simply stores the branches an itemtypes in a hash for lookup. This improves efficiency on pages where we are loading many items To test: 1 - Add ~1000 items to a record 2 - Note load time 3 - Apply patch 4 - Reload and note faster load 5 - Edit a branchname/itemtype description 6 - Reload page 7 - Confirm the updated name is reflected in display Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:21:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:21:36 +0000 Subject: [Koha-bugs] [Bug 29454] Stash branches and itemtypes in plugin objects to reduce DB calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29454 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes using koha-testing-docker. I found that for the detail page for the record in the staff interface that the load time with 1,001 items was significantly improved. On the edit items page I didn't notice much, if any, improvement. After the patch was applied I did a flush_memcached and restart_all, but not fater changing the item type and library names. Curious as to why we don't use pagination when the there are lots of items, on the dipslay item page in the staff interface and OPAC. Some numbers (a bit variable, but generally around the same) - YMMV: Before patch applied ~~~~~~~~~~~~~~~~~~~~ Item page in the staff interface: 1027 requests 6.74 MB / 49.24 KB transferred Finish: 20.45 s DOMContentLoaded: 18.52 s load: 20.01 s Edit items: 25 requests 5.50 MB / 82.78 KB transferred Finish: 1.10 min DOMContentLoaded: 1.10 min load: 1.12 min After the patch applied ~~~~~~~~~~~~~~~~~~~~~~~ Item page: 1030 requests 7.19 MB / 970.08 KB transferred Finish: 17.07 s DOMContentLoaded: 14.66 s load: 16.11 s Edit items page: 27 requests 5.63 MB / 107.81 KB transferred Finish: 56.97 s DOMContentLoaded: 56.77 s load: 58.19 s After the patch applied and change to item type and library names ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Used the refresh button. Item page: 1027 requests 7.21 MB / 48.92 KB transferred Finish: 17.27 s DOMContentLoaded: 15.27 s load: 16.87 s Edit items: 36 requests 6.40 MB / 1.24 MB transferred Finish: 1.10 min DOMContentLoaded: 1.09 min load: 1.12 min -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:26:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:26:29 +0000 Subject: [Koha-bugs] [Bug 28470] Typo: Are you sure you with to chart this report? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28470 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:28:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:28:01 +0000 Subject: [Koha-bugs] [Bug 28579] Typo: No record have been imported because they all match an existing record in your catalog. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28579 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:29:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:29:20 +0000 Subject: [Koha-bugs] [Bug 29213] Typo ol in member-alt-contact-style.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29213 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:31:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:31:30 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.hafen at washk12.org --- Comment #43 from Michael Hafen --- Created attachment 127521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127521&action=edit 21.05.x: Bug 28870: Regression tests Hope this is ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:32:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:32:06 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #44 from Michael Hafen --- Created attachment 127522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127522&action=edit 21.05.x: Bug 28870: Use Email::Address to validate email addresses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:32:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:32:46 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #45 from Michael Hafen --- Created attachment 127523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127523&action=edit 21.05.x: Bug 28870: Remove traces of Email::Valid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:33:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:33:16 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #46 from Michael Hafen --- Created attachment 127524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127524&action=edit 21.05.x: Bug 28870: Move email address validation to a specific class method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:33:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:33:27 +0000 Subject: [Koha-bugs] [Bug 28585] Cannot search on date fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #38 from Fridolin Somers --- I tried to apply on 20.11.x but tests fail. Can you try to rebase please ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:33:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:33:46 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #47 from Michael Hafen --- Created attachment 127525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127525&action=edit 21.05.x: Bug 28870: Use Email::Address->parse -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:34:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:34:09 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #48 from Michael Hafen --- Created attachment 127526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127526&action=edit 21.05.x: Bug 28870: non-FQDN addresses are valid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:35:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:35:55 +0000 Subject: [Koha-bugs] [Bug 29306] Holds.t: Fix Use of uninitialized value $_ in concatenation (.) or string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29306 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:37:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:37:16 +0000 Subject: [Koha-bugs] [Bug 29227] Patron messaging preferences digest show as editable but are not In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29227 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:39:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:39:10 +0000 Subject: [Koha-bugs] [Bug 29309] 'Pay all fines' should be 'Pay all charges' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29309 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #12 from Fridolin Somers --- I prefer not to push to 20.11.x to minimize translation work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:40:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:40:49 +0000 Subject: [Koha-bugs] [Bug 29315] Remove warnings from Search.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29315 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #4 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:43:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:43:54 +0000 Subject: [Koha-bugs] [Bug 29286] Typo: Librarien will need the manage_auth_values subpermission. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29286 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin Somers --- Is in 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:44:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:44:08 +0000 Subject: [Koha-bugs] [Bug 29286] Typo: Librarien will need the manage_auth_values subpermission. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29286 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:45:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:45:35 +0000 Subject: [Koha-bugs] [Bug 26374] Update for 19974 is not idempotent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26374 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:46:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:46:41 +0000 Subject: [Koha-bugs] [Bug 29272] API not respecting $category->effective_change_password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29272 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #16 from Fridolin Somers --- It is in 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:47:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:47:58 +0000 Subject: [Koha-bugs] [Bug 29272] API not respecting $category->effective_change_password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29272 --- Comment #17 from Fridolin Somers --- Does not apply on 20.11.x Please provide a rebase if needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:50:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:50:03 +0000 Subject: [Koha-bugs] [Bug 29218] "hidden" class is not working for DT if column visibility button is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29218 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- (In reply to Kyle M Hall from comment #5) > Pushed to 21.05.x for 21.05.05 Oh, depends on 28349 that is not in 21.05.x Is it still correct to backport it ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:51:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:51:17 +0000 Subject: [Koha-bugs] [Bug 29300] Release team 22.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29300 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:52:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:52:27 +0000 Subject: [Koha-bugs] [Bug 28613] Several objects.search-based routes missing parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28613 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers --- It will be in 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:53:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:53:44 +0000 Subject: [Koha-bugs] [Bug 28613] Several objects.search-based routes missing parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28613 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.06 released in| | --- Comment #7 from Fridolin Somers --- It will be in 21.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 00:58:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Nov 2021 23:58:01 +0000 Subject: [Koha-bugs] [Bug 29272] API not respecting $category->effective_change_password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29272 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.06 released in| | --- Comment #18 from Fridolin Somers --- It will be in 21.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 01:00:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 00:00:58 +0000 Subject: [Koha-bugs] [Bug 28613] Several objects.search-based routes missing parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28613 --- Comment #8 from Fridolin Somers --- Depends on Bug 28480 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 01:07:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 00:07:18 +0000 Subject: [Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |28189 --- Comment #87 from Fridolin Somers --- Ah patches does not apply in 20.11.x because of Bug 28189 Can you try to provide rebased patches ? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28189 [Bug 28189] Move the base swagger file to YAML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 01:07:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 00:07:18 +0000 Subject: [Koha-bugs] [Bug 28189] Move the base swagger file to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28189 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17314 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 [Bug 17314] Routes to create, list and delete a purchase suggestion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 01:10:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 00:10:37 +0000 Subject: [Koha-bugs] [Bug 29363] TestBuilder.t failing if biblionumber=123 does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29363 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | --- Comment #4 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 01:12:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 00:12:04 +0000 Subject: [Koha-bugs] [Bug 29364] Search.t not reverting changes made to the framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29364 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 01:34:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 00:34:42 +0000 Subject: [Koha-bugs] [Bug 28573] Replace authority record with Z39.50/SRU creates new authority record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |23302 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 [Bug 23302] Less clicks on Z3950 search results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 01:34:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 00:34:42 +0000 Subject: [Koha-bugs] [Bug 23302] Less clicks on Z3950 search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28573 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 [Bug 28573] Replace authority record with Z39.50/SRU creates new authority record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 01:34:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 00:34:44 +0000 Subject: [Koha-bugs] [Bug 11350] Holds offered to patrons who are not allowed to put the item on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11350 Sara Brown changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbrown at bywatersolutions.com Version|unspecified |21.05 --- Comment #4 from Sara Brown --- I'm seeing this on 21.05.04. Settings: -ReservesControlBranch set to 'item's home library' -Patron X created in category LIMITED with home library EAST -Circ rules at library EAST allow category LIMITED patrons to place holds on item type ADULTBOOK -Circ rules at library WEST prevent category LIMITED patrons from placing holds on item type BOOK -Bib 999 has items with itype ADULTBOOK (all home library EAST) and BOOK (all home library WEST) Steps: -Make ADULTBOOK copy of bib 999 unavailable via checkout to unrelated patron (etc.) -Place bib-level hold on bib 999 for patron X - WEST-owned BOOK copy shows correctly as unavailable for item-level hold in 'Place a hold on a specific item' section Then both: -The WEST-owned BOOK copy of bib 999 appears on WEST's next holds queue run for patron X, and also -Checking in the BOOK copy of bib 999 triggers the hold for patron X -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 01:34:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 00:34:59 +0000 Subject: [Koha-bugs] [Bug 28573] Replace authority record with Z39.50/SRU creates new authority record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 --- Comment #20 from Fridolin Somers --- Depends on Bug 23302 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 01:36:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 00:36:56 +0000 Subject: [Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices between different orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #17 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 01:38:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 00:38:56 +0000 Subject: [Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #13 from Fridolin Somers --- > We have been restarting SIP nightly for years ourselves Same at BibLibre ^^ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 01:39:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 00:39:20 +0000 Subject: [Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | --- Comment #14 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 01:42:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 00:42:42 +0000 Subject: [Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |23166 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 [Bug 23166] Simplify code related to orders in catalogue/*detail.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 01:42:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 00:42:42 +0000 Subject: [Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29283 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 [Bug 29283] Cannot delete basket with cancelled order for deleted biblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 01:43:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 00:43:45 +0000 Subject: [Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 --- Comment #7 from Fridolin Somers --- Depends on Bug 23166 which added filter_by_current() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 01:44:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 00:44:30 +0000 Subject: [Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | --- Comment #8 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 01:48:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 00:48:12 +0000 Subject: [Koha-bugs] [Bug 29152] Change to default search behavior when limiting by branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29152 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Depends on Bug 21249 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 02:05:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 01:05:54 +0000 Subject: [Koha-bugs] [Bug 28436] Cache relatively static info that is used often and on many pages (instead of fetching from DB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28436 --- Comment #8 from Fridolin Somers --- Duplicate of Bug 29454 no ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 02:06:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 01:06:52 +0000 Subject: [Koha-bugs] [Bug 29223] Auto-renewals can fail when not digested per branch and patron requests digest In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29223 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00 |21.11.00,21.05.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #11 from Fridolin Somers --- Will be in 21.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 02:07:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 01:07:09 +0000 Subject: [Koha-bugs] [Bug 29223] Auto-renewals can fail when not digested per branch and patron requests digest In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29223 --- Comment #12 from Fridolin Somers --- Depends on Bug 28581 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 02:08:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 01:08:03 +0000 Subject: [Koha-bugs] [Bug 28913] Automatic checkin setting in item type setup should note required cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28913 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin Somers --- Depends on Bug 23207 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 02:08:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 01:08:52 +0000 Subject: [Koha-bugs] [Bug 29075] OPAC info should not be displayed in libraries table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Fridolin Somers --- Will be in 21.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 02:16:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 01:16:48 +0000 Subject: [Koha-bugs] [Bug 29075] OPAC info should not be displayed in libraries table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.06 |21.11.00,21.05.06,20.11.12 released in| | --- Comment #11 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 02:19:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 01:19:26 +0000 Subject: [Koha-bugs] [Bug 29350] TT method 'delete' don't need to be escaped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29350 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #4 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 02:20:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 01:20:36 +0000 Subject: [Koha-bugs] [Bug 29319] Errors when doing a cataloging search which starts with a number + letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29319 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #12 from Fridolin Somers --- I prefer not to push on 20.11.x to keep stable behavior in cataloguing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 02:22:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 01:22:20 +0000 Subject: [Koha-bugs] [Bug 28910] Correct eslint errors in OPAC basket.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28910 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Removes some methods, I prefer not to push in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 02:31:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 01:31:08 +0000 Subject: [Koha-bugs] [Bug 29328] Add missing list parameter to reports parameter menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29328 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Depends on Bug 27380 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 02:35:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 01:35:05 +0000 Subject: [Koha-bugs] [Bug 29352] Runtime parameter labels should not be said to be optional In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29352 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Depends on Bug 27644 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 02:36:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 01:36:50 +0000 Subject: [Koha-bugs] [Bug 25459] In patron cards layout, barcode position doesn't respect units In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25459 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 02:38:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 01:38:41 +0000 Subject: [Koha-bugs] [Bug 27884] Add HTML mail support for patron emailer script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | --- Comment #17 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 02:39:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 01:39:40 +0000 Subject: [Koha-bugs] [Bug 29329] stray "s" in opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29329 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 02:42:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 01:42:17 +0000 Subject: [Koha-bugs] [Bug 28904] Update information on Newsletter editor on about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28904 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #20 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 02:43:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 01:43:23 +0000 Subject: [Koha-bugs] [Bug 28729] Return-path header not set in emails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #61 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 02:46:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 01:46:39 +0000 Subject: [Koha-bugs] [Bug 28470] Typo: Are you sure you with to chart this report? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28470 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #7 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 02:46:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 01:46:43 +0000 Subject: [Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 02:48:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 01:48:32 +0000 Subject: [Koha-bugs] [Bug 28973] Improve Koha::Patron::can_see_patron_infos efficiency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28973 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18403 CC| |fridolin.somers at biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 02:48:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 01:48:32 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28973 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28973 [Bug 28973] Improve Koha::Patron::can_see_patron_infos efficiency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 02:48:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 01:48:47 +0000 Subject: [Koha-bugs] [Bug 28973] Improve Koha::Patron::can_see_patron_infos efficiency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28973 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | --- Comment #7 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 02:50:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 01:50:02 +0000 Subject: [Koha-bugs] [Bug 28474] Pass process_message_queue.pl params to before_send_messages plugin hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28474 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24183 CC| |fridolin.somers at biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24183 [Bug 24183] Introduce `before_send_messages` hook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 02:50:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 01:50:02 +0000 Subject: [Koha-bugs] [Bug 24183] Introduce `before_send_messages` hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24183 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28474 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28474 [Bug 28474] Pass process_message_queue.pl params to before_send_messages plugin hooks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 02:59:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 01:59:46 +0000 Subject: [Koha-bugs] [Bug 28436] Cache relatively static info that is used often and on many pages (instead of fetching from DB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28436 --- Comment #9 from David Cook --- (In reply to Fridolin Somers from comment #8) > Duplicate of Bug 29454 no ? Yeah I'm not sure why that was opened as a new one.. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 09:50:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 08:50:40 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at hypern | |ova.fi --- Comment #521 from Olli-Antti Kivilahti --- Bug 11175, we have gone such a long way together. I am so proud of you, our bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 09:58:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 08:58:38 +0000 Subject: [Koha-bugs] [Bug 28712] Printed slips for fees come up empty if no notice is defined for the user's preferred language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28712 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |20.11 --- Comment #8 from Katrin Fischer --- I think the dependency is in 21.05 - we have run into this in 20.11. I have corrected the version on the bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 11:26:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 10:26:12 +0000 Subject: [Koha-bugs] [Bug 28712] Printed slips for fees come up empty if no notice is defined for the user's preferred language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28712 --- Comment #9 from David Nind --- (In reply to Katrin Fischer from comment #8) > I think the dependency is in 21.05 - we have run into this in 20.11. I have > corrected the version on the bug. Thanks Katrin! I was able to recreate the issue on 20.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 11:55:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 10:55:23 +0000 Subject: [Koha-bugs] [Bug 29457] New: Fee Cancellation records the wrong manager_id Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Bug ID: 29457 Summary: Fee Cancellation records the wrong manager_id Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org With the introduction of bug 22008 it has highlighted an error in the charge cancellation controller. We are passing '$user', which contains cardnumber/userid, to cancel when we should be passing a borrowernumber. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 11:57:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 10:57:50 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #1 from Martin Renvoize --- Created attachment 127527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127527&action=edit Bug 29457: Pass context borrowernumber This patch updates the call to cancel such that we pass the currently logged in users borrowernumber instead of their userid. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 11:58:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 10:58:04 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 11:58:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 10:58:08 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 11:59:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 10:59:51 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #2 from Martin Renvoize --- Without the above patch, cancelling a charge in the worst case can lead to a database error regarding key constrain failures.. or if your userid's happen to coincide with an existing borrowernumber it will record entirely the wrong user as the staff member who actioned the cancellation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 12:02:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 11:02:27 +0000 Subject: [Koha-bugs] [Bug 29458] New: Show login button consistently in relation to login instructions, reset and register links Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Bug ID: 29458 Summary: Show login button consistently in relation to login instructions, reset and register links Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Modal form from masthead: Usercode Password Instructions Reset Register Login opac-auth (click Login from home page): Usercode Password Login Reset Instructions Register opac-main: Usercode Password Login Instructions Reset Register I would suggest to follow the pattern from the home page. After entering usercode and password, next step is normally click Login. Below that offer Instructions, Reset and Register. Do the same on modal and opac-auth. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 12:26:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 11:26:48 +0000 Subject: [Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26636 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26636 [Bug 26636] Add objects.find Mojolicious helper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 12:26:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 11:26:48 +0000 Subject: [Koha-bugs] [Bug 26636] Add objects.find Mojolicious helper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26636 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17314 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 [Bug 17314] Routes to create, list and delete a purchase suggestion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 12:34:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 11:34:14 +0000 Subject: [Koha-bugs] [Bug 26636] Add objects.find Mojolicious helper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26636 --- Comment #28 from Tomás Cohen Arazi --- Created attachment 127528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127528&action=edit Bug 26636: Add tests [20.11.x] This patch adds tests for the new objects.find helper. Sponsored-by: Virginia Polytechnic Institute and State University Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 12:34:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 11:34:29 +0000 Subject: [Koha-bugs] [Bug 26636] Add objects.find Mojolicious helper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26636 --- Comment #29 from Tomás Cohen Arazi --- Created attachment 127529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127529&action=edit Bug 26636: Add objects.find helper [20.11.x] This patch adds the objects.find helper. Much like objects.search, it returns the to_api method with embedded. Sponsored-by: Virginia Polytechnic Institute and State University Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 12:34:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 11:34:36 +0000 Subject: [Koha-bugs] [Bug 26636] Add objects.find Mojolicious helper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26636 --- Comment #30 from Tomás Cohen Arazi --- Created attachment 127530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127530&action=edit Bug 26636: (QA follow-up) Add POD [20.11.x] Sponsored-by: Virginia Polytechnic Institute and State University Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 12:34:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 11:34:42 +0000 Subject: [Koha-bugs] [Bug 26636] Add objects.find Mojolicious helper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26636 --- Comment #31 from Tomás Cohen Arazi --- Created attachment 127531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127531&action=edit Bug 26636: Regression tests for undef case [20.11.x] This patch adds tests for the case in which there's no object identified by the supplied $id. It should return undef. Sponsored-by: Virginia Polytechnic Institute and State University Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 12:34:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 11:34:48 +0000 Subject: [Koha-bugs] [Bug 26636] Add objects.find Mojolicious helper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26636 --- Comment #32 from Tomás Cohen Arazi --- Created attachment 127532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127532&action=edit Bug 26636: (QA follow-up) Handle no results correctly [20.11.x] Sponsored-by: Virginia Polytechnic Institute and State University Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 12:36:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 11:36:52 +0000 Subject: [Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #88 from Tomás Cohen Arazi --- Created attachment 127533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127533&action=edit Bug 17314: Make TestBuilder set good defaults for Suggestions [20.11.x] Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 12:37:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 11:37:03 +0000 Subject: [Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #89 from Tomás Cohen Arazi --- Created attachment 127534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127534&action=edit Bug 17314: Unit tests [20.11.x] Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 12:37:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 11:37:10 +0000 Subject: [Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #90 from Tomás Cohen Arazi --- Created attachment 127535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127535&action=edit Bug 17314: OpenAPI spec [20.11.x] Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 12:37:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 11:37:17 +0000 Subject: [Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #91 from Tomás Cohen Arazi --- Created attachment 127536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127536&action=edit Bug 17314: Implement /suggestions routes [20.11.x] This patch introduces routes to handle purchase suggestions, from the staff POV. Tests are added as well. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/api/v1/suggestions.t => SUCCESS: Tests pass! And they are meaningful! 3. Play with your favourite REST tool (Postman?) 4. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 12:39:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 11:39:51 +0000 Subject: [Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #92 from Tomás Cohen Arazi --- I added a missing dependency, bug 26636. Patches for both this bug and its dependency have been adapted/rebased to 20.11.x. Bug 26636 itself is pretty self-contained and I confider it harmless. The worst thing that could happen is that tests can fail (they don't) as the helper it adds is only used on this bug (for 20.11.x). And this bug is pretty self-contained too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:09:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:09:04 +0000 Subject: [Koha-bugs] [Bug 28664] One should not be able to issue a refund against a VOID accountline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28664 --- Comment #3 from Martin Renvoize --- Created attachment 127537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127537&action=edit Bug 28664: Prevent refunds against void lines With the introduction of double entry accounting for VOID actions, we need to add an additional filter to the 'Issue refund' button appearance Test plan 1/ Add a debt 2/ Pay the debt 3/ Void the payment 4/ Confirm that with the patch applied the 'Issue refund' button doesn not appear on the 'Void' accountline. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:09:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:09:51 +0000 Subject: [Koha-bugs] [Bug 28664] One should not be able to issue a refund against a VOID accountline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28664 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #4 from Martin Renvoize --- Always moving is our Koha!... :) Rebased, thanks for looking David. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:10:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:10:02 +0000 Subject: [Koha-bugs] [Bug 28664] One should not be able to issue a refund against a VOID accountline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28664 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122587|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:18:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:18:11 +0000 Subject: [Koha-bugs] [Bug 28663] One should not be able to apply a discount to a VOID accountline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28663 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122588|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 127538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127538&action=edit Bug 28663: Prevent discounts against void lines With the introduction of double entry accounting for VOID actions, we need to add an additional filter to the 'Apply discount' button appearance Test plan 1/ Add a debt 2/ Pay the debt 3/ Void the payment 4/ Confirm that with the patch applied the 'Apply discount' button does not appear on the 'Void' accountline. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:21:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:21:41 +0000 Subject: [Koha-bugs] [Bug 28663] One should not be able to apply a discount to a VOID accountline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28663 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #4 from Martin Renvoize --- The logic is currently: CAN_user_updatecharges_discount && account.is_debit && ( account.amountoutstanding == account.amount ) && !(account.debit_type_code == 'PAYOUT') But a void is pretty much always applied immediately so the `account.amountoutstanding == account.amount` sohuldn't ever pass.. I have a feeling when I wrote this that there was a particular way to end up with it showing.. like a series of actions that would partially undo the void.. maybe now. I've rebased anyway.. but maybe leave this one for now.. marking back to minor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:21:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:21:49 +0000 Subject: [Koha-bugs] [Bug 28663] One should not be able to apply a discount to a VOID accountline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28663 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:23:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:23:18 +0000 Subject: [Koha-bugs] [Bug 29386] background jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #14 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:25:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:25:25 +0000 Subject: [Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:27:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:27:26 +0000 Subject: [Koha-bugs] [Bug 28768] OPAC reading history page (opac-readingrecord.pl) wont display news items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28768 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #12 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:28:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:28:28 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:29:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:29:33 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #21 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:32:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:32:55 +0000 Subject: [Koha-bugs] [Bug 28413] background job worker is running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:32:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:32:56 +0000 Subject: [Koha-bugs] [Bug 28410] Reduce memory footprint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410 Bug 28410 depends on bug 28413, which changed state. Bug 28413 Summary: background job worker is running with all the modules in RAM https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:33:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:33:10 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:33:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:33:11 +0000 Subject: [Koha-bugs] [Bug 29412] Fix uncertain years before 1000 AD in copyrightdate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29412 Bug 29412 depends on bug 24674, which changed state. Bug 24674 Summary: Uncertain years for publicationyear/copyrightdate -- corrected https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:33:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:33:53 +0000 Subject: [Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:34:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:34:12 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:34:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:34:13 +0000 Subject: [Koha-bugs] [Bug 24224] Convert OpacNavBottom system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 Bug 24224 depends on bug 24223, which changed state. Bug 24223 Summary: Convert OpacNav system preference to news block https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:34:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:34:13 +0000 Subject: [Koha-bugs] [Bug 26050] [OMNIBUS] Convert system preferences to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26050 Bug 26050 depends on bug 24223, which changed state. Bug 24223 Summary: Convert OpacNav system preference to news block https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:34:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:34:33 +0000 Subject: [Koha-bugs] [Bug 24224] Convert OpacNavBottom system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:34:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:34:34 +0000 Subject: [Koha-bugs] [Bug 26050] [OMNIBUS] Convert system preferences to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26050 Bug 26050 depends on bug 24224, which changed state. Bug 24224 Summary: Convert OpacNavBottom system preference to news block https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:34:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:34:56 +0000 Subject: [Koha-bugs] [Bug 29430] Table cell click doesn't activate buttons in patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29430 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:35:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:35:16 +0000 Subject: [Koha-bugs] [Bug 29404] Add infinite scrolling to pickup location dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:35:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:35:16 +0000 Subject: [Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Bug 29407 depends on bug 29404, which changed state. Bug 29404 Summary: Add infinite scrolling to pickup location dropdowns https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:35:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:35:33 +0000 Subject: [Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:35:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:35:33 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Bug 29397 depends on bug 29407, which changed state. Bug 29407 Summary: Make the pickup locations dropdown JS reusable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:36:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:36:01 +0000 Subject: [Koha-bugs] [Bug 29429] Cannot close budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29429 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:36:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:36:40 +0000 Subject: [Koha-bugs] [Bug 29195] Highlighting broken on odd rows in circ-patron-search-results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29195 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #7 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:38:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:38:08 +0000 Subject: [Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 13:56:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 12:56:07 +0000 Subject: [Koha-bugs] [Bug 28712] Printed slips for fees come up empty if no notice is defined for the user's preferred language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28712 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from David Nind --- I still get a blank PDF - changed the default to english, also installed and de-DE, but PDF still blank. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 14:53:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 13:53:49 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 14:53:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 13:53:53 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #1 from Marcel de Rooy --- Created attachment 127539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127539&action=edit Bug 29458: Reorder login elements Make masthead.inc modal and opac-auth follow the order of the login elements on the homepage. Test plan: Enable prefs for reset password and self registration. Fill additional contents for login instructions. Logout on OPAC. Click Login from your account on top bar. Click Login button on the home page (right side, in the middle). Verify that these two forms correspond with the home page login. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 14:54:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 13:54:06 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 15:36:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 14:36:16 +0000 Subject: [Koha-bugs] [Bug 29459] New: Replace some missed datetimepickers in circulation templates with Flatpickr Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29459 Bug ID: 29459 Summary: Replace some missed datetimepickers in circulation templates with Flatpickr Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, jonathan.druart+koha at gmail.com, koha-bugs at lists.koha-community.org, nugged at gmail.com, testopia at bugs.koha-community.org Blocks: 29239 My search of the source code for "datepicker" missed some places which referenced only "datetimepicker," resulting in these missed instances: - Circulation -> Check out -> Override renewal restrictions -> "Renewal due date" and "On hold due date." - Check in -> Checkin settings -> Specify return date - ILL requests -> Check out -> Due date. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 15:36:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 14:36:16 +0000 Subject: [Koha-bugs] [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29459 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29459 [Bug 29459] Replace some missed datetimepickers in circulation templates with Flatpickr -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 15:42:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 14:42:04 +0000 Subject: [Koha-bugs] [Bug 24866] Display budget hierarchy in the budget dropdown menu used when placing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #17 from Martin Renvoize --- I'm wondering whether we should convert the select to a select2 input? Then we can go back to using CSS ;) https://stackoverflow.com/questions/30820215/selectable-optgroups-in-select2#30948247 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 15:52:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 14:52:25 +0000 Subject: [Koha-bugs] [Bug 29452] unnecessary warns in the logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29452 --- Comment #2 from Martin Renvoize --- Created attachment 127540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127540&action=edit Bug 29452: remove unnecessary warns in the logs Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 15:56:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 14:56:18 +0000 Subject: [Koha-bugs] [Bug 29452] unnecessary warns in the logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29452 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127540|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 127541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127541&action=edit Bug 29452: remove unnecessary warns in the logs Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 15:56:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 14:56:58 +0000 Subject: [Koha-bugs] [Bug 29452] unnecessary warns in the logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29452 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Clear fix, works as expected.. Trivial patch. Going straight for QA.. Passed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 15:57:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 14:57:10 +0000 Subject: [Koha-bugs] [Bug 29452] unnecessary warns in the logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29452 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 15:57:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 14:57:20 +0000 Subject: [Koha-bugs] [Bug 29452] unnecessary warns in the logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29452 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127514|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 16:07:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 15:07:03 +0000 Subject: [Koha-bugs] [Bug 27613] Pipe separated online resource links are hard to customize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127453|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 127542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127542&action=edit Bug 27613: Change pipe seperated online resource links to psuedo elements To test: 1. Have a record with many 856 links 2. Look at the links on both the results and detail pages. 3. Look at the '|' and notice it is outside any HTML element, making it hard to remove. 4. Apply the patch and regenerate the CSS 5. Look at both the pages again and notice that the '|' is now a psuedo element. 6. It should look identical to the way it did without the patch 7. Switch the system pref OPACURLOpenInNewWindow to 'do' and make sure the the links look and function right still. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 16:07:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 15:07:07 +0000 Subject: [Koha-bugs] [Bug 27613] Pipe separated online resource links are hard to customize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127454|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 127543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127543&action=edit Bug 27613: (follow-up) Modify additional repeating entries for consistency This patch makes further changes to the detail and results XSLT in the OPAC so that previously pipe-separated fields are styled with CSS. The following tags are modified on the detail page: 020 ISBN 022 ISSN 050 LOC classification 060 NLM classification 082 DDC classification 084 Other classification 130/240/730 Uniform titles 246 Other title 336 Content type 337 Media type 338 Carrier type 385 Audience 508 Production credits 583 Action note 586 Awards 655 Genre/Form 700/710/711 Contained works 700/710/711 Related works 770 Supplement 772 Supplement to 856 Online resources These are modified on the results page: 028 Publisher number 246 Other title To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). In order to better see the effect of the CSS change you can add something ike this to your OPACUserCSS system preference: .resource_list li::after { content: "♦"; } View catalog search results and detail pages for records which contain repeated entries from the tag list above. The entries should be separated by "|" without customization, or the symbol from your OPACUserCSS if you specified one. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 16:07:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 15:07:26 +0000 Subject: [Koha-bugs] [Bug 27627] Fix invalid HTML in OPAC results XSLT: change spans to divs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127455|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 127544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127544&action=edit Bug 27627: Fix invalid HTMl in OPAC results XSLT: change spans to divs This patch modifies the XSL template for OPAC search results in order to improve HTML validation: Changing some s to
    s will prevent an error when those s contain block-level elements. To test, apply the patch and restart_all if necessary. - Confirm that OPACXSLTResultsDisplay is set to "default" - Perform a catalog search in the OPAC. - Validate the page source and confirm that there are no errors about "Element ul not allowed as child of element span in this context" Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 16:08:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 15:08:03 +0000 Subject: [Koha-bugs] [Bug 27613] Pipe separated online resource links are hard to customize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #13 from Martin Renvoize --- Looks great to me, signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 16:08:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 15:08:24 +0000 Subject: [Koha-bugs] [Bug 27627] Fix invalid HTML in OPAC results XSLT: change spans to divs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #11 from Martin Renvoize --- All works as expected now, nice bit of tidying up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 16:13:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 15:13:52 +0000 Subject: [Koha-bugs] [Bug 27145] Patron deletion via intranet doesn't handle exceptions well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114149|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 127545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127545&action=edit Bug 27145: Rethrow all other exceptions Bug 14708 introduced a try catch around $patron->delete in commit: "Bug 14708: (QA follow-up) Use try/catch blocks when calling" However, in the catch block it only assumes the exception was from trying to delete anonymous patron when it can be anything else as well, the code should be modified so that it will handle the anonymous patron case and if it is anything else we log the other exception. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 16:13:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 15:13:55 +0000 Subject: [Koha-bugs] [Bug 27145] Patron deletion via intranet doesn't handle exceptions well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114183|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 127546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127546&action=edit Bug 27145: Wrap delete and move_to_deleted in a transaction Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 16:15:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 15:15:52 +0000 Subject: [Koha-bugs] [Bug 27145] Patron deletion via intranet doesn't handle exceptions well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- The change makes allot of sense, though it would be nice to do something with the other types of failures we're currently rethrowing.. but it's no bad thing to rethrow for now and collect data on what they are so we can handle them later (in new bug reports).. in my opinion. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 16:24:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 15:24:24 +0000 Subject: [Koha-bugs] [Bug 29459] Replace some missed datetimepickers in circulation templates with Flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29459 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 16:24:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 15:24:27 +0000 Subject: [Koha-bugs] [Bug 29459] Replace some missed datetimepickers in circulation templates with Flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29459 --- Comment #1 from Owen Leonard --- Created attachment 127547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127547&action=edit Bug 29459: Replace some missed datetimepickers in circulation templates with Flatpickr This patch updates a few more instances of jQueryUI datepickers which were missed initially, replacing them with Flatpickr widgets. Also changed: A few datetime input fields are updated to have a size of 20, consistent with other datetime input fields. To test, apply the patch and go to Circulation. Check in: - With the 'SpecifyReturnDate' system preference enabled, go to Check in. - Click the "Checkin settings" link. - Test the "Specify return date" field. Clicking it should trigger a Flatpickr widget with a time picker. It should limit your selection to dates in the past. - Check the "Remember return date" checkbox and confirm that the date is preserved over page reloads. - Check and uncheck the "Box drop mode" checkbox to confirm that the return date field is disabled and enabled correctly. Check out: - With the 'AllowRenewalOnHoldOverride' preference enabled, check out to a patron who has a checkout which is on hold for another patron. - At the bottom of the table of checkouts, click the "Override renewal restrictions" checkbox. - The on-hold checkouts should now have a checkbox in the "Renew" column. Check one or more of these checkboxes. - In the table footer you should now see two date inputs, "Renewal due date" and "On hold due date." These should both trigger Flatpickr widgets with time pickers. - Confirm that your date selections are submitted correctly when you renew items. ILL checkout: - Create a new ILL request with the type "book," filling in at least title, patron, and destination library. - On the "Manage ILL request" page, click "Confirm request" and "Confirm request" on the next confirmation page. - There should now be a "Check out" button in the "Manage ILL request" toolbar. Click it. - Test the "Due date" field. It should trigger a Flatpickr widget with a time picker. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 16:29:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 15:29:22 +0000 Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create mysqluser@mysql_hostname so zebra update fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #34 from Martin Renvoize --- Right.. time has moved on... I'm thinking we can accept this patch now as-is? Promoting to the QA queue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 16:52:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 15:52:40 +0000 Subject: [Koha-bugs] [Bug 28664] One should not be able to issue a refund against a VOID accountline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28664 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 16:52:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 15:52:44 +0000 Subject: [Koha-bugs] [Bug 28664] One should not be able to issue a refund against a VOID accountline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28664 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127537|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 127548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127548&action=edit Bug 28664: Prevent refunds against void lines With the introduction of double entry accounting for VOID actions, we need to add an additional filter to the 'Issue refund' button appearance Test plan 1/ Add a debt 2/ Pay the debt 3/ Void the payment 4/ Confirm that with the patch applied the 'Issue refund' button doesn not appear on the 'Void' accountline. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 17:33:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 16:33:59 +0000 Subject: [Koha-bugs] [Bug 29455] 505$t - change in line break/display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29455 --- Comment #1 from Katrin Fischer --- Hi Sara, when I was working on bug 19616 I found no way to keep the existing behaviour and still make the $g display nicely with the subfields it belongs to. XSLT is a bit limiting in what you can do easily and works different to a programming language. I'd be happy if someone could help out here that can make both the old and new behaviour work together. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 17:42:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 16:42:24 +0000 Subject: [Koha-bugs] [Bug 28703] Display problem in 505$a field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28703 --- Comment #5 from Katrin Fischer --- Confirming the problem, a bit puzzled at my own changes on bug 28703. Will try to come up with a fix. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 18:59:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 17:59:02 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 19:16:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 18:16:36 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 19:16:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 18:16:42 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127438|0 |1 is obsolete| | --- Comment #14 from Tomás Cohen Arazi --- Created attachment 127549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127549&action=edit Bug 28374: Convert printreceipt to use GetPreparedLetter This patch converts the point of sale receipt printer controller to using GetPreparedLetter instead of calling getletter directly. Test plan 1. Setup for testing: i. Enable EnablePointOfSale and UseCashRegisters system preferences ii. Add a new cash register (Administration > Accounting > Cash registers) iii. Add one or two products for sale (Administration > Accounting > Debit types, make sure 'Can be sold?' is ticked) 2. Go to Home > Point of sale 3. Add some items for purchase to a sale 4. Click confirm 5. Click on 'Print receipt' and save the PDF file somewhere 6. Apply patches 7. Update database: updatedatabase 8. Repeat steps 2-5 9. Compare receipt PDFs - should be no changes 10. Check that the default RECEIPT is updated - for print, HTML should be ticked 11. Sign off! Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 19:16:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 18:16:51 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127439|0 |1 is obsolete| | --- Comment #15 from Tomás Cohen Arazi --- Created attachment 127550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127550&action=edit Bug 28374: Update existing notices This patch updates the default slip to include KohaDates, Branches and Price plugins as required and prepends the same to existing notices at upgrade time. We also, switch the HTML flag on. Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 19:30:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 18:30:04 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 127551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127551&action=edit Bug 28374: (QA follow-up) Avoid adding duplicate USE Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 19:32:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 18:32:29 +0000 Subject: [Koha-bugs] [Bug 27779] Cashup summary 'refunds' should denote what the refund was actioned against. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 19:32:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 18:32:33 +0000 Subject: [Koha-bugs] [Bug 27779] Cashup summary 'refunds' should denote what the refund was actioned against. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121224|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi --- Created attachment 127552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127552&action=edit Bug 27779: Group payouts by type of debit they're applied against This patch adds additional grouping to the cashup summary output such that payouts are additionally grouped by the types of debit they're applied against. The cashup sumary modal is adapted to expose the descriptions at the grouping level too. Test plan 1/ Add a various transactions using a cash register (Using Point of Sale, Patron Accounts with payments etc). 2/ Refund some of the debts and pick the 'cash' option for payout. (ensure you pick a variety of debit types) 3/ Add some credit to a patron account, (either refund a debt as 'credit' or add a 'manual credit') 4/ Payout the credit as 'cash' on the patron account 5/ Cashup the register 6/ Inspect the cashup summary for your cashup. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 19:32:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 18:32:37 +0000 Subject: [Koha-bugs] [Bug 27779] Cashup summary 'refunds' should denote what the refund was actioned against. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121225|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi --- Created attachment 127553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127553&action=edit Bug 27779: Update 'REFUND' description in the database This patch simplified the REFUND description from 'Refund applied to a patrons fine' to simply 'Refund'.. this allows the description to be combined with debit type descriptions simply to denote what it was applied against instead of using the generic 'applied to a patrons fine' Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 19:32:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 18:32:40 +0000 Subject: [Koha-bugs] [Bug 27779] Cashup summary 'refunds' should denote what the refund was actioned against. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 127554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127554&action=edit Bug 27779: New atomic update syntax Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 21:30:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 20:30:59 +0000 Subject: [Koha-bugs] [Bug 28375] Inefficiencies in fetching COinS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28375 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Tomás Cohen Arazi --- The code looks great and simple. But it doesn't apply. Please resubmit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 21:44:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 20:44:12 +0000 Subject: [Koha-bugs] [Bug 28664] One should not be able to issue a refund against a VOID accountline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28664 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Tomás Cohen Arazi --- The patch itself is simple and does the job. But I think we are a bit fragile here. Too much calculation in the controller/templates. Can we add something like: Koha::Account::Line->can_be_reduced Koha::Account::Line->refund and reuse it both in the templates and controllers? I would like the code to explode if tricked to try refunding a 'VOID' line. I can help coding or writing the tests if required. If this is being worked on somewhere else, please point me to the right direction. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 21:46:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 20:46:07 +0000 Subject: [Koha-bugs] [Bug 29321] Remove a last without loop context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29321 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 21:50:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 20:50:49 +0000 Subject: [Koha-bugs] [Bug 29321] Remove a last without loop context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29321 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 11 21:50:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 20:50:53 +0000 Subject: [Koha-bugs] [Bug 29321] Remove a last without loop context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29321 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127396|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi --- Created attachment 127555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127555&action=edit Bug 29321: Remove a last without loop context This reads better when converted to regular if. Note that last within such a block is allowed in Perl, but it feels better to use it only in a loop context. Test plan: Read the patch ;) Bonus: Test if you enter the block by using pref OPACSuggestionMandatoryFields when adding a suggestion from opac. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Edit: Added a space between 'if' and '(' :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 00:05:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Nov 2021 23:05:11 +0000 Subject: [Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com --- Comment #19 from Tomás Cohen Arazi --- Looking here. This requires regression tests, I'm writing them and will come back shortly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 03:45:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 02:45:25 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125917|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 03:45:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 02:45:36 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125916|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 03:45:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 02:45:46 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125915|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 03:45:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 02:45:57 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125914|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 03:46:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 02:46:10 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122536|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 03:46:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 02:46:39 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #90 from Alex Buckley --- Created attachment 127556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127556&action=edit Bug 26346: Updated schema file Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 03:47:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 02:47:03 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #91 from Alex Buckley --- Created attachment 127557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127557&action=edit Bug 26346: Add option to make public lists editable by all staff If a staff member has access to the staff client (either because 'catalogue' permission is enabled or they're a superlibrarian then that user can add items (from OPAC or staff client) to a list marked 'Staff only' Test plan: 1. In the staff client go to: Lists > 'New list'. Notice under 'Allow changes to contents from' there are three options: Nobody, Owner only, Anyone seeing this list 2. Apply first 3 patches and run updatedatabase.pl cd installer/data/mysql sudo koha-shell ./updatedatabase.pl 3. Restart memcached and plack 4. Create a public list and select the new 'Staff only' option under 'Allow changes to contents from' 5. Log out of the staff client and log back in as a different user with the 'Staff access, allows viewing of catalogue in staff interface (catalogue)' permission enabled. 6. Navigate to the Lists module, and click on the name of the list you created in #5 7. Select 'Add items' and enter an item barcode and submit 8. Notice the item has been added to the list 9. Search the catalogue in the staff client. Confirm you can add to the list you created in #5 from both the search result page and biblio record detail page 10. Confirm you can remove items from the list in the OPAC and staff client 11. Login to the OPAC as the same user as #5 12. Perform an OPAC search, Select 'Save to lists' under a biblio record, choose the list from #4 in 'Select a list' and save 13. Confirm in the staff client that the record from #11 has been added to the list 14. Logout of OPAC and login again as a user which does not have 'Staff access, allows viewing of catalogue in staff interface (catalogue)' or superlibrarian enabled 15. Do a OPAC search, hit 'Save to lists' and notice you cannot add the record to the list from #4 16. Run Patron.t and Virtualshelves.t unit tests: sudo koha-shell prove t/db_dependent/Koha/Patron.t prove t/db_dependent/Virtualshelves.t 17. Login to the staff client as the same user as #5 18. Create a new list in the staff client, select 'Category'='Private', 'Allow changes to contents from'='Staff only' 19. Notice 'The Staff only permission has no actual effect while this list is strictly private' message hint is displayed 20. Change 'Category'='Public' and notice the hint is removed 21. Switch back to 'Category'='Private' and 'Allow changes to contents from'='Anyone' 22. Notice the 'The Anyone permission has no actual effect while this list is strictly private.' is displayed 23. Repeat steps 18-22 in the OPAC 24. Create a 'staff only' list in the OPAC and then login as a different user with 'Staff access, allows viewing of catalogue in staff interface (catalogue)' permission enabled. Confirm you are able to add items to this new 'staff only' list. 25. Confirm that the 'Staff only' option is not available to patrons with no special permissions when creating lists in the OPAC Sponsored-by: Horowhenua District Council, New Zealand Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 03:47:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 02:47:25 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #92 from Alex Buckley --- Created attachment 127558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127558&action=edit Bug 26346: Add edit_public_lists sub-permission enabling patrons to switch 'owner only' public lists (which they're not the owners of) to 'staff only' lists The first patch on bug 26346 only allowed owners of existing 'owner only' public lists switch those lists to be 'Staff only'. This patch will allow other patrons with the 'edit_public_lists' sub-permission to also make this change. Test plan: 1. Apply the first 26346 patch and follow it's test plan 2. Apply this patch 3. Apply database changes: cd installer/data/mysql sudo koha-shell ./updatedatabase.pl 4. Restart memcached and plack 5. Login to the staff client. Create an 'owner only' public list 6. Create another patron record. Tick the following two permissions: * "Staff access, allows viewing of catalogue in staff interface (catalogue) Required for staff login." permission * Lists > "Edit public lists (edit_public_lists)" sub-permission 7. Logout of the staff client, and login as the user from step #6 8. Navigate to the Lists module, click 'Edit' on the 'owner only' list 9. Confirm you can change the 'Allow changes to contents from:' option to 'Staff only' 10. Confirm you can now add items to this 'staff only' list 11. Login to the OPAC as the patron from step #5 12. Create a 'owner only' public list 13. Logout of OPAC, and login as the patron from step #6 14. Navigate to public lists in the OPAC and edit the OPAC created 'owner only' public list from step # 15. Confirm you can change the 'Allow changes to contents from:" option to 'Staff only' 16. Confirm you can now add items to this 'staff only' list 17. Run Virtualshelves.t unit test: sudo koha-shell prove t/db_dependent/Virtualshelves.t Sponsored-by: Catalyst IT Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 03:54:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 02:54:52 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #93 from Alex Buckley --- Created attachment 127559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127559&action=edit Bug 26364: (QA follow-up) Do not crash on anonymous OPAC user Seriously! Can't call method "userid" on an undefined value at /usr/share/koha/Koha/Virtualshelf.pm line 253 Trivial fix. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 03:55:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 02:55:17 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #94 from Alex Buckley --- Created attachment 127560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127560&action=edit Bug 26346: (follow-up) Fixes in response to QA Fixes for the following comments on bug report 26346: 1. Comment #31 2. Comment #32 3. Comment #35 4. Comment #36 5. Comment #37 6. Comment #38 7. Comment #49 8. Comment #59 9. Comment #61 Test plan for comment #49 fix: 1. Log into the staff client as User A. Create one of each of the following types of public lists: - 'Owner only' - 'staff only' - 'Anyone seeing this list' 2. Visit the OPAC. Do not login. Confirm you are able to see all three public lists under the 'Lists' dropdown in the OPAC header 3. Perform a search. Select a search result checkbox and view the dropdown options in the 'Select titles to:' dropdown 4. Confirm only the 'Anyone seeing this list' is displayed as an option 5. Log into the OPAC as a user B (a user with no permissions). Confirm you can see all three public lists under the header 'Lists' dropdown 6. Repeat steps 3, and 4 as User B with the same results as un-authenticated user 6. Log into the OPAC as user C (a user with access to the staff client). Confirm you can see all three public lists under the header 'Lists' dropdown 7. Repeat steps 3, and 4 but this time you should see the 'staff only' and 'Anyone seeing this list' public lists in the dropdown 8. Log into the OPAC as user A. Confirm you can see all three poublic lists under the header 'Lists' dropdown 9. Repeat steps 3, and 4 but this time you should see the 'owner only', 'staff only' and 'Anyone seeing this list' public lists in the dropdown Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 04:28:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 03:28:07 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #95 from Alex Buckley --- Hi Caroline, I've rebased this patchset against master. Would you mind testing this patchset in a sandbox (https://wiki.koha-community.org/wiki/Sandboxes) to see if you still encounter the problems in comment #86? --- (In reply to Blou from comment #89) > This patch would be very helpful to some of our customers. But what would > it take to extend the concept to private lists to be viewable by staff ? > > There's Bug 19501 opened for that, but it seems to me this patch here is > almost there already. Hi Blou, Apologies for my slow response! My team has been flat out with client work recently. I'll have a think about this and try to get back to you as soon as possible. Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:11:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:11:08 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin Somers --- We have two behaviors : error => "$@" error => ($@ ? "$@" : 0) Shouldn't it be only one here ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:13:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:13:11 +0000 Subject: [Koha-bugs] [Bug 28876] No renewal before advisory text not wrapped in selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28876 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #4 from Fridolin Somers --- This will also be easier for translation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:14:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:14:06 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #53 from Marcel de Rooy --- Applying: Bug 27266: Move GetMarcAuthors to Koha namespace Using index info to reconstruct a base tree... M C4/Biblio.pm M opac/opac-detail.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-detail.pl Auto-merging C4/Biblio.pm Applying: Bug 27266: (QA follow-up) Rename to get_marc_authors Applying: Bug 27266: (follow-up) Remove instances of GetMarcAuthors Applying: Bug 27266: (follow-up) Using biblio frameworkcode to get rid of FIXME Applying: Bug 27266: (follow-up) Remove get_marc_authors from opac-detail Using index info to reconstruct a base tree... M opac/opac-detail.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-detail.pl Applying: Bug 27266: (QA follow-up) Remove GetBiblioData from basket scripts Applying: Bug 27266: (QA follow-up) Indentation in opac-sendshelf Applying: Bug 27266: (QA follow-up) Remove GetBiblioData from sendshelf too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:14:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:14:37 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #54 from Marcel de Rooy --- Wait. I am on the wrong branch ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:16:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:16:33 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #55 from Marcel de Rooy --- Makes no difference: Applying: Bug 27266: Move GetMarcAuthors to Koha namespace Using index info to reconstruct a base tree... M C4/Biblio.pm M opac/opac-detail.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-detail.pl Auto-merging C4/Biblio.pm Applying: Bug 27266: (QA follow-up) Rename to get_marc_authors Applying: Bug 27266: (follow-up) Remove instances of GetMarcAuthors Applying: Bug 27266: (follow-up) Using biblio frameworkcode to get rid of FIXME Applying: Bug 27266: (follow-up) Remove get_marc_authors from opac-detail Using index info to reconstruct a base tree... M opac/opac-detail.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-detail.pl Applying: Bug 27266: (QA follow-up) Remove GetBiblioData from basket scripts Applying: Bug 27266: (QA follow-up) Indentation in opac-sendshelf Applying: Bug 27266: (QA follow-up) Remove GetBiblioData from sendshelf too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:17:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:17:10 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127330|0 |1 is obsolete| | --- Comment #56 from Marcel de Rooy --- Created attachment 127561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127561&action=edit Bug 27266: Move GetMarcAuthors to Koha namespace This patch moves C4::Biblio::GetMarcAuthors to Koha::Biblio->get_authors_from_MARC. This is so the method can be used in templates and notices. To test: 1. Find a record that has an author in the added entry field (700-720). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm authors show as normal. 4. Click 'send' and confirm the email sent shows the authors as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. xslt) 6. Log in to the OPAC. Find the record and add it to the cart and a list 7. View the cart and click 'more details'. Confirm authors show as normal. 8. Click 'send' and confirm the email sent shows the authors as normal. 9. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 10. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:17:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:17:14 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127331|0 |1 is obsolete| | --- Comment #57 from Marcel de Rooy --- Created attachment 127562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127562&action=edit Bug 27266: (QA follow-up) Rename to get_marc_authors Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:17:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:17:18 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127332|0 |1 is obsolete| | --- Comment #58 from Marcel de Rooy --- Created attachment 127563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127563&action=edit Bug 27266: (follow-up) Remove instances of GetMarcAuthors Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:17:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:17:21 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127333|0 |1 is obsolete| | --- Comment #59 from Marcel de Rooy --- Created attachment 127564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127564&action=edit Bug 27266: (follow-up) Using biblio frameworkcode to get rid of FIXME Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:17:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:17:25 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127334|0 |1 is obsolete| | --- Comment #60 from Marcel de Rooy --- Created attachment 127565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127565&action=edit Bug 27266: (follow-up) Remove get_marc_authors from opac-detail There's no way to use 'no' XSLT now, so don't need to use this to show authors on the detail page. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:17:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:17:29 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127340|0 |1 is obsolete| | --- Comment #61 from Marcel de Rooy --- Created attachment 127566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127566&action=edit Bug 27266: (QA follow-up) Remove GetBiblioData from basket scripts We are adding (or already doing) a Koha::Biblios->find, so we should get rid of GetBiblioData, fetching the same data. It returned a few extra columns, but unused here: $dat->{bnotes}, $dat->{bi_notforloan} Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:17:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:17:33 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127341|0 |1 is obsolete| | --- Comment #62 from Marcel de Rooy --- Created attachment 127567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127567&action=edit Bug 27266: (QA follow-up) Indentation in opac-sendshelf Minimal fix to improve bad indentation a bit, moving to 2 spaces. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:17:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:17:37 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127342|0 |1 is obsolete| | --- Comment #63 from Marcel de Rooy --- Created attachment 127568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127568&action=edit Bug 27266: (QA follow-up) Remove GetBiblioData from sendshelf too Applies to opac and intranet script. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:17:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:17:44 +0000 Subject: [Koha-bugs] [Bug 11083] Authority Search Result Display should be XSLT Driven In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:40:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:40:49 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED --- Comment #37 from Marcel de Rooy --- Still having a look here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:43:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:43:27 +0000 Subject: [Koha-bugs] [Bug 28703] Display problem in 505$a field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28703 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19616 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19616 [Bug 19616] Add MARC21 505$g - Formatted Contents Note / Miscellaneous information -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:43:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:43:27 +0000 Subject: [Koha-bugs] [Bug 19616] Add MARC21 505$g - Formatted Contents Note / Miscellaneous information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19616 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28703 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28703 [Bug 28703] Display problem in 505$a field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:43:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:43:31 +0000 Subject: [Koha-bugs] [Bug 29455] 505$t - change in line break/display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29455 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19616 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19616 [Bug 19616] Add MARC21 505$g - Formatted Contents Note / Miscellaneous information -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:43:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:43:31 +0000 Subject: [Koha-bugs] [Bug 19616] Add MARC21 505$g - Formatted Contents Note / Miscellaneous information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19616 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29455 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29455 [Bug 29455] 505$t - change in line break/display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:45:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:45:41 +0000 Subject: [Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 --- Comment #22 from Fridolin Somers --- (In reply to Marcel de Rooy from comment #19) > The barcodedecode does the trimming, please remove the regexes. I'm testing but this does not work. I don't see a trim in barcodedecode(). Unless there is itemBarcodeInputFilter = whitespace, but we should always trim no ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:47:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:47:54 +0000 Subject: [Koha-bugs] [Bug 29460] New: Typo 'pendin g approval' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29460 Bug ID: 29460 Summary: Typo 'pendin g approval' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org installer/data/mysql/en/mandatory/sample_notices.yml: - "

    Suggestion pendin g approval

    " installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql:VALUES ('suggestions','NEW_SUGGESTION','New suggestion','New suggestion','

    Suggestion pendin g approval

    -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:48:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:48:04 +0000 Subject: [Koha-bugs] [Bug 29460] Typo 'pendin g approval' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29460 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:50:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:50:07 +0000 Subject: [Koha-bugs] [Bug 29460] Typo 'pendin g approval' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29460 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:50:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:50:11 +0000 Subject: [Koha-bugs] [Bug 29460] Typo 'pendin g approval' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29460 --- Comment #1 from Marcel de Rooy --- Created attachment 127569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127569&action=edit Bug 29460: Fix typo 'pendin g approval' Test plan: Apply and git grep for it. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:50:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:50:23 +0000 Subject: [Koha-bugs] [Bug 29460] Typo 'pendin g approval' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29460 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 08:51:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 07:51:05 +0000 Subject: [Koha-bugs] [Bug 29460] Typo 'pendin g approval' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29460 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #2 from Marcel de Rooy --- Too trivial for keeping it in SO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 09:11:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 08:11:17 +0000 Subject: [Koha-bugs] [Bug 28703] Display problem in 505$a field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28703 --- Comment #6 from Katrin Fischer --- Hm, it might just need changing the "after" to "before" here: - .r { - display: inline; + .newline::after { + content: "\A → "; + white-space: pre; } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 09:37:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 08:37:39 +0000 Subject: [Koha-bugs] [Bug 29461] New: Add spans to traced and untraced series entries Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29461 Bug ID: 29461 Summary: Add spans to traced and untraced series entries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Sometimes it would be helpful to recognize a traced vs an untraced series entry in the OPAC for styling and linking purposes. Adding a span with different classes for each would help with that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 09:55:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 08:55:20 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #38 from Marcel de Rooy --- w3.org The Message/rfc822 (primary) subtype: A Content-Type of "message/rfc822" indicates that the body contains an encapsulated message, with the syntax of an RFC 822 message. Better than using MIME as content-type.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 10:16:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 09:16:38 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 10:16:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 09:16:42 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127429|0 |1 is obsolete| | --- Comment #39 from Marcel de Rooy --- Created attachment 127570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127570&action=edit Bug 29330: Add Koha::Email->new_from_string This patch introduces a new method to Koha::Email. This method allows us to parse a MIME email to initialize the Koha::Email object. This is particularly important when we are restoring emails from the DB. i.e. from the *message_queue* table. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/Email.t => SUCCESS: Tests pass! Koha::Email->new_from_string is the correct counterpart for Koha::Email->as_string! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 10:16:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 09:16:46 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127430|0 |1 is obsolete| | --- Comment #40 from Marcel de Rooy --- Created attachment 127571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127571&action=edit Bug 29330: Restore handling of serialized MIME messages in message_queue This patch changes how multipart MIME messages are handled on the message_queue table. The email, with the required attachments, is now generated using Koha::Email, and serialized using Koha::Email->as_string. This bug also adds Koha::Email->new_from_string which is used to read that data from the DB, and produce a Koha::Email object, that can be further augmented/modified using regular Koha::Email methods. This implementation should be considered a middle ground, with backportability in mind. higher-level methods should encapsulate setting the default headers and addresses, to clean the area a bit further. Preparation: - You need a valid SMTP configuration in koha-conf.xml. If you use Gmail you can generate an 'app password' and set things like this: smtp.gmail.com 587 5 STARTTLS youraddress at gmail.com youpassword 1 - Set KohaAdminAddress to your address. To test: 1. Pick a patron. Make sure it doesn't have any email address (Acevedo?) 2. Set an overdue notice trigger for its category 3. Check something out, with due date in the past to force an overdue 4. Run: $ kshell k$ misc/cronjobs/overdue_notices.pl -v k$ exit $ koha-mysql kohadev > SELECT * FROM message_queue WHERE borrowernumber=the_borrowernumber; => SUCCESS: A notice has been created 5. Run: $ kshell k$ misc/cronjobs/process_message_queue.pl --verbose => SUCCESS: SMTP is ok => Email is sent => FAIL: Your inbox shows an email with weird content 6. Apply this patches 7. Run: $ koha-mysql kohadev > DELETE FROM message_queue; 8. Repeat 4 and 5 => SUCCESS: You got an email with an attachment! => SUCCESS: The attachment contains an email that couldn't be delivered! 9. Try all the things that enqueue messages :-D => SUCCESS: No behavior change 10. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Edited the POD, restoring a few lines that describe the needed hash keys of the attachments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 10:16:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 09:16:51 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127444|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy --- Created attachment 127572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127572&action=edit Bug 29330: (QA follow-up) Use passed MIME type Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Amended: tidied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 10:16:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 09:16:54 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #42 from Marcel de Rooy --- Created attachment 127573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127573&action=edit Bug 29330: (QA follow-up) Change to message/rfc822 This content-type might be more appropriated to use as a temporary label for the serialized email message with attachments. WARNING: perl -cw tells you that the constant is redefined. This has to do with an already existing module dependency loop of Letters. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 10:17:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 09:17:37 +0000 Subject: [Koha-bugs] [Bug 29378] After the automatic update to 21.05.05, the OPAC switches to maintenance mode and the web installer is displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29378 --- Comment #18 from Mason James --- (In reply to Katrin Fischer from comment #17) > (In reply to Victor Grousset/tuxayo from comment #16) > > > I guess we could either set back to 21.05.05.000 at the beginning of the cycle now or Kyle will have to start 21.05.05.004 now. > > > > The DB upgrade to 21.05.05.002 has already been released so we can't move it > > backwards right? > > So Kyle should just have to continue from 21.05.05.004 > > You are probably right about continuing with 21.05.05.004. Maybe there won't > even be a database update this cycle so we can jump to 21.05.06.000 next. yes, i think Katrin is correct :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 10:18:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 09:18:01 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #43 from Marcel de Rooy --- Good job, Tomas. Looks good to me. Tested with multiple attachments including some weird UTF8 stuff. Note that we do not have tests (yet) for adding attachments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 10:18:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 09:18:53 +0000 Subject: [Koha-bugs] [Bug 29462] New: OPACPopupAuthorsSearch doesn't work when authors include $d, $e and possible other subfields Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29462 Bug ID: 29462 Summary: OPACPopupAuthorsSearch doesn't work when authors include $d, $e and possible other subfields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When using OPACPopupAuthorsSearch with MARC records that have entries like: 700 1 _ ‡aName, Name‡d1960-‡4aut‡969108866 700 1 _ ‡aOthername, Othername‡d1945-t‡957721213 If you select both of those for search, it will create a seach link that includes the content from d and 4 with [] and the search won't work. I am also seeing other issues where I am redirected immediately to /cgi-bin/koha/undefined but not sure yet how to recreate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 10:21:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 09:21:48 +0000 Subject: [Koha-bugs] [Bug 29462] OPACPopupAuthorsSearch doesn't work when authors include $d, $4, and possible other subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29462 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPACPopupAuthorsSearch |OPACPopupAuthorsSearch |doesn't work when authors |doesn't work when authors |include $d, $e and possible |include $d, $4, and |other subfields |possible other subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 10:27:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 09:27:22 +0000 Subject: [Koha-bugs] [Bug 29462] OPACPopupAuthorsSearch doesn't work when authors include $d, $4, and possible other subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29462 --- Comment #1 from Katrin Fischer --- The "undefined" problem seems linked to our own XSLT, with "default" it works and only shows the subfield issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 10:30:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 09:30:55 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #44 from Marcel de Rooy --- Hmm. Still having an issue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 10:31:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 09:31:07 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 10:36:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 09:36:56 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA --- Comment #45 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #44) > Hmm. Still having an issue? False alarm. Back to green. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 10:52:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 09:52:04 +0000 Subject: [Koha-bugs] [Bug 29462] OPACPopupAuthorsSearch doesn't work when authors include $d, $4, and possible other subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29462 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13327 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 10:52:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 09:52:04 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29462 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29462 [Bug 29462] OPACPopupAuthorsSearch doesn't work when authors include $d, $4, and possible other subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 10:56:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 09:56:58 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #21 from Marcel de Rooy --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 10:57:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 09:57:12 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 --- Comment #22 from Marcel de Rooy --- Promising: Undefined subroutine &C4::Log::Dumper called at /usr/share/koha/C4/Log.pm line 81 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 10:59:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 09:59:25 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 --- Comment #23 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #20) > Great, this is a good first step and enough at this late stage in the cycle > for the next release in my opinion. > > I'd have been tempted to drop the 'item' prepension, but that would lead to > questions like "Should we run a DB update to fix existing cases" > > Signing off. How did you test it? First thing is a crash on missing module.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 11:05:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 10:05:47 +0000 Subject: [Koha-bugs] [Bug 26440] Not renewable Supersedes On Hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26440 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 11:27:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 10:27:43 +0000 Subject: [Koha-bugs] [Bug 29463] New: Umlauts in search field get changed into Replacement character Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Bug ID: 29463 Summary: Umlauts in search field get changed into Replacement character Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: stalkernoid at gmail.com Reporter: stalkernoid at gmail.com QA Contact: testopia at bugs.koha-community.org CC: nugged at gmail.com Our customers can't search for patrons with umlauts in their names using the "Check out" search menu on the main page of Koha. Other search menus seem to work fine. To reproduce: 1) Go to the main page of Koha and in the "Check out" search window type something like "Tëst". Press the search button. 2) See that it gets replaced with a replacement character. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 11:28:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 10:28:08 +0000 Subject: [Koha-bugs] [Bug 29463] Umlauts in search field get changed into Replacement character In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 11:33:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 10:33:40 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 --- Comment #24 from Marcel de Rooy --- + $infos = Dumper( $infos->unblessed ); + + if ( $infos->isa('Koha::Item') && $modulename eq 'CATALOGUING' && $actionname eq 'MODIFY' ) { Ha. If you change the variable to a string, it wont be a Koha::Item anymore ;) Will fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 11:46:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 10:46:54 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 --- Comment #25 from Marcel de Rooy --- Koha::Item Not sure if there was an idea to log the item version before we store (get_from_storage call) but we only save the current stage: my $result = $self->SUPER::store; if ( $log_action && C4::Context->preference("CataloguingLog") ) { $action eq 'create' ? logaction( "CATALOGUING", "ADD", $self->itemnumber, "item" ) : logaction( "CATALOGUING", "MODIFY", $self->itemnumber, $self ); } We already super stored. So if we wanted the version without the changes like the BIBLIO BEFORE then we should move the super store here? In that case I would also add a BEFORE. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 11:47:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 10:47:48 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 --- Comment #26 from Marcel de Rooy --- - my $result = $self->SUPER::store; if ( $log_action && C4::Context->preference("CataloguingLog") ) { $action eq 'create' ? logaction( "CATALOGUING", "ADD", $self->itemnumber, "item" ) : logaction( "CATALOGUING", "MODIFY", $self->itemnumber, $self ); } + my $result = $self->SUPER::store; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 11:52:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 10:52:19 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 11:52:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 10:52:23 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127446|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy --- Created attachment 127574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127574&action=edit Bug 28692: Get from storage before log actions To make sure we have logging the values from DB. It will reduce DB action_log table size when we log the full object and it contains DateTime object. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 11:52:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 10:52:26 +0000 Subject: [Koha-bugs] [Bug 20112] Optionally show invalid ISBN/ISSN 020/022 $z In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20112 --- Comment #1 from Katrin Fischer --- Still valid this one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 11:52:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 10:52:26 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 --- Comment #28 from Marcel de Rooy --- Created attachment 127575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127575&action=edit Bug 28962: (QA follow-up) Add module Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 11:52:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 10:52:30 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 --- Comment #29 from Marcel de Rooy --- Created attachment 127576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127576&action=edit Bug 28962: (QA follow-up) Sort hash keys of unblessed Trivial add. Reads much better. And might help future diffs. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 11:52:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 10:52:34 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 --- Comment #30 from Marcel de Rooy --- Created attachment 127577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127577&action=edit Bug 28962: (QA follow-up) Fix test for objects Simpler to check the ref instead of isa. Fix the bug where object is first stringified and then tested for being a Koha::Item. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 11:52:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 10:52:51 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 11:55:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 10:55:18 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 --- Comment #31 from Marcel de Rooy --- Development and testing seems to be done too hastily. Three follow-ups ;) Comment25 and 26 leaving open. Note that I didnt have time to add some additional test for logaction. But you are welcome to still add it, Jonathan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 12:00:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 11:00:27 +0000 Subject: [Koha-bugs] [Bug 29464] New: Sorting broken for receiving in acquisitions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Bug ID: 29464 Summary: Sorting broken for receiving in acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org This seems to be from bug 20212 - the sort options in the headers of the pending_orders table no longer function. Additionally, the 'Summary' column is now marked as 'orderable: false' - it was possible to sort on this column before those patches -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 12:01:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 11:01:24 +0000 Subject: [Koha-bugs] [Bug 29464] Sorting broken for receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Depends on| |20212 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 [Bug 20212] Improve performance of acquisitions receive page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 12:01:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 11:01:24 +0000 Subject: [Koha-bugs] [Bug 20212] Improve performance of acquisitions receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29464 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 [Bug 29464] Sorting broken for receiving in acquisitions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 12:12:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 11:12:17 +0000 Subject: [Koha-bugs] [Bug 29146] Default values from the framework should only be applied at biblio/item creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Summary|Should framework default |Default values from the |values be applied to |framework should only be |existing biblios and items? |applied at biblio/item | |creation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 12:18:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 11:18:54 +0000 Subject: [Koha-bugs] [Bug 29146] Default values from the framework should only be applied at biblio/item creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127041|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 127578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127578&action=edit Bug 29146: Apply framework defaultvalue only to new records This applies only to the 'regular' cataloguing editor. Another report could be opened for the advanced one, if needed. Test plan: [1] Add a default value to some field X in framework Y. [2] Open an existing biblio record in that fw. Clear field X. Save. [3] Reopen the record. The default should not be in field X. [4] Add a new record in that fw. You should see default value in X. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 12:18:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 11:18:58 +0000 Subject: [Koha-bugs] [Bug 29146] Default values from the framework should only be applied at biblio/item creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127042|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 127579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127579&action=edit Bug 29146: Same for item editor Test plan: Put some defaultvalue in an item subfield. Test adding new item; is defaultvalue supplied already? Test adding existing item. Clear the subfield. Save. Open again. Is the subfield still empty now? Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 12:19:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 11:19:01 +0000 Subject: [Koha-bugs] [Bug 29146] Default values from the framework should only be applied at biblio/item creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127043|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize --- Created attachment 127580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127580&action=edit Bug 29146: Add test for editing existing item Test plan: Run t/db_dependent/Koha/UI/Form/Builder/Item.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 12:20:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 11:20:21 +0000 Subject: [Koha-bugs] [Bug 29146] Default values from the framework should only be applied at biblio/item creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #23 from Martin Renvoize --- I really should have got to this earlier.. it was the question in the title that put me off.. but it's clear from the top comments that the question was answered. I've updated the title to reflect the consensus. Patches are clear and simple enough to understand.. testing provides positive results and no regressions are found.. QA scripts are happy... Passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 12:23:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 11:23:00 +0000 Subject: [Koha-bugs] [Bug 29334] Do not apply framework defaultvalue to existing authority records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29334 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127044|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 127581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127581&action=edit Bug 29334: Do not apply defaultvalue to existing auth record Note: The check in build_authorized_values_list with defaultvalue can be simplified since $value may already contain the defaultvalue. It is filled before the sub is called. The test for inserting a blank option is generalized; and may be still improved when using required attributes in the template? Note that we might experience some browser issues for these placeholders. Removed a few useless lines with respect to fields controlled by itemtypes. The last assignment to $value was useless and its probable intention unwanted (just use defaultvalue). Test plan: Put a defaultvalue in an authority framework. Add a new authority. Check for that value. Open existing authority. Clear field, save and reopen. Check if field is still empty. Bonus: test field controlled by authorised values. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 12:23:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 11:23:32 +0000 Subject: [Koha-bugs] [Bug 29334] Do not apply framework defaultvalue to existing authority records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29334 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- All working as expected, no regressions found and the QA scripts are happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 12:29:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 11:29:11 +0000 Subject: [Koha-bugs] [Bug 29465] New: Easily contact cash app support to get all queries and questions solved Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29465 Bug ID: 29465 Summary: Easily contact cash app support to get all queries and questions solved Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Project website Assignee: wizzyrea at gmail.com Reporter: jamessmith54485 at gmail.com Are you not able to make your online transactions on the Cash app? Then, you need to contact cash app support. You just need to click on the link here and you can easily get rid of all the issues. The Cash app is not undoubtedly a time-saving mobile-based payment service app but it is also common when there are some errors. The customer support services of the app are available 24/7 and users can easily solve their query with the assistance of the professionals. https://www.techjaadu.com/cash-app-support-number/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 12:37:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 11:37:52 +0000 Subject: [Koha-bugs] [Bug 29465] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29465 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Easily contact cash app |SPAM |support to get all queries | |and questions solved | Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 12:57:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 11:57:05 +0000 Subject: [Koha-bugs] [Bug 29463] Umlauts in search field get changed into Replacement character In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 --- Comment #1 from Peter Vashchuk --- Our customers can't search for patrons with umlauts in their names using the "Check out" search menu on the main page of Koha. Other search menus seem to work fine. To reproduce: 1) Go to the main page of Koha and in the "Check out" search window type something like "näyttö". Press the search button. 2) See that it gets replaced with a replacement character. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 13:02:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 12:02:12 +0000 Subject: [Koha-bugs] [Bug 28375] Inefficiencies in fetching COinS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28375 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 13:02:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 12:02:15 +0000 Subject: [Koha-bugs] [Bug 28375] Inefficiencies in fetching COinS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28375 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121124|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 127582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127582&action=edit Bug 28375: Inefficiencies in fetching COinS This patchset adds an 'interface' parameter to XSLTParseForDisplay to avoid fetching coins when not needed Additionally we move some logic from the scripts to searchResults to avoid an extra fetch fo the biblio object To test: 1 - Enable COinSinOPACResults syspref 2 - Also enable OPACShowOpenURL and OPACOpenURLItemTypes - adding an itemtype that you can find 3 - Perform a search on the OPAC and confirm coins are included and openurl shown 4 - Perform a search on staff client and confirm openurls do not show 5 - Apply patch 6 - Results should be the same -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 13:16:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 12:16:06 +0000 Subject: [Koha-bugs] [Bug 28436] Cache relatively static info that is used often and on many pages (instead of fetching from DB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28436 --- Comment #10 from Nick Clemens --- (In reply to David Cook from comment #9) > (In reply to Fridolin Somers from comment #8) > > Duplicate of Bug 29454 no ? > > Yeah I'm not sure why that was opened as a new one.. Joonas opened this one with broader context, and comments indicated that memcached would be a good way to go. I moved mine to a new bug as it deals narrowly with 2 plugins and doesn't use the Koha cache, I could have changed the title and reopened a new bug, but moving my patches seemed cleaner -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 13:27:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 12:27:10 +0000 Subject: [Koha-bugs] [Bug 29146] Default values from the framework should only be applied at biblio/item creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com --- Comment #24 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #23) > I really should have got to this earlier.. it was the question in the title > that put me off.. but it's clear from the top comments that the question was > answered. > > I've updated the title to reflect the consensus. > > Patches are clear and simple enough to understand.. testing provides > positive results and no regressions are found.. > > QA scripts are happy... Passing QA. Thanks. Will try to use less questions in bug titles :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 14:15:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 13:15:50 +0000 Subject: [Koha-bugs] [Bug 29463] Umlauts in search field get changed into Replacement character In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 14:15:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 13:15:54 +0000 Subject: [Koha-bugs] [Bug 29463] Umlauts in search field get changed into Replacement character In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 --- Comment #2 from Peter Vashchuk --- Created attachment 127583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127583&action=edit Bug 29463: Escape utf8 characters before appending search query to url. To test: 1) go to the main page of Koha and search in the "Check out" search window type "näyttö". 2) see that umlauts got replaced with replacement characters. 3) apply the patch. 4) repeat 1-2, ensure that umlauts displayed correctly and are not getting replaced with replacement characters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 14:39:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 13:39:22 +0000 Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120101|0 |1 is obsolete| | --- Comment #14 from Julian Maurice --- Created attachment 127584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127584&action=edit Bug 19318: Allow multiple storage spaces for file uploads This patch allow to configure multiple storage spaces to be used when uploading a file. Configuration is done in $KOHA_CONF. Element 'upload_path' is replaced by 'storage', which is repeatable and can contain the following elements: - name: The storage's identifier (also used for display) - adapter: The storage's adapter is a Perl module who is responsible for actually writing in the storage (creating/deleting files/directories). There is actually only one adapter, 'directory', which writes directly on the filesystem. - adapter_params: Additional parameters required for the storage's adapter - hash_filename: Whether to prepend hashvalue to the filename or not - temporary: Whether the storage is temporary or not - baseurl: Base URL of the storage, if one doesn't want to (or can't) use opac-retrieve-file.pl This is all documented in Koha::Storage There is two built-in storages: - 'TMP', the default temporary storage (not configurable) - 'DEFAULT', the default persistent storage (configurable in $KOHA_CONF) Note that if $KOHA_CONF is not updated, uploads should continues to work (the 'DEFAULT' storage will use 'upload_path', if set) This patch affects the following pages: - Tools › Upload - Tools › Upload local cover image (ZIP file upload) - Tools › Stage MARC records for import - Tools › Upload patron images - Circulation › Offline circulation file upload - Cataloguing plugin upload.pl Test plan: 0. Before applying the patch, be sure to use the pages mentioned above and upload some files, those files should continue to be accessible after the patch 1. Apply the patch, run updatedatabase and update_dbix_class_files 2. Without modifying $KOHA_CONF, verify that files uploaded in step 0 are still accessible (you can find them in tools/upload.pl) 3. Verify that you can still upload files using the pages mentioned above 4. Edit your $KOHA_CONF, copy the element from etc/koha-conf.xml in the source, set the using the value of and remove 5. Verify that you can still upload files 6. Add another storage in $KOHA_CONF, set to 0, and a . Now try to use the cataloguing plugin and see how the generated URL change. Also note that the files keep their original filename (without the hashvalue prepended) 7. Create some subdirectories under the main storage's path (using a shell). Try to upload a new files and see that these directories appear in a dropdown list. Select one, finish the upload and verify that the file has been uploaded to the selected subdirectory. 8. Run prove t/ImportBatch.t t/Koha/Storage.t t/db_dependent/ImportBatch.t t/db_dependent/Upload.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 14:39:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 13:39:26 +0000 Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318 --- Comment #15 from Julian Maurice --- Created attachment 127585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127585&action=edit Bug 19318: Normalize uploaded file name The uploaded file name can appear in the MARC record (if using the upload plugin), and all the strings in the MARC record are normalized using Unicode::Normalize::NFC. So the file name must be normalized everywhere (in the filesystem and in the uploaded_files table too). Test plan: 1. Create a file whose name contains combining characters. For instance: echo 'contents' > $(perl -e 'print "cine\x{cc}\x{81}ma"') 0xcc 0x81 is utf8 for "Combining acute accent" (́ ) https://unicode-table.com/fr/0301/ Once normalized it should be 0xc3 0xa9 (é) 2. Use the upload tool to upload this file 3. Verify on your filesystem that the filename is normalized % ls cin* | xxd 00000000: 6369 6ec3 a96d 610a cin..ma. ^^ ^^ 4. If you have configured the storage with a `baseurl`, use the upload cataloguing plugin, and verify that the generated URL works correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 14:43:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 13:43:05 +0000 Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 15:21:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 14:21:19 +0000 Subject: [Koha-bugs] [Bug 29466] New: MARC21: Missing space between repeated $e subfields in 7xx and 1xx Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29466 Bug ID: 29466 Summary: MARC21: Missing space between repeated $e subfields in 7xx and 1xx Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org If you have an author with multiple relator terms in $e there is no space between the entries. Example: 700$aName$eEditor$eAuthor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 15:22:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 14:22:00 +0000 Subject: [Koha-bugs] [Bug 29466] MARC21: Missing space between repeated $e subfields in 7xx and 1xx in result lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29466 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|MARC21: Missing space |MARC21: Missing space |between repeated $e |between repeated $e |subfields in 7xx and 1xx |subfields in 7xx and 1xx in | |result lists --- Comment #1 from Katrin Fischer --- This only affects the result lists. Using instead of a plain space seems to fix the issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 15:37:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 14:37:32 +0000 Subject: [Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 15:37:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 14:37:37 +0000 Subject: [Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119692|0 |1 is obsolete| | Attachment #126241|0 |1 is obsolete| | --- Comment #20 from Tomás Cohen Arazi --- Created attachment 127586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127586&action=edit Bug 21105: oai.pl returns invalid earliestDatestamp For OAI-PMH, all date and time values must be in the format "YYYY-MM-DDThh:mm:ssZ" and in UTC. Currently, Identify.earliestDatestamp uses the SQL format "YYYY-MM-DD hh:mm:ss". This patch fixes that. To test: 1) Get a Koha instance with OAI-PMH enabled. 2) Visit /cgi-bin/koha/oai.pl?verb=Identify, view source for the page and observe that earliestDate is in the wrong format "YYYY-MM-DD hh:mm:ss" 3) Apply patch 4) Visit /cgi-bin/koha/oai.pl?verb=Identify, view the source for the page and observe that earliestDate is now in the correct format "YYYY-MM-DDThh:mm:ssZ" 5) Sign off Sponsored-by: Reformational Study Centre Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 15:37:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 14:37:41 +0000 Subject: [Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 127587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127587&action=edit Bug 21105: Regression tests This patch introduces a regression test for the fixed behavior. I also changed a oneliner regex we had for stripping query parameters because it was causing a warning with the tests base URL (http://localhost) because it was generating an empty baseURL. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/OAI/Server.t => FAIL: Tests fail, the response is incorrect! 3. Apply the bug's patch 4. Repeat 2 => SUCCESS: Tests pass! Good response! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 15:37:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 14:37:46 +0000 Subject: [Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 127588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127588&action=edit Bug 21105: (QA follow-up) Silence warning because of tests setup The tests are using 'http://localhost' and the regex is setting $baseURL to empty in this case. It works on the oai.pl front-end. This patch changes the regex. To test: 1. Run: $ kshell k$ t/db_dependent/OAI/Server.t => FAIL: Boo! Warning! 2. Apply this patch 3. Repeat 2 => SUCCESS: Oh, cool. No warning :-D 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 15:37:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 14:37:55 +0000 Subject: [Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 127589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127589&action=edit Bug 21105: (QA follow-up) Avoid MySQL-ism Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 15:46:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 14:46:41 +0000 Subject: [Koha-bugs] [Bug 21104] oai.pl returns wrong baseURL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21104 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #1 from Tomás Cohen Arazi --- I tested a 21.05 demo site here [1] and this is not one of the problems that persist. Not sure what fixed it between now and 2018. [1] https://validator.oaipmh.com/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 15:46:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 14:46:41 +0000 Subject: [Koha-bugs] [Bug 21102] OAI-PMH specification conformance [UMBRELLA] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21102 Bug 21102 depends on bug 21104, which changed state. Bug 21104 Summary: oai.pl returns wrong baseURL https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21104 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 15:46:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 14:46:50 +0000 Subject: [Koha-bugs] [Bug 21104] oai.pl returns wrong baseURL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21104 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WORKSFORME |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 15:46:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 14:46:55 +0000 Subject: [Koha-bugs] [Bug 29467] New: MARC21: Display 1xx$u and 7xx$u affiliation in details and result lists Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29467 Bug ID: 29467 Summary: MARC21: Display 1xx$u and 7xx$u affiliation in details and result lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The subfield u = Affiliation for 1xx and 7xx is currently not displayed in Koha. https://www.loc.gov/marc/bibliographic/bdx00.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 15:57:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 14:57:38 +0000 Subject: [Koha-bugs] [Bug 21106] oai.pl XML output doesn't validate against OAI-PMH XML schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21106 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #2 from Tomás Cohen Arazi --- Nick, the 'Identify' bit is solved on bug 21105. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 16:13:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 15:13:22 +0000 Subject: [Koha-bugs] [Bug 23194] Public notes items in the OPAC should allow for HTML tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 16:22:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 15:22:21 +0000 Subject: [Koha-bugs] [Bug 29468] New: MARC21: Add display of 247 - Former Title Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29468 Bug ID: 29468 Summary: MARC21: Add display of 247 - Former Title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 16:25:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 15:25:09 +0000 Subject: [Koha-bugs] [Bug 29469] New: Error when approving and rejecting tags Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29469 Bug ID: 29469 Summary: Error when approving and rejecting tags Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org There is an AJAX error when approving or rejecting tags in the staff interface: Usage: POSIX::exit(status) at /kohadevbox/koha/tags/review.pl line 72. at /usr/share/perl/5.28/Carp.pm line 289 Carp::croak('Usage: POSIX::exit(status)') called at /usr/lib/x86_64-linux-gnu/perl/5.28/POSIX.pm line 22 POSIX::usage('exit(status)') called at (eval 1876) line 3 POSIX::exit at /kohadevbox/koha/tags/review.pl line 72 eval {...} at /kohadevbox/koha/tags/review.pl line 2 ...etc. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 16:57:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 15:57:31 +0000 Subject: [Koha-bugs] [Bug 29470] New: MARC21: Display 583 $x nonpublic note in staff interface Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29470 Bug ID: 29470 Summary: MARC21: Display 583 $x nonpublic note in staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org In 583 there is a nonpublic note subfield that could be displayed on the detail page in the staff interface. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 17:08:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 16:08:33 +0000 Subject: [Koha-bugs] [Bug 29471] New: MARC21: 520 - Summary etc. doesn't display in staff interface Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29471 Bug ID: 29471 Summary: MARC21: 520 - Summary etc. doesn't display in staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When the display for 520 was added to the OPAC, staff interface was missed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 17:45:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 16:45:14 +0000 Subject: [Koha-bugs] [Bug 29268] Query used in Koha::Biblio->get_marc_host is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29268 --- Comment #2 from Martin Renvoize --- Created attachment 127590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127590&action=edit Bug 29268: Correct cni handling for get_marc_host This patch adds a new method for fetching an ordered list of search queries that can then be used to fetch a records host biblio. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 17:48:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 16:48:45 +0000 Subject: [Koha-bugs] [Bug 29268] Query used in Koha::Biblio->get_marc_host is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29268 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127590|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 127591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127591&action=edit Bug 29268: Correct cni handling for get_marc_host This patch adds a new method for fetching an ordered list of search queries that can then be used to fetch a records host biblio. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 17:50:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 16:50:11 +0000 Subject: [Koha-bugs] [Bug 29268] Query used in Koha::Biblio->get_marc_host is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29268 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 17:50:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 16:50:16 +0000 Subject: [Koha-bugs] [Bug 29268] Query used in Koha::Biblio->get_marc_host is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29268 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 17:53:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 16:53:40 +0000 Subject: [Koha-bugs] [Bug 29268] Query used in Koha::Biblio->get_marc_host is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29268 --- Comment #4 from Martin Renvoize --- It took some leaps to work through this one... the host_record.t tests is failing for one case, but I'm not sure I understand the logic of what it's testing. In this change, we iterate through all 773 fields and their corresponding `w` subfields. We build an array of search options from this in order of most specific to least specific (our cni followed by any cni followed by just cn) searches.. we then execute these searches in order until we find one that has just a singular search match at which point we jump out of the loop and continue as we did before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 18:21:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 17:21:30 +0000 Subject: [Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Depends on| |23376 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 [Bug 23376] Cleanup order receive page code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 18:21:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 17:21:30 +0000 Subject: [Koha-bugs] [Bug 23376] Cleanup order receive page code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28627 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 18:21:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 17:21:35 +0000 Subject: [Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 --- Comment #4 from Nick Clemens --- Created attachment 127592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127592&action=edit Bug 28627: [alternate] Calculate unitprice if not set On bug 23376 the developer was too clever by half. Instead of passing values to the template we moved to simply passing the order object. The calculations that populated the unitprice, however, were simply dropped. This patch restores the behaviour of setting unitprice to the estimated cost by default. We do this conditionally in the template To test: 1 - Create a basket and adding items to it. Set the 'Vendor price' to '20', do not add an 'Actual cost' 2 - Close the basket 3 - Select 'Receive shipment' 4 - Set a value for vendor invoice 5 - Receive the order you created 6 - Observe 'Actual cost' is = 0.00 7 - Apply patch 8 - Refresh the order receival page, and confirm the 'Actual cost' = 20.00 9 - Cancel receipt - reopen basket - edit order - add an actual cost - close 10 - Receive the order again 11 - Confirm the actual price is used 12 - Repeat this whole plan, but ensure the vendor has a different value for Invoice prices: Include tax -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 18:29:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 17:29:53 +0000 Subject: [Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #5 from Nick Clemens --- (In reply to Alex Buckley from comment #1) > Created attachment 122380 [details] [review] > Bug 28627: Fallback to displaying ecost_tax_included, ecost_tax_excluded in > orderreceive.pl I think the logic here is was backward IF (order.unitprice_tax_included == 0.00000) THEN order.unitprice_tax_included ELSE order.ecost_tax_included I submitted an alternate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 18:49:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 17:49:04 +0000 Subject: [Koha-bugs] [Bug 29463] Umlauts in search field get changed into Replacement character In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 18:49:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 17:49:09 +0000 Subject: [Koha-bugs] [Bug 29463] Umlauts in search field get changed into Replacement character In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127583|0 |1 is obsolete| | --- Comment #3 from Joonas Kylmälä --- Created attachment 127593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127593&action=edit Bug 29463: Escape utf8 characters before appending search query to url To test: 1) go to the main page of Koha and search in the "Check out" search window type "näyttö". 2) see that umlauts got replaced with replacement characters. 3) apply the patch. 4) repeat 1-2, ensure that umlauts displayed correctly and are not getting replaced with replacement characters. JK: remove period from commit title Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 18:52:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 17:52:08 +0000 Subject: [Koha-bugs] [Bug 29463] Umlauts in search field get changed into Replacement character In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi Depends on| |15812 Severity|minor |normal --- Comment #4 from Joonas Kylmälä --- Regression from bug 15812, would be nice to get this in before the 21.11 release. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 18:52:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 17:52:08 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29463 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 [Bug 29463] Umlauts in search field get changed into Replacement character -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 18:54:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 17:54:21 +0000 Subject: [Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 Nathan Walker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nathan.walker at citruslibrari | |es.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 19:13:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 18:13:52 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127207|0 |1 is obsolete| | Attachment #127431|0 |1 is obsolete| | --- Comment #6 from Joonas Kylmälä --- Created attachment 127594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127594&action=edit Bug 29387: Stringify exception when logging error during a batch mod biblio If an exception is raised by one the methods/subroutines called when batch biblio update, the job will fail in the middle and some records won't be processed. Test plan: 0. Don't apply the patch In KTD you can run the a batch mod biblio on the 100 first records and the worker will fail with """ countered object 'C4::Biblio::_koha_modify_biblioitem_nonmarc(): DBI Exception: DBD::mysql::st execute failed: Data too long for column 'lccn' at row 1 at /kohadevbox/koha/C4/Biblio.pm line 423 ', but neither allow_blessed, convert_blessed nor allow_tags settings are enabled (or TO_JSON/FREEZE method missing) at /kohadevbox/koha/Koha/BackgroundJob/BatchUpdateBiblio.pm line 120. """ The UI is not saying anything about this problem. Generate 100 biblionumbers: perl -e 'for (1..100){print "$_\n"}' 1. Apply the patch and confirm than now you see the detail of the batch update and that biblionumber 72 is marked as not been modified with the correct error (raw DBI error) JK: add executable bit to BatchUpdateBiblio.t Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 19:13:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 18:13:56 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 --- Comment #7 from Joonas Kylmälä --- Created attachment 127595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127595&action=edit Bug 29387: Strinfigy exceptions for other background job modules Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 19:16:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 18:16:15 +0000 Subject: [Koha-bugs] [Bug 28019] Script "process_message_queue.pl" no more accepting comma separated addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28019 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|ASSIGNED |RESOLVED --- Comment #5 from Tomás Cohen Arazi --- This is actually fixed by bug 28870. Tested on master with (a good SMTP config on koha-conf.xml and) this command: $ perl misc/cronjobs/runreport.pl --to "tomascohen at gmail.com,nick at bywatersolutions.com,liz at bywatersolutions.com" --subject "Sending to tomascohen at gmail.com,nick at bywatersolutions.com,liz at bywatersolutions.com" --format html 1 *** This bug has been marked as a duplicate of bug 28870 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 19:16:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 18:16:15 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mik at adminkuhn.ch --- Comment #49 from Tomás Cohen Arazi --- *** Bug 28019 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 19:16:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 18:16:29 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Joonas Kylmälä --- (In reply to Fridolin Somers from comment #5) > We have two behaviors : > error => "$@" > error => ($@ ? "$@" : 0) > Shouldn't it be only one here ? In the error => "$@" cases there is already the if else check in the outer "if else" block so no need for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 19:33:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 18:33:37 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17979 CC| |joonas.kylmala at iki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 19:33:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 18:33:37 +0000 Subject: [Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29437 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 19:56:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 18:56:46 +0000 Subject: [Koha-bugs] [Bug 7456] Itemtype codes with hyphens and spaces can cause unexpected search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7456 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 20:21:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 19:21:31 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 20:21:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 19:21:36 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127527|0 |1 is obsolete| | --- Comment #3 from Joonas Kylmälä --- Created attachment 127596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127596&action=edit Bug 29457: Pass context borrowernumber This patch updates the call to cancel such that we pass the currently logged in users borrowernumber instead of their userid. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 20:23:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 19:23:01 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi --- Comment #4 from Joonas Kylmälä --- well this is bad indeed. I wonder what should be done with those corrupted entries, delete them or move them to some temp column in case someone wants to try to use them to track down the person who did the action? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 21:30:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 20:30:17 +0000 Subject: [Koha-bugs] [Bug 29472] New: Add option to view syspref history from a system preference Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29472 Bug ID: 29472 Summary: Add option to view syspref history from a system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com All system preference changes are logged automatically - it would be nice if there were a way to view the history of a systempreference from the syspref editor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 22:22:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 21:22:07 +0000 Subject: [Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 22:22:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 21:22:10 +0000 Subject: [Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127592|0 |1 is obsolete| | --- Comment #6 from Andrew Fuerste-Henry --- Created attachment 127597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127597&action=edit Bug 28627: [alternate] Calculate unitprice if not set On bug 23376 the developer was too clever by half. Instead of passing values to the template we moved to simply passing the order object. The calculations that populated the unitprice, however, were simply dropped. This patch restores the behaviour of setting unitprice to the estimated cost by default. We do this conditionally in the template To test: 1 - Create a basket and adding items to it. Set the 'Vendor price' to '20', do not add an 'Actual cost' 2 - Close the basket 3 - Select 'Receive shipment' 4 - Set a value for vendor invoice 5 - Receive the order you created 6 - Observe 'Actual cost' is = 0.00 7 - Apply patch 8 - Refresh the order receival page, and confirm the 'Actual cost' = 20.00 9 - Cancel receipt - reopen basket - edit order - add an actual cost - close 10 - Receive the order again 11 - Confirm the actual price is used 12 - Repeat this whole plan, but ensure the vendor has a different value for Invoice prices: Include tax Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 22:43:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 21:43:28 +0000 Subject: [Koha-bugs] [Bug 28413] background job worker is running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com --- Comment #20 from Andrew Nugged --- in https://git.koha-community.org/Koha-community/Koha/src/branch/master/Koha/BackgroundJob/BatchDeleteItem.pm#L113 my $item = Koha::Items->find($record_id) || next; it dies because was lost "use Koha::Items;" like here: https://git.koha-community.org/Koha-community/Koha/src/branch/master/Koha/BackgroundJob/BatchUpdateItem.pm#L33 since now packages are not included all at once, like before this ticket, when all modules were loaded by neighbors so the error was hidden. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 22:50:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 21:50:04 +0000 Subject: [Koha-bugs] [Bug 28413] background job worker is running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413 --- Comment #21 from Andrew Nugged --- Created attachment 127598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127598&action=edit Bug 28413: (QA follow-up) Fix for missing use Koha::Items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 23:33:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 22:33:27 +0000 Subject: [Koha-bugs] [Bug 28474] Pass process_message_queue.pl params to before_send_messages plugin hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28474 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | --- Comment #11 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 (Backported for plugins compatibility) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 23:36:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 22:36:57 +0000 Subject: [Koha-bugs] [Bug 27173] Add plugin hooks for authority record changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | --- Comment #18 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 Also backported for plugins compatibility -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 23:45:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 22:45:04 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 --- Comment #27 from David Gustafsson --- Created attachment 127599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127599&action=edit Bug 25539: Remove AddBiblio option "defer_marc_save" Items are no longer embedded in the MARCXML and because of this the MARC data does not need to be saved once more after changing record items data. The "defer_marc_save" is no longer needed since bulkmarcimport.pl was the only place this option was utilized in order to resave MARC data after possibly changing items data. There is also a bug bulkmarcimport.pl where the record data is re-saved without stripping items if duplicate items are found and the dedup barcodes option is enabled that is resolved by this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 23:45:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 22:45:08 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110261|0 |1 is obsolete| | --- Comment #28 from David Gustafsson --- Created attachment 127600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127600&action=edit Bug 25539: Strip items when adding new biblio to preserve previous behaviour of the script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 23:46:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 22:46:34 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109789|0 |1 is obsolete| | Attachment #127599|0 |1 is obsolete| | --- Comment #29 from David Gustafsson --- Created attachment 127601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127601&action=edit Bug 25539: Remove AddBiblio option "defer_marc_save" Items are no longer embedded in the MARCXML and because of this the MARC data does not need to be saved once more after changing record items data. The "defer_marc_save" is no longer needed since bulkmarcimport.pl was the only place this option was utilized in order to resave MARC data after possibly changing items data. There is also a bug bulkmarcimport.pl where the record data is re-saved without stripping items if duplicate items are found and the dedup barcodes option is enabled that is resolved by this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 23:46:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 22:46:38 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127600|0 |1 is obsolete| | --- Comment #30 from David Gustafsson --- Created attachment 127602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127602&action=edit Bug 25539: Strip items when adding new biblio to preserve previous behaviour of the script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 23:47:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 22:47:06 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 --- Comment #31 from David Gustafsson --- Now rebased upon bug 29440 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 23:49:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 22:49:51 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127602|0 |1 is obsolete| | --- Comment #32 from David Gustafsson --- Created attachment 127603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127603&action=edit Bug 25539: Strip items when adding new biblio to preserve previous behaviour of the script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 12 23:55:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 22:55:17 +0000 Subject: [Koha-bugs] [Bug 29378] After the automatic update to 21.05.05, the OPAC switches to maintenance mode and the web installer is displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29378 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #19 from Fridolin Somers --- I see this is actually in 21.05.x : https://git.koha-community.org/Koha-community/Koha/commit/1b39d0717a4b81cda28c72e07bb47e534d9d205b And there is a DBRev 21.05.05.004 for Bug 29386 So problem solved ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 00:01:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 23:01:11 +0000 Subject: [Koha-bugs] [Bug 29386] background jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #15 from Fridolin Somers --- (In reply to Kyle M Hall from comment #14) > Pushed to 21.05.x for 21.05.05 /!\ beware : I see the commit https://git.koha-community.org/Koha-community/Koha/commit/78e28dc804d379f7409b553afe5851a8a4a7442b The change in Koha.pm is missing no ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 00:05:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 23:05:09 +0000 Subject: [Koha-bugs] [Bug 29386] background jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | --- Comment #16 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 00:10:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 23:10:50 +0000 Subject: [Koha-bugs] [Bug 29386] background jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 --- Comment #17 from Fridolin Somers --- Note this contains 3 commits : a4aa24931c Bug 29386: DBIC schema changes 9c5e3ef1c9 Bug 29386: DBRev 20.11.11.001 6d74511c5c Bug 29386: Extend background_jobs.data to LONGTEXT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 00:14:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 23:14:36 +0000 Subject: [Koha-bugs] [Bug 28768] OPAC reading history page (opac-readingrecord.pl) wont display news items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28768 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 00:16:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 23:16:34 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #22 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 00:17:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 23:17:58 +0000 Subject: [Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 00:25:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Nov 2021 23:25:10 +0000 Subject: [Koha-bugs] [Bug 29195] Highlighting broken on odd rows in circ-patron-search-results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29195 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 11:39:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 10:39:21 +0000 Subject: [Koha-bugs] [Bug 29473] New: Documentation tasks for 21.11 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29473 Bug ID: 29473 Summary: Documentation tasks for 21.11 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org We are now using Bugzilla to manage documentation tasks. This is a placeholder for reviewing all the bugs in 21.11 and determining which ones require documentation updates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 11:39:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 10:39:54 +0000 Subject: [Koha-bugs] [Bug 29473] Documentation tasks for 21.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29473 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |david at davidnind.com |ity.org | QA Contact|testopia at bugs.koha-communit | |y.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 12:50:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 11:50:41 +0000 Subject: [Koha-bugs] [Bug 29473] Documentation tasks for 21.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29473 --- Comment #1 from David Nind --- I have created a spreadsheet from a Bugzilla query that lists all bugs pushed to master for 21.11. This will be used to: 1. Review all bugs 2. Determine if documentation changes are required, and 3. Manage documentation tasks for a release. Process for creating the initial list: 1. View the results of the Bugzilla query: https://bugs.koha-community.org/bugzilla3/buglist.cgi?cmdtype=runnamed&list_id=391785&namedcmd=Doc%20changes%2021.11 2. Save as a CSV file. 3. Create an editable spreadsheet using whatever online tool considered appropriate. 4. Add columns for: . Reviewed for documentation changes (Y/N) . Documentation changes required? (Y/N) . Complexity (Easy|Medium|hard) . Reviewed by . Assigned to . Notes (add any relevant notes, for example there may be several bugs related to a change that can be managed as one documentation change) 5. Review each bug and determine whether any updates are required. 6. Update the columns in the spreadsheet (apart from assigned to). Ideally, the spreadsheet is updated weekly with the new bugs pushed to master - use the GitLab mirror as new commits pushed show up in date order (https://gitlab.com/koha-community/Koha/-/commits/master), but they don't in the Gitea repository. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 12:52:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 11:52:09 +0000 Subject: [Koha-bugs] [Bug 29473] Documentation tasks for 21.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29473 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Priority|P5 - low |P1 - high URL| |https://docs.google.com/spr | |eadsheets/d/15AvxO5ReEgyAcS | |TjXs1zkQ4LzDJQw3Zn_Zk0L2g5m | |kI/edit?usp=sharing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 13:37:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 12:37:29 +0000 Subject: [Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 13:37:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 12:37:33 +0000 Subject: [Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127597|0 |1 is obsolete| | --- Comment #7 from Joonas Kylmälä --- Created attachment 127604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127604&action=edit Bug 28627: [alternate] Calculate unitprice if not set On bug 23376 the developer was too clever by half. Instead of passing values to the template we moved to simply passing the order object. The calculations that populated the unitprice, however, were simply dropped. This patch restores the behaviour of setting unitprice to the estimated cost by default. We do this conditionally in the template To test: 1 - Create a basket and adding items to it. Set the 'Vendor price' to '20', do not add an 'Actual cost' 2 - Close the basket 3 - Select 'Receive shipment' 4 - Set a value for vendor invoice 5 - Receive the order you created 6 - Observe 'Actual cost' is = 0.00 7 - Apply patch 8 - Refresh the order receival page, and confirm the 'Actual cost' = 20.00 9 - Cancel receipt - reopen basket - edit order - add an actual cost - close 10 - Receive the order again 11 - Confirm the actual price is used 12 - Repeat this whole plan, but ensure the vendor has a different value for Invoice prices: Include tax Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 13:39:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 12:39:23 +0000 Subject: [Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 14:00:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 13:00:59 +0000 Subject: [Koha-bugs] [Bug 29273] Warning not caught in tests for plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 14:01:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 13:01:03 +0000 Subject: [Koha-bugs] [Bug 29273] Warning not caught in tests for plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126582|0 |1 is obsolete| | --- Comment #8 from Joonas Kylmälä --- Created attachment 127605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127605&action=edit Bug 29273: Remove warnings from plugin tests This patch is suggesting to move the broken test plugins into a separate directory. t/lib/plugins and t/lib/bad_plugins Signed-off-by: David Nind JK: Add executable bit to Broken.t Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 14:22:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 13:22:10 +0000 Subject: [Koha-bugs] [Bug 29264] SIP config allows use of non-branchcode institution ids causes workers to die without responding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29264 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 14:22:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 13:22:13 +0000 Subject: [Koha-bugs] [Bug 29264] SIP config allows use of non-branchcode institution ids causes workers to die without responding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29264 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127425|0 |1 is obsolete| | --- Comment #4 from Joonas Kylmälä --- Created attachment 127606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127606&action=edit Bug 29264: SIP config allows use of non-branchcode institution ids causes workers to die without responding If is entirely possible to create an SIP institution whose ID does not match a valid branchcode in Koha's SIP config. In fact, Koha's example SIP config contains an example of this ( kohalibrary / kohalibrary2 ). If a SIP login uses an institution with an id that doesn't match a valid branchcode, everything will appear to work, but the SIP worker will die anywhere that Koha gets the branch from the userenv and assumes it is valid. The repercussions of this are that actions such as the checkout message simply die and do not return a response message to the requestor. At the very least, we should output a warning to the SIP log. I think we should strongly consider disallowing institution ids in the SIP config that do not match valid branchcodes. In this scenario, attempting to start the SIP server should result in a error message with the SIP server exiting immediately. Test Plan: 1) Apply this patch 2) Make a sip login that uses an instution whose id is *not* a valid branchcode 3) Start the SIP server 4) Check sip.log, you should see a warning similar to the following: [2021/10/18 12:18:29] [2068079] [ERROR] ERROR: Institution kohalibrary does does not match a branchcode. This can cause unexpected behavior. C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220) Signed-off-by: David Nind Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 14:23:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 13:23:18 +0000 Subject: [Koha-bugs] [Bug 29264] SIP config allows use of non-branchcode institution ids causes workers to die without responding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29264 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 14:35:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 13:35:49 +0000 Subject: [Koha-bugs] [Bug 29255] Built-in offline circulation broken with SQL error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 14:35:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 13:35:52 +0000 Subject: [Koha-bugs] [Bug 29255] Built-in offline circulation broken with SQL error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127179|0 |1 is obsolete| | --- Comment #5 from Joonas Kylmälä --- Created attachment 127607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127607&action=edit Bug 29255: Built-in offline circulation broken with SQL error This patch makes a minor correction to one of the queries used when synchronizing transactions in the built-in offline circulation system. This fixes the error: DBD::mysql::st execute failed: Column 'branchcode' in field list is ambiguous at /kohadevbox/koha/offline_circ/download.pl line 84 To test you must be using a browser which still supports applicationCache (Firefox before version 81, Chrome before version 94). - Apply the patch and restart services. - Enable the AllowOfflineCirculation system preference. - Go to Circulation -> Built-in offline circulation interface. - Click "Synchronize." - Click the "Download records" button. - After the page refreshes you should see updated dates where it lists "last synced" information. Signed-off-by: Martin Renvoize Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 14:37:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 13:37:07 +0000 Subject: [Koha-bugs] [Bug 29255] Built-in offline circulation broken with SQL error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 14:58:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 13:58:11 +0000 Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create mysqluser@mysql_hostname so zebra update fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi --- Comment #35 from Joonas Kylmälä --- (In reply to Rudolf Byker from comment #15) > Created attachment 96975 [details] [review] > Use `DROP USER IF EXISTS` and remove ` || true`. > > All right, here is my attempt at a proper patch! The author name is missing, it just has your username I guess: "dolf". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 15:17:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 14:17:07 +0000 Subject: [Koha-bugs] [Bug 27145] Patron deletion via intranet doesn't handle exceptions well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 15:17:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 14:17:10 +0000 Subject: [Koha-bugs] [Bug 27145] Patron deletion via intranet doesn't handle exceptions well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127545|0 |1 is obsolete| | Attachment #127546|0 |1 is obsolete| | --- Comment #7 from Joonas Kylmälä --- Created attachment 127608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127608&action=edit Bug 27145: Rethrow all other exceptions Bug 14708 introduced a try catch around $patron->delete in commit: "Bug 14708: (QA follow-up) Use try/catch blocks when calling" However, in the catch block it only assumes the exception was from trying to delete anonymous patron when it can be anything else as well, the code should be modified so that it will handle the anonymous patron case and if it is anything else we log the other exception. Signed-off-by: Martin Renvoize Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 15:17:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 14:17:14 +0000 Subject: [Koha-bugs] [Bug 27145] Patron deletion via intranet doesn't handle exceptions well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 --- Comment #8 from Joonas Kylmälä --- Created attachment 127609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127609&action=edit Bug 27145: Wrap delete and move_to_deleted in a transaction Signed-off-by: Martin Renvoize Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 15:18:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 14:18:08 +0000 Subject: [Koha-bugs] [Bug 27145] Patron deletion via intranet doesn't handle exceptions well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 15:32:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 14:32:14 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #13) > I wasn't aware of this behaviour, but it does not sound correct. "Branch" > must contain the branchcode, and be a foreign key. If we want to keep this > additional information it should be stored into a separate column. The change should be then done for the statistics table as well, in this same bug report, since there is only one syspref, OpacRenewalBranch, for both the tables (statistics and pseudonymized_transactions). In addition to that the OpacRenewalBranch syspref needs to be updated to described that if opacrenewal is used then it is stored into another column. Another thing we might wanna fix here is that if the user actually selects "NULL" as the OpacRenewalBranch syspref value then we store empty string and not null really (I wonder if this NULL/empty string is actually a regression?). > Note that Marcel's workaround should work, if you create a branch with > branchcode="OPACRenew" that should be inserted instead of NULL. Not suitable for production. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 15:42:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 14:42:47 +0000 Subject: [Koha-bugs] [Bug 29474] New: Automatic renewals cronjob is slow on systems with large numbers of reserves Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Bug ID: 29474 Summary: Automatic renewals cronjob is slow on systems with large numbers of reserves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When a site has many holds the automatic renewals cron can take a long time to run This is increased if the system preference 'AllowRenewalIfOtherItemsAvailable' is set to allow -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 15:43:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 14:43:45 +0000 Subject: [Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |joonas.kylmala at iki.fi --- Comment #7 from Joonas Kylmälä --- Doesn't apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 15:46:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 14:46:47 +0000 Subject: [Koha-bugs] [Bug 27269] Move C4::Biblio::GetMarcSubjects to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Joonas Kylmälä --- Doesn't apply anymore :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 15:50:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 14:50:24 +0000 Subject: [Koha-bugs] [Bug 29463] Umlauts in search field get changed into Replacement character In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |gmcharlt at gmail.com, | |kyle.m.hall at gmail.com Component|Searching |Circulation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 16:29:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 15:29:31 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #1 from Nick Clemens --- Created attachment 127610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127610&action=edit Bug 29474: Return too_soon before checking renewals This patch allows us to avoid checking reserves when the issue is too_soon and we are running the cron Code is covered by existing tests To test: 1 - prove -v t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 16:43:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 15:43:50 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |joonas.kylmala at iki.fi --- Comment #56 from Joonas Kylmälä --- 1. Some of the patches are missing check if there is any transfer at all before proceeding to check in_transit status: + my $transfer = $item->get_transfer; + if ( $transfer->in_transit ) { This results to such errors as this: > Can't call method "in_transit" on an undefined value at /kohadevbox/koha/catalogue/detail.pl line 350 2. The patch "Bug 24295: Finally remove GetTransfers from C4/Circulation" needs to come last in the patch series, so just reorder and reattach the patches. 3. Need to add "use Koha::DateUtils qw( output_pref );" to those patches that use the output_pref function here. 4. "Bug 24295: Remove GetTransfers from detail.pl" removes hours and minutes, please bring them back :) 5. "Bug 24295: Remove GetTransfer from Z3950Responder" now only lists the in_transit transfers, it used to return all transfers previously, even those not yet sent (so in queue). Could you double check on this? I think it is okay and the previous behaviour was buggy as it says they are IN_TRANSIT transfers, not queued ones. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 17:06:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 16:06:37 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi --- Comment #2 from Joonas Kylmälä --- If you remove the unless then you can delete the line > return ( 0, "on_reserve" ) if $resfound && $cron; # '' when no hold was found Makes the code much simpler. Please also move the cron return right after the call to > $auto_renew = _CanBookBeAutoRenewed({ so that now that the return value decision is not in an if-else condition at the end the requirement for returning the values in a different order is clear and the order won't be changed by some other developer accidentally. I think adding a comment like "cron wants 'too_soon' over 'on_reserve'" Please include stats too, but maybe you are at it, I noticed that this bug is not even yet for sign-off and I'm here reviewing ;D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 17:12:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 16:12:04 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #3 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #2) > I think adding a comment like "cron wants 'too_soon' over 'on_reserve'" This sentence was unfinished.. I meant adding this comment next to the code when returning the 'too_soon' reason near the _CanBookBeAutoRenewed function call. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 19:50:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 18:50:50 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127610|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 127611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127611&action=edit Bug 29474: Return too_soon before checking renewals This patch allows us to avoid checking reserves when the issue is too_soon and we are running the cron Code is covered by existing tests To test: 1 - prove -v t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 19:53:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 18:53:23 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #5 from Nick Clemens --- (In reply to Joonas Kylmälä from comment #2) > If you remove the unless ... makes the code much simpler. Done > Please also move the cron return right after the call to > > $auto_renew = _CanBookBeAutoRenewed({ I don't believe I can. That is inside "unless ($override_limit)" so it would make 'too_soon' subject to override > Please include stats too, but maybe you are at it, I noticed that this bug > is not even yet for sign-off and I'm here reviewing ;D Yes, seeing what else I can improve first, will add when ready. Feel free to add to/alter my patches - I appreciate the help! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 20:23:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 19:23:23 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127611|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 127612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127612&action=edit Bug 29474: Return too_soon before checking renewals This patch allows us to avoid checking reserves when the issue is too_soon and we are running the cron Code is covered by existing tests To test: 1 - prove -v t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 20:23:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 19:23:59 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #7 from Nick Clemens --- (In reply to Nick Clemens from comment #5) > > Please also move the cron return right after the call to > > > $auto_renew = _CanBookBeAutoRenewed({ > > I don't believe I can. That is inside "unless ($override_limit)" so it would > make 'too_soon' subject to override > I was wrong, done -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 20:52:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 19:52:19 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Michelle Carrillo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mcarrillo at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 21:01:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 20:01:38 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #8 from Nick Clemens --- Created attachment 127613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127613&action=edit Bug 29474: Check ItemsAnyAvailableAndNOtRestricted outside of loop IsAvailableForItemLevelRequest takes $items_any_available to avoid a double loop - this was done in request.pl, but it makes sense to do the same here -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 21:10:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 20:10:59 +0000 Subject: [Koha-bugs] [Bug 29475] New: opac-user.pl checks renewability even if patron expired and expired patrons blocked from renewal Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29475 Bug ID: 29475 Summary: opac-user.pl checks renewability even if patron expired and expired patrons blocked from renewal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Found while working on bug 29474: CanBookBeRenewed performs a check on whether the patron is blocked from renewing, however, it only does this check for auto_renewals. This would seem like a bug, however, the template opac-user.tt performs a check and simply removes any renewal options at display opac-renew.pl does the check in the script, so the renewal can stil not be performed, however, checking renewability in opac-user.pl is not optimal for performance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 21:51:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 20:51:45 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #9 from Nick Clemens --- 5 renewals allowed No renewal before unset (i.e. not before due) For a single biblio 100 items on record 10 items checked out and marked auto_renew 10 record level holds Without these patches: ~3.7 second With these patches ~1.5 second Then I set 'On shelf holds allowed' to 'If all unavailable' Without these patches: ~3 MINUTES! With these patches ~1.5 seconds To further test 'ItemsAnyAvailable' I set all the items as overdue, changed nothing else Without these patches: ~3 minutes With these patches ~1.25 minutes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 22:01:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 21:01:49 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 13 22:11:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Nov 2021 21:11:55 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #15 from Katrin Fischer --- I agree that knowing if a renewal was done from the OPAC is important and we need to maintain that information in some way. We could argue that in statistics the column doesn't need to be an FK, as you might want to keep statistics for deleted branches still. Same for itemtypes, categories etc. I think we could treat statistics like a log that is not altered by changes happening around it where we can avoid it. Adding a branch for that purpose is no solution (as Joonas already said :) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 06:18:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 05:18:35 +0000 Subject: [Koha-bugs] [Bug 28236] Selecting database columns for system preferences in standard and dev installs is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This fixes Apache access to release notes| |json files in koha-tmpl for | |non-package installs. This | |causes issues for system | |preferences where there is | |a pick list for database | |columns. | | | |Bug 22844 | |introduced a pick list of | |database columns for system | |preferences where such a | |list was required. This | |list is in a plain json | |file under the templates | |directory. This works fine | |for packages, but because | |of bug 9812 (which limited | |browser access to selected | |files) those directories | |are not accessible to the | |outside world for both | |standard and dev type | |installs using the make | |process. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 08:55:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 07:55:17 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Joonas Kylmälä --- The last patch is wrong, it checks the availability for the patron who is wanting to do the renewal and not the other patrons as it should (notice that the $patron variable is redefined here). You could however achieve the performance boost by adding the $items_any_available value to a hash table where the keys are borrowernumbers. However, I think we might be able to avoid that (it makes the code pretty ugly imho if we use the hash table) by splitting somehow the while loops and maybe ordering it so that we iterate patrons in the outer loop. Like I think "next if IsItemOnHoldAndFound( $item->itemnumber );" could be moved to its own loop. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 09:26:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 08:26:38 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #11 from Joonas Kylmälä --- oh, I think I discovered a bug in the CanBookBeRenewed function. We are calling > next unless IsAvailableForItemLevelRequest($item, $patron); and we are not passing the ignore_hold_counts=>1 here even though we should be. The patch "Bug 28013: (follow-up) Correct and update call to CanItemBeReserved" which is pushed already fixed it for the CanItemBeReserved() function call just the line below but this has the same bug. If you follow this code path you will notice the bug: IsAvailableForItemLevelRequest -> ItemsAnyAvailableAndNotRestricted -> CanItemBeReserved So this needs to kept also in mind while doing the perf work here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 11:45:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 10:45:30 +0000 Subject: [Koha-bugs] [Bug 28898] Context for translation: term (word) vs. term (semester) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This disambiguates the term release notes| |"term" used in course | |reserves, where the meaning | |is "semester". This allows | |it to be translated, rather | |than having to use JQuery | |to change the text | |displayed for languages | |other then English. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 11:45:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 10:45:49 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #12 from Joonas Kylmälä --- In the first patch you added the comment: # override_limit will override anything else except on_reserve or too_soon This is actually not what the code does, but it should do this I think, it used to do this but after the patch "Bug 19014: Return auto_too_soon before on_reserve" (51f5f6) the behaviour was changed. It was unadvertised change so it seems like a regression introduced by bug 19014. So actually the too_soon return should be outside the $override_limit if block as you had it the first time but before that we need to fix the regression from bug 19014. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 11:46:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 10:46:48 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #5 from Martin Renvoize --- I was really disappointed in myself getting this wedding in the first place :-(. Very good question regarding the corrupt entries; I can't see any obvious way to work backwards to reconstruct them so I think my vote would be to remove them... but I'm very much open to suggestions if anyone can think of a way to do better.. perhaps assigning to the anonymous user if one exists? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 11:48:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 10:48:29 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #6 from Martin Renvoize --- Hmm, maybe we can work backwards to get the right manager id.. I'll work on an update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 11:50:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 10:50:43 +0000 Subject: [Koha-bugs] [Bug 29146] Default values from the framework should only be applied at biblio/item creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 --- Comment #25 from Martin Renvoize --- By all means start with a question.. but amend it once a conclusion has been reached perhaps? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 11:53:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 10:53:29 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #13 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #12) > In the first patch you added the comment: > > # override_limit will override anything else except on_reserve or too_soon > > This is actually not what the code does, but it should do this I think, it > used to do this but after the patch "Bug 19014: Return auto_too_soon before > on_reserve" (51f5f6) the behaviour was changed. It was unadvertised change > so it seems like a regression introduced by bug 19014. So actually the > too_soon return should be outside the $override_limit if block as you had it > the first time but before that we need to fix the regression from bug 19014. Hmm, actually there is no regression, there was the $override_limit check also before bug 19014. So the comment you added should be removed. Sorry for the noise, the code is just so hard to understand... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 13:48:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 12:48:54 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127612|0 |1 is obsolete| | Attachment #127613|0 |1 is obsolete| | --- Comment #14 from Joonas Kylmälä --- Created attachment 127614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127614&action=edit Bug 29474: Return too_soon before checking renewals This patch allows us to avoid checking reserves when the issue is too_soon and we are running the cron Code is covered by existing tests To test: 1 - prove -v t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 13:48:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 12:48:57 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #15 from Joonas Kylmälä --- Created attachment 127615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127615&action=edit Bug 29474: Fix incorrect comment The too_soon is actually being overriden if $override_limit is true. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 13:49:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 12:49:01 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #16 from Joonas Kylmälä --- Created attachment 127616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127616&action=edit Bug 29474: Decouple renewal checks of auto-renewed issues from non-autorenewed The too_soon check does not relate at all to auto-renewed issues and should be moved outside the _CanBookBeAutoRenewed() function. To test: 1) prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 13:49:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 12:49:04 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #17 from Joonas Kylmälä --- Created attachment 127617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127617&action=edit Bug 29474: Remove one layer of indendation by adding if check in the begginning If we simply return "no" immediately from the function when the checkout is not an autorenewed checkout we can drop one layer of indendation and the code becomes much easier to read. To test: 1) prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 14:01:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 13:01:17 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #18 from Joonas Kylmälä --- I fixed the incorrect comment about too_soon not being overriden and added couple improvements to the code as well. I obsoleted also the patch from comment #8 now as it was buggy (see comment #10). I could try to work on those perf improvements as what was tried in the patch attached in comment #8 but I'm not sure I will manage to do that in the nearby days so please go ahead and have a new attempt at it as if I will it might take time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 14:02:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 13:02:05 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 14:16:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 13:16:03 +0000 Subject: [Koha-bugs] [Bug 29476] New: Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 Bug ID: 29476 Summary: Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: joonas.kylmala at iki.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The code in circ/renew.pl uses the code C4::Circulation::GetSoonestRenewDate to check the soonest renewal date and then displays it to the librarian. However, the code called by CanBookBeRenewed() that actually does the final check uses different calculation method for issues with auto renewal enabled. For auto renewed issues without circulation rules defined for soonest renewal date the soonest renewal date is the due date, in normal loans case the soonest renewal date is NOW(). This is not probably a too big annoyance to librarians, I just wanna clean up this so I can refactor some code in CanBookBeRenewed, will attach a patch shortly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 14:43:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 13:43:38 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #16 from Marcel de Rooy --- I am getting the feeling here that this fix is blamed for the weird OpacRenewalBranch stuff already in Koha. Obviously, this should have been developed differently. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 15:16:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 14:16:43 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor Assignee|koha-bugs at lists.koha-commun |joonas.kylmala at iki.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 15:19:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 14:19:37 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 --- Comment #1 from Katrin Fischer --- Hi Joonas, for "normal" renewals the "not renewal x days before" is also used. Actually it was developed fro normal renewals and around before the auto renewals were added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 15:31:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 14:31:49 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 15:31:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 14:31:52 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 --- Comment #2 from Joonas Kylmälä --- Created attachment 127618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127618&action=edit Bug 29476: Correct soonest renewal date calculation for checkouts with auto-renewal If a checkout with auto-renewal enabled doesn't have a "norenewalbefore" circulation rule set the code in CanBookBeRenewed() falls back to using due date (to verify this please look for the string "auto_too_soon" in C4/Circulation.pm), the calculation result of GetSoonestRenewDate() however didn't do this, though luckily it was not used in CanBookBeRenewed so we didn't get any issues there. However, GetSoonestRenewDate() is used for display the soonest renewal date in the staff interface on the circ/renew.pl page so you would have gotten wrong results there. This patch moves additionally the tests made for Bug 14395 under a new subtest for GetSoonestRenewDate() as they should have been like that already before. To test: 1) prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 15:33:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 14:33:57 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 --- Comment #3 from Joonas Kylmälä --- (In reply to Katrin Fischer from comment #1) > Hi Joonas, for "normal" renewals the "not renewal x days before" is also > used. Actually it was developed fro normal renewals and around before the > auto renewals were added. Yup, that's right. I think maybe you misunderstood my comment wrong and added this comment, please see the patch and maybe the bug is more clear, also a sign-off would be nice :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 15:37:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 14:37:01 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127618|0 |1 is obsolete| | --- Comment #4 from Joonas Kylmälä --- Created attachment 127619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127619&action=edit Bug 29476: Correct soonest renewal date calculation for checkouts with auto-renewal If a checkout with auto-renewal enabled doesn't have a "norenewalbefore" circulation rule set the code in CanBookBeRenewed() falls back to using due date (to verify this please look for the string "auto_too_soon" in C4/Circulation.pm), the calculation result of GetSoonestRenewDate() however didn't do this, though luckily it was not used in CanBookBeRenewed so we didn't get any issues there. However, GetSoonestRenewDate() is used for display the soonest renewal date in the staff interface on the circ/renew.pl page so you would have gotten wrong results there. This patch moves additionally the tests made for Bug 14395 under a new subtest for GetSoonestRenewDate() as they should have been like that already before. To test: 1) prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 15:41:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 14:41:43 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127619|0 |1 is obsolete| | --- Comment #5 from Joonas Kylmälä --- Created attachment 127620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127620&action=edit Bug 29476: Correct soonest renewal date calculation for checkouts with auto-renewal If a checkout with auto-renewal enabled doesn't have a "norenewalbefore" circulation rule set the code in CanBookBeRenewed() falls back to using due date (to verify this please look for the string "auto_too_soon" in C4/Circulation.pm), the calculation result of GetSoonestRenewDate() however didn't do this, though luckily it was not used in CanBookBeRenewed so we didn't get any issues there. However, GetSoonestRenewDate() is used for displaying the soonest renewal date in the staff interface on the circ/renew.pl page so you would have gotten wrong results there. This patch moves additionally the tests made for Bug 14395 under a new subtest for GetSoonestRenewDate() as they should have been like that already before. To test: 1) prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 15:42:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 14:42:22 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 --- Comment #6 from Joonas Kylmälä --- I noticed a couple typos in the comments so re-attached the patch, ready for sign-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 18:56:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 17:56:29 +0000 Subject: [Koha-bugs] [Bug 19891] itemtypecat should show categories in refine search (facets) and item details, not itypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19891 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 23:19:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 22:19:56 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 23:23:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 22:23:11 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 23:29:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 22:29:12 +0000 Subject: [Koha-bugs] [Bug 28898] Context for translation: term (word) vs. term (semester) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #17 from David Cook --- I'm a bit confused by this one. Does it show "Term" in the English UI but "Semester" in the translation file? While a "semester" is a "term", not all terms are semesters. https://en.wikipedia.org/wiki/Academic_term French should be the same as English with trimestres, semestres, etc. I'm not across Koha's translation idiosyncrasies but I can't see how "semester" would be the right choice here. Happy for someone to explain it though as I imagine I'm just confused. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 23:30:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 22:30:03 +0000 Subject: [Koha-bugs] [Bug 28898] Context for translation: term (word) vs. term (semester) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 --- Comment #18 from David Cook --- For context, here in Sydney Australia some universities use semesters and others use trimesters for their academic terms. While back in western Canada we had quarter terms in high school. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 23:30:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 22:30:56 +0000 Subject: [Koha-bugs] [Bug 28236] Selecting database columns for system preferences in standard and dev installs is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 23:33:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 22:33:52 +0000 Subject: [Koha-bugs] [Bug 29386] background jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 23:34:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 22:34:55 +0000 Subject: [Koha-bugs] [Bug 21102] OAI-PMH specification conformance [UMBRELLA] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21102 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 14 23:52:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Nov 2021 22:52:49 +0000 Subject: [Koha-bugs] [Bug 28898] Context for translation: term (word) vs. term (semester) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 --- Comment #19 from Katrin Fischer --- (In reply to David Cook from comment #17) > I'm a bit confused by this one. > > Does it show "Term" in the English UI but "Semester" in the translation file? The strings with the same context will be translated together with the context showing as a "hint" when translating. You still see "term". The English GUI is not changed by this patch set at all. The main point here is not semester vs. term, but more: term vs. search terms. We have "term" showing up in context of search and in the course reserves module. The context is different, but without this patch you can't differentiate. In German the term for 'time' and term for 'words' are completely different words and this patch allows to use different translations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 05:13:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 04:13:48 +0000 Subject: [Koha-bugs] [Bug 28579] Typo: No record have been imported because they all match an existing record in your catalog. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28579 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 05:15:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 04:15:36 +0000 Subject: [Koha-bugs] [Bug 29213] Typo ol in member-alt-contact-style.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29213 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #7 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 05:38:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 04:38:33 +0000 Subject: [Koha-bugs] [Bug 29306] Holds.t: Fix Use of uninitialized value $_ in concatenation (.) or string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29306 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net --- Comment #7 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 05:38:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 04:38:55 +0000 Subject: [Koha-bugs] [Bug 29227] Patron messaging preferences digest show as editable but are not In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29227 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net --- Comment #7 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 05:39:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 04:39:26 +0000 Subject: [Koha-bugs] [Bug 29315] Remove warnings from Search.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29315 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #5 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 05:39:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 04:39:26 +0000 Subject: [Koha-bugs] [Bug 25515] Remove warnings and errors from tests output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 Bug 25515 depends on bug 29315, which changed state. Bug 29315 Summary: Remove warnings from Search.t https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29315 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 05:39:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 04:39:52 +0000 Subject: [Koha-bugs] [Bug 29286] Typo: Librarien will need the manage_auth_values subpermission. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29286 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #7 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 05:41:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 04:41:47 +0000 Subject: [Koha-bugs] [Bug 26374] Update for 19974 is not idempotent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26374 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor at tuxayo.net Version(s)|21.11.00,21.05.05,20.11.12 |21.11.00,21.05.05,20.11.12, released in| |20.05.18 --- Comment #11 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 05:43:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 04:43:19 +0000 Subject: [Koha-bugs] [Bug 29300] Release team 22.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29300 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05,20.11.12 |21.11.00,21.05.05,20.11.12, released in| |20.05.18 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #12 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 05:44:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 04:44:38 +0000 Subject: [Koha-bugs] [Bug 29363] TestBuilder.t failing if biblionumber=123 does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29363 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #5 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 05:54:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 04:54:26 +0000 Subject: [Koha-bugs] [Bug 29223] Auto-renewals can fail when not digested per branch and patron requests digest In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29223 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #13 from David Cook --- This one was driving me a little crazy... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 06:44:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 05:44:15 +0000 Subject: [Koha-bugs] [Bug 29378] After the automatic update to 21.05.05, the OPAC switches to maintenance mode and the web installer is displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29378 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED --- Comment #20 from Mason James --- (In reply to Fridolin Somers from comment #19) > I see this is actually in 21.05.x : > https://git.koha-community.org/Koha-community/Koha/commit/ > 1b39d0717a4b81cda28c72e07bb47e534d9d205b > > And there is a DBRev 21.05.05.004 for Bug 29386 > > So problem solved ? i think yes, we can close the bug -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 08:33:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 07:33:33 +0000 Subject: [Koha-bugs] [Bug 28413] background job worker is running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 09:11:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 08:11:10 +0000 Subject: [Koha-bugs] [Bug 29459] Replace some missed datetimepickers in circulation templates with Flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29459 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate Severity|enhancement |normal -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 09:11:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 08:11:57 +0000 Subject: [Koha-bugs] [Bug 28416] Email::Sender::Transport::SMTP is using 10Mo of RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28416 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 09:20:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 08:20:29 +0000 Subject: [Koha-bugs] [Bug 29218] "hidden" class is not working for DT if column visibility button is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29218 --- Comment #7 from Jonathan Druart --- (In reply to Fridolin Somers from comment #6) > (In reply to Kyle M Hall from comment #5) > > Pushed to 21.05.x for 21.05.05 > > Oh, depends on 28349 that is not in 21.05.x > Is it still correct to backport it ? Yes, but you should backport bug 28349. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 09:23:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 08:23:29 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate, | |rel_21_11_candidate CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 09:24:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 08:24:39 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 09:26:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 08:26:19 +0000 Subject: [Koha-bugs] [Bug 29463] Umlauts in search field get changed into Replacement character In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 09:28:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 08:28:21 +0000 Subject: [Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Attachment #122380|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 09:36:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 08:36:59 +0000 Subject: [Koha-bugs] [Bug 29450] Allow flatPickr to instantiate in any order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29450 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127507|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 127621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127621&action=edit Bug 29450: Allow flatpickr to instantiate in any order This patch updates the flatpickr wrapper code to allow for cases where the startdate/enddate pickers are pre-populated and thus the onClose event of the startdate pickr may be fired before the enddate flatpickr is instantiated.. which leads to an error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 09:37:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 08:37:33 +0000 Subject: [Koha-bugs] [Bug 29450] Allow flatPickr to instantiate in any order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29450 --- Comment #3 from Martin Renvoize --- Removed a console.log statement I errantly left in.. otherwise, latest patch matches the previous upload. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 09:44:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 08:44:10 +0000 Subject: [Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127130|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 09:45:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 08:45:08 +0000 Subject: [Koha-bugs] [Bug 28995] Add --added_after to writeoff_debts.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28995 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart --- Options should be named --added-before and --added-after (_vs -) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 09:54:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 08:54:50 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #17 from Jonathan Druart --- I disagree with removing the FK. Statistics should not keep a wrong/obsolete code, they are kept (ON DELETE SET NULL) however. There are different things, and different fixes: Statistics table is missing the FK (or does not have it on purpose), and the OpacRenewalBranch behaviour is badly designed. I don't think removing the FK is going into the correct direction, adding a separate column is definitely out of the scope here. We need a quick bugfix for the ugly 500 (that is blocker), and this patch is the way to go in my opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 09:56:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 08:56:10 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #18 from Jonathan Druart --- (In reply to Katrin Fischer from comment #15) > Adding a branch for that purpose is no solution (as Joonas already said :) ) I called it a "workaround", it's the only way to remove the 500 in stable branches right now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 10:13:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 09:13:08 +0000 Subject: [Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 10:14:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 09:14:51 +0000 Subject: [Koha-bugs] [Bug 29477] New: flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 Bug ID: 29477 Summary: flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nugged at gmail.com QA Contact: testopia at bugs.koha-community.org CC: jonathan.druart+koha at gmail.com Our customers reported this UX issue: time by default set to the middle of the say (12:00) and they in all cases need to change the time manually to 23:59. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 10:18:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 09:18:06 +0000 Subject: [Koha-bugs] [Bug 29478] New: flatpickr misses quick shortcut to "Today" date Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Bug ID: 29478 Summary: flatpickr misses quick shortcut to "Today" date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nugged at gmail.com QA Contact: testopia at bugs.koha-community.org CC: jonathan.druart+koha at gmail.com In the previous datepicker there was the "Today" button which was useful for our Koha operators to return back to the current moment after some dates jumping. There is a request to return a somewhat "shortcut button" or similar feature to quickly jump to the current moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 10:20:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 09:20:05 +0000 Subject: [Koha-bugs] [Bug 29459] Replace some missed datetimepickers in circulation templates with Flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29459 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127547|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 127622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127622&action=edit Bug 29459: Replace some missed datetimepickers in circulation templates with Flatpickr This patch updates a few more instances of jQueryUI datepickers which were missed initially, replacing them with Flatpickr widgets. Also changed: A few datetime input fields are updated to have a size of 20, consistent with other datetime input fields. To test, apply the patch and go to Circulation. Check in: - With the 'SpecifyReturnDate' system preference enabled, go to Check in. - Click the "Checkin settings" link. - Test the "Specify return date" field. Clicking it should trigger a Flatpickr widget with a time picker. It should limit your selection to dates in the past. - Check the "Remember return date" checkbox and confirm that the date is preserved over page reloads. - Check and uncheck the "Box drop mode" checkbox to confirm that the return date field is disabled and enabled correctly. Check out: - With the 'AllowRenewalOnHoldOverride' preference enabled, check out to a patron who has a checkout which is on hold for another patron. - At the bottom of the table of checkouts, click the "Override renewal restrictions" checkbox. - The on-hold checkouts should now have a checkbox in the "Renew" column. Check one or more of these checkboxes. - In the table footer you should now see two date inputs, "Renewal due date" and "On hold due date." These should both trigger Flatpickr widgets with time pickers. - Confirm that your date selections are submitted correctly when you renew items. ILL checkout: - Create a new ILL request with the type "book," filling in at least title, patron, and destination library. - On the "Manage ILL request" page, click "Confirm request" and "Confirm request" on the next confirmation page. - There should now be a "Check out" button in the "Manage ILL request" toolbar. Click it. - Test the "Due date" field. It should trigger a Flatpickr widget with a time picker. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 10:20:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 09:20:38 +0000 Subject: [Koha-bugs] [Bug 29459] Replace some missed datetimepickers in circulation templates with Flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29459 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Good catch Owen.. all works as expected for me. Signing off. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 10:22:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 09:22:55 +0000 Subject: [Koha-bugs] [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29239 Severity|minor |major Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 10:22:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 09:22:55 +0000 Subject: [Koha-bugs] [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29477 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 10:23:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 09:23:02 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29239 Severity|enhancement |normal Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 10:23:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 09:23:02 +0000 Subject: [Koha-bugs] [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 [Bug 29478] flatpickr misses quick shortcut to "Today" date -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 10:30:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 09:30:10 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #19 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #18) > (In reply to Katrin Fischer from comment #15) > > Adding a branch for that purpose is no solution (as Joonas already said :) ) > > I called it a "workaround", it's the only way to remove the 500 in stable > branches right now. I would call it a legitimate workaround given the lack of quality of this so-called feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 10:34:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 09:34:40 +0000 Subject: [Koha-bugs] [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 10:34:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 09:34:44 +0000 Subject: [Koha-bugs] [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 --- Comment #1 from Jonathan Druart --- Created attachment 127623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127623&action=edit Bug 29477: Flatpickr - default to 23:59 for the time part It was defaulting to 12:00 which was an unexpected change in behaviour caused by flatpickr switch. Test plan: On the circulation view, check some items out and play with the time part and "Remember for session". The behaviour must be correct, ie. the same as prior to flatpickr switch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 10:35:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 09:35:01 +0000 Subject: [Koha-bugs] [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart+koha at gmail. | |com Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 10:35:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 09:35:53 +0000 Subject: [Koha-bugs] [Bug 28995] Add --added_after to writeoff_debts.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28995 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127463|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 127624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127624&action=edit Bug 28995: Add `--added_after` filter to writeoff_debts script This adds, as requested, the `added_after` filter option to writeoff_debts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 10:35:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 09:35:56 +0000 Subject: [Koha-bugs] [Bug 28995] Add --added_after to writeoff_debts.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28995 --- Comment #4 from Martin Renvoize --- Created attachment 127625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127625&action=edit Bug 28995: Update aliases Add an alias for added-before, added-after (Using an alias makes it backwards compatible) and update the POD. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 10:36:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 09:36:39 +0000 Subject: [Koha-bugs] [Bug 28995] Add --added_after to writeoff_debts.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28995 --- Comment #5 from Martin Renvoize --- Fair.. follow-up added.. I kept it backward compatible with the _ notation as I believe there may be uses already int the wild. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 10:39:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 09:39:29 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #1 from Jonathan Druart --- It's not implemented, looks like we need to use a plugin for that https://github.com/flatpickr/flatpickr/issues/576 https://github.com/jcsmorais/shortcut-buttons-flatpickr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 10:51:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 09:51:32 +0000 Subject: [Koha-bugs] [Bug 29459] Replace some missed datetimepickers in circulation templates with Flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29459 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- As this includes some ILL bits I'm going to take the leap of go for a straight QA as the ILL knowledge in the QA team is limited.. I got some help testing from Andrew (PTFS-E) to test that area. Passing QA -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 11:00:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 10:00:18 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 11:00:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 10:00:22 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #2 from Jonathan Druart --- Created attachment 127626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127626&action=edit Bug 29478: Flatpickr - Restore 'Today' button It's not implemented, looks like we need to use a plugin for that https://github.com/flatpickr/flatpickr/issues/576 https://github.com/jcsmorais/shortcut-buttons-flatpickr Test plan: Confirm that flatpickr instances now have a yesterday, today and tomorrow buttons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 11:02:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 10:02:32 +0000 Subject: [Koha-bugs] [Bug 28376] Flatpickr introduction for datetime picker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 --- Comment #19 from Jonathan Druart --- Created attachment 127627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127627&action=edit Bug 28376: (follow-up) Replace jQueryUI date/timepicker with Flatpickr Remove uneeded include of flatpickr.min.js (we load it from calendar.inc) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 11:25:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 10:25:51 +0000 Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29452 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29452 [Bug 29452] unnecessary warns in the logs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 11:25:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 10:25:51 +0000 Subject: [Koha-bugs] [Bug 29452] unnecessary warns in the logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29452 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25790 CC| |jonathan.druart+koha at gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 11:30:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 10:30:27 +0000 Subject: [Koha-bugs] [Bug 29479] New: Discrepancy between kohastructure and db revisions (impacting DBIx schema) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29479 Bug ID: 29479 Summary: Discrepancy between kohastructure and db revisions (impacting DBIx schema) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org kohastructure `public` tinyint(1) NOT NULL DEFAULT 1 COMMENT 'whether this library should show in the opac', 210600041.pl: unless ( column_exists('branches', 'public') ) { 210600041.pl: ALTER TABLE branches ADD public tinyint DEFAULT 1 AFTER pickup_location In the install public is not nullable, in the update it is nullable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 11:31:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 10:31:00 +0000 Subject: [Koha-bugs] [Bug 29479] Discrepancy between kohastructure and db revisions (impacting DBIx schema) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29479 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 11:36:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 10:36:21 +0000 Subject: [Koha-bugs] [Bug 23608] Koha::Objects::Limit::Library->get_library_limits can return undef In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23608 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #3 from Jonathan Druart --- I was going to open a bug for that, it leads to several warnings in categories.pl [WARN] Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt line 629. However my patch was simply doing: - return unless @branchcodes; + return Koha::Libraries->new->empty unless @branchcodes; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 11:37:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 10:37:00 +0000 Subject: [Koha-bugs] [Bug 23608] Koha::Objects::Limit::Library->get_library_limits can return undef In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23608 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17755 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 11:37:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 10:37:00 +0000 Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23608 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23608 [Bug 23608] Koha::Objects::Limit::Library->get_library_limits can return undef -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 11:44:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 10:44:56 +0000 Subject: [Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 --- Comment #24 from Jonathan Druart --- Created attachment 127628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127628&action=edit Bug 21105: (follow-up) Regression tests Mock KohaAdminEmailAddress in case it differs from the default value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 11:48:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 10:48:06 +0000 Subject: [Koha-bugs] [Bug 29479] Discrepancy between kohastructure and db revisions (impacting DBIx schema) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29479 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- Will fix on bug 27360. *** This bug has been marked as a duplicate of bug 27360 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 11:48:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 10:48:06 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #35 from Jonathan Druart --- *** Bug 29479 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 11:49:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 10:49:11 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 --- Comment #36 from Jonathan Druart --- Created attachment 127629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127629&action=edit Bug 27360: (follow-up) DBRev 21.06.00.041 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 11:53:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 10:53:32 +0000 Subject: [Koha-bugs] [Bug 29459] Replace some missed datetimepickers in circulation templates with Flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29459 --- Comment #5 from Jonathan Druart --- Would have been good to take bug 29394 into account and start the job from here. Not considering blocker however. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:00:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:00:18 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 --- Comment #17 from Jonathan Druart --- I would have tried to limit a bit more the matches * UPDATE letter SET content = REPLACE(content, 'payment.', 'credit.') WHERE code = 'RECEIPT'; Could have been payment\. * UPDATE letter SET content = REPLACE(content, 'offset', 'debit') WHERE code = 'RECEIPT'; offset\. and debit. * UPDATE letter SET content = REPLACE(content, 'offsets', 'credit.debits') WHERE code = 'RECEIPT'; IN offsets Not considering blocker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:04:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:04:31 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 --- Comment #32 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #30) > Created attachment 127577 [details] [review] > Bug 28962: (QA follow-up) Fix test for objects > > Simpler to check the ref instead of isa. > Fix the bug where object is first stringified and then tested for > being a Koha::Item. > > Signed-off-by: Marcel de Rooy This is not correct, we have modules in Koha:: that are not Koha::Object-based objects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:07:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:07:13 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 --- Comment #33 from Jonathan Druart --- Created attachment 127630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127630&action=edit Bug 28692: Correctly prefix "item " for Koha::Item MODIFY logs or the isa won't work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:09:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:09:20 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #34 from Jonathan Druart --- Comments 25 and 26 need more attention, and tests are missing. Help welcomed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:15:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:15:38 +0000 Subject: [Koha-bugs] [Bug 29264] SIP config allows use of non-branchcode institution ids causes workers to die without responding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29264 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #5 from Jonathan Druart --- Shouldn't we then adjust the SIP config file? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:33:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:33:36 +0000 Subject: [Koha-bugs] [Bug 27145] Patron deletion via intranet doesn't handle exceptions well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|27144 |14708 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 [Bug 14708] The patron set as the anonymous patron should not be deletable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 [Bug 27144] Cannot delete any patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:33:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:33:36 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27145 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 [Bug 27145] Patron deletion via intranet doesn't handle exceptions well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:33:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:33:36 +0000 Subject: [Koha-bugs] [Bug 27144] Cannot delete any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27145 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 [Bug 27145] Patron deletion via intranet doesn't handle exceptions well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:35:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:35:44 +0000 Subject: [Koha-bugs] [Bug 29321] Remove a last without loop context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29321 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23420 CC| |jonathan.druart+koha at gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:35:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:35:44 +0000 Subject: [Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29321 [Bug 29321] Remove a last without loop context -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:39:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:39:08 +0000 Subject: [Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:39:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:39:10 +0000 Subject: [Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 --- Comment #25 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:39:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:39:13 +0000 Subject: [Koha-bugs] [Bug 27145] Patron deletion via intranet doesn't handle exceptions well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:39:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:39:15 +0000 Subject: [Koha-bugs] [Bug 27145] Patron deletion via intranet doesn't handle exceptions well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 --- Comment #9 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:39:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:39:18 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:39:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:39:21 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 --- Comment #18 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:39:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:39:23 +0000 Subject: [Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:39:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:39:26 +0000 Subject: [Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:39:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:39:29 +0000 Subject: [Koha-bugs] [Bug 28994] Make writeoff_debts.pl use amountoutstanding, not amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28994 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:39:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:39:32 +0000 Subject: [Koha-bugs] [Bug 28994] Make writeoff_debts.pl use amountoutstanding, not amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28994 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:39:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:39:34 +0000 Subject: [Koha-bugs] [Bug 29146] Default values from the framework should only be applied at biblio/item creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:39:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:39:36 +0000 Subject: [Koha-bugs] [Bug 29146] Default values from the framework should only be applied at biblio/item creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 --- Comment #26 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:39:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:39:38 +0000 Subject: [Koha-bugs] [Bug 29183] Add query options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29183 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:39:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:39:41 +0000 Subject: [Koha-bugs] [Bug 29183] Add query options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29183 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:39:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:39:43 +0000 Subject: [Koha-bugs] [Bug 29204] Error 500 when execute Circulation report with date period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29204 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:39:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:39:46 +0000 Subject: [Koha-bugs] [Bug 29204] Error 500 when execute Circulation report with date period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29204 --- Comment #14 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:39:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:39:48 +0000 Subject: [Koha-bugs] [Bug 29255] Built-in offline circulation broken with SQL error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:39:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:39:51 +0000 Subject: [Koha-bugs] [Bug 29255] Built-in offline circulation broken with SQL error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:39:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:39:54 +0000 Subject: [Koha-bugs] [Bug 29264] SIP config allows use of non-branchcode institution ids causes workers to die without responding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29264 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:39:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:39:56 +0000 Subject: [Koha-bugs] [Bug 29264] SIP config allows use of non-branchcode institution ids causes workers to die without responding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29264 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:39:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:39:59 +0000 Subject: [Koha-bugs] [Bug 29273] Warning not caught in tests for plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:40:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:40:01 +0000 Subject: [Koha-bugs] [Bug 29273] Warning not caught in tests for plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 --- Comment #9 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:40:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:40:03 +0000 Subject: [Koha-bugs] [Bug 29321] Remove a last without loop context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29321 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:40:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:40:06 +0000 Subject: [Koha-bugs] [Bug 29321] Remove a last without loop context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29321 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:40:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:40:09 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:40:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:40:11 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #46 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:40:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:40:14 +0000 Subject: [Koha-bugs] [Bug 29334] Do not apply framework defaultvalue to existing authority records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:40:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:40:16 +0000 Subject: [Koha-bugs] [Bug 29334] Do not apply framework defaultvalue to existing authority records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29334 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:40:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:40:19 +0000 Subject: [Koha-bugs] [Bug 29405] The patron spec for date_renewed is missing it's format definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29405 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:40:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:40:22 +0000 Subject: [Koha-bugs] [Bug 29405] The patron spec for date_renewed is missing it's format definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29405 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:40:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:40:23 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Marie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom at musikverket.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:40:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:40:24 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:40:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:40:27 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 --- Comment #19 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:40:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:40:30 +0000 Subject: [Koha-bugs] [Bug 29435] OPAC authority details page broken when AuthDisplayHierarchy is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29435 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:40:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:40:32 +0000 Subject: [Koha-bugs] [Bug 29435] OPAC authority details page broken when AuthDisplayHierarchy is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29435 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:40:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:40:34 +0000 Subject: [Koha-bugs] [Bug 29452] unnecessary warns in the logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29452 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:40:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:40:37 +0000 Subject: [Koha-bugs] [Bug 29452] unnecessary warns in the logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29452 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:40:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:40:40 +0000 Subject: [Koha-bugs] [Bug 29459] Replace some missed datetimepickers in circulation templates with Flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29459 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:40:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:40:44 +0000 Subject: [Koha-bugs] [Bug 29459] Replace some missed datetimepickers in circulation templates with Flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29459 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:40:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:40:48 +0000 Subject: [Koha-bugs] [Bug 29460] Typo 'pendin g approval' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29460 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:40:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:40:52 +0000 Subject: [Koha-bugs] [Bug 29460] Typo 'pendin g approval' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29460 --- Comment #3 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:42:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:42:01 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 --- Comment #37 from Jonathan Druart --- (In reply to Jonathan Druart from comment #36) > Created attachment 127629 [details] [review] > Bug 27360: (follow-up) DBRev 21.06.00.041 Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:42:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:42:12 +0000 Subject: [Koha-bugs] [Bug 28376] Flatpickr introduction for datetime picker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 --- Comment #20 from Jonathan Druart --- (In reply to Jonathan Druart from comment #19) > Created attachment 127627 [details] [review] > Bug 28376: (follow-up) Replace jQueryUI date/timepicker with Flatpickr > > Remove uneeded include of flatpickr.min.js (we load it from > calendar.inc) Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:42:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:42:26 +0000 Subject: [Koha-bugs] [Bug 28413] background job worker is running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #22 from Jonathan Druart --- (In reply to Andrew Nugged from comment #21) > Created attachment 127598 [details] [review] > Bug 28413: (QA follow-up) Fix for missing use Koha::Items Pushed to master, thanks Andrew! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:44:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:44:20 +0000 Subject: [Koha-bugs] [Bug 29480] New: Add email address as a method for generating the userid when self registering in OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 Bug ID: 29480 Summary: Add email address as a method for generating the userid when self registering in OPAC Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: andreas.jonsson at kreablo.se QA Contact: testopia at bugs.koha-community.org - Add a system preference for selecting a method for generating the userid when self registering - Fall back to the default method (firstname.surname[uniqueness identifier when needed]) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:44:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:44:42 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:44:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:44:44 +0000 Subject: [Koha-bugs] [Bug 28994] Make writeoff_debts.pl use amountoutstanding, not amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28994 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:44:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:44:45 +0000 Subject: [Koha-bugs] [Bug 29435] OPAC authority details page broken when AuthDisplayHierarchy is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29435 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:44:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:44:47 +0000 Subject: [Koha-bugs] [Bug 29459] Replace some missed datetimepickers in circulation templates with Flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29459 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:44:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:44:50 +0000 Subject: [Koha-bugs] [Bug 29479] Discrepancy between kohastructure and db revisions (impacting DBIx schema) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29479 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:44:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:44:52 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:44:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:44:54 +0000 Subject: [Koha-bugs] [Bug 29183] Add query options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29183 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:46:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:46:41 +0000 Subject: [Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- URL|/cgi-bin/koha/opac-search.p | |l?q=foo | Summary|OPACItemsResultsDisplay |OPACItemsResultsDisplay |preference does not work |preference must be removed |with XSLT results | Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |jonathan.druart+koha at gmail. | |com --- Comment #8 from Jonathan Druart --- Renaming bug report, we should now just remove the pref. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:49:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:49:23 +0000 Subject: [Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:49:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:49:28 +0000 Subject: [Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 --- Comment #9 from Jonathan Druart --- Created attachment 127631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127631&action=edit Bug 5229: Remove system preference 'OPACItemsResultsDisplay' We dropped it on bug 12561 when removing the non-XSLT view. This feature has never been implemented for XSLT views and the pref must then be removed. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:55:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:55:05 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14957 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:55:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:55:05 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25539 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:59:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:59:17 +0000 Subject: [Koha-bugs] [Bug 29452] Unnecessary warns in the logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29452 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|unnecessary warns in the |Unnecessary warns in the |logs |logs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 12:59:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 11:59:28 +0000 Subject: [Koha-bugs] [Bug 29452] Unnecessary warns in sip logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29452 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Unnecessary warns in the |Unnecessary warns in sip |logs |logs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 13:09:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 12:09:40 +0000 Subject: [Koha-bugs] [Bug 29481] New: Terminology: Collection code, call number: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29481 Bug ID: 29481 Summary: Terminology: Collection code, call number: Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org This is from the new strings for 21.11: koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl:1513 Terminology: Collection code, call number: We have standardized on just "collection" as we display the description and not a code. This should be fixed accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 13:14:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 12:14:24 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 13:14:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 12:14:27 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127614|0 |1 is obsolete| | Attachment #127615|0 |1 is obsolete| | Attachment #127616|0 |1 is obsolete| | Attachment #127617|0 |1 is obsolete| | --- Comment #19 from Nick Clemens --- Created attachment 127632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127632&action=edit Bug 29474: Return too_soon before checking renewals This patch allows us to avoid checking reserves when the issue is too_soon and we are running the cron Code is covered by existing tests To test: 1 - prove -v t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 13:14:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 12:14:30 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #20 from Nick Clemens --- Created attachment 127633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127633&action=edit Bug 29474: Decouple renewal checks of auto-renewed issues from non-autorenewed The too_soon check does not relate at all to auto-renewed issues and should be moved outside the _CanBookBeAutoRenewed() function. To test: 1) prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 13:14:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 12:14:33 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #21 from Nick Clemens --- Created attachment 127634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127634&action=edit Bug 29474: Remove one layer of indendation by adding if check in the begginning If we simply return "no" immediately from the function when the checkout is not an autorenewed checkout we can drop one layer of indendation and the code becomes much easier to read. To test: 1) prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 13:14:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 12:14:37 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #22 from Nick Clemens --- Created attachment 127635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127635&action=edit Bug 29474: Pass rules/branchcode to subroutines, further simplify logic If we are going to decouple 'too_soon' from auto_renewals we should only call GetSoonestDate once Additionally, we can fetch all needed rules at once and pass to subroutines as needed Rather than check in the sub, let's not call _CanBookBeAutoRenewed if we aren't set for auto_renew -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 13:16:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 12:16:59 +0000 Subject: [Koha-bugs] [Bug 29480] Add email address as a method for generating the userid when self registering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 --- Comment #1 from Andreas Jonsson --- Created attachment 127636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127636&action=edit Bug 29480: Add new systempreference PatronSelfRegistrationUseridGenerationMethod and add email as option. Test plan - Install patch and run koha-upgrade-schema - The systempreference PatronSelfRegistrationUseridGenerationMethod should be found in the adminstrative interface under OPAC -> Self registration and modification - Also make sure - Make sure that PatronSelfRegistration is set to Allow and PatronSelfRegistrationDefaultCategory is set to an existing borrower category - Make sure that PatronSelfModificationBorrowerUnwantedField doesn't prevent the input of an email address in the self registration form. (I.e., make sure "email" is NOT selected for exclusion.) - Go to opac and self register a patron and verify that the userid is on the form firstname.surname. - Change systempreference to 'email' - Go to OPAC and self register a patron and make sure to add a valid email address. - Verify the that the userid is the email adress. - Go to OPAC and self register a patron using the SAME valid email adress as above (to provoke a conflicting userid). - Verify that the userid is on the form firstname.surname. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 13:17:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 12:17:39 +0000 Subject: [Koha-bugs] [Bug 29480] Add email address as a method for generating the userid when self registering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 Andreas Jonsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 13:21:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 12:21:18 +0000 Subject: [Koha-bugs] [Bug 21107] oai.pl error response did not contain error code 'badResumptionToken' when it should In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21107 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|NEW |In Discussion --- Comment #1 from Tomás Cohen Arazi --- I've been briefly poking at this. My findings are that the resumption token itself doesn't need to have a specific structure and is up to the implementation to defined how that token should look like. Koha uses this structure: "$metadata_prefix/$cursor/$from/$until/$set/$deleted/0/$next_id" This is an extreme reasoning, but things can be underspecified so they fallback to some default. I'm not sure if 'junk' couldn't be some valid resumption token if we decided to encode/compress the resumption token... That is, somehow, a weakness on the validation tool. They picked 'junk' meaning 'some random word'. That said, though: we know the structure of our resumption tokens (as pasted above) and we could be returning 'badResumptionToken' when the request doesn't comform to that structure. Do we agree? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 13:32:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 12:32:41 +0000 Subject: [Koha-bugs] [Bug 29482] New: Terminology: This item belongs to another branch. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29482 Bug ID: 29482 Summary: Terminology: This item belongs to another branch. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Another find int he 21.11 translation files: koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt:81 This item belongs to another branch. branch should be library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 13:33:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 12:33:33 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #50 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 13:34:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 12:34:58 +0000 Subject: [Koha-bugs] [Bug 29483] New: AllowRenewalIfOtherItemsAvailable has poor performance for records with many items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Bug ID: 29483 Summary: AllowRenewalIfOtherItemsAvailable has poor performance for records with many items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When a record has many items and holds and the check to see if other items available can take a long time to return -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 13:35:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 12:35:30 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #23 from Nick Clemens --- (In reply to Joonas Kylmälä from comment #18) > I fixed the incorrect comment about too_soon not being overriden and added > couple improvements to the code as well. Excellent! Thanks! I squashed the comment removal, I thought I had pulled that, I was confused when I added it :-) > I obsoleted also the patch from > comment #8 now as it was buggy (see comment #10). I could try to work on > those perf improvements as what was tried in the patch attached in comment > #8 but I'm not sure I will manage to do that in the nearby days so please go > ahead and have a new attempt at it as if I will it might take time. I am going to move that to it's own bug since it will take a little more reworking. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 13:35:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 12:35:57 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29483 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 13:35:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 12:35:57 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29474 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 13:43:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 12:43:11 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 --- Comment #35 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #34) > Comments 25 and 26 need more attention, and tests are missing. > > Help welcomed. Revisiting it now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 13:50:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 12:50:51 +0000 Subject: [Koha-bugs] [Bug 29484] New: ListSets doesn't return noSetHierarchy when appropriate Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 Bug ID: 29484 Summary: ListSets doesn't return noSetHierarchy when appropriate Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org To reproduce: $ cpanm HTTP::OAIPMH::Validator $ PERL5LIB=/root/.local/share/.cpan/build/HTTP-OAIPMH-Validator-1.06-0/lib perl /root/.local/share/.cpan/build/HTTP-OAIPMH-Validator-1.06-0/examples/oaipmh-validator.pl http://kohadev.myDNSname.org:8080/cgi-bin/koha/oai.pl => FAIL: There are several errors, some reported under the bug 21102 umbrella => FAIL: This error wasn't reported before: FAIL: Failed to extract any setSpec elements from ListSets but did not find an exception message. If sets are not supported by the repository then the ListSets response must be the noSetHierarchy error. See . -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 13:51:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 12:51:04 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21102 Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21102 [Bug 21102] OAI-PMH specification conformance [UMBRELLA] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 13:51:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 12:51:04 +0000 Subject: [Koha-bugs] [Bug 21102] OAI-PMH specification conformance [UMBRELLA] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21102 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29484 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 13:55:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 12:55:16 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 13:55:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 12:55:20 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 127637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127637&action=edit Bug 29484: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 13:55:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 12:55:24 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 127638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127638&action=edit Bug 29484: Make ListSets return noSetHierarchy when no sets defined This simple patch makes our OAI-PMH server return the appropriate error code when no sets are defined. To test: 1. Apply the regression tests 2. Run: $ kshell k$ t/db_dependent/OAI/Server.t => FAIL: Tests fail. Boo! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! YAY! 5. Sign off :-D Bonus: you can check with the tool mentioned on the bug report, that the error is gone. No sets need to be defined. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 13:55:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 12:55:34 +0000 Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create mysqluser@mysql_hostname so zebra update fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 --- Comment #36 from Rudolf Byker --- (In reply to Joonas Kylmälä from comment #35) > (In reply to Rudolf Byker from comment #15) > > Created attachment 96975 [details] [review] [review] > > Use `DROP USER IF EXISTS` and remove ` || true`. > > > > All right, here is my attempt at a proper patch! > > The author name is missing, it just has your username I guess: "dolf". I don't understand what you mean here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 13:55:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 12:55:45 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21102 Depends on|21102 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21102 [Bug 21102] OAI-PMH specification conformance [UMBRELLA] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 13:55:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 12:55:45 +0000 Subject: [Koha-bugs] [Bug 21102] OAI-PMH specification conformance [UMBRELLA] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21102 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29484 | Depends on| |29484 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 14:01:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 13:01:57 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127575|0 |1 is obsolete| | Attachment #127576|0 |1 is obsolete| | Attachment #127577|0 |1 is obsolete| | Attachment #127630|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy --- Created attachment 127639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127639&action=edit Bug 28692: (QA follow-up) Add module Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 14:02:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 13:02:01 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 --- Comment #37 from Marcel de Rooy --- Created attachment 127640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127640&action=edit Bug 28692: (QA follow-up) Sort hash keys of unblessed Trivial add. Reads much better. And might help future diffs. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 14:02:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 13:02:05 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 --- Comment #38 from Marcel de Rooy --- Created attachment 127641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127641&action=edit Bug 28692: (QA follow-up) Fix test for objects Fix the bug where object is first stringified and then tested for being a Koha::Item. Note: simple test since even 2->isa('Some::Class') works fine. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 14:05:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 13:05:03 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #51 from Tomás Cohen Arazi --- (In reply to Kyle M Hall from comment #50) > Pushed to 21.05.x for 21.05.05 Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 14:12:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 13:12:38 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127641|0 |1 is obsolete| | --- Comment #39 from Marcel de Rooy --- Created attachment 127642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127642&action=edit Bug 28692: (QA follow-up) Fix test for objects Fix the bug where object is first stringified and then tested for being a Koha::Item. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 14:16:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 13:16:01 +0000 Subject: [Koha-bugs] [Bug 29273] Warning not caught in tests for plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 --- Comment #10 from Jonathan Druart --- Created attachment 127643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127643&action=edit Bug 29273: Fix failing tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 14:34:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 13:34:57 +0000 Subject: [Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 --- Comment #26 from Jonathan Druart --- Created attachment 127644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127644&action=edit Bug 21105: Fix test if sample data missing # Failed test 'Identify - earliestDatestamp in the right format' # at t/db_dependent/OAI/Server.t line 182. # Compared $data->{"Identify"}{"earliestDatestamp"} # got : '2021-11-15T13:16:09Z' # expect : '2014-05-07T13:36:23Z' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 14:35:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 13:35:49 +0000 Subject: [Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #27 from Jonathan Druart --- (In reply to Jonathan Druart from comment #26) > Created attachment 127644 [details] [review] > Bug 21105: Fix test if sample data missing > > # Failed test 'Identify - earliestDatestamp in the right format' > # at t/db_dependent/OAI/Server.t line 182. > # Compared $data->{"Identify"}{"earliestDatestamp"} > # got : '2021-11-15T13:16:09Z' > # expect : '2014-05-07T13:36:23Z' Aren't we then missing the point of the test with this patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 14:35:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 13:35:54 +0000 Subject: [Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 14:45:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 13:45:01 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 14:45:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 13:45:05 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127574|0 |1 is obsolete| | --- Comment #40 from Marcel de Rooy --- Created attachment 127645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127645&action=edit Bug 28692: Get from storage before log actions To make sure we have logging the values from DB. It will reduce DB action_log table size when we log the full object and it contains DateTime object. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 14:45:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 13:45:09 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127639|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy --- Created attachment 127646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127646&action=edit Bug 28692: (QA follow-up) Add module Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 14:45:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 13:45:13 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127640|0 |1 is obsolete| | --- Comment #42 from Marcel de Rooy --- Created attachment 127647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127647&action=edit Bug 28692: (QA follow-up) Sort hash keys of unblessed Trivial add. Reads much better. And might help future diffs. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 14:45:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 13:45:17 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127642|0 |1 is obsolete| | --- Comment #43 from Marcel de Rooy --- Created attachment 127648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127648&action=edit Bug 28692: (QA follow-up) Fix test for objects Fix the bug where object is first stringified and then tested for being a Koha::Item. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 14:45:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 13:45:21 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 --- Comment #44 from Marcel de Rooy --- Created attachment 127649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127649&action=edit Bug 28692: (follow-up) Add tests Test plan: Run t/db_dependent/Log.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 14:46:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 13:46:16 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 --- Comment #45 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #34) > Comments 25 and 26 need more attention, and tests are missing. > > Help welcomed. Added tests. It seems to me that we should postpone comments 25 and 26. They feel a bit out of scope here too. We want to reduce log size here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 14:46:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 13:46:40 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 --- Comment #46 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #32) > (In reply to Marcel de Rooy from comment #30) > > Created attachment 127577 [details] [review] [review] > > Bug 28962: (QA follow-up) Fix test for objects > > > > Simpler to check the ref instead of isa. > > Fix the bug where object is first stringified and then tested for > > being a Koha::Item. > > > > Signed-off-by: Marcel de Rooy > > This is not correct, we have modules in Koha:: that are not > Koha::Object-based objects. Fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 14:53:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 13:53:07 +0000 Subject: [Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127644|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart --- Created attachment 127650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127650&action=edit Bug 21105: Fix test if sample data missing # Failed test 'Identify - earliestDatestamp in the right format' # at t/db_dependent/OAI/Server.t line 182. # Compared $data->{"Identify"}{"earliestDatestamp"} # got : '2021-11-15T13:16:09Z' # expect : '2014-05-07T13:36:23Z' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 14:59:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 13:59:23 +0000 Subject: [Koha-bugs] [Bug 29485] New: selenium/administration_tasks.t is failing randomly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29485 Bug ID: 29485 Summary: selenium/administration_tasks.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 19185 Since bug 19185, and Koha_Master running the tests after t/db_dependent/selenium/01-installation.t is ran, t/db_dependent/selenium/administration_tasks.t is failing randomly with: 12:32:59 koha_1 | STRACE: /usr/share/perl5/Try/Tiny.pm:123 in Selenium::Remote::Driver::catch {...} 12:32:59 koha_1 | /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm:361 in Try::Tiny::try 12:32:59 koha_1 | (eval 1710):1 in Selenium::Remote::Driver::__ANON__ 12:32:59 koha_1 | (eval 1712):2 in Selenium::Remote::Driver::__ANON__ 12:32:59 koha_1 | /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm:1340 in Selenium::Remote::Driver::_execute_command 12:32:59 koha_1 | /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm:1340 in (eval) 12:32:59 koha_1 | /kohadevbox/koha/t/lib/Selenium.pm:170 in Selenium::Remote::Driver::find_element 12:32:59 koha_1 | t/db_dependent/selenium/administration_tasks.t:188 in t::lib::Selenium::click I don't recreate it locally. The screenshot of the failure shows that the screen is still on the authorised value list view. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 [Bug 19185] Web installer and onboarding tool selenium test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 14:59:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 13:59:23 +0000 Subject: [Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29485 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29485 [Bug 29485] selenium/administration_tasks.t is failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 14:59:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 13:59:37 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127508|0 |1 is obsolete| | --- Comment #11 from David Gustafsson --- Created attachment 127651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127651&action=edit Bug 29440: Refactor and clean up bulkmarcimport.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 14:59:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 13:59:41 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127509|0 |1 is obsolete| | --- Comment #12 from David Gustafsson --- Created attachment 127652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127652&action=edit Bug 29440: Make authorities import behavior consistent with biblios The current behavior for when importing authorities, when match option is enabled, is to insert as a new authority fetching from db fails. This is both a bit confusing and not consistent with the biblio case where an error is generated. Also clean up error and log messages so both messages/errors and when messages/errors are issued are more consistent for the biblio and authority case. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 14:59:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 13:59:48 +0000 Subject: [Koha-bugs] [Bug 29485] selenium/administration_tasks.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29485 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 14:59:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 13:59:48 +0000 Subject: [Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29485 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29485 [Bug 29485] selenium/administration_tasks.t is failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 15:00:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 14:00:06 +0000 Subject: [Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127650|0 |1 is obsolete| | --- Comment #29 from Tomás Cohen Arazi --- Created attachment 127653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127653&action=edit Bug 21105: Fix test if sample data missing # Failed test 'Identify - earliestDatestamp in the right format' # at t/db_dependent/OAI/Server.t line 182. # Compared $data->{"Identify"}{"earliestDatestamp"} # got : '2021-11-15T13:16:09Z' # expect : '2014-05-07T13:36:23Z' Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 15:05:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 14:05:56 +0000 Subject: [Koha-bugs] [Bug 29485] selenium/administration_tasks.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29485 --- Comment #1 from Jonathan Druart --- Created attachment 127654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127654&action=edit Bug 29485: Trying to prevent administration_tasks.t to fail randomly Since bug 19185, and Koha_Master running the tests after t/db_dependent/selenium/01-installation.t is ran, t/db_dependent/selenium/administration_tasks.t is failing randomly with: 12:32:59 koha_1 | STRACE: /usr/share/perl5/Try/Tiny.pm:123 in Selenium::Remote::Driver::catch {...} 12:32:59 koha_1 | /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm:361 in Try::Tiny::try 12:32:59 koha_1 | (eval 1710):1 in Selenium::Remote::Driver::__ANON__ 12:32:59 koha_1 | (eval 1712):2 in Selenium::Remote::Driver::__ANON__ 12:32:59 koha_1 | /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm:1340 in Selenium::Remote::Driver::_execute_command 12:32:59 koha_1 | /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm:1340 in (eval) 12:32:59 koha_1 | /kohadevbox/koha/t/lib/Selenium.pm:170 in Selenium::Remote::Driver::find_element 12:32:59 koha_1 | t/db_dependent/selenium/administration_tasks.t:188 in t::lib::Selenium::click I don't recreate it locally. The screenshot of the failure shows that the screen is still on the authorised value list view. This does not make a lot of sense, but I am failing to find a logic here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 15:07:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 14:07:22 +0000 Subject: [Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #30 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #29) > Created attachment 127653 [details] [review] > Bug 21105: Fix test if sample data missing > > # Failed test 'Identify - earliestDatestamp in the right format' > # at t/db_dependent/OAI/Server.t line 182. > # Compared $data->{"Identify"}{"earliestDatestamp"} > # got : '2021-11-15T13:16:09Z' > # expect : '2014-05-07T13:36:23Z' > > Signed-off-by: Tomas Cohen Arazi Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 15:08:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 14:08:07 +0000 Subject: [Koha-bugs] [Bug 29273] Warning not caught in tests for plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 --- Comment #11 from Jonathan Druart --- (In reply to Jonathan Druart from comment #10) > Created attachment 127643 [details] [review] > Bug 29273: Fix failing tests Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 15:08:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 14:08:40 +0000 Subject: [Koha-bugs] [Bug 29485] selenium/administration_tasks.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29485 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 15:09:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 14:09:15 +0000 Subject: [Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127631|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 127655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127655&action=edit Bug 5229: Remove system preference 'OPACItemsResultsDisplay' We dropped it on bug 12561 when removing the non-XSLT view. This feature has never been implemented for XSLT views and the pref must then be removed. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 15:09:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 14:09:25 +0000 Subject: [Koha-bugs] [Bug 29485] selenium/administration_tasks.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29485 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master --- Comment #2 from Jonathan Druart --- Patch pushed to master for 21.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 15:15:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 14:15:11 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 15:15:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 14:15:14 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 --- Comment #1 from Nick Clemens --- Created attachment 127656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127656&action=edit Bug 29483: Check ItemsAnyAvailableAndNotRestricted once per patron ItemsAnyAvailableAndNotRestricted can take a long time and create nested loops. We can check it once per patron, however, this requires us to flip the loops. Since an item can only be used once, we now add a check to see if this item has already been assigned to a borrower. To test: 1 - Find or create a biblio with 100 items 2 - Place ten 'Next available' holds on a biblio 3 - Set preference 'AllowRenewalIfOtherItemsAvailable' to 'Allow' Set circ rules 'On shelf holds allowed' to 'If any unavailable' 4 - Checkout one of the items to a patron, backdated to be overdue 5 - Note a long loading time for the patron's checkouts 6 - Apply patch, restart_all 7 - Patron loads much faster -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 15:15:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 14:15:50 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 --- Comment #2 from Nick Clemens --- There is more that can be done here, but I think this first step is enough for this bug -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 15:16:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 14:16:17 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 15:16:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 14:16:27 +0000 Subject: [Koha-bugs] [Bug 27463] OAI-PMH date handling in ListBase.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27463 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #20 from Tomás Cohen Arazi --- (In reply to Rudolf Byker from comment #19) > I tested as follows: > > - Checked out Koha master branch. > - Ran Koha using docker composer from the koha-testing-docker repo. > - Enabled OAI-PMH (no YAML file, so default should be to exclude items) > - Visited cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml and > took note of last modified date of KOHA-OAI-TEST:7 . It is shown in UTC. > Good. > - Added an item for record 7. > - Checked KOHA-OAI-TEST:7 again: No change. Good. > - Edited record 7. > - Checked KOHA-OAI-TEST:7 again: Time updated. Still UTC. Good. > - Edited an item for record 7. > - Checked KOHA-OAI-TEST:7 again: No change. Good. > - Deleted two items for record 7. > - Checked KOHA-OAI-TEST:7 again: No change. Good. > - Deleted the last item for record 7. > - Checked KOHA-OAI-TEST:7 again: No change. Good. > > I think we can close this issue now :) \o/ Y'all rock :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 15:28:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 14:28:43 +0000 Subject: [Koha-bugs] [Bug 6456] Display of barcode in search results in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6456 pierre.genty at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 15:42:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 14:42:38 +0000 Subject: [Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 --- Comment #8 from Jonathan Druart --- Are you sure we don't only need to pass/cache the MARC record? Did you benchmark this patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 15:43:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 14:43:04 +0000 Subject: [Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 15:43:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 14:43:08 +0000 Subject: [Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122962|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 127657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127657&action=edit Bug 28709: Refactor Koha::Biblio->custom_cover_image_url to allow passing parameters Currently the search result template receive a Koha::Biblio object and call the method. The searchResults routine already has the isbn, issn, and normalized_isbn calculated. Rather than fetching the object and passing to the template we can pass the parameters, generate the url, and pass only the URL to the template To test: 1 - Set the system preferences: CustomCoverImages : Display OPACCustomCoverImages: Display CustomCoverImagesURL: https://images-na.ssl-images-amazon.com/images/P/{normalized_isbn}.01.LZZZZZZZ.jpg 2 - Search on staff and opac for a term that returns titles with covers, e.g. 'shuffle' 3 - Confirm the covers show 4 - Apply patch 5 - Restart all 6 - Confirm covers still show 7 - prove -v t/db_dependent/Koha/Biblios.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 15:43:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 14:43:42 +0000 Subject: [Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 --- Comment #10 from Jonathan Druart --- Patch rebased (and tidied searchResults changes). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 16:05:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 15:05:38 +0000 Subject: [Koha-bugs] [Bug 29486] New: _koha_marc_update_bib_ids no longer needed for GetMarcBiblio (?) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 Bug ID: 29486 Summary: _koha_marc_update_bib_ids no longer needed for GetMarcBiblio (?) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org C4::Biblio::_koha_marc_update_bib_ids is adding biblionumber and biblioitemnumber to the MARC record. When it may still be needed when a bibliographic record is added/edited, why do we need it for GetMarcBiblio? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 16:06:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 15:06:18 +0000 Subject: [Koha-bugs] [Bug 29307] marc record fetched twice in detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED Depends on| |29486 --- Comment #7 from Jonathan Druart --- (In reply to Joonas Kylmälä from comment #6) > (In reply to Jonathan Druart from comment #5) > > (In reply to Joonas Kylmälä from comment #4) > > > They don't do quite the same thing, GetMarcBiblio calls > > > C4::Biblio::_koha_marc_update_bib_ids() and $biblio->metadata->record > > > doesn't. > > > > What differences do you expect? > > Commenting on this just based on the code I read: Before this patch the > detail page included biblionumbers if they were not in the original data, > after this patch it doesn't. Yes, I don't think this call in GetMarcBiblio is relevant, I opened bug 29486. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio (?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 16:06:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 15:06:18 +0000 Subject: [Koha-bugs] [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29307 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 [Bug 29307] marc record fetched twice in detail.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 16:06:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 15:06:58 +0000 Subject: [Koha-bugs] [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 16:11:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 15:11:48 +0000 Subject: [Koha-bugs] [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 16:40:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 15:40:26 +0000 Subject: [Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 Sonia Bouis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sonia.bouis at univ-lyon3.fr --- Comment #9 from Sonia Bouis --- Sorry, but I found a problem with this patch. I have just tried and compared with a master from this morning. The preference system AcqCreateItem is on "placing an order" If I tried to save an order with this patch with an item where all mandatory item are filled, I have the message : "Form not submitted because of the following problem(s): - 4 item mandatory fields empty". If I tried the same on a master branch, my order is saved normally. Can you reproduce this issue ? Sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 16:53:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 15:53:09 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #24 from Kyle M Hall --- Created attachment 127658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127658&action=edit Bug 29474: Small efficiency improvement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 17:26:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 16:26:13 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Sonia Bouis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sonia.bouis at univ-lyon3.fr --- Comment #20 from Sonia Bouis --- Hello, I'm OK that this is not statisfying but unless someone has a better way to fix it rapidly, it's perhaps better to fix it than to keep an internal servor error ? I'm not sur to really understand the technical part with the foreign key. But, as Katrin said, in a library, the branches can change (closure, opening of a new building) and we may want to delete the branch but we need to keep the statistics and the pseudonymized information. It would be nice if this BZ doesn't stay too long in discussion. Sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 17:45:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 16:45:27 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127498|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize --- Created attachment 127659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127659&action=edit Bug 28854: Database update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 17:45:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 16:45:32 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127499|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize --- Created attachment 127660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127660&action=edit Bug 28854: DBIC Schema Updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 17:45:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 16:45:37 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127500|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize --- Created attachment 127661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127661&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point 1) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 2) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 3) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. TODO: Add Object Tests + API Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 17:45:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 16:45:42 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127501|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize --- Created attachment 127662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127662&action=edit Bug 28854: Add bundle content display to OPAC TODO: Move expand button to right like staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 17:45:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 16:45:47 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127502|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize --- Created attachment 127663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127663&action=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 17:45:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 16:45:52 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127503|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize --- Created attachment 127664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127664&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that the patron who lost the item is displayed 4) Checkin the lost item * The item should be marked as found and the items_lost_issue table should no longer contain a link to the issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 17:45:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 16:45:57 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127504|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize --- Created attachment 127665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127665&action=edit Bug 28854: Respect WhenLostChargeReplacementFee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 17:46:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 16:46:02 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127505|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize --- Created attachment 127666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127666&action=edit Bug 28854: Highlight bundle rows to clarify UI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 17:46:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 16:46:16 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29408 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 [Bug 29408] The datatables api wrapper is ambiguously named -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 17:46:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 16:46:16 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28854 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 17:47:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 16:47:55 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #55 from Martin Renvoize --- Just another rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 17:55:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 16:55:31 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 --- Comment #20 from Tomás Cohen Arazi --- Steps forward! \o/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 18:06:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 17:06:02 +0000 Subject: [Koha-bugs] [Bug 23608] Koha::Objects::Limit::Library->get_library_limits can return undef In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23608 --- Comment #4 from Martin Renvoize --- Wow... there's a lot of superfluous noise in my patch.. must have had a tidy setting on when I committed it. I do similar but instead of 'empty' I return 'all'.. shouldn't 'no limit' mean all rather than none.. or am I misunderstanding the function in the first place? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 18:54:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 17:54:52 +0000 Subject: [Koha-bugs] [Bug 28450] Make Account summary print tables configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28450 Sarah Cornell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell at cityofportsmouth. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 19:16:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 18:16:36 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 19:25:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 18:25:08 +0000 Subject: [Koha-bugs] [Bug 29487] New: Set autocomplete off for userid/password fields at login Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29487 Bug ID: 29487 Summary: Set autocomplete off for userid/password fields at login Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Bug 19570 did most of this work - adding a few that were reported -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 19:27:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 18:27:59 +0000 Subject: [Koha-bugs] [Bug 29487] Set autocomplete off for userid/password fields at login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29487 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19570 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19570 [Bug 19570] autocomplete="off" no set for login forms at the OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 19:27:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 18:27:59 +0000 Subject: [Koha-bugs] [Bug 19570] autocomplete="off" no set for login forms at the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19570 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29487 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29487 [Bug 29487] Set autocomplete off for userid/password fields at login -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 19:28:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 18:28:02 +0000 Subject: [Koha-bugs] [Bug 29487] Set autocomplete off for userid/password fields at login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29487 --- Comment #1 from Nick Clemens --- Created attachment 127667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127667&action=edit Bug 29487: Set autocomplete off for userid/password fields at login This patch adjust: Intranet login Opac-main Opac-main - 'log in to your account modal' To test: Login at the three places above Confirm html shows autocomplete off on the fields Confirm logins work -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 19:28:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 18:28:21 +0000 Subject: [Koha-bugs] [Bug 29487] Set autocomplete off for userid/password fields at login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29487 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 19:38:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 18:38:15 +0000 Subject: [Koha-bugs] [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 19:38:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 18:38:18 +0000 Subject: [Koha-bugs] [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127623|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 127668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127668&action=edit Bug 29477: Flatpickr - default to 23:59 for the time part It was defaulting to 12:00 which was an unexpected change in behaviour caused by flatpickr switch. Test plan: On the circulation view, check some items out and play with the time part and "Remember for session". The behaviour must be correct, ie. the same as prior to flatpickr switch. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 19:40:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 18:40:58 +0000 Subject: [Koha-bugs] [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the flatpickr release notes| |default time defaulting to | |12:00 instead of 23:59, | |which was an unexpected | |change in behaviour caused | |by the flatpickr switch. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 19:48:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 18:48:13 +0000 Subject: [Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740 Amanda Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acampbell at hmcpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 19:48:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 18:48:51 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 19:48:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 18:48:56 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127626|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 127676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127676&action=edit Bug 29478: Flatpickr - Restore 'Today' button It's not implemented, looks like we need to use a plugin for that https://github.com/flatpickr/flatpickr/issues/576 https://github.com/jcsmorais/shortcut-buttons-flatpickr Test plan: Confirm that flatpickr instances now have a yesterday, today and tomorrow buttons. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 19:51:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 18:51:39 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This adds shortcuts to release notes| |yesterday, today and | |tomorrow for the flatpickr | |date selector. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 19:57:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 18:57:42 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch 1) renames the release notes| |Koha REST JS dataTables | |wrapper from the | |ambiguous | |'api' to the clearer | |'kohaTable' 2) goes through | |the codebase and updates | |existing relevant calls to | |.api referencing the Koha | |REST dataTables wrapper to | |use the name 'kohaTable', | |and 3) adds JSDoc formatted | |parameter documentation for | |the kohaTable function. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 20:51:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 19:51:11 +0000 Subject: [Koha-bugs] [Bug 16872] You should not be allowed to delete a record with open orders attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16872 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |andrew at bywatersolutions.com --- Comment #7 from Andrew Fuerste-Henry --- *** This bug has been marked as a duplicate of bug 27893 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 20:51:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 19:51:11 +0000 Subject: [Koha-bugs] [Bug 27893] Delete of biblio with order does not always warn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #5 from Andrew Fuerste-Henry --- *** Bug 16872 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 20:51:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 19:51:38 +0000 Subject: [Koha-bugs] [Bug 16872] You should not be allowed to delete a record with open orders attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16872 --- Comment #8 from Andrew Fuerste-Henry --- Marking this as a duplicate of a newer bug as the newer bug has a little work on it already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 21:04:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 20:04:37 +0000 Subject: [Koha-bugs] [Bug 29488] New: NumSavedReports system preference doesn't work Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29488 Bug ID: 29488 Summary: NumSavedReports system preference doesn't work Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: sbrown at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The NumSavedReports system preference to set a custom default number of reports to show in Saved Reports isn't working in 21.05.04. Changing the number, saving, and then refreshing Saved Reports (or leaving then reentering the module) doesn't change the number shown from the system default of 20. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 21:08:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 20:08:19 +0000 Subject: [Koha-bugs] [Bug 29489] New: <> in RENEWAL notice subject field Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29489 Bug ID: 29489 Summary: <> in RENEWAL notice subject field Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: george at nekls.org QA Contact: testopia at bugs.koha-community.org Using <> returns the library name when used in the subject field for a notice template with one apparent exception. If an item is renewed from the OPAC the RENEWAL notice is sent with the subject "<>" We are set up so that an item renewal via the OPAC should get recorded statistically as a renewal by the branch the item was checked out at. It would be nice if <> filled in the branch name of the library where the item was checked out rather than "branches.branchcode" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 22:34:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 21:34:35 +0000 Subject: [Koha-bugs] [Bug 29364] Search.t not reverting changes made to the framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29364 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #7 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 15 23:55:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 22:55:24 +0000 Subject: [Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices between different orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Version(s)|21.11.00,21.05.05,20.11.12 |21.11.00,21.05.05,20.11.12, released in| |20.05.18 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #18 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 00:03:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 23:03:56 +0000 Subject: [Koha-bugs] [Bug 28898] Context for translation: term (word) vs. term (semester) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 --- Comment #20 from David Cook --- (In reply to Katrin Fischer from comment #19) > (In reply to David Cook from comment #17) > > I'm a bit confused by this one. > > > > Does it show "Term" in the English UI but "Semester" in the translation file? > > The strings with the same context will be translated together with the > context showing as a "hint" when translating. You still see "term". The > English GUI is not changed by this patch set at all. > > The main point here is not semester vs. term, but more: term vs. search > terms. We have "term" showing up in context of search and in the course > reserves module. The context is different, but without this patch you can't > differentiate. In German the term for 'time' and term for 'words' are > completely different words and this patch allows to use different > translations. Thanks for the explanation, Katrin. I figured it must be something like that but it wasn't obvious at a glance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 00:04:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 23:04:55 +0000 Subject: [Koha-bugs] [Bug 27893] Delete of biblio with order does not always warn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 00:07:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 23:07:06 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #21 from David Cook --- (In reply to Martin Renvoize from comment #13) > > I think we should slowly be migrating from template-driven datatables > (KohaTable) to api driven datatable (kohaTable).. so to me, the similarity > is deliberate and the distinction is clear. > Agreed and much appreciated! The .api() method name was driving me crazy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 00:07:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 23:07:27 +0000 Subject: [Koha-bugs] [Bug 29487] Set autocomplete off for userid/password fields at login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29487 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 00:07:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 23:07:34 +0000 Subject: [Koha-bugs] [Bug 19570] autocomplete="off" no set for login forms at the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19570 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 00:08:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 23:08:45 +0000 Subject: [Koha-bugs] [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- Good question. My guess might be coincidental record repair but that's not necessarily a good reason to keep it there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 00:09:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 23:09:39 +0000 Subject: [Koha-bugs] [Bug 29307] marc record fetched twice in detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 00:10:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 23:10:50 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 00:14:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 23:14:17 +0000 Subject: [Koha-bugs] [Bug 29480] Add email address as a method for generating the userid when self registering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 00:14:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 23:14:57 +0000 Subject: [Koha-bugs] [Bug 29480] Add email address as a method for generating the userid when self registering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 --- Comment #2 from David Cook --- Andreas, can you set yourself as assignee? I might be wrong but I think sysprefs.sql needs updating too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 00:15:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 23:15:45 +0000 Subject: [Koha-bugs] [Bug 29479] Discrepancy between kohastructure and db revisions (impacting DBIx schema) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29479 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 00:16:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 23:16:05 +0000 Subject: [Koha-bugs] [Bug 29435] OPAC authority details page broken when AuthDisplayHierarchy is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29435 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 00:17:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 23:17:22 +0000 Subject: [Koha-bugs] [Bug 29255] Built-in offline circulation broken with SQL error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 00:18:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Nov 2021 23:18:13 +0000 Subject: [Koha-bugs] [Bug 29146] Default values from the framework should only be applied at biblio/item creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 01:03:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 00:03:52 +0000 Subject: [Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 --- Comment #7 from David Cook --- I don't think that I have any QA powers any more but this sounds very important. (Bug 29223 was the issue I was having with automatic renewal digests.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 01:04:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 00:04:42 +0000 Subject: [Koha-bugs] [Bug 29223] Auto-renewals can fail when not digested per branch and patron requests digest In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29223 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18532 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 01:04:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 00:04:42 +0000 Subject: [Koha-bugs] [Bug 18532] Messaging preferences for auto renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29223 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 01:13:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 00:13:32 +0000 Subject: [Koha-bugs] [Bug 29488] NumSavedReports system preference doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29488 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version|21.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 01:15:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 00:15:12 +0000 Subject: [Koha-bugs] [Bug 29488] NumSavedReports system preference doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29488 --- Comment #1 from Lucas Gass --- In dataTables version 1.10 we should use pageLength instead of iDisplayLength. https://datatables.net/reference/option/pageLength Koha is using 1.10.18 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 01:19:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 00:19:24 +0000 Subject: [Koha-bugs] [Bug 29488] NumSavedReports system preference doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29488 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 01:19:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 00:19:27 +0000 Subject: [Koha-bugs] [Bug 29488] NumSavedReports system preference doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29488 --- Comment #2 from Lucas Gass --- Created attachment 127677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127677&action=edit Bug 29488: make NumSavedReports work 1. Have a bunch of saved reports 2. Try to use the sys pref NumSavedReports to limit how many show by default 3. It doesn't work 4. Apply patch 5. Try again, now it should work -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 08:01:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 07:01:21 +0000 Subject: [Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Version(s)|21.11.00,21.05.05,20.11.12 |21.11.00,21.05.05,20.11.12, released in| |20.05.18 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #15 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 08:12:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 07:12:07 +0000 Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 08:12:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 07:12:11 +0000 Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126641|0 |1 is obsolete| | --- Comment #7 from Fridolin Somers --- Created attachment 127678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127678&action=edit Bug 29230: Add Koha::Patron->messages Add methods to return the messages attached to a patron. It will add the capability to access them from notice templates. Test plan: Define some messages for a given patron Go to the circulation page of the patron and confirm that they are still displayed Test the notice templates: Add to HOLD_SLIP the following content """ [% SET messages = borrower.messages %] [% IF messages.count %] Messages:
      [% FOR m IN messages.search( message_type => 'L' ) %]
    • [% m.message %]
      • [% END %]
    [% END %] """ To display all the messages from staff ('L') Adapt following your needs. Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 08:14:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 07:14:01 +0000 Subject: [Koha-bugs] [Bug 29480] Add email address as a method for generating the userid when self registering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 Andreas Jonsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127636|0 |1 is obsolete| | --- Comment #3 from Andreas Jonsson --- Created attachment 127679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127679&action=edit Bug 29480: Add new systempreference PatronSelfRegistrationUseridGenerationMethod and add email as option. Test plan - Install patch and run koha-upgrade-schema - The systempreference PatronSelfRegistrationUseridGenerationMethod should be found in the adminstrative interface under OPAC -> Self registration and modification - Also make sure - Make sure that PatronSelfRegistration is set to Allow and PatronSelfRegistrationDefaultCategory is set to an existing borrower category - Make sure that PatronSelfModificationBorrowerUnwantedField doesn't prevent the input of an email address in the self registration form. (I.e., make sure "email" is NOT selected for exclusion.) - Go to opac and self register a patron and verify that the userid is on the form firstname.surname. - Change systempreference to 'email' - Go to OPAC and self register a patron and make sure to add a valid email address. - Verify the that the userid is the email adress. - Go to OPAC and self register a patron using the SAME valid email adress as above (to provoke a conflicting userid). - Verify that the userid is on the form firstname.surname. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 08:16:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 07:16:25 +0000 Subject: [Koha-bugs] [Bug 29480] Add email address as a method for generating the userid when self registering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 Andreas Jonsson changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |andreas.jonsson at kreablo.se --- Comment #4 from Andreas Jonsson --- Yes, I had missed to add the system preference to sysprefs.sql. Thank you David for pointing this out! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 08:32:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 07:32:33 +0000 Subject: [Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #9 from Victor Grousset/tuxayo --- Missing dependencies for 20.05.x, not affected after testing, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 08:33:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 07:33:32 +0000 Subject: [Koha-bugs] [Bug 29075] OPAC info should not be displayed in libraries table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #12 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 08:33:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 07:33:49 +0000 Subject: [Koha-bugs] [Bug 29350] TT method 'delete' don't need to be escaped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29350 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #5 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 08:33:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 07:33:49 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Bug 22605 depends on bug 29350, which changed state. Bug 29350 Summary: TT method 'delete' don't need to be escaped https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29350 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 08:34:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 07:34:24 +0000 Subject: [Koha-bugs] [Bug 25459] In patron cards layout, barcode position doesn't respect units In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25459 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 08:36:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 07:36:33 +0000 Subject: [Koha-bugs] [Bug 29054] Stop warns from advance_notices.pl if not running in verbose mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #2 from Fridolin Somers --- I agree with that -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 08:37:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 07:37:12 +0000 Subject: [Koha-bugs] [Bug 29054] Stop warns from advance_notices.pl if not running in verbose mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 08:37:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 07:37:15 +0000 Subject: [Koha-bugs] [Bug 29054] Stop warns from advance_notices.pl if not running in verbose mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125086|0 |1 is obsolete| | --- Comment #3 from Fridolin Somers --- Created attachment 127680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127680&action=edit Bug 29054: Add verbose check for warn in advance_notices.pl To test: 1) Set EnhancedMessagingPreferences to Don't allow 2) In the koha-shell, run misc/cronjobs/advance_notices.pl -c 3) Note that you see the warning "The "EnhancedMessagingPreferences" syspref is off... etc." 4) Apply the patch and restart services 5) In the koha-shell, run misc/cronjobs/advance_notices.pl -c and note the warning no longer shows 6) Still in the shell, run misc/cronjobs/advance_notices.pl -c -v and note the warning does show Sponsored-by: Catalyst IT Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 08:40:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 07:40:43 +0000 Subject: [Koha-bugs] [Bug 27884] Add HTML mail support for patron emailer script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #18 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 08:41:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 07:41:42 +0000 Subject: [Koha-bugs] [Bug 29329] stray "s" in opac-detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29329 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #7 from Victor Grousset/tuxayo --- Missing dependencies for 20.05.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 08:56:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 07:56:53 +0000 Subject: [Koha-bugs] [Bug 29300] Release team 22.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29300 --- Comment #13 from Victor Grousset/tuxayo --- Maybe I shouldn't have backported to 20.05.x since it will reach end of life? Now in the about page I see: > This is the team who are responsible for the next release of Koha and the ongoing maintenance of your currently installed Koha version. They will be in these roles up until 05/22/2022 Which doesn't make sense. And as a consequence, the Release maintainer role isn't present. Since in the 22.05 team there is no such role. I would say that I should revert from 20.05.x and that in the future if this patch comes up before the end of the cycle, then the soon to EOL release shouldn't backport it. Wait, there is more, shouldn't 21.05.x and 20.11.x have waited next cycle before backporting? As the wrong RMaint is listed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 08:57:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 07:57:52 +0000 Subject: [Koha-bugs] [Bug 28716] Hide toolbar and opaccredits when printing lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28716 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Summary|Hide toolbar when printing |Hide toolbar and |lists |opaccredits when printing | |lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 08:58:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 07:58:31 +0000 Subject: [Koha-bugs] [Bug 28716] Hide toolbar and opaccredits when printing lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28716 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 08:58:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 07:58:35 +0000 Subject: [Koha-bugs] [Bug 28716] Hide toolbar and opaccredits when printing lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28716 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122862|0 |1 is obsolete| | --- Comment #2 from Fridolin Somers --- Created attachment 127681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127681&action=edit Bug 28716: hide moresearches and opaccredits from print To test: 1. Make some lists and look at them in the OPAC 2. Have some content in your OPACCredits news section 3. Look at some lists and try clicking 'Print list' 4. You will see the moresearches (top navigation) and opaccredits content 5. apply patch and regenearte the CSS 6. Do 3 again, you should not see the contents of moresearches (top navigation) and opaccredits content Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 09:01:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 08:01:33 +0000 Subject: [Koha-bugs] [Bug 28716] Hide toolbar and opaccredits when printing lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28716 --- Comment #3 from Fridolin Somers --- I changed commit message : & => and (I bet it can break HTML somewhere) opacredits => opaccredits Sounds more a minor bug than enhancement to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 09:04:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 08:04:18 +0000 Subject: [Koha-bugs] [Bug 29487] Set autocomplete off for userid/password fields at login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29487 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart --- Ready for testing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 09:11:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 08:11:05 +0000 Subject: [Koha-bugs] [Bug 28904] Update information on Newsletter editor on about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28904 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.11.00,21.05.05,20.11.12 |21.11.00,21.05.05,20.11.12, released in| |20.05.18 CC| |victor at tuxayo.net --- Comment #21 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 09:12:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 08:12:34 +0000 Subject: [Koha-bugs] [Bug 29365] Koha::Email needs to be refactored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29365 Bug 29365 depends on bug 28729, which changed state. Bug 28729 Summary: Return-path header not set in emails https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 09:12:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 08:12:33 +0000 Subject: [Koha-bugs] [Bug 28729] Return-path header not set in emails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #62 from Victor Grousset/tuxayo --- Missing dependencies for 20.05.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 09:12:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 08:12:51 +0000 Subject: [Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #10 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 09:13:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 08:13:22 +0000 Subject: [Koha-bugs] [Bug 28973] Improve Koha::Patron::can_see_patron_infos efficiency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28973 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 09:13:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 08:13:41 +0000 Subject: [Koha-bugs] [Bug 28474] Pass process_message_queue.pl params to before_send_messages plugin hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28474 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #12 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 09:14:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 08:14:01 +0000 Subject: [Koha-bugs] [Bug 27173] Add plugin hooks for authority record changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net --- Comment #19 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 09:14:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 08:14:53 +0000 Subject: [Koha-bugs] [Bug 29386] background jobs table data field is a TEXT which is too small In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29386 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #18 from Victor Grousset/tuxayo --- Missing dependencies for 20.05.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 09:15:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 08:15:16 +0000 Subject: [Koha-bugs] [Bug 28768] OPAC reading history page (opac-readingrecord.pl) wont display news items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28768 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net --- Comment #14 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 09:15:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 08:15:17 +0000 Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Bug 24223 depends on bug 28768, which changed state. Bug 28768 Summary: OPAC reading history page (opac-readingrecord.pl) wont display news items https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28768 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 09:15:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 08:15:37 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net --- Comment #23 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 09:34:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 08:34:37 +0000 Subject: [Koha-bugs] [Bug 29300] Release team 22.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29300 --- Comment #14 from Martin Renvoize --- Good points to raise.. This patch should be bakported as one of the last things one does prior to their final release as RMaint.. though any time during that last month is fine really as it won't take wider effect until release. As for the last one to contain it, I'm not sure where I stand on that one.. perhaps if there's not an RMaint listed we should display 'No longer actively supported by the community' or something like that.. or 'Security release only, refer to the website for the current release team' ? With the introduction of LTS releases, this becomes a bigger question indeed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 09:35:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 08:35:53 +0000 Subject: [Koha-bugs] [Bug 29300] Release team 22.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29300 --- Comment #15 from Martin Renvoize --- Another option is to put 'end of life' details into the teams.yaml and publish that on the about page too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 09:52:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 08:52:23 +0000 Subject: [Koha-bugs] [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 --- Comment #2 from Jonathan Druart --- Created attachment 127682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127682&action=edit Bug 29486: _koha_marc_update_bib_ids no longer needed for GetMarcBiblio This subroutine is ensuring that the biblionumber and biblioitemnumber will be part of the MARC record. We should not need that, unless there is something broken somewhere else. This line has been added by the following commit: commit 4e95e94727b09b33d2f6c597bdd218a59dcc3681 Bug 6789: biblios with many items can result in broken search results link """ To this end, it also moves the fix_biblio_ids portion of get_corrected_marc_record out of rebuild_zebra.pl, and makes it a part of GetMarcBiblio (right before EmbedItemsInMarcBiblio, so the 952s still come last). fix_biblio_ids is kept as a subroutine for the deletion portion of rebuild_zebra.pl, which still uses it. """ But it does not explain why it's better to have it in GetMarcBiblio. If we need it for the reindexation process, we shouldn't impact GetMarcBiblio which is used from several different places. We might then consider adding the fix_biblio_ids call to rebuild_zebra.pl, but I am failing to understand in which cases it could be useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 09:56:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 08:56:33 +0000 Subject: [Koha-bugs] [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi, | |nick at bywatersolutions.com, | |tomascohen at gmail.com Status|NEW |In Discussion --- Comment #3 from Jonathan Druart --- This patch makes some tests fail, see t/db_dependent/Biblio.t When an update of biblio[item]number is made manually, the MARC record is (of course) not modified, and GetMarcRecord returns an "incorrect" record (ie. without the correct 999$c$d). Should we insist and remove this call? If so, should we provide a migration script and add a check to search_for_data_inconsistencies.pl? Which other situations this line was handling? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 10:00:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 09:00:54 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #25 from Jonathan Druart --- Can we move forward? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 10:01:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 09:01:02 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 10:01:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 09:01:22 +0000 Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 10:26:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 09:26:29 +0000 Subject: [Koha-bugs] [Bug 29343] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29343 smitheliza changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Acquisitions |About URL| |https://www.7qasearch.net/b | |log/how-to-increase-cash-ap | |p-withdrawal-limit/ Keywords| |cookie Version|21.05 |19.05 CC| |smitheliza620 at gmail.com --- Comment #2 from smitheliza --- Increasing the cash app limit becomes imperative to send money through this platform as per the requirement. Cash app service executives may provide their customers with efficient techniques. The limitation however can be managed with the verification procedure of the cash app account with effectiveness. Users will simply require understanding the policies of the cash app to increase the limit of their cash app account. https://www.7qasearch.net/blog/how-to-increase-cash-app-withdrawal-limit/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 10:56:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 09:56:51 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 --- Comment #1 from Jonathan Druart --- Created attachment 127683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127683&action=edit Bug 29394: Remove flatpickr instantiations from most of the tt files We must reduce the instantiations as much as possible to take advantages of the default values and specific behaviours we have defined in calendar.inc This patch is suggesting to have a .flatpickr class and using the data attributes: - flatpickr-futuredate - flatpickr-pastdate - flatpickr-enable-time - flatpickr-on-close-focus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 10:57:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 09:57:55 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, oleonard at myacpl.org Status|NEW |In Discussion --- Comment #2 from Jonathan Druart --- Owen, Martin, this is what I had in mind. Do you agree with the idea? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 11:09:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 10:09:35 +0000 Subject: [Koha-bugs] [Bug 29490] New: Preview for more notices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29490 Bug ID: 29490 Summary: Preview for more notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org It would be great to have the preview option available on more notices.. currently, it's limited to CHECKIN, CHECKOUT and HOLD_SLIP. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 11:09:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 10:09:45 +0000 Subject: [Koha-bugs] [Bug 29490] Preview for more notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29490 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 11:30:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 10:30:25 +0000 Subject: [Koha-bugs] [Bug 29491] New: Improve display of notices in patron details Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Bug ID: 29491 Summary: Improve display of notices in patron details Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The display of notices in a patrons record could be improved.. the display box seems to be unnecessarily narrow and I can't tell if HTML formatting is being fully applied. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 11:39:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 10:39:33 +0000 Subject: [Koha-bugs] [Bug 29462] OPACPopupAuthorsSearch doesn't work when authors include $d, $4, and possible other subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29462 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart --- I am seeing a lot of code related to this feature that has been removed on commit 56c2856e268ec02638898923d751a0b69c716f93 Bug 12561: Remove non-XSLT views For instance the class "authority_link" that is used in opac-detail.tt to generate the link was only used by the non-XSLT part. It feels like we never really implemented this feature for the XSLT view. It seems that we need to add the class "authority_link" to the link, with a data-authid Related code is: 1876 if( $(this).hasClass("authority_link") ){ 1877 authid = $(this).data("authid"); 1878 search_string = "an:" + authid; 1879 } else { 1880 search_string = terms[term]["keyword_search"] + encodeURIComponent( search_label ); 1881 } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 11:58:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 10:58:26 +0000 Subject: [Koha-bugs] [Bug 29419] suggest for purchase clears itemtype if bib exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29419 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 11:58:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 10:58:30 +0000 Subject: [Koha-bugs] [Bug 29419] suggest for purchase clears itemtype if bib exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29419 --- Comment #1 from Jonathan Druart --- Created attachment 127684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127684&action=edit Bug 29419: Retain user's inputs when suggesting for purchase and match found If a user suggests for purchase and a match is found, their inputs was not retained: quantity, item type, library, reason. Test plan: 1. Suggest for purchase 2. Fill the title in with a string that will match an existing record 3. Fill value in quantity, item type, library and reason input/dropdown 4. Submit => Notice that with this patch the values you entered are retained on the confirmation screen -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 11:58:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 10:58:55 +0000 Subject: [Koha-bugs] [Bug 29419] suggest for purchase clears itemtype, quantity, library and reason if bib exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29419 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Summary|suggest for purchase clears |suggest for purchase clears |itemtype if bib exists |itemtype, quantity, library | |and reason if bib exists CC| |jonathan.druart+koha at gmail. | |com Version|21.05 |unspecified -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 12:03:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 11:03:53 +0000 Subject: [Koha-bugs] [Bug 29487] Set autocomplete off for userid/password fields at login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29487 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Nick Clemens --- (In reply to Jonathan Druart from comment #2) > Ready for testing? Yes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 12:18:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 11:18:06 +0000 Subject: [Koha-bugs] [Bug 19852] Add message text box in circulation for patrons does not accept HTML tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19852 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 12:22:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 11:22:50 +0000 Subject: [Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371 Andreas Jonsson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson at kreablo.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 12:25:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 11:25:16 +0000 Subject: [Koha-bugs] [Bug 28702] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28702 Andreas Jonsson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson at kreablo.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 12:25:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 11:25:29 +0000 Subject: [Koha-bugs] [Bug 26587] detail.pl is very slow for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 Andreas Jonsson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson at kreablo.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 12:51:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 11:51:09 +0000 Subject: [Koha-bugs] [Bug 29493] New: 10 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29493 Bug ID: 29493 Summary: 10 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: gladstone at gvpersons.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Created attachment 127686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127686&action=edit Hantu Cyber Team Mati ae kalian -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 12:52:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 11:52:33 +0000 Subject: [Koha-bugs] [Bug 29493] 10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29493 Nekopoi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gladstone at gvpersons.com --- Comment #1 from Nekopoi --- Comment on attachment 127686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127686 Hantu Cyber Team JowoHappy #NgehekMletreAsek #StaySantuy
    #IndonesianDefacer #SedukuranOraMusuhan #DefacerSmile
    #WeAreMuslim #NothingCanStopUs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 13:03:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 12:03:43 +0000 Subject: [Koha-bugs] [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 13:05:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 12:05:09 +0000 Subject: [Koha-bugs] [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 13:05:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 12:05:13 +0000 Subject: [Koha-bugs] [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127668|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi --- Created attachment 127687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127687&action=edit Bug 29477: Flatpickr - default to 23:59 for the time part It was defaulting to 12:00 which was an unexpected change in behaviour caused by flatpickr switch. Test plan: On the circulation view, check some items out and play with the time part and "Remember for session". The behaviour must be correct, ie. the same as prior to flatpickr switch. Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 13:05:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 12:05:33 +0000 Subject: [Koha-bugs] [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 --- Comment #4 from Tomás Cohen Arazi --- Works as expected, trivial fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 13:10:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 12:10:45 +0000 Subject: [Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127657|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 127688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127688&action=edit Bug 28709: Refactor Koha::Biblio->custom_cover_image_url to allow passing parameters Currently the search result template receive a Koha::Biblio object and call the method. The searchResults routine already has the isbn, issn, and normalized_isbn calculated. Rather than fetching the object and passing to the template we can pass the parameters, generate the url, and pass only the URL to the template To test: 1 - Set the system preferences: CustomCoverImages : Display OPACCustomCoverImages: Display CustomCoverImagesURL: https://images-na.ssl-images-amazon.com/images/P/{normalized_isbn}.01.LZZZZZZZ.jpg 2 - Search on staff and opac for a term that returns titles with covers, e.g. 'shuffle' 3 - Confirm the covers show 4 - Apply patch 5 - Restart all 6 - Confirm covers still show 7 - prove -v t/db_dependent/Koha/Biblios.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 13:14:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 12:14:57 +0000 Subject: [Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 --- Comment #12 from Nick Clemens --- (In reply to Jonathan Druart from comment #8) > Are you sure we don't only need to pass/cache the MARC record? I suppose we could, but we have already called TransformMarcToKoha, why would we not pass the values we calculated? > Did you benchmark this patch? with numSearchResults at 50 - standard sample data, search for 'a' Before patch ~2 second After patch ~1.85 seconds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 13:16:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 12:16:00 +0000 Subject: [Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 13:16:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 12:16:05 +0000 Subject: [Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127655|0 |1 is obsolete| | --- Comment #11 from Tomás Cohen Arazi --- Created attachment 127689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127689&action=edit Bug 5229: Remove system preference 'OPACItemsResultsDisplay' We dropped it on bug 12561 when removing the non-XSLT view. This feature has never been implemented for XSLT views and the pref must then be removed. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 13:16:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 12:16:10 +0000 Subject: [Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 127690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127690&action=edit Bug 5229: Remove from searching.pref Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 13:18:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 12:18:23 +0000 Subject: [Koha-bugs] [Bug 29494] New: html-template-to-template-toolkit.pl no longer required Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29494 Bug ID: 29494 Summary: html-template-to-template-toolkit.pl no longer required Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org This file was used in the transition from HMTL::Template to Template::Toolkit and there's no need to carry it on the current codebase. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 13:18:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 12:18:30 +0000 Subject: [Koha-bugs] [Bug 29494] html-template-to-template-toolkit.pl no longer required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29494 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 13:20:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 12:20:22 +0000 Subject: [Koha-bugs] [Bug 29494] html-template-to-template-toolkit.pl no longer required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29494 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 13:20:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 12:20:41 +0000 Subject: [Koha-bugs] [Bug 29494] html-template-to-template-toolkit.pl no longer required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29494 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 13:20:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 12:20:45 +0000 Subject: [Koha-bugs] [Bug 29494] html-template-to-template-toolkit.pl no longer required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29494 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 127691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127691&action=edit Bug 29494: html-template-to-template-toolkit.pl no longer required This helper script was used to transition from HTML::Template to Template::Toolkit, which happened 11 (?) years ago. The file is part of Koha history, but we don't need it in current master. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 13:23:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 12:23:08 +0000 Subject: [Koha-bugs] [Bug 29492] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29492 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Group|Koha security | QA Contact| |testopia at bugs.koha-communit | |y.org Product|Koha security |Koha Component|Koha |Architecture, internals, | |and plumbing Assignee|chris at bigballofwax.co.nz |koha-bugs at lists.koha-commun | |ity.org Summary|10 |SPAM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 13:24:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 12:24:11 +0000 Subject: [Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 --- Comment #10 from Nick Clemens --- (In reply to Sonia Bouis from comment #9) > Sorry, but I found a problem with this patch. > > I have just tried and compared with a master from this morning. > The preference system AcqCreateItem is on "placing an order" > > If I tried to save an order with this patch with an item where all mandatory > item are filled, I have the message : "Form not submitted because of the > following problem(s): > - 4 item mandatory fields empty". > > If I tried the same on a master branch, my order is saved normally. > > Can you reproduce this issue ? > Sonia I don't recreate Sonia. This patch only touches the template on the receiving page. Can you provide a few more steps, or a screenshot? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 13:24:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 12:24:14 +0000 Subject: [Koha-bugs] [Bug 29490] Preview for more notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29490 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17981 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 [Bug 17981] Add the ability to preview generated notice templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 13:24:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 12:24:14 +0000 Subject: [Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29490 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29490 [Bug 29490] Preview for more notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 13:41:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 12:41:02 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #21 from Nick Clemens --- (In reply to Jonathan Druart from comment #17) > I disagree with removing the FK. Statistics should not keep a wrong/obsolete > code, they are kept (ON DELETE SET NULL) however. > > There are different things, and different fixes: Statistics table is missing > the FK (or does not have it on purpose), and the OpacRenewalBranch behaviour > is badly designed. > > I don't think removing the FK is going into the correct direction, adding a > separate column is definitely out of the scope here. We need a quick bugfix > for the ugly 500 (that is blocker), and this patch is the way to go in my > opinion. I disagree here, I think we should remove the FK to branches as the quick fix. While we may have opinions about how that feature was implemented, it has been implemented. Statistics is a ledger of transactions - foreign keys are going to remove/nullify data after the fact and I think that would be incorrect. If Pseudonymized transactions are meant to mirror the statistics table then I feel we should remove the FK for now, and fix the larger issue with OPACRenew etc on a new bug. Adding a new branch is going to add the branch in many places throughout Koha and will impact workflows -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 13:58:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 12:58:02 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #22 from Jonathan Druart --- If you delete the library then recreate another one with the same branchcode, do we want the stats to be linked to the new library? I don't think so. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 14:01:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 13:01:19 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 14:01:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 13:01:22 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 --- Comment #47 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 14:01:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 13:01:58 +0000 Subject: [Koha-bugs] [Bug 29428] Where is css/holds.css ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29428 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED CC| |jonathan.druart+koha at gmail. | |com --- Comment #3 from Jonathan Druart --- New commit pushed commit ff2fbfe35f20e767d0c47374ef9d366e62b8e848 Bug 28816: (follow-up) Compiled CSS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 14:03:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 13:03:03 +0000 Subject: [Koha-bugs] [Bug 29426] borrower_debarments.created is "ON UPDATE current_timestamp()" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29426 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- Yes it does, can you provide a patch please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 14:17:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 13:17:29 +0000 Subject: [Koha-bugs] [Bug 29447] authority that begins with a number isn't found in tag editor search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29447 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- It seems to work for me on master. Did you try on a sandbox? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 14:19:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 13:19:33 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #26 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #24) > additional_contents > - id > - category > - published_on > - updated_on > - expirationdate > - number > > Another table for translations: > - fk > - lang (or eventually fk to a lang table) > - title > - content This looks better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 14:27:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 13:27:55 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #27 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #26) > (In reply to Jonathan Druart from comment #24) > > > additional_contents > > - id > > - category > > - published_on > > - updated_on > > - expirationdate > > - number > > > > Another table for translations: > > - fk > > - lang (or eventually fk to a lang table) > > - title > > - content > > This looks better. But this is not for now :D However I still think we should hide the code for 21.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 14:50:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 13:50:29 +0000 Subject: [Koha-bugs] [Bug 29455] 505$t - change in line break/display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29455 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart --- Say you have several 505 with several $t$r$g, what's the expected behaviour then? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 14:57:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 13:57:19 +0000 Subject: [Koha-bugs] [Bug 29456] Notice overview on Patron Category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Keywords| |rel_21_05_candidate, | |rel_21_11_candidate Depends on| |18532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 [Bug 18532] Messaging preferences for auto renewals -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 14:57:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 13:57:19 +0000 Subject: [Koha-bugs] [Bug 18532] Messaging preferences for auto renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29456 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 [Bug 29456] Notice overview on Patron Category -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:00:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:00:08 +0000 Subject: [Koha-bugs] [Bug 29456] Notice overview on Patron Category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:00:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:00:08 +0000 Subject: [Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the date format release notes| |in OAI-PMH for | |Identify.earliestDatestamp | |so that it uses | |"YYYY-MM-DDThh:mm:ssZ" and | |is in UTC, instead of the | |SQL formsat "YYYY-MM-DD | |hh:mm:ss" currently used. | |For OAI-PMH all date and | |time values must be in the | |format | |"YYYY-MM-DDThh:mm:ssZ" and | |in UTC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:00:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:00:13 +0000 Subject: [Koha-bugs] [Bug 29456] Notice overview on Patron Category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 --- Comment #1 from Jonathan Druart --- Created attachment 127692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127692&action=edit Bug 29456: (bug 18532 follow-up) handle Auto_Renewals messages in category The new message appears in the list on the edit view, but the list view is showing "unknown" Test plan: Set AutoRenewalNotices to "according to patron messaging prefs" Edit a patron category Tick all the checkboxes On the category list view you should see a correct display in the "Messaging" column -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:01:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:01:20 +0000 Subject: [Koha-bugs] [Bug 29456] "Auto renewal" notice shown as "unknown" on the patron category list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Notice overview on Patron |"Auto renewal" notice shown |Category |as "unknown" on the patron | |category list view -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:01:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:01:24 +0000 Subject: [Koha-bugs] [Bug 29456] "Auto renewal" notice shown as "unknown" on the patron category list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:08:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:08:04 +0000 Subject: [Koha-bugs] [Bug 29495] New: Issue link is lost in return claims when using 'MarkLostItemsAsReturned' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Bug ID: 29495 Summary: Issue link is lost in return claims when using 'MarkLostItemsAsReturned' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com We have a foreign key constraint in return_claims for issue_id.. this means that if you have 'MarkLostItemsAsReturned' enabled, we first add the issue_id linking to the original checkout, then immediately move the checkout to old_issues and nuke the issue_id from the claims_return table :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:08:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:08:24 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:09:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:09:39 +0000 Subject: [Koha-bugs] [Bug 29455] 505$t - change in line break/display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29455 --- Comment #3 from Katrin Fischer --- Subfield g, r, t are repeatable, a is not. For defining "items" this is all I could find back then and asusmeed that each item should go on a new line: In records formulated according to AACR 2, a space-hyphen-hyphen-space ( -- ) is recorded between each item in the contents note unless a delimiter/subfield code follows in which case there is no ending space. In pre-AACR 2 records, items are separated by a period-hyphen-hyphen (.--). I am not sure what indications the subfield sequence can give. Here it's tg tg... 505 00$tQuatrain II$g(16:35) --$tWater ways$g(1:57) --$tWaves$g(10:49). But then the next example is already different with gt gt gt: 505 10$gNr. 1.$tRegion Neusiedlersee --$gNr. 2.$tRegion Rosalia/Lithagebirge --$gNr. 3.$tRegion Mettelburgenland --$gNr. 4.$tRegion südliches Burgenland --$gNr. 5.$tRegion Südburgland You'd need to keep the ones corresponding on one line togehter, but if the subfield sequence can change like this, I saw no other option than using the --. Example from LOC documentation: https://www.loc.gov/marc/bibliographic/bd505.html -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:11:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:11:25 +0000 Subject: [Koha-bugs] [Bug 28898] Context for translation: term (word) vs. term (semester) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This disambiguates the term |This disambiguates and release notes|"term" used in course |provides a hint for |reserves, where the meaning |translating the term "term" |is "semester". This allows |used in course reserves, |it to be translated, rather |where the meaning is |than having to use JQuery |"semester" rather than |to change the text |something like search term. |displayed for languages |This allows it to be |other then English. |translated, rather than | |having to use JQuery to | |change the text displayed | |for languages other then | |English. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:12:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:12:45 +0000 Subject: [Koha-bugs] [Bug 29456] "Auto renewal" notice shown as "unknown" on the patron category list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127692|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 127693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127693&action=edit Bug 29456: (bug 18532 follow-up) handle Auto_Renewals messages in category The new message appears in the list on the edit view, but the list view is showing "unknown" Test plan: Set AutoRenewalNotices to "according to patron messaging prefs" Edit a patron category Tick all the checkboxes On the category list view you should see a correct display in the "Messaging" column Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:13:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:13:20 +0000 Subject: [Koha-bugs] [Bug 29456] "Auto renewal" notice shown as "unknown" on the patron category list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Kelly McElligott --- Works great! Signing off through sandboxes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:21:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:21:38 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch converts the release notes| |point of sale receipt | |printer controller to using | |GetPreparedLetter instead | |of calling getletter | |directly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:24:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:24:58 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #4 from Owen Leonard --- Created attachment 127694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127694&action=edit Bug 29478: (follow-up) Provide default style for shortcut buttons This patch adds some CSS to _flatpickr.scss in order to give a deafult style to the "yesterday," "today," and "tomorrow" controls added by the shortcut plugin. A missed translatable string is now wrapped in the __() function: __("or"). The patch also updates the date calculation for those shortcuts to use Flatpickr's date calculation shorthand. This isn't strictly necessary but I think it makes the code more readable. To test, apply the patch and build the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). In the staff client, view some pages with date-picker widgets. A calendar widget time selection: - Circulation -> Check out -> Checkout settings -> Select date: - The calendar widget should have "yesterday," "today," and "tomorrow" controls styled like links appearing after the time selector. The controls should be centered, with the "or" label on the same line. A calendar widget without time selection: - Tools -> Log viewer -> Display from. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:26:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:26:49 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #5 from Owen Leonard --- (In reply to Jonathan Druart from comment #2) > Confirm that flatpickr instances now have a yesterday, today and > tomorrow buttons. I thought of an issue when testing my follow-up: Should the shortcut controls reflect the date limitations of the flatpickr instance? For instance, if selection is limited to a date before today, should the "today" and "tomorrow" controls be disabled? Currently clicking a shortcut for a date which is disallowed will empty the date field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:27:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:27:19 +0000 Subject: [Koha-bugs] [Bug 29334] Do not apply framework defaultvalue to existing authority records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29334 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an issue where release notes| |the default value for a | |field in a framework was | |being applied when records | |were edited, rather than | |only when first created. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:39:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:39:06 +0000 Subject: [Koha-bugs] [Bug 29264] SIP config allows use of non-branchcode institution ids causes workers to die without responding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29264 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds a warning to the release notes| |logs where a SIP login uses | |an institution id that is | |*not* a valid library code. | | | |If a SIP login uses an | |institution with an id that | |doesn't match a valid | |branchcode, everything will | |appear to work, but the SIP | |worker will die anywhere | |that Koha gets the branch | |from the userenv and | |assumes it is valid. | | | |The | |repercussions of this are | |that actions such as the | |checkout message simply die | |and do not return a | |response message to the | |requestor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:41:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:41:33 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #6 from Jonathan Druart --- (In reply to Owen Leonard from comment #5) > (In reply to Jonathan Druart from comment #2) > > > Confirm that flatpickr instances now have a yesterday, today and > > tomorrow buttons. > > I thought of an issue when testing my follow-up: Should the shortcut > controls reflect the date limitations of the flatpickr instance? For > instance, if selection is limited to a date before today, should the "today" > and "tomorrow" controls be disabled? Currently clicking a shortcut for a > date which is disallowed will empty the date field. Good point! Yes definitely, if not too hard to implement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:48:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:48:05 +0000 Subject: [Koha-bugs] [Bug 29469] Error when approving and rejecting tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29469 --- Comment #1 from Jonathan Druart --- Created attachment 127695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127695&action=edit Bug 29469: (bug 17600 follow-up) Fix tag approval/rejection from staff Usage: POSIX::exit(status) at /kohadevbox/koha/tags/review.pl line 72. at /usr/share/perl/5.28/Carp.pm line 289 Carp::croak('Usage: POSIX::exit(status)') called at /usr/lib/x86_64-linux-gnu/perl/5.28/POSIX.pm line 22 POSIX::usage('exit(status)') called at (eval 2066) line 3 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:48:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:48:27 +0000 Subject: [Koha-bugs] [Bug 29469] Error when approving and rejecting tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29469 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |jonathan.druart+koha at gmail. | |com Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:48:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:48:33 +0000 Subject: [Koha-bugs] [Bug 29469] Error when approving and rejecting tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29469 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:48:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:48:38 +0000 Subject: [Koha-bugs] [Bug 29469] Error when approving and rejecting tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29469 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:49:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:49:04 +0000 Subject: [Koha-bugs] [Bug 29469] Error when approving and rejecting tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29469 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17600 Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master --- Comment #2 from Jonathan Druart --- Patch pushed to master for 21.11.00 Thanks, Owen! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 [Bug 17600] Standardize the EXPORT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:49:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:49:04 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29469 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29469 [Bug 29469] Error when approving and rejecting tags -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:51:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:51:38 +0000 Subject: [Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This restores the behaviour release notes| |for purchase suggestions | |for an existing title, so | |that the suggestion form is | |pre-filled with the details | |from the existing record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:55:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:55:37 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:57:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:57:51 +0000 Subject: [Koha-bugs] [Bug 29494] html-template-to-template-toolkit.pl no longer required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29494 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 15:57:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 14:57:54 +0000 Subject: [Koha-bugs] [Bug 29494] html-template-to-template-toolkit.pl no longer required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29494 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127691|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 127696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127696&action=edit Bug 29494: html-template-to-template-toolkit.pl no longer required This helper script was used to transition from HTML::Template to Template::Toolkit, which happened 11 (?) years ago. The file is part of Koha history, but we don't need it in current master. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Owen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 16:02:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 15:02:11 +0000 Subject: [Koha-bugs] [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- I actually get this error when searchengine=zebra, and the message is... "elasticsearch_disabled"... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 16:06:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 15:06:25 +0000 Subject: [Koha-bugs] [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 16:06:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 15:06:29 +0000 Subject: [Koha-bugs] [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 --- Comment #2 from Jonathan Druart --- Created attachment 127697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127697&action=edit Bug 29436: ES mappings not saved if zebra is configured The mappings must be editable even if ES is not turned on yet. Using a separate array to store the errors as we are testing for $@ || @messages. There is still something wrong that should be improve, but this patch should be safe for backport. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 16:06:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 15:06:42 +0000 Subject: [Koha-bugs] [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 16:07:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 15:07:52 +0000 Subject: [Koha-bugs] [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19482 --- Comment #3 from Jonathan Druart --- Looks like it has been caused by commit 975e06bd7c3e198048c60d4a0f9968ba89079de7 Bug 19482: Add support for defining 'mandatory' mappings Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 [Bug 19482] Elasticsearch - prevent removal / editing of required indexes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 16:07:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 15:07:52 +0000 Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29436 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 16:08:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 15:08:39 +0000 Subject: [Koha-bugs] [Bug 29488] NumSavedReports system preference doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29488 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127677|0 |1 is obsolete| | --- Comment #3 from PTFS Europe Sandboxes --- Created attachment 127698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127698&action=edit Bug 29488: make NumSavedReports work 1. Have a bunch of saved reports 2. Try to use the sys pref NumSavedReports to limit how many show by default 3. It doesn't work 4. Apply patch 5. Try again, now it should work Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 16:09:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 15:09:00 +0000 Subject: [Koha-bugs] [Bug 29488] NumSavedReports system preference doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29488 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 16:09:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 15:09:06 +0000 Subject: [Koha-bugs] [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 --- Comment #4 from Jonathan Druart --- (In reply to Jonathan Druart from comment #2) > There is still something wrong that should be improve, but this patch > should be safe for backport. hum... bug 19482 comment 70 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 16:11:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 15:11:24 +0000 Subject: [Koha-bugs] [Bug 28279] mappings.yaml no longer in sync In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28279 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED --- Comment #8 from Jonathan Druart --- Has been regenerated by commit 0760045e0b10a80643b90cac77f653d5cda42e75 Bug 18984: Remove ES mapping for NORMARC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 16:25:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 15:25:10 +0000 Subject: [Koha-bugs] [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29239 Depends on|29239 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 16:25:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 15:25:10 +0000 Subject: [Koha-bugs] [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29477 | Depends on| |29477 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 16:25:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 15:25:35 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29477 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 16:25:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 15:25:35 +0000 Subject: [Koha-bugs] [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29394 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 [Bug 29394] Remove flatpickr instantiations from .tt files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 16:25:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 15:25:48 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart+koha at gmail. | |com Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 16:48:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 15:48:16 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #23 from Jonathan Druart --- Sonia confirmed me that it's ok to keep the branchcode and so remove the FK. I personally still don't think it's a good idea, but I understand the use case. This is also a bad use case: Create branch CPL, for testing purpose (hey you just installed the software and want to try it) Do some stuffs, it will create stats entries Remove CPL to start from scratch and clean state Reuse CPL as branchcode Stats are accumulating using the test data I will provide an alternate patch tomorrow if nobody beats me to it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 17:50:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 16:50:29 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 --- Comment #3 from Owen Leonard --- Created attachment 127699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127699&action=edit Bug 29394: (follow-up) Pass correct time format and other corrections This patch makes a few corrections, including adding the correct Flatpickr date format option when the timepicker is enabled. The patch also corrects a couple of places where the wrong date field was modified with the new data attributes. To test, apply the patch and test the datepickers on the batch checkout and renew pages. When you select a date and time the "TimeFormat" system preference should be correctly applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 17:57:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 16:57:24 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127699|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 18:01:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 17:01:20 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 --- Comment #4 from Owen Leonard --- Created attachment 127700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127700&action=edit Bug 29394: (follow-up) Pass correct time format and other corrections This patch makes a few corrections, including adding the correct Flatpickr date format option when the timepicker is enabled. Besides past and future date options, I've added a "pastinclusive" option which allows dates in the past OR today. This option was previously applied to the checkin page. The patch also corrects a couple of places where the wrong date field was modified with the new data attributes. To test, apply the patch and test the datepickers on the batch checkout and renew pages. When you select a date and time the "TimeFormat" system preference should be correctly applied. The calendar widget on the checkin page should allow you to select today's date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 18:02:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 17:02:51 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 --- Comment #5 from Owen Leonard --- One problem I wasn't able to understand: If you configure an input with the "pastdate" or "pastinclusive" option AND enable the time picker the defaultHour and defaultMinute options are lost. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 18:13:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 17:13:42 +0000 Subject: [Koha-bugs] [Bug 26802] Improve speed with records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26802 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 18:24:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 17:24:30 +0000 Subject: [Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #11 from Koha Team University Lyon 3 --- Hi Nick, The issue exists but I can reproduce it on the master git branch dating from yesterday (I don't understand why it has worked yesterday.. damn cache..) and on a sandbox. So, it's not linked to this patch, sorry for the wrong alert. I'm going to open a new BZ. (By the way, I haven't managed to have the sandbox provided on the bywatersolutions sandbox system) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 18:27:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 17:27:13 +0000 Subject: [Koha-bugs] [Bug 29496] New: can't save an order with mandatory items subfields Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Bug ID: 29496 Summary: can't save an order with mandatory items subfields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: koha at univ-lyon3.fr QA Contact: testopia at bugs.koha-community.org Here is the plan to reproduce it : - Unimarc flavour - Items in 995 field whith 3 mandatory / > Tab:10, | Koha field: items.homebranch, Not repeatable, Mandatory, Not Important, | Auth value:branches, > Tab:10, | Koha field: items.holdingbranch, Not repeatable, Mandatory, Not important, | Auth value:branches, > Tab:10, | Koha field: items.location, Not repeatable, Mandatory, Not important, | Auth value:LOC, - AcqCreateItem="placing an order" When adding an order from a new empty record,I filled - the title - the 3 mandatory items subfields (and clicked on add item) - the fund - the currency - the vendor price - the tax rate - the discount - the retail price - the replacement cost - the budgeted cost - the total When saving, I have the message : "Form not submitted because of the > following problem(s): - 3 item mandatory fields empty". You can try here : http://staff-master.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/acqui/basket.pl?basketno=2 Sonia -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 19:54:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 18:54:20 +0000 Subject: [Koha-bugs] [Bug 29491] Improve display of notices in patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #1 from Barbara Johnson --- Increasing the width of the display box would be helpful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 20:11:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 19:11:06 +0000 Subject: [Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 20:11:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 19:11:10 +0000 Subject: [Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126634|0 |1 is obsolete| | Attachment #126635|0 |1 is obsolete| | Attachment #126636|0 |1 is obsolete| | --- Comment #13 from Tomás Cohen Arazi --- Created attachment 127701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127701&action=edit Bug 29275: Add $patron_to_html to render patron information in JS Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 20:11:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 19:11:15 +0000 Subject: [Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 127702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127702&action=edit Bug 29275: Use the API to fetch checkouts information This patch changes issuehistory.pl so it leverages on the API for fetching checkouts information in the template. Workflow changes: This development splits the 'current' checkouts and the 'past' checkouts in two different tables. Terminology could be revisited by native english speakers. To test: 1. Have records with and without current/past checkouts 2. Notice how the Checkouts history tab presents the information on each case. => SUGGESTION: Keep each of them open on separate tabs for comparing 3. Apply this patchset and its dependencies 4. Restart plack, run: $ koha-plack --restart kohadev 5. Follow the same steps you followed for those open tabs, in new ones => SUCCESS: What you see makes sense, information is displayed as it used to, with the different tables now. 6. Try searching on the datatables => SUCCESS: Search works correctly! 7. Revisit the new texts I added => SUGGESTION: If you have better wordings, submit a patch, or just comment on the bug so I do it inline. 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 20:11:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 19:11:20 +0000 Subject: [Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 127703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127703&action=edit Bug 29275: (follow-up) Remove use of CountSubscriptionFromBiblionumber Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 20:19:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 19:19:45 +0000 Subject: [Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #16 from Tomás Cohen Arazi --- (In reply to Victor Grousset/tuxayo from comment #8) > A diff between current_checkouts and old_checkouts functions show that they > have a lot of duplication. > Is there a way to deduplicate without making something messy? > I wonder if there is a way to assign old_checkouts as a copy of > current_checkouts and then re assign so it it's properties to add and change > stuff. > The only difference is the URL param and a render function. Not just that. But I made a function to avoid duplication. > Also a call to encodeURIComponent() might be missing in current_checkouts Solved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 20:41:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 19:41:06 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|issuehistory.pl is very |Use the API to render |slow when there are many |checkout history for a |historical issues |biblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 20:52:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 19:52:33 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 127704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127704&action=edit Bug 29275: (follow-up) Split columns settings and handle upgrade This patch splits the table settings as we now have two tables. The atomic update takes care of setting the right values (if present) on the new tables entries. To test: 1. Do not apply this patch 2. Set some values you will remember for the checkoutshistory-table table 3. Run: $ koha-mysql kohadev > SELECT * FROM columns_settings WHERE tablename='checkoutshistory-table'; => SUCCESS: Koha currently works :-D 4. Apply this patch 5. Run: $ updatedatabase 6. Repeat 3 => SUCCESS: Things have been deleted 7. Run: $ koha-mysql kohadev > SELECT * FROM columns_settings WHERE tablename LIKE '%_checkouts-table'; => SUCCESS: old_checkouts-table and current_checkouts-table have the right setting 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 21:36:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 20:36:20 +0000 Subject: [Koha-bugs] [Bug 29497] New: Add ability to link authorities automatically in the advanced editor Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29497 Bug ID: 29497 Summary: Add ability to link authorities automatically in the advanced editor Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: estherm at sodaspringsid.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl It would be nice to add the link authorities automatically button in the advanced editor. Right now catalogers must use the basic editor in order to use this option. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 23:26:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 22:26:42 +0000 Subject: [Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean search and so results in error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Abbey Holt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aholt at dubuque.lib.ia.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 23:30:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 22:30:00 +0000 Subject: [Koha-bugs] [Bug 20956] BorrowersLog is not logging permission changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 23:33:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 22:33:47 +0000 Subject: [Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Version(s)|21.11.00,21.05.05,20.11.12 |21.11.00,21.05.05,20.11.12, released in| |20.05.18 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #12 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 16 23:35:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Nov 2021 22:35:01 +0000 Subject: [Koha-bugs] [Bug 29195] Highlighting broken on odd rows in circ-patron-search-results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29195 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 01:41:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 00:41:25 +0000 Subject: [Koha-bugs] [Bug 29485] selenium/administration_tasks.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29485 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #3 from Victor Grousset/tuxayo --- thanks, I'll try to reproduce and see if that can still happen when I'll upgrade Selenium to v4. Fingers crossed to not need the dirty fix after that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 01:48:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 00:48:36 +0000 Subject: [Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 --- Comment #13 from David Cook --- (In reply to Nick Clemens from comment #12) > > Did you benchmark this patch? > with numSearchResults at 50 - standard sample data, search for 'a' > Before patch ~2 second > After patch ~1.85 seconds Is that averaged or based on 1 test each? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 05:19:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 04:19:51 +0000 Subject: [Koha-bugs] [Bug 500] [INTRANET]Only 21 items are displayed in the search result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=500 Minerva.hernández changed: What |Removed |Added ---------------------------------------------------------------------------- OS|All |Linux Hardware|PC |Other CC| |atenea.min6 at gmail.com Resolution|FIXED |INVALID --- Comment #1 from Minerva.hernández --- No permite desplegar la plantilla de catalogación, así como no recupera la información y cuando migro en protocolo z39.50 no me permite guardar la información -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 07:18:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 06:18:25 +0000 Subject: [Koha-bugs] [Bug 29498] New: Remove usage of deprecated Mojolicious::Routes::Route::detour Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 Bug ID: 29498 Summary: Remove usage of deprecated Mojolicious::Routes::Route::detour Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Mojolicious::Routes::Route::detour was deprecated in Mojolicious 8.67 and removed in Mojolicious 9 The method is used in Koha::App::Plugin::RESTV1 to connect the "REST API" Mojolicious app to the other Mojolicious apps (Koha::App::Intranet and Koha::App::Opac), so it's only a problem when running Koha as a Mojolicious app. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 07:19:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 06:19:12 +0000 Subject: [Koha-bugs] [Bug 29498] Remove usage of deprecated Mojolicious::Routes::Route::detour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 --- Comment #1 from Julian Maurice --- Created attachment 127705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127705&action=edit Bug 29498: Remove usage of deprecated Mojolicious::Routes::Route::detour Mojolicious::Routes::Route::detour was deprecated in Mojolicious 8.67 and removed in Mojolicious 9 It was used in Koha::App::Plugin::RESTV1 to connect the "REST API" Mojolicious app to the other Mojolicious apps (Koha::App::Intranet and Koha::App::Opac), so it's only a problem when running Koha as a Mojolicious app. This patch makes use of the "partial" attribute instead, which does the same thing. Test plan: 1. Run `morbo bin/intranet` 2. Point your browser to what morbo says (should be localhost:3000) 3. Log in, and go to Administration » Libraries. This table uses the REST API, so if you see data in it, that means the API (and the patch) works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 07:19:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 06:19:25 +0000 Subject: [Koha-bugs] [Bug 29498] Remove usage of deprecated Mojolicious::Routes::Route::detour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 08:55:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 07:55:49 +0000 Subject: [Koha-bugs] [Bug 29493] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29493 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |koha-bugs at lists.koha-commun | |ity.org Group|Koha security | Component|Koha |Architecture, internals, | |and plumbing Product|Koha security |Koha QA Contact| |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 09:04:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 08:04:10 +0000 Subject: [Koha-bugs] [Bug 29270] Use flatpickr and futuredate on reserve/request.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29270 --- Comment #5 from Jonathan Druart --- Created attachment 127706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127706&action=edit Bug 29270: Expiration date must be in future -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 09:05:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 08:05:37 +0000 Subject: [Koha-bugs] [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 09:05:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 08:05:39 +0000 Subject: [Koha-bugs] [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 09:05:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 08:05:52 +0000 Subject: [Koha-bugs] [Bug 29270] Use flatpickr and futuredate on reserve/request.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29270 --- Comment #6 from Jonathan Druart --- (In reply to Jonathan Druart from comment #5) > Created attachment 127706 [details] [review] > Bug 29270: Expiration date must be in future Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 09:06:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 08:06:02 +0000 Subject: [Koha-bugs] [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 09:17:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 08:17:35 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #18 from Martin Renvoize --- Sorry dude.. I love this improvement.. but I think we have a problem. The new js equivalent to patron-name.inc is awesome and works great.. but it got me looking at what patron-name.inc does and threw me into the rabbit hole looking at how patrons get hidden from other branch staff in certain modes of operation. I can't see any handling, either in the js function or in the API response builder, that would filter out patrons that the logged-in user should not be able to see details for. I'm hopeful that I'm just missing something in the API layer as I think that's where it should sit personally.. we shouldn't expose the data at all if the user doesn't have permission to view it, rather than hide it at the view stage. If that functionality is there, any chance you could point me to the unit tests for it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 09:21:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 08:21:38 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 --- Comment #6 from Jonathan Druart --- Created attachment 127707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127707&action=edit Bug 29394: adjust request.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 09:34:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 08:34:26 +0000 Subject: [Koha-bugs] [Bug 29270] Use flatpickr and futuredate on reserve/request.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29270 --- Comment #7 from Jonathan Druart --- Created attachment 127708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127708&action=edit Bug 29270: start_for is actually date_to The attribute has been renamed in the meanwhile.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 09:36:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 08:36:20 +0000 Subject: [Koha-bugs] [Bug 29270] Use flatpickr and futuredate on reserve/request.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29270 --- Comment #8 from Jonathan Druart --- (In reply to Jonathan Druart from comment #7) > Created attachment 127708 [details] [review] > Bug 29270: start_for is actually date_to > > The attribute has been renamed in the meanwhile.. Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 09:47:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 08:47:26 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 --- Comment #7 from Jonathan Druart ---
    - + I think this is wrong, before this patchset we didn't have a "future" restriction on the renewal due date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 10:13:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 09:13:50 +0000 Subject: [Koha-bugs] [Bug 29241] Flatpickr not displaying date in the past for futuredate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29241 --- Comment #12 from Jonathan Druart --- Unfortunately there is a problem with this patch. The futuredate class add both minDate and allowInvalidPreload. It fix the original problem describes here, but it also permits the user to enter invalid (in the past) dates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 10:15:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 09:15:20 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #7 from Jonathan Druart --- There is a problem for futuredate, see bug 29241 comment 12. ie. you can click yesterday, the input is prefilled with yesterday's date when we should not accept dates in the past. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 10:56:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 09:56:58 +0000 Subject: [Koha-bugs] [Bug 29499] New: CheckMandatorySubfields don't work properly with select field in serials-edit.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29499 Bug ID: 29499 Summary: CheckMandatorySubfields don't work properly with select field in serials-edit.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: marion.durand at biblibre.com QA Contact: testopia at bugs.koha-community.org Since one of the patches of Bug 27526 (Bug 27526: Fix mandatory and important checks), CheckMandatorySubfields use the class "input_marceditor" but in the file serials-edit.tt this class is not set for all field (it is present on text input but not on select input). In consequence if a select field is set as mandatory, it is detected as missing even if it is filed and so you can't submit the form and receive the new serial. Test plan: 0- Be sure to be in a version of koha where the patch that introduces the bug is present (it is present in master since Jul 8 2021 (it is present in 21.06.00.046) and will be pushed in 21.11.00) 1- Create (or find) a subscription for a biblio record and select the option "Create an item record when receiving this serial" 2- Be sure to have at least one mandatory subfield that is filed with a select input in the framework used by the biblio record. (ex: 995$b, 995$c or 995$e in unimarc; 952$a, 952$b or 952$c in marc21) 3- From the subscription-detail page click on "Receive" 4- Change the status to "Arrived" and fill the item form that appears. 5- Click on "Save" and check that an error box appear with the message " Form not submitted because of the following problem(s) 1 mandatory fields empty (highlighted)" (the number can be different according to the number of concerned subfields) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:20:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:20:03 +0000 Subject: [Koha-bugs] [Bug 29500] New: Flatpickr accepting original date in the past for futuredate but also other dates in the past Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29500 Bug ID: 29500 Summary: Flatpickr accepting original date in the past for futuredate but also other dates in the past Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Staff Client Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 29241 was supposed to fix this but it didn't properly. We are accepting other dates in the past when we should only accept the original one (the one from the DB) AND dates in future. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:21:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:21:33 +0000 Subject: [Koha-bugs] [Bug 29499] CheckMandatorySubfields don't work properly with select field in serials-edit.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29499 --- Comment #1 from marion.durand at biblibre.com --- Created attachment 127709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127709&action=edit Bug 29499: CheckMandatorySubfields don't work properly with select field in serials-edit.tt Since one of the patches of BZ 27526 (Bug 27526: Fix mandatory and important checks), CheckMandatorySubfields use the class "input_marceditor" but in file serials-edit.tt this class is not set for all field (it is present on text input but not on select input) 5 9- Check that no error appear and that your item has been created. In consequence if a select field is set as mandatory, it is detected as missing even if it is filed and so you can't submit the form and receive the new serial. Test plan: 0- Be sure to be in a version of koha where the patch that introduces the bug is present (it is present in master since Jul 8 2021 (it is present in 21.06.00.046) and will be pushed in 21.11.00) 1- Create (or find) a subscription for a biblio record and select the option "Create an item record when receiving this serial" 2- Be sure to have at least one mandatory subfield that is filed with a select input in the framework used by the biblio record. (ex: 995$b, 995$c or 995$e in unimarc; 952$a, 952$b or 952$c in marc21) 3- From the subscription-detail page click on "Receive" 4- Change the status to "Arrived" and fill the item form that appears. 5- Click on "Save" 6- Check that an error box appear with the message " Form not submitted because of the following problem(s) 1 mandatory fields empty (highlighted)" (the number can be different according to the number of concerned subfields) 7- Apply the patch 8- Repeat step 3 to 5 9- Check that no error appear and that your item has been created -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:21:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:21:37 +0000 Subject: [Koha-bugs] [Bug 29241] Flatpickr not displaying date in the past for futuredate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29241 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29500 --- Comment #13 from Jonathan Druart --- (In reply to Jonathan Druart from comment #12) > Unfortunately there is a problem with this patch. The futuredate class add > both minDate and allowInvalidPreload. It fix the original problem describes > here, but it also permits the user to enter invalid (in the past) dates. See bug 29500. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29500 [Bug 29500] Flatpickr accepting original date in the past for futuredate but also other dates in the past -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:21:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:21:37 +0000 Subject: [Koha-bugs] [Bug 29500] Flatpickr accepting original date in the past for futuredate but also other dates in the past In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29500 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29241 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29241 [Bug 29241] Flatpickr not displaying date in the past for futuredate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:21:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:21:57 +0000 Subject: [Koha-bugs] [Bug 29499] CheckMandatorySubfields don't work properly with select field in serials-edit.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29499 marion.durand at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:22:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:22:29 +0000 Subject: [Koha-bugs] [Bug 29500] Flatpickr accepting original date in the past for futuredate but also other dates in the past In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29500 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29394 Blocks| |29478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 [Bug 29394] Remove flatpickr instantiations from .tt files https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 [Bug 29478] flatpickr misses quick shortcut to "Today" date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:22:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:22:29 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29500 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29500 [Bug 29500] Flatpickr accepting original date in the past for futuredate but also other dates in the past -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:22:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:22:29 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29500 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29500 [Bug 29500] Flatpickr accepting original date in the past for futuredate but also other dates in the past -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:25:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:25:00 +0000 Subject: [Koha-bugs] [Bug 29500] Flatpickr accepting original date in the past for futuredate but also other dates in the past In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29500 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:25:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:25:04 +0000 Subject: [Koha-bugs] [Bug 29500] Flatpickr accepting original date in the past for futuredate but also other dates in the past In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29500 --- Comment #1 from Jonathan Druart --- Created attachment 127710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127710&action=edit Bug 29500: Flatpickr - accept original date in the past and not others Bug 29241 was supposed to fix this but it didn't properly. We are accepting other dates in the past when we should only accept the original one (the one from the DB) AND dates in future. Test plan: Retry test plan for 29241 and confirm that you cannot set manually another date in the past. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:27:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:27:12 +0000 Subject: [Koha-bugs] [Bug 26912] Expired staff accounts can still log in to Koha staff intranet, SIP, API, etc. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26912 Ray Delahunty changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk --- Comment #9 from Ray Delahunty --- We use external authentication rather than using Koha authentication so if the removal of access were to be based on the Koha password, that would not work for us. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:29:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:29:25 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #1 from Martin Renvoize --- Created attachment 127711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127711&action=edit Bug 29495: Drop issue_id constraint from return_claims This patch removes the issue_id constraint from return_claims. Due to the nature of our dual table approach to checkouts/old_checkouts we can't safely hae this constraint and not lose data. Prior to this commit, when an item is checked in we move the checkout from checkouts to old_checkouts.. this therefore triggers the delete of the issue_id from the return_claims table as described by the foreign key constraint. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:29:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:29:28 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #2 from Martin Renvoize --- Created attachment 127712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127712&action=edit Bug 29495: DBIC Schema Rebuild -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:29:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:29:32 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #3 from Martin Renvoize --- Created attachment 127713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127713&action=edit Bug 29495: Add DBIC relationships back into Schema This patch adds the relationship accessors back into the affected Schema classes, now below the fold so they are retained during dbic rebuilds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:29:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:29:35 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #4 from Martin Renvoize --- Created attachment 127714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127714&action=edit Bug 29495: Add code level constraint replacement This patch adds a check in Koha::Checkouts::ReturnClaim::store to replace the database level foreign key check. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:31:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:31:11 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 --- Comment #8 from Jonathan Druart --- Created attachment 127715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127715&action=edit Bug 29394: Remove futuredate for renew -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:32:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:32:03 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:32:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:32:10 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:32:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:32:16 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:32:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:32:37 +0000 Subject: [Koha-bugs] [Bug 29501] New: gather_print_notices.pl does not use SMTP servers Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29501 Bug ID: 29501 Summary: gather_print_notices.pl does not use SMTP servers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Bug 22343 added the ability to specify SMTP servers for outgoing email, removing the need to run an MTA (like postfix) on the server. As far as I can tell, gather_print_notices.pl does it's own email sending with MIME::Lite, bypassing the message_queue and the SMTP server setup. So in order to use this as a cronjob to send print as email, you have to run an MTA anyway. Could this be fixed, so the script uses the SMTP server setup? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:32:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:32:49 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |nick at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:48:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:48:05 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 --- Comment #9 from Jonathan Druart --- (In reply to Owen Leonard from comment #5) > One problem I wasn't able to understand: If you configure an input with the > "pastdate" or "pastinclusive" option AND enable the time picker the > defaultHour and defaultMinute options are lost. I think that's because because TODAY 23:59 is in the future :-/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:51:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:51:26 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127683|0 |1 is obsolete| | Attachment #127700|0 |1 is obsolete| | Attachment #127707|0 |1 is obsolete| | Attachment #127715|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 127716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127716&action=edit Bug 29394: Remove flatpickr instantiations from most of the tt files We must reduce the instantiations as much as possible to take advantages of the default values and specific behaviours we have defined in calendar.inc This patch is suggesting to have a .flatpickr class and using the data attributes: - flatpickr-futuredate - flatpickr-pastdate - flatpickr-enable-time - flatpickr-on-close-focus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:51:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:51:30 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 --- Comment #11 from Jonathan Druart --- Created attachment 127717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127717&action=edit Bug 29394: (follow-up) Pass correct time format and other corrections This patch makes a few corrections, including adding the correct Flatpickr date format option when the timepicker is enabled. Besides past and future date options, I've added a "pastinclusive" option which allows dates in the past OR today. This option was previously applied to the checkin page. The patch also corrects a couple of places where the wrong date field was modified with the new data attributes. To test, apply the patch and test the datepickers on the batch checkout and renew pages. When you select a date and time the "TimeFormat" system preference should be correctly applied. The calendar widget on the checkin page should allow you to select today's date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:51:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:51:34 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 --- Comment #12 from Jonathan Druart --- Created attachment 127718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127718&action=edit Bug 29394: adjust request.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:51:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:51:38 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 --- Comment #13 from Jonathan Druart --- Created attachment 127719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127719&action=edit Bug 29394: Remove futuredate for renew -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:52:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:52:03 +0000 Subject: [Koha-bugs] [Bug 29500] Flatpickr accepting original date in the past for futuredate but also other dates in the past In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29500 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127710|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 127720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127720&action=edit Bug 29500: Flatpickr - accept original date in the past and not others Bug 29241 was supposed to fix this but it didn't properly. We are accepting other dates in the past when we should only accept the original one (the one from the DB) AND dates in future. Test plan: Retry test plan for 29241 and confirm that you cannot set manually another date in the past. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:52:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:52:35 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127676|0 |1 is obsolete| | Attachment #127694|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 127721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127721&action=edit Bug 29478: Flatpickr - Restore 'Today' button It's not implemented, looks like we need to use a plugin for that https://github.com/flatpickr/flatpickr/issues/576 https://github.com/jcsmorais/shortcut-buttons-flatpickr Test plan: Confirm that flatpickr instances now have a yesterday, today and tomorrow buttons. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:52:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:52:39 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #9 from Jonathan Druart --- Created attachment 127722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127722&action=edit Bug 29478: (follow-up) Provide default style for shortcut buttons This patch adds some CSS to _flatpickr.scss in order to give a deafult style to the "yesterday," "today," and "tomorrow" controls added by the shortcut plugin. A missed translatable string is now wrapped in the __() function: __("or"). The patch also updates the date calculation for those shortcuts to use Flatpickr's date calculation shorthand. This isn't strictly necessary but I think it makes the code more readable. To test, apply the patch and build the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). In the staff client, view some pages with date-picker widgets. A calendar widget time selection: - Circulation -> Check out -> Checkout settings -> Select date: - The calendar widget should have "yesterday," "today," and "tomorrow" controls styled like links appearing after the time selector. The controls should be centered, with the "or" label on the same line. A calendar widget without time selection: - Tools -> Log viewer -> Display from. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:59:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:59:33 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127716|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 127723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127723&action=edit Bug 29394: Remove flatpickr instantiations from most of the tt files We must reduce the instantiations as much as possible to take advantages of the default values and specific behaviours we have defined in calendar.inc This patch is suggesting to have a .flatpickr class and using the data attributes: - flatpickr-futuredate - flatpickr-pastdate - flatpickr-enable-time - flatpickr-on-close-focus Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:59:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:59:37 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127717|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 127724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127724&action=edit Bug 29394: (follow-up) Pass correct time format and other corrections This patch makes a few corrections, including adding the correct Flatpickr date format option when the timepicker is enabled. Besides past and future date options, I've added a "pastinclusive" option which allows dates in the past OR today. This option was previously applied to the checkin page. The patch also corrects a couple of places where the wrong date field was modified with the new data attributes. To test, apply the patch and test the datepickers on the batch checkout and renew pages. When you select a date and time the "TimeFormat" system preference should be correctly applied. The calendar widget on the checkin page should allow you to select today's date. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:59:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:59:40 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127718|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize --- Created attachment 127725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127725&action=edit Bug 29394: adjust request.tt Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 11:59:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 10:59:44 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127719|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 127726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127726&action=edit Bug 29394: Remove futuredate for renew Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 12:06:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 11:06:55 +0000 Subject: [Koha-bugs] [Bug 26912] Expired staff accounts can still log in to Koha staff intranet, SIP, API, etc. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26912 --- Comment #10 from gclg --- Perhaps the option to temporary restrict accounts which access the staff client would the preferred priority. There are probably numerous requirements for non Library staff/patrons which would be almost impossible to standardise. As mentioned the only way around limiting accounts which access the client is to remove the ability to log in via the permissions. I'd be interested to see where this sits with Cyber Essentials/internal auditing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 12:09:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 11:09:11 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29495 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 12:09:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 11:09:11 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28854 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 12:27:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 11:27:11 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 12:27:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 11:27:15 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #24 from Jonathan Druart --- Created attachment 127727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127727&action=edit Bug 29341: Remove foreign keys on pseudonymized_transactions Behave like the statistics table and don't remove the code even if the branch or patron's category is removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 12:27:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 11:27:42 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127350|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 12:30:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 11:30:36 +0000 Subject: [Koha-bugs] [Bug 27259] HomeOrHoldingBranch is not used in all places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27259 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 12:39:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 11:39:02 +0000 Subject: [Koha-bugs] [Bug 500] [INTRANET]Only 21 items are displayed in the search result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=500 --- Comment #2 from Katrin Fischer --- (In reply to Minerva.hernández from comment #1) > No permite desplegar la plantilla de catalogación, así como no recupera la > información y cuando migro en protocolo z39.50 no me permite guardar la > información Hi Minerva, please file a new bug in English or ask on the Spanish speaking mailing list: https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-es -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 12:39:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 11:39:36 +0000 Subject: [Koha-bugs] [Bug 29481] Terminology: Collection code, call number: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29481 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 12:39:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 11:39:39 +0000 Subject: [Koha-bugs] [Bug 29481] Terminology: Collection code, call number: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29481 --- Comment #1 from Owen Leonard --- Created attachment 127728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127728&action=edit Bug 29481: Terminology: Collection code, call number This patch corrects an instance of the phrase "Collection code," replacing it with the standard "Collection." To test, apply the patch and restart services. - In the staff interface, go to Administration -> System preferences and set the OpacItemLocation preference to "library, collection code, and call number." - In the OPAC, search the catalog using a term which will return multiple results. - In the search results, item descriptions in the "Availability" line should read like this: [Collection, call number: Non-fiction 394.2663 Bu] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 12:44:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 11:44:45 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #25 from Katrin Fischer --- (In reply to Jonathan Druart from comment #23) > Sonia confirmed me that it's ok to keep the branchcode and so remove the FK. > > I personally still don't think it's a good idea, but I understand the use > case. > > This is also a bad use case: > Create branch CPL, for testing purpose (hey you just installed the software > and want to try it) > Do some stuffs, it will create stats entries > Remove CPL to start from scratch and clean state > Reuse CPL as branchcode > Stats are accumulating using the test data > > I will provide an alternate patch tomorrow if nobody beats me to it. I feel like most people might have a test system or would be able to differentiate by timestamp in that case. My feeling is, that this would not be a big issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 12:45:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 11:45:21 +0000 Subject: [Koha-bugs] [Bug 29343] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29343 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://www.7qasearch.net/b | |log/how-to-increase-cash-ap | |p-withdrawal-limit/ | Keywords|cookie | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 12:52:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 11:52:34 +0000 Subject: [Koha-bugs] [Bug 29455] 505$t - change in line break/display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29455 --- Comment #4 from Katrin Fischer --- Maybe this could be a compromise: we check for existence of $g, if there are no $g we break before each $t. Would that work Sara? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 14:05:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 13:05:13 +0000 Subject: [Koha-bugs] [Bug 29502] New: Possibility of changing the database engine to avoid errors in autoincremental fields Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29502 Bug ID: 29502 Summary: Possibility of changing the database engine to avoid errors in autoincremental fields Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: jcautomatizacion at gmail.com QA Contact: testopia at bugs.koha-community.org Hi, A few days ago a reboot of the DB server was carried out due to a failure, this caused Koha to present a failure in incremental fields and they began to duplicate record id, specifically in reservations. Is there a possibility to change the database engine to avoid errors of autoincremental fields when failures happen in the DB server? Thanks for the help. Jonathan Cúellar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 14:21:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 13:21:09 +0000 Subject: [Koha-bugs] [Bug 10762] Not able to adjust size of barcode numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 --- Comment #7 from Jérémy Breuillard --- Created attachment 127729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127729&action=edit Bug 10762: Change the size of barcodes in label creator Test plan: 1)Home > Tools > Label creator > Manage Layout or New Layout 2)Make a new layout or edit an existing one 3)Notice the 2 new fields "Barcode width/Barcode height" 4)Save it like this 5)Create a batch of barcode and export if in PDF 6)Notice the size of barcode 7)Go back to your existing layout 8)Enter some values (Barcode width: 1.6 / Barcode height: 0.04), save 9)Take back your batch of barcode and export it in PDF 10)The barcode should be 2x bigger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 14:22:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 13:22:20 +0000 Subject: [Koha-bugs] [Bug 10762] Not able to adjust size of barcode numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jeremy.breuillard at biblibre. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 15:12:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 14:12:53 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- DB update should use primary_key_exists so it is idempotent. The last patch could add claim object methods that use something like return Koha::Checkouts->new_from_dbic( $self->_result->issue ) to allow prefetching, but I don't think that's absolutely necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 15:19:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 14:19:04 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #10 from Jonathan Druart --- Created attachment 127730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127730&action=edit Bug 29478: Today should select now for pastinclusive If Today is clicked when we only allow dates in the past and today/now, we should select the current date/time We need to update the maxDate to make it up-to-date, or the maxDate may be set to the minute before and clicking Today will blank the input. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 15:19:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 14:19:45 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #11 from Jonathan Druart --- Last patch fixes a bug, however it does not restore the 23:59 time part when another date is selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 15:21:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 14:21:42 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #52 from Katrin Fischer --- This was originally found in 20.11 - problem exists there for sure. Is it possible to backport? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 15:34:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 14:34:39 +0000 Subject: [Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |blocker CC| |jonathan.druart+koha at gmail. | |com Status|NEW |ASSIGNED Keywords| |rel_21_11_candidate Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Depends on| |27526 --- Comment #1 from Jonathan Druart --- Caused by commit 6ed29bccef590a1bc5e4cea175b41b8024483320 Bug 27526: Fix mandatory and important checks Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 15:34:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 14:34:39 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29496 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 [Bug 29496] can't save an order with mandatory items subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 15:49:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 14:49:26 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Florian changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |florian.bontemps at biblibre.c | |om --- Comment #22 from Florian --- Would like to sign off, should I use the test plan in bug 21932 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 15:50:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 14:50:50 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 15:50:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 14:50:53 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #5 from Nick Clemens --- Created attachment 127731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127731&action=edit Bug 29043: Don't load items unless a p[atron has been chosen on request.pl This patch moves the code that we sh9ould run if there is no patron to the head of the biblio loop. If we have no patron we execute this and go to the next loop. A few variables that were being passed to the template in the loop are moved outside - no reason to overwrite each loop To test: 1 - Browse to a bib in the staff client 2 - Click on the holds tab 3 - Note loading time 4 - Add 500 items to bib 5 - Note loading time - it takes longer 6 - Note items are not displayed 7 - Apply patch 8 - Reload page - is much faster 9 - Find/choose a patron 10 - Confirm items are loaded correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 15:50:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 14:50:56 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #6 from Nick Clemens --- Created attachment 127732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127732&action=edit Bug 29043: Prune dead code Remove sort_borrowerlist as it was not used Remove "time" for form name I don't see nay reason we needed this Remove messagetransfert from template Never passed in code Remove totalcount variable Assigned and never referenced Remove 'alreadyres'/'alreadyreserved' from template All references in coide were in template - never set or passed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 15:51:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 14:51:51 +0000 Subject: [Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 15:51:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 14:51:55 +0000 Subject: [Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #2 from Jonathan Druart --- Created attachment 127733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127733&action=edit Bug 29496: (bug 27526 follow-up) Fix item form validation The validation of the forms were blocked with "X item mandatory fields empty" when at least one dropdown list subfield was marked as mandatory. We need to add the 'input_marceditor' class to the select (does it actually make sense? select vs input...) Caused by commit 6ed29bccef590a1bc5e4cea175b41b8024483320 Bug 27526: Fix mandatory and important checks Which lamentably failed as it was stating: "Using .input_marceditor let us fix the additem.tt form and prevent to break the other ones" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 16:22:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 15:22:23 +0000 Subject: [Koha-bugs] [Bug 29504] New: Confirm Item Parts requires Force Checkout permission Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Bug ID: 29504 Summary: Confirm Item Parts requires Force Checkout permission Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com With bug 25261, CircConfirmItemParts system preference was added, which is highly popular with libraries. However, it requires staff to have the permission "Force checkout if a limitation exists (force_checkout)". This is a permission that many staff do not have. When a staff member without the Force permission attempts to checkout an item with a 952$3, they get a yellow box stating: Please confirm checkout Please confirm that the accompanying materials are present: check for 12 CDs The only option given is the Continue button (with a red X) and when clicked, the item does not get checked out. To replicate: 1. Set a staff member with circ permissions, but not FORCE_CHECKOUT 2. Turn on CircConfirmItemParts 3. Log in as staff member in step 1 4. Attempt to checkout an item with a 952$3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 16:31:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 15:31:18 +0000 Subject: [Koha-bugs] [Bug 29491] Improve display of notices in patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 17:15:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 16:15:46 +0000 Subject: [Koha-bugs] [Bug 29505] New: Add syspref to allow to place multiple holds on same item Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29505 Bug ID: 29505 Summary: Add syspref to allow to place multiple holds on same item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 17:19:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 16:19:03 +0000 Subject: [Koha-bugs] [Bug 29505] Add syspref to allow to place multiple holds on same item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29505 --- Comment #1 from Julian Maurice --- Created attachment 127734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127734&action=edit Bug 29505: Add syspref to allow to place multiple holds on same item Test plan: 1. Run installer/data/mysql/updatedatabase.pl 2. Enable syspref AllowMultipleHoldsOnSameItem 3. Try to place multiple holds for the same patron on the same item. Unless another circulation rule forbid this (like the maximum number of holds per record), it should work 4. Run `prove t/db_dependent/Holds/AllowMultipleHoldsOnSameItem.t` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 17:19:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 16:19:26 +0000 Subject: [Koha-bugs] [Bug 29505] Add syspref to allow to place multiple holds on same item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29505 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 17:50:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 16:50:01 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #7 from Martin Renvoize --- Created attachment 127739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127739&action=edit Bug 29457: Database update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 17:51:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 16:51:09 +0000 Subject: [Koha-bugs] [Bug 29491] Improve display of notices in patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 17:51:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 16:51:12 +0000 Subject: [Koha-bugs] [Bug 29491] Improve display of notices in patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 --- Comment #2 from Owen Leonard --- Created attachment 127740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127740&action=edit Bug 29491: Improve display of notices in patron details This patch updates the patron notices list so that notices are shown in a modal dialog instead of inline in the table. The "Resend" button is shown in the modal window controls. To test, apply the patch and locate a patron in the staff interface with multiple sent notices. - View the patron's "Notices" tab. - In the table of notices, click one of the notice titles. - A modal window should appear with the notice subject as the header and the notice content in the main body of the modal. - If the message has any other status than 'pending' there should be a "Resend" button in the modal footer. Confirm that it submits the form and resends the correct message. - Try viewing multiple notices to confirm that the contents of the modal are correctly updated for each message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 17:51:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 16:51:30 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #8 from Martin Renvoize --- My database update works.. though I'm sure it could be refined. But.. it's not idempotent and I'm not sure how to fix that or whether it matters now we have the new DB update system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 17:53:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 16:53:45 +0000 Subject: [Koha-bugs] [Bug 29491] Improve display of notices in patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 --- Comment #3 from Martin Renvoize --- Sorry Owen.. I get sha1 issues trying to apply this patch :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 18:04:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 17:04:15 +0000 Subject: [Koha-bugs] [Bug 29491] Improve display of notices in patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127740|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 127741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127741&action=edit Bug 29491: (preparatory step) Reindent template Step 1: Replace tabs with spaces and reindent. This patch should include only whitespace changes. If you view the diff while ignoring whitespace there should be no changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 18:04:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 17:04:18 +0000 Subject: [Koha-bugs] [Bug 29491] Improve display of notices in patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 --- Comment #5 from Owen Leonard --- Created attachment 127742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127742&action=edit Bug 29491: Improve display of notices in patron details This patch updates the patron notices list so that notices are shown in a modal dialog instead of inline in the table. The "Resend" button is shown in the modal window controls. To test, apply the patch and locate a patron in the staff interface with multiple sent notices. - View the patron's "Notices" tab. - In the table of notices, click one of the notice titles. - A modal window should appear with the notice subject as the header and the notice content in the main body of the modal. - If the message has any other status than 'pending' there should be a "Resend" button in the modal footer. Confirm that it submits the form and resends the correct message. - Try viewing multiple notices to confirm that the contents of the modal are correctly updated for each message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 18:29:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 17:29:04 +0000 Subject: [Koha-bugs] [Bug 29506] New: objects.search should call search_limited if present Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 Bug ID: 29506 Summary: objects.search should call search_limited if present Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 18:29:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 17:29:56 +0000 Subject: [Koha-bugs] [Bug 29506] objects.search should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Depends on| |29503 --- Comment #1 from Tomás Cohen Arazi --- We should use it internally to avoid any leaks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 18:34:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 17:34:35 +0000 Subject: [Koha-bugs] [Bug 29507] New: Speed up auto renew cronjob via parallel processing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29507 Bug ID: 29507 Summary: Speed up auto renew cronjob via parallel processing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 18:35:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 17:35:03 +0000 Subject: [Koha-bugs] [Bug 29507] Speed up auto renew cronjob via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29507 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 18:35:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 17:35:06 +0000 Subject: [Koha-bugs] [Bug 29507] Speed up auto renew cronjob via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29507 --- Comment #1 from Nick Clemens --- Created attachment 127743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127743&action=edit Bug 28833: Speed up auto renew cronjob via parallel processing The cron can take a very long time to run on systems with many issues. For example, a partner with ~250k auto_renew issues is taking about 9 hours to run. If we run that same number of holds in 5 parallel chunks ( splitting the number of issues as evenly as possible, it could take under 2 hours. Test Plan: 0) Install the Perl library Parallel::ForkManager 1) Generate a number of issues marked for auto_renew 2) Run the automatic_renewals.pl, use the `time` utility to track how much time it took to run 3) Set parallel_loops to 10 in auto_renew_cronjob section of config in koha-conf 4) Repeat step 2, note the improvement in speed 5) Experiment with other values -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 18:45:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 17:45:32 +0000 Subject: [Koha-bugs] [Bug 29507] Speed up auto renew cronjob via parallel processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29507 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127743|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 127744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127744&action=edit Bug 29057: Speed up auto renew cronjob via parallel processing The cron can take a very long time to run on systems with many issues. For example, a partner with ~250k auto_renew issues is taking about 9 hours to run. If we run that same number of holds in 5 parallel chunks ( splitting the number of issues as evenly as possible, it could take under 2 hours. Test Plan: 0) Install the Perl library Parallel::ForkManager 1) Generate a number of issues marked for auto_renew 2) Run the automatic_renewals.pl, use the `time` utility to track how much time it took to run 3) Set parallel_loops to 10 in auto_renew_cronjob section of config in koha-conf 4) Repeat step 2, note the improvement in speed 5) Experiment with other values -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 18:52:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 17:52:09 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #53 from Michael Hafen --- Created attachment 127745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127745&action=edit 20.11.x: Bug 28870: Regression tests cherry-pick applied clean for all patches. So here's a backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 18:52:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 17:52:56 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #54 from Michael Hafen --- Created attachment 127746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127746&action=edit 20.11.x: Bug 28870: Use Email::Address to validate email addresses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 18:53:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 17:53:22 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #55 from Michael Hafen --- Created attachment 127747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127747&action=edit 20.11.x: Bug 28870: Remove traces of Email::Valid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 18:53:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 17:53:52 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #56 from Michael Hafen --- Created attachment 127748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127748&action=edit 20.11.x: Bug 28870: Move email address validation to a specific class method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 18:54:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 17:54:23 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #57 from Michael Hafen --- Created attachment 127749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127749&action=edit 20.11.x: Bug 28870: Use Email::Address->parse -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 18:54:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 17:54:51 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #58 from Michael Hafen --- Created attachment 127750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127750&action=edit 20.11.x: Bug 28870: non-FQDN addresses are valid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 19:01:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 18:01:28 +0000 Subject: [Koha-bugs] [Bug 29506] objects.search should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 127751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127751&action=edit Bug 29506: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 19:01:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 18:01:34 +0000 Subject: [Koha-bugs] [Bug 29506] objects.search should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 127752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127752&action=edit Bug 29506: Make objects.search call search_limited if present This patch makes objects.search implicitly update the passed *$result_set* to use search_limited. This way no object leaks could happen without noticing. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => FAIL: Tests fail because search_limited is not used 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Results are correctly filtered based on userenv! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 19:01:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 18:01:39 +0000 Subject: [Koha-bugs] [Bug 29506] objects.search should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 127753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127753&action=edit Bug 29506: (follow-up) Adapt GET /patrons This patch makes GET /patrons rely on this new behavior from the objects.search helper. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 19:01:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 18:01:56 +0000 Subject: [Koha-bugs] [Bug 29506] objects.search should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 20:39:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 19:39:01 +0000 Subject: [Koha-bugs] [Bug 29508] GET /patrons/:patron_id should use Koha::Patrons->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29508 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Koha |REST API Group|Koha security | Assignee|chris at bigballofwax.co.nz |koha-bugs at lists.koha-commun | |ity.org Product|Koha security |Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 20:39:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 19:39:40 +0000 Subject: [Koha-bugs] [Bug 29508] GET /patrons/:patron_id should use Koha::Patrons->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29508 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29506 Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Severity|major |minor Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 [Bug 29506] objects.search should call search_limited if present -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 20:39:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 19:39:40 +0000 Subject: [Koha-bugs] [Bug 29506] objects.search should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29508 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29508 [Bug 29508] GET /patrons/:patron_id should use Koha::Patrons->search_limited -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 20:40:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 19:40:06 +0000 Subject: [Koha-bugs] [Bug 29506] objects.search should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 20:40:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 19:40:11 +0000 Subject: [Koha-bugs] [Bug 29464] Sorting broken for receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Abbey Holt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aholt at dubuque.lib.ia.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 20:40:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 19:40:39 +0000 Subject: [Koha-bugs] [Bug 29506] objects.search should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127751|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 127754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127754&action=edit Bug 29506: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 20:40:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 19:40:42 +0000 Subject: [Koha-bugs] [Bug 29506] objects.search should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127752|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 127755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127755&action=edit Bug 29506: Make objects.search call search_limited if present This patch makes objects.search implicitly update the passed *$result_set* to use search_limited. This way no object leaks could happen without noticing. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => FAIL: Tests fail because search_limited is not used 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Results are correctly filtered based on userenv! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 20:40:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 19:40:45 +0000 Subject: [Koha-bugs] [Bug 29506] objects.search should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127753|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 127756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127756&action=edit Bug 29506: (follow-up) Adapt GET /patrons This patch makes GET /patrons rely on this new behavior from the objects.search helper. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 20:40:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 19:40:49 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 20:42:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 19:42:14 +0000 Subject: [Koha-bugs] [Bug 29509] New: GET /patrons* routes permissions excessive Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509 Bug ID: 29509 Summary: GET /patrons* routes permissions excessive Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com The routes require full borrowers permissions, and that's not the case for Koha, generally. If required permissions were to be lowered, bug 29503 should be pushed first. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 20:42:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 19:42:26 +0000 Subject: [Koha-bugs] [Bug 29509] GET /patrons* routes permissions excessive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29503 Status|NEW |In Discussion Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 20:42:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 19:42:45 +0000 Subject: [Koha-bugs] [Bug 29509] GET /patrons* routes permissions excessive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 20:44:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 19:44:25 +0000 Subject: [Koha-bugs] [Bug 29506] objects.search should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #8 from Martin Renvoize --- Nice future-proofing here.. tests all make sense and pass.. including the /patrons regression test introduced in the prior bug. Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 20:45:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 19:45:14 +0000 Subject: [Koha-bugs] [Bug 29508] GET /patrons/:patron_id should use Koha::Patrons->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29508 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 127757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127757&action=edit Bug 29508: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 20:45:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 19:45:18 +0000 Subject: [Koha-bugs] [Bug 29508] GET /patrons/:patron_id should use Koha::Patrons->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29508 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 127758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127758&action=edit Bug 29508: Make GET /patrons/:patron_id use Koha::Patrons->search_limited This patch makes the route return 404 if the user is not allowed to see the requested patron information. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: The code doesn't respect limits 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 22:01:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 21:01:09 +0000 Subject: [Koha-bugs] [Bug 29510] New: objects.find should call search_limited if present Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29510 Bug ID: 29510 Summary: objects.find should call search_limited if present Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 22:01:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 21:01:47 +0000 Subject: [Koha-bugs] [Bug 29510] objects.find should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29510 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Depends on| |29508 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29508 [Bug 29508] GET /patrons/:patron_id should use Koha::Patrons->search_limited -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 22:01:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 21:01:47 +0000 Subject: [Koha-bugs] [Bug 29508] GET /patrons/:patron_id should use Koha::Patrons->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29508 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29510 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29510 [Bug 29510] objects.find should call search_limited if present -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 22:11:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 21:11:31 +0000 Subject: [Koha-bugs] [Bug 29510] objects.find should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29510 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 127759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127759&action=edit Bug 29510: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 22:11:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 21:11:37 +0000 Subject: [Koha-bugs] [Bug 29510] objects.find should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29510 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 127760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127760&action=edit Bug 29510: Make objects.find call search_limited if present This patch makes objects.find implicitly update the passed *$result_set* to use search_limited. This way no object leaks could happen without noticing. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => FAIL: Tests fail because search_limited is not used 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Results are correctly filtered based on userenv! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 22:11:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 21:11:42 +0000 Subject: [Koha-bugs] [Bug 29510] objects.find should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29510 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 127761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127761&action=edit Bug 29510: (follow-up) Adapt GET /patrons/:patron_id This patch makes GET /patrons/:patron_id rely on this new behavior from the objects.find helper. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 22:12:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 21:12:24 +0000 Subject: [Koha-bugs] [Bug 29509] GET /patrons* routes permissions excessive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29503 |29506, 29510 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 [Bug 29506] objects.search should call search_limited if present https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29510 [Bug 29510] objects.find should call search_limited if present -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 22:12:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 21:12:24 +0000 Subject: [Koha-bugs] [Bug 29506] objects.search should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29509 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509 [Bug 29509] GET /patrons* routes permissions excessive -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 22:12:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 21:12:24 +0000 Subject: [Koha-bugs] [Bug 29510] objects.find should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29510 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29509 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509 [Bug 29509] GET /patrons* routes permissions excessive -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 22:16:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 21:16:35 +0000 Subject: [Koha-bugs] [Bug 29509] GET /patrons* routes permissions excessive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |katrin.fischer at bsz-bw.de, | |nick at bywatersolutions.com --- Comment #1 from Tomás Cohen Arazi --- Based on moremember.pl we could do { borrowers => 'edit_borrowers' }. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 22:54:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 21:54:57 +0000 Subject: [Koha-bugs] [Bug 29511] New: While editing MARC records, subfields appear in varying order Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29511 Bug ID: 29511 Summary: While editing MARC records, subfields appear in varying order Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: valerie at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 127762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127762&action=edit 245 blank subfields not in order Edit the MARC record 245. Blank subfields appear in inconsistent order. Expected order: 245 a,b,c,h Default framework order: 245 a,b,c,h Different records with only a subfield a have the following order: 245 a,c,h,b 245 a,h,c,b 245 a,b,c,h Record with subfield a,c may appear as: 245 a,c,b,h 245 a,a,h,b Field 300 is also noted to have different blank subfield orders for different records. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 22:55:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 21:55:45 +0000 Subject: [Koha-bugs] [Bug 29511] While editing MARC records, subfields appear in varying order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29511 --- Comment #1 from Valerie --- Created attachment 127763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127763&action=edit 245 blank subfields in different order -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 23:24:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 22:24:20 +0000 Subject: [Koha-bugs] [Bug 29420] 401 Unauthorized pages come back as 200 OK under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 --- Comment #4 from Liz Rea --- It does not stop it from working, it shows the error page under the login screen for 401's. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 23:26:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 22:26:54 +0000 Subject: [Koha-bugs] [Bug 29420] 401 Unauthorized pages come back as 200 OK under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 --- Comment #5 from Tomás Cohen Arazi --- Do we really need to pass error pages through CGI/Perl? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 23:40:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 22:40:45 +0000 Subject: [Koha-bugs] [Bug 29420] 401 Unauthorized pages come back as 200 OK under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 --- Comment #6 from David Cook --- (In reply to Liz Rea from comment #4) > It does not stop it from working, it shows the error page under the login > screen for 401's. Hmm weird. I have no idea then without testing and digging in (which I don't have time for at the moment). If there are any issues, I can find them later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 23:41:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 22:41:06 +0000 Subject: [Koha-bugs] [Bug 29420] 401 Unauthorized pages come back as 200 OK under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 --- Comment #7 from David Cook --- (In reply to Tomás Cohen Arazi from comment #5) > Do we really need to pass error pages through CGI/Perl? You mean instead of using static HTML pages or...? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 17 23:42:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Nov 2021 22:42:26 +0000 Subject: [Koha-bugs] [Bug 26912] Expired staff accounts can still log in to Koha staff intranet, SIP, API, etc. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26912 --- Comment #11 from David Cook --- (In reply to Ray Delahunty from comment #9) > We use external authentication rather than using Koha authentication so if > the removal of access were to be based on the Koha password, that would not > work for us. That's a good point. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 02:25:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 01:25:54 +0000 Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #38 from David Cook --- This is just an aside but "unlimited nesting of sub-permissions" sounds like it would be difficult to maintain and process, but maybe I'm misunderstanding the proposal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 02:28:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 01:28:34 +0000 Subject: [Koha-bugs] [Bug 28702] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28702 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 08:02:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 07:02:55 +0000 Subject: [Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of stopping zebrasrv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885 Natsagdorj changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |natsagdorj at msue.edu.mn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 08:03:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 07:03:36 +0000 Subject: [Koha-bugs] [Bug 29512] New: zebrasrv -v none, fatal, warn -k 1024 -f /etc/koha/sites/library/koha-conf.xml Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29512 Bug ID: 29512 Summary: zebrasrv -v none, fatal, warn -k 1024 -f /etc/koha/sites/library/koha-conf.xml Change sponsored?: --- Product: Koha Version: 21.05 Hardware: PC OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Websites, Mailing Lists, etc Assignee: wizzyrea at gmail.com Reporter: natsagdorj at msue.edu.mn QA Contact: testopia at bugs.koha-community.org Created attachment 127764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127764&action=edit picture zebrasrv -v none, fatal, warn -k 1024 -f /etc/koha/sites/library/koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 08:45:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 07:45:06 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127711|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 127765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127765&action=edit Bug 29495: Drop issue_id constraint from return_claims This patch removes the issue_id constraint from return_claims. Due to the nature of our dual table approach to checkouts/old_checkouts we can't safely hae this constraint and not lose data. Prior to this commit, when an item is checked in we move the checkout from checkouts to old_checkouts.. this therefore triggers the delete of the issue_id from the return_claims table as described by the foreign key constraint. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 08:45:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 07:45:10 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127712|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 127766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127766&action=edit Bug 29495: DBIC Schema Rebuild -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 08:45:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 07:45:13 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127713|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 127767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127767&action=edit Bug 29495: Add DBIC relationships back into Schema This patch adds the relationship accessors back into the affected Schema classes, now below the fold so they are retained during dbic rebuilds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 08:45:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 07:45:17 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127714|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 127768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127768&action=edit Bug 29495: Add code level constraint replacement This patch adds a check in Koha::Checkouts::ReturnClaim::store to replace the database level foreign key check. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 08:45:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 07:45:21 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #10 from Martin Renvoize --- Created attachment 127769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127769&action=edit Bug 29495: Update relationship methods This patch updates the relationship methods found in Koha::Checkouts::ReturnClaim so that they are prefetchable and embeddable on the API. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 08:46:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 07:46:15 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #11 from Martin Renvoize --- Thanks for the review Kyle.. I've implemented the requested improvements now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 08:52:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 07:52:14 +0000 Subject: [Koha-bugs] [Bug 29508] GET /patrons/:patron_id should use Koha::Patrons->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29508 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127757|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 127770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127770&action=edit Bug 29508: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 08:52:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 07:52:18 +0000 Subject: [Koha-bugs] [Bug 29508] GET /patrons/:patron_id should use Koha::Patrons->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29508 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127758|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 127771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127771&action=edit Bug 29508: Make GET /patrons/:patron_id use Koha::Patrons->search_limited This patch makes the route return 404 if the user is not allowed to see the requested patron information. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: The code doesn't respect limits 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 08:52:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 07:52:49 +0000 Subject: [Koha-bugs] [Bug 29508] GET /patrons/:patron_id should use Koha::Patrons->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29508 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize --- Great work going through all this Tomas! Works as expected, tests are thorough and passing. Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 08:56:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 07:56:11 +0000 Subject: [Koha-bugs] [Bug 29510] objects.find should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29510 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127759|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 127772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127772&action=edit Bug 29510: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 08:56:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 07:56:15 +0000 Subject: [Koha-bugs] [Bug 29510] objects.find should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29510 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127760|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 127773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127773&action=edit Bug 29510: Make objects.find call search_limited if present This patch makes objects.find implicitly update the passed *$result_set* to use search_limited. This way no object leaks could happen without noticing. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => FAIL: Tests fail because search_limited is not used 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Results are correctly filtered based on userenv! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 08:56:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 07:56:18 +0000 Subject: [Koha-bugs] [Bug 29510] objects.find should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29510 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127761|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 127774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127774&action=edit Bug 29510: (follow-up) Adapt GET /patrons/:patron_id This patch makes GET /patrons/:patron_id rely on this new behavior from the objects.find helper. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 08:56:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 07:56:37 +0000 Subject: [Koha-bugs] [Bug 29510] objects.find should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29510 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize --- Nice work.. signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 08:57:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 07:57:54 +0000 Subject: [Koha-bugs] [Bug 29509] GET /patrons* routes permissions excessive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509 --- Comment #2 from Martin Renvoize --- I wondering how our changes to objects.search and objects.find might affect public routes and seeing ones owned data? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 09:03:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 08:03:17 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 09:06:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 08:06:06 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #23 from Jonathan Druart --- (In reply to Florian from comment #22) > Would like to sign off, should I use the test plan in bug 21932 ? Yes, that should work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 09:08:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 08:08:10 +0000 Subject: [Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 --- Comment #12 from Jonathan Druart --- For the record, Sonia reported on bug 29496. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 09:31:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 08:31:30 +0000 Subject: [Koha-bugs] [Bug 29491] Improve display of notices in patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127741|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 127775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127775&action=edit Bug 29491: (preparatory step) Reindent template Step 1: Replace tabs with spaces and reindent. This patch should include only whitespace changes. If you view the diff while ignoring whitespace there should be no changes. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 09:31:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 08:31:33 +0000 Subject: [Koha-bugs] [Bug 29491] Improve display of notices in patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127742|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 127776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127776&action=edit Bug 29491: Improve display of notices in patron details This patch updates the patron notices list so that notices are shown in a modal dialog instead of inline in the table. The "Resend" button is shown in the modal window controls. To test, apply the patch and locate a patron in the staff interface with multiple sent notices. - View the patron's "Notices" tab. - In the table of notices, click one of the notice titles. - A modal window should appear with the notice subject as the header and the notice content in the main body of the modal. - If the message has any other status than 'pending' there should be a "Resend" button in the modal footer. Confirm that it submits the form and resends the correct message. - Try viewing multiple notices to confirm that the contents of the modal are correctly updated for each message. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 09:32:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 08:32:00 +0000 Subject: [Koha-bugs] [Bug 29491] Improve display of notices in patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Martin Renvoize --- This is an excellent improvement, thanks Owen! Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 09:32:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 08:32:39 +0000 Subject: [Koha-bugs] [Bug 29510] objects.find should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29510 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #8 from Jonathan Druart --- Then we get a 404, is that expected? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 09:35:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 08:35:35 +0000 Subject: [Koha-bugs] [Bug 29513] New: Accessibility: Staff Client - Convert remaining breadcrumbs sections from div to nav blocks Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29513 Bug ID: 29513 Summary: Accessibility: Staff Client - Convert remaining breadcrumbs sections from div to nav blocks Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: a.roussos at dataly.gr QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 27846 and Bug 28101 dealt with making the Staff Client and OPAC breadcrumbs more accessible. It would appear, however, that some Staff Client template files were missed in the process: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/transfer_limits.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/merge-patrons.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 09:35:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 08:35:54 +0000 Subject: [Koha-bugs] [Bug 29513] Accessibility: Staff Client - Convert remaining breadcrumbs sections from div to nav blocks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29513 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |a.roussos at dataly.gr |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 09:38:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 08:38:21 +0000 Subject: [Koha-bugs] [Bug 29510] objects.find should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29510 --- Comment #9 from Jonathan Druart --- We can access holds using /api/v1/patrons/5/holds, I don't think we should. Note that /cgi-bin/koha/members/holdshistory.pl?borrowernumber=5 is accessible using Koha, but that sounds like a bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 09:45:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 08:45:02 +0000 Subject: [Koha-bugs] [Bug 29510] objects.find should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29510 --- Comment #10 from Jonathan Druart --- And, finally, what about /api/v1/checkouts with x-koha-embed = 'issuer'? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 10:03:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 09:03:18 +0000 Subject: [Koha-bugs] [Bug 29501] gather_print_notices.pl does not use SMTP servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29501 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29330 CC| |jonathan.druart+koha at gmail. | |com Depends on| |22343 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 [Bug 22343] Add configuration options for SMTP servers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 10:03:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 09:03:18 +0000 Subject: [Koha-bugs] [Bug 22343] Add configuration options for SMTP servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29501 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29501 [Bug 29501] gather_print_notices.pl does not use SMTP servers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 10:03:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 09:03:18 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29501 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 10:05:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 09:05:18 +0000 Subject: [Koha-bugs] [Bug 29502] Possibility of changing the database engine to avoid errors in autoincremental fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29502 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- You will find the relevant info on this wiki page: https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 10:09:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 09:09:30 +0000 Subject: [Koha-bugs] [Bug 29513] Accessibility: Staff Client - Convert remaining breadcrumbs sections from div to nav blocks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29513 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 10:09:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 09:09:33 +0000 Subject: [Koha-bugs] [Bug 29513] Accessibility: Staff Client - Convert remaining breadcrumbs sections from div to nav blocks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29513 --- Comment #1 from Andreas Roussos --- Created attachment 127777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127777&action=edit Bug 29513: Convert remaining breadcrumbs div blocks into nav As per https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27846#c0, breadcrumbs should adhere to the WAI-ARIA Authoring Practices. Most Staff Client template files have already been fixed, but there were a few that were missed. This patch fixes that. Test plan: 1) Apply this patch. 2) Visit these pages in the Staff Client: Home > Acquisitions > TestVendor > Basket TestBasket (1) for TestVendor (*) Home > Administration > Set library checkin and transfer policy (**) Home > Patrons > Merge patron records (***) ...and confirm that the breadcrumbs display correctly. (*) Can be accessed by creating a test basket for a test vendor (**) Can be found under Administration -> Patrons and circulation (***) Can be found by trying to merge two Patron records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 10:13:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 09:13:21 +0000 Subject: [Koha-bugs] [Bug 29432] Item type deletion should test frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29432 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- I am not sure I understand. In which cases it's a problem? You want to delete itemtype 'BOOK', 'BOOK' is used in biblioitems.itemtype but not using the 'itemtype' plugin and so you want to be able to delete the itemtype? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 10:20:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 09:20:56 +0000 Subject: [Koha-bugs] [Bug 29410] Dates compared arithmetically in MsgType.pm (warns: Argument isn't numeric in numeric ne) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29410 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Blocks| |25790 Depends on| |5601 --- Comment #4 from Jonathan Druart --- See also commit d4842d45601bd0f9c1bd33bf7978586ae746888f Bug 5601 Fix processing of DueDate return I think it would make sense to apply the same change for both recall_date and hold_pickup_date. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5601 [Bug 5601] SIP Due dates miscalculated via DateTime https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 10:20:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 09:20:56 +0000 Subject: [Koha-bugs] [Bug 5601] SIP Due dates miscalculated via DateTime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5601 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29410 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29410 [Bug 29410] Dates compared arithmetically in MsgType.pm (warns: Argument isn't numeric in numeric ne) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 10:20:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 09:20:56 +0000 Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29410 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29410 [Bug 29410] Dates compared arithmetically in MsgType.pm (warns: Argument isn't numeric in numeric ne) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 10:22:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 09:22:38 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm Item Parts requires Force Checkout permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25261 CC| |jonathan.druart+koha at gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 [Bug 25261] Multiple parts handling - confirmation alert -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 10:22:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 09:22:38 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29504 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 [Bug 29504] Confirm Item Parts requires Force Checkout permission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 10:22:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 09:22:46 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm Item Parts requires Force Checkout permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |unspecified -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 10:28:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 09:28:36 +0000 Subject: [Koha-bugs] [Bug 29513] Accessibility: Staff Client - Convert remaining breadcrumbs sections from div to nav blocks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29513 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff Client |Templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 10:29:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 09:29:44 +0000 Subject: [Koha-bugs] [Bug 29512] zebrasrv -v none, fatal, warn -k 1024 -f /etc/koha/sites/library/koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29512 --- Comment #1 from Katrin Fischer --- Hi, can you please add more information about the problem you are trying to report? See: https://wiki.koha-community.org/wiki/Bug_Reporting_Guidelines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 10:37:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 09:37:07 +0000 Subject: [Koha-bugs] [Bug 29505] Add syspref to allow to place multiple holds on same item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29505 --- Comment #2 from Katrin Fischer --- Hi Julian, is this about item level or biblio level holds? I wonder if it could be a possible duplicate to Bug 15565 - Place multiple item-level holds at once for the same record. Also not sure if this should be a system preference when we already have this option via the circulation rules (holds per record). Can you explain a bit more? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 10:37:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 09:37:54 +0000 Subject: [Koha-bugs] [Bug 29514] New: ILL requests: Remove extraneous › HTML entity from breadcrumbs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29514 Bug ID: 29514 Summary: ILL requests: Remove extraneous › HTML entity from breadcrumbs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: a.roussos at dataly.gr QA Contact: testopia at bugs.koha-community.org Created attachment 127778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127778&action=edit ILL requests - extra > after 'Home' breadcrumb As per the attached screenshot, the template file for ILL requests has a small typo: there exists an extra › HTML entity after "Home". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 10:38:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 09:38:03 +0000 Subject: [Koha-bugs] [Bug 29514] ILL requests: Remove extraneous › HTML entity from breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29514 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |a.roussos at dataly.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 10:42:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 09:42:37 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm Item Parts requires Force Checkout permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 --- Comment #1 from Katrin Fischer --- Hm, I was under the impression force_checkout was only for restrictions on the account. Maybe this should be made more similar to how "Override blocked renewals"? Or can we assume that this should never block a checkout but only force staff to check for completeness and confirm? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 10:47:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 09:47:31 +0000 Subject: [Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #3 from Katrin Fischer --- Hi, is this related to bug 29499? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 10:50:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 09:50:24 +0000 Subject: [Koha-bugs] [Bug 29514] ILL requests: Remove extraneous › HTML entity from breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29514 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 10:50:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 09:50:27 +0000 Subject: [Koha-bugs] [Bug 29514] ILL requests: Remove extraneous › HTML entity from breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29514 --- Comment #1 from Andreas Roussos --- Created attachment 127779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127779&action=edit Bug 29514: Remove extraneous HTML entity from breadcrumbs The template file for ILL requests has a small typo in the breadcrumbs section: there exists an extra › HTML entity after "Home". This patch fixes that. Test plan: 1) Access the ILL requests module, and notice how an extra character is displayed after "Home" in the breadcrumbs. 2) Apply this patch. 3) Refresh the page -- the extra character is no longer displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 11:09:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 10:09:35 +0000 Subject: [Koha-bugs] [Bug 29505] Add syspref to allow to place multiple holds on same item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29505 --- Comment #3 from Julian Maurice --- Hi Katrin, Bug 15565 was about being able to place multiple title-level holds on the same biblio record. Looking at the bug's history it seems that these patches changed quite a bit and are now about item-level holds. But it still does not allow to place a hold on the same item twice, which is what this new bug is about. Combined with the syspref AllowHoldDateInFuture, it allows to place several holds on the same item for different dates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 11:11:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 10:11:14 +0000 Subject: [Koha-bugs] [Bug 29322] Date validation can be sketchy on the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29322 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- The current situation on master is: PUT http://kohadev-intra.mydnsname.org:8081/api/v1/holds/1 { "pickup_library_id": "FPL", "priority": 1, "suspended_until": "2021-10-27 23:59" } => "message": "Does not match date-time format.", "path": "/body/suspended_until" PUT http://kohadev-intra.mydnsname.org:8081/api/v1/holds/1 { "pickup_library_id": "FPL", "priority": 1, "suspended_until": "2021-10-27 23:59:00" } => "error": "Something went wrong, check Koha logs for details." With, in logs: [2021/11/18 10:10:47] [ERROR] PUT /api/v1/holds/1: unhandled exception (Mojo::Exception)<> Koha::REST::Plugin::Exceptions::__ANON__ /kohadevbox/koha/Koha/REST/Plugin/Exceptions.pm (73) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 11:12:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 10:12:58 +0000 Subject: [Koha-bugs] [Bug 29322] Date validation can be sketchy on the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29322 --- Comment #2 from Jonathan Druart --- Note that: "suspended_until": null => "message": "Expected string - got null.", "suspended_until": "" => "message": "Does not match date-time format.", Shouldn't we allow null here? (not directly related however). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 11:18:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 10:18:05 +0000 Subject: [Koha-bugs] [Bug 29499] CheckMandatorySubfields don't work properly with select field in serials-edit.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29499 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart --- Hi Marion, the problem exists on other forms as well and I fixed it on bug 29496. Can you have a look at it please? I will move your patch there and rebase mine on top of yours. *** This bug has been marked as a duplicate of bug 29496 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 11:18:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 10:18:05 +0000 Subject: [Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marion.durand at biblibre.com --- Comment #4 from Jonathan Druart --- *** Bug 29499 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 11:18:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 10:18:21 +0000 Subject: [Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127733|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 127780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127780&action=edit Bug 29496: CheckMandatorySubfields don't work properly with select field in serials-edit.tt Since one of the patches of BZ 27526 (Bug 27526: Fix mandatory and important checks), CheckMandatorySubfields use the class "input_marceditor" but in file serials-edit.tt this class is not set for all field (it is present on text input but not on select input) 5 9- Check that no error appear and that your item has been created. In consequence if a select field is set as mandatory, it is detected as missing even if it is filed and so you can't submit the form and receive the new serial. Test plan: 0- Be sure to be in a version of koha where the patch that introduces the bug is present (it is present in master since Jul 8 2021 (it is present in 21.06.00.046) and will be pushed in 21.11.00) 1- Create (or find) a subscription for a biblio record and select the option "Create an item record when receiving this serial" 2- Be sure to have at least one mandatory subfield that is filed with a select input in the framework used by the biblio record. (ex: 995$b, 995$c or 995$e in unimarc; 952$a, 952$b or 952$c in marc21) 3- From the subscription-detail page click on "Receive" 4- Change the status to "Arrived" and fill the item form that appears. 5- Click on "Save" 6- Check that an error box appear with the message " Form not submitted because of the following problem(s) 1 mandatory fields empty (highlighted)" (the number can be different according to the number of concerned subfields) 7- Apply the patch 8- Repeat step 3 to 5 9- Check that no error appear and that your item has been created JD amended patch: remove comma to separate classes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 11:18:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 10:18:24 +0000 Subject: [Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #6 from Jonathan Druart --- Created attachment 127781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127781&action=edit Bug 29496: (bug 27526 follow-up) Fix item form validation The validation of the forms were blocked with "X item mandatory fields empty" when at least one dropdown list subfield was marked as mandatory. We need to add the 'input_marceditor' class to the select (does it actually make sense? select vs input...) Caused by commit 6ed29bccef590a1bc5e4cea175b41b8024483320 Bug 27526: Fix mandatory and important checks Which lamentably failed as it was stating: "Using .input_marceditor let us fix the additem.tt form and prevent to break the other ones" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 11:28:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 10:28:47 +0000 Subject: [Koha-bugs] [Bug 29322] Date validation can be sketchy on the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29322 --- Comment #3 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #1) > The current situation on master is: > > PUT http://kohadev-intra.mydnsname.org:8081/api/v1/holds/1 > { > "pickup_library_id": "FPL", > "priority": 1, > "suspended_until": "2021-10-27 23:59" > } > > => > "message": "Does not match date-time format.", > "path": "/body/suspended_until" > > PUT http://kohadev-intra.mydnsname.org:8081/api/v1/holds/1 > { > "pickup_library_id": "FPL", > "priority": 1, > "suspended_until": "2021-10-27 23:59:00" > } > > => "error": "Something went wrong, check Koha logs for details." > > With, in logs: > [2021/11/18 10:10:47] [ERROR] PUT /api/v1/holds/1: unhandled exception > (Mojo::Exception)< date format (rfc3339) at /kohadevbox/koha/Koha/DateUtils.pm line 193.>> > Koha::REST::Plugin::Exceptions::__ANON__ > /kohadevbox/koha/Koha/REST/Plugin/Exceptions.pm (73) Any 'Something went wrong' message means an uncaught exception. Once detected, we should catch it correctly and return the right message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 11:38:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 10:38:13 +0000 Subject: [Koha-bugs] [Bug 29396] "Search to hold" should not rely on cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29396 --- Comment #1 from Jonathan Druart --- Created attachment 127782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127782&action=edit Bug 29396: Make 'Search to hold' work for patron without cardnumber -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 11:41:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 10:41:40 +0000 Subject: [Koha-bugs] [Bug 29396] "Search to hold" should not rely on cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29396 --- Comment #2 from Jonathan Druart --- This patch may work, but there will be a side-effect. If patron A without a cardnumber has a borrowernumber set to the value of the cardnumber of patron B, B will be returned when "Place hold for A" will be clicked. To prevent that a follow-up is needed to pass 2 distinct variables to request.pl (one for cardnumber and one for borrowernumber). More logic will be needed in .tt files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 11:46:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 10:46:05 +0000 Subject: [Koha-bugs] [Bug 29432] Item type deletion should test frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29432 --- Comment #2 from Katrin Fischer --- I think the problem here is something that we will encounter again and again. You can remove the plugin from the frameworks and use another list of authorised values for biblioitems.itemtype and I know some Biblibre libraries have done this, but I really believe that it's a terrible idea. Because on the other side we have hold features, article requests features, search and display features relying on this to be an actual item type. Note: I am speaking of features for item level itypes! We can change the check here... but I believe that we should not support this use case. It's harmful to the libraries locking them out of functionality and will keep having us add code and workarounds. ... and instead of changing the check you could use different codes to fix the issue locally in this case? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 11:47:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 10:47:19 +0000 Subject: [Koha-bugs] [Bug 29322] Date validation can be sketchy on the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29322 --- Comment #4 from Jonathan Druart --- Cannot we teach the validator what is the date format we expect? It's weird that it catches some but not all bad formatted dates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 11:49:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 10:49:05 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Confirm Item Parts requires |Confirm item parts requires |Force Checkout permission |force_checkout permission -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 11:55:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 10:55:31 +0000 Subject: [Koha-bugs] [Bug 29509] GET /patrons* routes permissions excessive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509 --- Comment #3 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #2) > I wondering how our changes to objects.search and objects.find might affect > public routes and seeing ones owned data? That's a good question. It probably highlights the search_limited methods are too staff side oriented. I did this: $ git grep 'sub search_limited' Koha/ArticleRequests.pm:sub search_limited { Koha/Patron/Discharge.pm:sub search_limited { Koha/Patrons.pm:sub search_limited { Koha/Reviews.pm:sub search_limited { It feels like safe for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 11:59:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 10:59:47 +0000 Subject: [Koha-bugs] [Bug 29456] "Auto renewal" and "Hold reminder" notice shown as "unknown" on the patron category list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"Auto renewal" notice shown |"Auto renewal" and "Hold |as "unknown" on the patron |reminder" notice shown as |category list view |"unknown" on the patron | |category list view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 12:08:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 11:08:20 +0000 Subject: [Koha-bugs] [Bug 29322] Date validation can be sketchy on the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29322 --- Comment #5 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #4) > Cannot we teach the validator what is the date format we expect? It's weird > that it catches some but not all bad formatted dates. The validator is supposed to expect RFC3339 valid dates. Maybe it is time to try what happens in newer versions. In the meantime, we could use a regex instead of telling it is a date-time. I would (in that case) document on the spec that those regex expect rfc3339 date/date-time to avoid confusion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 12:08:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 11:08:23 +0000 Subject: [Koha-bugs] [Bug 29456] "Auto renewal" and "Hold reminder" notice shown as "unknown" on the patron category list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 12:08:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 11:08:27 +0000 Subject: [Koha-bugs] [Bug 29456] "Auto renewal" and "Hold reminder" notice shown as "unknown" on the patron category list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127693|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 127783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127783&action=edit Bug 29456: (bug 18532 follow-up) handle Auto_Renewals messages in category The new message appears in the list on the edit view, but the list view is showing "unknown" Test plan: Set AutoRenewalNotices to "according to patron messaging prefs" Edit a patron category Tick all the checkboxes On the category list view you should see a correct display in the "Messaging" column Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 12:08:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 11:08:31 +0000 Subject: [Koha-bugs] [Bug 29456] "Auto renewal" and "Hold reminder" notice shown as "unknown" on the patron category list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 --- Comment #5 from Katrin Fischer --- Created attachment 127784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127784&action=edit Bug 29456: Add Hold_Reminder description to patron categories overview page This was missed when initially adding the notice. To test: - Go to Administraiton > patron categories - Edit a patron category and check "Hold reminder" in messaging preferences, save. - Go to the overview page and verify it shows as 'Unknown'. - Apply patch. - Descrpition should now display. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 12:14:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 11:14:22 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #59 from Katrin Fischer --- Thx, Michael! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 12:35:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 11:35:02 +0000 Subject: [Koha-bugs] [Bug 29456] "Auto renewal" and "Hold reminder" notice shown as "unknown" on the patron category list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 --- Comment #6 from Katrin Fischer --- Strictly speaking this is a string patch, but as the string already exists in other spots, I believe we could be lucky here. And an English string showing would also be better than "Unknown". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 12:37:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 11:37:12 +0000 Subject: [Koha-bugs] [Bug 29515] New: Don't require title for HTML customizations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29515 Bug ID: 29515 Summary: Don't require title for HTML customizations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Depends on: 24387 The title field is mandatory for HTML customizations, but the field isn't used for display and doesn't make sense here. I think we should at least make it not mandatory, but possibly could remove it altogether. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 [Bug 24387] Rename News tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 12:37:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 11:37:12 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29515 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29515 [Bug 29515] Don't require title for HTML customizations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 12:37:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 11:37:12 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29515 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 12:43:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 11:43:18 +0000 Subject: [Koha-bugs] [Bug 29516] New: Remove dependency on IO::Scalar Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29516 Bug ID: 29516 Summary: Remove dependency on IO::Scalar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org IO::Scalar is used in Koha::App::Plugin::CGIBinKoha to create a filehandle tied to a scalar. Perl has this feature built in since 5.8.0 so IO::Scalar is not needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 12:43:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 11:43:50 +0000 Subject: [Koha-bugs] [Bug 29516] Remove dependency on IO::Scalar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29516 --- Comment #1 from Julian Maurice --- Created attachment 127785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127785&action=edit Bug 29516: Remove dependency on IO::Scalar IO::Scalar is used in Koha::App::Plugin::CGIBinKoha to create a filehandle tied to a scalar. Perl has this feature built in since 5.8.0 so IO::Scalar is not needed I'm not sure how to test this, since it should behave exactly the same with or without the patch, but we can at least verify that it doesn't introduce encoding issues. Test plan: 1. Run `morbo bin/intranet` 2. Go to http://localhost:3000 3. Create a bibliographic record with some non-latin characters (try emoji characters for instance). Verify that there is no visible encoding issues. 4. Save this record as MARCXML and re-import it as a new record using Tools » Stage MARC records for import. Verify that the new record has no visible encoding issues 5. `git grep IO::Scalar` should not return any result -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 12:44:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 11:44:15 +0000 Subject: [Koha-bugs] [Bug 29516] Remove dependency on IO::Scalar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29516 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 12:44:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 11:44:21 +0000 Subject: [Koha-bugs] [Bug 29513] Accessibility: Staff Client - Convert remaining breadcrumbs sections from div to nav blocks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29513 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 12:44:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 11:44:24 +0000 Subject: [Koha-bugs] [Bug 29513] Accessibility: Staff Client - Convert remaining breadcrumbs sections from div to nav blocks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29513 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127777|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 127786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127786&action=edit Bug 29513: Convert remaining breadcrumbs div blocks into nav As per https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27846#c0, breadcrumbs should adhere to the WAI-ARIA Authoring Practices. Most Staff Client template files have already been fixed, but there were a few that were missed. This patch fixes that. Test plan: 1) Apply this patch. 2) Visit these pages in the Staff Client: Home > Acquisitions > TestVendor > Basket TestBasket (1) for TestVendor (*) Home > Administration > Set library checkin and transfer policy (**) Home > Patrons > Merge patron records (***) ...and confirm that the breadcrumbs display correctly. (*) Can be accessed by creating a test basket for a test vendor (**) Can be found under Administration -> Patrons and circulation (***) Can be found by trying to merge two Patron records Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 12:48:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 11:48:27 +0000 Subject: [Koha-bugs] [Bug 29514] ILL requests: Remove extraneous › HTML entity from breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29514 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 12:48:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 11:48:30 +0000 Subject: [Koha-bugs] [Bug 29514] ILL requests: Remove extraneous › HTML entity from breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29514 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127779|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 127787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127787&action=edit Bug 29514: Remove extraneous HTML entity from breadcrumbs The template file for ILL requests has a small typo in the breadcrumbs section: there exists an extra › HTML entity after "Home". This patch fixes that. Test plan: 1) Access the ILL requests module, and notice how an extra character is displayed after "Home" in the breadcrumbs. 2) Apply this patch. 3) Refresh the page -- the extra character is no longer displayed. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 13:03:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 12:03:30 +0000 Subject: [Koha-bugs] [Bug 29517] New: CanItemBeReserved fetches biblio for agerestriction check if feature not enabled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29517 Bug ID: 29517 Summary: CanItemBeReserved fetches biblio for agerestriction check if feature not enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Before fetching the biblio, we can check if agerestriction is mapped to a field. The structure is cached, so we can save on lookup when not using this feature -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 13:06:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 12:06:41 +0000 Subject: [Koha-bugs] [Bug 29517] CanItemBeReserved fetches biblio for agerestriction check if feature not enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29517 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 13:06:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 12:06:44 +0000 Subject: [Koha-bugs] [Bug 29517] CanItemBeReserved fetches biblio for agerestriction check if feature not enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29517 --- Comment #1 from Nick Clemens --- Created attachment 127788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127788&action=edit Bug 29517: Check if agerestriction field is mapped before fetching biblio This patch simply adds a check of cached values to see if agerestriction enabled before fetching the biblio object To test: 1 - prove -v t/db_dependent/Holds.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 13:13:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 12:13:59 +0000 Subject: [Koha-bugs] [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 13:18:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 12:18:24 +0000 Subject: [Koha-bugs] [Bug 29515] Don't require title for HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29515 --- Comment #1 from Katrin Fischer --- We have discussed on IRC and some HTML customizations like OpacLoginInstructions can display the title, but not all of them. We concluded that having the field optional would work well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 13:19:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 12:19:58 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |We favored the use of release notes| |EXPORT_OK over EXPORT, to | |prevent name clashes and | |make the import explicit. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 13:43:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 12:43:37 +0000 Subject: [Koha-bugs] [Bug 29501] gather_print_notices.pl does not use SMTP servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29501 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 127789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127789&action=edit Bug 29501: Make gather_print_notices.pl use Koha::Email This patch makes the cronjob script use Koha::Email and thus relying on configured SMTP settings instead of just trying localhost. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 13:43:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 12:43:42 +0000 Subject: [Koha-bugs] [Bug 29501] gather_print_notices.pl does not use SMTP servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29501 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 127790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127790&action=edit Bug 29501: Remove MIME::Lite dependency The library usage is discouraged by the current maintainer and we don't use it in the codebase anymore. To test: 1. Apply this patch 2. Run: $ git grep MIME::Lite => SUCCESS: No uses of the removed library 3. Sign off :-D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 13:44:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 12:44:42 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 13:45:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 12:45:08 +0000 Subject: [Koha-bugs] [Bug 29501] gather_print_notices.pl does not use SMTP servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29501 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | --- Comment #3 from Tomás Cohen Arazi --- (In reply to Magnus Enger from comment #0) > Bug 22343 added the ability to specify SMTP servers for outgoing email, > removing the need to run an MTA (like postfix) on the server. > > As far as I can tell, gather_print_notices.pl does it's own email sending > with MIME::Lite, bypassing the message_queue and the SMTP server setup. So > in order to use this as a cronjob to send print as email, you have to run an > MTA anyway. > > Could this be fixed, so the script uses the SMTP server setup? Hi, I'm not familiar with the script enough to write a test plan. Can you test and amend the commit message to include the test plan? Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 13:45:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 12:45:21 +0000 Subject: [Koha-bugs] [Bug 29501] gather_print_notices.pl does not use SMTP servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29501 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 13:47:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 12:47:31 +0000 Subject: [Koha-bugs] [Bug 29501] gather_print_notices.pl does not use SMTP servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29501 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://metacpan.org/pod/MI | |ME::Lite#WAIT! --- Comment #4 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #2) > Created attachment 127790 [details] [review] > Bug 29501: Remove MIME::Lite dependency > > The library usage is discouraged by the current maintainer and we don't > use it in the codebase anymore. https://metacpan.org/pod/MIME::Lite#WAIT! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 13:52:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 12:52:07 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127651|0 |1 is obsolete| | --- Comment #13 from David Gustafsson --- Created attachment 127791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127791&action=edit Bug 29440: Refactor and clean up bulkmarcimport.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 13:56:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 12:56:18 +0000 Subject: [Koha-bugs] [Bug 29518] New: Title not display additional contents Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29518 Bug ID: 29518 Summary: Title not display additional contents Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Templates Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 13:58:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 12:58:09 +0000 Subject: [Koha-bugs] [Bug 29518] Title not display additional contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29518 --- Comment #1 from Jonathan Druart --- Created attachment 127793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127793&action=edit Bug 29518: Display title for additional contents/news -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 13:59:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 12:59:00 +0000 Subject: [Koha-bugs] [Bug 29518] Title not display additional contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29518 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |martin.renvoize at ptfs-europe | |.com, oleonard at myacpl.org Status|ASSIGNED |In Discussion --- Comment #2 from Jonathan Druart --- Hum, is it a regression? Looking at the code I am not sure it ever worked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 13:59:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 12:59:25 +0000 Subject: [Koha-bugs] [Bug 29518] Title not displayed additional contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29518 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Title not display |Title not displayed |additional contents |additional contents -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 13:59:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 12:59:32 +0000 Subject: [Koha-bugs] [Bug 29518] Title not displayed for additional contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29518 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Title not displayed |Title not displayed for |additional contents |additional contents -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 13:52:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 12:52:12 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127652|0 |1 is obsolete| | --- Comment #14 from David Gustafsson --- Created attachment 127792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127792&action=edit Bug 29440: Make authorities import behavior consistent with biblios The current behavior for when importing authorities, when match option is enabled, is to insert as a new authority fetching from db fails. This is both a bit confusing and not consistent with the biblio case where an error is generated. Also clean up error and log messages so both messages/errors and when messages/errors are issued are more consistent for the biblio and authority case. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 14:04:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 13:04:05 +0000 Subject: [Koha-bugs] [Bug 29501] gather_print_notices.pl does not use SMTP servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29501 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 127794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127794&action=edit Bug 29501: (follow-up) Remove unused MIME::QuotedPrint dependency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 14:08:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 13:08:50 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127791|0 |1 is obsolete| | --- Comment #15 from David Gustafsson --- Created attachment 127795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127795&action=edit Bug 29440: Refactor and clean up bulkmarcimport.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 14:08:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 13:08:54 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127792|0 |1 is obsolete| | --- Comment #16 from David Gustafsson --- Created attachment 127796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127796&action=edit Bug 29440: Make authorities import behavior consistent with biblios The current behavior for when importing authorities, when match option is enabled, is to insert as a new authority fetching from db fails. This is both a bit confusing and not consistent with the biblio case where an error is generated. Also clean up error and log messages so both messages/errors and when messages/errors are issued are more consistent for the biblio and authority case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 14:10:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 13:10:23 +0000 Subject: [Koha-bugs] [Bug 29518] Title not displayed for additional contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29518 --- Comment #3 from Katrin Fischer --- Hm, another thing: will this fix not appear as an unwanted change in behavior? As title now is not displaying, but the field is mandatory, people will probably have added all needed text to the entry and this could cause double ups. Also: they might just have done what I often do and add nonsense instead of good text... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 14:15:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 13:15:12 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #24 from Andrew Fuerste-Henry --- To test: APPLY PATCH 1 - create a hold with an expiration date sooner than the period defined by your MaxPickupDelay 2 - check your item in, triggering the hold, confirm the expiration date doesn't change 3 - revert your hold, confirm the expiration date doesn't change 4 - create a hold with an expiration date past the period defined by your MaxPickupDelay 5 - check your item in, triggering the hold, confirm the expiration date changes 6 - Revert your hold, confirm the expiration date reverts back to its original value 7 - create a hold with no expiration date 8 - check your item in, triggering the hold, confirm an expiration date is created 9 - revert your hold, confirm the expiration date is deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 14:24:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 13:24:14 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 14:24:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 13:24:18 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126160|0 |1 is obsolete| | --- Comment #25 from Andrew Fuerste-Henry --- Created attachment 127797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127797&action=edit Bug 21729: DB changes Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 14:24:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 13:24:23 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126161|0 |1 is obsolete| | --- Comment #26 from Andrew Fuerste-Henry --- Created attachment 127798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127798&action=edit Bug 21729: DBIC schema changes Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 14:24:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 13:24:28 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126203|0 |1 is obsolete| | --- Comment #27 from Andrew Fuerste-Henry --- Created attachment 127799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127799&action=edit Bug 21729: Keep expiration date set when placing a hold The expiration date picked by the patron (or librarian) when placing a hold is lost when a waiting hold is reverted. We need a separate DB field to store this value and restore it when needed: patron_expiration_date The new behaviours are now: Create a hold and specify an expiration date: expirationdate=patron_expiration_date Fill the hold: expiration_date is calculated expiration_date set to the calculated value or to patron_expiration_date if anterior patron_expiration_date not modified Revert the waiting status: expirationdate set back to patron_expiration_date Cancel expire reserves: if < expirationdate OR < patron_expiration_date Note: This change should not be needed but won't hurt Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 14:24:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 13:24:32 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126258|0 |1 is obsolete| | --- Comment #28 from Andrew Fuerste-Henry --- Created attachment 127800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127800&action=edit Bug 21729: Simplify non-existent expiration date No change in behaviour expected by this patch. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 14:37:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 13:37:01 +0000 Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create mysqluser@mysql_hostname so zebra update fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 --- Comment #37 from Katrin Fischer --- Hi, it's about the patch file, see: >From 06fd450e1f9749e8fa1d6455e32f597ac0ef85b4 Mon Sep 17 00:00:00 2001 From: dolf Date: Wed, 8 Jan 2020 11:20:02 +0200 Subject: [PATCH] Bug 10517: Use `DROP USER IF EXISTS` and remove ` || true`. This means that you will show up as "dolf" in some places. We do have mappings to make things show nicer/full names, but always easier to make sure it has the information you want to display. I think you might want to run: git config --global user.name "firstname lastname" I believe if you don't want to resubmit, we could also fix this as part of QA, but you should tell us what it should read like. Rudolf Byker? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 14:40:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 13:40:53 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 --- Comment #17 from Katrin Fischer --- Hi David, could you please also add a test plan that highlights the changes for testers? They usually should be added to the commit message. Also this is still marked as NEW - should it be Needs signoff to call for testers? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 14:44:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 13:44:56 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 --- Comment #2 from Donna --- >From talking with libraries, the thought is that it should never block a checkout, but make staff pause to verify parts and then either confirm so the item is checked out, or decline, and the item does not get checked out. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 14:54:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 13:54:01 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Katrin Fischer --- (In reply to Donna from comment #2) > From talking with libraries, the thought is that it should never block a > checkout, but make staff pause to verify parts and then either confirm so > the item is checked out, or decline, and the item does not get checked out. Thx Donna, that's what I was thinking too. So maybe it's just about removing the check? Adding Martin. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 14:58:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 13:58:25 +0000 Subject: [Koha-bugs] [Bug 29519] New: One should be able to resolve a return claim at checkin Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Bug ID: 29519 Summary: One should be able to resolve a return claim at checkin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently, upon checking in an item that has a return claim associated with it, we highlight this to the librarian but we don't give any option to resolve the claim there and then (but we do mark the item as found in the background). We should give the librarian the option to resolve the claim. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 14:58:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 13:58:32 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 15:01:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 14:01:44 +0000 Subject: [Koha-bugs] [Bug 28716] Hide toolbar and opaccredits when printing lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28716 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 15:01:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 14:01:48 +0000 Subject: [Koha-bugs] [Bug 28716] Hide toolbar and opaccredits when printing lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28716 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127681|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 127801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127801&action=edit Bug 28716: hide moresearches and opaccredits from print To test: 1. Make some lists and look at them in the OPAC 2. Have some content in your OPACCredits news section 3. Look at some lists and try clicking 'Print list' 4. You will see the moresearches (top navigation) and opaccredits content 5. apply patch and regenearte the CSS 6. Do 3 again, you should not see the contents of moresearches (top navigation) and opaccredits content Signed-off-by: Fridolin Somers Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 15:08:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 14:08:47 +0000 Subject: [Koha-bugs] [Bug 23608] Koha::Objects::Limit::Library->get_library_limits can return undef In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23608 --- Comment #5 from Jonathan Druart --- The POD says "It returns undef if no library limits defined." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 15:18:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 14:18:05 +0000 Subject: [Koha-bugs] [Bug 23608] Koha::Objects::Limit::Library->get_library_limits can return undef In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23608 --- Comment #6 from Jonathan Druart --- We actually return nothing in the first place to not selected anything on the admin edit form, for item type and categories: koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt: [% PROCESS options_for_libraries libraries => Branches.all( selected => category.get_library_limits, unfiltered => 1, do_not_select_my_library => 1 ) %] koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt: [% PROCESS options_for_libraries libraries => Branches.all( selected => itemtype.get_library_limits, unfiltered => 1, do_not_select_my_library => 1 ) %] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 15:19:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 14:19:01 +0000 Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create mysqluser@mysql_hostname so zebra update fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 --- Comment #38 from Rudolf Byker --- > git config --global user.name "firstname lastname" I'll keep this in mind for the future. > we could also fix this as part of QA That would be great, thanks. > but you should tell us what it should read like. Rudolf Byker? Exactly :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 15:19:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 14:19:51 +0000 Subject: [Koha-bugs] [Bug 23608] Koha::Objects::Limit::Library->get_library_limits can return undef In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23608 --- Comment #7 from Jonathan Druart --- (admin/credit_types.pl and admin/debit_types.pl should use the same construct by the way) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 15:20:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 14:20:13 +0000 Subject: [Koha-bugs] [Bug 23608] Koha::Objects::Limit::Library->get_library_limits can return undef In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23608 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 15:26:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 14:26:58 +0000 Subject: [Koha-bugs] [Bug 29518] Title not displayed for additional contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29518 --- Comment #4 from Jonathan Druart --- Well, they will notice quickly :) We could make the change part of 21.11 and announce it clearly in the release note. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 15:30:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 14:30:08 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 --- Comment #1 from Martin Renvoize --- Created attachment 127802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127802&action=edit Bug 29519: Allow resolution of claims return at checkin Add a 'Resolve' button in the alert dialogue that is displayed when a lost item with a return claim is checked in. The button will trigger the usual resolution modal allowing the user to pick their resolution. This patch splits the resolution modal out of checkouts.js and checkouts-table.inc so it can be used outside of the checkouts table. We then reload it, optionally based upon the presence of the claims preference, where needed. This has the added benefit that it saves a little bit of page load data in cases where the feature is not enabled. Test plan 1. As we alter the file locations of the resolution handling code we need to test that normal claims functionality continue to work as expected. 2. Test the new functoinality by checking in an item that has been claimed as returned (but not yet resolved). The dialogue box should now contain a 'resolve' button next to each claimant and clicking upon it should trigger the resolution modal where the librarian can subsequently pick the resolution and submit it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 15:30:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 14:30:37 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 15:30:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 14:30:54 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 15:33:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 14:33:47 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28854 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 15:33:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 14:33:47 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 [Bug 29519] One should be able to resolve a return claim at checkin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 15:34:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 14:34:16 +0000 Subject: [Koha-bugs] [Bug 29518] Title not displayed for additional contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29518 --- Comment #5 from Jonathan Druart --- Reading the changes, I'd say that bug 22880 broke it and that titles were displayed prior to its pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 15:48:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 14:48:23 +0000 Subject: [Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #19 from Owen Leonard --- The breadcrumbs problem turned out to be a local dependency issue, so I'm moving this back to "Signed off." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:02:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:02:25 +0000 Subject: [Koha-bugs] [Bug 29500] Flatpickr accepting original date in the past for futuredate but also other dates in the past In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29500 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:02:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:02:28 +0000 Subject: [Koha-bugs] [Bug 29500] Flatpickr accepting original date in the past for futuredate but also other dates in the past In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29500 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127720|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 127803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127803&action=edit Bug 29500: Flatpickr - accept original date in the past and not others Bug 29241 was supposed to fix this but it didn't properly. We are accepting other dates in the past when we should only accept the original one (the one from the DB) AND dates in future. Test plan: Retry test plan for 29241 and confirm that you cannot set manually another date in the past. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:06:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:06:35 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:06:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:06:39 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127730|0 |1 is obsolete| | --- Comment #12 from Owen Leonard --- Created attachment 127804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127804&action=edit Bug 29478: Today should select now for pastinclusive If Today is clicked when we only allow dates in the past and today/now, we should select the current date/time We need to update the maxDate to make it up-to-date, or the maxDate may be set to the minute before and clicking Today will blank the input. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:13:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:13:23 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 --- Comment #2 from Andrew Fuerste-Henry --- Quick test plan for checking both that current behavior is unchanged and that new behavior works. Let me know if I'm missing something! 1 - set ClaimReturnedLostValue syspref to enable claims 2 - set ClaimReturnedChargeFee to "ask if a lost fee should be charged" 3 - check out an item, mark claimed, choose to charge a fee, confirm your fee charged 4 - check out an item, mark claimed, choose NOT to charge a fee, confirm your fee did not charge 5 - check a claimed item in 6 - confirm you see the new Resolve button and can use it to successfully resolve a claim 7 - resolve your other claim without checking the item in 8 - check your item in and confirm you don't see the Resolve button, since this claim is already resolved 9 - set ClaimReturnedWarningThreshold to 1, confirm your claims are correctly counted toward this threshold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:16:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:16:03 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #13 from Owen Leonard --- The patch in Comment 9 still needs a signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:18:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:18:42 +0000 Subject: [Koha-bugs] [Bug 29520] New: addtioadditional-contents wont display News items or HTML customizations if the expiration date is in the past Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29520 Bug ID: 29520 Summary: addtioadditional-contents wont display News items or HTML customizations if the expiration date is in the past Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To Recreate: -add some News Items or HTML customizations on addtional-contents.pl -set the expiration dates to some date in the past -that news item is filtered out and librarians have no way of editing it I can also recreate this on 21.05 when the page is still named 'koha-news.pl' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:21:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:21:39 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Andrew Fuerste-Henry --- When I check in an item with an unresolved claim, I see the new Resolve button and it opens up a modal with which to resolve the claim, but I get an API error when I click the Resolve Claim button in the modal. The button spins indefinitely and the browser console says "None of these routes could generate a response for your GET request for /api/v1/return_claims/1/resolve, maybe you need to add a new one?" I'm not sure if that's an issue with the patch or with how I tested it. After applying the patch I restarted services and cleared by browser cache. Did I miss a step there? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:26:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:26:10 +0000 Subject: [Koha-bugs] [Bug 29515] Don't require title for HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29515 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:37:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:37:23 +0000 Subject: [Koha-bugs] [Bug 29520] addtioadditional-contents wont display News items or HTML customizations if the expiration date is in the past In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29520 --- Comment #1 from Owen Leonard --- Bug 27766 - "Hide expired news items by default" - made this the default, but checking the "Show expired" checkbox in the sidebar should display them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:38:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:38:42 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 [Bug 29519] One should be able to resolve a return claim at checkin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:38:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:38:42 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29495 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:38:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:38:59 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29519 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 [Bug 29519] One should be able to resolve a return claim at checkin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:38:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:38:59 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29495 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:39:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:39:24 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29495 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:39:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:39:24 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 [Bug 29519] One should be able to resolve a return claim at checkin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:40:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:40:16 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 --- Comment #4 from Martin Renvoize --- Ha.. this highlights a bug in the existing code I already fixed but hadn't realised affected here too. I've now just added it as a dependancy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:40:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:40:48 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 --- Comment #5 from Martin Renvoize --- Hold off on testing until I mark back to NSO.. just trying out the fix here first to make sure it's not more involved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:41:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:41:02 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28854 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:41:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:41:02 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29495 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:48:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:48:45 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127802|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 127805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127805&action=edit Bug 29519: Allow resolution of claims return at checkin Add a 'Resolve' button in the alert dialogue that is displayed when a lost item with a return claim is checked in. The button will trigger the usual resolution modal allowing the user to pick their resolution. This patch splits the resolution modal out of checkouts.js and checkouts-table.inc so it can be used outside of the checkouts table. We then reload it, optionally based upon the presence of the claims preference, where needed. This has the added benefit that it saves a little bit of page load data in cases where the feature is not enabled. Test plan 1. As we alter the file locations of the resolution handling code we need to test that normal claims functionality continue to work as expected. 2. Test the new functoinality by checking in an item that has been claimed as returned (but not yet resolved). The dialogue box should now contain a 'resolve' button next to each claimant and clicking upon it should trigger the resolution modal where the librarian can subsequently pick the resolution and submit it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:48:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:48:49 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 --- Comment #7 from Martin Renvoize --- Created attachment 127806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127806&action=edit Bug 29519: (follow-up) Use 'item' relationship This patch adds the missing 'item' relationship in Checkouts::ReturnClaim and then uses it from the resolve method. This improve the reliability of the resolution code so it works when the item has already been checked in (without having to check Old::Checkouts). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:49:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:49:16 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Martin Renvoize --- That should be better now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:50:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:50:50 +0000 Subject: [Koha-bugs] [Bug 29520] addtioadditional-contents wont display News items or HTML customizations if the expiration date is in the past In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29520 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #2 from Lucas Gass --- Ah! Thanks Owen -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:54:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:54:50 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127805|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 127807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127807&action=edit Bug 29519: Allow resolution of claims return at checkin Add a 'Resolve' button in the alert dialogue that is displayed when a lost item with a return claim is checked in. The button will trigger the usual resolution modal allowing the user to pick their resolution. This patch splits the resolution modal out of checkouts.js and checkouts-table.inc so it can be used outside of the checkouts table. We then reload it, optionally based upon the presence of the claims preference, where needed. This has the added benefit that it saves a little bit of page load data in cases where the feature is not enabled. Test plan 1. As we alter the file locations of the resolution handling code we need to test that normal claims functionality continue to work as expected. 2. Test the new functoinality by checking in an item that has been claimed as returned (but not yet resolved). The dialogue box should now contain a 'resolve' button next to each claimant and clicking upon it should trigger the resolution modal where the librarian can subsequently pick the resolution and submit it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:54:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:54:54 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127806|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 127808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127808&action=edit Bug 29519: (follow-up) Use 'item' relationship This patch adds the missing 'item' relationship in Checkouts::ReturnClaim and then uses it from the resolve method. This improve the reliability of the resolution code so it works when the item has already been checked in (without having to check Old::Checkouts). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 16:58:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 15:58:02 +0000 Subject: [Koha-bugs] [Bug 29515] Don't require title for HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29515 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #2 from Lucas Gass --- +1 if you work in this area a lot its becomes a bit tedious to always have to add a superfluous title -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 17:00:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 16:00:31 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 17:00:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 16:00:35 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127765|0 |1 is obsolete| | --- Comment #12 from Andrew Fuerste-Henry --- Created attachment 127809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127809&action=edit Bug 29495: Drop issue_id constraint from return_claims This patch removes the issue_id constraint from return_claims. Due to the nature of our dual table approach to checkouts/old_checkouts we can't safely hae this constraint and not lose data. Prior to this commit, when an item is checked in we move the checkout from checkouts to old_checkouts.. this therefore triggers the delete of the issue_id from the return_claims table as described by the foreign key constraint. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 17:00:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 16:00:39 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127766|0 |1 is obsolete| | --- Comment #13 from Andrew Fuerste-Henry --- Created attachment 127810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127810&action=edit Bug 29495: DBIC Schema Rebuild Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 17:00:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 16:00:43 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127767|0 |1 is obsolete| | --- Comment #14 from Andrew Fuerste-Henry --- Created attachment 127811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127811&action=edit Bug 29495: Add DBIC relationships back into Schema This patch adds the relationship accessors back into the affected Schema classes, now below the fold so they are retained during dbic rebuilds. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 17:00:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 16:00:47 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127768|0 |1 is obsolete| | --- Comment #15 from Andrew Fuerste-Henry --- Created attachment 127812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127812&action=edit Bug 29495: Add code level constraint replacement This patch adds a check in Koha::Checkouts::ReturnClaim::store to replace the database level foreign key check. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 17:00:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 16:00:51 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127769|0 |1 is obsolete| | --- Comment #16 from Andrew Fuerste-Henry --- Created attachment 127813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127813&action=edit Bug 29495: Update relationship methods This patch updates the relationship methods found in Koha::Checkouts::ReturnClaim so that they are prefetchable and embeddable on the API. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 17:27:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 16:27:02 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 17:27:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 16:27:06 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127807|0 |1 is obsolete| | --- Comment #11 from Andrew Fuerste-Henry --- Created attachment 127814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127814&action=edit Bug 29519: Allow resolution of claims return at checkin Add a 'Resolve' button in the alert dialogue that is displayed when a lost item with a return claim is checked in. The button will trigger the usual resolution modal allowing the user to pick their resolution. This patch splits the resolution modal out of checkouts.js and checkouts-table.inc so it can be used outside of the checkouts table. We then reload it, optionally based upon the presence of the claims preference, where needed. This has the added benefit that it saves a little bit of page load data in cases where the feature is not enabled. Test plan 1. As we alter the file locations of the resolution handling code we need to test that normal claims functionality continue to work as expected. 2. Test the new functoinality by checking in an item that has been claimed as returned (but not yet resolved). The dialogue box should now contain a 'resolve' button next to each claimant and clicking upon it should trigger the resolution modal where the librarian can subsequently pick the resolution and submit it. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 17:27:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 16:27:09 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127808|0 |1 is obsolete| | --- Comment #12 from Andrew Fuerste-Henry --- Created attachment 127815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127815&action=edit Bug 29519: (follow-up) Use 'item' relationship This patch adds the missing 'item' relationship in Checkouts::ReturnClaim and then uses it from the resolve method. This improve the reliability of the resolution code so it works when the item has already been checked in (without having to check Old::Checkouts). Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 17:37:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 16:37:06 +0000 Subject: [Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 --- Comment #20 from Katrin Fischer --- (In reply to Owen Leonard from comment #19) > The breadcrumbs problem turned out to be a local dependency issue, so I'm > moving this back to "Signed off." Oh, sorry for causing the hold up! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 17:49:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 16:49:37 +0000 Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 --- Comment #5 from Owen Leonard --- It seems odd to me that the AutoEmailOpacUser preference ONLY works if you're adding someone from the staff interface. A more comprehensive solution might add a flag to the patron account so that a cron job could send the notice to any new (unflagged) accounts periodically, whether they were created by self-registration, patron import, or manually via the staff interface. If we did it like that it would be relatively easy to trigger the re-sending of a notice by toggling the flag on the patron's acccount, thereby putting them back into the notification queue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 19:41:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 18:41:02 +0000 Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.hafen at washk12.org --- Comment #3 from Michael Hafen --- I seem to have run into this also. I'm running a modified 21.05.05. I have, since noticing the duplicates, deleted all the duplicates, and changed my systems crontab so that daily tasks will run before circulation starts. I've looked at the code in cronjobs/fines.pl and circ/returns.pl. It seems that AddReturn calls _FixOverduesOnReturn which flips the status to 'RETURNED'. Then fines.pl calls UpdateFine, which can't find the fine because the status has been flipped, so it add a new one. I'm think the best course of action would be to have UpdateFine return if the fine has been flipped to 'RETURNED' and 'CalculateFinesOnReturn' is on, since AddReturn will have already updated the fine in that case. Though that still doesn't over the edge-case of 'CalculateFinesOnReturn' being off, since AddReturn still calls _FixOverduesOnReturn either way. With 'CalculateFinesOnReturn' off, when the book gets returned before fines.pl gets to it, UpdateFine still won't find it because _FixOverduesOnReturn flipped the status, but AddReturn didn't call _CalculateAndUpdateFine. The duplicate will get added, but the amount on the original fine wasn't updated. So maybe the best course of action is to have UpdateFine not care about status when looking for the fine, and then only adjust the fine is it's 'UNRETURNED' or 'CalculateFinesOnReturn' is off. (In addition to the check for amount changing.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 19:45:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 18:45:33 +0000 Subject: [Koha-bugs] [Bug 27904] Improve Display in Creating Profile for Staging Marc Records for Import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27904 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 19:48:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 18:48:02 +0000 Subject: [Koha-bugs] [Bug 27904] Improve display in creating profile for staging MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27904 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve Display in Creating |Improve display in creating |Profile for Staging Marc |profile for staging MARC |Records for Import |records for import -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 19:49:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 18:49:43 +0000 Subject: [Koha-bugs] [Bug 29521] New: Patron Club name hyperlinks not operational + weird CSS behavior Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Bug ID: 29521 Summary: Patron Club name hyperlinks not operational + weird CSS behavior Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: mkstephens at lancasterseminary.edu QA Contact: testopia at bugs.koha-community.org Sometime between 20.05 and 21.05 (we skipped 20.11), the name of a patron club is now showing up in the clubs table as hyperlinked. Clicking this hyperlink doesn't do anything. I've tried to search through release notes and bugs to find what the hyperlinking is supposed to do and couldn't trace it. The screenshots in the manual and other online tutorials show that the club name was not previously hyperlinked. The hyperlink could be directed to open the enrollments list or to edit the club's settings. Both of these options are available in the Actions menu. I think it would also be okay to remove the hyperlink altogether to reduce confusion. (I'm almost ashamed to admit how many times I clicked on it thinking it was a shortcut to the enrollments list!) Also, there's a CSS style being applied to the table where every other row is highlighted yellow when the mouse pointer hovers over it. This is distracting and not helpful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 19:59:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 18:59:18 +0000 Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 --- Comment #4 from Michael Hafen --- Created attachment 127816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127816&action=edit Proposed fix -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 20:01:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 19:01:06 +0000 Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 20:01:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 19:01:53 +0000 Subject: [Koha-bugs] [Bug 27904] Improve display in creating profile for staging MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27904 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 20:01:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 19:01:56 +0000 Subject: [Koha-bugs] [Bug 27904] Improve display in creating profile for staging MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27904 --- Comment #1 from Owen Leonard --- Created attachment 127817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127817&action=edit Bug 27904: Improve display in creating profile for staging MARC records for import This patch updates the Stage MARC records for import page, in particular the format of the part of the form for saving or removing a profile. The page moves these controls into their own fieldset so that it is clear they are separate from the "Stage for import" button. The "Remove" control now includes the name of the profile which will be removed. To test, apply the patch and go to Tools -> Stage MARC for import. - Upload a file of records. - Make some changes to the settings and options. - At the bottom of the form you should see a "Save profile" fieldset. - Confirm that the "Save profile" button becomes enabled if you type something in the field (or paste something, or select something from form history). - Confirm that the profile is saved correctly by re-uploading a MARC file and selecting your newly added/edited profile and confirming that the values are set as expected. - In the "Save profile" section there should be a "Remove" link styled with a Bootstrap "trash" icon: "Remove profile: " - Confirm that profile deletion still works correctly. - Confirm that the "Remove" link is updated correctly when you make a selection from the "Profile" dropdown at the top of the form: - Choosing "Do not use profile" should change the "Remove" link to drop the name of the profile and disable the link. - Choosing different profiles should update the name in the "Remove" link. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 20:16:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 19:16:41 +0000 Subject: [Koha-bugs] [Bug 29521] Patron Club name hyperlinks not operational + weird CSS behavior In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED Version|20.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 20:20:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 19:20:37 +0000 Subject: [Koha-bugs] [Bug 29521] Patron Club name hyperlinks not operational + weird CSS behavior In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24627 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 [Bug 24627] Correct style of clubs search results during hold process -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 20:20:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 19:20:37 +0000 Subject: [Koha-bugs] [Bug 24627] Correct style of clubs search results during hold process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 [Bug 29521] Patron Club name hyperlinks not operational + weird CSS behavior -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 20:28:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 19:28:27 +0000 Subject: [Koha-bugs] [Bug 29521] Patron Club name hyperlinks not operational + weird CSS behavior In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 20:28:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 19:28:31 +0000 Subject: [Koha-bugs] [Bug 29521] Patron Club name hyperlinks not operational + weird CSS behavior In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 --- Comment #1 from Owen Leonard --- Created attachment 127818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127818&action=edit Bug 29521: Fix style of patron clubs table when in clubs management This patch follows up Bug 24627 to add some additional template logic to the table of clubs so that the interface is consistent whether you're looking at clubs during the holds process or during the clubs management view. The ways Bug 24627 made the clubs list more consistent with patron search results made it LESS consistent with the Clubs management interface. To test, apply the patch and go to Tools -> Patron clubs. - Scroll down to the "Clubs" table, below the "Club templates" table. - In the table of clubs, the club name should not be a link. - Hovering your mouse over the table should not highlight each row. Confirm the previous behavior of a clubs search when placing a hold: - Search the catalog and start the process of placing a hold on an item. - On the "Place hold" page, click the "Clubs" tab and perform a search which will return multiple clubs. - In this view, the club name should be a link. Clicking it should select that club for the hold. - You should also be able to click anywhere in the row to select the club for the hold. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 20:53:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 19:53:05 +0000 Subject: [Koha-bugs] [Bug 29522] New: Bib record not correctly updated when merging identical authorities with LinkerModule set to First Match Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29522 Bug ID: 29522 Summary: Bib record not correctly updated when merging identical authorities with LinkerModule set to First Match Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl To recreate: 1 - have LinkerModule set to First Match 2 - have a bib with its author linked to an authority 3 - duplicate that authority, confirm that an authority search for your author brings up two identical authorities, one linked to your bib 4 - merge the two authority records, telling Koha to keep the newer of the two (the one not linked to your bib) 5 - search authorities for your author again, confirm you see just one authority and it's not linked to any bibs 6 - reload your bib, see the 100$9 contains the number for the authority you deleted in the merge 7 - edit your bib to correctly link it to the remaining authority 8 - set LinkerModule to Default 9 - repeat steps 3 and 4 10 - see your remaining authority is linked to your bib, the bib has the correct authority number I'm not able to replicate this in master. I'm not sure what changed from 21.05. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 21:42:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 20:42:04 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 AspenCat Team changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 22:13:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 21:13:37 +0000 Subject: [Koha-bugs] [Bug 29523] New: Add a way to prevent embedding objects that should not be allowed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Bug ID: 29523 Summary: Add a way to prevent embedding objects that should not be allowed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com A user can be allowed to see only patrons from its own library, for example. So fetching (through the API) all the current checkouts for a biblio and embedding the patron each checkout in the response, could violate this rule (this is the case on bug 29275). We need some mechanism to prevent this at a lower level so controller developers don't need to code for that, and also to avoid unintended leaks. Possible implementations will need to standardize things like the one used in bug 29506, which relies on the existence of ->search_limited to filter out forbidden results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 22:13:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 21:13:44 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Blocks| |29275 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 [Bug 29275] Use the API to render checkout history for a biblio -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 22:13:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 21:13:44 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29523 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 [Bug 29523] Add a way to prevent embedding objects that should not be allowed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 22:56:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 21:56:20 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com --- Comment #43 from Manos PETRIDIS --- Is the "new block for plugin_repos" described somewhere? I see that the the system preference for plugins has been removed, but existing koha-conf.xmls have not been updated with the new block, even in commented form. Where is one to find it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 18 23:59:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Nov 2021 22:59:59 +0000 Subject: [Koha-bugs] [Bug 27904] Improve display in creating profile for staging MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27904 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov Status|Needs Signoff |Failed QA --- Comment #2 from Barbara Johnson --- I Failed QA on this one because the "Save profile" button does not become enabled (it is still greyed out) immediately upon typing something in the field. It only becomes enabled upon a click, tab or enter which is confusing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 01:48:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 00:48:23 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127656|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 127819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127819&action=edit Bug 29483: Unit tests This patch updates the AllowRenewalIfOtherItemsAvailable tests to remove deletion of all data, and create specific circ rules for this test. It adjust several other tests that were relying on the rules from this test, so thy too create their opwn specific rules. Additionally, we add tests to cover the case of mutliple items on the record, and some items cannot fill some reserves. What is uncovered here is that the same patron is checked twice, so two holds can be filled, but they only satisfy a single patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 01:48:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 00:48:26 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 --- Comment #4 from Nick Clemens --- Created attachment 127820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127820&action=edit Bug 29483: Check ItemsAnyAvailableAndNotRestricted once per patron ItemsAnyAvailableAndNotRestricted can take a long time and create nested loops. We can check it once per patron, however, this requires us to flip the loops. Since an item can only be used once, we now add a check to see if this item has already been assigned to a borrower. To test: 1 - Find or create a biblio with 100 items 2 - Place ten 'Next available' holds on a biblio 3 - Set preference 'AllowRenewalIfOtherItemsAvailable' to 'Allow' Set circ rules 'On shelf holds allowed' to 'If any unavailable' 4 - Checkout one of the items to a patron, backdated to be overdue 5 - Note a long loading time for the patron's checkouts 6 - Apply patch, restart_all 7 - Patron loads much faster -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 01:51:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 00:51:32 +0000 Subject: [Koha-bugs] [Bug 29524] New: cannot set a new value for privacy_guarantor_checkouts in memberentry.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Bug ID: 29524 Summary: cannot set a new value for privacy_guarantor_checkouts in memberentry.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate: -Set AllowStaffToSetCheckoutsVisibilityForGuarantor to allow. -Look at what the value for privacy_guarantor_checkouts is in the database. -Find a juvenile patron and try to set the value of privacy_guarantor_checkouts opposite of what is in the DB, you cannot. The value stays that same whether you choose yes or no. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 02:15:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 01:15:19 +0000 Subject: [Koha-bugs] [Bug 29525] New: Privacy settings for patrons should also affect holds history Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Bug ID: 29525 Summary: Privacy settings for patrons should also affect holds history Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Adjust Patron Privacy preferences to include holds history into privacy considerations. If patron privacy setting is set to never, never retain holds history (anonymize it). If privacy is set to keep, keep holds history for the patron forever. If privacy is set to default, keep it until library chooses to anonymize hold history. (add holds history functionality or option to batch_anonymise cronjob) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 02:15:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 01:15:29 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 [Bug 20936] Holds history for patrons in OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 02:15:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 01:15:29 +0000 Subject: [Koha-bugs] [Bug 20936] Holds history for patrons in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29525 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 [Bug 29525] Privacy settings for patrons should also affect holds history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 02:17:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 01:17:05 +0000 Subject: [Koha-bugs] [Bug 29526] New: Add 'Immediately delete holds history' button to patron privacy tab in opac Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Bug ID: 29526 Summary: Add 'Immediately delete holds history' button to patron privacy tab in opac Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Currently patrons have an option 'Immediate deletion' to remove/anonymise all checkout history. We should add a new button for immediately deleting holds history and rename the other to indicate it affects only checkout history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 02:17:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 01:17:14 +0000 Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 [Bug 20936] Holds history for patrons in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 02:17:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 01:17:14 +0000 Subject: [Koha-bugs] [Bug 20936] Holds history for patrons in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 02:18:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 01:18:52 +0000 Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 02:19:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 01:19:10 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 05:28:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 04:28:18 +0000 Subject: [Koha-bugs] [Bug 29515] Don't require title for HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29515 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- (In reply to Lucas Gass from comment #2) > +1 > > if you work in this area a lot its becomes a bit tedious to always have to > add a superfluous title I've recently noticed that I can just enter an empty space but it is very annoying... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 08:07:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 07:07:29 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- Hi, There is a small typo in commit message : Don't load items unless a p[atron Causing previous patch to not be obsolete. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 08:12:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 07:12:34 +0000 Subject: [Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Status|Signed Off |BLOCKED --- Comment #13 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 08:15:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 07:15:22 +0000 Subject: [Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 08:15:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 07:15:26 +0000 Subject: [Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127689|0 |1 is obsolete| | Attachment #127690|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy --- Created attachment 127821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127821&action=edit Bug 5229: Remove system preference 'OPACItemsResultsDisplay' We dropped it on bug 12561 when removing the non-XSLT view. This feature has never been implemented for XSLT views and the pref must then be removed. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 08:15:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 07:15:30 +0000 Subject: [Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 --- Comment #15 from Marcel de Rooy --- Created attachment 127822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127822&action=edit Bug 5229: Remove from searching.pref Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 08:15:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 07:15:34 +0000 Subject: [Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 --- Comment #16 from Marcel de Rooy --- Created attachment 127823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127823&action=edit Bug 5229: (QA follow-up) Remove last occurrence in code Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 08:20:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 07:20:46 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |BLOCKED --- Comment #9 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 08:32:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 07:32:19 +0000 Subject: [Koha-bugs] [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 08:32:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 07:32:23 +0000 Subject: [Koha-bugs] [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127697|0 |1 is obsolete| | --- Comment #5 from Fridolin Somers --- Created attachment 127824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127824&action=edit Bug 29436: ES mappings not saved if zebra is configured The mappings must be editable even if ES is not turned on yet. Using a separate array to store the errors as we are testing for $@ || @messages. There is still something wrong that should be improve, but this patch should be safe for backport. Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 08:33:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 07:33:10 +0000 Subject: [Koha-bugs] [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Looks OK to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 08:41:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 07:41:21 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 --- Comment #10 from Marcel de Rooy --- Did we consider the allow_blessed/convert_blessed route in JSON? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 08:43:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 07:43:33 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 08:43:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 07:43:36 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127594|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy --- Created attachment 127825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127825&action=edit Bug 29387: Stringify exception when logging error during a batch mod biblio If an exception is raised by one the methods/subroutines called when batch biblio update, the job will fail in the middle and some records won't be processed. Test plan: 0. Don't apply the patch In KTD you can run the a batch mod biblio on the 100 first records and the worker will fail with """ countered object 'C4::Biblio::_koha_modify_biblioitem_nonmarc(): DBI Exception: DBD::mysql::st execute failed: Data too long for column 'lccn' at row 1 at /kohadevbox/koha/C4/Biblio.pm line 423 ', but neither allow_blessed, convert_blessed nor allow_tags settings are enabled (or TO_JSON/FREEZE method missing) at /kohadevbox/koha/Koha/BackgroundJob/BatchUpdateBiblio.pm line 120. """ The UI is not saying anything about this problem. Generate 100 biblionumbers: perl -e 'for (1..100){print "$_\n"}' 1. Apply the patch and confirm than now you see the detail of the batch update and that biblionumber 72 is marked as not been modified with the correct error (raw DBI error) JK: add executable bit to BatchUpdateBiblio.t Signed-off-by: Joonas Kylmälä Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 08:43:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 07:43:39 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 --- Comment #12 from Marcel de Rooy --- Created attachment 127826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127826&action=edit Bug 29387: Stringify exceptions for other background job modules Signed-off-by: Joonas Kylmälä Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 08:43:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 07:43:43 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 --- Comment #13 from Marcel de Rooy --- Created attachment 127827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127827&action=edit Bug 29387: (QA follow-up) Fix modules in test Can't locate object method "new" via package "Koha::BackgroundJob::BatchUpdateBiblio" (perhaps you forgot to load "Koha::BackgroundJob::BatchUpdateBiblio"?) at t/db_dependent/Koha/BackgroundJobs/BatchUpdateBiblio.t line 45. How did it pass at signoff? Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 08:44:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 07:44:24 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127595|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 08:50:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 07:50:33 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |BLOCKED --- Comment #9 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 08:57:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 07:57:40 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 08:57:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 07:57:43 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127539|0 |1 is obsolete| | --- Comment #2 from Fridolin Somers --- Created attachment 127828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127828&action=edit Bug 29458: Reorder login elements Make masthead.inc modal and opac-auth follow the order of the login elements on the homepage. Test plan: Enable prefs for reset password and self registration. Fill additional contents for login instructions. Logout on OPAC. Click Login from your account on top bar. Click Login button on the home page (right side, in the middle). Verify that these two forms correspond with the home page login. Signed-off-by: Marcel de Rooy Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 08:58:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 07:58:53 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 --- Comment #13 from Martin Renvoize --- Damn.. t/db_dependant/Koha/Checkouts/ReturnClaim.pm is failing.. can't for the life of me work out what the particular test is testing for (Why it's using builder to test for a allow null?) or why TestBuilder itself doesn't like a constraint drop... (Tests fails before and after running the included DB update).. Any help at the QA stage gratefully appreciated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 08:59:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 07:59:43 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #3 from Fridolin Somers --- Looks way better :D In opac-auth, with should also fix : You may register here. instead of Don't have an account? Register here. Maybe in another bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 09:01:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 08:01:50 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127659|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize --- Created attachment 127829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127829&action=edit Bug 28854: Database update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 09:01:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 08:01:55 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127660|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize --- Created attachment 127830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127830&action=edit Bug 28854: DBIC Schema Updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 09:02:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 08:02:00 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127661|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize --- Created attachment 127831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127831&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point 1) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 2) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 3) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. TODO: Add Object Tests + API Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 09:02:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 08:02:05 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127662|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize --- Created attachment 127832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127832&action=edit Bug 28854: Add bundle content display to OPAC TODO: Move expand button to right like staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 09:02:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 08:02:10 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127663|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize --- Created attachment 127833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127833&action=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 09:02:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 08:02:15 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127664|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize --- Created attachment 127834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127834&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that it is marked as lost. 4) Navigate to the biblio for the collection and expand the collection item that contains the lost item. Note the item is marked as lost and checkout details are listed. 5) Checkin the lost item * The item should be marked as found and the return_claims line should be marked as resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 09:02:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 08:02:20 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #62 from Martin Renvoize --- Created attachment 127835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127835&action=edit Bug 28854: Drop unique index on issue_id in return claims With the introduction of circulating items within a bundle set, we can now loose multiple items from the bundle from the same issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 09:02:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 08:02:25 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #63 from Martin Renvoize --- Created attachment 127836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127836&action=edit Bug 28854: DBIC Update ReturnClaim Schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 09:02:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 08:02:30 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127666|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize --- Created attachment 127837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127837&action=edit Bug 28854: Highlight bundle rows to clarify UI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 09:02:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 08:02:34 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #65 from Martin Renvoize --- Created attachment 127838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127838&action=edit Bug 28854: Simplified status handling for bundle inventory check -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 09:03:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 08:03:47 +0000 Subject: [Koha-bugs] [Bug 29527] New: Convert item tables from pre-loading all order data to ajax tables Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29527 Bug ID: 29527 Summary: Convert item tables from pre-loading all order data to ajax tables Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: mathsabypro at gmail.com QA Contact: testopia at bugs.koha-community.org Hi With many items, a record takes age to display in OPAC (same issue in staff interface). This is a big issue for serials. Koha should fetch the record, display it, then fetch item data and display the table, with a pagination system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 09:05:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 08:05:11 +0000 Subject: [Koha-bugs] [Bug 29527] Convert item tables from pre-loading all items data to ajax tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29527 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Convert item tables from |Convert item tables from |pre-loading all order data |pre-loading all items data |to ajax tables |to ajax tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 09:07:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 08:07:21 +0000 Subject: [Koha-bugs] [Bug 27683] Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116767|0 |1 is obsolete| | --- Comment #4 from Fridolin Somers --- Created attachment 127839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127839&action=edit Bug 27683: Unit test for GetAnalyticsCount Run prove t/db_dependent/Items/GetAnalyticsCount.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 09:07:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 08:07:34 +0000 Subject: [Koha-bugs] [Bug 27683] Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116768|0 |1 is obsolete| | --- Comment #5 from Fridolin Somers --- Created attachment 127840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127840&action=edit Bug 27683: Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref C4::Items::GetAnalyticsCount is part of the easy analytics feature. Like Bug 20702 make early return when the system preference EasyAnalyticalRecords is disabled. Actually it may block an item deletion for wrong reason. Test plan : 1) Dont apply patch 2) Build an item and a linked analytical record with 773$0 and $9 3) Enable EasyAnalyticalRecords 4) Try to delete the item 5) You have an alert because linked to analytics 6) Disable EasyAnalyticalRecords 7) Try to delete the item 8) You have an alert because linked to analytics 9) Apply patch 10) Try to delete the item 11) No alert, it works :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 09:07:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 08:07:48 +0000 Subject: [Koha-bugs] [Bug 27683] Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116769|0 |1 is obsolete| | --- Comment #6 from Fridolin Somers --- Created attachment 127841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127841&action=edit Bug 27683: Impact on catalogue/detail.pl Since EasyAnalyticalRecords pref is now in GetAnalyticsCount, remove test in catalogue/detail.pl. Test plan : 1) Build an item and a linked analytical record with 773$0 and $9 2) Go to record detail page 3) Enable EasyAnalyticalRecords 4) You see analytics tab and analytical count on item 5) Disable EasyAnalyticalRecords 6) You dont see analytics tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 09:32:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 08:32:37 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 09:32:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 08:32:41 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127516|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy --- Created attachment 127842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127842&action=edit Bug 29437: Unit tests Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 09:32:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 08:32:44 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127517|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy --- Created attachment 127843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127843&action=edit Bug 29437: Search reservoir for term as title, author, or variations of ISBN The code in the script and the module attempt to determine whether a term is an isbn, or not. Rather than try to do this, we can simply search it on the three fields: isbn, title, author Additionally, we should search as any of the ISBN variations to broaden our matches Note: Curently only an ISBN 10 is stored in import biblios, so for an ISBN13 that doesn't convert the value will be blank - this is another bug To test: 1 - Perform a cataloging search for a valid ISBN 13 with no ISBN10 counterpart: 9798200834976 2 - 500 error 3 - Apply patch 4 - Repeat, no results 5 - Import some records 6 - Search by title/author/isbn 7 - Confirm searching works as expected WNC amended to fix spelling Signed-off-by: David Nind Signed-off-by: Marcel de Rooy AMENDED: Useless call of ISBNs (plural) when you only pass one parameter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 09:32:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 08:32:48 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 --- Comment #12 from Marcel de Rooy --- Created attachment 127844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127844&action=edit Bug 29437: (QA follow-up) Remove Business::ISBN from addbooks Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 09:32:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 08:32:51 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 --- Comment #13 from Marcel de Rooy --- Created attachment 127845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127845&action=edit Bug 29437: (QA follow-up) Update TODO in Breeding.t We now have some tests for BreedingSearch. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 09:36:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 08:36:38 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 --- Comment #14 from Marcel de Rooy --- (In reply to David Nind from comment #8) > Note: Curently only an ISBN 10 is stored in import biblios, so for an ISBN13 > that doesn't convert > the value will be blank - this is another bug Did you open a new report ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 09:39:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 08:39:20 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 --- Comment #15 from Marcel de Rooy --- Looks good enough to me. A funny side effect is that we find reservoir books via the ISBN variations 10/13/hypens/no hyphens. We wont find them in the catalog. But if we search for a partial isbn 545 (as being part of eg 0-545-01022-5), we will not find anything in the reservoir, but Zebra finds it in the catalog. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 09:55:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 08:55:34 +0000 Subject: [Koha-bugs] [Bug 29463] Umlauts in search field get changed into Replacement character In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 09:55:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 08:55:37 +0000 Subject: [Koha-bugs] [Bug 29463] Umlauts in search field get changed into Replacement character In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127593|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 127846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127846&action=edit Bug 29463: Escape utf8 characters before appending search query to url To test: 1) go to the main page of Koha and search in the "Check out" search window type "näyttö". 2) see that umlauts got replaced with replacement characters. 3) apply the patch. 4) repeat 1-2, ensure that umlauts displayed correctly and are not getting replaced with replacement characters. JK: remove period from commit title Signed-off-by: Joonas Kylmälä Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 09:55:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 08:55:55 +0000 Subject: [Koha-bugs] [Bug 29463] Umlauts in search field get changed into Replacement character In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 10:00:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 09:00:29 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 --- Comment #10 from Alex Arnaud --- Created attachment 127847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127847&action=edit Bug 29393 - Don't show notice templates for each language -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 10:01:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 09:01:51 +0000 Subject: [Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #7 from marion.durand at biblibre.com --- Thank you Jonathan for moving my patch here ! (When I created Bug 29499 I couldn't find this one, sorry for the duplicated bug.) Everything seems good to me. Since I have made one of the patches, should I signoff the other one or not ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 10:07:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 09:07:35 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #26 from Marcel de Rooy --- (In reply to Nick Clemens from comment #21) > I disagree here, I think we should remove the FK to branches as the quick > fix. > > While we may have opinions about how that feature was implemented, it has > been implemented. Statistics is a ledger of transactions - foreign keys are > going to remove/nullify data after the fact and I think that would be > incorrect. > > If Pseudonymized transactions are meant to mirror the statistics table then > I feel we should remove the FK for now, and fix the larger issue with > OPACRenew etc on a new bug. > > Adding a new branch is going to add the branch in many places throughout > Koha and will impact workflows Fair enough -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 10:08:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 09:08:09 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #27 from Marcel de Rooy --- KEY `pseudonymized_transactions_ibfk_1` (`categorycode`), KEY `pseudonymized_transactions_borrowers_ibfk_2` (`branchcode`), KEY `pseudonymized_transactions_borrowers_ibfk_3` (`transaction_branchcode`) When removing the FKs, the question is: Do we still need those indexes? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 10:08:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 09:08:53 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 10:08:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 09:08:56 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127727|0 |1 is obsolete| | --- Comment #28 from Marcel de Rooy --- Created attachment 127848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127848&action=edit Bug 29341: Remove foreign keys on pseudonymized_transactions Behave like the statistics table and don't remove the code even if the branch or patron's category is removed. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 10:10:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 09:10:33 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #29 from Marcel de Rooy --- OK We took the other turn :) Apart from comment27 no further questions. Trivial enough to combine SO and QA at this late time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 10:34:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 09:34:30 +0000 Subject: [Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #8 from Jonathan Druart --- (In reply to marion.durand from comment #7) > Thank you Jonathan for moving my patch here ! > > (When I created Bug 29499 I couldn't find this one, sorry for the duplicated > bug.) > > Everything seems good to me. Since I have made one of the patches, should I > signoff the other one or not ? Yes, please :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 10:40:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 09:40:48 +0000 Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 --- Comment #5 from Martin Renvoize --- This looks good.. My one query is around the `|| !C4::Context->preference('CalculateFinesOnReturn')` introduction.. I'm not sure if that's the behaviour we want/expect.. should we still increment a fine after return here? I realise, it's to do with the job being long running and so the patron has 'got away with it' as it were.. but we could be introducing questions if the patron returns their item, pays their fine and then finds they have a bit more to pay after the fact because the calculations were still running? Otherwise, I think this is a great little improvement. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 10:41:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 09:41:46 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 --- Comment #14 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #13) > Created attachment 127827 [details] [review] > Bug 29387: (QA follow-up) Fix modules in test > > Can't locate object method "new" via package > "Koha::BackgroundJob::BatchUpdateBiblio" (perhaps you forgot to load > "Koha::BackgroundJob::BatchUpdateBiblio"?) at > t/db_dependent/Koha/BackgroundJobs/BatchUpdateBiblio.t line 45. > > How did it pass at signoff? > > Signed-off-by: Marcel de Rooy Thanks for the follow-up. It got broken by bug 28413 that was pushed in the meanwhile. (In reply to Marcel de Rooy from comment #10) > Did we consider the allow_blessed/convert_blessed route in JSON? I didn't, we could but I wouldn't introduce such changes for 21.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 10:49:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 09:49:45 +0000 Subject: [Koha-bugs] [Bug 29521] Patron Club name hyperlinks not operational + weird CSS behavior In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 10:49:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 09:49:47 +0000 Subject: [Koha-bugs] [Bug 29521] Patron Club name hyperlinks not operational + weird CSS behavior In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127818|0 |1 is obsolete| | --- Comment #2 from Andreas Roussos --- Created attachment 127849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127849&action=edit Bug 29521: Fix style of patron clubs table when in clubs management This patch follows up Bug 24627 to add some additional template logic to the table of clubs so that the interface is consistent whether you're looking at clubs during the holds process or during the clubs management view. The ways Bug 24627 made the clubs list more consistent with patron search results made it LESS consistent with the Clubs management interface. To test, apply the patch and go to Tools -> Patron clubs. - Scroll down to the "Clubs" table, below the "Club templates" table. - In the table of clubs, the club name should not be a link. - Hovering your mouse over the table should not highlight each row. Confirm the previous behavior of a clubs search when placing a hold: - Search the catalog and start the process of placing a hold on an item. - On the "Place hold" page, click the "Clubs" tab and perform a search which will return multiple clubs. - In this view, the club name should be a link. Clicking it should select that club for the hold. - You should also be able to click anywhere in the row to select the club for the hold. Signed-off-by: Andreas Roussos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 10:57:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 09:57:16 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #14 from Jonathan Druart --- Created attachment 127850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127850&action=edit Bug 29478: (follow-up) Today should select now for pastinclusive This is getting ugly. We need to add 1 minute for the minDate or the 'Today' link may not work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 10:58:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 09:58:09 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #15 from Jonathan Druart --- (In reply to Owen Leonard from comment #13) > The patch in Comment 9 still needs a signoff. Looks good to me, but I prefer to see someone else testing this. Especially because I found (and fix) yet another problem... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 10:58:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 09:58:33 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 10:58:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 09:58:55 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 10:59:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 09:59:03 +0000 Subject: [Koha-bugs] [Bug 29500] Flatpickr accepting original date in the past for futuredate but also other dates in the past In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29500 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 11:03:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 10:03:49 +0000 Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 --- Comment #6 from Martin Renvoize --- Created attachment 127851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127851&action=edit Bug 18855: Don't create duplicate overdue fines if an issue is returned If cronjobs/fines.pl is running during circulation hours, then an issue may be considered for having it's overdue fine updated after the issue has been returned and it's fine status flipped from 'UNRETURNED' to 'RETURNED'. In this case UpdateFine will create a duplicate fine because it can't find the specific accountline for the overdue and unreturned fine. This changes UpdateFine to not care about status, so the accountline will be found, until it comes to adjusting the fine. At this point if the fine is 'UNRETURNED' or 'CalculateFinesOnReturn' is off (the book was returned and it's overdue fine status flipped, but the amount wasn't updated), then go ahead and adjust the fine amount. Test plan: 1. find an overdue fine near the end of the list of overdue fines that cronjobs/fines.pl will be considering. 2. start cronjobs/fines.pl. 3. immediately check in the overdue book. 4. once fines.pl is finished observe that a duplicate overdue fine has been created on the patrons account. 5. apply patch. 6. repeat 1 - 4 and observe that the duplicate fine was not created. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 11:03:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 10:03:53 +0000 Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 --- Comment #7 from Martin Renvoize --- Created attachment 127852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127852&action=edit Bug 18855: (follow-up) Restore CalculateFinesOnReturn behaviour This patch removes the check for a disabled 'CalculateFinesOnReturn' to restore the behaviour prior to this patch series. If a patron has returned the item during the fines cron run, they may well have been charged a reduced fine at check-in time. However, I feel that the fine should not then increment/decrement behind the scenes after the check-in. This is to reduce confusion for end users and librarians alike. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 11:05:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 10:05:10 +0000 Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127816|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 11:05:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 10:05:34 +0000 Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Martin Renvoize --- Signing off.. leaving to QA/RM to decide whether to keep my follow-up or not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 11:07:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 10:07:41 +0000 Subject: [Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 marion.durand at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 11:07:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 10:07:44 +0000 Subject: [Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 marion.durand at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127781|0 |1 is obsolete| | --- Comment #9 from marion.durand at biblibre.com --- Created attachment 127853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127853&action=edit Bug 29496: (bug 27526 follow-up) Fix item form validation The validation of the forms were blocked with "X item mandatory fields empty" when at least one dropdown list subfield was marked as mandatory. We need to add the 'input_marceditor' class to the select (does it actually make sense? select vs input...) Caused by commit 6ed29bccef590a1bc5e4cea175b41b8024483320 Bug 27526: Fix mandatory and important checks Which lamentably failed as it was stating: "Using .input_marceditor let us fix the additem.tt form and prevent to break the other ones" Signed-off-by: Marion Durand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 11:14:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 10:14:09 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #44 from Jonathan Druart --- (In reply to Manos PETRIDIS from comment #43) > Is the "new block for plugin_repos" described somewhere? I see that the the > system preference for plugins has been removed, but existing koha-conf.xmls > have not been updated with the new block, even in commented form. Where is > one to find it? Hi Manos, it's in the source: https://git.koha-community.org/Koha-community/Koha/src/commit/7bddfeb412e427ee8c02c700295382fe4a7340d6/debian/templates/koha-conf-site.xml.in#L406 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 11:17:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 10:17:48 +0000 Subject: [Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #10 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #6) > Created attachment 127781 [details] [review] > Bug 29496: (bug 27526 follow-up) Fix item form validation > > The validation of the forms were blocked with "X item mandatory fields > empty" when at least one dropdown list subfield was marked as mandatory. > > We need to add the 'input_marceditor' class to the select (does it > actually make sense? select vs input...) > > Caused by > commit 6ed29bccef590a1bc5e4cea175b41b8024483320 > Bug 27526: Fix mandatory and important checks > Which lamentably failed as it was stating: > "Using .input_marceditor let us fix the additem.tt form and prevent to break > the other ones" No test plan? Please explain how the addorderiso2709 change is supposed to work? This template does not use cataloging.js. I do not see the connection (yet)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 11:20:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 10:20:08 +0000 Subject: [Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #11 from Marcel de Rooy --- (In reply to marion.durand from comment #9) > Signed-off-by: Marion Durand What did you test, Marion ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 11:25:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 10:25:41 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #28 from Marcel de Rooy --- + code => $code || 'tmp_code', Please explain. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 11:27:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 10:27:58 +0000 Subject: [Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #12 from marion.durand at biblibre.com --- (In reply to Marcel de Rooy from comment #11) > (In reply to marion.durand from comment #9) > > Signed-off-by: Marion Durand > > What did you test, Marion ? I tested test plan given by the first patch and test plan given by Koha Team University Lyon 3 (fist comment) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 11:35:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 10:35:07 +0000 Subject: [Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #13 from Marcel de Rooy --- >From IRC: [11:28] <@Joubu> marcelr: it matches the pattern, and the pattern is: select with name="field_value" has input_marceditor class [11:29] <@Joubu> if we don't add on addorderiso, it will be the only place where input_marceditor is not set to selects with name="field_value" That makes sense :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 11:35:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 10:35:49 +0000 Subject: [Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #14 from Marcel de Rooy --- (In reply to marion.durand from comment #12) > (In reply to Marcel de Rooy from comment #11) > > (In reply to marion.durand from comment #9) > > > Signed-off-by: Marion Durand > > > > What did you test, Marion ? > > I tested test plan given by the first patch and test plan given by Koha Team > University Lyon 3 (fist comment) Thanks for your fast response. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 11:37:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 10:37:22 +0000 Subject: [Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 11:37:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 10:37:26 +0000 Subject: [Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127780|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy --- Created attachment 127854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127854&action=edit Bug 29496: CheckMandatorySubfields don't work properly with select field in serials-edit.tt Since one of the patches of BZ 27526 (Bug 27526: Fix mandatory and important checks), CheckMandatorySubfields use the class "input_marceditor" but in file serials-edit.tt this class is not set for all field (it is present on text input but not on select input) 5 9- Check that no error appear and that your item has been created. In consequence if a select field is set as mandatory, it is detected as missing even if it is filed and so you can't submit the form and receive the new serial. Test plan: 0- Be sure to be in a version of koha where the patch that introduces the bug is present (it is present in master since Jul 8 2021 (it is present in 21.06.00.046) and will be pushed in 21.11.00) 1- Create (or find) a subscription for a biblio record and select the option "Create an item record when receiving this serial" 2- Be sure to have at least one mandatory subfield that is filed with a select input in the framework used by the biblio record. (ex: 995$b, 995$c or 995$e in unimarc; 952$a, 952$b or 952$c in marc21) 3- From the subscription-detail page click on "Receive" 4- Change the status to "Arrived" and fill the item form that appears. 5- Click on "Save" 6- Check that an error box appear with the message " Form not submitted because of the following problem(s) 1 mandatory fields empty (highlighted)" (the number can be different according to the number of concerned subfields) 7- Apply the patch 8- Repeat step 3 to 5 9- Check that no error appear and that your item has been created JD amended patch: remove comma to separate classes Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 11:37:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 10:37:29 +0000 Subject: [Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127853|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy --- Created attachment 127855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127855&action=edit Bug 29496: (bug 27526 follow-up) Fix item form validation The validation of the forms were blocked with "X item mandatory fields empty" when at least one dropdown list subfield was marked as mandatory. We need to add the 'input_marceditor' class to the select (does it actually make sense? select vs input...) Caused by commit 6ed29bccef590a1bc5e4cea175b41b8024483320 Bug 27526: Fix mandatory and important checks Which lamentably failed as it was stating: "Using .input_marceditor let us fix the additem.tt form and prevent to break the other ones" Signed-off-by: Marion Durand Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 11:37:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 10:37:50 +0000 Subject: [Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 11:38:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 10:38:32 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #29 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #28) > + code => $code || 'tmp_code', > > Please explain. The code is mandatory at DB level so we must add a temporary code during the insert, then update it after I feel like it should actually be 'tmp_code' always, at this point we are creating a new entry and $code should never be set. We could add the following change diff --git a/tools/additional-contents.pl b/tools/additional-contents.pl index e63a44a809a..59721e24b2a 100755 --- a/tools/additional-contents.pl +++ b/tools/additional-contents.pl @@ -159,7 +159,7 @@ elsif ( $op eq 'add_validate' ) { my $additional_content = Koha::AdditionalContent->new( { category => $category, - code => $code || 'tmp_code', + code => 'tmp_code', location => $location, branchcode => $branchcode, title => $title, @@ -173,13 +173,11 @@ elsif ( $op eq 'add_validate' ) { )->store; eval { $additional_content->store; - unless ($code) { - $additional_content->discard_changes; - $code = $category eq 'news' - ? 'News_' . $additional_content->idnew - : $location . '_' . $additional_content->idnew; - $additional_content->code($code)->store; - } + $additional_content->discard_changes; + $code = $category eq 'news' + ? 'News_' . $additional_content->idnew + : $location . '_' . $additional_content->idnew; + $additional_content->code($code)->store; }; if ($@) { $success = 0; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 11:53:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 10:53:09 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 11:53:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 10:53:13 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125696|0 |1 is obsolete| | --- Comment #30 from Marcel de Rooy --- Created attachment 127856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127856&action=edit Bug 29113: Hide code for additional contents and generate it additional_contents.code is used to group DB rows together. Each row represent one content in a given language, and the code is used to know they are translation of the lang='default' one. It's not really useful for the end user and we could hide it and generate it. Test plan: Create/Edit/Delete additional contents (news and HTML customizations) and confirm that they are correctly grouped together. You need several languages installed to test this patch correctly. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 11:53:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 10:53:17 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127365|0 |1 is obsolete| | --- Comment #31 from Marcel de Rooy --- Created attachment 127857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127857&action=edit Bug 29113: Fix random assignation Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 11:53:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 10:53:56 +0000 Subject: [Koha-bugs] [Bug 29010] Weight input pattern wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29010 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Keywords| |rel_21_11_candidate CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 11:54:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 10:54:04 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #32 from Marcel de Rooy --- Works, but the 'code' could be nicer. Still time for another QAer today? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 12:03:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 11:03:09 +0000 Subject: [Koha-bugs] [Bug 28832] Batch modification always clears permanent_location if it is mapped in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832 --- Comment #11 from Jonathan Druart --- After bug 28445 I don't recreate the problem. Can you confirm, Nick? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 12:42:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 11:42:51 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125060|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 12:46:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 11:46:51 +0000 Subject: [Koha-bugs] [Bug 29415] Wrong number of received items/quantity shown in several places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29415 --- Comment #1 from Jonathan Druart --- Created attachment 127858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127858&action=edit Bug 29415: Fix quantity display in acq module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 12:47:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 11:47:27 +0000 Subject: [Koha-bugs] [Bug 29415] Wrong number of received items/quantity shown in several places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29415 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart --- Just a try, but I haven't test the patch deeply for different situations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 13:13:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 12:13:29 +0000 Subject: [Koha-bugs] [Bug 29463] Umlauts in search field get changed into replacement character In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Umlauts in search field get |Umlauts in search field get |changed into Replacement |changed into replacement |character |character -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 13:15:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 12:15:03 +0000 Subject: [Koha-bugs] [Bug 29496] Can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|can't save an order with |Can't save an order with |mandatory items subfields |mandatory items subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 13:16:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 12:16:34 +0000 Subject: [Koha-bugs] [Bug 29520] addtoadditional-contents wont display News items or HTML customizations if the expiration date is in the past In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29520 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|addtioadditional-contents |addtoadditional-contents |wont display News items or |wont display News items or |HTML customizations if the |HTML customizations if the |expiration date is in the |expiration date is in the |past |past -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 13:18:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 12:18:43 +0000 Subject: [Koha-bugs] [Bug 29524] cannot set a new value for privacy_guarantor_checkouts in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 13:20:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 12:20:50 +0000 Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 --- Comment #6 from Katrin Fischer --- (In reply to Owen Leonard from comment #5) > It seems odd to me that the AutoEmailOpacUser preference ONLY works if > you're adding someone from the staff interface. A more comprehensive > solution might add a flag to the patron account so that a cron job could > send the notice to any new (unflagged) accounts periodically, whether they > were created by self-registration, patron import, or manually via the staff > interface. > > If we did it like that it would be relatively easy to trigger the re-sending > of a notice by toggling the flag on the patron's acccount, thereby putting > them back into the notification queue. +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 13:28:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 12:28:00 +0000 Subject: [Koha-bugs] [Bug 29087] Holds to pull list can crash with a SQL::Abstract puke In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087 --- Comment #1 from Jonathan Druart --- Created attachment 127859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127859&action=edit Bug 29087: Prevent filter_by_for_hold to crash if default holdallowed is not_allowed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 13:29:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 12:29:01 +0000 Subject: [Koha-bugs] [Bug 29087] Holds to pull list can crash with a SQL::Abstract puke In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart --- This seems to be the way to go, but I don't think it's ready for integration. We should have the logic moved to Koha::ItemTypes and add test coverage. Will try and come back to this later. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 13:30:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 12:30:13 +0000 Subject: [Koha-bugs] [Bug 29087] Holds to pull list can crash with a SQL::Abstract puke In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |3142 Severity|normal |major Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 [Bug 3142] Standardize how OPAC and staff determine requestability -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 13:30:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 12:30:13 +0000 Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29087 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087 [Bug 29087] Holds to pull list can crash with a SQL::Abstract puke -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 13:31:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 12:31:02 +0000 Subject: [Koha-bugs] [Bug 29087] Holds to pull list can crash with a SQL::Abstract puke In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087 --- Comment #3 from Jonathan Druart --- Galen, thanks for reporting this bug! Are you seeing this in master or stable? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 13:35:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 12:35:05 +0000 Subject: [Koha-bugs] [Bug 23857] Club holds endpoint not setting Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|In Discussion |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 13:47:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 12:47:05 +0000 Subject: [Koha-bugs] [Bug 29514] ILL requests: Remove extraneous › HTML entity from breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29514 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 13:47:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 12:47:09 +0000 Subject: [Koha-bugs] [Bug 29514] ILL requests: Remove extraneous › HTML entity from breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29514 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127787|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 127860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127860&action=edit Bug 29514: Remove extraneous HTML entity from breadcrumbs The template file for ILL requests has a small typo in the breadcrumbs section: there exists an extra › HTML entity after "Home". This patch fixes that. Test plan: 1) Access the ILL requests module, and notice how an extra character is displayed after "Home" in the breadcrumbs. 2) Apply this patch. 3) Refresh the page -- the extra character is no longer displayed. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 13:51:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 12:51:08 +0000 Subject: [Koha-bugs] [Bug 29515] Don't require title for HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29515 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 13:56:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 12:56:55 +0000 Subject: [Koha-bugs] [Bug 29528] New: Breadcrumbs on HTML customizations take you to news Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 Bug ID: 29528 Summary: Breadcrumbs on HTML customizations take you to news Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Go to HTML customizations and click on it in the breadbrumbs and you'll end up on News. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 14:11:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 13:11:26 +0000 Subject: [Koha-bugs] [Bug 29515] Don't require title for HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29515 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 14:11:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 13:11:30 +0000 Subject: [Koha-bugs] [Bug 29515] Don't require title for HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29515 --- Comment #4 from Katrin Fischer --- Created attachment 127861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127861&action=edit Bug 29515: Make title for HTML customizations optional This adds code to make the title field for HTML customizations optional while it stays mandatory for news entries. 1) Add a new HTML customization, verify you are forced to enter a title 2) Apply patch 3) Repeat and verify that you can now save without title 4) Add a new news entry 5) Verify that the title field remained mandatory there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 14:18:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 13:18:27 +0000 Subject: [Koha-bugs] [Bug 29513] Accessibility: Staff Client - Convert remaining breadcrumbs sections from div to nav blocks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29513 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 14:18:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 13:18:31 +0000 Subject: [Koha-bugs] [Bug 29513] Accessibility: Staff Client - Convert remaining breadcrumbs sections from div to nav blocks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29513 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127786|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 127862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127862&action=edit Bug 29513: Convert remaining breadcrumbs div blocks into nav As per https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27846#c0, breadcrumbs should adhere to the WAI-ARIA Authoring Practices. Most Staff Client template files have already been fixed, but there were a few that were missed. This patch fixes that. Test plan: 1) Apply this patch. 2) Visit these pages in the Staff Client: Home > Acquisitions > TestVendor > Basket TestBasket (1) for TestVendor (*) Home > Administration > Set library checkin and transfer policy (**) Home > Patrons > Merge patron records (***) ...and confirm that the breadcrumbs display correctly. (*) Can be accessed by creating a test basket for a test vendor (**) Can be found under Administration -> Patrons and circulation (***) Can be found by trying to merge two Patron records Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 14:18:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 13:18:34 +0000 Subject: [Koha-bugs] [Bug 29513] Accessibility: Staff Client - Convert remaining breadcrumbs sections from div to nav blocks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29513 --- Comment #4 from Katrin Fischer --- Created attachment 127863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127863&action=edit Bug 29513: (QA follow-up) Fix TT filters Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 14:31:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 13:31:42 +0000 Subject: [Koha-bugs] [Bug 29132] API access denied after update to 19.11.22 due to not executed atomicupdate for api keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29132 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |wainuiwitikapark at catalyst.n | |et.nz Depends on| |28772 --- Comment #2 from Jonathan Druart --- Wainui, did you see this bug report? You forgot to move the atomicupdate to the updatedatabase.pl script. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28772 [Bug 28772] Any user that can work with reports can see API keys of any other user -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 14:31:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 13:31:42 +0000 Subject: [Koha-bugs] [Bug 28772] Any user that can work with reports can see API keys of any other user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28772 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29132 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29132 [Bug 29132] API access denied after update to 19.11.22 due to not executed atomicupdate for api keys -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 14:33:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 13:33:34 +0000 Subject: [Koha-bugs] [Bug 29050] Add punctuation in Unseen Renewals message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |trivial Keywords| |Academy CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 14:37:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 13:37:27 +0000 Subject: [Koha-bugs] [Bug 29521] Patron Club name hyperlinks not operational + weird CSS behavior In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 14:37:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 13:37:31 +0000 Subject: [Koha-bugs] [Bug 29521] Patron Club name hyperlinks not operational + weird CSS behavior In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127849|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 127864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127864&action=edit Bug 29521: Fix style of patron clubs table when in clubs management This patch follows up Bug 24627 to add some additional template logic to the table of clubs so that the interface is consistent whether you're looking at clubs during the holds process or during the clubs management view. The ways Bug 24627 made the clubs list more consistent with patron search results made it LESS consistent with the Clubs management interface. To test, apply the patch and go to Tools -> Patron clubs. - Scroll down to the "Clubs" table, below the "Club templates" table. - In the table of clubs, the club name should not be a link. - Hovering your mouse over the table should not highlight each row. Confirm the previous behavior of a clubs search when placing a hold: - Search the catalog and start the process of placing a hold on an item. - On the "Place hold" page, click the "Clubs" tab and perform a search which will return multiple clubs. - In this view, the club name should be a link. Clicking it should select that club for the hold. - You should also be able to click anywhere in the row to select the club for the hold. Signed-off-by: Andreas Roussos Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 14:42:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 13:42:46 +0000 Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create mysqluser@mysql_hostname so zebra update fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 --- Comment #39 from Katrin Fischer --- Created attachment 127865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127865&action=edit Bug 10517: Use `DROP USER IF EXISTS` and remove ` || true`. When restoring a Koha instance, and the database user does not exist, an error is shown, although it is prevented from stopping the script by ` || true`. This patch removes the ` || true` guard, and rather uses `DROP USER IF EXISTS` which does exactly what one would expect, without confusing error messages, whether the user existed or not. To test: 1) Assume your Koha instance is called `asdf`. 1) Export the Koha instance using `koha-dump`. 2) Remove the instance completely using `koha-remove`. 3) Import it again using `koha-restore`. 4) No error should be shown, and the import should work. There was NO user to drop, therefore `DROP USER IF EXISTS` did nothing. 5) A database user called `koha_asdf` should exist, and have all privileges on the database of the same name. 6) Remove the instance again using `koha-remove`. 7) Now create a database user in MySQL called `koha_instance` where instance is the name of your dumped koha instance. 8) Import your koha instance again using `koha-restore`. 9) Again, no error should be shown, and the import should work. There WAS a user to drop, therefore `DROP USER IF EXISTS` dropped the user before creating a new one. 10) Again, a database user called `koha_asdf` should exist, and have all privileges on the database of the same name. Sponsored-by: Reformational Study Centre -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 14:43:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 13:43:06 +0000 Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create mysqluser@mysql_hostname so zebra update fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96975|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 14:43:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 13:43:43 +0000 Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create mysqluser@mysql_hostname so zebra update fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 --- Comment #40 from Katrin Fischer --- Martin, are we missing your sign-off line here? I think you were the one to switch to signed-off. Fixed the author line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 14:55:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 13:55:14 +0000 Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Blocks| |25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 14:55:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 13:55:14 +0000 Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29040 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 [Bug 29040] Uninitialized value warning in Languages.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 14:57:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 13:57:20 +0000 Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 14:57:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 13:57:25 +0000 Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 --- Comment #4 from Jonathan Druart --- Created attachment 127866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127866&action=edit Bug 29040: Remove warning from the itemtype edit view Use of uninitialized value $interface in concatenation (.) or string at /kohadevbox/koha/C4/Languages.pm line 121. We are expecting "intranet" or "opac", here we sent undef which raises a warning. For no change in behaviour we can send "both" (or whatever different than "intranet" and "opac"). Test plan: Hit /cgi-bin/koha/admin/itemtypes.pl?op=add_form&itemtype=BK Notice that the warning does no longer appear in the logs with the patch applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 14:57:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 13:57:26 +0000 Subject: [Koha-bugs] [Bug 29529] New: Fix \n in hint on Koha to MARC mappings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29529 Bug ID: 29529 Summary: Fix \n in hint on Koha to MARC mappings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The \n don't work in translations as Pootle escapes them. We should not use them in translatable text and have fixed other occurences in the past: koha-tmpl/intranet-tmpl/prog/en/modules/admin/koha2marclinks.tt:86 Please enter field tag and subfield code, separated by a comma. (For control fields: add '@' as subfield code.)\nThe change will be applied immediately. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:02:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:02:47 +0000 Subject: [Koha-bugs] [Bug 29053] ILSDI Internal Server errors seem not to log anywhere? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29053 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart --- Looks good to me on master. /cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=1&bib_id=1&item_id=1&expiry_date=3214 I am getting a stacktrace in the logs ==> /var/log/koha/kohadev/plack-error.log <== Invalid date '3214' passed to output_pref at /usr/share/perl5/Exception/Class/Base.pm line 88 Exception::Class::Base::throw('Koha::Exceptions::WrongParameter', 'Invalid date \'3214\' passed to output_pref') called at /kohadevbox/koha/Koha/DateUtils.pm line 276 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:07:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:07:49 +0000 Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org --- Comment #1 from George Williams (NEKLS) --- +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:08:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:08:17 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org --- Comment #1 from George Williams (NEKLS) --- +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:11:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:11:01 +0000 Subject: [Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 --- Comment #17 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #16) > Created attachment 127823 [details] [review] > Bug 5229: (QA follow-up) Remove last occurrence in code > > Signed-off-by: Marcel de Rooy I let it there on purpose. At the time it made sense to keep it, today I don't know why we should keep it :D I will skip the patch as it will (easy) conflict with bug 29494 that is removing completely the file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:11:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:11:11 +0000 Subject: [Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127823|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:15:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:15:29 +0000 Subject: [Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:15:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:15:32 +0000 Subject: [Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 --- Comment #18 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:15:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:15:34 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:15:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:15:37 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #30 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:15:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:15:39 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:15:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:15:42 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 --- Comment #15 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:15:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:15:44 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:15:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:15:47 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 --- Comment #16 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:15:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:15:50 +0000 Subject: [Koha-bugs] [Bug 29456] "Auto renewal" and "Hold reminder" notice shown as "unknown" on the patron category list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:15:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:15:52 +0000 Subject: [Koha-bugs] [Bug 29456] "Auto renewal" and "Hold reminder" notice shown as "unknown" on the patron category list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:15:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:15:55 +0000 Subject: [Koha-bugs] [Bug 29463] Umlauts in search field get changed into replacement character In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:15:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:15:57 +0000 Subject: [Koha-bugs] [Bug 29463] Umlauts in search field get changed into replacement character In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:16:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:16:00 +0000 Subject: [Koha-bugs] [Bug 29496] Can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:16:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:16:02 +0000 Subject: [Koha-bugs] [Bug 29496] Can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #17 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:24:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:24:48 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #29 from Florian --- Created attachment 127867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127867&action=edit Bug 29469: (bug 17600 follow-up) Fix tag approval/rejection from staff Usage: POSIX::exit(status) at /kohadevbox/koha/tags/review.pl line 72. at /usr/share/perl/5.28/Carp.pm line 289 Carp::croak('Usage: POSIX::exit(status)') called at /usr/lib/x86_64-linux-gnu/perl/5.28/POSIX.pm line 22 POSIX::usage('exit(status)') called at (eval 2066) line 3 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:24:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:24:53 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #30 from Florian --- Created attachment 127868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127868&action=edit Bug 29270: Expiration date must be in future Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:24:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:24:56 +0000 Subject: [Koha-bugs] [Bug 29496] Can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #18 from Jonathan Druart --- Congratulations for your first patch pushed, Marion! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:24:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:24:58 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #31 from Florian --- Created attachment 127869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127869&action=edit Bug 29477: Flatpickr - default to 23:59 for the time part It was defaulting to 12:00 which was an unexpected change in behaviour caused by flatpickr switch. Test plan: On the circulation view, check some items out and play with the time part and "Remember for session". The behaviour must be correct, ie. the same as prior to flatpickr switch. Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:25:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:25:03 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #32 from Florian --- Created attachment 127870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127870&action=edit Bug 29270: start_for is actually date_to The attribute has been renamed in the meanwhile.. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:25:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:25:40 +0000 Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |michael.hafen at washk12.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:25:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:25:59 +0000 Subject: [Koha-bugs] [Bug 29496] Can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #19 from marion.durand at biblibre.com --- (In reply to Jonathan Druart from comment #18) > Congratulations for your first patch pushed, Marion! Thank you :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:32:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:32:36 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #33 from Jonathan Druart --- Florian, to obsolete patches you need to click "Details", "edit details", tick "obsolete", then submit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:32:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:32:38 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127867|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:32:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:32:45 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127868|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:32:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:32:47 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127868|0 |1 is obsolete| | Attachment #127869|0 |1 is obsolete| | Attachment #127870|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:32:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:32:46 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127868|0 |1 is obsolete| | Attachment #127869|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:35:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:35:51 +0000 Subject: [Koha-bugs] [Bug 29530] New: When NumSavedReports is set, show value in pull down of entries Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 Bug ID: 29530 Summary: When NumSavedReports is set, show value in pull down of entries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When NumSavedReports is set to a value, the list of reports defaults to the set number of reports showing on a page, but the pull down of settings for per page entries will be empty. So after changing the value, you cannot reset it. We should make the entry show up there as well (if it doesn't match one of the existing already). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:36:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:36:28 +0000 Subject: [Koha-bugs] [Bug 29488] NumSavedReports system preference doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29488 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:36:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:36:31 +0000 Subject: [Koha-bugs] [Bug 29488] NumSavedReports system preference doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29488 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127698|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 127871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127871&action=edit Bug 29488: make NumSavedReports work 1. Have a bunch of saved reports 2. Try to use the sys pref NumSavedReports to limit how many show by default 3. It doesn't work 4. Apply patch 5. Try again, now it should work Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:39:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:39:55 +0000 Subject: [Koha-bugs] [Bug 29487] Set autocomplete off for userid/password fields at login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29487 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:39:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:39:58 +0000 Subject: [Koha-bugs] [Bug 29487] Set autocomplete off for userid/password fields at login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29487 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127667|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 127872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127872&action=edit Bug 29487: Set autocomplete off for userid/password fields at login This patch adjust: Intranet login Opac-main Opac-main - 'log in to your account modal' To test: Login at the three places above Confirm html shows autocomplete off on the fields Confirm logins work Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:42:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:42:00 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #24 from Katrin Fischer --- Thx, Björn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:45:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:45:13 +0000 Subject: [Koha-bugs] [Bug 29464] Sorting broken for receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #1 from Katrin Fischer --- Confirmed the issue :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:47:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:47:56 +0000 Subject: [Koha-bugs] [Bug 29529] Fix \n in hint on Koha to MARC mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29529 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:48:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:48:51 +0000 Subject: [Koha-bugs] [Bug 24304] Incomplete returns (notes) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24304 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org --- Comment #2 from George Williams (NEKLS) --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:50:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:50:50 +0000 Subject: [Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:50:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:50:54 +0000 Subject: [Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126806|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer --- Created attachment 127873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127873&action=edit Bug 29036: Accessibility OPAC buttons don't have sufficient contrast This patch changed the base colour of OPAC buttons to increase the contrast ratio, improving accessibility and making the button text easier to read. To test: 1. Use an accessibility tool (e.g. Chrome's Lighthouse tool) to check the contrast ratio on the OPAC 2. Confirm that the OPAC buttons don't have sufficient colour contrast 3. Apply the patch and rebuild css: yarn build --view opac 4. Use the accessibility tool to confirm the button contrast ratio now meets minimum accessibility requirements 5. Check that the OPAC still looks ok after the changes Signed-off-by: Owen Leonard Signed-off-by: jeremy breuillard Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:51:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:51:02 +0000 Subject: [Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126807|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer --- Created attachment 127874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127874&action=edit Bug 29036: (follow-up) Improve the use of variables to keep colors consistent This patch modifies the OPAC SCSS so that a "base theme color" variable is defined which can be used to color button backgrounds and similar elements. The patch also moves some other colors into variables and removes some unused CSS. The Koha logo which is displayed in the upper left corner of the OPAC has been modified to use the same color. To test, apply the patch and repeat the previous test plan. Signed-off-by: jeremy breuillard Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:52:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:52:43 +0000 Subject: [Koha-bugs] [Bug 29494] html-template-to-template-toolkit.pl no longer required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29494 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 15:52:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 14:52:47 +0000 Subject: [Koha-bugs] [Bug 29494] html-template-to-template-toolkit.pl no longer required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29494 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127696|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 127875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127875&action=edit Bug 29494: html-template-to-template-toolkit.pl no longer required This helper script was used to transition from HTML::Template to Template::Toolkit, which happened 11 (?) years ago. The file is part of Koha history, but we don't need it in current master. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Owen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:00:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:00:46 +0000 Subject: [Koha-bugs] [Bug 29529] Fix \n in hint on Koha to MARC mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29529 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:00:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:00:50 +0000 Subject: [Koha-bugs] [Bug 29529] Fix \n in hint on Koha to MARC mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29529 --- Comment #1 from Owen Leonard --- Created attachment 127876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127876&action=edit Bug 29529: Fix \n in hint on Koha to MARC mappings This patch breaks up a translatable string so that "\n" is excluded from what is translated. Unrelated: Capitalization is corrected on an instance of the phrase "Koha to MARC Mappings." To test, apply the patch and go to Administration -> Koha to MARC mapping. - The breadcrumb for the current page should have correct capitalization ("mapping" instead of "Mapping"). - Click the "Add" button for any Koha field. The dialog should display correctly: Adding a mapping for: biblio.abstract. Please enter field tag and subfield code, separated by a comma. (For control fields: add '@' as subfield code.) The change will be applied immediately. Test the way the po file is updated: > cd misc/translator > perl translate update en-GB (for example) - Open the updated po file, en-GB-staff-prog.po - You should find these lines: SCRIPT koha-tmpl/intranet-tmpl/prog/en/modules/admin/koha2marclinks.tt:86 msgid "The change will be applied immediately." msgstr "" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:03:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:03:08 +0000 Subject: [Koha-bugs] [Bug 27613] Pipe separated online resource links are hard to customize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Katrin Fischer --- Ok, I came around to the change :) Only one question: could we throw in the contributurs/authors list to make this more complete of a change? There might be some more in the Utils file that need attention. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:03:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:03:48 +0000 Subject: [Koha-bugs] [Bug 27627] Fix invalid HTML in OPAC results XSLT: change spans to divs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27627 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #12 from Katrin Fischer --- Right now waiting for its dependency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:06:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:06:33 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Florian changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127797|0 |1 is obsolete| | --- Comment #34 from Florian --- Created attachment 127877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127877&action=edit Bug 21729: DB changes Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Florian Bontemps -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:06:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:06:38 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Florian changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127798|0 |1 is obsolete| | --- Comment #35 from Florian --- Created attachment 127878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127878&action=edit Bug 21729: DBIC schema changes Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Florian Bontemps -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:06:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:06:44 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Florian changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127799|0 |1 is obsolete| | --- Comment #36 from Florian --- Created attachment 127879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127879&action=edit Bug 21729: Keep expiration date set when placing a hold The expiration date picked by the patron (or librarian) when placing a hold is lost when a waiting hold is reverted. We need a separate DB field to store this value and restore it when needed: patron_expiration_date The new behaviours are now: Create a hold and specify an expiration date: expirationdate=patron_expiration_date Fill the hold: expiration_date is calculated expiration_date set to the calculated value or to patron_expiration_date if anterior patron_expiration_date not modified Revert the waiting status: expirationdate set back to patron_expiration_date Cancel expire reserves: if < expirationdate OR < patron_expiration_date Note: This change should not be needed but won't hurt Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Florian Bontemps -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:06:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:06:49 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Florian changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127800|0 |1 is obsolete| | --- Comment #37 from Florian --- Created attachment 127880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127880&action=edit Bug 21729: Simplify non-existent expiration date No change in behaviour expected by this patch. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Florian Bontemps -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:09:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:09:45 +0000 Subject: [Koha-bugs] [Bug 29010] Weight input pattern wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29010 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:09:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:09:49 +0000 Subject: [Koha-bugs] [Bug 29010] Weight input pattern wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29010 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126303|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 127881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127881&action=edit Bug 29010: fix pattern in search_field.weight search_field.weight is of type NUMERIC(5,2) in the database, and values are rendered as floats in /admin/searchengine/elasticsearch/mappings.pl But the field validation only accepts INTs. This patch fixes the pattern to accept NUMERIC(ish) values - Enable Elasticsearch (but no need to actually index anyting) - go to cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl - Enter an integer (eg "8") into any "weight" column and click save - Koha now displays the value as NUMERIC, eg. "8.00" - Change nothing, and click save again - Save does not work, you get a warning by the browser that the input does not match the requested format (because in the html field only ints are allowed, but the DB stored the value as numeric and returns it as such) - Workaround: Change all the values back to ints (i.e. remove ".00"), but this is very cumbersome if you have several weights - Apply the patch - Now try to save again (without changing eg "8.00" to "8". It works - Add a new weight (eg "4"), save, it's turned into "4.00", but saving again still works Sponsored-by: Steiermärkische Landesbibliothek Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:09:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:09:53 +0000 Subject: [Koha-bugs] [Bug 29010] Weight input pattern wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29010 --- Comment #9 from Katrin Fischer --- Created attachment 127882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127882&action=edit Bug 29010: (QA follow-up) Change inputmode from numeric to decimal Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:10:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:10:22 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #38 from Florian --- Apologies for the mess I caused, hopefully all should be good. Sidenote though : I was able to run the full test plan without the patches on master, and it worked as intented; so in essence I saw no differences with or without the patches. Maybe it was fixed elsewhere? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:31:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:31:58 +0000 Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in reports does not work with CONCAT in report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #22 from Lucas Gass --- It appears like this does not work in 20.05, 21.05, or master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:33:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:33:33 +0000 Subject: [Koha-bugs] [Bug 29123] Add Dataly Tech to About page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29123 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #13 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:36:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:36:36 +0000 Subject: [Koha-bugs] [Bug 29459] Replace some missed datetimepickers in circulation templates with Flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29459 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:36:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:36:37 +0000 Subject: [Koha-bugs] [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 Bug 29239 depends on bug 29459, which changed state. Bug 29459 Summary: Replace some missed datetimepickers in circulation templates with Flatpickr https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29459 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:41:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:41:15 +0000 Subject: [Koha-bugs] [Bug 29435] OPAC authority details page broken when AuthDisplayHierarchy is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29435 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:41:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:41:16 +0000 Subject: [Koha-bugs] [Bug 11873] Upgrade jstree jQuery plugin to the latest version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 Bug 11873 depends on bug 29435, which changed state. Bug 29435 Summary: OPAC authority details page broken when AuthDisplayHierarchy is enabled https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29435 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:41:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:41:34 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:41:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:41:35 +0000 Subject: [Koha-bugs] [Bug 29365] Koha::Email needs to be refactored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29365 Bug 29365 depends on bug 29330, which changed state. Bug 29330 Summary: Koha cannot send emails with attachments using Koha::Email and message_queue table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:44:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:44:32 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #47 from Kyle M Hall --- If this is needed to for 21.05.x please rebase and notify me! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:45:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:45:53 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #48 from Katrin Fischer --- It is needed... but I can't provide the reabase. :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:47:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:47:15 +0000 Subject: [Koha-bugs] [Bug 29183] Add query options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29183 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:48:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:48:05 +0000 Subject: [Koha-bugs] [Bug 28994] Make writeoff_debts.pl use amountoutstanding, not amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28994 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:48:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:48:24 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:48:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:48:25 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Bug 13985 depends on bug 28374, which changed state. Bug 28374 Summary: Convert pos/printreceipt.pl to use GetPreparedLetter https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:50:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:50:06 +0000 Subject: [Koha-bugs] [Bug 29204] Error 500 when execute Circulation report with date period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29204 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle at bywatersolutions.com --- Comment #15 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:50:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:50:35 +0000 Subject: [Koha-bugs] [Bug 29264] SIP config allows use of non-branchcode institution ids causes workers to die without responding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29264 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #7 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 16:51:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 15:51:12 +0000 Subject: [Koha-bugs] [Bug 29255] Built-in offline circulation broken with SQL error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #7 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:19:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:19:32 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127819|0 |1 is obsolete| | Attachment #127820|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 127883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127883&action=edit Bug 29483: Unit tests This patch updates the AllowRenewalIfOtherItemsAvailable tests to remove deletion of all data, and create specific circ rules for this test. It adjust several other tests that were relying on the rules from this test, so thy too create their opwn specific rules. Additionally, we add tests to cover the case of mutliple items on the record, and some items cannot fill some reserves. What is uncovered here is that the same patron is checked twice, so two holds can be filled, but they only satisfy a single patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:19:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:19:35 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 --- Comment #6 from Nick Clemens --- Created attachment 127884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127884&action=edit Bug 29483: Check ItemsAnyAvailableAndNotRestricted once per patron ItemsAnyAvailableAndNotRestricted can take a long time and create nested loops. We can check it once per patron, however, this requires us to flip the loops. Since an item can only be used once, we now add a check to see if this item has already been assigned to a borrower. To test: 1 - Find or create a biblio with 100 items 2 - Place ten 'Next available' holds on a biblio 3 - Set preference 'AllowRenewalIfOtherItemsAvailable' to 'Allow' Set circ rules 'On shelf holds allowed' to 'If any unavailable' 4 - Checkout one of the items to a patron, backdated to be overdue 5 - Note a long loading time for the patron's checkouts 6 - Apply patch, restart_all 7 - Patron loads much faster -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:19:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:19:38 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 --- Comment #7 from Nick Clemens --- Created attachment 127885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127885&action=edit Bug 29483: Further improve performance of script This patch adds a few tests to cover more cases, and to highlight current functionality. The script only allows renewal if all outstanding holds can be filled by available items. This means we can return as soon as we have determined that not all holds can be filled. I add FIXME and some explanatory comments - I will file a follow-up bug for those, but I feel we can accept these improvements to the performance and deal with the issues of how it 'should' work versus how it does work on another report. To test: 1 - prove -v t/db_dependent/Circulation.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:20:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:20:41 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:25:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:25:42 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |agustinmoyano at theke.io, | |jonathan.druart+koha at gmail. | |com, | |joonas.kylmala at helsinki.fi, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:26:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:26:04 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 127886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127886&action=edit Bug 29523: Add Koha::Objects->search_limited stub method This method is just a passthru to the search method. It is defined here to avoid the need to check if each class implements it. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:26:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:26:09 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 127887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127887&action=edit Bug 29523: Add Koha::Object->accessible This patch introduces a method for checking if an object can be retrieved by the current user. It depends on the plural class implementation of the ->search_limited method. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:26:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:26:15 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 127888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127888&action=edit Bug 29523: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:26:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:26:20 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 127889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127889&action=edit Bug 29523: Make Koha::Object->to_api respect accessibility This patch makes the *to_api* method honour the accessibility check for the object. This is relevant in the context of embedding single objects. The Koha::Patron->to_api method is adjusted to reflect this behavior as well (it does some manipulation after the ->to_api call and we need to prevent it). To test: 1. Apply up to the regression tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => FAIL: A patron, that shouldn't be accessed, is returned by ->to_api 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 6. Pick Henry Acevedo from the sample data, assign him 'catalogue' permissions and a know user/password combination 7. Enable basic authentication 8. Point your favourite tool (Postman?) to GET http://kohadev-intra.myDNSname.org:8081/api/v1/biblio/245/checkouts Set the following header: x-koha-embed: patron Pick whatever biblio you want, actually. => SUCCESS: No checkouts 9. Perform a couple checkouts on the chosen biblio. Make sure one checkout is for a patron on the same library as Henry, and the other on a different one. 10. Repeat 8 => SUCCESS: You see two checkouts. One of them has an attribute 'patron' containing the patron from Henry's library. The other, has the attribute set to 'null'. 11. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:26:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:26:31 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:28:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:28:19 +0000 Subject: [Koha-bugs] [Bug 29531] New: CanBookBeRenewed is inconsistent when checking AllowRenewalIfOtherItemsAvailable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29531 Bug ID: 29531 Summary: CanBookBeRenewed is inconsistent when checking AllowRenewalIfOtherItemsAvailable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In working on bug 29483 it was found that the logic of CanBookBeRenewed can be flawed when relating to AllowRenewalIfOtherItemsAvailable At checkin we call 'CheckReserves' to find holds on the current item and will fill only holds that obey hold 'policies' - but we will also fill a hold that violates the 'rules' To recreate: 1 - Set circ rules to allow 5 holds for All/All 2 - Set an itemtype level circ rule to allow 0 holds 3 - Place a title level hold on a record with an item of that type and one of another type 4 - Note while placing hold that you cannot select the item of that type 5 - Check in the item with that type - the hold is trapped - ignore it for now 6 - Check out the other item to a patron 7 - Note the renew column in checkouts says 'On hold' 8 - Set AllowRenewalIfOtherItemsAvailable to 'Allow' 9 - Note the renew column still says 'On hold' despite the fact that that item will fill the existing hold -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:28:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:28:21 +0000 Subject: [Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle at bywatersolutions.com --- Comment #13 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:28:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:28:28 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29531 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:28:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:28:28 +0000 Subject: [Koha-bugs] [Bug 29531] CanBookBeRenewed is inconsistent when checking AllowRenewalIfOtherItemsAvailable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29531 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29483 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:29:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:29:05 +0000 Subject: [Koha-bugs] [Bug 29273] Warning not caught in tests for plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:29:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:29:05 +0000 Subject: [Koha-bugs] [Bug 25515] Remove warnings and errors from tests output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 Bug 25515 depends on bug 29273, which changed state. Bug 29273 Summary: Warning not caught in tests for plugins https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29273 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:30:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:30:00 +0000 Subject: [Koha-bugs] [Bug 29531] CanBookBeRenewed is inconsistent when checking AllowRenewalIfOtherItemsAvailable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29531 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:30:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:30:08 +0000 Subject: [Koha-bugs] [Bug 29146] Default values from the framework should only be applied at biblio/item creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED --- Comment #27 from Kyle M Hall --- Does not apply to 21.05.x. Please rebase and let me know if this is needed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:30:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:30:39 +0000 Subject: [Koha-bugs] [Bug 29334] Do not apply framework defaultvalue to existing authority records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29334 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:31:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:31:06 +0000 Subject: [Koha-bugs] [Bug 29460] Typo 'pendin g approval' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29460 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:35:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:35:01 +0000 Subject: [Koha-bugs] [Bug 27145] Patron deletion via intranet doesn't handle exceptions well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #10 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:35:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:35:12 +0000 Subject: [Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #31 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:35:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:35:53 +0000 Subject: [Koha-bugs] [Bug 29321] Remove a last without loop context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29321 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #7 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:36:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:36:39 +0000 Subject: [Koha-bugs] [Bug 29452] Unnecessary warns in sip logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29452 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:38:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:38:35 +0000 Subject: [Koha-bugs] [Bug 29405] The patron spec for date_renewed is missing it's format definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29405 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #6 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:39:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:39:22 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #22 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:40:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:40:04 +0000 Subject: [Koha-bugs] [Bug 29485] selenium/administration_tasks.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29485 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #4 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:40:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:40:53 +0000 Subject: [Koha-bugs] [Bug 29485] selenium/administration_tasks.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29485 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:40:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:40:53 +0000 Subject: [Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 Bug 25551 depends on bug 29485, which changed state. Bug 29485 Summary: selenium/administration_tasks.t is failing randomly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29485 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:41:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:41:20 +0000 Subject: [Koha-bugs] [Bug 29485] selenium/administration_tasks.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29485 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:44:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:44:16 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle at bywatersolutions.com --- Comment #48 from Kyle M Hall --- Doesn't apply to 21.05.x. Please rebase and let me know if you think this should be backported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:44:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:44:41 +0000 Subject: [Koha-bugs] [Bug 29469] Error when approving and rejecting tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29469 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:48:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:48:07 +0000 Subject: [Koha-bugs] [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:48:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:48:08 +0000 Subject: [Koha-bugs] [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 Bug 29239 depends on bug 29477, which changed state. Bug 29477 Summary: flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:48:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:48:08 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 Bug 29394 depends on bug 29477, which changed state. Bug 29477 Summary: flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:48:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:48:49 +0000 Subject: [Koha-bugs] [Bug 29496] Can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:49:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:49:54 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #31 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:57:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:57:30 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |FIXED --- Comment #16 from Kyle M Hall --- Doesn't apply to 21.05.x. Please rebase and let me know if this is needed in 21.05! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:59:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:59:14 +0000 Subject: [Koha-bugs] [Bug 29463] Umlauts in search field get changed into replacement character In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 17:59:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 16:59:59 +0000 Subject: [Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 18:00:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 17:00:44 +0000 Subject: [Koha-bugs] [Bug 29456] "Auto renewal" and "Hold reminder" notice shown as "unknown" on the patron category list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 18:02:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 17:02:17 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle at bywatersolutions.com --- Comment #17 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 18:08:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 17:08:16 +0000 Subject: [Koha-bugs] [Bug 29532] New: Display cover images for titles on hold tabs tab for logged in users on OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29532 Bug ID: 29532 Summary: Display cover images for titles on hold tabs tab for logged in users on OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: barbara.johnson at bedfordtx.gov QA Contact: testopia at bugs.koha-community.org On the holds tab in the user's account (opac-user.pl) on the OPAC it would be helpful to patrons if they could see the cover images of the titles they have on hold similar to the way they can see the images for the items they have checked out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 18:26:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 17:26:46 +0000 Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 --- Comment #9 from Michael Hafen --- I am totally in agreement with you on this. (In reply to Martin Renvoize from comment #7) > Created attachment 127852 [details] [review] > Bug 18855: (follow-up) Restore CalculateFinesOnReturn behaviour > > This patch removes the check for a disabled 'CalculateFinesOnReturn' > to restore the behaviour prior to this patch series. > > If a patron has returned the item during the fines cron run, they may > well have been charged a reduced fine at check-in time. However, I feel > that the fine should not then increment/decrement behind the scenes > after the check-in. This is to reduce confusion for end users and > librarians alike. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 18:49:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 17:49:30 +0000 Subject: [Koha-bugs] [Bug 29533] New: add more fields to items sql table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29533 Bug ID: 29533 Summary: add more fields to items sql table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: mathsabypro at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl MARC tag dedicated to items (995 Unimarc / 952 Marc21) can contain a lot of subfields (0-9 ; a-z ; A-Z). It frequently happens that a value stored in this tag cannot be mapped to items SQL table through "Koha => MARC" configuration page. The use of "more_subfields_xml" to make something useful of these information is cumbersome. Koha should provide a way to map to SQL more information related to items, for example by creation 10 new fields in items sql table (items.customfield1, items.customfield2, etc), or something more subtle. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 18:52:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 17:52:11 +0000 Subject: [Koha-bugs] [Bug 29534] New: Search of Authorities log erroneously selects Authentication log on results page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29534 Bug ID: 29534 Summary: Search of Authorities log erroneously selects Authentication log on results page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When searching the action logs, the results page is meant to maintain the selections one made for one's search. However, when one searches the Authorities log the results page loads with both Authorities and Authentication selected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 19:27:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 18:27:37 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 19:27:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 18:27:41 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127721|0 |1 is obsolete| | --- Comment #16 from David Nind --- Created attachment 127890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127890&action=edit Bug 29478: Flatpickr - Restore 'Today' button It's not implemented, looks like we need to use a plugin for that https://github.com/flatpickr/flatpickr/issues/576 https://github.com/jcsmorais/shortcut-buttons-flatpickr Test plan: Confirm that flatpickr instances now have a yesterday, today and tomorrow buttons. Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 19:27:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 18:27:47 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127722|0 |1 is obsolete| | --- Comment #17 from David Nind --- Created attachment 127891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127891&action=edit Bug 29478: (follow-up) Provide default style for shortcut buttons This patch adds some CSS to _flatpickr.scss in order to give a deafult style to the "yesterday," "today," and "tomorrow" controls added by the shortcut plugin. A missed translatable string is now wrapped in the __() function: __("or"). The patch also updates the date calculation for those shortcuts to use Flatpickr's date calculation shorthand. This isn't strictly necessary but I think it makes the code more readable. To test, apply the patch and build the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). In the staff client, view some pages with date-picker widgets. A calendar widget time selection: - Circulation -> Check out -> Checkout settings -> Select date: - The calendar widget should have "yesterday," "today," and "tomorrow" controls styled like links appearing after the time selector. The controls should be centered, with the "or" label on the same line. A calendar widget without time selection: - Tools -> Log viewer -> Display from. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 19:27:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 18:27:54 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127804|0 |1 is obsolete| | --- Comment #18 from David Nind --- Created attachment 127892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127892&action=edit Bug 29478: Today should select now for pastinclusive If Today is clicked when we only allow dates in the past and today/now, we should select the current date/time We need to update the maxDate to make it up-to-date, or the maxDate may be set to the minute before and clicking Today will blank the input. Signed-off-by: Owen Leonard Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 19:28:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 18:28:01 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127850|0 |1 is obsolete| | --- Comment #19 from David Nind --- Created attachment 127893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127893&action=edit Bug 29478: (follow-up) Today should select now for pastinclusive This is getting ugly. We need to add 1 minute for the minDate or the 'Today' link may not work. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 19:34:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 18:34:55 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #20 from David Nind --- I'm not sure the "or" is necessary, but that is pretty minor. Things seem to work as per the test plan, and I didn't come across anything that didn't work... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 19:37:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 18:37:06 +0000 Subject: [Koha-bugs] [Bug 19360] Give items URL a link text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #27 from Liz Rea --- Hi, This is still a really good idea, and people are still asking for this feature - what are the chances of work continuing on this bug? Seems like it's only getting more common for libraries to have one item that they have many different online sources for! Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 19:39:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 18:39:19 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127704|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 19:39:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 18:39:22 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127701|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 19:39:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 18:39:24 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127702|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 19:39:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 18:39:27 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127703|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 19:39:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 18:39:30 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Signed Off --- Comment #18 from David Nind --- It looks to me as though Martin has signed this off - have changed the status. Feel free to change back and I will test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 19:39:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 18:39:54 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 127894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127894&action=edit Bug 29275: Add $patron_to_html to render patron information in JS Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 19:39:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 18:39:58 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 127895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127895&action=edit Bug 29275: Use the API to fetch checkouts information This patch changes issuehistory.pl so it leverages on the API for fetching checkouts information in the template. Workflow changes: This development splits the 'current' checkouts and the 'past' checkouts in two different tables. Terminology could be revisited by native english speakers. To test: 1. Have records with and without current/past checkouts 2. Notice how the Checkouts history tab presents the information on each case. => SUGGESTION: Keep each of them open on separate tabs for comparing 3. Apply this patchset and its dependencies 4. Restart plack, run: $ koha-plack --restart kohadev 5. Follow the same steps you followed for those open tabs, in new ones => SUCCESS: What you see makes sense, information is displayed as it used to, with the different tables now. 6. Try searching on the datatables => SUCCESS: Search works correctly! 7. Revisit the new texts I added => SUGGESTION: If you have better wordings, submit a patch, or just comment on the bug so I do it inline. 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 19:40:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 18:40:03 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 127896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127896&action=edit Bug 29275: (follow-up) Remove use of CountSubscriptionFromBiblionumber Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 19:40:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 18:40:08 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 127897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127897&action=edit Bug 29275: (follow-up) Split columns settings and handle upgrade This patch splits the table settings as we now have two tables. The atomic update takes care of setting the right values (if present) on the new tables entries. To test: 1. Do not apply this patch 2. Set some values you will remember for the checkoutshistory-table table 3. Run: $ koha-mysql kohadev > SELECT * FROM columns_settings WHERE tablename='checkoutshistory-table'; => SUCCESS: Koha currently works :-D 4. Apply this patch 5. Run: $ updatedatabase 6. Repeat 3 => SUCCESS: Things have been deleted 7. Run: $ koha-mysql kohadev > SELECT * FROM columns_settings WHERE tablename LIKE '%_checkouts-table'; => SUCCESS: old_checkouts-table and current_checkouts-table have the right setting 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 19:44:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 18:44:59 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #23 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #18) > Sorry dude.. I love this improvement.. but I think we have a problem. The > new js equivalent to patron-name.inc is awesome and works great.. but it got > me looking at what patron-name.inc does and threw me into the rabbit hole > looking at how patrons get hidden from other branch staff in certain modes > of operation. Good catch! And this is bigger than this dev! > I can't see any handling, either in the js function or in the API response > builder, that would filter out patrons that the logged-in user should not be > able to see details for. I'm hopeful that I'm just missing something in the > API layer as I think that's where it should sit personally.. we shouldn't > expose the data at all if the user doesn't have permission to view it, > rather than hide it at the view stage. If that functionality is there, any > chance you could point me to the unit tests for it? I proposed a generic solution for checking 'allowed-to-embed' objects on bug 28523. It looks pretty solid to me and I made this bug dependent on it. For the specific case of a 'null' patron on the response (which is now the case, correctly handled in the controller level, not just hidden) I decided to handle it locally (so not in js-patron-format.inc) like this: if ( row.patron != null ) { return $patron_to_html( row.patron, { display_cardnumber: true, url: true } ); } else { return _("A patron from library %s").format(escape_str(row.library.name)); } it felt like there was no need for a generic message, as each scenario could require different wordings. Please test! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 20:13:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 19:13:00 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate --- Comment #19 from Katrin Fischer --- Also needs to be a 21.11 candidate because of dependencies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 20:48:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 19:48:42 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #24 from Tomás Cohen Arazi --- (In reply to Victor Grousset/tuxayo from comment #12) > And it has been pushed :D Time to test :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 20:49:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 19:49:30 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #5 from Tomás Cohen Arazi --- We should consider this one for 21.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 21:19:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 20:19:18 +0000 Subject: [Koha-bugs] [Bug 29515] Don't require title for HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29515 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127861|0 |1 is obsolete| | --- Comment #5 from PTFS Europe Sandboxes --- Created attachment 127898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127898&action=edit Bug 29515: Make title for HTML customizations optional This adds code to make the title field for HTML customizations optional while it stays mandatory for news entries. 1) Add a new HTML customization, verify you are forced to enter a title 2) Apply patch 3) Repeat and verify that you can now save without title 4) Add a new news entry 5) Verify that the title field remained mandatory there. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 21:20:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 20:20:28 +0000 Subject: [Koha-bugs] [Bug 29535] New: error message: Connection failed to aplyaz.austintexas.gov Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29535 Bug ID: 29535 Summary: error message: Connection failed to aplyaz.austintexas.gov Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: JSMITH at LANTANA.ORG QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Cannot access holdings in the Austin Public Library for cataloging -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 21:22:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 20:22:08 +0000 Subject: [Koha-bugs] [Bug 29515] Don't require title for HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29515 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 21:26:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 20:26:27 +0000 Subject: [Koha-bugs] [Bug 29535] error message: Connection failed to aplyaz.austintexas.gov In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29535 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Hi Jane, this sounds like a problem you should bring up with your support provider if you have one or have your local system administrator have look into. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 21:36:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 20:36:12 +0000 Subject: [Koha-bugs] [Bug 29481] Terminology: Collection code, call number: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29481 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127728|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 127899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127899&action=edit Bug 29481: Terminology: Collection code, call number This patch corrects an instance of the phrase "Collection code," replacing it with the standard "Collection." To test, apply the patch and restart services. - In the staff interface, go to Administration -> System preferences and set the OpacItemLocation preference to "library, collection code, and call number." - In the OPAC, search the catalog using a term which will return multiple results. - In the search results, item descriptions in the "Availability" line should read like this: [Collection, call number: Non-fiction 394.2663 Bu] Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 21:36:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 20:36:26 +0000 Subject: [Koha-bugs] [Bug 20956] BorrowersLog is not logging permission changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #5 from Liz Rea --- We definitely want to come back to this, there is a whole slew of legislation out right now that is going to require certifications that changes such as this can be audited (at least in the US, and I presume elsewhere). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 21:36:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 20:36:36 +0000 Subject: [Koha-bugs] [Bug 29481] Terminology: Collection code, call number: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29481 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 21:37:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 20:37:07 +0000 Subject: [Koha-bugs] [Bug 27912] Quotes break guarantor search. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27912 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 21:46:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 20:46:09 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #60 from Fridolin Somers --- Applying on 20.11.x I tried to use patches in this bug report but it failed on : error: sha1 information is lacking or useless (Koha/Email.pm). error: could not build fake ancestor Patch failed at 0001 Bug 28870: Move email address validation to a specific class method So I tried to cherry-pick from 21.05.x and it works. Unit test is OK so should be OK. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 21:46:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 20:46:43 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #61 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 21:46:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 20:46:53 +0000 Subject: [Koha-bugs] [Bug 20956] BorrowersLog is not logging permission changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 Severity|enhancement |major --- Comment #6 from Liz Rea --- Also, due to the legalities, this is an actual missing feature that qualifies as a bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 21:49:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 20:49:10 +0000 Subject: [Koha-bugs] [Bug 28994] Make writeoff_debts.pl use amountoutstanding, not amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28994 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Depends on Bug 27049 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 22:07:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 21:07:22 +0000 Subject: [Koha-bugs] [Bug 29204] Error 500 when execute Circulation report with date period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29204 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #16 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 22:21:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 21:21:34 +0000 Subject: [Koha-bugs] [Bug 29264] SIP config allows use of non-branchcode institution ids causes workers to die without responding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29264 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 22:53:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 21:53:20 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #2 from Lucas Gass --- Does this need to be a configuration option? I'd imagine some libraries would like those item level dropdowns to default to the items hold location. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 19 22:53:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 21:53:46 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #3 from Lucas Gass --- I meant items home location, not items hold location -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 00:14:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 23:14:07 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #4 from Christopher Brannon --- >From a consortium point of view, it is always going to be about where the patron is going to pick up. I know that there are already settings that define where items should default to pickup, and this should really adhere to those existing settings. I'm not sure why a pickup location should change if the hold is bib-level or item-level. That seems a bit nit-picky and tedious to manage. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 00:17:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 23:17:50 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #4 from Christopher Brannon --- I agree this should not have been a blocker. It is only meant to grab attention to details. Having it block is a blocker itself. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 00:58:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Nov 2021 23:58:44 +0000 Subject: [Koha-bugs] [Bug 20956] BorrowersLog is not logging permission changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #7 from Tomás Cohen Arazi --- Should it be in the action_logs? Maybe another table? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 01:00:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 00:00:53 +0000 Subject: [Koha-bugs] [Bug 29255] Built-in offline circulation broken with SQL error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 01:02:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 00:02:59 +0000 Subject: [Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #14 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 01:10:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 00:10:01 +0000 Subject: [Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #32 from Fridolin Somers --- Does not apply on 20.11.x, fails on t/db_dependent/OAI/Server.t because of missing Bug 29135 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 01:10:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 00:10:23 +0000 Subject: [Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29135 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 01:10:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 00:10:23 +0000 Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from deleteditems when determining deletedbiblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21105 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 01:12:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 00:12:37 +0000 Subject: [Koha-bugs] [Bug 27145] Patron deletion via intranet doesn't handle exceptions well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 01:14:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 00:14:32 +0000 Subject: [Koha-bugs] [Bug 29321] Remove a last without loop context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29321 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers at biblibre.co | |m Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | --- Comment #8 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 01:16:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 00:16:03 +0000 Subject: [Koha-bugs] [Bug 29452] Unnecessary warns in sip logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29452 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 01:17:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 00:17:20 +0000 Subject: [Koha-bugs] [Bug 29405] The patron spec for date_renewed is missing it's format definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29405 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 01:23:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 00:23:24 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #23 from Fridolin Somers --- Shouldn't we also change in koha-tmpl/opac-tmpl/bootstrap/js/datatables.js ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 01:24:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 00:24:41 +0000 Subject: [Koha-bugs] [Bug 29485] selenium/administration_tasks.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29485 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin Somers --- I see it has been reverted from 21.05.x : 4107c8def4 Revert "Bug 29485: Trying to prevent administration_tasks.t to fail randomly" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 01:25:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 00:25:57 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #32 from Fridolin Somers --- (In reply to Marcel de Rooy from comment #27) > KEY `pseudonymized_transactions_ibfk_1` (`categorycode`), > KEY `pseudonymized_transactions_borrowers_ibfk_2` (`branchcode`), > KEY `pseudonymized_transactions_borrowers_ibfk_3` > (`transaction_branchcode`) > > When removing the FKs, the question is: Do we still need those indexes? I bet yes, for SQL join performance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 01:37:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 00:37:02 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #33 from Fridolin Somers --- /!\ Arg, Koha.pm change is missing in 21.05.x : It is still in "21.05.05.003" when updatedatabase is "21.05.05.005" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 02:10:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 01:10:06 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28803 --- Comment #49 from Victor Grousset/tuxayo --- conflict is due to bug 28803 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 02:10:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 01:10:06 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29330 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 02:11:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 01:11:52 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|28803 | --- Comment #50 from Victor Grousset/tuxayo --- No actual dependency it seems. bug 28803 adds a catch and this patch adds code in the try. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 02:11:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 01:11:52 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29330 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 02:27:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 01:27:18 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #54 from Victor Grousset/tuxayo --- (In reply to Kyle M Hall from comment #52) > Please add patches for 21.05.x if needed. Patches apply on 21.05.x I suppose it's thanks to bug 28870 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 03:08:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 02:08:28 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #34 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 03:09:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 02:09:28 +0000 Subject: [Koha-bugs] [Bug 29456] "Auto renewal" and "Hold reminder" notice shown as "unknown" on the patron category list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin Somers --- Depends on Bug 18532 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 03:10:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 02:10:27 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #18 from Fridolin Somers --- Depends on Bug 29319 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 03:26:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 02:26:43 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #51 from Victor Grousset/tuxayo --- Nonetheless with bug 28803[1] applied, only minor conflicts remain. Other than some attention the module use conflict, the patch can be applied. [1] which is major and is not able to apply on 21.05.x so will likely be backported so no need to circumvent it's absence. For 20.11.x it might be trickier. Bug 28803 depends on bug 28813 which depends on 14723 which might not be an easy 20.11.x backport. So circumventing bug 28803 might be the way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 06:14:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 05:14:31 +0000 Subject: [Koha-bugs] [Bug 29536] New: Need help in hosting in Godaddy Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29536 Bug ID: 29536 Summary: Need help in hosting in Godaddy Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Websites, Mailing Lists, etc Assignee: wizzyrea at gmail.com Reporter: ashish12uca002 at gmail.com QA Contact: testopia at bugs.koha-community.org Dear Koha Support Team, I need help in publishing the Koha Application in Linux Web Server which can be used for my Team. I have never published in the cloud. Kindly suggest me on how to publish the website in Online platform like godaddy,hostinger. Thanks and Regards Ashish Sharma ashish12uca002 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 08:42:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 07:42:04 +0000 Subject: [Koha-bugs] [Bug 25028] The not-onloan-count index is not used in ES In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25028 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #1 from Fridolin Somers --- > Looking at rebuild_zebra.pl and the fact that ES doesn't use the EmbedSeeFromHeadings filter either, probably more bugs should be filled. This was fixed in Bug 25030 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 08:42:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 07:42:22 +0000 Subject: [Koha-bugs] [Bug 25028] The not-onloan-count index is not used in ES In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25028 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25030 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 08:42:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 07:42:22 +0000 Subject: [Koha-bugs] [Bug 25030] IncludeSeeFromInSearches not honoured in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25028 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 08:53:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 07:53:12 +0000 Subject: [Koha-bugs] [Bug 25028] The not-onloan-count index is not used in ES In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25028 e.betemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 08:54:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 07:54:11 +0000 Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 e.betemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 12:34:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 11:34:09 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127620|0 |1 is obsolete| | --- Comment #7 from Joonas Kylmälä --- Created attachment 127900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127900&action=edit Bug 29476: Correct soonest renewal date calculation for checkouts with auto-renewal If a checkout with auto-renewal enabled doesn't have a "norenewalbefore" circulation rule set the code in CanBookBeRenewed() falls back to using due date (to verify this please look for the string "auto_too_soon" in C4/Circulation.pm), the calculation result of GetSoonestRenewDate() however didn't do this, though luckily it was not used in CanBookBeRenewed so we didn't get any issues there. However, GetSoonestRenewDate() is used for displaying the soonest renewal date in the staff interface on the circ/renew.pl page so you would have gotten wrong results there. This patch moves additionally the tests made for Bug 14395 under a new subtest for GetSoonestRenewDate() as they should have been like that already before. To test: 1) prove t/db_dependent/Circulation.t Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 12:40:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 11:40:26 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29476 --- Comment #25 from Joonas Kylmälä --- The renewal date calculation is buggy for auto-renewals, I made a fix for that a few days ago in bug 29476. I will mark this bug to now depend on that bug as "Bug 29474: Pass rules/branchcode to subroutines, further simplify logic" uses now GetSoonestRenewDate also for auto-renewals as well, thus requires the bug fix. Also, now that we depend on bug 29476 I can make at least one further simplification in the code, will attach a patch shortly. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 12:40:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 11:40:26 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29474 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 12:52:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 11:52:41 +0000 Subject: [Koha-bugs] [Bug 29537] New: Simplify auto-renewal code in CanBookBeRenewed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Bug ID: 29537 Summary: Simplify auto-renewal code in CanBookBeRenewed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: joonas.kylmala at iki.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 29474 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 12:52:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 11:52:41 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29537 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 12:55:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 11:55:59 +0000 Subject: [Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 12:56:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 11:56:01 +0000 Subject: [Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 --- Comment #1 from Joonas Kylmälä --- Created attachment 127901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127901&action=edit Bug 29537: Remove unnecessary if-else checks for soonest renew date GetSoonestRenewDate() calculates the renewal due date now also correctly for auto-renewals after the fixes from bug 29537 so we don't have to add any if-else checks because of it being buggy anymore. To test: 1) prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 12:56:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 11:56:52 +0000 Subject: [Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29476 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 12:56:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 11:56:52 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29537 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 12:59:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 11:59:28 +0000 Subject: [Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127901|0 |1 is obsolete| | --- Comment #2 from Joonas Kylmälä --- Created attachment 127902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127902&action=edit Bug 29537: Remove unnecessary if-else checks for soonest renew date GetSoonestRenewDate() calculates the renewal due date now also correctly for auto-renewals after the fixes from bug 29476 so we don't have to add any if-else checks because of it being buggy anymore. To test: 1) prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 13:07:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 12:07:50 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29474 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 13:07:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 12:07:50 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29476 | --- Comment #26 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #25) > The renewal date calculation is buggy for auto-renewals, I made a fix for > that a few days ago in bug 29476. I will mark this bug to now depend on that > bug as "Bug 29474: Pass rules/branchcode to subroutines, further simplify > logic" uses now GetSoonestRenewDate also for auto-renewals as well, thus > requires the bug fix. Also, now that we depend on bug 29476 I can make at > least one further simplification in the code, will attach a patch shortly. After further verification, there is no dependency so I created a completely new bug report for that: bug 29537. It should help *tiny* bit with performance as well so you might consider signing-off that. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 13:14:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 12:14:08 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127632|0 |1 is obsolete| | Attachment #127633|0 |1 is obsolete| | Attachment #127634|0 |1 is obsolete| | Attachment #127635|0 |1 is obsolete| | Attachment #127658|0 |1 is obsolete| | --- Comment #27 from Joonas Kylmälä --- Created attachment 127903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127903&action=edit Bug 29474: Return too_soon before checking renewals This patch allows us to avoid checking reserves when the issue is too_soon and we are running the cron Code is covered by existing tests To test: 1 - prove -v t/db_dependent/Circulation.t Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 13:14:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 12:14:12 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #28 from Joonas Kylmälä --- Created attachment 127904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127904&action=edit Bug 29474: Decouple renewal checks of auto-renewed issues from non-autorenewed The too_soon check does not relate at all to auto-renewed issues and should be moved outside the _CanBookBeAutoRenewed() function. To test: 1) prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 13:14:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 12:14:16 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #29 from Joonas Kylmälä --- Created attachment 127905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127905&action=edit Bug 29474: Remove one layer of indendation by adding if check in the begginning If we simply return "no" immediately from the function when the checkout is not an autorenewed checkout we can drop one layer of indendation and the code becomes much easier to read. To test: 1) prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 13:14:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 12:14:19 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #30 from Joonas Kylmälä --- Created attachment 127906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127906&action=edit Bug 29474: Pass rules/branchcode to subroutines, further simplify logic If we are going to decouple 'too_soon' from auto_renewals we should only call GetSoonestDate once Additionally, we can fetch all needed rules at once and pass to subroutines as needed Rather than check in the sub, let's not call _CanBookBeAutoRenewed if we aren't set for auto_renew Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 13:14:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 12:14:23 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #31 from Joonas Kylmälä --- Created attachment 127907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127907&action=edit Bug 29474: Small efficiency improvement Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 13:15:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 12:15:31 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #32 from Joonas Kylmälä --- Added sign-off to all the patches that were not from me, Nick or Kyle, you could sign-off the patches from me to get this to signed-off state :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 13:23:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 12:23:56 +0000 Subject: [Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |joonas.kylmala at iki.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 13:39:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 12:39:12 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Joonas Kylmälä --- The userid could have been changed later on by the staff member and someone else might have started to use that same userid, thus the DB upgrade here is buggy. Maybe the best bet is just to delete or move the data to some safe place? Or provide somehow instructions for the users to do the data recovery themselves. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 13:45:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 12:45:25 +0000 Subject: [Koha-bugs] [Bug 29533] add more fields to items sql table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29533 --- Comment #1 from Marcel de Rooy --- (In reply to mathieu saby from comment #0) > MARC tag dedicated to items (995 Unimarc / 952 Marc21) can contain a lot of > subfields (0-9 ; a-z ; A-Z). Bad idea. Dont use these capital letters. Not MARC compliant. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 14:41:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 13:41:23 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 --- Comment #24 from Martin Renvoize --- Good call... I didn't actually realise we had the api wrapper on the opac as yet... We need a better way of keeping files like this in sync.. I'd put money on there being other bits of the wrapper that are already out of sync -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 14:58:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 13:58:45 +0000 Subject: [Koha-bugs] [Bug 29533] add more fields to items sql table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29533 --- Comment #2 from mathieu saby --- Hi Even with only lowercases in 952/995, do you believe that the idea of allowing more subfields to be mapped in SQL is a bad idea? But I think uppercases are allowed in UNIMARC for subfields in local (9XX) fields, and I doubt it is forbidden in MARC21. For Marc21 the alphabetic character must be lowercase: Subfield codes - Two characters that distinguish the data elements within a field which require separate manipulation. A subfield code consists of a delimiter (ASCII 1F hex), represented in this document as a $, followed by a data element identifier. Data element identifiers may be a lowercase alphabetic or a numeric character. https://www.loc.gov/marc/bibliographic/bdintro.html But there is no such precision for UNIMARC: Subfield Identifier – A code consisting of two characters identifying individual subfields within a variable field. The first character, the delimiter, is always the same unique character specified in ISO 2709 and the second character, the subfield code, is either numeric or alphabetic https://eprints.mdx.ac.uk/2655/1/UNIMARC-2008-AH_final.pdf And in marcXML schema you can read this, so it seems that uppercase are allowed in MARC21 for local data https://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd "May 21, 2009 - Version 1.2 - in subfieldcodeDataType the pattern "[\da-z!"#$%&'()*+,-./:;<=>?{}_^`~\[\]\\]{1}" changed to: "[\dA-Za-z!"#$%&'()*+,-./:;<=>?{}_^`~\[\]\\]{1}" i.e "A-Z" added after "[\d" before "a-z" to allow upper case. This change is for consistency with the documentation. ************************************************************ This schema supports XML markup of MARC21 records as specified in the MARC documentation (see www.loc.gov). It allows tags with alphabetics and subfield codes that are symbols, neither of which are as yet used in the MARC 21 communications formats, but are allowed by MARC 21 for local data." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 15:07:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 14:07:01 +0000 Subject: [Koha-bugs] [Bug 27912] Quotes break guarantor search. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27912 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi Severity|major |critical --- Comment #1 from Joonas Kylmälä --- I'd even say this is critical as anyone could use self-registration via OPAC and this issue happens also with firstname field so they could make the feature stop working any time they wish. The same bug seems to be also on the file ./prog/en/modules/acqui/tables/members_results.tt in addition to ./prog/en/modules/members/tables/guarantor_search.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 17:37:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 16:37:22 +0000 Subject: [Koha-bugs] [Bug 29538] New: UNIMARC no longer available as marc flavour when installing in Italian Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29538 Bug ID: 29538 Summary: UNIMARC no longer available as marc flavour when installing in Italian Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: john at voipsupport.it QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Installing 21.05 with it-IT, only MARC21 is available. Installing 20.05 with it-IT, it is possible to install MARC21 or Unimarc. To reproduce do a standard package install. I used Ubuntu 21.10 and echo 'deb http://debian.koha-community.org/koha 21.05 main' | sudo tee /etc/apt/sources.list.d/koha.list as repository setup After mysql and koha-common install and normal configurations and library, I ran sudo koha-translate --install it-IT When using the web installer when reaching the marc flavour question, only MARC21 is available. I noticed in git that Koha/installer/data/mysql/it-IT/marcflavour/ which is present in 20.11 is no longer present in 21.05 and language directories have been moved to a localization subdirectory Koha/installer/data/mysql/localization/it-IT/ where there is no marcflavour subdirectory. Not sure then why even MARC21 is shown as available given there is no marcflavour directory. What needs to be done to put UNIMARC installatino support back into the Italian translation? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 20 17:50:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 16:50:08 +0000 Subject: [Koha-bugs] [Bug 29539] New: UNIMARCslimUtils.xsl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29539 Bug ID: 29539 Summary: UNIMARCslimUtils.xsl Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: rafael.antonio at sapo.pt QA Contact: testopia at bugs.koha-community.org When it hapens UNIMARC record to have $9 after $a on biblio_metadata record like Portugal 12005 OPAC details display the authority number and not the term. If we change record for 12005 Portugal it display the term. Is it a bug? The only piece of XSLT code I see for such reason is at UNIMARCslimUtils.xsl file Any comment? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 00:29:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 23:29:54 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #52 from Victor Grousset/tuxayo --- errata: > and is not able to apply on 21.05.x and is *now* able to be applied on 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 00:33:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Nov 2021 23:33:00 +0000 Subject: [Koha-bugs] [Bug 28926] Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 --- Comment #9 from Victor Grousset/tuxayo --- What minimal testing is needed? Must we build packages locally and install? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 03:59:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 02:59:41 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #62 from Victor Grousset/tuxayo --- Hi, I'm trying to see if 20.05.x is affected. How can I test this? I tried setting a server in koha-conf.xml like in bug 29330 comment 40 but it still tries to connect to localhost when sending an OPAC cart. I think it because I would need bug 22343 right? I can't find how it was done before bug 22343. Any hints? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 05:00:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 04:00:44 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #63 from Tomás Cohen Arazi --- (In reply to Victor Grousset/tuxayo from comment #62) > Hi, I'm trying to see if 20.05.x is affected. How can I test this? > > I tried setting a server in koha-conf.xml like in bug 29330 comment 40 but > it still tries to connect to localhost when sending an OPAC cart. I think it > because I would need bug 22343 right? > > I can't find how it was done before bug 22343. Any hints? Prior to bug 22343, Koha expected an MTA in localhost. What I did for testing in those days was installing postfix, and mutt. You can assign localhost as the resolution for any find and have the MTA deliver locally. It was usually enough to use mutt to read the root user emails for bounces and such. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 06:02:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 05:02:35 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #64 from Victor Grousset/tuxayo --- > What I did for testing in those days was installing postfix, and mutt. You can assign localhost as the resolution for any find and have the MTA deliver locally. That might be a little adventure ^^" In case 20.05.x turns out to be affected - it should be, since it uses Email::Valid - the patch conflicts quite a lot due to bug 22343 missing. Unless there is a way that doesn't mess with too much code. I don't think it would be wise to backport (recode more likely) this fix in the less than 48h remaining before the last minor release of 20.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 06:09:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 05:09:37 +0000 Subject: [Koha-bugs] [Bug 29300] Release team 22.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29300 --- Comment #16 from Victor Grousset/tuxayo --- > This patch should be bakported as one of the last things one does prior to their final release as RMaint.. though any time during that last month is fine really as it won't take wider effect until release. But about.pl will still say that the release is maintained while it's already EOL? I plan to revert from 20.05.x unless I missed something and someone tells me. That way it will be like the past cycles where the next team patch was done and backported on the beginning of it's cycle. So only the still supported releases had this team. > Another option is to put 'end of life' details into the teams.yaml and publish that on the about page too? EOL could be mentioned when the RMaint isn't found. Then yes it's makes sense to backport the next team in a release soon-to-be-EOL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 06:13:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 05:13:05 +0000 Subject: [Koha-bugs] [Bug 29204] Error 500 when execute Circulation report with date period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29204 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05,20.11.12 |21.11.00,21.05.05,20.11.12, released in| |20.05.18 CC| |victor at tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #17 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 13:52:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 12:52:41 +0000 Subject: [Koha-bugs] [Bug 29545] New: Bonvoyage Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29545 Bug ID: 29545 Summary: Bonvoyage Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Browser compatibility Assignee: oleonard at myacpl.org Reporter: m-10204236 at moe-dl.edu.my QA Contact: testopia at bugs.koha-community.org Created attachment 127908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127908&action=edit Killo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 13:54:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 12:54:17 +0000 Subject: [Koha-bugs] [Bug 29545] Bonvoyage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29545 --- Comment #1 from MrN3xploit --- Created attachment 127909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127909&action=edit Killobyte AAA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 14:08:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 13:08:50 +0000 Subject: [Koha-bugs] [Bug 29546] New: Ppppppppo Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29546 Bug ID: 29546 Summary: Ppppppppo Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: jasjusmerahxpolit at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 127910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127910&action=edit Jasjus -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 14:11:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 13:11:32 +0000 Subject: [Koha-bugs] [Bug 29547] New: Ppppppppo Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29547 Bug ID: 29547 Summary: Ppppppppo Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: jasjusmerahxpolit at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 14:14:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 13:14:44 +0000 Subject: [Koha-bugs] [Bug 29548] New: Hay Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29548 Bug ID: 29548 Summary: Hay Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: helkyhaxor at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 127911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127911&action=edit Hay -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 14:17:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 13:17:14 +0000 Subject: [Koha-bugs] [Bug 29549] New: Hay Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29549 Bug ID: 29549 Summary: Hay Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: helkyhaxor at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 14:18:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 13:18:58 +0000 Subject: [Koha-bugs] [Bug 29547] Ppppppppo In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29547 --- Comment #1 from Jasjuamerah --- Created attachment 127912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127912&action=edit Pppe -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 14:19:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 13:19:39 +0000 Subject: [Koha-bugs] [Bug 29550] New: Hay Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29550 Bug ID: 29550 Summary: Hay Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: helkyhaxor at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 14:23:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 13:23:23 +0000 Subject: [Koha-bugs] [Bug 29551] New: Hay Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29551 Bug ID: 29551 Summary: Hay Change sponsored?: --- Product: Koha Version: unspecified Hardware: Other OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: helkyhaxor at gmail.com QA Contact: testopia at bugs.koha-community.org Kwkwkw -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 14:24:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 13:24:18 +0000 Subject: [Koha-bugs] [Bug 29551] Hay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29551 TWEntY4 changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |helkyhaxor at gmail.com |ity.org | CC| |helkyhaxor at gmail.com --- Comment #1 from TWEntY4 --- Created attachment 127913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127913&action=edit Hay Kwkwk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 17:01:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 16:01:06 +0000 Subject: [Koha-bugs] [Bug 29545] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29545 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bonvoyage |SPAM Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 17:01:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 16:01:58 +0000 Subject: [Koha-bugs] [Bug 29546] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29546 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Summary|Ppppppppo |SPAM Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 17:02:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 16:02:28 +0000 Subject: [Koha-bugs] [Bug 29548] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29548 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Hay |SPAM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 17:02:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 16:02:41 +0000 Subject: [Koha-bugs] [Bug 29548] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29548 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 21:48:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 20:48:20 +0000 Subject: [Koha-bugs] [Bug 19360] Give items URL a link text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360 Hayley Pelham changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|hayleypelham at catalyst.net.n |koha-bugs at lists.koha-commun |z |ity.org Status|ASSIGNED |NEW --- Comment #28 from Hayley Pelham --- Hi Liz, Marking as new as I don't have time to work on this at the moment, hopefully someone else will pick it up or I'll try to give it a go over Christmas! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 22:11:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 21:11:51 +0000 Subject: [Koha-bugs] [Bug 29264] SIP config allows use of non-branchcode institution ids causes workers to die without responding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29264 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.11.00,21.05.05,20.11.12 |21.11.00,21.05.05,20.11.12, released in| |20.05.18 --- Comment #9 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 22:48:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 21:48:17 +0000 Subject: [Koha-bugs] [Bug 29255] Built-in offline circulation broken with SQL error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Version(s)|21.11.00,21.05.05,20.11.12 |21.11.00,21.05.05,20.11.12, released in| |20.05.18 --- Comment #9 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 22:48:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 21:48:25 +0000 Subject: [Koha-bugs] [Bug 29255] Built-in offline circulation broken with SQL error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 23:04:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 22:04:39 +0000 Subject: [Koha-bugs] [Bug 29550] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29550 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Summary|Hay |SPAM Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 23:05:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 22:05:00 +0000 Subject: [Koha-bugs] [Bug 29551] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29551 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID Summary|Hay |SPAM -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 23:05:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 22:05:32 +0000 Subject: [Koha-bugs] [Bug 29549] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29549 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Hay |SPAM Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 23:06:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 22:06:03 +0000 Subject: [Koha-bugs] [Bug 29547] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29547 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED Summary|Ppppppppo |SPAM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 23:08:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 22:08:04 +0000 Subject: [Koha-bugs] [Bug 29539] UNIMARC: authority number in $9 displays for 606 instead of content of $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29539 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|UNIMARCslimUtils.xsl |UNIMARC: authority number | |in $9 displays for 606 | |instead of content of $a -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 23:09:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 22:09:29 +0000 Subject: [Koha-bugs] [Bug 29536] Need help in hosting in Godaddy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29536 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Katrin Fischer --- Hi Ashish, bugzilla is used for tracking bugs and enhancement requests, but your question is more a support/installation question. Please ask on the mailing list instead where you will reach many more people: https://koha-community.org/support/koha-mailing-lists/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 23:12:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 22:12:25 +0000 Subject: [Koha-bugs] [Bug 29533] add more fields to items sql table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29533 --- Comment #3 from Katrin Fischer --- Thx Mathieu, that comment in the schema is really interesting! Upper case subfields work in Koha, but as Marcel points out they are not standard in MARC21. Bug I know they are used in local data by us and other libraries as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 23:12:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 22:12:54 +0000 Subject: [Koha-bugs] [Bug 29533] add more fields to items sql table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29533 --- Comment #4 from Katrin Fischer --- I'd be interested in what your problem with more_subfields_xml is? We have quite a bit of data there and no issues. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 23:32:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 22:32:13 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #53 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #52) > errata: > > > and is not able to apply on 21.05.x > > and is *now* able to be applied on 21.05.x Could you clarify this one a bit more? I'd like to apply these patches to 21.05. What did you need to do that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 23:37:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 22:37:24 +0000 Subject: [Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 21 23:37:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Nov 2021 22:37:36 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 02:40:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 01:40:55 +0000 Subject: [Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #15 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 02:41:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 01:41:18 +0000 Subject: [Koha-bugs] [Bug 27145] Patron deletion via intranet doesn't handle exceptions well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net --- Comment #12 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 02:41:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 01:41:42 +0000 Subject: [Koha-bugs] [Bug 29321] Remove a last without loop context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29321 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 02:43:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 01:43:05 +0000 Subject: [Koha-bugs] [Bug 29452] Unnecessary warns in sip logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29452 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.11.00,21.05.05,20.11.12 |21.11.00,21.05.05,20.11.12, released in| |20.05.18 --- Comment #8 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 02:44:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 01:44:07 +0000 Subject: [Koha-bugs] [Bug 29405] The patron spec for date_renewed is missing it's format definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29405 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 02:45:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 01:45:53 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #35 from Victor Grousset/tuxayo --- Missing dependencies for 20.05.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 03:20:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 02:20:44 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #54 from Victor Grousset/tuxayo --- (clarified in chat, no change in the backport plan) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 04:36:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 03:36:46 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #55 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #54) > (clarified in chat, no change in the backport plan) Well... I'd say that I still don't really understand and that I'll just wait to see what Kyle comes up with. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 08:20:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 07:20:29 +0000 Subject: [Koha-bugs] [Bug 29480] Add email address as a method for generating the userid when self registering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 Andreas Jonsson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson at kreablo.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 08:48:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 07:48:40 +0000 Subject: [Koha-bugs] [Bug 29533] add more fields to items sql table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29533 --- Comment #5 from Marcel de Rooy --- (In reply to mathieu saby from comment #2) > Even with only lowercases in 952/995, do you believe that the idea of > allowing more subfields to be mapped in SQL is a bad idea? No, not necessarily. > But I think uppercases are allowed in UNIMARC for subfields in local (9XX) > fields, and I doubt it is forbidden in MARC21. As you wrote for MARC21: Data element identifiers may be a lowercase alphabetic or a numeric character. Thats clear language? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 08:57:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 07:57:33 +0000 Subject: [Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #49 from Fridolin Somers --- (In reply to Fridolin Somers from comment #47) > + # Check for item on shelves and OnShelfHoldsAllowed > + return { status => 'onShelfHoldsNotAllowed' } > + unless IsAvailableForItemLevelRequest($item, $patron, > $pickup_branchcode,1); > > Strange : IsAvailableForItemLevelRequest() is not the feature of on shelf > holds allowed, it means hold can be on item level or forced to biblio level > o_O Ah this method is calling : Koha::CirculationRules->get_onshelfholds_policy() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:25:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:25:23 +0000 Subject: [Koha-bugs] [Bug 29480] Add email address as a method for generating the userid when self registering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:47:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:47:05 +0000 Subject: [Koha-bugs] [Bug 19036] Number payment receipts / payment slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:47:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:47:06 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Bug 13985 depends on bug 19036, which changed state. Bug 19036 Summary: Number payment receipts / payment slips https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:47:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:47:07 +0000 Subject: [Koha-bugs] [Bug 28318] accounlintes.credit_number missing on the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28318 Bug 28318 depends on bug 19036, which changed state. Bug 19036 Summary: Number payment receipts / payment slips https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:47:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:47:52 +0000 Subject: [Koha-bugs] [Bug 14233] Add logging support to notices and slips management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:47:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:47:53 +0000 Subject: [Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 Bug 22794 depends on bug 14233, which changed state. Bug 14233 Summary: Add logging support to notices and slips management https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:47:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:47:53 +0000 Subject: [Koha-bugs] [Bug 26734] Convert accounts (monetary) notices to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26734 Bug 26734 depends on bug 14233, which changed state. Bug 14233 Summary: Add logging support to notices and slips management https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:47:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:47:54 +0000 Subject: [Koha-bugs] [Bug 28108] Move action logs 'SERIAL CLAIM' and 'ACQUISITION CLAIM' to a new 'CLAIMS' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28108 Bug 28108 depends on bug 14233, which changed state. Bug 14233 Summary: Add logging support to notices and slips management https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:47:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:47:54 +0000 Subject: [Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 Bug 28872 depends on bug 14233, which changed state. Bug 14233 Summary: Add logging support to notices and slips management https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:48:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:48:30 +0000 Subject: [Koha-bugs] [Bug 26689] Monetary accounts notices should be definable at the credit_type/debit_type level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689 Bug 26689 depends on bug 26734, which changed state. Bug 26734 Summary: Convert accounts (monetary) notices to use GetPreparedLetter https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26734 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:48:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:48:29 +0000 Subject: [Koha-bugs] [Bug 26734] Convert accounts (monetary) notices to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26734 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:48:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:48:30 +0000 Subject: [Koha-bugs] [Bug 28368] Error when printing receipt of point of sale In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28368 Bug 28368 depends on bug 26734, which changed state. Bug 26734 Summary: Convert accounts (monetary) notices to use GetPreparedLetter https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26734 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:48:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:48:56 +0000 Subject: [Koha-bugs] [Bug 28368] Error when printing receipt of point of sale In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28368 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:48:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:48:57 +0000 Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Bug 28374 depends on bug 28368, which changed state. Bug 28368 Summary: Error when printing receipt of point of sale https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28368 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:49:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:49:27 +0000 Subject: [Koha-bugs] [Bug 27796] SIP payment types should not be available as refund types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27796 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:49:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:49:28 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Bug 13985 depends on bug 27796, which changed state. Bug 27796 Summary: SIP payment types should not be available as refund types https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27796 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:49:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:49:28 +0000 Subject: [Koha-bugs] [Bug 17735] Merge boraccount and pay pages into one In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17735 Bug 17735 depends on bug 27796, which changed state. Bug 27796 Summary: SIP payment types should not be available as refund types https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27796 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:49:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:49:29 +0000 Subject: [Koha-bugs] [Bug 28138] Add system preference to make the payment type required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28138 Bug 28138 depends on bug 27796, which changed state. Bug 27796 Summary: SIP payment types should not be available as refund types https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27796 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:50:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:50:36 +0000 Subject: [Koha-bugs] [Bug 28127] POS register details tables should have a transaction date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28127 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:50:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:50:36 +0000 Subject: [Koha-bugs] [Bug 28390] Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Bug 28390 depends on bug 28127, which changed state. Bug 28127 Summary: POS register details tables should have a transaction date https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28127 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:51:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:51:11 +0000 Subject: [Koha-bugs] [Bug 27582] Breadcrumb incorrect for POS: Library details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27582 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:51:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:51:11 +0000 Subject: [Koha-bugs] [Bug 27583] Clarify how cash management fits together In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27583 Bug 27583 depends on bug 27582, which changed state. Bug 27582 Summary: Breadcrumb incorrect for POS: Library details page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27582 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:52:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:52:13 +0000 Subject: [Koha-bugs] [Bug 27967] Modals on the borrower account page don't validate minimum values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27967 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:52:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:52:13 +0000 Subject: [Koha-bugs] [Bug 24300] Add a 'payout amount' option to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300 Bug 24300 depends on bug 27967, which changed state. Bug 27967 Summary: Modals on the borrower account page don't validate minimum values https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27967 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:53:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:53:05 +0000 Subject: [Koha-bugs] [Bug 20212] Improve performance of acquisitions receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27930 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27930 [Bug 27930] Move _escape_* functions from acq/parcel.tt to be re-usable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:53:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:53:05 +0000 Subject: [Koha-bugs] [Bug 27930] Move _escape_* functions from acq/parcel.tt to be re-usable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27930 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20212 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 [Bug 20212] Improve performance of acquisitions receive page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:53:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:53:15 +0000 Subject: [Koha-bugs] [Bug 20212] Improve performance of acquisitions receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:53:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:53:16 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Bug 8179 depends on bug 20212, which changed state. Bug 20212 Summary: Improve performance of acquisitions receive page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:53:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:53:18 +0000 Subject: [Koha-bugs] [Bug 18967] Acquisitions receipt search filter is too sticky In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18967 Bug 18967 depends on bug 20212, which changed state. Bug 20212 Summary: Improve performance of acquisitions receive page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:53:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:53:18 +0000 Subject: [Koha-bugs] [Bug 29464] Sorting broken for receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Bug 29464 depends on bug 20212, which changed state. Bug 20212 Summary: Improve performance of acquisitions receive page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:53:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:53:19 +0000 Subject: [Koha-bugs] [Bug 27719] Receiving orders hangs on processing when missing a replacement price In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 Bug 27719 depends on bug 20212, which changed state. Bug 20212 Summary: Improve performance of acquisitions receive page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:53:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:53:33 +0000 Subject: [Koha-bugs] [Bug 25670] Add useful methods to Koha::Acquisition::Orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:53:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:53:33 +0000 Subject: [Koha-bugs] [Bug 28509] Koha/Acquisition/Orders.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 Bug 28509 depends on bug 25670, which changed state. Bug 25670 Summary: Add useful methods to Koha::Acquisition::Orders https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:53:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:53:34 +0000 Subject: [Koha-bugs] [Bug 20212] Improve performance of acquisitions receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Bug 20212 depends on bug 25670, which changed state. Bug 25670 Summary: Add useful methods to Koha::Acquisition::Orders https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:54:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:54:28 +0000 Subject: [Koha-bugs] [Bug 24300] Add a 'payout amount' option to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:54:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:54:29 +0000 Subject: [Koha-bugs] [Bug 27971] The VOID method should be updated to respect double-entry accounting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27971 Bug 27971 depends on bug 24300, which changed state. Bug 24300 Summary: Add a 'payout amount' option to accounts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:54:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:54:51 +0000 Subject: [Koha-bugs] [Bug 27971] The VOID method should be updated to respect double-entry accounting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27971 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:54:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:54:51 +0000 Subject: [Koha-bugs] [Bug 27995] Koha::Account::Line->apply should return the update Koha::Account::Line object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27995 Bug 27995 depends on bug 27971, which changed state. Bug 27971 Summary: The VOID method should be updated to respect double-entry accounting https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27971 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:54:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:54:51 +0000 Subject: [Koha-bugs] [Bug 28663] One should not be able to apply a discount to a VOID accountline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28663 Bug 28663 depends on bug 27971, which changed state. Bug 27971 Summary: The VOID method should be updated to respect double-entry accounting https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27971 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:54:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:54:52 +0000 Subject: [Koha-bugs] [Bug 28664] One should not be able to issue a refund against a VOID accountline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28664 Bug 28664 depends on bug 27971, which changed state. Bug 27971 Summary: The VOID method should be updated to respect double-entry accounting https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27971 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:54:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:54:52 +0000 Subject: [Koha-bugs] [Bug 28421] Add tests for Voided Payment and Voided Writeoff. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28421 Bug 28421 depends on bug 27971, which changed state. Bug 27971 Summary: The VOID method should be updated to respect double-entry accounting https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27971 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:56:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:56:15 +0000 Subject: [Koha-bugs] [Bug 26469] Register_id saves incorrect value in accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:56:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:56:16 +0000 Subject: [Koha-bugs] [Bug 24786] Allow setting a cash register for a login session and configuring library-default cash registers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Bug 24786 depends on bug 26469, which changed state. Bug 26469 Summary: Register_id saves incorrect value in accountlines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:56:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:56:57 +0000 Subject: [Koha-bugs] [Bug 26273] Expose cashup summary history for a cash register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:56:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:56:57 +0000 Subject: [Koha-bugs] [Bug 27779] Cashup summary 'refunds' should denote what the refund was actioned against. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Bug 27779 depends on bug 26273, which changed state. Bug 26273 Summary: Expose cashup summary history for a cash register https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:57:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:57:12 +0000 Subject: [Koha-bugs] [Bug 26272] Allow cashup summaries to be displayed from the library summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26272 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:57:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:57:13 +0000 Subject: [Koha-bugs] [Bug 27779] Cashup summary 'refunds' should denote what the refund was actioned against. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Bug 27779 depends on bug 26272, which changed state. Bug 26272 Summary: Allow cashup summaries to be displayed from the library summary page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26272 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:57:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:57:44 +0000 Subject: [Koha-bugs] [Bug 26939] Account payment_type in the cash register details page should use description instead of code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26939 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:57:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:57:45 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Bug 13985 depends on bug 26939, which changed state. Bug 26939 Summary: Account payment_type in the cash register details page should use description instead of code https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26939 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:58:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:58:31 +0000 Subject: [Koha-bugs] [Bug 24786] Allow setting a cash register for a login session and configuring library-default cash registers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:58:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:58:31 +0000 Subject: [Koha-bugs] [Bug 26177] The 'set library' functionality should be changed to 'session settings' or similar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26177 Bug 26177 depends on bug 24786, which changed state. Bug 24786 Summary: Allow setting a cash register for a login session and configuring library-default cash registers https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:58:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:58:31 +0000 Subject: [Koha-bugs] [Bug 26540] Server error when attempting to issue cash credit with UseCashRegisters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Bug 26540 depends on bug 24786, which changed state. Bug 24786 Summary: Allow setting a cash register for a login session and configuring library-default cash registers https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:58:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:58:31 +0000 Subject: [Koha-bugs] [Bug 28167] A warning when setting which library to use in intranet and UseCashRegisters is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28167 Bug 28167 depends on bug 24786, which changed state. Bug 24786 Summary: Allow setting a cash register for a login session and configuring library-default cash registers https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 09:58:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 08:58:32 +0000 Subject: [Koha-bugs] [Bug 24665] Add ability to run cash register report with new cash register feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24665 Bug 24665 depends on bug 24786, which changed state. Bug 24786 Summary: Allow setting a cash register for a login session and configuring library-default cash registers https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 10:23:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 09:23:04 +0000 Subject: [Koha-bugs] [Bug 29539] UNIMARC: authority number in $9 displays for 606 instead of content of $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29539 --- Comment #1 from Rafael Antonio --- This problem hapens with all fields that are validate through thesaurus and use $9 to link to authority, not only 606 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 10:33:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 09:33:13 +0000 Subject: [Koha-bugs] [Bug 29539] UNIMARC: authority number in $9 displays for thesaurus controlled fields instead of content of $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29539 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|UNIMARC: authority number |UNIMARC: authority number |in $9 displays for 606 |in $9 displays for |instead of content of $a |thesaurus controlled fields | |instead of content of $a -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 10:55:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 09:55:49 +0000 Subject: [Koha-bugs] [Bug 28617] misc/kohalib.pl no longer useful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 10:55:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 09:55:52 +0000 Subject: [Koha-bugs] [Bug 28617] misc/kohalib.pl no longer useful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122935|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 127916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127916&action=edit Bug 28617: Remove kohalib.pl and rely on PERL5LIB The purpose of this script was to load the relevant Koha lib for the different scripts (installation, cronjob, CLI, etc.) However it is not used consistently and we prefer to rely on PERL5LIB. >From bug 28617 comment 6 from Galen: """ Time marches on, and one of the motivations for having kohalib.pl - making it possible to install Koha without setting a single environment variable - has been obviated by the vast improvements in the ease of installing Koha. Consequently, I think kohalib.pl can go away. """ Test plan: confirm that the changes make sense and that kohalib.pl can be removed safely. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 10:55:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 09:55:56 +0000 Subject: [Koha-bugs] [Bug 28617] misc/kohalib.pl no longer useful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 --- Comment #10 from Marcel de Rooy --- Created attachment 127917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127917&action=edit Bug 28617: (QA follow-up) Restore FindBin in two places Resolving: Name "FindBin::Bin" used only once: possible typo Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:12:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:12:33 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #150 from Jonathan Druart --- Created attachment 127918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127918&action=edit Bug 17600: Fix opac/unapi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:13:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:13:50 +0000 Subject: [Koha-bugs] [Bug 29496] Can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:13:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:13:56 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_candidate, | |rel_21_05_candidate, | |rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:13:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:13:59 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:14:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:14:01 +0000 Subject: [Koha-bugs] [Bug 29463] Umlauts in search field get changed into replacement character In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:14:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:14:06 +0000 Subject: [Koha-bugs] [Bug 29456] "Auto renewal" and "Hold reminder" notice shown as "unknown" on the patron category list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate, | |rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:14:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:14:09 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate, | |rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:14:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:14:11 +0000 Subject: [Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:23:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:23:31 +0000 Subject: [Koha-bugs] [Bug 29500] Flatpickr accepting original date in the past for futuredate but also other dates in the past In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29500 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127803|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 127919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127919&action=edit Bug 29500: Flatpickr - accept original date in the past and not others Bug 29241 was supposed to fix this but it didn't properly. We are accepting other dates in the past when we should only accept the original one (the one from the DB) AND dates in future. Test plan: Retry test plan for 29241 and confirm that you cannot set manually another date in the past. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:24:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:24:13 +0000 Subject: [Koha-bugs] [Bug 29500] Flatpickr accepting original date in the past for futuredate but also other dates in the past In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29500 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- This works as expected.. at some point I'd love to see us do more JS testing, but I don't think we should hold this up. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:36:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:36:00 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127890|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 127920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127920&action=edit Bug 29478: Flatpickr - Restore 'Today' button It's not implemented, looks like we need to use a plugin for that https://github.com/flatpickr/flatpickr/issues/576 https://github.com/jcsmorais/shortcut-buttons-flatpickr Test plan: Confirm that flatpickr instances now have a yesterday, today and tomorrow buttons. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:36:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:36:04 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127891|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize --- Created attachment 127921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127921&action=edit Bug 29478: (follow-up) Provide default style for shortcut buttons This patch adds some CSS to _flatpickr.scss in order to give a deafult style to the "yesterday," "today," and "tomorrow" controls added by the shortcut plugin. A missed translatable string is now wrapped in the __() function: __("or"). The patch also updates the date calculation for those shortcuts to use Flatpickr's date calculation shorthand. This isn't strictly necessary but I think it makes the code more readable. To test, apply the patch and build the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). In the staff client, view some pages with date-picker widgets. A calendar widget time selection: - Circulation -> Check out -> Checkout settings -> Select date: - The calendar widget should have "yesterday," "today," and "tomorrow" controls styled like links appearing after the time selector. The controls should be centered, with the "or" label on the same line. A calendar widget without time selection: - Tools -> Log viewer -> Display from. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:36:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:36:08 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127892|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize --- Created attachment 127922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127922&action=edit Bug 29478: Today should select now for pastinclusive If Today is clicked when we only allow dates in the past and today/now, we should select the current date/time We need to update the maxDate to make it up-to-date, or the maxDate may be set to the minute before and clicking Today will blank the input. Signed-off-by: Owen Leonard Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:36:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:36:12 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127893|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize --- Created attachment 127923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127923&action=edit Bug 29478: (follow-up) Today should select now for pastinclusive This is getting ugly. We need to add 1 minute for the minDate or the 'Today' link may not work. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:37:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:37:36 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #25 from Martin Renvoize --- This all works.. yes the last patch is a bit weird, but I understand the reasoning behind it. I can PQA on the functionality.. though Owens comment regarding disabling the invalid options isn't yet implemented.. I'd love to see that happen, but given the late stag of the cycle I think that can be handled as an early follow-up bug for next cycle. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:40:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:40:07 +0000 Subject: [Koha-bugs] [Bug 29552] New: flatpickr misses quick shortcut to "Today" date Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Bug ID: 29552 Summary: flatpickr misses quick shortcut to "Today" date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: rel_22_05_candidate Severity: major Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: david at davidnind.com, jonathan.druart+koha at gmail.com, martin.renvoize at ptfs-europe.com, nugged at gmail.com, testopia at bugs.koha-community.org Depends on: 29478 >From bug 29478 comment 5: > I thought of an issue when testing my follow-up: Should the shortcut controls reflect the date limitations of the flatpickr instance? For instance, if selection is limited to a date before today, should the "today" and "tomorrow" controls be disabled? Currently clicking a shortcut for a date which is disallowed will empty the date field. I decided we should go with what we have for this coming release, but we should really implement the above asap after release. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 [Bug 29478] flatpickr misses quick shortcut to "Today" date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:40:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:40:07 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29552 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 [Bug 29552] flatpickr misses quick shortcut to "Today" date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:40:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:40:56 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|flatpickr misses quick |flatpickr quick shortcuts |shortcut to "Today" date |should be 'Disabled' for | |invalid dates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:41:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:41:13 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This adds shortcuts to | release notes|yesterday, today and | |tomorrow for the flatpickr | |date selector. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:43:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:43:09 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 --- Comment #20 from Martin Renvoize --- (In reply to David Nind from comment #18) > It looks to me as though Martin has signed this off - have changed the > status. Feel free to change back and I will test. Thanks David, you're right.. I had just forgotten to change the state. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:44:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:44:04 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:44:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:44:47 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:49:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:49:33 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 --- Comment #21 from Jonathan Druart --- Skipping QA, we need it pushed ASAP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:50:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:50:07 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:51:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:51:47 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:52:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:52:15 +0000 Subject: [Koha-bugs] [Bug 29553] New: Reserves: Can't call method "notforloan" on an undefined value Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29553 Bug ID: 29553 Summary: Reserves: Can't call method "notforloan" on an undefined value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com C4::Reserves::IsAvailableForItemLevelRequest my $itemtype = $item->effective_itemtype; my $notforloan_per_itemtype = Koha::ItemTypes->find($itemtype)->notforloan; If you have set item level itypes to biblioitems, but your biblioitem record has itemtype NULL, placing a hold will crash. (You must have an item too.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:53:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:53:47 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 --- Comment #17 from Jonathan Druart --- Created attachment 127924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127924&action=edit Bug 29387: [21.05] Stringify exception when logging error during a batch mod biblio If an exception is raised by one the methods/subroutines called when batch biblio update, the job will fail in the middle and some records won't be processed. Test plan: 0. Don't apply the patch In KTD you can run the a batch mod biblio on the 100 first records and the worker will fail with """ countered object 'C4::Biblio::_koha_modify_biblioitem_nonmarc(): DBI Exception: DBD::mysql::st execute failed: Data too long for column 'lccn' at row 1 at /kohadevbox/koha/C4/Biblio.pm line 423 ', but neither allow_blessed, convert_blessed nor allow_tags settings are enabled (or TO_JSON/FREEZE method missing) at /kohadevbox/koha/Koha/BackgroundJob/BatchUpdateBiblio.pm line 120. """ The UI is not saying anything about this problem. Generate 100 biblionumbers: perl -e 'for (1..100){print "$_\n"}' 1. Apply the patch and confirm than now you see the detail of the batch update and that biblionumber 72 is marked as not been modified with the correct error (raw DBI error) JK: add executable bit to BatchUpdateBiblio.t Signed-off-by: Joonas Kylmälä Signed-off-by: Marcel de Rooy Bug 29387: Stringify exceptions for other background job modules Signed-off-by: Joonas Kylmälä Signed-off-by: Marcel de Rooy Bug 29387: (QA follow-up) Fix modules in test Can't locate object method "new" via package "Koha::BackgroundJob::BatchUpdateBiblio" (perhaps you forgot to load "Koha::BackgroundJob::BatchUpdateBiblio"?) at t/db_dependent/Koha/BackgroundJobs/BatchUpdateBiblio.t line 45. How did it pass at signoff? Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:54:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:54:02 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:54:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:54:10 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:54:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:54:21 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:54:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:54:28 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:54:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:54:50 +0000 Subject: [Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 --- Comment #18 from Jonathan Druart --- (In reply to Kyle M Hall from comment #16) > Doesn't apply to 21.05.x. Please rebase and let me know if this is needed in > 21.05! Yes it's needed, I rebased and squashed the patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:55:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:55:54 +0000 Subject: [Koha-bugs] [Bug 29553] Reserves: Can't call method "notforloan" on an undefined value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29553 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:55:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:55:58 +0000 Subject: [Koha-bugs] [Bug 29553] Reserves: Can't call method "notforloan" on an undefined value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29553 --- Comment #1 from Marcel de Rooy --- Created attachment 127925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127925&action=edit Bug 29553: Fix crash on undefined notforloan value Test plan: Set item level itypes to biblioitems. Find a record with itemtype NULL, having an item. Place a hold. Without this patch, it crashes. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:56:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:56:08 +0000 Subject: [Koha-bugs] [Bug 29553] Reserves: Can't call method "notforloan" on an undefined value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29553 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:59:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:59:29 +0000 Subject: [Koha-bugs] [Bug 29554] New: No itemtype for neworderempty.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554 Bug ID: 29554 Summary: No itemtype for neworderempty.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org neworderempty contains: # Get the item types list, but only if item_level_itype is YES. Otherwise, it will be in the item, no need to display it in the biblio my @itemtypes; @itemtypes = Koha::ItemTypes->search unless C4::Context->preference('item-level_itypes'); I would argue that we should always fetch the itemtypes here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:59:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:59:40 +0000 Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in reports does not work with CONCAT in report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305 --- Comment #23 from Jonathan Druart --- (In reply to Lucas Gass from comment #22) > It appears like this does not work in 20.05, 21.05, or master What exactly? I've tried on master and it seems to work for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:59:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:59:44 +0000 Subject: [Koha-bugs] [Bug 29554] No itemtype for neworderempty.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 11:59:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 10:59:57 +0000 Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in reports does not work with CONCAT in report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305 --- Comment #24 from Jonathan Druart --- (In reply to Jonathan Druart from comment #23) > (In reply to Lucas Gass from comment #22) > > It appears like this does not work in 20.05, 21.05, or master > > What exactly? I've tried on master and it seems to work for me. SELECT itemnumber, CONCAT('', itemnumber, '' ) AS itemnumber FROM items LIMIT 10; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:04:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:04:02 +0000 Subject: [Koha-bugs] [Bug 29496] Can't save an order with mandatory items subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 jmbroust changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust at univ-lyo | |n2.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:14:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:14:51 +0000 Subject: [Koha-bugs] [Bug 29010] Weight input pattern wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29010 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:14:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:14:54 +0000 Subject: [Koha-bugs] [Bug 29010] Weight input pattern wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29010 --- Comment #10 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:14:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:14:56 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:14:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:14:58 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 --- Comment #22 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:15:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:15:00 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:15:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:15:03 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #26 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:15:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:15:05 +0000 Subject: [Koha-bugs] [Bug 29500] Flatpickr accepting original date in the past for futuredate but also other dates in the past In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29500 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:15:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:15:05 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #151 from Jonathan Druart --- (In reply to Jonathan Druart from comment #150) > Created attachment 127918 [details] [review] > Bug 17600: Fix opac/unapi Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:15:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:15:08 +0000 Subject: [Koha-bugs] [Bug 29500] Flatpickr accepting original date in the past for futuredate but also other dates in the past In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29500 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:22:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:22:35 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:22:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:22:37 +0000 Subject: [Koha-bugs] [Bug 29500] Flatpickr accepting original date in the past for futuredate but also other dates in the past In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29500 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:22:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:22:39 +0000 Subject: [Koha-bugs] [Bug 29010] Weight input pattern wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29010 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:22:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:22:40 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:22:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:22:57 +0000 Subject: [Koha-bugs] [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:30:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:30:56 +0000 Subject: [Koha-bugs] [Bug 29538] UNIMARC no longer available as marc flavour when installing in Italian In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29538 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major Depends on| |27621 Version|21.05 |unspecified See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27619 CC| |bgkriegel at gmail.com, | |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- Hi John, I have contacted you some months ago and you told me you weren't using them. Yes, we have removed the it-IT installer files (bug 27621) to make them use the normal translation process. The downside is that fr-FR has not been removed yet (bug 27619), and so UNIMARC frameworks are not available for other languages. Bernardo is working on it but it's long and tedious. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27621 [Bug 27621] Remove it-IT installer data -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:30:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:30:56 +0000 Subject: [Koha-bugs] [Bug 27621] Remove it-IT installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27621 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29538 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29538 [Bug 29538] UNIMARC no longer available as marc flavour when installing in Italian -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:30:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:30:56 +0000 Subject: [Koha-bugs] [Bug 27619] Remove fr-FR installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29538 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:38:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:38:11 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 --- Comment #5 from Martin Renvoize --- Created attachment 127926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127926&action=edit Bug 29504: Allow 'ADDITIONAL_MATERIALS' check to be confirmed The additional materials check when CircConfirmParts is enabled was errantly relying upon the 'FORCE_CHECKOUT' permission. This patch updates the template to allow confirmation as well as cancellation of chekout. Test plan 1. Set a staff member with circ permissions, but not FORCE_CHECKOUT 2. Turn on CircConfirmItemParts 3. Log in as staff member in step 1 4. Attempt to checkout an item with a 952$3 5. The only option given is the Continue button (with a red X) and when clicked, the item does not get checked out. 6. Apply patch 7. Repeat step 4. 8. You should now have the option to 'Yes, check out (Y)' or 'No, don't check out (N)' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:38:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:38:26 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:38:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:38:44 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:38:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:38:55 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:39:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:39:16 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 --- Comment #6 from Martin Renvoize --- There are no string changes here, just template logic fixes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:46:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:46:58 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #55 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:48:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:48:23 +0000 Subject: [Koha-bugs] [Bug 29553] Holds: Can't call method "notforloan" on an undefined value when placing a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29553 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Reserves: Can't call method |Holds: Can't call method |"notforloan" on an |"notforloan" on an |undefined value |undefined value when | |placing a hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:49:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:49:29 +0000 Subject: [Koha-bugs] [Bug 29554] No itemtype for neworderempty.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554 --- Comment #1 from Katrin Fischer --- I think this might be used for the itemtype pull down visible in the new order form when item level itype is set to biblio. It's not visible otherwise, which would explain the comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 12:59:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 11:59:55 +0000 Subject: [Koha-bugs] [Bug 29485] selenium/administration_tasks.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29485 --- Comment #6 from Kyle M Hall --- (In reply to Fridolin Somers from comment #5) > I see it has been reverted from 21.05.x : > > 4107c8def4 Revert "Bug 29485: Trying to prevent administration_tasks.t to > fail randomly" Yes, my bad for not posting an update. Patched unit tests run and pass, but are superfluous as parent bug is not part of 21.05.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 13:52:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 12:52:39 +0000 Subject: [Koha-bugs] [Bug 29554] No itemtype for neworderempty.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #1) > I think this might be used for the itemtype pull down visible in the new > order form when item level itype is set to biblio. It's not visible > otherwise, which would explain the comment. Sure. But thats arguable. I dont like creating records with bibliotems.itemtype NULL even when the item level itype is item. Note that 942c is mandatory in the editor too. These NULL itemtypes make Koha crash on other code locations. Since we often assume that the itemtype should be found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 13:53:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 12:53:10 +0000 Subject: [Koha-bugs] [Bug 29554] No itemtype for neworderempty.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554 --- Comment #3 from Marcel de Rooy --- - tagfield: "942" tagsubfield: "c" liblibrarian: "Koha item type" libopac: "Koha item type" repeatable: 0 mandatory: 1 kohafield: biblioitems.itemtype tab: 9 authorised_value: itemtypes authtypecode: "" value_builder: "" isurl: hidden: 0 frameworkcode: "" seealso: "" link: "" defaultvalue: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 13:54:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 12:54:05 +0000 Subject: [Koha-bugs] [Bug 29554] neworderempty.pl may create records with biblioitems.itemtype NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|No itemtype for |neworderempty.pl may create |neworderempty.pl |records with | |biblioitems.itemtype NULL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 13:54:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 12:54:24 +0000 Subject: [Koha-bugs] [Bug 29554] neworderempty.pl may create records with biblioitems.itemtype NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29553 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 13:54:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 12:54:24 +0000 Subject: [Koha-bugs] [Bug 29553] Holds: Can't call method "notforloan" on an undefined value when placing a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29553 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29554 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 14:03:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 13:03:12 +0000 Subject: [Koha-bugs] [Bug 29554] neworderempty.pl may create records with biblioitems.itemtype NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 14:03:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 13:03:15 +0000 Subject: [Koha-bugs] [Bug 29554] neworderempty.pl may create records with biblioitems.itemtype NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554 --- Comment #4 from Marcel de Rooy --- Created attachment 127927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127927&action=edit Bug 29554: Do not hide display of itemtypes on neworderempty Hiding them may lead to biblioitems.itemtype==NULL. We do not want that, since 942$c is mandatory. Test plan: Create basket, create order from new empty record. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 14:06:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 13:06:34 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 --- Comment #7 from Jonathan Druart --- Batch checkout is broken as well for 'ADDITIONAL_MATERIALS'. I've tried to fix it but it's not trivial, and I think this patch is impacted by the same problem. You can have ADDITIONAL_MATERIALS AND another flags, in that case you shouldn't be allowed to bypass. We need to test that ADDITIONAL_MATERIALS is the only flag that needs a confirmation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 14:24:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 13:24:38 +0000 Subject: [Koha-bugs] [Bug 29524] cannot set a new value for privacy_guarantor_checkouts in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical Depends on| |28935 CC| |jonathan.druart+koha at gmail. | |com Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Status|NEW |ASSIGNED --- Comment #1 from Jonathan Druart --- Caused by commit 5f37d8d2f496ce3c9fd6dfd5a2efa7a9fe435af3 Bug 28935: No filtering on patron's data on member entry pages Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28935 [Bug 28935] No filtering on patron's data on member entry pages (OPAC, self registration, staff interface) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 14:24:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 13:24:38 +0000 Subject: [Koha-bugs] [Bug 28935] No filtering on patron's data on member entry pages (OPAC, self registration, staff interface) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28935 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29524 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 [Bug 29524] cannot set a new value for privacy_guarantor_checkouts in memberentry.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 14:26:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 13:26:02 +0000 Subject: [Koha-bugs] [Bug 29555] New: Auto-renewals digest reports on 'auto_too_soon' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29555 Bug ID: 29555 Summary: Auto-renewals digest reports on 'auto_too_soon' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When a patron has requested auto-renewal digests the cron sends emails when all items are 'auto_too_soon' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 14:29:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 13:29:06 +0000 Subject: [Koha-bugs] [Bug 29524] cannot set a new value for privacy_guarantor_checkouts in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 14:29:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 13:29:10 +0000 Subject: [Koha-bugs] [Bug 29524] cannot set a new value for privacy_guarantor_checkouts in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 --- Comment #2 from Jonathan Druart --- Created attachment 127928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127928&action=edit Bug 29524: (bug 28935 follow-up) Restore modification of some patron's attributes On commit 5f37d8d2f496ce3c9fd6dfd5a2efa7a9fe435af3 Bug 28935: No filtering on patron's data on member entry pages we restricted the list of the columns from the borrowers table that can be modified from the patron edit view. We were too restrictive, the following 3 attributes can be edited from this form: privacy_guarantor_fines, privacy_guarantor_checkouts, checkprevcheckout and lang Test plan: Turn on the following prefs: - AllowStaffToSetFinesVisibilityForGuarantor - AllowStaffToSetCheckoutsVisibilityForGuarantor - CheckPrevCheckout (set to 'unless overridden *') - TranslateNotices Edit a patron and see the 4 different options are now displayed. Change their value, save, edit again Confirm that the values have been saved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 14:31:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 13:31:25 +0000 Subject: [Koha-bugs] [Bug 29524] cannot set a new value for privacy_guarantor_checkouts in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 14:33:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 13:33:22 +0000 Subject: [Koha-bugs] [Bug 29555] Auto-renewals digest reports on 'auto_too_soon' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29555 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 14:33:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 13:33:25 +0000 Subject: [Koha-bugs] [Bug 29555] Auto-renewals digest reports on 'auto_too_soon' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29555 --- Comment #1 from Nick Clemens --- Created attachment 127929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127929&action=edit Bug 29555: Don't push auto_too_soon issues into report This patch adds a conditional to avoid reporting on issues that are too soon to be renewed To test: 1 - Set AutoRenewalNotices preference to 'according to patron messaging preferences' 2 - Set a patront o request auto renewal emails digested 3 - Checkout an item to the patron, back dated to be opverdue, and marked for auto renewal 4 - Add an email to the patron for testing 5 - perl misc/cronjobs/automatic_renewals.pl -v -c 6 - See the issue is renewed (ensure it is now not overdue) 7 - Confirm the patron was sent a digest with the renewal (on patron 'Notices' tab) 8 - perl misc/cronjobs/automatic_renewals.pl -v -c 9 - See the issue was not renewed 10 - See a notice was sent, with no indication of what happened to the issue 11 - Apply patch 12 - perl misc/cronjobs/automatic_renewals.pl -v -c 13 - Confrim no renewal or notice 14 - Checkout a second item to patron, backdated and set for auto renewal 15 - perl misc/cronjobs/automatic_renewals.pl -v -c 16 - Confirm the correct item is renewed and notice sent 17 - Confirm notice does not include the too soon issue 18 - Checkout a third item 19 - perl misc/cronjobs/automatic_renewals.pl -v -c -b 20 - Confirm correct item is renewed and notice sent, nbot including other two 21 - perl misc/cronjobs/automatic_renewals.pl -v -c -b 22 - Confirm no notice sent -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 14:50:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 13:50:28 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 --- Comment #18 from David Gustafsson --- Hi! As it wasn't really ready for signoff I did not change the status. Have done some manual testing to go through most of the options and catch possible issues after splitting the code into feature branches. There are no (serious at least) bugs fixed, and no features added, just a clean up, so what need to make sure is that the script works as before. There is no test-suite for bulkmarkimport.pl so it's a lot of work for reviewers to go through all the options and fully test the script, but I can at least provide some basic steps wit the most common options. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 15:04:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 14:04:29 +0000 Subject: [Koha-bugs] [Bug 17423] patronimage.pl permission is too restrictive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17423 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29541 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 15:17:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 14:17:04 +0000 Subject: [Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #17 from Nick Clemens --- I believe the patches on bug 29437 resolve the issue here (if a slightly different implementation) *** This bug has been marked as a duplicate of bug 29437 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 15:17:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 14:17:04 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 --- Comment #19 from Nick Clemens --- *** Bug 17979 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 15:27:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 14:27:39 +0000 Subject: [Koha-bugs] [Bug 29524] cannot set a new value for privacy_guarantor_checkouts in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 15:27:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 14:27:42 +0000 Subject: [Koha-bugs] [Bug 29524] cannot set a new value for privacy_guarantor_checkouts in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127928|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 127931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127931&action=edit Bug 29524: (bug 28935 follow-up) Restore modification of some patron's attributes On commit 5f37d8d2f496ce3c9fd6dfd5a2efa7a9fe435af3 Bug 28935: No filtering on patron's data on member entry pages we restricted the list of the columns from the borrowers table that can be modified from the patron edit view. We were too restrictive, the following 3 attributes can be edited from this form: privacy_guarantor_fines, privacy_guarantor_checkouts, checkprevcheckout and lang Test plan: Turn on the following prefs: - AllowStaffToSetFinesVisibilityForGuarantor - AllowStaffToSetCheckoutsVisibilityForGuarantor - CheckPrevCheckout (set to 'unless overridden *') - TranslateNotices Edit a patron and see the 4 different options are now displayed. Change their value, save, edit again Confirm that the values have been saved Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 15:35:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 14:35:22 +0000 Subject: [Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 --- Comment #14 from Nick Clemens --- (In reply to David Cook from comment #13) > (In reply to Nick Clemens from comment #12) > > > Did you benchmark this patch? > > with numSearchResults at 50 - standard sample data, search for 'a' > > Before patch ~2 second > > After patch ~1.85 seconds > > Is that averaged or based on 1 test each? I repeated the tests 10 times each, that was the average -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 15:39:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 14:39:50 +0000 Subject: [Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 --- Comment #18 from Jonathan Druart --- (In reply to Nick Clemens from comment #17) > I believe the patches on bug 29437 resolve the issue here (if a slightly > different implementation) > > *** This bug has been marked as a duplicate of bug 29437 *** Not the second patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 15:47:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 14:47:59 +0000 Subject: [Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 --- Comment #19 from Nick Clemens --- (In reply to Jonathan Druart from comment #18) > (In reply to Nick Clemens from comment #17) > > I believe the patches on bug 29437 resolve the issue here (if a slightly > > different implementation) > > > > *** This bug has been marked as a duplicate of bug 29437 *** > > Not the second patch. Doesn't it? The second patch here pushed the conditions to an array depending on whether we think we have an ISBN or not Bug 29437 removes the attempt to determine which kind of query we have and instead uses 'OR' and builds the same condition each time. As the overlap between title/author and ISBN is very small I think one condition that searches all the fields resolves the issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 15:55:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 14:55:18 +0000 Subject: [Koha-bugs] [Bug 29556] New: MARC21slim2MODS.xsl broken by duplicate template name "part" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556 Bug ID: 29556 Summary: MARC21slim2MODS.xsl broken by duplicate template name "part" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 5927 Bug 5927, "Show series information in search results page" made a change to MARC21slimUtils.xsl, adding a block starting like this: ...this breaks UNAPI in the OPAC when using MODS format because MARC21slim2MODS.xsl, which imports MARC21slimUtils.xsl, also includes the same block. Removing the redundant section from MARC21slim2MODS.xsl should fix the error. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5927 [Bug 5927] Show series information in search results page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 15:55:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 14:55:18 +0000 Subject: [Koha-bugs] [Bug 5927] Show series information in search results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5927 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29556 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556 [Bug 29556] MARC21slim2MODS.xsl broken by duplicate template name "part" -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 15:55:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 14:55:23 +0000 Subject: [Koha-bugs] [Bug 29554] neworderempty.pl may create records with biblioitems.itemtype NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554 --- Comment #5 from Katrin Fischer --- We never set the itemtype on biblio level and haven't had any issues with that in 18.11 - if there are issues now, that would be quite bad. But should this bug report then not be about making the field visible independent from the item-level_itype setting? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 16:03:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 15:03:34 +0000 Subject: [Koha-bugs] [Bug 29556] MARC21slim2MODS.xsl broken by duplicate template name "part" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 16:03:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 15:03:37 +0000 Subject: [Koha-bugs] [Bug 29556] MARC21slim2MODS.xsl broken by duplicate template name "part" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556 --- Comment #1 from Owen Leonard --- Created attachment 127933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127933&action=edit Bug 29556: MARC21slim2MODS.xsl broken by duplicate template name "part" This patch removes a redundant section from MARC21slim2MODS.xsl which was breaking the option to use unAPI in the OPAC using MODS format. To test, apply the patch and view a record in the OPAC using unAPI, e.g.: /cgi-bin/koha/unapi?id=koha:biblionumber:1&format=MODS You should see an XML file where previously there would have been an error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 16:06:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 15:06:45 +0000 Subject: [Koha-bugs] [Bug 28855] Purging Suggestions test should not being on timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 marion.durand at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 16:07:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 15:07:35 +0000 Subject: [Koha-bugs] [Bug 28855] Purging Suggestions test should not being on timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 marion.durand at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|didier.gautheron at biblibre.c |marion.durand at biblibre.com |om | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 16:14:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 15:14:02 +0000 Subject: [Koha-bugs] [Bug 29554] neworderempty.pl may create records with biblioitems.itemtype NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554 --- Comment #6 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #5) > We never set the itemtype on biblio level and haven't had any issues with > that in 18.11 - if there are issues now, that would be quite bad. > > But should this bug report then not be about making the field visible > independent from the item-level_itype setting? Yeah the bug title is a bit cryptic, but describes the problem. And the commit title tells you the fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 16:14:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 15:14:09 +0000 Subject: [Koha-bugs] [Bug 29555] Auto-renewals digest reports on 'auto_too_soon' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29555 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 16:14:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 15:14:12 +0000 Subject: [Koha-bugs] [Bug 29555] Auto-renewals digest reports on 'auto_too_soon' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29555 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127929|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 127934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127934&action=edit Bug 29555: Don't push auto_too_soon issues into report This patch adds a conditional to avoid reporting on issues that are too soon to be renewed To test: 1 - Set AutoRenewalNotices preference to 'according to patron messaging preferences' 2 - Set a patront o request auto renewal emails digested 3 - Checkout an item to the patron, back dated to be opverdue, and marked for auto renewal 4 - Add an email to the patron for testing 5 - perl misc/cronjobs/automatic_renewals.pl -v -c 6 - See the issue is renewed (ensure it is now not overdue) 7 - Confirm the patron was sent a digest with the renewal (on patron 'Notices' tab) 8 - perl misc/cronjobs/automatic_renewals.pl -v -c 9 - See the issue was not renewed 10 - See a notice was sent, with no indication of what happened to the issue 11 - Apply patch 12 - perl misc/cronjobs/automatic_renewals.pl -v -c 13 - Confrim no renewal or notice 14 - Checkout a second item to patron, backdated and set for auto renewal 15 - perl misc/cronjobs/automatic_renewals.pl -v -c 16 - Confirm the correct item is renewed and notice sent 17 - Confirm notice does not include the too soon issue 18 - Checkout a third item 19 - perl misc/cronjobs/automatic_renewals.pl -v -c -b 20 - Confirm correct item is renewed and notice sent, nbot including other two 21 - perl misc/cronjobs/automatic_renewals.pl -v -c -b 22 - Confirm no notice sent Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 16:31:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 15:31:33 +0000 Subject: [Koha-bugs] [Bug 29524] cannot set a new value for privacy_guarantor_checkouts in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 16:33:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 15:33:02 +0000 Subject: [Koha-bugs] [Bug 29524] cannot set a new value for privacy_guarantor_checkouts in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 17:07:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 16:07:02 +0000 Subject: [Koha-bugs] [Bug 29557] New: auto-renew notices should handle failed renewal due to patron expiration Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 Bug ID: 29557 Summary: auto-renew notices should handle failed renewal due to patron expiration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The default auto-renew and auto-renew-digest notices should include logic to tell patrons when their renewals have failed due to upcoming patron expiration. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 17:20:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 16:20:52 +0000 Subject: [Koha-bugs] [Bug 29524] cannot set a new value for privacy_guarantor_checkouts in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 17:20:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 16:20:56 +0000 Subject: [Koha-bugs] [Bug 29524] cannot set a new value for privacy_guarantor_checkouts in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127931|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 127935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127935&action=edit Bug 29524: (bug 28935 follow-up) Restore modification of some patron's attributes On commit 5f37d8d2f496ce3c9fd6dfd5a2efa7a9fe435af3 Bug 28935: No filtering on patron's data on member entry pages we restricted the list of the columns from the borrowers table that can be modified from the patron edit view. We were too restrictive, the following 3 attributes can be edited from this form: privacy_guarantor_fines, privacy_guarantor_checkouts, checkprevcheckout and lang Test plan: Turn on the following prefs: - AllowStaffToSetFinesVisibilityForGuarantor - AllowStaffToSetCheckoutsVisibilityForGuarantor - CheckPrevCheckout (set to 'unless overridden *') - TranslateNotices Edit a patron and see the 4 different options are now displayed. Change their value, save, edit again Confirm that the values have been saved Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 17:21:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 16:21:03 +0000 Subject: [Koha-bugs] [Bug 22671] Built-in offline circulation applicationCache errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22671 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 17:21:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 16:21:10 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 17:21:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 16:21:13 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 17:21:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 16:21:18 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 17:21:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 16:21:22 +0000 Subject: [Koha-bugs] [Bug 29524] cannot set a new value for privacy_guarantor_checkouts in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 17:23:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 16:23:09 +0000 Subject: [Koha-bugs] [Bug 29528] Breadcrumbs on HTML customizations take you to news In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 17:53:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 16:53:25 +0000 Subject: [Koha-bugs] [Bug 29528] Breadcrumbs on HTML customizations take you to news In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 17:53:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 16:53:28 +0000 Subject: [Koha-bugs] [Bug 29528] Breadcrumbs on HTML customizations take you to news In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 --- Comment #1 from Owen Leonard --- Created attachment 127936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127936&action=edit Bug 29528: Breadcrumbs on HTML customizations take you to news This patch removes the "Additional contents" breadcrumb when working with news items or HTML customizations. Since news and HTML customizations are separate links on the Tools home page there's no reason to have the breadcrumbs imply the two sections are connected in any way. We already have the "See News" link, for example, for switching quickly between the two areas. To test, apply the patch and go to Tools -> News. - The breadcrumbs should be: Home > Tools > News - Click "New entry." The breadcrumbs should be: Home > Tools > News > Add additional content (News). Clicking "News" should take you to the correct page. - Go to Tools -> HTML customizations. - The breadcrumbs should be Home > Tools > HTML customizations. - Click "New entry." The breadcrumbs should be: Home > Tools > HTML customizations > Add additional content (HTML customizations). Clicking "HTML customizations" should take you to the correct page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 17:54:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 16:54:50 +0000 Subject: [Koha-bugs] [Bug 29528] Breadcrumbs on HTML customizations take you to news In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 --- Comment #2 from Owen Leonard --- (In reply to Owen Leonard from comment #1) > Since news and HTML > customizations are separate links on the Tools home page there's no > reason to have the breadcrumbs imply the two sections are connected in > any way. There are other changes I'd like to make to this template along these same lines, but I don't want to hold up this patch with string changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 19:00:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 18:00:31 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #17 from Martin Renvoize --- Created attachment 127937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127937&action=edit Bug 29495: Unit Tests Test plan 1. Run updated tests prior to applying new patches.. pass 2. Run updated tests after applying new patches.. pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 19:00:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 18:00:35 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127809|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 127938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127938&action=edit Bug 29495: Drop issue_id constraint from return_claims This patch removes the issue_id constraint from return_claims. Due to the nature of our dual table approach to checkouts/old_checkouts we can't safely hae this constraint and not lose data. Prior to this commit, when an item is checked in we move the checkout from checkouts to old_checkouts.. this therefore triggers the delete of the issue_id from the return_claims table as described by the foreign key constraint. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 19:00:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 18:00:38 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127810|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 127939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127939&action=edit Bug 29495: DBIC Schema Rebuild Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 19:00:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 18:00:42 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127811|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 127940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127940&action=edit Bug 29495: Add DBIC relationships back into Schema This patch adds the relationship accessors back into the affected Schema classes, now below the fold so they are retained during dbic rebuilds. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 19:00:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 18:00:46 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127812|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 127941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127941&action=edit Bug 29495: Add code level constraint replacement This patch adds a check in Koha::Checkouts::ReturnClaim::store to replace the database level foreign key check. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 19:00:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 18:00:50 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127813|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize --- Created attachment 127942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127942&action=edit Bug 29495: Update relationship methods This patch updates the relationship methods found in Koha::Checkouts::ReturnClaim so that they are prefetchable and embeddable on the API. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 19:00:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 18:00:53 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #23 from Martin Renvoize --- Created attachment 127943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127943&action=edit Bug 29495: (follow-up) Use 'item' relationship This patch adds the missing 'item' relationship in Checkouts::ReturnClaim and then uses it from the resolve method. This improve the reliability of the resolution code so it works when the item has already been checked in (without having to check Old::Checkouts). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 19:00:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 18:00:57 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #24 from Martin Renvoize --- Created attachment 127944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127944&action=edit Bug 29495: Add relation tests This patch adds missing tests for relationship accessors in the ReturnClaim class. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 19:01:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 18:01:25 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #25 from Martin Renvoize --- Added missing unit tests.. we're well covered now.. over to QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 19:03:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 18:03:47 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127814|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 127945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127945&action=edit Bug 29519: Allow resolution of claims return at checkin Add a 'Resolve' button in the alert dialogue that is displayed when a lost item with a return claim is checked in. The button will trigger the usual resolution modal allowing the user to pick their resolution. This patch splits the resolution modal out of checkouts.js and checkouts-table.inc so it can be used outside of the checkouts table. We then reload it, optionally based upon the presence of the claims preference, where needed. This has the added benefit that it saves a little bit of page load data in cases where the feature is not enabled. Test plan 1. As we alter the file locations of the resolution handling code we need to test that normal claims functionality continue to work as expected. 2. Test the new functoinality by checking in an item that has been claimed as returned (but not yet resolved). The dialogue box should now contain a 'resolve' button next to each claimant and clicking upon it should trigger the resolution modal where the librarian can subsequently pick the resolution and submit it. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 19:04:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 18:04:12 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127815|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 19:04:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 18:04:41 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 --- Comment #15 from Martin Renvoize --- Tests added to dependancy bug and item relation patch moved there.. Over to QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 19:22:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 18:22:36 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #56 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 19:36:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 18:36:51 +0000 Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #32 from Nick Clemens --- This should be backported to 21.05 - it fixes a bug introduced by 21249 The code in the scripts joins the branches by 'or' - for ES this must be 'OR' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 19:39:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 18:39:04 +0000 Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #33 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 19:42:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 18:42:26 +0000 Subject: [Koha-bugs] [Bug 29538] UNIMARC no longer available as marc flavour when installing in Italian In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29538 --- Comment #2 from John Fawcett --- Hi John probably I misunderstood. I agreed with the suggestion to remove the language specific installer files in favour of using the english .yml file that would be translated on pootle, since this would mean being able to keep the Italian version more aligned to data structure changes in the English version. I was not aware that this meant that only MARC21 would be supported for Italian. I assumed that UNIMARC would also be supported. Is it possible to get UNIMARC back? Is it just a question of doing the translation on pootle and getting up published? If so I am more than willing to help out as I imagine other Italian users are too. Thanks John -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 19:47:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 18:47:14 +0000 Subject: [Koha-bugs] [Bug 29524] Cannot set a new value for privacy_guarantor_checkouts in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|cannot set a new value for |Cannot set a new value for |privacy_guarantor_checkouts |privacy_guarantor_checkouts |in memberentry.pl |in memberentry.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 21:06:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 20:06:54 +0000 Subject: [Koha-bugs] [Bug 28896] Checkin Slip doesn't work for anonymized checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28896 Sara Brown changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbrown at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 21:12:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 20:12:27 +0000 Subject: [Koha-bugs] [Bug 29558] New: Tabbing through item editor no longer works Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29558 Bug ID: 29558 Summary: Tabbing through item editor no longer works Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Libraries are reporting a change to the way you can use the TAB button in the item editor. Prior to 21.05, you could use the TAB key to move through the item editor, hit tab and it would confirm the highlighted/upper choice and go to the next field. You can't just tab to Not For Loan, hit O (for Ordered), and hit tab to select that and jump to collection code. You now have to click and/or use enter. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 21:28:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 20:28:35 +0000 Subject: [Koha-bugs] [Bug 29524] Cannot set a new value for privacy_guarantor_checkouts in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 22:53:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 21:53:39 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds |This enhancement adds release notes|additional logging of |additional logging of |acquisition-related changes |acquisition-related changes |including: |including: |- Order line |- Order line |creation and cancellation |creation and cancellation |- |- |Invoice adjustment |Invoice adjustment |additions, amendments and |additions, amendments and |deletions |deletions |- Order line |- Order line |receipts against an invoice |receipts against an invoice |- Budget adjustments |- Budget adjustments |- Fund |- Fund |adjustments |adjustments |- Order release |- Order release |date |date (EDIFACT) | | |The name of the |The name of |system preference that |the system preference that |enables logging of |enables logging of |acquisition-related changes |acquisition-related changes |was changed from AcqLog to |was changed from AcqLog to |AcquisitionLog. |AcquisitionLog. | | |Note: |Note: |Acquisition logging was |Acquisition logging was |added in Koha 21.05. |added in Koha 21.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 22:55:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 21:55:13 +0000 Subject: [Koha-bugs] [Bug 27287] Make note fields from orders searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27287 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Adds search options for the release notes| |internal and vendor note | |fields from the basket to | |the advanced search form in | |acquisitions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 22:58:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 21:58:46 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 23:08:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 22:08:16 +0000 Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement lets you |This enhancement lets you release notes|include text that patrons |include text that patrons |need to accept before they |need to accept before they |can place an article |can place an article |request (similar to the |request (similar to the |ILLModuleCopyrightClearance |ILLModuleCopyrightClearance |system preference). |system preference). | | |Add |Add |the text required to the |the text required to the |new |new |ArticleRequestsDisclaimerTe |ArticleRequestsDisclaimerTe |xt entry in the news tool. |xt entry in the additional | |contents tool. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 23:16:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 22:16:03 +0000 Subject: [Koha-bugs] [Bug 29555] Auto-renewals digest reports on 'auto_too_soon' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29555 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au Resolution|--- |DUPLICATE Status|Signed Off |RESOLVED --- Comment #3 from David Cook --- Marking this as a duplicate of bug 29381 since it's older and signed off (also Andrew can't sign off Nick's patches). Although after comparing the patches on both issues... I'm not sure that either is 100% correct... *** This bug has been marked as a duplicate of bug 29381 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 23:16:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 22:16:03 +0000 Subject: [Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #8 from David Cook --- *** Bug 29555 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 23:16:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 22:16:42 +0000 Subject: [Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 --- Comment #9 from David Cook --- (In reply to David Cook from comment #8) > *** Bug 29555 has been marked as a duplicate of this bug. *** Nick made different changes on bug 29555 and after comparing both patches I'm thinking that maybe Nick and Joonas should talk and combine the patches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 23:22:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 22:22:15 +0000 Subject: [Koha-bugs] [Bug 26177] The 'set library' functionality should be changed to 'session settings' or similar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26177 --- Comment #5 from David Cook --- Wow I do not recall commenting on this previously but still +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 23:26:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 22:26:45 +0000 Subject: [Koha-bugs] [Bug 25429] `cleanup_database.pl` should remove resolved claims returned after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds the |This enhancement adds the release notes|new |new |`CleanUpDatabaseReturnClaim |`CleanUpDatabaseReturnClaim |s` system preference |s` system preference |allowing administrators to |allowing administrators to |specify how many days after |specify how many days after |resolution a claimed return |resolution a claimed return |record should be deleted |record should be deleted |from the database. |from the database. | | |For |For |this functionality to be |this functionality to be |enabled, the |enabled, the |`cleanup_database.pl` must |`cleanup_database.pl` must |be scheduled to run |be scheduled to run |regularly with the new |regularly with the new |`--returns_claims` |`--return_claims` parameter |parameter passed. |passed. --- Comment #56 from Katrin Fischer --- Wondering: return-claims or return_claims? + --return-claims Purge all resolved return claims older than the number of days specified in + the system preference CleanUpDatabaseReturnClaims. vs. +$return_claims = C4::Context->preference('CleanUpDatabaseReturnClaims') if $return_claims; if ($return_claims) { print "Purging return claims older than $return_claims days.\n" if $verbose; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 23:29:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 22:29:02 +0000 Subject: [Koha-bugs] [Bug 14237] Allow bibs to be added to course without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237 --- Comment #56 from Katrin Fischer --- Should/could we promote this to 'new feature'? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 23:35:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 22:35:46 +0000 Subject: [Koha-bugs] [Bug 27170] ILL availability should be able to display arbitrary links to related resources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 23:35:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 22:35:52 +0000 Subject: [Koha-bugs] [Bug 28340] Provide improved display of ILL request metadata in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 23:54:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 22:54:09 +0000 Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #96 from Katrin Fischer --- Maybe another candidate for 'new feature'? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 23:56:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 22:56:05 +0000 Subject: [Koha-bugs] [Bug 28810] Housebound details should be textarea not text inputs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28810 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com, | |kyle.m.hall at gmail.com Component|OPAC |Circulation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 22 23:59:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 22:59:14 +0000 Subject: [Koha-bugs] [Bug 24406] Add a span to patron category category type codes in patron search result lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove patron category |Add a span to patron |category type codes from |category category type |patron search results |codes in patron search | |result lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 00:07:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 23:07:15 +0000 Subject: [Koha-bugs] [Bug 20688] Add accesskeys for hold confirmation boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |Circulation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 00:07:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 23:07:39 +0000 Subject: [Koha-bugs] [Bug 27850] Search link for 260 a and c in MARC21 XSLT display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27850 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |MARC Bibliographic data | |support -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 00:08:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 23:08:36 +0000 Subject: [Koha-bugs] [Bug 28816] Improve the display of multiple holds during hold process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org Component|Templates |Hold requests CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 00:17:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 23:17:34 +0000 Subject: [Koha-bugs] [Bug 29300] Release team 22.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29300 --- Comment #17 from wainuiwitikapark at catalyst.net.nz --- Could someone please help me with what I should do with this bug for 19.11.x? I think it is too late this month to add it to 19.11.x but I can add it next month? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 00:23:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Nov 2021 23:23:33 +0000 Subject: [Koha-bugs] [Bug 26177] The 'set library' functionality should be changed to 'session settings' or similar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26177 --- Comment #6 from Tomás Cohen Arazi --- 'Session' might be enough? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 01:05:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 00:05:06 +0000 Subject: [Koha-bugs] [Bug 26177] The 'set library' functionality should be changed to 'session settings' or similar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26177 --- Comment #7 from David Cook --- (In reply to Tomás Cohen Arazi from comment #6) > 'Session' might be enough? Thinking about this again... I think that "session" is a developer concept that most staff users wouldn't understand. I think they're all circulation related so maybe "My circulation settings", although that's a lot of text. Maybe "My location"? Since it would be dealing with their branch, desk, cash register... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 01:11:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 00:11:32 +0000 Subject: [Koha-bugs] [Bug 26374] Update for 19974 is not idempotent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26374 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #12 from wainuiwitikapark at catalyst.net.nz --- Not backporting to 19.11.x - LTS version will just backport security patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 01:17:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 00:17:08 +0000 Subject: [Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices between different orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #19 from wainuiwitikapark at catalyst.net.nz --- Not backporting to 19.11.x - LTS version will just backport security patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 01:18:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 00:18:48 +0000 Subject: [Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #16 from wainuiwitikapark at catalyst.net.nz --- Not backporting to 19.11.x - LTS version will just backport security patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 01:20:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 00:20:14 +0000 Subject: [Koha-bugs] [Bug 28904] Update information on Newsletter editor on about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28904 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #22 from wainuiwitikapark at catalyst.net.nz --- Could someone please help me with what I should do with this bug for 19.11.x? I think it is too late this month to add it to 19.11.x but I can add it next month? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 01:22:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 00:22:02 +0000 Subject: [Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #13 from wainuiwitikapark at catalyst.net.nz --- Not backporting to 19.11.x - LTS version will just backport security patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 01:23:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 00:23:37 +0000 Subject: [Koha-bugs] [Bug 29204] Error 500 when execute Circulation report with date period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29204 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #18 from wainuiwitikapark at catalyst.net.nz --- Not backporting to 19.11.x - LTS version will just backport security patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 01:25:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 00:25:48 +0000 Subject: [Koha-bugs] [Bug 29264] SIP config allows use of non-branchcode institution ids causes workers to die without responding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29264 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #10 from wainuiwitikapark at catalyst.net.nz --- Not backporting to 19.11.x - LTS version will just backport security patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 01:27:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 00:27:02 +0000 Subject: [Koha-bugs] [Bug 29255] Built-in offline circulation broken with SQL error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #10 from wainuiwitikapark at catalyst.net.nz --- Not backporting to 19.11.x - LTS version will just backport security patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 01:27:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 00:27:58 +0000 Subject: [Koha-bugs] [Bug 29452] Unnecessary warns in sip logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29452 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #9 from wainuiwitikapark at catalyst.net.nz --- Not backporting to 19.11.x - LTS version will just backport security patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 01:33:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 00:33:49 +0000 Subject: [Koha-bugs] [Bug 26177] The 'set library' functionality should be changed to 'session settings' or similar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26177 --- Comment #8 from Tomás Cohen Arazi --- (In reply to David Cook from comment #7) > (In reply to Tomás Cohen Arazi from comment #6) > > 'Session' might be enough? > > Thinking about this again... I think that "session" is a developer concept > that most staff users wouldn't understand. > > I think they're all circulation related so maybe "My circulation settings", > although that's a lot of text. Maybe "My location"? Since it would be > dealing with their branch, desk, cash register... I like 'Location'. The 'My' part of implicit it could be clarified on a drop-down title/header. To understand my opinion, lol at the account info in OPAC and see how redundant it can get! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 01:50:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 00:50:16 +0000 Subject: [Koha-bugs] [Bug 26177] The 'set library' functionality should be changed to 'session settings' or similar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26177 --- Comment #9 from David Cook --- (In reply to Tomás Cohen Arazi from comment #8) > I like 'Location'. The 'My' part of implicit it could be clarified on a > drop-down title/header. To understand my opinion, lol at the account info in > OPAC and see how redundant it can get! Haha. True! I was thinking of keeping it consistent with other items in the dropdown menu but I'm not opposed to dropping the "My". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 01:50:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 00:50:57 +0000 Subject: [Koha-bugs] [Bug 26177] The 'set library' functionality should be changed to 'session settings' or similar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26177 --- Comment #10 from David Cook --- (Also, lovely to hear from you, but you should go to sleep!) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 07:48:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 06:48:46 +0000 Subject: [Koha-bugs] [Bug 28896] Checkin Slip doesn't work for anonymized checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28896 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen at koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 07:56:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 06:56:50 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #57 from Fridolin Somers --- (In reply to Victor Grousset/tuxayo from comment #51) > > For 20.11.x it might be trickier. Bug 28803 depends on bug 28813 which > depends on 14723 which might not be an easy 20.11.x backport. So > circumventing bug 28803 might be the way. So we can skip for 20.11.x ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 08:11:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 07:11:35 +0000 Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #34 from Fridolin Somers --- Depends on bug 21249 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 09:00:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 08:00:12 +0000 Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 09:20:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 08:20:10 +0000 Subject: [Koha-bugs] [Bug 26177] The 'set library' functionality should be changed to 'session settings' or similar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26177 --- Comment #11 from Katrin Fischer --- I am not sure if session would not be understood, location might get confused with locations in items again. What about something generic like "my settings"? We could imagine using this later for other things like some GUI preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 09:33:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 08:33:07 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibaud.guillot at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 10:34:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 09:34:57 +0000 Subject: [Koha-bugs] [Bug 29559] New: Update creates "unexpected type" entries for standard codes in debit and credit types Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29559 Bug ID: 29559 Summary: Update creates "unexpected type" entries for standard codes in debit and credit types Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: martin.renvoize at ptfs-europe.com After an update from 18.11 to 20.11.11 we notice that there are a lot of "Unexpected type found during upgrade (Voided)" in the patron accounts. It looks like 19.12.00.027 / Bug 24532 and maybe others are related to this. Following entries have been added: select * from account_credit_types; LOST select * from account_debit_types; Pay W It could be related to voiding entries, but I am not fully understanding the issue yet. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 11:25:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 10:25:41 +0000 Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 11:26:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 10:26:09 +0000 Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 12:09:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 11:09:08 +0000 Subject: [Koha-bugs] [Bug 25429] `cleanup_database.pl` should remove resolved claims returned after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds the |This enhancement adds the release notes|new |new |`CleanUpDatabaseReturnClaim |`CleanUpDatabaseReturnClaim |s` system preference |s` system preference |allowing administrators to |allowing administrators to |specify how many days after |specify how many days after |resolution a claimed return |resolution a claimed return |record should be deleted |record should be deleted |from the database. |from the database. | | |For |For |this functionality to be |this functionality to be |enabled, the |enabled, the |`cleanup_database.pl` must |`cleanup_database.pl` must |be scheduled to run |be scheduled to run |regularly with the new |regularly with the new |`--return_claims` parameter |`--return-claims` parameter |passed. |passed. --- Comment #57 from Jonathan Druart --- return-claims -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 12:31:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 11:31:59 +0000 Subject: [Koha-bugs] [Bug 29132] API access denied after update to 19.11.22 due to not executed atomicupdate for api keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29132 --- Comment #3 from Jonathan Druart --- Created attachment 127946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127946&action=edit Bug 28772: DBRev 19.11.23.001 Note that this added back the following patch: "Bug 28772: Do not hash secrets twice" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 12:32:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 11:32:54 +0000 Subject: [Koha-bugs] [Bug 29132] API access denied after update to 19.11.22 due to not executed atomicupdate for api keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29132 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #4 from Jonathan Druart --- Wainui, this patch is moving the dbrev to the updatedatabase.pl script. Note that it also added back a commit you reverted. Do you remember why? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 12:33:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 11:33:20 +0000 Subject: [Koha-bugs] [Bug 29132] API access denied after update to 19.11.22 due to not executed atomicupdate for api keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29132 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com QA Contact| |tomascohen at gmail.com --- Comment #5 from Jonathan Druart --- Tomas, can you have a look please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 12:40:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 11:40:46 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com, | |kyle.m.hall at gmail.com Component|Cataloging |Circulation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 12:42:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 11:42:55 +0000 Subject: [Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 12:42:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 11:42:58 +0000 Subject: [Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127416|0 |1 is obsolete| | --- Comment #10 from Nick Clemens --- Created attachment 127947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127947&action=edit Bug 29381: Prevent sending of automatic renewal messages on every cron run Currently the auto-renewal digest messages are sent on every cron run even if there was nothing to renew or no renewal errors. This regression was introduced in the commit "Bug 18532: Add individual issues to digest notice and hide auto_renewals messaging preference when not needed". To test: 1) set syspref AutoRenewalNotices to be according to patron preferences 2) Enable renewal digest messages on a patron's messaging preferences 3) Checkout a book for patron, during the checkout use the Checkout settings menu to check the box "Automatic renewal" 4) Run $ perl misc/cronjobs/automatic_renewals.pl --send-notices --confirm --digest-per-branch $ perl misc/cronjobs/automatic_renewals.pl --send-notices --confirm --digest-per-branch 5) Notice you have now two renewal messages for the patron 6) Apply patch 7) repeat step 4) and notice you don't get anymore these unnecessary renewal messages Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 12:43:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 11:43:16 +0000 Subject: [Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 12:43:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 11:43:23 +0000 Subject: [Koha-bugs] [Bug 29560] New: Add option to create MARC links when adding items to bundles Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560 Bug ID: 29560 Summary: Add option to create MARC links when adding items to bundles Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Bug 28854 adds the ability to bundle items together for circulation as collections. It may be useful to optionally allow the action of adding an item into a bundle to trigger the creation of MARC field links in the constituent items biblio. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 12:43:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 11:43:32 +0000 Subject: [Koha-bugs] [Bug 29560] Add option to create MARC links when adding items to bundles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28854 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 12:43:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 11:43:32 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29560 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560 [Bug 29560] Add option to create MARC links when adding items to bundles -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 12:43:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 11:43:38 +0000 Subject: [Koha-bugs] [Bug 29560] Add option to create MARC links when adding items to bundles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 12:54:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 11:54:43 +0000 Subject: [Koha-bugs] [Bug 29132] API access denied after update to 19.11.22 due to not executed atomicupdate for api keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29132 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 12:54:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 11:54:47 +0000 Subject: [Koha-bugs] [Bug 29132] API access denied after update to 19.11.22 due to not executed atomicupdate for api keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29132 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127946|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi --- Created attachment 127948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127948&action=edit Bug 28772: DBRev 19.11.23.001 Note that this added back the following patch: "Bug 28772: Do not hash secrets twice" https://bugs.koha-community.org/show_bug.cgi?id=29132 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 12:59:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 11:59:02 +0000 Subject: [Koha-bugs] [Bug 29132] API access denied after update to 19.11.22 due to not executed atomicupdate for api keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29132 --- Comment #7 from Tomás Cohen Arazi --- Tested before the 28772 patches then the upgrade and then this patch. All works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 13:00:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 12:00:05 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 13:00:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 12:00:08 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127903|0 |1 is obsolete| | Attachment #127904|0 |1 is obsolete| | Attachment #127905|0 |1 is obsolete| | Attachment #127906|0 |1 is obsolete| | Attachment #127907|0 |1 is obsolete| | --- Comment #33 from Nick Clemens --- Created attachment 127949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127949&action=edit Bug 29474: Return too_soon before checking renewals This patch allows us to avoid checking reserves when the issue is too_soon and we are running the cron Code is covered by existing tests To test: 1 - prove -v t/db_dependent/Circulation.t Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 13:00:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 12:00:12 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #34 from Nick Clemens --- Created attachment 127950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127950&action=edit Bug 29474: Decouple renewal checks of auto-renewed issues from non-autorenewed The too_soon check does not relate at all to auto-renewed issues and should be moved outside the _CanBookBeAutoRenewed() function. To test: 1) prove t/db_dependent/Circulation.t Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 13:00:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 12:00:15 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #35 from Nick Clemens --- Created attachment 127951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127951&action=edit Bug 29474: Remove one layer of indendation by adding if check in the begginning If we simply return "no" immediately from the function when the checkout is not an autorenewed checkout we can drop one layer of indendation and the code becomes much easier to read. To test: 1) prove t/db_dependent/Circulation.t Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 13:00:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 12:00:18 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #36 from Nick Clemens --- Created attachment 127952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127952&action=edit Bug 29474: Pass rules/branchcode to subroutines, further simplify logic If we are going to decouple 'too_soon' from auto_renewals we should only call GetSoonestDate once Additionally, we can fetch all needed rules at once and pass to subroutines as needed Rather than check in the sub, let's not call _CanBookBeAutoRenewed if we aren't set for auto_renew Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 13:00:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 12:00:22 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #37 from Nick Clemens --- Created attachment 127953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127953&action=edit Bug 29474: Small efficiency improvement Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 13:40:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 12:40:24 +0000 Subject: [Koha-bugs] [Bug 29559] Update creates "unexpected type" entries for standard codes in debit and credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29559 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24532 CC| |jonathan.druart+koha at gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532 [Bug 24532] Some account types are converted to debits when they shouldn't be -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 13:40:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 12:40:24 +0000 Subject: [Koha-bugs] [Bug 24532] Some account types are converted to debits when they shouldn't be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29559 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29559 [Bug 29559] Update creates "unexpected type" entries for standard codes in debit and credit types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 13:48:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 12:48:00 +0000 Subject: [Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 --- Comment #20 from Jonathan Druart --- I've applied the test from the second patch and it's failing. See bug 27008. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 14:18:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 13:18:38 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 --- Comment #1 from Jonathan Druart --- Created attachment 127954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127954&action=edit Bug 29552: Flatpickr - Disable shortcut buttons if inactive If one of the buttons is not relevant we should disable it and mark is as such on the interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 14:20:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 13:20:09 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 --- Comment #2 from Jonathan Druart --- I was curious to know how easy/hard it would be to implement so I gave it a try. It seems quite easy actually, here is my version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 14:33:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 13:33:04 +0000 Subject: [Koha-bugs] [Bug 29557] auto-renew notices should handle failed renewal due to patron expiration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19444 CC| |jonathan.druart+koha at gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 [Bug 19444] Automatic renewal script should not auto-renew if a patron's record has expired -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 14:33:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 13:33:04 +0000 Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not auto-renew if a patron's record has expired In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29557 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 [Bug 29557] auto-renew notices should handle failed renewal due to patron expiration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 14:44:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 13:44:05 +0000 Subject: [Koha-bugs] [Bug 29511] While editing MARC records, subfields appear in varying order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29511 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 14:44:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 13:44:08 +0000 Subject: [Koha-bugs] [Bug 29511] While editing MARC records, subfields appear in varying order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29511 --- Comment #2 from Nick Clemens --- Created attachment 127955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127955&action=edit Bug 29511: Sort hash keys This code exists in authorities/authorities.pl and the hash keys are sorted I just do the same here To test: 1 - Find/create a record with 245a 245h populated 2 - Load/reload the record several times and note that fields c and b are ordered randomly 3 - Apply patch 4 - Reload and note c and b are ordered alphabetically 5 - Move subfield h before subfield c 6 - Save and reload 7 - Confirm that existing/filled fields retain order in the MARC record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 14:44:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 13:44:20 +0000 Subject: [Koha-bugs] [Bug 29511] While editing MARC records, subfields appear in varying order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29511 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 14:53:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 13:53:05 +0000 Subject: [Koha-bugs] [Bug 29557] auto-renew notices should handle failed renewal due to patron expiration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 14:53:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 13:53:08 +0000 Subject: [Koha-bugs] [Bug 29557] auto-renew notices should handle failed renewal due to patron expiration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 --- Comment #1 from Jonathan Druart --- Created attachment 127956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127956&action=edit Bug 29557: Add auto_account_expired to AUTO_RENEWALS It was missing and the notice sent was not providing the reason of the failure. Test plan: Check an item out with a date in the past, mark it as auto renew Modify the expired date of the patron and set it in the past Run the automatic_renewals.pl cronjob script, confirm that the notice now contains the reason of the failure. QA note: The template will be updated only for English installations. Should we add an alert for others? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 14:53:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 13:53:18 +0000 Subject: [Koha-bugs] [Bug 29557] auto-renew notices should handle failed renewal due to patron expiration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 15:44:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 14:44:09 +0000 Subject: [Koha-bugs] [Bug 28896] Checkin Slip doesn't work for anonymized checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28896 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 15:44:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 14:44:27 +0000 Subject: [Koha-bugs] [Bug 29561] New: Remove blank facet for languages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29561 Bug ID: 29561 Summary: Remove blank facet for languages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com Because the field for language facets is part of a control field, it won't be missing from a record, but it may be blank. When indexing into ES this means we put the field in the document empty When aggregating, ES counts these correctly, but we cannot search for them The display of facets includes a link to the empty values, but it isn't visible -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 15:48:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 14:48:46 +0000 Subject: [Koha-bugs] [Bug 29561] Remove blank facet for languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29561 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 15:48:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 14:48:49 +0000 Subject: [Koha-bugs] [Bug 29561] Remove blank facet for languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29561 --- Comment #1 from Nick Clemens --- Created attachment 127957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127957&action=edit Bug 29561: Remove blank facets This patch strips the blank facets from the ES aggregations, this seems to only affect language fields currently, but could affect any facetable field that can contain blank values To test: 1 - Have Koha running Elasticsearch with standard test data, or add some records with blank values in the 008/35-37 2 - Search for 'a' 3 - Look at the language facets, they should appear normal 4 - Browse to: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=&q=a&sort_by=relevance_dsc&count=20&limit=ln: 5 - Note there is now an 'x' under the Languages facet - to remove a limit you cannot see 6 - Apply patch 7 - Reload 8 - Note the x is not there 9 - Inspect HTML, confirm no blank link under language facets -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 15:51:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 14:51:49 +0000 Subject: [Koha-bugs] [Bug 27136] Add languages and avoid displaying nothing in facet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29561 CC| |nick at bywatersolutions.com --- Comment #3 from Nick Clemens --- The update database here needs to be updated to use skeleton.perl as a base Moving the removal of blank facet to bug 29561 - we should not display anything as the facet cannot be searched. We don't include blank searches for any of the facets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 15:51:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 14:51:49 +0000 Subject: [Koha-bugs] [Bug 29561] Remove blank facet for languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29561 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27136 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 15:51:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 14:51:57 +0000 Subject: [Koha-bugs] [Bug 29561] Remove blank facet for languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29561 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 15:53:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 14:53:44 +0000 Subject: [Koha-bugs] [Bug 27904] Improve display in creating profile for staging MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27904 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 15:53:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 14:53:48 +0000 Subject: [Koha-bugs] [Bug 27904] Improve display in creating profile for staging MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27904 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127817|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 127958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127958&action=edit Bug 27904: Improve display in creating profile for staging MARC records for import This patch updates the Stage MARC records for import page, in particular the format of the part of the form for saving or removing a profile. The page moves these controls into their own fieldset so that it is clear they are separate from the "Stage for import" button. The "Remove" control now includes the name of the profile which will be removed. To test, apply the patch and go to Tools -> Stage MARC for import. - Upload a file of records. - Make some changes to the settings and options. - At the bottom of the form you should see a "Save profile" fieldset. - Confirm that the "Save profile" button becomes enabled if you type something in the field (or paste something, or select something from form history). - Confirm that the profile is saved correctly by re-uploading a MARC file and selecting your newly added/edited profile and confirming that the values are set as expected. - In the "Save profile" section there should be a "Remove" link styled with a Bootstrap "trash" icon: "Remove profile: " - Confirm that profile deletion still works correctly. - Confirm that the "Remove" link is updated correctly when you make a selection from the "Profile" dropdown at the top of the form: - Choosing "Do not use profile" should change the "Remove" link to drop the name of the profile and disable the link. - Choosing different profiles should update the name in the "Remove" link. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 16:18:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 15:18:00 +0000 Subject: [Koha-bugs] [Bug 29558] Tabbing through item editor no longer works In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29558 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- I think this is a duplicate of Bug 28903. If I misunderstand, please reopen. *** This bug has been marked as a duplicate of bug 28903 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 16:18:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 15:18:00 +0000 Subject: [Koha-bugs] [Bug 28903] Tab key and drop-down menu in item module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28903 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com --- Comment #14 from Owen Leonard --- *** Bug 29558 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 16:52:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 15:52:56 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127795|0 |1 is obsolete| | --- Comment #19 from David Gustafsson --- Created attachment 127959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127959&action=edit Bug 29440: Refactor and clean up bulkmarcimport.pl To test: 1) Import biblios using ./bulkmarcimport.pl -v -b -file biblios.mrc -insert -update -c=MARC21 -match "control-number,001" -n=1 -l "/tmp/import.log" 2) Verify in /tmp/import.log that one biblio has been inserted 3) Import again without the "-n" option, verify that one biblio has been updated and the rest inserted 4) In the staff interface search the catalog for some string appearing in the imported biblios to verify records have been indexed 5) View/edit some of the biblios the staff interface to very have been properly imported 6) Import authorities using ./bulkmarcimport.pl -v -m=MARCXML -a -file authorities.xml -insert -update -c=MARC21 -keepids="024a" -match "heading-main,100a" -l "/tmp/import.log" -yaml="/tmp/ids.yml" 7) Go to the authorities page and find the imported authority by for example search for a 400 or 100 field value. Verify that the 001 field of the incoming record has been moved to 024a. Also check that the value of 024a appear as a key in /tmp/ids.yml. 8) Edit the authorities.xml file and change the value of field 400a 9) Import authorities again using the same options 10) Verify that the 400a field of the authority in Koha has not been updated (the import was skippped since revision did not change) 11) Edit authorities.xml, replace the value of field 005 in the file with field 005 of the authority in Koha incremented by one 12) Import again with the same options 13) Verify that the 400a field of the authority in Koha now have been updated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 16:53:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 15:53:02 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127796|0 |1 is obsolete| | --- Comment #20 from David Gustafsson --- Created attachment 127960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127960&action=edit Bug 29440: Make authorities import behavior consistent with biblios The current behavior for when importing authorities, when match option is enabled, is to insert as a new authority fetching from db fails. This is both a bit confusing and not consistent with the biblio case where an error is generated. Also clean up error and log messages so both messages/errors and when messages/errors are issued are more consistent for the biblio and authority case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 16:56:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 15:56:29 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 --- Comment #21 from David Gustafsson --- Created attachment 127961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127961&action=edit Authorities MARCXML example -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 16:57:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 15:57:22 +0000 Subject: [Koha-bugs] [Bug 27904] Improve display in creating profile for staging MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27904 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127958|0 |1 is obsolete| | --- Comment #4 from PTFS Europe Sandboxes --- Created attachment 127962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127962&action=edit Bug 27904: Improve display in creating profile for staging MARC records for import This patch updates the Stage MARC records for import page, in particular the format of the part of the form for saving or removing a profile. The page moves these controls into their own fieldset so that it is clear they are separate from the "Stage for import" button. The "Remove" control now includes the name of the profile which will be removed. To test, apply the patch and go to Tools -> Stage MARC for import. - Upload a file of records. - Make some changes to the settings and options. - At the bottom of the form you should see a "Save profile" fieldset. - Confirm that the "Save profile" button becomes enabled if you type something in the field (or paste something, or select something from form history). - Confirm that the profile is saved correctly by re-uploading a MARC file and selecting your newly added/edited profile and confirming that the values are set as expected. - In the "Save profile" section there should be a "Remove" link styled with a Bootstrap "trash" icon: "Remove profile: " - Confirm that profile deletion still works correctly. - Confirm that the "Remove" link is updated correctly when you make a selection from the "Profile" dropdown at the top of the form: - Choosing "Do not use profile" should change the "Remove" link to drop the name of the profile and disable the link. - Choosing different profiles should update the name in the "Remove" link. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 16:57:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 15:57:24 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127961|Authorities MARCXML example |authorities.xml description| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 16:58:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 15:58:01 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 --- Comment #22 from David Gustafsson --- Created attachment 127963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127963&action=edit biblios.mrc -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 16:58:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 15:58:46 +0000 Subject: [Koha-bugs] [Bug 27904] Improve display in creating profile for staging MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27904 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Barbara Johnson --- This worked perfectly. I really like this new layout - it is so much more intuitive. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 17:03:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 16:03:32 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 17:04:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 16:04:12 +0000 Subject: [Koha-bugs] [Bug 29528] Breadcrumbs on HTML customizations take you to news In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127936|0 |1 is obsolete| | --- Comment #3 from PTFS Europe Sandboxes --- Created attachment 127964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127964&action=edit Bug 29528: Breadcrumbs on HTML customizations take you to news This patch removes the "Additional contents" breadcrumb when working with news items or HTML customizations. Since news and HTML customizations are separate links on the Tools home page there's no reason to have the breadcrumbs imply the two sections are connected in any way. We already have the "See News" link, for example, for switching quickly between the two areas. To test, apply the patch and go to Tools -> News. - The breadcrumbs should be: Home > Tools > News - Click "New entry." The breadcrumbs should be: Home > Tools > News > Add additional content (News). Clicking "News" should take you to the correct page. - Go to Tools -> HTML customizations. - The breadcrumbs should be Home > Tools > HTML customizations. - Click "New entry." The breadcrumbs should be: Home > Tools > HTML customizations > Add additional content (HTML customizations). Clicking "HTML customizations" should take you to the correct page. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 17:04:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 16:04:31 +0000 Subject: [Koha-bugs] [Bug 29528] Breadcrumbs on HTML customizations take you to news In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 17:20:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 16:20:10 +0000 Subject: [Koha-bugs] [Bug 18148] Make list of lists in OPAC sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca --- Comment #9 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 18:57:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 17:57:57 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 19:05:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 18:05:08 +0000 Subject: [Koha-bugs] [Bug 19360] Give items URL a link text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360 --- Comment #29 from Liz Rea --- Christmastime is a perfectly acceptable timeline if you have a chance to get to it :D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 19:20:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 18:20:55 +0000 Subject: [Koha-bugs] [Bug 29530] When NumSavedReports is set, show value in pull down of entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 19:58:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 18:58:29 +0000 Subject: [Koha-bugs] [Bug 29530] When NumSavedReports is set, show value in pull down of entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 19:58:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 18:58:32 +0000 Subject: [Koha-bugs] [Bug 29530] When NumSavedReports is set, show value in pull down of entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 --- Comment #1 from Owen Leonard --- Created attachment 127965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127965&action=edit Bug 29530: Fix handling of NumSavedReports preference in reports table This patch updates the way the NumSavedReports preference value is used on the saved reports page so that the setting is correctly incorporated into the DataTable. The patch also expands the description of the NumSavedReports preference in order to clarify the expected behavior when no value is saved. To test, apply the patch and go to Administration -> System preferences and note the value of NumSavedReports. - Go to Reports -> Use saved. - Confirm that the first page of saved reports shows the number specified in NumSavedReports. - In the "Show" dropdown menu, confirm that the number from NumSavedReports is preselected by default. - Expand the dropdown menu to confirm that the NumSavedReports number is positioned sequentially with the default values. For example, if NumSavedReports = "78," the menu options should be "10, 20, 50, 78, 100, All". - Test with various values of NumSavedReports. A blank value should result in the "All" option being selected. A non-numeric or non-positive value should result in the default set of options being used ("10, 20, 50, 100, All"). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 20:59:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 19:59:04 +0000 Subject: [Koha-bugs] [Bug 29562] New: CanItemBeReserved should take patron and item objects as parameters Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 Bug ID: 29562 Summary: CanItemBeReserved should take patron and item objects as parameters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CanItemBeReserved takes a borrowernumber and an itemnumber and then fetches the objects to do calculations. Most calls to the routine already have the object, so we should be able to pass them CanBookBeReserved loops on every item, fetching the patron anew each time. Changing the parameters will increase performance. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 21:00:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 20:00:59 +0000 Subject: [Koha-bugs] [Bug 29562] CanItemBeReserved should take patron and item objects as parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 21:01:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 20:01:03 +0000 Subject: [Koha-bugs] [Bug 29562] CanItemBeReserved should take patron and item objects as parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 --- Comment #1 from Nick Clemens --- Created attachment 127966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127966&action=edit Bug 29562: Adjust CanItemBeReserved to take objects Most of the changes here are simple, this can be read to view the changes Testing that holds can be placed via staff client, and opac, and are disallowed when expected is the best test plan, beyond running the unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 21:01:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 20:01:14 +0000 Subject: [Koha-bugs] [Bug 29562] CanItemBeReserved should take patron and item objects as parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 21:32:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 20:32:24 +0000 Subject: [Koha-bugs] [Bug 29011] Error 500 on item checkout when Pseudonymization is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29011 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #9 from Liz Rea --- 100% if you do not have the kconf entry, you will have this problem. I believe this is fixed in 21.05.04 or 05. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 21:52:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 20:52:17 +0000 Subject: [Koha-bugs] [Bug 29563] New: Version 21.05.05 is missing database update Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29563 Bug ID: 29563 Summary: Version 21.05.05 is missing database update Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org The increment to 21.05.05 was done in these two commits: https://git.koha-community.org/Koha-community/Koha/commit/d4f60deeb7f157177ccbff44e7e7e4c83c992e22 https://git.koha-community.org/Koha-community/Koha/commit/ba30e76d1a08ef84e66583cd4638f6150ffdeee2 But these commits do not update the database, only Koha.pm. Here is what it usually looks like: https://git.koha-community.org/Koha-community/Koha/commit/b17cf65633107306bd5d423998a50b65aaecce65 So if you check out the 21.05.05 tag, Koha.pm says: $VERSION = "21.05.05.000"; But the last DB update in installer/data/mysql/updatedatabase.pl is this: $DBversion = '21.05.04.003'; if( CheckVersion( $DBversion ) ) { $dbh->do( q{ INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('CreateAVFromCataloguing', '1', '', 'Ability to create authorized values from the cataloguing module', 'YesNo') }); NewVersion( $DBversion, 29137, "Add system preference CreateAVFromCataloguing"); } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 21:52:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 20:52:48 +0000 Subject: [Koha-bugs] [Bug 29563] Version 21.05.05 is missing database update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29563 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 23:04:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 22:04:45 +0000 Subject: [Koha-bugs] [Bug 29538] UNIMARC no longer available as marc flavour when installing in Italian In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29538 --- Comment #3 from John Fawcett --- Jonathan (sorry I called you John on the previous update!) just to clarify a bit more. I don't believe that removal of UNIMARC support from Italian localization was ever raised or discussed (or agreed). Please correct me if I got this wrong. I took a look on Pootle and I don't see any missing translation for Italian UNIMARC support. So I do believe that this is a bug. If files about the Italian localization have been deleted without introducing the alternative mechanism, then this is removing a feature. I'm not sure if this is a temporary removal or not, since I don't understand what would be needed to add back UNIMARC support and what help might be needed to do that. My suggestion is to outline what is the strategy for UNIMARC support in non English versions and if that is not something immediate (you mentioned it was long and tedious) then I suggest bringing back the localization files that were deleted (and updating them to latest En UNIMARC code which I can help with) until such time as the strategy can be implemented. thanks John -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 23:13:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 22:13:35 +0000 Subject: [Koha-bugs] [Bug 29132] API access denied after update to 19.11.22 due to not executed atomicupdate for api keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29132 --- Comment #8 from wainuiwitikapark at catalyst.net.nz --- Sorry about this everyone, I do not remember why the patch reverted. Thanks so much!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 23:34:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 22:34:55 +0000 Subject: [Koha-bugs] [Bug 29132] API access denied after update to 19.11.22 due to not executed atomicupdate for api keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29132 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127948|0 |1 is obsolete| | --- Comment #9 from wainuiwitikapark at catalyst.net.nz --- Created attachment 127967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127967&action=edit Bug 28772: DBRev 19.11.23.001 Note that this added back the following patch: "Bug 28772: Do not hash secrets twice" https://bugs.koha-community.org/show_bug.cgi?id=29132 Signed-off-by: Tomas Cohen Arazi Signed-off-by: Wainui Witika-Park -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 23:37:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 22:37:41 +0000 Subject: [Koha-bugs] [Bug 29132] API access denied after update to 19.11.22 due to not executed atomicupdate for api keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29132 --- Comment #10 from wainuiwitikapark at catalyst.net.nz --- I have added this patch to the 19.11.x branch, however I am unsure if I should release this this month as it is the only new patch. 19.11.x is LTS, so only really backporting security patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 23 23:43:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Nov 2021 22:43:20 +0000 Subject: [Koha-bugs] [Bug 29132] API access denied after update to 19.11.22 due to not executed atomicupdate for api keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29132 --- Comment #11 from Tomás Cohen Arazi --- (In reply to wainuiwitikapark from comment #10) > I have added this patch to the 19.11.x branch, however I am unsure if I > should release this this month as it is the only new patch. 19.11.x is LTS, > so only really backporting security patches. ...and important fixes, in my opinion. If a feature got broken, and doesn't introduce new strings, I'd release even out of schedule. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 01:44:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 00:44:57 +0000 Subject: [Koha-bugs] [Bug 29563] Version 21.05.05 is missing database update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29563 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 01:45:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 00:45:29 +0000 Subject: [Koha-bugs] [Bug 29562] CanItemBeReserved should take patron and item objects as parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 02:57:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 01:57:29 +0000 Subject: [Koha-bugs] [Bug 29564] New: Use List::MoreUtils so SIP U16/Xenial does not break Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Bug ID: 29564 Summary: Use List::MoreUtils so SIP U16/Xenial does not break Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org patch to come... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 03:02:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 02:02:33 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #27 from Mason James --- Created attachment 127968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127968&action=edit to test... - run prove t/00-load.t, see error - apply patch 00:07:08.189 koha_1 | # Failed test 'use C4::SIP::Sip::Configuration;' 00:07:08.189 koha_1 | # at t/00-load.t line 46. 00:07:08.189 koha_1 | # Tried to use 'C4::SIP::Sip::Configuration'. 00:07:08.189 koha_1 | # Error: "uniq" is not exported by the List::Util module - run prove t/00-load.t, see tests pass :0) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 03:03:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 02:03:51 +0000 Subject: [Koha-bugs] [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 03:03:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 02:03:54 +0000 Subject: [Koha-bugs] [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 --- Comment #1 from Mason James --- Created attachment 127969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127969&action=edit to test... - run prove t/00-load.t, see error - apply patch 00:07:08.189 koha_1 | # Failed test 'use C4::SIP::Sip::Configuration;' 00:07:08.189 koha_1 | # at t/00-load.t line 46. 00:07:08.189 koha_1 | # Tried to use 'C4::SIP::Sip::Configuration'. 00:07:08.189 koha_1 | # Error: "uniq" is not exported by the List::Util module - run prove t/00-load.t, see tests pass :0) https://bugs.koha-community.org/show_bug.cgi?id=29478 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 03:05:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 02:05:48 +0000 Subject: [Koha-bugs] [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127969|0 |1 is obsolete| | --- Comment #2 from Mason James --- Created attachment 127970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127970&action=edit Bug 29564: Use List::MoreUtils so SIP U16/Xenial does not break - run prove t/00-load.t, see error - apply patch 00:07:08.189 koha_1 | # Failed test 'use C4::SIP::Sip::Configuration;' 00:07:08.189 koha_1 | # at t/00-load.t line 46. 00:07:08.189 koha_1 | # Tried to use 'C4::SIP::Sip::Configuration'. 00:07:08.189 koha_1 | # Error: "uniq" is not exported by the List::Util module - run prove t/00-load.t, see tests pass :0) https://bugs.koha-community.org/show_bug.cgi?id=29478 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 03:07:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 02:07:03 +0000 Subject: [Koha-bugs] [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29264 Depends on| |29264 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29264 [Bug 29264] SIP config allows use of non-branchcode institution ids causes workers to die without responding -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 03:07:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 02:07:03 +0000 Subject: [Koha-bugs] [Bug 29264] SIP config allows use of non-branchcode institution ids causes workers to die without responding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29264 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29564 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29564 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 03:46:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 02:46:35 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #28 from Mason James --- oops, patch attached to wrong BZ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 03:47:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 02:47:15 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127968|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 09:05:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 08:05:20 +0000 Subject: [Koha-bugs] [Bug 29563] Version 21.05.05 is missing database update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29563 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Severity|major |blocker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 09:10:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 08:10:06 +0000 Subject: [Koha-bugs] [Bug 29563] Version 21.05.05 is missing database update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29563 --- Comment #1 from Jonathan Druart --- v21.05.05 is broken and will stay broken. However I think we fixed the package, and the current origin/21.05.x branch seems to be ok -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 09:14:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 08:14:59 +0000 Subject: [Koha-bugs] [Bug 29485] selenium/administration_tasks.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29485 --- Comment #7 from Jonathan Druart --- Created attachment 127971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127971&action=edit Bug 29485: (follow-up) Trying to prevent administration_tasks.t to fail randomly Recreated the problem after run #47 Error while executing command: no such element: Unable to locate element: //*[@id="userid"] at /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm line 411. With this patch I do not longer recreate the failure. It's ugly but, well, I don't have any other solutions. It seems that the accept_alert is taking too long and is async (??) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 09:26:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 08:26:06 +0000 Subject: [Koha-bugs] [Bug 29565] New: selenium/regressions.t can fail on slow boxes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29565 Bug ID: 29565 Summary: selenium/regressions.t can fail on slow boxes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Blocks: 25551 # Failed test 'Encoding in session variables' # at t/db_dependent/selenium/regressions.t line 300. Can't call method "get_text" on an undefined value at t/db_dependent/selenium/regressions.t line 285. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 09:26:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 08:26:06 +0000 Subject: [Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29565 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29565 [Bug 29565] selenium/regressions.t can fail on slow boxes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 09:28:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 08:28:56 +0000 Subject: [Koha-bugs] [Bug 29565] selenium/regressions.t can fail on slow boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29565 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 09:28:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 08:28:59 +0000 Subject: [Koha-bugs] [Bug 29565] selenium/regressions.t can fail on slow boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29565 --- Comment #1 from Jonathan Druart --- Created attachment 127972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127972&action=edit Bug 29565: Prevent regressions.t to fail on slow boxes It's failing randomly on some Jenkins' nodes # Failed test 'Encoding in session variables' # at t/db_dependent/selenium/regressions.t line 300. Can't call method "get_text" on an undefined value at t/db_dependent/selenium/regressions.t line 285. It can be recreated locally with the following changes: @ t/lib/Selenium.pm:50 @ sub new { ); bless $self, $class; $self->add_error_handler; - $self->driver->set_implicit_wait_timeout(5000); + $self->driver->set_implicit_wait_timeout(1000); return $self; } @ t/lib/Selenium.pm:50 @ sub new { ); bless $self, $class; $self->add_error_handler; - $self->driver->set_implicit_wait_timeout(5000); + $self->driver->set_implicit_wait_timeout(1000); return $self; } This patch suggests to simply double the timeout. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 09:32:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 08:32:31 +0000 Subject: [Koha-bugs] [Bug 21670] t/db_dependent/Plugins.t is failing randomly on Jenkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21670 --- Comment #14 from Jonathan Druart --- 16:30:40 koha_1 | Could not unlink /tmp/7LgBZuL/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm.pm: No such file or directory at /kohadevbox/koha/Koha/Plugins/Handler.pm line 107. 16:30:40 koha_1 | 16:30:40 koha_1 | # Failed test 'Koha::Plugins::Handler::delete works correctly (pass 1)' 16:30:40 koha_1 | # at t/db_dependent/Koha/Plugins/Plugins.t line 322. 16:30:40 koha_1 | # Looks like you failed 1 test of 61. 16:30:40 koha_1 | [15:26:45] t/db_dependent/Koha/Plugins/Plugins.t ................................... 16:30:40 koha_1 | Dubious, test returned 1 (wstat 256, 0x100) 16:30:40 koha_1 | Failed 1/61 subtests Koha_Master/1830 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 09:33:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 08:33:00 +0000 Subject: [Koha-bugs] [Bug 29565] selenium/regressions.t can fail on slow boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29565 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 09:33:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 08:33:05 +0000 Subject: [Koha-bugs] [Bug 29565] selenium/regressions.t can fail on slow boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29565 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 09:36:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 08:36:46 +0000 Subject: [Koha-bugs] [Bug 29485] selenium/administration_tasks.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29485 --- Comment #8 from Jonathan Druart --- (In reply to Jonathan Druart from comment #7) > Created attachment 127971 [details] [review] > Bug 29485: (follow-up) Trying to prevent administration_tasks.t to fail > randomly > > Recreated the problem after run #47 > Error while executing command: no such element: Unable to locate element: > //*[@id="userid"] at /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm > line 411. > > With this patch I do not longer recreate the failure. It's ugly but, > well, I don't have any other solutions. It seems that the accept_alert > is taking too long and is async (??) Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 09:37:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 08:37:01 +0000 Subject: [Koha-bugs] [Bug 29565] selenium/regressions.t can fail on slow boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29565 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master --- Comment #2 from Jonathan Druart --- Patch pushed to master for 21.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 09:43:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 08:43:06 +0000 Subject: [Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #11 from Jonathan Druart --- There is a terrible lack of these in this area :-/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 09:43:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 08:43:21 +0000 Subject: [Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 --- Comment #12 from Jonathan Druart --- There is a terrible lack of tests in this area :-/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 09:46:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 08:46:13 +0000 Subject: [Koha-bugs] [Bug 29300] Release team 22.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29300 --- Comment #18 from Martin Renvoize --- Did we reach a final agreement on what our support process would be.. how long is long in LTS terms.. do we continue to maintain three stables + the LTS or do we drop at least one stable so we can concentrate on doing a good job of maintaining an LTS.. how far back to security only releases continue. I think we need to consider these things before adding an 'End of life' date into releases... I'd love to see a rolling stream added personally. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 09:48:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 08:48:21 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #10 from Martin Renvoize --- I don't think we can/should move the data.. there's isn't a good place to put it. Whilst I agree the DB update isn't perfect either... perhaps move the DB update to a script that can be optionally run instead and leave the data as is otherwise.? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 09:51:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 08:51:34 +0000 Subject: [Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 09:51:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 08:51:37 +0000 Subject: [Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 --- Comment #13 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 09:51:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 08:51:40 +0000 Subject: [Koha-bugs] [Bug 29524] Cannot set a new value for privacy_guarantor_checkouts in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 09:51:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 08:51:42 +0000 Subject: [Koha-bugs] [Bug 29524] Cannot set a new value for privacy_guarantor_checkouts in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 10:05:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 09:05:16 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 10:05:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 09:05:35 +0000 Subject: [Koha-bugs] [Bug 29538] UNIMARC no longer available as marc flavour when installing in Italian In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29538 --- Comment #4 from Jonathan Druart --- I am sorry John for the misunderstanding. I thought you didn't need the UNIMARC frameworks from the Koha codebase because you were using yours. At the moment there is no way to have the UNIMARC frameworks installed in it-IT for 21.05 and 21.11 (or any other languages that fr-FR). But I will do my best to make them back in 22.05 It was a temporary removal anyway, the plan is to: 1. build the UNIMARC frameworks that are as close as possible to IFLA's 2. move them to the general directory to make them available for all languages 3. have the framework strings translatable on pootle I am in contact with Bernardo and will get back to you as soon as possible. I am focused on the 21.11 release right now but will hopefully have time to dedicate to this after the release. We will definitely need more hands to translate and check the process, so it's good to know you will be there! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 10:07:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 09:07:00 +0000 Subject: [Koha-bugs] [Bug 29538] UNIMARC no longer available as marc flavour when installing in Italian In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29538 --- Comment #5 from Jonathan Druart --- (note that you can still install 20.11 it-IT with the UNIMARC frameworks and do a regular update to 21.05 or 21.11) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 10:32:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 09:32:33 +0000 Subject: [Koha-bugs] [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | CC| |jonathan.druart+koha at gmail. | |com Keywords| |rel_20_11_candidate, | |rel_21_05_candidate, | |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 10:51:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 09:51:37 +0000 Subject: [Koha-bugs] [Bug 27550] "Duplicate budget" does not keep users associated with that budget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy.breuillard at biblibre. | |com Attachment #127400|1 |0 is patch| | Attachment #127400|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 11:09:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 10:09:17 +0000 Subject: [Koha-bugs] [Bug 29563] Version 21.05.05 is missing database update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29563 --- Comment #2 from Kyle M Hall --- (In reply to Jonathan Druart from comment #1) > v21.05.05 is broken and will stay broken. However I think we fixed the > package, and the current origin/21.05.x branch seems to be ok That is correct. The packages were fixed by Mason IIRC! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 11:39:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 10:39:58 +0000 Subject: [Koha-bugs] [Bug 29566] New: Convert bundle contents modal to a notice Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 Bug ID: 29566 Summary: Convert bundle contents modal to a notice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com We add a simple way to display and print a contents list for bundle items in bug 28854. It would be useful to allow librarians to customise how this list displays and prints; We can achieve that by converting the contents to a notice list other print slips. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 11:40:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 10:40:05 +0000 Subject: [Koha-bugs] [Bug 29566] Convert bundle contents modal to a notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 11:40:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 10:40:16 +0000 Subject: [Koha-bugs] [Bug 29566] Convert bundle contents modal to a notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28854 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 11:40:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 10:40:16 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29566 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 [Bug 29566] Convert bundle contents modal to a notice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 11:45:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 10:45:34 +0000 Subject: [Koha-bugs] [Bug 29563] Version 21.05.05 is missing database update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29563 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 11:53:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 10:53:45 +0000 Subject: [Koha-bugs] [Bug 29524] Cannot set a new value for privacy_guarantor_checkouts in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #6 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 11:56:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 10:56:49 +0000 Subject: [Koha-bugs] [Bug 29567] New: Cataloguing plugins are broken on the batch item mod toold Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 Bug ID: 29567 Summary: Cataloguing plugins are broken on the batch item mod toold Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Tools Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 28445 Broken by bug 28445. See also the FIXME from commit 86156da415141e32e16f2090477be32bda241afb Bug 28445: Adjust code to handle regexs Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 [Bug 28445] Use the task queue for the batch delete and update items tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 11:56:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 10:56:49 +0000 Subject: [Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29567 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 [Bug 29567] Cataloguing plugins are broken on the batch item mod toold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 11:58:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 10:58:48 +0000 Subject: [Koha-bugs] [Bug 29567] Cataloguing plugins are broken on the batch item mod toold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 11:58:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 10:58:52 +0000 Subject: [Koha-bugs] [Bug 29567] Cataloguing plugins are broken on the batch item mod toold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 --- Comment #1 from Jonathan Druart --- Created attachment 127973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127973&action=edit Bug 29567: (bug 28445 follow-up) Restore cataloguing plugins Broken by bug 28445. See also the FIXME from commit 86156da415141e32e16f2090477be32bda241afb Bug 28445: Adjust code to handle regexs The problem is that the cataloguing plugins inject JS code in the DOM BEFORE the footer in somes page we have all the JS loaded at the end of the DOM and so $ (jQuery) is not defined It's working on additem as we don't have the JS in the footer, but the batch item mod tool has it there. Test plan: Batch edit items and confirm that cataloguing are working correctly with this patch applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 11:59:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 10:59:09 +0000 Subject: [Koha-bugs] [Bug 29567] Cataloguing plugins are broken on the batch item mod tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cataloguing plugins are |Cataloguing plugins are |broken on the batch item |broken on the batch item |mod toold |mod tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 11:59:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 10:59:16 +0000 Subject: [Koha-bugs] [Bug 29567] Cataloguing plugins are broken on the batch item mod tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 12:07:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 11:07:49 +0000 Subject: [Koha-bugs] [Bug 29567] Cataloguing plugins are broken on the batch item mod tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 12:12:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 11:12:52 +0000 Subject: [Koha-bugs] [Bug 29524] Cannot set a new value for privacy_guarantor_checkouts in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 12:18:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 11:18:15 +0000 Subject: [Koha-bugs] [Bug 26205] News changes aren't logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 --- Comment #33 from Jonathan Druart --- Here we are adding a new syspref "NewsLog" which will use "NEWS" for module. It will be released in 21.11.00 alongwith bug 24387 that is renaming the whole tool "Additional contents", as well as the syspref NewsToolEditor => AdditionalContentsEditor I am suggesting to rename the syspref NewsLog => AdditionalContentsLog, and use "ADDITIONAL_CONTENTS" for module in the action_logs table. Would that work for you? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 12:19:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 11:19:00 +0000 Subject: [Koha-bugs] [Bug 26205] News changes aren't logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 --- Comment #34 from Jonathan Druart --- Erk, it has been backported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 12:22:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 11:22:05 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 --- Comment #30 from Emmi Takkinen --- (In reply to Martin Renvoize from comment #29) > Also, when autorenewal of items upon payment was added (a similar feature in > my opinion).. we required that the user was given feedback of the change.. > I'd love to see that here too. > I tried to find which feature you mean with this but alas, I failed :D Could you point me the bug number of this so I could take a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 12:30:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 11:30:25 +0000 Subject: [Koha-bugs] [Bug 22972] Proposal for enriching the bibliographic records with standard identifiers from authority data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22972 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #3 from Paul Poulain --- One of our libraries is interested by this feature, they asked me to have a look at this ticket. Some explanations (from history) : I'm the developer who wrote the MARC management in Koha (in 2003...) The $9 was chosen to store a link between biblio & authority because it was for local use (as any field/subfield with a 9). In UNIMARC, the $3 was a possible field (as it contains the linkage), in MARC21 there was no subfield for that. But anyway, I thought (and still think) it was better to keep the $3 as it is and use a local field because it stores a local information (the authid of the authority in the local [Koha] system) In France, the SUDOC (national academic catalogue) makes an extensive usage of the $3, we must preserve it. Otherwise : That's a very good idea to add the wikidata reference (or any other one) and your specification seems OK, I have a couple of comment though: - switch the feature on/off => not sure it's needed, if the next syspref is empty, it's OFF ;) - source of the standard IDs (possibly different for different biblio fields?) (standard in MARC 21 authority: 024, but may be also 010/035) (a list) => I agree, it must not be at a global level. But counter-proposal : define that in the authority level. In the authority definition, we define which authority field must be copied in the biblio field [for example, corporate name is copied from the 110 of the authority]. Shouldn't we have another option to say "024$a" is copied in the $1 of the biblio ? [the $1 is possible for UNIMARC, it's an unused field] - how many ids should be copied (= how may $0 added): only the first found or all of them => I would say "copy only one". Of maybe add another option in the authority definition to say "add the 1st where source/$2=[_____]" [$2 is valid for UNIMARC too] - if an extra link/icon should be generated in display (OPAC / librarian) => I think we just need to improve the XSLT for that. Very interesting proposal though ! I'll continue talking with the library to see if they can sponsor the dev -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 13:11:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 12:11:11 +0000 Subject: [Koha-bugs] [Bug 29567] Cataloguing plugins are broken on the batch item mod tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 13:11:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 12:11:14 +0000 Subject: [Koha-bugs] [Bug 29567] Cataloguing plugins are broken on the batch item mod tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127973|0 |1 is obsolete| | --- Comment #2 from Andrew Nugged --- Created attachment 127974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127974&action=edit Bug 29567: (bug 28445 follow-up) Restore cataloguing plugins Broken by bug 28445. See also the FIXME from commit 86156da415141e32e16f2090477be32bda241afb Bug 28445: Adjust code to handle regexs The problem is that the cataloguing plugins inject JS code in the DOM BEFORE the footer in somes page we have all the JS loaded at the end of the DOM and so $ (jQuery) is not defined It's working on additem as we don't have the JS in the footer, but the batch item mod tool has it there. Test plan: Batch edit items and confirm that cataloguing are working correctly with this patch applied. Signed-off-by: Andrew Nugged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 13:13:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 12:13:01 +0000 Subject: [Koha-bugs] [Bug 29568] New: Are your Google servers down Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29568 Bug ID: 29568 Summary: Are your Google servers down Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: windikartika376 at gmail.com QA Contact: testopia at bugs.koha-community.org Assuming you are a Google client and confronting issues with your Google account since Google servers down then you are at the perfect spot. Some of the time this issue settle following a couple of moments or hours and here and there it might require a few days. Try not to stress you can resolve these issues without help from anyone else by follow some straightforward advances. https://www.contactcustomerservice.co/blog/google-outage/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 13:13:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 12:13:22 +0000 Subject: [Koha-bugs] [Bug 29568] Are your Google servers down In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29568 windikartika changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://www.contactcustomer | |service.co/blog/google-outa | |ge/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 13:16:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 12:16:08 +0000 Subject: [Koha-bugs] [Bug 29569] New: Want the cash.app/help number to check balance? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29569 Bug ID: 29569 Summary: Want the cash.app/help number to check balance? Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: windikartika376 at gmail.com QA Contact: testopia at bugs.koha-community.org Want to get the number of the cash.app/help to check the balances then you have knocked on the correct door to get the number of cash app help desk to check the balance in the cash app account. you will easily get the number here because we made it so simple for you by placing a link here that will directly take you to that number which you want. But for this, you have to click the link. https://www.contactcustomerservice.co/cash-app -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 14:39:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 13:39:36 +0000 Subject: [Koha-bugs] [Bug 27550] "Duplicate budget" does not keep users associated with that budget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 --- Comment #3 from Jérémy Breuillard --- Created attachment 127975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127975&action=edit Bug 27550: "Duplicate budget" does not keep users associated with that budget When a budget is duplicated, Owner is copied but not Users Test plan : Home > Administration > Budgets 1)Create a budget to allow (active or inactive) 2)Give it some funds by filling up the form, especially Owner and User(s) 3)Submit then go back to the Budgets dashboard 4)Duplicate the Budget and click on its name 5)Edit it and notice that User(s) is empty 6)Apply the patch 7)Repeat from 1) to 5) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 14:41:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 13:41:31 +0000 Subject: [Koha-bugs] [Bug 27550] "Duplicate budget" does not keep users associated with that budget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 14:44:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 13:44:07 +0000 Subject: [Koha-bugs] [Bug 29563] Version 21.05.05 is missing database update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29563 --- Comment #3 from Magnus Enger --- > That is correct. The packages were fixed by Mason IIRC! OK. I was seeing this because I was upgrading a gitifed install to 21.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 14:46:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 13:46:18 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127601|0 |1 is obsolete| | --- Comment #33 from David Gustafsson --- Created attachment 127976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127976&action=edit Bug 25539: Remove AddBiblio option "defer_marc_save" Items are no longer embedded in the MARCXML and because of this the MARC data does not need to be saved once more after changing record items data. The "defer_marc_save" is no longer needed since bulkmarcimport.pl was the only place this option was utilized in order to resave MARC data after possibly changing items data. There is also a bug bulkmarcimport.pl where the record data is re-saved without stripping items if duplicate items are found and the dedup barcodes option is enabled that is resolved by this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 14:46:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 13:46:23 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127603|0 |1 is obsolete| | --- Comment #34 from David Gustafsson --- Created attachment 127977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127977&action=edit Bug 25539: Strip items when adding new biblio to preserve previous behaviour of the script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 15:32:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 14:32:56 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127976|0 |1 is obsolete| | --- Comment #35 from David Gustafsson --- Created attachment 127978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127978&action=edit Bug 25539: Remove AddBiblio option "defer_marc_save" Items are no longer embedded in the MARCXML and because of this the MARC data does not need to be saved once more after changing record items data. The "defer_marc_save" is no longer needed since bulkmarcimport.pl was the only place this option was utilized in order to resave MARC data after possibly changing items data. There is also a bug bulkmarcimport.pl where the record data is re-saved without stripping items if duplicate items are found and the dedup barcodes option is enabled that is resolved by this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 15:33:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 14:33:01 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127977|0 |1 is obsolete| | --- Comment #36 from David Gustafsson --- Created attachment 127979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127979&action=edit Bug 25539: Strip items when adding new biblio to preserve previous behaviour of the script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 15:41:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 14:41:10 +0000 Subject: [Koha-bugs] [Bug 27887] Patrons should not receive overdue notices for claimed returns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27887 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org --- Comment #2 from George Williams (NEKLS) --- I'd rather see the ability to decide on a claims-returned-by-claims-returned basis whether or not an overdue notice is sent regarding claims returned items. I'd like to see a checkbox in the claims returned table that staff can check on or off to determine whether or not a notice is sent. That would be far more flexible than an all-on or all-off feature. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 15:46:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 14:46:05 +0000 Subject: [Koha-bugs] [Bug 29568] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29568 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Are your Google servers |SPAM |down | Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 15:46:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 14:46:17 +0000 Subject: [Koha-bugs] [Bug 29568] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29568 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://www.contactcustomer | |service.co/blog/google-outa | |ge/ | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 15:47:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 14:47:07 +0000 Subject: [Koha-bugs] [Bug 29304] Add a first time login page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29304 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #1 from Barbara Johnson --- This is an excellent idea. I can imagine using this to highlight library services, give info on checking out, placing holds, digital resources, hours, sign up for library newsletter, etc. I like the idea of allowing the first time users to get back to the page and to have the option to not show it again if they don't want to see it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 16:01:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 15:01:32 +0000 Subject: [Koha-bugs] [Bug 28832] Batch modification always clears permanent_location if it is mapped in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |21.05 --- Comment #12 from Nick Clemens --- (In reply to Jonathan Druart from comment #11) > After bug 28445 I don't recreate the problem. Can you confirm, Nick? Yes, however, it still affects 21.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 16:02:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 15:02:42 +0000 Subject: [Koha-bugs] [Bug 29570] New: unable to sort pending_orders table on parcel.pl by summary column Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Bug ID: 29570 Summary: unable to sort pending_orders table on parcel.pl by summary column Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Have a pending order and go to: /cgi-bin/koha/acqui/parcel.pl?invoiceid=X Most of the columns you are able to sort but they summary column you cannot, it has the 'sorting_disabled' class. Librarians with large orders need to be able to sort by Summary. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 16:03:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 15:03:57 +0000 Subject: [Koha-bugs] [Bug 24304] Incomplete returns (notes) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24304 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #3 from Barbara Johnson --- I like this idea. Staff spends a lot of time adding messages about missing pieces to patron accounts and this would help streamline the process. At our library, we block the patron until the missing pieces are returned so having an option on the modal to block the patron's account would be helpful to us. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 16:05:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 15:05:00 +0000 Subject: [Koha-bugs] [Bug 29570] unable to sort pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 16:14:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 15:14:46 +0000 Subject: [Koha-bugs] [Bug 14237] Allow bibs to be added to course without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 16:16:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 15:16:07 +0000 Subject: [Koha-bugs] [Bug 29326] _ALL_ should not override other rules in UpdateItemLocationOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29326 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #1 from Barbara Johnson --- +1 We use the CART functionality but we also have some special collections such as Library of Things and STEM kits that we would like to handle differently. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 16:36:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 15:36:04 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 16:36:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 15:36:09 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127978|0 |1 is obsolete| | --- Comment #37 from David Gustafsson --- Created attachment 127980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127980&action=edit Bug 25539: Remove AddBiblio option "defer_marc_save" Items are no longer embedded in the MARCXML and because of this the MARC data does not need to be saved once more after changing record items data. The "defer_marc_save" is no longer needed since bulkmarcimport.pl was the only place this option was utilized in order to resave MARC data after possibly changing items data. There is also a bug bulkmarcimport.pl where the record data is re-saved without stripping items if duplicate items are found and the dedup barcodes option is enabled that is resolved by this change. This change enables MARC Overlay rules to be enabled for bulkmarkcimport.pl as using the defer_marc option would previously effectively bypass any defined rules. To test 1) Apply patch 29440 (which this depends on), but no not yet apply this patch 2) Enable MARC overlay rules and add a rule (with source => "*" or 'bulkmarcimport') to protect some field. 3) Import a biblio using the bulkmarcimport script. Overlay rules will only be applied on updates so a match condition need to be supplied (for example -match "control-number,001") 4) Edit the imported biblio and change the value of the protected field 5) Run the import again and verify the the field that should have been protected has been overwritten 6) Apply the patch and repeat steps 4-5, verify that the field was protected and has not been overwritten -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 16:36:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 15:36:12 +0000 Subject: [Koha-bugs] [Bug 29250] "Show checkouts/fines to guarantor" cannot be set to yes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29250 Amanda Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acampbell at hmcpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 16:36:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 15:36:15 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127979|0 |1 is obsolete| | --- Comment #38 from David Gustafsson --- Created attachment 127981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127981&action=edit Bug 25539: Strip items when adding new biblio to preserve previous behaviour of the script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 17:05:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 16:05:50 +0000 Subject: [Koha-bugs] [Bug 28832] Batch modification always clears permanent_location if it is mapped in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 17:05:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 16:05:53 +0000 Subject: [Koha-bugs] [Bug 28832] Batch modification always clears permanent_location if it is mapped in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832 --- Comment #13 from Nick Clemens --- Created attachment 127982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127982&action=edit Bug 28832: (follow-up) Don't remove false values, only empty strings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 17:06:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 16:06:33 +0000 Subject: [Koha-bugs] [Bug 28832] Batch modification always clears permanent_location if it is mapped in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832 --- Comment #14 from Nick Clemens --- (In reply to Joonas Kylmälä from comment #10) > After applying the patches modifying the item fields to values that evaluate > in perl to false is impossible. The conditions in > > > unless( $values[$i] || $searches[$i] || grep { $subfields[$i] } @disabled ){ > > should be the same as just above it, i.e. if the value is empty string or > not. Updated > To reproduce: > 1) Try to change inventory field to 0 and notice it is not modified. I actually find this is true from the item editor as well - it is not caused by this patchset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 17:13:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 16:13:57 +0000 Subject: [Koha-bugs] [Bug 29571] New: Mainpage : "All librairies" pending suggestions are visible only if the current library has suggestions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Bug ID: 29571 Summary: Mainpage : "All librairies" pending suggestions are visible only if the current library has suggestions Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: christophe.torin at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org On the mainpage, the "Suggestions pending approval" block is shown only if there are suggestions for the user's current library, even if the other library have suggestions. Example with 3 libraries : , LIB_A (3 suggestions), LIB_B (1 sugg.), LIB_C (0 sugg.) LIB_A will show "Suggestions pending approval: LIB_A: 3 / All Libraries: 4" LIB_B will show "Suggestions pending approval: LIB_B: 1 / All Libraries: 4" LIB_C will show nothing. If this is to be fixed, it would be simple, in the template intranet-main.tt on line 178 : The condition on "pendingsuggestions" will return false if it's equal to 0, thus hiding the whole block, even if the field "all_pendingsuggestions" is set and above 0. This was seen on koha 20.11, but I checked and is still on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 17:29:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 16:29:53 +0000 Subject: [Koha-bugs] [Bug 29566] Convert bundle contents modal to a notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 --- Comment #1 from Martin Renvoize --- Created attachment 127983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127983&action=edit Bug 29566: Add API route for fetching item slip content This patch adds an API endpoint to allow the generation and fetching of an item print slip. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 17:29:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 16:29:56 +0000 Subject: [Koha-bugs] [Bug 29566] Convert bundle contents modal to a notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 --- Comment #2 from Martin Renvoize --- Created attachment 127984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127984&action=edit Bug 29566: Update modal to use slip api -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 17:30:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 16:30:00 +0000 Subject: [Koha-bugs] [Bug 29566] Convert bundle contents modal to a notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 --- Comment #3 from Martin Renvoize --- Created attachment 127985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127985&action=edit Bug 29566: Add sample notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 17:31:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 16:31:33 +0000 Subject: [Koha-bugs] [Bug 29566] Convert bundle contents modal to a notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 18:13:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 17:13:53 +0000 Subject: [Koha-bugs] [Bug 29572] New: Receipt of issue on expired subscription should follow serialsadditems value Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29572 Bug ID: 29572 Summary: Receipt of issue on expired subscription should follow serialsadditems value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Koha will allow receipt of an issue on an expired subscription. Bug 29188 already exists to suggest we should no longer allow that. I'd be fine with preventing receipt of issues on expired subscriptions entirely, but for the moment Koha allows it. In 20.05 and earlier, Koha would correctly follow the serialsadditems when receiving an issue on an expired subscription. In 21.05, Koha will not create an item when receiving an item on an expired subscription, even if serialsadditems=1. It allows the receipt, but does not present the Add Item form. If we're not preventing this receipt entirely, we should make it work entirely. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 18:14:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 17:14:10 +0000 Subject: [Koha-bugs] [Bug 29572] Receipt of issue on expired subscription should follow serialsadditems value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29572 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29188 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 18:14:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 17:14:10 +0000 Subject: [Koha-bugs] [Bug 29188] Expired serial subscriptions can still receive issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29188 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29572 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 18:34:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 17:34:44 +0000 Subject: [Koha-bugs] [Bug 29560] Add option to create MARC links when adding items to bundles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560 --- Comment #1 from Martin Renvoize --- What I'm thinking is adding a checkbox to the add to bundle modal that allows adding '773' links to the child as it's added to the bundle. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 18:35:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 17:35:12 +0000 Subject: [Koha-bugs] [Bug 29560] Add option to create MARC links when adding items to bundles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17775 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 18:35:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 17:35:12 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|Oldversions |--- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29560 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 18:35:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 17:35:38 +0000 Subject: [Koha-bugs] [Bug 29560] Add option to create MARC links when adding items to bundles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community |https://bugs.koha-community |.org/bugzilla3/show_bug.cgi |.org/bugzilla3/show_bug.cgi |?id=17775 |?id=27775 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 18:35:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 17:35:38 +0000 Subject: [Koha-bugs] [Bug 27775] Add hint about drag and drop feature on framework subfield edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27775 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29560 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 18:35:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 17:35:38 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29560 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 18:35:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 17:35:50 +0000 Subject: [Koha-bugs] [Bug 29560] Add option to create MARC links when adding items to bundles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27775 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 18:35:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 17:35:50 +0000 Subject: [Koha-bugs] [Bug 27775] Add hint about drag and drop feature on framework subfield edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27775 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29560 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 18:36:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 17:36:58 +0000 Subject: [Koha-bugs] [Bug 29560] Add option to create MARC links when adding items to bundles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11175 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 18:36:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 17:36:58 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29560 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 19:59:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 18:59:46 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 21:04:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 20:04:10 +0000 Subject: [Koha-bugs] [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 21:04:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 20:04:15 +0000 Subject: [Koha-bugs] [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127970|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 127986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127986&action=edit Bug 29564: Use List::MoreUtils so SIP U16/Xenial does not break - run prove t/00-load.t, see error - apply patch 00:07:08.189 koha_1 | # Failed test 'use C4::SIP::Sip::Configuration;' 00:07:08.189 koha_1 | # at t/00-load.t line 46. 00:07:08.189 koha_1 | # Tried to use 'C4::SIP::Sip::Configuration'. 00:07:08.189 koha_1 | # Error: "uniq" is not exported by the List::Util module - run prove t/00-load.t, see tests pass :0) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 21:10:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 20:10:10 +0000 Subject: [Koha-bugs] [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- Testing notes using koha-testing-docker (KTD): - To start KTD using U16/xenial change KOHA_IMAGE=master-xenial in your .env file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 21:11:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 20:11:00 +0000 Subject: [Koha-bugs] [Bug 29327] Add option to remove Non-Priority status from hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29327 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 21:33:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 20:33:19 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #58 from Victor Grousset/tuxayo --- I don't think there is a dependency from bug 28803 (and it's dep bug 28813) **for the bug occurrence**. 20.11.x should be affected since bug 22343 is there 28803 gets in the way to seamlessly backport the fix. To reword the results of my testing, here are the possibilities 1. backport this bug 29330 directly even if it conflicts due to the lack of 28803. It adds a catch without changing the code in the try and this patch (29330) adds code in the try. 2. try to backport 28803 without it's dependency 28813 (it might not be actually a dependency our case) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 21:44:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 20:44:33 +0000 Subject: [Koha-bugs] [Bug 29538] UNIMARC no longer available as marc flavour when installing in Italian In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29538 --- Comment #6 from John Fawcett --- Jonathan The workaround sounds useful and hopefully means that effort can more profitably directed to the target solution rather than reverting changes. I appreciate that there are other priorities and that it may be a big job. But just to understand what's needed: the en UNIMARC directories are still sql based, so looks like first step is to move to .yml configurations. Then I think the task is to create files like these: /usr/share/koha/misc/translator/po/en-GB-installer-UNIMARC.po /usr/share/koha/misc/translator/po/it-IT-installer-UNIMARC.po Is that correct or am I underestimating the impacts? Are any updates needed to core code. I was assuming no, since the Italian MARC21 is getting installed with the localization strings, which I assume are coming from the combination of yml and /usr/share/koha/misc/translator/po/it-IT-installer-MARC21.po, since there are no longer specific sql files for it-IT. I guess, given there is a working version of it-IT UNIMARC on previous versions, that some kind of scripting can be done to create the yml and master pot files and draft translated po files from existing data. Do you already have such tools that maybe have been used to create MARC21 localization or is it all hand written? Thanks John -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 22:45:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 21:45:36 +0000 Subject: [Koha-bugs] [Bug 24866] Display budget hierarchy in the budget dropdown menu used when placing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #18 from Fridolin Somers --- (In reply to Martin Renvoize from comment #17) > I'm wondering whether we should convert the select to a select2 input? Then > we can go back to using CSS ;) > > https://stackoverflow.com/questions/30820215/selectable-optgroups-in- > select2#30948247 We could. But dashes is better for accessibility right ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 22:46:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 21:46:53 +0000 Subject: [Koha-bugs] [Bug 24866] Display budget hierarchy in the budget dropdown menu used when placing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866 --- Comment #19 from Fridolin Somers --- Great job Florian :D I suggest you replace : [% level_indent | $raw %] with : [% level_indent | html %] Iven if dashed does not need it. It is more secure. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 22:59:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 21:59:19 +0000 Subject: [Koha-bugs] [Bug 28660] Self checkout is not automatically logging in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 23:32:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 22:32:56 +0000 Subject: [Koha-bugs] [Bug 29559] Update creates "unexpected type" entries for standard codes in debit and credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29559 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- I've noticed the same thing recently on a 18.05 to 21.05 upgrade. We don't have many libraries working with money, so I hadn't noticed it previously. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 23:42:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 22:42:24 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #59 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #50) > No actual dependency it seems. bug 28803 adds a catch and this patch adds > code in the try. So you're saying that the merge conflict is just due to the surrounding lines being different so it can't auto-merge without manual intervention? That's not so bad. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 23:44:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 22:44:11 +0000 Subject: [Koha-bugs] [Bug 29569] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29569 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED Summary|Want the cash.app/help |SPAM |number to check balance? | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 23:46:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 22:46:03 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Mainpage : "All librairies" |Mainpage : "All libraries" |pending suggestions are |pending suggestions are |visible only if the current |visible only if the current |library has suggestions |library has suggestions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 24 23:55:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 22:55:43 +0000 Subject: [Koha-bugs] [Bug 28380] Elasticsearch - Correct 024aa in mappings (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28380 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 00:00:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 23:00:18 +0000 Subject: [Koha-bugs] [Bug 27583] Clarify how cash management fits together In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27583 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff Client |Fines and fees -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 00:02:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 23:02:38 +0000 Subject: [Koha-bugs] [Bug 28563] Add AllowHoldItemTypeSelection to Hea In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28563 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add |Add |AllowHoldItemTypeSelection |AllowHoldItemTypeSelection |to HEA |to Hea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 00:06:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 23:06:25 +0000 Subject: [Koha-bugs] [Bug 27850] Search link for 260 a and c in MARC21 XSLT display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27850 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds |This enhancement adds release notes|search links to the MARC21 |search links to the MARC21 |XSLT display for 260$a and |XSLT display for 260$a and |$b fields for the OPAC and |$c fields for the OPAC and |staff interface. |staff interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 00:08:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 23:08:21 +0000 Subject: [Koha-bugs] [Bug 28450] Make Account summary print tables configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28450 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |Patrons CC| |gmcharlt at gmail.com, | |kyle.m.hall at gmail.com Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 00:09:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 23:09:38 +0000 Subject: [Koha-bugs] [Bug 28450] Make Account summary print tables configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28450 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds table release notes| |settings for the three | |tables (checkouts, fines | |and holds) which appear on | |the | |patron's "Print | |summary" view. This will | |allow the administrator to | |set a default configuration | |for columns on the print | |summary page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 00:10:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 23:10:26 +0000 Subject: [Koha-bugs] [Bug 28694] Check alert in cataloguing should be a static message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org CC| |m.de.rooy at rijksmuseum.nl Component|Templates |Cataloging -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 00:57:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 23:57:18 +0000 Subject: [Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #8 from David Nind --- With no patch applied and using the latest master, if only 500 is hidden using the NotesToHide system preference then it works as expected. As per comment #2, if I have two 5XX fields with data (say 500 and 504, but I tested and it can be any two fields) and hide all of them 500 still displays. >From what I can tell, if all the available 5XX fields are added to NotesToHide, then the first available field still displays. That is, it needs to display at least one field under the description tab in the OPAC and staff interface, and you can't hide them all. To replicate (using koha-testing-docker (KTD) and the default book framework): 1. Add data to each available field for a record (with KTD I used record 262 - Programming Perl). 2. Progressively hide each field until all the 5XX fields available are included in NotesToHide (500,504,505,520,521,522,526,538,541,546,583,586). 3. Up until 586 was added to NotesToHide, everything worked as expected. 4. However, once I added 586, 500 was no longer hidden (all the other fields remained hidden). 5. If I only have data in two fields, say 504 and 526, then 504 is still displayed. The patch no longer applies 8-(.. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17127: Remove notes from detail.tt to only use MARCNOTES Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 17127: Remove notes from detail.tt to only use MARCNOTES -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 00:59:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Nov 2021 23:59:53 +0000 Subject: [Koha-bugs] [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127986|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo --- Created attachment 127987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127987&action=edit Bug 29564: Use List::MoreUtils so SIP U16/Xenial does not break - run prove t/00-load.t, see error - apply patch 00:07:08.189 koha_1 | # Failed test 'use C4::SIP::Sip::Configuration;' 00:07:08.189 koha_1 | # at t/00-load.t line 46. 00:07:08.189 koha_1 | # Tried to use 'C4::SIP::Sip::Configuration'. 00:07:08.189 koha_1 | # Error: "uniq" is not exported by the List::Util module - run prove t/00-load.t, see tests pass :0) https://bugs.koha-community.org/show_bug.cgi?id=29478 https://bugs.koha-community.org/show_bug.cgi?id=29564 Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 01:51:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 00:51:08 +0000 Subject: [Koha-bugs] [Bug 29538] UNIMARC no longer available as marc flavour when installing in Italian In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29538 --- Comment #7 from John Fawcett --- Sorry I meant: to create UNIMARC localization -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 02:08:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 01:08:30 +0000 Subject: [Koha-bugs] [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Signed Off |Passed QA --- Comment #6 from Victor Grousset/tuxayo --- Our use case is simple so switching to List::MoreUtils:uniq shouldn't change the behavior. List::MoreUtils is already even in 19.11.x so it's not a new dep. Look good for QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 02:36:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 01:36:09 +0000 Subject: [Koha-bugs] [Bug 25126] MARC visibility settings not obeyed on cart normal and detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25126 Lye Jia Lun changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jialun at toa.edu.my --- Comment #2 from Lye Jia Lun --- We've recently upgrade to version 21.05.05.003 and encountered a similar issue. In the MARC Frameworks, the visibility setting for a subfield was unticked for OPAC but it still appeared inside OPAC. This worked perfectly in version 20.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 03:07:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 02:07:44 +0000 Subject: [Koha-bugs] [Bug 29573] New: MARC Framework Subfields Visibility Setting Not Obeyed for 5XX Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29573 Bug ID: 29573 Summary: MARC Framework Subfields Visibility Setting Not Obeyed for 5XX Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: jialun at toa.edu.my QA Contact: testopia at bugs.koha-community.org Created attachment 127988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127988&action=edit Tag 583 Subfield constraints I've recently upgraded to version 21.05.05.003 and encountered an issue with the when viewing an item inside the OPAC (opac-detail.pl) while using Normal view inside the Title notes. Our librarians have configured the one of the Subfields for MARC Framework 583 to be hidden in the OPAC but visible for Intranet and Editor. It was working fine in version 20.11 but once we upgraded to version 21.05 it appeared inside the OPAC despite the visibility setting. I've tested changing the Subfields Visibility setting by enabling either OPAC or Intranet only but there was not changes in the OPAC or Staff Client either. The Title Notes were still visible. Thank you in advance for your help! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 03:20:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 02:20:21 +0000 Subject: [Koha-bugs] [Bug 29300] Release team 22.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29300 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05,20.11.12, |21.11.00,21.05.05,20.11.12 released in|20.05.18 | --- Comment #19 from Victor Grousset/tuxayo --- Reverted from 20.05.x as it's end of line. See comment 13 and following -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 03:21:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 02:21:13 +0000 Subject: [Koha-bugs] [Bug 29300] Release team 22.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29300 --- Comment #20 from Victor Grousset/tuxayo --- (In reply to wainuiwitikapark from comment #17) > Could someone please help me with what I should do with this bug for 19.11.x? I think you should backport it. Like for 21.05 and 20.11, this bug is relevant for 19.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 06:49:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 05:49:19 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127856|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize --- Created attachment 127989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127989&action=edit Bug 29113: Hide code for additional contents and generate it additional_contents.code is used to group DB rows together. Each row represent one content in a given language, and the code is used to know they are translation of the lang='default' one. It's not really useful for the end user and we could hide it and generate it. Test plan: Create/Edit/Delete additional contents (news and HTML customizations) and confirm that they are correctly grouped together. You need several languages installed to test this patch correctly. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 06:49:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 05:49:23 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127857|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize --- Created attachment 127990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127990&action=edit Bug 29113: Fix random assignation Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 06:49:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 05:49:34 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 06:52:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 05:52:16 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 --- Comment #31 from Martin Renvoize --- It's bug 23051 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 07:16:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 06:16:32 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #56 from Fridolin Somers --- I've backported unit test to 20.11.x (just removed failure code part) : 2712dbeca6 Bug 28803: Add unit tests And since Bug 28813 is not in 20.11.x, I applied a simplified version based on Bug 28996 : c8a36a1b95 Bug 28803: (20.11.x) Add invalid email handling in _send_message_by_email -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 07:17:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 06:17:10 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 --- Comment #57 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 07:49:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 06:49:33 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 07:49:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 06:49:39 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127886|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 127991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127991&action=edit Bug 29523: Add Koha::Objects->search_limited stub method This method is just a passthru to the search method. It is defined here to avoid the need to check if each class implements it. Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 07:49:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 06:49:50 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127887|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 127992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127992&action=edit Bug 29523: Add Koha::Object->accessible This patch introduces a method for checking if an object can be retrieved by the current user. It depends on the plural class implementation of the ->search_limited method. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 07:50:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 06:50:09 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127888|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 127993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127993&action=edit Bug 29523: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 07:50:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 06:50:27 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127889|0 |1 is obsolete| | --- Comment #9 from David Nind --- Created attachment 127994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127994&action=edit Bug 29523: Make Koha::Object->to_api respect accessibility This patch makes the *to_api* method honour the accessibility check for the object. This is relevant in the context of embedding single objects. The Koha::Patron->to_api method is adjusted to reflect this behavior as well (it does some manipulation after the ->to_api call and we need to prevent it). To test: 1. Apply up to the regression tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => FAIL: A patron, that shouldn't be accessed, is returned by ->to_api 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 6. Pick Henry Acevedo from the sample data, assign him 'catalogue' permissions and a know user/password combination 7. Enable basic authentication 8. Point your favourite tool (Postman?) to GET http://kohadev-intra.myDNSname.org:8081/api/v1/biblio/245/checkouts Set the following header: x-koha-embed: patron Pick whatever biblio you want, actually. => SUCCESS: No checkouts 9. Perform a couple checkouts on the chosen biblio. Make sure one checkout is for a patron on the same library as Henry, and the other on a different one. 10. Repeat 8 => SUCCESS: You see two checkouts. One of them has an attribute 'patron' containing the patron from Henry's library. The other, has the attribute set to 'null'. 11. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 07:58:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 06:58:20 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #10 from David Nind --- Testing notes: 1. Step 6: had to give Henry circulate and catalogue permissions. 2. Step 8: URL should be ../vi/biblios/... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 08:31:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 07:31:31 +0000 Subject: [Koha-bugs] [Bug 29574] New: OPACShelfBrowser Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29574 Bug ID: 29574 Summary: OPACShelfBrowser Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: hagud at orex.es QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 08:34:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 07:34:38 +0000 Subject: [Koha-bugs] [Bug 29574] OPACShelfBrowser doesn't show any records in koha 21.05.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29574 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Version|unspecified |21.05 Summary|OPACShelfBrowser |OPACShelfBrowser doesn't | |show any records in koha | |21.05.x --- Comment #1 from Hugo Agud --- OPACShelfBrowser doesn't show any records, it is being able to launch, and close, but not content is not displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 09:26:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 08:26:10 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 09:26:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 08:26:15 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127637|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 127995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127995&action=edit Bug 29484: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 09:26:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 08:26:19 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127638|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 127996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127996&action=edit Bug 29484: Make ListSets return noSetHierarchy when no sets defined This simple patch makes our OAI-PMH server return the appropriate error code when no sets are defined. To test: 1. Apply the regression tests 2. Run: $ kshell k$ t/db_dependent/OAI/Server.t => FAIL: Tests fail. Boo! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! YAY! 5. Sign off :-D Bonus: you can check with the tool mentioned on the bug report, that the error is gone. No sets need to be defined. Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 09:48:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 08:48:01 +0000 Subject: [Koha-bugs] [Bug 29567] Cataloguing plugins are broken on the batch item mod tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Jonathan Druart --- Skipping QA, this needs to be pushed today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 10:04:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 09:04:03 +0000 Subject: [Koha-bugs] [Bug 24866] Display budget hierarchy in the budget dropdown menu used when placing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866 --- Comment #20 from Florian --- Created attachment 127997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127997&action=edit Bug_24866: Changed $raw for html for extra safety Same test plan as before -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 10:05:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 09:05:06 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 10:05:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 09:05:09 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #35 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 10:05:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 09:05:12 +0000 Subject: [Koha-bugs] [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 10:05:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 09:05:14 +0000 Subject: [Koha-bugs] [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 10:05:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 09:05:17 +0000 Subject: [Koha-bugs] [Bug 29567] Cataloguing plugins are broken on the batch item mod tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 10:05:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 09:05:19 +0000 Subject: [Koha-bugs] [Bug 29567] Cataloguing plugins are broken on the batch item mod tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 10:05:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 09:05:36 +0000 Subject: [Koha-bugs] [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 10:05:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 09:05:38 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 10:05:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 09:05:39 +0000 Subject: [Koha-bugs] [Bug 29567] Cataloguing plugins are broken on the batch item mod tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29567 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 10:05:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 09:05:58 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 10:06:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 09:06:02 +0000 Subject: [Koha-bugs] [Bug 22671] Built-in offline circulation applicationCache errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22671 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 10:15:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 09:15:43 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24603 CC| |jonathan.druart+koha at gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 [Bug 24603] Allow to cancel charges in patron accounting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 10:15:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 09:15:43 +0000 Subject: [Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29457 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 [Bug 29457] Fee Cancellation records the wrong manager_id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 10:42:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 09:42:01 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #11 from Jonathan Druart --- (In reply to Martin Renvoize from comment #2) > Without the above patch, cancelling a charge in the worst case can lead to a > database error regarding key constrain failures.. or if your userid's happen > to coincide with an existing borrowernumber it will record entirely the > wrong user as the staff member who actioned the cancellation. It actually won't lead every often to a DBI exception, I've tried to recreate with userid="koha"/borrowernumber=51, and I saw that "koha" was passed to ->store, but "NULL" was actually in DB. It's coming from Koha::Object->store: 134 if ( _numeric_column_type( $columns_info->{$col}->{data_type} ) 135 or _decimal_column_type( $columns_info->{$col}->{data_type} ) 136 ) { 137 # Has been passed but not a number, usually an empty string 138 my $value = $self->_result()->get_column($col); 139 if ( defined $value and not looks_like_number( $value ) ) { 140 if ( $columns_info->{$col}->{is_nullable} ) { 141 # If nullable, default to null 142 $self->_result()->set_column($col => undef); And that's certainly why we didn't catch that earlier. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 10:44:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 09:44:15 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #12 from Jonathan Druart --- What about a warn during the upgrade, for NULLs? Userid that was a valid borrowernumber will never be restored correctly, no idea what we can do with that. However the more the wait, the more we introduce bad data, we should fix ASAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 11:00:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 10:00:19 +0000 Subject: [Koha-bugs] [Bug 27880] Database migrations in separate files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27880 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- So.. bits of this ended up getting merged into bug 25078.. I'm not sure what's still to do.. I think the recording of which updates have run which this bug does is a good idea still.. allowing us to make update idempotent by checking for previous runs of the update rather than trying to be clever with that actual statements themselves. Thoughts Julian.. is this still something you're happy to pursue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 11:09:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 10:09:10 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 11:15:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 10:15:23 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29503 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 11:23:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 10:23:08 +0000 Subject: [Koha-bugs] [Bug 27880] Database migrations in separate files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27880 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #4 from Julian Maurice --- Yes, this is something I still want to work on. I'll try to rebase the patch soon so it can be tested -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 11:27:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 10:27:41 +0000 Subject: [Koha-bugs] [Bug 29559] Update creates "unexpected type" entries for standard codes in debit and credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29559 --- Comment #2 from Katrin Fischer --- Adding my findings here in hope that we can still improve the update scripts some: IDENTIFY PROBLEMS select code, description from account_debit_types where description LIKE "Unexpected%" union select code, description from account_credit_types where description LIKE "Unexpected%" * Some problems might be related to entries with amount/amountoutstanding 0. Most of those have status VOID. * Another issue seems to be with written off L (=LOST) fees. * And last, but not least: reversed fines. ------------------ GROUP 1: Pay, VOID, amount/amountoutstanding = 0 debit_type_code: Pay credit_type_code: NULL amount: 0 amount_outstanding: 0 status: VOID Some with entries in account_offsets Some with no entries in account_offsets Possible fix: UPDATE accountlines set credit_type_code = "PAYMENT", debit_type_code = NULL where debit_type_code = "PAY" and status ="VOID" and amount = 0 and amountoutstanding = 0; ------------------ GORUP 2: Pay NOT VOID, not reversed, amount/amountoutstanding = 0 debit_type_code: Pay credit_type_code: NULL amount: 0 amount_outstanding: 0 status: NULL select * from accountlines where (debit_type_code="Pay" or credit_type_code = "Pay") and amount = 0 and amountoutstanding = 0 and description not like "%Reversed%"; Possible fix: UPDATE accountlines set credit_type_code = "PAYMENT", debit_type_code = NULL where (debit_type_code ="Pay" or credit_type_code = "Pay") and amount = 0 and amountoutstanding = 0 and description not like "%Reversed%"; ------------------ GROUP 3: Pay NOT VOID not Reversed, amountoutstanding = 0, amount > 0 debit_type_code: Pay credit_type_code: NULL amount: > 0 amount_outstanding: 0 status: NULL select * from accountlines where (debit_type_code ="Pay" or credit_type_code = "Pay") and description not like "%Reversed%" and amountoutstanding = 0; I am not sure if they are linked to the reversed entries from Group 4, haven't been able to resolve those. ------------------ GROUP 4: Pay Reversed decription: like "%Reversed%" In part these entries have been reversed multiple times with mulitple "Reversed" in the description. I haven't been able to find a solution to those. select * from accountlines where (debit_type_code ="Pay" or credit_type_code = "Pay") and description like "%Reversed%" ------------------ GROUP 5: W, VOID, amount/amountoutstanding = 0 debit_type_code: W credit_type_code: NULL amount: 0 amount_outstanding: 0 status: VOID select * from accountlines WHERE amount = 0 and amountoutstanding = 0 and debit_type_code = "W" and status = "VOID"; Possible fix: UPDATE accountlines set credit_type_code = "WRITEOFF", debit_type_code = NULL WHERE amount = 0 and amountoutstanding = 0 and debit_type_code = "W" and status = "VOID"; ------------------ GROUP 6: W, NOT VOID, amountoutstanding IS NULL debit_type_code W credit_type_code NULL amount: positive value (should be negative) amount_outstanding: NULL status: NULL This has been a rather big group with about 400 entries out of 3200 total. select * from accountlines WHERE debit_type_code = "W" and status IS NULL and amountoutstanding IS NULL; Possible fix: UPDATE accountlines SET amount = amount*-1, credit_type_code = "WRITEOFF", debit_type_code = NULL, amountoutstanding = 0 WHERE debit_type_code = "W" and status IS NULL and amountoutstanding IS NULL; ------------------ GROUP 7: LOST debit_type_code NULL credit_type_code LOST amount: negative value amount_outstanding: NULL status: NULL interface: upgrade LOST exists as a debit type code, but has been added by the update as a credit type code. In account_offsets when looking for the accountlines_id in debit_id and credit_id, we find entries with the debit_id only. credit_id is always filled in, linked to a writeoff line. select * from accountlines WHERE credit_type_code = "LOST" and amount < 0 and amountoutstanding is NULL; Possible fix: UPDATE accountlines SET debit_type_code = "LOST", credit_type_code = NULL, amount = amount*-1, amountoutstanding = 0 WHERE credit_type_code = "LOST" and amount < 0 and amountoutstanding is NULL; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 11:41:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 10:41:39 +0000 Subject: [Koha-bugs] [Bug 27880] Database migrations in separate files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27880 --- Comment #5 from Julian Maurice --- Created attachment 127998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127998&action=edit Bug 27880: Store each database migrations state in database This patch is the continuation of bug 25078. It improves it by decorrelating database migrations from Koha version number, which allows to prevent that a database migration is executed twice, even if present in two different stable releases. Database migrations are regular Perl scripts that return migration metadata and code in a hashref. Their filename is meaningful. It should always start with a timestamp (in the form YYYYMMDDHHMMSS), which is used for executing migrations in the correct order. It should also contain a short description. Once a migration has been successfully executed, its name is stored into a new table `executed_migrations`. This is how we avoid executing a migration twice. With this new system, the 'Version' system preference becomes useless, as well as the 4th part of the Koha version. A good part of the patch is about adapting the code to these changes. Test plan: 1. Apply patch and restart starman 2. Go to the staff interface, you should be redirected to the installer 3. Enter your credentials, click on "Continue to the next step" until you arrive at the "Update database" step 4. You should now see the following message: Pending migrations: 20201002135449-create-executed-migrations-table.pl Click on "Update your database" 5. Now you should see Update report : Migration done: 20201002135449-create-executed-migrations-table.pl (Create table executed_migrations) Everything went okay. Update done. 6. Log into Koha 7. Verify that the About page shows the correct version 8. Verify that the 'Help' link in the top right corner redirects to the correct version of the manual 9. Now, do a fresh install and verify that the executed_migrations table exists and is not empty at the end of the install process -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 11:41:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 10:41:59 +0000 Subject: [Koha-bugs] [Bug 27880] Store each database migrations state in database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27880 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Database migrations in |Store each database |separate files |migrations state in | |database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 11:42:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 10:42:17 +0000 Subject: [Koha-bugs] [Bug 27880] Store each database migrations state in database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27880 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117835|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 11:42:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 10:42:27 +0000 Subject: [Koha-bugs] [Bug 27880] Store each database migrations state in database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27880 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 11:43:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 10:43:31 +0000 Subject: [Koha-bugs] [Bug 29538] UNIMARC no longer available as marc flavour when installing in Italian In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29538 --- Comment #8 from Jonathan Druart --- We need to create a UNIMARC framework that does not contain specificities, only things coming from the standard. Then yes, we need to build a yml file (Bernardo has scripts for that already I think). Once we have that (for biblios and authorities), we need to add them to installer/data/mysql/en/marcflavour/unimarc/ and it will then be available for the different languages. The translations will be then done on pootle, and it-IT-installer-UNIMARC.po will contain the strings when a new version is released. As I told you, Bernardo was working on it a couple of months ago, so some work have been done already. I am waiting for an answer from him to know what is still missing to provide a patch here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 11:44:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 10:44:50 +0000 Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background using Koha::BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344 --- Comment #22 from Jonathan Druart --- Do we still need this or we abandon? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 12:28:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 11:28:26 +0000 Subject: [Koha-bugs] [Bug 29575] New: Add a JS render function equivalent of the patron-title.inc TT include Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 Bug ID: 29575 Summary: Add a JS render function equivalent of the patron-title.inc TT include Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Blocks: 28854, 28874, 29275 We need a re-usable function that will use the json patron object as returned from the API and render an equivalent to the TT patron-title.inc output. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28874 [Bug 28874] We need javascript equivalents to many of our TT plugins https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 [Bug 29275] Use the API to render checkout history for a biblio -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 12:28:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 11:28:26 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29575 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 12:28:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 11:28:26 +0000 Subject: [Koha-bugs] [Bug 28874] We need javascript equivalents to many of our TT plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28874 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29575 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 12:28:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 11:28:26 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29575 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 12:28:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 11:28:44 +0000 Subject: [Koha-bugs] [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 12:29:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 11:29:23 +0000 Subject: [Koha-bugs] [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 --- Comment #1 from Martin Renvoize --- Grabbing the code from bug 29275 by Tomas and submitting it here so we can depend on it in other bugs without requiring the whole of 29275 for backports. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 12:43:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 11:43:09 +0000 Subject: [Koha-bugs] [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 --- Comment #2 from Martin Renvoize --- Created attachment 127999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127999&action=edit Bug 29575: Add $patron_to_html to render patron information in JS This patch adds a re-usable javascript render function that accepts a Koha REST api Patron object and outputs the HTML representation. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 12:43:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 11:43:13 +0000 Subject: [Koha-bugs] [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 --- Comment #3 from Martin Renvoize --- Created attachment 128000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128000&action=edit Bug 29575: Add JSDoc documentation This patch adds some basic documentation for the $patron_to_html function the patchset introduces. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 12:43:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 11:43:30 +0000 Subject: [Koha-bugs] [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 12:44:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 11:44:00 +0000 Subject: [Koha-bugs] [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize --- Grabbing SO from Victor on Bug 29275 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 12:49:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 11:49:55 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samu.heiskanen at hypernova.fi --- Comment #7 from Samu Heiskanen --- When you click "Delete record" it still asks: "Are you sure you want to delete this record?", though it won't really delete it even if you click ok. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 12:50:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 11:50:06 +0000 Subject: [Koha-bugs] [Bug 29573] MARC Framework Subfields Visibility Setting Not Obeyed for 5XX In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29573 --- Comment #1 from Katrin Fischer --- Hi, did it appear in the normal view or in the tab with the descriptions? If it's the latter, you can hide it there using the NotesToHide system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 12:50:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 11:50:11 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127895|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize --- Created attachment 128001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128001&action=edit Bug 29275: Use the API to fetch checkouts information This patch changes issuehistory.pl so it leverages on the API for fetching checkouts information in the template. Workflow changes: This development splits the 'current' checkouts and the 'past' checkouts in two different tables. Terminology could be revisited by native english speakers. To test: 1. Have records with and without current/past checkouts 2. Notice how the Checkouts history tab presents the information on each case. => SUGGESTION: Keep each of them open on separate tabs for comparing 3. Apply this patchset and its dependencies 4. Restart plack, run: $ koha-plack --restart kohadev 5. Follow the same steps you followed for those open tabs, in new ones => SUCCESS: What you see makes sense, information is displayed as it used to, with the different tables now. 6. Try searching on the datatables => SUCCESS: Search works correctly! 7. Revisit the new texts I added => SUGGESTION: If you have better wordings, submit a patch, or just comment on the bug so I do it inline. 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 12:50:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 11:50:15 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127896|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize --- Created attachment 128002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128002&action=edit Bug 29275: (follow-up) Remove use of CountSubscriptionFromBiblionumber Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 12:50:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 11:50:18 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127897|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize --- Created attachment 128003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128003&action=edit Bug 29275: (follow-up) Split columns settings and handle upgrade This patch splits the table settings as we now have two tables. The atomic update takes care of setting the right values (if present) on the new tables entries. To test: 1. Do not apply this patch 2. Set some values you will remember for the checkoutshistory-table table 3. Run: $ koha-mysql kohadev > SELECT * FROM columns_settings WHERE tablename='checkoutshistory-table'; => SUCCESS: Koha currently works :-D 4. Apply this patch 5. Run: $ updatedatabase 6. Repeat 3 => SUCCESS: Things have been deleted 7. Run: $ koha-mysql kohadev > SELECT * FROM columns_settings WHERE tablename LIKE '%_checkouts-table'; => SUCCESS: old_checkouts-table and current_checkouts-table have the right setting 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 12:50:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 11:50:46 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127894|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 12:51:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 11:51:07 +0000 Subject: [Koha-bugs] [Bug 29574] OPACShelfBrowser doesn't show any records in koha 21.05.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29574 --- Comment #2 from Katrin Fischer --- Hi Hugo, did it work before and do your items have callnumbers? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 12:53:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 11:53:23 +0000 Subject: [Koha-bugs] [Bug 27880] Store each database migrations state in database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27880 --- Comment #6 from Julian Maurice --- The patch is rebased and works, but there is still some work to do: - figure what to do with the already existing db_revs/.pl (I believe we can leave it like that, but maybe there's another, cleaner solution) - pass the same parameters to the 'up' subroutine as with the db_revs system (for now only $dbh is passed, not the $out parameter) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 12:54:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 11:54:05 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #28 from Martin Renvoize --- OK, I split out the first patch and moved it to bug 29575 and set it as a dependency. This allows other bugs to utilise this great new function ;) I've added my SO to the patches here and am just finishing up QAing the embed dependency.. will switch to PQA along with that one once I'm done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 13:12:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 12:12:22 +0000 Subject: [Koha-bugs] [Bug 29574] OPACShelfBrowser doesn't show any records in koha 21.05.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29574 --- Comment #3 from Hugo Agud --- I have been working on it... and this is it happening because cn_sort is not filled, I have been able to trace how the items has been created.. and has been created via mysql.. then cn sort is empty and koha has a null value at mysql and it is not able to create it. It is not really a bug.. it is because items has been created directly from mysql sorry for misunderstanding -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 13:34:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 12:34:37 +0000 Subject: [Koha-bugs] [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 --- Comment #5 from Martin Renvoize --- Created attachment 128004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128004&action=edit Bug 27975: (follow-up) Patron fields can be empty strings We need to account for empty strings as well as 'null' values in the patron data structure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 13:36:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 12:36:11 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 --- Comment #32 from Emmi Takkinen --- Created attachment 128005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128005&action=edit Bug 16223: Call DelDebarmentsAfterPayment from Koha::Account::Line::apply Calling function from Koha::Account::pay missed several payment cases. Moving it to Koha::Account::Line::apply should cover all payments. Also reworked tests no just to test DelDebarmentsAfterPayment but to test if debartments are lifted after pay. To test repeat test plan from previous patches. Also prove t/db_dependent/Patron/Borrower_Debartments.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 13:36:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 12:36:22 +0000 Subject: [Koha-bugs] [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 --- Comment #6 from Martin Renvoize --- Created attachment 128006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128006&action=edit Bug 29575: (follow-up) Patron fields can be empty strings We need to account for empty strings as well as 'null' values in the patron data structure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 13:36:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 12:36:41 +0000 Subject: [Koha-bugs] [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128004|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 13:55:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 12:55:20 +0000 Subject: [Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 --- Comment #106 from Jonathan Druart --- Created attachment 128007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128007&action=edit Bug 28445: Add diag for failing test Temporary patch to help trying to fix the following random error: # Failed test 'Item types should be sorted by description and an empty entries should be shown' # at t/db_dependent/Koha/UI/Form/Builder/Item.t line 121. # Structures begin differing at: # $got->[12] = 'Be9T9FH5aO' # $expected->[12] = 'REF' # Looks like you failed 1 test of 2. # Failed test 'itemtypes' # at t/db_dependent/Koha/UI/Form/Builder/Item.t line 130. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 13:55:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 12:55:39 +0000 Subject: [Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 --- Comment #107 from Jonathan Druart --- Created attachment 128008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128008&action=edit Bug 28445: (follow-up) Add diag for failing test Last diag was not enough (Koha_Master_D11/457) # Failed test 'Item types should be sorted by description and an empty entries should be shown' # at t/db_dependent/Koha/UI/Form/Builder/Item.t line 127. # Structures begin differing at: # $got->[11] = 'X_vvQE5' # $expected->[11] = 'knHm32' # Itemtypes details: $VAR1 = [ # '', # 'EMVzKcGR', # 'x4S8_BaFCp', # 'Cp2BGkY', # 'BK', # 'CF', # 'CR', # 'bBvgmVAIzD', # 'WKyaQ_l', # 'Cjc0SKQz', # 'liic63', # 'X_vvQE5', # 'knHm32', # 'MP', # 'MX', # 'MU', # 'g_F5eNqA', # 'REF', # 'pkxaMSv', # 'VM' # ]; # $VAR2 = [ # 'bBvgmVAIzD', # 'BK', # 'CF', # 'Cjc0SKQz', # 'Cp2BGkY', # 'CR', # 'EMVzKcGR', # 'g_F5eNqA', # 'knHm32', # 'liic63', # 'MP', # 'MU', # 'MX', # 'pkxaMSv', # 'REF', # 'VM', # 'WKyaQ_l', # 'X_vvQE5', # 'x4S8_BaFCp' # ]; We needed the translated_description. It should be the same actually, but maybe something weird is happening. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 13:56:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 12:56:13 +0000 Subject: [Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 --- Comment #108 from Jonathan Druart --- Created attachment 128009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128009&action=edit Bug 28445: Prevent UI/Form/Builder/Item.t to fail randomly MySQL and Perl don't order strings with _ identically which cause a mismatch when comparing the itemtypes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 14:07:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 13:07:43 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 14:07:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 13:07:46 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 --- Comment #1 from Jonathan Druart --- Created attachment 128010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128010&action=edit Bug 29571: Display all pending suggestions even if none from logged in library The number of pending suggestions was only displayed if there are pending suggestions at the logged in library. Test plan: Login at CPL Create a suggestion (ASKED) for another library => Without this patch there is nothing on the mainpage => With this patch applied you will see info about pending suggestions: "Suggestions pending approval: Centerville: 0 / All libraries: 1" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 14:08:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 13:08:22 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart+koha at gmail. | |com CC| |jonathan.druart+koha at gmail. | |com Version|20.11 |unspecified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 14:10:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 13:10:12 +0000 Subject: [Koha-bugs] [Bug 29570] unable to sort pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Depends on| |20212 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 [Bug 20212] Improve performance of acquisitions receive page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 14:10:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 13:10:12 +0000 Subject: [Koha-bugs] [Bug 20212] Improve performance of acquisitions receive page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29570 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 [Bug 29570] unable to sort pending_orders table on parcel.pl by summary column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 14:11:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 13:11:00 +0000 Subject: [Koha-bugs] [Bug 29570] unable to sort pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 29464 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 14:11:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 13:11:00 +0000 Subject: [Koha-bugs] [Bug 29464] Sorting broken for receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #2 from Jonathan Druart --- *** Bug 29570 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 14:41:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 13:41:33 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28803 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 14:41:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 13:41:33 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29330 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 14:43:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 13:43:44 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #60 from Victor Grousset/tuxayo --- Yes, that's how it looks :) And bug 28803 made it to oldstable anyway. Possibility 2 of comment 58 happened ^^ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 14:48:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 13:48:50 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 --- Comment #8 from marion.durand at biblibre.com --- (In reply to Samu Heiskanen from comment #7) > When you click "Delete record" it still asks: "Are you sure you want to > delete this record?", though it won't really delete it even if you click ok. Thank for testing the patch. I think you need to empty your browser cash for the second patch to take into effect. I don't have this problem on my first setup but on my second I have seen it and emptying the cash of my browser (or restarting koha) solved the problem. Have you tried that ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 14:58:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 13:58:05 +0000 Subject: [Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 --- Comment #109 from Jonathan Druart --- Last 3 patches pushed to master (the first one has been pushed earlier actually). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 15:16:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 14:16:59 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Samu Heiskanen --- I tried and now it works fine. Thanks for your advice. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 15:30:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 14:30:25 +0000 Subject: [Koha-bugs] [Bug 29576] New: Add streetype to fields which can be copied from guarantor to guarantee Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29576 Bug ID: 29576 Summary: Add streetype to fields which can be copied from guarantor to guarantee Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: didier.gautheron at biblibre.com Reporter: didier.gautheron at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 22534 Since #22534 you can prefill addresses but streettype and B_streettype aren't in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref list. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 [Bug 22534] Add ability to choose which fields are copied from guarantor to guarantee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 15:30:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 14:30:25 +0000 Subject: [Koha-bugs] [Bug 22534] Add ability to choose which fields are copied from guarantor to guarantee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Didier Gautheron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29576 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29576 [Bug 29576] Add streetype to fields which can be copied from guarantor to guarantee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 15:44:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 14:44:02 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127665|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 15:44:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 14:44:12 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127829|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 15:44:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 14:44:23 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127830|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 15:44:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 14:44:35 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127831|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 15:44:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 14:44:45 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127832|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 15:44:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 14:44:54 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127833|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 15:45:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 14:45:06 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127834|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 15:45:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 14:45:15 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127835|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 15:45:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 14:45:28 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127836|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 15:45:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 14:45:42 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127838|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 15:45:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 14:45:52 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127837|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 15:46:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 14:46:51 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://gitlab.com/mrenvoiz |https://gitlab.com/mrenvoiz |e/Koha/-/commits/bug_28854 |e/Koha/-/merge_requests/6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 15:49:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 14:49:03 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #66 from Martin Renvoize --- Please see the linked branch/merge request on gitlab for the patchset.. uploading rebases here was getting a bit obscene. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 16:55:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 15:55:41 +0000 Subject: [Koha-bugs] [Bug 21982] Circulation statistics wizard does not count deleted items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 --- Comment #3 from Jérémy Breuillard --- Created attachment 128011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128011&action=edit MT 34887: Statistic assistant - Circulation By default statistic assistant filter is set on the existing items and doesn't mind about deleted items. The patch corrects this. Items belong to the same library. Test plan: 1)Make sure to have at least 1 or more item(s) in deleteditems database table 2)Home > Reports > Circulation statistics 3)Fill up 'Issuing library', 'Home library' and 'Holding library' 4)Submit 5)Notice that only statistics for active items are shown 6)Apply patch and repeat from 2) to 5) 7)Now active items and deleted items are shown -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 17:02:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 16:02:52 +0000 Subject: [Koha-bugs] [Bug 21982] Circulation statistics wizard does not count deleted items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jeremy.breuillard at biblibre. | |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 17:04:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 16:04:41 +0000 Subject: [Koha-bugs] [Bug 21982] Circulation statistics wizard does not count deleted items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128011|MT 34887: Statistic |Bug 34887: Statistic description|assistant - Circulation |assistant - Circulation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 17:08:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 16:08:53 +0000 Subject: [Koha-bugs] [Bug 29464] Sorting broken for receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 17:09:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 16:09:00 +0000 Subject: [Koha-bugs] [Bug 21982] Circulation statistics wizard does not count deleted items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128011|Bug 34887: Statistic |Bug 21982: Statistic description|assistant - Circulation |assistant - Circulation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 17:17:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 16:17:54 +0000 Subject: [Koha-bugs] [Bug 21982] Circulation statistics wizard does not count deleted items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 --- Comment #4 from Jérémy Breuillard --- Created attachment 128012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128012&action=edit BZ 34887: Statistic assistant - Circulation By default statistic assistant filter is set on the existing items and doesn't mind about deleted items. The patch corrects this. Items belong to the same library. Test plan: 1)Make sure to have at least 1 or more item(s) in deleteditems database table 2)Home > Reports > Circulation statistics 3)Fill up 'Issuing library', 'Home library' and 'Holding library' 4)Submit 5)Notice that only statistics for active items are shown 6)Apply patch and repeat from 2) to 5) 7)Now active items and deleted items are shown -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 17:21:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 16:21:33 +0000 Subject: [Koha-bugs] [Bug 29524] Cannot set a new value for privacy_guarantor_checkouts in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_candidate CC| |victor at tuxayo.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 17:24:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 16:24:36 +0000 Subject: [Koha-bugs] [Bug 21982] Circulation statistics wizard does not count deleted items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128012|0 |1 is obsolete| | --- Comment #5 from Jérémy Breuillard --- Created attachment 128013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128013&action=edit BZ 34887: Statistic assistant - Circulation By default statistic assistant filter is set on the existing items and doesn't mind about deleted items. The patch corrects this. Items belong to the same library. Test plan: 1)Make sure to have at least 1 or more item(s) in deleteditems database table 2)Home > Reports > Circulation statistics 3)Fill up 'Issuing library', 'Home library' and 'Holding library' 4)Submit 5)Notice that only statistics for active items are shown 6)Apply patch and repeat from 2) to 5) 7)Now active items and deleted items are shown -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 17:25:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 16:25:41 +0000 Subject: [Koha-bugs] [Bug 21982] Circulation statistics wizard does not count deleted items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128011|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 17:40:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 16:40:06 +0000 Subject: [Koha-bugs] [Bug 29533] add more fields to items sql table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29533 --- Comment #6 from mathieu saby --- (In reply to Katrin Fischer from comment #4) > I'd be interested in what your problem with more_subfields_xml is? We have > quite a bit of data there and no issues. A collegue from an other library told me it was "clumsy". I cannot say something more precisely because we are only planning to migrate to Koha and I am doing some tests. Generally speaking I confess I am not fond of Koha's logic for managing items (some other ILS I know, and our current one, store item data in SQL and only map them in MARC for display or export...), but we will adapt. What I fear mainly with more_subfield_xml is performance problems, if we need to use ExtractValue() for extracting information from this field in a report. Maybe am I worrying about nothing, but I have bad memories of ExtractValue() applied to MARCXML data. Less important, it will also be more complicated if we want to develop plugins or patches for customizing or making more parametrable the display of items (add a new column in OPAC for a information stored in more_subfield_xml ) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 18:00:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 17:00:06 +0000 Subject: [Koha-bugs] [Bug 29577] New: Link bibs to authorities fails if relator terms are in records to be linked Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29577 Bug ID: 29577 Summary: Link bibs to authorities fails if relator terms are in records to be linked Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: bernard.scaife at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org If you use a relator ($e) in the authority and biblio records and run link_bibs_to_authorities.pl, it does not link the records although they are a match Observed at 20.11.09 Workflow: 1. Add PERSONAL authority record with 100a Berridge, Elizabeth and 100e actor 2. Add new biblio record with 700a Berridge, Elizabeth and 700e actor NB/ 700 Field should not be under authority control whilst this data is entered to simulate data that is not linked. Temporarily amend this in cataloguing template for 700 field 3. Run link biblio script on the new test bib's biblionumber: sudo koha-shell -c "/usr/share/koha/bin/link_bibs_to_authorities.pl --bib-limit='biblionumber=' --verbose" 4. Observe log which will say Number of bibs checked: 1 Number of headings linked: 0 Number of headings unlinked: 1 5. Remove 100e actor (from authority) and 700e actor (from biblio) and save 6. Rerun linker script (step 3) Number of bibs checked: 1 Number of headings linked: 1 Number of headings unlinked: 0 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 19:57:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 18:57:42 +0000 Subject: [Koha-bugs] [Bug 29556] MARC21slim2MODS.xsl broken by duplicate template name "part" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 19:57:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 18:57:46 +0000 Subject: [Koha-bugs] [Bug 29556] MARC21slim2MODS.xsl broken by duplicate template name "part" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127933|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 128014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128014&action=edit Bug 29556: MARC21slim2MODS.xsl broken by duplicate template name "part" This patch removes a redundant section from MARC21slim2MODS.xsl which was breaking the option to use unAPI in the OPAC using MODS format. To test, apply the patch and view a record in the OPAC using unAPI, e.g.: /cgi-bin/koha/unapi?id=koha:biblionumber:1&format=MODS You should see an XML file where previously there would have been an error. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 20:05:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 19:05:43 +0000 Subject: [Koha-bugs] [Bug 29556] MARC21slim2MODS.xsl broken by duplicate template name "part" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This fixes an error when release notes| |making an unAPI request in | |the OPAC using the MODS | |format. A 500 page error | |was displayed instead of an | |XML file. Example URL: | |http://your-library-opac-do | |main/cgi-bin/koha/unapi?id= | |koha:biblionumber:1&format= | |MODS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 20:23:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 19:23:00 +0000 Subject: [Koha-bugs] [Bug 29529] Fix \n in hint on Koha to MARC mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29529 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 20:23:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 19:23:05 +0000 Subject: [Koha-bugs] [Bug 29529] Fix \n in hint on Koha to MARC mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29529 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127876|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 128015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128015&action=edit Bug 29529: Fix \n in hint on Koha to MARC mappings This patch breaks up a translatable string so that "\n" is excluded from what is translated. Unrelated: Capitalization is corrected on an instance of the phrase "Koha to MARC Mappings." To test, apply the patch and go to Administration -> Koha to MARC mapping. - The breadcrumb for the current page should have correct capitalization ("mapping" instead of "Mapping"). - Click the "Add" button for any Koha field. The dialog should display correctly: Adding a mapping for: biblio.abstract. Please enter field tag and subfield code, separated by a comma. (For control fields: add '@' as subfield code.) The change will be applied immediately. Test the way the po file is updated: > cd misc/translator > perl translate update en-GB (for example) - Open the updated po file, en-GB-staff-prog.po - You should find these lines: SCRIPT koha-tmpl/intranet-tmpl/prog/en/modules/admin/koha2marclinks.tt:86 msgid "The change will be applied immediately." msgstr "" Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 20:35:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 19:35:44 +0000 Subject: [Koha-bugs] [Bug 29529] Fix \n in hint on Koha to MARC mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29529 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This fixes: release notes| |- a string in | |Koha to MARC mappings | |(koha2marclinks.tt:86) so | |that it can be correctly | |translated (excludes "\n" | |from what is translated), | |and | |- Capitalization for | |the breadcrumb link: | |Administration > Koha to | |MARC mappings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 20:46:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 19:46:07 +0000 Subject: [Koha-bugs] [Bug 29530] When NumSavedReports is set, show value in pull down of entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 20:46:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 19:46:11 +0000 Subject: [Koha-bugs] [Bug 29530] When NumSavedReports is set, show value in pull down of entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127965|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 128016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128016&action=edit Bug 29530: Fix handling of NumSavedReports preference in reports table This patch updates the way the NumSavedReports preference value is used on the saved reports page so that the setting is correctly incorporated into the DataTable. The patch also expands the description of the NumSavedReports preference in order to clarify the expected behavior when no value is saved. To test, apply the patch and go to Administration -> System preferences and note the value of NumSavedReports. - Go to Reports -> Use saved. - Confirm that the first page of saved reports shows the number specified in NumSavedReports. - In the "Show" dropdown menu, confirm that the number from NumSavedReports is preselected by default. - Expand the dropdown menu to confirm that the NumSavedReports number is positioned sequentially with the default values. For example, if NumSavedReports = "78," the menu options should be "10, 20, 50, 78, 100, All". - Test with various values of NumSavedReports. A blank value should result in the "All" option being selected. A non-numeric or non-positive value should result in the default set of options being used ("10, 20, 50, 100, All"). Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 21:09:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 20:09:42 +0000 Subject: [Koha-bugs] [Bug 29530] When NumSavedReports is set, show value in pull down of entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This updates the way the release notes| |NumSavedReports preference | |value is used on the saved | |reports page. For the | |"Show" dropwdown list: | |- it | |now displays the number set | |in NumSavedReports | |(previously it showed 20) | |- | |when expanded it now shows | |the number set in | |NumSavedReports | |sequentially (for example, | |if NumSavedReports is 78, | |the menu options should be | |"10, 20, 50, 78, 100, | |All"), and | |- it now | |displays 'All' if | |NumSavedReports is blank. | | | |It also updates the | |description for the | |NumSavedReports preference | |to clarify that all reports | |are shown when no value is | |entered. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 21:41:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 20:41:33 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127560|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 21:41:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 20:41:45 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127559|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 21:41:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 20:41:57 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127558|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 21:42:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 20:42:08 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127557|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 21:42:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 20:42:18 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127556|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 21:42:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 20:42:28 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122535|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 21:45:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 20:45:00 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #96 from Alex Buckley --- Created attachment 128017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128017&action=edit Bug 26346: Database changes - Adds allow_change_from_staff to virtualshelves table Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 21:46:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 20:46:42 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #97 from Alex Buckley --- Created attachment 128018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128018&action=edit Bug 26346: Updated schema file Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 21:47:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 20:47:18 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #98 from Alex Buckley --- Created attachment 128019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128019&action=edit Bug 26346: Add option to make public lists editable by all staff If a staff member has access to the staff client (either because 'catalogue' permission is enabled or they're a superlibrarian then that user can add items (from OPAC or staff client) to a list marked 'Staff only' Test plan: 1. In the staff client go to: Lists > 'New list'. Notice under 'Allow changes to contents from' there are three options: Nobody, Owner only, Anyone seeing this list 2. Apply first 3 patches and run updatedatabase.pl cd installer/data/mysql sudo koha-shell ./updatedatabase.pl 3. Restart memcached and plack 4. Create a public list and select the new 'Staff only' option under 'Allow changes to contents from' 5. Log out of the staff client and log back in as a different user with the 'Staff access, allows viewing of catalogue in staff interface (catalogue)' permission enabled. 6. Navigate to the Lists module, and click on the name of the list you created in #5 7. Select 'Add items' and enter an item barcode and submit 8. Notice the item has been added to the list 9. Search the catalogue in the staff client. Confirm you can add to the list you created in #5 from both the search result page and biblio record detail page 10. Confirm you can remove items from the list in the OPAC and staff client 11. Login to the OPAC as the same user as #5 12. Perform an OPAC search, Select 'Save to lists' under a biblio record, choose the list from #4 in 'Select a list' and save 13. Confirm in the staff client that the record from #11 has been added to the list 14. Logout of OPAC and login again as a user which does not have 'Staff access, allows viewing of catalogue in staff interface (catalogue)' or superlibrarian enabled 15. Do a OPAC search, hit 'Save to lists' and notice you cannot add the record to the list from #4 16. Run Patron.t and Virtualshelves.t unit tests: sudo koha-shell prove t/db_dependent/Koha/Patron.t prove t/db_dependent/Virtualshelves.t 17. Login to the staff client as the same user as #5 18. Create a new list in the staff client, select 'Category'='Private', 'Allow changes to contents from'='Staff only' 19. Notice 'The Staff only permission has no actual effect while this list is strictly private' message hint is displayed 20. Change 'Category'='Public' and notice the hint is removed 21. Switch back to 'Category'='Private' and 'Allow changes to contents from'='Anyone' 22. Notice the 'The Anyone permission has no actual effect while this list is strictly private.' is displayed 23. Repeat steps 18-22 in the OPAC 24. Create a 'staff only' list in the OPAC and then login as a different user with 'Staff access, allows viewing of catalogue in staff interface (catalogue)' permission enabled. Confirm you are able to add items to this new 'staff only' list. 25. Confirm that the 'Staff only' option is not available to patrons with no special permissions when creating lists in the OPAC Sponsored-by: Horowhenua District Council, New Zealand Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 21:52:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 20:52:05 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #99 from Alex Buckley --- Created attachment 128020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128020&action=edit Bug 26346: Add edit_public_lists sub-permission enabling patrons to switch 'owner only' public lists (which they're not the owners of) to 'staff only' lists The first patch on bug 26346 only allowed owners of existing 'owner only' public lists switch those lists to be 'Staff only'. This patch will allow other patrons with the 'edit_public_lists' sub-permission to also make this change. Test plan: 1. Apply the first 26346 patch and follow it's test plan 2. Apply this patch 3. Apply database changes: cd installer/data/mysql sudo koha-shell ./updatedatabase.pl 4. Restart memcached and plack 5. Login to the staff client. Create an 'owner only' public list 6. Create another patron record. Tick the following two permissions: * "Staff access, allows viewing of catalogue in staff interface (catalogue) Required for staff login." permission * Lists > "Edit public lists (edit_public_lists)" sub-permission 7. Logout of the staff client, and login as the user from step #6 8. Navigate to the Lists module, click 'Edit' on the 'owner only' list 9. Confirm you can change the 'Allow changes to contents from:' option to 'Staff only' 10. Confirm you can now add items to this 'staff only' list 11. Login to the OPAC as the patron from step #5 12. Create a 'owner only' public list 13. Logout of OPAC, and login as the patron from step #6 14. Navigate to public lists in the OPAC and edit the OPAC created 'owner only' public list from step # 15. Confirm you can change the 'Allow changes to contents from:" option to 'Staff only' 16. Confirm you can now add items to this 'staff only' list 17. Run Virtualshelves.t unit test: sudo koha-shell prove t/db_dependent/Virtualshelves.t Sponsored-by: Catalyst IT Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 21:52:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 20:52:31 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #100 from Alex Buckley --- Created attachment 128021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128021&action=edit Bug 26364: (QA follow-up) Do not crash on anonymous OPAC user Seriously! Can't call method "userid" on an undefined value at /usr/share/koha/Koha/Virtualshelf.pm line 253 Trivial fix. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 21:52:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 20:52:56 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #101 from Alex Buckley --- Created attachment 128022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128022&action=edit Bug 26346: (follow-up) Fixes in response to QA Fixes for the following comments on bug report 26346: 1. Comment #31 2. Comment #32 3. Comment #35 4. Comment #36 5. Comment #37 6. Comment #38 7. Comment #49 8. Comment #59 9. Comment #61 Test plan for comment #49 fix: 1. Log into the staff client as User A. Create one of each of the following types of public lists: - 'Owner only' - 'staff only' - 'Anyone seeing this list' 2. Visit the OPAC. Do not login. Confirm you are able to see all three public lists under the 'Lists' dropdown in the OPAC header 3. Perform a search. Select a search result checkbox and view the dropdown options in the 'Select titles to:' dropdown 4. Confirm only the 'Anyone seeing this list' is displayed as an option 5. Log into the OPAC as a user B (a user with no permissions). Confirm you can see all three public lists under the header 'Lists' dropdown 6. Repeat steps 3, and 4 as User B with the same results as un-authenticated user 6. Log into the OPAC as user C (a user with access to the staff client). Confirm you can see all three public lists under the header 'Lists' dropdown 7. Repeat steps 3, and 4 but this time you should see the 'staff only' and 'Anyone seeing this list' public lists in the dropdown 8. Log into the OPAC as user A. Confirm you can see all three poublic lists under the header 'Lists' dropdown 9. Repeat steps 3, and 4 but this time you should see the 'owner only', 'staff only' and 'Anyone seeing this list' public lists in the dropdown Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 21:59:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 20:59:02 +0000 Subject: [Koha-bugs] [Bug 29524] Cannot set a new value for privacy_guarantor_checkouts in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | --- Comment #7 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 22:01:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 21:01:33 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128022|0 |1 is obsolete| | --- Comment #102 from Alex Buckley --- Created attachment 128023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128023&action=edit Bug 26346: (follow-up) Fixes in response to QA Fixes for the following comments on bug report 26346: 1. Comment #31 2. Comment #32 3. Comment #35 4. Comment #36 5. Comment #37 6. Comment #38 7. Comment #49 8. Comment #59 9. Comment #61 Test plan for comment #49 fix: 1. Log into the staff client as User A. Create one of each of the following types of public lists: - 'Owner only' - 'staff only' - 'Anyone seeing this list' 2. Visit the OPAC. Do not login. Confirm you are able to see all three public lists under the 'Lists' dropdown in the OPAC header 3. Perform a search. Select a search result checkbox and view the dropdown options in the 'Select titles to:' dropdown 4. Confirm only the 'Anyone seeing this list' is displayed as an option 5. Log into the OPAC as a user B (a user with no permissions). Confirm you can see all three public lists under the header 'Lists' dropdown 6. Repeat steps 3, and 4 as User B with the same results as un-authenticated user 6. Log into the OPAC as user C (a user with access to the staff client). Confirm you can see all three public lists under the header 'Lists' dropdown 7. Repeat steps 3, and 4 but this time you should see the 'staff only' and 'Anyone seeing this list' public lists in the dropdown 8. Log into the OPAC as user A. Confirm you can see all three poublic lists under the header 'Lists' dropdown 9. Repeat steps 3, and 4 but this time you should see the 'owner only', 'staff only' and 'Anyone seeing this list' public lists in the dropdown Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 22:04:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 21:04:41 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #61 from Fridolin Somers --- Ich not easy. I prefer not risking breaking all email feature just before 20.11.12 release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 22:10:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 21:10:32 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #103 from Alex Buckley --- I've uploaded a fixed second patch on this bug report which was causing the t/db_dependent/Virtualshelves.t unit test to fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 23:38:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 22:38:29 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #104 from Alex Buckley --- (In reply to Alex Buckley from comment #95) > Hi Caroline, > > I've rebased this patchset against master. Would you mind testing this > patchset in a sandbox (https://wiki.koha-community.org/wiki/Sandboxes) to > see if you still encounter the problems in comment #86? > > --- > > (In reply to Blou from comment #89) > > This patch would be very helpful to some of our customers. But what would > > it take to extend the concept to private lists to be viewable by staff ? > > > > There's Bug 19501 opened for that, but it seems to me this patch here is > > almost there already. > > Hi Blou, > > Apologies for my slow response! My team has been flat out with client work > recently. > > I'll have a think about this and try to get back to you as soon as possible. > > Thanks, > Alex Hi Blou, Yes, extending this patchset to implement functionality requested in Bug 19501 would be straightforward except for the fact that the virtualshelves.category has been changed to a boolean virtualshelves.public field in bug 28959. Meaning adding a third option of 'Restricted', or 'Staff client only' in that field, would be regressing 28959. However, the way I would approach the functionality you're after is: * Change virtualshelves.public back to virtualshelves.category * Add a new option to virtualshelves.category of 3 (Staff client only) * Add two new patron lists sub-permissions: - 'Delete staff client lists (delete_staff_client_lists)' - 'Edit staff client lists (edit_staff_client_lists)' When a 'staff client only' list is created it would be viewable by all logged-in users on the staff client. It would not be visible to anyone in the OPAC. Only users with the 'edit_staff_client_lists' sub-permission would be able to edit it. Similarly, it would only be deletable by users with the 'delete_staff_client_lists' sub-permission. Thanks! Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 25 23:44:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Nov 2021 22:44:48 +0000 Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background using Koha::BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344 --- Comment #23 from Martin Renvoize --- I still think it's a good idea myself. One to pursue next cycle :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 01:58:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 00:58:27 +0000 Subject: [Koha-bugs] [Bug 29573] MARC Framework Subfields Visibility Setting Not Obeyed for 5XX In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29573 --- Comment #2 from Lye Jia Lun --- Hi! It appeared in the Normal View inside the Title Notes section. Previously in 20.11 we were able to hide that particular info by setting the Subfields Visibility. But in 21.05 it doesn't seem to be following the Visibility setting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 02:07:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 01:07:08 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #62 from Victor Grousset/tuxayo --- Indeed. Wait, I though I really needed this one for 20.05 but it's not even affected since it's about a feature that came in 20.11 So it turns out I don't care about this bug :P See ya! 🚪<= 🏃 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 03:30:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 02:30:45 +0000 Subject: [Koha-bugs] [Bug 19501] New list category to restrict specific lists to staff & hide from OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26346 CC| |alexbuckley at catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 03:30:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 02:30:46 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19501 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 08:33:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 07:33:25 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #13 from Marcel de Rooy --- Looking here. This serves to demonstrate that the field name 'userid' is kind of confusing. E.g. user_code would already be better.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 08:46:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 07:46:12 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #14 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #12) > What about a warn during the upgrade, for NULLs? > > Userid that was a valid borrowernumber will never be restored correctly, no > idea what we can do with that. > > However the more the wait, the more we introduce bad data, we should fix > ASAP. In most cases NULL will have been stored. So the db rev makes no sense. But the question is: Does it really hurt that the manager_id field is NULL for historic cancellations. Looks to me that it does not. So we could just go with the first patch? We could perhaps print the number of NULLs found in accountlines for this reason? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 08:47:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 07:47:01 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 08:59:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 07:59:21 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 08:59:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 07:59:25 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127596|0 |1 is obsolete| | Attachment #127739|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy --- Created attachment 128024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128024&action=edit Bug 29457: Pass context borrowernumber This patch updates the call to cancel such that we pass the currently logged in users borrowernumber instead of their userid. Signed-off-by: Joonas Kylmälä Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 08:59:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 07:59:28 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #16 from Marcel de Rooy --- Created attachment 128025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128025&action=edit Bug 29457: (QA follow-up) Warn number of missing manager_id's No sense in trying to match userid's with borrowernumbers. In 99% of the cases (at least) we will find just NULLs. We could print the number we found. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 09:00:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 08:00:20 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 09:03:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 08:03:47 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #17 from Jonathan Druart --- Joonas, Martin, do you agree with this follow-up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 09:22:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 08:22:14 +0000 Subject: [Koha-bugs] [Bug 21982] Circulation statistics wizard does not count deleted items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128013|BZ 34887: Statistic |BZ 21982: Circulation description|assistant - Circulation |statistics wizard does not | |count deleted items -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 09:26:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 08:26:41 +0000 Subject: [Koha-bugs] [Bug 21982] Circulation statistics wizard does not count deleted items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128013|BZ 21982: Circulation |Bug 21982: Circulation description|statistics wizard does not |statistics wizard does not |count deleted items |count deleted items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 09:36:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 08:36:43 +0000 Subject: [Koha-bugs] [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 --- Comment #8 from Mason James --- hi, can we get this pushed back to 20.05.x branch please :0) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 09:37:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 08:37:23 +0000 Subject: [Koha-bugs] [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 09:37:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 08:37:45 +0000 Subject: [Koha-bugs] [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 09:42:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 08:42:01 +0000 Subject: [Koha-bugs] [Bug 21982] Circulation statistics wizard does not count deleted items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128013|0 |1 is obsolete| | --- Comment #6 from Jérémy Breuillard --- Created attachment 128026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128026&action=edit Bug 21982: Circulation statistics wizard does not count deleted items By default statistic assistant filter is set on the existing items and doesn't mind about deleted items. The patch corrects this. Items belong to the same library. Test plan: 1)Make sure to have at least 1 or more item(s) in deleteditems database table 2)Home > Reports > Circulation statistics 3)Fill up 'Issuing library', 'Home library' and 'Holding library' 4)Submit 5)Notice that only statistics for active items are shown 6)Apply patch and repeat from 2) to 5) 7)Now active items and deleted items are shown -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 09:43:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 08:43:13 +0000 Subject: [Koha-bugs] [Bug 29529] Fix \n in hint on Koha to MARC mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29529 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 09:43:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 08:43:16 +0000 Subject: [Koha-bugs] [Bug 29529] Fix \n in hint on Koha to MARC mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29529 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128015|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 128027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128027&action=edit Bug 29529: Fix \n in hint on Koha to MARC mappings This patch breaks up a translatable string so that "\n" is excluded from what is translated. Unrelated: Capitalization is corrected on an instance of the phrase "Koha to MARC Mappings." To test, apply the patch and go to Administration -> Koha to MARC mapping. - The breadcrumb for the current page should have correct capitalization ("mapping" instead of "Mapping"). - Click the "Add" button for any Koha field. The dialog should display correctly: Adding a mapping for: biblio.abstract. Please enter field tag and subfield code, separated by a comma. (For control fields: add '@' as subfield code.) The change will be applied immediately. Test the way the po file is updated: > cd misc/translator > perl translate update en-GB (for example) - Open the updated po file, en-GB-staff-prog.po - You should find these lines: SCRIPT koha-tmpl/intranet-tmpl/prog/en/modules/admin/koha2marclinks.tt:86 msgid "The change will be applied immediately." msgstr "" Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 09:52:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 08:52:17 +0000 Subject: [Koha-bugs] [Bug 29556] MARC21slim2MODS.xsl broken by duplicate template name "part" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- Resolves: [2021/11/26 08:51:19] [WARN] XSLT::Base: compilation error: file /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS.xsl element template xsl:template: error duplicate name 'part' at /usr/share/koha/Koha/XSLT/Base.pm line 342. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 09:53:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 08:53:07 +0000 Subject: [Koha-bugs] [Bug 29556] MARC21slim2MODS.xsl broken by duplicate template name "part" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 09:53:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 08:53:11 +0000 Subject: [Koha-bugs] [Bug 29556] MARC21slim2MODS.xsl broken by duplicate template name "part" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128014|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 128028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128028&action=edit Bug 29556: MARC21slim2MODS.xsl broken by duplicate template name "part" This patch removes a redundant section from MARC21slim2MODS.xsl which was breaking the option to use unAPI in the OPAC using MODS format. To test, apply the patch and view a record in the OPAC using unAPI, e.g.: /cgi-bin/koha/unapi?id=koha:biblionumber:1&format=MODS You should see an XML file where previously there would have been an error. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 09:54:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 08:54:43 +0000 Subject: [Koha-bugs] [Bug 29556] MARC21slim2MODS.xsl broken by duplicate template name "part" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 10:04:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 09:04:51 +0000 Subject: [Koha-bugs] [Bug 29420] 401 Unauthorized pages come back as 200 OK under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #8 from Marcel de Rooy --- (In reply to David Cook from comment #6) > (In reply to Liz Rea from comment #4) > > It does not stop it from working, it shows the error page under the login > > screen for 401's. > > Hmm weird. I have no idea then without testing and digging in (which I don't > have time for at the moment). If there are any issues, I can find them later. This is an effective way of blocking development :) It must be wrong, but I do not have time to look further.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 10:24:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 09:24:58 +0000 Subject: [Koha-bugs] [Bug 29487] Set autocomplete off for userid/password fields at login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29487 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 10:25:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 09:25:02 +0000 Subject: [Koha-bugs] [Bug 29487] Set autocomplete off for userid/password fields at login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29487 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127872|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 128029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128029&action=edit Bug 29487: Set autocomplete off for userid/password fields at login This patch adjust: Intranet login Opac-main Opac-main - 'log in to your account modal' To test: Login at the three places above Confirm html shows autocomplete off on the fields Confirm logins work Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 10:25:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 09:25:11 +0000 Subject: [Koha-bugs] [Bug 29487] Set autocomplete off for userid/password fields at login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29487 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 10:37:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 09:37:45 +0000 Subject: [Koha-bugs] [Bug 29573] MARC Framework Subfields Visibility Setting Not Obeyed for 5XX In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29573 --- Comment #3 from Katrin Fischer --- Yes, please have a look at the NotesToHide system preference I suggested for hiding it within the tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 10:39:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 09:39:29 +0000 Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |michael.hafen at washk12.org |ity.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 10:44:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 09:44:44 +0000 Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #13 from Marcel de Rooy --- Advanced hacking? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 11:23:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 10:23:06 +0000 Subject: [Koha-bugs] [Bug 29556] MARC21slim2MODS.xsl broken by duplicate template name "part" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556 --- Comment #5 from Marcel de Rooy --- What about: git grep 'xsl:template name="part"' [11:13:29] koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MADS.xsl: koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3-1.xsl: koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3.xsl: koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS32.xsl: koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl: koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslim2intranetDetail.xsl: koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl: koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl: % grep slimUtils koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MADS.xsl koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3-1.xsl koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3.xsl koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS32.xsl koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslim2intranetDetail.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MADS.xsl: koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3-1.xsl: koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3.xsl: koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS32.xsl: koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslim2intranetDetail.xsl: koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 11:27:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 10:27:54 +0000 Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |BLOCKED --- Comment #14 from Marcel de Rooy --- Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 11:29:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 10:29:45 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128024|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 128030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128030&action=edit Bug 29457: Pass context borrowernumber This patch updates the call to cancel such that we pass the currently logged in users borrowernumber instead of their userid. Signed-off-by: Joonas Kylmälä Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 11:29:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 10:29:49 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128025|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 128031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128031&action=edit Bug 29457: (QA follow-up) Warn number of missing manager_id's No sense in trying to match userid's with borrowernumbers. In 99% of the cases (at least) we will find just NULLs. We could print the number we found. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 11:29:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 10:29:52 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #20 from Martin Renvoize --- Created attachment 128032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128032&action=edit Bug 29457: (follow-up) Add additional information to warnings Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 11:30:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 10:30:27 +0000 Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 --- Comment #15 from Marcel de Rooy --- Created attachment 128033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128033&action=edit Bug 29325: (QA follow-up) Remove unexisting parameters of BatchRevertRecords There is no interval and callback as in BatchCommitRecords. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 11:44:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 10:44:41 +0000 Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 --- Comment #16 from Marcel de Rooy --- git grep BatchCommitRecords C4/ImportBatch.pm: BatchCommitRecords C4/ImportBatch.pm:=head2 BatchCommitRecords C4/ImportBatch.pm: BatchCommitRecords($batch_id, $framework, C4/ImportBatch.pm:sub BatchCommitRecords { misc/commit_file.pl:use C4::ImportBatch qw( GetAllImportBatches GetImportBatch BatchCommitRecords BatchRevertRecords ); misc/commit_file.pl: BatchCommitRecords($import_batch_id, $framework, 100, \&print_progress_and_commit); misc/cronjobs/import_webservice_batch.pl:use C4::ImportBatch qw( BatchCommitRecords ); misc/cronjobs/import_webservice_batch.pl:BatchCommitRecords($_, $framework) foreach @$batch_ids; svc/import_bib:use C4::ImportBatch qw( GetWebserviceBatchId AddBiblioToBatch AddItemsToImportBiblio BatchFindDuplicates BatchCommitRecords ); svc/import_bib: BatchCommitRecords($batch_id, $framework) if lc($import_mode) eq 'direct'; tools/manage-marc-import.pl:use C4::ImportBatch qw( CleanBatch DeleteBatch GetImportBatch GetImportBatchOverlayAction GetImportBatchNoMatchAction GetImportBatchItemAction SetImportBatchOverlayAction SetImportBatchNoMatchAction SetImportBatchItemAction BatchFindDuplicates SetImportBatchMatcher GetItemNumbersFromImportBatch GetImportBatchRangeDesc GetNumberOfNonZ3950ImportBatches BatchCommitRecords BatchRevertRecords ); tools/manage-marc-import.pl: = BatchCommitRecords( $import_batch_id, $framework, 50, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 11:50:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 10:50:00 +0000 Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #17 from Marcel de Rooy --- We really should not add these txn begin etc statements in the ImportBatch module. Not only is it ugly, we probably break other scripts using this routine. Before resolving this issue, we should address the question: Do we really want to do commits along the way? And import a partial batch potentially? I think we should not. So that makes life simpler. Do a commit at the end in the misc_file script. Dont touch the module. When just commenting three lines, the script already works: diff --git a/misc/commit_file.pl b/misc/commit_file.pl index 543d7b06c7..e1ff4c4bd8 100755 --- a/misc/commit_file.pl +++ b/misc/commit_file.pl @@ -46,7 +46,7 @@ if ($list_batches) { C4::Context->set_userenv(0, 'batch', 0, 'batch', 'batch', 'batch', 'batch'); my $dbh = C4::Context->dbh; -$dbh->{AutoCommit} = 0; +#$dbh->{AutoCommit} = 0; if ($batch_number =~ /^\d+$/ and $batch_number > 0) { my $batch = GetImportBatch($batch_number); die "$0: import batch $batch_number does not exist in database\n" unless defined $batch; @@ -59,7 +59,7 @@ if ($batch_number =~ /^\d+$/ and $batch_number > 0) { unless $batch->{'import_status'} eq "staged" or $batch->{'import_status'} eq "reverted"; process_batch($batch_number); } - $dbh->commit(); +# $dbh->commit(); } else { die "$0: please specify a numeric batch ID\n"; } @@ -132,7 +132,7 @@ _SUMMARY_ sub print_progress_and_commit { my $recs = shift; print "... processed $recs records\n"; - $dbh->commit(); +# $dbh->commit(); } sub print_usage { But note that I now also commit when we fail halfway. The name of the progress callback should be adjusted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 11:54:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 10:54:21 +0000 Subject: [Koha-bugs] [Bug 29578] New: Search term highlighting breaks with titles containing characters with Greek diacritics Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 Bug ID: 29578 Summary: Search term highlighting breaks with titles containing characters with Greek diacritics Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: a.roussos at dataly.gr QA Contact: testopia at bugs.koha-community.org The commits from Bug 5844 and Bug 20501 fixed the problem of DOM content disappearing from the results of OPAC/Staff Client searches under certain conditions (e.g. when the search terms were "magaz mag" or "the the"). However, there is still a case where the jQuery term highlighter can break, and in the process actually make the "Highlight"/"Unhighlight" button disappear altogether! To reproduce, catalogue two books using the titles below, one of which includes a word ("τοῖς") [1] containing Greek diacritics: Title #1: Συλλογής των εν επιτομή τοῖς πάλαι γεωγραφηθέντων Title #2: Επιτομή της ιστορίας των Βαλκανικών Πολέμων (1912-1913) Then, perform a catalog search for "επιτομή των" (without the quotes). You should get what is depicted in the attached screenshots. Notice how 1) the "Highlight"/"Unhighlight" button has disappeared, and 2) not all search terms are highlighted (e.g. "των" in the 2nd result) If using Firefox, in the Browser Console the following error will be logged: Uncaught DOMException: Index or size is negative or greater than the allowed amount The offending file is koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.highlight-3.js, line 26: 26 var endbit = middlebit.splitText(pat.length); Upgrading the plugin from its current version (v3) to the latest version available [1] from the developer (v5) fixes the problem. Please note that the changes to this script from commit 2e4b574074 should also be incorporated. [1] https://en.wiktionary.org/wiki/%CF%84%CE%BF%E1%BF%96%CF%82 [2] https://johannburkard.de/blog/programming/javascript/highlight-javascript-text-higlighting-jquery-plugin.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 11:54:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 10:54:21 +0000 Subject: [Koha-bugs] [Bug 5844] Unhighlight cuts off some strings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5844 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29578 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 11:54:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 10:54:21 +0000 Subject: [Koha-bugs] [Bug 20501] Unhighlight in search results when the search terms contain the same word twice removes the word In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20501 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29578 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 11:54:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 10:54:50 +0000 Subject: [Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |a.roussos at dataly.gr Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 11:56:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 10:56:21 +0000 Subject: [Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 --- Comment #1 from Andreas Roussos --- Created attachment 128034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128034&action=edit search term highlighting broken in the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 11:56:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 10:56:34 +0000 Subject: [Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 --- Comment #2 from Andreas Roussos --- Created attachment 128035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128035&action=edit search term highlighting broken in the Staff Client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 12:02:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 11:02:58 +0000 Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 --- Comment #18 from Tomás Cohen Arazi --- The whole area clearly needs a big rewrite... I didn't intend to do it as part of the bugfix because this is hurting us in stable, and backportability is important in this case. With a big transaction, you will minimize the chances of table lock issues, but you will also need to work on refactoring the reporting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 12:07:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 11:07:43 +0000 Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 --- Comment #19 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #18) > With a big transaction, you will minimize the chances of table lock issues, > but you will also need to work on refactoring the reporting. What do you mean? Skip the commit, print a number? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 12:15:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 11:15:35 +0000 Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 --- Comment #41 from Jonathan Druart --- Created attachment 128036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128036&action=edit Bug 28959: Fix occurrence in tools/batch_delete_records.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 12:17:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 11:17:46 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #21 from Jonathan Druart --- - say $out "Prior to this patch a users 'userid' was being passed into the manager_id field where borrowernumber is expected"; + say $out "Prior to this patch a user's 'userid' was being passed into the manager_id field where borrowernumber is expected"; And at the end + say $out "Nothing to worry about" unless $count_bad || $count_empty -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 12:18:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 11:18:38 +0000 Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 --- Comment #42 from Jonathan Druart --- (In reply to Jonathan Druart from comment #41) > Created attachment 128036 [details] [review] > Bug 28959: Fix occurrence in tools/batch_delete_records.pl Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 12:24:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 11:24:18 +0000 Subject: [Koha-bugs] [Bug 29579] New: Show saved SQL report ID in database query Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579 Bug ID: 29579 Summary: Show saved SQL report ID in database query Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org When users run saved SQL reports, some of them might cause problems on the database end, for example taking too long or requiring too much resources. It would be useful if it was possible to see in the database server end which saved SQL report was the culprit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 12:27:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 11:27:07 +0000 Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at koha-suomi.fi |ity.org | Status|NEW |Needs Signoff --- Comment #1 from paxed --- Created attachment 128037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128037&action=edit Bug 29579: Show saved SQL report ID in database query Bug 29579: Show saved SQL report ID in database query When trying to figure out which saved SQL report caused too much load, it's useful to have the report id show in the mysql process list. This patch adds the saved SQL ID number as a comment line in front of the SQL before passing it to the database. To test: 1) Run a saved report that takes long enough time, so you can: 2) Connect to the database with your preferred client, and use "show processlist;" to list all the running mysql processes. 3) The running saved SQL report should show up with "-- saved_sql.id=123" in the process info field. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 12:27:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 11:27:23 +0000 Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|new feature |enhancement Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 12:55:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 11:55:28 +0000 Subject: [Koha-bugs] [Bug 26443] while installation internal server error occured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26443 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart+koha at gmail. | |com Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 12:58:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 11:58:45 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #22 from Marcel de Rooy --- I would push at least the fix only ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 13:03:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 12:03:48 +0000 Subject: [Koha-bugs] [Bug 28477] INTRANET and OPAC loggers should print to STDERR instead of to file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28477 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 13:06:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 12:06:17 +0000 Subject: [Koha-bugs] [Bug 28477] INTRANET and OPAC loggers should print to STDERR instead of to file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28477 --- Comment #6 from Andrew Nugged --- Sidenote: we also have pack-error.log without timestamps, which makes backtrace and debugging of important dies very hard on productions. Do we have anything on that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 14:16:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 13:16:40 +0000 Subject: [Koha-bugs] [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127999|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 128038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128038&action=edit Bug 29575: Add $patron_to_html to render patron information in JS This patch adds a re-usable javascript render function that accepts a Koha REST api Patron object and outputs the HTML representation. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 14:16:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 13:16:43 +0000 Subject: [Koha-bugs] [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 --- Comment #8 from Martin Renvoize --- Created attachment 128039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128039&action=edit Bug 29575: (QA follow-up) Add JSDoc documentation This patch adds some basic documentation for the $patron_to_html function the patchset introduces. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 14:16:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 13:16:47 +0000 Subject: [Koha-bugs] [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 --- Comment #9 from Martin Renvoize --- Created attachment 128040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128040&action=edit Bug 29575: (QA follow-up) Patron fields can be empty strings We need to account for empty strings as well as 'null' values in the patron data structure. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 14:17:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 13:17:20 +0000 Subject: [Koha-bugs] [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128000|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 14:17:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 13:17:34 +0000 Subject: [Koha-bugs] [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128006|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 14:18:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 13:18:14 +0000 Subject: [Koha-bugs] [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize --- I've tested this on a few of the dependant bugs, it's looking great and testing lead me to just these two minor QA follow-ups. Passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 14:21:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 13:21:34 +0000 Subject: [Koha-bugs] [Bug 28874] We need javascript equivalents to many of our TT plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28874 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24455 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455 [Bug 24455] Add ability to apply Koha formatting to dates from Javascript -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 14:21:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 13:21:34 +0000 Subject: [Koha-bugs] [Bug 24455] Add ability to apply Koha formatting to dates from Javascript In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28874 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28874 [Bug 28874] We need javascript equivalents to many of our TT plugins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 15:31:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 14:31:12 +0000 Subject: [Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 Florian changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126990|0 |1 is obsolete| | --- Comment #9 from Florian --- Created attachment 128041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128041&action=edit Bug 17127: Remove notes from detail.tt to only use MARCNOTES Notes come from the biblio table, but that table is already used to fill in MARCNOTES through Biblio.pm and get_marc_notes. Get_marc_notes does check for NotesToHide and already read every note on the records, but .notes doesn't go through that same filter. I don't see the point of keeping notes as a condition when MARCNOTES does the same job but better. To test: 1) Take any record, or create one 2) Input something in the 500 field (or 300 in UNIMARC) 3) In Systempreferences -> NotesToHide, fill in the number 500 (or 300). 4) Save, then go look at the record detail in the OPAC and admin website. 5) You should still see the 500 or 300 field under the Description tab. 6) Apply patch. 7) Reload the record detail page. 8) Observe the error is gone. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 15:32:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 14:32:18 +0000 Subject: [Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 Florian changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |florian.bontemps at biblibre.c | |om Status|Patch doesn't apply |Needs Signoff --- Comment #10 from Florian --- Thank you David, a pesky new line had lodged itself in the code since then :p I posted the rebased version. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 15:48:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 14:48:41 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127991|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 128042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128042&action=edit Bug 29523: Add Koha::Objects->search_limited stub method This method is just a passthru to the search method. It is defined here to avoid the need to check if each class implements it. Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 15:48:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 14:48:45 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127992|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 128043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128043&action=edit Bug 29523: Add Koha::Object->accessible This patch introduces a method for checking if an object can be retrieved by the current user. It depends on the plural class implementation of the ->search_limited method. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 15:48:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 14:48:49 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127993|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 128044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128044&action=edit Bug 29523: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 15:48:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 14:48:53 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127994|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 128045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128045&action=edit Bug 29523: Make Koha::Object->to_api respect accessibility This patch makes the *to_api* method honour the accessibility check for the object. This is relevant in the context of embedding single objects. The Koha::Patron->to_api method is adjusted to reflect this behavior as well (it does some manipulation after the ->to_api call and we need to prevent it). To test: 1. Apply up to the regression tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => FAIL: A patron, that shouldn't be accessed, is returned by ->to_api 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 6. Pick Henry Acevedo from the sample data, assign him 'catalogue' permissions and a know user/password combination 7. Enable basic authentication 8. Point your favourite tool (Postman?) to GET http://kohadev-intra.myDNSname.org:8081/api/v1/biblio/245/checkouts Set the following header: x-koha-embed: patron Pick whatever biblio you want, actually. => SUCCESS: No checkouts 9. Perform a couple checkouts on the chosen biblio. Make sure one checkout is for a patron on the same library as Henry, and the other on a different one. 10. Repeat 8 => SUCCESS: You see two checkouts. One of them has an attribute 'patron' containing the patron from Henry's library. The other, has the attribute set to 'null'. 11. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 15:48:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 14:48:57 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #15 from Martin Renvoize --- Created attachment 128046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128046&action=edit Bug 29523: (QA follow-up) Catch remaining SUPER::to_api cases Koha::Object->to_api can now return undefined.. we should be catching that cases in all post manipulation cases. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 15:49:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 14:49:01 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #16 from Martin Renvoize --- Created attachment 128047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128047&action=edit Bug 29523: (QA follow-up) Fix failing test in club holds With this patch series, all singular objects need to 'use' their plural counterparts.. otherwise the parent can't find search_related. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 15:53:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 14:53:59 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #17 from Martin Renvoize --- OK.. this works as-is, mostly, but I think we can continue to refine it. However, currently, there is one test failing and I couldn't grok how to fix it: `t/db_dependent/api/v1/patrons.t` In a future place, I'd be tempted to try and not rely on 'search_related' from the plural class from the singular. I'm wondering if we could instead just have a 'can_be_seen' or 'accessible' method at the object/singular level. The challenge will be how do we prevent db calls etc in that function when it's being called in the iterative loop to build a to_api resultset... we need a way of caching the 'why I cannot be seen' functionality at the set level.. hence I think I can see where Tomas was going trying to use search_related. Great work so far.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 16:41:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 15:41:46 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #18 from Martin Renvoize --- Created attachment 128048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128048&action=edit ALT: An idea of doing it at singular level? In this patch I add 'user', containing the Koha::Patron object for the logged in user in the params hash we pass around in to_api. I then use that in a new 'is_accessible_in_context' method added to Koha::Patron. The method name is a bit of a mouthfull.. it could be 'is_limited' as it's really the equivilent of 'search_limited' in the plural class.. but I wasn't sure that was actually clearer... if we like it we could strip back out some of the work around search_related. As an asside, I also update Koha::Patron->can_see_patrons_from to use Koha::Patron->libraries_where_can_see_patrons internally.. DRY! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 17:06:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 16:06:49 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #23 from Martin Renvoize --- Nice work David.. On with the review: 1. You appear to introduce a few new modules, but I'm not seeing some of them actually used. [List::MoreUtils qw(any), Koha::Plugins::Handler;] 2. With such an extensive tidy up.. I'd probably go ahead and run it through perltidy as a final patch.. (I did this on the before and after script to make comparing simpler) Otherwise, this is generally looking very reasonable to me. I'm going to run a few more test runs against it and ask our migrations team to have a play -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 17:21:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 16:21:01 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bernard.scaife at ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 17:21:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 16:21:15 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.bays at ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 17:23:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 16:23:09 +0000 Subject: [Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 17:23:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 16:23:12 +0000 Subject: [Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128041|0 |1 is obsolete| | --- Comment #11 from David Nind --- Created attachment 128049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128049&action=edit Bug 17127: Remove notes from detail.tt to only use MARCNOTES Notes come from the biblio table, but that table is already used to fill in MARCNOTES through Biblio.pm and get_marc_notes. Get_marc_notes does check for NotesToHide and already read every note on the records, but .notes doesn't go through that same filter. I don't see the point of keeping notes as a condition when MARCNOTES does the same job but better. To test: 1) Take any record, or create one 2) Input something in the 500 field (or 300 in UNIMARC) 3) In Systempreferences -> NotesToHide, fill in the number 500 (or 300). 4) Save, then go look at the record detail in the OPAC and admin website. 5) You should still see the 500 or 300 field under the Description tab. 6) Apply patch. 7) Reload the record detail page. 8) Observe the error is gone. Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 17:25:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 16:25:48 +0000 Subject: [Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 --- Comment #12 from David Nind --- (In reply to Florian from comment #10) > Thank you David, a pesky new line had lodged itself in the code since then :p > > I posted the rebased version. Thanks Florian! Things now work as expected and you can hide 500 fields. Note: I only tested the 500 fields in MARC21, and didn't test . -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 17:26:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 16:26:26 +0000 Subject: [Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 --- Comment #13 from David Nind --- ... UNIMARC. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 17:32:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 16:32:55 +0000 Subject: [Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes hiding notes release notes| |fields (5XX in MARC21 and | |3XX in UNIMARC) using | |NotesToHide. Before this | |you could hide one field | |and it worked. However, | |when hiding multiple fields | |one field would still | |always be visible. Now | |hiding notes fields works | |as expected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 17:34:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 16:34:20 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #19 from Martin Renvoize --- I think we also need a regression test for the to_api method.. I might be just overlooking it? I have a question.. if you embed a plural on a route.. like 'patrons'.. should the result be an array with 'null' gaps.. or an array that just contains valid patrons without gaps? This relates closely to my query regards should we return undefined vs should we return something that states the user is restricted from the consumer's view. The use of search_limited in .search and .find methods (and thus returning 404) makes me think for consistency we should not leave null gaps here.. but at the same time knowing something exists but is restricted from view is meaningful data.. so should .search and .find actually return 404 (or conversely 403/451 to show it exists but isn't allowed to be seen). I can see uses cases for all of the above.. so perhaps it needs a header to allow switching modes!>? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 17:35:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 16:35:32 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 18:13:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 17:13:33 +0000 Subject: [Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 --- Comment #14 from David Nind --- Now tested on a UNIMARC system, and everything works as expected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 20:08:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 19:08:06 +0000 Subject: [Koha-bugs] [Bug 27550] "Duplicate budget" does not keep users associated with that budget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samu.heiskanen at hypernova.fi Status|Needs Signoff |Signed Off --- Comment #4 from Samu Heiskanen --- The patch works as expected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 21:33:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 20:33:08 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 --- Comment #10 from Samu Heiskanen --- Created attachment 126905 [details] [review] Bug 9565: (follow-up) Deleting a biblio should alert/fail if there are existent subscriptions Clicking on "Delete record" while there are existent subscriptions no longer delete the record and the subscription. Instead an alert box inform the user that he must delete all subscription before deleting the record. To test: 1) Add a subscription to a biblio, or check a biblio which has one attached already. 2) Remove all items if there are any. 3) Apply patch. 4) Confirm that the 'Delete record' item is disabled in the list. 5) Attempt to 'Delete record', you should recieve an error message stating to delete all subscriptions before deleting record. 6) Sign off. Sponsored by: Lunds Universitetsbibliotek Signed-off-by: Samu heiskanen -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 21:37:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 20:37:10 +0000 Subject: [Koha-bugs] [Bug 27550] "Duplicate budget" does not keep users associated with that budget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 --- Comment #5 from Samu Heiskanen --- Created attachment 127975 [details] [review] Bug 27550: "Duplicate budget" does not keep users associated with that budget When a budget is duplicated, Owner is copied but not Users Test plan : Home > Administration > Budgets 1)Create a budget to allow (active or inactive) 2)Give it some funds by filling up the form, especially Owner and User(s) 3)Submit then go back to the Budgets dashboard 4)Duplicate the Budget and click on its name 5)Edit it and notice that User(s) is empty 6)Apply the patch 7)Repeat from 1) to 5) Signed-off-by: Samu Heiskanen -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 26 22:27:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 21:27:06 +0000 Subject: [Koha-bugs] [Bug 28698] News for all displays in all locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #6 from David Nind --- I'm only seeing the news item displayed in the normal news location in the OPAC. Do I need another language installed and enabled? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 27 00:22:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Nov 2021 23:22:33 +0000 Subject: [Koha-bugs] [Bug 28904] Update information on Newsletter editor on about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28904 --- Comment #23 from Victor Grousset/tuxayo --- It's up to your discretion, totally optional. I only added it because trivial and checking the result in about.pl is easy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 27 01:21:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Nov 2021 00:21:32 +0000 Subject: [Koha-bugs] [Bug 27550] "Duplicate budget" does not keep users associated with that budget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127975|0 |1 is obsolete| | --- Comment #6 from Samu Heiskanen --- Created attachment 128050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128050&action=edit Bug 27550: "Duplicate budget" does not keep users associated with that budget When a budget is duplicated, Owner is copied but not Users Test plan : Home > Administration > Budgets 1)Create a budget to allow (active or inactive) 2)Give it some funds by filling up the form, especially Owner and User(s) 3)Submit then go back to the Budgets dashboard 4)Duplicate the Budget and click on its name 5)Edit it and notice that User(s) is empty 6)Apply the patch 7)Repeat from 1) to 5) Signed-off-by: Samu Heiskanen -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 27 01:33:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Nov 2021 00:33:50 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126905|0 |1 is obsolete| | --- Comment #11 from Samu Heiskanen --- Created attachment 128051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128051&action=edit Bug 9565: (follow-up) Deleting a biblio should alert/fail if there are existent subscriptions Clicking on "Delete record" while there are existent subscriptions no longer delete the record and the subscription. Instead an alert box inform the user that he must delete all subscription before deleting the record. To test: 1) Add a subscription to a biblio, or check a biblio which has one attached already. 2) Remove all items if there are any. 3) Apply patch. 4) Confirm that the 'Delete record' item is disabled in the list. 5) Attempt to 'Delete record', you should recieve an error message stating to delete all subscriptions before deleting record. 6) Sign off. Sponsored by: Lunds Universitetsbibliotek Signed-off-by: Samu Heiskanen -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 27 02:38:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Nov 2021 01:38:53 +0000 Subject: [Koha-bugs] [Bug 29580] New: Missing end tag in circ/overdue.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29580 Bug ID: 29580 Summary: Missing end tag in circ/overdue.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In circ/overdue.tt there is a end tag inside a IF condition. I should be outside. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 27 02:39:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Nov 2021 01:39:03 +0000 Subject: [Koha-bugs] [Bug 29580] Missing end tag in circ/overdue.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29580 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |fridolin.somers at biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 27 02:39:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Nov 2021 01:39:09 +0000 Subject: [Koha-bugs] [Bug 29580] Missing end tag in circ/overdue.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29580 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 27 02:39:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Nov 2021 01:39:09 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29580 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29580 [Bug 29580] Missing end tag in circ/overdue.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 27 02:43:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Nov 2021 01:43:03 +0000 Subject: [Koha-bugs] [Bug 29580] Missing end tag in circ/overdue.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29580 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 27 02:42:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Nov 2021 01:42:41 +0000 Subject: [Koha-bugs] [Bug 29580] Missing end tag in circ/overdue.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29580 --- Comment #1 from Fridolin Somers --- Created attachment 128052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128052&action=edit Bug 29580: Fix missing end tag in circ/overdue.tt In circ/overdue.tt there is a end tag inside a IF condition. I should be outside. Test plan : Check HTML in overdue page with and without seeing patrons infos from other branches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 27 02:42:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Nov 2021 01:42:38 +0000 Subject: [Koha-bugs] [Bug 29580] Missing end tag in circ/overdue.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29580 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 27 07:54:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Nov 2021 06:54:10 +0000 Subject: [Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 27 07:54:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Nov 2021 06:54:12 +0000 Subject: [Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 --- Comment #3 from Andreas Roussos --- Created attachment 128053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128053&action=edit Bug 29578: Upgrade the jQuery highlighter plugin Under certain conditions, the jQuery term highlighter can break and in the process actually make the "Highlight"/"Unhighlight" button disappear altogether. This affects catalog searches in both the OPAC and the Staff Client. This patch fixes that by upgrading the plugin to its latest version. Test plan: 0) Catalogue two books using the titles below, one of which includes a word ("τοῖς") containing Greek diacritics: Book #1 title: Συλλογής των εν επιτομή τοῖς πάλαι γεωγραφηθέντων Book #2 title: Επιτομή της ιστορίας των Βαλκανικών Πολέμων (1912-1913) Then, perform a catalog search for "επιτομή των" (without the quotes). In the results page, notice that: a) the "Highlight"/"Unhighlight" button has disappeared, and b) not all search terms are highlighted (e.g. "των" in the 2nd book) 1) Apply this patch. 2) Repeat the same search (remember to press CTRL-F5 to refresh JS code). This time the "Highlight"/"Unhighlight" button is displayed normally, and all instances of your search terms are highlighted in the results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 27 14:56:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Nov 2021 13:56:09 +0000 Subject: [Koha-bugs] [Bug 29581] New: "Items expected" on receive shipment page is always empty Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29581 Bug ID: 29581 Summary: "Items expected" on receive shipment page is always empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The 'Items expected' column on the receive shipment page (parcels.pl) always shows 0, independent of the orders received already and if they have been fully received or partial. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 27 18:43:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Nov 2021 17:43:14 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : Data sharing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com --- Comment #462 from Andrew Nugged --- Comment on attachment 84325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84325 Bug 17047: SQL reports management with Mana-KB Hidden gem in https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84325&action=diff&headers=0#a/reports/guided_reports.pl_sec3 ➟ 185 'mana_success' => $input->param('mana_success'), 186 'mana_success' => scalar $input->param('mana_success'), "Double Mana" feature, but of course that's the hash so first one useless + more: it generates warning: /koha/intranet/cgi-bin/reports/guided_reports.pl line 188 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 27 23:26:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Nov 2021 22:26:49 +0000 Subject: [Koha-bugs] [Bug 29524] Cannot set a new value for privacy_guarantor_checkouts in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05,20.11.12 |21.11.00,21.05.05,20.11.12, released in| |20.05.18 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #8 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 00:14:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Nov 2021 23:14:07 +0000 Subject: [Koha-bugs] [Bug 29582] New: Browse search results block not visible in OPAC when using Google Chrome Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29582 Bug ID: 29582 Summary: Browse search results block not visible in OPAC when using Google Chrome Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org Created attachment 128054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128054&action=edit Browse results block in OPAC not visible in Google Chrome When using Google Chrome and clicking through from the search results page, the browse search results block on the details page for a record is not visible. It does display correctly in Firefox. Screenshot attached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 00:14:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Nov 2021 23:14:49 +0000 Subject: [Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- Created attachment 128055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128055&action=edit Bug 29578 - Screenshots from testing 2021-11028 I attempted to test this (using koha-testing-docker on master) but I didn't get the same results. My observations: 1. Before the patch is applied: in the OPAC and staff interface I am not seeing the Unhighlight and Highlight button disappearing as reported. These appear fine for me (using Firefox and Google Chrome on Ubuntu 18.04). The highlighting on the search results page also looks okay to me - see the screenshots in the attachment (note: I just changed the titles for existing records). 2. OPAC details page (clicking through from the search results page): . Before the patch is applied I do see the issue with words not being highlighted on the detail page. . After the patch is applied this fixes this, and for "normal" searches highlighting continues to work as expected. 3. Staff interface details page (clicking through from the search results page): both before and after the patch is applied search words are not highlighted on the details page for a record (not sure if this is the expected behavour or not - "normal" words are not highlighted either). Not related to this bug, but in the OPAC I do not see the browse results block (Browse results, Previous, Back to results, Next) on the right hand side on the detail page when using Google Chrome - it displays fine using Firefox. See the attachment. I have logged bug 29582 for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 00:23:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Nov 2021 23:23:14 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #29 from Victor Grousset/tuxayo --- Good idea thanks! :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 00:50:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Nov 2021 23:50:24 +0000 Subject: [Koha-bugs] [Bug 29580] Missing end tag in circ/overdue.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29580 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 00:50:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Nov 2021 23:50:29 +0000 Subject: [Koha-bugs] [Bug 29580] Missing end tag in circ/overdue.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29580 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128052|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 128056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128056&action=edit Bug 29580: Fix missing end tag in circ/overdue.tt In circ/overdue.tt there is a end tag inside a IF condition. I should be outside. Test plan : Check HTML in overdue page with and without seeing patrons infos from other branches Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 00:52:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Nov 2021 23:52:43 +0000 Subject: [Koha-bugs] [Bug 29580] Missing end tag in circ/overdue.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29580 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Tested by reviewing the HTML in the overdue.tt file and the patch - I couldn't figure out how to hide the patron information in the patron column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 06:36:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Nov 2021 05:36:11 +0000 Subject: [Koha-bugs] [Bug 29581] "Items expected" on receive shipment page is always empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29581 giuseppe.angilella at ct.infn.it changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |giuseppe.angilella at ct.infn. | |it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 07:12:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Nov 2021 06:12:05 +0000 Subject: [Koha-bugs] [Bug 29583] New: error as its is asking for 7395 character length. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29583 Bug ID: 29583 Summary: error as its is asking for 7395 character length. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: mdigesh555 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 128057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128057&action=edit error as its is asking for 7395 character length In Koha platform patron creation password is showing error as its is asking for 7395 character length. Please check below the screen shot. Kindly, please resolve the issue as soon as possible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 07:47:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Nov 2021 06:47:04 +0000 Subject: [Koha-bugs] [Bug 29583] error as its is asking for 7395 character length. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29583 --- Comment #1 from digeswar --- problem solved -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 12:28:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Nov 2021 11:28:21 +0000 Subject: [Koha-bugs] [Bug 29584] New: autoBarcode generates a fifteen-digit number in the unit catalog instead of EAN13 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29584 Bug ID: 29584 Summary: autoBarcode generates a fifteen-digit number in the unit catalog instead of EAN13 Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: resetka.bedi at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl I have Koha 21.05.05.003. I have autoBarcode in Administration set to Barcodes are incremental EAN-13 barcodes. Previously, this generated a EAN13 number correctly for my units. Now I get a number like, for example: 977233613400114 - There are extra zeros I guess. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 17:28:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Nov 2021 16:28:09 +0000 Subject: [Koha-bugs] [Bug 29585] New: "Go to field" in cataloguing alerts is not translatable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 Bug ID: 29585 Summary: "Go to field" in cataloguing alerts is not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Depends on: 28450 koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt var subfield=tagsubfieldid.substr(3,1); StrAlert += "
  • "+_("Tag %s subfield %s %s in tab %s").format(tag, subfield, formatFieldName( tabflag[tagsubfieldid][1] ), tabflag[tagsubfieldid][2]) + ' Go to field
    • '; Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28450 [Bug 28450] Make Account summary print tables configurable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 17:28:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Nov 2021 16:28:09 +0000 Subject: [Koha-bugs] [Bug 28450] Make Account summary print tables configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28450 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29585 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 [Bug 29585] "Go to field" in cataloguing alerts is not translatable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 17:28:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Nov 2021 16:28:15 +0000 Subject: [Koha-bugs] [Bug 29585] "Go to field" in cataloguing alerts is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 17:29:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Nov 2021 16:29:40 +0000 Subject: [Koha-bugs] [Bug 29585] "Go to field" in cataloguing alerts is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|28450 |28694 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28450 [Bug 28450] Make Account summary print tables configurable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694 [Bug 28694] Check alert in cataloguing should be a static message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 17:29:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Nov 2021 16:29:40 +0000 Subject: [Koha-bugs] [Bug 28450] Make Account summary print tables configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28450 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29585 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 [Bug 29585] "Go to field" in cataloguing alerts is not translatable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 17:29:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Nov 2021 16:29:40 +0000 Subject: [Koha-bugs] [Bug 28694] Check alert in cataloguing should be a static message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29585 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 [Bug 29585] "Go to field" in cataloguing alerts is not translatable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 17:58:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Nov 2021 16:58:14 +0000 Subject: [Koha-bugs] [Bug 29586] New: "Hold reminder" notice doesn't show in messaging preferences in new installation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586 Bug ID: 29586 Summary: "Hold reminder" notice doesn't show in messaging preferences in new installation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org I am not sure why, but after a reset_all with current master (past 21.11 release), the 'Hold reminder' notice doesn't show in the messaging preferences table and is not in the message_attributes table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 18:04:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Nov 2021 17:04:38 +0000 Subject: [Koha-bugs] [Bug 29586] "Hold reminder" notice doesn't show in messaging preferences in new installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28153 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28153 [Bug 28153] Add 'Hold reminder' messaging preference -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 18:04:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Nov 2021 17:04:38 +0000 Subject: [Koha-bugs] [Bug 28153] Add 'Hold reminder' messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28153 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29586 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586 [Bug 29586] "Hold reminder" notice doesn't show in messaging preferences in new installation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 18:30:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Nov 2021 17:30:08 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david at davidnind.com --- Comment #6 from David Nind --- Patch no longer applies 8-(... Applying: Bug 26296: Use new table column selection modal for OPAC suggestion fields error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref). error: could not build fake ancestor Patch failed at 0001 Bug 26296: Use new table column selection modal for OPAC suggestion fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 19:20:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Nov 2021 18:20:52 +0000 Subject: [Koha-bugs] [Bug 26257] Move translatable strings out of subscription-add.tt and into subscription-add.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26257 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 19:20:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Nov 2021 18:20:56 +0000 Subject: [Koha-bugs] [Bug 26257] Move translatable strings out of subscription-add.tt and into subscription-add.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26257 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126675|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 128058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128058&action=edit Bug 26257: Move translatable strings out of subscription-add.tt and into subscription-add.js This patch removes the definition of translatable strings out of templates and into the corresponding JavaScript file, using the new JS i81n function. To test: - Apply the patch and go to Serials -> New subscription - Click "Next" without filling out any fields. You should get two confirmations, "If you wish to claim late or missing issues you must link this subscription to a vendor. Click OK to ignore or Cancel to return and enter a vendor" and "You must choose or create a bibliographic record." - Manually enter a vendor number which doesn't exist and click "Next." Error: "The vendor does not exist." - Manually enter a record number which doesn't exist and click "Next." Error: "Bibliographic record does not exist!" - Select a valid vendor and bibliographic record and proceed to the next page. - Click "Test prediction pattern" without filling in any fields. Error: "Cannot test prediction pattern for the following reason(s): Frequency is not defined. - First publication date is not defined" - Click "Save subscription" without filling in any information. Error: "You must choose a first publication date." - Fill in a date and click "Save subscription." Error: "You must choose a subscription length or an end date." - Enter a frequency and subscription start date and click "Save subscription." Error: "Please click on 'Test prediction pattern' before saving subscription." - Click "Show advanced pattern" and then "Save subscription." Error: "You have modified the advanced prediction pattern. Please save your work or cancel modifications." Testing numbering patterns: - There are several strings related to setting and editing numbering patterns but I don't think they can be tested live while Bug 28012 is unfixed. Testing Mana integration: - To test Mana integration you must have Mana enabled, and a bibliographic record in your catalog which has an ISSN matching a record in Mana. You can go to "Search on Mana" from the Serials sidebar menu to locate a working record. - Add a subscription using the bibliographic record which will match a record in Mana. When you click "Next" you should see a message at the top of the page saying, "Searching for subscription in Mana Knowledge Base" - After a moment this message should be replaced with "Subscription found on Mana Knowledge Base: Show Mana results" - Clicking the "Show Mana results" should trigger a modal window with the heading "Results from Mana Knowledge Base." - Test the subscription add process using a bibliographic record which doesn't match anything in Mana. The message at the top of the page should read, "No subscription found on Mana Knowledge Base" TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/subscription-add.js for translation, e.g.: msgid "Next issue publication date is not defined" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 19:21:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Nov 2021 18:21:34 +0000 Subject: [Koha-bugs] [Bug 26257] Move translatable strings out of subscription-add.tt and into subscription-add.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26257 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- (In reply to Owen Leonard from comment #2) > Sorry this test plan is so long! I tried to describe how to trigger as many > of the translatable strings as possible. I like long test plans! 8-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 19:31:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Nov 2021 18:31:38 +0000 Subject: [Koha-bugs] [Bug 26257] Move translatable strings out of subscription-add.tt and into subscription-add.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26257 --- Comment #5 from David Nind --- Created attachment 128059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128059&action=edit Bug 26257 - Screenshot - Formatting of test prediction pattern error message A couple of minor formatting suggestions for the messages. Full stops at the end of these sentences - some have, some don't - I am not sure of the correct rule for these: - The vendor does not exist - You must choose a first publication date Formatting of test prediction pattern error message (see screenshot from Firefox): - No carriage return before the first reason - No space between the - and the first letter for the second error ==> should ideally appear as: Cannot test prediction pattern for the following reason(s): - Frequency is not defined. - First publication date is not defined. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 19:39:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Nov 2021 18:39:44 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 19:39:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Nov 2021 18:39:48 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128010|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 128060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128060&action=edit Bug 29571: Display all pending suggestions even if none from logged in library The number of pending suggestions was only displayed if there are pending suggestions at the logged in library. Test plan: Login at CPL Create a suggestion (ASKED) for another library => Without this patch there is nothing on the mainpage => With this patch applied you will see info about pending suggestions: "Suggestions pending approval: Centerville: 0 / All libraries: 1" Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 19:48:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Nov 2021 18:48:26 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the display of release notes| |pending suggestions in the | |staff interface so that it | |now shows pending | |suggestions for all | |libraries, for example: | |"Suggestions pending | |approval: Centerville: 0 / | |All libraries: 1.". | |Previously suggestions | |pending approval was only | |shown if there were | |suggestions for the user's | |current library. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 19:51:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Nov 2021 18:51:05 +0000 Subject: [Koha-bugs] [Bug 26257] Move translatable strings out of subscription-add.tt and into subscription-add.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26257 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement moves the release notes| |definition of translatable | |strings for serial | |subscriptions | |(subscription-add.tt) out | |of templates and into the | |corresponding JavaScript | |file, using the new JS i81n | |function. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 19:57:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Nov 2021 18:57:58 +0000 Subject: [Koha-bugs] [Bug 29587] New: Test mail option in SMTP servers Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29587 Bug ID: 29587 Summary: Test mail option in SMTP servers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: vimalibre at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Dear Developers, Here is a feature suggestion to Administration > SMTP servers. Test mail option helpful for users to try newly added SMTP server works or not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 28 23:41:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Nov 2021 22:41:02 +0000 Subject: [Koha-bugs] [Bug 29588] New: Yesterday and tomorrow in datepicker don't translate Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588 Bug ID: 29588 Summary: Yesterday and tomorrow in datepicker don't translate Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Depends on: 29478 Tomorrow, Yesterday and or in the new Flatpickr datepicker don't translate. Today does, I am not sure why. I think it should be either only one underscore in an .inc file or it's something else. I tried updating the po files locally, but the strings didn't show up. ++ b/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc @@ -34,6 +34,7 @@ [% Asset.js("js/calendar.js") | $raw %] [% Asset.js("lib/flatpickr/flatpickr.min.js") | $raw %] +[% Asset.js("lib/flatpickr/shortcut-buttons-flatpickr.min.js") | $raw %]