[Koha-bugs] [Bug 29365] Koha::Email needs to be refactored

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29365

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Here are a few of my findings when working on bug 28729, 29330.

[1] We should move away from Email::Stuffer imo. We are wrapping a wrapper
around a wrapper around Email::MIME. Just go there and use Koha::Email as your
wrapper. Stuffer is too simple. We are already calling $message->email often
enough to illustrate that point.

[2] Bug 28729 fixed an issue with Sender/Returnpath. We c/should solve this
already in Koha::Email->create.

[3] Currently we call Stuffer::send_or_die and not send. We are only fixing
stuff in the former one. We should do the same for send or let it explode.

[4] We are never passing from and to parameters to send_or_die only transport.
Should we support them, or keep it in create only? Move the bcc handling to
create?

[5] Attachments do not work. See bug 29330. We should refactor the code in
Letters for that. Move it to Koha::Email? How do we save them in the database
while they are pending?

[6] When doing these things, we can probably rearrange so that create can call
Email::MIME at the end, and the result does not need further tweaking?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.