[Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am sorry, but I am having a bit of trouble with this one:

prove t/db_dependent/Illrequests.t
t/db_dependent/Illrequests.t .. 3/13 
    #   Failed test 'new node + core_status_graph = bigger status graph'
    #   at t/db_dependent/Illrequests.t line 272.
    # Compared array length of $data->{"GENREQ"}{"next_actions"}
    #    got : array with 3 element(s)
    # expect : array with 2 element(s)
    # {
    #   'CANCREQ' => {
    #     'id' => 'CANCREQ',
    #     'method' => 0,
    #     'name' => 'Cancellation requested',
    #     'next_actions' => [
    #       'KILL',
    #       'REQ'
    #     ],
    #     'prev_actions' => [
    #       'NEW'
    #     ],
    #     'ui_method_icon' => 0,
    #     'ui_method_name' => 0
    #   },
    #   'CHK' => {
    #     'id' => 'CHK',
    #     'method' => 'check_out',
    #     'name' => 'Checked out',
    #     'needs_all' => [
    #       sub { "DUMMY" }
    #     ],
    #     'needs_perms' => [
    #       'user_circulate_circulate_remaining_permissions'
    #     ],
    #     'needs_prefs' => [
    #       'CirculateILL'
    #     ],
    #     'next_actions' => [],
    #     'prev_actions' => [
    #       'REQ',
    #       'GENREQ',
    #       'COMP'
    #     ],
    #     'ui_method_icon' => 'fa-upload',
    #     'ui_method_name' => 'Check out'
    #   },
    #   'COMP' => {
    #     'id' => 'COMP',
    #     'method' => 'mark_completed',
    #     'name' => 'Completed',
    #     'next_actions' => [
    #       'CHK'
    #     ],
    #     'prev_actions' => [
    #       'REQ'
    #     ],
    #     'ui_method_icon' => 'fa-check',
    #     'ui_method_name' => 'Mark completed'
    #   },
    #   'GENREQ' => {
    #     'id' => 'GENREQ',
    #     'method' => 'generic_confirm',
    #     'name' => 'Requested from partners',
    #     'next_actions' => [
    #       'COMP',
    #       'CHK',
    #       'GENREQ'
    #     ],
    #     'prev_actions' => [
    #       'NEW',
    #       'REQREV',
    #       'GENREQ'
    #     ],
    #     'ui_method_icon' => 'fa-send-o',
    #     'ui_method_name' => 'Place request with partners'
    #   },
    #   'KILL' => {
    #     'id' => 'KILL',
    #     'method' => 'delete',
    #     'name' => 0,
    #     'next_actions' => [],
    #     'prev_actions' => [
    #       'QUEUED',
    #       'REQREV',
    #       'NEW',
    #       'CANCREQ'
    #     ],
    #     'ui_method_icon' => 'fa-trash',
    #     'ui_method_name' => 'Delete request'
    #   },
    #   'NEW' => {
    #     'id' => 'NEW',
    #     'method' => 'create',
    #     'name' => 'New request',
    #     'next_actions' => [
    #       'REQ',
    #       'GENREQ',
    #       'KILL'
    #     ],
    #     'prev_actions' => [],
    #     'ui_method_icon' => 'fa-plus',
    #     'ui_method_name' => 'New request'
    #   },
    #   'QUEUED' => {
    #     'id' => 'QUEUED',
    #     'method' => 0,
    #     'name' => 'Queued request',
    #     'next_actions' => [
    #       'REQ',
    #       'KILL'
    #     ],
    #     'prev_actions' => [],
    #     'ui_method_icon' => 0,
    #     'ui_method_name' => 0
    #   },
    #   'REQ' => {
    #     'id' => 'REQ',
    #     'method' => 'confirm',
    #     'name' => 'Requested',
    #     'next_actions' => [
    #       'REQREV',
    #       'COMP',
    #       'CHK'
    #     ],
    #     'prev_actions' => [
    #       'NEW',
    #       'REQREV',
    #       'QUEUED',
    #       'CANCREQ'
    #     ],
    #     'ui_method_icon' => 'fa-check',
    #     'ui_method_name' => 'Confirm request'
    #   },
    #   'REQREV' => {
    #     'id' => 'REQREV',
    #     'method' => 'cancel',
    #     'name' => 'Request reverted',
    #     'next_actions' => [
    #       'REQ',
    #       'GENREQ',
    #       'KILL'
    #     ],
    #     'prev_actions' => [
    #       'REQ'
    #     ],
    #     'ui_method_icon' => 'fa-times',
    #     'ui_method_name' => 'Revert Request'
    #   },
    #   'RET' => {
    #     'id' => 'RET',
    #     'method' => 'check_in',
    #     'name' => 'Returned to library',
    #     'next_actions' => [
    #       'COMP'
    #     ],
    #     'prev_actions' => [
    #       'CHK'
    #     ],
    #     'ui_method_icon' => 'fa-download',
    #     'ui_method_name' => 'Check in'
    #   },
    #   'TEST' => {
    #     'id' => 'TEST',
    #     'next_actions' => [],
    #     'prev_actions' => []
    #   }
    # }
    # Looks like you failed 1 test of 5.
t/db_dependent/Illrequests.t .. 5/13 
#   Failed test 'Status Graph tests'
#   at t/db_dependent/Illrequests.t line 380.
t/db_dependent/Illrequests.t .. 11/13     # Looks like you planned 3 tests but
ran 5.

#   Failed test 'Custom statuses'
#   at t/db_dependent/Illrequests.t line 1343.
t/db_dependent/Illrequests.t .. 13/13 # Looks like you failed 2 tests of 13.
t/db_dependent/Illrequests.t .. Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/13 subtests 

Test Summary Report
-------------------
t/db_dependent/Illrequests.t (Wstat: 512 Tests: 13 Failed: 2)
  Failed tests:  5, 12
  Non-zero exit status: 2


There are also some minor QA fails (tab characters and missing TT filters). I
would have fixed those, but holding off now as the tests might need a little
work anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.