[Koha-bugs] [Bug 29010] Weight input pattern wrong

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Nov 1 23:29:09 CET 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29010

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18316

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I was checking how we handle other decimal fields and for accounting we have:

<input type="text" inputmode="decimal" pattern="^\d+(\.\d{2})?$" name="amount"
id="amount" required="required" min="0" value="" class="noEnterSubmit">

The patch has:

<input type="text" inputmode="numeric" pattern="[0-9\.]*"
name="search_field_weight" value="[% search_field.weight | html %]" />

>From documentation I think if we want to support decimals we should change the
inputmode from numeric to decimal and maybe make the pattern a bit more
specific.

For example see:
https://developer.mozilla.org/de/docs/Web/HTML/Global_attributes/inputmode

What do you think?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316
[Bug 18316] Add weighting/relevancy options to ElasticSearch
-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list