[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #10)
> (In reply to Marcel de Rooy from comment #9)
> > Will give it a try now
> 
> Yes, it looks like David was right. This might not be a minimal fix. The
> add_attachments stuff in C4::Letters does not seem to work well with
> Email::Stuffer. Imo we should go back to Email::MIME in Koha::Email.
> 
> More comments on bug 29365

Koha::Email used to be just a wrapper for a hashref used to build something
suitable for passing to Mail::Sendmail. We didn't use Email::MIME. Multi-part
emails with attachments were built by concatenating manually crafted strings...

That said, there's room for improvement. Using Email::MIME is hard, and error
prone. That's why the author (of both libraries, and Email::Simple,
Email::Sender, etc) suggests using Email::Stuffer.

I don't think it is urgent to replace Email::Stuffer because its API has design
issues. In fact, if required we can add MIME content manually.

I hadn't payed attention to this bugs and will now. If the problem is how
emails are serialized on the db, maybe we can use Koha::Email->to_string
(inherited from Email::Stuffer). But as I said, I've just discovered this bugs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.