[Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
1. This one seems wrong:
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:                    
   link = `request.pl?biblionumbers=[% biblionumbers | url
%]&action=cancelBulk&ids=${$('.holds_table
.select_hold:checked').toArray().map(el => $(el).data('id')).join(',')}`;

I don't have the time to confirm now but could do later.

2. This one is wrong:
koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc:       
            [% SET data_url =
"/cgi-bin/koha/reserve/request.pl?borrowernumber=" _ borrower.borrowernumber _
"&multi_hold=1&biblionumbers=" _ biblionumbers %]

to recreate: search, select at least 2 records, place holds, search for patron
(which will give you several results), select one
=> url is
/reserve/request.pl?borrowernumber=19&multi_hold=1&biblionumbers=ARRAY(0x55def41723e8)

3. The occurrences of biblionumers in virtualshelves/addbybiblionumber.tt seem
wrong but not related (?)

-- 
You are receiving this mail because:
You are watching all bug changes.